[webkit-changes] [WebKit/WebKit] 839963: [WPE] Bump Cog version

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83996366152ea06807fa581c52c12d5342850af2
  
https://github.com/WebKit/WebKit/commit/83996366152ea06807fa581c52c12d5342850af2
  Author: Philippe Normand 
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
M Tools/PlatformWPE.cmake

  Log Message:
  ---
  [WPE] Bump Cog version
https://bugs.webkit.org/show_bug.cgi?id=277632

Reviewed by Michael Catanzaro.

Update to latest ToT of Cog master branch:
https://github.com/Igalia/cog/commit/9ac900a835ee4905ad3dc3d8dc377494bd8e4c34

* Tools/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/281828@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad489a: [Buildstream SDK] Update GStreamer recipes to 1.24...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad489a8d15ad5647d6de1e8a959cbd05cf7737ec
  
https://github.com/WebKit/WebKit/commit/ad489a8d15ad5647d6de1e8a959cbd05cf7737ec
  Author: Philippe Normand 
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
M Tools/buildstream/elements/freedesktop-sdk.bst
M Tools/buildstream/elements/sdk/gst-plugin-audiofx.bst
M Tools/buildstream/elements/sdk/gst-plugin-closedcaption.bst
M Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst
M Tools/buildstream/elements/sdk/gst-plugin-livesync.bst
M Tools/buildstream/elements/sdk/gst-plugin-rtp.bst
R Tools/buildstream/files/gst-plugin-audiofx/Cargo.lock
M Tools/buildstream/files/gst-plugin-closedcaption/Cargo.lock
M Tools/buildstream/files/gst-plugin-dav1d/Cargo.lock
R Tools/buildstream/files/gst-plugin-dav1d/dav1d-Cargo.toml
R Tools/buildstream/files/gst-plugin-livesync/Cargo.lock
M Tools/buildstream/files/gst-plugin-rtp/Cargo.lock
R Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.4.patch
A Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.6.patch
A 
Tools/buildstream/patches/fdo-0010-gst-plugins-bad-webrtcbin-create-and-associate-trans.patch
A 
Tools/buildstream/patches/fdo-0011-gst-plugins-bad-webrtcbin-connect-transportreceivebi.patch

  Log Message:
  ---
  [Buildstream SDK] Update GStreamer recipes to 1.24.6 and gst-plugins-rs 0.13
https://bugs.webkit.org/show_bug.cgi?id=277488

Reviewed by Adrian Perez de Castro.

This update includes:
- gst-plugins-rs version bumps to 0.13.0
- gstreamer bump to 1.24.6
- gstreamer webrtc backports of:
  * https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7156
  * https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7294

* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/elements/sdk/gst-plugin-audiofx.bst:
* Tools/buildstream/elements/sdk/gst-plugin-closedcaption.bst:
* Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst:
* Tools/buildstream/elements/sdk/gst-plugin-livesync.bst:
* Tools/buildstream/elements/sdk/gst-plugin-rtp.bst:
* Tools/buildstream/files/gst-plugin-audiofx/Cargo.lock: Removed.
* Tools/buildstream/files/gst-plugin-closedcaption/Cargo.lock:
* Tools/buildstream/files/gst-plugin-dav1d/Cargo.lock:
* Tools/buildstream/files/gst-plugin-dav1d/dav1d-Cargo.toml: Removed.
* Tools/buildstream/files/gst-plugin-livesync/Cargo.lock: Removed.
* Tools/buildstream/files/gst-plugin-rtp/Cargo.lock:
* Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.6.patch: Renamed 
from Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.4.patch.
* 
Tools/buildstream/patches/fdo-0010-gst-plugins-bad-webrtcbin-create-and-associate-trans.patch:
 Added.
* 
Tools/buildstream/patches/fdo-0011-gst-plugins-bad-webrtcbin-connect-transportreceivebi.patch:
 Added.

Canonical link: https://commits.webkit.org/281825@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c683dc: Cherry-pick 276412@main (da50e63df7f3). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: c683dc77add674d8b77a776cc6b0d0a6c61f2c18
  
https://github.com/WebKit/WebKit/commit/c683dc77add674d8b77a776cc6b0d0a6c61f2c18
  Author: Philippe Normand 
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  ---
  Cherry-pick 276412@main (da50e63df7f3). 
https://bugs.webkit.org/show_bug.cgi?id=271243

[GStreamer][WebRTC] webrtc/connection-state.html started failing after 
update to 1.24.0
https://bugs.webkit.org/show_bug.cgi?id=271243


Reviewed by Xabier Rodriguez-Calvar.

The `doneGatheringCandidates()` method is called by the 
PeerConnectionBackend when it's notified
from gst-webrtc that the ICE gathering is finished, so we don't need to 
call it ourselves. The
end-of-candidates SDP attribute shouldn't appear in the offer/answer the 
end-point reports either.
This is covered by the webrtc/libwebrtc/descriptionGetters.html test.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::fetchDescription):
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
(WebCore::GStreamerMediaEndpoint::onIceCandidate):

Canonical link: https://commits.webkit.org/276412@main

Canonical link: https://commits.webkit.org/274313.306@webkitglib/2.44


  Commit: f4c108b7b1b841bf883f05af505dccc176bcf564
  
https://github.com/WebKit/WebKit/commit/f4c108b7b1b841bf883f05af505dccc176bcf564
  Author: Ahmad Saleem 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h

  Log Message:
  ---
  Cherry-pick 279039@main (868f20242ed9). 
https://bugs.webkit.org/show_bug.cgi?id=274025

`m_maxMessageSize` should be `infinity()` instead of `max()` in 
`RTCSctpTransport.h`

https://bugs.webkit.org/show_bug.cgi?id=274025
rdar://problem/128306030

Reviewed by Youenn Fablet.

This patch aligns WebKit with web specification [1]:

[1] https://w3c.github.io/webrtc-pc/#dfn-update-the-data-max-message-size

"If both remoteMaxMessageSize and canSendSize are 0, set
[[MaxMessageSize]] to the positive Infinity value."

* Source/WebCore/Modules/mediastream/RTCSctpTransport.h:
(double m_maxMessageSize):
* 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt:
 Rebaselined

Canonical link: https://commits.webkit.org/279039@main

Canonical link: https://commits.webkit.org/274313.307@webkitglib/2.44


  Commit: 4954333c2945eca30e9dc0d8acb0651100c95003
  
https://github.com/WebKit/WebKit/commit/4954333c2945eca30e9dc0d8acb0651100c95003
  Author: Enrique Ocaña González 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

  Log Message:
  ---
  Cherry-pick 277541@main (40cfa6a61706). 
https://bugs.webkit.org/show_bug.cgi?id=272167

[GStreamer] Ignore sinks position while seeking
https://bugs.webkit.org/show_bug.cgi?id=272167

Reviewed by Alicia Boya Garcia.

After removing MSE data, sinks get flushed and are not able to return
valid playback time. Some implementation return invalid time, 0.00 or
even some random value. This value may be then reported up to
HTMLMediaElement and that may be confusing to web applications.

This commit doesn't trust sinks position when pipeline is not prerolled,
as behavor is different across devices. The last cached position is used
instead.

To reflect better what's actually happening, isPipelineSeeking() has been
renamed as isPipelineWaitingPreroll() and the condition now also includes
pending states higher than paused.

Original author: Andrzej Surdej (https://github.com/asurdej-comcast)

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1302

* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isPipelineWaitingPreroll const): 
Renamed from isPipelineSeeking().
(WebCore::MediaPlayerPrivateGStreamer::play): isPipelineSeeking() now named 
as isPipelineWaitingPreroll().
(WebCore::MediaPlayerPrivateGStreamer::paused const): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const): Use 
GST_CLOCK_TIME_NONE when the pipeline isn't prerolled. This will force 

[webkit-changes] [WebKit/WebKit] 6ca202: [GStreamer] Implement gstStructureGetString()

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ca202068171d6cced2d5a381eba85074fdabbdb
  
https://github.com/WebKit/WebKit/commit/6ca202068171d6cced2d5a381eba85074fdabbdb
  Author: Philippe Normand 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp
M Tools/Scripts/webkitpy/style/checkers/cpp.py
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Implement gstStructureGetString()
https://bugs.webkit.org/show_bug.cgi?id=277000

Reviewed by Xabier Rodriguez-Calvar.

Usage of gst_structure_get_string() is no longer recommended. Use this new 
helper instead.
This patch includes drive-by changes, reducing usage of raw pointers and 
avoiding memory allocations
when possible (using StringView instead of GUniquePtr in the 
GStreamerRtpTransceiverBackend).

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::requestPad):
* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::toRtpCodecCapability):
(WebCore::getMsidFromCurrentCodecPreferences):
(WebCore::GStreamerRtpTransceiverBackend::setCodecPreferences):
(): Deleted.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::RTCStatsReport::Stats::Stats):
(WebCore::RTCStatsReport::RtpStreamStats::RtpStreamStats):
(WebCore::RTCStatsReport::CodecStats::CodecStats):
(WebCore::RTCStatsReport::RemoteInboundRtpStreamStats::RemoteInboundRtpStreamStats):
(WebCore::RTCStatsReport::RemoteOutboundRtpStreamStats::RemoteOutboundRtpStreamStats):
(WebCore::RTCStatsReport::OutboundRtpStreamStats::OutboundRtpStreamStats):
(WebCore::RTCStatsReport::TransportStats::TransportStats):
(WebCore::iceCandidateType):
(WebCore::RTCStatsReport::IceCandidateStats::IceCandidateStats):
(WebCore::RTCStatsReport::IceCandidatePairStats::IceCandidatePairStats):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
(WebCore::toRTCEncodingParameters):
(WebCore::toRTCRtpSendParameters):
(WebCore::payloadTypeForEncodingName):
(WebCore::capsFromRtpCapabilities):
(WebCore::capsFromSDPMedia):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureGet):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
* 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(transformCaps):
(transformInPlace):
* Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
(WebCore::GStreamerMediaDescription::extractCodecName const):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:
(WebCore::GStreamerCaptureDeviceManager::addDevice):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::configure):
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::reconfigure):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):
* Tools/Scripts/webkitpy/style/checkers/cpp.py

[webkit-changes] [WebKit/WebKit] 7abc50: [GStreamer][WebRTC] Simplified pipeline for incomi...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7abc5055a3246204779b7426dfdd5800bb9a9d6d
  
https://github.com/WebKit/WebKit/commit/7abc5055a3246204779b7426dfdd5800bb9a9d6d
  Author: Philippe Normand 
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCCommon.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h

  Log Message:
  ---
  [GStreamer][WebRTC] Simplified pipeline for incoming tracks
https://bugs.webkit.org/show_bug.cgi?id=276989

Reviewed by Xabier Rodriguez-Calvar.

The incoming track processor now feeds a single sink, no tee or dynamic 
pipeline manipulations
involved anymore. This brings back a timeout in webrtc/h265.html, but it will 
be fixed once we have
track events dispatching fixed (bug #275685).

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::setConfiguration):
(WebCore::GStreamerMediaEndpoint::connectIncomingTrack):
(WebCore::GStreamerMediaEndpoint::connectPad):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::configure):
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
(WebCore::GStreamerIncomingTrackProcessor::createParser):
(WebCore::GStreamerIncomingTrackProcessor::stats):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCCommon.h:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::RealtimeIncomingSourceGStreamer):
(WebCore::RealtimeIncomingSourceGStreamer::setBin):
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):
(WebCore::RealtimeIncomingSourceGStreamer::unregisterClient):
(WebCore::RealtimeIncomingSourceGStreamer::unregisterClientLocked):
(WebCore::RealtimeIncomingSourceGStreamer::forEachClient):
(WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamEvent):
(WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamQuery):
(WebCore::RealtimeIncomingSourceGStreamer::handleDownstreamEvent):
(WebCore::RealtimeIncomingSourceGStreamer::setUpstreamBin): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::startProducingData): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::stopProducingData): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::configureAppSink): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::configureFakeVideoSink): Deleted.
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:
(WebCore::RealtimeIncomingSourceGStreamer::bin const):
(WebCore::RealtimeIncomingSourceGStreamer::bin): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::setIsUpstreamDecoding): Deleted.
(WebCore::RealtimeIncomingSourceGStreamer::dispatchSample): Deleted.
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:
(WebCore::RealtimeIncomingVideoSourceGStreamer::setBin):
(WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample):
(WebCore::RealtimeIncomingVideoSourceGStreamer::setUpstreamBin): Deleted.
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h:

Canonical link: https://commits.webkit.org/281394@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c8074e: [GStreamer][WebRTC] Apply platform-specific quirks...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8074e2e862a990d4cc5cdd2c4cdec834c321f62
  
https://github.com/WebKit/WebKit/commit/c8074e2e862a990d4cc5cdd2c4cdec834c321f62
  Author: Philippe Normand 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Apply platform-specific quirks for incoming tracks
https://bugs.webkit.org/show_bug.cgi?id=276769

Reviewed by Xabier Rodriguez-Calvar.

On platforms where quirks are required, keep hardware-accelerated parsers out 
of the WebRTC
pipeline. They are instead used from the playback pipeline. The LibWebRTC 
backend had support for
this already, this patch brings the same feature to the GstWebRTC backend.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstGetAutoplugSelectResult):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::createParser):
* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerWebRTCVideoDecoder::getGstAutoplugSelectResult): Deleted.

Canonical link: https://commits.webkit.org/281292@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bfb2a5: [GStreamer][WebRTC] Minor improvements in incoming...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bfb2a5b5e0fe4a4549723470555c7888459ae872
  
https://github.com/WebKit/WebKit/commit/bfb2a5b5e0fe4a4549723470555c7888459ae872
  Author: Philippe Normand 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Minor improvements in incoming track processor
https://bugs.webkit.org/show_bug.cgi?id=276988

Reviewed by Xabier Rodriguez-Calvar.

The msid information can be present in the pad caps, so when that's the case 
inspecting the SDP is
not required. Also we now send the force-key-unit event only for video tracks.

* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::configure):
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):

Canonical link: https://commits.webkit.org/281286@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 602c91: [GStreamer][WPE] Remove support for the WPEBackend...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 602c91212cdb11bff348ea5e28892e1dbe31ad7b
  
https://github.com/WebKit/WebKit/commit/602c91212cdb11bff348ea5e28892e1dbe31ad7b
  Author: Philippe Normand 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Source/WebCore/PlatformWPE.cmake
M Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp
M Source/cmake/GStreamerChecks.cmake

  Log Message:
  ---
  [GStreamer][WPE] Remove support for the WPEBackend-FDO audio protocol
https://bugs.webkit.org/show_bug.cgi?id=276878

Reviewed by Xabier Rodriguez-Calvar.

This protocol was meant for GstWPE's audio support but in the end a different 
solution was used.

* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp:
(webKitAudioSinkConfigure):
(webKitAudioSinkSetProperty):
(webKitAudioSinkGetProperty):
(webKitAudioSinkChangeState):
(webkit_audio_sink_class_init):
(AudioPacketHolder::AudioPacketHolder): Deleted.
(AudioPacketHolder::~AudioPacketHolder): Deleted.
(AudioPacketHolder::map): Deleted.
(webKitAudioSinkHandleSample): Deleted.
(getInternalVolumeObject): Deleted.
* Source/cmake/GStreamerChecks.cmake:

Canonical link: https://commits.webkit.org/281281@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d4946: [GStreamer] Add gstStructureGet helper funct...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d494648332fbd981645653e77709213ff89532e
  
https://github.com/WebKit/WebKit/commit/6d494648332fbd981645653e77709213ff89532e
  Author: Philippe Normand 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
M Tools/Scripts/webkitpy/style/checkers/cpp.py
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Add gstStructureGet helper function and complete migration 
to gstStructureGet helpers
https://bugs.webkit.org/show_bug.cgi?id=276772

Reviewed by Xabier Rodriguez-Calvar.

This new helper makes boolean fields access from GstStructures a bit more 
idiomatic. The migration
to gstStructureGet helpers is now complete and the coding style checker is 
now able to detect
cases where the helper functions would be recommended.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureGet):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::updateVideoSinkStatistics):
* 
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(transformInPlace):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderConstructed):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:
(WebCore::sortDevices):
(WebCore::GStreamerCaptureDeviceManager::addDevice):
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_language):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/281187@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eefbdb: [GStreamer][WebRTC] Use appsink for incoming (deco...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eefbdb0cba411800ff5ef66dde3ff4ea7e8778e4
  
https://github.com/WebKit/WebKit/commit/eefbdb0cba411800ff5ef66dde3ff4ea7e8778e4
  Author: Philippe Normand 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Use appsink for incoming (decoding) video sources
https://bugs.webkit.org/show_bug.cgi?id=276768

Reviewed by Xabier Rodriguez-Calvar.

With GStreamer 1.24 there's a new signal in appsink that allows the application 
to handle the
allocation query, so fakevideosink shouldn't be needed. The fallback is kept 
for older GStreamer
versions.

* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::configureAppSink):
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):

Canonical link: https://commits.webkit.org/281184@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a41146: [GStreamer][Debug] ASSERTs in RegistryScanner when...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4114606a8641eb68c46be42cdb1399f5631a369
  
https://github.com/WebKit/WebKit/commit/a4114606a8641eb68c46be42cdb1399f5631a369
  Author: Philippe Normand 
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h

  Log Message:
  ---
  [GStreamer][Debug] ASSERTs in RegistryScanner when re-initialized from 
WebAudio webworker
https://bugs.webkit.org/show_bug.cgi?id=276721

Reviewed by Xabier Rodriguez-Calvar.

AtomString cannot be used in the GStreamer RegistryScanner because it can be 
initialized from one
thread and refreshed from another. Use String instead, and ASCIILiteral where 
possible.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::refresh):
(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
(WebCore::GStreamerRegistryScanner::initializeEncoders):
(WebCore::GStreamerRegistryScanner::isCodecSupported const):
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const):
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:

Canonical link: https://commits.webkit.org/281085@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 431ee8: [GStreamer][WebRTC] heap-buffer-overflow in EndPoint

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 431ee891573634865d8c5db0a0df90436ea130bb
  
https://github.com/WebKit/WebKit/commit/431ee891573634865d8c5db0a0df90436ea130bb
  Author: Philippe Normand 
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] heap-buffer-overflow in EndPoint
https://bugs.webkit.org/show_bug.cgi?id=276711

Reviewed by Xabier Rodriguez-Calvar.

gst_sdp_message_new_from_text() expects an input string, not a uint8_t pointer. 
Also the SDP can in
theory contain non-latin1 characters, so load it as UTF8 (this is covered by the
webrtc/utf8-sdp.html test).

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::setDescription):
(WebCore::GStreamerMediaEndpoint::isIceGatheringComplete):

Canonical link: https://commits.webkit.org/281084@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 89a209: [EME] MediaKeySystemController and client leaks

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89a20910a56be13d2b83e33e800eea6f5ce3c283
  
https://github.com/WebKit/WebKit/commit/89a20910a56be13d2b83e33e800eea6f5ce3c283
  Author: Philippe Normand 
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemController.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemController.h
M Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.h

  Log Message:
  ---
  [EME] MediaKeySystemController and client leaks
https://bugs.webkit.org/show_bug.cgi?id=276660

Reviewed by Andy Estes.

The client is now destroyed once the page has been destroyed. Driving-by, use 
WeakRef in the client
to keep track of the page and make the controller non-copyable.

* Source/WebCore/Modules/encryptedmedia/MediaKeySystemController.cpp:
(WebCore::MediaKeySystemController::MediaKeySystemController):
(WebCore::provideMediaKeySystemTo):
* Source/WebCore/Modules/encryptedmedia/MediaKeySystemController.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.cpp:
(WebKit::WebMediaKeySystemClient::pageDestroyed):
(WebKit::WebMediaKeySystemClient::requestMediaKeySystem):
(WebKit::WebMediaKeySystemClient::cancelMediaKeySystemRequest):
* Source/WebKit/WebProcess/WebCoreSupport/WebMediaKeySystemClient.h:
(WebKit::WebMediaKeySystemClient::~WebMediaKeySystemClient): Deleted.

Canonical link: https://commits.webkit.org/281048@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff8510: [WPE][GTK] First round of memory leak fixes, repor...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff8510d36cc79a4cfc2c9f8bb9dcc55a302ad716
  
https://github.com/WebKit/WebKit/commit/ff8510d36cc79a4cfc2c9f8bb9dcc55a302ad716
  Author: Philippe Normand 
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
M Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp
M Source/WebCore/platform/audio/glib/MediaSessionGLib.h
M 
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebProcessExtensionManager.cpp
M Tools/MiniBrowser/gtk/BrowserWindow.c

  Log Message:
  ---
  [WPE][GTK] First round of memory leak fixes, reported by LeakSanitizer
https://bugs.webkit.org/show_bug.cgi?id=276655

Reviewed by Xabier Rodriguez-Calvar and Michael Catanzaro.

Fix a few GVariant leaks in WebKit/WebCore and one GSList leak in MiniBrowser.

* Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp:
(WebCore::MediaSessionGLib::updateNowPlaying):
(WebCore::MediaSessionGLib::emitPropertiesChanged):
(WebCore::MediaSessionGLib::playbackStatusChanged):
* Source/WebCore/platform/audio/glib/MediaSessionGLib.h:
* 
Source/WebKit/WebProcess/InjectedBundle/API/glib/WebProcessExtensionManager.cpp:
(WebKit::parseUserData):
* Tools/MiniBrowser/gtk/BrowserWindow.c:
(browserWindowTryClose):

Canonical link: https://commits.webkit.org/281047@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ed8de7: [GTK][WPE] Fix ASan clang build

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed8de7bc88561ffca7290537179ea80c76431fcc
  
https://github.com/WebKit/WebKit/commit/ed8de7bc88561ffca7290537179ea80c76431fcc
  Author: Philippe Normand 
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
M Source/WTF/wtf/Vector.h

  Log Message:
  ---
  [GTK][WPE] Fix ASan clang build
https://bugs.webkit.org/show_bug.cgi?id=276592

Reviewed by Michael Catanzaro.

The invalid-offsetof warning in Vector.h should be ignored for GCC and clang on 
linux, not only for
GCC.

* Source/WTF/wtf/Vector.h:
(WTF::VectorBuffer::endOfBuffer):

Canonical link: https://commits.webkit.org/280978@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9878e3: [GTK] Unconditionally enable network access from t...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9878e30a6f7350aca54e860251f34971e6aed1f6
  
https://github.com/WebKit/WebKit/commit/9878e30a6f7350aca54e860251f34971e6aed1f6
  Author: Philippe Normand 
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
M Tools/flatpak/flatpakutils.py

  Log Message:
  ---
  [GTK] Unconditionally enable network access from the flatpak build sandbox
https://bugs.webkit.org/show_bug.cgi?id=276588

Reviewed by Alicia Boya Garcia.

The clangd-related tools added in bug #274909 require network access for the 
installation of the
jinja Python package. Until now the WPE build sandbox had unconditional network 
access already, but
the GTK build sandbox didn't. That was conditioned by the IceCC and/or SCCache 
options.

* Tools/flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):

Canonical link: https://commits.webkit.org/280966@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7eea04: [GStreamer] Reduce usage of const char* in VideoFr...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7eea0493a7279f9a03309c5f867ee8e947ca9cdd
  
https://github.com/WebKit/WebKit/commit/7eea0493a7279f9a03309c5f867ee8e947ca9cdd
  Author: Philippe Normand 
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Reduce usage of const char* in VideoFrameGStreamer
https://bugs.webkit.org/show_bug.cgi?id=276567

Reviewed by Xabier Rodriguez-Calvar.

Use ASCIILiteral and span() where appropriate.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::convertSampleToImage):
(WebCore::VideoFrameGStreamer::createFromPixelBuffer):
(WebCore::VideoFrameGStreamer::convert):

Canonical link: https://commits.webkit.org/280962@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b2de3a: [GStreamer] Improve logging in RegistryScanner

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2de3ad0411d807a4851b80e39e5e4809d7b6215
  
https://github.com/WebKit/WebKit/commit/b2de3ad0411d807a4851b80e39e5e4809d7b6215
  Author: Philippe Normand 
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

  Log Message:
  ---
  [GStreamer] Improve logging in RegistryScanner
https://bugs.webkit.org/show_bug.cgi?id=276477

Reviewed by Xabier Rodriguez-Calvar.

Log the selected GstElementFactory for the given format, which will help 
debugging.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForCaps const):

Canonical link: https://commits.webkit.org/280961@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 736ccf: [GStreamer] Make use of ASCIILiteral in video encoder

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 736ccfb3ad4fdb495da711148024318289bacc92
  
https://github.com/WebKit/WebKit/commit/736ccfb3ad4fdb495da711148024318289bacc92
  Author: Philippe Normand 
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Make use of ASCIILiteral in video encoder
https://bugs.webkit.org/show_bug.cgi?id=276532

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(Encoders::registerEncoder):
(videoEncoderSetEncoder):
(videoEncoderFindForFormat):
(setBitrateKbitPerSec):
(setBitrateBitPerSec):
(webkit_video_encoder_class_init):

Canonical link: https://commits.webkit.org/280960@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 999fdd: [GStreamer][WebRTC] webrtc/video-av1.html is flaky

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 999fdd1fc6c65d3c328cb802f8ff268ea59fb2ca
  
https://github.com/WebKit/WebKit/commit/999fdd1fc6c65d3c328cb802f8ff268ea59fb2ca
  Author: Philippe Normand 
  Date:   2024-07-14 (Sun, 14 Jul 2024)

  Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [GStreamer][WebRTC] webrtc/video-av1.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=276587

Unreviewed, update webrtc/video-av1.html test expectations for the GTK/WPE 
ports.

* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/280950@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20f074: [GStreamer][WebRTC] Gardening

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20f0743786e31888bfc94412f2bc69513ef7e374
  
https://github.com/WebKit/WebKit/commit/20f0743786e31888bfc94412f2bc69513ef7e374
  Author: Philippe Normand 
  Date:   2024-07-13 (Sat, 13 Jul 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations

  Log Message:
  ---
  [GStreamer][WebRTC] Gardening
https://bugs.webkit.org/show_bug.cgi?id=276566

Unreviewed, gardening.

webrtc/video-av1.html is passing locally, unskip it and we will monitor the 
results on the bots.
Also move a couple webrtc-extensions test expectations to the "Need 
investigation" block.

* LayoutTests/platform/glib/TestExpectations:

Canonical link: https://commits.webkit.org/280940@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ef8296: [GStreamer] Move some DMABuf-related code from the...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef8296de8bc58c4434fb79656f78a76cea852ca3
  
https://github.com/WebKit/WebKit/commit/ef8296de8bc58c4434fb79656f78a76cea852ca3
  Author: Philippe Normand 
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
M Source/WebCore/platform/SourcesGStreamer.txt
A Source/WebCore/platform/graphics/gstreamer/DMABufUtilities.cpp
A Source/WebCore/platform/graphics/gstreamer/DMABufUtilities.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/network/DataURLDecoder.cpp

  Log Message:
  ---
  [GStreamer] Move some DMABuf-related code from the player to a new 
DMABufUtilities file
https://bugs.webkit.org/show_bug.cgi?id=276481

Reviewed by Xabier Rodriguez-Calvar.

Refactoring aiming to reduce a bit the size of 
MediaPlayerPrivateGStreamer::pushDMABufToCompositor()
and improve readability.

* Source/WebCore/platform/SourcesGStreamer.txt:
* Source/WebCore/platform/graphics/gstreamer/DMABufUtilities.cpp: Added.
(WebCore::DMABufDestination::DMABufDestination):
(WebCore::DMABufDestination::~DMABufDestination):
(WebCore::DMABufDestination::copyPlaneData):
(WebCore::fillSwapChainBuffer):
* Source/WebCore/platform/graphics/gstreamer/DMABufUtilities.h: Added.
(WebCore::dmaBufFourccValue):
(WebCore::dmaBufColorSpaceForColorimetry):
(WebCore::DMABufDestination::mappingLock):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
(WebCore::fourccValue): Deleted.
(WebCore::colorSpaceForColorimetry): Deleted.

Canonical link: https://commits.webkit.org/280906@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aed572: [GStreamer][WebRTC] Incoming video track handling ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aed57210e6b345f50f0292484ad08e1d88c7415c
  
https://github.com/WebKit/WebKit/commit/aed57210e6b345f50f0292484ad08e1d88c7415c
  Author: Philippe Normand 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h

  Log Message:
  ---
  [GStreamer][WebRTC] Incoming video track handling improvements
https://bugs.webkit.org/show_bug.cgi?id=276419

Reviewed by Xabier Rodriguez-Calvar.

The h265.html test now consistently fails, due to bug #269285. Before this 
patch it was consistently
timing out, due to a caps negotiation issue triggered when the MediaStreamTrack 
was disabled. The
framerate not being set on the black video frames triggered variable framerate 
code paths, messing
up downstream elements.

After fixing the framerate issue, another bug surfaced, the buffers coming from 
the RealtimeIncoming
source had no video meta information, leading to glupload failing to handle 
frames and raising
errors. By using fakevideosink instead of appsink in the WebRTC pipeline for 
incoming video tracks
that are decoded the tee element will perform no allocation query shenanigans 
and the decoder will
correctly attach video metas to buffers.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::configureAppSink):
(WebCore::RealtimeIncomingSourceGStreamer::configureFakeVideoSink):
(WebCore::RealtimeIncomingSourceGStreamer::handleDownstreamEvent):
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:

Canonical link: https://commits.webkit.org/280855@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a4113: [GStreamer] Paused pipelines accumulate when scrol...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a41131cab31450174e2b86e985cdbcfd0c60a19
  
https://github.com/WebKit/WebKit/commit/5a41131cab31450174e2b86e985cdbcfd0c60a19
  Author: Philippe Normand 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Paused pipelines accumulate when scrolling on Reddit pages with 
many videos
https://bugs.webkit.org/show_bug.cgi?id=276296

Reviewed by Xabier Rodriguez-Calvar.

Dispose the GStreamer pipeline if the destination 
TextureMapperPlatformLayerProxy becomes inactive,
meaning that either the compositor is gone or the target layer no longer exists.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::tearDown):
(WebCore::MediaPlayerPrivateGStreamer::isPipelineWaitingPreroll const):
(WebCore::MediaPlayerPrivateGStreamer::buffered const):
(WebCore::MediaPlayerPrivateGStreamer::pausedTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
(WebCore::MediaPlayerPrivateGStreamer::setVisibleInViewport):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/280808@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e166d: [GStreamer] Caps updates fixes for VideoFrame impl...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e166d523ba140df8193012a9b4583bad59946a0
  
https://github.com/WebKit/WebKit/commit/8e166d523ba140df8193012a9b4583bad59946a0
  Author: Philippe Normand 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Caps updates fixes for VideoFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=276359

Reviewed by Xabier Rodriguez-Calvar.

Copy the caps before updating them and also make sure the sample is writable 
before changing its
caps.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrameGStreamer::setFrameRate):
(WebCore::VideoFrameGStreamer::setMaxFrameRate):

Canonical link: https://commits.webkit.org/280807@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c9aa4: [LibWebRTC] WPE/GTK build fails

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c9aa4d98e54a5aa051420c0de84334d0e89cc29
  
https://github.com/WebKit/WebKit/commit/0c9aa4d98e54a5aa051420c0de84334d0e89cc29
  Author: Philippe Normand 
  Date:   2024-07-08 (Mon, 08 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp

  Log Message:
  ---
  [LibWebRTC] WPE/GTK build fails
https://bugs.webkit.org/show_bug.cgi?id=276308

Unreviewed, fix LibWebRTC build for the WPE/GTK ports.

* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

Canonical link: https://commits.webkit.org/280724@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bba4f8: [GStreamer] Fix typo in X265 encoder options

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bba4f82149e3872da296e534f359c13da39ae1d7
  
https://github.com/WebKit/WebKit/commit/bba4f82149e3872da296e534f359c13da39ae1d7
  Author: Philippe Normand 
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Fix typo in X265 encoder options
https://bugs.webkit.org/show_bug.cgi?id=276249

Reviewed by Xabier Rodriguez-Calvar.

The vbv bufsize option was missing a dash in case variable bitrate mode 
configuration. Driving by,
removed un-needed StringBuilder usage.

* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(webkit_video_encoder_class_init):

Canonical link: https://commits.webkit.org/280685@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 758f24: [GStreamer] Fix uint structure field serialization...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 758f24c80d6a9ff9cdee8a85ba2771dab3659095
  
https://github.com/WebKit/WebKit/commit/758f24c80d6a9ff9cdee8a85ba2771dab3659095
  Author: Philippe Normand 
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Fix uint structure field serialization to JSON
https://bugs.webkit.org/show_bug.cgi?id=276247

Reviewed by Xabier Rodriguez-Calvar.

Converting an uint to int can lead to integer overflow, so use double instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureValueToJSON):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/280682@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f309ba: [GStreamer][WebRTC] Support for RTP2 payloaders

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f309ba2ca43119c4e558a80f5883fdc19307c8b1
  
https://github.com/WebKit/WebKit/commit/f309ba2ca43119c4e558a80f5883fdc19307c8b1
  Author: Philippe Normand 
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Support for RTP2 payloaders
https://bugs.webkit.org/show_bug.cgi?id=276115

Reviewed by Xabier Rodriguez-Calvar.

By relying on the registry scanner for payloader selection, the one with higher 
rank will be used,
so by setting GST_PLUGIN_FEATURE_RANK=rtpopuspay2:max (or similar), the 
selection can be influenced.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isRtpPacketizerSupported):
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):

Canonical link: https://commits.webkit.org/280619@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a465d: [WPE][GTK] Source links in generated API documenta...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a465d3ecf859c297677d5e5b5663e99ca6ec54a
  
https://github.com/WebKit/WebKit/commit/6a465d3ecf859c297677d5e5b5663e99ca6ec54a
  Author: Philippe Normand 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M Source/WebKit/gtk/gtk3-webkitgtk.toml.in
M Source/WebKit/gtk/gtk4-webkitgtk.toml.in
M Source/WebKit/gtk/webkitgtk-web-process-extension.toml.in
M Source/WebKit/wpe/wpe-web-process-extension.toml.in
M Source/WebKit/wpe/wpewebkit.toml.in

  Log Message:
  ---
  [WPE][GTK] Source links in generated API documentation are incorrect
https://bugs.webkit.org/show_bug.cgi?id=276119

Reviewed by Michael Catanzaro.

gi-docgen strips the last URL path component not ending with a slash, 
apparently. So the source
links were missing the "main" part.

* Source/WebKit/gtk/gtk3-webkitgtk.toml.in:
* Source/WebKit/gtk/gtk4-webkitgtk.toml.in:
* Source/WebKit/gtk/webkitgtk-web-process-extension.toml.in:
* Source/WebKit/wpe/wpe-web-process-extension.toml.in:
* Source/WebKit/wpe/wpewebkit.toml.in:

Canonical link: https://commits.webkit.org/280572@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 502351: [GStreamer][WebRTC] Log stats type as lower case i...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50235160a52251955de6db4050b96a047638bccd
  
https://github.com/WebKit/WebKit/commit/50235160a52251955de6db4050b96a047638bccd
  Author: Philippe Normand 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Log stats type as lower case in JSON
https://bugs.webkit.org/show_bug.cgi?id=276070

Reviewed by Xabier Rodriguez-Calvar.

Using lower case values brings us a bit closer to the LibWebRTC JSON stats 
format and will simplify
cross-backend stats processing.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::webrtcStatsTypeName):
(WebCore::gstStructureValueToJSON):

Canonical link: https://commits.webkit.org/280570@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] be6447: [GStreamer] Use gstStructureGet helper in more places

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be64472d6f0a6e2415907fabe53ba7aa4fec261c
  
https://github.com/WebKit/WebKit/commit/be64472d6f0a6e2415907fabe53ba7aa4fec261c
  Author: Philippe Normand 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp

  Log Message:
  ---
  [GStreamer] Use gstStructureGet helper in more places
https://bugs.webkit.org/show_bug.cgi?id=276063

Reviewed by Xabier Rodriguez-Calvar.

Use the new helper instead of gst_structure_get_ functions when possible.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::pickAvailablePayloadType):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::getVideoResolutionFromCaps):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::createOptionalParserForFormat):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderSetEncoder):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::stats):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::reconfigure):

Canonical link: https://commits.webkit.org/280533@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59b02e: [GStreamer] Use ASCIILiteral in registry scanner

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59b02eee1fcfe02ef18314b534ad1c54866518a0
  
https://github.com/WebKit/WebKit/commit/59b02eee1fcfe02ef18314b534ad1c54866518a0
  Author: Philippe Normand 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h

  Log Message:
  ---
  [GStreamer] Use ASCIILiteral in registry scanner
https://bugs.webkit.org/show_bug.cgi?id=276061

Reviewed by Xabier Rodriguez-Calvar.

Replace const char* usage in hasElementForMediaType with an ASCIILiteral.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType 
const):
(WebCore::GStreamerRegistryScanner::initializeDecoders):
(WebCore::GStreamerRegistryScanner::initializeEncoders):
(WebCore::GStreamerRegistryScanner::fillAudioRtpCapabilities):
(WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities):
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:

Canonical link: https://commits.webkit.org/280532@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87ee5e: [GStreamer] Support for serializing uint64_t value...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87ee5e0693a006bda3b05bfc7f47fdaaafd4dd99
  
https://github.com/WebKit/WebKit/commit/87ee5e0693a006bda3b05bfc7f47fdaaafd4dd99
  Author: Philippe Normand 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Support for serializing uint64_t values to JSON
https://bugs.webkit.org/show_bug.cgi?id=276068

Reviewed by Xabier Rodriguez-Calvar.

BigInt is not officially supported in JSON, so the workaround is to serialize 
to a string. See:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#use_within_json

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureValueToJSON):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/280531@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e73a5a: [GStreamer][LibWebRTC] Fix format handling in vide...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e73a5a8be966c99782f1d6059e131837f5a91e4e
  
https://github.com/WebKit/WebKit/commit/e73a5a8be966c99782f1d6059e131837f5a91e4e
  Author: Philippe Normand 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp

  Log Message:
  ---
  [GStreamer][LibWebRTC] Fix format handling in video encoder/decoder factory
https://bugs.webkit.org/show_bug.cgi?id=276047

Reviewed by Xabier Rodriguez-Calvar.

The SdpVideoFormat == operator relies on codec parameters additionally to the 
codec name, we want to
check the name only.

* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoderFactory::Create):
* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoderFactory::Create):

Canonical link: https://commits.webkit.org/280525@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19a245: [GStreamer] Registry scanner element filtering imp...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19a24540092a3acd36896b569960a56e0bec8853
  
https://github.com/WebKit/WebKit/commit/19a24540092a3acd36896b569960a56e0bec8853
  Author: Philippe Normand 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

  Log Message:
  ---
  [GStreamer] Registry scanner element filtering improvements
https://bugs.webkit.org/show_bug.cgi?id=276048

Reviewed by Xabier Rodriguez-Calvar.

We can't use gst_element_factory_list_filter because it would allow-list 
elements with pads using
ANY in their caps template.

This issue was found when trying to reduce the list of RTP (de)payloaders using
GST_PLUGIN_FEATURE_RANK, the rtpgstdepay element would be selected as candidate 
for audio/G722 caps,
which is valid, but in practice not a suitable element for our pipeline.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::findCompatibleFactories):
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForCaps const):

Canonical link: https://commits.webkit.org/280524@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22714b: REGRESSION(280453@main): [GTK][WPE] Build broken w...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22714bafb93d587ace2a6ef0729f2c78c46df0bd
  
https://github.com/WebKit/WebKit/commit/22714bafb93d587ace2a6ef0729f2c78c46df0bd
  Author: Philippe Normand 
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp

  Log Message:
  ---
  REGRESSION(280453@main): [GTK][WPE] Build broken with MEDIA_STREAM disabled
https://bugs.webkit.org/show_bug.cgi?id=275611

Unreviewed, fix build where MEDIA_STREAM is disabled.

* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):

Canonical link: https://commits.webkit.org/280454@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c1fba8: [GStreamer][MediaStream] Set a non constant groupI...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1fba8fb854b0f087c6822eca20788749e0485b0
  
https://github.com/WebKit/WebKit/commit/c1fba8fb854b0f087c6822eca20788749e0485b0
  Author: Philippe Normand 
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  ---
  [GStreamer][MediaStream] Set a non constant groupId on streams emitted by 
webkitmediastreamsrc
https://bugs.webkit.org/show_bug.cgi?id=275734

Reviewed by Xabier Rodriguez-Calvar.

While hardcoding 1 as group-id hasn't created issues in practice, it's not 
semantically correct, a
unique groupId should be used.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcConstructed):
(webkitMediaStreamSrcAddTrack):

Canonical link: https://commits.webkit.org/280411@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d2e5c: [GStreamer] Sample handling cleanups in text sink

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d2e5c0bc67adf9568e51f3aa10e515e88ad09ac
  
https://github.com/WebKit/WebKit/commit/6d2e5c0bc67adf9568e51f3aa10e515e88ad09ac
  Author: Philippe Normand 
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Sample handling cleanups in text sink
https://bugs.webkit.org/show_bug.cgi?id=275733

Reviewed by Xabier Rodriguez-Calvar.

Use GRefPtr and String instead of raw pointers when passing samples from the 
text sink to the
player.

* 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleTextSample):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkHandleSample):
(): Deleted.

Canonical link: https://commits.webkit.org/280367@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3402d3: [GStreamer][MSE] imported/w3c/web-platform-tests/m...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3402d3c3b3ae0bab3996518d8be3c5d26fb53b16
  
https://github.com/WebKit/WebKit/commit/3402d3c3b3ae0bab3996518d8be3c5d26fb53b16
  Author: Philippe Normand 
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations

  Log Message:
  ---
  [GStreamer][MSE] 
imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html
 crashes
https://bugs.webkit.org/show_bug.cgi?id=187804

Unreviewed, update test expectations for mediasource-seek-beyond-duration.html.

* LayoutTests/platform/glib/TestExpectations:

Canonical link: https://commits.webkit.org/280365@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20b365: [GStreamer][Debug] http/tests/navigation/page-cach...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20b365f98fbfdc9434233b92fecfd7faaad4fef4
  
https://github.com/WebKit/WebKit/commit/20b365f98fbfdc9434233b92fecfd7faaad4fef4
  Author: Philippe Normand 
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations

  Log Message:
  ---
  [GStreamer][Debug] http/tests/navigation/page-cache-video.html asserts
https://bugs.webkit.org/show_bug.cgi?id=271050


Unreviewed, gardening. Flag the test as flaky crash on Debug builds.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/280336@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0b3e3c: [GStreamer][MSE] Improved error handling in webkit...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b3e3c5ec50bd9d6c0ecb21d0832a42edeaf9f86
  
https://github.com/WebKit/WebKit/commit/0b3e3c5ec50bd9d6c0ecb21d0832a42edeaf9f86
  Author: Philippe Normand 
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MSE] Improved error handling in webkitmediasrc
https://bugs.webkit.org/show_bug.cgi?id=275778

Reviewed by Alicia Boya Garcia.

If we fail to push a buffer downstream we should post an error on the bus, 
GST_ELEMENT_ERROR takes
care of that. In that case the error message will be handled in the player, 
which will also dump the
pipeline graph, so there is no need to do that anymore from the source element.

Driving-by, the pipeline dumps generated by webkitmediasrc are now named 
according to the pipeline
they belong to, instead of hardcoding "playback-pipeline".

* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(dumpPipeline):
(webKitMediaSrcLoop):

Canonical link: https://commits.webkit.org/280297@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1b86ab: [GStreamer] Error building with libwebrtc enabled ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b86aba5013c21c198a3182424ec5c10b585aeb6
  
https://github.com/WebKit/WebKit/commit/1b86aba5013c21c198a3182424ec5c10b585aeb6
  Author: Philippe Normand 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

  Log Message:
  ---
  [GStreamer] Error building with libwebrtc enabled with gstreamer 1.18
https://bugs.webkit.org/show_bug.cgi?id=275657

Reviewed by Xabier Rodriguez-Calvar.

Fix LibWebRTC build for GStreamer versions older than 1.20.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(gst_buffer_new_memdup):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:

Canonical link: https://commits.webkit.org/280247@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ddbe6: [Flatpak] Update from llvm-16 to llvm18 flatpak ex...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ddbe6e87a550c270118bc938566f707384b6ffe
  
https://github.com/WebKit/WebKit/commit/0ddbe6e87a550c270118bc938566f707384b6ffe
  Author: Philippe Normand 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
M Tools/flatpak/flatpakutils.py

  Log Message:
  ---
  [Flatpak] Update from llvm-16 to llvm18 flatpak extension
https://bugs.webkit.org/show_bug.cgi?id=275732

Reviewed by Nikolas Zimmermann.

The llvm-16 extension doesn't seem to have working C++23 support.

* Tools/flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak._get_dependency_packages):

Canonical link: https://commits.webkit.org/280245@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 18670f: [GLib] Fix CLang build after switch to C++23

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18670f2c3a78d7e7b8b81154f50ff69558db1579
  
https://github.com/WebKit/WebKit/commit/18670f2c3a78d7e7b8b81154f50ff69558db1579
  Author: Philippe Normand 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp

  Log Message:
  ---
  [GLib] Fix CLang build after switch to C++23
https://bugs.webkit.org/show_bug.cgi?id=275728

Unreviewed, remove forward-declaration of classes used in std::unique_ptr. 
Since C++23 unique_ptr seems to
expect a complete type.

* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(WebKitAutomationClient::browserVersion const):
(WebKitAutomationClient::requestAutomationSession):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(PageLoadStateObserver::didChangeIsLoading):
(PageLoadStateObserver::didChangeTitle):
(PageLoadStateObserver::willChangeActiveURL):
(PageLoadStateObserver::didChangeActiveURL):

Canonical link: https://commits.webkit.org/280243@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d5844: [GTK][GStreamer] VA+DMABuf videos flicker

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d5844679af8f84036f1b800307e799bd7ab73ba
  
https://github.com/WebKit/WebKit/commit/9d5844679af8f84036f1b800307e799bd7ab73ba
  Author: Philippe Normand 
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp

  Log Message:
  ---
  [GTK][GStreamer] VA+DMABuf videos flicker
https://bugs.webkit.org/show_bug.cgi?id=253807

Reviewed by Xabier Rodriguez-Calvar.

By requesting a video frame allocation pool containing at least 3 frames, the 
risks of flickering
when rendering should be reduced.

* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(WebKitVideoSinkProbe::doProbe):

Canonical link: https://commits.webkit.org/280210@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c03ca8: REGRESSION(279944@main): [GStreamer] Build broken ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c03ca8dc15f5d30809c64feb0db684b72fa205f1
  
https://github.com/WebKit/WebKit/commit/c03ca8dc15f5d30809c64feb0db684b72fa205f1
  Author: Philippe Normand 
  Date:   2024-06-19 (Wed, 19 Jun 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  REGRESSION(279944@main): [GStreamer] Build broken with RELEASE_LOG disabled
https://bugs.webkit.org/show_bug.cgi?id=275607

Reviewed by Eric Carlson.

Fix build with RELEASE_LOG disabled.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayerWillBeDestroyed):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Canonical link: https://commits.webkit.org/280172@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc158b: REGRESSION(274853@main): [GLib][MSE] Excessive CPU...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc158b61f4bedc9bc1a7dd01689a64c225c813d2
  
https://github.com/WebKit/WebKit/commit/fc158b61f4bedc9bc1a7dd01689a64c225c813d2
  Author: Philippe Normand 
  Date:   2024-06-19 (Wed, 19 Jun 2024)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  ---
  REGRESSION(274853@main): [GLib][MSE] Excessive CPU usage from cached web 
process after closing ksdk.com page, failure to display web content after 
reopening page, part 2
https://bugs.webkit.org/show_bug.cgi?id=274802

Reviewed by Xabier Rodriguez-Calvar.

The excessive CPU usage was due to mediaPlayerReadyStateChanged() recursing on 
itself forever after
being triggered due to the MediaSource closing procedure. In the WPE/GTK ports 
at least, the
isSuspended() condition is always true in this situation. The proposed 
workaround is to attempt a
fixed amount of recursions.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/280171@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d48e67: [GStreamer] Duplicate WebCore log messages due to ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d48e67ce96f458d90843afa21b9bb56bdbb964ef
  
https://github.com/WebKit/WebKit/commit/d48e67ce96f458d90843afa21b9bb56bdbb964ef
  Author: Philippe Normand 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Duplicate WebCore log messages due to observing the document 
logger multiple times
https://bugs.webkit.org/show_bug.cgi?id=275396

Reviewed by Xabier Rodriguez-Calvar.

Because both the PeerConnection and HTMLMediaElement rely on the same logger 
instance (the one
created by the document), a page containing more than one PeerConnection and/or 
more than one Media
element would emit duplicate logs because we were adding multiple log observers 
to the same logger.

Also we now filter log message by their channel name before dispatching them to 
the GStreamer
logging system.

Thanks to Carlos Bentzen for the report.

* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::webrtcLogObserverSingleton):
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::~GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::didLogMessage): Deleted.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::WebCoreLogObserver::didLogMessage):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::WebCoreLogObserver::addWatch):
(WebCore::WebCoreLogObserver::removeWatch):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaLogObserverSingleton):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayerWillBeDestroyed):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::didLogMessage): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/280007@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 68997f: [GStreamer] Bridge WebCore Media logs to GStreamer...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68997f1c82a94b8f174691089f4d2b9a2f96a172
  
https://github.com/WebKit/WebKit/commit/68997f1c82a94b8f174691089f4d2b9a2f96a172
  Author: Philippe Normand 
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Bridge WebCore Media logs to GStreamer media player
https://bugs.webkit.org/show_bug.cgi?id=275354

Reviewed by Xabier Rodriguez-Calvar.

By setting WEBKIT_DEBUG=Media=debug the MediaElement logs are now also sent to 
GStreamer's logging
system, easing a bit debugging. The m_player being a weak pointer in 
MediaPlayerPrivate we needed a
new MediaPlayerPrivate method to allow clean-up before MediaPlayer destruction.

Driving-by, the PeerConnection backend logging was also aligned with the 
WTFLogLevel value.

* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::didLogMessage):
* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::~MediaPlayer):
* Source/WebCore/platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::mediaPlayerWillBeDestroyed):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLogMessage):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayerWillBeDestroyed):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/279944@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a650e: [GStreamer][MSE] SleepDisabler not reliably create...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a650e644b1ccf02a2aa19f07d5ec4bc706ac8ce
  
https://github.com/WebKit/WebKit/commit/6a650e644b1ccf02a2aa19f07d5ec4bc706ac8ce
  Author: Philippe Normand 
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
A 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion-expected.txt
A 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion.html
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h

  Log Message:
  ---
  [GStreamer][MSE] SleepDisabler not reliably created when playing YouTube 
videos
https://bugs.webkit.org/show_bug.cgi?id=219354

Reviewed by Xabier Rodriguez-Calvar.

When playing videos the display screensaver should be disabled, and when the 
video is paused it
should be re-enabled. This is mostly useful on desktop systems. The sleep 
disabler is handled by
HTMLMediaElement.

Until this patch display sleep wasn't consistently disabled as a result of 
playback request. By
notifying the MediaPlayer of successful GStreamer pipeline state changes the 
HTMLMediaElement gets
another opportunity to update the sleep disabling state. This is done already 
in the
MediaPlayerPrivateGStreamer::updateStates() method, but for some reason the MSE 
player has a
different implementation of that method.

Test: media/media-source/media-source-video-play-holds-sleep-assertion.html

* 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion-expected.txt:
 Added.
* 
LayoutTests/media/media-source/media-source-video-play-holds-sleep-assertion.html:
 Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::progressEventTimerFired):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::checkPlayingConsistency):
(WebCore::MediaPlayerPrivateGStreamerMSE::setShouldDisableSleep):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):
(WebCore::MediaPlayerPrivateGStreamerMSE::timeIsProgressing const):
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

Canonical link: https://commits.webkit.org/279943@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2d3841: [GStreamer] Crash in WebCore::VideoFrameGStreamer:...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d3841081a4404e5734aca80209fa8efcc537f06
  
https://github.com/WebKit/WebKit/commit/2d3841081a4404e5734aca80209fa8efcc537f06
  Author: Philippe Normand 
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

  Log Message:
  ---
  [GStreamer] Crash in WebCore::VideoFrameGStreamer::createWrappedSample when 
used by ImageDecoderGStreamer
https://bugs.webkit.org/show_bug.cgi?id=275205

Reviewed by Xabier Rodriguez-Calvar.

The issue here was that events were not correctly dispatched in nested 
GStreamer element harnesses,
leading to situations where a video decoder would receive an audio caps event, 
for instance. The VA
and libav decoders cope well with that situation, but the openh264 decoder just 
accepted those audio
caps (which is a bug in that decoder).

The solution is to pass events from upstream to downstream harness, if there is 
one. That's how
samples are also handled.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::Stream::Stream):

Canonical link: https://commits.webkit.org/279942@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d8c01: [GStreamer][WebRTC] Bridge PeerConnection logs to ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d8c01cb3854dcd7b53e4d971f6c9493d71a4dc9
  
https://github.com/WebKit/WebKit/commit/4d8c01cb3854dcd7b53e4d971f6c9493d71a4dc9
  Author: Philippe Normand 
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h

  Log Message:
  ---
  [GStreamer][WebRTC] Bridge PeerConnection logs to GStreamer logging system
https://bugs.webkit.org/show_bug.cgi?id=275161

Reviewed by Xabier Rodriguez-Calvar.

By setting WEBKIT_DEBUG=WebRTC=debug the PeerConnection logs are now also sent 
to GStreamer's
logging system, easing a bit debugging.

* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::~GStreamerPeerConnectionBackend):
(WebCore::GStreamerPeerConnectionBackend::didLogMessage):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:

Canonical link: https://commits.webkit.org/279871@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a47deb: [GStreamer] Give unique name to pads created by th...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a47deb713746fa2f228e8450a52ed0ecafc5309d
  
https://github.com/WebKit/WebKit/commit/a47deb713746fa2f228e8450a52ed0ecafc5309d
  Author: Philippe Normand 
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

  Log Message:
  ---
  [GStreamer] Give unique name to pads created by the ElementHarness
https://bugs.webkit.org/show_bug.cgi?id=275256

Reviewed by Xabier Rodriguez-Calvar.

Using unique names for the pads created by the GStreamer element harness, the 
pipeline dumps will be
more accurate. Without this patch the same pad could appear as linked to 
multiple peers, which is
semantically incorrect.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::GStreamerElementHarness):
(WebCore::GStreamerElementHarness::Stream::Stream):

Canonical link: https://commits.webkit.org/279869@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 35cd99: [GStreamer] Classify our custom video meta as such

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35cd997fead9c51ad1b5c0a39188336f0e2bbc90
  
https://github.com/WebKit/WebKit/commit/35cd997fead9c51ad1b5c0a39188336f0e2bbc90
  Author: Philippe Normand 
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Classify our custom video meta as such
https://bugs.webkit.org/show_bug.cgi?id=275050

Reviewed by Xabier Rodriguez-Calvar.

Using the video meta tag can be useful, for instance a video encoder might not 
copy the meta to its
output buffers if that tag is not present.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:
(videoFrameMetadataAPIGetType):

Canonical link: https://commits.webkit.org/279692@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ddfc6c: [GStreamer][MediaStream] Stream collection fixes

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ddfc6ce0fa86827863d420bf7b603dd710f71e3b
  
https://github.com/WebKit/WebKit/commit/ddfc6ce0fa86827863d420bf7b603dd710f71e3b
  Author: Philippe Normand 
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MediaStream] Stream collection fixes
https://bugs.webkit.org/show_bug.cgi?id=274825

Reviewed by Xabier Rodriguez-Calvar.

Our MediaStream source element answers to GST_QUERY_SELECTABLE queries but 
until this patch it
wasn't sending collection events on its pad(s). It still worked by luck in 
GStreamer versions older
than 1.25/1.26, decodebin3 would still create a parsebin internally.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcEnsureStreamCollection):
(webkitMediaStreamSrcPostStreamCollection):
(webkitMediaStreamSrcAddPad):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcAddTrack):
(ProbeData::ProbeData): Deleted.

Canonical link: https://commits.webkit.org/279570@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00f3c2: [GStreamer][WebCodecs] Remove a few unused includes

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00f3c2bfce1a58f1592d37a55a07190dfc7000f4
  
https://github.com/WebKit/WebKit/commit/00f3c2bfce1a58f1592d37a55a07190dfc7000f4
  Author: Philippe Normand 
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebCodecs] Remove a few unused includes
https://bugs.webkit.org/show_bug.cgi?id=274918

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp:
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:

Canonical link: https://commits.webkit.org/279568@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b1496: [GStreamer][MediaRecorder] Pipeline remains in glo...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b149650aebe9972cad909d83279d198dda6cb47
  
https://github.com/WebKit/WebKit/commit/4b149650aebe9972cad909d83279d198dda6cb47
  Author: Philippe Normand 
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MediaRecorder] Pipeline remains in global registry if 
stopRecording is called
https://bugs.webkit.org/show_bug.cgi?id=274893

Reviewed by Xabier Rodriguez-Calvar.

Clearing the GStreamer pipeline without un-registering it from the global 
registry would result in a
memory leak.

* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::stopRecording):

Canonical link: https://commits.webkit.org/279567@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c3e81: Cherry-pick 279190@main (f6f7e5b1258f). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c3e8148817aa35bd1ca9d18a955de08741b1cea
  
https://github.com/WebKit/WebKit/commit/5c3e8148817aa35bd1ca9d18a955de08741b1cea
  Author: Philippe Normand 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 279190@main (f6f7e5b1258f). 
https://bugs.webkit.org/show_bug.cgi?id=274257

[GStreamer] Silence GstVideoFrame leaks
https://bugs.webkit.org/show_bug.cgi?id=274257


Reviewed by Xabier Rodriguez-Calvar.

The ImageGStreamer no longer holds a BitmapImage, but a PlatformImagePtr. A 
BitmapImage is now
created by VideoFrameGStreamer when painting is required. The 
ImageGStreamerSkia implementation no
longer holds the mapped GstVideoFrame because that keeps un-necessary 
references and file
descriptors open, the needed plane data is copied instead.

* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ensureDebugCategoryIsInitialized):
(WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::create):
(WebCore::ImageGStreamer::image const):
(WebCore::ImageGStreamer::rect):
(WebCore::ImageGStreamer::createImage): Deleted.
(WebCore::ImageGStreamer::image): Deleted.
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:
(WebCore::MediaSampleGStreamer::sample const):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::convertSampleToImage):
(WebCore::VideoFrame::paintInContext):

Canonical link: https://commits.webkit.org/279190@main

Canonical link: https://commits.webkit.org/274313.291@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2fcc5: Cherry-pick 278912@main (20f2c49ed07f). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: a2fcc59214e31fdace49676749db193039fb76fc
  
https://github.com/WebKit/WebKit/commit/a2fcc59214e31fdace49676749db193039fb76fc
  Author: Philippe Normand 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 278912@main (20f2c49ed07f). 
https://bugs.webkit.org/show_bug.cgi?id=274254

[GStreamer] Clean-up GstSample ref handling in MediaSampleGStreamer
https://bugs.webkit.org/show_bug.cgi?id=274254

Reviewed by Michael Catanzaro.

The MediaSampleGStreamer constructor consumes GstSample references, so they 
should be moved
accordingly.

* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
(WebCore::MediaSampleGStreamer::createNonDisplayingCopy const):

Canonical link: https://commits.webkit.org/278912@main

Canonical link: https://commits.webkit.org/274313.290@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a8781: Cherry-pick 277980@main (231262cc356b). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a8781d912a1d8f28bff5142c10560cf43c84baa
  
https://github.com/WebKit/WebKit/commit/8a8781d912a1d8f28bff5142c10560cf43c84baa
  Author: Philippe Normand 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  ---
  Cherry-pick 277980@main (231262cc356b). 
https://bugs.webkit.org/show_bug.cgi?id=273238

[GStreamer][WebRTC] Request video key-frame when connecting incoming streams
https://bugs.webkit.org/show_bug.cgi?id=273238

Reviewed by Xabier Rodriguez-Calvar.

In some cases of remote peer sending H.264, the resulting depayloaded 
bitstream might not contain
SPS/PPS informations required for decoding. Without these the parser would 
discard frames until the
stream can be parsed, potentially leading to delay in setting up the video 
decoder. To workaround
this issue, issue a key-frame request as soon as a new src pad is exposed 
on webrtcbin, and also
when adding video pads to the mediastreamsrc element.

* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcPadProbeCb):

Canonical link: https://commits.webkit.org/277980@main

Canonical link: https://commits.webkit.org/274313.289@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90db18: Cherry-pick 278306@main (9f7fcac9257e). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 90db18fb1152c126c9140573d1fdbff9fd1da367
  
https://github.com/WebKit/WebKit/commit/90db18fb1152c126c9140573d1fdbff9fd1da367
  Author: Philippe Normand 
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 278306@main (9f7fcac9257e). 
https://bugs.webkit.org/show_bug.cgi?id=273555

[GStreamer][WebAudio] Misc improvements in playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=273555

Reviewed by Xabier Rodriguez-Calvar.

A small queue is needed before the sink, by design. In the webaudiosrc 
element timestamping was
improved, silent buffers are now flagged as droppable and the render task 
starts only when going to
PLAYING state.

* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcRenderAndPushFrames):
(webKitWebAudioSrcChangeState):

Canonical link: https://commits.webkit.org/278306@main

Canonical link: https://commits.webkit.org/274313.288@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d19ea: [Buildstream SDK] Update to GStreamer 1.24.4

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d19eaf9232161759c9cdb24226bb9e23e01e40f
  
https://github.com/WebKit/WebKit/commit/9d19eaf9232161759c9cdb24226bb9e23e01e40f
  Author: Philippe Normand 
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
M Tools/buildstream/elements/freedesktop-sdk.bst
R Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.2.patch
A Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.4.patch

  Log Message:
  ---
  [Buildstream SDK] Update to GStreamer 1.24.4
https://bugs.webkit.org/show_bug.cgi?id=274829

Reviewed by Adrian Perez de Castro.

* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.4.patch: Renamed 
from Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.2.patch.

Canonical link: https://commits.webkit.org/279441@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e67dd6: [GStreamer] Move most GStreamerCommon classes impl...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e67dd6f289db6671b04a9f74c47dc54cd266c257
  
https://github.com/WebKit/WebKit/commit/e67dd6f289db6671b04a9f74c47dc54cd266c257
  Author: Philippe Normand 
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp

  Log Message:
  ---
  [GStreamer] Move most GStreamerCommon classes implemenations to cpp file
https://bugs.webkit.org/show_bug.cgi?id=274524

Reviewed by Xabier Rodriguez-Calvar.

The GStreamerCommon.h file is included in many other files, so any change there 
triggers ~950
compile jobs on an incremental build. The template classes were left in the 
header, moving them to
the cpp file would increase verbosity too much. Also driving-by a couple 
GstMappedFrame methods were
renamed, adopting the camelCase style.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::GstMappedOwnedBuffer::create):
(WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer):
(WebCore::GstMappedOwnedBuffer::createSharedBuffer):
(WebCore::GstMappedFrame::GstMappedFrame):
(WebCore::GstMappedFrame::~GstMappedFrame):
(WebCore::GstMappedFrame::get):
(WebCore::GstMappedFrame::componentData const):
(WebCore::GstMappedFrame::componentStride const):
(WebCore::GstMappedFrame::info):
(WebCore::GstMappedFrame::width const):
(WebCore::GstMappedFrame::height const):
(WebCore::GstMappedFrame::format const):
(WebCore::GstMappedFrame::planeData const):
(WebCore::GstMappedFrame::planeStride const):
(WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer):
(WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer):
(WebCore::GstMappedAudioBuffer::get):
(WebCore::GstMappedAudioBuffer::info):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::unmapFunction):
(WebCore::GstMappedOwnedBuffer::create): Deleted.
(WebCore::GstMappedOwnedBuffer::~GstMappedOwnedBuffer): Deleted.
(WebCore::GstMappedFrame::GstMappedFrame): Deleted.
(WebCore::GstMappedFrame::~GstMappedFrame): Deleted.
(WebCore::GstMappedFrame::get): Deleted.
(WebCore::GstMappedFrame::ComponentData const): Deleted.
(WebCore::GstMappedFrame::ComponentStride const): Deleted.
(WebCore::GstMappedFrame::info): Deleted.
(WebCore::GstMappedFrame::width const): Deleted.
(WebCore::GstMappedFrame::height const): Deleted.
(WebCore::GstMappedFrame::format const): Deleted.
(WebCore::GstMappedFrame::planeData const): Deleted.
(WebCore::GstMappedFrame::planeStride const): Deleted.
(WebCore::GstMappedAudioBuffer::GstMappedAudioBuffer): Deleted.
(WebCore::GstMappedAudioBuffer::get): Deleted.
(WebCore::GstMappedAudioBuffer::info): Deleted.
(WebCore::GstMappedAudioBuffer::~GstMappedAudioBuffer): Deleted.
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrame::copyTo):
* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerVideoFrameLibWebRTC::ToI420):

Canonical link: https://commits.webkit.org/279191@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6f7e5: [GStreamer] Silence GstVideoFrame leaks

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6f7e5b1258f62f62681fbf0e34fefe8c12369bb
  
https://github.com/WebKit/WebKit/commit/f6f7e5b1258f62f62681fbf0e34fefe8c12369bb
  Author: Philippe Normand 
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Silence GstVideoFrame leaks
https://bugs.webkit.org/show_bug.cgi?id=274257


Reviewed by Xabier Rodriguez-Calvar.

The ImageGStreamer no longer holds a BitmapImage, but a PlatformImagePtr. A 
BitmapImage is now
created by VideoFrameGStreamer when painting is required. The 
ImageGStreamerSkia implementation no
longer holds the mapped GstVideoFrame because that keeps un-necessary 
references and file
descriptors open, the needed plane data is copied instead.

* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ensureDebugCategoryIsInitialized):
(WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::create):
(WebCore::ImageGStreamer::image const):
(WebCore::ImageGStreamer::rect):
(WebCore::ImageGStreamer::createImage): Deleted.
(WebCore::ImageGStreamer::image): Deleted.
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:
(WebCore::MediaSampleGStreamer::sample const):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::convertSampleToImage):
(WebCore::VideoFrame::paintInContext):

Canonical link: https://commits.webkit.org/279190@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff0ee8: [GStreamer] GstVideoFrame leaks

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff0ee80363c44d9454014b8703db57abd893bc32
  
https://github.com/WebKit/WebKit/commit/ff0ee80363c44d9454014b8703db57abd893bc32
  Author: Philippe Normand 
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] GstVideoFrame leaks
https://bugs.webkit.org/show_bug.cgi?id=274257

Unreviewed, revert due to incomplete fix.

Canonical link: https://commits.webkit.org/279063@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb1279: Cherry-pick 278745@main (2ff0a25e8850). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: cb1279707f32345eb93ccd4395417a0e5b288846
  
https://github.com/WebKit/WebKit/commit/cb1279707f32345eb93ccd4395417a0e5b288846
  Author: Philippe Normand 
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 278745@main (2ff0a25e8850). 
https://bugs.webkit.org/show_bug.cgi?id=274093

[GStreamer][WebRTC] Incoming video track renderer should rely on the track 
intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=274093

Reviewed by Xabier Rodriguez-Calvar.

Pixel and display aspect ratios shouldn't be applied for WebRTC video 
tracks. The intrinsic size is
re-used as it is. The avf MediaStream player behaves similarly.

* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::updateVideoSizeAndOrientationFromCaps):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:
(WebCore::RealtimeIncomingVideoSourceGStreamer::ensureSizeAndFramerate):
(WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample):

Canonical link: https://commits.webkit.org/278745@main

Canonical link: https://commits.webkit.org/274313.260@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f5bc5e: [GStreamer] GstVideoFrame leaks

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5bc5e55ae85bcd192d63e135c7007999c2f7f2a
  
https://github.com/WebKit/WebKit/commit/f5bc5e55ae85bcd192d63e135c7007999c2f7f2a
  Author: Philippe Normand 
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] GstVideoFrame leaks
https://bugs.webkit.org/show_bug.cgi?id=274257

Reviewed by Xabier Rodriguez-Calvar.

The ImageGStreamer no longer holds a BitmapImage, but a PlatformImagePtr. A 
BitmapImage is now
created by VideoFrameGStreamer when painting is required. The 
ImageGStreamerSkia implementation no
longer holds the mapped GstVideoFrame because that keeps un-necessary 
references and file
descriptors open, the needed plane data is copied instead. The static 
ImageDecoderGStreamer vector
now stores WeakPtrs instead of RefPtr, which semantically more correct but in 
practice makes no difference.

* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ensureDebugCategoryIsInitialized):
(WebCore::teardownGStreamerImageDecoders):
(WebCore::ImageDecoderGStreamer::create):
(WebCore::ImageDecoderGStreamer::ImageDecoderGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::create):
(WebCore::ImageGStreamer::image const):
(WebCore::ImageGStreamer::rect):
(WebCore::ImageGStreamer::createImage): Deleted.
(WebCore::ImageGStreamer::image): Deleted.
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp:
(WebCore::ImageGStreamer::ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h:
(WebCore::MediaSampleGStreamer::sample const):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::convertSampleToImage):
(WebCore::VideoFrame::paintInContext):

Canonical link: https://commits.webkit.org/279052@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04a4f4: [GStreamer] Minor cleanups in GstMappedFrame class

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04a4f4adf3f1272fe288b310cdcca6cc8f96c956
  
https://github.com/WebKit/WebKit/commit/04a4f4adf3f1272fe288b310cdcca6cc8f96c956
  Author: Philippe Normand 
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

  Log Message:
  ---
  [GStreamer] Minor cleanups in GstMappedFrame class
https://bugs.webkit.org/show_bug.cgi?id=274312

Reviewed by Xabier Rodriguez-Calvar.

There is no need for a m_isValid boolean attribute because the buffer field on 
the GstVideoFrame can
be checked instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::GstMappedFrame::GstMappedFrame):
(WebCore::GstMappedFrame::~GstMappedFrame):
(WebCore::GstMappedFrame::get):
(WebCore::GstMappedFrame::ComponentData const):
(WebCore::GstMappedFrame::ComponentStride const):
(WebCore::GstMappedFrame::info):
(WebCore::GstMappedFrame::width const):
(WebCore::GstMappedFrame::height const):
(WebCore::GstMappedFrame::format const):
(WebCore::GstMappedFrame::planeData const):
(WebCore::GstMappedFrame::planeStride const):
(WebCore::GstMappedFrame::isValid const):
(WebCore::GstMappedFrame::operator bool const):
(WebCore::GstMappedFrame::operator! const):

Canonical link: https://commits.webkit.org/278992@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 20f2c4: [GStreamer] Clean-up GstSample ref handling in Med...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20f2c49ed07fa9eaf05c77269f5b3516e4544d0d
  
https://github.com/WebKit/WebKit/commit/20f2c49ed07fa9eaf05c77269f5b3516e4544d0d
  Author: Philippe Normand 
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Clean-up GstSample ref handling in MediaSampleGStreamer
https://bugs.webkit.org/show_bug.cgi?id=274254

Reviewed by Michael Catanzaro.

The MediaSampleGStreamer constructor consumes GstSample references, so they 
should be moved
accordingly.

* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
(WebCore::MediaSampleGStreamer::createNonDisplayingCopy const):

Canonical link: https://commits.webkit.org/278912@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5b512a: [WPE] Unconditionally enable the Mesa software ras...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b512a4a6d1c6e086357719cfc59e4b9f598d7f6
  
https://github.com/WebKit/WebKit/commit/5b512a4a6d1c6e086357719cfc59e4b9f598d7f6
  Author: Philippe Normand 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Tools/Scripts/webkitpy/port/wpe.py

  Log Message:
  ---
  [WPE] Unconditionally enable the Mesa software rasterizer when running tests
https://bugs.webkit.org/show_bug.cgi?id=274148

Reviewed by Carlos Garcia Campos.

We can't expect all the WPE post-commit test bots to have a GPU, so in order to 
improve test
reproducability independently from the test host graphics setup, enable the 
Mesa software
rasterizer.

* Tools/Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):

Canonical link: https://commits.webkit.org/278862@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec004d: [GStreamer] GL/DMABuf logging improvements

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec004d2b24503adb91ec90b2ff441663522f28b7
  
https://github.com/WebKit/WebKit/commit/ec004d2b24503adb91ec90b2ff441663522f28b7
  Author: Philippe Normand 
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp

  Log Message:
  ---
  [GStreamer] GL/DMABuf logging improvements
https://bugs.webkit.org/show_bug.cgi?id=274146

Reviewed by Xabier Rodriguez-Calvar.

The webkitdisplay GST_DEBUG category can be used to diagnose WebKit/GL errors 
now. The DMABuf
rendering code path was also instrumented with logs in order to help diagnosing 
issues.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
* Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:
(WebCore::ensureDebugCategoryInitialized):
(WebCore::PlatformDisplay::gstGLContext const):

Canonical link: https://commits.webkit.org/278802@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2ff0a2: [GStreamer][WebRTC] Incoming video track renderer ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ff0a25e8850318798332aebf550bd67bc812a54
  
https://github.com/WebKit/WebKit/commit/2ff0a25e8850318798332aebf550bd67bc812a54
  Author: Philippe Normand 
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Incoming video track renderer should rely on the track 
intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=274093

Reviewed by Xabier Rodriguez-Calvar.

Pixel and display aspect ratios shouldn't be applied for WebRTC video tracks. 
The intrinsic size is
re-used as it is. The avf MediaStream player behaves similarly.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateVideoSizeAndOrientationFromCaps):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp:
(WebCore::RealtimeIncomingVideoSourceGStreamer::ensureSizeAndFramerate):
(WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample):

Canonical link: https://commits.webkit.org/278745@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d6d7f3: [GStreamer][WebRTC] Caps negotiation failure when ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6d7f3edf374504363fece083b65e38793b27df0
  
https://github.com/WebKit/WebKit/commit/d6d7f3edf374504363fece083b65e38793b27df0
  Author: Philippe Normand 
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
M 
LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt
M 
LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Caps negotiation failure when ssrc-audio-level RTP 
extension is requested
https://bugs.webkit.org/show_bug.cgi?id=271519

Reviewed by Xabier Rodriguez-Calvar.

When not present in caps, the vad support of the ssrc-audio-level extension 
should be enabled. In
order to prevent caps negotiation issues with downstream, explicitely set it.

* 
LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt:
* 
LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt:
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType):

Canonical link: https://commits.webkit.org/278738@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d653b: [GLib] Support for loading websettings from a conf...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d653b68af47298e0454fb62fb15a52f56c184ae
  
https://github.com/WebKit/WebKit/commit/4d653b68af47298e0454fb62fb15a52f56c184ae
  Author: Philippe Normand 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
M Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in
M Tools/MiniBrowser/gtk/main.c
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

  Log Message:
  ---
  [GLib] Support for loading websettings from a config file
https://bugs.webkit.org/show_bug.cgi?id=273043

Reviewed by Michael Catanzaro, Carlos Garcia Campos and Adrian Perez de Castro.

New WebKitSettings API allowing to apply settings declared in a .ini style 
file. Based on a similar
feature implemented in Cog by Adrian Perez de Castro .

* Source/WTF/wtf/glib/GUniquePtr.h:
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_apply_from_key_file):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in:
* Tools/MiniBrowser/gtk/main.c:
(main):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettingsApplyFromConfigFile):
(beforeAll):

Canonical link: https://commits.webkit.org/278688@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4f4033: [GStreamer][MSE] Typos in AppendPipeline

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f403324a20209aa3f12c0fc4735f1764a08b16e
  
https://github.com/WebKit/WebKit/commit/4f403324a20209aa3f12c0fc4735f1764a08b16e
  Author: Philippe Normand 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h

  Log Message:
  ---
  [GStreamer][MSE] Typos in AppendPipeline
https://bugs.webkit.org/show_bug.cgi?id=274050

Reviewed by Xabier Rodriguez-Calvar.

* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::linkPadWithTrack):
(WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::Track::Track):

Canonical link: https://commits.webkit.org/278675@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b023c5: [GStreamer][WebRTC] Improve error checking in Data...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b023c541869491bacd7a9c0980dae6821881e95b
  
https://github.com/WebKit/WebKit/commit/b023c541869491bacd7a9c0980dae6821881e95b
  Author: Philippe Normand 
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Improve error checking in DataChannel backend
https://bugs.webkit.org/show_bug.cgi?id=273932

Reviewed by Xabier Rodriguez-Calvar.

Use the new gst_webrtc_data_channel_send_{string,data}_full APIs when 
available. Also fix
GST_CHECK_VERSION ifdefs, those should use stable release numbering unless the 
needed check is for a
development version not shipped yet.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.cpp:
(WebCore::GStreamerDataChannelHandler::sendStringData):
(WebCore::GStreamerDataChannelHandler::sendRawData):
(WebCore::GStreamerDataChannelHandler::checkState):

Canonical link: https://commits.webkit.org/278611@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3736e: [CMake][LibWebRTC] ARM build fixes

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3736efaa6acb2262fd5140c02dd3e0a61a1a27b
  
https://github.com/WebKit/WebKit/commit/e3736efaa6acb2262fd5140c02dd3e0a61a1a27b
  Author: Philippe Normand 
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/CMakeLists.txt

  Log Message:
  ---
  [CMake][LibWebRTC] ARM build fixes
https://bugs.webkit.org/show_bug.cgi?id=273870

Unreviewed, fix LibWebRTC ARM build.

* Source/ThirdParty/libwebrtc/CMakeLists.txt:

Canonical link: https://commits.webkit.org/278500@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 60532c: [CMake][LibWebRTC] Add support for optimized ASM B...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60532cbe64e57216edfe958bf734a31da594cdb0
  
https://github.com/WebKit/WebKit/commit/60532cbe64e57216edfe958bf734a31da594cdb0
  Author: Philippe Normand 
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/CMakeLists.txt

  Log Message:
  ---
  [CMake][LibWebRTC] Add support for optimized ASM BoringSSL modules
https://bugs.webkit.org/show_bug.cgi?id=273543

Reviewed by Adrian Perez de Castro.

Build the fipsmodule and crypto assembly code. The nasm files are not built 
though, those might be
needed on platforms where nasm is required.

* Source/ThirdParty/libwebrtc/CMakeLists.txt:

Canonical link: https://commits.webkit.org/278497@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 16888f: [GStreamer][WebRTC] Basic logging support in trans...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16888f96cdf4992d3fa1cbb041a35bf64fe67923
  
https://github.com/WebKit/WebKit/commit/16888f96cdf4992d3fa1cbb041a35bf64fe67923
  Author: Philippe Normand 
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.cpp
M 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Basic logging support in transport backends
https://bugs.webkit.org/show_bug.cgi?id=273811

Reviewed by Xabier Rodriguez-Calvar.

Add basic GStreamer debug instrumentation in the ICE and DTLS transport 
backends.

* 
Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.cpp:
(WebCore::GStreamerDtlsTransportBackendObserver::stateChanged):
(WebCore::GStreamerDtlsTransportBackendObserver::stop):
(WebCore::GStreamerDtlsTransportBackend::GStreamerDtlsTransportBackend):
(WebCore::GStreamerDtlsTransportBackend::unregisterClient):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.cpp:
(WebCore::GStreamerIceTransportBackend::GStreamerIceTransportBackend):
(WebCore::GStreamerIceTransportBackend::registerClient):
(WebCore::GStreamerIceTransportBackend::stateChanged const):
(WebCore::GStreamerIceTransportBackend::selectedCandidatePairChanged):

Canonical link: https://commits.webkit.org/278495@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c47f18: [GStreamer][LibWebRTC] Timestamp handling improvem...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c47f18c9b0377b063033a3a65b979ad488642ae0
  
https://github.com/WebKit/WebKit/commit/c47f18c9b0377b063033a3a65b979ad488642ae0
  Author: Philippe Normand 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp
M 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.h

  Log Message:
  ---
  [GStreamer][LibWebRTC] Timestamp handling improvements in video decoder 
factory
https://bugs.webkit.org/show_bug.cgi?id=273757

Reviewed by Xabier Rodriguez-Calvar.

The buffers injected into the parser pipeline are now timestamped by appsrc. 
The RTP timestamps are
required by the LibWebRTC generic decoder in order to match parsed frames with 
input buffers, so
they are attached on each buffers using a reference timestamp meta.

* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerWebRTCVideoDecoder::GStreamerWebRTCVideoDecoder):
(WebCore::GStreamerWebRTCVideoDecoder::pullSample):
* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::ensureDebugCategoryIsRegistered):
(WebCore::convertGStreamerSampleToLibWebRTCVideoFrame):
(WebCore::GStreamerVideoFrameLibWebRTC::ToI420):
* 
Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.h:

Canonical link: https://commits.webkit.org/278447@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f7fca: [GStreamer][WebAudio] Misc improvements in playbac...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f7fcac9257ebed1331734bccf454638ca63a732
  
https://github.com/WebKit/WebKit/commit/9f7fcac9257ebed1331734bccf454638ca63a732
  Author: Philippe Normand 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebAudio] Misc improvements in playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=273555

Reviewed by Xabier Rodriguez-Calvar.

A small queue is needed before the sink, by design. In the webaudiosrc element 
timestamping was
improved, silent buffers are now flagged as droppable and the render task 
starts only when going to
PLAYING state.

* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcRenderAndPushFrames):
(webKitWebAudioSrcChangeState):

Canonical link: https://commits.webkit.org/278306@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 64f50f: Cherry-pick 277804@main (9e5519436f6b). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 64f50f9bd802084b206f96aea42690695442098a
  
https://github.com/WebKit/WebKit/commit/64f50f9bd802084b206f96aea42690695442098a
  Author: Philippe Normand 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 277804@main (9e5519436f6b). 
https://bugs.webkit.org/show_bug.cgi?id=272912

[GStreamer] Deadlock in webKitWebSrcCreate when handling non-flushing seeks
https://bugs.webkit.org/show_bug.cgi?id=272912

Reviewed by Xabier Rodriguez-Calvar.

When handling non-flushing seeks the GStreamer basesrc base class will 
pause the pad task instead of
sending a flush-start event, so in that situation the "unlock" vmethod is 
not called. In order to
prevent deadlocks, unlock the streaming thread before letting basesrc 
handle the non-flushing seek
event.

* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
(webKitWebSrcEvent):

Canonical link: https://commits.webkit.org/277804@main

Canonical link: https://commits.webkit.org/274313.198@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a65cb6: [GStreamer] Video encoder configuration using code...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a65cb6426ce7d364e4f0c462533bf67e5d0abb5f
  
https://github.com/WebKit/WebKit/commit/a65cb6426ce7d364e4f0c462533bf67e5d0abb5f
  Author: Philippe Normand 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp
M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp
M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Video encoder configuration using codec strings
https://bugs.webkit.org/show_bug.cgi?id=273398

Reviewed by Xabier Rodriguez-Calvar.

The video encoder used to be configurable with output caps, but that wasn't 
sufficient so later on
it was extended with some support for codec string handling, which made the 
code more complex. By
dropping GstCaps configuration support and by relying only on codec string 
parsing, the input/output
caps logic is now decided in the GStreamerCodecUtilities. So modules making use 
of codec
strings (MediaRecorder, WebCodecs) pass their configuration directly to the 
encoder. For WebRTC we
forge a codec string according to the negotiated video encoding-name. Later on 
for simulcast the
codec strings from the RtpSender parameters will be leveraged.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoEncoder::initialize):
* Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp:
(WebCore::h264CapsFromCodecString):
(WebCore::h265CapsFromCodecString):
(WebCore::vpxCapsFromCodecString):
(WebCore::av1CapsFromCodecString):
(WebCore::GStreamerCodecUtilities::capsFromCodecString):
* Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h:
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderGetProperty):
(videoEncoderSetEncoder):
(videoEncoderFindForCodec):
(videoEncoderSupportsCodec):
(videoEncoderSetCodec):
(videoEncoderSetProperty):
(webkit_video_encoder_class_init):
(videoEncoderSupportsFormat): Deleted.
(videoEncoderSetFormat): Deleted.
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h:
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::containerProfile):
(WebCore::MediaRecorderPrivateBackend::configureVideoEncoder):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.h:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/278266@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bafd89: [GStreamer] Memory leak fixes in GStreamerElementH...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bafd8951d49e3ff6979d57ceb9a9c118dadbd649
  
https://github.com/WebKit/WebKit/commit/bafd8951d49e3ff6979d57ceb9a9c118dadbd649
  Author: Philippe Normand 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp

  Log Message:
  ---
  [GStreamer] Memory leak fixes in GStreamerElementHarness tests
https://bugs.webkit.org/show_bug.cgi?id=273544

Reviewed by Xabier Rodriguez-Calvar.

Fix memory leaks detected by the GStreamer leak tracer.

* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::GStreamerTest::SetUpTestSuite):
(TestWebKitAPI::GStreamerTest::TearDownTestSuite):
(TestWebKitAPI::GStreamerTest::SetUp): Deleted.
(TestWebKitAPI::GStreamerTest::TearDown): Deleted.
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h:
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/278264@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d5b97: [Buildstream SDK] Rollback GTK 4.15 update

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d5b97db9832ad1614e994ee23c21eba97eb6564
  
https://github.com/WebKit/WebKit/commit/4d5b97db9832ad1614e994ee23c21eba97eb6564
  Author: Philippe Normand 
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
M Tools/buildstream/elements/sdk/gtk.bst
R 
Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch

  Log Message:
  ---
  [Buildstream SDK] Rollback GTK 4.15 update
https://bugs.webkit.org/show_bug.cgi?id=273423

Unreviewed, GTK 4.15 is not usable, going back to latest stable release.

* Tools/buildstream/elements/sdk/gtk.bst:
* 
Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch: 
Removed.

Canonical link: https://commits.webkit.org/278117@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8a213: [Buildstream SDK] Backport GTK startup assert fix

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8a213ced45bbdf0de563464a143039162ac9276
  
https://github.com/WebKit/WebKit/commit/b8a213ced45bbdf0de563464a143039162ac9276
  Author: Philippe Normand 
  Date:   2024-04-28 (Sun, 28 Apr 2024)

  Changed paths:
M Tools/buildstream/elements/sdk/gtk.bst
A 
Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch

  Log Message:
  ---
  [Buildstream SDK] Backport GTK startup assert fix
https://bugs.webkit.org/show_bug.cgi?id=273370

Unreviewed, backport a GTK patch fixing an assert being raised at startup in 
Wayland.

* Tools/buildstream/elements/sdk/gtk.bst:
* 
Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch: 
Added.

Canonical link: https://commits.webkit.org/278086@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c99c18: [Buildstream SDK] Update GTK and gst-plugin-dav1d

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c99c18cd6894b42a18739abb2cff0a06b32cb783
  
https://github.com/WebKit/WebKit/commit/c99c18cd6894b42a18739abb2cff0a06b32cb783
  Author: Philippe Normand 
  Date:   2024-04-27 (Sat, 27 Apr 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Tools/buildstream/elements/freedesktop-sdk.bst
M Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst
M Tools/buildstream/elements/sdk/gtk.bst
A Tools/buildstream/elements/sdk/pango.bst

  Log Message:
  ---
  [Buildstream SDK] Update GTK and gst-plugin-dav1d
https://bugs.webkit.org/show_bug.cgi?id=273356

Reviewed by Adrian Perez de Castro.

Update to GTK 4.15, which depends on Pango 1.52, not shipped by upstream SDK, 
so we need a local
override. The gst-plugin-dav1d was also update to latest development version 
including an additional
colorimetry-related patch.

* LayoutTests/platform/glib/TestExpectations:
* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst:
* Tools/buildstream/elements/sdk/gtk.bst:
* Tools/buildstream/elements/sdk/pango.bst: Added.

Canonical link: https://commits.webkit.org/278079@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69c582: Cherry-pick 275198@main (a45b3b20b106). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 69c582be05a46699bda0bd400f33e4782c0ac1c8
  
https://github.com/WebKit/WebKit/commit/69c582be05a46699bda0bd400f33e4782c0ac1c8
  Author: Ben Nham 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M Source/WTF/wtf/MemoryPressureHandler.cpp
M Source/WTF/wtf/MemoryPressureHandler.h
M Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm
M Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp
M Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp
M Source/WebKit/WebProcess/WebProcess.cpp

  Log Message:
  ---
  Cherry-pick 275198@main (a45b3b20b106). 
https://bugs.webkit.org/show_bug.cgi?id=269859

WebContent process stays in the isUnderMemoryPressure state forever after 
it breaches the PROC_LIMIT_CRITICAL threshold
https://bugs.webkit.org/show_bug.cgi?id=269859
rdar://118126701

Reviewed by Antti Koivisto.

After 244148@main, a WebContent process that exceeds the 
PROC_LIMIT_CRITICAL threshold ends up in
the isUnderMemoryPressure state forever. This is because we were mutating 
the memory pressure state
instance variable when handling the process limit notification. Since the 
OS only notifies you when
you exceed the proc limit, but not when you go back under the proc limit, 
that state variable ended
up staying in the critical state forever. (This bug has occurred before, 
see r234646.)

To fix this, stop mutating the memory pressure state when the process limit 
notification fires, and
add a separate callback for handling process limit notifications.

* Source/WTF/wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::setMemoryPressureStatus):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):
(WTF::MemoryPressureHandler::didExceedProcessMemoryLimit):
* Source/WTF/wtf/MemoryPressureHandler.h:
(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setDidExceedProcessMemoryLimitCallback):
(WTF::MemoryPressureHandler::isUnderMemoryWarning const):
(WTF::MemoryPressureHandler::isUnderMemoryPressure const):
* Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:
(WTF::MemoryPressureHandler::install):
* Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:
(WTF::MemoryPressureHandler::triggerMemoryPressureEvent):
* Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp:
(WTF::MemoryPressureHandler::windowsMeasurementTimerFired):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Canonical link: https://commits.webkit.org/275198@main

Canonical link: https://commits.webkit.org/274313.162@webkitglib/2.44


  Commit: 25e4703314326cda79659dec3e4843263da30c32
  
https://github.com/WebKit/WebKit/commit/25e4703314326cda79659dec3e4843263da30c32
  Author: Philippe Normand 
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp

  Log Message:
  ---
  Cherry-pick 275090@main (c62c74690915). 
https://bugs.webkit.org/show_bug.cgi?id=269836

[WPE][GTK] Disable mDNS LibWebRTC support
https://bugs.webkit.org/show_bug.cgi?id=269836

Reviewed by Adrian Perez de Castro.

Disable mDNS address resolving for WPE and GTK ports, mDNS address 
registration is implemented only
for the Mac ports, so resolving can work only for those, currently.

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::GetMdnsResponder const):

Canonical link: https://commits.webkit.org/275090@main

Canonical link: https://commits.webkit.org/274313.163@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/bb9c461af9bf...25e470331432

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 231262: [GStreamer][WebRTC] Request video key-frame when c...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 231262cc356b901d0734046cbbea8555941d6a46
  
https://github.com/WebKit/WebKit/commit/231262cc356b901d0734046cbbea8555941d6a46
  Author: Philippe Normand 
  Date:   2024-04-25 (Thu, 25 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Request video key-frame when connecting incoming streams
https://bugs.webkit.org/show_bug.cgi?id=273238

Reviewed by Xabier Rodriguez-Calvar.

In some cases of remote peer sending H.264, the resulting depayloaded bitstream 
might not contain
SPS/PPS informations required for decoding. Without these the parser would 
discard frames until the
stream can be parsed, potentially leading to delay in setting up the video 
decoder. To workaround
this issue, issue a key-frame request as soon as a new src pad is exposed on 
webrtcbin, and also
when adding video pads to the mediastreamsrc element.

* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcPadProbeCb):

Canonical link: https://commits.webkit.org/277980@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3b1ff: [GStreamer] Improve support for AV1 colorimetry ha...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b1ffe5f3a0558820b7f75fa36664b2b7ef0408
  
https://github.com/WebKit/WebKit/commit/c3b1ffe5f3a0558820b7f75fa36664b2b7ef0408
  Author: Philippe Normand 
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/AV1Utilities.cpp
M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  [GStreamer] Improve support for AV1 colorimetry handling
https://bugs.webkit.org/show_bug.cgi?id=273059

Reviewed by Xabier Rodriguez-Calvar.

The parsed av01 codec string can now be translated to GStreamer caps. While 
writing tests for this I
noticed a couple issues in `parseAV1CodecParameters()`, returning empty results 
after parsing
optional fields. That issue is now fixed and we have tests. Later on the 
encoder will be adapted in
order to make use of this code.

* Source/WebCore/platform/graphics/AV1Utilities.cpp:
(WebCore::parseAV1CodecParameters):
* Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp:
(WebCore::av1CapsFromCodecString):
(WebCore::GStreamerCodecUtilities::capsFromCodecString):
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/277857@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9e5519: [GStreamer] Deadlock in webKitWebSrcCreate when ha...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e5519436f6b4b766fe205d2adacf6668033e9bb
  
https://github.com/WebKit/WebKit/commit/9e5519436f6b4b766fe205d2adacf6668033e9bb
  Author: Philippe Normand 
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Deadlock in webKitWebSrcCreate when handling non-flushing seeks
https://bugs.webkit.org/show_bug.cgi?id=272912

Reviewed by Xabier Rodriguez-Calvar.

When handling non-flushing seeks the GStreamer basesrc base class will pause 
the pad task instead of
sending a flush-start event, so in that situation the "unlock" vmethod is not 
called. In order to
prevent deadlocks, unlock the streaming thread before letting basesrc handle 
the non-flushing seek
event.

* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_class_init):
(webKitWebSrcEvent):

Canonical link: https://commits.webkit.org/277804@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 92f622: [CMake] copy-user-interface-resources.pl very slow...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92f622fab3091300db9c1798f2f1fb7ca1a8bd6b
  
https://github.com/WebKit/WebKit/commit/92f622fab3091300db9c1798f2f1fb7ca1a8bd6b
  Author: Philippe Normand 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M Source/WebInspectorUI/CMakeLists.txt

  Log Message:
  ---
  [CMake] copy-user-interface-resources.pl very slow on release developer builds
https://bugs.webkit.org/show_bug.cgi?id=273042

Reviewed by Michael Catanzaro.

Disable COMBINE_INSPECTOR_RESOURCES for developer builds.

Before:

Executed in   48.30 secsfish   external
   usr time   29.89 secs  304.00 micros   29.89 secs
   sys time   18.25 secs   67.00 micros   18.25 secs

After:

Executed in  378.19 millisfish   external
   usr time  233.63 millis  205.00 micros  233.42 millis
   sys time  142.31 millis   45.00 micros  142.26 millis

* Source/WebInspectorUI/CMakeLists.txt:

Canonical link: https://commits.webkit.org/277794@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 489e73: Cherry-pick 277599@main (99c088c4507f). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 489e73630675cf485feb02096cb04af13099c3b6
  
https://github.com/WebKit/WebKit/commit/489e73630675cf485feb02096cb04af13099c3b6
  Author: Philippe Normand 
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  ---
  Cherry-pick 277599@main (99c088c4507f). 
https://bugs.webkit.org/show_bug.cgi?id=272752

[GStreamer][MediaStream] gst_object_get_path_string() leaking in 
mediastreamsrc element
https://bugs.webkit.org/show_bug.cgi?id=272752

Reviewed by Xabier Rodriguez-Calvar.

Fix string leak webkitMediaStreamSrcAddPad().

* 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcAddPad):

Canonical link: https://commits.webkit.org/277599@main

Canonical link: https://commits.webkit.org/274313.147@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f92b4b: Cherry-pick 277657@main (ffd37b170425). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: f92b4b5d931be073c1ba4a0f372e9bfb24505ab8
  
https://github.com/WebKit/WebKit/commit/f92b4b5d931be073c1ba4a0f372e9bfb24505ab8
  Author: Philippe Normand 
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  ---
  Cherry-pick 277657@main (ffd37b170425). 
https://bugs.webkit.org/show_bug.cgi?id=272819

[GStreamer] Disable the gst-libav aac decoder
https://bugs.webkit.org/show_bug.cgi?id=272819

Reviewed by Xabier Rodriguez-Calvar.

Unconditionally disable the libav aac decoder, due to bad user experience. 
Distributors are advised
to recommend the FDK decoder instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):

Canonical link: https://commits.webkit.org/277657@main

Canonical link: https://commits.webkit.org/274313.146@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] de9ef4: Cherry-pick 277675@main (72ef47e183a4). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: de9ef49161937e724f9771da681e465714d41d6e
  
https://github.com/WebKit/WebKit/commit/de9ef49161937e724f9771da681e465714d41d6e
  Author: Philippe Normand 
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp

  Log Message:
  ---
  Cherry-pick 277675@main (72ef47e183a4). 
https://bugs.webkit.org/show_bug.cgi?id=272830

[WPE] Variable length array build warning
https://bugs.webkit.org/show_bug.cgi?id=272830

Reviewed by Michael Catanzaro.

Variable-length arrays (VLAs) are supported in C (since the C99 standard). 
But not in the C++
standard. This is an extension of some compilers.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp:
(WPE::DRM::Cursor::updateBuffer): Store the cursor pixels data in a Vector.
* Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp: Store the 
viewConfigurations in a Vector.

Canonical link: https://commits.webkit.org/277675@main

Canonical link: https://commits.webkit.org/274313.142@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0dd254: [GStreamer][WebRTC] Improvements in variable frame...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0dd2540f475d5c11b3e0ebc6537052a3803a85b0
  
https://github.com/WebKit/WebKit/commit/0dd2540f475d5c11b3e0ebc6537052a3803a85b0
  Author: Philippe Normand 
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp
M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebRTC] Improvements in variable framerate outgoing sources
https://bugs.webkit.org/show_bug.cgi?id=272811

Reviewed by Xabier Rodriguez-Calvar.

Set the max-framerate field on the caps of variable framerate sources, such as 
canvas. Then on
outgoing video sources the videorate element can be made mandatory. This patch 
also re-enables
aggregate-mode and config-interval on h264/h265 payloaders.

* Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas):
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toVideoFrame):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::setBufferFields):
(WebCore::VideoFrameGStreamer::createFromPixelBuffer):
(WebCore::VideoFrameGStreamer::setMaxFrameRate):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer):
(WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType):

Canonical link: https://commits.webkit.org/277730@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 72ef47: [WPE] Variable length array build warning

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72ef47e183a417a7e337b9b5b7d5ae448079f744
  
https://github.com/WebKit/WebKit/commit/72ef47e183a417a7e337b9b5b7d5ae448079f744
  Author: Philippe Normand 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp

  Log Message:
  ---
  [WPE] Variable length array build warning
https://bugs.webkit.org/show_bug.cgi?id=272830

Reviewed by Michael Catanzaro.

Variable-length arrays (VLAs) are supported in C (since the C99 standard). But 
not in the C++
standard. This is an extension of some compilers.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp:
(WPE::DRM::Cursor::updateBuffer): Store the cursor pixels data in a Vector.
* Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp: Store the 
viewConfigurations in a Vector.

Canonical link: https://commits.webkit.org/277675@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffd37b: [GStreamer] Disable the gst-libav aac decoder

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffd37b17042513ad1509a92196be383284feb353
  
https://github.com/WebKit/WebKit/commit/ffd37b17042513ad1509a92196be383284feb353
  Author: Philippe Normand 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp

  Log Message:
  ---
  [GStreamer] Disable the gst-libav aac decoder
https://bugs.webkit.org/show_bug.cgi?id=272819

Reviewed by Xabier Rodriguez-Calvar.

Unconditionally disable the libav aac decoder, due to bad user experience. 
Distributors are advised
to recommend the FDK decoder instead.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):

Canonical link: https://commits.webkit.org/277657@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc9bb0: [GStreamer][MSE] Dumps pipeline for each buffer pu...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc9bb027d4585b7be5d8d9ac1c12c59f2dfaee76
  
https://github.com/WebKit/WebKit/commit/bc9bb027d4585b7be5d8d9ac1c12c59f2dfaee76
  Author: Philippe Normand 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MSE] Dumps pipeline for each buffer pushed on msesrc pads
https://bugs.webkit.org/show_bug.cgi?id=272814

Reviewed by Alicia Boya Garcia.

Dump the pipeline only for the first buffer pushed on each pad. Doing that for 
every buffer has a
high CPU cost and doesn't seem very useful :)

* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcLoop):

Canonical link: https://commits.webkit.org/277638@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes