[webkit-changes] [WebKit/WebKit] b36cbc: Use smart pointers for members in CanvasCaptureMed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b36cbce69fddb7da33823f316bd8ead5bebee970 https://github.com/WebKit/WebKit/commit/b36cbce69fddb7da33823f316bd8ead5bebee970 Author: Rob Buis Date: 2024-07-25 (Thu, 25 Jul 2024) Changed paths: M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h Log Message: --- Use smart pointers for members in CanvasCaptureMediaStreamTrack https://bugs.webkit.org/show_bug.cgi?id=275246 Reviewed by Sihui Liu. Use smart pointers for members in CanvasCaptureMediaStreamTrack. * Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h: Canonical link: https://commits.webkit.org/281338@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b99281: Use smart pointers for members in StyleCanvasImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9928105e8ea59e01d2aa3f4348db76b82850f15 https://github.com/WebKit/WebKit/commit/b9928105e8ea59e01d2aa3f4348db76b82850f15 Author: Rob Buis Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M Source/WebCore/rendering/style/StyleCanvasImage.cpp M Source/WebCore/rendering/style/StyleCanvasImage.h Log Message: --- Use smart pointers for members in StyleCanvasImage https://bugs.webkit.org/show_bug.cgi?id=275200 Reviewed by Chris Dumez. Adopt more smart pointers based on the [alpha.webkit.NoUncountedMemberChecker] warning. * Source/WebCore/rendering/style/StyleCanvasImage.cpp: (WebCore::StyleCanvasImage::element const): * Source/WebCore/rendering/style/StyleCanvasImage.h: Canonical link: https://commits.webkit.org/281280@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d82719: Use more smart pointers for members
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d827195d613f685f3af939eeae5c779c27dee3ac https://github.com/WebKit/WebKit/commit/d827195d613f685f3af939eeae5c779c27dee3ac Author: Rob Buis Date: 2024-07-23 (Tue, 23 Jul 2024) Changed paths: M Source/WebCore/animation/KeyframeEffect.h M Source/WebCore/dom/Document.cpp M Source/WebCore/html/HTMLFrameOwnerElement.h M Source/WebCore/html/HTMLProgressElement.cpp M Source/WebCore/html/HTMLProgressElement.h M Source/WebCore/html/HTMLTrackElement.cpp M Source/WebCore/html/HTMLTrackElement.h M Source/WebCore/html/track/LoadableTextTrack.cpp M Source/WebCore/html/track/LoadableTextTrack.h M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/rendering/RenderView.h M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp M Source/WebCore/rendering/updating/RenderTreeUpdater.h M Source/WebCore/xml/parser/XMLDocumentParser.h M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Use more smart pointers for members https://bugs.webkit.org/show_bug.cgi?id=274252 Reviewed by Chris Dumez. Use more smart pointers for members to address [clang-analyzer-webkit.NoUncountedMemberChecker] warnings. * Source/WebCore/animation/KeyframeEffect.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::createParser): * Source/WebCore/html/HTMLFrameOwnerElement.h: (WebCore::SubframeLoadingDisabler::SubframeLoadingDisabler): (WebCore::SubframeLoadingDisabler::~SubframeLoadingDisabler): * Source/WebCore/html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): * Source/WebCore/html/HTMLProgressElement.h: * Source/WebCore/html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::~HTMLTrackElement): (WebCore::HTMLTrackElement::track): * Source/WebCore/html/HTMLTrackElement.h: * Source/WebCore/html/track/LoadableTextTrack.cpp: (WebCore::LoadableTextTrack::LoadableTextTrack): (WebCore::LoadableTextTrack::trackElementIndex): * Source/WebCore/html/track/LoadableTextTrack.h: * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::patchDocument): * Source/WebCore/rendering/RenderView.h: * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::commit): (WebCore::RenderTreeUpdater::updateElementRenderer): (WebCore::RenderTreeUpdater::createRenderer): (WebCore::RenderTreeUpdater::createTextRenderer): (WebCore::RenderTreeUpdater::updateRenderViewStyle): (WebCore::RenderTreeUpdater::renderView): * Source/WebCore/rendering/updating/RenderTreeUpdater.h: * Source/WebCore/xml/parser/XMLDocumentParser.h: * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::endElementNs): Canonical link: https://commits.webkit.org/281261@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b838f8: Adopt more smart pointers in LocalDOMWindow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b838f8bb3573bd5906bc5f02fcc8cb274b3c9b8a https://github.com/WebKit/WebKit/commit/b838f8bb3573bd5906bc5f02fcc8cb274b3c9b8a Author: Rob Buis Date: 2024-07-23 (Tue, 23 Jul 2024) Changed paths: M Source/WebCore/page/LocalDOMWindow.cpp Log Message: --- Adopt more smart pointers in LocalDOMWindow https://bugs.webkit.org/show_bug.cgi?id=273393 Reviewed by Chris Dumez. Adopt more smart pointers in LocalDOMWindow based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::allowsBeforeUnloadListeners): (WebCore::LocalDOMWindow::allowPopUp): (WebCore::LocalDOMWindow::isCurrentlyDisplayedInFrame const): (WebCore::LocalDOMWindow::collectMatchingElementsInFlatTree): (WebCore::LocalDOMWindow::matchingElementInFlatTree): (WebCore::LocalDOMWindow::closePage): (WebCore::LocalDOMWindow::origin const): (WebCore::LocalDOMWindow::securityOrigin const): Canonical link: https://commits.webkit.org/281244@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43764d: Use smart pointers to access NavigationScheduler
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43764db17fb88fbd41265fa0b51905ffe9959829 https://github.com/WebKit/WebKit/commit/43764db17fb88fbd41265fa0b51905ffe9959829 Author: Rob Buis Date: 2024-07-23 (Tue, 23 Jul 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/html/parser/HTMLDocumentParser.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/page/History.cpp M Source/WebCore/page/RemoteDOMWindow.cpp Log Message: --- Use smart pointers to access NavigationScheduler https://bugs.webkit.org/show_bug.cgi?id=276880 Reviewed by Chris Dumez. Use smart pointers to access NavigationScheduler based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitClose): (WebCore::Document::navigateFromServiceWorker): * Source/WebCore/html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizerLoop): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): * Source/WebCore/page/Frame.h: (WebCore::Frame::navigationScheduler const): Deleted. * Source/WebCore/page/History.cpp: (WebCore::History::go): * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::setLocation): Canonical link: https://commits.webkit.org/281239@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 115aae: Use smart pointer when accessing CachedResourceLoa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 115aae15a98b284596444de1513377e15f7a4aad https://github.com/WebKit/WebKit/commit/115aae15a98b284596444de1513377e15f7a4aad Author: Rob Buis Date: 2024-07-23 (Tue, 23 Jul 2024) Changed paths: M Source/WebCore/Modules/mediasession/MediaMetadata.cpp M Source/WebCore/Modules/model-element/HTMLModelElement.cpp M Source/WebCore/css/StyleRuleImport.cpp M Source/WebCore/loader/ImageLoader.cpp M Source/WebCore/loader/icon/IconLoader.cpp M Source/WebCore/svg/SVGFEImageElement.cpp Log Message: --- Use smart pointer when accessing CachedResourceLoader request methods https://bugs.webkit.org/show_bug.cgi?id=276816 Reviewed by Chris Dumez. Use smart pointer when accessing CachedResourceLoader request methods based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/Modules/mediasession/MediaMetadata.cpp: (WebCore::ArtworkImageLoader::requestImageResource): * Source/WebCore/Modules/model-element/HTMLModelElement.cpp: (WebCore::HTMLModelElement::setSourceURL): * Source/WebCore/css/StyleRuleImport.cpp: (WebCore::StyleRuleImport::requestStyleSheet): * Source/WebCore/loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): * Source/WebCore/loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): * Source/WebCore/svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): Canonical link: https://commits.webkit.org/281233@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75ba0c: Use smart pointers when accessing CSSFontSelector
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75ba0c46a4b93f5162d2c4f21efebcdd1e333110 https://github.com/WebKit/WebKit/commit/75ba0c46a4b93f5162d2c4f21efebcdd1e333110 Author: Rob Buis Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/style/RuleSetBuilder.cpp M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleScope.cpp Log Message: --- Use smart pointers when accessing CSSFontSelector https://bugs.webkit.org/show_bug.cgi?id=276887 Reviewed by Ryosuke Niwa. Use smart pointers when accessing CSSFontSelector based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/dom/Document.cpp: (WebCore::Document::fonts): * Source/WebCore/style/RuleSetBuilder.cpp: (WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver): * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::initialize): * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::createDocumentResolver): Canonical link: https://commits.webkit.org/281201@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a586b: Use smart pointers to access SecurityOrigin::canRe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a586b49cf35fb6445e1a49d6e8deee6d1f83cc3 https://github.com/WebKit/WebKit/commit/5a586b49cf35fb6445e1a49d6e8deee6d1f83cc3 Author: Rob Buis Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M Source/WebCore/Modules/fetch/FetchRequest.cpp M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/dom/ScriptExecutionContext.cpp M Source/WebCore/loader/CookieJar.cpp M Source/WebCore/loader/CrossOriginAccessControl.cpp M Source/WebCore/loader/DocumentThreadableLoader.cpp M Source/WebCore/loader/NavigationAction.cpp M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/workers/AbstractWorker.cpp M Source/WebCore/workers/shared/SharedWorker.cpp M Source/WebCore/xml/XSLTProcessorLibxslt.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Log Message: --- Use smart pointers to access SecurityOrigin::canRequest https://bugs.webkit.org/show_bug.cgi?id=276713 Reviewed by Chris Dumez. Use smart pointers to access SecurityOrigin::canRequest as indicated by [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/Modules/fetch/FetchRequest.cpp: (WebCore::computeReferrer): * Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::wouldTaintOrigin const): * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::canAccessRules const): * Source/WebCore/css/parser/CSSParserContext.cpp: * Source/WebCore/dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::canIncludeErrorDetails): * Source/WebCore/loader/CrossOriginAccessControl.cpp: (WebCore::createPotentialAccessControlRequest): * Source/WebCore/loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): * Source/WebCore/loader/NavigationAction.cpp: (WebCore::shouldTreatAsSameOriginNavigation): * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const): (WebCore::ResourceLoader::isAllowedToAskUserForCredentials const): * Source/WebCore/workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): * Source/WebCore/workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::create): * Source/WebCore/xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::shouldAllowExternalLoad): Canonical link: https://commits.webkit.org/281198@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7cc874: Use smart pointer when accessing UserContentProvid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cc8740e9a532c7bc8be8fed91600e6d34463a49 https://github.com/WebKit/WebKit/commit/7cc8740e9a532c7bc8be8fed91600e6d34463a49 Author: Rob Buis Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp M Source/WebCore/css/StyleSheetContents.cpp M Source/WebCore/dom/ExtensionStyleSheets.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/page/UserMessageHandlersNamespace.cpp Log Message: --- Use smart pointer when accessing UserContentProvider.processContentRuleListsForLoad https://bugs.webkit.org/show_bug.cgi?id=276812 Reviewed by Chris Dumez. Use smart pointer when accessing UserContentProvider.processContentRuleListsForLoad based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp: (WebCore::ThreadableWebSocketChannel::validateURL): * Source/WebCore/css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::subresourcesAllowReuse const): * Source/WebCore/dom/ExtensionStyleSheets.cpp: (WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::handleSubstituteDataLoadNow): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): * Source/WebCore/page/UserMessageHandlersNamespace.cpp: (WebCore::UserMessageHandlersNamespace::namedItem): Canonical link: https://commits.webkit.org/281193@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 119c3f: [Navigation] Fix navigate-event/navigate-history-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 119c3f505360a74d63d6747fd6167c8af7d416ff https://github.com/WebKit/WebKit/commit/119c3f505360a74d63d6747fd6167c8af7d416ff Author: Rob Buis Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/loader/NavigationScheduler.cpp M Source/WebCore/page/History.cpp M Source/WebCore/page/History.h Log Message: --- [Navigation] Fix navigate-event/navigate-history-go-0.html https://bugs.webkit.org/show_bug.cgi?id=276863 Reviewed by Darin Adler. Fix navigate-history-go-0.html by adding a new state to NavigationHistoryBehavior to identify reloads so the determined navigation type will be "reload". This is needed because go(0) is not identified as a traditional reload by FrameLoader. This PR also corrects an unaddressed review comment from 281135@main and replaces StateObjectType with NavigationHistoryBehavior. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::determineNavigationType): (WebCore::FrameLoader::loadURL): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/FrameLoaderTypes.h: * Source/WebCore/loader/NavigationScheduler.cpp: * Source/WebCore/page/History.cpp: (WebCore::History::stateObjectAdded): * Source/WebCore/page/History.h: (WebCore::History::pushState): (WebCore::History::replaceState): Canonical link: https://commits.webkit.org/281182@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6cb4f7: Use smart pointers to access SecurityOrigin::isSam...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6cb4f73384a6a1d127187d0be3585c4622f54c5b https://github.com/WebKit/WebKit/commit/6cb4f73384a6a1d127187d0be3585c4622f54c5b Author: Rob Buis Date: 2024-07-19 (Fri, 19 Jul 2024) Changed paths: M Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/html/HTMLPlugInImageElement.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentWriter.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/LinkLoader.cpp M Source/WebCore/page/IntersectionObserver.cpp M Source/WebCore/rendering/RenderWidget.cpp Log Message: --- Use smart pointers to access SecurityOrigin::isSameOriginDomain https://bugs.webkit.org/show_bug.cgi?id=276654 Reviewed by Sihui Liu. Use smart pointers to access SecurityOrigin::isSameOriginDomain as indicated by [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp: (WebCore::canAccessDocument): * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::deriveShadowRealmGlobalObject): * Source/WebCore/bindings/js/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin): * Source/WebCore/dom/Document.cpp: (WebCore::Document::supportsPaintTiming const): (WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking): (WebCore::Document::initContentSecurityPolicy): * Source/WebCore/html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::canLoadURL const): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::shouldUseActiveServiceWorkerFromParent): * Source/WebCore/loader/DocumentWriter.cpp: (WebCore::canReferToParentFrameEncoding): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchBeforeUnloadEvent): * Source/WebCore/loader/LinkLoader.cpp: (WebCore::LinkLoader::preconnectIfNeeded): * Source/WebCore/page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::updateObservations): * Source/WebCore/rendering/RenderWidget.cpp: (WebCore::RenderWidget::paintContents): Canonical link: https://commits.webkit.org/281142@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 804792: [Navigation] Implement history handling steps from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8047924d30e0f6ec3785d815be4737f1ad0bcdf2 https://github.com/WebKit/WebKit/commit/8047924d30e0f6ec3785d815be4737f1ad0bcdf2 Author: Rob Buis Date: 2024-07-19 (Fri, 19 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-navigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt M Source/WebCore/loader/FrameLoader.cpp Log Message: --- [Navigation] Implement history handling steps from the navigate algorithm https://bugs.webkit.org/show_bug.cgi?id=276785 Reviewed by Darin Adler. Implement history handling steps from the navigate algorithm [1]. [1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate (Steps 11, 12) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-navigate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::loadURL): Canonical link: https://commits.webkit.org/281135@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44777c: [LBSE] Correct visual overflow computation for fil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44777cb431bb83660de805b629a1a3d589a95b0a https://github.com/WebKit/WebKit/commit/44777cb431bb83660de805b629a1a3d589a95b0a Author: Rob Buis Date: 2024-07-16 (Tue, 16 Jul 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-tile-01-b-manual-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-tile-01-b-manual-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/filter-empty-g-expected.txt M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.h Log Message: --- [LBSE] Correct visual overflow computation for filters on g https://bugs.webkit.org/show_bug.cgi?id=276038 Reviewed by Nikolas Zimmermann. Correct visual overflow computation for filters on g by adding a new option to SVGBoundingBoxComputation::DecorationOption to calculate the filter effect for otherwise empty geometries. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-tile-01-b-manual-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-tile-01-b-manual-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/types-dom-01-b-manual-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/filter-empty-g-expected.txt: * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::adjustBoxForClippingAndEffects const): (WebCore::SVGBoundingBoxComputation::computeVisualOverflowRect): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.h: (WebCore::SVGBoundingBoxComputation::computeVisualOverflowRect): Deleted. Canonical link: https://commits.webkit.org/281016@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 76dad9: Adopt more pointers in ApplicationCacheGroup.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76dad98cefe8535b56570d1a48af52b7610eb25f https://github.com/WebKit/WebKit/commit/76dad98cefe8535b56570d1a48af52b7610eb25f Author: Rob Buis Date: 2024-07-13 (Sat, 13 Jul 2024) Changed paths: M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp Log Message: --- Adopt more pointers in ApplicationCacheGroup.cpp https://bugs.webkit.org/show_bug.cgi?id=276491 Reviewed by Sihui Liu. Adopt smart pointers for ApplicationCacheGroup.cpp based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::abort): (WebCore::ApplicationCacheGroup::didFinishLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingEntry): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::didFailLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Canonical link: https://commits.webkit.org/280939@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b59ab: Adopt more pointers in CachedResourceLoader.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b59abd114c3c74728bbc67c76c1295d38c5b208 https://github.com/WebKit/WebKit/commit/7b59abd114c3c74728bbc67c76c1295d38c5b208 Author: Rob Buis Date: 2024-07-12 (Fri, 12 Jul 2024) Changed paths: M Source/WebCore/loader/cache/CachedResourceLoader.cpp Log Message: --- Adopt more pointers in CachedResourceLoader.cpp https://bugs.webkit.org/show_bug.cgi?id=276534 Reviewed by Chris Dumez. Adopt smart pointers for CachedResourceLoader.cpp based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::checkInsecureContent const): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::canRequestAfterRedirection const): (WebCore::CachedResourceLoader::canRequestInContentDispositionAttachmentSandbox const): (WebCore::CachedResourceLoader::updateHTTPRequestHeaders): (WebCore::CachedResourceLoader::printAccessDeniedMessage const): Canonical link: https://commits.webkit.org/280908@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3209fe: [Navigation] Throw exceptions when unloading
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3209febcce786a323163ed4c5a67c96057507e1e https://github.com/WebKit/WebKit/commit/3209febcce786a323163ed4c5a67c96057507e1e Author: Rob Buis Date: 2024-07-12 (Fri, 12 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-pagehide-expected.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h R Source/WebCore/dom/IgnoreOpensDuringUnloadCountIncrementer.h A Source/WebCore/dom/UnloadCountIncrementer.h M Source/WebCore/history/BackForwardCache.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Throw exceptions when unloading https://bugs.webkit.org/show_bug.cgi?id=276176 Reviewed by Alex Christensen. Throw exceptions when unloading as specified for multiple methods [1, 2, 3]. This PR also renames m_ignoreOpensDuringUnloadCount to better reflect the specification [4] [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate [2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-reload [3] https://html.spec.whatwg.org/multipage/nav-history-apis.html#performing-a-navigation-api-traversal [4] https://html.spec.whatwg.org/multipage/document-lifecycle.html#unload-counter * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-pagehide-expected.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::write): * Source/WebCore/dom/Document.h: (WebCore::Document::unloadCounter const): * Source/WebCore/dom/UnloadCountIncrementer.h: Renamed from Source/WebCore/dom/IgnoreOpensDuringUnloadCountIncrementer.h. (WebCore::UnloadCountIncrementer::UnloadCountIncrementer): (WebCore::UnloadCountIncrementer::~UnloadCountIncrementer): * Source/WebCore/history/BackForwardCache.cpp: (WebCore::firePageHideEventRecursively): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::shouldClose): (WebCore::FrameLoader::dispatchUnloadEvents): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::reload): (WebCore::Navigation::navigate): (WebCore::Navigation::performTraversal): Canonical link: https://commits.webkit.org/280898@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a37ba2: Adopt more smart pointers in loading
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a37ba25938493f786b6241403547d8c805ba4e71 https://github.com/WebKit/WebKit/commit/a37ba25938493f786b6241403547d8c805ba4e71 Author: Rob Buis Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/ResourceLoadNotifier.cpp M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp Log Message: --- Adopt more smart pointers in loading https://bugs.webkit.org/show_bug.cgi?id=276363 Reviewed by Chris Dumez. Adopt more smart pointers in loading involving DocumentLoader accessing. This PR also fixes a few places where DocumentLoader was accessed unnecessarily. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::loadDifferentDocumentItem): * Source/WebCore/loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingManifest): (WebCore::ApplicationCacheGroup::startLoadingEntry): * Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Canonical link: https://commits.webkit.org/280820@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 487628: [Navigation] Implement NavigationDestination.getState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4876281cfad6c0e881c669a99b48e564b7234f3e https://github.com/WebKit/WebKit/commit/4876281cfad6c0e881c669a99b48e564b7234f3e Author: Rob Buis Date: 2024-07-10 (Wed, 10 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/NavigationDestination.cpp M Source/WebCore/page/NavigationDestination.h M Source/WebCore/page/NavigationDestination.idl Log Message: --- [Navigation] Implement NavigationDestination.getState https://bugs.webkit.org/show_bug.cgi?id=276320 Reviewed by Alex Christensen. Implement NavigationDestination.getState functionality [1]. Note that state is not set yet in the traversal case and although it improves behaviour, it is obscured by an unrelated problem that makes those tests fail before getState is called. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-getstate * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent): * Source/WebCore/page/NavigationDestination.cpp: (WebCore::NavigationDestination::getState const): * Source/WebCore/page/NavigationDestination.h: * Source/WebCore/page/NavigationDestination.idl: Canonical link: https://commits.webkit.org/280809@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7b3da: Adopt smart pointers for HistoryController
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7b3da8d3c2032ab1e99bec4a5c2a70f80cc2c4d https://github.com/WebKit/WebKit/commit/b7b3da8d3c2032ab1e99bec4a5c2a70f80cc2c4d Author: Rob Buis Date: 2024-07-09 (Tue, 09 Jul 2024) Changed paths: M Source/WebCore/loader/HistoryController.cpp Log Message: --- Adopt smart pointers for HistoryController https://bugs.webkit.org/show_bug.cgi?id=276067 Reviewed by Chris Dumez. Adopt smart pointers for HistoryController based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::recursiveUpdateForCommit): (WebCore::HistoryController::updateBackForwardListClippedAtTarget): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState): Canonical link: https://commits.webkit.org/280767@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 087cca: Adopt more smart pointers addressing UncountedLoca...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 087ccacd8055a28188d1b4e372e7e183bed4b4f2 https://github.com/WebKit/WebKit/commit/087ccacd8055a28188d1b4e372e7e183bed4b4f2 Author: Rob Buis Date: 2024-07-08 (Mon, 08 Jul 2024) Changed paths: M Source/WebCore/loader/SubresourceIntegrity.cpp M Source/WebCore/loader/cocoa/BundleResourceLoader.mm M Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp M Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp M Source/WebCore/platform/network/BlobRegistryImpl.cpp M Source/WebCore/platform/network/DataURLDecoder.cpp M Source/WebCore/rendering/style/ShapeValue.cpp Log Message: --- Adopt more smart pointers addressing UncountedLocalVarsChecker warning https://bugs.webkit.org/show_bug.cgi?id=275614 Reviewed by Chris Dumez. Adopt more smart pointers addressing the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/loader/SubresourceIntegrity.cpp: (WebCore::integrityMismatchDescription): * Source/WebCore/loader/cocoa/BundleResourceLoader.mm: (WebCore::BundleResourceLoader::loadQueue): * Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp: (WebCore::DisplayRefreshMonitorManager::clientPreferredFramesPerSecondChanged): (WebCore::DisplayRefreshMonitorManager::scheduleAnimation): (WebCore::DisplayRefreshMonitorManager::nominalFramesPerSecondForDisplay): (WebCore::DisplayRefreshMonitorManager::displayDidRefresh): (WebCore::DisplayRefreshMonitorManager::monitorForClient): * Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp: (WebCore::AudioTrackPrivateMediaStream::createRenderer): * Source/WebCore/platform/network/BlobRegistryImpl.cpp: (WebCore::blobUtilityQueue): * Source/WebCore/platform/network/DataURLDecoder.cpp: (WebCore::DataURLDecoder::decodeQueue): * Source/WebCore/rendering/style/ShapeValue.cpp: (WebCore::ShapeValue::canBlend const): Canonical link: https://commits.webkit.org/280747@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ad8ab: Allow calling intercept handlers multiple times
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ad8ab8a4392f3a20fa0a2981f08a1d63787936a https://github.com/WebKit/WebKit/commit/6ad8ab8a4392f3a20fa0a2981f08a1d63787936a Author: Rob Buis Date: 2024-07-06 (Sat, 06 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-multiple-expected.txt M Source/WebCore/page/NavigationInterceptHandler.idl Log Message: --- Allow calling intercept handlers multiple times https://bugs.webkit.org/show_bug.cgi?id=276246 Reviewed by Alex Christensen. Allow calling intercept handlers multiple times, even on disconnected iframes, by skipping the callback invoke check. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-multiple-expected.txt: * Source/WebCore/page/NavigationInterceptHandler.idl: Canonical link: https://commits.webkit.org/280715@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] adedad: Remove unneeded functions in RenderTreeAsText.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: adedad6c3074b5cdf0b97cc3db38d488531fbc06 https://github.com/WebKit/WebKit/commit/adedad6c3074b5cdf0b97cc3db38d488531fbc06 Author: Rob Buis Date: 2024-07-04 (Thu, 04 Jul 2024) Changed paths: M Source/WebCore/rendering/RenderTreeAsText.cpp Log Message: --- Remove unneeded functions in RenderTreeAsText.cpp https://bugs.webkit.org/show_bug.cgi?id=276231 Reviewed by Alan Baradlay. Remove functions in RenderTreeAsText.cpp that are not used anymore after 275888@main. * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::isRenderInlineEmpty): Deleted. (WebCore::hasNonEmptySibling): Deleted. Canonical link: https://commits.webkit.org/280671@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e08a72: [Navigation] Detect early error in Navigation.navi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e08a72c3d292c1ef4fd66f9c2efb96581ec7ca87 https://github.com/WebKit/WebKit/commit/e08a72c3d292c1ef4fd66f9c2efb96581ec7ca87 Author: Rob Buis Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-204-205-download-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-file-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-pagehide-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-pagehide-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-double-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-event-order-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Detect early error in Navigation.navigate https://bugs.webkit.org/show_bug.cgi?id=276129 Reviewed by Alex Christensen. Detect early error in Navigation.navigate for the case the navigate event was not dispatched [1]. This PR also removes the code for dispatching navigate events in FrameLoader::loadWithDocumentLoader, because since r280526 this is handled by FrameLoader::loadURL, and in fact we could end up with multiple navigate events being dispatched. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate (Step 12.2) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-204-205-download-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-file-url-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-pagehide-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-pagehide-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-pagehide-unserializablestate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-double-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-event-order-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::navigate): Canonical link: https://commits.webkit.org/280616@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92b5dd: [Navigation] Abort ongoing navigation on window.st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92b5ddfd057326297847ab105fe65e50437ad65b https://github.com/WebKit/WebKit/commit/92b5ddfd057326297847ab105fe65e50437ad65b Author: Rob Buis Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-detach-in-onnavigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-in-onnavigate-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Abort ongoing navigation on window.stop() https://bugs.webkit.org/show_bug.cgi?id=275659 Reviewed by Darin Adler and Alex Christensen. Implement the "inform the navigation API about aborting navigation" alogithm [1] and call it as part of the "stop loading" algorithm [2]. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#inform-the-navigation-api-about-aborting-navigation [2] https://html.spec.whatwg.org/multipage/document-lifecycle.html#nav-stop * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-detach-in-onnavigate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-in-onnavigate-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::abortOngoingNavigationIfNeeded): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/280526@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 682326: Make Navigation::navigate use FrameLoader::loadFra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 682326372f421011e6b82ee585efb1e95dd8facf https://github.com/WebKit/WebKit/commit/682326372f421011e6b82ee585efb1e95dd8facf Author: Rob Buis Date: 2024-06-28 (Fri, 28 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/defaultPrevented-window-stop-after-dispatch-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-same-document-history-back-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-dynamic-index-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-intercept-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-preventDefault-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-after-intercept-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-in-onnavigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/index-not-in-entries-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/state-after-navigate-restore-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-history-push-same-url-cross-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-history-push-same-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-same-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-204-205-download-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-detach-in-onnavigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-file-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-pagehide-expected.txt R LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-unload-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-pagehide-unserializablestate-expected.txt R LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-unload-unserializablestate-expected.txt R LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unload-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/currententrychange-dispose-ordering-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-double-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/navigate-cross-document-event-order-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/cross-document-location-api-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/location-reload-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- Make Navigation::navigate use FrameLoader::loadFrameRequest https://bugs.webkit.org/show_bug.cgi?id=275954 Reviewed by Alex Christensen. Make Navigation::navigate use FrameLoader::loadFrameRequest, this has at least two benefits: - this code path does extra checks like whether we are allowed to load a local resource (file:///) - using load had the downside of not using NavigationAction, so there was no way the check in loadWithDocumentLoader could decide to send the navigate event (in the case of non-fragment navigations). * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/defaultPrevented
[webkit-changes] [WebKit/WebKit] 5a5392: [Navigation] Support "initial about:blank document...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a53929d85a19d356f2d0c0b40a13e84165db281 https://github.com/WebKit/WebKit/commit/5a53929d85a19d356f2d0c0b40a13e84165db281 Author: Rob Buis Date: 2024-06-26 (Wed, 26 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-popup-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/exception-order-initial-about-blank-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/initial-about-blank-expected.txt M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentLoader.h M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Support "initial about:blank document" logic https://bugs.webkit.org/show_bug.cgi?id=274393 Reviewed by Darin Adler. Keep track of the "initial about:blank document" flag and check it in the "has entries and events disabled" algorithm. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#has-entries-and-events-disabled (Step 3) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigate-from-initial-about-blank-same-doc-popup-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/exception-order-initial-about-blank-unserializablestate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/initial-about-blank-expected.txt: * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::maybeLoadEmpty): * Source/WebCore/loader/DocumentLoader.h: (WebCore::DocumentLoader::isInitialAboutBlank const): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::hasEntriesAndEventsDisabled const): Canonical link: https://commits.webkit.org/280378@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be3ab1: Gardening - update LBSE expectations now filter su...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be3ab121b14a9074bdc6031125646c295fe7d1f4 https://github.com/WebKit/WebKit/commit/be3ab121b14a9074bdc6031125646c295fe7d1f4 Author: Rob Buis Date: 2024-06-26 (Wed, 26 Jun 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-example-01-b-manual-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-image-01-b-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Discrete-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Gamma-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Linear-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Table-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/image-with-transform-clip-filter-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/subRegion-one-effect-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/subRegion-two-effects-expected.png Log Message: --- Gardening - update LBSE expectations now filter support landed https://bugs.webkit.org/show_bug.cgi?id=275853 Reviewed by Nikolas Zimmermann. Update LBSE expectations now filter support landed, many filter expectations need to be marked as flaky and also add some comments relating tests to reported bugs. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-example-01-b-manual-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Discrete-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Gamma-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Linear-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/feComponentTransfer-Table-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/image-with-transform-clip-filter-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/subRegion-one-effect-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/filters/subRegion-two-effects-expected.png: Added. Canonical link: https://commits.webkit.org/280366@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0eb86e: [LBSE] Fix dynamic updating of lighting-color/floo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0eb86e157166d4f1bd0740f78b445747d02877e6 https://github.com/WebKit/WebKit/commit/0eb86e157166d4f1bd0740f78b445747d02877e6 Author: Rob Buis Date: 2024-06-25 (Tue, 25 Jun 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp M Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h Log Message: --- [LBSE] Fix dynamic updating of lighting-color/flood-color/flood-opacity https://bugs.webkit.org/show_bug.cgi?id=275824 Reviewed by Nikolas Zimmermann and Said Abou-Hallawa. Fix dynamic updating of lighting-color/flood-color/flood-opacity in the same way as legacy. In particular: - flood-color/flood-opacity style changes for feFlood and feDropShadow - lighting-color style changes for feDiffuseLighting and feSpecularLighting. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp: (WebCore::RenderSVGResourceFilterPrimitive::filterPrimitiveElement const): (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h: Canonical link: https://commits.webkit.org/280328@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ae255: Adopt smart pointers for Document::existingAXObjec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ae25587c9d6940e177f17fcb2ab846d50653a30 https://github.com/WebKit/WebKit/commit/7ae25587c9d6940e177f17fcb2ab846d50653a30 Author: Rob Buis Date: 2024-06-24 (Mon, 24 Jun 2024) Changed paths: M Source/WebCore/accessibility/AXImage.cpp M Source/WebCore/dom/Node.cpp M Source/WebCore/editing/Editing.cpp M Source/WebCore/html/ColorInputType.cpp M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLOptionElement.cpp M Source/WebCore/html/HTMLProgressElement.cpp M Source/WebCore/html/HTMLTextAreaElement.cpp M Source/WebCore/html/InputType.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/page/FocusController.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderMenuList.cpp M Source/WebCore/rendering/RenderWidget.cpp Log Message: --- Adopt smart pointers for Document::existingAXObjectCache https://bugs.webkit.org/show_bug.cgi?id=275804 Reviewed by Chris Dumez. Adopt smart pointers for Document::existingAXObjectCache usage, most AXObjectCache are not trivial and so far some locations have been adapted to use a smart pointer, this PR should cover all remaining callers of existingAXObjectCache. Based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/accessibility/AXImage.cpp: (WebCore::AXImage::imageOverlayElements): * Source/WebCore/dom/Node.cpp: (WebCore::Node::removedFromAncestor): (WebCore::Node::moveNodeToNewDocumentSlowCase): * Source/WebCore/editing/Editing.cpp: (WebCore::isEditableToAccessibility): (WebCore::editableRootForPosition): * Source/WebCore/html/ColorInputType.cpp: (WebCore::ColorInputType::attributeChanged): (WebCore::ColorInputType::didChooseColor): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): (WebCore::HTMLInputElement::setAutoFilledAndObscured): (WebCore::HTMLInputElement::setShowAutoFillButton): * Source/WebCore/html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): * Source/WebCore/html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::didElementStateChange): * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValueCommon): * Source/WebCore/html/InputType.cpp: (WebCore::InputType::applyStep): * Source/WebCore/html/ValidatedFormListedElement.cpp: (WebCore::ValidatedFormListedElement::updateValidity): * Source/WebCore/page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::didLayout): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutModernLines): * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::didAttachChild): (RenderMenuList::didUpdateActiveOption): * Source/WebCore/rendering/RenderWidget.cpp: (WebCore::RenderWidget::willBeDestroyed): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::styleDidChange): Canonical link: https://commits.webkit.org/280308@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b8bf2f: [Navigation] Remove ASSERT added in r280167
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b8bf2f7cf2baf3c29cddc44427915994e8b82ee2 https://github.com/WebKit/WebKit/commit/b8bf2f7cf2baf3c29cddc44427915994e8b82ee2 Author: Rob Buis Date: 2024-06-24 (Mon, 24 Jun 2024) Changed paths: M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Remove ASSERT added in r280167 https://bugs.webkit.org/show_bug.cgi?id=275737 Reviewed by Darin Adler. In r280167 the behaviour change was implemented to use the ongoing promise information as a fallback to determine the script execution context, since the script execution context may be gone in detached state. However, tests such as navigate-event/intercept-detach.html show that there is no guarantee that there is any ongoing promise at all, so remove the ASSERT and just return early in that case. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::abortOngoingNavigation): Canonical link: https://commits.webkit.org/280305@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 636b19: [LBSE] Adopt more smart pointers in SVG code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 636b19890dbccb5e6a2a33ac411659fa1f6d65ae https://github.com/WebKit/WebKit/commit/636b19890dbccb5e6a2a33ac411659fa1f6d65ae Author: Rob Buis Date: 2024-06-21 (Fri, 21 Jun 2024) Changed paths: M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceClipper.h M Source/WebCore/rendering/svg/RenderSVGResourceClipperInlines.h M Source/WebCore/rendering/svg/RenderSVGResourceMarker.h M Source/WebCore/rendering/svg/RenderSVGResourceMarkerInlines.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/rendering/svg/RenderSVGResourceMaskerInlines.h Log Message: --- [LBSE] Adopt more smart pointers in SVG code https://bugs.webkit.org/show_bug.cgi?id=275689 Reviewed by Alex Christensen. Based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paintForeground): (WebCore::RenderSVGImage::updateImageViewport): (WebCore::RenderSVGImage::bufferForeground): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::shouldApplyPathClipping const): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/RenderSVGResourceClipperInlines.h: (WebCore::RenderSVGResourceClipper::protectedClipPathElement const): (WebCore::RenderSVGResourceClipper::clipPathUnits const): (WebCore::RenderSVGResourceClipper::clipPathElement const): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourceMarker.h: * Source/WebCore/rendering/svg/RenderSVGResourceMarkerInlines.h: (WebCore::RenderSVGResourceMarker::protectedMarkerElement const): (WebCore::RenderSVGResourceMarker::angle const): (WebCore::RenderSVGResourceMarker::markerUnits const): (WebCore::RenderSVGResourceMarker::hasReverseStart const): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoContext): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/rendering/svg/RenderSVGResourceMaskerInlines.h: (WebCore::RenderSVGResourceMasker::protectedMaskElement const): (WebCore::RenderSVGResourceMasker::maskUnits const): (WebCore::RenderSVGResourceMasker::maskContentUnits const): Canonical link: https://commits.webkit.org/280244@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a5ede: Reject SharedArrayBuffer serialization when forSto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a5ede6d46809b13b5c8aca1230990b26d3d20c8 https://github.com/WebKit/WebKit/commit/1a5ede6d46809b13b5c8aca1230990b26d3d20c8 Author: Rob Buis Date: 2024-06-20 (Thu, 20 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unserializable-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-unserializable-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/unserializable-expected.txt M Source/WebCore/bindings/js/SerializedScriptValue.cpp Log Message: --- Reject SharedArrayBuffer serialization when forStorage is true https://bugs.webkit.org/show_bug.cgi?id=248331 rdar://102656648 Reviewed by Yusuke Suzuki. When serializing SharedArrayBuffers, throw DataCloneError if forStorage is true. [1] [1] https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializeinternal (Step 12.1.2) * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unserializable-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-unserializable-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/unserializable-expected.txt: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): Canonical link: https://commits.webkit.org/280194@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bbe66: Gardening - regenerate LBSE baselines
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bbe66844f4ebe0ba8c29c9109a16a5b69bdc29e https://github.com/WebKit/WebKit/commit/3bbe66844f4ebe0ba8c29c9109a16a5b69bdc29e Author: Rob Buis Date: 2024-06-19 (Wed, 19 Jun 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/animate-pservers-grad-01-b-manual-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-cursor-01-f-manual-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-002-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-expected.png R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-001-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-001-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-002-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/paint-order-001-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/percentage-attribute-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/painting/reftests/percentage-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-expected.txt R LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/path/property/priority-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/coords-units-01-b-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/batik/text/xmlSpace-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/focus-event-handling-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/text/scaling-font-with-geometric-precision-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/zoom/page/zoom-mask-with-percentages-expected.txt R LayoutTests/platform
[webkit-changes] [WebKit/WebKit] 344c9a: [Navigation] Abort ongoing navigation correctly wh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 344c9a838c7845d49b57c311662a0924a0101927 https://github.com/WebKit/WebKit/commit/344c9a838c7845d49b57c311662a0924a0101927 Author: Rob Buis Date: 2024-06-19 (Wed, 19 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-detach-same-document-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Abort ongoing navigation correctly when in detached state https://bugs.webkit.org/show_bug.cgi?id=275496 Reviewed by Alex Christensen. When dispaching the navigate event the frame may be detached and there is no script execution context left. In that case, fall back to the script execution context the JS promise is created in. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-detach-same-document-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::abortOngoingNavigation): (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/280167@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aaea02: Adopt more smart pointers addressing UncountedLoca...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aaea02d09e528cdd2284887ef407a86586380c07 https://github.com/WebKit/WebKit/commit/aaea02d09e528cdd2284887ef407a86586380c07 Author: Rob Buis Date: 2024-06-18 (Tue, 18 Jun 2024) Changed paths: M Source/WebCore/css/CSSCounterStyleRegistry.cpp M Source/WebCore/css/ImmutableStyleProperties.cpp M Source/WebCore/html/PublicURLManager.cpp M Source/WebCore/loader/archive/ArchiveResourceCollection.cpp Log Message: --- Adopt more smart pointers addressing UncountedLocalVarsChecker warning https://bugs.webkit.org/show_bug.cgi?id=275562 Reviewed by Ryosuke Niwa. Adopt more smart pointers addressing the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/css/CSSCounterStyleRegistry.cpp: (WebCore::CSSCounterStyleRegistry::resolveExtendsReference): (WebCore::CSSCounterStyleRegistry::counterStyle): * Source/WebCore/css/ImmutableStyleProperties.cpp: (WebCore::ImmutableStyleProperties::ImmutableStyleProperties): * Source/WebCore/html/PublicURLManager.cpp: (WebCore::PublicURLManager::revoke): (WebCore::PublicURLManager::stop): * Source/WebCore/loader/archive/ArchiveResourceCollection.cpp: (WebCore::ArchiveResourceCollection::archiveResourceForURL): Canonical link: https://commits.webkit.org/280112@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2be5a7: [Navigation] Form submit should set historyHandlin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2be5a73cd6d8a5e7aa9a12bba3cabc5ffcb96f55 https://github.com/WebKit/WebKit/commit/2be5a73cd6d8a5e7aa9a12bba3cabc5ffcb96f55 Author: Rob Buis Date: 2024-06-17 (Mon, 17 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-get-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/NavigationScheduler.cpp Log Message: --- [Navigation] Form submit should set historyHandling correctly https://bugs.webkit.org/show_bug.cgi?id=275546 Reviewed by Alex Christensen. Form submit should set historyHandling correctly [1]. [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit (Step 25) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-get-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPostRequest): * Source/WebCore/loader/NavigationScheduler.cpp: Canonical link: https://commits.webkit.org/280109@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3d83f: [Navigation] Reset navigation API state when using...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3d83f83abe551d565be879c9f6cfafe963b428b https://github.com/WebKit/WebKit/commit/a3d83f83abe551d565be879c9f6cfafe963b428b Author: Rob Buis Date: 2024-06-17 (Mon, 17 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/history-replaceState-expected.txt M Source/WebCore/loader/HistoryController.cpp Log Message: --- [Navigation] Reset navigation API state when using History.replaceState https://bugs.webkit.org/show_bug.cgi?id=275547 Reviewed by Alex Christensen. Reset navigation API state when using History.replaceState. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/history-replaceState-expected.txt: * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::replaceState): Canonical link: https://commits.webkit.org/280083@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a99de: [Navigation] NavigateEvent hashChange should be fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a99ded3fddd6d32ff97a3c2bd0cb3d332a77e5b https://github.com/WebKit/WebKit/commit/1a99ded3fddd6d32ff97a3c2bd0cb3d332a77e5b Author: Rob Buis Date: 2024-06-06 (Thu, 06 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-pushState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-replaceState-expected.txt M Source/WebCore/page/History.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] NavigateEvent hashChange should be false in certain cases https://bugs.webkit.org/show_bug.cgi?id=275054 Reviewed by Alex Christensen and Darin Adler. When determining hashChange now we have one extra requirement [1]: - event's classic history API state is null. [1] https://github.com/whatwg/html/pull/10393 * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-pushState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-replaceState-expected.txt: * Source/WebCore/page/History.cpp: (WebCore::History::stateObjectAdded): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/279770@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b9d1a: [Navigation] Unskip some tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b9d1a23c4f3c68ceee356c29040b0256e2ea905 https://github.com/WebKit/WebKit/commit/9b9d1a23c4f3c68ceee356c29040b0256e2ea905 Author: Rob Buis Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Navigation] Unskip some tests https://bugs.webkit.org/show_bug.cgi?id=275046 Unreviewed test gardening. Unskip some tests that now pass. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/279739@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b50dcf: [Navigation] Add fully active document check to th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b50dcf22f189f2c47da11c0929f1204ba6ecac1f https://github.com/WebKit/WebKit/commit/b50dcf22f189f2c47da11c0929f1204ba6ecac1f Author: Rob Buis Date: 2024-06-01 (Sat, 01 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-expected.txt M Source/WebCore/page/NavigateEvent.cpp M Source/WebCore/page/NavigateEvent.h M Source/WebCore/page/NavigateEvent.idl Log Message: --- [Navigation] Add fully active document check to the "perform shared checks" algorithm https://bugs.webkit.org/show_bug.cgi?id=274890 Reviewed by Alex Christensen. Add fully active document check to the "perform shared checks" algorithm [1]. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigateevent-perform-shared-checks * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-expected.txt: * Source/WebCore/page/NavigateEvent.cpp: (WebCore::NavigateEvent::sharedChecks): (WebCore::NavigateEvent::intercept): (WebCore::NavigateEvent::scroll): * Source/WebCore/page/NavigateEvent.h: * Source/WebCore/page/NavigateEvent.idl: Canonical link: https://commits.webkit.org/279613@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cdfb0: [Navigation] Some tests pass unexpectedly now
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cdfb0a20c2048c7ae46ef02c33f34140bc02786 https://github.com/WebKit/WebKit/commit/8cdfb0a20c2048c7ae46ef02c33f34140bc02786 Author: Rob Buis Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Navigation] Some tests pass unexpectedly now https://bugs.webkit.org/show_bug.cgi?id=274650 Reviewed by Jonathan Bedard. Some tests pass unexpectedly now on mac and ios platforms. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/279294@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43ae85: [GPU Process] Cache the Filter only if it has a va...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43ae8533abcdc3bc0551cdfc317458c03d2e9bae https://github.com/WebKit/WebKit/commit/43ae8533abcdc3bc0551cdfc317458c03d2e9bae Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/send-filter-expected.txt A LayoutTests/ipc/send-filter.html M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp Log Message: --- [GPU Process] Cache the Filter only if it has a valid resource identifier https://bugs.webkit.org/show_bug.cgi?id=270324 rdar://122378065 Reviewed by Said Abou-Hallawa. Filter is a RenderingResource and it can be cached by DisplayList, however, every resource needs an identifier to be cached and a Filter can be created without an identifier. This patch prevents Filters without identifiers from being cached. * LayoutTests/TestExpectations: * LayoutTests/ipc/send-filter-expected.txt: Added. * LayoutTests/ipc/send-filter.html: Added. * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheFilter): Originally-landed-as: 274097.15@webkit-2024.2-embargoed (977618344850). rdar://128555035 Canonical link: https://commits.webkit.org/279226@main Commit: f99d7c5195c4359543ab224fcee958054c0fe8d7 https://github.com/WebKit/WebKit/commit/f99d7c5195c4359543ab224fcee958054c0fe8d7 Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/ipc/ui-send-empty-uuid-expected.txt A LayoutTests/ipc/ui-send-empty-uuid.html M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm Log Message: --- Missing return when uuid is empty https://bugs.webkit.org/show_bug.cgi?id=270481 rdar://122379657 Reviewed by John Wilander. When sending a message to WebPageProxy_ModelElementLoadRemotePreview, the uuid cannot be empty. There is already a check for that but if an empty uuid is indeed sent, we never return the error. This patch adds the missing return. * LayoutTests/ipc/ui-send-empty-uuid-expected.txt: Added. * LayoutTests/ipc/ui-send-empty-uuid.html: Added. * Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::modelElementLoadRemotePreview): Originally-landed-as: 274097.13@webkit-2024.2-embargoed (8105acb3cedb). rdar://128555186 Canonical link: https://commits.webkit.org/279227@main Commit: 90e96164e02f963b67c605a228c0e5bf98b2df2d https://github.com/WebKit/WebKit/commit/90e96164e02f963b67c605a228c0e5bf98b2df2d Author: Mikhail R. Gadelha Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/send-gradient-expected.txt A LayoutTests/ipc/send-gradient.html M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/Platform/Logging.h Log Message: --- Always build a Gradient identifier to enable resource caching https://bugs.webkit.org/show_bug.cgi?id=270480 rdar://122181237 Reviewed by Said Abou-Hallawa. Gradient is a RenderingResource and it can be cached by DisplayList, however, every resource needs an identifier to be cached and a Gradient can be created withouth an identifier. This patch prevents Gradients without identifiers from being cached. * LayoutTests/TestExpectations: * LayoutTests/ipc/send-gradient-expected.txt: Added. * LayoutTests/ipc/send-gradient.html: Added. * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheGradient): Originally-landed-as: 274097.14@webkit-2024.2-embargoed (0bfbed0e1d1a). rdar://128555359 Canonical link: https://commits.webkit.org/279228@main Commit: 49088ee12eea360c9d010a79635372547d095341 https://github.com/WebKit/WebKit/commit/49088ee12eea360c9d010a79635372547d095341 Author: Rob Buis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: A LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent-expected.txt A LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent.html M Source/WebCore/rendering/style/StyleGradientImage.cpp Log Message: --- ASAN_TRAP | WTF::Vector::expandCapacity; WTF::Vector::expandCapacity; WTF::Vector::appendSlowCase https://bugs.webkit.org/show_bug.cgi?id=271904 rdar://125579928 Reviewed by Antti Koivisto. For https://bugs.webkit.org/show_bug.cgi?id=264639 a fix was done to deal with repeating gradients where a tiny offset range was repeated, causing a large number of items to be added to the stop vector. That fix does not apply when the offset range is reasonable but the maxExtent is large. So, also take the maxExtent into account when deciding whether to produce extra gradient stops. * LayoutTests/fast/css/repeating-radial-gradient-small-range-large-extent-expected.txt: Added. * LayoutTests/fast/css/repeating-radial-gradient-small
[webkit-changes] [WebKit/WebKit] 5fb3db: [Navigation] Set serialized state on navigation hi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fb3db45a58f172e9c8335f1da4133031e10ca58 https://github.com/WebKit/WebKit/commit/5fb3db45a58f172e9c8335f1da4133031e10ca58 Author: Rob Buis Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-info-and-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-info-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-no-args-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-and-info-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-undefined-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-pushState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/same-document-away-and-back-navigation-api-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Set serialized state on navigation history items https://bugs.webkit.org/show_bug.cgi?id=274535 Reviewed by Alex Christensen. Set serialized state on navigation history items as part of step 2 of the "notify about the committed-to entry" algorithm [1]. The test changes are progressions, i.e. assertions involving state now pass but the test may run into some failure later. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#notify-about-the-committed-to-entry * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-info-and-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-info-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-no-args-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-and-info-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-state-undefined-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-pushState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/state/history-replaceState-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::notifyCommittedToEntry): (WebCore::Navigation::updateForNavigation): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/279222@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f987e5: Adopt more smart pointers in HTMLCanvasElement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f987e56ae559b455cb008420ff25583cf0081905 https://github.com/WebKit/WebKit/commit/f987e56ae559b455cb008420ff25583cf0081905 Author: Rob Buis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/html/HTMLCanvasElement.cpp Log Message: --- Adopt more smart pointers in HTMLCanvasElement https://bugs.webkit.org/show_bug.cgi?id=274463 Reviewed by Ryosuke Niwa. Adopt more smart pointers in HTMLCanvasElement based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::createContextWebGL): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::didMoveToNewDocument): Canonical link: https://commits.webkit.org/279122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 072b03: [Navigation] Correct cancelable determination of N...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 072b031414e564e51079e9a3448b5843d0f4492d https://github.com/WebKit/WebKit/commit/072b031414e564e51079e9a3448b5843d0f4492d Author: Rob Buis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-iframe-location-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-sameorigindomain.sub-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Correct cancelable determination of NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=274471 Reviewed by Alex Christensen and Darin Adler. When determining the cancelable flag for NavigateEvent we did not take into account the navigation type [1]. By fixing that we fix navigate-anchor-download.html, navigate-anchor-download-userInitiated.html and can mark two further tests as passing. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#inner-navigate-event-firing-algorithm (Step 11) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-iframe-location-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/279109
[webkit-changes] [WebKit/WebKit] 71b00c: Adopt more smart pointers in mathml
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71b00c93fe19cd323da86c8b97de37219cb19ed4 https://github.com/WebKit/WebKit/commit/71b00c93fe19cd323da86c8b97de37219cb19ed4 Author: Rob Buis Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M Source/WebCore/mathml/MathMLAnnotationElement.cpp M Source/WebCore/mathml/MathMLElement.cpp M Source/WebCore/mathml/MathMLRowElement.cpp M Source/WebCore/mathml/MathMLSelectElement.cpp Log Message: --- Adopt more smart pointers in mathml https://bugs.webkit.org/show_bug.cgi?id=274388 Reviewed by Sihui Liu. Adopt more smart pointers in mathml based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/mathml/MathMLAnnotationElement.cpp: (WebCore::MathMLAnnotationElement::attributeChanged): * Source/WebCore/mathml/MathMLElement.cpp: (WebCore::MathMLElement::defaultEventHandler): * Source/WebCore/mathml/MathMLRowElement.cpp: (WebCore::MathMLRowElement::childrenChanged): * Source/WebCore/mathml/MathMLSelectElement.cpp: (WebCore::MathMLSelectElement::MathMLSelectElement): (WebCore::MathMLSelectElement::getSelectedActionChild): (WebCore::MathMLSelectElement::getSelectedSemanticsChild): Canonical link: https://commits.webkit.org/279070@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63e956: Adopt more smart pointers in rendering/mathml
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63e956ceca0793f620202fd952c2286f15379827 https://github.com/WebKit/WebKit/commit/63e956ceca0793f620202fd952c2286f15379827 Author: Rob Buis Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp M Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp M Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp Log Message: --- Adopt more smart pointers in rendering/mathml https://bugs.webkit.org/show_bug.cgi?id=274384 Reviewed by Sihui Liu. Adopt more smart pointers in endering/mathml based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp: (WebCore::axisHeight): * Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp: (WebCore::RenderMathMLFenced::updateFromElement): * Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::defaultLineThickness const): (WebCore::RenderMathMLFraction::fractionParameters const): (WebCore::RenderMathMLFraction::stackParameters const): * Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::horizontalParameters): (WebCore::RenderMathMLRoot::verticalParameters): * Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp: (WebCore::RenderMathMLScripts::spaceAfterScript): (WebCore::RenderMathMLScripts::verticalParameters const): * Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp: (WebCore::RenderMathMLSpace::spaceWidth const): (WebCore::RenderMathMLSpace::getSpaceHeightAndDepth const): * Source/WebCore/rendering/mathml/RenderMathMLToken.cpp: (WebCore::RenderMathMLToken::updateMathVariantGlyph): * Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp: (WebCore::RenderMathMLUnderOver::verticalParameters const): Canonical link: https://commits.webkit.org/279042@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d41105: [Navigation] Support download navigations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d41105b73082dcda0b1aa78c6850a77067c0bc20 https://github.com/WebKit/WebKit/commit/d41105b73082dcda0b1aa78c6850a77067c0bc20 Author: Rob Buis Date: 2024-05-18 (Sat, 18 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-userInitiated-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/anchor-download-expected.txt M Source/WebCore/loader/PolicyChecker.cpp M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Support download navigations https://bugs.webkit.org/show_bug.cgi?id=272349 Reviewed by Alex Christensen. Implement detecting download requests and firing a navigate event for them [1]. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#fire-a-download-request-navigate-event * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-userInitiated-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/anchor-download-expected.txt: * Source/WebCore/loader/PolicyChecker.cpp: (WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::dispatchDownloadNavigateEvent): Canonical link: https://commits.webkit.org/278950@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96f558: WASM unreachable code validation is broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96f558b446153e1417a8df780d22e338091d86a6 https://github.com/WebKit/WebKit/commit/96f558b446153e1417a8df780d22e338091d86a6 Author: Mikhail R. Gadelha Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: A JSTests/wasm/stress/wasm-unreachable-br-block.js M Source/JavaScriptCore/wasm/WasmFunctionParser.h Log Message: --- WASM unreachable code validation is broken https://bugs.webkit.org/show_bug.cgi?id=265425 rdar://103288466 Reviewed by Keith Miller. This patch fixes an assertion failure in the unreachable code parser when the target of a br instruction is a block that was not added into the control stack. The code that checks the br target now takes into account the number of unreachable blocks, if the br instruction is also unreachable. This is similar to the solution employed by parseDelegateTarget and should support cases when block, if, try, and loop were not added to the control stack. * JSTests/wasm/stress/wasm-unreachable-br-block.js: Added. (async test): * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseBranchTarget): (JSC::Wasm::FunctionParser::parseUnreachableExpression): Originally-landed-as: 274097.7@webkit-2024.2-embargoed (ab8e4a4470bb). rdar://128090590 Canonical link: https://commits.webkit.org/278882@main Commit: 72485b3a40e30c94b4394e7bac01af3159debbd6 https://github.com/WebKit/WebKit/commit/72485b3a40e30c94b4394e7bac01af3159debbd6 Author: Žan Doberšek Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: A LayoutTests/fast/css/repeating-conic-gradient-small-range-expected.txt A LayoutTests/fast/css/repeating-conic-gradient-small-range.html A LayoutTests/fast/css/repeating-linear-gradient-small-range-expected.txt A LayoutTests/fast/css/repeating-linear-gradient-small-range.html A LayoutTests/fast/css/repeating-radial-gradient-small-range-expected.txt A LayoutTests/fast/css/repeating-radial-gradient-small-range.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/rendering/style/StyleGradientImage.cpp Log Message: --- ASAN_ILL | WTF::Vector::expandCapacity; WTF::Vector::expandCapacity; WebCore::StyleGradientImage::computeStops https://bugs.webkit.org/show_bug.cgi?id=264639 rdar://114069174 Reviewed by Antti Koivisto. When working with repeating gradients, more care should be put into limiting the amount of stops that can be additionally generated. If the original gradient range is already too small, the extra stops are not generated. Once the number of additional stops is calculated, the generation proceeds only if that number is below some reasonable limit. That generation is also improved slightly by creating a separate Vector of gradient stops that then simply replaces the original one. * LayoutTests/fast/css/repeating-conic-gradient-small-range-expected.txt: Added. * LayoutTests/fast/css/repeating-conic-gradient-small-range.html: Added. * LayoutTests/fast/css/repeating-linear-gradient-small-range-expected.txt: Added. * LayoutTests/fast/css/repeating-linear-gradient-small-range.html: Added. * LayoutTests/fast/css/repeating-radial-gradient-small-range-expected.txt: Added. * LayoutTests/fast/css/repeating-radial-gradient-small-range.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/rendering/style/StyleGradientImage.cpp: (WebCore::StyleGradientImage::computeStops const): Originally-landed-as: 274097.8@webkit-2024.2-embargoed (efd994a148b6). rdar://128090422 Canonical link: https://commits.webkit.org/278883@main Commit: 3f5fc52ff3ea57f51b2a004ea0e47542b13ad1ae https://github.com/WebKit/WebKit/commit/3f5fc52ff3ea57f51b2a004ea0e47542b13ad1ae Author: Rob Buis Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: A LayoutTests/security/schedule-request-object-then-move-plugin-to-frameless-document-crash-expected.txt A LayoutTests/security/schedule-request-object-then-move-plugin-to-frameless-document-crash.html M Source/WebCore/html/HTMLPlugInImageElement.cpp Log Message: --- HTMLPlugInImageElement: verify that element is in same document before requesting a load https://bugs.webkit.org/show_bug.cgi?id=268769 rdar://121960561 Reviewed by Ryosuke Niwa. The testcase shows a scenario where a plugin is set up to start loading the plugin contents from an event loop, however before the event loop is started the rest of the script will run, which moves the plugin to a different document, thus hitting an ASSERT in WebFrame::createSubframe when the load is performed. Protect against this by returning early when this situation is detected in the event loop. * LayoutTests/security/schedule-request-object-then-move-plugin-to-frameless-document-crash-expected.txt: Added. * LayoutTests/security/schedule-request-object-then-move-plugin-to-frameless-document-crash.html: Added. * Source
[webkit-changes] [WebKit/WebKit] 9142a5: [Navigation] Make NavigationHistoryEntry getters c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9142a5f4e9ee7abc53ce1c77e2979f0065b46e1d https://github.com/WebKit/WebKit/commit/9142a5f4e9ee7abc53ce1c77e2979f0065b46e1d Author: Rob Buis Date: 2024-05-14 (Tue, 14 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entry-after-detach-expected.txt M Source/WebCore/page/NavigationHistoryEntry.cpp M Source/WebCore/page/NavigationHistoryEntry.h Log Message: --- [Navigation] Make NavigationHistoryEntry getters check for fully active document https://bugs.webkit.org/show_bug.cgi?id=274000 Reviewed by Alex Christensen. Make NavigationHistoryEntry getters check for fully active document [see 1, 2 etc.]. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-url [2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#concept-navigationhistoryentry-key * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entry-after-detach-expected.txt: * Source/WebCore/page/NavigationHistoryEntry.cpp: (WebCore::NavigationHistoryEntry::url const): (WebCore::NavigationHistoryEntry::key const): (WebCore::NavigationHistoryEntry::id const): (WebCore::NavigationHistoryEntry::index const): (WebCore::NavigationHistoryEntry::sameDocument const): (WebCore::NavigationHistoryEntry::getState const): * Source/WebCore/page/NavigationHistoryEntry.h: Canonical link: https://commits.webkit.org/278770@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e05acd: Use smart pointers for members of SVG classes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e05acd940a06b9c9070c748bdd563a8e0d8550f9 https://github.com/WebKit/WebKit/commit/e05acd940a06b9c9070c748bdd563a8e0d8550f9 Author: Rob Buis Date: 2024-05-13 (Mon, 13 May 2024) Changed paths: M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.h M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.h M Source/WebCore/rendering/svg/SVGLayerTransformComputation.h M Source/WebCore/rendering/svg/SVGLayerTransformUpdater.h M Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp M Source/WebCore/rendering/svg/SVGTextLayoutAttributes.h M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h Log Message: --- Use smart pointers for members of SVG classes https://bugs.webkit.org/show_bug.cgi?id=273061 Reviewed by Chris Dumez. Use smart pointers for members of SVG classes instead of raw pointers. * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleShapeOrTextOrInline const): (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): (WebCore::SVGBoundingBoxComputation::handleForeignObjectOrImage const): (WebCore::SVGBoundingBoxComputation::adjustBoxForClippingAndEffects const): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.h: * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutChildren): (WebCore::SVGContainerLayout::positionChildrenRelativeToContainer): (WebCore::SVGContainerLayout::layoutSizeOfNearestViewportChanged const): * Source/WebCore/rendering/svg/SVGContainerLayout.h: * Source/WebCore/rendering/svg/SVGLayerTransformComputation.h: (WebCore::SVGLayerTransformComputation::computeAccumulatedTransform const): (WebCore::SVGLayerTransformComputation::calculateScreenFontSizeScalingFactor const): * Source/WebCore/rendering/svg/SVGLayerTransformUpdater.h: (WebCore::SVGLayerTransformUpdater::SVGLayerTransformUpdater): (WebCore::SVGLayerTransformUpdater::~SVGLayerTransformUpdater): (WebCore::SVGLayerTransformUpdater::layerTransformChanged const): * Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp: (WebCore::SVGTextLayoutAttributes::context): (WebCore::SVGTextLayoutAttributes::context const): * Source/WebCore/rendering/svg/SVGTextLayoutAttributes.h: (WebCore::SVGTextLayoutAttributes::context): Deleted. (WebCore::SVGTextLayoutAttributes::context const): Deleted. * Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp: (WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder): * Source/WebCore/rendering/svg/SVGTextMetricsBuilder.h: Canonical link: https://commits.webkit.org/278697@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df4f81: [Navigation] Consolidate "document is fully active...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df4f8114adb94520ac83c8a0b0d8b4aaba7e1028 https://github.com/WebKit/WebKit/commit/df4f8114adb94520ac83c8a0b0d8b4aaba7e1028 Author: Rob Buis Date: 2024-05-10 (Fri, 10 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-detached-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Consolidate "document is fully active" check in navigate https://bugs.webkit.org/show_bug.cgi?id=273972 Reviewed by Alex Christensen. The navigate method starts of by (partly) checking whether the document is fully active by checking that the frame exists, however the "document is fully active" check should be done in step 7 (see [1]). So remove the frame check and rely on the later call to isFullyActive to get the correct order of handling possible errors. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-detached-unserializablestate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::navigate): Canonical link: https://commits.webkit.org/278627@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 268766: Make setupTransitionPseudoElements end in an up-to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 268766c7de0d0900b5c389d62be961065c6ea3dc https://github.com/WebKit/WebKit/commit/268766c7de0d0900b5c389d62be961065c6ea3dc Author: Rob Buis Date: 2024-05-10 (Fri, 10 May 2024) Changed paths: A LayoutTests/fast/css/view-transition-pseudo-element-styles-crash-expected.txt A LayoutTests/fast/css/view-transition-pseudo-element-styles-crash.html M Source/WebCore/dom/ViewTransition.cpp Log Message: --- Make setupTransitionPseudoElements end in an up-to-date render tree https://bugs.webkit.org/show_bug.cgi?id=273962 Reviewed by Tim Nguyen. It is important for setupTransitionPseudoElements to end in an up-to-date render tree, after potentially invaliding the document element, since updatePseudoElementStyles expects that for copying element properties. * LayoutTests/fast/css/view-transition-pseudo-element-styles-crash-expected.txt: Added. * LayoutTests/fast/css/view-transition-pseudo-element-styles-crash.html: Added. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::setupTransitionPseudoElements): Canonical link: https://commits.webkit.org/278608@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb1d80: Adopt more smart pointers in Navigator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb1d80ceb53e75aa8c57c8515cf017c6c04b0e8f https://github.com/WebKit/WebKit/commit/bb1d80ceb53e75aa8c57c8515cf017c6c04b0e8f Author: Rob Buis Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M Source/WebCore/page/Navigator.cpp Log Message: --- Adopt more smart pointers in Navigator https://bugs.webkit.org/show_bug.cgi?id=273547 Reviewed by Chris Dumez and Tim Nguyen. Adopt more smart pointers in Navigator based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/Navigator.cpp: (WebCore::Navigator::userAgent const): (WebCore::Navigator::platform const): (WebCore::Navigator::share): (WebCore::Navigator::showShareData): (WebCore::Navigator::initializePluginAndMimeTypeArrays): (WebCore::Navigator::cookieEnabled const): (WebCore::Navigator::setAppBadge): (WebCore::Navigator::setClientBadge): Canonical link: https://commits.webkit.org/278553@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6ec31: Sync navigation-api from WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6ec312f2f6c7d6a2df240b5de1974063867562b https://github.com/WebKit/WebKit/commit/b6ec312f2f6c7d6a2df240b5de1974063867562b Author: Rob Buis Date: 2024-05-07 (Tue, 07 May 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/navigation-api/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-origin-traversal-redirect.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/event-constructor.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-cross-origin.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-userInitiated.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-same-origin-cross-document.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-with-target.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-reload.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-get.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-reload.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-traverse.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-userInitiated.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-with-target.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-after-fragment.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-after-pushState.html A LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-bfcache.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-cross-document.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-pushState.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-replaceState.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-iframe-location.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-location.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-meta-refresh.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-cross-document.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-navigate.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-to-srcdoc.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open-self.html M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open.html A LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/resources/cross-origin
[webkit-changes] [WebKit/WebKit] 2b3f00: Add more smart pointers to lazy load observers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b3f00e89aabd3a238b70e5153315344e8ac73e1 https://github.com/WebKit/WebKit/commit/2b3f00e89aabd3a238b70e5153315344e8ac73e1 Author: Rob Buis Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebCore/html/LazyLoadFrameObserver.cpp M Source/WebCore/html/LazyLoadFrameObserver.h M Source/WebCore/html/LazyLoadImageObserver.cpp Log Message: --- Add more smart pointers to lazy load observers https://bugs.webkit.org/show_bug.cgi?id=273321 Reviewed by Chris Dumez. Add more smart pointers to lazy load observers, by both replacing raw member variables and fixing [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/html/LazyLoadFrameObserver.cpp: (WebCore::LazyLoadFrameObserver::observe): (WebCore::LazyLoadFrameObserver::unobserve): * Source/WebCore/html/LazyLoadFrameObserver.h: * Source/WebCore/html/LazyLoadImageObserver.cpp: (WebCore::LazyLoadImageObserver::observe): Canonical link: https://commits.webkit.org/278368@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e86473: Adopt more smart pointers in IntersectionObserver
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e864738237198a14b63c6f519be1023b951f00fe https://github.com/WebKit/WebKit/commit/e864738237198a14b63c6f519be1023b951f00fe Author: Rob Buis Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebCore/page/IntersectionObserver.cpp Log Message: --- Adopt more smart pointers in IntersectionObserver https://bugs.webkit.org/show_bug.cgi?id=273478 Reviewed by Chris Dumez. Adopt more smart pointers in IntersectionObserver based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::observe): (WebCore::IntersectionObserver::unobserve): (WebCore::IntersectionObserver::disconnect): (WebCore::IntersectionObserver::targetDestroyed): (WebCore::computeClippedRectInRootContentsSpace): (WebCore::IntersectionObserver::nowTimestamp const): (WebCore::IntersectionObserver::notify): (WebCore::IntersectionObserver::isReachableFromOpaqueRoots const): Canonical link: https://commits.webkit.org/278315@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cde484: Adopt more smart pointers in History.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cde48409003c820470a6e7ff1f5e2c753fa956e7 https://github.com/WebKit/WebKit/commit/cde48409003c820470a6e7ff1f5e2c753fa956e7 Author: Rob Buis Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebCore/page/History.cpp Log Message: --- Adopt more smart pointers in History.cpp https://bugs.webkit.org/show_bug.cgi?id=273541 Reviewed by Sihui Liu. Adopt more smart pointers in History.cpp based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/History.cpp: (WebCore::History::length const): (WebCore::History::scrollRestoration const): (WebCore::History::setScrollRestoration): (WebCore::History::go): (WebCore::History::urlForState): Canonical link: https://commits.webkit.org/278310@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 088a3e: Adopt more smart pointers in LocalFrame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 088a3e573b59664dc988291e52900bba6b106b2c https://github.com/WebKit/WebKit/commit/088a3e573b59664dc988291e52900bba6b106b2c Author: Rob Buis Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/page/LocalFrame.cpp Log Message: --- Adopt more smart pointers in LocalFrame https://bugs.webkit.org/show_bug.cgi?id=273397 Reviewed by Sihui Liu. Adopt more smart pointers in LocalFrame based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/LocalFrame.cpp: (WebCore::parentPageZoomFactor): (WebCore::parentTextZoomFactor): (WebCore::rootFrame): (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::~LocalFrame): (WebCore::LocalFrame::shouldUsePrintingLayout const): (WebCore::LocalFrame::frameForWidget): (WebCore::LocalFrame::rangeForPoint): (WebCore::LocalFrame::debugDescription const): (WebCore::LocalFrame::contentFrameFromWindowOrFrameElement): Canonical link: https://commits.webkit.org/278206@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6999be: [LBSE] Add support for LBSE masks in SVGResourceImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6999be889df2d2b5b9ba7b5c92cd35f7b0ee848a https://github.com/WebKit/WebKit/commit/6999be889df2d2b5b9ba7b5c92cd35f7b0ee848a Author: Rob Buis Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/ReferencedSVGResources.h M Source/WebCore/rendering/style/StyleCachedImage.cpp M Source/WebCore/rendering/style/StyleCachedImage.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/svg/graphics/SVGResourceImage.cpp M Source/WebCore/svg/graphics/SVGResourceImage.h Log Message: --- [LBSE] Add support for LBSE masks in SVGResourceImage https://bugs.webkit.org/show_bug.cgi?id=272823 Reviewed by Nikolas Zimmermann. Add support for LBSE masks in SVGResourceImage and that way support HTML referencing SVG masks, both in same document and in external SVG documents. * LayoutTests/TestExpectations: * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::ReferencedSVGResources::referencedMaskElement): * Source/WebCore/rendering/ReferencedSVGResources.h: * Source/WebCore/rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::legacyRenderSVGResource const): (WebCore::StyleCachedImage::renderSVGResource const): (WebCore::StyleCachedImage::isRenderSVGResource const): (WebCore::StyleCachedImage::image const): * Source/WebCore/rendering/style/StyleCachedImage.h: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyMask): (WebCore::RenderSVGResourceMasker::drawContentIntoContext): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/svg/graphics/SVGResourceImage.cpp: (WebCore::SVGResourceImage::create): (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::draw): * Source/WebCore/svg/graphics/SVGResourceImage.h: Canonical link: https://commits.webkit.org/278102@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2ca06: [LBSE] Adopt more smart pointers in SVG code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2ca06dc3d84b356d01cdf09a82049f80515fbfe https://github.com/WebKit/WebKit/commit/b2ca06dc3d84b356d01cdf09a82049f80515fbfe Author: Rob Buis Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/style/StyleCachedImage.cpp M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp M Source/WebCore/rendering/svg/legacy/SVGResources.cpp Log Message: --- [LBSE] Adopt more smart pointers in SVG code https://bugs.webkit.org/show_bug.cgi?id=273113 Reviewed by Sihui Liu. Based on [alpha.webkit.UncountedCallArgsChecker] warnings. * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::ReferencedSVGResources::~ReferencedSVGResources): (WebCore::ReferencedSVGResources::referencedMarkerElement): (WebCore::ReferencedSVGResources::referencedMaskElement): (WebCore::ReferencedSVGResources::referencedPaintServerElement): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::svgMaskerResourceFromStyle const): * Source/WebCore/rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::uncheckedRenderSVGResource const): * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::computeClipPath const): * Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource): * Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::updateLayerTransform): (WebCore::RenderSVGResourceMarker::overflowClipRect const): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyMask): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): (WebCore::SVGRenderSupport::applyStrokeStyleToContext): (WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.cpp: (WebCore::removeFromCacheAndInvalidateDependencies): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp: (WebCore::LegacyRenderSVGResourceContainer::registerResource): * Source/WebCore/rendering/svg/legacy/SVGResources.cpp: (WebCore::SVGResources::buildCachedResources): Canonical link: https://commits.webkit.org/277969@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2fa2e8: Add more smart pointers to CheckboxInputType.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2fa2e804cc1bd7c1528e35b071c5943ac62094eb https://github.com/WebKit/WebKit/commit/2fa2e804cc1bd7c1528e35b071c5943ac62094eb Author: Rob Buis Date: 2024-04-22 (Mon, 22 Apr 2024) Changed paths: M Source/WebCore/html/CheckboxInputType.cpp Log Message: --- Add more smart pointers to CheckboxInputType.cpp https://bugs.webkit.org/show_bug.cgi?id=272897 Reviewed by Chris Dumez. Add more smart pointers to CheckboxInputType.cpp. * Source/WebCore/html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::handleMouseDownEvent): (WebCore::CheckboxInputType::handleMouseMoveEvent): (WebCore::CheckboxInputType::handleTouchEvent): (WebCore::CheckboxInputType::willDispatchClick): (WebCore::CheckboxInputType::didDispatchClick): (WebCore::CheckboxInputType::disabledStateChanged): Canonical link: https://commits.webkit.org/277810@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a84a9: Move old SVG Resource code to legacy
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a84a91909d9c592060440c75bf43ec7bbfdd13f https://github.com/WebKit/WebKit/commit/5a84a91909d9c592060440c75bf43ec7bbfdd13f Author: Rob Buis Date: 2024-04-22 (Mon, 22 Apr 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/rendering/svg/SVGResources.cpp R Source/WebCore/rendering/svg/SVGResources.h R Source/WebCore/rendering/svg/SVGResourcesCache.cpp R Source/WebCore/rendering/svg/SVGResourcesCache.h R Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp R Source/WebCore/rendering/svg/SVGResourcesCycleSolver.h A Source/WebCore/rendering/svg/legacy/SVGResources.cpp A Source/WebCore/rendering/svg/legacy/SVGResources.h A Source/WebCore/rendering/svg/legacy/SVGResourcesCache.cpp A Source/WebCore/rendering/svg/legacy/SVGResourcesCache.h A Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.cpp A Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.h Log Message: --- Move old SVG Resource code to legacy https://bugs.webkit.org/show_bug.cgi?id=272989 Reviewed by Nikolas Zimmermann. Move old SVG Resource code to legacy. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/rendering/svg/legacy/SVGResources.cpp: Renamed from Source/WebCore/rendering/svg/SVGResources.cpp. (WebCore::SVGResources::SVGResources): (WebCore::tagSet): (WebCore::clipperFilterMaskerTags): (WebCore::markerTags): (WebCore::fillAndStrokeTags): (WebCore::chainableResourceTags): (WebCore::targetReferenceFromResource): (WebCore::isChainableResource): (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources): (WebCore::SVGResources::layoutDifferentRootIfNeeded): (WebCore::SVGResources::markerReverseStart const): (WebCore::SVGResources::removeClientFromCache const): (WebCore::SVGResources::resourceDestroyed): (WebCore::SVGResources::buildSetOfResources): (WebCore::SVGResources::setClipper): (WebCore::SVGResources::resetClipper): (WebCore::SVGResources::setFilter): (WebCore::SVGResources::resetFilter): (WebCore::SVGResources::setMarkerStart): (WebCore::SVGResources::resetMarkerStart): (WebCore::SVGResources::setMarkerMid): (WebCore::SVGResources::resetMarkerMid): (WebCore::SVGResources::setMarkerEnd): (WebCore::SVGResources::resetMarkerEnd): (WebCore::SVGResources::setMasker): (WebCore::SVGResources::resetMasker): (WebCore::SVGResources::setFill): (WebCore::SVGResources::resetFill): (WebCore::SVGResources::setStroke): (WebCore::SVGResources::resetStroke): (WebCore::SVGResources::setLinkedResource): (WebCore::SVGResources::resetLinkedResource): (WebCore::SVGResources::dump): * Source/WebCore/rendering/svg/legacy/SVGResources.h: Renamed from Source/WebCore/rendering/svg/SVGResources.h. (WebCore::SVGResources::clipper const): (WebCore::SVGResources::masker const): (WebCore::SVGResources::filter const): (WebCore::SVGResources::markerStart const): (WebCore::SVGResources::markerMid const): (WebCore::SVGResources::markerEnd const): (WebCore::SVGResources::fill const): (WebCore::SVGResources::stroke const): (WebCore::SVGResources::linkedResource const): (WebCore::SVGResources::isEmpty const): * Source/WebCore/rendering/svg/legacy/SVGResourcesCache.cpp: Renamed from Source/WebCore/rendering/svg/SVGResourcesCache.cpp. (WebCore::SVGResourcesCache::addResourcesFromRenderer): (WebCore::SVGResourcesCache::removeResourcesFromRenderer): (WebCore::resourcesCacheFromRenderer): (WebCore::SVGResourcesCache::cachedResourcesForRenderer): (WebCore::hasPaintResourceRequiringRemovalOnClientLayoutChange): (WebCore::hasResourcesRequiringRemovalOnClientLayoutChange): (WebCore::SVGResourcesCache::clientLayoutChanged): (WebCore::rendererCanHaveResources): (WebCore::SVGResourcesCache::clientStyleChanged): (WebCore::SVGResourcesCache::clientWasAddedToTree): (WebCore::SVGResourcesCache::clientWillBeRemovedFromTree): (WebCore::SVGResourcesCache::clientDestroyed): (WebCore::SVGResourcesCache::resourceDestroyed): (WebCore::SVGResourcesCache::SetStyleForScope::SetStyleForScope): (WebCore::SVGResourcesCache::SetStyleForScope::~SetStyleForScope): (WebCore::SVGResourcesCache::SetStyleForScope::setStyle): * Source/WebCore/rendering/svg/legacy/SVGResourcesCache.h: Renamed from Source/WebCore/rendering/svg/SVGResourcesCache.h. * Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.cpp: Renamed from Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp. (WebCore::SVGResourcesCycleSolver::resourceContainsCycles): (WebCore::SVGResourcesCycleSolver::resolveCycles): (WebCore::SVGResourcesCycleSolver::breakCycle): * Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.h: Renamed from Source/WebCore/rendering/svg/SVGResourcesCycleSolver.h. (WebCore::SVGResourcesCycleSolver::SVGResourcesCycleSolver): Canonical link: https://commits.webkit.org/277803@main
[webkit-changes] [WebKit/WebKit] cf5707: Adopt smart pointers for updateStyleIfNeeded calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf57073b902deb869332e992dd14afba86cc5cf2 https://github.com/WebKit/WebKit/commit/cf57073b902deb869332e992dd14afba86cc5cf2 Author: Rob Buis Date: 2024-04-20 (Sat, 20 Apr 2024) Changed paths: M Source/WebCore/animation/WebAnimation.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- Adopt smart pointers for updateStyleIfNeeded calls https://bugs.webkit.org/show_bug.cgi?id=272895 Reviewed by Sihui Liu and Ryosuke Niwa. Adopt smart pointers for updateStyleIfNeeded calls. * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::commitStyles): * Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::handleSyntheticClick): Canonical link: https://commits.webkit.org/26@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7196d1: Use more smart pointers for dynamicDowncast<>in SV...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7196d1f760d62c84bcddef4c342d42398a9048bd https://github.com/WebKit/WebKit/commit/7196d1f760d62c84bcddef4c342d42398a9048bd Author: Rob Buis Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp M Source/WebCore/rendering/svg/SVGTextQuery.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp M Source/WebCore/svg/SVGFEComponentTransferElement.cpp M Source/WebCore/svg/SVGFontFaceSrcElement.cpp M Source/WebCore/svg/SVGGraphicsElement.cpp Log Message: --- Use more smart pointers for dynamicDowncast<>in SVG code https://bugs.webkit.org/show_bug.cgi?id=272817 Reviewed by Chris Dumez. Use more smart pointers for dynamicDowncast<>in SVG code. * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::findPreviousAndNextAttributes): * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::additionalContainerTranslation const): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutChildren): (WebCore::SVGContainerLayout::positionChildrenRelativeToContainer): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout): (WebCore::updateObjectBoundingBox): (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): (WebCore::SVGRenderSupport::computeContainerStrokeBoundingBox): (WebCore::layoutSizeOfNearestViewportChanged): (WebCore::SVGRenderSupport::layoutChildren): (WebCore::isPointInCSSClippingArea): (WebCore::SVGRenderSupport::clipContextToCSSClippingArea): (WebCore::SVGRenderSupport::calculateApproximateStrokeBoundingBox): * Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingFeatures): (WebCore::writeResources): * Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp: (WebCore::SVGTextMetricsBuilder::walkTree): * Source/WebCore/rendering/svg/SVGTextQuery.cpp: (WebCore::flowBoxForRenderer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp: (WebCore::getElementCTM): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: (WebCore::LegacyRenderSVGResourceClipper::pathOnlyClipping): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp: (WebCore::LegacyRenderSVGTransformableContainer::calculateLocalTransform): * Source/WebCore/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::setFilterEffectAttributeFromChild): * Source/WebCore/svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::createSrcValue const): * Source/WebCore/svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded): Canonical link: https://commits.webkit.org/277661@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc08a3: Adopt smart pointers for updateLayout calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc08a3b096a4d7587bade1e0f7a7c6074a9d8537 https://github.com/WebKit/WebKit/commit/fc08a3b096a4d7587bade1e0f7a7c6074a9d8537 Author: Rob Buis Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/dom/BoundaryPoint.h M Source/WebCore/editing/Editor.cpp M Source/WebCore/html/HTMLLabelElement.cpp M Source/WebCore/html/ImageInputType.cpp M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/PrintContext.cpp M Source/WebCore/page/ios/FrameIOS.mm M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- Adopt smart pointers for updateLayout calls https://bugs.webkit.org/show_bug.cgi?id=272738 Reviewed by Ryosuke Niwa. Adopt smart pointers for updateLayout calls. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::propertyValue const): * Source/WebCore/dom/BoundaryPoint.h: * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::firstRectForRange const): * Source/WebCore/html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::focus): * Source/WebCore/html/ImageInputType.cpp: (WebCore::ImageInputType::height const): (WebCore::ImageInputType::width const): * Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp: (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::performSizeToContentAutoSize): (WebCore::LocalFrameView::setTracksRepaints): (WebCore::LocalFrameView::trackedRepaintRectsAsText const): * Source/WebCore/page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): * Source/WebCore/page/ios/FrameIOS.mm: (WebCore::LocalFrame::wordsInCurrentParagraph const): (WebCore::LocalFrame::preferredHeight const): (WebCore::LocalFrame::updateLayout const): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::willEnterFullScreen): * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: (WebKit::InjectedBundleRangeHandle::text const): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updateAttachmentAttributes): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::requestDocumentEditingContext): (WebKit::WebPage::focusTextInputContextAndPlaceCaret): Canonical link: https://commits.webkit.org/277606@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60e7ce: Adopt smart pointers for updateLayoutIgnorePending...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60e7ce5c20bc02a0b06942cec2e35457ab9bce50 https://github.com/WebKit/WebKit/commit/60e7ce5c20bc02a0b06942cec2e35457ab9bce50 Author: Rob Buis Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/editing/CustomUndoStep.cpp M Source/WebCore/editing/DeleteSelectionCommand.cpp M Source/WebCore/html/HTMLButtonElement.cpp M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/page/FocusController.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/TextIndicator.cpp M Source/WebCore/page/UndoItem.h M Source/WebCore/svg/SVGLocatable.cpp Log Message: --- Adopt smart pointers for updateLayoutIgnorePendingStylesheets calls https://bugs.webkit.org/show_bug.cgi?id=272673 Reviewed by Chris Dumez. Adopt smart pointers for updateLayoutIgnorePendingStylesheets calls. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::propertyValue const): * Source/WebCore/dom/Element.cpp: (WebCore::Element::getClientRects): * Source/WebCore/editing/CustomUndoStep.cpp: (WebCore::CustomUndoStep::unapply): (WebCore::CustomUndoStep::reapply): * Source/WebCore/editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace): * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::requestSubmit): (WebCore::HTMLFormElement::reportValidity): * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange): * Source/WebCore/html/ValidatedFormListedElement.cpp: (WebCore::ValidatedFormListedElement::reportValidity): * Source/WebCore/page/FocusController.cpp: (WebCore::FocusController::findFocusableElementDescendingIntoSubframes): (WebCore::FocusController::advanceFocusDirectionallyInContainer): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollElementToRect): (WebCore::LocalFrameView::performFixedWidthAutoSize): * Source/WebCore/page/TextIndicator.cpp: (WebCore::initializeIndicator): * Source/WebCore/page/UndoItem.h: (WebCore::UndoItem::protectedDocument const): * Source/WebCore/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): Canonical link: https://commits.webkit.org/277519@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e1ce4: [Navigation] Throw exceptions in navigation method...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e1ce4ca4dde839299bd340169b10fdd6cdd6e65 https://github.com/WebKit/WebKit/commit/7e1ce4ca4dde839299bd340169b10fdd6cdd6e65 Author: Rob Buis Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt M Source/WebCore/bindings/IDLTypes.h M Source/WebCore/bindings/js/JSDOMConvertPromise.h M Source/WebCore/bindings/js/JSDOMPromiseDeferredForward.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/IDLAttributes.json M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.idl Log Message: --- [Navigation] Throw exceptions in navigation methods if in detached state https://bugs.webkit.org/show_bug.cgi?id=269987 Reviewed by Darin Adler. The back/forward/traverseTo implementation needs to check whether the document is fully active and throw an exception if not [1]. Similar rules apply to reload [2] and navigate [3]. To fix the frame/document detachment, add an IDL attribute [BypassDocumentFullyActiveCheck], which ignores the script execution context being suspended and avoids the ASSERT in DOMPromise::promise(). This behaviour matches callPromiseFunction, which simply returns the JSPromise and ignores the script execution context. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#performing-a-navigation-api-traversal (step 5) [2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-reload (step 5) [3] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate (step 7) * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-already-detached-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-detach-in-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-already-detached-expected.txt: * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertPromise.h: (WebCore::JSConverter>::convert): * Source/WebCore/bindings/js/JSDOMPromiseDeferredForward.h: * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GetBaseIDLType): * Source/WebCore/bindings/scripts/IDLAttributes.json: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::reload): (WebCore::Navigation::navigate): (WebCore::Navigation::performTraversal): (WebCore::Navigation::updateCurrentEntry): * Source/WebCore/page/Navigation.idl: Canonical link: https://commits.webkit.org/277487@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 985c25: [LBSE] Adopt more smart pointers in SVG code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 985c2518b1d1140c5b2105e8c94b5e154c58e571 https://github.com/WebKit/WebKit/commit/985c2518b1d1140c5b2105e8c94b5e154c58e571 Author: Rob Buis Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebCore/rendering/svg/RenderSVGBlock.cpp M Source/WebCore/rendering/svg/RenderSVGBlock.h M Source/WebCore/rendering/svg/RenderSVGBlockInlines.h M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGPath.cpp M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp Log Message: --- [LBSE] Adopt more smart pointers in SVG code https://bugs.webkit.org/show_bug.cgi?id=272470 Reviewed by Chris Dumez. Adopt more smart pointers in SVG code based on the Safer CPP Guidelines. * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::needsHasSVGTransformFlags const): * Source/WebCore/rendering/svg/RenderSVGBlock.h: * Source/WebCore/rendering/svg/RenderSVGBlockInlines.h: (WebCore::RenderSVGBlock::protectedGraphicsElement const): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::pushMappingToContainer const): * Source/WebCore/rendering/svg/RenderSVGPath.cpp: (WebCore::markerForType): (WebCore::RenderSVGPath::drawMarkers): (WebCore::RenderSVGPath::computeMarkerBoundingBox const): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyMaskClipping): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyMask): * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::prepareStrokeOperation): (WebCore::RenderSVGResourcePattern::createTileImage const): * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::updateFromStyle): (WebCore::RenderSVGRoot::mapLocalToContainer const): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::strokeWidth const): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::updateFontInAllDescendants): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::handleShapeOrTextOrInline const): (WebCore::SVGBoundingBoxComputation::handleRootOrContainer const): (WebCore::SVGBoundingBoxComputation::adjustBoxForClippingAndEffects const): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutChildren): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::isPointInCSSClippingArea): (WebCore::SVGRenderSupport::clipContextToCSSClippingArea): (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Canonical link: https://commits.webkit.org/277452@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e8747: [LBSE] Improve RenderSVGResourcePattern
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e8747f4819708b1c2cfa80ba0bf32a6042e9a2f https://github.com/WebKit/WebKit/commit/9e8747f4819708b1c2cfa80ba0bf32a6042e9a2f Author: Rob Buis Date: 2024-04-10 (Wed, 10 Apr 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/rendering/svg/RenderSVGResourcePattern.h M Source/WebCore/svg/SVGGraphicsElement.cpp M Source/WebCore/svg/SVGPatternElement.cpp M Source/WebCore/svg/SVGSVGElement.cpp Log Message: --- [LBSE] Improve RenderSVGResourcePattern https://bugs.webkit.org/show_bug.cgi?id=269184 Reviewed by Nikolas Zimmermann. Improve pattern resource implementation in the following ways: - take legacy pattern resource calculations to fix custom/nested-pattern-boundingBoxModeContent.svg - cache pattern tiles as image bitmaps (like legacy did). This allows pattern-nested-reference.html to not time out - take care of correctly invalidating in case pattern contents change or a referencing client is added or removed This PR relies on SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded introduced in r277292 and adds patterns as an SVG resource to invalidate for image buffer caching. The expectation is that this is the final SVG resource that needs to be taken into account in SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Added. * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): (WebCore::RenderSVGResourcePattern::prepareFillOperation): (WebCore::RenderSVGResourcePattern::prepareStrokeOperation): (WebCore::RenderSVGResourcePattern::createTileImage const): (WebCore::RenderSVGResourcePattern::removeReferencingCSSClient): (WebCore::clear2DRotation): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::invalidatePattern): * Source/WebCore/svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded): * Source/WebCore/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged): * Source/WebCore/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): Canonical link: https://commits.webkit.org/277306@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 466a4e: [LBSE] Fix performance of nested masks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 466a4e163671edd79710f625f32e3ee740b3a522 https://github.com/WebKit/WebKit/commit/466a4e163671edd79710f625f32e3ee740b3a522 Author: Rob Buis Date: 2024-04-10 (Wed, 10 Apr 2024) Changed paths: A LayoutTests/svg/custom/mask-nested-reference-expected.txt A LayoutTests/svg/custom/mask-nested-reference.html M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/svg/RenderSVGResourceContainer.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/svg/SVGCircleElement.cpp M Source/WebCore/svg/SVGElement.cpp M Source/WebCore/svg/SVGEllipseElement.cpp M Source/WebCore/svg/SVGGraphicsElement.cpp M Source/WebCore/svg/SVGGraphicsElement.h M Source/WebCore/svg/SVGImageElement.cpp M Source/WebCore/svg/SVGLineElement.cpp M Source/WebCore/svg/SVGMaskElement.cpp M Source/WebCore/svg/SVGPathElement.cpp M Source/WebCore/svg/SVGPolyElement.cpp M Source/WebCore/svg/SVGRectElement.cpp M Source/WebCore/svg/SVGResourceElementClient.h M Source/WebCore/svg/SVGTextContentElement.cpp M Source/WebCore/svg/SVGTextElement.cpp M Source/WebCore/svg/SVGTextElement.h M Source/WebCore/svg/SVGTextPositioningElement.cpp M Source/WebCore/svg/SVGUseElement.cpp Log Message: --- [LBSE] Fix performance of nested masks https://bugs.webkit.org/show_bug.cgi?id=271146 Reviewed by Nikolas Zimmermann. Masks with a high amount of nesting can take a lot of resources, both in computation and memory. One example of this is mask-nested-reference.html (based on pattern-nested-reference.html). To fix this, implement two optimizations: - cache masks as image bitmaps (like legacy did) - restrict the nesting level when calculating the mask bounding box - take care of correctly invalidating in case mask contents change or a referencing client is added or removed * LayoutTests/svg/custom/mask-nested-reference-expected.txt: Added. * LayoutTests/svg/custom/mask-nested-reference.html: Added. * Source/WebCore/rendering/ReferencedSVGResources.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::addReferencingCSSClient): (WebCore::RenderSVGResourceContainer::removeReferencingCSSClient): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyMask): (WebCore::RenderSVGResourceMasker::removeReferencingCSSClient): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::adjustBoxForClippingAndEffects const): * Source/WebCore/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): * Source/WebCore/svg/SVGElement.cpp: (WebCore::SVGElement::addReferencingCSSClient): (WebCore::SVGElement::removeReferencingCSSClient): * Source/WebCore/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): * Source/WebCore/svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::invalidateResourceImageBuffersIfNeeded): * Source/WebCore/svg/SVGGraphicsElement.h: * Source/WebCore/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): * Source/WebCore/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): * Source/WebCore/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): * Source/WebCore/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged): * Source/WebCore/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): * Source/WebCore/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): * Source/WebCore/svg/SVGResourceElementClient.h: * Source/WebCore/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::svgAttributeChanged): * Source/WebCore/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childrenChanged): * Source/WebCore/svg/SVGTextElement.h: * Source/WebCore/svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): * Source/WebCore/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): Canonical link: https://commits.webkit.org/277292@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68c440: Branch point for webkit-2023.2-embargoed
Branch: refs/heads/webkit-2023.2-embargoed Home: https://github.com/WebKit/WebKit Commit: 68c44009f220b31e590385b9420c86734543b1d2 https://github.com/WebKit/WebKit/commit/68c44009f220b31e590385b9420c86734543b1d2 Author: Jonathan Bedard Date: 2023-02-14 (Tue, 14 Feb 2023) Changed paths: Log Message: --- Branch point for webkit-2023.2-embargoed Canonical link: https://commits.webkit.org/260286.1@webkit-2023.2-embargoed Commit: d18363c6c4ced4892e1875799dc7cba4b6e9b834 https://github.com/WebKit/WebKit/commit/d18363c6c4ced4892e1875799dc7cba4b6e9b834 Author: Rob Buis Date: 2023-02-14 (Tue, 14 Feb 2023) Changed paths: A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- Cherry-pick 256843.4@webkit-2022.12-embargoed (6234ec9c65b9). rdar://102808328 Do not issue repaints when in detached state https://bugs.webkit.org/show_bug.cgi?id=248773 rdar://102808328 Reviewed by Antti Koivisto. Do not issue repaints when the RenderObject is in detached state while removing render subtrees. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: Added. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderTableCell::willBeRemovedFromTree const): Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/260286.2@webkit-2023.2-embargoed Commit: 92dee4feedbf5f6d2aef96496b09326d8a2fcfe0 https://github.com/WebKit/WebKit/commit/92dee4feedbf5f6d2aef96496b09326d8a2fcfe0 Author: Rob Buis Date: 2023-02-14 (Tue, 14 Feb 2023) Changed paths: A LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt A LayoutTests/fast/css/content/quote-display-contents-crash.html M Source/WebCore/dom/Element.cpp Log Message: --- Cherry-pick 256843.5@webkit-2022.12-embargoed (312254f5776d). rdar://102807985 Check displayContentsChanged in destroyRenderTreeIfNeeded https://bugs.webkit.org/show_bug.cgi?id=248776 rdar://102807985> Reviewed by Antti Koivisto. Check displayContentsChanged in destroyRenderTreeIfNeeded since display: contents may be removed due to focus removal while removing subtrees but we still need to clean up pseudo elements. * LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt: Added. * LayoutTests/fast/css/content/quote-display-contents-crash.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::destroyRenderTreeIfNeeded): * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): Canonical link: https://commits.webkit.org/256843.5@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/260286.3@webkit-2023.2-embargoed Commit: 553700646910e53691d7c87dea6500265104f2cd https://github.com/WebKit/WebKit/commit/553700646910e53691d7c87dea6500265104f2cd Author: Rob Buis Date: 2023-02-14 (Tue, 14 Feb 2023) Changed paths: A LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html A LayoutTests/fast/dom/set-outer-text-on-moved-element.html M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- Cherry-pick 256843.6@webkit-2022.12-embargoed (c4c0ef6360b2). rdar://102808104 Verify that style update roots are for correct document https://bugs.webkit.org/show_bug.cgi?id=248775 rdar://102808104 Reviewed by Antti Koivisto. Verify that style update roots are for the correct document since we may be dealing with a pending update on an element/text node that moved to another document. * LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html: Added. * LayoutTests/fast/dom/set-outer-text-on-moved-element.html: Added. * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::commit): Canonical link: https://commits.webkit.org/256843.6@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/260286.4@webkit-2023.2-embargoed Commit: fc9a39453ba0c1a619e3444eb2530c36a8731389 https://github.com/WebKit/WebKit/commit/fc9a39453ba0c1a619e3444eb2530c36a8731389 Author: Rob Buis Date: 2023-02-14 (Tue, 14 Feb 2023) Changed paths: A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash-expected.txt A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash.html M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- Cherry-pick 256843.7@webkit-2022.12-embargoed (3b92d70ba3ea). rdar://98438399 Do not skip fragmented flow thr
[webkit-changes] [WebKit/WebKit] 28733f: [Navigation] Implement userInitiated in NavigateEvent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28733f4c1575c6350918cc83e645f6a5f8e79c0e https://github.com/WebKit/WebKit/commit/28733f4c1575c6350918cc83e645f6a5f8e79c0e Author: Rob Buis Date: 2024-04-08 (Mon, 08 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Implement userInitiated in NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=272146 Reviewed by Alex Christensen. Implement userInitiated in NavigateEvent. Also correct isSameDocument determination when sending the push/replace/reload navigate event on fragment navigation since it is hardcoded to true: https://html.spec.whatwg.org/multipage/browsing-the-web.html#scroll-to-fragid:fire-a-push/replace/reload-navigate-event * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-userInitiated-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/277208@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c1792: Update RELEASE_ASSERT in FormState::willDetachPage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c17927610b9ae436eb76bd1dea3354921331c35 https://github.com/WebKit/WebKit/commit/4c17927610b9ae436eb76bd1dea3354921331c35 Author: Rob Buis Date: 2024-04-08 (Mon, 08 Apr 2024) Changed paths: A LayoutTests/fast/forms/form-submission-crash-4-expected.txt A LayoutTests/fast/forms/form-submission-crash-4.html M Source/WebCore/loader/FormState.cpp Log Message: --- Update RELEASE_ASSERT in FormState::willDetachPage https://bugs.webkit.org/show_bug.cgi?id=270479 rdar://123991819 Reviewed by Chris Dumez. During the call to continueLoadAfterNavigationPolicy(), it's possible for the frame to be detached. The FrameDestructionObserver willDetachPage() implementation in FormState has the expectation that there is only one reference at this stage, so having an extra one during the scope of continueLoadAfterNavigationPolicy() might break this assumption. To respect the new smart pointer adoption guidelines, but also keep the trap introduced in https://trac.webkit.org/changeset/229683/webkit, use refCount() instead. * LayoutTests/fast/forms/form-submission-crash-4-expected.txt: Added. * LayoutTests/fast/forms/form-submission-crash-4.html: Added. * Source/WebCore/loader/FormState.cpp: (WebCore::FormState::willDetachPage): Canonical link: https://commits.webkit.org/277207@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d55a9c: [Navigation] Detect hasUAVisualTransition for Navi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d55a9c43bd6e450433aef6841e21b532c1c5db4b https://github.com/WebKit/WebKit/commit/d55a9c43bd6e450433aef6841e21b532c1c5db4b Author: Rob Buis Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: A LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition-expected.txt A LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition.html M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Detect hasUAVisualTransition for NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=272019 Reviewed by Simon Fraser. Detect hasUAVisualTransition for NavigateEvent as specified: https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigate-event-firing:dom-navigateevent-hasuavisualtransition * LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition-expected.txt: Added. * LayoutTests/swipe/navigate-event-back-swipe-verify-ua-transition.html: Added. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/277129@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 256947: [Navigation] Process NavigateEvent earlier in Fram...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25694764feddef056fca34e4757708ef5cd45503 https://github.com/WebKit/WebKit/commit/25694764feddef056fca34e4757708ef5cd45503 Author: Rob Buis Date: 2024-04-03 (Wed, 03 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt M Source/WebCore/loader/FrameLoader.cpp Log Message: --- [Navigation] Process NavigateEvent earlier in FrameLoader::loadInSameDocument https://bugs.webkit.org/show_bug.cgi?id=271464 Reviewed by Alex Christensen. Process NavigateEvent earlier in FrameLoader::loadInSameDocument, this allows us to properly determine same document and hashChange values, before updating the document url. Also now we react to preventDefault() calls by doing an early return. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Canonical link: https://commits.webkit.org/277030@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b127d: [Navigation] Enable some tests that now pass
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b127d88d3a00844e7389c7c12e1afec4643594c https://github.com/WebKit/WebKit/commit/8b127d88d3a00844e7389c7c12e1afec4643594c Author: Rob Buis Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-initial-about-blank-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-opaque-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-already-detached-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-detach-in-serialization-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-invalid-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-javascript-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unserializable-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-invalid-key-expected.txt Log Message: --- [Navigation] Enable some tests that now pass https://bugs.webkit.org/show_bug.cgi?id=271374 Reviewed by Manuel Rego Casasnovas. Enable some tests that now pass. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-back-noop-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-navigation-back-same-document-in-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-cross-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/same-url-replace-same-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-initial-about-blank-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-opaque-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-already-detached-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-detach-in-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-invalid-url-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-javascript-url-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-unserializablestate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-unserializable-state-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/traverseTo-invalid-key-expected.txt: Canonical link: https://commits.webkit.org/276474@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org
[webkit-changes] [WebKit/WebKit] 1ad9a7: [LBSE] Only clipPath should be an opportunistic st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ad9a7beb555644c0b5f949b8f635e305018ab4a https://github.com/WebKit/WebKit/commit/1ad9a7beb555644c0b5f949b8f635e305018ab4a Author: Rob Buis Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceClipper.h Log Message: --- [LBSE] Only clipPath should be an opportunistic stacking context https://bugs.webkit.org/show_bug.cgi?id=270338 Reviewed by Nikolas Zimmermann. Only clipPath should be an opportunistic stacking context, other SVG resources are stacking contexts according to CSS or do not need to be one (for example gradients). * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::styleDidChange): Deleted. * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h: * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGResourceClipper.h: Canonical link: https://commits.webkit.org/276449@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6a412: [Navigation] Fix navigation-methods/return-value/n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6a4129a5ef31c678d949ef5c9770bc5cc94d6b7 https://github.com/WebKit/WebKit/commit/a6a4129a5ef31c678d949ef5c9770bc5cc94d6b7 Author: Rob Buis Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-out-of-bounds-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-initial-about-blank-expected.txt M Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp M Source/WebCore/bindings/js/JSDOMPromiseDeferred.h M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Fix navigation-methods/return-value/navigate-push-initial-about-blank.html https://bugs.webkit.org/show_bug.cgi?id=270008 Reviewed by Darin Adler. The navigate implementation needs to check whether the history option is "replace" and the document is about:blank and throw an exception if not [1]. To fully fix this test, adjust DeferredPromise::reject so it can reuse a JS exception object, since the test framework will check committed/finished promises return the same exception object. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate (Step 4) * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-out-of-bounds-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-push-initial-about-blank-expected.txt: * Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp: (WebCore::DeferredPromise::reject): * Source/WebCore/bindings/js/JSDOMPromiseDeferred.h: (WebCore::DeferredPromise::reject): * Source/WebCore/page/Navigation.cpp: (WebCore::createErrorResult): (WebCore::Navigation::navigate): Canonical link: https://commits.webkit.org/276213@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20cf87: [Navigation] Implement "update the navigation API ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20cf87bc4485eefd39154530327a27670e484950 https://github.com/WebKit/WebKit/commit/20cf87bc4485eefd39154530327a27670e484950 Author: Rob Buis Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/anchor-click-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/location-api-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-same-doc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/properties-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-across-origins-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-after-blank-navigation-from-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-srcdoc-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-reload-intercept-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-replace-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/sameDocument-after-navigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-intercept-history-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-base-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-parent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-sibling-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/manual-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/manual-immediate-scroll-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/location-reload-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Implement "update the navigation API entries for a same-document navigation" algorithm https://bugs.webkit.org/show_bug.cgi?id=270696 Reviewed by Alex Christensen. This PR implements the "update the navigation API entries for a same-document navigation" algorithm [1]. Some parts of it we can't do now until some other parts are in place so two FIXMEs are left. Since this means meany WPT tests start to work now this also marks many tests in TestExpectations as passing. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#update-the-navigation-api-entries-for-a-same-document-navigation * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/anchor-click-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-across-origins-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-after-blank-navigation-from-cross-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-srcdoc-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-reload-intercept-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-replace-cross-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/sameDocument-after-navigate-expected.txt: * LayoutTests/imported/w3
[webkit-changes] [WebKit/WebKit] 4ac62b: [LBSE] Rebaseline svg tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ac62bf9551810c9b37e8e6c3dd5e9f1c38142f5 https://github.com/WebKit/WebKit/commit/4ac62bf9551810c9b37e8e6c3dd5e9f1c38142f5 Author: Rob Buis Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/animate-interact-pevents-03-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/animate-interact-pevents-04-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/conform-viewers-03-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-cursor-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-pevents-08-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-pevents-09-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/linking-a-09-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/paths-dom-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/styling-css-05-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/styling-pres-02-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-04-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-06-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-07-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-08-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-deco-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-dom-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-fonts-05-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-path-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tref-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tselect-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tspan-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tspan-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/no-background-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-005-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-006-expected.txt
[webkit-changes] [WebKit/WebKit] 44bbee: [Navigation] Use local history for subframes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44bbee81c8028bfbefbff2d67189a105771a1e17 https://github.com/WebKit/WebKit/commit/44bbee81c8028bfbefbff2d67189a105771a1e17 Author: Rob Buis Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-back-forward-cross-doc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-out-of-bounds-expected.txt M Source/WebCore/loader/FrameLoader.cpp Log Message: --- [Navigation] Use local history for subframes https://bugs.webkit.org/show_bug.cgi?id=268451 Reviewed by Alex Christensen. Use local history for subframes rather than the global history from the page. This is tested by back-forward-out-of-bounds.html. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-back-forward-cross-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/back-forward-out-of-bounds-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateNavigationAPIEntries): Canonical link: https://commits.webkit.org/275776@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6dc9c6: [LBSE] Fix svg/repaint/image-with-clip-path.svg
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dc9c6a25c09a9b226ac1d692b4dcad6b29be15b https://github.com/WebKit/WebKit/commit/6dc9c6a25c09a9b226ac1d692b4dcad6b29be15b Author: Rob Buis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- [LBSE] Fix svg/repaint/image-with-clip-path.svg https://bugs.webkit.org/show_bug.cgi?id=270187 Reviewed by Nikolas Zimmermann. On a transform change from identity matrix to non-identity matrix the render layer needs to become a stacking context without relying on a style update in the case of LBSE. Add logic for this in repaintOrRelayoutAfterSVGTransformChange. Also add a correction to only call updateLayerTransform once in repaintOrRelayoutAfterSVGTransformChange. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::repaintOrRelayoutAfterSVGTransformChange): Canonical link: https://commits.webkit.org/275683@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 880753: [LBSE] Support outlines
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88075355648c45f1260590232b05804af2ea95b6 https://github.com/WebKit/WebKit/commit/88075355648c45f1260590232b05804af2ea95b6 Author: Rob Buis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.h M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp Log Message: --- [LBSE] Support outlines https://bugs.webkit.org/show_bug.cgi?id=269917 Reviewed by Nikolas Zimmermann. Support outline painting by adding and using RenderSVGModelObject::paintSVGOutline as well as using default LayoutRepainter mode of including outlines in repaint rectangle calculations. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::paintSVGOutline): * Source/WebCore/rendering/svg/RenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::layout): (WebCore::RenderSVGShape::paint): Canonical link: https://commits.webkit.org/275682@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44a5e9: Add logic to determine hasUAVisualTransition value
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a https://github.com/WebKit/WebKit/commit/44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a Author: Rob Buis Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/PopStateEvent.h M Source/WebCore/page/Page.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- Add logic to determine hasUAVisualTransition value https://bugs.webkit.org/show_bug.cgi?id=264748 Reviewed by Simon Fraser. Add logic to determine hasUAVisualTransition value for PopStateEvent when swiping on navigation and add a test to verify this. Rename FreezeLayerTreeDueToSwipeAnimation/UnfreezeLayerTreeDueToSwipeAnimation messages to the more generic SwipeAnimationDidStart/swipeAnimationDidEnd, since now it needs to handle both layer tree freezing as well as detecting the swipe on the Page for hasUAVisualTransition determination. * LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt: Added. * LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html: Added. * Source/WebCore/dom/Document.cpp: (WebCore::Document::dispatchPopstateEvent): * Source/WebCore/dom/PopStateEvent.h: * Source/WebCore/page/Page.h: (WebCore::Page::setIsInSwipeAnimation): (WebCore::Page::isInSwipeAnimation const): * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::swipeAnimationDidEnd): (WebKit::ProvisionalPageProxy::unfreezeLayerTreeDueToSwipeAnimation): Deleted. * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::commitProvisionalPage): (WebKit::WebPageProxy::navigationGestureWillEnd): (WebKit::WebPageProxy::navigationGestureDidEnd): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::swipeAnimationDidStart): (WebKit::WebPage::swipeAnimationDidEnd): (WebKit::WebPage::freezeLayerTreeDueToSwipeAnimation): Deleted. (WebKit::WebPage::unfreezeLayerTreeDueToSwipeAnimation): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/275438@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd25a0: Regression (Safari 17 vs 16.5, 261003@main): heigh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd25a04355e3584bf5615720b1e48f90796b6c1e https://github.com/WebKit/WebKit/commit/dd25a04355e3584bf5615720b1e48f90796b6c1e Author: Rob Buis Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderGrid.h Log Message: --- Regression (Safari 17 vs 16.5, 261003@main): height collapsing on auto-height image when container-type set on parent https://bugs.webkit.org/show_bug.cgi?id=268874 Reviewed by Alan Baradlay. In r261003 isComputingSizeOrInlineSizeContainment was used which did not consider grid track sizing direction. Fix that by using shouldCheckExplicitIntrinsicInnerLogicalSize which will take the direction into account. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html: Added. * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const): * Source/WebCore/rendering/RenderGrid.h: Canonical link: https://commits.webkit.org/275376@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25a983: Improve SVG Markers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25a983afbde5c58bd75b054a5fdd511e28216d8e https://github.com/WebKit/WebKit/commit/25a983afbde5c58bd75b054a5fdd511e28216d8e Author: Rob Buis Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/svg/SVGMarkerData.h Log Message: --- Improve SVG Markers https://bugs.webkit.org/show_bug.cgi?id=269789 Reviewed by Nikolas Zimmermann. Fix the following problems: - if the previous segment was a move to, we need to calculate the previous (mid-marker) segment orientation as a start marker - if we are now moving to a new subpath, the previous (mid-marker) segment orientation should be calculated as an end marker - don't calculate the out slope if we are moving to a new suboath Fixes: web-platform-tests/svg/painting/reftests/marker-path-011.svg web-platform-tests/svg/painting/reftests/marker-path-012.svg * LayoutTests/TestExpectations: * Source/WebCore/rendering/svg/SVGMarkerData.h: (WebCore::SVGMarkerData::SVGMarkerData): (WebCore::SVGMarkerData::updateFromPathElement): Canonical link: https://commits.webkit.org/275167@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07ca7d: [Navigation] Implement more of NavigationHistoryEntry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07ca7d40e32bb25bfc5ba2bc2e41870d0b20e5bc https://github.com/WebKit/WebKit/commit/07ca7d40e32bb25bfc5ba2bc2e41870d0b20e5bc Author: Rob Buis Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/NavigationHistoryEntry.cpp M Source/WebCore/page/NavigationHistoryEntry.h Log Message: --- [Navigation] Implement more of NavigationHistoryEntry https://bugs.webkit.org/show_bug.cgi?id=268986 Reviewed by Alex Christensen. Implement more of NavigationHistoryEntry according to the specification: - implement index by looking the NavigationHistoryEntry up in the entries of the associated Navigation object. - implement sameDocument by checking whether it is same document to the current history item. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::back): (WebCore::Navigation::forward): * Source/WebCore/page/NavigationHistoryEntry.cpp: (WebCore::NavigationHistoryEntry::NavigationHistoryEntry): (WebCore::NavigationHistoryEntry::index const): (WebCore::NavigationHistoryEntry::sameDocument const): * Source/WebCore/page/NavigationHistoryEntry.h: Canonical link: https://commits.webkit.org/275153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c443c9: Fix custom/pattern-userSpaceOnUse-userToBaseTransf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c443c971c715d48e5b9031f62c0926d05f27310c https://github.com/WebKit/WebKit/commit/c443c971c715d48e5b9031f62c0926d05f27310c Author: Rob Buis Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h Log Message: --- Fix custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml https://bugs.webkit.org/show_bug.cgi?id=269234 Reviewed by Nikolas Zimmermann. When determining RenderSVGRoot as root layer we also calculate any padding/border values as part of offsetFromAncestor, this means for patterns painting would be wrongly offset for pattern content. Instead, use the RenderSVGRoot, viewport as root layer which discards any border/padding for the pattern content painting. * LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintSVGResourceLayer): (WebCore::RenderLayer::enclosingSVGRootLayer const): Deleted. * Source/WebCore/rendering/RenderLayer.h: Canonical link: https://commits.webkit.org/275117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba02cc: Displayed datalist dropdown is out of sync with da...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba02cc6aade5caa1ddecb92778f6bfe82d5bef25 https://github.com/WebKit/WebKit/commit/ba02cc6aade5caa1ddecb92778f6bfe82d5bef25 Author: Rob Buis Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: A LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-expected.txt A LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown-expected.txt A LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown.html A LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options.html M Source/WebCore/html/DataListSuggestionInformation.h M Source/WebCore/html/HTMLDataListElement.cpp M Source/WebCore/html/HTMLDataListElement.h M Source/WebCore/html/TextFieldInputType.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm Log Message: --- Displayed datalist dropdown is out of sync with datalist options elements after DOM update https://bugs.webkit.org/show_bug.cgi?id=201121 Reviewed by Aditya Keerthi. Adding datalist dropdown items by dynamically inserting options to the datalist on keydown/input change was not taking effect right away. To fix this, detect datalist DOM changes through HTMLDataListElement::childrenChanged and notify the corresponding input. This will eventually land in TextFieldInputType::dataListMayHaveChanged which now ends with trying to display the suggestions if the input is focused. Note that here a new DataListSuggestionActivationType value DataListMayHaveChanged is added to distinguish from current usages (text changed, indicator/control clicked). * LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-expected.txt: Added. * LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown-expected.txt: Added. * LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options-on-keydown.html: Added. * LayoutTests/fast/forms/datalist/datalist-textinput-dynamically-add-options.html: Added. * Source/WebCore/html/DataListSuggestionInformation.h: * Source/WebCore/html/HTMLDataListElement.cpp: (WebCore::HTMLDataListElement::childrenChanged): * Source/WebCore/html/HTMLDataListElement.h: * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::dataListMayHaveChanged): (WebCore::TextFieldInputType::displaySuggestions): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (-[WKDataListSuggestionsDropdown _displayWithActivationType:]): Canonical link: https://commits.webkit.org/274608@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ddf79: [Navigation] Implement canGoForward/canGoBackward
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ddf79a30220e5397021a067a8d6e17455a0281b https://github.com/WebKit/WebKit/commit/1ddf79a30220e5397021a067a8d6e17455a0281b Author: Rob Buis Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Implement canGoForward/canGoBackward https://bugs.webkit.org/show_bug.cgi?id=268454 Reviewed by Anne van Kesteren. Implement canGoForward/canGoBackward as specified here: https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-cangoback https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-cangoforward This PR also makes m_currentEntryIndex a std::optional, this is more convenient as it avoids signed/unsigned confusion/casting. * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::canGoBack const): (WebCore::Navigation::canGoForward const): (WebCore::Navigation::currentEntry const): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/274542@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58d446: [content-visibility] Optimize lazy layout
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58d4460957a8b92c7109bddc65c5972a556aceb2 https://github.com/WebKit/WebKit/commit/58d4460957a8b92c7109bddc65c5972a556aceb2 Author: Rob Buis Date: 2024-02-12 (Mon, 12 Feb 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-getboundingclientrect-on-children-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-getboundingclientrect-on-children.html M Source/WebCore/dom/Document.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderElementInlines.h M Source/WebCore/rendering/RenderGrid.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- [content-visibility] Optimize lazy layout https://bugs.webkit.org/show_bug.cgi?id=263327 Reviewed by Alan Baradlay. Keep track of whether a hidden content-visibility subtree has been laid out using a dedicated bit named everHadSkippedContentLayout, and only force layout if everHadSkippedContentLayout is false. In order to make clearNeedsLayoutForSkippedContent work correctly the everHadSkippedContentLayout bit is cleared for the whole content-visibility subtree. This patch also merges isSkippedContentRootForLayout and isSkippedContentRoot since it was not always clear which one to call and was a source of bugs. The new behaviour is now to always take layout into account, but for size containment related code the static WebCore::isSkippedContentRoot is used that does not take layout into account since size containment determination should be invariant to (forced) layout. The test content-visibility-getboundingclientrect-on-children.html is added to verify layout is forced only once for subtrees. Canonical link: https://commits.webkit.org/274490@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2a19b: [LBSE] Allow tests that pass with the default tole...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2a19bd2cf7ae20372d9131c95c61890c195b3b6 https://github.com/WebKit/WebKit/commit/b2a19bd2cf7ae20372d9131c95c61890c195b3b6 Author: Rob Buis Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-pattern-and-object-creation-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-deep-referencing-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-incorrect-tiling-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaled-pattern-space-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaling-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-skew-transformed-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-with-transformation-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/transformed-pattern-clamp-svg-root-expected.txt Log Message: --- [LBSE] Allow tests that pass with the default tolerance https://bugs.webkit.org/show_bug.cgi?id=268812 Reviewed by Nikolas Zimmermann. So far tests have been mostly run with tolerance=0, however some tests have only a few pixel difference and pass with the default tolerance, so allow these. Reasons for pixel differences imay well be gpu process related. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-deep-referencing-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-incorrect-tiling-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaled-pattern-space-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaling-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-skew-transformed-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-with-transformation-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added. Canonical link: https://commits.webkit.org/274143@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4633ac: [LBSE] Fix svg/custom/use-nested-symbol-viewport.html
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4633ac0a7a7cbcc3d5975cab4d05f269ca707ffd https://github.com/WebKit/WebKit/commit/4633ac0a7a7cbcc3d5975cab4d05f269ca707ffd Author: Rob Buis Date: 2024-02-06 (Tue, 06 Feb 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp Log Message: --- [LBSE] Fix svg/custom/use-nested-symbol-viewport.html https://bugs.webkit.org/show_bug.cgi?id=268810 Reviewed by Nikolas Zimmermann. Percentages needs to be resolved in the generated svg context, not the original use context. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::additionalContainerTranslation const): Canonical link: https://commits.webkit.org/274138@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f1e7f: [LBSE] Fix use-on-clip-path-with-transformation.svg
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f1e7f15120b48bfc0aa895a6783c5c1dfcf4f9a https://github.com/WebKit/WebKit/commit/3f1e7f15120b48bfc0aa895a6783c5c1dfcf4f9a Author: Rob Buis Date: 2024-02-04 (Sun, 04 Feb 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/use-on-clip-path-with-transformation-expected.txt M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp Log Message: --- [LBSE] Fix use-on-clip-path-with-transformation.svg https://bugs.webkit.org/show_bug.cgi?id=268283 Reviewed by Nikolas Zimmermann. pathFromGraphicsElement and the layer transform both contain the use x/y translate, so avoid calling pathFromGraphicsElement in the use case by instead directly calling pathFromGraphicsElement on the clip child. * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::computeClipPath const): Canonical link: https://commits.webkit.org/274074@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c63c8c: [LBSE] Fix pattern related dynamic-updates tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c63c8c15979ad610c3b40b7c374f8a388c1c51cc https://github.com/WebKit/WebKit/commit/c63c8c15979ad610c3b40b7c374f8a388c1c51cc Author: Rob Buis Date: 2024-02-02 (Fri, 02 Feb 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations R LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-size-bigger-than-target-size-expected.png M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/svg/SVGPatternElement.cpp Log Message: --- [LBSE] Fix pattern related dynamic-updates tests https://bugs.webkit.org/show_bug.cgi?id=268610 Reviewed by Nikolas Zimmermann. Make sure changing animated properties like x, y, width, height, etc. invalidate the pattern. This PR also fixes a last minute change from r273757. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-size-bigger-than-target-size-expected.png: Removed. * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildPattern): * Source/WebCore/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::svgAttributeChanged): Canonical link: https://commits.webkit.org/273985@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 649d51: Remove duplicated SVG clip path tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 649d511f93de1d6e06acbd1d00286fd18388afb0 https://github.com/WebKit/WebKit/commit/649d511f93de1d6e06acbd1d00286fd18388afb0 Author: Rob Buis Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations R LayoutTests/svg/clip-path/clip-path-clip-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-nested-twice-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-nested-twice.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-001-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-001.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-002-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-002.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-003-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-003.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-004-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-004.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-005-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-005.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-006-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-006.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-007-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-007.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-008-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-008.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-009-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-009.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-010-expected.svg R LayoutTests/svg/clip-path/clip-path-clip-rule-010.svg R LayoutTests/svg/clip-path/clip-path-clip.svg R LayoutTests/svg/clip-path/clip-path-content-clip-001-expected.svg R LayoutTests/svg/clip-path/clip-path-content-clip-001.svg R LayoutTests/svg/clip-path/clip-path-content-clip-002-expected.svg R LayoutTests/svg/clip-path/clip-path-content-clip-002.svg R LayoutTests/svg/clip-path/clip-path-content-clip-003-expected.svg R LayoutTests/svg/clip-path/clip-path-content-clip-003.svg R LayoutTests/svg/clip-path/clip-path-content-invisible-expected.svg R LayoutTests/svg/clip-path/clip-path-content-invisible.svg R LayoutTests/svg/clip-path/clip-path-content-syling-expected.svg R LayoutTests/svg/clip-path/clip-path-content-syling.svg R LayoutTests/svg/clip-path/clip-path-content-use-001-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-001.svg R LayoutTests/svg/clip-path/clip-path-content-use-002-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-002.svg R LayoutTests/svg/clip-path/clip-path-content-use-003-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-003.svg R LayoutTests/svg/clip-path/clip-path-content-use-004-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-004.svg R LayoutTests/svg/clip-path/clip-path-content-use-005-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-005.svg R LayoutTests/svg/clip-path/clip-path-content-use-006-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-006.svg R LayoutTests/svg/clip-path/clip-path-content-use-007-expected.svg R LayoutTests/svg/clip-path/clip-path-content-use-007.svg R LayoutTests/svg/clip-path/clip-path-css-transform-001-expected.svg R LayoutTests/svg/clip-path/clip-path-css-transform-001.svg R LayoutTests/svg/clip-path/clip-path-css-transform-002-expected.svg R LayoutTests/svg/clip-path/clip-path-css-transform-002.svg R LayoutTests/svg/clip-path/clip-path-css-transform-003-expected.svg R LayoutTests/svg/clip-path/clip-path-css-transform-003.svg R LayoutTests/svg/clip-path/clip-path-css-transform-004-expected.svg R LayoutTests/svg/clip-path/clip-path-css-transform-004.svg R LayoutTests/svg/clip-path/clip-path-dom-child-changes-expected.svg R LayoutTests/svg/clip-path/clip-path-dom-child-changes.svg R LayoutTests/svg/clip-path/clip-path-dom-clippathunits-expected.svg R LayoutTests/svg/clip-path/clip-path-dom-clippathunits.svg R LayoutTests/svg/clip-path/clip-path-dom-href-expected.svg R LayoutTests/svg/clip-path/clip-path-dom-href.svg R LayoutTests/svg/clip-path/clip-path-dom-id-expected.svg R LayoutTests/svg/clip-path/clip-path-dom-id.svg R LayoutTests/svg/clip-path/clip-path-invalid-expected.svg R LayoutTests/svg/clip-path/clip-path-invalid.svg R LayoutTests/svg/clip-path/clip-path-negative-scale-expected.svg R LayoutTests/svg/clip-path/clip-path-negative-scale.svg R LayoutTests/svg/clip-path/clip-path-no-content-001-expected.svg R LayoutTests/svg/clip-path/clip-path-no-content-001.svg R LayoutTests
[webkit-changes] [WebKit/WebKit] 3e8617: [LBSE] Fix css3/masking crashes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e861792fa615fba90248600581b1dca40d5c354 https://github.com/WebKit/WebKit/commit/3e861792fa615fba90248600581b1dca40d5c354 Author: Rob Buis Date: 2024-01-30 (Tue, 30 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- [LBSE] Fix css3/masking crashes https://bugs.webkit.org/show_bug.cgi?id=268381 Reviewed by Nikolas Zimmermann. This code did not take into account non-SVG elements can use SVG clippers, dix that. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::svgClipperResourceFromStyle const): (WebCore::RenderLayerModelObject::paintSVGClippingMask const): Canonical link: https://commits.webkit.org/273760@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db4c99: [LBSE] Implement support for patterns
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db4c995fc7b47368c3f67671b89c42dc632402a7 https://github.com/WebKit/WebKit/commit/db4c995fc7b47368c3f67671b89c42dc632402a7 Author: Rob Buis Date: 2024-01-30 (Tue, 30 Jan 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/batik/paints/patternRegionA-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/absolute-root-position-masking-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/absolute-sized-content-with-resources-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-update-pattern-child-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-update-pattern-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/oversized-pattern-scale-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-cycle-detection-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-cycle-detection-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-excessive-malloc-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-in-defs-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-no-pixelation-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-no-pixelation-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-gaps-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-size-bigger-than-target-size-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-y-offset-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-y-offset-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pending-resource-after-removal-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/recursive-pattern-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/pattern-object-bounding-box-update-pattern-content-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/pattern-user-space-on-use-update-pattern-content-expected.txt M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/pattern-no-pixelation-expected.png R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/pattern-skew-transformed-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/pattern-y-offset-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/recursive-pattern-expected.png A LayoutTests/svg/repaint/pattern-object-bounding-box-expected.txt A LayoutTests/svg/repaint/pattern-object-bounding-box-transformed-expected.txt A LayoutTests/svg/repaint/pattern-object-bounding-box-transformed.html A LayoutTests/svg/repaint/pattern-object-bounding-box-update-pattern-content-expected.txt A LayoutTests/svg/repaint/pattern-object-bounding-box-update-pattern-content.html A LayoutTests/svg/repaint/pattern-object-bounding-box.html A LayoutTests/svg/repaint/pattern-user-space-on-use-expected.txt A LayoutTests/svg/repaint/pattern-user-space-on-use-transformed-expected.txt A LayoutTests/svg/repaint/pattern-user-space-on-use-transformed.html A LayoutTests/svg/repaint/pattern-user-space-on-use-update-pattern-content-expected.txt A LayoutTests/svg/repaint/pattern-user-space-on-use-update-pattern-content.html A LayoutTests/svg/repaint/pattern-user-space-on-use.html M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/RenderObject.h A Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp A Source/WebCore/rendering/svg/RenderSVGResourcePattern.h A Source/WebCore/rendering/svg/RenderSVGResourcePatternInlines.h M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourcePattern.cpp M Source/WebCore/svg/SVGElement.cpp M Source/WebCore/svg/SVGPatternElement.cpp Log Message: --- [LBSE] Implement support for patterns https://bugs.webkit.org/show_bug.cgi?id=267041 Reviewed by Nikolas Zimmermann. Implement pattern support using a different approach to legacy including the use of RenderLayer::paintSVGLayer ro
[webkit-changes] [WebKit/WebKit] b96b33: [Content-visibility][repaint] Boxes with "content-...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b96b33ee6c4c6dde7bf51c3744d6ccbc19a517e8
https://github.com/WebKit/WebKit/commit/b96b33ee6c4c6dde7bf51c3744d6ccbc19a517e8
Author: Rob Buis
Date: 2024-01-27 (Sat, 27 Jan 2024)
Changed paths:
A
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-c-v-auto-child-expected.txt
A
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-c-v-auto-child.html
A
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-child-expected.txt
A
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-child.html
A
LayoutTests/fast/repaint/position-relative-container-with-abs-pos-child-expected.txt
A
LayoutTests/fast/repaint/position-relative-container-with-abs-pos-child.html
M Source/WebCore/rendering/RenderElement.cpp
Log Message:
---
[Content-visibility][repaint] Boxes with "content-visibility: hidden" lingers
around
https://bugs.webkit.org/show_bug.cgi?id=264173
Reviewed by Simon Fraser.
When skipped content becomes hidden, a repaint should be issued to clear it,
before the style change is processed.
Add repaint logic for that similar to what is done when the visibility property
changes to hidden on an element.
However, absolute positioned elements are not always repainted correctly when
hidden and the container
changes. First, after layout repaints will have no effect since it is skipped
for layers with hidden content.
For the repaint before style change, the newly calculated clipped overflow
rectangle can be empty, causing the
artefact. Fix this by always using the cached clipped overflow ("old")
rectangle for out of flow elements, if
it is available, in before style change repainting.
*
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-c-v-auto-child-expected.txt:
Added.
*
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-c-v-auto-child.html:
Added.
*
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-child-expected.txt:
Added.
*
LayoutTests/fast/repaint/content-visibility-hidden-container-with-abs-pos-child.html:
Added.
*
LayoutTests/fast/repaint/position-relative-container-with-abs-pos-child-expected.txt:
Added.
* LayoutTests/fast/repaint/position-relative-container-with-abs-pos-child.html:
Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintBeforeStyleChange):
(WebCore::RenderElement::styleWillChange):
Canonical link: https://commits.webkit.org/273602@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
