[webkit-changes] [148072] trunk

[adamk]

Title: [148072] trunk








Revision 148072
Author ad...@chromium.org
Date 2013-04-09 18:11:50 -0700 (Tue, 09 Apr 2013)


Log Message
Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322

Reviewed by Darin Adler.

Source/WebCore:

Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.

An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.

Test: fast/events/event-listener-moving-documents.html

* dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.

LayoutTests:

* fast/events/event-listener-moving-documents-expected.txt: Added.
* fast/events/event-listener-moving-documents.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp


Added Paths

trunk/LayoutTests/fast/events/event-listener-moving-documents-expected.txt
trunk/LayoutTests/fast/events/event-listener-moving-documents.html




Diff

Modified: trunk/LayoutTests/ChangeLog (148071 => 148072)

--- trunk/LayoutTests/ChangeLog	2013-04-10 00:57:52 UTC (rev 148071)
+++ trunk/LayoutTests/ChangeLog	2013-04-10 01:11:50 UTC (rev 148072)
@@ -1,3 +1,13 @@
+2013-04-09  Adam Klein  ad...@chromium.org
+
+Update Document's event listener type bitfield when adopting a Node
+https://bugs.webkit.org/show_bug.cgi?id=114322
+
+Reviewed by Darin Adler.
+
+* fast/events/event-listener-moving-documents-expected.txt: Added.
+* fast/events/event-listener-moving-documents.html: Added.
+
 2013-04-09  Dongwoo Joshua Im  dw...@samsung.com
 
 [CSS3] Parsing the property, text-justify.


Added: trunk/LayoutTests/fast/events/event-listener-moving-documents-expected.txt (0 => 148072)

--- trunk/LayoutTests/fast/events/event-listener-moving-documents-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/event-listener-moving-documents-expected.txt	2013-04-10 01:11:50 UTC (rev 148072)
@@ -0,0 +1,12 @@
+Moving an event listener between documents should keep it active
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS addedCalls is 1
+PASS addedCalls is 2
+PASS removedCalls is 1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/events/event-listener-moving-documents.html (0 => 148072)

--- trunk/LayoutTests/fast/events/event-listener-moving-documents.html	(rev 0)
+++ trunk/LayoutTests/fast/events/event-listener-moving-documents.html	2013-04-10 01:11:50 UTC (rev 148072)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+body
+script src=""
+script
+description('Moving an event listener between documents should keep it active');
+
+var doc = document.implementation.createHTMLDocument('');
+var div = doc.createElement('div');
+var addedCalls = 0;
+var removedCalls = 0;
+div.addEventListener('DOMNodeInserted', function() { addedCalls++ });
+div.addEventListener('DOMNodeRemoved', function() { removedCalls++ });
+document.body.appendChild(div);
+shouldBe('addedCalls', '1');
+div.appendChild(document.createElement('span'));
+shouldBe('addedCalls', '2');
+div.removeChild(div.firstChild);
+shouldBe('removedCalls', '1');
+/script
+script src=""
+/body


Modified: trunk/Source/WebCore/ChangeLog (148071 => 148072)

--- trunk/Source/WebCore/ChangeLog	2013-04-10 00:57:52 UTC (rev 148071)
+++ trunk/Source/WebCore/ChangeLog	2013-04-10 01:11:50 UTC (rev 148072)
@@ -1,3 +1,25 @@
+2013-04-09  Adam Klein  ad...@chromium.org
+
+Update Document's event listener type bitfield when adopting a Node
+https://bugs.webkit.org/show_bug.cgi?id=114322
+
+Reviewed by Darin Adler.
+
+Without this, moving a Node between documents can silently deactivate
+an event listener, if it's one of the types that whose creation is
+optimized away by Document::hasListenerType.
+
+An alternate approach would be to simply copy the old document's
+bitfield over. It's a tradeoff between making adoption fast and making
+the operation of any operation depending on these event types fast.
+The latter seems like the right optimization given that adoption
+doesn't happen very often.
+
+Test: fast/events/event-listener-moving-documents.html
+
+* dom/Node.cpp:
+(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.
+
 2013-04-09  Dean Jackson  d...@apple.com
 
 Add logging channel for animations

[webkit-changes] [147441] trunk

[adamk]

Title: [147441] trunk








Revision 147441
Author ad...@chromium.org
Date 2013-04-02 09:14:40 -0700 (Tue, 02 Apr 2013)


Log Message
HTML parser should consistently inspect the namespace of elements on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=113723

Reviewed by Adam Barth.

Source/WebCore:

Added HTMLStackItem::matchesHTMLTag method and use that nearly
everywhere instead of HTMLStackItem::hasLocalName. The most important
of these changes is in HTMLElementStack's inScopeCommon() function,
where the use of matchesHTMLTag means that any of the inXXXScope()
calls now only match HTML tags.

Tests: html5lib/generated/run-namespace-sensitivity-data.html
   html5lib/generated/run-namespace-sensitivity-write.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):
(WebCore::HTMLElementStack::inButtonScope):
(WebCore::HTMLElementStack::inSelectScope):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::popUntilPopped):
* html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):
* html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::matchesHTMLTag):
(HTMLStackItem):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):

LayoutTests:

* html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
* html5lib/generated/run-namespace-sensitivity-data.html: Added.
* html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
* html5lib/generated/run-namespace-sensitivity-write.html: Added.
* html5lib/resources/namespace-sensitivity.dat: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
trunk/Source/WebCore/html/parser/HTMLElementStack.cpp
trunk/Source/WebCore/html/parser/HTMLElementStack.h
trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp
trunk/Source/WebCore/html/parser/HTMLStackItem.h
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp


Added Paths

trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data-expected.txt
trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data.html
trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-write-expected.txt
trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-write.html
trunk/LayoutTests/html5lib/resources/namespace-sensitivity.dat




Diff

Modified: trunk/LayoutTests/ChangeLog (147440 => 147441)

--- trunk/LayoutTests/ChangeLog	2013-04-02 16:00:28 UTC (rev 147440)
+++ trunk/LayoutTests/ChangeLog	2013-04-02 16:14:40 UTC (rev 147441)
@@ -1,3 +1,16 @@
+2013-04-02  Adam Klein  ad...@chromium.org
+
+HTML parser should consistently inspect the namespace of elements on the stack of open elements
+https://bugs.webkit.org/show_bug.cgi?id=113723
+
+Reviewed by Adam Barth.
+
+* html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
+* html5lib/generated/run-namespace-sensitivity-data.html: Added.
+* html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
+* html5lib/generated/run-namespace-sensitivity-write.html: Added.
+* html5lib/resources/namespace-sensitivity.dat: Added.
+
 2013-04-02  Andrei Bucur  abu...@adobe.com
 
 [Chromium] Unreviewed.


Added: trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data-expected.txt (0 => 147441)

--- trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data-expected.txt	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data-expected.txt	2013-04-02 16:14:40 UTC (rev 147441)
@@ -0,0 +1 @@
+../resources/namespace-sensitivity.dat: PASS


Added: trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data.html (0 => 147441)

--- trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data.html	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-data.html	2013-04-02 16:14:40 UTC (rev 147441)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+script
+var test_files = [ '../resources/namespace-sensitivity.dat' ]
+/script
+script src=""
+scriptwindow.forceDataURLs = true;/script
+script src=""


Added: trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-write-expected.txt (0 => 147441)

--- trunk/LayoutTests/html5lib/generated/run-namespace-sensitivity-write-expected.txt	(rev 0)
+++ 

[webkit-changes] [145379] trunk

[adamk]

Title: [145379] trunk








Revision 145379
Author ad...@chromium.org
Date 2013-03-11 12:16:01 -0700 (Mon, 11 Mar 2013)


Log Message
MutationCallback should be a WebIDL 'callback', not a [Callback] interface
https://bugs.webkit.org/show_bug.cgi?id=91406

Reviewed by Adam Barth.

Source/WebCore:

Spec: http://dom.spec.whatwg.org/#mutationcallback

Besides no longer calling handleEvent methods on passed-in objects,
throw a TypeError if a non-function is passed to the MutationObserver constructor.
This is per WebIDL: http://www.w3.org/TR/WebIDL/#es-callback-function

Updated MutationObserver constructor tests to exercise TypeError-throwing behavior.

* bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call): Call the callback directly instead of handing off to JSCallbackData; make return value void.
Use jsArray() to convert from WTF::Vector - JSArray.
* bindings/js/JSMutationCallback.h:
(JSMutationCallback): Rename handleEvent() to call(), make it void.
* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver): Throw if passed a non-function.
* bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback): Take a v8::Function instead of a v8::Object.
(WebCore::V8MutationCallback::call): Call the callback directly instead of handing off to invokeCallback(); make return value void.
Use v8Array() to convert form WTF::Vector - JSArray.
* bindings/v8/V8MutationCallback.h:
(WebCore::V8MutationCallback::create): Take a v8::Function instead of a v8::Object.
(V8MutationCallback): ditto
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCustom): Throw if passed a non-function, cast to a v8::Function when constructing callback.
* dom/MutationCallback.h:
(WebCore): Remove unnecessary typedef.
(MutationCallback): Rename handleEvent() to call(), make it void.
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliver): Update MutationCallback method name.

LayoutTests:

* fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
* fast/dom/MutationObserver/mutation-observer-constructor.html: Add test for TypeError-throwing.
Note that the Number and String cases already threw before this patch.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor-expected.txt
trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMutationCallback.cpp
trunk/Source/WebCore/bindings/js/JSMutationCallback.h
trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp
trunk/Source/WebCore/bindings/v8/V8MutationCallback.cpp
trunk/Source/WebCore/bindings/v8/V8MutationCallback.h
trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp
trunk/Source/WebCore/dom/MutationCallback.h
trunk/Source/WebCore/dom/MutationObserver.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (145378 => 145379)

--- trunk/LayoutTests/ChangeLog	2013-03-11 19:07:54 UTC (rev 145378)
+++ trunk/LayoutTests/ChangeLog	2013-03-11 19:16:01 UTC (rev 145379)
@@ -1,3 +1,14 @@
+2013-03-11  Adam Klein  ad...@chromium.org
+
+MutationCallback should be a WebIDL 'callback', not a [Callback] interface
+https://bugs.webkit.org/show_bug.cgi?id=91406
+
+Reviewed by Adam Barth.
+
+* fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
+* fast/dom/MutationObserver/mutation-observer-constructor.html: Add test for TypeError-throwing.
+Note that the Number and String cases already threw before this patch.
+
 2013-03-11  Julien Chaffraix  jchaffr...@webkit.org
 
 [CSS Grid Layout] Handle spanning grid items over specified grid tracks


Modified: trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor-expected.txt (145378 => 145379)

--- trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor-expected.txt	2013-03-11 19:07:54 UTC (rev 145378)
+++ trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor-expected.txt	2013-03-11 19:16:01 UTC (rev 145379)
@@ -8,6 +8,10 @@
 PASS typeof WebKitMutationObserver.prototype.disconnect is function
 PASS typeof observer.observe is function
 PASS typeof observer.disconnect is function
+PASS new MutationObserver({ handleEvent: function() {} }) threw exception TypeError: Callback argument must be a function.
+PASS new MutationObserver({}) threw exception TypeError: Callback argument must be a function.
+PASS new MutationObserver(42) threw exception TypeError: Callback argument must be a function.
+PASS new MutationObserver(foo) threw exception TypeError: Callback argument must be a function.
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor.html (145378 => 145379)

--- 

[webkit-changes] [145430] branches/chromium/1410

[adamk]

Title: [145430] branches/chromium/1410








Revision 145430
Author ad...@chromium.org
Date 2013-03-11 16:40:58 -0700 (Mon, 11 Mar 2013)


Log Message
Merge 144522 Don't leak Documents when using MutationObserver f...

 Don't leak Documents when using MutationObserver from extensions
 https://bugs.webkit.org/show_bug.cgi?id=111234
 
 Patch by Elliott Sprehn espr...@gmail.com on 2013-03-01
 Reviewed by Adam Barth.
 
 .:
 
 * ManualTests/leak-observer-nonmain-world.html: Added.
 
 Source/WebCore:
 
 MutationObserverCallback holds a WorldContextHandle which secretly isn't
 a handle to anything when it's for the main world. When it's for a non-main
 world though, like those used in extensions, it becomes a strong reference
 to the v8::Context which results in leaks by creating cycles:
 
 MutationObserver - Callback - World - Document - Node - MutationObserver.
 
 Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
 get the v8::Context from that inside handleEvent.
 
 Tests: ManualTests/leak-observer-nonmain-world.html
 
 * bindings/v8/V8Binding.cpp:
 (WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
 * bindings/v8/V8Binding.h:
 * bindings/v8/V8MutationCallback.cpp:
 (WebCore::V8MutationCallback::V8MutationCallback):
 (WebCore::V8MutationCallback::handleEvent):
 * bindings/v8/V8MutationCallback.h:
 (V8MutationCallback):

TBR=espr...@chromium.org

Modified Paths

branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.cpp
branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.h
branches/chromium/1410/Source/WebCore/bindings/v8/V8MutationCallback.cpp
branches/chromium/1410/Source/WebCore/bindings/v8/V8MutationCallback.h


Added Paths

branches/chromium/1410/ManualTests/leak-observer-nonmain-world.html




Diff

Copied: branches/chromium/1410/ManualTests/leak-observer-nonmain-world.html (from rev 144522, trunk/ManualTests/leak-observer-nonmain-world.html) (0 => 145430)

--- branches/chromium/1410/ManualTests/leak-observer-nonmain-world.html	(rev 0)
+++ branches/chromium/1410/ManualTests/leak-observer-nonmain-world.html	2013-03-11 23:40:58 UTC (rev 145430)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+
+pTest that using mutation observers from the non-main world doesn't leak the document./p
+pExpected output of this test is LEAK: 28 WebCoreNode/p
+
+iframe/iframe
+
+script
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+
+var iframe = document.querySelector('iframe');
+var count = 0;
+var totalRuns = 5;
+
+iframe._onload_ = function() {
+if (count++  totalRuns) {
+testRunner.evaluateScriptInIsolatedWorld(1, 'new MutationObserver(function(){}).observe(document, {childList: true, subtree: true});');
+iframe.srcdoc = bodyinput autofocus/body;
+GCController.collect();
+} else {
+GCController.collect();
+testRunner.notifyDone();
+}
+};
+
+// Need autofocus since evaluateScriptInIsolatedWorld runs in the focused frame.
+iframe.srcdoc = bodyinput autofocus/body;
+/script
+


Modified: branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.cpp (145429 => 145430)

--- branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.cpp	2013-03-11 23:40:36 UTC (rev 145429)
+++ branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.cpp	2013-03-11 23:40:58 UTC (rev 145430)
@@ -266,6 +266,26 @@
 return v8::Localv8::Context();
 }
 
+v8::Localv8::Context toV8Context(ScriptExecutionContext* context, DOMWrapperWorld* world)
+{
+if (context-isDocument()) {
+if (Frame* frame = static_castDocument*(context)-frame()) {
+// FIXME: Store the DOMWrapperWorld for the main world in the v8::Context so callers
+// that are looking up their world with DOMWrapperWorld::getWorld(v8::Context::GetCurrent())
+// won't end up passing null here when later trying to get their v8::Context back.
+if (!world)
+return frame-script()-mainWorldContext();
+return v8::Localv8::Context::New(frame-script()-windowShell(world)-context());
+}
+#if ENABLE(WORKERS)
+} else if (context-isWorkerContext()) {
+if (WorkerScriptController* script = static_castWorkerContext*(context)-script())
+return script-context();
+#endif
+}
+return v8::Localv8::Context();
+}
+
 bool handleOutOfMemory()
 {
 v8::Localv8::Context context = v8::Context::GetCurrent();


Modified: branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.h (145429 => 145430)

--- branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.h	2013-03-11 23:40:36 UTC (rev 145429)
+++ branches/chromium/1410/Source/WebCore/bindings/v8/V8Binding.h	2013-03-11 23:40:58 UTC (rev 145430)
@@ -432,6 +432,7 @@
 
 // Returns the context associated with a ScriptExecutionContext.
 v8::Localv8::Context toV8Context(ScriptExecutionContext*, const WorldContextHandle);
+v8::Localv8::Context toV8Context(ScriptExecutionContext*, DOMWrapperWorld*);
 
  

[webkit-changes] [144994] trunk

[adamk]

Title: [144994] trunk








Revision 144994
Author ad...@chromium.org
Date 2013-03-06 15:56:27 -0800 (Wed, 06 Mar 2013)


Log Message
[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382

Reviewed by Adam Barth.

.:

* ManualTests/mutation-observer-leaks-nodes.html: Added.

Source/WebCore:

Two-phase approach to implicit references: after grouping objects
together, add an implicit reference between each registered node's
group and the MutationObserver's group (which includes wrappers from
all worlds).

Also changed many uses of v8::Value to v8::Object where we know we're
dealing with Object and the V8 API expects them.

Test: ManualTests/mutation-observer-leaks-nodes.html

* bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::wrapper):
(ImplicitConnection):
(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
(ImplicitReference):
(WebCore::operator): Needed for std::sort() call to avoid the overhead of using a HashMap
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
(WebCore::WrapperGrouper::addImplicitReference):
(WrapperGrouper):
(WebCore::WrapperGrouper::apply):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8GCController.cpp


Added Paths

trunk/ManualTests/mutation-observer-leaks-nodes.html




Diff

Modified: trunk/ChangeLog (144993 => 144994)

--- trunk/ChangeLog	2013-03-06 23:25:19 UTC (rev 144993)
+++ trunk/ChangeLog	2013-03-06 23:56:27 UTC (rev 144994)
@@ -1,3 +1,12 @@
+2013-03-06  Adam Klein  ad...@chromium.org
+
+[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
+https://bugs.webkit.org/show_bug.cgi?id=111382
+
+Reviewed by Adam Barth.
+
+* ManualTests/mutation-observer-leaks-nodes.html: Added.
+
 2013-03-06  Gustavo Noronha Silva  g...@gnome.org
 
 Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,


Added: trunk/ManualTests/mutation-observer-leaks-nodes.html (0 => 144994)

--- trunk/ManualTests/mutation-observer-leaks-nodes.html	(rev 0)
+++ trunk/ManualTests/mutation-observer-leaks-nodes.html	2013-03-06 23:56:27 UTC (rev 144994)
@@ -0,0 +1,14 @@
+!DOCTYPE html
+body
+script
+testRunner.dumpAsText();
+var count = 100;
+var observer = new MutationObserver(function(){});
+for (var i = 0; i  count; i++) {
+var span = document.createElement('span');
+observer.observe(span, {attributes:true});
+};
+GCController.collect();
+/script
+pNumber of leaked nodes reported by DRT should be less than 100/p
+/body


Modified: trunk/Source/WebCore/ChangeLog (144993 => 144994)

--- trunk/Source/WebCore/ChangeLog	2013-03-06 23:25:19 UTC (rev 144993)
+++ trunk/Source/WebCore/ChangeLog	2013-03-06 23:56:27 UTC (rev 144994)
@@ -1,3 +1,33 @@
+2013-03-06  Adam Klein  ad...@chromium.org
+
+[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
+https://bugs.webkit.org/show_bug.cgi?id=111382
+
+Reviewed by Adam Barth.
+
+Two-phase approach to implicit references: after grouping objects
+together, add an implicit reference between each registered node's
+group and the MutationObserver's group (which includes wrappers from
+all worlds).
+
+Also changed many uses of v8::Value to v8::Object where we know we're
+dealing with Object and the V8 API expects them.
+
+Test: ManualTests/mutation-observer-leaks-nodes.html
+
+* bindings/v8/V8GCController.cpp:
+(WebCore::ImplicitConnection::ImplicitConnection):
+(WebCore::ImplicitConnection::wrapper):
+(ImplicitConnection):
+(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
+(ImplicitReference):
+(WebCore::operator): Needed for std::sort() call to avoid the overhead of using a HashMap
+(WebCore::WrapperGrouper::addObjectWrapperToGroup):
+(WebCore::WrapperGrouper::addNodeWrapperToGroup):
+(WebCore::WrapperGrouper::addImplicitReference):
+(WrapperGrouper):
+(WebCore::WrapperGrouper::apply):
+
 2013-03-06  Ankur Taly  at...@google.com
 
 Modify log method in V8DOMActivityLogger so that the apiName and


Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (144993 => 144994)

--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2013-03-06 23:25:19 UTC (rev 144993)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2013-03-06 23:56:27 UTC (rev 144994)
@@ -49,13 +49,13 @@
 
 class ImplicitConnection {
 public:
-ImplicitConnection(void* root, v8::Persistentv8::Value wrapper)
+

[webkit-changes] [144030] trunk/Source/WebCore

[adamk]

Title: [144030] trunk/Source/WebCore








Revision 144030
Author ad...@chromium.org
Date 2013-02-26 02:40:12 -0800 (Tue, 26 Feb 2013)


Log Message
Remove unused conditional includes of {MathML,SVG}Names.h
https://bugs.webkit.org/show_bug.cgi?id=110809

Reviewed by Eric Seidel.

* html/parser/HTMLConstructionSite.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (144029 => 144030)

--- trunk/Source/WebCore/ChangeLog	2013-02-26 10:30:29 UTC (rev 144029)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 10:40:12 UTC (rev 144030)
@@ -1,3 +1,12 @@
+2013-02-26  Adam Klein  ad...@chromium.org
+
+Remove unused conditional includes of {MathML,SVG}Names.h
+https://bugs.webkit.org/show_bug.cgi?id=110809
+
+Reviewed by Eric Seidel.
+
+* html/parser/HTMLConstructionSite.cpp:
+
 2013-02-26  Eric Seidel  e...@webkit.org
 
 Threaded HTML parser fails fast/loader/stateobjects/state-attribute-history-getter.html


Modified: trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp (144029 => 144030)

--- trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2013-02-26 10:30:29 UTC (rev 144029)
+++ trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp	2013-02-26 10:40:12 UTC (rev 144030)
@@ -46,13 +46,7 @@
 #include HTMLToken.h
 #include HTMLTokenizer.h
 #include LocalizedStrings.h
-#if ENABLE(MATHML)
-#include MathMLNames.h
-#endif
 #include NotImplemented.h
-#if ENABLE(SVG)
-#include SVGNames.h
-#endif
 #include Settings.h
 #include Text.h
 #include wtf/UnusedParam.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144128] trunk

[adamk]

Title: [144128] trunk








Revision 144128
Author ad...@chromium.org
Date 2013-02-26 17:05:07 -0800 (Tue, 26 Feb 2013)


Log Message
Parsing of HTML tags in MathML Text Insertion Points leads to bogus parser behavior
https://bugs.webkit.org/show_bug.cgi?id=110808

Reviewed by Adam Barth.

Source/WebCore:

When looking for various table tags in the HTMLElementStack, compare
QualifiedNames rather than just local names, where necessary.

Note that not all uses have been fixed; I've only changed for which
I could write a test with differing behavior. A followup patch to
rationalize the use of QualifiedName vs local names would be ideal.

Tests: html5lib/generated/run-math-data.html
   html5lib/generated/run-math-write.html

* html/parser/HTMLElementStack.cpp:
(WebCore::inScopeCommon): Added a version of inScopeCommon that
handles QualifiedNames instead of just localNames.
(WebCore::HTMLElementStack::inTableScope): When given a QualifiedName,
call the new version of inScopeCommon().
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):

LayoutTests:

* html5lib/generated/run-math-data-expected.txt: Added.
* html5lib/generated/run-math-data.html: Added.
* html5lib/generated/run-math-write-expected.txt: Added.
* html5lib/generated/run-math-write.html: Added.
* html5lib/resources/math.dat: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLElementStack.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp


Added Paths

trunk/LayoutTests/html5lib/generated/run-math-data-expected.txt
trunk/LayoutTests/html5lib/generated/run-math-data.html
trunk/LayoutTests/html5lib/generated/run-math-write-expected.txt
trunk/LayoutTests/html5lib/generated/run-math-write.html
trunk/LayoutTests/html5lib/resources/math.dat




Diff

Modified: trunk/LayoutTests/ChangeLog (144127 => 144128)

--- trunk/LayoutTests/ChangeLog	2013-02-27 01:01:19 UTC (rev 144127)
+++ trunk/LayoutTests/ChangeLog	2013-02-27 01:05:07 UTC (rev 144128)
@@ -1,3 +1,16 @@
+2013-02-26  Adam Klein  ad...@chromium.org
+
+Parsing of HTML tags in MathML Text Insertion Points leads to bogus parser behavior
+https://bugs.webkit.org/show_bug.cgi?id=110808
+
+Reviewed by Adam Barth.
+
+* html5lib/generated/run-math-data-expected.txt: Added.
+* html5lib/generated/run-math-data.html: Added.
+* html5lib/generated/run-math-write-expected.txt: Added.
+* html5lib/generated/run-math-write.html: Added.
+* html5lib/resources/math.dat: Added.
+
 2013-02-26  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Notification.requestPermission callback should be optional


Added: trunk/LayoutTests/html5lib/generated/run-math-data-expected.txt (0 => 144128)

--- trunk/LayoutTests/html5lib/generated/run-math-data-expected.txt	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-math-data-expected.txt	2013-02-27 01:05:07 UTC (rev 144128)
@@ -0,0 +1 @@
+../resources/math.dat: PASS


Added: trunk/LayoutTests/html5lib/generated/run-math-data.html (0 => 144128)

--- trunk/LayoutTests/html5lib/generated/run-math-data.html	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-math-data.html	2013-02-27 01:05:07 UTC (rev 144128)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+script
+var test_files = [ '../resources/math.dat' ]
+/script
+script src=""
+scriptwindow.forceDataURLs = true;/script
+script src=""


Added: trunk/LayoutTests/html5lib/generated/run-math-write-expected.txt (0 => 144128)

--- trunk/LayoutTests/html5lib/generated/run-math-write-expected.txt	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-math-write-expected.txt	2013-02-27 01:05:07 UTC (rev 144128)
@@ -0,0 +1 @@
+../resources/math.dat: PASS


Added: trunk/LayoutTests/html5lib/generated/run-math-write.html (0 => 144128)

--- trunk/LayoutTests/html5lib/generated/run-math-write.html	(rev 0)
+++ trunk/LayoutTests/html5lib/generated/run-math-write.html	2013-02-27 01:05:07 UTC (rev 144128)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+script
+var test_files = [ '../resources/math.dat' ]
+/script
+script src=""
+
+script src=""


Added: trunk/LayoutTests/html5lib/resources/math.dat (0 => 144128)

--- trunk/LayoutTests/html5lib/resources/math.dat	(rev 0)
+++ trunk/LayoutTests/html5lib/resources/math.dat	2013-02-27 01:05:07 UTC (rev 144128)
@@ -0,0 +1,81 @@
+#data
+mathtrtdmotr
+#errors
+#document-fragment
+td
+#document
+| math math
+|   math tr
+| math td
+|   math mo
+
+#data
+mathtrtdmotr
+#errors
+#document-fragment
+tr
+#document
+| math math
+|   math tr
+| math td
+|   math mo
+
+#data
+maththeadmotbody
+#errors
+#document-fragment
+thead
+#document
+| math math
+|   math thead
+| math mo
+
+#data
+mathtfootmotbody
+#errors

[webkit-changes] [143526] trunk/Source/WebCore

[adamk]

Title: [143526] trunk/Source/WebCore








Revision 143526
Author ad...@chromium.org
Date 2013-02-20 16:00:33 -0800 (Wed, 20 Feb 2013)


Log Message
[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

* bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (143525 => 143526)

--- trunk/Source/WebCore/ChangeLog	2013-02-20 23:59:55 UTC (rev 143525)
+++ trunk/Source/WebCore/ChangeLog	2013-02-21 00:00:33 UTC (rev 143526)
@@ -1,3 +1,16 @@
+2013-02-20  Adam Klein  ad...@chromium.org
+
+[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
+https://bugs.webkit.org/show_bug.cgi?id=110396
+
+Reviewed by Kentaro Hara.
+
+This is in preparation for a refactor to expose a simplified
+WrapperGrouper interface to V8 wrapper classes enabling them to
+specify multiple roots per wrapper object. 
+
+* bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
+
 2013-02-20  Levi Weintraub  le...@chromium.org
 
 Line layout (but not pref widths) double-counts word spacing when between inlines


Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (143525 => 143526)

--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2013-02-20 23:59:55 UTC (rev 143525)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2013-02-21 00:00:33 UTC (rev 143526)
@@ -311,7 +311,7 @@
 MutationObserver* observer = static_castMutationObserver*(object);
 HashSetNode* observedNodes = observer-getObservedNodes();
 for (HashSetNode*::iterator it = observedNodes.begin(); it != observedNodes.end(); ++it)
-m_grouper.addNodeToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
+m_grouper.addObjectToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
 } else {
 ActiveDOMObject* activeDOMObject = type-toActiveDOMObject(wrapper);
 if (activeDOMObject  activeDOMObject-hasPendingActivity())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140715] trunk/LayoutTests

[adamk]

Title: [140715] trunk/LayoutTests








Revision 140715
Author ad...@chromium.org
Date 2013-01-24 13:16:32 -0800 (Thu, 24 Jan 2013)


Log Message
Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=106612

Reviewed by Eric Seidel.

* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Wait for
the iframe's onload event before running the test.
* platform/chromium/TestExpectations: Remove flaky expectation.
* platform/efl/TestExpectations: ditto
* platform/gtk/TestExpectations: ditto

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (140714 => 140715)

--- trunk/LayoutTests/ChangeLog	2013-01-24 21:09:29 UTC (rev 140714)
+++ trunk/LayoutTests/ChangeLog	2013-01-24 21:16:32 UTC (rev 140715)
@@ -1,3 +1,16 @@
+2013-01-24  Adam Klein  ad...@chromium.org
+
+Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=106612
+
+Reviewed by Eric Seidel.
+
+* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Wait for
+the iframe's onload event before running the test.
+* platform/chromium/TestExpectations: Remove flaky expectation.
+* platform/efl/TestExpectations: ditto
+* platform/gtk/TestExpectations: ditto
+
 2013-01-24  Tony Chang  t...@chromium.org
 
 Remove document as a parameter from a few internals methods


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html (140714 => 140715)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html	2013-01-24 21:09:29 UTC (rev 140714)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html	2013-01-24 21:16:32 UTC (rev 140715)
@@ -1,22 +1,28 @@
 !DOCTYPE html
 body
 templatediv/div/template
-iframe srcdoc=templatediv/div/template style=display:none/iframe
 script src=""
 script
 description('Adopting a template from another document should also switch the template content document');
+jsTestIsAsync = true;
 
-var template = document.querySelector('template');
-var frameTemplate = frames[0].document.querySelector('template');
+var template;
+var frameTemplate;
+function test() {
+template = document.querySelector('template');
+frameTemplate = frames[0].document.querySelector('template');
 
-debug('Before adoption:');
-shouldNotBe('template.ownerDocument', 'frameTemplate.ownerDocument');
-shouldNotBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
-frameTemplate = document.adoptNode(frameTemplate);
-debug('\nAfter adoption:');
-shouldBe('template.ownerDocument', 'frameTemplate.ownerDocument');
-shouldBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
-debug('');
+debug('Before adoption:');
+shouldNotBe('template.ownerDocument', 'frameTemplate.ownerDocument');
+shouldNotBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
+frameTemplate = document.adoptNode(frameTemplate);
+debug('\nAfter adoption:');
+shouldBe('template.ownerDocument', 'frameTemplate.ownerDocument');
+shouldBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
+debug('');
+finishJSTest();
+}
 /script
 script src=""
+iframe srcdoc=templatediv/div/template _onload_=test() style=display:none/iframe
 /body


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (140714 => 140715)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-24 21:09:29 UTC (rev 140714)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-24 21:16:32 UTC (rev 140715)
@@ -4289,7 +4289,6 @@
 webkit.org/b/103955 fast/repaint/selection-rl.html [ ImageOnlyFailure ]
 webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]
 webkit.org/b/106609 [ Win ] animations/fill-mode-iteration-count-non-integer.html [ Failure ]
-webkit.org/b/106612 [ Win ] fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html [ Failure Pass ]
 
 webkit.org/b/106689 canvas/philip/tests/2d.gradient.interpolate.overlap2.html [ Failure ]
 webkit.org/b/106689 canvas/philip/tests/2d.gradient.linear.transform.1.html [ Failure ]


Modified: trunk/LayoutTests/platform/efl/TestExpectations (140714 => 140715)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-24 21:09:29 UTC (rev 140714)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-24 21:16:32 UTC (rev 140715)
@@ -1775,9 +1775,6 @@
 webkit.org/b/106015 fast/css-generated-content/pseudo-animation.html [ Failure ]
 webkit.org/b/106015 fast/css-generated-content/pseudo-transition.html [ Failure ]
 
-# New test introduced in r138756 is failing.

[webkit-changes] [138841] trunk/Source/WebCore

[adamk]

Title: [138841] trunk/Source/WebCore








Revision 138841
Author ad...@chromium.org
Date 2013-01-04 13:03:20 -0800 (Fri, 04 Jan 2013)


Log Message
[v8] Stop using an IDL to generate V8MutationCallback
https://bugs.webkit.org/show_bug.cgi?id=106122

Reviewed by Adam Barth.

The only real code in the generated V8MutationCallback.{h,cpp} files
were specifically written in CodeGeneratorV8 for its use. By instead
Using completely-hand-written versions of these files, the
CodeGenerator can be simplified (as can all generated Callbacks).
All the actually shared code is still shared via subclassing of
ActiveDOMCallback.

This introduces additional flexibility into the implementation of
MutationCallback which will be used when fixing the MutationObserver
memory leak (http://webkit.org/b/90661) for JSC.

No changes to JSC for now, just a FIXME in the IDL file.

No new tests, refactoringonly.

* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::V8TestCallback):
* bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::create):
(V8TestCallback):
* bindings/v8/V8MutationCallback.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp.
(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/V8MutationCallback.h: Added.
(V8MutationCallback):
(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):
* dom/MutationCallback.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h
trunk/Source/WebCore/dom/MutationCallback.idl


Added Paths

trunk/Source/WebCore/bindings/v8/V8MutationCallback.cpp
trunk/Source/WebCore/bindings/v8/V8MutationCallback.h


Removed Paths

trunk/Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (138840 => 138841)

--- trunk/Source/WebCore/ChangeLog	2013-01-04 20:51:10 UTC (rev 138840)
+++ trunk/Source/WebCore/ChangeLog	2013-01-04 21:03:20 UTC (rev 138841)
@@ -1,3 +1,43 @@
+2013-01-04  Adam Klein  ad...@chromium.org
+
+[v8] Stop using an IDL to generate V8MutationCallback
+https://bugs.webkit.org/show_bug.cgi?id=106122
+
+Reviewed by Adam Barth.
+
+The only real code in the generated V8MutationCallback.{h,cpp} files
+were specifically written in CodeGeneratorV8 for its use. By instead
+Using completely-hand-written versions of these files, the
+CodeGenerator can be simplified (as can all generated Callbacks).
+All the actually shared code is still shared via subclassing of
+ActiveDOMCallback.
+
+This introduces additional flexibility into the implementation of
+MutationCallback which will be used when fixing the MutationObserver
+memory leak (http://webkit.org/b/90661) for JSC.
+
+No changes to JSC for now, just a FIXME in the IDL file.
+
+No new tests, refactoringonly.
+
+* WebCore.gypi:
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateCallbackHeader):
+(GenerateCallbackImplementation):
+* bindings/scripts/test/V8/V8TestCallback.cpp:
+(WebCore::V8TestCallback::V8TestCallback):
+* bindings/scripts/test/V8/V8TestCallback.h:
+(WebCore::V8TestCallback::create):
+(V8TestCallback):
+* bindings/v8/V8MutationCallback.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp.
+(WebCore::V8MutationCallback::V8MutationCallback):
+(WebCore::V8MutationCallback::handleEvent):
+* bindings/v8/V8MutationCallback.h: Added.
+(V8MutationCallback):
+(WebCore::V8MutationCallback::create):
+(WebCore::V8MutationCallback::weakCallback):
+* dom/MutationCallback.idl:
+
 2013-01-04  Tony Chang  t...@chromium.org
 
 Remove some autogenerated settings from InternalSettings.idl


Modified: trunk/Source/WebCore/WebCore.gypi (138840 => 138841)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-04 20:51:10 UTC (rev 138840)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-04 21:03:20 UTC (rev 138841)
@@ -224,7 +224,6 @@
 'dom/MessageEvent.idl',
 'dom/MessagePort.idl',
 'dom/MouseEvent.idl',
-'dom/MutationCallback.idl',
 'dom/MutationEvent.idl',
 'dom/MutationObserver.idl',
 'dom/MutationRecord.idl',
@@ -1258,6 +1257,8 @@
 'bindings/v8/V8Initializer.h',
 'bindings/v8/V8LazyEventListener.cpp',
 'bindings/v8/V8LazyEventListener.h',
+'bindings/v8/V8MutationCallback.cpp',
+

[webkit-changes] [138724] trunk

[adamk]

Title: [138724] trunk








Revision 138724
Author ad...@chromium.org
Date 2013-01-03 11:52:26 -0800 (Thu, 03 Jan 2013)


Log Message
Clear failed image loads when an img is adopted into a different document
https://bugs.webkit.org/show_bug.cgi?id=104409

Reviewed by Nate Chapin.

Source/WebCore:

This avoids an assertion failure setImageWithoutConsideringPendingLoadEvent().

Test: loader/image-loader-adoptNode-assert.html

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Use new helper.
(WebCore::ImageLoader::updateFromElementIgnoringPreviousError): ditto
(WebCore::ImageLoader::elementDidMoveToNewDocument): ditto
(WebCore::ImageLoader::clearFailedLoadURL): Added a helper method to self-document the code.
(WebCore):
* loader/ImageLoader.h:
(ImageLoader):

LayoutTests:

* loader/image-loader-adoptNode-assert-expected.txt: Added.
* loader/image-loader-adoptNode-assert.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ImageLoader.cpp
trunk/Source/WebCore/loader/ImageLoader.h


Added Paths

trunk/LayoutTests/loader/image-loader-adoptNode-assert-expected.txt
trunk/LayoutTests/loader/image-loader-adoptNode-assert.html




Diff

Modified: trunk/LayoutTests/ChangeLog (138723 => 138724)

--- trunk/LayoutTests/ChangeLog	2013-01-03 19:24:27 UTC (rev 138723)
+++ trunk/LayoutTests/ChangeLog	2013-01-03 19:52:26 UTC (rev 138724)
@@ -1,3 +1,13 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+Clear failed image loads when an img is adopted into a different document
+https://bugs.webkit.org/show_bug.cgi?id=104409
+
+Reviewed by Nate Chapin.
+
+* loader/image-loader-adoptNode-assert-expected.txt: Added.
+* loader/image-loader-adoptNode-assert.html: Added.
+
 2013-01-03  Vincent Scheib  sch...@chromium.org
 
 Sandbox-blocked pointer lock should log to the console.


Added: trunk/LayoutTests/loader/image-loader-adoptNode-assert-expected.txt (0 => 138724)

--- trunk/LayoutTests/loader/image-loader-adoptNode-assert-expected.txt	(rev 0)
+++ trunk/LayoutTests/loader/image-loader-adoptNode-assert-expected.txt	2013-01-03 19:52:26 UTC (rev 138724)
@@ -0,0 +1,2 @@
+Blocked access to external URL http://foo.com/blarg.jpg
+Test passes if it does not ASSERT


Added: trunk/LayoutTests/loader/image-loader-adoptNode-assert.html (0 => 138724)

--- trunk/LayoutTests/loader/image-loader-adoptNode-assert.html	(rev 0)
+++ trunk/LayoutTests/loader/image-loader-adoptNode-assert.html	2013-01-03 19:52:26 UTC (rev 138724)
@@ -0,0 +1,9 @@
+!DOCTYPE html
+script
+if (window.testRunner) testRunner.dumpAsText();
+var doc = document.implementation.createHTMLDocument('');
+var img = document.createElement('img');
+img._onerror_ = function() { doc.adoptNode(img); };
+img.src = '';
+/script
+divTest passes if it does not ASSERT/div


Modified: trunk/Source/WebCore/ChangeLog (138723 => 138724)

--- trunk/Source/WebCore/ChangeLog	2013-01-03 19:24:27 UTC (rev 138723)
+++ trunk/Source/WebCore/ChangeLog	2013-01-03 19:52:26 UTC (rev 138724)
@@ -1,3 +1,23 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+Clear failed image loads when an img is adopted into a different document
+https://bugs.webkit.org/show_bug.cgi?id=104409
+
+Reviewed by Nate Chapin.
+
+This avoids an assertion failure setImageWithoutConsideringPendingLoadEvent().
+
+Test: loader/image-loader-adoptNode-assert.html
+
+* loader/ImageLoader.cpp:
+(WebCore::ImageLoader::updateFromElement): Use new helper.
+(WebCore::ImageLoader::updateFromElementIgnoringPreviousError): ditto
+(WebCore::ImageLoader::elementDidMoveToNewDocument): ditto
+(WebCore::ImageLoader::clearFailedLoadURL): Added a helper method to self-document the code.
+(WebCore):
+* loader/ImageLoader.h:
+(ImageLoader):
+
 2013-01-03  Vincent Scheib  sch...@chromium.org
 
 Sandbox-blocked pointer lock should log to the console.


Modified: trunk/Source/WebCore/loader/ImageLoader.cpp (138723 => 138724)

--- trunk/Source/WebCore/loader/ImageLoader.cpp	2013-01-03 19:24:27 UTC (rev 138723)
+++ trunk/Source/WebCore/loader/ImageLoader.cpp	2013-01-03 19:52:26 UTC (rev 138724)
@@ -214,7 +214,7 @@
 m_hasPendingErrorEvent = true;
 errorEventSender().dispatchEventSoon(this);
 } else
-m_failedLoadURL = AtomicString();
+clearFailedLoadURL();
 } else if (!attr.isNull()) {
 // Fire an error event if the url is empty.
 // FIXME: Should we fire this event asynchronoulsy via errorEventSender()?
@@ -263,8 +263,7 @@
 
 void ImageLoader::updateFromElementIgnoringPreviousError()
 {
-// Clear previous error.
-m_failedLoadURL = AtomicString();
+clearFailedLoadURL();
 updateFromElement();
 }
 
@@ -452,7 +451,13 @@
 
 void ImageLoader::elementDidMoveToNewDocument()
 {
+

[webkit-changes] [138730] trunk

[adamk]

Title: [138730] trunk








Revision 138730
Author ad...@chromium.org
Date 2013-01-03 13:16:59 -0800 (Thu, 03 Jan 2013)


Log Message
[HTMLTemplateElement] Disallow cycles within template content
https://bugs.webkit.org/show_bug.cgi?id=105066

Reviewed by Ojan Vafai.

Source/WebCore:

Cycles in template content aren't quite as bad as cycles in normal
DOM trees, but they can easily cause crashes, e.g. in cloneNode and
innerHTML.

Shadow DOM has an analagous issue, and this patch tackles that problem
at the same time by creating a new method, Node::containsIncludingHostElements.

In order to disallow cycles, the HTMLTemplateElement.content
DocumentFragment needs a pointer to its host. The approach here
creates a new subclass with a host pointer and a new virtual method
to DocumentFragment to identify the subclass.

To avoid unnecessary virtual function calls, also changed how
Document::templateContentsOwnerDocument works to allow fast inlined
access and avoid lazy creation when not needed.

Tests: fast/dom/HTMLTemplateElement/cycles-in-shadow.html
   fast/dom/HTMLTemplateElement/cycles.html
   fast/dom/shadow/shadow-hierarchy-exception.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::isInTemplateContent):
(WebCore::containsConsideringHostElements):
(WebCore::checkAcceptChild):
* dom/Document.cpp:
(WebCore::Document::ensureTemplateContentsOwnerDocument): Renamed to make clear that it lazily creates the Document. Updated all existing callers to call this method.
* dom/Document.h:
(Document):
(WebCore::Document::templateContentsOwnerDocument): Fast, inlined accessor for use in checkAcceptChild().
* dom/DocumentFragment.h:
(WebCore::DocumentFragment::isTemplateContent):
* dom/Node.cpp:
(WebCore::Node::containsIncludingShadowDOM): made const, simplified
(WebCore::Node::containsIncludingHostElements): Specialized version of Node::contains that knows how to jump over template content boundaries.
* dom/Node.h:
(Node):
* dom/TemplateContentDocumentFragment.h: Added.
(TemplateContentDocumentFragment): Subclass of DocumentFragment which stores its host template element.
(WebCore::TemplateContentDocumentFragment::create):
(WebCore::TemplateContentDocumentFragment::host):
(WebCore::TemplateContentDocumentFragment::TemplateContentDocumentFragment):
* editing/markup.cpp:
(WebCore::createFragmentForInnerOuterHTML):
* html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::content): Construct the new subclass.

LayoutTests:

* fast/dom/HTMLTemplateElement/cycles-expected.txt: Added.
* fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt: Added.
* fast/dom/HTMLTemplateElement/cycles-in-shadow.html: Added.
* fast/dom/HTMLTemplateElement/cycles.html: Added.
* fast/dom/shadow/shadow-hierarchy-exception-expected.txt: Added.
* fast/dom/shadow/shadow-hierarchy-exception.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/DocumentFragment.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/html/HTMLTemplateElement.cpp


Added Paths

trunk/LayoutTests/fast/dom/HTMLTemplateElement/cycles-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/cycles-in-shadow.html
trunk/LayoutTests/fast/dom/HTMLTemplateElement/cycles.html
trunk/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-hierarchy-exception.html
trunk/Source/WebCore/dom/TemplateContentDocumentFragment.h




Diff

Modified: trunk/LayoutTests/ChangeLog (138729 => 138730)

--- trunk/LayoutTests/ChangeLog	2013-01-03 21:00:37 UTC (rev 138729)
+++ trunk/LayoutTests/ChangeLog	2013-01-03 21:16:59 UTC (rev 138730)
@@ -1,3 +1,17 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] Disallow cycles within template content
+https://bugs.webkit.org/show_bug.cgi?id=105066
+
+Reviewed by Ojan Vafai.
+
+* fast/dom/HTMLTemplateElement/cycles-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/cycles-in-shadow.html: Added.
+* fast/dom/HTMLTemplateElement/cycles.html: Added.
+* fast/dom/shadow/shadow-hierarchy-exception-expected.txt: Added.
+* fast/dom/shadow/shadow-hierarchy-exception.html: Added.
+
 2013-01-03  Alexis Menard  ale...@webkit.org
 
 Querying transition-timing-function value on the computed style does not return keywords when it 

[webkit-changes] [138731] trunk/Source/WebCore

[adamk]

Title: [138731] trunk/Source/WebCore








Revision 138731
Author ad...@chromium.org
Date 2013-01-03 13:22:10 -0800 (Thu, 03 Jan 2013)


Log Message
Unreviewed build fix.

* dom/ContainerNode.cpp:
(WebCore::isInTemplateContent): s/UNUSED/UNUSED_PARAM/

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (138730 => 138731)

--- trunk/Source/WebCore/ChangeLog	2013-01-03 21:16:59 UTC (rev 138730)
+++ trunk/Source/WebCore/ChangeLog	2013-01-03 21:22:10 UTC (rev 138731)
@@ -1,5 +1,12 @@
 2013-01-03  Adam Klein  ad...@chromium.org
 
+Unreviewed build fix.
+
+* dom/ContainerNode.cpp:
+(WebCore::isInTemplateContent): s/UNUSED/UNUSED_PARAM/
+
+2013-01-03  Adam Klein  ad...@chromium.org
+
 [HTMLTemplateElement] Disallow cycles within template content
 https://bugs.webkit.org/show_bug.cgi?id=105066
 


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (138730 => 138731)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2013-01-03 21:16:59 UTC (rev 138730)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2013-01-03 21:22:10 UTC (rev 138731)
@@ -144,7 +144,7 @@
 Document* document = node-document();
 return document  document == document-templateContentsOwnerDocument();
 #else
-UNUSED(node);
+UNUSED_PARAM(node);
 return false;
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138756] trunk

[adamk]

Title: [138756] trunk








Revision 138756
Author ad...@chromium.org
Date 2013-01-03 15:41:16 -0800 (Thu, 03 Jan 2013)


Log Message
[HTMLTemplateElement] When adopting a template element, also adopt its content into the appropriate document
https://bugs.webkit.org/show_bug.cgi?id=106039

Reviewed by Eric Seidel.

Source/WebCore:

Implements the approach discussed in the spec bug:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=20129

Test: fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html

* html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::didMoveToNewDocument):
* html/HTMLTemplateElement.h:
(HTMLTemplateElement):

LayoutTests:

* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt: Added.
* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTemplateElement.cpp
trunk/Source/WebCore/html/HTMLTemplateElement.h


Added Paths

trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html




Diff

Modified: trunk/LayoutTests/ChangeLog (138755 => 138756)

--- trunk/LayoutTests/ChangeLog	2013-01-03 23:28:48 UTC (rev 138755)
+++ trunk/LayoutTests/ChangeLog	2013-01-03 23:41:16 UTC (rev 138756)
@@ -1,3 +1,13 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] When adopting a template element, also adopt its content into the appropriate document
+https://bugs.webkit.org/show_bug.cgi?id=106039
+
+Reviewed by Eric Seidel.
+
+* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Added.
+
 2013-01-03  Zoltan Horvath  zol...@webkit.org
 
 [CSS Regions] Don't apply region flow to fullscreen video playing


Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt (0 => 138756)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt	2013-01-03 23:41:16 UTC (rev 138756)
@@ -0,0 +1,17 @@
+Adopting a template from another document should also switch the template content document
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Before adoption:
+PASS template.ownerDocument is not frameTemplate.ownerDocument
+PASS template.content.ownerDocument is not frameTemplate.content.ownerDocument
+
+After adoption:
+PASS template.ownerDocument is frameTemplate.ownerDocument
+PASS template.content.ownerDocument is frameTemplate.content.ownerDocument
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html (0 => 138756)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html	2013-01-03 23:41:16 UTC (rev 138756)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+body
+templatediv/div/template
+iframe srcdoc=templatediv/div/template style=display:none/iframe
+script src=""
+script
+description('Adopting a template from another document should also switch the template content document');
+
+var template = document.querySelector('template');
+var frameTemplate = frames[0].document.querySelector('template');
+
+debug('Before adoption:');
+shouldNotBe('template.ownerDocument', 'frameTemplate.ownerDocument');
+shouldNotBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
+frameTemplate = document.adoptNode(frameTemplate);
+debug('\nAfter adoption:');
+shouldBe('template.ownerDocument', 'frameTemplate.ownerDocument');
+shouldBe('template.content.ownerDocument', 'frameTemplate.content.ownerDocument');
+debug('');
+/script
+script src=""
+/body


Modified: trunk/Source/WebCore/ChangeLog (138755 => 138756)

--- trunk/Source/WebCore/ChangeLog	2013-01-03 23:28:48 UTC (rev 138755)
+++ trunk/Source/WebCore/ChangeLog	2013-01-03 23:41:16 UTC (rev 138756)
@@ -1,3 +1,20 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] When adopting a template element, also adopt its content into the appropriate document
+https://bugs.webkit.org/show_bug.cgi?id=106039
+
+Reviewed by Eric Seidel.
+
+Implements the approach discussed in the spec bug:
+https://www.w3.org/Bugs/Public/show_bug.cgi?id=20129
+
+Test: fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html
+
+* html/HTMLTemplateElement.cpp:
+(WebCore::HTMLTemplateElement::didMoveToNewDocument):
+* html/HTMLTemplateElement.h:
+(HTMLTemplateElement):
+
 2013-01-03  Zoltan Horvath  zol...@webkit.org
 
 [CSS Regions] Don't apply region flow to fullscreen video playing

[webkit-changes] [138769] trunk/Source/WebCore

[adamk]

Title: [138769] trunk/Source/WebCore








Revision 138769
Author ad...@chromium.org
Date 2013-01-03 17:18:03 -0800 (Thu, 03 Jan 2013)


Log Message
Unreviewed rebaseline of binding tests after r138754

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader): Remove unnecessary whitespace
* bindings/scripts/test/JS/JSTestCallback.h:
(WebCore::JSTestCallback::scriptExecutionContext):
(JSTestCallback):
* bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::scriptExecutionContext):
(V8TestCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (138768 => 138769)

--- trunk/Source/WebCore/ChangeLog	2013-01-04 01:06:19 UTC (rev 138768)
+++ trunk/Source/WebCore/ChangeLog	2013-01-04 01:18:03 UTC (rev 138769)
@@ -1,3 +1,16 @@
+2013-01-03  Adam Klein  ad...@chromium.org
+
+Unreviewed rebaseline of binding tests after r138754
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateCallbackHeader): Remove unnecessary whitespace
+* bindings/scripts/test/JS/JSTestCallback.h:
+(WebCore::JSTestCallback::scriptExecutionContext):
+(JSTestCallback):
+* bindings/scripts/test/V8/V8TestCallback.h:
+(WebCore::V8TestCallback::scriptExecutionContext):
+(V8TestCallback):
+
 2013-01-03  Antoine Quint  grao...@apple.com
 
 onload callback for track element attached to video does not fire


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (138768 => 138769)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-04 01:06:19 UTC (rev 138768)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-04 01:18:03 UTC (rev 138769)
@@ -3286,7 +3286,7 @@
 }
 
 push(@headerContent, END);
-  
+
 virtual ScriptExecutionContext* scriptExecutionContext() const { return ContextDestructionObserver::scriptExecutionContext(); }
 
 private:


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.h (138768 => 138769)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.h	2013-01-04 01:06:19 UTC (rev 138768)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.h	2013-01-04 01:18:03 UTC (rev 138769)
@@ -37,6 +37,8 @@
 return adoptRef(new JSTestCallback(callback, globalObject));
 }
 
+virtual ScriptExecutionContext* scriptExecutionContext() const { return ContextDestructionObserver::scriptExecutionContext(); }
+
 virtual ~JSTestCallback();
 
 // Functions


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h (138768 => 138769)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h	2013-01-04 01:06:19 UTC (rev 138768)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h	2013-01-04 01:18:03 UTC (rev 138769)
@@ -55,6 +55,8 @@
 virtual bool callbackWithBoolean(bool boolParam);
 virtual bool callbackRequiresThisToPass(Class8* class8Param, ThisClass* thisClassParam);
 
+virtual ScriptExecutionContext* scriptExecutionContext() const { return ContextDestructionObserver::scriptExecutionContext(); }
+
 private:
 V8TestCallback(v8::Handlev8::Object, ScriptExecutionContext*, v8::Handlev8::Object);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138642] branches/chromium/1364/Source/WebKit/chromium/features.gypi

[adamk]

Title: [138642] branches/chromium/1364/Source/WebKit/chromium/features.gypi








Revision 138642
Author ad...@chromium.org
Date 2013-01-02 13:33:07 -0800 (Wed, 02 Jan 2013)


Log Message
Turn off ENABLE_TEMPLATE_ELEMENT
Review URL: https://codereview.chromium.org/11635022

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/features.gypi




Diff

Modified: branches/chromium/1364/Source/WebKit/chromium/features.gypi (138641 => 138642)

--- branches/chromium/1364/Source/WebKit/chromium/features.gypi	2013-01-02 21:28:28 UTC (rev 138641)
+++ branches/chromium/1364/Source/WebKit/chromium/features.gypi	2013-01-02 21:33:07 UTC (rev 138642)
@@ -111,7 +111,7 @@
   'ENABLE_STYLE_SCOPED=1',
   'ENABLE_SVG=(enable_svg)',
   'ENABLE_SVG_FONTS=(enable_svg)',
-  'ENABLE_TEMPLATE_ELEMENT=1',
+  'ENABLE_TEMPLATE_ELEMENT=0',
   'ENABLE_TEXT_AUTOSIZING=1',
   'ENABLE_TOUCH_ADJUSTMENT=1',
   'ENABLE_TOUCH_EVENTS=(enable_touch_events)',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138315] trunk

[adamk]

Title: [138315] trunk








Revision 138315
Author ad...@chromium.org
Date 2012-12-20 16:09:20 -0800 (Thu, 20 Dec 2012)


Log Message
Properly process template end tags when in TemplateContentsMode
https://bugs.webkit.org/show_bug.cgi?id=105556

Reviewed by Eric Seidel.

Source/WebCore:

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag): Take care of the FIXME and just call
processTemplateEndTag() instead of incorrectly special-casing the end tag behavior in some cases.

LayoutTests:

* html5lib/resources/template.dat:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/resources/template.dat
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (138314 => 138315)

--- trunk/LayoutTests/ChangeLog	2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/LayoutTests/ChangeLog	2012-12-21 00:09:20 UTC (rev 138315)
@@ -1,3 +1,12 @@
+2012-12-20  Adam Klein  ad...@chromium.org
+
+Properly process template end tags when in TemplateContentsMode
+https://bugs.webkit.org/show_bug.cgi?id=105556
+
+Reviewed by Eric Seidel.
+
+* html5lib/resources/template.dat:
+
 2012-12-20  Emil A Eklund  e...@chromium.org
 
 [flexbox] Fix handling of very large flex grow/shrink values


Modified: trunk/LayoutTests/html5lib/resources/template.dat (138314 => 138315)

--- trunk/LayoutTests/html5lib/resources/template.dat	2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/LayoutTests/html5lib/resources/template.dat	2012-12-21 00:09:20 UTC (rev 138315)
@@ -859,3 +859,19 @@
 | tbody
 |   tr
 | tfoot
+
+#data
+bodytemplatetemplatebtemplate/template/templatetext/template
+#errors
+#document
+| html
+|   head
+|   body
+| template
+|   #document-fragment
+| template
+|   #document-fragment
+| b
+|   template
+| #document-fragment
+| text


Modified: trunk/Source/WebCore/ChangeLog (138314 => 138315)

--- trunk/Source/WebCore/ChangeLog	2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/Source/WebCore/ChangeLog	2012-12-21 00:09:20 UTC (rev 138315)
@@ -1,3 +1,14 @@
+2012-12-20  Adam Klein  ad...@chromium.org
+
+Properly process template end tags when in TemplateContentsMode
+https://bugs.webkit.org/show_bug.cgi?id=105556
+
+Reviewed by Eric Seidel.
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::processEndTag): Take care of the FIXME and just call
+processTemplateEndTag() instead of incorrectly special-casing the end tag behavior in some cases.
+
 2012-12-20  Kondapally Kalyan  kalyan.kondapa...@intel.com
 
 [EFL][WebGL][Wk2] Replace HAVE(GLX) checks with USE(GLX)


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (138314 => 138315)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-12-21 00:04:40 UTC (rev 138314)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-12-21 00:09:20 UTC (rev 138315)
@@ -2283,12 +2283,8 @@
 break;
 case TemplateContentsMode:
 #if ENABLE(TEMPLATE_ELEMENT)
-// FIXME: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19966
 if (token-name() == templateTag) {
-ASSERT(m_tree.currentStackItem()-hasTagName(templateTag));
-m_tree.openElements()-pop();
-m_templateInsertionModes.removeLast();
-resetInsertionModeAppropriately();
+processTemplateEndTag(token);
 return;
 }
 setInsertionMode(InBodyMode);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [138059] trunk

[adamk]

Title: [138059] trunk








Revision 138059
Author ad...@chromium.org
Date 2012-12-18 13:06:33 -0800 (Tue, 18 Dec 2012)


Log Message
[HTMLTemplateElement] Prevent first-level recursive template from resetting the implied context
https://bugs.webkit.org/show_bug.cgi?id=104142

Reviewed by Eric Seidel.

Source/WebCore:

This patch adds a stack of InsertionModes retains the chosen
implied context for each template element.

Based on a patch by Rafael Weinstein.

Tests added to html5lib/run-template.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the stack appropriately for HTMLTemplateElement.innerHTML.
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processStartTag): Once we've figured out the insertion mode for a given template store it in the stack.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile): Clear the stack if we hit end of file to allow the assertion in finish().
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):

LayoutTests:

Added test that the original template context is retained after inner template.

* html5lib/resources/template.dat:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/html5lib/resources/template.dat
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h




Diff

Modified: trunk/LayoutTests/ChangeLog (138058 => 138059)

--- trunk/LayoutTests/ChangeLog	2012-12-18 21:02:45 UTC (rev 138058)
+++ trunk/LayoutTests/ChangeLog	2012-12-18 21:06:33 UTC (rev 138059)
@@ -1,3 +1,14 @@
+2012-12-18  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] Prevent first-level recursive template from resetting the implied context
+https://bugs.webkit.org/show_bug.cgi?id=104142
+
+Reviewed by Eric Seidel.
+
+Added test that the original template context is retained after inner template.
+
+* html5lib/resources/template.dat:
+
 2012-12-18  Hans Muller  hmul...@adobe.com
 
 [CSS Exclusions] shape-inside layout fails to adjust first line correctly for writing-mode: vertical-rl


Modified: trunk/LayoutTests/html5lib/resources/template.dat (138058 => 138059)

--- trunk/LayoutTests/html5lib/resources/template.dat	2012-12-18 21:02:45 UTC (rev 138058)
+++ trunk/LayoutTests/html5lib/resources/template.dat	2012-12-18 21:06:33 UTC (rev 138059)
@@ -840,4 +840,22 @@
 | tr
 | template
 |   #document-fragment
-| td
+| tr
+|   td
+
+#data
+bodytemplatethead/theadtemplatetr/tr/templatetr/trtfoot/tfoot/template
+#errors
+#document
+| html
+|   head
+|   body
+| template
+|   #document-fragment
+| thead
+| template
+|   #document-fragment
+| tr
+| tbody
+|   tr
+| tfoot


Modified: trunk/Source/WebCore/ChangeLog (138058 => 138059)

--- trunk/Source/WebCore/ChangeLog	2012-12-18 21:02:45 UTC (rev 138058)
+++ trunk/Source/WebCore/ChangeLog	2012-12-18 21:06:33 UTC (rev 138059)
@@ -1,3 +1,29 @@
+2012-12-18  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] Prevent first-level recursive template from resetting the implied context
+https://bugs.webkit.org/show_bug.cgi?id=104142
+
+Reviewed by Eric Seidel.
+
+This patch adds a stack of InsertionModes retains the chosen
+implied context for each template element.
+
+Based on a patch by Rafael Weinstein.
+
+Tests added to html5lib/run-template.html
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the stack appropriately for HTMLTemplateElement.innerHTML.
+(WebCore::HTMLTreeBuilder::processTemplateStartTag):
+(WebCore::HTMLTreeBuilder::processTemplateEndTag):
+(WebCore::HTMLTreeBuilder::processStartTag): Once we've figured out the insertion mode for a given template store it in the stack.
+(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
+(WebCore::HTMLTreeBuilder::processEndTag):
+(WebCore::HTMLTreeBuilder::processEndOfFile): Clear the stack if we hit end of file to allow the assertion in finish().
+(WebCore::HTMLTreeBuilder::finished):
+* html/parser/HTMLTreeBuilder.h:
+(HTMLTreeBuilder):
+
 2012-12-18  Andrew Lo  a...@rim.com
 
 [BlackBerry] Use midpoint for fixed position heuristic


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (138058 => 138059)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-12-18 21:02:45 UTC (rev 138058)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-12-18 21:06:33 UTC (rev 138059)
@@ -303,6 +303,12 @@
 // For efficiency, we skip step 4.2 (Let root be a new 

[webkit-changes] [137938] trunk/Tools

[adamk]

Title: [137938] trunk/Tools








Revision 137938
Author ad...@chromium.org
Date 2012-12-17 13:40:59 -0800 (Mon, 17 Dec 2012)


Log Message
build-webkit: rename --template-tag to --template-element to match ENABLE #define name
https://bugs.webkit.org/show_bug.cgi?id=105072

Reviewed by Laszlo Gombos.

* Scripts/webkitperl/FeatureList.pm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/Tools/ChangeLog (137937 => 137938)

--- trunk/Tools/ChangeLog	2012-12-17 21:38:51 UTC (rev 137937)
+++ trunk/Tools/ChangeLog	2012-12-17 21:40:59 UTC (rev 137938)
@@ -1,3 +1,12 @@
+2012-12-17  Adam Klein  ad...@chromium.org
+
+build-webkit: rename --template-tag to --template-element to match ENABLE #define name
+https://bugs.webkit.org/show_bug.cgi?id=105072
+
+Reviewed by Laszlo Gombos.
+
+* Scripts/webkitperl/FeatureList.pm:
+
 2012-12-17  Julien Chaffraix  jchaffr...@webkit.org
 
 Add some unit testing for WTF::clampTo* functions


Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (137937 => 137938)

--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-12-17 21:38:51 UTC (rev 137937)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-12-17 21:40:59 UTC (rev 137938)
@@ -127,7 +127,7 @@
 $svgFontsSupport,
 $svgSupport,
 $systemMallocSupport,
-$templateTagSupport,
+$templateElementSupport,
 $textAutosizingSupport,
 $tiledBackingStoreSupport,
 $touchEventsSupport,
@@ -395,8 +395,8 @@
 { option = system-malloc, desc = Toggle system allocator instead of TCmalloc,
   define = USE_SYSTEM_MALLOC, default = isWinCE(), value = \$systemMallocSupport },
 
-{ option = template-tag, desc = Toggle Templates Tag support,
-  define = ENABLE_TEMPLATE_ELEMENT, default = 0, value = \$templateTagSupport },
+{ option = template-element, desc = Toggle HTMLTemplateElement support,
+  define = ENABLE_TEMPLATE_ELEMENT, default = 0, value = \$templateElementSupport },
 
 { option = text-autosizing, desc = Toggle Text Autosizing support,
   define = ENABLE_TEXT_AUTOSIZING, default = 0, value = \$textAutosizingSupport },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137769] trunk/LayoutTests

[adamk]

Title: [137769] trunk/LayoutTests








Revision 137769
Author ad...@chromium.org
Date 2012-12-14 14:11:18 -0800 (Fri, 14 Dec 2012)


Log Message
fast/dom/HTMLTemplateElement/inertContents.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104023

Reviewed by Eric Seidel.

Made the test only check inertness using script, since
imgs are currently flaky due to the preload scanner.

* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
* fast/dom/HTMLTemplateElement/inertContents.html:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137768 => 137769)

--- trunk/LayoutTests/ChangeLog	2012-12-14 22:07:32 UTC (rev 137768)
+++ trunk/LayoutTests/ChangeLog	2012-12-14 22:11:18 UTC (rev 137769)
@@ -1,3 +1,17 @@
+2012-12-14  Adam Klein  ad...@chromium.org
+
+fast/dom/HTMLTemplateElement/inertContents.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=104023
+
+Reviewed by Eric Seidel.
+
+Made the test only check inertness using script, since
+imgs are currently flaky due to the preload scanner.
+
+* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
+* fast/dom/HTMLTemplateElement/inertContents.html:
+* platform/chromium/TestExpectations:
+
 2012-12-14  Anton Vayvod  avay...@chromium.org
 
 Consider inline-block and inline-table elements to be autosizing clusters.


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt (137768 => 137769)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt	2012-12-14 22:07:32 UTC (rev 137768)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents-expected.txt	2012-12-14 22:11:18 UTC (rev 137769)
@@ -1,7 +1,11 @@
-http://baz.com/bat.jpg - willSendRequest NSURLRequest URL http://baz.com/bat.jpg, main document URL inertContents.html, http method GET redirectResponse (null)
-Blocked access to external URL http://baz.com/bat.jpg
-http://baz.com/bat.jpg - didFailLoadingWithError: NSError domain NSURLErrorDomain, code -999, failing URL (null)
-The test asserts that elements within template contents are inert, e.g. resources do not fetch, script does not run.
+The test asserts that elements within template contents are inert, e.g. script does not run.
 
-pass!
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
+
+PASS testVal is script has not run
+PASS testVal is script has run
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html (137768 => 137769)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html	2012-12-14 22:07:32 UTC (rev 137768)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/inertContents.html	2012-12-14 22:11:18 UTC (rev 137769)
@@ -1,35 +1,17 @@
 !DOCTYPE html
-html
-head
+body
+script src=""
 script
-var testVal = 1;
-
-window._onload_ = function() {
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.dumpResourceLoadCallbacks();
-}
-
-if (testVal != 1)
-return;
-
-var templateContent = document.getElementById('template').content;
-var img = templateContent.childNodes[1];
-img.src = ""
-document.body.appendChild(templateContent);
-
-if (testVal != 2)
-return;
-
-document.getElementById('output').innerText = 'pass!';
-}
+var testVal = 'script has not run';
 /script
-/head
-body
-pThe test asserts that elements within template contents are inert, e.g. resources do not fetch, script does not run./p
-template id=templatescriptwindow.testVal = 2;/scriptimg src=""
-/template
-div id=output
-/div
+!-- FIXME: Add non-flaky test for img tags --
+templatescriptwindow.testVal = 'script has run';/script/template
+script
+description('The test asserts that elements within template contents are inert, e.g. script does not run.');
+shouldBeEqualToString('testVal', 'script has not run');
+var templateContent = document.querySelector('template').content;
+document.body.appendChild(templateContent);
+shouldBeEqualToString('testVal', 'script has run');
+/script
+script src=""
 /body
-/html
\ No newline at end of file


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137768 => 137769)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-14 22:07:32 UTC (rev 137768)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-14 22:11:18 UTC (rev 137769)
@@ -4180,8 +4180,6 @@
 webkit.org/b/99800 fast/harness/perftests/perf-runner-compute-statistics.html [ Failure Pass ]
 webkit.org/b/99800 fast/harness/perftests/runs-per-second-log.html [ Failure ImageOnlyFailure Missing Pass ]
 
-webkit.org/b/104023 [ Win Mac Debug ] 

[webkit-changes] [137609] trunk/LayoutTests

[adamk]

Title: [137609] trunk/LayoutTests








Revision 137609
Author ad...@chromium.org
Date 2012-12-13 10:32:15 -0800 (Thu, 13 Dec 2012)


Log Message
Unreviewed. Update chromium expectatins for fonts/monospace.html

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137608 => 137609)

--- trunk/LayoutTests/ChangeLog	2012-12-13 18:30:57 UTC (rev 137608)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 18:32:15 UTC (rev 137609)
@@ -1,3 +1,9 @@
+2012-12-13  Adam Klein  ad...@chromium.org
+
+Unreviewed. Update chromium expectatins for fonts/monospace.html
+
+* platform/chromium/TestExpectations:
+
 2012-12-13  Nate Chapin  jap...@chromium.org
 
 Route main resource loads through the memory cache.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137608 => 137609)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-13 18:30:57 UTC (rev 137608)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-13 18:32:15 UTC (rev 137609)
@@ -4186,7 +4186,7 @@
 webkit.org/b/104548 [ Linux ] fast/text/hyphens.html [ Failure ]
 
 # Flaky
-webkit.org/b/104283 [ XP ] fonts/monospace.html [ Failure Pass ]
+webkit.org/b/104283 [ Win Release ] fonts/monospace.html [ Failure Pass ]
 webkit.org/b/104283 [ Mac Debug ] fonts/monospace.html [ ImageOnlyFailure Pass ]
 
 # Flaky on Win






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137667] trunk/LayoutTests

[adamk]

Title: [137667] trunk/LayoutTests








Revision 137667
Author ad...@chromium.org
Date 2012-12-13 15:31:55 -0800 (Thu, 13 Dec 2012)


Log Message
Mark one test as failing and rebaseline another after r137646

Unreviewed chromium gardening.

* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/
trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/
trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (137666 => 137667)

--- trunk/LayoutTests/ChangeLog	2012-12-13 23:30:51 UTC (rev 137666)
+++ trunk/LayoutTests/ChangeLog	2012-12-13 23:31:55 UTC (rev 137667)
@@ -1,5 +1,16 @@
 2012-12-13  Adam Klein  ad...@chromium.org
 
+Mark one test as failing and rebaseline another after r137646
+
+Unreviewed chromium gardening.
+
+* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
+* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
+* platform/chromium/TestExpectations:
+
+2012-12-13  Adam Klein  ad...@chromium.org
+
 Move MutationObserver tests to fast/dom/MutationObserver
 https://bugs.webkit.org/show_bug.cgi?id=104948
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137666 => 137667)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-13 23:30:51 UTC (rev 137666)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-13 23:31:55 UTC (rev 137667)
@@ -1450,6 +1450,9 @@
 # Fails on webkit windows as well.
 crbug.com/24207 fast/events/attempt-scroll-with-no-scrollbars.html [ Failure ]
 
+# Fails when opting into composited scrolling.
+webkit.org/b/104965 [ Mac ] platform/chromium/virtual/gpu/compositedscrolling/scrollbars/scrollbar-drag-thumb-with-large-content.html [ Failure ]
+
 # No glyph for U+FFFD (Replacement Character : black diamond with
 # question mark) in them on Win XP.
 crbug.com/10315 [ XP ] fast/encoding/invalid-UTF-8.html [ Failure ]


Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style-expected.png

(Binary files differ)

Property changes on: 

[webkit-changes] [137427] trunk/LayoutTests

[adamk]

Title: [137427] trunk/LayoutTests








Revision 137427
Author ad...@chromium.org
Date 2012-12-12 00:02:19 -0800 (Wed, 12 Dec 2012)


Log Message
Mark a Linux compositing test as failing after a change to the Chromium compositor.

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137426 => 137427)

--- trunk/LayoutTests/ChangeLog	2012-12-12 08:00:33 UTC (rev 137426)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 08:02:19 UTC (rev 137427)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Mark a Linux compositing test as failing after a change to the Chromium compositor.
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Hayato Ito  hay...@chromium.org
 
 REGRESSION(r137408): breaks chromium's browser tests which use WebKitShadowRoot (Requested by hayato on #webkit).


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137426 => 137427)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 08:00:33 UTC (rev 137426)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 08:02:19 UTC (rev 137427)
@@ -4215,3 +4215,5 @@
 webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ ImageOnlyFailure ]
 
 webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]
+
+crbug.com/165633 [ Linux ] compositing/reflections/reflection-in-composited.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137476] trunk/LayoutTests

[adamk]

Title: [137476] trunk/LayoutTests








Revision 137476
Author ad...@chromium.org
Date 2012-12-12 09:35:35 -0800 (Wed, 12 Dec 2012)


Log Message
Rebaseline after change to Chromium compositor

Unreviewed gardening.

* platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (137475 => 137476)

--- trunk/LayoutTests/ChangeLog	2012-12-12 17:31:01 UTC (rev 137475)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 17:35:35 UTC (rev 137476)
@@ -1,3 +1,12 @@
+2012-12-12  Adam Klein  ad...@chromium.org
+
+Rebaseline after change to Chromium compositor
+
+Unreviewed gardening.
+
+* platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png:
+* platform/chromium/TestExpectations:
+
 2012-12-12  Justin Novosad  ju...@google.com
 
 Use render box background over border draw strategy in cases with background-image


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137475 => 137476)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 17:31:01 UTC (rev 137475)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 17:35:35 UTC (rev 137476)
@@ -4211,8 +4211,6 @@
 # Flaky on Win (perhaps due to lighttpd?)
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html [ Failure Pass ]
 
-# Failing differently since r137152, probably just need rebaselines
-
 # Broken by Chromium r172175
 crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ]
 
@@ -4220,5 +4218,3 @@
 webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ ImageOnlyFailure ]
 
 webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]
-
-crbug.com/165633 [ Linux ] compositing/reflections/reflection-in-composited.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/chromium-linux/compositing/reflections/reflection-in-composited-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137493] trunk/LayoutTests

[adamk]

Title: [137493] trunk/LayoutTests








Revision 137493
Author ad...@chromium.org
Date 2012-12-12 11:39:42 -0800 (Wed, 12 Dec 2012)


Log Message
Mark calendar-picker-appearance tests as ImageOnlyFailures on cr-mac after r137473

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137492 => 137493)

--- trunk/LayoutTests/ChangeLog	2012-12-12 19:38:15 UTC (rev 137492)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 19:39:42 UTC (rev 137493)
@@ -1,3 +1,11 @@
+2012-12-12  Adam Klein  ad...@chromium.org
+
+Mark calendar-picker-appearance tests as ImageOnlyFailures on cr-mac after r137473
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-12  James Simonsen  simon...@chromium.org
 
 [Resource Timing] Failed resources shouldn't be recorded in the buffer


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137492 => 137493)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 19:38:15 UTC (rev 137492)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 19:39:42 UTC (rev 137493)
@@ -4075,6 +4075,14 @@
 webkit.org/b/101408 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]
 webkit.org/b/101408 platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html [ Failure Pass ]
 
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/month-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ ImageOnlyFailure ]
+webkit.org/b/104825 [ Mac ] platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ ImageOnlyFailure ]
+
 webkit.org/b/101539 [ Linux Win ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
 
 webkit.org/b/101618 http/tests/inspector/indexeddb/database-data.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137499] trunk/LayoutTests

[adamk]

Title: [137499] trunk/LayoutTests








Revision 137499
Author ad...@chromium.org
Date 2012-12-12 12:14:31 -0800 (Wed, 12 Dec 2012)


Log Message
Mark the template inert contents test as flaky on cr-win as well.

Unreviewed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137498 => 137499)

--- trunk/LayoutTests/ChangeLog	2012-12-12 20:10:55 UTC (rev 137498)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 20:14:31 UTC (rev 137499)
@@ -1,3 +1,11 @@
+2012-12-12  Adam Klein  ad...@chromium.org
+
+Mark the template inert contents test as flaky on cr-win as well.
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+
 2012-12-12  Robert Hogan  rob...@webkit.org
 
 White space between inline blocks should be affected by word-spacing property


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137498 => 137499)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 20:10:55 UTC (rev 137498)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 20:14:31 UTC (rev 137499)
@@ -4168,8 +4168,7 @@
 webkit.org/b/99800 fast/harness/perftests/perf-runner-compute-statistics.html [ Failure Pass ]
 webkit.org/b/99800 fast/harness/perftests/runs-per-second-log.html [ Failure ImageOnlyFailure Missing Pass ]
 
-# Flaky on mac debug since r136472 or earlier
-webkit.org/b/104023 [ Mac Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Failure Pass ]
+webkit.org/b/104023 [ Win Mac Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Failure Pass ]
 
 # Needs platform-specific results
 webkit.org/b/104035 fast/text/orientation-sideways.html [ Missing ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137501] trunk/LayoutTests

[adamk]

Title: [137501] trunk/LayoutTests








Revision 137501
Author ad...@chromium.org
Date 2012-12-12 12:36:31 -0800 (Wed, 12 Dec 2012)


Log Message
Mark fast/css/nested-rounded-corners.html as flaky on Chromium/MountainLion

Unreviewed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137500 => 137501)

--- trunk/LayoutTests/ChangeLog	2012-12-12 20:19:12 UTC (rev 137500)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 20:36:31 UTC (rev 137501)
@@ -1,3 +1,11 @@
+2012-12-12  Adam Klein  ad...@chromium.org
+
+Mark fast/css/nested-rounded-corners.html as flaky on Chromium/MountainLion
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+
 2012-12-12  Dean Jackson  d...@apple.com
 
 Use CAFilter rather than CIFilter


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137500 => 137501)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 20:19:12 UTC (rev 137500)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 20:36:31 UTC (rev 137501)
@@ -4218,3 +4218,5 @@
 webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ ImageOnlyFailure ]
 
 webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]
+
+webkit.org/b/104834 [ MountainLion ] fast/css/nested-rounded-corners.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137522] trunk/LayoutTests

[adamk]

Title: [137522] trunk/LayoutTests








Revision 137522
Author ad...@chromium.org
Date 2012-12-12 15:13:02 -0800 (Wed, 12 Dec 2012)


Log Message
Unreviewed test expectations update: tweak flakiness of various tests.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137521 => 137522)

--- trunk/LayoutTests/ChangeLog	2012-12-12 23:04:59 UTC (rev 137521)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 23:13:02 UTC (rev 137522)
@@ -1,3 +1,9 @@
+2012-12-12  Adam Klein  ad...@chromium.org
+
+Unreviewed test expectations update: tweak flakiness of various tests.
+
+* platform/chromium/TestExpectations:
+
 2012-12-12  Dominic Mazzoni  dmazz...@google.com
 
 Rebaselining platform/mac/accessibility/internal-link-anchors2-expected.txt after r137512


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137521 => 137522)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 23:04:59 UTC (rev 137521)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 23:13:02 UTC (rev 137522)
@@ -3514,7 +3514,7 @@
 webkit.org/b/89702 platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion.html [ ImageOnlyFailure Pass ]
 
 webkit.org/b/89789 [ Mac ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ]
-webkit.org/b/89789 [ Mac Win7 Debug ] userscripts/user-script-video-document.html [ Crash Pass ]
+webkit.org/b/89789 [ XP ] userscripts/user-script-video-document.html [ Pass Timeout ]
 
 # Flaky
 webkit.org/b/89794 [ Mac ] fast/regions/get-regions-by-content2.html [ Crash Pass ]
@@ -3650,7 +3650,7 @@
 webkit.org/b/93938 [ Lion Release ] fast/forms/range/slider-delete-while-dragging-thumb.html [ Failure Pass ]
 webkit.org/b/93938 [ Debug ] fast/forms/range/slider-mouse-events.html [ Failure Pass ]
 webkit.org/b/93938 [ Lion Release ] fast/forms/range/slider-mouse-events.html [ Failure Pass ]
-webkit.org/b/93938 [ Linux Win Debug ] fast/forms/range/slider-onchange-event.html [ Failure Pass ]
+webkit.org/b/93938 [ Linux Win7 ] fast/forms/range/slider-onchange-event.html [ Failure Pass ]
 
 # Require rebaselining after  https://bugs.webkit.org/show_bug.cgi?id=89826
 webkit.org/b/89826 [ Mac Win ] fast/css/word-space-extra.html [ Failure ]
@@ -3830,7 +3830,7 @@
 webkit.org/b/96833 svg/carto.net/combobox.svg [ ImageOnlyFailure Pass ]
 
 webkit.org/b/96549 [ Android ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ]
-webkit.org/b/96628 [ Lion MountainLion ] fast/frames/calculate-order.html [ Failure Pass ]
+webkit.org/b/96628 [ Lion Debug ] fast/frames/calculate-order.html [ Failure ]
 webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [ Pass Timeout ]
 
 crbug.com/63921 platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html [ Failure ]
@@ -4209,3 +4209,7 @@
 webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]
 
 webkit.org/b/104834 [ MountainLion ] fast/css/nested-rounded-corners.html [ Failure Pass ]
+
+webkit.org/b/104848 [ Linux XP SnowLeopard Lion Release ] fast/frames/sandboxed-iframe-attribute-parsing.html [ Pass Failure ]
+webkit.org/b/104848 [ SnowLeopard Debug ] fast/frames/sandboxed-iframe-attribute-parsing.html [ Pass Failure ]
+webkit.org/b/104848 [ Release ] fast/frames/sandboxed-iframe-parsing-space-characters.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137525] trunk/LayoutTests

[adamk]

Title: [137525] trunk/LayoutTests








Revision 137525
Author ad...@chromium.org
Date 2012-12-12 15:20:20 -0800 (Wed, 12 Dec 2012)


Log Message
Unreviewed test expectations update: tweak flakiness of resource timing tests.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137524 => 137525)

--- trunk/LayoutTests/ChangeLog	2012-12-12 23:20:20 UTC (rev 137524)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 23:20:20 UTC (rev 137525)
@@ -1,5 +1,11 @@
 2012-12-12  Adam Klein  ad...@chromium.org
 
+Unreviewed test expectations update: tweak flakiness of resource timing tests.
+
+* platform/chromium/TestExpectations:
+
+2012-12-12  Adam Klein  ad...@chromium.org
+
 Unreviewed test expectations update: tweak flakiness of various tests.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137524 => 137525)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 23:20:20 UTC (rev 137524)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 23:20:20 UTC (rev 137525)
@@ -4100,10 +4100,13 @@
 
 webkit.org/b/102724 [ Linux ] svg/carto.net/colourpicker.svg [ ImageOnlyFailure Pass ]
 
-webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html [ Failure ]
 webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html [ Failure ]
-webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html [ Failure ]
-webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html [ Failure ]
+webkit.org/b/103927 [ Mac Linux ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html [ Failure ]
+webkit.org/b/103927 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html [ Failure Timeout ]
+webkit.org/b/103927 [ Mac Linux ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html [ Failure ]
+webkit.org/b/103927 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html [ Failure Timeout ]
+webkit.org/b/103927 [ Mac Linux ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html [ Failure ]
+webkit.org/b/103927 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html [ Failure Timeout ]
 webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
 webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html [ Failure ]
 
@@ -4199,6 +4202,7 @@
 
 # Flaky on Win (perhaps due to lighttpd?)
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html [ Failure Pass ]
+webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html [ Timeout Pass ]
 
 # Broken by Chromium r172175
 crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137323] trunk/LayoutTests

[adamk]

Title: [137323] trunk/LayoutTests








Revision 137323
Author ad...@chromium.org
Date 2012-12-11 09:04:39 -0800 (Tue, 11 Dec 2012)


Log Message
Attempt to rebaseline move-by-line-001, which has become less flaky.

Unreviewed gardening.

* platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Removed.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (137322 => 137323)

--- trunk/LayoutTests/ChangeLog	2012-12-11 16:45:24 UTC (rev 137322)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 17:04:39 UTC (rev 137323)
@@ -1,3 +1,13 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Attempt to rebaseline move-by-line-001, which has become less flaky.
+
+Unreviewed gardening.
+
+* platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png:
+* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Removed.
+* platform/chromium/TestExpectations:
+
 2012-12-11  Jussi Kukkonen  jussi.kukko...@intel.com
 
 [EFL] Update http/tests/multipart results now that we have soup multipart support


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137322 => 137323)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 16:45:24 UTC (rev 137322)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 17:04:39 UTC (rev 137323)
@@ -3664,10 +3664,6 @@
 webkit.org/b/94010 [ Debug ] fast/regex/unicodeCaseInsensitive.html [ Crash Pass ]
 webkit.org/b/94017 [ Win ] css2.1/20110323/c541-word-sp-000.htm [ ImageOnlyFailure ]
 
-webkit.org/b/94059 [ Debug ] editing/selection/move-by-line-001.html [ Failure Pass ]
-webkit.org/b/94059 [ Linux Release ] editing/selection/move-by-line-001.html [ Failure Pass ]
-webkit.org/b/94059 [ Lion Release ] editing/selection/move-by-line-001.html [ Failure ImageOnlyFailure Pass ]
-
 webkit.org/b/94078 [ Win Release ] http/tests/inspector/web-socket-frame-error.html [ Failure Pass ]
 
 webkit.org/b/94256 [ Debug ] fast/block/inline-children-root-linebox-crash.html [ Crash Pass ]


Modified: trunk/LayoutTests/platform/chromium-mac-lion/editing/selection/move-by-line-001-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137339] trunk/LayoutTests

[adamk]

Title: [137339] trunk/LayoutTests








Revision 137339
Author ad...@chromium.org
Date 2012-12-11 12:06:57 -0800 (Tue, 11 Dec 2012)


Log Message
Fix bogus test expectations

Unreviewed.

There were a bunch of uses of Text when they should have said Failure.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137338 => 137339)

--- trunk/LayoutTests/ChangeLog	2012-12-11 19:02:06 UTC (rev 137338)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 20:06:57 UTC (rev 137339)
@@ -1,3 +1,13 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Fix bogus test expectations
+
+Unreviewed.
+
+There were a bunch of uses of Text when they should have said Failure.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Elliott Sprehn  espr...@chromium.org
 
 Switch to new PseudoElement based :before and :after


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137338 => 137339)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 19:02:06 UTC (rev 137338)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 20:06:57 UTC (rev 137339)
@@ -3656,7 +3656,7 @@
 webkit.org/b/94002 [ Win7 Debug ] inspector/debugger [ Pass Timeout ]
 
 # Flaky
-webkit.org/b/99389 [ Win ] inspector/debugger/xhr-breakpoints.html [ Pass Text ]
+webkit.org/b/99389 [ Win ] inspector/debugger/xhr-breakpoints.html [ Pass Failure ]
 
 # Added by bug 89826
 webkit.org/b/94003 [ Win ] fast/css/word-spacing-characters-complex-text.html [ ImageOnlyFailure ]
@@ -3934,7 +3934,7 @@
 webkit.org/b/98699 [ Lion ] fast/writing-mode/vertical-subst-font-vert-no-dflt.html [ Crash ]
 webkit.org/b/98811 [ Mac ] fast/transforms/transformed-focused-text-input.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/98948 [ Linux Debug ] http/tests/media/media-source/video-media-source-play.html [ PASS CRASH ]
+webkit.org/b/98948 [ Linux Debug ] http/tests/media/media-source/video-media-source-play.html [ Pass Crash ]
 
 webkit.org/b/99089 transforms/3d/general/perspective-units.html [ Pass ImageOnlyFailure ]
 
@@ -3951,7 +3951,7 @@
 
 webkit.org/b/99802 [ MountainLion ] fast/forms/text-control-intrinsic-widths.html [ Failure ]
 
-webkit.org/b/99873 platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html [ Text ]
+webkit.org/b/99873 platform/chromium/virtual/gpu/fast/canvas/webgl/array-bounds-clamping.html [ Failure ]
 
 # These tests are failing already and because of virtual test suite for deferred
 # image decoding they need to be suppressed again.
@@ -4059,8 +4059,8 @@
 
 webkit.org/b/100806 [ Win ] fast/css/font-face-implicit-local-font.html [ Failure ]
 webkit.org/b/100806 [ Win ] fast/css/font-face-unicode-range.html [ Failure ]
-webkit.org/b/100806 [ Win ] fast/css/font-face-descending-unicode-range.html [ Text ]
-webkit.org/b/100806 [ Win ] fast/css/font-face-download-error.html [ Text ]
+webkit.org/b/100806 [ Win ] fast/css/font-face-descending-unicode-range.html [ Failure ]
+webkit.org/b/100806 [ Win ] fast/css/font-face-download-error.html [ Failure ]
 # Seems to have the wrong font in the SVG part of the test (CSS is ok).
 webkit.org/b/100806 [ Win ] svg/custom/font-face-simple.svg [ Failure ]
 
@@ -4079,7 +4079,7 @@
 webkit.org/b/90022 platform/chromium/virtual/gpu/fast/canvas/canvas-resize-reset-pixelRatio.html [ WontFix ]
 webkit.org/b/90022 fast/canvas/canvas-as-image-hidpi.html [ WontFix ]
 webkit.org/b/90022 platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-hidpi.html [ WontFix ]
-webkit.org/b/101986 [ Linux Win ] platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html [ Text ]
+webkit.org/b/101986 [ Linux Win ] platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html [ Failure ]
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-3.html [ Pass ImageOnlyFailure ]
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-origins.html [ Pass ImageOnlyFailure ]
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Pass ImageOnlyFailure ]
@@ -4087,8 +4087,8 @@
 webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass ImageOnlyFailure ]
 webkit.org/b/102131 [ Win ] fast/workers/worker-exception-during-navigation.html [ Pass Crash ]
 webkit.org/b/102264 [ Debug ] css3/filters/custom/custom-filter-property-computed-style.html [ Pass Timeout ]
-webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Text ]
-webkit.org/b/102277 fast/events/overflow-scroll-fake-mouse-move.html [ Pass Text ]
+webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Failure ]
+webkit.org/b/102277 fast/events/overflow-scroll-fake-mouse-move.html [ Pass Failure ]
 webkit.org/b/102294 [ Mac ] 

[webkit-changes] [137347] trunk/LayoutTests

[adamk]

Title: [137347] trunk/LayoutTests








Revision 137347
Author ad...@chromium.org
Date 2012-12-11 13:08:36 -0800 (Tue, 11 Dec 2012)


Log Message
Chromium test expectations update: narrow expecatations for now-passing tests

Unreviewed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137346 => 137347)

--- trunk/LayoutTests/ChangeLog	2012-12-11 20:58:40 UTC (rev 137346)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 21:08:36 UTC (rev 137347)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Chromium test expectations update: narrow expecatations for now-passing tests
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Michael Pruett  mich...@68k.org
 
 [JSC] Add tests for explicit serialization values


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137346 => 137347)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 20:58:40 UTC (rev 137346)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 21:08:36 UTC (rev 137347)
@@ -1987,7 +1987,7 @@
 crbug.com/28005 [ Android ] fast/css/color-correction.html [ Failure ]
 crbug.com/28005 [ Android ] fast/css/color-correction-on-box-shadow.html [ Failure ]
 crbug.com/28005 [ Android ] fast/css/color-correction-on-text-shadow.html [ Failure ]
-crbug.com/28005 [ Android Win ] fast/css/color-correction-on-background-image.html [ Failure ]
+crbug.com/28005 [ Android ] fast/css/color-correction-on-background-image.html [ Failure ]
 crbug.com/28005 [ Android XP ] fast/css/color-correction-untagged-images.html [ Failure ]
 
 # Timeout on Debug.
@@ -2398,9 +2398,9 @@
 code.google.com/p/v8/issues/detail?id=2218 fast/js/string-fontsize.html [ Failure ]
 code.google.com/p/v8/issues/detail?id=2218 fast/js/string-link.html [ Failure ]
 
-webkit.org/b/50282 [ Android Win ] fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html [ Failure ]
-webkit.org/b/50282 [ Android Win ] fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [ Failure ]
-webkit.org/b/50282 [ Android Win ] fast/images/imagemap-focus-ring-outline-color.html [ Failure ]
+webkit.org/b/50282 [ Android ] fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html [ Failure ]
+webkit.org/b/50282 [ Android ] fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [ Failure ]
+webkit.org/b/50282 [ Android ] fast/images/imagemap-focus-ring-outline-color.html [ Failure ]
 webkit.org/b/50282 [ Android ] fast/images/imagemap-circle-focus-ring.html [ Failure ]
 webkit.org/b/50282 [ Android ] fast/images/imagemap-polygon-focus-ring.html [ Failure ]
 
@@ -4063,7 +4063,7 @@
 
 webkit.org/b/100806 [ Win ] fast/css/font-face-implicit-local-font.html [ Failure ]
 webkit.org/b/100806 [ Win ] fast/css/font-face-unicode-range.html [ Failure ]
-webkit.org/b/100806 [ Win ] fast/css/font-face-descending-unicode-range.html [ Failure ]
+webkit.org/b/100806 [ Win ] fast/css/font-face-descending-unicode-range.html [ Pass Failure ]
 webkit.org/b/100806 [ Win ] fast/css/font-face-download-error.html [ Failure ]
 # Seems to have the wrong font in the SVG part of the test (CSS is ok).
 webkit.org/b/100806 [ Win ] svg/custom/font-face-simple.svg [ Failure ]
@@ -4160,7 +4160,7 @@
 # Need baseline
 webkit.org/b/104438 fast/forms/datetimelocal/datetimelocal-appearance-basic.html [ Missing ImageOnlyFailure ]
 webkit.org/b/104438 fast/forms/datetimelocal/datetimelocal-appearance-l10n.html [ Missing ImageOnlyFailure ]
-webkit.org/b/104438 fast/forms/time-multiple-fields/time-multiple-fields-localization.html [ Failure ]
+webkit.org/b/104438 [ Win Linux ] fast/forms/time-multiple-fields/time-multiple-fields-localization.html [ Failure ]
 
 # New tests added in r136492 that do not work in chromium
 webkit.org/b/99800 fast/harness/perftests/runs-per-second-iterations.html [ Failure Pass ]
@@ -4193,9 +4193,6 @@
 webkit.org/b/104283 [ XP ] fonts/monospace.html [ Failure Pass ]
 webkit.org/b/104283 [ Mac Debug ] fonts/monospace.html [ ImageOnlyFailure Pass ]
 
-# First row, third column is wrong.
-crbug.com/164997 compositing/backface-visibility/backface-visibility-webgl.html [ ImageOnlyFailure ]
-
 # Flaky on Win
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html [ Failure Pass ]
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137349] trunk/LayoutTests

[adamk]

Title: [137349] trunk/LayoutTests








Revision 137349
Author ad...@chromium.org
Date 2012-12-11 13:10:35 -0800 (Tue, 11 Dec 2012)


Log Message
Rebaseline floats-wrap-inside-inline-007.html after r137331.

Unreviewed gardening.

* platform/chromium-mac/fast/block/float/floats-wrap-inside-inline-007-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/block/float/floats-wrap-inside-inline-007-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (137348 => 137349)

--- trunk/LayoutTests/ChangeLog	2012-12-11 21:08:38 UTC (rev 137348)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 21:10:35 UTC (rev 137349)
@@ -1,5 +1,13 @@
 2012-12-11  Adam Klein  ad...@chromium.org
 
+Rebaseline floats-wrap-inside-inline-007.html after r137331.
+
+Unreviewed gardening.
+
+* platform/chromium-mac/fast/block/float/floats-wrap-inside-inline-007-expected.png: Added.
+
+2012-12-11  Adam Klein  ad...@chromium.org
+
 Chromium test expectations update: narrow expecatations for now-passing tests
 
 Unreviewed.


Added: trunk/LayoutTests/platform/chromium-mac/fast/block/float/floats-wrap-inside-inline-007-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/block/float/floats-wrap-inside-inline-007-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137352] trunk/LayoutTests

[adamk]

Title: [137352] trunk/LayoutTests








Revision 137352
Author ad...@chromium.org
Date 2012-12-11 13:33:53 -0800 (Tue, 11 Dec 2012)


Log Message
Tweak expectations of inspector/elements/edit-dom-action.html

Unreviewed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137351 => 137352)

--- trunk/LayoutTests/ChangeLog	2012-12-11 21:30:31 UTC (rev 137351)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 21:33:53 UTC (rev 137352)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Tweak expectations of inspector/elements/edit-dom-action.html
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Robert Hogan  rob...@webkit.org
 
 Suppress 5 new ref tests that are failing with small pixel differences on Qt after r137331


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137351 => 137352)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 21:30:31 UTC (rev 137351)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 21:33:53 UTC (rev 137352)
@@ -1032,9 +1032,8 @@
 webkit.org/b/82894 [ Release ] inspector/profiler/heap-snapshot-inspect-dom-wrapper.html [ Pass Timeout ]
 webkit.org/b/82894 [ Debug ] inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
 
-webkit.org/b/60109 [ Win Release ] inspector/elements/edit-dom-actions.html [ Failure Pass ]
-webkit.org/b/60109 [ Win Debug ] inspector/elements/edit-dom-actions.html [ Pass Timeout ]
-webkit.org/b/60109 [ Linux Mac Release ] inspector/elements/edit-dom-actions.html [ Pass Timeout ]
+webkit.org/b/60109 [ Win Linux Mac Release ] inspector/elements/edit-dom-actions.html [ Pass Slow ]
+webkit.org/b/60109 [ Mac Debug ] inspector/elements/edit-dom-actions.html [ Skip ]
 
 webkit.org/b/74654 http/tests/inspector/network/network-worker.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137360] trunk/LayoutTests

[adamk]

Title: [137360] trunk/LayoutTests








Revision 137360
Author ad...@chromium.org
Date 2012-12-11 14:23:21 -0800 (Tue, 11 Dec 2012)


Log Message
Suppress new failing reftest from r137331

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137359 => 137360)

--- trunk/LayoutTests/ChangeLog	2012-12-11 22:16:11 UTC (rev 137359)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 22:23:21 UTC (rev 137360)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Suppress new failing reftest from r137331
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Dan Bernstein  m...@apple.com
 
 rdar://problem/12771885 Support ruby-position: {before, after}


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137359 => 137360)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 22:16:11 UTC (rev 137359)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 22:23:21 UTC (rev 137360)
@@ -4213,3 +4213,6 @@
 
 # Broken by Chromium r172175
 crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ]
+
+# New test added in r137331
+webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137363] trunk/LayoutTests

[adamk]

Title: [137363] trunk/LayoutTests








Revision 137363
Author ad...@chromium.org
Date 2012-12-11 14:45:20 -0800 (Tue, 11 Dec 2012)


Log Message
Mark another inspector test as flaky.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137362 => 137363)

--- trunk/LayoutTests/ChangeLog	2012-12-11 22:36:45 UTC (rev 137362)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 22:45:20 UTC (rev 137363)
@@ -1,5 +1,11 @@
 2012-12-11  Adam Klein  ad...@chromium.org
 
+Mark another inspector test as flaky.
+
+* platform/chromium/TestExpectations:
+
+2012-12-11  Adam Klein  ad...@chromium.org
+
 Suppress new failing reftest from r137331
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137362 => 137363)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 22:36:45 UTC (rev 137362)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 22:45:20 UTC (rev 137363)
@@ -1022,6 +1022,7 @@
 
 webkit.org/b/83890 http/tests/inspector/resource-tree/resource-tree-document-url.html [ Failure Pass Timeout ]
 webkit.org/b/83890 http/tests/inspector/resource-tree/resource-request-content-while-loading.html [ Failure Pass Timeout ]
+webkit.org/b/83890 [ Win Linux Release ] http/tests/inspector/resource-tree/resource-tree-frame-add.html [ Pass Timeout ]
 
 webkit.org/b/60107 [ Win Release ] inspector/console/console-object-constructor-name.html [ Failure Pass ]
 webkit.org/b/60107 [ Win Release ] inspector/console/console-log-before-inspector-open.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137366] trunk/LayoutTests

[adamk]

Title: [137366] trunk/LayoutTests








Revision 137366
Author ad...@chromium.org
Date 2012-12-11 15:11:20 -0800 (Tue, 11 Dec 2012)


Log Message
Mark more tests as flaky for Chromium

Unreviewed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137365 => 137366)

--- trunk/LayoutTests/ChangeLog	2012-12-11 22:56:54 UTC (rev 137365)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 23:11:20 UTC (rev 137366)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Mark more tests as flaky for Chromium
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Emil A Eklund  e...@chromium.org
 
 Clamp out-of-range numbers in CSS


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137365 => 137366)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 22:56:54 UTC (rev 137365)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:11:20 UTC (rev 137366)
@@ -1023,6 +1023,8 @@
 webkit.org/b/83890 http/tests/inspector/resource-tree/resource-tree-document-url.html [ Failure Pass Timeout ]
 webkit.org/b/83890 http/tests/inspector/resource-tree/resource-request-content-while-loading.html [ Failure Pass Timeout ]
 webkit.org/b/83890 [ Win Linux Release ] http/tests/inspector/resource-tree/resource-tree-frame-add.html [ Pass Timeout ]
+webkit.org/b/83890 [ Win Linux Release ] http/tests/inspector/resource-tree/resource-tree-events.html [ Pass Timeout ]
+webkit.org/b/83890 [ Win Linux Release ] http/tests/inspector/resource-tree/resource-tree-non-unique-url.html [ Pass Failure ]
 
 webkit.org/b/60107 [ Win Release ] inspector/console/console-object-constructor-name.html [ Failure Pass ]
 webkit.org/b/60107 [ Win Release ] inspector/console/console-log-before-inspector-open.html [ Failure Pass ]
@@ -4182,6 +4184,9 @@
 
 webkit.org/b/103487 [ Linux ] fast/forms/placeholder-position.html [ ImageOnlyFailure Pass ]
 
+webkit.org/b/104727 transforms/3d/hit-testing/backface-hit-test.html [ Pass ImageOnlyFailure ]
+webkit.org/b/104727 transforms/3d/hit-testing/backface-no-transform-hit-test.html [ Pass ImageOnlyFailure ]
+
 # Fail only on WebKit-only checkout
 webkit.org/b/104548 [ Linux ] fast/text/hyphenate-character.html [ Failure ]
 webkit.org/b/104548 [ Linux ] fast/text/hyphenate-first-word.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137372] trunk/LayoutTests

[adamk]

Title: [137372] trunk/LayoutTests








Revision 137372
Author ad...@chromium.org
Date 2012-12-11 15:34:25 -0800 (Tue, 11 Dec 2012)


Log Message
Mark fast/ruby/position-after.html as failing on cr-linux

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137371 => 137372)

--- trunk/LayoutTests/ChangeLog	2012-12-11 23:33:55 UTC (rev 137371)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 23:34:25 UTC (rev 137372)
@@ -1,3 +1,11 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Mark fast/ruby/position-after.html as failing on cr-linux
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-11  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137371 => 137372)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:33:55 UTC (rev 137371)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:34:25 UTC (rev 137372)
@@ -4222,3 +4222,5 @@
 
 # New test added in r137331
 webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ Failure ]
+
+webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137374] trunk/LayoutTests

[adamk]

Title: [137374] trunk/LayoutTests








Revision 137374
Author ad...@chromium.org
Date 2012-12-11 15:42:11 -0800 (Tue, 11 Dec 2012)


Log Message
More inspector flakiness

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137373 => 137374)

--- trunk/LayoutTests/ChangeLog	2012-12-11 23:42:09 UTC (rev 137373)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 23:42:11 UTC (rev 137374)
@@ -1,5 +1,11 @@
 2012-12-11  Adam Klein  ad...@chromium.org
 
+More inspector flakiness
+
+* platform/chromium/TestExpectations:
+
+2012-12-11  Adam Klein  ad...@chromium.org
+
 Mark fast/ruby/position-after.html as failing on cr-linux
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137373 => 137374)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:42:09 UTC (rev 137373)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:42:11 UTC (rev 137374)
@@ -1036,8 +1036,10 @@
 webkit.org/b/82894 [ Debug ] inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
 
 webkit.org/b/60109 [ Win Linux Mac Release ] inspector/elements/edit-dom-actions.html [ Pass Slow ]
-webkit.org/b/60109 [ Mac Debug ] inspector/elements/edit-dom-actions.html [ Skip ]
+webkit.org/b/60109 [ Win Mac Debug ] inspector/elements/edit-dom-actions.html [ Skip ]
 
+webkit.org/b/90488 [ Mac Debug ] inspector/elements/edit-style-attribute.html [ Pass Timeout ]
+
 webkit.org/b/74654 http/tests/inspector/network/network-worker.html
 
 webkit.org/b/75186 [ Linux ] http/tests/inspector-enabled/dedicated-workers-list.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137376] trunk/LayoutTests

[adamk]

Title: [137376] trunk/LayoutTests








Revision 137376
Author ad...@chromium.org
Date 2012-12-11 16:11:58 -0800 (Tue, 11 Dec 2012)


Log Message
More flakiness.

Unreviewed chromium gardening.

Hopefully all these flaky markings will help make the CQ more reliable.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137375 => 137376)

--- trunk/LayoutTests/ChangeLog	2012-12-11 23:45:29 UTC (rev 137375)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 00:11:58 UTC (rev 137376)
@@ -1,5 +1,15 @@
 2012-12-11  Adam Klein  ad...@chromium.org
 
+More flakiness.
+
+Unreviewed chromium gardening.
+
+Hopefully all these flaky markings will help make the CQ more reliable.
+
+* platform/chromium/TestExpectations:
+
+2012-12-11  Adam Klein  ad...@chromium.org
+
 More inspector flakiness
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137375 => 137376)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 23:45:29 UTC (rev 137375)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 00:11:58 UTC (rev 137376)
@@ -4077,7 +4077,8 @@
 
 webkit.org/b/101377 [ Linux MountainLion ] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html [ Failure ImageOnlyFailure Pass Crash ]
 
-webkit.org/b/101408 platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure Pass ]
+webkit.org/b/101408 [ Mac ] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]
+webkit.org/b/101408 platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html [ Failure Pass ]
 
 webkit.org/b/101539 [ Linux Win ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137380] trunk/LayoutTests

[adamk]

Title: [137380] trunk/LayoutTests








Revision 137380
Author ad...@chromium.org
Date 2012-12-11 16:28:07 -0800 (Tue, 11 Dec 2012)


Log Message
Rebaselines after r137359

Unreviewed chromium gardening.

* platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png: Added.
* platform/chromium-mac/fast/ruby/position-after-expected.png: Added.
* platform/chromium-win/fast/ruby/position-after-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/ruby/position-after-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png
trunk/LayoutTests/platform/chromium-win/fast/ruby/position-after-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (137379 => 137380)

--- trunk/LayoutTests/ChangeLog	2012-12-12 00:21:43 UTC (rev 137379)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 00:28:07 UTC (rev 137380)
@@ -1,3 +1,13 @@
+2012-12-11  Adam Klein  ad...@chromium.org
+
+Rebaselines after r137359
+
+Unreviewed chromium gardening.
+
+* platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png: Added.
+* platform/chromium-mac/fast/ruby/position-after-expected.png: Added.
+* platform/chromium-win/fast/ruby/position-after-expected.png: Added.
+
 2012-12-11  Nate Chapin  jap...@chromium.org
 
 Revert changes to resource-parameters.html introduced in r137333.


Added: trunk/LayoutTests/platform/chromium-mac/fast/ruby/position-after-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/ruby/position-after-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/fast/ruby/position-after-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/fast/ruby/position-after-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137382] trunk/LayoutTests

[adamk]

Title: [137382] trunk/LayoutTests








Revision 137382
Author ad...@chromium.org
Date 2012-12-11 16:32:36 -0800 (Tue, 11 Dec 2012)


Log Message
Unreviewed. Tweak expectations to be image-only.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137381 => 137382)

--- trunk/LayoutTests/ChangeLog	2012-12-12 00:29:01 UTC (rev 137381)
+++ trunk/LayoutTests/ChangeLog	2012-12-12 00:32:36 UTC (rev 137382)
@@ -1,5 +1,10 @@
 2012-12-11  Adam Klein  ad...@chromium.org
+Unreviewed. Tweak expectations to be image-only.
 
+* platform/chromium/TestExpectations:
+
+2012-12-11  Adam Klein  ad...@chromium.org
+
 Rebaselines after r137359
 
 Unreviewed chromium gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137381 => 137382)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 00:29:01 UTC (rev 137381)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-12 00:32:36 UTC (rev 137382)
@@ -4224,6 +4224,6 @@
 crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ]
 
 # New test added in r137331
-webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ Failure ]
+webkit.org/b/104715 [ MountainLion ] fast/block/float/floats-wrap-inside-inline-007.html [ ImageOnlyFailure ]
 
 webkit.org/b/103667 [ Linux ] fast/ruby/position-after.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137165] trunk/LayoutTests

[adamk]

Title: [137165] trunk/LayoutTests








Revision 137165
Author ad...@chromium.org
Date 2012-12-10 09:19:55 -0800 (Mon, 10 Dec 2012)


Log Message
Remove expectation of previously failing test.
It passes after r137152.

Unreviewed gardening.

* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (137164 => 137165)

--- trunk/LayoutTests/ChangeLog	2012-12-10 17:14:13 UTC (rev 137164)
+++ trunk/LayoutTests/ChangeLog	2012-12-10 17:19:55 UTC (rev 137165)
@@ -1,3 +1,12 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+Remove expectation of previously failing test.
+It passes after r137152.
+
+Unreviewed gardening.
+
+* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
+
 2012-12-10  Eric Carlson  eric.carl...@apple.com
 
 Add support for in-band text tracks to Mac port


Deleted: trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt (137164 => 137165)

--- trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt	2012-12-10 17:14:13 UTC (rev 137164)
+++ trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt	2012-12-10 17:19:55 UTC (rev 137165)
@@ -1,54 +0,0 @@
-Multiple fields UI of time input type with keyboard events
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-Please run this with DumpRenderTree.
-
-Test following keys:
-Digit keys
-Left/Right - Move focus field inside element
-Up/Down - Increment/decrement value of focus field
-Tab - Move focus field
-Backspace - Make value empty
-  
-== Digit keys ==
-PASS input.value is 07:56
-== Left/Right keys ==
-PASS input.value is 06:05
-PASS document.activeElement.id is input
-== Up/Down keys ==
-PASS input.value is 05:56
-PASS input.value is 03:56
-== Up/Down keys on empty value ==
-PASS input.value is 14:58
-== Tab key ==
-PASS input.value is 03:05
-PASS input.value is 07:05
-PASS document.activeElement.id is another
-== Tab navigation should skip disabled/readonly inputs ==
-PASS document.activeElement.id is another
-PASS document.activeElement.id is another
-== Shfit+Tab key ==
-PASS input.value is 15:00
-PASS input.value is 15:03
-PASS document.activeElement.id is before
-== Up key on maximum value ==
-PASS input.value is 13:00
-== Down key on minimum value ==
-PASS input.value is 00:59:59.999
-== Backspace key ==
-PASS input.value is 
-== Delete key ==
-PASS input.value is 
-== Typeahead ==
-PASS input.value is 12:01:56
-PASS input.value is 12:02:56
-== RTL Left/Right keys ==
-PASS input.value is 01:56
-FAIL input.value should be 01:02. Was 00:56.
-FAIL input.value should be 03:02. Was 00:56.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137167] trunk/Source/WebCore

[adamk]

Title: [137167] trunk/Source/WebCore








Revision 137167
Author ad...@chromium.org
Date 2012-12-10 09:28:02 -0800 (Mon, 10 Dec 2012)


Log Message
cr-win build fix after r137161.

Unreviewed.

* platform/graphics/MediaPlayer.h: Replace forward-decl of
InbandTextTrackPrivate with #include as the definition is required.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/MediaPlayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (137166 => 137167)

--- trunk/Source/WebCore/ChangeLog	2012-12-10 17:25:58 UTC (rev 137166)
+++ trunk/Source/WebCore/ChangeLog	2012-12-10 17:28:02 UTC (rev 137167)
@@ -1,3 +1,12 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+cr-win build fix after r137161.
+
+Unreviewed.
+
+* platform/graphics/MediaPlayer.h: Replace forward-decl of
+InbandTextTrackPrivate with #include as the definition is required.
+
 2012-12-10  Alexis Menard  ale...@webkit.org
 
 [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.


Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (137166 => 137167)

--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2012-12-10 17:25:58 UTC (rev 137166)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2012-12-10 17:28:02 UTC (rev 137167)
@@ -32,6 +32,7 @@
 #include MediaPlayerProxy.h
 #endif
 
+#include InbandTextTrackPrivate.h
 #include IntRect.h
 #include KURL.h
 #include LayoutRect.h
@@ -59,7 +60,6 @@
 class AudioSourceProvider;
 class Document;
 class GStreamerGWorld;
-class InbandTextTrackPrivate;
 class MediaPlayerPrivateInterface;
 class MediaSource;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137170] trunk/LayoutTests

[adamk]

Title: [137170] trunk/LayoutTests








Revision 137170
Author ad...@chromium.org
Date 2012-12-10 09:35:21 -0800 (Mon, 10 Dec 2012)


Log Message
Chromium test expectations update after r137152.
Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137169 => 137170)

--- trunk/LayoutTests/ChangeLog	2012-12-10 17:31:35 UTC (rev 137169)
+++ trunk/LayoutTests/ChangeLog	2012-12-10 17:35:21 UTC (rev 137170)
@@ -1,3 +1,10 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+Chromium test expectations update after r137152.
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-10  Alejandro Piñeiro  apinhe...@igalia.com
 
 AX: wrong Enabled states on a ListBox


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137169 => 137170)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 17:31:35 UTC (rev 137169)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 17:35:21 UTC (rev 137170)
@@ -4226,3 +4226,7 @@
 
 # Flaky on Win (perhaps due to lighttpd?)
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html [ Failure Pass ]
+
+# Failing differently since r137152, probably just need rebaselines
+webkit.org/b/104567 [ XP ] fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html [ Failure ]
+webkit.org/b/104567 [ XP ] fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137171] trunk/Source/WebCore

[adamk]

Title: [137171] trunk/Source/WebCore








Revision 137171
Author ad...@chromium.org
Date 2012-12-10 09:48:33 -0800 (Mon, 10 Dec 2012)


Log Message
In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.

Unreviewed build fix.

* platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::label):
(WebCore::InbandTextTrackPrivate::language):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (137170 => 137171)

--- trunk/Source/WebCore/ChangeLog	2012-12-10 17:35:21 UTC (rev 137170)
+++ trunk/Source/WebCore/ChangeLog	2012-12-10 17:48:33 UTC (rev 137171)
@@ -1,3 +1,13 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.
+
+Unreviewed build fix.
+
+* platform/graphics/InbandTextTrackPrivate.h:
+(WebCore::InbandTextTrackPrivate::label):
+(WebCore::InbandTextTrackPrivate::language):
+
 2012-12-10  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.


Modified: trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h (137170 => 137171)

--- trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h	2012-12-10 17:35:21 UTC (rev 137170)
+++ trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h	2012-12-10 17:48:33 UTC (rev 137171)
@@ -56,8 +56,8 @@
 enum Kind { Subtitles, Captions, Descriptions, Chapters, Metadata, None };
 virtual Kind kind() const { return Subtitles; }
 
-virtual AtomicString label() const { return emptyString(); }
-virtual AtomicString language() const { return emptyString(); }
+virtual AtomicString label() const { return emptyAtom; }
+virtual AtomicString language() const { return emptyAtom; }
 virtual bool isDefault() const { return false; }
 
 virtual int textTrackIndex() const { return 0; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137174] trunk/LayoutTests

[adamk]

Title: [137174] trunk/LayoutTests








Revision 137174
Author ad...@chromium.org
Date 2012-12-10 09:58:55 -0800 (Mon, 10 Dec 2012)


Log Message
inspector/styles/styles-computed-trace still times out after r137156.

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137173 => 137174)

--- trunk/LayoutTests/ChangeLog	2012-12-10 17:55:00 UTC (rev 137173)
+++ trunk/LayoutTests/ChangeLog	2012-12-10 17:58:55 UTC (rev 137174)
@@ -1,3 +1,11 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+inspector/styles/styles-computed-trace still times out after r137156.
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-10  Ryosuke Niwa  rn...@webkit.org
 
 Removed failing test expectations for GTK+ port after r137107.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137173 => 137174)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 17:55:00 UTC (rev 137173)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-10 17:58:55 UTC (rev 137174)
@@ -97,6 +97,9 @@
 webkit.org/b/90488 [ Debug ] http/tests/inspector [ Pass Slow ]
 webkit.org/b/90488 [ Debug ] http/tests/inspector-enabled [ Pass Slow ]
 
+# Similar slowness, but always times out on some platforms.
+webkit.org/b/90488 [ Win Mac Debug ] inspector/styles/styles-computed-trace.html [ Timeout ]
+
 # Chromium r163873 slowed down these tests
 webkit.org/b/100287 [ Linux Win Mac ] compositing/culling/filter-occlusion-blur-large.html [ Pass Slow ]
 webkit.org/b/66989 transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ImageOnlyFailure Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137212] branches/chromium/1312/Source

[adamk]

Title: [137212] branches/chromium/1312/Source








Revision 137212
Author ad...@chromium.org
Date 2012-12-10 15:06:42 -0800 (Mon, 10 Dec 2012)


Log Message
Merge 136785
 Add runtime enable for web intents.
 https://bugs.webkit.org/show_bug.cgi?id=103669
 
 Patch by Greg Billock gbill...@google.com on 2012-12-05
 Reviewed by Adam Barth.
 
 Source/WebCore:
 
 Make web intents _javascript_ API enabled by a runtime setting.
 
 * Modules/intents/DOMWindowIntents.idl:
 * Modules/intents/NavigatorIntents.idl:
 * bindings/generic/RuntimeEnabledFeatures.cpp:
 (WebCore):
 * bindings/generic/RuntimeEnabledFeatures.h:
 (RuntimeEnabledFeatures):
 (WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled):
 (WebCore::RuntimeEnabledFeatures::webkitIntentEnabled):
 (WebCore::RuntimeEnabledFeatures::webKitIntentEnabled):
 (WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled):
 
 Source/WebKit/chromium:
 
 Propagate runtime setting to enable/disable web intents _javascript_ API.
 
 * public/WebRuntimeFeatures.h:
 (WebRuntimeFeatures):
 * src/WebRuntimeFeatures.cpp:
 (WebKit::WebRuntimeFeatures::enableWebIntents):
 (WebKit):
 (WebKit::WebRuntimeFeatures::isWebIntentsEnabled):

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11519009

Modified Paths

branches/chromium/1312/Source/WebCore/Modules/intents/DOMWindowIntents.idl
branches/chromium/1312/Source/WebCore/Modules/intents/NavigatorIntents.idl
branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
branches/chromium/1312/Source/WebKit/chromium/public/WebRuntimeFeatures.h
branches/chromium/1312/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp




Diff

Modified: branches/chromium/1312/Source/WebCore/Modules/intents/DOMWindowIntents.idl (137211 => 137212)

--- branches/chromium/1312/Source/WebCore/Modules/intents/DOMWindowIntents.idl	2012-12-10 23:01:20 UTC (rev 137211)
+++ branches/chromium/1312/Source/WebCore/Modules/intents/DOMWindowIntents.idl	2012-12-10 23:06:42 UTC (rev 137212)
@@ -28,8 +28,8 @@
 Conditional=WEB_INTENTS,
 Supplemental=DOMWindow
 ] interface DOMWindowIntents {
-attribute IntentConstructor WebKitIntent;
+[V8EnabledAtRuntime] attribute IntentConstructor WebKitIntent;
 
-[Replaceable] readonly attribute DeliveredIntent webkitIntent;
+[Replaceable, V8EnabledAtRuntime] readonly attribute DeliveredIntent webkitIntent;
 };
 


Modified: branches/chromium/1312/Source/WebCore/Modules/intents/NavigatorIntents.idl (137211 => 137212)

--- branches/chromium/1312/Source/WebCore/Modules/intents/NavigatorIntents.idl	2012-12-10 23:01:20 UTC (rev 137211)
+++ branches/chromium/1312/Source/WebCore/Modules/intents/NavigatorIntents.idl	2012-12-10 23:06:42 UTC (rev 137212)
@@ -21,9 +21,9 @@
 Conditional=WEB_INTENTS,
 Supplemental=Navigator
 ] interface NavigatorIntents {
-void webkitStartActivity(in Intent intent,
- in [Callback, Optional] IntentResultCallback successCallback,
- in [Callback, Optional] IntentResultCallback failureCallback)
+[V8EnabledAtRuntime] void webkitStartActivity(in Intent intent,
+  in [Callback, Optional] IntentResultCallback successCallback,
+  in [Callback, Optional] IntentResultCallback failureCallback)
 raises(DOMException);
 };
 


Modified: branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (137211 => 137212)

--- branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-12-10 23:01:20 UTC (rev 137211)
+++ branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-12-10 23:06:42 UTC (rev 137212)
@@ -241,4 +241,8 @@
 bool RuntimeEnabledFeatures::isDialogElementEnabled = false;
 #endif
 
+#if ENABLE(WEB_INTENTS)
+bool RuntimeEnabledFeatures::isWebIntentsEnabled = true;
+#endif
+
 } // namespace WebCore


Modified: branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (137211 => 137212)

--- branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-12-10 23:01:20 UTC (rev 137211)
+++ branches/chromium/1312/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-12-10 23:06:42 UTC (rev 137212)
@@ -259,6 +259,13 @@
 // The lang attribute support is incomplete and should only be turned on for tests.
 static void setLangAttributeAwareFormControlUIEnabled(bool isEnabled) { isLangAttributeAwareFormControlUIEnabled = isEnabled; }
 
+#if ENABLE(WEB_INTENTS)
+static bool webkitStartActivityEnabled() { return isWebIntentsEnabled; }
+static bool webkitIntentEnabled() { return isWebIntentsEnabled; }
+static bool webKitIntentEnabled() { return isWebIntentsEnabled; }
+static void setWebIntentsEnabled(bool isEnabled) { isWebIntentsEnabled = isEnabled; }

[webkit-changes] [137225] trunk/LayoutTests

[adamk]

Title: [137225] trunk/LayoutTests








Revision 137225
Author ad...@chromium.org
Date 2012-12-10 16:43:37 -0800 (Mon, 10 Dec 2012)


Log Message
Mark an encrypted media test as failing after http://crrev.com/172175
Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137224 => 137225)

--- trunk/LayoutTests/ChangeLog	2012-12-11 00:32:01 UTC (rev 137224)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 00:43:37 UTC (rev 137225)
@@ -1,3 +1,10 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+Mark an encrypted media test as failing after http://crrev.com/172175
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-10  Min Qin  qin...@chromium.org
 
 Sending multi-touch events to the same Iframe


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137224 => 137225)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 00:32:01 UTC (rev 137224)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 00:43:37 UTC (rev 137225)
@@ -4222,3 +4222,6 @@
 # Failing differently since r137152, probably just need rebaselines
 webkit.org/b/104567 [ XP ] fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html [ Failure ]
 webkit.org/b/104567 [ XP ] fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html [ Failure ]
+
+# Broken by Chromium r172175
+crbug.com/165315 media/encrypted-media/encrypted-media-can-play-type-webm.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137232] trunk/LayoutTests

[adamk]

Title: [137232] trunk/LayoutTests








Revision 137232
Author ad...@chromium.org
Date 2012-12-10 17:40:46 -0800 (Mon, 10 Dec 2012)


Log Message
Expand flakiness of move-by-line-001.html.
Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137231 => 137232)

--- trunk/LayoutTests/ChangeLog	2012-12-11 01:35:28 UTC (rev 137231)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 01:40:46 UTC (rev 137232)
@@ -1,3 +1,10 @@
+2012-12-10  Adam Klein  ad...@chromium.org
+
+Expand flakiness of move-by-line-001.html.
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-12-10  Aaron Colwell  acolw...@chromium.org
 
 Temporarily disable video-media-source-seek.html  video-media-source-state-changes.html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137231 => 137232)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 01:35:28 UTC (rev 137231)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 01:40:46 UTC (rev 137232)
@@ -3677,7 +3677,8 @@
 webkit.org/b/94017 [ Win ] css2.1/20110323/c541-word-sp-000.htm [ ImageOnlyFailure ]
 
 webkit.org/b/94059 [ Debug ] editing/selection/move-by-line-001.html [ Failure Pass ]
-webkit.org/b/94059 [ Lion Release ] editing/selection/move-by-line-001.html [ Failure Pass ]
+webkit.org/b/94059 [ Linux Release ] editing/selection/move-by-line-001.html [ Failure Pass ]
+webkit.org/b/94059 [ Lion Release ] editing/selection/move-by-line-001.html [ Failure ImageOnlyFailure Pass ]
 
 webkit.org/b/94078 [ Win Release ] http/tests/inspector/web-socket-frame-error.html [ Failure Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137235] trunk/LayoutTests

[adamk]

Title: [137235] trunk/LayoutTests








Revision 137235
Author ad...@chromium.org
Date 2012-12-10 17:54:16 -0800 (Mon, 10 Dec 2012)


Log Message
Rewrite last occurrences of Image in TestExpectations to ImageOnlyFailure.
Unreviewed test expectations update.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137234 => 137235)

--- trunk/LayoutTests/ChangeLog	2012-12-11 01:48:10 UTC (rev 137234)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 01:54:16 UTC (rev 137235)
@@ -1,5 +1,12 @@
 2012-12-10  Adam Klein  ad...@chromium.org
 
+Rewrite last occurrences of Image in TestExpectations to ImageOnlyFailure.
+Unreviewed test expectations update.
+
+* platform/chromium/TestExpectations:
+
+2012-12-10  Adam Klein  ad...@chromium.org
+
 Expand flakiness of move-by-line-001.html.
 Unreviewed gardening.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137234 => 137235)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 01:48:10 UTC (rev 137234)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 01:54:16 UTC (rev 137235)
@@ -4043,7 +4043,7 @@
 
 webkit.org/b/79446 svg/repaint/image-with-clip-path.svg [ Pass ImageOnlyFailure ]
 
-# Image is incorrect:  feSpecularLighting sample has a Y-flip.
+# ImageOnlyFailure is incorrect:  feSpecularLighting sample has a Y-flip.
 webkit.org/b/104289 css3/filters/effect-reference-hw.html [ Failure ImageOnlyFailure ]
 
 # Only ready for JSC so far, not fixed in v8 yet.
@@ -4092,11 +4092,11 @@
 webkit.org/b/90022 fast/canvas/canvas-as-image-hidpi.html [ WontFix ]
 webkit.org/b/90022 platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-hidpi.html [ WontFix ]
 webkit.org/b/101986 [ Linux Win ] platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html [ Text ]
-webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-3.html [ Pass Image ]
-webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-origins.html [ Pass Image ]
-webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Pass Image ]
-webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Pass Image ]
-webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass Image ]
+webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-3.html [ Pass ImageOnlyFailure ]
+webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-origins.html [ Pass ImageOnlyFailure ]
+webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Pass ImageOnlyFailure ]
+webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Pass ImageOnlyFailure ]
+webkit.org/b/101988 [ Linux Mac Win ] transforms/3d/point-mapping/3d-point-mapping.html [ Pass ImageOnlyFailure ]
 webkit.org/b/102131 [ Win ] fast/workers/worker-exception-during-navigation.html [ Pass Crash ]
 webkit.org/b/102264 [ Debug ] css3/filters/custom/custom-filter-property-computed-style.html [ Pass Timeout ]
 webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Text ]
@@ -4107,7 +4107,6 @@
 
 # This test is consistently leaking state into the next test.
 webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ]
-webkit.org/b/102542 [ Win7 ] platform/chromium/virtual/softwarecompositing/checkerboard.html [ Image ]
 webkit.org/b/102542 [ Linux Mac Win ] compositing/checkerboard.html [ ImageOnlyFailure ]
 
 webkit.org/b/102724 [ Linux ] svg/carto.net/colourpicker.svg [ ImageOnlyFailure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137238] trunk/LayoutTests

[adamk]

Title: [137238] trunk/LayoutTests








Revision 137238
Author ad...@chromium.org
Date 2012-12-10 18:06:01 -0800 (Mon, 10 Dec 2012)


Log Message
Fix expectations lint errors in r137231
Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (137237 => 137238)

--- trunk/LayoutTests/ChangeLog	2012-12-11 02:00:26 UTC (rev 137237)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 02:06:01 UTC (rev 137238)
@@ -1,5 +1,12 @@
 2012-12-10  Adam Klein  ad...@chromium.org
 
+Fix expectations lint errors in r137231
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
+2012-12-10  Adam Klein  ad...@chromium.org
+
 Rewrite last occurrences of Image in TestExpectations to ImageOnlyFailure.
 Unreviewed test expectations update.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (137237 => 137238)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 02:00:26 UTC (rev 137237)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-12-11 02:06:01 UTC (rev 137238)
@@ -3847,8 +3847,8 @@
 webkit.org/b/96628 [ Lion MountainLion ] fast/frames/calculate-order.html [ Failure Pass ]
 webkit.org/b/96550 http/tests/media/media-source/seek-to-end-after-duration-change.html [ Pass Timeout ]
 
-webkit.org/b/104584 http/tests/media/media-source/video-media-source-seek.html [ Skip ]
-webkit.org/b/104584 http/tests/media/media-source/video-media-source-state-changes.html [ Skip ]
+webkit.org/b/104584 [ Win Mac Linux ] http/tests/media/media-source/video-media-source-seek.html [ Skip ]
+webkit.org/b/104584 [ Win Mac Linux ] http/tests/media/media-source/video-media-source-state-changes.html [ Skip ]
 
 crbug.com/63921 platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html [ Failure ]
 webkit.org/b/77550 platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [137021] trunk

[adamk]

Title: [137021] trunk








Revision 137021
Author ad...@chromium.org
Date 2012-12-08 01:22:06 -0800 (Sat, 08 Dec 2012)


Log Message
HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
https://bugs.webkit.org/show_bug.cgi?id=104407

Reviewed by Eric Seidel.

Source/WebCore:

When parsing via innerHTML, ensure that all operations (including the
initial fragment creation) occur in the proper document to avoid,
e.g., images loading while being parsed into the template contents.
This matches the parsing behavior during page load.

Test: fast/dom/HTMLTemplateElement/innerHTML-inert.html

* editing/markup.cpp:
(WebCore::createFragmentForInnerOuterHTML):

LayoutTests:

* fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt: Added.
* fast/dom/HTMLTemplateElement/innerHTML-inert.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/markup.cpp


Added Paths

trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert.html




Diff

Modified: trunk/LayoutTests/ChangeLog (137020 => 137021)

--- trunk/LayoutTests/ChangeLog	2012-12-08 08:36:58 UTC (rev 137020)
+++ trunk/LayoutTests/ChangeLog	2012-12-08 09:22:06 UTC (rev 137021)
@@ -1,3 +1,13 @@
+2012-12-08  Adam Klein  ad...@chromium.org
+
+HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
+https://bugs.webkit.org/show_bug.cgi?id=104407
+
+Reviewed by Eric Seidel.
+
+* fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/innerHTML-inert.html: Added.
+
 2012-12-07  Stephen White  senorbla...@chromium.org
 
 [Chromium] Unreviewed gardening.


Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt (0 => 137021)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt	2012-12-08 09:22:06 UTC (rev 137021)
@@ -0,0 +1,11 @@
+Blocked access to external URL http://active.com/bar.jpg
+Test that setting HTMLTemplateElement.innerHTML uses the inert document when creating elements
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS attemptedLoad is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert.html (0 => 137021)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/innerHTML-inert.html	2012-12-08 09:22:06 UTC (rev 137021)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+script src=""
+script
+description(Test that setting HTMLTemplateElement.innerHTML uses the inert document when creating elements);
+jsTestIsAsync = true;
+
+var template = document.createElement('template');
+var div = document.createElement('div');
+var attemptedLoad = false;
+function finish() {
+shouldBeFalse('attemptedLoad');
+finishJSTest();
+}
+
+template.innerHTML = 'img src="" _onerror_=attemptedLoad = true';
+div.innerHTML = 'img src="" _onerror_=finish()';
+/script
+script src=""


Modified: trunk/Source/WebCore/ChangeLog (137020 => 137021)

--- trunk/Source/WebCore/ChangeLog	2012-12-08 08:36:58 UTC (rev 137020)
+++ trunk/Source/WebCore/ChangeLog	2012-12-08 09:22:06 UTC (rev 137021)
@@ -1,3 +1,20 @@
+2012-12-08  Adam Klein  ad...@chromium.org
+
+HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
+https://bugs.webkit.org/show_bug.cgi?id=104407
+
+Reviewed by Eric Seidel.
+
+When parsing via innerHTML, ensure that all operations (including the
+initial fragment creation) occur in the proper document to avoid,
+e.g., images loading while being parsed into the template contents.
+This matches the parsing behavior during page load.
+
+Test: fast/dom/HTMLTemplateElement/innerHTML-inert.html
+
+* editing/markup.cpp:
+(WebCore::createFragmentForInnerOuterHTML):
+
 2012-12-08  ChangSeok Oh  shivami...@gmail.com
 
 Assertion failed at WebCore::RedirectedXCompositeWindow::context()


Modified: trunk/Source/WebCore/editing/markup.cpp (137020 => 137021)

--- trunk/Source/WebCore/editing/markup.cpp	2012-12-08 08:36:58 UTC (rev 137020)
+++ trunk/Source/WebCore/editing/markup.cpp	2012-12-08 09:22:06 UTC (rev 137021)
@@ -997,6 +997,10 @@
 PassRefPtrDocumentFragment createFragmentForInnerOuterHTML(const String markup, Element* contextElement, FragmentScriptingPermission scriptingPermission, ExceptionCode ec)
 {
 Document* document = contextElement-document();
+#if ENABLE(TEMPLATE_ELEMENT)
+if (contextElement-hasTagName(templateTag))
+document = document-templateContentsOwnerDocument();
+#endif
  

[webkit-changes] [136996] trunk

[adamk]

Title: [136996] trunk








Revision 136996
Author ad...@chromium.org
Date 2012-12-07 15:43:48 -0800 (Fri, 07 Dec 2012)


Log Message
MutationRecord addedNodes/removedNodes should never be null
https://bugs.webkit.org/show_bug.cgi?id=98921

Reviewed by Ryosuke Niwa.

Source/WebCore:

Per an update to the DOM4 spec that matches Gecko's behavior,
addedNodes/removedNodes should be empty NodeLists on 'attributes'
and 'characterData' records, rather than null.

This is accomplished with lazy initialization of addedNodes/removedNodes
attributes on 'attributes'/'characterData' records and the
addition of a new StaticNodeList::createEmpty() factory method.

* dom/MutationRecord.cpp:
* dom/MutationRecord.h:
(MutationRecord):
* dom/StaticNodeList.h:
(WebCore::StaticNodeList::adopt):
(StaticNodeList):
(WebCore::StaticNodeList::createEmpty):
(WebCore::StaticNodeList::StaticNodeList):

LayoutTests:

Updated nullity test to check for empty nodelists.

* fast/mutation/mutation-record-nullity-expected.txt:
* fast/mutation/mutation-record-nullity.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt
trunk/LayoutTests/fast/mutation/mutation-record-nullity.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationRecord.cpp
trunk/Source/WebCore/dom/MutationRecord.h
trunk/Source/WebCore/dom/StaticNodeList.h




Diff

Modified: trunk/LayoutTests/ChangeLog (136995 => 136996)

--- trunk/LayoutTests/ChangeLog	2012-12-07 23:42:02 UTC (rev 136995)
+++ trunk/LayoutTests/ChangeLog	2012-12-07 23:43:48 UTC (rev 136996)
@@ -1,3 +1,15 @@
+2012-12-07  Adam Klein  ad...@chromium.org
+
+MutationRecord addedNodes/removedNodes should never be null
+https://bugs.webkit.org/show_bug.cgi?id=98921
+
+Reviewed by Ryosuke Niwa.
+
+Updated nullity test to check for empty nodelists.
+
+* fast/mutation/mutation-record-nullity-expected.txt:
+* fast/mutation/mutation-record-nullity.html:
+
 2012-12-07  Emil A Eklund  e...@chromium.org
 
 Unreviewed chromium-win rebaselines.


Modified: trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt (136995 => 136996)

--- trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt	2012-12-07 23:42:02 UTC (rev 136995)
+++ trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt	2012-12-07 23:43:48 UTC (rev 136996)
@@ -1,4 +1,4 @@
-Non-relevant properties on mutation records should be null
+Non-relevant properties on mutation records should be null, except for NodeLists, which should be empty
 
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
@@ -7,10 +7,10 @@
 PASS record.attributeName is null
 PASS record.attributeNamespace is null
 PASS record.oldValue is null
-PASS record.addedNodes is null
-PASS record.removedNodes is null
 PASS record.previousSibling is null
 PASS record.nextSibling is null
+PASS record.addedNodes.length is 0
+PASS record.removedNodes.length is 0
 
 childList record:
 PASS record.attributeName is null
@@ -20,10 +20,10 @@
 attributes record:
 PASS record.attributeNamespace is null
 PASS record.oldValue is null
-PASS record.addedNodes is null
-PASS record.removedNodes is null
 PASS record.previousSibling is null
 PASS record.nextSibling is null
+PASS record.addedNodes.length is 0
+PASS record.removedNodes.length is 0
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/mutation/mutation-record-nullity.html (136995 => 136996)

--- trunk/LayoutTests/fast/mutation/mutation-record-nullity.html	2012-12-07 23:42:02 UTC (rev 136995)
+++ trunk/LayoutTests/fast/mutation/mutation-record-nullity.html	2012-12-07 23:43:48 UTC (rev 136996)
@@ -1,7 +1,7 @@
 !DOCTYPE html
 script src=""
 script
-description('Non-relevant properties on mutation records should be null');
+description('Non-relevant properties on mutation records should be null, except for NodeLists, which should be empty');
 var observer = new WebKitMutationObserver(function() {});
 
 var text = document.createTextNode('something');
@@ -12,10 +12,10 @@
 shouldBeNull('record.attributeName');
 shouldBeNull('record.attributeNamespace');
 shouldBeNull('record.oldValue');
-shouldBeNull('record.addedNodes');
-shouldBeNull('record.removedNodes');
 shouldBeNull('record.previousSibling');
 shouldBeNull('record.nextSibling');
+shouldBe('record.addedNodes.length', '0');
+shouldBe('record.removedNodes.length', '0');
 
 var div = document.createElement('div');
 observer.observe(div, {childList: true});
@@ -32,9 +32,9 @@
 debug('\nattributes record:');
 shouldBeNull('record.attributeNamespace');
 shouldBeNull('record.oldValue');
-shouldBeNull('record.addedNodes');
-shouldBeNull('record.removedNodes');
 shouldBeNull('record.previousSibling');
 shouldBeNull('record.nextSibling');
+shouldBe('record.addedNodes.length', '0');
+shouldBe('record.removedNodes.length', '0');
 /script
 script src=""


Modified: 

[webkit-changes] [136862] trunk/Source/WebCore

[adamk]

Title: [136862] trunk/Source/WebCore








Revision 136862
Author ad...@chromium.org
Date 2012-12-06 11:33:33 -0800 (Thu, 06 Dec 2012)


Log Message
Remove gyp config for incomplete and unused Apple Mac gyp build
https://bugs.webkit.org/show_bug.cgi?id=104068

Reviewed by Adam Barth.

As part of the removal, move some files to the proper sections
of the gypi file.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (136861 => 136862)

--- trunk/Source/WebCore/ChangeLog	2012-12-06 19:27:44 UTC (rev 136861)
+++ trunk/Source/WebCore/ChangeLog	2012-12-06 19:33:33 UTC (rev 136862)
@@ -1,3 +1,16 @@
+2012-12-05  Adam Klein  ad...@chromium.org
+
+Remove gyp config for incomplete and unused Apple Mac gyp build
+https://bugs.webkit.org/show_bug.cgi?id=104068
+
+Reviewed by Adam Barth.
+
+As part of the removal, move some files to the proper sections
+of the gypi file.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+
 2012-12-06  Hans Muller  hmul...@adobe.com
 
 [CSS Exclusions] Add support for computing the first included interval position.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (136861 => 136862)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-12-06 19:27:44 UTC (rev 136861)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-12-06 19:33:33 UTC (rev 136862)
@@ -1601,7 +1601,6 @@
 'webcore_prerequisites',
   ],
   'sources': [
-'@(webcore_dom_privateheader_files)',
 '@(webcore_dom_files)',
   ],
   'sources!': [
@@ -1623,7 +1622,6 @@
 'webcore_prerequisites',
   ],
   'sources': [
-'@(webcore_html_privateheader_files)',
 '@(webcore_html_files)',
   ],
   'sources/': [
@@ -1644,7 +1642,6 @@
 'webcore_prerequisites',
   ],
   'sources': [
-'@(webcore_svg_privateheader_files)',
 '@(webcore_svg_files)',
   ],
   'sources/': [
@@ -1661,7 +1658,6 @@
   # if this hard dependency could be split off the rest.
   'hard_dependency': 1,
   'sources': [
-'@(webcore_privateheader_files)',
 '@(webcore_platform_files)',
 
 # For WebCoreSystemInterface, Mac-only.
@@ -1991,7 +1987,6 @@
 'webcore_prerequisites',
   ],
   'sources': [
-'@(webcore_privateheader_files)',
 '@(webcore_files)',
   ],
   'sources/': [
@@ -2080,7 +2075,6 @@
   # if this hard dependency could be split off the rest.
   'hard_dependency': 1,
   'sources': [
-'@(webcore_privateheader_files)',
 '@(webcore_files)',
   ],
   'sources/': [


Modified: trunk/Source/WebCore/WebCore.gypi (136861 => 136862)

--- trunk/Source/WebCore/WebCore.gypi	2012-12-06 19:27:44 UTC (rev 136861)
+++ trunk/Source/WebCore/WebCore.gypi	2012-12-06 19:33:33 UTC (rev 136862)
@@ -1,798 +1,6 @@
 {
 'variables': {
 'project_dir': ['.'],
-# These headers are part of WebCore's private API in the Apple Mac build.
-'webcore_privateheader_files': [
-'Modules/geolocation/Geolocation.h',
-'Modules/geolocation/GeolocationController.h',
-'Modules/geolocation/GeolocationError.h',
-'Modules/geolocation/GeolocationPosition.h',
-'Modules/geolocation/Geoposition.h',
-'Modules/geolocation/PositionCallback.h',
-'Modules/geolocation/PositionError.h',
-'Modules/geolocation/PositionErrorCallback.h',
-'Modules/geolocation/PositionOptions.h',
-'Modules/notifications/NotificationClient.h',
-'Modules/notifications/NotificationController.h',
-'Modules/webdatabase/AbstractDatabase.h',
-'Modules/webdatabase/Database.h',
-'Modules/webdatabase/DatabaseDetails.h',
-'Modules/webdatabase/DatabaseTracker.h',
-'Modules/webdatabase/DatabaseTrackerClient.h',
-'Modules/webdatabase/SQLError.h',
-'Modules/webdatabase/SQLResultSet.h',
-'Modules/webdatabase/SQLResultSetRowList.h',
-'Modules/webdatabase/SQLStatementCallback.h',
-'Modules/webdatabase/SQLStatementErrorCallback.h',
-'Modules/webdatabase/SQLTransaction.h',
-'Modules/webdatabase/SQLTransactionCallback.h',
-'Modules/webdatabase/SQLTransactionErrorCallback.h',
-'accessibility/AXObjectCache.h',
-'accessibility/AccessibilityObject.h',
-'bindings/ScriptControllerBase.h',
-'bindings/js/DOMObjectHashTableMap.h',
-'bindings/js/DOMWrapperWorld.h',
-'bindings/js/GCController.h',
-'bindings/js/JSDOMBinding.h',
-'bindings/js/JSDOMGlobalObject.h',
-'bindings/js/JSDOMWindowBase.h',

[webkit-changes] [136882] trunk/Source/WebCore

[adamk]

Title: [136882] trunk/Source/WebCore








Revision 136882
Author ad...@chromium.org
Date 2012-12-06 13:26:27 -0800 (Thu, 06 Dec 2012)


Log Message
Remove non-v8 binding files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=104288

Reviewed by Adam Barth.

Since the gyp build is only used by the Chromium project,
there's no need for cpp, gobject, objc, or jsc bindings
in these build files.

* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (136881 => 136882)

--- trunk/Source/WebCore/ChangeLog	2012-12-06 21:22:03 UTC (rev 136881)
+++ trunk/Source/WebCore/ChangeLog	2012-12-06 21:26:27 UTC (rev 136882)
@@ -1,3 +1,16 @@
+2012-12-06  Adam Klein  ad...@chromium.org
+
+Remove non-v8 binding files from WebCore.gypi
+https://bugs.webkit.org/show_bug.cgi?id=104288
+
+Reviewed by Adam Barth.
+
+Since the gyp build is only used by the Chromium project,
+there's no need for cpp, gobject, objc, or jsc bindings
+in these build files.
+
+* WebCore.gypi:
+
 2012-12-06  Tony Chang  t...@chromium.org
 
 REGRESSION(r135082): Restore the ability to insert author level style sheets from script


Modified: trunk/Source/WebCore/WebCore.gypi (136881 => 136882)

--- trunk/Source/WebCore/WebCore.gypi	2012-12-06 21:22:03 UTC (rev 136881)
+++ trunk/Source/WebCore/WebCore.gypi	2012-12-06 21:26:27 UTC (rev 136882)
@@ -1147,26 +1147,6 @@
 'accessibility/win/AccessibilityObjectWin.cpp',
 'accessibility/win/AccessibilityObjectWrapperWin.h',
 'bindings/ScriptControllerBase.cpp',
-'bindings/cpp/WebDOMCString.cpp',
-'bindings/cpp/WebDOMCString.h',
-'bindings/cpp/WebDOMDOMWindowCustom.cpp',
-'bindings/cpp/WebDOMEventListenerCustom.cpp',
-'bindings/cpp/WebDOMEventTarget.cpp',
-'bindings/cpp/WebDOMEventTarget.h',
-'bindings/cpp/WebDOMHTMLCollectionCustom.cpp',
-'bindings/cpp/WebDOMHTMLDocumentCustom.cpp',
-'bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp',
-'bindings/cpp/WebDOMNodeCustom.cpp',
-'bindings/cpp/WebDOMNodeFilterCustom.cpp',
-'bindings/cpp/WebDOMObject.h',
-'bindings/cpp/WebDOMString.cpp',
-'bindings/cpp/WebDOMString.h',
-'bindings/cpp/WebExceptionHandler.cpp',
-'bindings/cpp/WebExceptionHandler.h',
-'bindings/cpp/WebNativeEventListener.cpp',
-'bindings/cpp/WebNativeEventListener.h',
-'bindings/cpp/WebNativeNodeFilterCondition.cpp',
-'bindings/cpp/WebNativeNodeFilterCondition.h',
 'bindings/generic/ActiveDOMCallback.cpp',
 'bindings/generic/ActiveDOMCallback.h',
 'bindings/generic/BindingSecurity.cpp',
@@ -1174,250 +1154,6 @@
 'bindings/generic/GenericBinding.h',
 'bindings/generic/RuntimeEnabledFeatures.cpp',
 'bindings/generic/RuntimeEnabledFeatures.h',
-'bindings/gobject/ConvertToUTF8String.cpp',
-'bindings/gobject/ConvertToUTF8String.h',
-'bindings/gobject/DOMObjectCache.cpp',
-'bindings/gobject/DOMObjectCache.h',
-'bindings/gobject/GObjectEventListener.cpp',
-'bindings/gobject/GObjectEventListener.h',
-'bindings/gobject/WebKitDOMBinding.cpp',
-'bindings/gobject/WebKitDOMBinding.h',
-'bindings/gobject/WebKitDOMEventTarget.cpp',
-'bindings/gobject/WebKitDOMEventTarget.h',
-'bindings/gobject/WebKitDOMEventTargetPrivate.h',
-'bindings/gobject/WebKitDOMObject.cpp',
-'bindings/gobject/WebKitDOMObject.h',
-'bindings/gobject/WebKitHTMLElementWrapperFactory.cpp',
-'bindings/gobject/WebKitHTMLElementWrapperFactory.h',
-'bindings/js/ArrayValue.cpp',
-'bindings/js/ArrayValue.h',
-'bindings/js/BindingState.cpp',
-'bindings/js/BindingState.h',
-'bindings/js/CachedScriptSourceProvider.h',
-'bindings/js/CallbackFunction.cpp',
-'bindings/js/CallbackFunction.h',
-'bindings/js/DOMObjectHashTableMap.cpp',
-'bindings/js/DOMWrapperWorld.cpp',
-'bindings/js/GCController.cpp',
-'bindings/js/IDBBindingUtilities.cpp',
-'bindings/js/IDBBindingUtilities.h',
-'bindings/js/JSArrayBufferCustom.cpp',
-'bindings/js/JSArrayBufferViewHelper.h',
-'bindings/js/JSAttrCustom.cpp',
-'bindings/js/JSAudioBufferSourceNodeCustom.cpp',
-'bindings/js/JSAudioContextCustom.cpp',
-'bindings/js/JSBindingsAllInOne.cpp',
-'bindings/js/JSBlobCustom.cpp',
-'bindings/js/JSCDATASectionCustom.cpp',
-'bindings/js/JSCSSFontFaceRuleCustom.cpp',

[webkit-changes] [136903] trunk

[adamk]

Title: [136903] trunk








Revision 136903
Author ad...@chromium.org
Date 2012-12-06 15:47:58 -0800 (Thu, 06 Dec 2012)


Log Message
[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
https://bugs.webkit.org/show_bug.cgi?id=104181

Reviewed by Adam Barth.

Source/WebCore:

Note that this patch also adds IDL attributes/custom code to tie the lifetime
of the content DocumentFragment wrapper to the lifetime of the template element wrapper
via a hidden JS property.

Based on a patch by Rafael Weinstein.

Test: fast/dom/HTMLTemplateElement/contentWrappers.html

* DerivedSources.cpp:
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSHTMLTemplateElementCustom.cpp: Copied from Source/WebCore/html/HTMLTemplateElement.idl.
(WebCore):
(WebCore::JSHTMLTemplateElement::content):
* bindings/scripts/CodeGeneratorV8.pm: Add support for new V8CacheAttributeForGC attribute.
* dom/Element.h:
(Element): Annotate cloneNode() with OVERRIDE
* html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::cloneNode):
* html/HTMLTemplateElement.h:
(HTMLTemplateElement): override cloneNode
* html/HTMLTemplateElement.idl: Make content readonly and add custom attributes.

LayoutTests:

* fast/dom/HTMLTemplateElement/cloneNode-expected.txt:
* fast/dom/HTMLTemplateElement/cloneNode.html:
* fast/dom/HTMLTemplateElement/contentWrappers-expected.txt: Added.
* fast/dom/HTMLTemplateElement/contentWrappers.html: Added.
* fast/dom/HTMLTemplateElement/ownerDocument-expected.txt:
* fast/dom/HTMLTemplateElement/ownerDocument.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode.html
trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/ownerDocument.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/HTMLTemplateElement.cpp
trunk/Source/WebCore/html/HTMLTemplateElement.h
trunk/Source/WebCore/html/HTMLTemplateElement.idl


Added Paths

trunk/LayoutTests/fast/dom/HTMLTemplateElement/contentWrappers-expected.txt
trunk/LayoutTests/fast/dom/HTMLTemplateElement/contentWrappers.html
trunk/Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (136902 => 136903)

--- trunk/LayoutTests/ChangeLog	2012-12-06 23:31:39 UTC (rev 136902)
+++ trunk/LayoutTests/ChangeLog	2012-12-06 23:47:58 UTC (rev 136903)
@@ -1,3 +1,17 @@
+2012-12-06  Adam Klein  ad...@chromium.org
+
+[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
+https://bugs.webkit.org/show_bug.cgi?id=104181
+
+Reviewed by Adam Barth.
+
+* fast/dom/HTMLTemplateElement/cloneNode-expected.txt:
+* fast/dom/HTMLTemplateElement/cloneNode.html:
+* fast/dom/HTMLTemplateElement/contentWrappers-expected.txt: Added.
+* fast/dom/HTMLTemplateElement/contentWrappers.html: Added.
+* fast/dom/HTMLTemplateElement/ownerDocument-expected.txt:
+* fast/dom/HTMLTemplateElement/ownerDocument.html:
+
 2012-12-06  Emil A Eklund  e...@chromium.org
 
 Unreviewed chromium rebaseline for r136885.


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode-expected.txt (136902 => 136903)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode-expected.txt	2012-12-06 23:31:39 UTC (rev 136902)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode-expected.txt	2012-12-06 23:47:58 UTC (rev 136903)
@@ -4,5 +4,10 @@
 
 
 PASS template.content.childNodes.length is 1
-PASS clone.content.childNodes.length is 0
+PASS clone.content.childNodes.length is 1
+PASS clone.outerHTML is template.outerHTML
+PASS clone.content.firstChild is not template.content.firstChild
+PASS clone.content is not template.content
+PASS clone.firstChild.tagName is DIV
+PASS clone.firstChild is not div
 


Modified: trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode.html (136902 => 136903)

--- trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode.html	2012-12-06 23:31:39 UTC (rev 136902)
+++ trunk/LayoutTests/fast/dom/HTMLTemplateElement/cloneNode.html	2012-12-06 23:47:58 UTC (rev 136903)
@@ -1,5 +1,5 @@
 !DOCTYPE html
-template id=templateContents/template
+template id=templatespanContents/span/template
 script src=""
 script
 
@@ -9,8 +9,15 @@
 testFailed('This test requires ENABLE(TEMPLATE_ELEMENT)');
 
 var template = document.getElementById('template');
+var div = 

[webkit-changes] [135320] trunk/Source/WebCore

[adamk]

Title: [135320] trunk/Source/WebCore








Revision 135320
Author ad...@chromium.org
Date 2012-11-20 15:38:44 -0800 (Tue, 20 Nov 2012)


Log Message
[v8] Avoid unnecessary call to ToObject() in Callback constructors
https://bugs.webkit.org/show_bug.cgi?id=102831

Reviewed by Adam Barth.

The code already asserted that the argument was an object, so calling
ToObject() is unnecessary: a simple Cast() suffices.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
* bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (135319 => 135320)

--- trunk/Source/WebCore/ChangeLog	2012-11-20 23:34:14 UTC (rev 135319)
+++ trunk/Source/WebCore/ChangeLog	2012-11-20 23:38:44 UTC (rev 135320)
@@ -1,3 +1,18 @@
+2012-11-20  Adam Klein  ad...@chromium.org
+
+[v8] Avoid unnecessary call to ToObject() in Callback constructors
+https://bugs.webkit.org/show_bug.cgi?id=102831
+
+Reviewed by Adam Barth.
+
+The code already asserted that the argument was an object, so calling
+ToObject() is unnecessary: a simple Cast() suffices.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateCallbackHeader):
+* bindings/scripts/test/V8/V8TestCallback.h:
+(WebCore::V8TestCallback::create):
+
 2012-11-20  Brent Fulgham  bfulg...@webkit.org
 
 [WinCairo] Build fix after r135316


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (135319 => 135320)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-11-20 23:34:14 UTC (rev 135319)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-11-20 23:38:44 UTC (rev 135320)
@@ -3250,7 +3250,7 @@
 {
 ASSERT(value-IsObject());
 ASSERT(context);
-return adoptRef(new ${v8InterfaceName}(value-ToObject(), context, owner));
+return adoptRef(new ${v8InterfaceName}(v8::Handlev8::Object::Cast(value), context, owner));
 }
 
 virtual ~${v8InterfaceName}();


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h (135319 => 135320)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h	2012-11-20 23:34:14 UTC (rev 135319)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.h	2012-11-20 23:38:44 UTC (rev 135320)
@@ -39,7 +39,7 @@
 {
 ASSERT(value-IsObject());
 ASSERT(context);
-return adoptRef(new V8TestCallback(value-ToObject(), context, owner));
+return adoptRef(new V8TestCallback(v8::Handlev8::Object::Cast(value), context, owner));
 }
 
 virtual ~V8TestCallback();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [135337] trunk

[adamk]

Title: [135337] trunk








Revision 135337
Author ad...@chromium.org
Date 2012-11-20 17:35:49 -0800 (Tue, 20 Nov 2012)


Log Message
[JSC] MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102744

Reviewed by Adam Barth.

Source/WebCore:

This is the JSC side of the change landed for V8 in r135228.
It ensures MutationObserver wrapper objects are kept alive as long as
any observed nodes.

* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Keep MutationObserver wrappers alive
if any of their observed nodes' roots is an opaque root.
* dom/MutationObserver.idl: Add JSCustomIsReachable

LayoutTests:

Remove suppressions for wrapper dropoff tests.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMutationObserverCustom.cpp
trunk/Source/WebCore/dom/MutationObserver.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (135336 => 135337)

--- trunk/LayoutTests/ChangeLog	2012-11-21 01:29:52 UTC (rev 135336)
+++ trunk/LayoutTests/ChangeLog	2012-11-21 01:35:49 UTC (rev 135337)
@@ -1,3 +1,19 @@
+2012-11-20  Adam Klein  ad...@chromium.org
+
+[JSC] MutationObserver wrapper should not be collected while still observing
+https://bugs.webkit.org/show_bug.cgi?id=102744
+
+Reviewed by Adam Barth.
+
+Remove suppressions for wrapper dropoff tests.
+
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wincairo/TestExpectations:
+
 2012-11-20  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r131106): magnitude-perf.js calls bind on undefined


Modified: trunk/LayoutTests/platform/efl/TestExpectations (135336 => 135337)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-21 01:29:52 UTC (rev 135336)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-21 01:35:49 UTC (rev 135337)
@@ -1706,6 +1706,3 @@
 webkit.org/b/102367 fast/forms/zoomed-controls.html [ ImageOnlyFailure Missing ]
 
 webkit.org/b/102493 fast/events/mouse-cursor.html [ Failure ]
-
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff.html [ Skip ]
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff-transient.html [ Skip ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (135336 => 135337)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-11-21 01:29:52 UTC (rev 135336)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-11-21 01:35:49 UTC (rev 135337)
@@ -1385,9 +1385,6 @@
 
 webkit.org/b/102586 media/video-src-blob.html [ Failure ]
 
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff.html [ Skip ]
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff-transient.html [ Skip ]
-
 # Fix for https://bugs.webkit.org/show_bug.cgi?id=97192 introduces these regressions
 webkit.org/b/102776 media/media-document-audio-repaint.html [ Failure ]
 webkit.org/b/102776 media/track/track-cue-container-rendering-position.html [ Failure ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (135336 => 135337)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-11-21 01:29:52 UTC (rev 135336)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-11-21 01:35:49 UTC (rev 135337)
@@ -1190,6 +1190,3 @@
 
 # Hangs safari apparently due to an issue with weird multi-frame CUR image files
 webkit.org/b/101811 fast/events/mouse-cursor-multiframecur.html [ Skip ]
-
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff.html [ Skip ]
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff-transient.html [ Skip ]


Modified: trunk/LayoutTests/platform/qt/TestExpectations (135336 => 135337)

--- trunk/LayoutTests/platform/qt/TestExpectations	2012-11-21 01:29:52 UTC (rev 135336)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2012-11-21 01:35:49 UTC (rev 135337)
@@ -2386,6 +2386,3 @@
 
 # [Qt] fast/block/float/overhanging-tall-block.html asserts after r135025
 webkit.org/b/102675 [ Debug ] fast/block/float/overhanging-tall-block.html
-
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff.html [ Skip ]
-webkit.org/b/102744 fast/mutation/observer-wrapper-dropoff-transient.html [ Skip ]


Modified: trunk/LayoutTests/platform/win/TestExpectations (135336 => 135337)

--- trunk/LayoutTests/platform/win/TestExpectations	

[webkit-changes] [135228] trunk

[adamk]

Title: [135228] trunk








Revision 135228
Author ad...@chromium.org
Date 2012-11-19 18:16:33 -0800 (Mon, 19 Nov 2012)


Log Message
MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102328

Reviewed by Adam Barth.

Source/WebCore:

Use the new opaqueRootForGC helper in V8GCController to put each
MutationObserver wrapper in the same object group as the nodes it's
observing.

Only includes V8 impl for now, JSC impl coming soon.

Tests: fast/mutation/observer-wrapper-dropoff-transient.html
   fast/mutation/observer-wrapper-dropoff.html

* bindings/v8/V8GCController.cpp: Add custom code for MutationObserver
with a FIXME to move this out once we update the opaque roots API.
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::getObservedNodes): Plumbing to expose the observed nodes
to the GC controller.
(WebCore):
* dom/MutationObserver.h:
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet): More plumbing.
(WebCore):
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration):

LayoutTests:

Tests showing that observers are kept alive, both in the simple case
and in the transient registered observer case (where the original
registration node is GCed but the transient observation node is still
alive).

* fast/mutation/observer-wrapper-dropoff-expected.txt: Added.
* fast/mutation/observer-wrapper-dropoff-transient-expected.txt: Added.
* fast/mutation/observer-wrapper-dropoff-transient.html: Added.
* fast/mutation/observer-wrapper-dropoff.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8GCController.cpp
trunk/Source/WebCore/dom/MutationObserver.cpp
trunk/Source/WebCore/dom/MutationObserver.h
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h


Added Paths

trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-expected.txt
trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient-expected.txt
trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient.html
trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff.html




Diff

Modified: trunk/LayoutTests/ChangeLog (135227 => 135228)

--- trunk/LayoutTests/ChangeLog	2012-11-20 02:11:53 UTC (rev 135227)
+++ trunk/LayoutTests/ChangeLog	2012-11-20 02:16:33 UTC (rev 135228)
@@ -1,3 +1,20 @@
+2012-11-19  Adam Klein  ad...@chromium.org
+
+MutationObserver wrapper should not be collected while still observing
+https://bugs.webkit.org/show_bug.cgi?id=102328
+
+Reviewed by Adam Barth.
+
+Tests showing that observers are kept alive, both in the simple case
+and in the transient registered observer case (where the original
+registration node is GCed but the transient observation node is still
+alive).
+
+* fast/mutation/observer-wrapper-dropoff-expected.txt: Added.
+* fast/mutation/observer-wrapper-dropoff-transient-expected.txt: Added.
+* fast/mutation/observer-wrapper-dropoff-transient.html: Added.
+* fast/mutation/observer-wrapper-dropoff.html: Added.
+
 2012-11-19  Tony Chang  t...@chromium.org
 
 Move more non-settings out of InternalSettings


Added: trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-expected.txt (0 => 135228)

--- trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-expected.txt	2012-11-20 02:16:33 UTC (rev 135228)
@@ -0,0 +1,10 @@
+MutationObserver wrappers should survive GC for passing into the callback even if JS has lost references.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS observer.testProperty is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient-expected.txt (0 => 135228)

--- trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient-expected.txt	2012-11-20 02:16:33 UTC (rev 135228)
@@ -0,0 +1,10 @@
+MutationObserver wrappers should survive GC for passing into the callback even if JS has lost references and the only remaining observations are transient.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS observer.testProperty is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/observer-wrapper-dropoff-transient.html (0 => 

[webkit-changes] [132211] trunk

[adamk]

Title: [132211] trunk








Revision 132211
Author ad...@chromium.org
Date 2012-10-23 06:06:32 -0700 (Tue, 23 Oct 2012)


Log Message
Always parse pasted fragments as HTML even on XHTML pages
https://bugs.webkit.org/show_bug.cgi?id=99880

Reviewed by Ojan Vafai.

Source/WebCore:

When pasting HTML into a page, using the XML parser is unlikely
to work correctly, as the contents of the clipboard are unlikely
to be properly-formed XHTML. Thus, for the pasting case, it's always
better to use HTML parsing, which will properly parse either HTML
(which is what's usually in the clipboard) or XHTML (which is
sometimes there as well).

The Mac port previously worked around this problem by falling back to plain text
when parsing failed, but switching to HTML seems like a clear improvement.

This also fixes a crash in Chromium (see http://webkit.org/b/99607
and http://crbug.com/136218); it erroneously assumed that createFragmentFromMarkup()
would never return null. This patch makes that true.

* editing/markup.cpp:
(WebCore::createFragmentFromMarkup): Don't delegate to createContextualFragment:
we already know our context element is safe (i.e., it's body),
and we want to force HTML (not XML) parsing.

LayoutTests:

Updated existing tests to match new expected behavior.

* editing/pasteboard/paste-noscript-xhtml-expected.txt: The HTML
parser leaves script tags in the DOM when pasting, but removes their
attributes and children, so this is just as safe as the previous
behavior.
* platform/mac/editing/pasteboard/paste-xml-expected.txt: Now that we
use the HTML parser, parsing the paste succeeds and so we insert DOM
instead of plain text. Similar rebaselines may be needed on other
platforms.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/paste-noscript-xhtml-expected.txt
trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/markup.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (132210 => 132211)

--- trunk/LayoutTests/ChangeLog	2012-10-23 12:34:51 UTC (rev 132210)
+++ trunk/LayoutTests/ChangeLog	2012-10-23 13:06:32 UTC (rev 132211)
@@ -1,3 +1,21 @@
+2012-10-23  Adam Klein  ad...@chromium.org
+
+Always parse pasted fragments as HTML even on XHTML pages
+https://bugs.webkit.org/show_bug.cgi?id=99880
+
+Reviewed by Ojan Vafai.
+
+Updated existing tests to match new expected behavior.
+
+* editing/pasteboard/paste-noscript-xhtml-expected.txt: The HTML
+parser leaves script tags in the DOM when pasting, but removes their
+attributes and children, so this is just as safe as the previous
+behavior.
+* platform/mac/editing/pasteboard/paste-xml-expected.txt: Now that we
+use the HTML parser, parsing the paste succeeds and so we insert DOM
+instead of plain text. Similar rebaselines may be needed on other
+platforms.
+
 2012-10-23  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/editing/pasteboard/paste-noscript-xhtml-expected.txt (132210 => 132211)

--- trunk/LayoutTests/editing/pasteboard/paste-noscript-xhtml-expected.txt	2012-10-23 12:34:51 UTC (rev 132210)
+++ trunk/LayoutTests/editing/pasteboard/paste-noscript-xhtml-expected.txt	2012-10-23 13:06:32 UTC (rev 132211)
@@ -67,6 +67,8 @@
 |   href=""
 |   id=anchor2
 |   Hello
+| script
+| script
 | iframe
 |   id=iframe1
 |   src=""


Modified: trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt (132210 => 132211)

--- trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt	2012-10-23 12:34:51 UTC (rev 132210)
+++ trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt	2012-10-23 13:06:32 UTC (rev 132211)
@@ -9,10 +9,11 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldInsertText:bar replacingDOMRange:range from 7 of #text  span  div  body  html  #document to 7 of #text  span  div  body  html  #document givenAction:WebViewInsertActionPasted
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text  span  div  body  html  #document to 7 of #text  span  div  body  html  #document toDOMRange:range from 10 of #text  span  div  body  html  #document to 10 of #text  span  div  body  html  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 7 of #text  span  div  body  html  #document to 7 of #text  span  div  body  html  #document givenAction:WebViewInsertActionPasted
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 10 of #text  span  div  

[webkit-changes] [130442] trunk

[adamk]

Title: [130442] trunk








Revision 130442
Author ad...@chromium.org
Date 2012-10-04 18:02:29 -0700 (Thu, 04 Oct 2012)


Log Message
MutationRecord attributeName should be null for non attribute changes
https://bugs.webkit.org/show_bug.cgi?id=98438

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/mutation-record-nullity.html

* dom/MutationRecord.idl:

LayoutTests:

* fast/mutation/mutation-record-nullity-expected.txt: Added.
* fast/mutation/mutation-record-nullity.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationRecord.idl


Added Paths

trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt
trunk/LayoutTests/fast/mutation/mutation-record-nullity.html




Diff

Modified: trunk/LayoutTests/ChangeLog (130441 => 130442)

--- trunk/LayoutTests/ChangeLog	2012-10-05 00:54:12 UTC (rev 130441)
+++ trunk/LayoutTests/ChangeLog	2012-10-05 01:02:29 UTC (rev 130442)
@@ -1,3 +1,13 @@
+2012-10-04  Adam Klein  ad...@chromium.org
+
+MutationRecord attributeName should be null for non attribute changes
+https://bugs.webkit.org/show_bug.cgi?id=98438
+
+Reviewed by Ojan Vafai.
+
+* fast/mutation/mutation-record-nullity-expected.txt: Added.
+* fast/mutation/mutation-record-nullity.html: Added.
+
 2012-10-04  Ryosuke Niwa  rn...@webkit.org
 
 More Qt rebaselines after r130411.


Added: trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt (0 => 130442)

--- trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/mutation-record-nullity-expected.txt	2012-10-05 01:02:29 UTC (rev 130442)
@@ -0,0 +1,30 @@
+Non-relevant properties on mutation records should be null
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+characterData record:
+PASS record.attributeName is null
+PASS record.attributeNamespace is null
+PASS record.oldValue is null
+PASS record.addedNodes is null
+PASS record.removedNodes is null
+PASS record.previousSibling is null
+PASS record.nextSibling is null
+
+childList record:
+PASS record.attributeName is null
+PASS record.attributeNamespace is null
+PASS record.oldValue is null
+
+attributes record:
+PASS record.attributeNamespace is null
+PASS record.oldValue is null
+PASS record.addedNodes is null
+PASS record.removedNodes is null
+PASS record.previousSibling is null
+PASS record.nextSibling is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/mutation-record-nullity.html (0 => 130442)

--- trunk/LayoutTests/fast/mutation/mutation-record-nullity.html	(rev 0)
+++ trunk/LayoutTests/fast/mutation/mutation-record-nullity.html	2012-10-05 01:02:29 UTC (rev 130442)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+script src=""
+script
+description('Non-relevant properties on mutation records should be null');
+var observer = new WebKitMutationObserver(function() {});
+
+var text = document.createTextNode('something');
+observer.observe(text, {characterData: true});
+text.data = '';
+var record = observer.takeRecords()[0];
+debug('characterData record:');
+shouldBeNull('record.attributeName');
+shouldBeNull('record.attributeNamespace');
+shouldBeNull('record.oldValue');
+shouldBeNull('record.addedNodes');
+shouldBeNull('record.removedNodes');
+shouldBeNull('record.previousSibling');
+shouldBeNull('record.nextSibling');
+
+var div = document.createElement('div');
+observer.observe(div, {childList: true});
+div.appendChild(document.createElement('span'));
+record = observer.takeRecords()[0];
+debug('\nchildList record:');
+shouldBeNull('record.attributeName');
+shouldBeNull('record.attributeNamespace');
+shouldBeNull('record.oldValue');
+
+observer.observe(div, {attributes: true});
+div.setAttribute('data-foo', 'bar');
+record = observer.takeRecords()[0];
+debug('\nattributes record:');
+shouldBeNull('record.attributeNamespace');
+shouldBeNull('record.oldValue');
+shouldBeNull('record.addedNodes');
+shouldBeNull('record.removedNodes');
+shouldBeNull('record.previousSibling');
+shouldBeNull('record.nextSibling');
+/script
+script src=""


Modified: trunk/Source/WebCore/ChangeLog (130441 => 130442)

--- trunk/Source/WebCore/ChangeLog	2012-10-05 00:54:12 UTC (rev 130441)
+++ trunk/Source/WebCore/ChangeLog	2012-10-05 01:02:29 UTC (rev 130442)
@@ -1,3 +1,14 @@
+2012-10-04  Adam Klein  ad...@chromium.org
+
+MutationRecord attributeName should be null for non attribute changes
+https://bugs.webkit.org/show_bug.cgi?id=98438
+
+Reviewed by Ojan Vafai.
+
+Test: fast/mutation/mutation-record-nullity.html
+
+* dom/MutationRecord.idl:
+
 2012-10-04  Simon Fraser  simon.fra...@apple.com
 
 Final part of sync to flush renaming


Modified: trunk/Source/WebCore/dom/MutationRecord.idl (130441 => 130442)

--- trunk/Source/WebCore/dom/MutationRecord.idl	

[webkit-changes] [130336] trunk/Source/WebCore

[adamk]

Title: [130336] trunk/Source/WebCore








Revision 130336
Author ad...@chromium.org
Date 2012-10-03 15:44:25 -0700 (Wed, 03 Oct 2012)


Log Message
Remove bogus FIXME from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=98302

Reviewed by Adam Barth.

The FIXME claimed that document.body throwing an exception was not
specced, but in fact it is:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#dom-document-body

* dom/Document.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (130335 => 130336)

--- trunk/Source/WebCore/ChangeLog	2012-10-03 22:41:57 UTC (rev 130335)
+++ trunk/Source/WebCore/ChangeLog	2012-10-03 22:44:25 UTC (rev 130336)
@@ -1,3 +1,16 @@
+2012-10-03  Adam Klein  ad...@chromium.org
+
+Remove bogus FIXME from Document.idl
+https://bugs.webkit.org/show_bug.cgi?id=98302
+
+Reviewed by Adam Barth.
+
+The FIXME claimed that document.body throwing an exception was not
+specced, but in fact it is:
+http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#dom-document-body
+
+* dom/Document.idl:
+
 2012-10-03  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Memory leak when deleting object stores with indexes


Modified: trunk/Source/WebCore/dom/Document.idl (130335 => 130336)

--- trunk/Source/WebCore/dom/Document.idl	2012-10-03 22:41:57 UTC (rev 130335)
+++ trunk/Source/WebCore/dom/Document.idl	2012-10-03 22:44:25 UTC (rev 130336)
@@ -167,8 +167,6 @@
  setter raises (DOMException),
  getter raises (DOMException);
 
-// FIXME: the DOM spec does NOT have this attribute
-// raising an exception.
  attribute HTMLElement body
  setter raises (DOMException);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [130069] trunk/Source/WebCore

[adamk]

Title: [130069] trunk/Source/WebCore








Revision 130069
Author ad...@chromium.org
Date 2012-10-01 13:12:05 -0700 (Mon, 01 Oct 2012)


Log Message
Consolidate more MutationObserverRegistration logic in Node
https://bugs.webkit.org/show_bug.cgi?id=98058

Reviewed by Ryosuke Niwa.

One remaining oddity of Node's MutationObserver-related interface was
that registerMutationObserver returned the resulting MutationObserverRegistration
object.

Instead, Node now internally handles resetting the observation
if the registration already exists, and updating the Document's list of
mutation observer types.

No change in behavior, refactoring only.

* dom/MutationObserver.cpp:
(WebCore::MutationObserver::observe): Simplified to just call
Node::registerMutationObserver; nothing else is needed.
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::create): Take options and attributeFilter,
avoiding an unnecessary call to resetObservation().
(WebCore::MutationObserverRegistration::MutationObserverRegistration): ditto
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration):
* dom/Node.cpp:
(WebCore::Node::registerMutationObserver): Handle observation
resetting if that observer's already registered, and update the list
of active MutationObserver types in the Document.
* dom/Node.h:
(Node):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationObserver.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (130068 => 130069)

--- trunk/Source/WebCore/ChangeLog	2012-10-01 19:53:53 UTC (rev 130068)
+++ trunk/Source/WebCore/ChangeLog	2012-10-01 20:12:05 UTC (rev 130069)
@@ -1,3 +1,36 @@
+2012-10-01  Adam Klein  ad...@chromium.org
+
+Consolidate more MutationObserverRegistration logic in Node
+https://bugs.webkit.org/show_bug.cgi?id=98058
+
+Reviewed by Ryosuke Niwa.
+
+One remaining oddity of Node's MutationObserver-related interface was
+that registerMutationObserver returned the resulting MutationObserverRegistration
+object.
+
+Instead, Node now internally handles resetting the observation
+if the registration already exists, and updating the Document's list of
+mutation observer types.
+
+No change in behavior, refactoring only.
+
+* dom/MutationObserver.cpp:
+(WebCore::MutationObserver::observe): Simplified to just call
+Node::registerMutationObserver; nothing else is needed.
+* dom/MutationObserverRegistration.cpp:
+(WebCore::MutationObserverRegistration::create): Take options and attributeFilter,
+avoiding an unnecessary call to resetObservation().
+(WebCore::MutationObserverRegistration::MutationObserverRegistration): ditto
+* dom/MutationObserverRegistration.h:
+(MutationObserverRegistration):
+* dom/Node.cpp:
+(WebCore::Node::registerMutationObserver): Handle observation
+resetting if that observer's already registered, and update the list
+of active MutationObserver types in the Document.
+* dom/Node.h:
+(Node):
+
 2012-10-01  Glenn Adams  gl...@skynav.com
 
 YYDEBUG doesn't print token values


Modified: trunk/Source/WebCore/dom/MutationObserver.cpp (130068 => 130069)

--- trunk/Source/WebCore/dom/MutationObserver.cpp	2012-10-01 19:53:53 UTC (rev 130068)
+++ trunk/Source/WebCore/dom/MutationObserver.cpp	2012-10-01 20:12:05 UTC (rev 130069)
@@ -116,10 +116,7 @@
 return;
 }
 
-MutationObserverRegistration* registration = node-registerMutationObserver(this);
-registration-resetObservation(options, attributeFilter);
-
-node-document()-addMutationObserverTypes(registration-mutationTypes());
+node-registerMutationObserver(this, options, attributeFilter);
 }
 
 VectorRefPtrMutationRecord  MutationObserver::takeRecords()


Modified: trunk/Source/WebCore/dom/MutationObserverRegistration.cpp (130068 => 130069)

--- trunk/Source/WebCore/dom/MutationObserverRegistration.cpp	2012-10-01 19:53:53 UTC (rev 130068)
+++ trunk/Source/WebCore/dom/MutationObserverRegistration.cpp	2012-10-01 20:12:05 UTC (rev 130069)
@@ -40,15 +40,16 @@
 
 namespace WebCore {
 
-PassOwnPtrMutationObserverRegistration MutationObserverRegistration::create(PassRefPtrMutationObserver observer, Node* registrationNode)
+PassOwnPtrMutationObserverRegistration MutationObserverRegistration::create(PassRefPtrMutationObserver observer, Node* registrationNode, MutationObserverOptions options, const HashSetAtomicString attributeFilter)
 {
-return adoptPtr(new MutationObserverRegistration(observer, registrationNode));
+return adoptPtr(new MutationObserverRegistration(observer, registrationNode, options, attributeFilter));
 }
 

[webkit-changes] [129781] trunk/Source/WebCore

[adamk]

Title: [129781] trunk/Source/WebCore








Revision 129781
Author ad...@chromium.org
Date 2012-09-27 11:35:13 -0700 (Thu, 27 Sep 2012)


Log Message
Simplify and clarify MutationObserverRegistration interface and usage
https://bugs.webkit.org/show_bug.cgi?id=97742

Reviewed by Ojan Vafai.

Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.

No change in behavior.

* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous inline keyword.
(WebCore::MutationObserverRegistration::observer): const method.
* dom/Node.cpp:
(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
* dom/Node.h:
(Node): Remove old method, replaced by templatized static function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129780 => 129781)

--- trunk/Source/WebCore/ChangeLog	2012-09-27 18:30:40 UTC (rev 129780)
+++ trunk/Source/WebCore/ChangeLog	2012-09-27 18:35:13 UTC (rev 129781)
@@ -1,3 +1,32 @@
+2012-09-27  Adam Klein  ad...@chromium.org
+
+Simplify and clarify MutationObserverRegistration interface and usage
+https://bugs.webkit.org/show_bug.cgi?id=97742
+
+Reviewed by Ojan Vafai.
+
+Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
+use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
+remove the declaration of a no-longer-existing method.
+
+No change in behavior.
+
+* dom/MutationObserverRegistration.cpp:
+(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
+(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
+* dom/MutationObserverRegistration.h:
+(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
+(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
+(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous inline keyword.
+(WebCore::MutationObserverRegistration::observer): const method.
+* dom/Node.cpp:
+(WebCore):
+(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
+(WebCore::Node::getRegisteredMutationObserversOfType):
+(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
+* dom/Node.h:
+(Node): Remove old method, replaced by templatized static function.
+
 2012-09-27  Erik Arvidsson  a...@chromium.org
 
 DOM4: Add support for rest parameters to DOMTokenList


Modified: trunk/Source/WebCore/dom/MutationObserverRegistration.cpp (129780 => 129781)

--- trunk/Source/WebCore/dom/MutationObserverRegistration.cpp	2012-09-27 18:30:40 UTC (rev 129780)
+++ trunk/Source/WebCore/dom/MutationObserverRegistration.cpp	2012-09-27 18:35:13 UTC (rev 129781)
@@ -66,7 +66,7 @@
 m_attributeFilter = attributeFilter;
 }
 
-void MutationObserverRegistration::observedSubtreeNodeWillDetach(PassRefPtrNode node)
+void MutationObserverRegistration::observedSubtreeNodeWillDetach(Node* node)
 {
 if (!isSubtree())
 return;
@@ -105,7 +105,7 @@
 // The above line will cause this object to be deleted, so don't do any more in this function.
 }
 
-bool MutationObserverRegistration::shouldReceiveMutationFrom(Node* node, MutationObserver::MutationType type, const QualifiedName* attributeName)
+bool MutationObserverRegistration::shouldReceiveMutationFrom(Node* node, MutationObserver::MutationType type, const QualifiedName* attributeName) const
 {
 ASSERT((type == MutationObserver::Attributes  attributeName) || !attributeName);
 if (!(m_options  type))


Modified: trunk/Source/WebCore/dom/MutationObserverRegistration.h (129780 => 129781)

--- 

[webkit-changes] [129551] trunk/Source/WebCore

[adamk]

Title: [129551] trunk/Source/WebCore








Revision 129551
Author ad...@chromium.org
Date 2012-09-25 13:47:23 -0700 (Tue, 25 Sep 2012)


Log Message
Remove unused DOMAttrModified from EventsNames and Document::ListenerType
https://bugs.webkit.org/show_bug.cgi?id=97591

Reviewed by Ojan Vafai.

WebKit does not, and will never, fire DOMAttrModified events, so
there's no need to create the DOMAttrModified event name.

The only use of the name was to set the DOMATTRMODIFIED_LISTENER bit
on Document; with the name gone, the enum value can be removed as well.

* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded):
* dom/Document.h: Remove DOMATTRMODIFIED_LISTENER, and switch this
enum to use shift-left instead of hex values, so as to be easier to
update in future.
* dom/EventNames.h:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/EventNames.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (129550 => 129551)

--- trunk/Source/WebCore/ChangeLog	2012-09-25 20:44:19 UTC (rev 129550)
+++ trunk/Source/WebCore/ChangeLog	2012-09-25 20:47:23 UTC (rev 129551)
@@ -1,3 +1,24 @@
+2012-09-25  Adam Klein  ad...@chromium.org
+
+Remove unused DOMAttrModified from EventsNames and Document::ListenerType
+https://bugs.webkit.org/show_bug.cgi?id=97591
+
+Reviewed by Ojan Vafai.
+
+WebKit does not, and will never, fire DOMAttrModified events, so
+there's no need to create the DOMAttrModified event name.
+
+The only use of the name was to set the DOMATTRMODIFIED_LISTENER bit
+on Document; with the name gone, the enum value can be removed as well.
+
+* dom/Document.cpp:
+(WebCore::Document::addListenerTypeIfNeeded):
+* dom/Document.h: Remove DOMATTRMODIFIED_LISTENER, and switch this
+enum to use shift-left instead of hex values, so as to be easier to
+update in future.
+* dom/EventNames.h:
+(WebCore):
+
 2012-09-25  Leo Yang  leoy...@rim.com
 
 GraphicsContext3D::compileShader is using incorrect string length in GraphicsContext3DOpenGLCommon.cpp


Modified: trunk/Source/WebCore/dom/Document.cpp (129550 => 129551)

--- trunk/Source/WebCore/dom/Document.cpp	2012-09-25 20:44:19 UTC (rev 129550)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-09-25 20:47:23 UTC (rev 129551)
@@ -3767,8 +3767,6 @@
 addMutationEventListenerTypeIfEnabled(DOMNODEREMOVEDFROMDOCUMENT_LISTENER);
 else if (eventType == eventNames().DOMNodeInsertedIntoDocumentEvent)
 addMutationEventListenerTypeIfEnabled(DOMNODEINSERTEDINTODOCUMENT_LISTENER);
-else if (eventType == eventNames().DOMAttrModifiedEvent)
-addMutationEventListenerTypeIfEnabled(DOMATTRMODIFIED_LISTENER);
 else if (eventType == eventNames().DOMCharacterDataModifiedEvent)
 addMutationEventListenerTypeIfEnabled(DOMCHARACTERDATAMODIFIED_LISTENER);
 else if (eventType == eventNames().overflowchangedEvent)


Modified: trunk/Source/WebCore/dom/Document.h (129550 => 129551)

--- trunk/Source/WebCore/dom/Document.h	2012-09-25 20:44:19 UTC (rev 129550)
+++ trunk/Source/WebCore/dom/Document.h	2012-09-25 20:47:23 UTC (rev 129551)
@@ -757,20 +757,20 @@
 // keep track of what types of event listeners are registered, so we don't
 // dispatch events unnecessarily
 enum ListenerType {
-DOMSUBTREEMODIFIED_LISTENER  = 0x01,
-DOMNODEINSERTED_LISTENER = 0x02,
-DOMNODEREMOVED_LISTENER  = 0x04,
-DOMNODEREMOVEDFROMDOCUMENT_LISTENER  = 0x08,
-DOMNODEINSERTEDINTODOCUMENT_LISTENER = 0x10,
-DOMATTRMODIFIED_LISTENER = 0x20,
-DOMCHARACTERDATAMODIFIED_LISTENER= 0x40,
-OVERFLOWCHANGED_LISTENER = 0x80,
-ANIMATIONEND_LISTENER= 0x100,
-ANIMATIONSTART_LISTENER  = 0x200,
-ANIMATIONITERATION_LISTENER  = 0x400,
-TRANSITIONEND_LISTENER   = 0x800,
-BEFORELOAD_LISTENER  = 0x1000,
-SCROLL_LISTENER  = 0x2000
+DOMSUBTREEMODIFIED_LISTENER  = 1,
+DOMNODEINSERTED_LISTENER = 1  1,
+DOMNODEREMOVED_LISTENER  = 1  2,
+DOMNODEREMOVEDFROMDOCUMENT_LISTENER  = 1  3,
+DOMNODEINSERTEDINTODOCUMENT_LISTENER = 1  4,
+DOMCHARACTERDATAMODIFIED_LISTENER= 1  5,
+OVERFLOWCHANGED_LISTENER = 1  6,
+ANIMATIONEND_LISTENER= 1  7,
+ANIMATIONSTART_LISTENER  = 1  8,
+ANIMATIONITERATION_LISTENER  = 1  9,
+TRANSITIONEND_LISTENER   = 1  10,
+BEFORELOAD_LISTENER  = 1  11,
+SCROLL_LISTENER  = 1  12
+// 3 bits remaining
 };
 
 bool hasListenerType(ListenerType listenerType) const { 

[webkit-changes] [129280] trunk/Source/WebCore

[adamk]

Title: [129280] trunk/Source/WebCore








Revision 129280
Author ad...@chromium.org
Date 2012-09-21 17:30:48 -0700 (Fri, 21 Sep 2012)


Log Message
Simplify and optimize ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97352

Reviewed by Ryosuke Niwa.

ChildListMutationScope is one of the most complicated bits of
MutationObserver implementation. This patch aims to simplify it for
clarity and improve its performance (mostly by just doing less).

The big change is to remove the MutationAccumulatorRouter class,
replacing it with lifetime-management logic in ChildListMutationAccumulator
ChildListMutationScope is expected to call getOrCreate() in
its constructor, and each scope holds a RefPtr to the accumulator.
When the last scope holding such a RefPtr is destroyed,
ChildListMutationAccumulator's destructor enqueues the accumulated record.

This greatly reduces the number of lines of code, and condenses
two HashMaps into one. It also reduces hash lookups, which now
occur only on scope creation and when the refcount for a given
accumulator reaches 0 (previously, each childAdded and willRemoveChild
call could result in two hash lookups each).

There are some minor changes as well: the ChildListMutationAccumulator::clear()
method is gone, as it was doing more work than necessary;
DEFINE_STATIC_LOCAL is now used instead of hand-rolled static-management
code; ChildListMutationAccumulator::m_lastAdded is no longer a RefPtr, since it
always points at a Node that's already being ref'd by the accumulator.
Also various minor syntactic cleanups.

No new tests, no change in behavior.

* dom/ChildListMutationScope.cpp:
(WebCore::accumulatorMap): Reduced two maps to one, and manage its lifetime with DEFINE_STATIC_LOCAL.
(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator): Remove unnecessary call to clear() (which itself has been removed).
(WebCore::ChildListMutationAccumulator::~ChildListMutationAccumulator): Enqueue record if not empty at destruction, and have the accumulator
remove itself from the map.
(WebCore::ChildListMutationAccumulator::getOrCreate): Replaces half of MutationAccumulatorRouter's job.
(WebCore::ChildListMutationAccumulator::childAdded): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::isRemovedNodeInOrder): Simplify RefPtr syntax.
(WebCore::ChildListMutationAccumulator::willRemoveChild): Minor RefPtr usage improvements.
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord): Replace call to clear() with clearing m_lastAdded,
since it's the only bit not cleared by the MutationRecord creation call. Also remove
isEmpty check and replace with asserts now that it's a private method.
(WebCore::ChildListMutationAccumulator::isEmpty): Added more assertions about emptiness.
* dom/ChildListMutationScope.h:
(WebCore):
(ChildListMutationAccumulator): Extract the inner class to make everything easier to read.
(WebCore::ChildListMutationScope::ChildListMutationScope): Store m_accumulator rather than m_target.
(WebCore::ChildListMutationScope::~ChildListMutationScope): ditto
(WebCore::ChildListMutationScope::childAdded): ditto
(WebCore::ChildListMutationScope::willRemoveChild): ditto
(ChildListMutationScope):
* html/HTMLElement.cpp: Remove unused ChildListMutationScope.h #include.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
trunk/Source/WebCore/dom/ChildListMutationScope.h
trunk/Source/WebCore/html/HTMLElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129279 => 129280)

--- trunk/Source/WebCore/ChangeLog	2012-09-22 00:16:45 UTC (rev 129279)
+++ trunk/Source/WebCore/ChangeLog	2012-09-22 00:30:48 UTC (rev 129280)
@@ -1,3 +1,59 @@
+2012-09-21  Adam Klein  ad...@chromium.org
+
+Simplify and optimize ChildListMutationScope
+https://bugs.webkit.org/show_bug.cgi?id=97352
+
+Reviewed by Ryosuke Niwa.
+
+ChildListMutationScope is one of the most complicated bits of
+MutationObserver implementation. This patch aims to simplify it for
+clarity and improve its performance (mostly by just doing less).
+
+The big change is to remove the MutationAccumulatorRouter class,
+replacing it with lifetime-management logic in ChildListMutationAccumulator
+ChildListMutationScope is expected to call getOrCreate() in
+its constructor, and each scope holds a RefPtr to the accumulator.
+When the last scope holding such a RefPtr is destroyed,
+ChildListMutationAccumulator's destructor enqueues the accumulated record.
+
+This greatly reduces the number of lines of code, and condenses
+two HashMaps into one. It also reduces hash lookups, which now
+occur only on scope creation and when the refcount for a given
+accumulator reaches 0 (previously, each childAdded and willRemoveChild
+call could result in two hash lookups each).
+
+There are some minor changes as well: the 

[webkit-changes] [129288] trunk

[adamk]

Title: [129288] trunk








Revision 129288
Author ad...@chromium.org
Date 2012-09-21 18:27:52 -0700 (Fri, 21 Sep 2012)


Log Message
Remove bogus assertions from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=97372

Reviewed by Ryosuke Niwa.

Source/WebCore:

Some asserts (and their accompanying comment) were trying to enforce
proper usage of ChildListMutationScope from WebCore, but in the
presence of MutationEvents they could fail due to arbitrary script
execution.

This change gets rid of those asserts and adds tests exercising
the (pre-existing) codepaths for handling these out-of-order cases.
Without this patch, these tests ASSERT in debug builds.

Tests: fast/mutation/added-out-of-order.html
   fast/mutation/removed-out-of-order.html

* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):
* dom/ChildListMutationScope.h:
(WebCore):

LayoutTests:

* fast/mutation/added-out-of-order-expected.txt: Added.
* fast/mutation/added-out-of-order.html: Added.
* fast/mutation/removed-out-of-order-expected.txt: Added.
* fast/mutation/removed-out-of-order.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
trunk/Source/WebCore/dom/ChildListMutationScope.h


Added Paths

trunk/LayoutTests/fast/mutation/added-out-of-order-expected.txt
trunk/LayoutTests/fast/mutation/added-out-of-order.html
trunk/LayoutTests/fast/mutation/removed-out-of-order-expected.txt
trunk/LayoutTests/fast/mutation/removed-out-of-order.html




Diff

Modified: trunk/LayoutTests/ChangeLog (129287 => 129288)

--- trunk/LayoutTests/ChangeLog	2012-09-22 01:18:54 UTC (rev 129287)
+++ trunk/LayoutTests/ChangeLog	2012-09-22 01:27:52 UTC (rev 129288)
@@ -1,3 +1,15 @@
+2012-09-21  Adam Klein  ad...@chromium.org
+
+Remove bogus assertions from ChildListMutationScope
+https://bugs.webkit.org/show_bug.cgi?id=97372
+
+Reviewed by Ryosuke Niwa.
+
+* fast/mutation/added-out-of-order-expected.txt: Added.
+* fast/mutation/added-out-of-order.html: Added.
+* fast/mutation/removed-out-of-order-expected.txt: Added.
+* fast/mutation/removed-out-of-order.html: Added.
+
 2012-09-21  Dan Bernstein  m...@apple.com
 
 REGRESSION (r129176): Incorrect line breaking when kerning occurs between a space and the following character


Added: trunk/LayoutTests/fast/mutation/added-out-of-order-expected.txt (0 => 129288)

--- trunk/LayoutTests/fast/mutation/added-out-of-order-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/added-out-of-order-expected.txt	2012-09-22 01:27:52 UTC (rev 129288)
@@ -0,0 +1,19 @@
+Test MutationEvents interfering with MutationObservers: adding nodes 'out of order'
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS mutations.length is 3
+PASS mutations[0].addedNodes.length is 0
+PASS mutations[0].removedNodes.length is 1
+PASS mutations[0].removedNodes[0].tagName is 'SPAN'
+PASS mutations[1].addedNodes.length is 1
+PASS mutations[1].removedNodes.length is 0
+PASS mutations[1].addedNodes[0].tagName is 'DIV'
+PASS mutations[2].addedNodes.length is 1
+PASS mutations[2].removedNodes.length is 0
+PASS mutations[2].addedNodes[0].nodeValue is 'hello world'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/added-out-of-order.html (0 => 129288)

--- trunk/LayoutTests/fast/mutation/added-out-of-order.html	(rev 0)
+++ trunk/LayoutTests/fast/mutation/added-out-of-order.html	2012-09-22 01:27:52 UTC (rev 129288)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+div id=sandbox style=display:nonespan/span/div
+script src=""
+script
+description(Test MutationEvents interfering with MutationObservers: adding nodes 'out of order');
+var sandbox = document.getElementById('sandbox');
+var inserted = false;
+sandbox.addEventListener('DOMNodeRemoved', function() {
+if (!inserted) {
+sandbox.appendChild(document.createElement('div'));
+inserted = true;
+}
+});
+var observer = new WebKitMutationObserver(function(){});
+observer.observe(sandbox, {childList: true});
+sandbox.textContent = 'hello world';
+
+var mutations = observer.takeRecords();
+shouldBe(mutations.length, 3);
+shouldBe(mutations[0].addedNodes.length, 0);
+shouldBe(mutations[0].removedNodes.length, 1);
+shouldBe(mutations[0].removedNodes[0].tagName, 'SPAN');
+shouldBe(mutations[1].addedNodes.length, 1);
+shouldBe(mutations[1].removedNodes.length, 0);
+shouldBe(mutations[1].addedNodes[0].tagName, 'DIV');
+shouldBe(mutations[2].addedNodes.length, 1);
+shouldBe(mutations[2].removedNodes.length, 0);
+shouldBe(mutations[2].addedNodes[0].nodeValue, 'hello world');
+/script
+script src=""


Added: trunk/LayoutTests/fast/mutation/removed-out-of-order-expected.txt (0 => 129288)

--- 

[webkit-changes] [129164] trunk/Source/WebCore

[adamk]

Title: [129164] trunk/Source/WebCore








Revision 129164
Author ad...@chromium.org
Date 2012-09-20 13:47:41 -0700 (Thu, 20 Sep 2012)


Log Message
Rename ContainerNode::parserAddChild parserAppendChild for consistency
https://bugs.webkit.org/show_bug.cgi?id=97254

Reviewed by Adam Barth.

No functional change, all the below changes are simple renames.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserAppendChild):
* dom/ContainerNode.h:
(ContainerNode):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* editing/markup.cpp:
(WebCore::createFragmentForTransformToFragment):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addText):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::executeTask):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::parseDocumentFragment):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
(WebCore::XMLDocumentParser::parseCdata):
(WebCore::XMLDocumentParser::parseComment):
(WebCore::XMLDocumentParser::parseDtd):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::add):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/DOMImplementation.cpp
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp
trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/track/WebVTTParser.cpp
trunk/Source/WebCore/xml/XMLErrors.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp
trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129163 => 129164)

--- trunk/Source/WebCore/ChangeLog	2012-09-20 20:46:09 UTC (rev 129163)
+++ trunk/Source/WebCore/ChangeLog	2012-09-20 20:47:41 UTC (rev 129164)
@@ -1,3 +1,58 @@
+2012-09-20  Adam Klein  ad...@chromium.org
+
+Rename ContainerNode::parserAddChild parserAppendChild for consistency
+https://bugs.webkit.org/show_bug.cgi?id=97254
+
+Reviewed by Adam Barth.
+
+No functional change, all the below changes are simple renames.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::takeAllChildrenFrom):
+(WebCore::ContainerNode::parserAppendChild):
+* dom/ContainerNode.h:
+(ContainerNode):
+* dom/DOMImplementation.cpp:
+(WebCore::DOMImplementation::createDocument):
+* editing/markup.cpp:
+(WebCore::createFragmentForTransformToFragment):
+* html/HTMLViewSourceDocument.cpp:
+(WebCore::HTMLViewSourceDocument::createContainingTable):
+(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
+(WebCore::HTMLViewSourceDocument::addLine):
+(WebCore::HTMLViewSourceDocument::finishLine):
+(WebCore::HTMLViewSourceDocument::addText):
+(WebCore::HTMLViewSourceDocument::addBase):
+(WebCore::HTMLViewSourceDocument::addLink):
+* html/parser/HTMLConstructionSite.cpp:
+(WebCore::executeTask):
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
+* html/track/WebVTTParser.cpp:
+(WebCore::WebVTTParser::constructTreeFromToken):
+* xml/XMLErrors.cpp:
+(WebCore::createXHTMLParserErrorHeader):
+(WebCore::XMLErrors::insertErrorMessageBlock):
+* xml/parser/XMLDocumentParser.cpp:
+(WebCore::XMLDocumentParser::enterText):
+(WebCore::XMLDocumentParser::parseDocumentFragment):
+* xml/parser/XMLDocumentParserLibxml2.cpp:
+(WebCore::XMLDocumentParser::startElementNs):
+(WebCore::XMLDocumentParser::processingInstruction):
+

[webkit-changes] [128314] trunk/LayoutTests

[adamk]

Title: [128314] trunk/LayoutTests








Revision 128314
Author ad...@chromium.org
Date 2012-09-12 08:34:37 -0700 (Wed, 12 Sep 2012)


Log Message
Mark new test fast/filesystem/workers/detached-frame-crash.html
as flakily crashing in cr-win  cr-linux debug builds.

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128313 => 128314)

--- trunk/LayoutTests/ChangeLog	2012-09-12 15:32:48 UTC (rev 128313)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 15:34:37 UTC (rev 128314)
@@ -1,3 +1,12 @@
+2012-09-12  Adam Klein  ad...@chromium.org
+
+Mark new test fast/filesystem/workers/detached-frame-crash.html
+as flakily crashing in cr-win  cr-linux debug builds.
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-09-12  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128313 => 128314)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 15:32:48 UTC (rev 128313)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 15:34:37 UTC (rev 128314)
@@ -3620,4 +3620,6 @@
 
 BUGWK96227 SKIP : fast/js/function-dot-arguments-identity.html = TEXT
 
+BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH
+
 BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128343] trunk/Tools

[adamk]

Title: [128343] trunk/Tools








Revision 128343
Author ad...@chromium.org
Date 2012-09-12 11:24:39 -0700 (Wed, 12 Sep 2012)


Log Message
[chromium] Add content_browsertests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=96535

Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/dashboard_base.js:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js




Diff

Modified: trunk/Tools/ChangeLog (128342 => 128343)

--- trunk/Tools/ChangeLog	2012-09-12 18:23:44 UTC (rev 128342)
+++ trunk/Tools/ChangeLog	2012-09-12 18:24:39 UTC (rev 128343)
@@ -1,3 +1,12 @@
+2012-09-12  Adam Klein  ad...@chromium.org
+
+[chromium] Add content_browsertests to the flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=96535
+
+Reviewed by Ojan Vafai.
+
+* TestResultServer/static-dashboards/dashboard_base.js:
+
 2012-09-12  Christophe Dumez  christophe.du...@intel.com
 
 [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache


Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (128342 => 128343)

--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-09-12 18:23:44 UTC (rev 128342)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-09-12 18:24:39 UTC (rev 128343)
@@ -119,6 +119,7 @@
 'browser_tests',
 'cacheinvalidation_unittests',
 'compositor_unittests',
+'content_browsertests',
 'content_unittests',
 'courgette_unittests',
 'crypto_unittests',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128354] trunk/LayoutTests

[adamk]

Title: [128354] trunk/LayoutTests








Revision 128354
Author ad...@chromium.org
Date 2012-09-12 13:33:32 -0700 (Wed, 12 Sep 2012)


Log Message
Unreviewed gardening.

Mark some new hidpi tests as failing after r128348.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128353 => 128354)

--- trunk/LayoutTests/ChangeLog	2012-09-12 20:13:47 UTC (rev 128353)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 20:33:32 UTC (rev 128354)
@@ -1,3 +1,11 @@
+2012-09-12  Adam Klein  ad...@chromium.org
+
+Unreviewed gardening.
+
+Mark some new hidpi tests as failing after r128348.
+
+* platform/chromium/TestExpectations:
+
 2012-09-12  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r128318 and r128332.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128353 => 128354)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:13:47 UTC (rev 128353)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:33:32 UTC (rev 128354)
@@ -3628,4 +3628,7 @@
 
 BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH
 
+BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html = IMAGE
+BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html = IMAGE
+
 BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128355] trunk/LayoutTests

[adamk]

Title: [128355] trunk/LayoutTests








Revision 128355
Author ad...@chromium.org
Date 2012-09-12 13:35:34 -0700 (Wed, 12 Sep 2012)


Log Message
Unreviewed gardening.

Mark seek-to-end-after-duration-change.html as flaky.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128354 => 128355)

--- trunk/LayoutTests/ChangeLog	2012-09-12 20:33:32 UTC (rev 128354)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 20:35:34 UTC (rev 128355)
@@ -2,6 +2,14 @@
 
 Unreviewed gardening.
 
+Mark seek-to-end-after-duration-change.html as flaky.
+
+* platform/chromium/TestExpectations:
+
+2012-09-12  Adam Klein  ad...@chromium.org
+
+Unreviewed gardening.
+
 Mark some new hidpi tests as failing after r128348.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128354 => 128355)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:33:32 UTC (rev 128354)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:35:34 UTC (rev 128355)
@@ -3631,4 +3631,6 @@
 BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html = IMAGE
 BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html = IMAGE
 
+BUGWK96550 : http/tests/media/media-source/seek-to-end-after-duration-change.html = PASS TIMEOUT
+
 BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128357] trunk/LayoutTests

[adamk]

Title: [128357] trunk/LayoutTests








Revision 128357
Author ad...@chromium.org
Date 2012-09-12 13:57:25 -0700 (Wed, 12 Sep 2012)


Log Message
Widen CRASH expectations for fast/replaced/border-radius-clip.html

Unreviewed gardening.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128356 => 128357)

--- trunk/LayoutTests/ChangeLog	2012-09-12 20:40:06 UTC (rev 128356)
+++ trunk/LayoutTests/ChangeLog	2012-09-12 20:57:25 UTC (rev 128357)
@@ -1,3 +1,11 @@
+2012-09-12  Adam Klein  ad...@chromium.org
+
+Widen CRASH expectations for fast/replaced/border-radius-clip.html
+
+Unreviewed gardening.
+
+* platform/chromium/TestExpectations:
+
 2012-09-12  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Updated test expectations following r128346.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128356 => 128357)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:40:06 UTC (rev 128356)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-12 20:57:25 UTC (rev 128357)
@@ -2403,8 +2403,7 @@
 BUGWK60097 DEBUG : fast/dom/HTMLLinkElement/link-and-subresource-test.html = PASS TEXT
 
 // Looks like some uninitialized memory at the bottom.
-BUGWK60103 LINUX ANDROID DEBUG : fast/replaced/border-radius-clip.html = IMAGE CRASH
-BUGWK60103 LINUX ANDROID RELEASE : fast/replaced/border-radius-clip.html = IMAGE
+BUGWK60103 LINUX ANDROID : fast/replaced/border-radius-clip.html = IMAGE CRASH
 BUGWK60103 WIN : fast/replaced/border-radius-clip.html = IMAGE
 BUGWK60103 MAC : fast/replaced/border-radius-clip.html = IMAGE+TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128213] trunk/Tools

[adamk]

Title: [128213] trunk/Tools








Revision 128213
Author ad...@chromium.org
Date 2012-09-11 11:50:13 -0700 (Tue, 11 Sep 2012)


Log Message
Garden-o-matic should ignore a wider variety of warnings in buildbot json
https://bugs.webkit.org/show_bug.cgi?id=96411

Reviewed by Adam Barth.

Previously only the exact string warning was treated as a warning
result. This patch treats any string with warning as a substring
as a warning (e.g., warnings, as seen on the cr-win buildbots).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js (128212 => 128213)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js	2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js	2012-09-11 18:50:13 UTC (rev 128213)
@@ -56,7 +56,8 @@
 // FIXME: Do build.webkit.org bots output this marker when the tests fail to run?
 return step.text.indexOf(kCrashedOrHungOutputMarker) != -1;
 }
-return step.results[0]  0  step.text.indexOf('warning') == -1;
+function isWarning(text) { return text.indexOf('warning') != -1; }
+return step.results[0]  0  !step.text.some(isWarning);
 }
 
 function failingSteps(buildInfo)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js (128212 => 128213)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js	2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js	2012-09-11 18:50:13 UTC (rev 128213)
@@ -541,7 +541,7 @@
 results: [1, []],
 statistics: {},
 step_number: 4,
-text: [extract_build, warning],
+text: [extract_build, warnings],
 times: [1318366370.94771, 1318366404.552783],
 urls: {}
 }, {


Modified: trunk/Tools/ChangeLog (128212 => 128213)

--- trunk/Tools/ChangeLog	2012-09-11 18:42:55 UTC (rev 128212)
+++ trunk/Tools/ChangeLog	2012-09-11 18:50:13 UTC (rev 128213)
@@ -1,3 +1,18 @@
+2012-09-11  Adam Klein  ad...@chromium.org
+
+Garden-o-matic should ignore a wider variety of warnings in buildbot json
+https://bugs.webkit.org/show_bug.cgi?id=96411
+
+Reviewed by Adam Barth.
+
+Previously only the exact string warning was treated as a warning
+result. This patch treats any string with warning as a substring
+as a warning (e.g., warnings, as seen on the cr-win buildbots).
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
+(.):
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
+
 2012-09-11  Marcelo Lira  marcelo.l...@openbossa.org
 
 Restore original value of mock scrollbars enabled in InternalSettings






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128214] trunk/LayoutTests

[adamk]

Title: [128214] trunk/LayoutTests








Revision 128214
Author ad...@chromium.org
Date 2012-09-11 12:04:35 -0700 (Tue, 11 Sep 2012)


Log Message
Unreviewed chromium gardening.

Mark compositing/overflow/overflow-scaled-descendant-overflapping as
failing on cr-mac after r127789 and remove bad rebaselines.

* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Removed Paths

trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (128213 => 128214)

--- trunk/LayoutTests/ChangeLog	2012-09-11 18:50:13 UTC (rev 128213)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 19:04:35 UTC (rev 128214)
@@ -1,3 +1,14 @@
+2012-09-11  Adam Klein  ad...@chromium.org
+
+Unreviewed chromium gardening.
+
+Mark compositing/overflow/overflow-scaled-descendant-overflapping as
+failing on cr-mac after r127789 and remove bad rebaselines.
+
+* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
+* platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
+* platform/chromium/TestExpectations:
+
 2012-09-11  Mike West  mk...@chromium.org
 
 Improve console error messages when 'document.domain' blocks cross-origin script access.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128213 => 128214)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 18:50:13 UTC (rev 128213)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 19:04:35 UTC (rev 128214)
@@ -3631,4 +3631,6 @@
 
 BUGWK96227 SKIP : fast/js/function-dot-arguments-identity.html = TEXT
 
+BUGWK96416 MAC : compositing/overflow/overflow-scaled-descendant-overlapping.html = IMAGE
+
 BUGWK128105 : fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE PASS


Deleted: trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png (128213 => 128214)

--- trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png	2012-09-11 18:50:13 UTC (rev 128213)
+++ trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png	2012-09-11 19:04:35 UTC (rev 128214)
@@ -1,4 +0,0 @@
-\x89PNG
-
-
-IHDR X\x9Av\x82p)tEXtchecksum9b0ce6613aac1c659e70dd1fe9b08077y\xD1.\xD7\x98IDATx\x9C\xED\xDB\xD1m1\xC10羃\xF4}\xD3D\xB0\xB2q3\xBC\xDF\xA5\xD9\xDD\xFD|\x9F\x87
2ȼN\x80w6\xBFsz¿\xD8_\xBD\x80\xF7\xE0d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
d\x90 @F\x80
dfw\xF7\xF4\xE0\@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 #@\x80\x8C
2\xC8 

[webkit-changes] [128233] trunk/LayoutTests

[adamk]

Title: [128233] trunk/LayoutTests








Revision 128233
Author ad...@chromium.org
Date 2012-09-11 16:04:11 -0700 (Tue, 11 Sep 2012)


Log Message
Unreviewed gardening.

Suppress image failures for gradient-with-scaled-ancestor.html due to
scrollbar diffs.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128232 => 128233)

--- trunk/LayoutTests/ChangeLog	2012-09-11 22:47:32 UTC (rev 128232)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 23:04:11 UTC (rev 128233)
@@ -1,3 +1,12 @@
+2012-09-11  Adam Klein  ad...@chromium.org
+
+Unreviewed gardening.
+
+Suppress image failures for gradient-with-scaled-ancestor.html due to
+scrollbar diffs.
+
+* platform/chromium/TestExpectations:
+
 2012-09-11  James Robinson  jam...@chromium.org
 
 Unreviewed gardening. Update some expectations to reference specific bugs.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128232 => 128233)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 22:47:32 UTC (rev 128232)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-11 23:04:11 UTC (rev 128233)
@@ -3638,6 +3638,7 @@
 
 BUGWK95813 : fast/innerHTML/innerHTML-iframe.html = TEXT PASS
 
+BUGWK96441 WIN DEBUG : fast/hidpi/gradient-with-scaled-ancestor.html = IMAGE
 
 BUGWK96041 LINUX : http/tests/cache/cancel-during-revalidation-succeeded.html = PASS TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126080] trunk

[adamk]

Title: [126080] trunk








Revision 126080
Author ad...@chromium.org
Date 2012-08-20 15:24:35 -0700 (Mon, 20 Aug 2012)


Log Message
Remove redundant TOUCH_LISTENER event type
https://bugs.webkit.org/show_bug.cgi?id=94524

Reviewed by Ryosuke Niwa.

Source/WebCore:

Code that needs to determine whether there are touch listeners
can instead call Document::touchEventHandlerCount(), added in r107832.
TOUCH_LISTENER didn't fit very well into the hasListenerType() model
anyway, as there's not a 1:1 correspondance between the enum value and
an event.

* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Remove two bits of code:
the bookkeeping for TOUCH_LISTENER, and the notification into
ChromeClient (which is handled by calls to didAddTouchEventHandler in
all the places that call addListenerTypeIfNeeded).
(WebCore::Document::didRemoveTouchEventHandler): Remove bookkeeping for TOUCH_LISTENER.
* dom/Document.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Call touchEventHandlerCount instead of hasListenerType.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): ditto
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): ditto
* page/Frame.cpp:
(WebCore::Frame::setDocument): ditto
* testing/Internals.cpp: Remove hasTouchEventListener method since its
data source no longer exists.
* testing/Internals.h: ditto
(Internals):
* testing/Internals.idl: ditto

Source/WebKit/chromium:

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove
bookkeeping for TOUCH_LISTENER.

LayoutTests:

Removed tests for hasTouchEventListener as they're redundant
with tests for touchEventHandlerCount.

* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
trunk/LayoutTests/fast/events/touch/touch-handler-count.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/history/CachedFrame.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (126079 => 126080)

--- trunk/LayoutTests/ChangeLog	2012-08-20 22:23:54 UTC (rev 126079)
+++ trunk/LayoutTests/ChangeLog	2012-08-20 22:24:35 UTC (rev 126080)
@@ -1,3 +1,16 @@
+2012-08-20  Adam Klein  ad...@chromium.org
+
+Remove redundant TOUCH_LISTENER event type
+https://bugs.webkit.org/show_bug.cgi?id=94524
+
+Reviewed by Ryosuke Niwa.
+
+Removed tests for hasTouchEventListener as they're redundant
+with tests for touchEventHandlerCount.
+
+* fast/events/touch/touch-handler-count-expected.txt:
+* fast/events/touch/touch-handler-count.html:
+
 2012-08-20  Kenneth Russell  k...@google.com
 
 Reftest fast/text-autosizing/nested-em-line-height.html needs updating after r126058


Modified: trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (126079 => 126080)

--- trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-08-20 22:23:54 UTC (rev 126079)
+++ trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt	2012-08-20 22:24:35 UTC (rev 126080)
@@ -5,9 +5,7 @@
 
 Test addEventListener/removeEventListener on the document.
 PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.hasTouchEventListener(document) is false
 PASS window.internals.touchEventHandlerCount(document) is 1
-PASS window.internals.hasTouchEventListener(document) is true
 PASS window.internals.touchEventHandlerCount(document) is 2
 PASS window.internals.touchEventHandlerCount(document) is 3
 PASS window.internals.touchEventHandlerCount(document) is 2
@@ -15,22 +13,16 @@
 PASS window.internals.touchEventHandlerCount(document) is 1
 PASS window.internals.touchEventHandlerCount(document) is 1
 PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.hasTouchEventListener(document) is false
 Test setting touch handlers on the document.
 PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.hasTouchEventListener(document) is false
 PASS window.internals.touchEventHandlerCount(document) is 4
-PASS window.internals.hasTouchEventListener(document) is true
 PASS window.internals.touchEventHandlerCount(document) is 4
 PASS window.internals.touchEventHandlerCount(document) is 3
 PASS window.internals.touchEventHandlerCount(document) is 3
 PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.hasTouchEventListener(document) is false
 Test 

[webkit-changes] [126113] trunk/Source

[adamk]

Title: [126113] trunk/Source








Revision 126113
Author ad...@chromium.org
Date 2012-08-20 18:14:51 -0700 (Mon, 20 Aug 2012)


Log Message
Allow MutationEvents to be enabled/disabled per context
https://bugs.webkit.org/show_bug.cgi?id=94016

Reviewed by Ojan Vafai.

Source/WebCore:

Chromium wants to be able to turn MutationEvents off for some
Documents (e.g., for Apps V2). This patch makes the firing (and the
constructor on DOMWindow) of MutationEvents a per-context feature, with
the default being enabled.

No functional change (since the feature defaults to enabled).
It's not clear to me that there's a way to test this in DRT without
adding a special hook for this one feature. It will be tested in
Chromium once it's implemented in Chromium.

* dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::mutationEventsEnabled): Add new method,
with the default being enabled.
* dom/ContextFeatures.h:
* dom/Document.cpp:
(WebCore::Document::addMutationEventListenerTypeIfEnabled): Add new
method that checks the ContextFeature flag before adding the passed-in
listener type.
(WebCore::Document::addListenerTypeIfNeeded): Call the new method
instead of addListenerType for MutationEvent types.
* dom/Document.h:
(WebCore::Document::addListenerType): Make private to avoid anyone
outside Document from enabling MutationEvent listeners. All callers
must go through addListenerTypeIfNeeded.

Source/WebKit/chromium:

Add Chromium/WebKit API for enabling/disabling MutationEvents via
WebPermissionClient.

* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowMutationEvents):
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContextFeatures.cpp
trunk/Source/WebCore/dom/ContextFeatures.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPermissionClient.h
trunk/Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (126112 => 126113)

--- trunk/Source/WebCore/ChangeLog	2012-08-21 01:01:01 UTC (rev 126112)
+++ trunk/Source/WebCore/ChangeLog	2012-08-21 01:14:51 UTC (rev 126113)
@@ -1,3 +1,35 @@
+2012-08-20  Adam Klein  ad...@chromium.org
+
+Allow MutationEvents to be enabled/disabled per context
+https://bugs.webkit.org/show_bug.cgi?id=94016
+
+Reviewed by Ojan Vafai.
+
+Chromium wants to be able to turn MutationEvents off for some
+Documents (e.g., for Apps V2). This patch makes the firing (and the
+constructor on DOMWindow) of MutationEvents a per-context feature, with
+the default being enabled.
+
+No functional change (since the feature defaults to enabled).
+It's not clear to me that there's a way to test this in DRT without
+adding a special hook for this one feature. It will be tested in
+Chromium once it's implemented in Chromium.
+
+* dom/ContextFeatures.cpp:
+(WebCore::ContextFeatures::mutationEventsEnabled): Add new method,
+with the default being enabled.
+* dom/ContextFeatures.h:
+* dom/Document.cpp:
+(WebCore::Document::addMutationEventListenerTypeIfEnabled): Add new
+method that checks the ContextFeature flag before adding the passed-in
+listener type.
+(WebCore::Document::addListenerTypeIfNeeded): Call the new method
+instead of addListenerType for MutationEvent types.
+* dom/Document.h:
+(WebCore::Document::addListenerType): Make private to avoid anyone
+outside Document from enabling MutationEvent listeners. All callers
+must go through addListenerTypeIfNeeded.
+
 2012-08-20  Levi Weintraub  le...@chromium.org
 
 [Sub-pixel Layout] Block selection gap repainting can leave one pixel gaps


Modified: trunk/Source/WebCore/dom/ContextFeatures.cpp (126112 => 126113)

--- trunk/Source/WebCore/dom/ContextFeatures.cpp	2012-08-21 01:01:01 UTC (rev 126112)
+++ trunk/Source/WebCore/dom/ContextFeatures.cpp	2012-08-21 01:14:51 UTC (rev 126113)
@@ -111,6 +111,14 @@
 #endif
 }
 
+bool ContextFeatures::mutationEventsEnabled(Document* document)
+{
+ASSERT(document);
+if (!document)
+return true;
+return document-contextFeatures()-isEnabled(document, MutationEvents, true);
+}
+
 void provideContextFeaturesTo(Page* page, ContextFeaturesClient* client)
 {
 RefCountedSupplementPage, ContextFeatures::provideTo(page, ContextFeatures::supplementName(), ContextFeatures::create(client));


Modified: trunk/Source/WebCore/dom/ContextFeatures.h (126112 => 126113)

--- trunk/Source/WebCore/dom/ContextFeatures.h	2012-08-21 01:01:01 UTC (rev 126112)
+++ trunk/Source/WebCore/dom/ContextFeatures.h	2012-08-21 01:14:51 UTC (rev 126113)
@@ -44,6 +44,7 @@
 StyleScoped,
 PagePopup,
 HTMLNotifications,

[webkit-changes] [123233] trunk/Source/WebCore

[adamk]

Title: [123233] trunk/Source/WebCore








Revision 123233
Author ad...@chromium.org
Date 2012-07-20 10:56:12 -0700 (Fri, 20 Jul 2012)


Log Message
CodeGeneratorInspector.py is unnecessarily chatty
https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a print statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

* inspector/CodeGeneratorInspector.py:
(SmartOutput.close): Remove print statement.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (123232 => 123233)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 17:56:12 UTC (rev 123233)
@@ -1,3 +1,22 @@
+2012-07-20  Adam Klein  ad...@chromium.org
+
+CodeGeneratorInspector.py is unnecessarily chatty
+https://bugs.webkit.org/show_bug.cgi?id=91758
+
+Reviewed by Vsevolod Vlasov.
+
+The code aded in r123091 included a print statement for each written
+file. This makes for noisy build output, especially noticeable in the
+Chromium ninja build (where build output takes up a single line of the
+console).
+
+If this print statement is generally useful, it should be
+hidden behind a --verbose commandline option, as we do for the binding
+generators.
+
+* inspector/CodeGeneratorInspector.py:
+(SmartOutput.close): Remove print statement.
+
 2012-07-20  Stephen White  senorbla...@chromium.org
 
 [chromium] Enable GPU-accelerated skia implementation of


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (123232 => 123233)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:56:12 UTC (rev 123233)
@@ -2975,7 +2975,6 @@
 pass
 
 if text_changed:
-print writing  + self.file_name_
 out_file = open(self.file_name_, w)
 out_file.write(self.output_)
 out_file.close()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122284] trunk/Source/WebKit/chromium

[adamk]

Title: [122284] trunk/Source/WebKit/chromium








Revision 122284
Author ad...@chromium.org
Date 2012-07-10 18:13:16 -0700 (Tue, 10 Jul 2012)


Log Message
[Chromium] REGRESSION(r121909): m_currentInputEvent never set
https://bugs.webkit.org/show_bug.cgi?id=90914

Reviewed by Abhishek Arya.

The always-null m_currentInputEvent causes a regression when
middle-clicking on a link that calls window.open('...', '_blank');
that new tab should open in the background, but instead opens in the
foreground (see code in ChromeClientImpl::getNavigationPolicy()).

Fix usage of TemporaryChange to specify a local variable name so that
m_currentInputEvent is actually set for the duration of handleInputEvent.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122283 => 122284)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-11 01:07:49 UTC (rev 122283)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-11 01:13:16 UTC (rev 122284)
@@ -1,3 +1,21 @@
+2012-07-10  Adam Klein  ad...@chromium.org
+
+[Chromium] REGRESSION(r121909): m_currentInputEvent never set
+https://bugs.webkit.org/show_bug.cgi?id=90914
+
+Reviewed by Abhishek Arya.
+
+The always-null m_currentInputEvent causes a regression when
+middle-clicking on a link that calls window.open('...', '_blank');
+that new tab should open in the background, but instead opens in the
+foreground (see code in ChromeClientImpl::getNavigationPolicy()).
+
+Fix usage of TemporaryChange to specify a local variable name so that
+m_currentInputEvent is actually set for the duration of handleInputEvent.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance.
+
 2012-07-10  Adam Barth  aba...@webkit.org
 
 WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (122283 => 122284)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-11 01:07:49 UTC (rev 122283)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-11 01:13:16 UTC (rev 122284)
@@ -1761,7 +1761,7 @@
 if (m_ignoreInputEvents)
 return false;
 
-TemporaryChangeconst WebInputEvent*(m_currentInputEvent, inputEvent);
+TemporaryChangeconst WebInputEvent* currentEventChange(m_currentInputEvent, inputEvent);
 
 #if ENABLE(POINTER_LOCK)
 if (isPointerLocked()  WebInputEvent::isMouseEventType(inputEvent.type)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [121278] trunk

[adamk]

Title: [121278] trunk








Revision 121278
Author ad...@chromium.org
Date 2012-06-26 12:36:50 -0700 (Tue, 26 Jun 2012)


Log Message
MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992

Reviewed by Ojan Vafai.

Source/WebCore:

The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.

Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of attributes, childList, or characterData
as a key in the dictionary.

* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):

LayoutTests:

* fast/mutation/observe-exceptions-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (121277 => 121278)

--- trunk/LayoutTests/ChangeLog	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 19:36:50 UTC (rev 121278)
@@ -1,3 +1,12 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+MutationObserver.observe should treat a null or undefined options argument as empty
+https://bugs.webkit.org/show_bug.cgi?id=89992
+
+Reviewed by Ojan Vafai.
+
+* fast/mutation/observe-exceptions-expected.txt:
+
 2012-06-26  Alpha Lam  hc...@chromium.org
 
 [chromium] Mark a layout test as timeout


Modified: trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt (121277 => 121278)

--- trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt	2012-06-26 19:36:50 UTC (rev 121278)
@@ -7,8 +7,8 @@
 PASS observer.observe(null) threw exception TypeError: Not enough arguments.
 PASS observer.observe(undefined) threw exception TypeError: Not enough arguments.
 PASS observer.observe(document.body) threw exception TypeError: Not enough arguments.
-PASS observer.observe(document.body, null) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
-PASS observer.observe(document.body, undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS observer.observe(document.body, null) threw exception Error: SYNTAX_ERR: DOM Exception 12.
+PASS observer.observe(document.body, undefined) threw exception Error: SYNTAX_ERR: DOM Exception 12.
 PASS observer.observe(null, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
 PASS observer.observe(undefined, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
 PASS observer.observe(document.body, {subtree: true}) threw exception Error: SYNTAX_ERR: DOM Exception 12.


Modified: trunk/Source/WebCore/ChangeLog (121277 => 121278)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 19:36:50 UTC (rev 121278)
@@ -1,3 +1,21 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+MutationObserver.observe should treat a null or undefined options argument as empty
+https://bugs.webkit.org/show_bug.cgi?id=89992
+
+Reviewed by Ojan Vafai.
+
+The WebIDL spec was recently updated to treat null or undefined
+Dictionary arguments the same as the empty dictionary. This patch
+updates MutationObserver.observe to follow that spec.
+
+Note that we still throw a SYNTAX_ERR in this case, since it's an
+error not to pass one of attributes, childList, or characterData
+as a key in the dictionary.
+
+* dom/WebKitMutationObserver.cpp:
+(WebCore::WebKitMutationObserver::observe):
+
 2012-06-26  Ian Vollick  voll...@chromium.org
 
 [chromium] The single thread proxy should not automatically tick new animations.


Modified: trunk/Source/WebCore/dom/WebKitMutationObserver.cpp (121277 => 121278)

--- trunk/Source/WebCore/dom/WebKitMutationObserver.cpp	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/Source/WebCore/dom/WebKitMutationObserver.cpp	2012-06-26 19:36:50 UTC (rev 121278)
@@ -89,11 +89,6 @@
 return;
 }
 
-if (optionsDictionary.isUndefinedOrNull()) {
-ec = TYPE_MISMATCH_ERR;
-return;
-}
-
 static const struct {
 const char* name;
 MutationObserverOptions value;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121295] trunk/Source/WebCore

[adamk]

Title: [121295] trunk/Source/WebCore








Revision 121295
Author ad...@chromium.org
Date 2012-06-26 16:02:00 -0700 (Tue, 26 Jun 2012)


Log Message
[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994

Reviewed by Adam Barth.

No change in behavior, so no new tests.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121294 => 121295)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1,3 +1,17 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+[v8] Clean up generated Dictionary-handling code
+https://bugs.webkit.org/show_bug.cgi?id=89994
+
+Reviewed by Adam Barth.
+
+No change in behavior, so no new tests.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateParametersCheck):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::optionsObjectCallback):
+
 2012-06-26  Raymond Toy  r...@google.com
 
 Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (121294 => 121295)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1724,13 +1724,8 @@
 $parameterCheckString .= EXCEPTION_BLOCK($nativeType, $parameterName,  .
  JSValueToNative($parameter, MAYBE_MISSING_PARAMETER(args, $paramIndex, $parameterDefaultPolicy), args.GetIsolate()) . );\n;
 if ($nativeType eq 'Dictionary') {
-   $parameterCheckString .= if (args.Length()  $paramIndex  !$parameterName.isUndefinedOrNull()  !$parameterName.isObject()) {\n;
-   if (@{$function-raisesExceptions}) {
-   $parameterCheckString .= ec = TYPE_MISMATCH_ERR;\n;
-   $parameterCheckString .= V8Proxy::setDOMException(ec, args.GetIsolate());\n;
-   }
-   $parameterCheckString .= return V8Proxy::throwTypeError(\Not an object.\);\n;
-   $parameterCheckString .= }\n;
+   $parameterCheckString .= if (!$parameterName.isUndefinedOrNull()  !$parameterName.isObject())\n;
+   $parameterCheckString .= return V8Proxy::throwTypeError(\Not an object.\, args.GetIsolate());\n;
 }
 }
 


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (121294 => 121295)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1150,17 +1150,15 @@
 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());
 TestObj* imp = V8TestObj::toNative(args.Holder());
 EXCEPTION_BLOCK(Dictionary, oo, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined));
-if (args.Length()  0  !oo.isUndefinedOrNull()  !oo.isObject()) {
-return V8Proxy::throwTypeError(Not an object.);
-}
+if (!oo.isUndefinedOrNull()  !oo.isObject())
+return V8Proxy::throwTypeError(Not an object., args.GetIsolate());
 if (args.Length() = 1) {
 imp-optionsObject(oo);
 return v8::Handlev8::Value();
 }
 EXCEPTION_BLOCK(Dictionary, ooo, MAYBE_MISSING_PARAMETER(args, 1, DefaultIsUndefined));
-if (args.Length()  1  !ooo.isUndefinedOrNull()  !ooo.isObject()) {
-return V8Proxy::throwTypeError(Not an object.);
-}
+if (!ooo.isUndefinedOrNull()  !ooo.isObject())
+return V8Proxy::throwTypeError(Not an object., args.GetIsolate());
 imp-optionsObject(oo, ooo);
 return v8::Handlev8::Value();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [120900] trunk/Source/WebCore

[adamk]

Title: [120900] trunk/Source/WebCore








Revision 120900
Author ad...@chromium.org
Date 2012-06-20 21:18:51 -0700 (Wed, 20 Jun 2012)


Log Message
Use Dictionary in MutationObserver.observe to kill custom code
https://bugs.webkit.org/show_bug.cgi?id=89629

Reviewed by Ryosuke Niwa.

Move code for dictionary parsing in MutationObserver.observe
that used to be duplicated (with different implementations)
in JSC and V8 bindings into WebKitMutationObserver.cpp, using
the new Dictionary interface.

No new tests, no change in behavior.

* bindings/js/JSWebKitMutationObserverCustom.cpp:
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:
(WebCore):
* dom/WebKitMutationObserver.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp
trunk/Source/WebCore/dom/WebKitMutationObserver.h
trunk/Source/WebCore/dom/WebKitMutationObserver.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (120899 => 120900)

--- trunk/Source/WebCore/ChangeLog	2012-06-21 02:03:44 UTC (rev 120899)
+++ trunk/Source/WebCore/ChangeLog	2012-06-21 04:18:51 UTC (rev 120900)
@@ -1,3 +1,25 @@
+2012-06-20  Adam Klein  ad...@chromium.org
+
+Use Dictionary in MutationObserver.observe to kill custom code
+https://bugs.webkit.org/show_bug.cgi?id=89629
+
+Reviewed by Ryosuke Niwa.
+
+Move code for dictionary parsing in MutationObserver.observe
+that used to be duplicated (with different implementations)
+in JSC and V8 bindings into WebKitMutationObserver.cpp, using
+the new Dictionary interface.
+
+No new tests, no change in behavior.
+
+* bindings/js/JSWebKitMutationObserverCustom.cpp:
+* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
+* dom/WebKitMutationObserver.cpp:
+(WebCore::WebKitMutationObserver::observe):
+* dom/WebKitMutationObserver.h:
+(WebCore):
+* dom/WebKitMutationObserver.idl:
+
 2012-06-20  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r120889.


Modified: trunk/Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp (120899 => 120900)

--- trunk/Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp	2012-06-21 02:03:44 UTC (rev 120899)
+++ trunk/Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp	2012-06-21 04:18:51 UTC (rev 120900)
@@ -34,15 +34,9 @@
 
 #include JSWebKitMutationObserver.h
 
-#include ExceptionCode.h
-#include JSDictionary.h
 #include JSMutationCallback.h
-#include JSNode.h
-#include Node.h
 #include WebKitMutationObserver.h
 #include runtime/Error.h
-#include wtf/HashSet.h
-#include wtf/text/AtomicString.h
 
 using namespace JSC;
 
@@ -64,59 +58,6 @@
 return JSValue::encode(asObject(toJS(exec, jsConstructor-globalObject(), WebKitMutationObserver::create(callback.release();
 }
 
-struct BooleanOption {
-const char* name;
-MutationObserverOptions value;
-};
-
-static const BooleanOption booleanOptions[] = {
-{ childList, WebKitMutationObserver::ChildList },
-{ attributes, WebKitMutationObserver::Attributes },
-{ characterData, WebKitMutationObserver::CharacterData },
-{ subtree, WebKitMutationObserver::Subtree },
-{ attributeOldValue, WebKitMutationObserver::AttributeOldValue },
-{ characterDataOldValue, WebKitMutationObserver::CharacterDataOldValue }
-};
-
-static const size_t numBooleanOptions = sizeof(booleanOptions) / sizeof(BooleanOption);
-
-JSValue JSWebKitMutationObserver::observe(ExecState* exec)
-{
-if (exec-argumentCount()  2)
-return throwError(exec, createNotEnoughArgumentsError(exec));
-Node* target = toNode(exec-argument(0));
-if (exec-hadException())
-return jsUndefined();
-
-JSObject* optionsObject = exec-argument(1).getObject();
-if (!optionsObject) {
-setDOMException(exec, TYPE_MISMATCH_ERR);
-return jsUndefined();
-}
-
-JSDictionary dictionary(exec, optionsObject);
-MutationObserverOptions options = 0;
-for (unsigned i = 0; i  numBooleanOptions; ++i) {
-bool option = false;
-if (!dictionary.tryGetProperty(booleanOptions[i].name, option))
-return jsUndefined();
-if (option)
-options |= booleanOptions[i].value;
-}
-
-HashSetAtomicString attributeFilter;
-if (!dictionary.tryGetProperty(attributeFilter, attributeFilter))
-return jsUndefined();
-if (!attributeFilter.isEmpty())
-options |= WebKitMutationObserver::AttributeFilter;
-
-ExceptionCode ec = 0;
-impl()-observe(target, options, attributeFilter, ec);
-if (ec)
-setDOMException(exec, ec);
-return jsUndefined();
-}
-
 } // namespace WebCore
 
 #endif // 

[webkit-changes] [118571] trunk/LayoutTests

[adamk]

Title: [118571] trunk/LayoutTests








Revision 118571
Author ad...@chromium.org
Date 2012-05-25 15:07:32 -0700 (Fri, 25 May 2012)


Log Message
Rebaseline Chromium expectations for fast/box-shadow/shadow-buffer-partial.html

Unreviewed rebaselining.

The same rebaseline was made in r112582, but only got the Linux expectations.

* fast/box-shadow/shadow-buffer-partial-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt.
* platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/fast/box-shadow/shadow-buffer-partial-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/efl/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt
trunk/LayoutTests/platform/mac/fast/box-shadow/shadow-buffer-partial-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118570 => 118571)

--- trunk/LayoutTests/ChangeLog	2012-05-25 22:02:32 UTC (rev 118570)
+++ trunk/LayoutTests/ChangeLog	2012-05-25 22:07:32 UTC (rev 118571)
@@ -1,3 +1,24 @@
+2012-05-25  Adam Klein  ad...@chromium.org
+
+Rebaseline Chromium expectations for fast/box-shadow/shadow-buffer-partial.html
+
+Unreviewed rebaselining.
+
+The same rebaseline was made in r112582, but only got the Linux expectations.
+
+* fast/box-shadow/shadow-buffer-partial-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt.
+* platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/chromium/test_expectations.txt:
+* platform/efl/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+* platform/mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
+
 2012-05-24  Ryosuke Niwa  rn...@webkit.org
 
 createContextualFragment and insertAdjacentHTML should throw syntax error


Copied: trunk/LayoutTests/fast/box-shadow/shadow-buffer-partial-expected.txt (from rev 118570, trunk/LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt) (0 => 118571)

--- trunk/LayoutTests/fast/box-shadow/shadow-buffer-partial-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/box-shadow/shadow-buffer-partial-expected.txt	2012-05-25 22:07:32 UTC (rev 118571)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x192
+  RenderBlock {HTML} at (0,0) size 800x192
+RenderBody {BODY} at (8,30) size 

[webkit-changes] [118573] trunk/LayoutTests

[adamk]

Title: [118573] trunk/LayoutTests








Revision 118573
Author ad...@chromium.org
Date 2012-05-25 15:14:30 -0700 (Fri, 25 May 2012)


Log Message
Mark some flaky TypedArray tests more appropriately as DEBUG SLOW

Unreviewed test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118572 => 118573)

--- trunk/LayoutTests/ChangeLog	2012-05-25 22:10:59 UTC (rev 118572)
+++ trunk/LayoutTests/ChangeLog	2012-05-25 22:14:30 UTC (rev 118573)
@@ -1,5 +1,13 @@
 2012-05-25  Adam Klein  ad...@chromium.org
 
+Mark some flaky TypedArray tests more appropriately as DEBUG SLOW
+
+Unreviewed test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2012-05-25  Adam Klein  ad...@chromium.org
+
 Rebaseline Chromium expectations for fast/box-shadow/shadow-buffer-partial.html
 
 Unreviewed rebaselining.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (118572 => 118573)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:10:59 UTC (rev 118572)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:14:30 UTC (rev 118573)
@@ -3628,10 +3628,10 @@
 BUGWK85038 : http/tests/inspector/network/network-initiator.html = TEXT TIMEOUT
 BUGWK85082 XP DEBUG : platform/chromium/media/video-capture-preview.html = CRASH PASS
 
-BUGWK85090 : fast/js/dfg-float64array.html = PASS TIMEOUT
-BUGWK85090 : fast/js/dfg-uint32array.html = PASS TIMEOUT
-BUGWK85090 : fast/js/dfg-uint16array.html = PASS TIMEOUT
-BUGWK85090 : fast/js/dfg-uint8array.html = PASS TIMEOUT
+BUGWK85090 DEBUG SLOW : fast/js/dfg-float64array.html = PASS
+BUGWK85090 DEBUG SLOW : fast/js/dfg-uint32array.html = PASS
+BUGWK85090 DEBUG SLOW : fast/js/dfg-uint16array.html = PASS
+BUGWK85090 DEBUG SLOW : fast/js/dfg-uint8array.html = PASS
 BUGWK85106 SLOW : tables/mozilla/other/slashlogo.html = PASS
 
 BUGWK85174 : fast/files/blob-constructor.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118576] trunk/LayoutTests

[adamk]

Title: [118576] trunk/LayoutTests








Revision 118576
Author ad...@chromium.org
Date 2012-05-25 15:24:41 -0700 (Fri, 25 May 2012)


Log Message
compositing/overflow/overflow-positioning.html fails with timeout on multiple chromium bots
https://bugs.webkit.org/show_bug.cgi?id=85771

Unreviewed test expectations update.

These tests haven't timed out lately on the Chromium bots, so removing
the suppressions.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118575 => 118576)

--- trunk/LayoutTests/ChangeLog	2012-05-25 22:22:56 UTC (rev 118575)
+++ trunk/LayoutTests/ChangeLog	2012-05-25 22:24:41 UTC (rev 118576)
@@ -1,3 +1,15 @@
+2012-05-25  Adam Klein  ad...@chromium.org
+
+compositing/overflow/overflow-positioning.html fails with timeout on multiple chromium bots
+https://bugs.webkit.org/show_bug.cgi?id=85771
+
+Unreviewed test expectations update.
+
+These tests haven't timed out lately on the Chromium bots, so removing
+the suppressions.
+
+* platform/chromium/test_expectations.txt:
+
 2012-05-25  Anna Cavender ann...@chromium.org
 
 [Chromium] Removing tests from test_expectations.txt that are no longer crashing.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (118575 => 118576)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:22:56 UTC (rev 118575)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:24:41 UTC (rev 118576)
@@ -3676,16 +3676,6 @@
 BUGWK85952 WIN : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT
 BUGWK85952 MAC DEBUG : http/tests/media/media-source/video-media-source-state-changes.html = PASS TEXT
 
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/overflow/overflow-positioning.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/overflow/scrollbar-painting.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/reflections/masked-reflection-on-composited.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/visibility/visibility-simple-webgl-layer.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/rtl/rtl-absolute-overflow-scrolled.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : platform/chromium/compositing/lost-compositor-context.html = PASS TIMEOUT
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/animation/state-at-end-event-transform-layer.html = TIMEOUT PASS
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/geometry/video-opacity-overlay.html = TIMEOUT PASS
-BUGWK85771 SNOWLEOPARD LION LINUX : compositing/scroll-painted-composited-content.html = TIMEOUT PASS
-BUGWK85771 SNOWLEOPARD LION : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = TIMEOUT PASS
 // Started flaking at around http://trac.webkit.org/changeset/116278.
 BUGWK85950 LINUX DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT
 
@@ -3760,7 +3750,7 @@
 
 BUGWK87160 WIN SNOWLEOPARD : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html = PASS CRASH
 BUGWK87160 XP VISTA : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = PASS CRASH
-BUGWK85771 BUGWK87160 LINUX : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = PASS CRASH TIMEOUT
+BUGWK87160 LINUX : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = PASS CRASH
 
 BUGWK87273 : webaudio/audioparam-connect-audioratesignal.html = TIMEOUT PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118578] trunk/LayoutTests

[adamk]

Title: [118578] trunk/LayoutTests








Revision 118578
Author ad...@chromium.org
Date 2012-05-25 15:36:16 -0700 (Fri, 25 May 2012)


Log Message
Remove a bunch of flaky expectations for tests that now pass.

Unreviewed test expectations update.

Also marked some nearby tests as more definitely failing.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118577 => 118578)

--- trunk/LayoutTests/ChangeLog	2012-05-25 22:30:56 UTC (rev 118577)
+++ trunk/LayoutTests/ChangeLog	2012-05-25 22:36:16 UTC (rev 118578)
@@ -1,5 +1,15 @@
 2012-05-25  Adam Klein  ad...@chromium.org
 
+Remove a bunch of flaky expectations for tests that now pass.
+
+Unreviewed test expectations update.
+
+Also marked some nearby tests as more definitely failing.
+
+* platform/chromium/test_expectations.txt:
+
+2012-05-25  Adam Klein  ad...@chromium.org
+
 compositing/overflow/overflow-positioning.html fails with timeout on multiple chromium bots
 https://bugs.webkit.org/show_bug.cgi?id=85771
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (118577 => 118578)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:30:56 UTC (rev 118577)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-25 22:36:16 UTC (rev 118578)
@@ -3297,18 +3297,8 @@
 BUGW81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-sw.html = PASS IMAGE
 BUGW81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-w.html = PASS IMAGE
 
-// Timing out on SNOWLEOPARD DEBUG since at least r111525
-BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/input-type-change3.html = PASS TIMEOUT
-BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/textarea-align.html = PASS TIMEOUT
-BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/select-empty-option-height.html = PASS TIMEOUT
-BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/input-type-change.html = PASS TIMEOUT
-BUGWK81813 SNOWLEOPARD DEBUG : fast/forms/interactive-validation-remove-node-in-handler.html = PASS TIMEOUT
-BUGWK81814 SNOWLEOPARD DEBUG : fast/parser/fragment-parser.html = PASS TIMEOUT
-BUGWK81815 SNOWLEOPARD DEBUG : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS TIMEOUT
-BUGWK81816 SNOWLEOPARD DEBUG : fast/dom/DOMImplementation/createDocumentType-err.html = PASS TIMEOUT
-BUGWK81857 SNOWLEOPARD LEOPARD : fast/frames/valid.html = PASS IMAGE TIMEOUT
-BUGWK81857 SNOWLEOPARD DEBUG : fast/frames/calculate-order.html = PASS TIMEOUT
-BUGWK81931 SNOWLEOPARD LEOPARD DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT
+BUGWK81857 SNOWLEOPARD LEOPARD : fast/frames/valid.html = IMAGE
+BUGWK81931 SNOWLEOPARD LEOPARD WIN DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT
 
 BUGWK37244 : tables/mozilla/bugs/bug27038-1.html = IMAGE+TEXT
 BUGWK37244 : tables/mozilla/bugs/bug27038-2.html = IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115897] trunk

[adamk]

Title: [115897] trunk








Revision 115897
Author ad...@chromium.org
Date 2012-05-02 15:04:15 -0700 (Wed, 02 May 2012)


Log Message
Childlist mutations in shadow DOM should be observable with MutationObservers
https://bugs.webkit.org/show_bug.cgi?id=85402

Reviewed by Ojan Vafai.

Source/WebCore:

Though Mutation Events are not supported in Shadow DOM,
MutationObservers are supposed to be. Due to a misplacement of the
ChildListMutationScope, they were erroneously getting skipped.

This patch moves code around to properly notify when childlist are
mutated in shadow DOM and covers that change with a new test.

Test: fast/mutation/shadow-dom.html

* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Handle notification of removal directly.
(WebCore::willRemoveChildren): ditto.
(WebCore::dispatchChildInsertionEvents): Remove notification of insertion.
(WebCore::dispatchChildRemovalEvents): Remove notification of removal.
(WebCore::updateTreeAfterInsertion): Handle notification of insertion directly.

LayoutTests:

Added test covering childList mutations as well as attribute and
characterData mutations (these were already working).

* fast/mutation/shadow-dom-expected.txt: Added.
* fast/mutation/shadow-dom.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp


Added Paths

trunk/LayoutTests/fast/mutation/shadow-dom-expected.txt
trunk/LayoutTests/fast/mutation/shadow-dom.html




Diff

Modified: trunk/LayoutTests/ChangeLog (115896 => 115897)

--- trunk/LayoutTests/ChangeLog	2012-05-02 22:01:37 UTC (rev 115896)
+++ trunk/LayoutTests/ChangeLog	2012-05-02 22:04:15 UTC (rev 115897)
@@ -1,3 +1,16 @@
+2012-05-02  Adam Klein  ad...@chromium.org
+
+Childlist mutations in shadow DOM should be observable with MutationObservers
+https://bugs.webkit.org/show_bug.cgi?id=85402
+
+Reviewed by Ojan Vafai.
+
+Added test covering childList mutations as well as attribute and
+characterData mutations (these were already working).
+
+* fast/mutation/shadow-dom-expected.txt: Added.
+* fast/mutation/shadow-dom.html: Added.
+
 2012-05-02  Eric Carlson  eric.carl...@apple.com
 
 Crash in WebCore::TextTrackList::remove


Added: trunk/LayoutTests/fast/mutation/shadow-dom-expected.txt (0 => 115897)

--- trunk/LayoutTests/fast/mutation/shadow-dom-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mutation/shadow-dom-expected.txt	2012-05-02 22:04:15 UTC (rev 115897)
@@ -0,0 +1,18 @@
+Test that MutationObservers operate in Shadow DOM
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Mutations in shadow DOM should have been observed:
+PASS mutations.length is 4
+PASS mutations[0].type is attributes
+PASS mutations[1].type is childList
+PASS mutations[2].type is characterData
+PASS mutations[3].type is childList
+
+Observing from outside shadow DOM should not see mutations in the shadow:
+PASS mutations is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/mutation/shadow-dom.html (0 => 115897)

--- trunk/LayoutTests/fast/mutation/shadow-dom.html	(rev 0)
+++ trunk/LayoutTests/fast/mutation/shadow-dom.html	2012-05-02 22:04:15 UTC (rev 115897)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+body
+input type=range
+script src=""
+script
+description('Test that MutationObservers operate in Shadow DOM');
+
+function doTest() {
+function mutate(elt) {
+elt.setAttribute('data-foo', 'bar');
+elt.insertBefore(document.createTextNode('hello'), elt.firstChild);
+elt.firstChild.textContent = 'goodbye';
+elt.removeChild(elt.firstChild);
+}
+
+var shadowRoot = internals.shadowRoot(document.querySelector('input'));
+var observer = new WebKitMutationObserver(function(mutations) {
+window.mutations = mutations;
+});
+
+observer.observe(shadowRoot.firstChild, {attributes: true, childList: true, characterData: true, subtree: true});
+mutate(shadowRoot.firstChild);
+
+setTimeout(function() {
+debug('Mutations in shadow DOM should have been observed:');
+shouldBe('mutations.length', '4');
+shouldBe('mutations[0].type', 'attributes');
+shouldBe('mutations[1].type', 'childList');
+shouldBe('mutations[2].type', 'characterData');
+shouldBe('mutations[3].type', 'childList');
+observer.disconnect();
+
+window.mutations = null;
+observer.observe(document, {attributes: true, childList: true, characterData: true, subtree: true});
+mutate(shadowRoot.firstChild);
+setTimeout(function() {
+debug('\nObserving from outside shadow DOM should not see mutations in the shadow:');
+shouldBeNull('mutations');
+finishJSTest();
+}, 0);
+}, 0);
+}
+
+if (window.internals) {
+doTest();
+window.jsTestIsAsync = true;
+} else
+

[webkit-changes] [115517] trunk/Source/WebCore

[adamk]

Title: [115517] trunk/Source/WebCore








Revision 115517
Author ad...@chromium.org
Date 2012-04-27 16:56:42 -0700 (Fri, 27 Apr 2012)


Log Message
Remove misspelled, unused, unimplemented method from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=85091

Reviewed by Dimitri Glazkov.

* bindings/v8/V8Proxy.h:
(V8Proxy):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Proxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115516 => 115517)

--- trunk/Source/WebCore/ChangeLog	2012-04-27 23:51:17 UTC (rev 115516)
+++ trunk/Source/WebCore/ChangeLog	2012-04-27 23:56:42 UTC (rev 115517)
@@ -1,3 +1,13 @@
+2012-04-27  Adam Klein  ad...@chromium.org
+
+Remove misspelled, unused, unimplemented method from V8Proxy
+https://bugs.webkit.org/show_bug.cgi?id=85091
+
+Reviewed by Dimitri Glazkov.
+
+* bindings/v8/V8Proxy.h:
+(V8Proxy):
+
 2012-04-24  Jeffrey Pfau  jp...@apple.com
 
 Disable RTF in _javascript_ drag-and-drop


Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (115516 => 115517)

--- trunk/Source/WebCore/bindings/v8/V8Proxy.h	2012-04-27 23:51:17 UTC (rev 115516)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.h	2012-04-27 23:56:42 UTC (rev 115517)
@@ -171,8 +171,6 @@
 // Returns the window object associated with a context.
 static DOMWindow* retrieveWindow(v8::Handlev8::Context);
 
-static DOMWindow* retriveWindowForCallingCOntext();
-
 // Returns V8Proxy object of the currently executing context.
 static V8Proxy* retrieve();
 // Returns V8Proxy object associated with a frame.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115381] trunk/Source/WebCore

[adamk]

Title: [115381] trunk/Source/WebCore








Revision 115381
Author ad...@chromium.org
Date 2012-04-26 15:36:34 -0700 (Thu, 26 Apr 2012)


Log Message
Don't include V8Proxy.h in ScriptValue.h when V8GCController is all that's required
https://bugs.webkit.org/show_bug.cgi?id=84986

Reviewed by Kentaro Hara.

This makes it easier to include ScriptValue.h since it greatly reduces
that header's dependencies.

* bindings/v8/ScriptValue.h: Changed to include just V8GCController.h and
removed comment which is redundant with explicit V8GCController references nearby.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115380 => 115381)

--- trunk/Source/WebCore/ChangeLog	2012-04-26 22:34:15 UTC (rev 115380)
+++ trunk/Source/WebCore/ChangeLog	2012-04-26 22:36:34 UTC (rev 115381)
@@ -1,3 +1,16 @@
+2012-04-26  Adam Klein  ad...@chromium.org
+
+Don't include V8Proxy.h in ScriptValue.h when V8GCController is all that's required
+https://bugs.webkit.org/show_bug.cgi?id=84986
+
+Reviewed by Kentaro Hara.
+
+This makes it easier to include ScriptValue.h since it greatly reduces
+that header's dependencies.
+
+* bindings/v8/ScriptValue.h: Changed to include just V8GCController.h and
+removed comment which is redundant with explicit V8GCController references nearby.
+
 2012-04-26  Aaron Colwell  acolw...@chromium.org
 
 Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.


Modified: trunk/Source/WebCore/bindings/v8/ScriptValue.h (115380 => 115381)

--- trunk/Source/WebCore/bindings/v8/ScriptValue.h	2012-04-26 22:34:15 UTC (rev 115380)
+++ trunk/Source/WebCore/bindings/v8/ScriptValue.h	2012-04-26 22:36:34 UTC (rev 115381)
@@ -40,7 +40,7 @@
 #include wtf/Vector.h
 
 #ifndef NDEBUG
-#include V8Proxy.h  // for register and unregister global handles.
+#include V8GCController.h
 #endif
 
 namespace WTF {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115249] trunk/Source/WebCore

[adamk]

Title: [115249] trunk/Source/WebCore








Revision 115249
Author ad...@chromium.org
Date 2012-04-25 15:33:10 -0700 (Wed, 25 Apr 2012)


Log Message
Fix uninitialized variable warnings in PasteboardMac.mm after 115145
https://bugs.webkit.org/show_bug.cgi?id=84879

Reviewed by Enrica Casucci.

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
(WebCore::Pasteboard::writeSelectionForTypes): ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PasteboardMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (115248 => 115249)

--- trunk/Source/WebCore/ChangeLog	2012-04-25 22:12:49 UTC (rev 115248)
+++ trunk/Source/WebCore/ChangeLog	2012-04-25 22:33:10 UTC (rev 115249)
@@ -1,3 +1,14 @@
+2012-04-25  Adam Klein  ad...@chromium.org
+
+Fix uninitialized variable warnings in PasteboardMac.mm after 115145
+https://bugs.webkit.org/show_bug.cgi?id=84879
+
+Reviewed by Enrica Casucci.
+
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
+(WebCore::Pasteboard::writeSelectionForTypes): ditto.
+
 2012-04-25  Kenneth Russell  k...@google.com
 
 Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced


Modified: trunk/Source/WebCore/platform/mac/PasteboardMac.mm (115248 => 115249)

--- trunk/Source/WebCore/platform/mac/PasteboardMac.mm	2012-04-25 22:12:49 UTC (rev 115248)
+++ trunk/Source/WebCore/platform/mac/PasteboardMac.mm	2012-04-25 22:33:10 UTC (rev 115249)
@@ -156,7 +156,7 @@
 if (enclosingAnchor  comparePositions(firstPositionInOrBeforeNode(range-startPosition().anchorNode()), range-startPosition()) = 0)
 range-setStart(enclosingAnchor, 0, ec);
 
-NSAttributedString* attributedString;
+NSAttributedString* attributedString = nil;
 RetainPtrWebHTMLConverter converter(AdoptNS, [[WebHTMLConverter alloc] initWithDOMRange:kit(range.get())]);
 if (converter)
 attributedString = [converter.get() attributedString];
@@ -176,7 +176,7 @@
 
 void Pasteboard::writeSelectionForTypes(const VectorString pasteboardTypes, bool canSmartCopyOrDelete, Frame* frame)
 {
-NSAttributedString* attributedString;
+NSAttributedString* attributedString = nil;
 RetainPtrWebHTMLConverter converter(AdoptNS, [[WebHTMLConverter alloc] initWithDOMRange:kit(frame-editor()-selectedRange().get())]);
 if (converter)
 attributedString = [converter.get() attributedString];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115061] trunk/Source

[adamk]

Title: [115061] trunk/Source








Revision 115061
Author ad...@chromium.org
Date 2012-04-24 08:29:22 -0700 (Tue, 24 Apr 2012)


Log Message
Fix includes in StrongInlines.h and ScriptValue.h
https://bugs.webkit.org/show_bug.cgi?id=84659

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

* heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's
definiition is required here.

Source/WebCore:

This change was prompted by an attempt to use ScriptValue.h from a
WebCore header file and running into trouble with the (as it turns out
unnecessary) include of JSDOMBinding.h.

* bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that
it's not included by the header.
* bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/StrongInlines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptValue.cpp
trunk/Source/WebCore/bindings/js/ScriptValue.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (115060 => 115061)

--- trunk/Source/_javascript_Core/ChangeLog	2012-04-24 15:27:11 UTC (rev 115060)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-24 15:29:22 UTC (rev 115061)
@@ -1,3 +1,13 @@
+2012-04-24  Adam Klein  ad...@chromium.org
+
+Fix includes in StrongInlines.h and ScriptValue.h
+https://bugs.webkit.org/show_bug.cgi?id=84659
+
+Reviewed by Geoffrey Garen.
+
+* heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's
+definiition is required here.
+
 2012-04-23  Filip Pizlo  fpi...@apple.com
 
 DFG OSR exit should ensure that all variables have been initialized


Modified: trunk/Source/_javascript_Core/heap/StrongInlines.h (115060 => 115061)

--- trunk/Source/_javascript_Core/heap/StrongInlines.h	2012-04-24 15:27:11 UTC (rev 115060)
+++ trunk/Source/_javascript_Core/heap/StrongInlines.h	2012-04-24 15:29:22 UTC (rev 115061)
@@ -26,6 +26,8 @@
 #ifndef StrongInlines_h
 #define StrongInlines_h
 
+#include JSGlobalData.h
+
 namespace JSC {
 
 template typename T


Modified: trunk/Source/WebCore/ChangeLog (115060 => 115061)

--- trunk/Source/WebCore/ChangeLog	2012-04-24 15:27:11 UTC (rev 115060)
+++ trunk/Source/WebCore/ChangeLog	2012-04-24 15:29:22 UTC (rev 115061)
@@ -1,3 +1,18 @@
+2012-04-24  Adam Klein  ad...@chromium.org
+
+Fix includes in StrongInlines.h and ScriptValue.h
+https://bugs.webkit.org/show_bug.cgi?id=84659
+
+Reviewed by Geoffrey Garen.
+
+This change was prompted by an attempt to use ScriptValue.h from a
+WebCore header file and running into trouble with the (as it turns out
+unnecessary) include of JSDOMBinding.h.
+
+* bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that
+it's not included by the header.
+* bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.
+
 2012-04-24  Antti Koivisto  an...@apple.com
 
 Move MediaList CSSOM wrapper ownership to parent rule or stylesheet


Modified: trunk/Source/WebCore/bindings/js/ScriptValue.cpp (115060 => 115061)

--- trunk/Source/WebCore/bindings/js/ScriptValue.cpp	2012-04-24 15:27:11 UTC (rev 115060)
+++ trunk/Source/WebCore/bindings/js/ScriptValue.cpp	2012-04-24 15:29:22 UTC (rev 115061)
@@ -31,6 +31,7 @@
 #include ScriptValue.h
 
 #include InspectorValues.h
+#include JSDOMBinding.h
 #include SerializedScriptValue.h
 
 #include _javascript_Core/APICast.h


Modified: trunk/Source/WebCore/bindings/js/ScriptValue.h (115060 => 115061)

--- trunk/Source/WebCore/bindings/js/ScriptValue.h	2012-04-24 15:27:11 UTC (rev 115060)
+++ trunk/Source/WebCore/bindings/js/ScriptValue.h	2012-04-24 15:29:22 UTC (rev 115061)
@@ -31,7 +31,6 @@
 #ifndef ScriptValue_h
 #define ScriptValue_h
 
-#include JSDOMBinding.h
 #include PlatformString.h
 #include SerializedScriptValue.h
 #include ScriptState.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115158] trunk/Source/WebCore

[adamk]

Title: [115158] trunk/Source/WebCore








Revision 115158
Author ad...@chromium.org
Date 2012-04-24 19:05:46 -0700 (Tue, 24 Apr 2012)


Log Message
Remove unused undefined() method from ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=84751

Reviewed by Kentaro Hara.

* bindings/js/ScriptValue.h:
(ScriptValue):
* bindings/v8/ScriptValue.h:
(ScriptValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptValue.h
trunk/Source/WebCore/bindings/v8/ScriptValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115157 => 115158)

--- trunk/Source/WebCore/ChangeLog	2012-04-25 01:59:08 UTC (rev 115157)
+++ trunk/Source/WebCore/ChangeLog	2012-04-25 02:05:46 UTC (rev 115158)
@@ -1,3 +1,15 @@
+2012-04-24  Adam Klein  ad...@chromium.org
+
+Remove unused undefined() method from ScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=84751
+
+Reviewed by Kentaro Hara.
+
+* bindings/js/ScriptValue.h:
+(ScriptValue):
+* bindings/v8/ScriptValue.h:
+(ScriptValue):
+
 2012-04-24  Yong Li  y...@rim.com
 
 ASSERT failure in RenderLayer::computeRepaintRects


Modified: trunk/Source/WebCore/bindings/js/ScriptValue.h (115157 => 115158)

--- trunk/Source/WebCore/bindings/js/ScriptValue.h	2012-04-25 01:59:08 UTC (rev 115157)
+++ trunk/Source/WebCore/bindings/js/ScriptValue.h	2012-04-25 02:05:46 UTC (rev 115158)
@@ -65,8 +65,6 @@
 PassRefPtrSerializedScriptValue serialize(ScriptState*, SerializationErrorMode = Throwing);
 static ScriptValue deserialize(ScriptState*, SerializedScriptValue*, SerializationErrorMode = Throwing);
 
-static ScriptValue undefined();
-
 #if ENABLE(INSPECTOR)
 PassRefPtrInspectorValue toInspectorValue(ScriptState*) const;
 #endif


Modified: trunk/Source/WebCore/bindings/v8/ScriptValue.h (115157 => 115158)

--- trunk/Source/WebCore/bindings/v8/ScriptValue.h	2012-04-25 01:59:08 UTC (rev 115157)
+++ trunk/Source/WebCore/bindings/v8/ScriptValue.h	2012-04-25 02:05:46 UTC (rev 115158)
@@ -133,8 +133,6 @@
 PassRefPtrSerializedScriptValue serialize(ScriptState*);
 static ScriptValue deserialize(ScriptState*, SerializedScriptValue*);
 
-static ScriptValue undefined() { return ScriptValue(v8::Undefined()); }
-
 void clear()
 {
 if (m_value.IsEmpty())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [114034] trunk/Source/WebCore

[adamk]

Title: [114034] trunk/Source/WebCore








Revision 114034
Author ad...@chromium.org
Date 2012-04-12 14:11:37 -0700 (Thu, 12 Apr 2012)


Log Message
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Kentaro Hara.

This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.

I've landed the refactoring bits of r112318 as separate changes,
so that this patch contains only the change in which map setter is called.

Binding tests have been updated with new output.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
to set up wrapper mapping and remove call to leakRef() which is handled
in V8DOMWrapper.
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (114033 => 114034)

--- trunk/Source/WebCore/ChangeLog	2012-04-12 21:09:48 UTC (rev 114033)
+++ trunk/Source/WebCore/ChangeLog	2012-04-12 21:11:37 UTC (rev 114034)
@@ -1,3 +1,44 @@
+2012-04-12  Adam Klein  ad...@chromium.org
+
+Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
+https://bugs.webkit.org/show_bug.cgi?id=82256
+
+Reviewed by Kentaro Hara.
+
+This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.
+
+I've landed the refactoring bits of r112318 as separate changes,
+so that this patch contains only the change in which map setter is called.
+
+Binding tests have been updated with new output.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
+to set up wrapper mapping and remove call to leakRef() which is handled
+in V8DOMWrapper.
+* bindings/scripts/test/V8/V8Float64Array.cpp:
+(WebCore::V8Float64Array::wrapSlow):
+* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
+(WebCore::V8TestActiveDOMObject::wrapSlow):
+* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
+(WebCore::V8TestCustomNamedGetter::wrapSlow):
+* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
+(WebCore::V8TestEventConstructor::wrapSlow):
+* bindings/scripts/test/V8/V8TestEventTarget.cpp:
+(WebCore::V8TestEventTarget::wrapSlow):
+* bindings/scripts/test/V8/V8TestInterface.cpp:
+(WebCore::V8TestInterface::wrapSlow):
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
+(WebCore::V8TestMediaQueryListListener::wrapSlow):
+* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
+(WebCore::V8TestNamedConstructor::wrapSlow):
+* bindings/scripts/test/V8/V8TestNode.cpp:
+(WebCore::V8TestNode::wrapSlow):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::V8TestObj::wrapSlow):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+

[webkit-changes] [113897] trunk

[adamk]

Title: [113897] trunk








Revision 113897
Author ad...@chromium.org
Date 2012-04-11 13:00:26 -0700 (Wed, 11 Apr 2012)


Log Message
[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=83706

Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.

This change is coming soon to the DOM4 spec, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.

* dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::createIfNeeded):
* dom/MutationObserverInterestGroup.h:
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
* dom/MutationObserverRegistration.h:
(WebCore):
(MutationObserverRegistration):
* dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
(Node):

LayoutTests:

Updated attributes test to match new behavior.

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt
trunk/LayoutTests/fast/mutation/observe-attributes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationObserverInterestGroup.cpp
trunk/Source/WebCore/dom/MutationObserverInterestGroup.h
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/LayoutTests/ChangeLog (113896 => 113897)

--- trunk/LayoutTests/ChangeLog	2012-04-11 20:00:10 UTC (rev 113896)
+++ trunk/LayoutTests/ChangeLog	2012-04-11 20:00:26 UTC (rev 113897)
@@ -1,3 +1,15 @@
+2012-04-11  Adam Klein  ad...@chromium.org
+
+[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
+https://bugs.webkit.org/show_bug.cgi?id=83706
+
+Reviewed by Ryosuke Niwa.
+
+Updated attributes test to match new behavior.
+
+* fast/mutation/observe-attributes-expected.txt:
+* fast/mutation/observe-attributes.html:
+
 2012-04-11  Anders Carlsson  ander...@apple.com
 
 Add two more DOM storage tests to the Skipped list.


Modified: trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt (113896 => 113897)

--- trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt	2012-04-11 20:00:10 UTC (rev 113896)
+++ trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt	2012-04-11 20:00:26 UTC (rev 113897)
@@ -135,16 +135,13 @@
 PASS mutations[2].attributeName is baz
 PASS mutations[2].attributeNamespace is null
 
-Testing that attributeFilter respects case with non-HTML elements.
-...pathLength should be received.
-PASS mutations.length is 1
-PASS mutations[0].type is attributes
-PASS mutations[0].attributeName is pathLength
-PASS mutations[0].attributeNamespace is http://www.w3.org/2000/svg
+Testing that setting an attributeFilter filters out namespaced attributes.
+...pathLength should not be received.
+PASS mutations is null
 
 Testing that attributeFilter respects case with non-HTML elements.
-...only ID, id, booM, pathLength should be received.
-PASS mutations.length is 4
+...only ID, id, booM should be received.
+PASS mutations.length is 3
 PASS mutations[0].type is attributes
 PASS mutations[0].attributeName is ID
 PASS mutations[0].attributeNamespace is null
@@ -154,9 +151,6 @@
 PASS mutations[2].type is attributes
 PASS mutations[2].attributeName is booM
 PASS mutations[2].attributeNamespace is null
-PASS mutations[3].type is attributes
-PASS mutations[3].attributeName is pathLength
-PASS mutations[3].attributeNamespace is http://www.w3.org/2000/svg
 
 Testing that modifying an elements style property dispatches Mutation Records.
 PASS mutations.length is 3


Modified: trunk/LayoutTests/fast/mutation/observe-attributes.html (113896 => 113897)

--- trunk/LayoutTests/fast/mutation/observe-attributes.html	2012-04-11 20:00:10 UTC (rev 113896)
+++ trunk/LayoutTests/fast/mutation/observe-attributes.html	2012-04-11 20:00:26 UTC (rev 113897)
@@ -562,7 +562,7 @@
 var observer;
 
 function start() {
-debug('Testing that attributeFilter respects case with non-HTML elements.');
+debug('Testing that setting an attributeFilter filters out namespaced attributes.');
 
 mutations = null;
 observer = new WebKitMutationObserver(function(m) {
@@ -572,18 +572,14 @@
 path = 

[webkit-changes] [113747] branches/chromium/1084

[adamk]

Title: [113747] branches/chromium/1084








Revision 113747
Author ad...@chromium.org
Date 2012-04-10 12:01:44 -0700 (Tue, 10 Apr 2012)


Log Message
Merge 113378 - Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html
   fast/mutation/transient-gc-crash.html

* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.
* dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.
* dom/WebKitMutationObserver.h:

LayoutTests:

* fast/mutation/clear-transient-without-delivery-expected.txt: Added.
* fast/mutation/clear-transient-without-delivery.html: Added.
* fast/mutation/transient-gc-crash-expected.txt: Added.
* fast/mutation/transient-gc-crash.html: Added.


TBR=infe...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/033

Modified Paths

branches/chromium/1084/Source/WebCore/dom/MutationObserverRegistration.cpp
branches/chromium/1084/Source/WebCore/dom/MutationObserverRegistration.h
branches/chromium/1084/Source/WebCore/dom/WebKitMutationObserver.cpp
branches/chromium/1084/Source/WebCore/dom/WebKitMutationObserver.h


Added Paths

branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery-expected.txt
branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery.html
branches/chromium/1084/LayoutTests/fast/mutation/transient-gc-crash-expected.txt
branches/chromium/1084/LayoutTests/fast/mutation/transient-gc-crash.html




Diff

Copied: branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery-expected.txt (from rev 113378, trunk/LayoutTests/fast/mutation/clear-transient-without-delivery-expected.txt) (0 => 113747)

--- branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery-expected.txt	(rev 0)
+++ branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery-expected.txt	2012-04-10 19:01:44 UTC (rev 113747)
@@ -0,0 +1,10 @@
+Transient registrations should be cleared even without delivery.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS mutationsDelivered is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery.html (from rev 113378, trunk/LayoutTests/fast/mutation/clear-transient-without-delivery.html) (0 => 113747)

--- branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery.html	(rev 0)
+++ branches/chromium/1084/LayoutTests/fast/mutation/clear-transient-without-delivery.html	2012-04-10 19:01:44 UTC (rev 113747)
@@ -0,0 +1,26 @@
+script src=""
+script
+window.jsTestIsAsync = true;
+description('Transient registrations should be cleared even without delivery.');
+
+var mutationsDelivered = false;
+function callback(mutations) {
+mutationsDelivered = true;
+}
+var observer = new WebKitMutationObserver(callback);
+
+var div = document.createElement('div');
+var span = div.appendChild(document.createElement('span'));
+observer.observe(div, {attributes: true, subtree: true});
+div.removeChild(span);
+setTimeout(function() {
+// By the time this function runs the transient registration should be cleared,
+// so we expect not to be notified of this attribute mutation.
+span.setAttribute('bar', 'baz');
+setTimeout(function() {
+shouldBeFalse('mutationsDelivered');
+finishJSTest();
+}, 0);
+}, 0);
+/script
+script src=""


Copied: branches/chromium/1084/LayoutTests/fast/mutation/transient-gc-crash-expected.txt (from rev 113378, trunk/LayoutTests/fast/mutation/transient-gc-crash-expected.txt) (0 => 113747)

--- branches/chromium/1084/LayoutTests/fast/mutation/transient-gc-crash-expected.txt	(rev 0)
+++ 

[webkit-changes] [113754] trunk/Source/WebCore

[adamk]

Title: [113754] trunk/Source/WebCore








Revision 113754
Author ad...@chromium.org
Date 2012-04-10 12:41:41 -0700 (Tue, 10 Apr 2012)


Log Message
Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528

Reviewed by Kentaro Hara.

Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.

This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.

No new tests, no change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (113753 => 113754)

--- trunk/Source/WebCore/ChangeLog	2012-04-10 19:36:14 UTC (rev 113753)
+++ trunk/Source/WebCore/ChangeLog	2012-04-10 19:41:41 UTC (rev 113754)
@@ -1,3 +1,32 @@
+2012-04-10  Adam Klein  ad...@chromium.org
+
+Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
+https://bugs.webkit.org/show_bug.cgi?id=83528
+
+Reviewed by Kentaro Hara.
+
+Instead of using a run-time call to isActiveNode to determine which
+map to put a Node wrapper in, generate the proper call in the CodeGenerator.
+
+This was originally part of r112318, which got rolled out due to OOM concerns.
+I'm splitting it into smaller pieces so that each can be landed and
+watched for issues seperately.
+
+No new tests, no change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateConstructorCallback): Use new GetDomMapName function to
+figure out which setJSWrapper to call.
+(GenerateNamedConstructorCallback): ditto.
+(GetDomMapFunction): Delegate to GetDomMapName for logic.
+(GetDomMapName): New helper factored out of GetDomMapFunction.
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
+(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
+Assert isActiveNode instead of branching on it.
+* bindings/v8/V8DOMWrapper.h:
+(V8DOMWrapper):
+
 2012-04-10  Luke Macpherson  macpher...@chromium.org
 
 Pass PropertyHandler by reference in CSSStyleApplyProperty.h.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (113753 => 113754)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-10 19:36:14 UTC (rev 113753)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-10 19:41:41 UTC (rev 113754)
@@ -1752,13 +1752,7 @@
 push(@implContent, goto fail;\n);
 }
 
-my $DOMObject = DOMObject;
-if (IsNodeSubType($dataNode)) {
-$DOMObject = DOMNode;
-} elsif ($dataNode-extendedAttributes-{ActiveDOMObject}) {
-$DOMObject = ActiveDOMObject;
-}
-
+my $DOMObject = GetDomMapName($dataNode, $implClassName);
 push(@implContent, END);
 
 V8DOMWrapper::setDOMWrapper(wrapper, info, impl.get());
@@ -1932,14 +1926,7 @@
 push(@implContent, goto fail;\n);
 }
 
-my $DOMObject = DOMObject;
-# A DOMObject that is an ActiveDOMObject and also a DOMNode should be treated as an DOMNode here.
-# setJSWrapperForDOMNode() will look if node is active and choose correct map to add node to.
-if (IsNodeSubType($dataNode)) {
-$DOMObject = DOMNode;
-} elsif ($dataNode-extendedAttributes-{ActiveDOMObject}) {
-$DOMObject = ActiveDOMObject;
-}
+my $DOMObject = GetDomMapName($dataNode, $implClassName);
 push(@implContent, END);
 
 V8DOMWrapper::setDOMWrapper(wrapper, V8${implClassName}Constructor::info, impl.get());
@@ -3190,13 +3177,19 @@
 
 sub GetDomMapFunction
 {
+return get . GetDomMapName(@_) . Map();
+}
+
+sub GetDomMapName
+{
 my $dataNode = shift;
 my $type = shift;
-return getDOMSVGElementInstanceMap() if $type eq SVGElementInstance;
-return getActiveDOMNodeMap() if (IsNodeSubType($dataNode)  

[webkit-changes] [113794] trunk/Source

[adamk]

Title: [113794] trunk/Source








Revision 113794
Author ad...@chromium.org
Date 2012-04-10 17:15:36 -0700 (Tue, 10 Apr 2012)


Log Message
Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389

Reviewed by Kentaro Hara.

Source/_javascript_Core:

* _javascript_Core.order: Remove nonexistent symbols referencing NonNullPassRefPtr.

Source/WTF:

NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.

If someone decides they need this later, they can always revert this patch.

* wtf/PassRefPtr.h:
* wtf/RefPtr.h:
(RefPtr):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.order
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PassRefPtr.h
trunk/Source/WTF/wtf/RefPtr.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (113793 => 113794)

--- trunk/Source/_javascript_Core/ChangeLog	2012-04-11 00:09:45 UTC (rev 113793)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-11 00:15:36 UTC (rev 113794)
@@ -1,3 +1,12 @@
+2012-04-10  Adam Klein  ad...@chromium.org
+
+Remove unused NonNullPassRefPtr from WTF
+https://bugs.webkit.org/show_bug.cgi?id=82389
+
+Reviewed by Kentaro Hara.
+
+* _javascript_Core.order: Remove nonexistent symbols referencing NonNullPassRefPtr.
+
 2012-04-10  Darin Adler  da...@apple.com
 
 Remove unused data member from Lexer class


Modified: trunk/Source/_javascript_Core/_javascript_Core.order (113793 => 113794)

--- trunk/Source/_javascript_Core/_javascript_Core.order	2012-04-11 00:09:45 UTC (rev 113793)
+++ trunk/Source/_javascript_Core/_javascript_Core.order	2012-04-11 00:15:36 UTC (rev 113794)
@@ -268,7 +268,6 @@
 __ZN3JSC14MacroAssembler4jumpENS_22AbstractMacroAssemblerINS_12X86AssemblerEE5LabelE
 __ZN3WTF15deleteAllValuesIPN3JSC4Yarr18PatternDisjunctionELm4EEEvRKNS_6VectorIT_XT0_EEE
 __ZN3WTF15deleteAllValuesIPN3JSC4Yarr14CharacterClassELm0EEEvRKNS_6VectorIT_XT0_EEE
-__ZN3JSC12RegExpObjectC2EPNS_14JSGlobalObjectEPNS_9StructureEN3WTF17NonNullPassRefPtrINS_6RegExpEEE
 __ZN3JSC14ErrorPrototypeC1EPNS_9ExecStateEPNS_14JSGlobalObjectEPNS_9StructureE
 __ZN3JSC14ErrorPrototypeC2EPNS_9ExecStateEPNS_14JSGlobalObjectEPNS_9StructureE
 __ZN3JSC13ErrorInstanceC2EPNS_12JSGlobalDataEPNS_9StructureE
@@ -1035,7 +1034,6 @@
 __ZN3JSC3JIT18emit_op_new_regexpEPNS_11InstructionE
 __ZN3JSC8JSString18getOwnPropertySlotEPNS_9ExecStateERKNS_10IdentifierERNS_12PropertySlotE
 _cti_op_new_regexp
-__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEN3WTF17NonNullPassRefPtrINS_6RegExpEEE
 __ZN3JSCL22stringProtoFuncReplaceEPNS_9ExecStateE
 __ZNK3JSC7JSValue14toThisJSStringEPNS_9ExecStateE
 __ZN3JSC9ExecState8argumentEi


Modified: trunk/Source/WTF/ChangeLog (113793 => 113794)

--- trunk/Source/WTF/ChangeLog	2012-04-11 00:09:45 UTC (rev 113793)
+++ trunk/Source/WTF/ChangeLog	2012-04-11 00:15:36 UTC (rev 113794)
@@ -1,3 +1,19 @@
+2012-04-10  Adam Klein  ad...@chromium.org
+
+Remove unused NonNullPassRefPtr from WTF
+https://bugs.webkit.org/show_bug.cgi?id=82389
+
+Reviewed by Kentaro Hara.
+
+NonNullPassRefPtr seems to be unused since JSC allocation was
+restructured in r84052.
+
+If someone decides they need this later, they can always revert this patch.
+
+* wtf/PassRefPtr.h:
+* wtf/RefPtr.h:
+(RefPtr):
+
 2012-04-10  Patrick Gansterer  par...@webkit.org
 
 [CMake] Enable USE_FOLDERS property


Modified: trunk/Source/WTF/wtf/PassRefPtr.h (113793 => 113794)

--- trunk/Source/WTF/wtf/PassRefPtr.h	2012-04-11 00:09:45 UTC (rev 113793)
+++ trunk/Source/WTF/wtf/PassRefPtr.h	2012-04-11 00:15:36 UTC (rev 113794)
@@ -92,63 +92,6 @@
 mutable T* m_ptr;
 };
 
-// NonNullPassRefPtr: Optimized for passing non-null pointers. A NonNullPassRefPtr
-// begins life non-null, and can only become null through a call to leakRef()
-// or clear().
-
-// FIXME: NonNullPassRefPtr could just inherit from PassRefPtr. However,
-// if we use inheritance, GCC's optimizer fails to realize that destruction
-// of a released NonNullPassRefPtr is a no-op. So, for now, just copy the
-// most important code from PassRefPtr.
-templatetypename T class NonNullPassRefPtr {
-public:
-NonNullPassRefPtr(T* ptr)
-: m_ptr(ptr)
-{
-ASSERT(m_ptr);
-m_ptr-ref();
-}
-
-templatetypename U NonNullPassRefPtr(const RefPtrU o)
-: m_ptr(o.get())
-{
-ASSERT(m_ptr);
-m_ptr-ref();
-}
-
-NonNullPassRefPtr(const NonNullPassRefPtr o)
-: m_ptr(o.leakRef())
-{
-ASSERT(m_ptr);
-}
-
-templatetypename U NonNullPassRefPtr(const NonNullPassRefPtrU o)
-: m_ptr(o.leakRef())
-{
-ASSERT(m_ptr);
-}
-
-templatetypename U NonNullPassRefPtr(const PassRefPtrU o)
- 

[webkit-changes] [113806] trunk/Source/WebCore

[adamk]

Title: [113806] trunk/Source/WebCore








Revision 113806
Author ad...@chromium.org
Date 2012-04-10 18:57:03 -0700 (Tue, 10 Apr 2012)


Log Message
Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
https://bugs.webkit.org/show_bug.cgi?id=83615

Reviewed by Adam Barth.

Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).

No new tests, no expected change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetDomMapName):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
* bindings/v8/DOMDataStore.h:
(DOMDataStore):
* bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
(StaticDOMDataStore):
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjects):
* bindings/v8/V8DOMMap.h:
(WebCore):
* bindings/v8/V8DOMWrapper.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/DOMDataStore.h
trunk/Source/WebCore/bindings/v8/ScopedDOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.h
trunk/Source/WebCore/bindings/v8/V8DOMMap.cpp
trunk/Source/WebCore/bindings/v8/V8DOMMap.h
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (113805 => 113806)

--- trunk/Source/WebCore/ChangeLog	2012-04-11 01:46:49 UTC (rev 113805)
+++ trunk/Source/WebCore/ChangeLog	2012-04-11 01:57:03 UTC (rev 113806)
@@ -1,3 +1,37 @@
+2012-04-10  Adam Klein  ad...@chromium.org
+
+Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
+https://bugs.webkit.org/show_bug.cgi?id=83615
+
+Reviewed by Adam Barth.
+
+Historically, these wrappers had their own map, but there doesn't seem
+to be any particular reason for this. The V8GCController doesn't
+treat them specially (which is the reason you normally need a separate
+wrapper map).
+
+No new tests, no expected change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GetDomMapName):
+* bindings/v8/DOMDataStore.cpp:
+(WebCore::DOMDataStore::DOMDataStore):
+(WebCore::DOMDataStore::getDOMWrapperMap):
+* bindings/v8/DOMDataStore.h:
+(DOMDataStore):
+* bindings/v8/ScopedDOMDataStore.cpp:
+(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
+(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
+* bindings/v8/StaticDOMDataStore.cpp:
+(WebCore::StaticDOMDataStore::StaticDOMDataStore):
+* bindings/v8/StaticDOMDataStore.h:
+(StaticDOMDataStore):
+* bindings/v8/V8DOMMap.cpp:
+(WebCore::removeAllDOMObjects):
+* bindings/v8/V8DOMMap.h:
+(WebCore):
+* bindings/v8/V8DOMWrapper.cpp:
+
 2012-04-10  Noel Gordon  noel.gor...@gmail.com
 
 [Qt] Separate image encoding from dataURL construction


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (113805 => 113806)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-11 01:46:49 UTC (rev 113805)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-11 01:57:03 UTC (rev 113806)
@@ -3185,7 +3185,6 @@
 my $dataNode = shift;
 my $type = shift;
 
-return DOMSVGElementInstance if $type eq SVGElementInstance;
 return ActiveDOMNode if (IsNodeSubType($dataNode)  $dataNode-extendedAttributes-{ActiveDOMObject});
 return DOMNode if IsNodeSubType($dataNode);
 return ActiveDOMObject if $dataNode-extendedAttributes-{ActiveDOMObject};


Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp (113805 => 113806)

--- trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp	2012-04-11 01:46:49 UTC (rev 113805)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp	2012-04-11 01:57:03 UTC (rev 113806)
@@ -89,9 +89,6 @@
 , m_activeDomNodeMap(0)
 , m_domObjectMap(0)
 , m_activeDomObjectMap(0)
-#if ENABLE(SVG)
-, m_domSvgElementInstanceMap(0)
-#endif
 {
 }
 
@@ -115,10 +112,6 @@
 return m_domObjectMap;
 case ActiveDOMObjectMap:
 return m_activeDomObjectMap;
-#if ENABLE(SVG)
-case DOMSVGElementInstanceMap:
-return m_domSvgElementInstanceMap;
-#endif
 }
 
 ASSERT_NOT_REACHED();
@@ -165,15 +158,4 @@
 node-deref(); // Nobody overrides Node::deref so it's safe
 }
 
-#if ENABLE(SVG)
-
-void DOMDataStore::weakSVGElementInstanceCallback(v8::Persistentv8::Value v8Object, void* domObject)
-{
-v8::HandleScope scope;
-