[webkit-changes] [117111] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [117111] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Revision 117111
Author carycl...@google.com
Date 2012-05-15 12:03:54 -0700 (Tue, 15 May 2012)
Log Message
Add self as committer-but-not-reviewer
Modified Paths
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (117110 => 117111)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-05-15 18:54:16 UTC (rev 117110)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-05-15 19:03:54 UTC (rev 117111)
@@ -229,6 +229,7 @@
Committer("Dominic Mazzoni", ["dmazz...@google.com", "dmazz...@chromium.org"], "dmazzoni"),
Committer("Drew Wilson", "atwil...@chromium.org", "atwilson"),
Committer("Eli Fidler", ["e...@staikos.net", "efid...@rim.com"], "efidler"),
+Committer("Elliot Poger", ["epo...@chromium.org", "epo...@google.com"], "epoger"),
Committer("Emil A Eklund", "e...@chromium.org", "eae"),
Committer("Erik Arvidsson", "a...@chromium.org", "arv"),
Committer("Eric Roman", "ero...@chromium.org", "eroman"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110860] trunk/LayoutTests
Title: [110860] trunk/LayoutTests Revision 110860 Author carycl...@google.com Date 2012-03-15 10:32:08 -0700 (Thu, 15 Mar 2012) Log Message migrate Yang Guo's expectations from chromium to webkit https://bugs.webkit.org/show_bug.cgi?id=81026 Unreviewed test_expectations. Patch by Elliot Poger on 2012-03-15 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110859 => 110860) --- trunk/LayoutTests/ChangeLog 2012-03-15 17:28:53 UTC (rev 110859) +++ trunk/LayoutTests/ChangeLog 2012-03-15 17:32:08 UTC (rev 110860) @@ -1,3 +1,12 @@ +2012-03-15 Elliot Poger + +migrate Yang Guo's expectations from chromium to webkit +https://bugs.webkit.org/show_bug.cgi?id=81026 + +Unreviewed test_expectations. + +* platform/chromium/test_expectations.txt: + 2012-03-14 Pavel Podivilov Web Inspector: extract CompilerScriptMapping from RawSourceCode. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110859 => 110860) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-15 17:28:53 UTC (rev 110859) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-15 17:32:08 UTC (rev 110860) @@ -3913,3 +3913,15 @@ BUGWK81145 LION : fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html = TEXT BUGWK81145 LION : fast/events/platform-wheelevent-paging-y-in-scrolling-page.html = TEXT BUGWK81145 LION : fast/events/scrollbar-double-click.html = TEXT + +// Migrated from chromium's downstream test_expectations +BUGYANGGUO LINUX X86_64 : fast/repaint/moving-shadow-on-container.html = TEXT +BUGYANGGUO LINUX X86_64 : fast/repaint/moving-shadow-on-path.html = TEXT +BUGYANGGUO LINUX X86_64 : svg/css/stars-with-shadow.html = TEXT +BUGYANGGUO MAC : fast/repaint/moving-shadow-on-container.html = TEXT +BUGYANGGUO MAC : fast/repaint/moving-shadow-on-path.html = TEXT +BUGYANGGUO MAC : svg/css/stars-with-shadow.html = TEXT +BUGYANGGUO WIN : fast/repaint/moving-shadow-on-container.html = TEXT +BUGYANGGUO WIN : fast/repaint/moving-shadow-on-path.html = TEXT +BUGYANGGUO WIN : svg/css/stars-with-shadow.html = TEXT + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109604] trunk/LayoutTests
Title: [109604] trunk/LayoutTests Revision 109604 Author carycl...@google.com Date 2012-03-02 12:58:54 -0800 (Fri, 02 Mar 2012) Log Message new baselines for Skia shadows Unreviewed rebaselining. * platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: * platform/chromium-win-xp/svg/css: Added. * platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added. * platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png: * platform/chromium-win/fast/transforms/shadows-expected.png: * platform/chromium-win/svg/css/group-with-shadow-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png trunk/LayoutTests/platform/chromium-win/fast/transforms/shadows-expected.png trunk/LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.png trunk/LayoutTests/platform/chromium-win-vista/svg/css/group-with-shadow-expected.png Added Paths trunk/LayoutTests/platform/chromium-win-xp/svg/css/ trunk/LayoutTests/platform/chromium-win-xp/svg/css/group-with-shadow-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (109603 => 109604) --- trunk/LayoutTests/ChangeLog 2012-03-02 20:54:03 UTC (rev 109603) +++ trunk/LayoutTests/ChangeLog 2012-03-02 20:58:54 UTC (rev 109604) @@ -1,3 +1,17 @@ +2012-03-02 Mike Reed + +new baselines for Skia shadows + +Unreviewed rebaselining. + +* platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: +* platform/chromium-win-xp/svg/css: Added. +* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added. +* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png: +* platform/chromium-win/fast/transforms/shadows-expected.png: +* platform/chromium-win/svg/css/group-with-shadow-expected.png: +* platform/chromium/test_expectations.txt: + 2012-03-02 Adam Klein Unreviewed gardening. Suppress an inspector test timing out after r109561. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109603 => 109604) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-02 20:54:03 UTC (rev 109603) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-02 20:58:54 UTC (rev 109604) @@ -4229,12 +4229,6 @@ BUGV8_1973 : fast/js/caller-property.html = TEXT -// Failures after Skia roll to 3303. Working with reed to figure out if -// they just need a rebaseline. -BUGADAMK WIN : fast/repaint/shadow-multiple-vertical.html = IMAGE -BUGADAMK WIN : fast/transforms/shadows.html = IMAGE -BUGADAMK WIN : svg/css/group-with-shadow.svg = IMAGE - // FIXME: sort these in next to the non-virtual expectations. BUGWK79679 DEBUG SLOW : platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html = PASS BUGWK63933 : platform/chromium/virtual/gpu/fast/canvas/canvas-webkitLineDash.html = FAIL Modified: trunk/LayoutTests/platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/transforms/shadows-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win-vista/svg/css/group-with-shadow-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-win-xp/svg/css/group-with-shadow-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win-xp/svg/css/group-with-shadow-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [107114] trunk/LayoutTests
Title: [107114] trunk/LayoutTests Revision 107114 Author carycl...@google.com Date 2012-02-08 12:11:28 -0800 (Wed, 08 Feb 2012) Log Message Unreviewed rebaselines for vertical text tests. See https://bugs.webkit.org/show_bug.cgi?id=78120 * platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: [...] * platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/dynamic/text-combine-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/fallback-orientation-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-text-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-text-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/vertical-baseline-alignment-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/dynamic/text-combine-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/international/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/border-vertical-lr-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/broken-ideographic-font-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-lr-text-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby
[webkit-changes] [107097] trunk/Source/WebCore
Title: [107097] trunk/Source/WebCore Revision 107097 Author carycl...@google.com Date 2012-02-08 09:15:42 -0800 (Wed, 08 Feb 2012) Log Message [Skia Mac] Make misspelling underline dots unclipped https://bugs.webkit.org/show_bug.cgi?id=78117 http://code.google.com/p/chromium/issues/detail?id=113154 Reviewed by Stephen White. No new tests. Existing layout tests cover this. As is done on the CoreGraphics Mac platform, adjust the underline width to remove partial dots, not including the trailing transparent pixel column. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLineForTextChecking): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (107096 => 107097) --- trunk/Source/WebCore/ChangeLog 2012-02-08 17:05:08 UTC (rev 107096) +++ trunk/Source/WebCore/ChangeLog 2012-02-08 17:15:42 UTC (rev 107097) @@ -1,3 +1,20 @@ +2012-02-08 Cary Clark + +[Skia Mac] Make misspelling underline dots unclipped +https://bugs.webkit.org/show_bug.cgi?id=78117 +http://code.google.com/p/chromium/issues/detail?id=113154 + +Reviewed by Stephen White. + +No new tests. Existing layout tests cover this. + +As is done on the CoreGraphics Mac platform, adjust the +underline width to remove partial dots, not including the +trailing transparent pixel column. + +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::GraphicsContext::drawLineForTextChecking): + 2012-02-08 Pavel Feldman Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted. Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (107096 => 107097) --- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-02-08 17:05:08 UTC (rev 107096) +++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2012-02-08 17:15:42 UTC (rev 107097) @@ -721,6 +721,11 @@ SkScalar originX = WebCoreFloatToSkScalar(pt.x()); #if PLATFORM(CHROMIUM) && OS(DARWIN) SkScalar originY = WebCoreFloatToSkScalar(pt.y()); +// Make sure to draw only complete dots. +int rowPixels = misspellBitmap->width(); +float widthMod = fmodf(width, rowPixels); +if (rowPixels - widthMod > 1) +width -= widthMod; #else // Offset it vertically by 1 so that there's some space under the text. SkScalar originY = WebCoreFloatToSkScalar(pt.y()) + 1; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105468] trunk
Title: [105468] trunk Revision 105468 Author carycl...@google.com Date 2012-01-19 17:47:41 -0800 (Thu, 19 Jan 2012) Log Message [Skia Mac] Match style of platform error underline for misspellings https://bugs.webkit.org/show_bug.cgi?id=76556 Reviewed by Stephen White. Source/WebCore: Add Darwin-specific code in Skia to draw the error underline so that it matches the CoreGraphics style. Many existing layout tests inadvertantly trigger the misspelling underline by including the word 'foo' in an editable field. Those tests are temporarily suppressed separately in an edit to test_expectations.txt. * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLineForTextChecking): LayoutTests: Suppress editing tests with misspellings, since the error underline is drawn differently. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (105467 => 105468) --- trunk/LayoutTests/ChangeLog 2012-01-20 01:34:24 UTC (rev 105467) +++ trunk/LayoutTests/ChangeLog 2012-01-20 01:47:41 UTC (rev 105468) @@ -1,3 +1,15 @@ +2012-01-19 Cary Clark + +[Skia Mac] Match style of platform error underline for misspellings +https://bugs.webkit.org/show_bug.cgi?id=76556 + +Reviewed by Stephen White. + +Suppress editing tests with misspellings, since the error underline +is drawn differently. + +* platform/chromium/test_expectations.txt: + 2012-01-19 Stephen Chenney [Chromium] A Skia roll will break some tests - marking as expected Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (105467 => 105468) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-20 01:34:24 UTC (rev 105467) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-20 01:47:41 UTC (rev 105468) @@ -3916,5 +3916,87 @@ // RenderSVGRoot now reports a correct size. BUGWK76646 : svg/foreignObject/text-tref-02-b.svg = TEXT +// Change error (misspelling) underlines from Windows look to Mac look. +BUG_CARYCLARK MAC : editing/deleting/delete-3928305-fix.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-3959464-fix.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-and-undo.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-block-contents-003.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-contiguous-ws-001.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-tab-002.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-tab-003.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-to-select-table.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-trailing-ws-002.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-ws-fixup-001.html = IMAGE +BUG_CARYCLARK MAC : editing/deleting/delete-ws-fixup-002.html = IMAGE +BUG_CARYCLARK MAC : editing/execCommand/5569741.html = IMAGE +BUG_CARYCLARK MAC : editing/execCommand/insert-list-and-stitch.html = IMAGE +BUG_CARYCLARK MAC : editing/execCommand/insertHorizontalRule.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/5418891.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/editing-empty-divs.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-br-004.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-br-005.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-br-007.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-007.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-012.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-013.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-014.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-015.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-016.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-017.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-018.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-019.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-020.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-022.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-025.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-div-027.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-paragraph-02.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-paragraph-03.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-tab-002.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-tab-003.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/insert-text-with-newlines.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/paragraph-separator-01.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/paragraph-separator-02.html = IMAGE +BUG_CARYCLARK MAC : editing/inserting/pa
[webkit-changes] [104173] trunk/Source/WebCore
Title: [104173] trunk/Source/WebCore
Revision 104173
Author carycl...@google.com
Date 2012-01-05 10:08:58 -0800 (Thu, 05 Jan 2012)
Log Message
[Skia Mac] Rounded bezel style button needs one more local graphics context to scale
https://bugs.webkit.org/show_bug.cgi?id=75623
http://code.google.com/p/chromium/issues/detail?id=108749
In paintButton(), the local context is set up first, and later the context is
scaled if there's a zoomFactor. Skia creates the CoreGraphics context to draw the
button into without that scale factor. To fix this, another local context is added
after the parameter context scale, before the button draw. The first local context
is still required to restore the parameter context state.
Reviewed by Stephen White.
* platform/chromium/ThemeChromiumMac.mm:
(WebCore::paintButton):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ThemeChromiumMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (104172 => 104173)
--- trunk/Source/WebCore/ChangeLog 2012-01-05 17:52:42 UTC (rev 104172)
+++ trunk/Source/WebCore/ChangeLog 2012-01-05 18:08:58 UTC (rev 104173)
@@ -1,3 +1,20 @@
+2012-01-05 Cary Clark
+
+[Skia Mac] Rounded bezel style button needs one more local graphics context to scale
+https://bugs.webkit.org/show_bug.cgi?id=75623
+http://code.google.com/p/chromium/issues/detail?id=108749
+
+In paintButton(), the local context is set up first, and later the context is
+scaled if there's a zoomFactor. Skia creates the CoreGraphics context to draw the
+button into without that scale factor. To fix this, another local context is added
+after the parameter context scale, before the button draw. The first local context
+is still required to restore the parameter context state.
+
+Reviewed by Stephen White.
+
+* platform/chromium/ThemeChromiumMac.mm:
+(WebCore::paintButton):
+
2012-01-05 Alexis Menard
getComputedStyle for background is not implemented.
Modified: trunk/Source/WebCore/platform/chromium/ThemeChromiumMac.mm (104172 => 104173)
--- trunk/Source/WebCore/platform/chromium/ThemeChromiumMac.mm 2012-01-05 17:52:42 UTC (rev 104172)
+++ trunk/Source/WebCore/platform/chromium/ThemeChromiumMac.mm 2012-01-05 18:08:58 UTC (rev 104173)
@@ -595,6 +595,7 @@
}
{
+LocalCurrentGraphicsContext localContext(context);
FocusIndicationFix::ScopedFixer fix;
[buttonCell drawWithFrame:NSRect(inflatedRect) inView:FlippedView()];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [102454] trunk
Title: [102454] trunk
Revision 102454
Author carycl...@google.com
Date 2011-12-09 08:18:37 -0800 (Fri, 09 Dec 2011)
Log Message
Source/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118
Reviewed by Adam Barth.
* DEPS:
Tools: layout_test update to accommodate new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(get):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_graphics_type):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (102453 => 102454)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-09 16:18:37 UTC (rev 102454)
@@ -1,3 +1,12 @@
+2011-12-09 Cary Clark
+
+Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
+https://bugs.webkit.org/show_bug.cgi?id=74118
+
+Reviewed by Adam Barth.
+
+* DEPS:
+
2011-12-08 Fady Samuel
[Chromium] Enable viewport metatag
Modified: trunk/Source/WebKit/chromium/DEPS (102453 => 102454)
--- trunk/Source/WebKit/chromium/DEPS 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Source/WebKit/chromium/DEPS 2011-12-09 16:18:37 UTC (rev 102454)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '113603',
+ 'chromium_rev': '113807',
'nacl_svn': 'http://src.chromium.org/native_client/trunk',
'nacl_rev': '7169',
}
Modified: trunk/Tools/ChangeLog (102453 => 102454)
--- trunk/Tools/ChangeLog 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/ChangeLog 2011-12-09 16:18:37 UTC (rev 102454)
@@ -1,3 +1,18 @@
+2011-12-09 Cary Clark
+
+layout_test update to accommodate new use_skia=1 default on Chromium-Mac
+https://bugs.webkit.org/show_bug.cgi?id=74118
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
+(get):
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+(ChromiumMacPort.__init__):
+* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
+(ChromiumMacPortTest.test_versions):
+(ChromiumMacPortTest.test_graphics_type):
+
2011-12-09 Tor Arne Vestbø
[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (102453 => 102454)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-12-09 16:18:37 UTC (rev 102454)
@@ -42,7 +42,7 @@
elif platform.startswith('linux'):
port_name = 'chromium-gpu-linux'
elif platform == 'darwin':
-port_name = 'chromium-gpu-cg-mac'
+port_name = 'chromium-gpu-mac'
else:
raise NotImplementedError('unsupported platform: %s' % platform)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py (102453 => 102454)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py 2011-12-09 16:18:37 UTC (rev 102454)
@@ -112,7 +112,7 @@
def __init__(self, host, port_name=None, os_version_string=None, **kwargs):
# We're a little generic here because this code is reused by the
# 'google-chrome' port as well as the 'mock-' and 'dryrun-' ports.
-port_name = port_name or 'chromium-cg-mac'
+port_name = port_name or 'chromium-mac'
chromium.ChromiumPort.__init__(self, host, port_name=port_name, **kwargs)
if port_name.endswith('-mac'):
self._version = mac.os_version(os_version_string, self.SUPPORTED_OS_VERSIONS)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py (102453 => 102454)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py 2011-12-09 15:19:05 UTC (rev 102453)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py 2011-12-09 16:18:37 UTC (rev 102454)
@@ -46,26 +46,26 @@
self.assertEquals(expected, port.name())
def test_versions(self):
-self.assertTrue(self.make_port().name() in ('chromium-cg-mac-leopard', 'chromium-cg-mac-snowleopard', 'chromium-cg-mac-lion', 'chromi
[webkit-changes] [101075] trunk/LayoutTests
Title: [101075] trunk/LayoutTests
Revision 101075
Author carycl...@google.com
Date 2011-11-23 06:09:40 -0800 (Wed, 23 Nov 2011)
Log Message
Unreviewed rebaselining: update incorrectly generated baseline images
that masked http://crbug.com/105025 ('Regression: WebGL content flipped
with use_skia enabled on mac.')
Marking these tests as expected to fail until we fix the underlying bug.
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Removed Paths
trunk/LayoutTests/platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (101074 => 101075)
--- trunk/LayoutTests/ChangeLog 2011-11-23 13:58:02 UTC (rev 101074)
+++ trunk/LayoutTests/ChangeLog 2011-11-23 14:09:40 UTC (rev 101075)
@@ -1,3 +1,15 @@
+2011-11-23 Cary Clark
+
+Unreviewed rebaselining: update incorrectly generated baseline images
+that masked http://crbug.com/105025 ('Regression: WebGL content flipped
+with use_skia enabled on mac.')
+
+Marking these tests as expected to fail until we fix the underlying bug.
+
+* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
+* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
+* platform/chromium/test_expectations.txt:
+
2011-11-18 Pavel Podivilov
Web Inspector: add integration test for compiler source maps.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101074 => 101075)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 13:58:02 UTC (rev 101074)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-23 14:09:40 UTC (rev 101075)
@@ -3844,3 +3844,7 @@
BUGWK72761 : accessibility/anonymous-render-block-in-continuation-causes-crash.html = PASS TIMEOUT
BUGWK72904 XP : http/tests/media/video-served-as-text.html = PASS TEXT
+
+BUGCR105025 MAC CPU GPU : fast/canvas/webgl/css-webkit-canvas.html = IMAGE
+BUGCR105025 MAC CPU GPU : fast/canvas/webgl/css-webkit-canvas-repaint.html = IMAGE
+
Deleted: trunk/LayoutTests/platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png
(Binary files differ)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100917] trunk/LayoutTests
Title: [100917] trunk/LayoutTests Revision 100917 Author carycl...@google.com Date 2011-11-21 08:13:01 -0800 (Mon, 21 Nov 2011) Log Message Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard. * platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: * platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png: * platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png: * platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added. * platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added. * platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: * platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: * platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png: * platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100916 => 100917) --- trunk/LayoutTests/ChangeLog 2011-11-21 15:47:35 UTC (rev 100916) +++ trunk/LayoutTests/ChangeLog 2011-11-21 16:13:01 UTC (rev 100917) @@ -1,3 +1,18 @@ +2011-11-21 Cary Clark + +Unreviewed rebaselining: Re-enable most layout tests on chromium-mac-leopard. + +* platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: +* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png: +* platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png: +* platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added. +* platform/chromium-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added. +* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: +* platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: +* platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png: +* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: +* platform/chromium/test_expectations.txt: + 2011-11-21 Raphael Kubo da Costa [EFL] Add more appcache functions to ewk_settings. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100916 => 100917) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-21 15:47:35 UTC (rev 100916) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-21 16:13:01 UTC (rev 100917) @@ -3544,25 +3544,6 @@ // Tests that are known to exhibit IMAGE or IMAGE+TEXT failures on Mac10.5 with CPU-Skia graphics. BUGWK68437 LEOPARD CPU : printing/return-from-printing-mode.html = IMAGE -// Temporarily allowing many failures for Mac10.5 with Skia graphics. -// epoger promises to remove these expectations by 27 October 2011. -BUGWK68270 LEOPARD CPU GPU : animations = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : css1 = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : css3 = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : editing = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : fast = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : fonts = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : http = PASS FAIL -BUGWK68270 LEOPARD CPU : media = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : platform = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : plugins = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : svg = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : tables = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : transforms = PASS FAIL -BUGWK68270 LEOPARD CPU GPU : transitions = PASS FAIL - // These should fall under BUGWK6827
[webkit-changes] [100283] trunk
Title: [100283] trunk Revision 100283 Author carycl...@google.com Date 2011-11-15 08:17:25 -0800 (Tue, 15 Nov 2011) Log Message [chromium-mac] Enable vertical text using Skia https://bugs.webkit.org/show_bug.cgi?id=72137 Source/WebCore: Use Skia to draw vertical text. This is much faster and has higher fidelity than the old method of drawing text on a path. The graphics context passed to Skia has been rotated 90 degrees but the character advances have not, so it is necessary to unrotate the canvas, and re-rotate the positions. This generates correct output (or, at least, consistent with Chromium CG on Mac) for all vertical text tests, one of which is mentioned below. Reviewed by Stephen White. Test: fast/writing-mode/text-orientation-basic.html * platform/graphics/skia/FontSkia.cpp: (WebCore::setupPaint): (WebCore::Font::drawGlyphs): LayoutTests: Ignore vertical text tests on Skia on Mac for now. Reviewed by Stephen White. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (100282 => 100283) --- trunk/LayoutTests/ChangeLog 2011-11-15 16:14:39 UTC (rev 100282) +++ trunk/LayoutTests/ChangeLog 2011-11-15 16:17:25 UTC (rev 100283) @@ -1,3 +1,14 @@ +2011-11-15 Cary Clark + +[chromium-mac] Enable vertical text using Skia +https://bugs.webkit.org/show_bug.cgi?id=72137 + +Ignore vertical text tests on Skia on Mac for now. + +Reviewed by Stephen White. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Eric Carlson media-blocked-by-willsendrequest.html is flaky Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100282 => 100283) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 16:14:39 UTC (rev 100282) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 16:17:25 UTC (rev 100283) @@ -3886,6 +3886,37 @@ BUGWK59552 MAC DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH +// use Skia to draw vertical text directly instead of text-on-path +BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-p.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/dynamic/text-combine.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-clear.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/repaint-across-writing-mode-boundary.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/international/vertical-text-glyph-test.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/justify-ideograph-vertical.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/Kusa-Makura-background-canvas.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/border-vertical-lr.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/broken-ideographic-font.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/fallback-orientation.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-lr-text.html = IMAGE +BUG_CARYCLARK LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD CPU RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-rl-text.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-lr.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-rl.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/text-orientation-basic.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-align-table-baseline.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-baseline-alignment.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-font-fallback.html = IMAGE + BUGWK72271 MAC DEBUG : fast/loader/_javascript_-url-in-embed.html = PASS CRASH BUGWK72272 WIN : security/crypto-random-values-types.html = TEXT PASS Modified: trunk/Source/WebCore/ChangeLog (100282 =>
[webkit-changes] [97971] trunk/Source/WebCore
Title: [97971] trunk/Source/WebCore
Revision 97971
Author carycl...@google.com
Date 2011-10-20 06:18:51 -0700 (Thu, 20 Oct 2011)
Log Message
[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124
Reviewed by Adam Barth.
The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.
The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.
The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.
I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.
With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:
editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97970 => 97971)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 13:05:21 UTC (rev 97970)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 13:18:51 UTC (rev 97971)
@@ -1,3 +1,41 @@
+2011-10-20 Cary Clark
+
+[Chromium Skia on Mac] Improve focus ring
+https://bugs.webkit.org/show_bug.cgi?id=70124
+
+Reviewed by Adam Barth.
+
+The focus ring code formerly outset the bounds of
+the component rectangles by fractional amounts. Because
+the rectangles are SkIRect (integer based), the fractional
+outset had no effect.
+
+The equivalent code in GraphicsContextMac.mm computes
+the curve radius and rectangle outset with integers, so
+the use of floats in Skia's case, besides not working,
+is unnecessary.
+
+The Skia code also failed to take the offset into account.
+In LayoutTests, the focus rings either have an offset of
+0 or 2. The CoreGraphics code increases the ring's rectangles
+by the offset, then passes the result to wkDrawFocusRing.
+
+I did not find any documentation about how wkDrawFocusRing
+further inflates the focus ring, but empirically I determined
+that adding 2 to the offset generated rings with identical
+outer diameters.
+
+With these adjustments, the layout tests generate focus rings
+in the Skia on Mac case that match the coverage of the
+Chromium CG-based platform, in particular, matching:
+
+editing/inserting/editable-inline-element.html
+editing/selection/3690703-2.html
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::getFocusRingOutset):
+(WebCore::GraphicsContext::drawFocusRing):
+
2011-10-20 Zoltan Herczeg
Improve NEON based GaussianBlur
Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (97970 => 97971)
--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-20 13:05:21 UTC (rev 97970)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-20 13:18:51 UTC (rev 97971)
@@ -538,16 +538,16 @@
#endif
}
-static inline SkScalar getFocusRingOutset()
+static inline int getFocusRingOutset(int offset)
{
#if PLATFORM(CHROMIUM) && OS(DARWIN)
-return 0.75f;
+return offset + 2;
#else
-return 0.5f;
+return 0;
#endif
}
-void GraphicsContext::drawFocusRing(const Vector& rects, int width, int /* offset */, const Color& color)
+void GraphicsContext::drawFocusRing(const Vector& rects, int width, int offset, const Color& color)
{
if (paintingDisabled())
return;
@@ -557,7 +557,7 @@
return;
SkRegion focusRingRegion;
-const SkScalar focusRingOutset = getFocusRingOutset();
+const int focusRingOutset = getFocusRingOutset(offset);
for (unsigned i = 0; i < rectCount; i++) {
SkIRect r = rects[i];
r.inset(-focusRingOutset, -focusRingOutset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97519] trunk/Source/WebCore
Title: [97519] trunk/Source/WebCore
Revision 97519
Author carycl...@google.com
Date 2011-10-14 15:24:24 -0700 (Fri, 14 Oct 2011)
Log Message
[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124
Reviewed by Eric Seidel.
The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.
The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.
The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.
I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.
With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:
editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97518 => 97519)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 22:17:48 UTC (rev 97518)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 22:24:24 UTC (rev 97519)
@@ -1,3 +1,41 @@
+2011-10-14 Cary Clark
+
+[Chromium Skia on Mac] Improve focus ring
+https://bugs.webkit.org/show_bug.cgi?id=70124
+
+Reviewed by Eric Seidel.
+
+The focus ring code formerly outset the bounds of
+the component rectangles by fractional amounts. Because
+the rectangles are SkIRect (integer based), the fractional
+outset had no effect.
+
+The equivalent code in GraphicsContextMac.mm computes
+the curve radius and rectangle outset with integers, so
+the use of floats in Skia's case, besides not working,
+is unnecessary.
+
+The Skia code also failed to take the offset into account.
+In LayoutTests, the focus rings either have an offset of
+0 or 2. The CoreGraphics code increases the ring's rectangles
+by the offset, then passes the result to wkDrawFocusRing.
+
+I did not find any documentation about how wkDrawFocusRing
+further inflates the focus ring, but empirically I determined
+that adding 2 to the offset generated rings with identical
+outer diameters.
+
+With these adjustments, the layout tests generate focus rings
+in the Skia on Mac case that match the coverage of the
+Chromium CG-based platform, in particular, matching:
+
+editing/inserting/editable-inline-element.html
+editing/selection/3690703-2.html
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::getFocusRingOutset):
+(WebCore::GraphicsContext::drawFocusRing):
+
2011-10-14 Chang Shu
[Qt] Enable fullscreen api on Qt
Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (97518 => 97519)
--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-14 22:17:48 UTC (rev 97518)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-14 22:24:24 UTC (rev 97519)
@@ -538,16 +538,16 @@
#endif
}
-static inline SkScalar getFocusRingOutset()
+static inline int getFocusRingOutset(int offset)
{
#if PLATFORM(CHROMIUM) && OS(DARWIN)
-return 0.75f;
+return offset + 2;
#else
-return 0.5f;
+return 0;
#endif
}
-void GraphicsContext::drawFocusRing(const Vector& rects, int width, int /* offset */, const Color& color)
+void GraphicsContext::drawFocusRing(const Vector& rects, int width, int offset, const Color& color)
{
if (paintingDisabled())
return;
@@ -557,7 +557,7 @@
return;
SkRegion focusRingRegion;
-const SkScalar focusRingOutset = getFocusRingOutset();
+const int focusRingOutset = getFocusRingOutset(offset);
for (unsigned i = 0; i < rectCount; i++) {
SkIRect r = rects[i];
r.inset(-focusRingOutset, -focusRingOutset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97257] trunk/Source/WebKit/chromium
Title: [97257] trunk/Source/WebKit/chromium
Revision 97257
Author carycl...@google.com
Date 2011-10-12 06:31:03 -0700 (Wed, 12 Oct 2011)
Log Message
[Chromium] Prevent fallback fonts from purging while measuring
https://bugs.webkit.org/show_bug.cgi?id=69855
Reviewed by Eric Seidel.
When Chrome computes the page width, an international page
may bring in a fallback font. FontCache::getCachedFontData
expects the font cache to be locked, so the measure path
needs to include an instance of FontCachePurgePreventer.
Adding FontCachePurgePreventer suppresses a debug-time assert
when running PageCycler over international tests.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::contentsPreferredWidth):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97256 => 97257)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-12 13:23:19 UTC (rev 97256)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-12 13:31:03 UTC (rev 97257)
@@ -1,3 +1,21 @@
+2011-10-12 Cary Clark
+
+[Chromium] Prevent fallback fonts from purging while measuring
+https://bugs.webkit.org/show_bug.cgi?id=69855
+
+Reviewed by Eric Seidel.
+
+When Chrome computes the page width, an international page
+may bring in a fallback font. FontCache::getCachedFontData
+expects the font cache to be locked, so the measure path
+needs to include an instance of FontCachePurgePreventer.
+
+Adding FontCachePurgePreventer suppresses a debug-time assert
+when running PageCycler over international tests.
+
+* src/WebFrameImpl.cpp:
+(WebKit::WebFrameImpl::contentsPreferredWidth):
+
2011-10-12 Pavel Podivilov
Unreviewed, CCThreadTest.startPostAndWaitOnCondition is flaky on linux.
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (97256 => 97257)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-10-12 13:23:19 UTC (rev 97256)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-10-12 13:31:03 UTC (rev 97257)
@@ -86,6 +86,7 @@
#include "Editor.h"
#include "EventHandler.h"
#include "FocusController.h"
+#include "FontCache.h"
#include "FormState.h"
#include "FrameLoadRequest.h"
#include "FrameLoader.h"
@@ -579,8 +580,11 @@
int WebFrameImpl::contentsPreferredWidth() const
{
-if (m_frame->document() && m_frame->document()->renderView())
+if (m_frame->document() && m_frame->document()->renderView()) {
+FontCachePurgePreventer fontCachePurgePreventer;
+
return m_frame->document()->renderView()->minPreferredLogicalWidth();
+}
return 0;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97058] trunk/Source/WebCore
Title: [97058] trunk/Source/WebCore
Revision 97058
Author carycl...@google.com
Date 2011-10-10 06:07:53 -0700 (Mon, 10 Oct 2011)
Log Message
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889
Reviewed by Stephen White.
Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.
Tests: fast/text/justify-ideograph-complex.html
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97057 => 97058)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 13:07:53 UTC (rev 97058)
@@ -1,3 +1,22 @@
+2011-10-10 Cary Clark
+
+[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
+https://bugs.webkit.org/show_bug.cgi?id=69656
+https://bugs.webkit.org/show_bug.cgi?id=62987
+https://bugs.webkit.org/show_bug.cgi?id=62889
+
+Reviewed by Stephen White.
+
+Skia on Linux and Windows uses different font engines from
+Skia on Mac. After determining that the underlying CoreText
+can handle it, enabling this allows justification to work
+correctly.
+
+Tests: fast/text/justify-ideograph-complex.html
+
+* platform/graphics/skia/FontSkia.cpp:
+(WebCore::Font::canExpandAroundIdeographsInComplexText):
+
2011-10-10 Ilya Tikhonovsky
Web Inspector: memory leak in Resource panel.
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (97057 => 97058)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:07:53 UTC (rev 97058)
@@ -49,12 +49,9 @@
return true;
}
-// FIXME: Determine if the Mac port of Chromium using Skia can expand around
-// ideographs in complex text. (The Windows and Linux ports for Chromium can't.)
-// This issue is tracked in https://bugs.webkit.org/show_bug.cgi?id=62987
bool Font::canExpandAroundIdeographsInComplexText()
{
-return false;
+return true;
}
static bool isCanvasMultiLayered(SkCanvas* canvas)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96970] trunk
Title: [96970] trunk
Revision 96970
Author carycl...@google.com
Date 2011-10-07 12:26:47 -0700 (Fri, 07 Oct 2011)
Log Message
Source/WebCore: Enable color profiles, unless profile is grayscale
https://bugs.webkit.org/show_bug.cgi?id=69622
https://bugs.webkit.org/show_bug.cgi?id=49950
http://code.google.com/p/chromium/issues/detail?id=80844
Further specialize the earlier fix described in 49950 to
allow color profiles in YCbCr images, but disallow color
profiles marked as grayData.
(see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )
Reviewed by Adam Barth.
Test: fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/color-jpeg-with-color-profile.html
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::readColorProfile):
(WebCore::JPEGImageReader::decode):
LayoutTests: Reviewed by Adam Barth.
Add a image with a color profile that's not gray.
https://bugs.webkit.org/show_bug.cgi?id=69622
Test that we properly render JPEGs with embedded non-gray color profiles.
* fast/images/color-jpeg-with-color-profile.html: Added.
* fast/images/resources/icc-v2-gbr.jpg: Added.
* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Added Paths
trunk/LayoutTests/fast/images/color-jpeg-with-color-profile.html
trunk/LayoutTests/fast/images/resources/icc-v2-gbr.jpg
trunk/LayoutTests/platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96969 => 96970)
--- trunk/LayoutTests/ChangeLog 2011-10-07 19:25:00 UTC (rev 96969)
+++ trunk/LayoutTests/ChangeLog 2011-10-07 19:26:47 UTC (rev 96970)
@@ -1,3 +1,16 @@
+2011-10-07 Cary Clark
+
+Reviewed by Adam Barth.
+
+Add a image with a color profile that's not gray.
+https://bugs.webkit.org/show_bug.cgi?id=69622
+
+Test that we properly render JPEGs with embedded non-gray color profiles.
+
+* fast/images/color-jpeg-with-color-profile.html: Added.
+* fast/images/resources/icc-v2-gbr.jpg: Added.
+* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
+
2011-10-07 Sheriff Bot
Unreviewed, rolling out r96938.
Added: trunk/LayoutTests/fast/images/color-jpeg-with-color-profile.html (0 => 96970)
--- trunk/LayoutTests/fast/images/color-jpeg-with-color-profile.html (rev 0)
+++ trunk/LayoutTests/fast/images/color-jpeg-with-color-profile.html 2011-10-07 19:26:47 UTC (rev 96970)
@@ -0,0 +1 @@
+
Added: trunk/LayoutTests/fast/images/resources/icc-v2-gbr.jpg
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/images/resources/icc-v2-gbr.jpg
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt (0 => 96970)
--- trunk/LayoutTests/platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt 2011-10-07 19:26:47 UTC (rev 96970)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderImage {IMG} at (0,0) size 275x207
+ RenderText {#text} at (0,0) size 0x0
Modified: trunk/Source/WebCore/ChangeLog (96969 => 96970)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 19:25:00 UTC (rev 96969)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 19:26:47 UTC (rev 96970)
@@ -1,3 +1,24 @@
+2011-10-07 Cary Clark
+
+Enable color profiles, unless profile is grayscale
+https://bugs.webkit.org/show_bug.cgi?id=69622
+https://bugs.webkit.org/show_bug.cgi?id=49950
+http://code.google.com/p/chromium/issues/detail?id=80844
+
+Further specialize the earlier fix described in 49950 to
+allow color profiles in YCbCr images, but disallow color
+profiles marked as grayData.
+(see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )
+
+Reviewed by Adam Barth.
+
+Test: fast/images/gray-scale-jpeg-with-color-profile.html
+ fast/images/color-jpeg-with-color-profile.html
+
+* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+(WebCore::readColorProfile):
+(WebCore::JPEGImageReader::decode):
+
2011-10-07 Chris Fleizach
AX: re-organize fake elements to use new AccessibilityMockObject
@@ -8293,7 +8314,6 @@
* bridge/qt/qt_runtime.h:
* workers/WorkerContext.h:
-<<< .mine
2011-09-27 Mark Hahnenberg
Add static version of JSCell::getCallData
@@ -8359,7 +8379,6 @@
(JSC::Bindings::RuntimeObject::getCallDa
[webkit-changes] [96725] trunk/LayoutTests
Title: [96725] trunk/LayoutTests Revision 96725 Author carycl...@google.com Date 2011-10-05 11:02:32 -0700 (Wed, 05 Oct 2011) Log Message Unreviewed; new baselines (Skia on Mac) Temporarily disable Skia on Mac on Leopard and Snow Leopard. * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (96724 => 96725) --- trunk/LayoutTests/ChangeLog 2011-10-05 17:56:25 UTC (rev 96724) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:02:32 UTC (rev 96725) @@ -1,3 +1,11 @@ +2011-10-05 Cary Clark + +Unreviewed; new baselines (Skia on Mac) + +Temporarily disable Skia on Mac on Leopard and Snow Leopard. + +* LayoutTests/platform/chromium/test_expectations.txt: + 2011-10-05 Sachin Puranik Spec change - option.label should be reflected like option.value Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96724 => 96725) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 17:56:25 UTC (rev 96724) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 18:02:32 UTC (rev 96725) @@ -3651,26 +3651,27 @@ // Temporarily allowing many failures for Mac10.5 with Skia graphics. // epoger promises to remove these expectations by 10 October 2011. -BUGWK68270 LEOPARD CPU GPU : animations = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css1 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css3 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : editing = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : fast = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : fonts = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : http = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU : media = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : platform = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : plugins = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : svg = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : tables = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : transforms = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : transitions = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : animations = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css1 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css3 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : editing = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : fast = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : fonts = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : http = PASS FAIL +BUGWK68270 LEOPARD CPU : media = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : platform = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : plugins = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : svg = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : tables = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : transforms = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : transitions = PASS FAIL // Temporarily allowing many failures for Mac10.6 with Skia graphics, while we work out kinks. // epoger promises to remove these expectations by 10 October 2011. BUGWK69279 SNOWLEOPARD CPU GPU : animations = PASS FAIL +BUGWK69279 SNOWLEOPARD GPU : compositing = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css1 = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css2.1 = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css3 = PASS FAIL @@ -3743,7 +3744,7 @@ BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.primarycolours.html = TEXT BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.quality.basic.html = TEXT -BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH +BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH IMAGE BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH IMAGE BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96635] trunk/Source/WebCore
Title: [96635] trunk/Source/WebCore Revision 96635 Author carycl...@google.com Date 2011-10-04 13:20:13 -0700 (Tue, 04 Oct 2011) Log Message Enable sub pixel text (Skia on Mac) https://bugs.webkit.org/show_bug.cgi?id=69354 http://code.google.com/p/chromium/issues/detail?id=98165 Reviewed by Eric Seidel. No new tests. Layout test pixel results have been disabled and will be rebaselined once all Skia on Mac changes are in. * platform/graphics/skia/FontSkia.cpp: (WebCore::setupPaint): Enable sub pixel text. This is set by default to enabled by CoreGraphics, but by default disabled on Skia. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (96634 => 96635) --- trunk/Source/WebCore/ChangeLog 2011-10-04 20:16:51 UTC (rev 96634) +++ trunk/Source/WebCore/ChangeLog 2011-10-04 20:20:13 UTC (rev 96635) @@ -1,3 +1,20 @@ +2011-10-04 Cary Clark + +Enable sub pixel text (Skia on Mac) +https://bugs.webkit.org/show_bug.cgi?id=69354 +http://code.google.com/p/chromium/issues/detail?id=98165 + +Reviewed by Eric Seidel. + +No new tests. Layout test pixel results have been +disabled and will be rebaselined once all Skia on Mac +changes are in. + +* platform/graphics/skia/FontSkia.cpp: +(WebCore::setupPaint): +Enable sub pixel text. This is set by default to enabled +by CoreGraphics, but by default disabled on Skia. + 2011-10-04 Anders Carlsson Remove PlatformWheelEvent::m_isAccepted Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (96634 => 96635) --- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-04 20:16:51 UTC (rev 96634) +++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-04 20:20:13 UTC (rev 96635) @@ -89,6 +89,7 @@ paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0); paint->setAutohinted(false); // freetype specific paint->setLCDRenderText(shouldSmoothFonts); +paint->setSubpixelText(true); } // TODO: This needs to be split into helper functions to better scope the ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96615] trunk/Source/WebCore
Title: [96615] trunk/Source/WebCore
Revision 96615
Author carycl...@google.com
Date 2011-10-04 11:12:58 -0700 (Tue, 04 Oct 2011)
Log Message
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956
This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.
Reviewed by Adam Barth.
No new tests. This platform is not enabled.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96614 => 96615)
--- trunk/Source/WebCore/ChangeLog 2011-10-04 18:11:55 UTC (rev 96614)
+++ trunk/Source/WebCore/ChangeLog 2011-10-04 18:12:58 UTC (rev 96615)
@@ -1,3 +1,21 @@
+2011-10-04 Cary Clark
+
+Inset focus ring (Skia on Mac)
+https://bugs.webkit.org/show_bug.cgi?id=69166
+http://code.google.com/p/chromium/issues/detail?id=97956
+
+This focus ring was drawn too large and was left tracks
+in subsequent invalidations. Make it more closely match
+the CG version.
+
+Reviewed by Adam Barth.
+
+No new tests. This platform is not enabled.
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::getFocusRingOutset):
+(WebCore::GraphicsContext::drawFocusRing):
+
2011-10-03 Jon Lee
Extend DOM WheelEvent to differentiate between physical and logical scroll directions
Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (96614 => 96615)
--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-04 18:11:55 UTC (rev 96614)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-10-04 18:12:58 UTC (rev 96615)
@@ -538,10 +538,10 @@
#endif
}
-static inline SkScalar getFocusRingOutset(int width)
+static inline SkScalar getFocusRingOutset()
{
#if PLATFORM(CHROMIUM) && OS(DARWIN)
-return (width * 0.5f) + 0.25f;
+return 0.75f;
#else
return 0.5f;
#endif
@@ -557,7 +557,7 @@
return;
SkRegion focusRingRegion;
-const SkScalar focusRingOutset = getFocusRingOutset(width);
+const SkScalar focusRingOutset = getFocusRingOutset();
for (unsigned i = 0; i < rectCount; i++) {
SkIRect r = rects[i];
r.inset(-focusRingOutset, -focusRingOutset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96609] trunk/Source/WebCore
Title: [96609] trunk/Source/WebCore
Revision 96609
Author carycl...@google.com
Date 2011-10-04 10:49:46 -0700 (Tue, 04 Oct 2011)
Log Message
Apply color profile found to decoded bitmap (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69144
This fixes http://code.google.com/p/chromium/issues/detail?id=97830
Reviewed by Stephen White.
No new tests. This platform is not enabled.
* platform/image-decoders/ImageDecoder.h:
Add color profile slot to Skia variation.
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
Adjust the bitmap in place to use the supplied color space.
(WebCore::createColorSpace):
Create a CGColorSpace from a color profile.
(WebCore::ImageFrame::setColorProfile):
Save the image's color profile until the image is complete.
(WebCore::ImageFrame::setStatus):
Apply the color profile, if any, to the image.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h
trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96608 => 96609)
--- trunk/Source/WebCore/ChangeLog 2011-10-04 17:47:29 UTC (rev 96608)
+++ trunk/Source/WebCore/ChangeLog 2011-10-04 17:49:46 UTC (rev 96609)
@@ -1,3 +1,29 @@
+2011-10-04 Cary Clark
+
+Apply color profile found to decoded bitmap (Skia on Mac)
+https://bugs.webkit.org/show_bug.cgi?id=69144
+This fixes http://code.google.com/p/chromium/issues/detail?id=97830
+
+Reviewed by Stephen White.
+
+No new tests. This platform is not enabled.
+
+* platform/image-decoders/ImageDecoder.h:
+Add color profile slot to Skia variation.
+
+* platform/image-decoders/skia/ImageDecoderSkia.cpp:
+(WebCore::resolveColorSpace):
+Adjust the bitmap in place to use the supplied color space.
+
+(WebCore::createColorSpace):
+Create a CGColorSpace from a color profile.
+
+(WebCore::ImageFrame::setColorProfile):
+Save the image's color profile until the image is complete.
+
+(WebCore::ImageFrame::setStatus):
+Apply the color profile, if any, to the image.
+
2011-10-04 Leandro Pereira
[CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.
Modified: trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h (96608 => 96609)
--- trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h 2011-10-04 17:47:29 UTC (rev 96608)
+++ trunk/Source/WebCore/platform/image-decoders/ImageDecoder.h 2011-10-04 17:49:46 UTC (rev 96609)
@@ -188,6 +188,9 @@
#if USE(SKIA)
NativeImageSkia m_bitmap;
+#if PLATFORM(CHROMIUM) && OS(DARWIN)
+ColorProfile m_colorProfile;
+#endif
#elif PLATFORM(QT)
mutable QPixmap m_pixmap;
mutable QImage m_image;
Modified: trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp (96608 => 96609)
--- trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp 2011-10-04 17:47:29 UTC (rev 96608)
+++ trunk/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp 2011-10-04 17:49:46 UTC (rev 96609)
@@ -29,6 +29,11 @@
#include "NotImplemented.h"
+#if PLATFORM(CHROMIUM) && OS(DARWIN)
+#include "GraphicsContextCG.h"
+#include "SkCGUtils.h"
+#endif
+
namespace WebCore {
ImageFrame::ImageFrame()
@@ -110,16 +115,56 @@
m_bitmap.bitmap().setIsOpaque(!alpha);
}
+#if PLATFORM(CHROMIUM) && OS(DARWIN)
+static void resolveColorSpace(const SkBitmap& bitmap, CGColorSpaceRef colorSpace)
+{
+int width = bitmap.width();
+int height = bitmap.height();
+CGImageRef srcImage = SkCreateCGImageRefWithColorspace(bitmap, colorSpace);
+SkAutoLockPixels lock(bitmap);
+void* pixels = bitmap.getPixels();
+RetainPtr cgBitmap(AdoptCF, CGBitmapContextCreate(pixels, width, height, 8, width * 4, deviceRGBColorSpaceRef(), kCGBitmapByteOrder32Host | kCGImageAlphaPremultipliedFirst));
+if (!cgBitmap)
+return;
+CGContextSetBlendMode(cgBitmap.get(), kCGBlendModeCopy);
+CGRect bounds = { {0, 0}, {width, height} };
+CGContextDrawImage(cgBitmap.get(), bounds, srcImage);
+}
+
+static CGColorSpaceRef createColorSpace(const ColorProfile& colorProfile)
+{
+RetainPtr data(AdoptCF, CFDataCreate(kCFAllocatorDefault, reinterpret_cast(colorProfile.data()), colorProfile.size()));
+#ifndef TARGETING_LEOPARD
+return CGColorSpaceCreateWithICCProfile(data.get());
+#else
+RetainPtr profileDataProvider(AdoptCF, CGDataProviderCreateWithCFData(data.get()));
+CGFloat ranges[] = {0.0, 255.0, 0.0, 255.0, 0.0, 255.0};
+return CGColorSpaceCreateICCBased(3, ranges, profileDataProvider.get(), deviceRGBColorSpaceRef());
+#endif
+}
+#endif
+
void ImageFrame::setColorProfile(const ColorProfile& colorProfile)
{
+#if PLATFORM(CHROMIUM) && OS(DARWIN)
+m_colorProfile = colorProfile;
+#else
notImplemented();
+#endif
}
void ImageFrame::setStatus(FrameSta
[webkit-changes] [96426] trunk/Source/WebCore
Title: [96426] trunk/Source/WebCore
Revision 96426
Author carycl...@google.com
Date 2011-09-30 14:26:08 -0700 (Fri, 30 Sep 2011)
Log Message
Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166
http://code.google.com/p/chromium/issues/detail?id=97956
This focus ring was drawn too large and was left tracks
in subsequent invalidations. Make it more closely match
the CG version.
Reviewed by Stephen White.
No new tests. This platform is not enabled.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96425 => 96426)
--- trunk/Source/WebCore/ChangeLog 2011-09-30 21:23:44 UTC (rev 96425)
+++ trunk/Source/WebCore/ChangeLog 2011-09-30 21:26:08 UTC (rev 96426)
@@ -1,3 +1,21 @@
+2011-09-30 Cary Clark
+
+Inset focus ring (Skia on Mac)
+https://bugs.webkit.org/show_bug.cgi?id=69166
+http://code.google.com/p/chromium/issues/detail?id=97956
+
+This focus ring was drawn too large and was left tracks
+in subsequent invalidations. Make it more closely match
+the CG version.
+
+Reviewed by Stephen White.
+
+No new tests. This platform is not enabled.
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::getFocusRingOutset):
+(WebCore::GraphicsContext::drawFocusRing):
+
2011-09-30 Sheriff Bot
Unreviewed, rolling out r96422.
Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (96425 => 96426)
--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-09-30 21:23:44 UTC (rev 96425)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp 2011-09-30 21:26:08 UTC (rev 96426)
@@ -538,10 +538,10 @@
#endif
}
-static inline SkScalar getFocusRingOutset(int width)
+static inline SkScalar getFocusRingOutset()
{
#if PLATFORM(CHROMIUM) && OS(DARWIN)
-return (width * 0.5f) + 0.25f;
+return 0.75f;
#else
return 0.5f;
#endif
@@ -557,7 +557,7 @@
return;
SkRegion focusRingRegion;
-const SkScalar focusRingOutset = getFocusRingOutset(width);
+const SkScalar focusRingOutset = getFocusRingOutset();
for (unsigned i = 0; i < rectCount; i++) {
SkIRect r = rects[i];
r.inset(-focusRingOutset, -focusRingOutset);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96366] trunk/Source/WebCore
Title: [96366] trunk/Source/WebCore
Revision 96366
Author carycl...@google.com
Date 2011-09-29 15:21:00 -0700 (Thu, 29 Sep 2011)
Log Message
Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734
Reviewed by Stephen White.
No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.
Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.
* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96365 => 96366)
--- trunk/Source/WebCore/ChangeLog 2011-09-29 22:16:56 UTC (rev 96365)
+++ trunk/Source/WebCore/ChangeLog 2011-09-29 22:21:00 UTC (rev 96366)
@@ -1,3 +1,21 @@
+2011-09-29 Cary Clark
+
+Enable LCD text in Skia on Mac
+https://bugs.webkit.org/show_bug.cgi?id=68734
+
+Reviewed by Stephen White.
+
+No new tests. Existing layout tests are generated
+with LCD text disabled for pixel comparisons.
+
+Duplicate the logic in FontMac.mm to pass settings
+for antialiasing and smoothing. Also disable smoothing
+for DumpRenderTree.
+
+* platform/graphics/skia/FontSkia.cpp:
+(WebCore::setupPaint):
+(WebCore::Font::drawGlyphs):
+
2011-09-29 Varun Jain
Implement flick gesture in Chromium Gesture Recognizer
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (96365 => 96366)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-09-29 22:16:56 UTC (rev 96365)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-09-29 22:21:00 UTC (rev 96366)
@@ -34,6 +34,7 @@
#include "GlyphBuffer.h"
#include "GraphicsContext.h"
#include "PlatformContextSkia.h"
+#include "PlatformSupport.h"
#include "SimpleFontData.h"
#include "SkCanvas.h"
@@ -73,12 +74,12 @@
paint->setLCDRenderText(false);
}
-static void setupPaint(SkPaint* paint, const SimpleFontData* fontData, const Font* font)
+static void setupPaint(SkPaint* paint, const SimpleFontData* fontData, const Font* font, bool shouldAntialias, bool shouldSmoothFonts)
{
const FontPlatformData& platformData = fontData->platformData();
const float textSize = platformData.m_size >= 0 ? platformData.m_size : 12;
-paint->setAntiAlias(true);
+paint->setAntiAlias(shouldAntialias);
paint->setEmbeddedBitmapText(false);
paint->setTextSize(SkFloatToScalar(textSize));
SkTypeface* typeface = SkCreateTypefaceFromCTFont(platformData.ctFont());
@@ -87,7 +88,7 @@
paint->setFakeBoldText(platformData.m_syntheticBold);
paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0);
paint->setAutohinted(false); // freetype specific
-paint->setLCDRenderText(font->fontDescription().fontSmoothing() == SubpixelAntialiased);
+paint->setLCDRenderText(shouldSmoothFonts);
}
// TODO: This needs to be split into helper functions to better scope the
@@ -98,6 +99,27 @@
const FloatPoint& point) const {
COMPILE_ASSERT(sizeof(GlyphBufferGlyph) == sizeof(uint16_t), GlyphBufferGlyphSize_equals_uint16_t);
+bool shouldSmoothFonts = true;
+bool shouldAntialias = true;
+
+switch (fontDescription().fontSmoothing()) {
+case Antialiased:
+shouldSmoothFonts = false;
+break;
+case SubpixelAntialiased:
+break;
+case NoSmoothing:
+shouldAntialias = false;
+shouldSmoothFonts = false;
+break;
+case AutoSmoothing:
+// For the AutoSmooth case, don't do anything! Keep the default settings.
+break;
+}
+
+if (!shouldUseSmoothing() || PlatformSupport::layoutTestMode())
+shouldSmoothFonts = false;
+
const GlyphBufferGlyph* glyphs = glyphBuffer.glyphs(from);
SkScalar x = SkFloatToScalar(point.x());
SkScalar y = SkFloatToScalar(point.y());
@@ -133,7 +155,7 @@
if (textMode & TextModeFill) {
SkPaint paint;
gc->platformContext()->setupPaintForFilling(&paint);
-setupPaint(&paint, font, this);
+setupPaint(&paint, font, this, shouldAntialias, shouldSmoothFonts);
adjustTextRenderMode(&paint, gc->platformContext());
paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
paint.setColor(gc->fillColor().rgb());
@@ -156,7 +178,7 @@
SkPaint paint;
gc->platformContext()->setupPaintForStroking(&paint, 0, 0);
-setupPaint(&paint, font, this);
+setupPaint(&paint, font, this, shouldAntialias, shouldSmoothFonts);
adjustTextRenderMode(&paint, gc->platformContext());
paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
paint.setColor(gc->strokeColor().rgb());
___
web
[webkit-changes] [95635] trunk/LayoutTests
Title: [95635] trunk/LayoutTests Revision 95635 Author carycl...@google.com Date 2011-09-21 08:51:51 -0700 (Wed, 21 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) This separates test failures that are specific to CG Mac from failures for Skia on Mac. Most of these changes are specific to Leopard, but a handful add new fail flavors for all Mac variations. * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95634 => 95635) --- trunk/LayoutTests/ChangeLog 2011-09-21 15:39:53 UTC (rev 95634) +++ trunk/LayoutTests/ChangeLog 2011-09-21 15:51:51 UTC (rev 95635) @@ -1,3 +1,13 @@ +2011-09-21 Cary Clark + +Unreviewed; new baselines (Skia on Mac) + +This separates test failures that are specific to CG Mac from failures +for Skia on Mac. Most of these changes are specific to Leopard, but a +handful add new fail flavors for all Mac variations. + +* LayoutTests/platform/chromium/test_expectations.txt: + 2011-09-21 Philippe Normand Unreviewed, GTK baselines for Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95634 => 95635) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-21 15:39:53 UTC (rev 95634) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-21 15:51:51 UTC (rev 95635) @@ -960,7 +960,7 @@ // - // This test is slow due to Mesa slowness. -WONTFIX GPU WIN LINUX : canvas/philip/tests/2d.shadow.blur.low.html = PASS TIMEOUT +WONTFIX GPU : canvas/philip/tests/2d.shadow.blur.low.html = PASS TIMEOUT // This test is overly-finicky about pixel values. BUGWK64876 LINUX WIN GPU : fast/canvas/canvas-scale-strokePath-shadow.html = TEXT @@ -1345,8 +1345,8 @@ // We could fix this test for us and upstream it if the test shell user agent // would let us differentiate test_shell and WebKit DumpTreeNode. -BUGCR7482 LINUX MAC : http/tests/misc/timer-vs-loading.html = PASS TIMEOUT -BUGCR7482 WIN : http/tests/misc/timer-vs-loading.html = PASS TIMEOUT +BUGCR7482 MAC : http/tests/misc/timer-vs-loading.html = PASS TIMEOUT TEXT +BUGCR7482 LINUX WIN : http/tests/misc/timer-vs-loading.html = PASS TIMEOUT // Selection highlight colors are wrong. BUGCR10426 LINUX : fast/lists/drag-into-marker.html = FAIL @@ -1589,7 +1589,7 @@ // in isolated worlds are cleared. BUGCR27849 : http/tests/security/isolatedWorld/didClearWindowObject.html = TEXT -BUGCR28040 MAC WIN DEBUG : fast/body-propagation/overflow/003-xhtml.xhtml = PASS IMAGE+TEXT +BUGCR28040 MAC WIN DEBUG : fast/body-propagation/overflow/003-xhtml.xhtml = PASS IMAGE IMAGE+TEXT BUGCR28092 WIN : http/tests/xmlhttprequest/redirect-cross-origin-post.html = PASS FAIL @@ -1716,10 +1716,11 @@ // New test, added http://trac.webkit.org/changeset/55546 BUGCR37896 LINUX WIN : fast/multicol/hit-test-above-or-below.html = TEXT BUGCR37896 WIN DEBUG : fast/text/firstline/001.html = PASS CRASH -BUGCR37896 LINUX MAC DEBUG : fast/text/firstline/001.html = PASS CRASH TIMEOUT +BUGCR37896 LINUX DEBUG : fast/text/firstline/001.html = PASS CRASH TIMEOUT +BUGCR37896 MAC DEBUG : fast/text/firstline/001.html = PASS CRASH TIMEOUT IMAGE // Added in http://trac.webkit.org/changeset/55587 // Three flaky tests noticed during a sheriff rotation. -BUGCR37962 MAC DEBUG : fast/dom/HTMLElement/bdo.html = PASS CRASH +BUGCR37962 MAC DEBUG : fast/dom/HTMLElement/bdo.html = PASS CRASH IMAGE BUGCR37962 LINUX DEBUG : fast/forms/multiple-form-submission-protection-mouse.html = PASS CRASH // WebKit roll r55853 -> 55940 @@ -2244,7 +2245,8 @@ BUG_AUTO WIN DEBUG : animations/multiple-keyframes.html = PASS TEXT // Seems to have been crashing intermittently for as long as we have test history. -BUGCR62741 DEBUG : svg/clip-path/clip-path-text-and-stroke.svg = PASS CRASH +BUGCR62741 WIN LINUX SNOWLEOPARD DEBUG : svg/clip-path/clip-path-text-and-stroke.svg = PASS CRASH +BUGWK68270 LEOPARD CPU DEBUG : svg/clip-path/clip-path-text-and-stroke.svg = IMAGE // nodesFromRect() removed from Document.idl and test skipped on other platforms at r68345. BUGWK46596 : fast/dom/nodesFromRect-basic.html = TIMEOUT @@ -2694,7 +2696,7 @@ // that needs to be implemented for GPU BUGCR94918 GPU SKIP : media/media-document-audio-repaint.html = IMAGE+TEXT IMAGE -BUGWK55968 MAC GPU-CG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT +BUGWK55968 MAC GPU GPU-CG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE IMAGE+TEXT BUGWK55968 WIN DEBUG GPU : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE // Flaky scrollbar issues @@ -2783,7 +2785,7 @@ BUGWK55560 : editing/input/setting-input-value-cancel-ime-composition.html = TEXT -BUGCR74710 LINUX MAC : svg/text/font-size-below-point-five.svg = PASS TEXT IMAGE +BUGCR74710
[webkit-changes] [95562] trunk/LayoutTests
Title: [95562] trunk/LayoutTests Revision 95562 Author carycl...@google.com Date 2011-09-20 13:05:23 -0700 (Tue, 20 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) This separates test failures that are specific to CG Mac from failures for Skia on Mac. Most of these changes are specific to Leopard, but a handful add new fail flavors for all Mac variations. * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95561 => 95562) --- trunk/LayoutTests/ChangeLog 2011-09-20 19:05:41 UTC (rev 95561) +++ trunk/LayoutTests/ChangeLog 2011-09-20 20:05:23 UTC (rev 95562) @@ -1,3 +1,13 @@ +2011-09-20 Cary Clark + +Unreviewed; new baselines (Skia on Mac) + +This separates test failures that are specific to CG Mac from failures +for Skia on Mac. Most of these changes are specific to Leopard, but a +handful add new fail flavors for all Mac variations. + +* LayoutTests/platform/chromium/test_expectations.txt: + 2011-09-20 Pavel Feldman Not reviewed: one line inspector's script-formatter.html fix. @@ -45,8 +55,8 @@ Unreviewed; new baselines (Skia on Mac) Updated reference images. -* LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed. -* LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: +* platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed. +* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: 2011-09-19 Pavel Feldman Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95561 => 95562) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-20 19:05:41 UTC (rev 95561) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-20 20:05:23 UTC (rev 95562) @@ -689,7 +689,7 @@ // Flaky BUGCR31803 LINUX MAC : editing/inserting/12882.html = PASS IMAGE -BUGCR31803 MAC WIN : editing/pasteboard/copy-standalone-image.html = PASS TEXT +BUGCR31803 MAC WIN : editing/pasteboard/copy-standalone-image.html = PASS TEXT IMAGE+TEXT // Tests added in r69269. // Apple-Mac port corrects "notationl" to "notational" automatically? @@ -900,7 +900,7 @@ // The test is flaky and maybe platform-dependent. BUGCR32401 LINUX WIN : svg/custom/marker-changes.svg = IMAGE+TEXT IMAGE -BUGCR89369 MAC : svg/hixie/text/003.html = PASS IMAGE+TEXT +BUGCR89369 MAC : svg/hixie/text/003.html = PASS IMAGE IMAGE+TEXT BUGCR32444 LINUX WIN : svg/hixie/text/003.html = FAIL // SVG masks aren't quite working yet. @@ -2124,9 +2124,9 @@ BUGWK42964 LINUX WIN : tables/mozilla_expected_failures/bugs/bug89315.html = PASS FAIL // Application Cache Quotas are N/A to the chromium port. -BUGWK43459 WONTFIX : http/tests/appcache/origin-quota.html = MISSING TEXT -BUGWK43459 WONTFIX : http/tests/appcache/origin-quota-continued-download.html = MISSING TEXT -BUGWK43459 WONTFIX : http/tests/appcache/origin-quota-continued-download-multiple-manifests.html = MISSING TEXT +BUGWK43459 WONTFIX : http/tests/appcache/origin-quota.html = MISSING TEXT IMAGE+TEXT +BUGWK43459 WONTFIX : http/tests/appcache/origin-quota-continued-download.html = MISSING TEXT IMAGE+TEXT +BUGWK43459 WONTFIX : http/tests/appcache/origin-quota-continued-download-multiple-manifests.html = MISSING TEXT IMAGE+TEXT // Need to support DeviceMotion. BUGCR51416 : fast/dom/DeviceMotion/window-property.html = TEXT @@ -2288,8 +2288,8 @@ // Flaky because they snapshot and animation. // Started failing on Mac since 69314:69342. -BUGCR10479 MAC WIN : svg/hixie/perf/001.xml = PASS IMAGE -BUGCR10479 MAC WIN : svg/hixie/perf/002.xml = PASS IMAGE +BUGCR10479 MAC WIN : svg/hixie/perf/001.xml = PASS IMAGE IMAGE+TEXT +BUGCR10479 MAC WIN : svg/hixie/perf/002.xml = PASS IMAGE IMAGE+TEXT // FileWriter isn't in TestShell yet. BUGCR58587 SKIP : fast/filesystem/file-writer-gc-blob.html = FAIL @@ -2783,7 +2783,7 @@ BUGWK55560 : editing/input/setting-input-value-cancel-ime-composition.html = TEXT -BUGCR74710 LINUX MAC : svg/text/font-size-below-point-five.svg = PASS TEXT +BUGCR74710 LINUX MAC : svg/text/font-size-below-point-five.svg = PASS TEXT IMAGE BUGCR74766 WIN DEBUG : http/tests/security/_javascript_URL/xss-ALLOWED-from-_javascript_-url-sub-frame-to-_javascript_-url-sub-frame.html = PASS CRASH @@ -2885,8 +2885,8 @@ BUGCR77574 LINUX : fast/writing-mode/fallback-orientation.html = IMAGE // Regression in r82056. -BUGWK57302 LEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT -BUGWK57302 LEOPARD : fast/text/international/text-combine-image-test.html = IMAGE+TEXT +BUGWK57302 LEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE IMAGE+TEXT +BUGWK57302 LEOPARD : fast/text/international/text-combine-image-test.html = IMAGE IMAGE+TEXT // Ne
[webkit-changes] [95539] trunk/LayoutTests
Title: [95539] trunk/LayoutTests Revision 95539 Author carycl...@google.com Date 2011-09-20 07:03:21 -0700 (Tue, 20 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed. * LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95538 => 95539) --- trunk/LayoutTests/ChangeLog 2011-09-20 14:00:37 UTC (rev 95538) +++ trunk/LayoutTests/ChangeLog 2011-09-20 14:03:21 UTC (rev 95539) @@ -1,3 +1,11 @@ +2011-09-20 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + +* LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png: Removed. +* LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: + 2011-09-19 Pavel Feldman Web Inspector: document Debugger.paused, introduce types for ids in Debugger domain. Modified: trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-mac/fast/ruby/overhang-horizontal-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95445] trunk/Source/WebCore
Title: [95445] trunk/Source/WebCore
Revision 95445
Author carycl...@google.com
Date 2011-09-19 11:27:34 -0700 (Mon, 19 Sep 2011)
Log Message
Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
https://bugs.webkit.org/show_bug.cgi?id=68358
Reviewed by Dan Bernstein.
No new tests.
* platform/graphics/mac/FontMac.mm:
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (95444 => 95445)
--- trunk/Source/WebCore/ChangeLog 2011-09-19 18:18:56 UTC (rev 95444)
+++ trunk/Source/WebCore/ChangeLog 2011-09-19 18:27:34 UTC (rev 95445)
@@ -1,3 +1,19 @@
+2011-09-19 Cary Clark
+
+Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
+https://bugs.webkit.org/show_bug.cgi?id=68358
+
+Reviewed by Dan Bernstein.
+
+No new tests.
+
+* platform/graphics/mac/FontMac.mm:
+* platform/graphics/mac/FontComplexTextMac.cpp:
+(WebCore::Font::fontDataForCombiningCharacterSequence):
+This moves the implementation from FontMac.mm to
+FontComplexTextMac.cpp, so it is visible to the Skia on Mac
+platform as well.
+
2011-09-19 Jessie Berlin
Sites that use history pushState or replaceState are recorded in history in Private Browsing
Modified: trunk/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp (95444 => 95445)
--- trunk/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp 2011-09-19 18:18:56 UTC (rev 95444)
+++ trunk/Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp 2011-09-19 18:27:34 UTC (rev 95445)
@@ -125,4 +125,38 @@
return controller.offsetForPosition(x, includePartialGlyphs);
}
+const SimpleFontData* Font::fontDataForCombiningCharacterSequence(const UChar* characters, size_t length, FontDataVariant variant) const
+{
+UChar32 baseCharacter;
+size_t baseCharacterLength = 0;
+U16_NEXT(characters, baseCharacterLength, length, baseCharacter);
+
+GlyphData baseCharacterGlyphData = glyphDataForCharacter(baseCharacter, false, variant);
+
+if (length == baseCharacterLength)
+return baseCharacterGlyphData.glyph ? baseCharacterGlyphData.fontData : 0;
+
+bool triedBaseCharacterFontData = false;
+
+unsigned i = 0;
+for (const FontData* fontData = fontDataAt(0); fontData; fontData = fontDataAt(++i)) {
+const SimpleFontData* simpleFontData = fontData->fontDataForCharacter(baseCharacter);
+if (variant != NormalVariant) {
+if (const SimpleFontData* variantFontData = simpleFontData->variantFontData(m_fontDescription, variant))
+simpleFontData = variantFontData;
+}
+
+if (simpleFontData == baseCharacterGlyphData.fontData)
+triedBaseCharacterFontData = true;
+
+if (simpleFontData->canRenderCombiningCharacterSequence(characters, length))
+return simpleFontData;
+}
+
+if (!triedBaseCharacterFontData && baseCharacterGlyphData.fontData && baseCharacterGlyphData.fontData->canRenderCombiningCharacterSequence(characters, length))
+return baseCharacterGlyphData.fontData;
+
+return 0;
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (95444 => 95445)
--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2011-09-19 18:18:56 UTC (rev 95444)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2011-09-19 18:27:34 UTC (rev 95445)
@@ -249,38 +249,4 @@
CGContextSetShouldSmoothFonts(cgContext, originalShouldUseFontSmoothing);
}
-const SimpleFontData* Font::fontDataForCombiningCharacterSequence(const UChar* characters, size_t length, FontDataVariant variant) const
-{
-UChar32 baseCharacter;
-size_t baseCharacterLength = 0;
-U16_NEXT(characters, baseCharacterLength, length, baseCharacter);
-
-GlyphData baseCharacterGlyphData = glyphDataForCharacter(baseCharacter, false, variant);
-
-if (length == baseCharacterLength)
-return baseCharacterGlyphData.glyph ? baseCharacterGlyphData.fontData : 0;
-
-bool triedBaseCharacterFontData = false;
-
-unsigned i = 0;
-for (const FontData* fontData = fontDataAt(0); fontData; fontData = fontDataAt(++i)) {
-const SimpleFontData* simpleFontData = fontData->fontDataForCharacter(baseCharacter);
-if (variant != NormalVariant) {
-if (const SimpleFontData* variantFontData = simpleFontData->variantFontData(m_fontDescription, variant))
-simpleFontData = variantFontData;
-}
-
-if (simpleFontData == baseCharacterGlyphData.fontData)
-triedBaseCharacterFont
[webkit-changes] [95317] trunk/LayoutTests
Title: [95317] trunk/LayoutTests Revision 95317 Author carycl...@google.com Date 2011-09-16 13:22:20 -0700 (Fri, 16 Sep 2011) Log Message Unreviewed; new expectations (Skia on Mac) This separates test failures that are specific to CG Mac from failures for Skia on Mac (Leopard only). * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95316 => 95317) --- trunk/LayoutTests/ChangeLog 2011-09-16 20:18:46 UTC (rev 95316) +++ trunk/LayoutTests/ChangeLog 2011-09-16 20:22:20 UTC (rev 95317) @@ -1,3 +1,11 @@ +2011-09-16 Cary Clark +Unreviewed; new expectations (Skia on Mac) + +This separates test failures that are specific to CG Mac from failures +for Skia on Mac (Leopard only). + +* LayoutTests/platform/chromium/test_expectations.txt: + 2011-09-16 James Simonsen Fix HTML5 parser's adoption agency algorithm to reparent correctly Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95316 => 95317) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-16 20:18:46 UTC (rev 95316) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-16 20:22:20 UTC (rev 95317) @@ -3758,3 +3758,23 @@ // New test added in r95259 looks like it is failing BUG_KEISHI : http/tests/history/back-with-fragment-change.php = FAIL +// Temporarily allowing many failures for non-CoreGraphics 10.5 (LEOPARD). +// epoger promises to remove these expectations by 10 October 2011. +BUGWK68270 LEOPARD CPU GPU : animations = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : compositing = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : css1 = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : css3 = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : editing = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : fast = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : fonts = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : fullscreen = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : http = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : media = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : platform = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : plugins = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : svg = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : tables = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : transforms = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : transitions = PASS TEXT IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95191] trunk/LayoutTests
Title: [95191] trunk/LayoutTests Revision 95191 Author carycl...@google.com Date 2011-09-15 07:42:33 -0700 (Thu, 15 Sep 2011) Log Message Unreviewed; new expectations (Skia on Mac) This separates test failures that are specific to CG Mac from failures for Skia on Mac. * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (95190 => 95191) --- trunk/LayoutTests/ChangeLog 2011-09-15 14:39:18 UTC (rev 95190) +++ trunk/LayoutTests/ChangeLog 2011-09-15 14:42:33 UTC (rev 95191) @@ -1,5 +1,13 @@ 2011-09-15 Cary Clark +Unreviewed; new expectations (Skia on Mac) + +This separates test failures that are specific to CG Mac from failures +for Skia on Mac. +* LayoutTests/platform/chromium/test_expectations.txt: + +2011-09-15 Cary Clark + Unreviewed; new baselines (Skia on Mac) Updated reference images. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95190 => 95191) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-15 14:39:18 UTC (rev 95190) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-15 14:42:33 UTC (rev 95191) @@ -481,9 +481,9 @@ // throw. V8 follows the spec. WONTFIX SKIP : fast/js/reparsing-semicolon-insertion.html = FAIL -// Rubber-banding is currently a Mac only feature. -WONTFIX WIN LINUX : platform/chromium/rubberbanding = FAIL -WONTFIX WIN LINUX : platform/chromium-gpu/compositing/rubberbanding = IMAGE +// Rubber-banding is currently a CG only feature. +WONTFIX CPU GPU : platform/chromium/rubberbanding = FAIL +WONTFIX CPU GPU : platform/chromium-gpu/compositing/rubberbanding = IMAGE // - // LIGHTTPD @@ -1888,17 +1888,17 @@ BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.gradient.radial.cone.front.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.gradient.radial.inside2.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.gradient.radial.inside3.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.gradient.radial.outside1.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.line.cap.closed.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.line.join.parallel.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.line.miter.lineedge.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.path.rect.winding.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.shadow.enable.x.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.shadow.enable.y.html = TEXT -BUGCR62301 MAC : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.gradient.radial.cone.front.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.gradient.radial.inside2.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.gradient.radial.inside3.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.gradient.radial.outside1.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.line.cap.closed.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.line.join.parallel.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.line.miter.lineedge.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.path.rect.winding.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.shadow.enable.x.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.shadow.enable.y.html = TEXT +BUGCR62301 MAC CPU-CG : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT // These SVG tests have been flaky on Win from quite some time. // Hard to pin down which roll introduced the flakiness. @@ -2654,18 +2654,19 @@ // Chromium does not support PDF content in tags. WONTFIX GPU WIN LINUX : compositing/color-matching/pdf-image-match.html = IMAGE+TEXT -WONTFIX GPU GPU-CG MAC : compositing/color-matching/pdf-image-match.html = IMAGE -WONTFIX GPU GPU-CG : compositing/images/direct-pdf-image.html = IMAGE +WONTFIX MAC GPU-CG : compositing/color-matching/pdf-image-match.html = IMAGE +WONTFIX WIN LINUX GPU : compositing/images/direct-pdf-image.html = IMAGE +WONTFIX MAC GPU-CG : compositing/images/direct-pdf-image.html = IMAGE // Chromium does not support PDF or plugin content in layers right now. BUGWK47925 LINUX WIN GPU : compositing/plugins/composited-plugin.html = IMAGE+TEXT -BUGWK47925 MAC GPU GPU-CG : compositing/plugins/composited-plugin.html = IMAGE+TEXT -BUGWK47925 MAC GPU GPU-CG : compositing/plugins/small-to-large-composited-plugin.html = TEXT +BUGWK47925 MAC GPU-CG : compositing/plugins/composited-plugin.html = IMAGE+TEXT +BUGWK47925 MAC GPU-CG : compositing/plugins/small-to-large-composited-plugin.html = TEXT BUGWK47949 LINUX WIN GPU : compositing/reflections/nested-reflection-anchor-point.html = IMAGE+TEXT -BUGW
[webkit-changes] [95190] trunk/LayoutTests
Title: [95190] trunk/LayoutTests Revision 95190 Author carycl...@google.com Date 2011-09-15 07:39:18 -0700 (Thu, 15 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-relative-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt: Removed. * LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-relative-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95189 => 95190) --- trunk/LayoutTests/ChangeLog 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/ChangeLog 2011-09-15 14:39:18 UTC (rev 95190) @@ -1,3 +1,16 @@ +2011-09-15 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-relative-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt: Removed. +* LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed. + 2011-09-15 Sheriff Bot Unreviewed, rolling out r95186. Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-expected.txt 2011-09-15 14:39:18 UTC (rev 95190) @@ -1 +0,0 @@ - Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-expected.txt 2011-09-15 14:39:18 UTC (rev 95190) @@ -1 +0,0 @@ - Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt 2011-09-15 14:39:18 UTC (rev 95190) @@ -1 +0,0 @@ - Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-expected.txt 2011-09-15 14:39:18 UTC (rev 95190) @@ -1 +0,0 @@ - Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt 2011-09-15 14:36:14 UTC (rev 95189) +++ trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-expected.txt 2011-09-15 14:39:18 UTC (rev 95190) @@ -1 +0,0 @@ - Deleted: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt (95189 => 95190) --- trunk/LayoutTests/platform/chromium-gpu-mac/compositing/rtl/rtl-fixed-overflow-scrolled-ex
[webkit-changes] [95187] trunk/LayoutTests
Title: [95187] trunk/LayoutTests Revision 95187 Author carycl...@google.com Date 2011-09-15 06:47:16 -0700 (Thu, 15 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: * LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png: * LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png: * LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added. * LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95186 => 95187) --- trunk/LayoutTests/ChangeLog 2011-09-15 13:46:21 UTC (rev 95186) +++ trunk/LayoutTests/ChangeLog 2011-09-15 13:47:16 UTC (rev 95187) @@ -1,3 +1,19 @@ +2011-09-15 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + +* LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added. + 2011-09-15 Keishi Hattori [chromium] rebaseline expectations due to r95180 @@ -11,6 +27,22 @@ Unreviewed; new baselines (Skia on Mac) Updated reference images. +* LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png: +* LayoutTests/platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added. +* LayoutTests/platform/chromium-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added. + +2011-09-15 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + * platform/chrom
[webkit-changes] [95185] trunk/LayoutTests
Title: [95185] trunk/LayoutTests Revision 95185 Author carycl...@google.com Date 2011-09-15 05:30:18 -0700 (Thu, 15 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * platform/chromium-mac/fast/borders/border-image-border-radius-expected.png: * platform/chromium-mac/fast/borders/border-image-01-expected.png: * platform/chromium-mac/fast/borders/border-image-slices-expected.png: * platform/chromium-mac/fast/borders/border-image-scrambled-expected.png: Added. * platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: * platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: * platform/chromium-mac/fast/borders/border-image-repeat-expected.png: * platform/chromium-mac/fast/borders/border-image-scaled-expected.png: * platform/chromium-mac/fast/borders/border-image-source-expected.png: * platform/chromium-mac/fast/borders/border-image-longhand-expected.png: * platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-01-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-border-radius-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-longhand-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-repeat-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-slices-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-source-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scrambled-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95184 => 95185) --- trunk/LayoutTests/ChangeLog 2011-09-15 12:25:37 UTC (rev 95184) +++ trunk/LayoutTests/ChangeLog 2011-09-15 12:30:18 UTC (rev 95185) @@ -1,3 +1,20 @@ +2011-09-15 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + +* platform/chromium-mac/fast/borders/border-image-border-radius-expected.png: +* platform/chromium-mac/fast/borders/border-image-01-expected.png: +* platform/chromium-mac/fast/borders/border-image-slices-expected.png: +* platform/chromium-mac/fast/borders/border-image-scrambled-expected.png: Added. +* platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: +* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: +* platform/chromium-mac/fast/borders/border-image-repeat-expected.png: +* platform/chromium-mac/fast/borders/border-image-scaled-expected.png: +* platform/chromium-mac/fast/borders/border-image-source-expected.png: +* platform/chromium-mac/fast/borders/border-image-longhand-expected.png: +* platform/chromium-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Removed. + 2011-09-15 Gabor Loki [Qt][ARMv5] Two timeline tests of inspector fail Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-01-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-border-radius-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-longhand-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-repeat-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scrambled-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scrambled-expected.png ___ Added: svn:mime-type Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-slices-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-source-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/japane
[webkit-changes] [95106] trunk/LayoutTests
Title: [95106] trunk/LayoutTests Revision 95106 Author carycl...@google.com Date 2011-09-14 11:47:34 -0700 (Wed, 14 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images (missed this one on the prior land) * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95105 => 95106) --- trunk/LayoutTests/ChangeLog 2011-09-14 18:46:19 UTC (rev 95105) +++ trunk/LayoutTests/ChangeLog 2011-09-14 18:47:34 UTC (rev 95106) @@ -1,6 +1,13 @@ 2011-09-14 Cary Clark Unreviewed; new baselines (Skia on Mac) +Updated reference images (missed this one on the prior land) + + * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added. + +2011-09-14 Cary Clark + +Unreviewed; new baselines (Skia on Mac) Updated reference images. * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed. Added: trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95105] trunk/LayoutTests
Title: [95105] trunk/LayoutTests Revision 95105 Author carycl...@google.com Date 2011-09-14 11:46:19 -0700 (Wed, 14 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed. * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95104 => 95105) --- trunk/LayoutTests/ChangeLog 2011-09-14 18:41:32 UTC (rev 95104) +++ trunk/LayoutTests/ChangeLog 2011-09-14 18:46:19 UTC (rev 95105) @@ -1,3 +1,11 @@ +2011-09-14 Cary Clark + +Unreviewed; new baselines (Skia on Mac) +Updated reference images. + + * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed. + * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added. + 2011-09-14 Eric Carlson video-error-abort.html shouldn't be in Mac skipped list Deleted: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95043] trunk/LayoutTests
Title: [95043] trunk/LayoutTests Revision 95043 Author carycl...@google.com Date 2011-09-13 13:59:38 -0700 (Tue, 13 Sep 2011) Log Message Unreviewed; new baselines (Skia on Mac) Updated reference images. * platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added. * platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png trunk/LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95042 => 95043) --- trunk/LayoutTests/ChangeLog 2011-09-13 20:51:29 UTC (rev 95042) +++ trunk/LayoutTests/ChangeLog 2011-09-13 20:59:38 UTC (rev 95043) @@ -1,6 +1,14 @@ 2011-09-13 Cary Clark Unreviewed; new baselines (Skia on Mac) +Updated reference images. + +* platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added. +* platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added. + +2011-09-13 Cary Clark + +Unreviewed; new baselines (Skia on Mac) Updated reference images, text. * platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed. Added: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95041] trunk/LayoutTests
Title: [95041] trunk/LayoutTests
Revision 95041
Author carycl...@google.com
Date 2011-09-13 13:35:17 -0700 (Tue, 13 Sep 2011)
Log Message
Unreviewed; new baselines (Skia on Mac)
Updated reference images, text.
* platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
* platform/chromium-mac/platform/chromium/fast/repaint: Added.
* platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
* platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
* platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png
trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/repaint/
trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png
trunk/LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (95040 => 95041)
--- trunk/LayoutTests/ChangeLog 2011-09-13 20:19:35 UTC (rev 95040)
+++ trunk/LayoutTests/ChangeLog 2011-09-13 20:35:17 UTC (rev 95041)
@@ -1,3 +1,17 @@
+2011-09-13 Cary Clark
+
+Unreviewed; new baselines (Skia on Mac)
+Updated reference images, text.
+
+* platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
+* platform/chromium-mac/platform/chromium/fast/repaint: Added.
+* platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
+* platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
+* platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
+* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
+* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
+* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
+
2011-09-13 Chang Shu
[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
Added: trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png
___
Added: svn:mime-type
Deleted: trunk/LayoutTests/platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt (95040 => 95041)
--- trunk/LayoutTests/platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt 2011-09-13 20:19:35 UTC (rev 95040)
+++ trunk/LayoutTests/platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt 2011-09-13 20:35:17 UTC (rev 95041)
@@ -1,2 +0,0 @@
-CONSOLE MESSAGE: line 1: EventSource's response has a MIME type ("text/html") that is not "text/event-stream". Aborting the connection.
-PASS
Added: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/repaint/fixed-layo
[webkit-changes] [94761] trunk/LayoutTests
Title: [94761] trunk/LayoutTests Revision 94761 Author carycl...@google.com Date 2011-09-08 09:03:40 -0700 (Thu, 08 Sep 2011) Log Message Unreviewed; removed one erroneous baseline (Skia on Mac) * platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94760 => 94761) --- trunk/LayoutTests/ChangeLog 2011-09-08 15:05:35 UTC (rev 94760) +++ trunk/LayoutTests/ChangeLog 2011-09-08 16:03:40 UTC (rev 94761) @@ -1,3 +1,9 @@ +2011-09-08 Cary Clark + +Unreviewed; removed one erroneous baseline (Skia on Mac) + +* platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed. + 2011-09-06 Pavel Podivilov Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode. Deleted: trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt (94760 => 94761) --- trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt 2011-09-08 15:05:35 UTC (rev 94760) +++ trunk/LayoutTests/platform/chromium-mac/fast/frames/lots-of-objects-expected.txt 2011-09-08 16:03:40 UTC (rev 94761) @@ -1 +0,0 @@ - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94019] trunk/Source/WebCore
Title: [94019] trunk/Source/WebCore Revision 94019 Author carycl...@google.com Date 2011-08-29 14:57:09 -0700 (Mon, 29 Aug 2011) Log Message Only enable font smoothing as requested (Skia on Mac) https://bugs.webkit.org/show_bug.cgi?id=67143 This adjusts LayoutTest pixel output to more closely match other platforms. Reviewed by Kenneth Russell. No new tests. This platform is not yet enabled. * platform/graphics/skia/FontSkia.cpp: (WebCore::setupPaint): LCD text was always enabled to test the code path. With this change, it is only enabled when instructed by the font state. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94018 => 94019) --- trunk/Source/WebCore/ChangeLog 2011-08-29 21:47:48 UTC (rev 94018) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 21:57:09 UTC (rev 94019) @@ -1,3 +1,20 @@ +2011-08-29 Cary Clark + +Only enable font smoothing as requested (Skia on Mac) +https://bugs.webkit.org/show_bug.cgi?id=67143 + +This adjusts LayoutTest pixel output to more closely +match other platforms. + +Reviewed by Kenneth Russell. + +No new tests. This platform is not yet enabled. + +* platform/graphics/skia/FontSkia.cpp: +(WebCore::setupPaint): +LCD text was always enabled to test the code path. With this change, +it is only enabled when instructed by the font state. + 2011-08-29 Julien Chaffraix Assertion failure in RenderLayer::computeRepaintRects when scrolling Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (94018 => 94019) --- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:47:48 UTC (rev 94018) +++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:57:09 UTC (rev 94019) @@ -87,7 +87,7 @@ paint->setFakeBoldText(platformData.m_syntheticBold); paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0); paint->setAutohinted(false); // freetype specific -paint->setLCDRenderText(true); // font->fontDescription().fontSmoothing() == SubpixelAntialiased); +paint->setLCDRenderText(font->fontDescription().fontSmoothing() == SubpixelAntialiased); } // TODO: This needs to be split into helper functions to better scope the ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93653] trunk/Tools
Title: [93653] trunk/Tools Revision 93653 Author carycl...@google.com Date 2011-08-23 16:18:34 -0700 (Tue, 23 Aug 2011) Log Message Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac) https://bugs.webkit.org/show_bug.cgi?id=66803 This fixes the WebKit Canaries, in particular avoids a crash on tests like css1/basic/comments.html. Reviewed by James Robinson. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb): The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void* parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land) and treated it as if it were a CGContextRef. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm Diff Modified: trunk/Tools/ChangeLog (93652 => 93653) --- trunk/Tools/ChangeLog 2011-08-23 23:12:27 UTC (rev 93652) +++ trunk/Tools/ChangeLog 2011-08-23 23:18:34 UTC (rev 93653) @@ -1,3 +1,19 @@ +2011-08-23 Cary Clark + +Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac) +https://bugs.webkit.org/show_bug.cgi?id=66803 + +This fixes the WebKit Canaries, in particular avoids a crash on tests +like css1/basic/comments.html. + +Reviewed by James Robinson. + +* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: +(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb): +The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void* +parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land) +and treated it as if it were a CGContextRef. + 2011-08-23 Patrick Gansterer Fix mergeChangeLogs test on native windows Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm (93652 => 93653) --- trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm 2011-08-23 23:12:27 UTC (rev 93652) +++ trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm 2011-08-23 23:18:34 UTC (rev 93653) @@ -176,7 +176,13 @@ [scroller setKnobProportion: knobProportion]; NSGraphicsContext* previousGraphicsContext = [NSGraphicsContext currentContext]; -NSGraphicsContext* nsGraphicsContext = [NSGraphicsContext graphicsContextWithGraphicsPort:canvas flipped:YES]; +#if WEBKIT_USING_SKIA +gfx::SkiaBitLocker bitLocker(canvas); +CGContextRef cgContext = bitLocker.cgContext(); +#else +CGContextRef cgContext = canvas; +#endif +NSGraphicsContext* nsGraphicsContext = [NSGraphicsContext graphicsContextWithGraphicsPort:cgContext flipped:YES]; [NSGraphicsContext setCurrentContext:nsGraphicsContext]; // Despite passing in frameRect() to the scroller, it always draws at (0, 0). ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93540] trunk/Source/WebCore
Title: [93540] trunk/Source/WebCore
Revision 93540
Author carycl...@google.com
Date 2011-08-22 14:07:03 -0700 (Mon, 22 Aug 2011)
Log Message
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703
This error was detected by the debug build of the Chromium WebKit
Canary.
Reviewed by James Robinson.
No new tests. This change suppresses a compile-time warning
but does not affect the generated code.
* platform/graphics/mac/FontCustomPlatformData.h:
Replaced struct with class in a forward reference.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (93539 => 93540)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 21:05:33 UTC (rev 93539)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 21:07:03 UTC (rev 93540)
@@ -1,3 +1,19 @@
+2011-08-22 Cary Clark
+
+Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
+https://bugs.webkit.org/show_bug.cgi?id=66703
+
+This error was detected by the debug build of the Chromium WebKit
+Canary.
+
+Reviewed by James Robinson.
+
+No new tests. This change suppresses a compile-time warning
+but does not affect the generated code.
+
+* platform/graphics/mac/FontCustomPlatformData.h:
+Replaced struct with class in a forward reference.
+
2011-08-22 Alexandru Chiculita
[CSSRegions] RenderFlowThread layout should use the attached region sizes
Modified: trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h (93539 => 93540)
--- trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h 2011-08-22 21:05:33 UTC (rev 93539)
+++ trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h 2011-08-22 21:07:03 UTC (rev 93540)
@@ -34,7 +34,7 @@
typedef UInt32 ATSFontRef;
#if USE(SKIA_ON_MAC_CHROMIUM)
-struct SkTypeface;
+class SkTypeface;
#endif
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93343] trunk/Source/WebCore
Title: [93343] trunk/Source/WebCore
Revision 93343
Author carycl...@google.com
Date 2011-08-18 13:22:52 -0700 (Thu, 18 Aug 2011)
Log Message
Fix rubber band gutter drawing for Skia on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=66478
Reviewed by James Robinson.
No new tests. The Skia on Chromium Mac platform has
not been enabled.
This break was detected at compile time; there is no
behavior change.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
Convert the CGImage into an SkBitmap if Skia is present.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (93342 => 93343)
--- trunk/Source/WebCore/ChangeLog 2011-08-18 20:22:47 UTC (rev 93342)
+++ trunk/Source/WebCore/ChangeLog 2011-08-18 20:22:52 UTC (rev 93343)
@@ -1,3 +1,20 @@
+2011-08-18 Cary Clark
+
+Fix rubber band gutter drawing for Skia on Chromium Mac
+https://bugs.webkit.org/show_bug.cgi?id=66478
+
+Reviewed by James Robinson.
+
+No new tests. The Skia on Chromium Mac platform has
+not been enabled.
+
+This break was detected at compile time; there is no
+behavior change.
+
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+Convert the CGImage into an SkBitmap if Skia is present.
+
2011-08-18 Julien Chaffraix
Implement a faster path for painting tables with overflowing cells
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm (93342 => 93343)
--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm 2011-08-18 20:22:47 UTC (rev 93342)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm 2011-08-18 20:22:52 UTC (rev 93343)
@@ -42,6 +42,7 @@
#include
#if USE(SKIA)
+#include "BitmapImageSingleFrameSkia.h"
#include "PlatformContextSkia.h"
#include "skia/ext/skia_utils_mac.h"
#endif
@@ -203,7 +204,12 @@
if (tiffData) {
CGImageSourceRef imageSource = CGImageSourceCreateWithData((CFDataRef)tiffData, NULL);
CGImageRef cgImage = CGImageSourceCreateImageAtIndex(imageSource, 0, NULL);
+#if USE(SKIA)
+SkBitmap bitmap = gfx::CGImageToSkBitmap(cgImage);
+RefPtr patternImage = BitmapImageSingleFrameSkia::create(bitmap, false);
+#else
RefPtr patternImage = BitmapImage::create(cgImage);
+#endif
m_overhangPattern = Pattern::create(patternImage, true, true);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93057] trunk/Source/WebCore
Title: [93057] trunk/Source/WebCore
Revision 93057
Author carycl...@google.com
Date 2011-08-15 12:59:54 -0700 (Mon, 15 Aug 2011)
Log Message
Revise Skia on Chrome Mac to return fallback fonts.
https://bugs.webkit.org/show_bug.cgi?id=62986
Reviewed by Darin Fisher.
Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.
This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canReturnFallbackFontsForComplexText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93056 => 93057)
--- trunk/Source/WebCore/ChangeLog 2011-08-15 19:59:08 UTC (rev 93056)
+++ trunk/Source/WebCore/ChangeLog 2011-08-15 19:59:54 UTC (rev 93057)
@@ -1,3 +1,20 @@
+2011-08-15 Cary Clark
+
+Revise Skia on Chrome Mac to return fallback fonts.
+https://bugs.webkit.org/show_bug.cgi?id=62986
+
+Reviewed by Darin Fisher.
+
+Since Skia on Chrome Mac uses CoreText to determine
+text metrics, CG font architecture is used to return
+fallback fonts.
+
+This improves many existing layout tests, including
+justify-ideograph-simple and t0905-c414-flt-04-c
+
+* platform/graphics/skia/FontSkia.cpp:
+(WebCore::Font::canReturnFallbackFontsForComplexText):
+
2011-08-15 Aaron Boodman
Pass additional details to client in didCreateIsolatedContext
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (93056 => 93057)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-15 19:59:08 UTC (rev 93056)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-15 19:59:54 UTC (rev 93057)
@@ -43,12 +43,9 @@
namespace WebCore {
-// FIXME: Determine if the Mac port of Chromium using Skia can return fallback
-// fonts for complex text. (The Windows and Linux ports for Chromium do not.)
-// This issue is tracked in https://bugs.webkit.org/show_bug.cgi?id=62986
bool Font::canReturnFallbackFontsForComplexText()
{
-return false;
+return true;
}
// FIXME: Determine if the Mac port of Chromium using Skia can expand around
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91388] trunk/Source/WebCore
Title: [91388] trunk/Source/WebCore Revision 91388 Author carycl...@google.com Date 2011-07-20 12:31:06 -0700 (Wed, 20 Jul 2011) Log Message update FontSkia to match platform context convention https://bugs.webkit.org/show_bug.cgi?id=64795 Reviewed by James Robinson. No new tests. This platform variant is not built at this time. * platform/graphics/skia/FontSkia.cpp: (WebCore::Font::drawGlyphs): Call makeGrContextCurrent instead of the obsolete prepareForSoftwareDraw. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (91387 => 91388) --- trunk/Source/WebCore/ChangeLog 2011-07-20 19:16:55 UTC (rev 91387) +++ trunk/Source/WebCore/ChangeLog 2011-07-20 19:31:06 UTC (rev 91388) @@ -1,3 +1,17 @@ +2011-07-20 Cary Clark + +update FontSkia to match platform context convention +https://bugs.webkit.org/show_bug.cgi?id=64795 + +Reviewed by James Robinson. + +No new tests. This platform variant is not +built at this time. + +* platform/graphics/skia/FontSkia.cpp: +(WebCore::Font::drawGlyphs): +Call makeGrContextCurrent instead of the obsolete prepareForSoftwareDraw. + 2011-07-20 Brian Weinstein Build fix after r91384. Add an ASSERT_UNSED for the timer. Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (91387 => 91388) --- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-07-20 19:16:55 UTC (rev 91387) +++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-07-20 19:31:06 UTC (rev 91388) @@ -129,7 +129,7 @@ y += SkFloatToScalar(adv[i].height); } -gc->platformContext()->prepareForSoftwareDraw(); +gc->platformContext()->makeGrContextCurrent(); SkCanvas* canvas = gc->platformContext()->canvas(); TextDrawingModeFlags textMode = gc->platformContext()->getTextDrawingMode(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91291] trunk/Tools
Title: [91291] trunk/Tools
Revision 91291
Author carycl...@google.com
Date 2011-07-19 13:06:47 -0700 (Tue, 19 Jul 2011)
Log Message
add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=64816
No review needed.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (91290 => 91291)
--- trunk/Tools/ChangeLog 2011-07-19 20:03:13 UTC (rev 91290)
+++ trunk/Tools/ChangeLog 2011-07-19 20:06:47 UTC (rev 91291)
@@ -1,3 +1,12 @@
+2011-07-19 Cary Clark
+
+add myself to committers.py
+https://bugs.webkit.org/show_bug.cgi?id=64816
+
+No review needed.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2011-07-19 Daniel Bates
Rename variable isEmptyTextPatch in svn-{apply, unapply}
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (91290 => 91291)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-19 20:03:13 UTC (rev 91290)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-19 20:06:47 UTC (rev 91291)
@@ -128,6 +128,7 @@
Committer("Cameron McCormack", ["c...@mcc.id.au", "c...@webkit.org"], "heycam"),
Committer("Carlos Garcia Campos", ["cgar...@igalia.com", "carlo...@gnome.org", "carlo...@webkit.org"], "KaL"),
Committer("Carol Szabo", "ca...@webkit.org", "cszabo1"),
+Committer("Cary Clark", "carycl...@google.com", "caryclark"),
Committer("Chang Shu", ["c...@webkit.org", "chang@nokia.com"], "cshu"),
Committer("Chris Evans", "cev...@google.com"),
Committer("Chris Guillory", ["ctg...@chromium.org", "chris.guill...@google.com"], "ctguil"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
