[webkit-changes] [226729] trunk/Tools

[clopez]

Title: [226729] trunk/Tools








Revision 226729
Author clo...@igalia.com
Date 2018-01-10 13:00:10 -0800 (Wed, 10 Jan 2018)


Log Message
Add a JSCOnly MIPS buildbot
https://bugs.webkit.org/show_bug.cgi?id=181487

Reviewed by Michael Catanzaro.

Add the new bot configs definitions for the master and update the unit tests.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (226728 => 226729)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-10 20:19:20 UTC (rev 226728)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-10 21:00:10 UTC (rev 226729)
@@ -90,6 +90,7 @@
 { "name": "jsconly-linux-szeged-slave-1", "platform": "jsc-only" },
 { "name": "jsconly-linux-szeged-slave-2", "platform": "jsc-only" },
 { "name": "jsconly-linux-szeged-slave-3", "platform": "jsc-only" },
+{ "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
 
 { "name": "wpe-linux-bot-1", "platform": "wpe" },
 { "name": "wpe-linux-bot-2", "platform": "wpe" }
@@ -383,6 +384,11 @@
   "slavenames": ["jsconly-linux-szeged-slave-3"]
 },
 {
+  "name": "JSCOnly Linux MIPS32el Release", "type": "BuildAndRemoteJSCTests", "builddir": "jsconly-linux-mips32el-release",
+  "platform": "jsc-only", "configuration": "release", "architectures": ["mips"],
+  "slavenames": ["jsconly-linux-igalia-bot-1"]
+},
+{
   "name": "WPE Linux 64-bit Release (Build)", "type": "Build", "builddir": "wpe-linux-64-release",
   "platform": "wpe", "configuration": "release", "architectures": ["x86_64"],
   "triggers": ["wpe-linux-64-release-tests"],


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (226728 => 226729)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2018-01-10 20:19:20 UTC (rev 226728)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2018-01-10 21:00:10 UTC (rev 226729)
@@ -463,6 +463,7 @@
 'JSCOnly Linux ARMv7 Thumb2 Release': ['configure build', 'wait-for-svn-server', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
 'JSCOnly Linux ARMv7 Traditional Release': ['configure build', 'wait-for-svn-server', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
 'JSCOnly Linux AArch64 Release': ['configure build', 'wait-for-svn-server', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
+'JSCOnly Linux MIPS32el Release': ['configure build', 'svn', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'jscore-test'],
 
 'GTK Linux 32-bit Release': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'compile-webkit', 'jscore-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'API tests'],
 'GTK Linux 64-bit Debug (Build)': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],


Modified: trunk/Tools/ChangeLog (226728 => 226729)

--- trunk/Tools/ChangeLog	2018-01-10 20:19:20 UTC (rev 226728)
+++ trunk/Tools/ChangeLog	2018-01-10 21:00:10 UTC (rev 226729)
@@ -1,3 +1,15 @@
+2018-01-10  Carlos Alberto Lopez Perez  
+
+Add a JSCOnly MIPS buildbot
+https://bugs.webkit.org/show_bug.cgi?id=181487
+
+Reviewed by Michael Catanzaro.
+
+Add the new bot configs definitions for the master and update the unit tests.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
+
 2018-01-10  Jonathan Bedard  
 
 REGRESSION (r226715): don't re-check number of simulators in child processes






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226302] trunk/Source/JavaScriptCore

[clopez]

Title: [226302] trunk/Source/_javascript_Core








Revision 226302
Author clo...@igalia.com
Date 2017-12-27 09:41:19 -0800 (Wed, 27 Dec 2017)


Log Message
Build fix after r226299 (3)
https://bugs.webkit.org/show_bug.cgi?id=181160

Unreviewed build fix.

* API/tests/TypedArrayCTest.cpp: fix typo in header name.

Modified Paths

trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp (226301 => 226302)

--- trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 17:38:14 UTC (rev 226301)
+++ trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 17:41:19 UTC (rev 226302)
@@ -27,7 +27,7 @@
 #include "TypedArrayCTest.h"
 
 #include "_javascript_.h"
-#include 
+#include 
 #include 
 #include 
 #include 


Modified: trunk/Source/_javascript_Core/ChangeLog (226301 => 226302)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-27 17:38:14 UTC (rev 226301)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-27 17:41:19 UTC (rev 226302)
@@ -1,5 +1,14 @@
 2017-12-27  Carlos Alberto Lopez Perez  
 
+Build fix after r226299 (3)
+https://bugs.webkit.org/show_bug.cgi?id=181160
+
+Unreviewed build fix.
+
+* API/tests/TypedArrayCTest.cpp: fix typo in header name.
+
+2017-12-27  Carlos Alberto Lopez Perez  
+
 Build fix after r226299 (2)
 https://bugs.webkit.org/show_bug.cgi?id=181160
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226301] trunk/Source/JavaScriptCore

[clopez]

Title: [226301] trunk/Source/_javascript_Core








Revision 226301
Author clo...@igalia.com
Date 2017-12-27 09:38:14 -0800 (Wed, 27 Dec 2017)


Log Message
Build fix after r226299 (2)
https://bugs.webkit.org/show_bug.cgi?id=181160

Unreviewed build fix.

* API/tests/TypedArrayCTest.cpp: Add missing header include.

Modified Paths

trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp (226300 => 226301)

--- trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 17:29:28 UTC (rev 226300)
+++ trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 17:38:14 UTC (rev 226301)
@@ -27,6 +27,7 @@
 #include "TypedArrayCTest.h"
 
 #include "_javascript_.h"
+#include 
 #include 
 #include 
 #include 


Modified: trunk/Source/_javascript_Core/ChangeLog (226300 => 226301)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-27 17:29:28 UTC (rev 226300)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-27 17:38:14 UTC (rev 226301)
@@ -1,5 +1,14 @@
 2017-12-27  Carlos Alberto Lopez Perez  
 
+Build fix after r226299 (2)
+https://bugs.webkit.org/show_bug.cgi?id=181160
+
+Unreviewed build fix.
+
+* API/tests/TypedArrayCTest.cpp: Add missing header include.
+
+2017-12-27  Carlos Alberto Lopez Perez  
+
 Build fix after r226299
 https://bugs.webkit.org/show_bug.cgi?id=181160
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226300] trunk/Source

[clopez]

Title: [226300] trunk/Source








Revision 226300
Author clo...@igalia.com
Date 2017-12-27 09:29:28 -0800 (Wed, 27 Dec 2017)


Log Message
Build fix after r226299
https://bugs.webkit.org/show_bug.cgi?id=181160

Unreviewed build fix.

Source/_javascript_Core:

* API/tests/TypedArrayCTest.cpp:
(assertEqualsAsNumber): Disambiguate usage of isnan.

Source/WebCore:

No new tests, its a build fix.

* platform/graphics/FontSelectionAlgorithm.h: Add missing include.

Modified Paths

trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h




Diff

Modified: trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp (226299 => 226300)

--- trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 16:46:02 UTC (rev 226299)
+++ trunk/Source/_javascript_Core/API/tests/TypedArrayCTest.cpp	2017-12-27 17:29:28 UTC (rev 226300)
@@ -84,7 +84,7 @@
 static int assertEqualsAsNumber(JSGlobalContextRef context, JSValueRef value, double expectedValue)
 {
 double number = JSValueToNumber(context, value, nullptr);
-if (number != expectedValue && !(isnan(number) && isnan(expectedValue))) {
+if (number != expectedValue && !(std::isnan(number) && std::isnan(expectedValue))) {
 fprintf(stderr, "assertEqualsAsNumber FAILED: %p, %lf\n", value, expectedValue);
 return 1;
 }


Modified: trunk/Source/_javascript_Core/ChangeLog (226299 => 226300)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-27 16:46:02 UTC (rev 226299)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-27 17:29:28 UTC (rev 226300)
@@ -1,3 +1,13 @@
+2017-12-27  Carlos Alberto Lopez Perez  
+
+Build fix after r226299
+https://bugs.webkit.org/show_bug.cgi?id=181160
+
+Unreviewed build fix.
+
+* API/tests/TypedArrayCTest.cpp:
+(assertEqualsAsNumber): Disambiguate usage of isnan.
+
 2017-12-26  Carlos Alberto Lopez Perez  
 
 REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4


Modified: trunk/Source/WebCore/ChangeLog (226299 => 226300)

--- trunk/Source/WebCore/ChangeLog	2017-12-27 16:46:02 UTC (rev 226299)
+++ trunk/Source/WebCore/ChangeLog	2017-12-27 17:29:28 UTC (rev 226300)
@@ -1,3 +1,14 @@
+2017-12-27  Carlos Alberto Lopez Perez  
+
+Build fix after r226299
+https://bugs.webkit.org/show_bug.cgi?id=181160
+
+Unreviewed build fix.
+
+No new tests, its a build fix.
+
+* platform/graphics/FontSelectionAlgorithm.h: Add missing include.
+
 2017-12-26  Carlos Alberto Lopez Perez  
 
 REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4


Modified: trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h (226299 => 226300)

--- trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h	2017-12-27 16:46:02 UTC (rev 226299)
+++ trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h	2017-12-27 17:29:28 UTC (rev 226300)
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226299] trunk/Source

[clopez]

Title: [226299] trunk/Source








Revision 226299
Author clo...@igalia.com
Date 2017-12-27 08:46:02 -0800 (Wed, 27 Dec 2017)


Log Message
REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
https://bugs.webkit.org/show_bug.cgi?id=181160

Reviewed by Myles C. Maxfield.

Source/_javascript_Core:

Disambiguate usage of min and max (Use the version from stdlib).

* runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):

Source/WebCore:

No new tests, its a build fix.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::currentMediaTime const): Disambiguate usage of max (Use the version from stdlib).
* platform/graphics/FontSelectionAlgorithm.h:
(WebCore::FontSelectionValue::clampFloat): Use WTF::min and WTF::max for constexpr result.
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem): Disambiguate usage of min and max (Use the version from stdlib).

Source/WebKitLegacy/win:

* Plugins/PluginView.cpp:
(WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).

Source/WTF:

In libstdc++-4 std::max and std::min are not annotated with constexpr.
This patch adds a WTF::min and WTF::max for using where a constexpr result is expected.
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60271

* wtf/StdLibExtras.h:
(WTF::min):
(WTF::max):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebCore/platform/graphics/win/UniscribeController.cpp
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226298 => 226299)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-27 10:52:39 UTC (rev 226298)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-27 16:46:02 UTC (rev 226299)
@@ -1,3 +1,19 @@
+2017-12-26  Carlos Alberto Lopez Perez  
+
+REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
+https://bugs.webkit.org/show_bug.cgi?id=181160
+
+Reviewed by Myles C. Maxfield.
+
+Disambiguate usage of min and max (Use the version from stdlib).
+
+* runtime/JSArray.cpp:
+(JSC::JSArray::unshiftCountSlowCase):
+(JSC::JSArray::setLengthWithArrayStorage):
+(JSC::JSArray::shiftCountWithArrayStorage):
+(JSC::JSArray::fillArgList):
+(JSC::JSArray::copyToArguments):
+
 2017-12-27  Zan Dobersek  
 
 REGRESSION(r225913): about 30 JSC test failures on ARMv7


Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (226298 => 226299)

--- trunk/Source/_javascript_Core/runtime/JSArray.cpp	2017-12-27 10:52:39 UTC (rev 226298)
+++ trunk/Source/_javascript_Core/runtime/JSArray.cpp	2017-12-27 16:46:02 UTC (rev 226299)
@@ -339,7 +339,7 @@
 
 unsigned length = storage->length();
 unsigned oldVectorLength = storage->vectorLength();
-unsigned usedVectorLength = min(oldVectorLength, length);
+unsigned usedVectorLength = std::min(oldVectorLength, length);
 ASSERT(usedVectorLength <= MAX_STORAGE_VECTOR_LENGTH);
 // Check that required vector length is possible, in an overflow-safe fashion.
 if (count > MAX_STORAGE_VECTOR_LENGTH - usedVectorLength)
@@ -353,7 +353,7 @@
 // FIXME: This code should be fixed to avoid internal fragmentation. It's not super high
 // priority since increaseVectorLength() will "fix" any mistakes we make, but it would be cool
 // to get this right eventually.
-unsigned desiredCapacity = min(MAX_STORAGE_VECTOR_LENGTH, max(BASE_ARRAY_STORAGE_VECTOR_LEN, requiredVectorLength) << 1);
+unsigned desiredCapacity = std::min(MAX_STORAGE_VECTOR_LENGTH, std::max(BASE_ARRAY_STORAGE_VECTOR_LEN, requiredVectorLength) << 1);
 
 // Step 2:
 // We're either going to choose to allocate a new ArrayStorage, or we're going to reuse the existing one.
@@ -388,7 +388,7 @@
 postCapacity = newStorageCapacity - requiredVectorLength;
 else if (length < storage->vectorLength()) {
 // Atomic decay, + the post-capacity cannot be greater than what is available.
-postCapacity = min((storage->vectorLength() - length) >> 1, newStorageCapacity - requiredVectorLength);
+postCapacity = std::min((storage->vectorLength() - length) >> 1, newStorageCapacity - requiredVectorLength);
 // If we're moving contents within the same allocation, the post-capacity is being 

[webkit-changes] [226174] trunk/Source/WebCore

[clopez]

Title: [226174] trunk/Source/WebCore








Revision 226174
Author clo...@igalia.com
Date 2017-12-20 04:46:29 -0800 (Wed, 20 Dec 2017)


Log Message
[GTK][Clang] Build fix after r226138
https://bugs.webkit.org/show_bug.cgi?id=180984

Unreviewed build fix.

No new tests, its a build fix.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::collectSubrangesForDocumentMarkers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226173 => 226174)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 12:44:10 UTC (rev 226173)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 12:46:29 UTC (rev 226174)
@@ -1,3 +1,15 @@
+2017-12-20  Carlos Alberto Lopez Perez  
+
+[GTK][Clang] Build fix after r226138
+https://bugs.webkit.org/show_bug.cgi?id=180984
+
+Unreviewed build fix.
+
+No new tests, its a build fix.
+
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::collectSubrangesForDocumentMarkers):
+
 2017-12-20  Ryosuke Niwa  
 
 REGRESSION(r222699): Drag & drop from a web page to Gmail fails


Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (226173 => 226174)

--- trunk/Source/WebCore/rendering/InlineTextBox.cpp	2017-12-20 12:44:10 UTC (rev 226173)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp	2017-12-20 12:46:29 UTC (rev 226174)
@@ -849,8 +849,8 @@
 case DocumentMarker::TextMatch:
 if (!renderer().frame().editor().markedTextMatchesAreHighlighted())
 continue;
+#if ENABLE(TELEPHONE_NUMBER_DETECTION)
 FALLTHROUGH;
-#if ENABLE(TELEPHONE_NUMBER_DETECTION)
 case DocumentMarker::TelephoneNumber:
 #endif
 if (phase == TextPaintPhase::Foreground)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225888] trunk

[clopez]

Title: [225888] trunk








Revision 225888
Author clo...@igalia.com
Date 2017-12-13 17:45:03 -0800 (Wed, 13 Dec 2017)


Log Message
[WPE] WebCrypto should be a public option.
https://bugs.webkit.org/show_bug.cgi?id=180780

Reviewed by Konstantin Tokarev.

Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
when this option is not enabled. This is also how the GTK+ port
configures the visibility of this option and its dependencies.

* Source/cmake/OptionsWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (225887 => 225888)

--- trunk/ChangeLog	2017-12-14 01:12:03 UTC (rev 225887)
+++ trunk/ChangeLog	2017-12-14 01:45:03 UTC (rev 225888)
@@ -1,3 +1,16 @@
+2017-12-13  Carlos Alberto Lopez Perez  
+
+[WPE] WebCrypto should be a public option.
+https://bugs.webkit.org/show_bug.cgi?id=180780
+
+Reviewed by Konstantin Tokarev.
+
+Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
+when this option is not enabled. This is also how the GTK+ port
+configures the visibility of this option and its dependencies.
+
+* Source/cmake/OptionsWPE.cmake:
+
 2017-12-13  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.


Modified: trunk/Source/cmake/OptionsWPE.cmake (225887 => 225888)

--- trunk/Source/cmake/OptionsWPE.cmake	2017-12-14 01:12:03 UTC (rev 225887)
+++ trunk/Source/cmake/OptionsWPE.cmake	2017-12-14 01:45:03 UTC (rev 225888)
@@ -17,6 +17,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
 
@@ -60,9 +61,8 @@
 find_package(ICU REQUIRED)
 find_package(JPEG REQUIRED)
 find_package(LibEpoxy 1.4.0 REQUIRED)
-find_package(LibGcrypt 1.7.0 REQUIRED)
+find_package(LibGcrypt 1.6.0 REQUIRED)
 find_package(LibSoup 2.42.0 REQUIRED)
-find_package(Libtasn1 REQUIRED)
 find_package(LibXml2 2.8.0 REQUIRED)
 find_package(PNG REQUIRED)
 find_package(Sqlite REQUIRED)
@@ -75,6 +75,16 @@
 find_package(CairoGL 1.10.2 REQUIRED COMPONENTS cairo-egl)
 endif ()
 
+if (ENABLE_SUBTLE_CRYPTO)
+find_package(Libtasn1 REQUIRED)
+if (NOT LIBTASN1_FOUND)
+message(FATAL_ERROR "libtasn1 is required to enable Web Crypto API support.")
+endif ()
+if (LIBGCRYPT_VERSION VERSION_LESS 1.7.0)
+message(FATAL_ERROR "libgcrypt 1.7.0 is required to enable Web Crypto API support.")
+endif ()
+endif ()
+
 if (ENABLE_XSLT)
 find_package(LibXslt 1.1.7 REQUIRED)
 endif ()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225783] trunk/Source/WebCore

[clopez]

Title: [225783] trunk/Source/WebCore








Revision 225783
Author clo...@igalia.com
Date 2017-12-12 08:46:09 -0800 (Tue, 12 Dec 2017)


Log Message
[GTK][WebRTC] Stop warning with so much verbosity about not implemented RealtimeMediaSourceCenter
https://bugs.webkit.org/show_bug.cgi?id=180694

Reviewed by Youenn Fablet.

No new tests -- no change in functionality.

* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::singleton):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (225782 => 225783)

--- trunk/Source/WebCore/ChangeLog	2017-12-12 16:12:39 UTC (rev 225782)
+++ trunk/Source/WebCore/ChangeLog	2017-12-12 16:46:09 UTC (rev 225783)
@@ -1,3 +1,15 @@
+2017-12-12  Carlos Alberto Lopez Perez  
+
+[GTK][WebRTC] Stop warning with so much verbosity about not implemented RealtimeMediaSourceCenter
+https://bugs.webkit.org/show_bug.cgi?id=180694
+
+Reviewed by Youenn Fablet.
+
+No new tests -- no change in functionality.
+
+* platform/mediastream/RealtimeMediaSourceCenter.cpp:
+(WebCore::RealtimeMediaSourceCenter::singleton):
+
 2017-12-12  Ms2ger  
 
 Implement {DOMMimeTypeArray, DOMPluginArray}::supportedPropertyNames().


Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp (225782 => 225783)

--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp	2017-12-12 16:12:39 UTC (rev 225782)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp	2017-12-12 16:46:09 UTC (rev 225783)
@@ -65,8 +65,8 @@
 if (override)
 return *override;
 #if PLATFORM(GTK)
-WTFLogAlways("WebKitGTK LIBWEBRTC RealtimeMediaSourceCenter NOT IMPLEMENTED. Returning MockRealtimeMediaSourceCenter instead to avoid crash!\n");
 ASSERT(isMainThread());
+notImplemented(); // Return MockRealtimeMediaSourceCenter to avoid crash.
 static NeverDestroyed center;
 return center;
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225780] trunk/Tools

[clopez]

Title: [225780] trunk/Tools








Revision 225780
Author clo...@igalia.com
Date 2017-12-12 06:58:05 -0800 (Tue, 12 Dec 2017)


Log Message
[GTK][WPE] Bump GStreamer version to 1.12 in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171677

Reviewed by Carlos Garcia Campos.

Bump gstreamer related modules and rebase patches still needed and not merged

* gstreamer/jhbuild.modules:
* gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed. This was needed for OpenWebRTC. Not longer supported.
* gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Rebased.
* gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Rebased.
* gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Rebased.
* gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added a note about merge commit not still in 1.12.4.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gstreamer/jhbuild.modules
trunk/Tools/gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch
trunk/Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
trunk/Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch
trunk/Tools/gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch


Removed Paths

trunk/Tools/gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch




Diff

Modified: trunk/Tools/ChangeLog (225779 => 225780)

--- trunk/Tools/ChangeLog	2017-12-12 14:29:01 UTC (rev 225779)
+++ trunk/Tools/ChangeLog	2017-12-12 14:58:05 UTC (rev 225780)
@@ -1,3 +1,19 @@
+2017-12-12  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] Bump GStreamer version to 1.12 in jhbuild
+https://bugs.webkit.org/show_bug.cgi?id=171677
+
+Reviewed by Carlos Garcia Campos.
+
+Bump gstreamer related modules and rebase patches still needed and not merged
+
+* gstreamer/jhbuild.modules:
+* gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed. This was needed for OpenWebRTC. Not longer supported.
+* gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Rebased.
+* gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Rebased.
+* gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Rebased.
+* gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added a note about merge commit not still in 1.12.4.
+
 2017-12-12  Yusuke Suzuki  
 
 [WTF] Thread::create should have Thread::tryCreate


Modified: trunk/Tools/gstreamer/jhbuild.modules (225779 => 225780)

--- trunk/Tools/gstreamer/jhbuild.modules	2017-12-12 14:29:01 UTC (rev 225779)
+++ trunk/Tools/gstreamer/jhbuild.modules	2017-12-12 14:58:05 UTC (rev 225780)
@@ -22,10 +22,9 @@
   href=""
 
   
-+ repo="gstreamer"
-hash="sha256:4fc7cca48c59fff23afee78fb642cdbde001f56401c8f47b95a16578d1d5d7e8"
-md5sum="af1bf3dab9e69f3c36f389285e2a12a1"/>
+hash="sha256:bfcd7c6563b05672386c4eedfc4c0d4a0a12b4b4775b74ec6deb88fc2bcd83ce"/>
   
 
   
@@ -47,9 +46,9 @@
 
   
 
-+ repo="gstreamer"
-hash="sha256:bc06243600817f637029da29d089d5908d1d266542f68bf6626a10c5f05f1f1d">
+hash="sha256:5a8704aa4c2eeb04da192c4a9942f94f860ac1a585de90d9f914bac26a970674">
   
 
   
@@ -63,9 +62,9 @@
 
   
 
-+ repo="gstreamer"
-hash="sha256:1c401a79bd1e4521c6ef1b66579bddedd9136e164e54792aab4bfcf3485bf9a7"/>
+hash="sha256:4c306b03df0212f1b8903784e29bb3493319ba19ebebf13b0c56a17870292282"/>
   
 
   
@@ -74,10 +73,9 @@
   
 
 
-+ repo="gstreamer"
-hash="sha256:be053f6ed716eeb517cec148cec637cdce571c6e04d5c21409e2876fb76c7639">
-  
+hash="sha256:649f49bec60892d47ee6731b92266974c723554da1c6649f21296097715eb957">
   
   
   
@@ -91,9 +89,9 @@
   
   
 
-+ repo="gstreamer"
-hash="sha256:c5806040bb83b43be86ce592e6a19c5d83d7776f7d9f434eb4b911c4efff3573"/>
+hash="sha256:0c7857be16686d5c1ba6e34bd338664d3d4599d32714a8eca5c8a41a101e2d08"/>
   
 
   
@@ -100,9 +98,9 @@
 
   
 
-+ repo="gstreamer"
-hash="sha256:e4d2f315f478d47281fbfdfbd590a63d23704ca37911d7142d5992616f4b28d3"/>
+hash="sha256:2a56aa5d2d8cd912f2bce17f174713d2c417ca298f1f9c28ee66d4aa1e1d9e62"/>
   
 
 


Deleted: 

[webkit-changes] [225336] trunk/Tools

[clopez]

Title: [225336] trunk/Tools








Revision 225336
Author clo...@igalia.com
Date 2017-11-30 11:29:54 -0800 (Thu, 30 Nov 2017)


Log Message
Add a script for automatically running the buildbot configurations on a test environment.
https://bugs.webkit.org/show_bug.cgi?id=169084

Reviewed by Michael Catanzaro.

This new script does the following:
- Creates a temporal workingdir.
- Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ).
  This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
- Copies the buildmaster config files to the temporal workingdir.
- Performs the required steps to start a buildmaster.
- Creates the required config for each slave and starts all of them.

The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
This allows to test any configuration changes on this test environment that is pretty much identical to the production one.

* BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.
(check_tcp_port_open):
(upgrade_db_needed):
(create_tempdir):
(print_if_error_stdout_stderr):
(setup_master_workdir):
(wait_for_master_ready):
(start_master):
(get_list_workers):
(start_worker):
(clean):
(cmd_exists):
(check_buildbot_installed):
(setup_virtualenv):
(configdir_is_valid):
(main):

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py (0 => 225336)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py	2017-11-30 19:29:54 UTC (rev 225336)
@@ -0,0 +1,347 @@
+#!/usr/bin/env python
+#
+# Copyright (C) 2017 Igalia S.L.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+import sys
+import signal
+import os
+import argparse
+import subprocess
+import tempfile
+import shutil
+import socket
+import json
+import traceback
+import multiprocessing
+from time import sleep
+
+test_buildbot_master_tac = """
+import os
+from twisted.application import service
+try:
+from buildbot.master.bot import BuildMaster
+except:
+from buildbot.master import BuildMaster
+
+basedir = os.path.dirname(os.path.realpath(__file__))
+configfile = r'master.cfg'
+
+application = service.Application('buildmaster')
+BuildMaster(basedir, configfile).setServiceParent(application)
+"""
+
+worker_buildbot_master_tac = """
+import os
+from twisted.application import service
+from buildslave.bot import BuildSlave
+
+basedir = os.path.dirname(os.path.realpath(__file__))
+buildmaster_host = 'localhost'
+port = 17000
+slavename = '%(worker)s'
+passwd = '1234'
+keepalive = 600
+usepty = 1
+
+application = service.Application('buildslave')
+BuildSlave(buildmaster_host, port, slavename, passwd, basedir, keepalive, usepty).setServiceParent(application)
+"""
+
+
+def check_tcp_port_open(address, port):
+s = socket.socket()
+try:
+s.connect((address, port))
+return True
+except:
+return False
+
+
+def upgrade_db_needed(log):
+try:
+with open(log) as f:
+for l in f:
+if 'upgrade the database' in l:
+return True
+except:
+return False
+return False
+
+
+def create_tempdir(tmpdir=None):
+if tmpdir is not None:
+if not os.path.isdir(tmpdir):
+raise ValueError('%s is not a directory' % tmpdir)
+return 

[webkit-changes] [225301] trunk/Source

[clopez]

Title: [225301] trunk/Source








Revision 225301
Author clo...@igalia.com
Date 2017-11-29 16:16:19 -0800 (Wed, 29 Nov 2017)


Log Message
Source/_javascript_Core:
[MIPS][JSC] Implement MacroAssembler::probe support on MIPS
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj  on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

This patch allows DFG JIT to be enabled on MIPS platforms.

* Sources.txt:
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::sprName):
* assembler/MacroAssemblerMIPS.cpp: Added.
(JSC::MacroAssembler::probe):
* assembler/ProbeContext.cpp:
(JSC::Probe::executeProbe):
* assembler/ProbeContext.h:
(JSC::Probe::CPUState::pc):
* assembler/testmasm.cpp:
(JSC::isSpecialGPR):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

Source/WTF:
[DFG][MIPS] Enable DFG JIT on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj  on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

* wtf/Platform.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/assembler/MIPSAssembler.h
trunk/Source/_javascript_Core/assembler/ProbeContext.cpp
trunk/Source/_javascript_Core/assembler/ProbeContext.h
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h


Added Paths

trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.cpp


Property Changed

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WTF/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225300 => 225301)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-29 23:23:54 UTC (rev 225300)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 00:16:19 UTC (rev 225301)
@@ -1,3 +1,29 @@
+2017-11-29  Stanislav Ocovaj  
+
+[MIPS][JSC] Implement MacroAssembler::probe support on MIPS
+https://bugs.webkit.org/show_bug.cgi?id=175447
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+This patch allows DFG JIT to be enabled on MIPS platforms.
+
+* Sources.txt:
+* assembler/MIPSAssembler.h:
+(JSC::MIPSAssembler::lastSPRegister):
+(JSC::MIPSAssembler::numberOfSPRegisters):
+(JSC::MIPSAssembler::sprName):
+* assembler/MacroAssemblerMIPS.cpp: Added.
+(JSC::MacroAssembler::probe):
+* assembler/ProbeContext.cpp:
+(JSC::Probe::executeProbe):
+* assembler/ProbeContext.h:
+(JSC::Probe::CPUState::pc):
+* assembler/testmasm.cpp:
+(JSC::isSpecialGPR):
+(JSC::testProbePreservesGPRS):
+(JSC::testProbeModifiesStackPointer):
+(JSC::testProbeModifiesStackValues):
+
 2017-11-29  Matt Lewis  
 
 Unreviewed, rolling out r225286.
Property changes on: trunk/Source/_javascript_Core/ChangeLog
___


Deleted: svn:executable
-*
\ No newline at end of property

Modified: trunk/Source/_javascript_Core/Sources.txt (225300 => 225301)

--- trunk/Source/_javascript_Core/Sources.txt	2017-11-29 23:23:54 UTC (rev 225300)
+++ trunk/Source/_javascript_Core/Sources.txt	2017-11-30 00:16:19 UTC (rev 225301)
@@ -47,6 +47,7 @@
 assembler/MacroAssemblerARM64.cpp
 assembler/MacroAssemblerARMv7.cpp
 assembler/MacroAssemblerCodeRef.cpp
+assembler/MacroAssemblerMIPS.cpp
 assembler/MacroAssemblerPrinter.cpp
 assembler/MacroAssemblerX86Common.cpp
 assembler/Printer.cpp


Modified: trunk/Source/_javascript_Core/assembler/MIPSAssembler.h (225300 => 225301)

--- trunk/Source/_javascript_Core/assembler/MIPSAssembler.h	2017-11-29 23:23:54 UTC (rev 225300)
+++ trunk/Source/_javascript_Core/assembler/MIPSAssembler.h	2017-11-30 00:16:19 UTC (rev 225301)
@@ -113,7 +113,8 @@
 fccr = 25,
 fexr = 26,
 fenr = 28,
-fcsr = 31
+fcsr = 31,
+pc
 } SPRegisterID;
 
 typedef enum {
@@ -165,8 +166,8 @@
 static constexpr unsigned numberOfRegisters() { return lastRegister() - firstRegister() + 1; }
 
 static constexpr SPRegisterID firstSPRegister() { return MIPSRegisters::fir; }
-static constexpr SPRegisterID lastSPRegister() { return MIPSRegisters::fcsr; }
-static constexpr unsigned numberOfSPRegisters() { return 5; }
+static constexpr SPRegisterID lastSPRegister() { return MIPSRegisters::pc; }
+static constexpr unsigned numberOfSPRegisters() { return lastSPRegister() - firstSPRegister() + 1; }
 
 static constexpr FPRegisterID firstFPRegister() { return MIPSRegisters::f0; }
 static constexpr FPRegisterID lastFPRegister() { return MIPSRegisters::f31; }
@@ -197,6 +198,8 @@
 return "fenr";
 case MIPSRegisters::fcsr:
 return "fcsr";
+case MIPSRegisters::pc:
+return 

[webkit-changes] [225134] trunk/LayoutTests

[clopez]

Title: [225134] trunk/LayoutTests








Revision 225134
Author clo...@igalia.com
Date 2017-11-24 06:17:59 -0800 (Fri, 24 Nov 2017)


Log Message
REGRESSION(r225098): [WPE] Gardening of tests after r225098.

70 new failures after some features changed of value.
Reported on https://bugs.webkit.org/show_bug.cgi?id=180004
Remove also 2 duplicated entries on the expectations file.

Unreviewed gardening.

* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225133 => 225134)

--- trunk/LayoutTests/ChangeLog	2017-11-24 13:30:36 UTC (rev 225133)
+++ trunk/LayoutTests/ChangeLog	2017-11-24 14:17:59 UTC (rev 225134)
@@ -1,3 +1,15 @@
+2017-11-24  Carlos Alberto Lopez Perez  
+
+REGRESSION(r225098): [WPE] Gardening of tests after r225098.
+
+70 new failures after some features changed of value.
+Reported on https://bugs.webkit.org/show_bug.cgi?id=180004
+Remove also 2 duplicated entries on the expectations file.
+
+Unreviewed gardening.
+
+* platform/wpe/TestExpectations:
+
 2017-11-24  Antoine Quint  
 
 [Web Animations] Allow getComputedStyle() to return animated values for accelerated animations


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (225133 => 225134)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-11-24 13:30:36 UTC (rev 225133)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-11-24 14:17:59 UTC (rev 225134)
@@ -991,7 +991,6 @@
 webkit.org/b/107018 svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg [ ImageOnlyFailure ]
 webkit.org/b/99893 svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg [ ImageOnlyFailure ]
 webkit.org/b/110446 svg/as-background-image/svg-transformed-background.html [ ImageOnlyFailure ]
-Bug(WPE) svg/as-image/svg-as-image-canvas.html [ ImageOnlyFailure Crash ]
 webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-006.svg [ ImageOnlyFailure ]
 webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-007.svg [ ImageOnlyFailure ]
 webkit.org/b/129958 svg/clip-path/mask-nested-clip-path-008.svg [ ImageOnlyFailure ]
@@ -1006,7 +1005,6 @@
 webkit.org/b/163830 svg/css/mix-blend-mode-with-inline-svg.html [ ImageOnlyFailure ]
 webkit.org/b/135529 svg/css/parse-height.html [ Failure ]
 webkit.org/b/135529 svg/css/parse-length.html [ Failure ]
-Bug(WPE) svg/css/svg-resource-fragment-identifier-img-src.html [ ImageOnlyFailure Crash ]
 webkit.org/b/163831 svg/custom/acid3-test-77.html [ Failure ]
 webkit.org/b/163832 svg/custom/filter-update-different-root.html [ ImageOnlyFailure ]
 webkit.org/b/134758 svg/custom/composited-svg-with-opacity.html [ ImageOnlyFailure Pass ]
@@ -1048,3 +1046,75 @@
 webkit.org/b/179897 imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm [ Failure ]
 
 webkit.org/b/179898 svg/animations/svglengthlist-animation-3.html [ Pass Failure ]
+
+# Some features have changed of value after r225098
+webkit.org/b/180004 fast/canvas/webgl/webgl2-buffer-targets.html [ Failure ]
+webkit.org/b/180004 fast/canvas/webgl/webgl2-context-creation.html [ Failure ]
+webkit.org/b/180004 fast/canvas/webgl/webgl2-getActiveUniforms.html [ Failure ]
+webkit.org/b/180004 fast/canvas/webgl/webgl2-runtime-flag.html [ Failure ]
+webkit.org/b/180004 fast/canvas/webgl/webgl2-texStorage.html [ Failure ]
+webkit.org/b/180004 fast/canvas/webgl/webgl2/constants.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-events.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events.html [ Failure ]
+webkit.org/b/180004 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license.html [ Failure ]
+webkit.org/b/180004 

[webkit-changes] [225126] trunk/LayoutTests

[clopez]

Title: [225126] trunk/LayoutTests








Revision 225126
Author clo...@igalia.com
Date 2017-11-23 17:25:56 -0800 (Thu, 23 Nov 2017)


Log Message
REGRESSION(r225098): [GTK] Gardening of tests after r225098.
https://bugs.webkit.org/show_bug.cgi?id=179989

Unreviewed.

Mark new expected failures meanwhile the issue is not fixed.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225125 => 225126)

--- trunk/LayoutTests/ChangeLog	2017-11-24 00:47:58 UTC (rev 225125)
+++ trunk/LayoutTests/ChangeLog	2017-11-24 01:25:56 UTC (rev 225126)
@@ -1,3 +1,14 @@
+2017-11-23  Carlos Alberto Lopez Perez  
+
+REGRESSION(r225098): [GTK] Gardening of tests after r225098.
+https://bugs.webkit.org/show_bug.cgi?id=179989
+
+Unreviewed.
+
+Mark new expected failures meanwhile the issue is not fixed.
+
+* platform/gtk/TestExpectations:
+
 2017-11-23  Simon Fraser  
 
 Add support for CanvasPattern.setTransform()


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (225125 => 225126)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-11-24 00:47:58 UTC (rev 225125)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-11-24 01:25:56 UTC (rev 225126)
@@ -1196,6 +1196,19 @@
 
 webkit.org/b/179052 compositing/contents-format/subpixel-antialiased-nested-layer.html [ Failure ]
 
+webkit.org/b/179989 http/tests/misc/prefetch-purpose.html [ Timeout ]
+webkit.org/b/179989 http/tests/misc/link-rel-prefetch-and-subresource.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/subresource.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onload.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch-onerror.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/prefetch.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Timeout ]
+webkit.org/b/179989 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Timeout ]
+webkit.org/b/179989 fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html [ Failure ]
+webkit.org/b/179989 fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html [ Failure ]
+webkit.org/b/179989 fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html [ Failure ]
+webkit.org/b/179989 fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html [ Failure ]
+
 #
 # End of Expected failures
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225124] trunk/Source/WebCore

[clopez]

Title: [225124] trunk/Source/WebCore








Revision 225124
Author clo...@igalia.com
Date 2017-11-23 16:35:31 -0800 (Thu, 23 Nov 2017)


Log Message
[GTK] [Debug] Fix build after r225117.
https://bugs.webkit.org/show_bug.cgi?id=179907

Unreviewed build fix.

r225117 renamed containsOnlyASCII() to isAllASCII().
And this reference was not updated for the GTK Debug build.

No new tests, its a build fix.

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (225123 => 225124)

--- trunk/Source/WebCore/ChangeLog	2017-11-23 22:23:15 UTC (rev 225123)
+++ trunk/Source/WebCore/ChangeLog	2017-11-24 00:35:31 UTC (rev 225124)
@@ -1,3 +1,18 @@
+2017-11-23  Carlos Alberto Lopez Perez  
+
+[GTK] [Debug] Fix build after r225117.
+https://bugs.webkit.org/show_bug.cgi?id=179907
+
+Unreviewed build fix.
+
+r225117 renamed containsOnlyASCII() to isAllASCII().
+And this reference was not updated for the GTK Debug build.
+
+No new tests, its a build fix.
+
+* loader/archive/mhtml/MHTMLArchive.cpp:
+(WebCore::MHTMLArchive::generateMHTMLData):
+
 2017-11-23  Simon Fraser  
 
 FELighting cleanup and optimization


Modified: trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp (225123 => 225124)

--- trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp	2017-11-23 22:23:15 UTC (rev 225123)
+++ trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp	2017-11-24 00:35:31 UTC (rev 225124)
@@ -160,7 +160,7 @@
 stringBuilder.append("\"\r\n\r\n");
 
 // We use utf8() below instead of ascii() as ascii() replaces CRLFs with ?? (we still only have put ASCII characters in it).
-ASSERT(stringBuilder.toString().containsOnlyASCII());
+ASSERT(stringBuilder.toString().isAllASCII());
 CString asciiString = stringBuilder.toString().utf8();
 auto mhtmlData = SharedBuffer::create();
 mhtmlData->append(asciiString.data(), asciiString.length());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225051] trunk/Source/WebCore

[clopez]

Title: [225051] trunk/Source/WebCore








Revision 225051
Author clo...@igalia.com
Date 2017-11-20 07:57:57 -0800 (Mon, 20 Nov 2017)


Log Message
[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}
https://bugs.webkit.org/show_bug.cgi?id=179511

Reviewed by Žan Doberšek.

r217208 changed the definition of GLNativeWindowType from EGLNativeWindowType to uint64_t for platform WPE.
This built fine on a 64-bit platform since uint64_t matches the size of a pointer, but fails on 32-bits.

This switches back the definition to EGLNativeWindowType.
And we need to include  first in order to get a definition for EGLNativeWindowType itself.

This commit pretty much reverts the changes r217208 did on platform/graphics/GLContext.h

No new tests, it is a build fix.

* platform/graphics/GLContext.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GLContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225050 => 225051)

--- trunk/Source/WebCore/ChangeLog	2017-11-20 15:46:17 UTC (rev 225050)
+++ trunk/Source/WebCore/ChangeLog	2017-11-20 15:57:57 UTC (rev 225051)
@@ -1,3 +1,22 @@
+2017-11-20  Carlos Alberto Lopez Perez  
+
+[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}
+https://bugs.webkit.org/show_bug.cgi?id=179511
+
+Reviewed by Žan Doberšek.
+
+r217208 changed the definition of GLNativeWindowType from EGLNativeWindowType to uint64_t for platform WPE.
+This built fine on a 64-bit platform since uint64_t matches the size of a pointer, but fails on 32-bits.
+
+This switches back the definition to EGLNativeWindowType.
+And we need to include  first in order to get a definition for EGLNativeWindowType itself.
+
+This commit pretty much reverts the changes r217208 did on platform/graphics/GLContext.h
+
+No new tests, it is a build fix.
+
+* platform/graphics/GLContext.h:
+
 2017-11-20  Michael Catanzaro  
 
 Remove ENABLE_ALLINONE_BUILD option


Modified: trunk/Source/WebCore/platform/graphics/GLContext.h (225050 => 225051)

--- trunk/Source/WebCore/platform/graphics/GLContext.h	2017-11-20 15:46:17 UTC (rev 225050)
+++ trunk/Source/WebCore/platform/graphics/GLContext.h	2017-11-20 15:57:57 UTC (rev 225051)
@@ -24,10 +24,17 @@
 #include "PlatformDisplay.h"
 #include 
 
-#if USE(EGL) && !PLATFORM(GTK) && !PLATFORM(WPE)
+#if USE(EGL) && !PLATFORM(GTK)
+#if PLATFORM(WPE)
+// FIXME: For now default to the GBM EGL platform, but this should really be
+// somehow deducible from the build configuration.
+#define __GBM__ 1
+#include 
+#else
 #include "eglplatform.h"
+#endif // PLATFORM(WPE)
 typedef EGLNativeWindowType GLNativeWindowType;
-#else
+#else // !USE(EGL) || PLATFORM(GTK)
 typedef uint64_t GLNativeWindowType;
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [224643] trunk/Tools

[clopez]

Title: [224643] trunk/Tools








Revision 224643
Author clo...@igalia.com
Date 2017-11-09 12:56:27 -0800 (Thu, 09 Nov 2017)


Log Message
[WPE] Update dyz (WPE MiniBrowser)
https://bugs.webkit.org/show_bug.cgi?id=179492

Reviewed by Michael Catanzaro.

Update it to the last version as of today.
This version not longer uses the C API.

* wpe/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (224642 => 224643)

--- trunk/Tools/ChangeLog	2017-11-09 20:56:03 UTC (rev 224642)
+++ trunk/Tools/ChangeLog	2017-11-09 20:56:27 UTC (rev 224643)
@@ -1,3 +1,15 @@
+2017-11-09  Carlos Alberto Lopez Perez  
+
+[WPE] Update dyz (WPE MiniBrowser)
+https://bugs.webkit.org/show_bug.cgi?id=179492
+
+Reviewed by Michael Catanzaro.
+
+Update it to the last version as of today.
+This version not longer uses the C API.
+
+* wpe/jhbuild.modules:
+
 2017-11-09  Christopher Reid  
 
 Use enum classes within FileSystem


Modified: trunk/Tools/wpe/jhbuild.modules (224642 => 224643)

--- trunk/Tools/wpe/jhbuild.modules	2017-11-09 20:56:03 UTC (rev 224642)
+++ trunk/Tools/wpe/jhbuild.modules	2017-11-09 20:56:27 UTC (rev 224643)
@@ -211,7 +211,7 @@
   
 
   
-
+
   
 
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [224624] trunk/LayoutTests

[clopez]

Title: [224624] trunk/LayoutTests








Revision 224624
Author clo...@igalia.com
Date 2017-11-09 04:36:07 -0800 (Thu, 09 Nov 2017)


Log Message
[GTK] Gardening 09 nov
https://bugs.webkit.org/show_bug.cgi?id=179472

Unreviewed GTK gardening


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (224623 => 224624)

--- trunk/LayoutTests/ChangeLog	2017-11-09 09:02:10 UTC (rev 224623)
+++ trunk/LayoutTests/ChangeLog	2017-11-09 12:36:07 UTC (rev 224624)
@@ -1,3 +1,12 @@
+2017-11-09  Carlos Alberto Lopez Perez  
+
+[GTK] Gardening 09 nov
+https://bugs.webkit.org/show_bug.cgi?id=179472
+
+Unreviewed GTK gardening
+
+* platform/gtk/TestExpectations:
+
 2017-11-09  Alicia Boya García  
 
 [GTK] Test gardening


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (224623 => 224624)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-11-09 09:02:10 UTC (rev 224623)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-11-09 12:36:07 UTC (rev 224624)
@@ -2201,6 +2201,33 @@
 
 webkit.org/b/178792 fast/events/touch/touch-inside-iframe.html [ Timeout ]
 
+webkit.org/b/179471 inspector/console/console-message.html [ Timeout ]
+webkit.org/b/179471 inspector/console/console-time.html [ Timeout ]
+webkit.org/b/179471 inspector/console/heapSnapshot.html [ Timeout ]
+webkit.org/b/179471 inspector/console/js-source-locations.html [ Timeout ]
+webkit.org/b/179471 inspector/console/x-frame-options-message.html [ Timeout ]
+webkit.org/b/179471 inspector/heap/tracking.html [ Timeout ]
+webkit.org/b/179471 inspector/layers/layers-anonymous.html [ Timeout ]
+webkit.org/b/179471 inspector/layers/layers-compositing-reasons.html [ Timeout ]
+webkit.org/b/179471 inspector/layers/layers-for-node.html [ Timeout ]
+webkit.org/b/179471 inspector/layers/layers-generated-content.html [ Timeout ]
+webkit.org/b/179471 inspector/layers/layers-reflected-content.html [ Timeout ]
+webkit.org/b/179471 inspector/memory/tracking.html [ Timeout ]
+webkit.org/b/179471 inspector/page/media-query-list-listener-exception.html [ Timeout ]
+webkit.org/b/179471 inspector/protocol/backend-dispatcher-argument-errors.html [ Timeout ]
+webkit.org/b/179471 inspector/protocol/backend-dispatcher-malformed-message-errors.html [ Timeout ]
+webkit.org/b/179471 inspector/runtime/CommandLineAPI-inspect.html [ Timeout ]
+webkit.org/b/179471 inspector/script-profiler/event-type-API.html [ Timeout ]
+webkit.org/b/179471 inspector/script-profiler/event-type-Microtask.html [ Timeout ]
+webkit.org/b/179471 inspector/script-profiler/event-type-Other.html [ Timeout ]
+webkit.org/b/179471 inspector/script-profiler/tracking.html [ Timeout ]
+webkit.org/b/179471 inspector/unit-tests/async-test-suite.html [ Timeout ]
+webkit.org/b/179471 inspector/unit-tests/protocol-test-dispatch-event-to-frontend.html [ Timeout ]
+webkit.org/b/179471 inspector/unit-tests/sync-test-suite.html [ Timeout ]
+webkit.org/b/179471 inspector/worker/worker-create-and-terminate.html [ Timeout ]
+webkit.org/b/179471 inspector/worker/worker-recover-if-inspector-close.html [ Timeout ]
+webkit.org/b/179471 inspector/unit-tests/breakpoint-log-message-lexer.html [ Timeout ]
+
 #
 # End of Tests timing out
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [224331] trunk/Tools

[clopez]

Title: [224331] trunk/Tools








Revision 224331
Author clo...@igalia.com
Date 2017-11-02 07:48:07 -0700 (Thu, 02 Nov 2017)


Log Message
[WPE][JHBuild] Update WPEBackend and WPEBackend-mesa
https://bugs.webkit.org/show_bug.cgi?id=179169

Reviewed by Michael Catanzaro.

Update WPEBackend and WPEBackend-mesa to last master as of today.

* wpe/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (224330 => 224331)

--- trunk/Tools/ChangeLog	2017-11-02 13:56:48 UTC (rev 224330)
+++ trunk/Tools/ChangeLog	2017-11-02 14:48:07 UTC (rev 224331)
@@ -1,3 +1,14 @@
+2017-11-02  Carlos Alberto Lopez Perez  
+
+[WPE][JHBuild] Update WPEBackend and WPEBackend-mesa
+https://bugs.webkit.org/show_bug.cgi?id=179169
+
+Reviewed by Michael Catanzaro.
+
+Update WPEBackend and WPEBackend-mesa to last master as of today.
+
+* wpe/jhbuild.modules:
+
 2017-11-02  Frederic Wang  
 
 Add references to bug 179167 in FIXME comments


Modified: trunk/Tools/wpe/jhbuild.modules (224330 => 224331)

--- trunk/Tools/wpe/jhbuild.modules	2017-11-02 13:56:48 UTC (rev 224330)
+++ trunk/Tools/wpe/jhbuild.modules	2017-11-02 14:48:07 UTC (rev 224331)
@@ -171,7 +171,7 @@
 
   
 -tag="5e2a29d2ccc637f7122ba72c1d62ef669b42f05c" />
+tag="3013faaebab42e7ef7497b3850a2902978eb3d6f" />
   
 
   
@@ -182,7 +182,7 @@
   
 
 -tag="0286aed84a09120de16c3ab08bdf83c91d4a1754" />
+tag="ce2a0ad98d1746d5b0fa743121a6ebb148ab92c1" />
   
 
   






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [224178] trunk/LayoutTests

[clopez]

Title: [224178] trunk/LayoutTests








Revision 224178
Author clo...@igalia.com
Date 2017-10-30 06:39:27 -0700 (Mon, 30 Oct 2017)


Log Message
[GTK] Rebaseline affected tests after r224177
https://bugs.webkit.org/show_bug.cgi?id=178933

Unreviewed gardening.

* platform/gtk/editing/deleting/4922367-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-023-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-024-expected.txt:
* platform/gtk/editing/deleting/delete-br-008-expected.txt:
* platform/gtk/editing/deleting/delete-br-010-expected.txt:
* platform/gtk/editing/deleting/delete-line-015-expected.txt:
* platform/gtk/editing/deleting/delete-line-016-expected.txt:
* platform/gtk/editing/deleting/delete-line-017-expected.txt:
* platform/gtk/editing/deleting/merge-no-br-expected.txt:
* platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
* platform/gtk/editing/execCommand/4747450-expected.txt:
* platform/gtk/editing/execCommand/4916402-expected.txt:
* platform/gtk/editing/execCommand/4916541-expected.txt:
* platform/gtk/editing/execCommand/4924441-expected.txt:
* platform/gtk/editing/execCommand/5136770-expected.txt:
* platform/gtk/editing/execCommand/5142012-2-expected.txt:
* platform/gtk/editing/execCommand/5190926-expected.txt:
* platform/gtk/editing/execCommand/5481523-expected.txt:
* platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
* platform/gtk/editing/execCommand/indent-selection-expected.txt:
* platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt:
* platform/gtk/editing/execCommand/nsresponder-indent-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-004-expected.txt:
* platform/gtk/editing/inserting/insert-br-quoted-006-expected.txt:
* platform/gtk/editing/pasteboard/5071074-2-expected.txt:
* platform/gtk/editing/pasteboard/displaced-generic-placeholder-expected.txt:
* platform/gtk/editing/pasteboard/displaced-placeholder-expected.txt:
* platform/gtk/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/gtk/editing/pasteboard/merge-after-delete-expected.txt:
* platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
* platform/gtk/editing/pasteboard/undoable-fragment-removes-expected.txt:
* platform/gtk/editing/pasteboard/unrendered-br-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/gtk/editing/style/4916887-expected.txt:
* platform/gtk/editing/style/5046875-1-expected.txt:
* platform/gtk/editing/style/5046875-2-expected.txt:
* platform/gtk/editing/style/5279521-expected.txt:
* platform/gtk/editing/style/create-block-for-style-003-expected.txt:
* platform/gtk/editing/style/create-block-for-style-004-expected.txt:
* platform/gtk/editing/style/create-block-for-style-007-expected.txt:
* platform/gtk/editing/style/create-block-for-style-009-expected.txt:
* platform/gtk/editing/style/create-block-for-style-010-expected.txt:
* platform/gtk/editing/style/create-block-for-style-011-expected.txt:
* platform/gtk/editing/style/create-block-for-style-012-expected.txt:
* platform/gtk/editing/style/create-block-for-style-013-expected.txt:
* platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
* platform/gtk/fast/forms/button-generated-content-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/deleting/4922367-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/delete-block-merge-contents-005-expected.txt

[webkit-changes] [222969] trunk/Source/WebCore

[clopez]

Title: [222969] trunk/Source/WebCore








Revision 222969
Author clo...@igalia.com
Date 2017-10-06 01:52:33 -0700 (Fri, 06 Oct 2017)


Log Message
[GTK][Clang] Build fix after r222926
https://bugs.webkit.org/show_bug.cgi?id=175384

Unreviewed build fix.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::setStatus):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFace.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (222968 => 222969)

--- trunk/Source/WebCore/ChangeLog	2017-10-06 08:36:36 UTC (rev 222968)
+++ trunk/Source/WebCore/ChangeLog	2017-10-06 08:52:33 UTC (rev 222969)
@@ -1,3 +1,13 @@
+2017-10-06  Carlos Alberto Lopez Perez  
+
+[GTK][Clang] Build fix after r222926
+https://bugs.webkit.org/show_bug.cgi?id=175384
+
+Unreviewed build fix.
+
+* css/CSSFontFace.cpp:
+(WebCore::CSSFontFace::setStatus):
+
 2017-10-06  Enrique Ocaña González  
 
 [MSE][GStreamer] Seek on youtube.com/tv fails after r217185


Modified: trunk/Source/WebCore/css/CSSFontFace.cpp (222968 => 222969)

--- trunk/Source/WebCore/css/CSSFontFace.cpp	2017-10-06 08:36:36 UTC (rev 222968)
+++ trunk/Source/WebCore/css/CSSFontFace.cpp	2017-10-06 08:52:33 UTC (rev 222969)
@@ -661,13 +661,13 @@
 case Status::Loading:
 if (blockPeriodTimeout == 0_s)
 setStatus(Status::TimedOut);
-else if (isfinite(blockPeriodTimeout.value()))
+else if (std::isfinite(blockPeriodTimeout.value()))
 m_timeoutTimer.startOneShot(blockPeriodTimeout);
 break;
 case Status::TimedOut:
 if (swapPeriodTimeout == 0_s)
 setStatus(Status::Failure);
-else if (isfinite(swapPeriodTimeout.value()))
+else if (std::isfinite(swapPeriodTimeout.value()))
 m_timeoutTimer.startOneShot(swapPeriodTimeout);
 break;
 case Status::Success:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222930] trunk

[clopez]

Title: [222930] trunk








Revision 222930
Author clo...@igalia.com
Date 2017-10-05 13:39:04 -0700 (Thu, 05 Oct 2017)


Log Message
Generate a compile error if release is built without compiler optimizations
https://bugs.webkit.org/show_bug.cgi?id=177665

Reviewed by Brian Burg.

.:

Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.

* CMakeLists.txt:

Source/_javascript_Core:

Pass -DRELEASE_WITHOUT_OPTIMIZATIONS to testair.cpp and testb3.cpp because
this files are compiled with -O0 for build speed reasons after r195639.

* _javascript_Core.xcodeproj/project.pbxproj:

Source/WTF:

For GCC and Clang, generate an error at build time that will alert
the developer that she is trying to build Release without any compiler
optimization. A build time error is much better than an unexpected
"oh, WebKit is really slow ..."  situation later.

If this was intended, then we tell the developer that she can continue
by just setting -DRELEASE_WITHOUT_OPTIMIZATIONS in the list of build
flags.

The intention of this patch is to ensure that nobody builds Release
without enabling compiler optimization by mistake.

* wtf/Compiler.h:

Modified Paths

trunk/CMakeLists.txt
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h




Diff

Modified: trunk/CMakeLists.txt (222929 => 222930)

--- trunk/CMakeLists.txt	2017-10-05 19:58:08 UTC (rev 222929)
+++ trunk/CMakeLists.txt	2017-10-05 20:39:04 UTC (rev 222930)
@@ -1,4 +1,15 @@
+# -
+# Determine CMake version and build type.
+# -
 cmake_minimum_required(VERSION 3.3)
+
+if (NOT CMAKE_BUILD_TYPE)
+message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
+set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
+else ()
+message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
+endif ()
+
 project(WebKit)
 
 set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")


Modified: trunk/ChangeLog (222929 => 222930)

--- trunk/ChangeLog	2017-10-05 19:58:08 UTC (rev 222929)
+++ trunk/ChangeLog	2017-10-05 20:39:04 UTC (rev 222930)
@@ -1,3 +1,14 @@
+2017-10-05  Carlos Alberto Lopez Perez  
+
+Generate a compile error if release is built without compiler optimizations
+https://bugs.webkit.org/show_bug.cgi?id=177665
+
+Reviewed by Brian Burg.
+
+Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
+
+* CMakeLists.txt:
+
 2017-10-05  Tim Horton  
 
 Make progress toward properly-formed XPC services in the Mac CMake build


Modified: trunk/Source/_javascript_Core/ChangeLog (222929 => 222930)

--- trunk/Source/_javascript_Core/ChangeLog	2017-10-05 19:58:08 UTC (rev 222929)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-05 20:39:04 UTC (rev 222930)
@@ -1,3 +1,15 @@
+2017-10-05  Carlos Alberto Lopez Perez  
+
+Generate a compile error if release is built without compiler optimizations
+https://bugs.webkit.org/show_bug.cgi?id=177665
+
+Reviewed by Brian Burg.
+
+Pass -DRELEASE_WITHOUT_OPTIMIZATIONS to testair.cpp and testb3.cpp because
+this files are compiled with -O0 for build speed reasons after r195639.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+
 2017-10-05  Saam Barati  
 
 Only add prototypes to the PrototypeMap if they're not already present


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (222929 => 222930)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-05 19:58:08 UTC (rev 222929)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-05 20:39:04 UTC (rev 222930)
@@ -344,7 +344,7 @@
 		0F6183311C45BF070072450B /* AirLowerMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F6183281C45BF070072450B /* AirLowerMacros.h */; };
 		0F61833C1C45F62A0072450B /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
 		0F61833D1C45F62A0072450B /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* _javascript_Core.framework */; };
-		0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
+		0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
 		0F620174143FCD330068B77C /* DFGVariableAccessData.h in Headers */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [222851] trunk/Tools

[clopez]

Title: [222851] trunk/Tools








Revision 222851
Author clo...@igalia.com
Date 2017-10-04 09:54:16 -0700 (Wed, 04 Oct 2017)


Log Message
[JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
https://bugs.webkit.org/show_bug.cgi?id=177865

Reviewed by Michael Catanzaro.

Build freetype6 without harfbuzz support.
This seems to be what distros like Fedora, Debian or OpenEmbedded do.
Also explicitly enable support for freetype and fontconfig on harfbuzz.

* gtk/jhbuild.modules: Enable also support for icu.
* wpe/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules
trunk/Tools/wpe/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (222850 => 222851)

--- trunk/Tools/ChangeLog	2017-10-04 15:18:00 UTC (rev 222850)
+++ trunk/Tools/ChangeLog	2017-10-04 16:54:16 UTC (rev 222851)
@@ -1,3 +1,17 @@
+2017-10-04  Carlos Alberto Lopez Perez  
+
+[JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
+https://bugs.webkit.org/show_bug.cgi?id=177865
+
+Reviewed by Michael Catanzaro.
+
+Build freetype6 without harfbuzz support.
+This seems to be what distros like Fedora, Debian or OpenEmbedded do.
+Also explicitly enable support for freetype and fontconfig on harfbuzz.
+
+* gtk/jhbuild.modules: Enable also support for icu.
+* wpe/jhbuild.modules:
+
 2017-10-04  Yusuke Suzuki  
 
 [Test262] Update Test262 to Oct 4 version


Modified: trunk/Tools/gtk/jhbuild.modules (222850 => 222851)

--- trunk/Tools/gtk/jhbuild.modules	2017-10-04 15:18:00 UTC (rev 222850)
+++ trunk/Tools/gtk/jhbuild.modules	2017-10-04 16:54:16 UTC (rev 222851)
@@ -118,15 +118,19 @@
 
   
 
-  
+  
  repo="savannah.gnu.org"
 hash="sha256:a3c603ed84c3c2495f9c9331fe6bba3bb0ee65e06ec331e0a0fb52158291b40b"/>
   
 
-  
+  
 
   
+  
+  
 
  version="1.4.2"


Modified: trunk/Tools/wpe/jhbuild.modules (222850 => 222851)

--- trunk/Tools/wpe/jhbuild.modules	2017-10-04 15:18:00 UTC (rev 222850)
+++ trunk/Tools/wpe/jhbuild.modules	2017-10-04 16:54:16 UTC (rev 222851)
@@ -100,11 +100,11 @@
 
   
 
-  
+  
  repo="savannah.gnu.org"
-hash="sha256:a3c603ed84c3c2495f9c9331fe6bba3bb0ee65e06ec331e0a0fb52158291b40b">
-
+hash="sha256:a3c603ed84c3c2495f9c9331fe6bba3bb0ee65e06ec331e0a0fb52158291b40b"/>
   
 
   
@@ -117,9 +117,10 @@
   
 
   -autogenargs="--with-cairo=no --with-glib=no --with-freetype=yes">
+autogenargs="--with-cairo=no --with-glib=no --with-freetype=yes --with-fontconfig=yes">
 
   
+  
 
  version="1.3.3"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222840] trunk

[clopez]

Title: [222840] trunk








Revision 222840
Author clo...@igalia.com
Date 2017-10-04 05:08:55 -0700 (Wed, 04 Oct 2017)


Log Message
Generate a compile error if release is built without compiler optimizations
https://bugs.webkit.org/show_bug.cgi?id=177665

Reviewed by Michael Catanzaro.

.:

Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.

* CMakeLists.txt:

Source/_javascript_Core:

Pass -DRELEASE_WITHOUT_OPTIMIZATIONS to testair.cpp and testb3.cpp because
this files are compiled with -O0 for build speed reasons after r195639.

* _javascript_Core.xcodeproj/project.pbxproj:

Source/WTF:

For GCC and Clang, generate an error at build time that will alert
the developer that she is trying to build Release without any compiler
optimization. A build time error is much better than an unexpected
"oh, WebKit is really slow ..."  situation later.

If this was intended, then we tell the developer that she can continue
by just setting -DRELEASE_WITHOUT_OPTIMIZATIONS in the list of build
flags.

The intention of this patch is to ensure that nobody builds Release
without enabling compiler optimization by mistake.

* wtf/Compiler.h:

Modified Paths

trunk/CMakeLists.txt
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h




Diff

Modified: trunk/CMakeLists.txt (222839 => 222840)

--- trunk/CMakeLists.txt	2017-10-04 11:06:15 UTC (rev 222839)
+++ trunk/CMakeLists.txt	2017-10-04 12:08:55 UTC (rev 222840)
@@ -1,4 +1,15 @@
+# -
+# Determine CMake version and build type.
+# -
 cmake_minimum_required(VERSION 3.3)
+
+if (NOT CMAKE_BUILD_TYPE)
+message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
+set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
+else ()
+message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
+endif ()
+
 project(WebKit)
 
 set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")


Modified: trunk/ChangeLog (222839 => 222840)

--- trunk/ChangeLog	2017-10-04 11:06:15 UTC (rev 222839)
+++ trunk/ChangeLog	2017-10-04 12:08:55 UTC (rev 222840)
@@ -1,3 +1,14 @@
+2017-10-04  Carlos Alberto Lopez Perez  
+
+Generate a compile error if release is built without compiler optimizations
+https://bugs.webkit.org/show_bug.cgi?id=177665
+
+Reviewed by Michael Catanzaro.
+
+Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
+
+* CMakeLists.txt:
+
 2017-10-03  Gustavo Noronha Silva  
 
 [GLib] Let WebCore know of low power situations


Modified: trunk/Source/_javascript_Core/ChangeLog (222839 => 222840)

--- trunk/Source/_javascript_Core/ChangeLog	2017-10-04 11:06:15 UTC (rev 222839)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-10-04 12:08:55 UTC (rev 222840)
@@ -1,3 +1,15 @@
+2017-10-04  Carlos Alberto Lopez Perez  
+
+Generate a compile error if release is built without compiler optimizations
+https://bugs.webkit.org/show_bug.cgi?id=177665
+
+Reviewed by Michael Catanzaro.
+
+Pass -DRELEASE_WITHOUT_OPTIMIZATIONS to testair.cpp and testb3.cpp because
+this files are compiled with -O0 for build speed reasons after r195639.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+
 2017-10-03  Jon Davis  
 
 Update WebAssembly to "Supported"


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (222839 => 222840)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-04 11:06:15 UTC (rev 222839)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2017-10-04 12:08:55 UTC (rev 222840)
@@ -344,7 +344,7 @@
 		0F6183311C45BF070072450B /* AirLowerMacros.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F6183281C45BF070072450B /* AirLowerMacros.h */; };
 		0F61833C1C45F62A0072450B /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
 		0F61833D1C45F62A0072450B /* _javascript_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* _javascript_Core.framework */; };
-		0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
+		0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
 		0F620174143FCD330068B77C /* DFGVariableAccessData.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F620172143FCD2F0068B77C /* 

[webkit-changes] [222644] trunk/LayoutTests

[clopez]

Title: [222644] trunk/LayoutTests








Revision 222644
Author clo...@igalia.com
Date 2017-09-28 19:35:27 -0700 (Thu, 28 Sep 2017)


Log Message
[GTK] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=177635

Unreviewed test gardening.


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (222643 => 222644)

--- trunk/LayoutTests/ChangeLog	2017-09-29 02:22:22 UTC (rev 222643)
+++ trunk/LayoutTests/ChangeLog	2017-09-29 02:35:27 UTC (rev 222644)
@@ -1,3 +1,12 @@
+2017-09-28  Carlos Alberto Lopez Perez  
+
+[GTK] Test gardening
+https://bugs.webkit.org/show_bug.cgi?id=177635
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+
 2017-09-28  Megan Gardner  
 
 Clean up Long Press Selection Tests


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (222643 => 222644)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-09-29 02:22:22 UTC (rev 222643)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-09-29 02:35:27 UTC (rev 222644)
@@ -1256,6 +1256,12 @@
 webkit.org/b/177532 accessibility/image-load-on-delay.html [ Failure ]
 webkit.org/b/177533 webrtc/video-interruption.html [ Failure ]
 
+webkit.org/b/177632 fast/text/flag-codepoint.html [ ImageOnlyFailure ]
+
+webkit.org/b/177633 editing/pasteboard/data-transfer-get-data-on-paste-rich-text.html [ Failure ]
+webkit.org/b/177633 editing/pasteboard/data-transfer-get-data-on-paste-plain-text.html [ Failure ]
+webkit.org/b/177633 editing/pasteboard/data-transfer-get-data-on-paste-custom.html [ Failure ]
+
 #
 # End of Expected failures
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222459] trunk/Source/WebCore

[clopez]

Title: [222459] trunk/Source/WebCore








Revision 222459
Author clo...@igalia.com
Date 2017-09-25 13:06:12 -0700 (Mon, 25 Sep 2017)


Log Message
Building release with -DLOG_DISABLED=0 fails
https://bugs.webkit.org/show_bug.cgi?id=177441

Reviewed by Michael Catanzaro.

No new tests, it is a build fix.

* Modules/indexeddb/IDBKeyPath.cpp:
* Modules/indexeddb/IDBKeyPath.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (222458 => 222459)

--- trunk/Source/WebCore/ChangeLog	2017-09-25 19:55:31 UTC (rev 222458)
+++ trunk/Source/WebCore/ChangeLog	2017-09-25 20:06:12 UTC (rev 222459)
@@ -1,3 +1,15 @@
+2017-09-25  Carlos Alberto Lopez Perez  
+
+Building release with -DLOG_DISABLED=0 fails
+https://bugs.webkit.org/show_bug.cgi?id=177441
+
+Reviewed by Michael Catanzaro.
+
+No new tests, it is a build fix.
+
+* Modules/indexeddb/IDBKeyPath.cpp:
+* Modules/indexeddb/IDBKeyPath.h:
+
 2017-09-25  Brent Fulgham  
 
 Switch back to partitioning (rather than blocking) prevalent origins without interaction


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp (222458 => 222459)

--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp	2017-09-25 19:55:31 UTC (rev 222458)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp	2017-09-25 20:06:12 UTC (rev 222459)
@@ -223,7 +223,7 @@
 return WTF::visit(visitor, keyPath);
 }
 
-#ifndef NDEBUG
+#if !LOG_DISABLED
 String loggingString(const IDBKeyPath& path)
 {
 auto visitor = WTF::makeVisitor([](const String& string) {


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h (222458 => 222459)

--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h	2017-09-25 19:55:31 UTC (rev 222458)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyPath.h	2017-09-25 20:06:12 UTC (rev 222459)
@@ -53,7 +53,7 @@
 return isolatedCopy(variant.value());
 }
 
-#ifndef NDEBUG
+#if !LOG_DISABLED
 String loggingString(const IDBKeyPath&);
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222442] trunk/Tools

[clopez]

Title: [222442] trunk/Tools








Revision 222442
Author clo...@igalia.com
Date 2017-09-25 05:21:47 -0700 (Mon, 25 Sep 2017)


Log Message
REGRESSION(r222160) [GTK] [Debug] Internal compiler error on the buildbot (huge memory usage by GCC)
https://bugs.webkit.org/show_bug.cgi?id=177223

Reviewed by Carlos Garcia Campos.

When the user environment sets the variable NUMBER_OF_PROCESSORS
this should be passed down to the build system (ninja or make) always.

Playing with the number of this variable is needed when using icecc
(as you usually want to launch more parallel build process than your
number of cores), or when you want to limit the number of parallel
build process for hardware capacity reasons.

* Scripts/build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (222441 => 222442)

--- trunk/Tools/ChangeLog	2017-09-25 08:39:48 UTC (rev 222441)
+++ trunk/Tools/ChangeLog	2017-09-25 12:21:47 UTC (rev 222442)
@@ -1,3 +1,20 @@
+2017-09-25  Carlos Alberto Lopez Perez  
+
+REGRESSION(r222160) [GTK] [Debug] Internal compiler error on the buildbot (huge memory usage by GCC)
+https://bugs.webkit.org/show_bug.cgi?id=177223
+
+Reviewed by Carlos Garcia Campos.
+
+When the user environment sets the variable NUMBER_OF_PROCESSORS
+this should be passed down to the build system (ninja or make) always.
+
+Playing with the number of this variable is needed when using icecc
+(as you usually want to launch more parallel build process than your
+number of cores), or when you want to limit the number of parallel
+build process for hardware capacity reasons.
+
+* Scripts/build-webkit:
+
 2017-09-24  Fujii Hironori  
 
 [GTK] Incremental builds fail every time Web Inspector icons are removed


Modified: trunk/Tools/Scripts/build-webkit (222441 => 222442)

--- trunk/Tools/Scripts/build-webkit	2017-09-25 08:39:48 UTC (rev 222441)
+++ trunk/Tools/Scripts/build-webkit	2017-09-25 12:21:47 UTC (rev 222442)
@@ -239,10 +239,10 @@
 }
 
 if (isCMakeBuild() && !isAnyWindows()) {
-if (!canUseNinja()) {
-# By default we build using all of the available CPUs.
-# Ninja will automatically determine the number of jobs to run in parallel,
-# so don't override the number of jobs if building with Ninja.
+if (!canUseNinja() || defined($ENV{NUMBER_OF_PROCESSORS})) {
+# If the user environment is not setting a specific number of process,
+# then don't pass the number of jobs to Ninja. Because Ninja will
+# automatically determine the number of jobs to run in parallel.
 $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [222222] trunk

[clopez]

Title: [22] trunk








Revision 22
Author clo...@igalia.com
Date 2017-09-19 13:42:26 -0700 (Tue, 19 Sep 2017)


Log Message
[CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
https://bugs.webkit.org/show_bug.cgi?id=177180

Reviewed by Michael Catanzaro.

This adds a ENABLE_WEB_CRYPTO flag and makes ENABLE_SUBTLE_CRYPTO depend on it.
The GTK and WPE ports enable them and set ENABLE_WEB_CRYPTO to public.

* Source/cmake/OptionsGTK.cmake: Set both features to ON and ENABLE_WEB_CRYPTO to public. No change in behaviour for GTK.
* Source/cmake/OptionsWPE.cmake: Do like on the GTK port. The public flag is now ENABLE_WEB_CRYPTO.
* Source/cmake/WebKitFeatures.cmake: Add the definition of ENABLE_WEB_CRYPTO and make ENABLE_SUBTLE_CRYPTO depend on it.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (21 => 22)

--- trunk/ChangeLog	2017-09-19 20:28:29 UTC (rev 21)
+++ trunk/ChangeLog	2017-09-19 20:42:26 UTC (rev 22)
@@ -1,3 +1,17 @@
+2017-09-19  Carlos Alberto Lopez Perez  
+
+[CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
+https://bugs.webkit.org/show_bug.cgi?id=177180
+
+Reviewed by Michael Catanzaro.
+
+This adds a ENABLE_WEB_CRYPTO flag and makes ENABLE_SUBTLE_CRYPTO depend on it.
+The GTK and WPE ports enable them and set ENABLE_WEB_CRYPTO to public.
+
+* Source/cmake/OptionsGTK.cmake: Set both features to ON and ENABLE_WEB_CRYPTO to public. No change in behaviour for GTK.
+* Source/cmake/OptionsWPE.cmake: Do like on the GTK port. The public flag is now ENABLE_WEB_CRYPTO.
+* Source/cmake/WebKitFeatures.cmake: Add the definition of ENABLE_WEB_CRYPTO and make ENABLE_SUBTLE_CRYPTO depend on it.
+
 2017-09-18  Michael Catanzaro  
 
 [CMake] Rename WebKit target to WebKitLegacy and rename WebKit2 target to WebKit


Modified: trunk/Source/cmake/OptionsGTK.cmake (21 => 22)

--- trunk/Source/cmake/OptionsGTK.cmake	2017-09-19 20:28:29 UTC (rev 21)
+++ trunk/Source/cmake/OptionsGTK.cmake	2017-09-19 20:42:26 UTC (rev 22)
@@ -89,7 +89,6 @@
 WEBKIT_OPTION_DEFINE(ENABLE_QUARTZ_TARGET "Whether to enable support for the Quartz windowing target." PUBLIC ${GTK3_SUPPORTS_QUARTZ})
 WEBKIT_OPTION_DEFINE(ENABLE_X11_TARGET "Whether to enable support for the X11 windowing target." PUBLIC ${GTK3_SUPPORTS_X11})
 WEBKIT_OPTION_DEFINE(ENABLE_WAYLAND_TARGET "Whether to enable support for the Wayland windowing target." PUBLIC ${GTK3_SUPPORTS_WAYLAND})
-WEBKIT_OPTION_DEFINE(ENABLE_WEB_CRYPTO "Whether to enable support for Web Crypto API." PUBLIC ON)
 WEBKIT_OPTION_DEFINE(USE_LIBNOTIFY "Whether to enable the default web notification implementation." PUBLIC ON)
 WEBKIT_OPTION_DEFINE(USE_LIBHYPHEN "Whether to enable the default automatic hyphenation implementation." PUBLIC ON)
 WEBKIT_OPTION_DEFINE(USE_LIBSECRET "Whether to enable the persistent credential storage using libsecret." PUBLIC ON)
@@ -106,7 +105,6 @@
 WEBKIT_OPTION_DEPEND(ENABLE_GLES2 ENABLE_OPENGL)
 WEBKIT_OPTION_DEPEND(ENABLE_PLUGIN_PROCESS_GTK2 ENABLE_X11_TARGET)
 WEBKIT_OPTION_DEPEND(ENABLE_WEBGL ENABLE_OPENGL)
-WEBKIT_OPTION_DEPEND(ENABLE_SUBTLE_CRYPTO ENABLE_WEB_CRYPTO)
 WEBKIT_OPTION_DEPEND(USE_REDIRECTED_XCOMPOSITE_WINDOW ENABLE_OPENGL)
 WEBKIT_OPTION_DEPEND(USE_REDIRECTED_XCOMPOSITE_WINDOW ENABLE_X11_TARGET)
 
@@ -141,6 +139,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SAMPLING_PROFILER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
 


Modified: trunk/Source/cmake/OptionsWPE.cmake (21 => 22)

--- trunk/Source/cmake/OptionsWPE.cmake	2017-09-19 20:28:29 UTC (rev 21)
+++ trunk/Source/cmake/OptionsWPE.cmake	2017-09-19 20:42:26 UTC (rev 22)
@@ -29,10 +29,11 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USER_MESSAGE_HANDLERS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_ANIMATIONS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")


Modified: trunk/Source/cmake/WebKitFeatures.cmake (21 => 22)

--- 

[webkit-changes] [222032] trunk/Tools

[clopez]

Title: [222032] trunk/Tools








Revision 222032
Author clo...@igalia.com
Date 2017-09-14 10:53:18 -0700 (Thu, 14 Sep 2017)


Log Message
[GTK] Add a switch to start the mini-browser in full-screen mode
https://bugs.webkit.org/show_bug.cgi?id=176904

Reviewed by Carlos Garcia Campos.

* MiniBrowser/gtk/main.c:
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/main.c




Diff

Modified: trunk/Tools/ChangeLog (222031 => 222032)

--- trunk/Tools/ChangeLog	2017-09-14 17:38:20 UTC (rev 222031)
+++ trunk/Tools/ChangeLog	2017-09-14 17:53:18 UTC (rev 222032)
@@ -1,3 +1,13 @@
+2017-09-14  Carlos Alberto Lopez Perez  
+
+[GTK] Add a switch to start the mini-browser in full-screen mode
+https://bugs.webkit.org/show_bug.cgi?id=176904
+
+Reviewed by Carlos Garcia Campos.
+
+* MiniBrowser/gtk/main.c:
+(main):
+
 2017-09-14  Filip Pizlo  
 
 Unreviewed, fix a typo that was preventing a test from running.


Modified: trunk/Tools/MiniBrowser/gtk/main.c (222031 => 222032)

--- trunk/Tools/MiniBrowser/gtk/main.c	2017-09-14 17:38:20 UTC (rev 222031)
+++ trunk/Tools/MiniBrowser/gtk/main.c	2017-09-14 17:53:18 UTC (rev 222032)
@@ -43,6 +43,7 @@
 static char *geometry;
 static gboolean privateMode;
 static gboolean automationMode;
+static gboolean fullScreen;
 
 typedef enum {
 MINI_BROWSER_ERROR_INVALID_ABOUT_PATH
@@ -96,6 +97,7 @@
 { "editor-mode", 'e', 0, G_OPTION_ARG_NONE, , "Run in editor mode", NULL },
 { "session-file", 's', 0, G_OPTION_ARG_FILENAME, , "Session file", "FILE" },
 { "geometry", 'g', 0, G_OPTION_ARG_STRING, , "Set the size and position of the window (WIDTHxHEIGHT+X+Y)", "GEOMETRY" },
+{ "full-screen", 'f', 0, G_OPTION_ARG_NONE, , "Set the window to full-screen mode", NULL },
 { "private", 'p', 0, G_OPTION_ARG_NONE, , "Run in private browsing mode", NULL },
 { "automation", 0, 0, G_OPTION_ARG_NONE, , "Run in automation mode", NULL },
 { G_OPTION_REMAINING, 0, 0, G_OPTION_ARG_FILENAME_ARRAY, , 0, "[URL…]" },
@@ -513,7 +515,9 @@
 g_signal_connect(webContext, "automation-started", G_CALLBACK(automationStartedCallback), NULL);
 
 BrowserWindow *mainWindow = BROWSER_WINDOW(browser_window_new(NULL, webContext));
-if (geometry)
+if (fullScreen)
+gtk_window_fullscreen(GTK_WINDOW(mainWindow));
+else if (geometry)
 gtk_window_parse_geometry(GTK_WINDOW(mainWindow), geometry);
 
 GtkWidget *firstTab = NULL;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221989] trunk/Source/WebCore

[clopez]

Title: [221989] trunk/Source/WebCore








Revision 221989
Author clo...@igalia.com
Date 2017-09-13 13:17:35 -0700 (Wed, 13 Sep 2017)


Log Message
[GTK] Fails to build because 'Float32Array' has not been declared in AudioContext.h
https://bugs.webkit.org/show_bug.cgi?id=176870

Reviewed by Konstantin Tokarev.

Add missing include of Float32Array.h

No new tests, its a build fix.

* Modules/webaudio/AudioContext.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (221988 => 221989)

--- trunk/Source/WebCore/ChangeLog	2017-09-13 20:04:45 UTC (rev 221988)
+++ trunk/Source/WebCore/ChangeLog	2017-09-13 20:17:35 UTC (rev 221989)
@@ -1,3 +1,16 @@
+2017-09-13  Carlos Alberto Lopez Perez  
+
+[GTK] Fails to build because 'Float32Array' has not been declared in AudioContext.h
+https://bugs.webkit.org/show_bug.cgi?id=176870
+
+Reviewed by Konstantin Tokarev.
+
+Add missing include of Float32Array.h
+
+No new tests, its a build fix.
+
+* Modules/webaudio/AudioContext.h:
+
 2017-09-13  Andy Estes  
 
 [CF] Upstream CFNetwork-related WebKitSystemInterface functions


Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (221988 => 221989)

--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h	2017-09-13 20:04:45 UTC (rev 221988)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h	2017-09-13 20:17:35 UTC (rev 221989)
@@ -36,6 +36,7 @@
 #include "PlatformMediaSession.h"
 #include "VisibilityChangeClient.h"
 #include 
+#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221926] trunk/Tools

[clopez]

Title: [221926] trunk/Tools








Revision 221926
Author clo...@igalia.com
Date 2017-09-12 10:04:31 -0700 (Tue, 12 Sep 2017)


Log Message
The EWS build system is forcing a non UTF-8 locale and breaks meson.
https://bugs.webkit.org/show_bug.cgi?id=176761

Reviewed by Michael Catanzaro.

On 2011 in order to disable GCC smartquotes (UTF-8 pretty quotes)
that were causing trouble with the commit-queue server, the tooling
for the EWS bots started to force an LC_ALL=C locale.

This was needed back then apparently because the commit-queue server
was unable to handle properly UTF-8 text.

6 years forward and none of the ports that commit-queue tests before
landing a patch use GCC, but Clang. So this should not be an issue anymore.

Forcing a non UTF-8 locale breaks the Meson build system (that the
GTK/WPE ports use for some dependencies of its JHBuild dependencies
local build system).
It has also the potential to break things in subtle ways that are
hard to debug and detect. So better stop doing this.

This patch also changes TERM=none to TERM=dumb that is the proper
way to disable VT100 codes (see bug 127922).

* Scripts/webkitpy/common/system/environment.py:
(Environment.to_dictionary):
(Environment.disable_jhbuild_VT100_output):
* Scripts/webkitpy/common/system/environment_unittest.py:
(EnvironmentTest.test_disable_jhbuild_VT100_output):
* Scripts/webkitpy/port/base.py:
(Port._build_driver):
(Port._build_image_diff):
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_build_driver):
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/steps/build.py:
(Build.build):
* Scripts/webkitpy/tool/steps/steps_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/environment.py
trunk/Tools/Scripts/webkitpy/common/system/environment_unittest.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/port_testcase.py
trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py
trunk/Tools/Scripts/webkitpy/tool/steps/build.py
trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (221925 => 221926)

--- trunk/Tools/ChangeLog	2017-09-12 16:59:24 UTC (rev 221925)
+++ trunk/Tools/ChangeLog	2017-09-12 17:04:31 UTC (rev 221926)
@@ -1,3 +1,44 @@
+2017-09-12  Carlos Alberto Lopez Perez  
+
+The EWS build system is forcing a non UTF-8 locale and breaks meson.
+https://bugs.webkit.org/show_bug.cgi?id=176761
+
+Reviewed by Michael Catanzaro.
+
+On 2011 in order to disable GCC smartquotes (UTF-8 pretty quotes)
+that were causing trouble with the commit-queue server, the tooling
+for the EWS bots started to force an LC_ALL=C locale.
+
+This was needed back then apparently because the commit-queue server
+was unable to handle properly UTF-8 text.
+
+6 years forward and none of the ports that commit-queue tests before
+landing a patch use GCC, but Clang. So this should not be an issue anymore.
+
+Forcing a non UTF-8 locale breaks the Meson build system (that the
+GTK/WPE ports use for some dependencies of its JHBuild dependencies
+local build system).
+It has also the potential to break things in subtle ways that are
+hard to debug and detect. So better stop doing this.
+
+This patch also changes TERM=none to TERM=dumb that is the proper
+way to disable VT100 codes (see bug 127922).
+
+* Scripts/webkitpy/common/system/environment.py:
+(Environment.to_dictionary):
+(Environment.disable_jhbuild_VT100_output):
+* Scripts/webkitpy/common/system/environment_unittest.py:
+(EnvironmentTest.test_disable_jhbuild_VT100_output):
+* Scripts/webkitpy/port/base.py:
+(Port._build_driver):
+(Port._build_image_diff):
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.test_build_driver):
+* Scripts/webkitpy/tool/commands/download_unittest.py:
+* Scripts/webkitpy/tool/steps/build.py:
+(Build.build):
+* Scripts/webkitpy/tool/steps/steps_unittest.py:
+
 2017-09-12  Michael Catanzaro  
 
 [WPE][GTK] Run tests with G_DEBUG=fatal-criticals


Modified: trunk/Tools/Scripts/webkitpy/common/system/environment.py (221925 => 221926)

--- trunk/Tools/Scripts/webkitpy/common/system/environment.py	2017-09-12 16:59:24 UTC (rev 221925)
+++ trunk/Tools/Scripts/webkitpy/common/system/environment.py	2017-09-12 17:04:31 UTC (rev 221926)
@@ -34,14 +34,8 @@
 def to_dictionary(self):
 return self.env
 
-def disable_gcc_smartquotes(self):
-# Technically we only need to set LC_CTYPE to disable current
-# smartquote behavior: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38363
-# Apple's XCode sets LC_ALL instead, probably to be future-proof.
-self.env['LC_ALL'] = 'C'
-
 def 

[webkit-changes] [221432] trunk/LayoutTests

[clopez]

Title: [221432] trunk/LayoutTests








Revision 221432
Author clo...@igalia.com
Date 2017-08-31 12:05:18 -0700 (Thu, 31 Aug 2017)


Log Message
[GTK][WPE] Mark test media/event-queue-crash as flaky
https://bugs.webkit.org/show_bug.cgi?id=176174

Unreviewed gardening.

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (221431 => 221432)

--- trunk/LayoutTests/ChangeLog	2017-08-31 18:52:11 UTC (rev 221431)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 19:05:18 UTC (rev 221432)
@@ -1,3 +1,13 @@
+2017-08-31  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] Mark test media/event-queue-crash as flaky
+https://bugs.webkit.org/show_bug.cgi?id=176174
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2017-08-31  Jonathan Bedard  
 
 iOS should include both iPad and iPhone when running layout tests


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (221431 => 221432)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-31 18:52:11 UTC (rev 221431)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-31 19:05:18 UTC (rev 221432)
@@ -1900,6 +1900,8 @@
 
 webkit.org/b/176110 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.worker.html [ Pass Failure ]
 
+webkit.org/b/176174 media/event-queue-crash.html [ Pass Failure ]
+
 #
 # End of Flaky tests
 #


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (221431 => 221432)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-31 18:52:11 UTC (rev 221431)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-31 19:05:18 UTC (rev 221432)
@@ -836,3 +836,5 @@
 
 webkit.org/b/172815 imported/w3c/i18n/bidi/bidi-plaintext-011.html [ ImageOnlyFailure ]
 webkit.org/b/175380 scrollbars/scrollbar-iframe-click-does-not-blur-content.html [ ImageOnlyFailure ]
+
+webkit.org/b/176174 media/event-queue-crash.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221413] trunk/Tools

[clopez]

Title: [221413] trunk/Tools








Revision 221413
Author clo...@igalia.com
Date 2017-08-30 19:54:21 -0700 (Wed, 30 Aug 2017)


Log Message
[GTK] install-dependencies script should install CUPS headers
https://bugs.webkit.org/show_bug.cgi?id=176129

Reviewed by Michael Catanzaro.

When building GTK+ on the JHBuild, it will enable the CUPS print
backend if the CUPS headers are installed. Having a print backend
on GTK+ is needed for the print-related API tests.

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (221412 => 221413)

--- trunk/Tools/ChangeLog	2017-08-31 02:32:21 UTC (rev 221412)
+++ trunk/Tools/ChangeLog	2017-08-31 02:54:21 UTC (rev 221413)
@@ -1,3 +1,16 @@
+2017-08-30  Carlos Alberto Lopez Perez  
+
+[GTK] install-dependencies script should install CUPS headers
+https://bugs.webkit.org/show_bug.cgi?id=176129
+
+Reviewed by Michael Catanzaro.
+
+When building GTK+ on the JHBuild, it will enable the CUPS print
+backend if the CUPS headers are installed. Having a print backend
+on GTK+ is needed for the print-related API tests.
+
+* gtk/install-dependencies:
+
 2017-08-30  Filip Pizlo  
 
 Rename ArrayLang to WebGPU Shading Language, or WSL for short, pronounced "whistle"


Modified: trunk/Tools/gtk/install-dependencies (221412 => 221413)

--- trunk/Tools/gtk/install-dependencies	2017-08-31 02:32:21 UTC (rev 221412)
+++ trunk/Tools/gtk/install-dependencies	2017-08-31 02:54:21 UTC (rev 221413)
@@ -175,6 +175,7 @@
 gsettings-desktop-schemas-dev \
 icon-naming-utils \
 libcroco3-dev \
+libcups2-dev \
 libdrm-dev \
 libegl1-mesa-dev \
 libepoxy-dev \
@@ -331,6 +332,7 @@
 gsettings-desktop-schemas \
 icon-naming-utils \
 libcroco \
+libcups \
 libdrm \
 libepoxy \
 libevdev \
@@ -463,11 +465,12 @@
 
 # These are dependencies necessary for building the jhbuild.
 packages="$packages \
+cups-devel \
+docbook-utils \
 expat-devel \
-docbook-utils \
 git \
+gnutls-devel \
 gobject-introspection \
-gnutls-devel \
 gsettings-desktop-schemas-devel \
 icon-naming-utils \
 itstool \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221372] trunk

[clopez]

Title: [221372] trunk








Revision 221372
Author clo...@igalia.com
Date 2017-08-30 08:06:43 -0700 (Wed, 30 Aug 2017)


Log Message
[WPE] Enable MEMORY_SAMPLER
https://bugs.webkit.org/show_bug.cgi?id=176099

Reviewed by Michael Catanzaro.

.:

Enable the otion at build time by default on Linux (currently
there are only Linux and Mac implementations of this feature).

* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.

* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_compositingManagerProxy):

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (221371 => 221372)

--- trunk/ChangeLog	2017-08-30 13:22:25 UTC (rev 221371)
+++ trunk/ChangeLog	2017-08-30 15:06:43 UTC (rev 221372)
@@ -1,3 +1,16 @@
+2017-08-30  Carlos Alberto Lopez Perez  
+
+[WPE] Enable MEMORY_SAMPLER
+https://bugs.webkit.org/show_bug.cgi?id=176099
+
+Reviewed by Michael Catanzaro.
+
+Enable the otion at build time by default on Linux (currently
+there are only Linux and Mac implementations of this feature).
+
+* Source/cmake/OptionsWPE.cmake:
+* Source/cmake/OptionsGTK.cmake:
+
 2017-08-30  Carlos Garcia Campos  
 
 Unreviewed. Fix versions numbers after r221136.


Modified: trunk/Source/WebKit/ChangeLog (221371 => 221372)

--- trunk/Source/WebKit/ChangeLog	2017-08-30 13:22:25 UTC (rev 221371)
+++ trunk/Source/WebKit/ChangeLog	2017-08-30 15:06:43 UTC (rev 221372)
@@ -1,3 +1,15 @@
+2017-08-30  Carlos Alberto Lopez Perez  
+
+[WPE] Enable MEMORY_SAMPLER
+https://bugs.webkit.org/show_bug.cgi?id=176099
+
+Reviewed by Michael Catanzaro.
+
+Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.
+
+* UIProcess/API/wpe/WPEView.cpp:
+(WKWPE::m_compositingManagerProxy):
+
 2017-08-30  Andy Estes  
 
 [Mac] Upstream Carbon-related WebKitSystemInterface functions


Modified: trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp (221371 => 221372)

--- trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp	2017-08-30 13:22:25 UTC (rev 221371)
+++ trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp	2017-08-30 15:06:43 UTC (rev 221372)
@@ -66,6 +66,11 @@
 auto* pool = configuration->processPool();
 m_pageProxy = pool->createWebPage(*m_pageClient, WTFMove(configuration));
 
+#if ENABLE(MEMORY_SAMPLER)
+if (getenv("WEBKIT_SAMPLE_MEMORY"))
+pool->startMemorySampler(0);
+#endif
+
 m_backend = backend;
 if (!m_backend)
 m_backend = wpe_view_backend_create();


Modified: trunk/Source/cmake/OptionsGTK.cmake (221371 => 221372)

--- trunk/Source/cmake/OptionsGTK.cmake	2017-08-30 13:22:25 UTC (rev 221371)
+++ trunk/Source/cmake/OptionsGTK.cmake	2017-08-30 15:06:43 UTC (rev 221372)
@@ -123,10 +123,10 @@
 endif ()
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
 else ()
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
 endif ()
 


Modified: trunk/Source/cmake/OptionsWPE.cmake (221371 => 221372)

--- trunk/Source/cmake/OptionsWPE.cmake	2017-08-30 13:22:25 UTC (rev 221371)
+++ trunk/Source/cmake/OptionsWPE.cmake	2017-08-30 15:06:43 UTC (rev 221372)
@@ -36,8 +36,10 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
 else ()
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
 endif ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221260] trunk/Source/WebCore

[clopez]

Title: [221260] trunk/Source/WebCore








Revision 221260
Author clo...@igalia.com
Date 2017-08-28 09:37:31 -0700 (Mon, 28 Aug 2017)


Log Message
[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
https://bugs.webkit.org/show_bug.cgi?id=175864

Unreviewed cosmetic follow-up patch after r221075.

No new tests. No change in behavior.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.
(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::createDraggingDataTransfer const):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWPE.cmake


Added Paths

trunk/Source/WebCore/platform/glib/EventHandlerGLib.cpp


Removed Paths

trunk/Source/WebCore/platform/glib/EventHandlerGlib.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (221259 => 221260)

--- trunk/Source/WebCore/ChangeLog	2017-08-28 15:54:35 UTC (rev 221259)
+++ trunk/Source/WebCore/ChangeLog	2017-08-28 16:37:31 UTC (rev 221260)
@@ -1,3 +1,28 @@
+2017-08-28  Carlos Alberto Lopez Perez  
+
+[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
+https://bugs.webkit.org/show_bug.cgi?id=175864
+
+Unreviewed cosmetic follow-up patch after r221075.
+
+No new tests. No change in behavior.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+* platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.
+(WebCore::EventHandler::tabsToAllFormControls const):
+(WebCore::EventHandler::focusDocumentView):
+(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
+(WebCore::EventHandler::passMouseDownEventToWidget):
+(WebCore::EventHandler::eventActivatedView const):
+(WebCore::EventHandler::widgetDidHandleWheelEvent):
+(WebCore::EventHandler::createDraggingDataTransfer const):
+(WebCore::EventHandler::passMousePressEventToSubframe):
+(WebCore::EventHandler::passMouseMoveEventToSubframe):
+(WebCore::EventHandler::passMouseReleaseEventToSubframe):
+(WebCore::EventHandler::accessKeyModifiers):
+(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):
+
 2017-08-28  Zan Dobersek  
 
 [WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code


Modified: trunk/Source/WebCore/PlatformGTK.cmake (221259 => 221260)

--- trunk/Source/WebCore/PlatformGTK.cmake	2017-08-28 15:54:35 UTC (rev 221259)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2017-08-28 16:37:31 UTC (rev 221260)
@@ -146,7 +146,7 @@
 
 page/gtk/DragControllerGtk.cpp
 
-platform/glib/EventHandlerGlib.cpp
+platform/glib/EventHandlerGLib.cpp
 
 platform/graphics/PlatformDisplay.cpp
 


Modified: trunk/Source/WebCore/PlatformWPE.cmake (221259 => 221260)

--- trunk/Source/WebCore/PlatformWPE.cmake	2017-08-28 15:54:35 UTC (rev 221259)
+++ trunk/Source/WebCore/PlatformWPE.cmake	2017-08-28 16:37:31 UTC (rev 221260)
@@ -132,7 +132,7 @@
 list(APPEND WebCorePlatformWPE_SOURCES
 editing/wpe/EditorWPE.cpp
 
-platform/glib/EventHandlerGlib.cpp
+platform/glib/EventHandlerGLib.cpp
 
 platform/graphics/egl/GLContextEGLWPE.cpp
 


Copied: trunk/Source/WebCore/platform/glib/EventHandlerGLib.cpp (from rev 221258, trunk/Source/WebCore/platform/glib/EventHandlerGlib.cpp) (0 => 221260)

--- trunk/Source/WebCore/platform/glib/EventHandlerGLib.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/glib/EventHandlerGLib.cpp	2017-08-28 16:37:31 UTC (rev 221260)
@@ -0,0 +1,156 @@
+/*
+ * Copyright (C) 2006 Zack Rusin 
+ * Copyright (C) 2014-2017 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 

[webkit-changes] [221075] trunk

[clopez]

Title: [221075] trunk








Revision 221075
Author clo...@igalia.com
Date 2017-08-23 08:16:23 -0700 (Wed, 23 Aug 2017)


Log Message
[WPE] Some event handlers not working.
https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* page/wpe/EventHandlerWPE.cpp: Removed.
* platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

* platform/wpe/TestExpectations:
* platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWPE.cmake


Added Paths

trunk/LayoutTests/platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt
trunk/Source/WebCore/platform/glib/EventHandlerGlib.cpp


Removed Paths

trunk/Source/WebCore/page/gtk/EventHandlerGtk.cpp
trunk/Source/WebCore/page/wpe/




Diff

Modified: trunk/LayoutTests/ChangeLog (221074 => 221075)

--- trunk/LayoutTests/ChangeLog	2017-08-23 13:02:00 UTC (rev 221074)
+++ trunk/LayoutTests/ChangeLog	2017-08-23 15:16:23 UTC (rev 221075)
@@ -1,3 +1,17 @@
+2017-08-23  Carlos Alberto Lopez Perez  
+
+[WPE] Some event handlers not working.
+https://bugs.webkit.org/show_bug.cgi?id=175864
+
+Reviewed by Michael Catanzaro.
+
+Remove expected failures for tests that now pass, add new expectation
+for a test that is failing also on GTK+ and rebaseline a test with
+the same expected result than on GTK+.
+
+* platform/wpe/TestExpectations:
+* platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
+
 2017-08-23  Ms2ger  
 
 [GTK] Remove some flaky annotations for passing tests.


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (221074 => 221075)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-23 13:02:00 UTC (rev 221074)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-08-23 15:16:23 UTC (rev 221075)
@@ -461,7 +461,6 @@
 # The tests below need gardening after the EventSenderWPE has been added.
 # Most of them are probably failing because of missing support of event related
 # features in WPE.
-webkit.org/b/173419 fast/events/autoscroll-in-overflow-hidden-html.html [ Failure ]
 webkit.org/b/173419 fast/events/autoscroll-in-textarea.html [ Failure ]
 webkit.org/b/173419 fast/events/autoscroll-in-textfield.html [ Failure ]
 webkit.org/b/173419 fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html [ Failure ]
@@ -483,15 +482,9 @@
 webkit.org/b/173419 fast/events/input-events-paste-data.html [ Failure ]
 webkit.org/b/173419 fast/events/input-events-paste-rich-datatransfer.html [ Failure ]
 webkit.org/b/173419 fast/events/js-keyboard-event-creation.html [ Failure ]
-webkit.org/b/173419 fast/events/keydown-1.html [ Failure ]
 webkit.org/b/173419 fast/events/keydown-numpad-keys.html [ Failure ]
 webkit.org/b/173419 fast/events/mouse-cursor-image-set.html [ Failure ]
-webkit.org/b/173419 fast/events/mouse-drag-from-frame-to-other-frame.html [ Failure ]
-webkit.org/b/173419 fast/events/mouse-drag-from-frame.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseenterleave-on-subframe.html [ Failure ]
 webkit.org/b/173419 fast/events/mouseover-button.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseover-mouseout.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseover-mouseout2.html [ Failure ]
 webkit.org/b/173419 fast/events/mouseup-from-button2.html [ Failure ]
 webkit.org/b/173419 fast/events/no-scroll-on-input-text-selection.html [ Failure ]
 webkit.org/b/173419 fast/events/node-event-anchor-lock.html [ Failure ]
@@ -498,7 +491,6 @@
 webkit.org/b/173419 fast/events/offsetX-offsetY.html [ Failure ]
 webkit.org/b/173419 fast/events/onchange-range-slider.html [ Failure ]
 webkit.org/b/173419 fast/events/option-tab.html [ Failure ]
-webkit.org/b/173419 fast/events/page-scaled-mouse-click-iframe.html [ Failure ]
 webkit.org/b/173419 fast/events/platform-wheelevent-in-scrolling-div.html [ Failure ]
 webkit.org/b/173419 fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure ]
 webkit.org/b/173419 fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html [ Failure ]
@@ -532,33 +524,28 @@
 webkit.org/b/173419 fast/events/autoscroll-should-not-stop-on-keypress.html [ Timeout ]
 webkit.org/b/173419 fast/events/autoscroll-when-zoomed.html [ Timeout ]
 

[webkit-changes] [221010] trunk/Tools

[clopez]

Title: [221010] trunk/Tools








Revision 221010
Author clo...@igalia.com
Date 2017-08-22 06:47:05 -0700 (Tue, 22 Aug 2017)


Log Message
[GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
https://bugs.webkit.org/show_bug.cgi?id=175822

Reviewed by Xabier Rodriguez-Calvar.

* gtk/install-dependencies: Add the bad plugins to the list.
* wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies
trunk/Tools/wpe/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (221009 => 221010)

--- trunk/Tools/ChangeLog	2017-08-22 09:54:16 UTC (rev 221009)
+++ trunk/Tools/ChangeLog	2017-08-22 13:47:05 UTC (rev 221010)
@@ -1,3 +1,13 @@
+2017-08-22  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
+https://bugs.webkit.org/show_bug.cgi?id=175822
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* gtk/install-dependencies: Add the bad plugins to the list.
+* wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
+
 2017-08-21  Myles C. Maxfield  
 
 DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion


Modified: trunk/Tools/gtk/install-dependencies (221009 => 221010)

--- trunk/Tools/gtk/install-dependencies	2017-08-22 09:54:16 UTC (rev 221009)
+++ trunk/Tools/gtk/install-dependencies	2017-08-22 13:47:05 UTC (rev 221010)
@@ -115,6 +115,7 @@
 libgtk2.0-dev \
 libgtk-3-dev \
 libgstreamer1.0-dev \
+libgstreamer-plugins-bad1.0-dev \
 libgstreamer-plugins-base1.0-dev \
 libgudev-1.0-dev \
 libhyphen-dev \
@@ -245,6 +246,7 @@
 grep \
 groff \
 gstreamer \
+gst-plugins-bad \
 gst-plugins-base-libs \
 gzip \
 hyphen \
@@ -391,6 +393,7 @@
 gobject-introspection-devel \
 gperf \
 gstreamer1-devel \
+gstreamer1-plugins-bad-free-devel \
 gstreamer1-plugins-base-devel \
 gtk-doc \
 gtk2-devel \


Modified: trunk/Tools/wpe/install-dependencies (221009 => 221010)

--- trunk/Tools/wpe/install-dependencies	2017-08-22 09:54:16 UTC (rev 221009)
+++ trunk/Tools/wpe/install-dependencies	2017-08-22 13:47:05 UTC (rev 221010)
@@ -68,6 +68,9 @@
 intltool \
 itstool \
 libgnutls28-dev \
+libgstreamer1.0-dev \
+libgstreamer-plugins-bad1.0-dev \
+libgstreamer-plugins-base1.0-dev \
 libicu-dev \
 libjpeg-dev \
 $(aptIfElse libpng-dev libpng12-dev) \
@@ -143,6 +146,9 @@
 gperf \
 grep \
 groff \
+gstreamer \
+gst-plugins-bad \
+gst-plugins-base-libs \
 gzip \
 icu \
 intltool \
@@ -224,6 +230,9 @@
 gcc-c++ \
 gnutls-devel \
 gperf \
+gstreamer1-devel \
+gstreamer1-plugins-bad-free-devel \
+gstreamer1-plugins-base-devel \
 intltool \
 itstool \
 libicu-devel \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220993] trunk/Source/WTF

[clopez]

Title: [220993] trunk/Source/WTF








Revision 220993
Author clo...@igalia.com
Date 2017-08-21 18:07:17 -0700 (Mon, 21 Aug 2017)


Log Message
[GTK] ARMv7 build fails to build MacroAssemblerARMv7.cpp.
https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by Keith Miller.

* wtf/Platform.h: Enable DFG and MASM_PROBE back for GTK ARM_THUMB2.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/Source/WTF/ChangeLog (220992 => 220993)

--- trunk/Source/WTF/ChangeLog	2017-08-22 00:23:39 UTC (rev 220992)
+++ trunk/Source/WTF/ChangeLog	2017-08-22 01:07:17 UTC (rev 220993)
@@ -1,3 +1,12 @@
+2017-08-21  Carlos Alberto Lopez Perez  
+
+[GTK] ARMv7 build fails to build MacroAssemblerARMv7.cpp.
+https://bugs.webkit.org/show_bug.cgi?id=175514
+
+Reviewed by Keith Miller.
+
+* wtf/Platform.h: Enable DFG and MASM_PROBE back for GTK ARM_THUMB2.
+
 2017-08-20  Sam Weinig  
 
 StringView could use a function to strip leading/trailing characters without allocation


Modified: trunk/Source/WTF/wtf/Platform.h (220992 => 220993)

--- trunk/Source/WTF/wtf/Platform.h	2017-08-22 00:23:39 UTC (rev 220992)
+++ trunk/Source/WTF/wtf/Platform.h	2017-08-22 01:07:17 UTC (rev 220993)
@@ -786,8 +786,8 @@
 #if (CPU(X86) || CPU(X86_64)) && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD) || OS(HURD))
 #define ENABLE_DFG_JIT 1
 #endif
-/* Enable the DFG JIT on ARMv7.  Only tested on iOS and Qt/GTK+ Linux. */
-#if (CPU(ARM_THUMB2) || CPU(ARM64)) && (PLATFORM(IOS) || PLATFORM(WPE))
+/* Enable the DFG JIT on ARMv7.  Only tested on iOS and GTK+/WPE Linux. */
+#if (CPU(ARM_THUMB2) || CPU(ARM64)) && (PLATFORM(IOS) || PLATFORM(GTK) || PLATFORM(WPE))
 #define ENABLE_DFG_JIT 1
 #endif
 /* Enable the DFG JIT on ARM. */
@@ -831,11 +831,6 @@
 #undef ENABLE_MASM_PROBE
 #define ENABLE_MASM_PROBE 0
 #endif
-#if PLATFORM(GTK) && CPU(ARM_THUMB2)
-/* FIXME: https://bugs.webkit.org/show_bug.cgi?id=175514 */
-#undef ENABLE_MASM_PROBE
-#define ENABLE_MASM_PROBE 0
-#endif
 
 /* If the baseline jit is not available, then disable upper tiers as well.
The MacroAssembler::probe() is also required for supporting the upper tiers. */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220584] trunk/Source/WebDriver

[clopez]

Title: [220584] trunk/Source/WebDriver








Revision 220584
Author clo...@igalia.com
Date 2017-08-11 05:28:21 -0700 (Fri, 11 Aug 2017)


Log Message
Fix build warning in WebDriverService.h
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

* WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/WebDriverService.h




Diff

Modified: trunk/Source/WebDriver/ChangeLog (220583 => 220584)

--- trunk/Source/WebDriver/ChangeLog	2017-08-11 10:06:12 UTC (rev 220583)
+++ trunk/Source/WebDriver/ChangeLog	2017-08-11 12:28:21 UTC (rev 220584)
@@ -1,3 +1,12 @@
+2017-08-11  Carlos Alberto Lopez Perez  
+
+Fix build warning in WebDriverService.h
+https://bugs.webkit.org/show_bug.cgi?id=166682
+
+Unreviewed build fix.
+
+* WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
+
 2017-08-08  Michael Catanzaro  
 
 Unreviewed, fix Ubuntu LTS build


Modified: trunk/Source/WebDriver/WebDriverService.h (220583 => 220584)

--- trunk/Source/WebDriver/WebDriverService.h	2017-08-11 10:06:12 UTC (rev 220583)
+++ trunk/Source/WebDriver/WebDriverService.h	2017-08-11 12:28:21 UTC (rev 220584)
@@ -38,7 +38,7 @@
 
 namespace WebDriver {
 
-class Capabilities;
+struct Capabilities;
 class CommandResult;
 class Session;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220529] trunk

[clopez]

Title: [220529] trunk








Revision 220529
Author clo...@igalia.com
Date 2017-08-10 09:33:31 -0700 (Thu, 10 Aug 2017)


Log Message
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

* Source/cmake/FindGeoClue2.cmake:

Tools:

* gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindGeoClue2.cmake
trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/ChangeLog (220528 => 220529)

--- trunk/ChangeLog	2017-08-10 15:44:39 UTC (rev 220528)
+++ trunk/ChangeLog	2017-08-10 16:33:31 UTC (rev 220529)
@@ -1,3 +1,15 @@
+2017-08-10  Carlos Alberto Lopez Perez  
+
+REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
+https://bugs.webkit.org/show_bug.cgi?id=175426
+
+Reviewed by Carlos Garcia Campos.
+
+Fix the pkg-config file name.
+We really require geoclue-2.0 and not libgeoclue-2.0.
+
+* Source/cmake/FindGeoClue2.cmake:
+
 2017-08-09  Michael Catanzaro  
 
 [GTK] Remove support for geoclue1


Modified: trunk/Source/cmake/FindGeoClue2.cmake (220528 => 220529)

--- trunk/Source/cmake/FindGeoClue2.cmake	2017-08-10 15:44:39 UTC (rev 220528)
+++ trunk/Source/cmake/FindGeoClue2.cmake	2017-08-10 16:33:31 UTC (rev 220529)
@@ -31,7 +31,7 @@
 # ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 find_package(PkgConfig)
-pkg_check_modules(GEOCLUE2 libgeoclue-2.0)
+pkg_check_modules(GEOCLUE2 geoclue-2.0)
 
 set(VERSION_OK FALSE)
 if (GEOCLUE2_VERSION)


Modified: trunk/Tools/ChangeLog (220528 => 220529)

--- trunk/Tools/ChangeLog	2017-08-10 15:44:39 UTC (rev 220528)
+++ trunk/Tools/ChangeLog	2017-08-10 16:33:31 UTC (rev 220529)
@@ -1,3 +1,12 @@
+2017-08-10  Carlos Alberto Lopez Perez  
+
+REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
+https://bugs.webkit.org/show_bug.cgi?id=175426
+
+Reviewed by Carlos Garcia Campos.
+
+* gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
+
 2017-08-10  Ms2ger  
 
 Add Ms2ger as contributor.


Modified: trunk/Tools/gtk/install-dependencies (220528 => 220529)

--- trunk/Tools/gtk/install-dependencies	2017-08-10 15:44:39 UTC (rev 220528)
+++ trunk/Tools/gtk/install-dependencies	2017-08-10 16:33:31 UTC (rev 220529)
@@ -109,7 +109,6 @@
 libfaad-dev \
 libffi-dev \
 $(aptIfElse libgcrypt20-dev libgcrypt11-dev) \
-$(aptIfElse libgeoclue-2-dev libgeoclue-dev) \
 libgirepository1.0-dev \
 libgl1-mesa-dev \
 libgl1-mesa-glx \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220334] trunk/Source

[clopez]

Title: [220334] trunk/Source








Revision 220334
Author clo...@igalia.com
Date 2017-08-07 08:44:14 -0700 (Mon, 07 Aug 2017)


Log Message
[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Source/WebCore:

No change of behavior, covered by existing tests.

* CMakeLists.txt: Instead of negating 3 times the use of libepoxy
move the logic for (E)GL detection inside an else() block.

Source/WebKit:

* CMakeLists.txt: When using libepoxy avoid passing the CFLAGS from (E)GL,
and instead pass the libepoxy ones.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (220333 => 220334)

--- trunk/Source/WebCore/CMakeLists.txt	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-08-07 15:44:14 UTC (rev 220334)
@@ -3386,34 +3386,6 @@
 # For platforms that want to use system-provided OpenGL (ES) / EGL headers,
 # these include directories, libraries or definitions need to be
 # added before the ANGLE directories.
-if (USE_OPENGL AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${OPENGL_LIBRARIES}
-)
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2 AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${OPENGLES2_LIBRARIES}
-)
-add_definitions(${OPENGLES2_DEFINITIONS})
-endif ()
-
-if (USE_EGL AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${EGL_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${EGL_LIBRARIES}
-)
-add_definitions(${EGL_DEFINITIONS})
-endif ()
-
 if (USE_LIBEPOXY)
 list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
 ${LIBEPOXY_INCLUDE_DIRS}
@@ -3421,6 +3393,34 @@
 list(APPEND WebCore_LIBRARIES
 ${LIBEPOXY_LIBRARIES}
 )
+else ()
+if (USE_OPENGL)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${OPENGL_LIBRARIES}
+)
+add_definitions(${OPENGL_DEFINITIONS})
+elseif (USE_OPENGL_ES_2)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGLES2_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${OPENGLES2_LIBRARIES}
+)
+add_definitions(${OPENGLES2_DEFINITIONS})
+endif ()
+
+if (USE_EGL)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${EGL_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${EGL_LIBRARIES}
+)
+add_definitions(${EGL_DEFINITIONS})
+endif ()
 endif ()
 
 list(APPEND WebCore_INCLUDE_DIRECTORIES


Modified: trunk/Source/WebCore/ChangeLog (220333 => 220334)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 15:44:14 UTC (rev 220334)
@@ -1,3 +1,15 @@
+2017-08-07  Carlos Alberto Lopez Perez  
+
+[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
+https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Reviewed by Michael Catanzaro.
+
+No change of behavior, covered by existing tests.
+
+* CMakeLists.txt: Instead of negating 3 times the use of libepoxy
+move the logic for (E)GL detection inside an else() block.
+
 2017-08-07  Antti Koivisto  
 
 REGRESSION (r219121): Airmail 3 prints header part only.


Modified: trunk/Source/WebKit/CMakeLists.txt (220333 => 220334)

--- trunk/Source/WebKit/CMakeLists.txt	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-08-07 15:44:14 UTC (rev 220334)
@@ -702,32 +702,41 @@
 # For platforms that want to use system-provided OpenGL (ES) / EGL headers,
 # these include directories, libraries or definitions need to be
 # added before the ANGLE directories.
-if (USE_OPENGL)
+if (USE_LIBEPOXY)
 list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
+${LIBEPOXY_INCLUDE_DIRS}
 )
 list(APPEND WebKit2_LIBRARIES
-${OPENGL_LIBRARIES}
+${LIBEPOXY_LIBRARIES}
 )
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-   

[webkit-changes] [220331] trunk/Source/WebKit

[clopez]

Title: [220331] trunk/Source/WebKit








Revision 220331
Author clo...@igalia.com
Date 2017-08-07 02:53:52 -0700 (Mon, 07 Aug 2017)


Log Message
[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
https://bugs.webkit.org/show_bug.cgi?id=175125

Unreviewed follow-up fix after r220326.

* CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES
below where the list itself is created.

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (220330 => 220331)

--- trunk/Source/WebKit/CMakeLists.txt	2017-08-07 07:03:06 UTC (rev 220330)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-08-07 09:53:52 UTC (rev 220331)
@@ -90,44 +90,6 @@
 ${ICU_INCLUDE_DIRS}
 )
 
-if (ENABLE_GRAPHICS_CONTEXT_3D)
-# For platforms that want to use system-provided OpenGL (ES) / EGL headers,
-# these include directories, libraries or definitions need to be
-# added before the ANGLE directories.
-if (USE_OPENGL)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${OPENGL_LIBRARIES}
-)
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${OPENGLES2_LIBRARIES}
-)
-add_definitions(${OPENGLES2_DEFINITIONS})
-endif ()
-
-if (USE_EGL)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${EGL_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${EGL_LIBRARIES}
-)
-add_definitions(${EGL_DEFINITIONS})
-endif ()
-
-list(APPEND WebKit2_INCLUDE_DIRECTORIES
-"${THIRDPARTY_DIR}/ANGLE"
-"${THIRDPARTY_DIR}/ANGLE/include/KHR"
-)
-endif ()
-
 set(WebKit2_SOURCES
 NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp
 
@@ -736,6 +698,44 @@
 WebKit2
 )
 
+if (ENABLE_GRAPHICS_CONTEXT_3D)
+# For platforms that want to use system-provided OpenGL (ES) / EGL headers,
+# these include directories, libraries or definitions need to be
+# added before the ANGLE directories.
+if (USE_OPENGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGL_LIBRARIES}
+)
+add_definitions(${OPENGL_DEFINITIONS})
+elseif (USE_OPENGL_ES_2)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGLES2_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGLES2_LIBRARIES}
+)
+add_definitions(${OPENGLES2_DEFINITIONS})
+endif ()
+
+if (USE_EGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${EGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${EGL_LIBRARIES}
+)
+add_definitions(${EGL_DEFINITIONS})
+endif ()
+
+list(APPEND WebKit2_INCLUDE_DIRECTORIES
+"${THIRDPARTY_DIR}/ANGLE"
+"${THIRDPARTY_DIR}/ANGLE/include/KHR"
+)
+endif ()
+
 if (WIN32 AND INTERNAL_BUILD)
 set(_javascript_Core_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/_javascript_Core/Scripts")
 else ()


Modified: trunk/Source/WebKit/ChangeLog (220330 => 220331)

--- trunk/Source/WebKit/ChangeLog	2017-08-07 07:03:06 UTC (rev 220330)
+++ trunk/Source/WebKit/ChangeLog	2017-08-07 09:53:52 UTC (rev 220331)
@@ -1,3 +1,13 @@
+2017-08-07  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
+https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Unreviewed follow-up fix after r220326.
+
+* CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES
+below where the list itself is created.
+
 2017-08-05  Carlos Garcia Campos  
 
 [GTK][WPE] Add API to provide browser information required by automation






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220326] trunk/Source/WebKit

[clopez]

Title: [220326] trunk/Source/WebKit








Revision 220326
Author clo...@igalia.com
Date 2017-08-06 16:34:58 -0700 (Sun, 06 Aug 2017)


Log Message
[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Some platforms define cflags on the (E)GL pkg-config files that we
need to pass to the build system when including the (E)GL headers.
And we are already doing this when building WebCore (after r184954).

But now we need to do this also on WebKit (former WebKit2) because
we include (E)GL headers (and make use of them) on the UIProcess.

* CMakeLists.txt:

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (220325 => 220326)

--- trunk/Source/WebKit/CMakeLists.txt	2017-08-06 23:24:17 UTC (rev 220325)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-08-06 23:34:58 UTC (rev 220326)
@@ -91,6 +91,37 @@
 )
 
 if (ENABLE_GRAPHICS_CONTEXT_3D)
+# For platforms that want to use system-provided OpenGL (ES) / EGL headers,
+# these include directories, libraries or definitions need to be
+# added before the ANGLE directories.
+if (USE_OPENGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGL_LIBRARIES}
+)
+add_definitions(${OPENGL_DEFINITIONS})
+elseif (USE_OPENGL_ES_2)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGLES2_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGLES2_LIBRARIES}
+)
+add_definitions(${OPENGLES2_DEFINITIONS})
+endif ()
+
+if (USE_EGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${EGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${EGL_LIBRARIES}
+)
+add_definitions(${EGL_DEFINITIONS})
+endif ()
+
 list(APPEND WebKit2_INCLUDE_DIRECTORIES
 "${THIRDPARTY_DIR}/ANGLE"
 "${THIRDPARTY_DIR}/ANGLE/include/KHR"


Modified: trunk/Source/WebKit/ChangeLog (220325 => 220326)

--- trunk/Source/WebKit/ChangeLog	2017-08-06 23:24:17 UTC (rev 220325)
+++ trunk/Source/WebKit/ChangeLog	2017-08-06 23:34:58 UTC (rev 220326)
@@ -1,3 +1,19 @@
+2017-08-06  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
+https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Reviewed by Michael Catanzaro.
+
+Some platforms define cflags on the (E)GL pkg-config files that we
+need to pass to the build system when including the (E)GL headers.
+And we are already doing this when building WebCore (after r184954).
+
+But now we need to do this also on WebKit (former WebKit2) because
+we include (E)GL headers (and make use of them) on the UIProcess.
+
+* CMakeLists.txt:
+
 2017-08-05  Carlos Garcia Campos  
 
 WebDriver: Implement page load strategy






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220292] trunk/Tools

[clopez]

Title: [220292] trunk/Tools








Revision 220292
Author clo...@igalia.com
Date 2017-08-04 14:18:17 -0700 (Fri, 04 Aug 2017)


Log Message
REGRESSION(r219857): run-benchmark --allplans broken
https://bugs.webkit.org/show_bug.cgi?id=175186

Reviewed by Saam Barati.

r219857 forgot to update also the calls to BenchmarkRunner() that
is done when the script is run with --allplans.

To fix this (and avoid future issues like this), let's factorize
the calls to the benchhmark runner in a run_benchmark_plan()
function.

* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(run_benchmark_plan):
(start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py




Diff

Modified: trunk/Tools/ChangeLog (220291 => 220292)

--- trunk/Tools/ChangeLog	2017-08-04 20:50:51 UTC (rev 220291)
+++ trunk/Tools/ChangeLog	2017-08-04 21:18:17 UTC (rev 220292)
@@ -1,3 +1,21 @@
+2017-08-04  Carlos Alberto Lopez Perez  
+
+REGRESSION(r219857): run-benchmark --allplans broken
+https://bugs.webkit.org/show_bug.cgi?id=175186
+
+Reviewed by Saam Barati.
+
+r219857 forgot to update also the calls to BenchmarkRunner() that
+is done when the script is run with --allplans.
+
+To fix this (and avoid future issues like this), let's factorize
+the calls to the benchhmark runner in a run_benchmark_plan()
+function.
+
+* Scripts/webkitpy/benchmark_runner/run_benchmark.py:
+(run_benchmark_plan):
+(start):
+
 2017-08-04  Aakash Jain  
 
 Dashboard bubbles sometimes show failure count instead of crash count


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py (220291 => 220292)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py	2017-08-04 20:50:51 UTC (rev 220291)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py	2017-08-04 21:18:17 UTC (rev 220292)
@@ -60,6 +60,12 @@
 return args
 
 
+def run_benchmark_plan(args, plan):
+benchmark_runner_class = benchmark_runner_subclasses[args.driver]
+runner = benchmark_runner_class(plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser, args.scale_unit, args.device_id)
+runner.execute()
+
+
 def start(args):
 if args.json_file:
 results_json = json.load(open(args.json_file, 'r'))
@@ -83,8 +89,7 @@
 continue
 _log.info('Starting benchmark plan: %s' % plan)
 try:
-runner = BenchmarkRunner(plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser, args.scale_unit, args.device_id)
-runner.execute()
+run_benchmark_plan(args, plan)
 _log.info('Finished benchmark plan: %s' % plan)
 except KeyboardInterrupt:
 raise
@@ -94,9 +99,7 @@
 if failed:
 _log.error('The following benchmark plans have failed: %s' % failed)
 return len(failed)
-benchmark_runner_class = benchmark_runner_subclasses[args.driver]
-runner = benchmark_runner_class(args.plan, args.localCopy, args.countOverride, args.buildDir, args.output, args.platform, args.browser, args.scale_unit, args.device_id)
-runner.execute()
+run_benchmark_plan(args, args.plan)
 
 
 def format_logger(logger):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220266] trunk/LayoutTests

[clopez]

Title: [220266] trunk/LayoutTests








Revision 220266
Author clo...@igalia.com
Date 2017-08-04 03:12:53 -0700 (Fri, 04 Aug 2017)


Log Message
[GTK] Test gardening around MOUSE_CURSOR_SCALE.
https://bugs.webkit.org/show_bug.cgi?id=109469

Patch by Ms2ger  on 2017-08-04
Reviewed by Carlos Alberto Lopez Perez.

Remove obsolete expectation for cursor-parsing-image-set.html; it may have
started passing in r209396.

Mark mouse-cursor-image-set.html as failing rather than using an incorrect
-expected file.

* platform/gtk/TestExpectations:
* platform/gtk/fast/events/mouse-cursor-image-set-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Removed Paths

trunk/LayoutTests/platform/gtk/fast/events/mouse-cursor-image-set-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (220265 => 220266)

--- trunk/LayoutTests/ChangeLog	2017-08-04 10:01:15 UTC (rev 220265)
+++ trunk/LayoutTests/ChangeLog	2017-08-04 10:12:53 UTC (rev 220266)
@@ -1,3 +1,19 @@
+2017-08-04  Ms2ger  
+
+[GTK] Test gardening around MOUSE_CURSOR_SCALE.
+https://bugs.webkit.org/show_bug.cgi?id=109469
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Remove obsolete expectation for cursor-parsing-image-set.html; it may have
+started passing in r209396.
+
+Mark mouse-cursor-image-set.html as failing rather than using an incorrect
+-expected file.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/events/mouse-cursor-image-set-expected.txt: Removed.
+
 2017-08-04  Zan Dobersek  
 
 Unreviewed GTK+ gardening. Update test expectations and layout test baselines


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220265 => 220266)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-04 10:01:15 UTC (rev 220265)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-04 10:12:53 UTC (rev 220266)
@@ -2630,7 +2630,7 @@
 
 webkit.org/b/108973 fast/css/negative-text-indent-in-inline-block.html [ ImageOnlyFailure ]
 
-webkit.org/b/109469 fast/css/cursor-parsing-image-set.html [ Failure ]
+webkit.org/b/109469 fast/events/mouse-cursor-image-set.html [ Failure ]
 
 webkit.org/b/110446 svg/as-background-image/svg-transformed-background.html [ ImageOnlyFailure ]
 


Deleted: trunk/LayoutTests/platform/gtk/fast/events/mouse-cursor-image-set-expected.txt (220265 => 220266)

--- trunk/LayoutTests/platform/gtk/fast/events/mouse-cursor-image-set-expected.txt	2017-08-04 10:01:15 UTC (rev 220265)
+++ trunk/LayoutTests/platform/gtk/fast/events/mouse-cursor-image-set-expected.txt	2017-08-04 10:12:53 UTC (rev 220266)
@@ -1,82 +0,0 @@
-Test that mouse cursors are applied correctly.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Bug 99493
-
-
-Checking cursors with device pixel ratio of 1
---
-TEST CASE: 25x25 image at 1x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: 25x25 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: 25x25 image at 1x, 30x30 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: 25x25 image at 1.5x, 30x30 image at 5x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: Invalid tiny scale with fallback to pointer
-Cursor Info: type=Hand hotSpot=0,0
-
-TEST CASE: Over-large image with fallback to pointer
-Cursor Info: type=Hand hotSpot=0,0
-
-TEST CASE: 200x200 image at 4x (not over-large in UI pixels)
-Cursor Info: type=Custom hotSpot=0,0 image=200x200
-
-TEST CASE: Non-existent image in image-set with fallback to 25x25 image
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: Explicit hotspot at (5,3) logical in 1x and 2x
-Cursor Info: type=Custom hotSpot=5,3 image=25x25
-
-TEST CASE: Explicit hotspot at (7,3) logical in 0.7x and 1.4x - should round to nearest integer
-Cursor Info: type=Custom hotSpot=7,3 image=30x30
-
-TEST CASE: Implicit hot-spot at (5,4) physical for 1x and (28,3) physical for 2x
-Cursor Info: type=Custom hotSpot=5,4 image=25x25
-
-Checking cursors with device pixel ratio of 2
---
-TEST CASE: 25x25 image at 1x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: 25x25 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=25x25
-
-TEST CASE: 25x25 image at 1x, 30x30 image at 2x
-Cursor Info: type=Custom hotSpot=0,0 image=30x30
-
-TEST CASE: 25x25 image at 1.5x, 30x30 image at 5x
-Cursor Info: type=Custom hotSpot=0,0 image=30x30
-
-TEST CASE: Invalid tiny scale with fallback to pointer
-Cursor Info: type=Hand hotSpot=0,0
-
-TEST CASE: Over-large image with fallback to pointer
-Cursor Info: type=Hand hotSpot=0,0
-
-TEST CASE: 200x200 image at 4x (not over-large in UI pixels)
-Cursor Info: type=Custom hotSpot=0,0 image=200x200
-
-TEST CASE: Non-existent image in image-set with 

[webkit-changes] [220265] trunk/JSTests

[clopez]

Title: [220265] trunk/JSTests








Revision 220265
Author clo...@igalia.com
Date 2017-08-04 03:01:15 -0700 (Fri, 04 Aug 2017)


Log Message
JSC test wasm/js-api/test_memory_constructor.js should be skipped on memoryLimited
https://bugs.webkit.org/show_bug.cgi?id=175150

Unreviewed test gardening.

* wasm/js-api/test_memory_constructor.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/js-api/test_memory_constructor.js




Diff

Modified: trunk/JSTests/ChangeLog (220264 => 220265)

--- trunk/JSTests/ChangeLog	2017-08-04 09:54:42 UTC (rev 220264)
+++ trunk/JSTests/ChangeLog	2017-08-04 10:01:15 UTC (rev 220265)
@@ -1,3 +1,12 @@
+2017-08-03  Carlos Alberto Lopez Perez  
+
+JSC test wasm/js-api/test_memory_constructor.js should be skipped on memoryLimited
+https://bugs.webkit.org/show_bug.cgi?id=175150
+
+Unreviewed test gardening.
+
+* wasm/js-api/test_memory_constructor.js:
+
 2017-08-02  Carlos Alberto Lopez Perez  
 
 [Linux] JSTests/wasm/stress/oom.js should not run on Linux


Modified: trunk/JSTests/wasm/js-api/test_memory_constructor.js (220264 => 220265)

--- trunk/JSTests/wasm/js-api/test_memory_constructor.js	2017-08-04 09:54:42 UTC (rev 220264)
+++ trunk/JSTests/wasm/js-api/test_memory_constructor.js	2017-08-04 10:01:15 UTC (rev 220265)
@@ -1,4 +1,5 @@
 // FIXME: use the assert library: https://bugs.webkit.org/show_bug.cgi?id=165684
+//@ skip if $memoryLimited
 import Builder from '../Builder.js';
 
 function assert(b) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220246] trunk/Tools

[clopez]

Title: [220246] trunk/Tools








Revision 220246
Author clo...@igalia.com
Date 2017-08-03 18:12:52 -0700 (Thu, 03 Aug 2017)


Log Message
REGRESSION(r219850): run-benchmark script broken on Linux
https://bugs.webkit.org/show_bug.cgi?id=175126

Reviewed by Stephanie Lewis.

The run-benchmark script dynamically generates the list of supported
browsers and platforms (currently Linux and OSX) by loading all
python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
and getting the browser_name and platform variables from the
classes defined there.

This means that this classes should not raise an exception when
loaded on other platforms or otherwise they will broke the whole
script. Its fine if they raise an exception when executing any of
the methods they implement, but not when just loading/importing
the class.

Move the argument variable definitions that call on the platform
specific OSXBrowserDriver._screen_size() function from beeing
variables that are evaluated when loading the file, to be functions
that are only evaluated when the actual functionality needs to be
executed.

* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver.launch_url):
(OSXChromeCanaryDriver.launch_url):
(create_args):
(create_chrome_options):
(create_window_size_arg):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_driver):
(create_args):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py




Diff

Modified: trunk/Tools/ChangeLog (220245 => 220246)

--- trunk/Tools/ChangeLog	2017-08-04 01:07:24 UTC (rev 220245)
+++ trunk/Tools/ChangeLog	2017-08-04 01:12:52 UTC (rev 220246)
@@ -1,3 +1,40 @@
+2017-08-03  Carlos Alberto Lopez Perez  
+
+REGRESSION(r219850): run-benchmark script broken on Linux
+https://bugs.webkit.org/show_bug.cgi?id=175126
+
+Reviewed by Stephanie Lewis.
+
+The run-benchmark script dynamically generates the list of supported
+browsers and platforms (currently Linux and OSX) by loading all
+python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
+and getting the browser_name and platform variables from the
+classes defined there.
+
+This means that this classes should not raise an exception when
+loaded on other platforms or otherwise they will broke the whole
+script. Its fine if they raise an exception when executing any of
+the methods they implement, but not when just loading/importing
+the class.
+
+Move the argument variable definitions that call on the platform
+specific OSXBrowserDriver._screen_size() function from beeing
+variables that are evaluated when loading the file, to be functions
+that are only evaluated when the actual functionality needs to be
+executed.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
+(OSXChromeDriver.launch_url):
+(OSXChromeCanaryDriver.launch_url):
+(create_args):
+(create_chrome_options):
+(create_window_size_arg):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
+(OSXFirefoxDriver.launch_url):
+(OSXFirefoxNightlyDriver.launch_url):
+(OSXFirefoxNightlyDriver.launch_driver):
+(create_args):
+
 2017-08-03  Yoshiaki Jitsukawa  
 
 [PAL] Move spi/cf directory into PAL


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py (220245 => 220246)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py	2017-08-04 01:07:24 UTC (rev 220245)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py	2017-08-04 01:12:52 UTC (rev 220246)
@@ -7,8 +7,6 @@
 
 
 _log = logging.getLogger(__name__)
-window_size_arg = '--window-size={width},{height}'.format(width=int(OSXBrowserDriver._screen_size().width), height=int(OSXBrowserDriver._screen_size().height))
-args = ['--args', '--homepage', window_size_arg]
 
 class OSXChromeDriver(OSXBrowserDriver):
 process_name = 'Google Chrome'
@@ -16,7 +14,7 @@
 app_name = 'Google Chrome.app'
 
 def launch_url(self, url, options, browser_build_path):
-args_with_url = self._insert_url(args, 2, url)
+args_with_url = self._insert_url(create_args(), 2, url)
 self._launch_process(build_dir=browser_build_path, app_name=self.app_name, url="" args=args_with_url)
 
 def launch_driver(self, url, options, browser_build_path):
@@ -38,7 +36,7 @@
 app_name = 'Google Chrome Canary.app'
 
 def launch_url(self, url, options, browser_build_path):
-

[webkit-changes] [220221] trunk/Tools

[clopez]

Title: [220221] trunk/Tools








Revision 220221
Author clo...@igalia.com
Date 2017-08-03 12:37:13 -0700 (Thu, 03 Aug 2017)


Log Message
[GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=175140

Reviewed by Alexey Proskuryakov.

We are having lately issues with JSC tests causing problems on
the GTK+ and WPE bots due to the high amount of memory some tests
need to run.

The best thing we can do now is to workaround this by disabling
all the tests marked as memoryLimited on the GTK and WPE bots.
We may revise this on the future.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunJavaScriptCoreTests.start):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (220220 => 220221)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 19:21:43 UTC (rev 220220)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-08-03 19:37:13 UTC (rev 220221)
@@ -334,7 +334,12 @@
 logfiles = {"json": jsonFileName}
 
 def start(self):
-appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
+platform = self.getProperty('platform')
+# Linux bots have currently problems with JSC tests that try to use large amounts of memory.
+# Check: https://bugs.webkit.org/show_bug.cgi?id=175140
+if platform in ('gtk', 'wpe'):
+self.setCommand(self.command + ['--memory-limited'])
+appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
 return shell.Test.start(self)
 
 def countFailures(self, cmd):


Modified: trunk/Tools/ChangeLog (220220 => 220221)

--- trunk/Tools/ChangeLog	2017-08-03 19:21:43 UTC (rev 220220)
+++ trunk/Tools/ChangeLog	2017-08-03 19:37:13 UTC (rev 220221)
@@ -1,3 +1,21 @@
+2017-08-03  Carlos Alberto Lopez Perez  
+
+[GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
+https://bugs.webkit.org/show_bug.cgi?id=175140
+
+Reviewed by Alexey Proskuryakov.
+
+We are having lately issues with JSC tests causing problems on
+the GTK+ and WPE bots due to the high amount of memory some tests
+need to run.
+
+The best thing we can do now is to workaround this by disabling
+all the tests marked as memoryLimited on the GTK and WPE bots.
+We may revise this on the future.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunJavaScriptCoreTests.start):
+
 2017-08-03  Brady Eidson  
 
 Add SW IDLs and stub out basic functionality.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220173] trunk/JSTests

[clopez]

Title: [220173] trunk/JSTests








Revision 220173
Author clo...@igalia.com
Date 2017-08-02 18:42:13 -0700 (Wed, 02 Aug 2017)


Log Message
[Linux] JSTests/wasm/stress/oom.js should not run on Linux
https://bugs.webkit.org/show_bug.cgi?id=175100

Reviewed by Mark Lam.

The JSC test JSTests/wasm/stress/oom.js tries to use all the
available memory until an out of memory exception happens.

The Linux kernel is more tuned for server workloads than for GUI
responsiveness. When a process tries to use a lot of memory, Linux
will do its best to serve the request. This usually translates to
free physical RAM by writing to disk dirty pages and/or moving out
less recently used pages to swap (disk storage).
Meanwhile it does this, the system will become unresponsive and this
leads to freezes that can last even some minutes on the worst cases.

Therefore, let's skip this test on Linux as it will cause more harm
than good on the Linux bots or on the machines of Linux developers.

* wasm/stress/oom.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/stress/oom.js




Diff

Modified: trunk/JSTests/ChangeLog (220172 => 220173)

--- trunk/JSTests/ChangeLog	2017-08-03 01:33:16 UTC (rev 220172)
+++ trunk/JSTests/ChangeLog	2017-08-03 01:42:13 UTC (rev 220173)
@@ -1,3 +1,26 @@
+2017-08-02  Carlos Alberto Lopez Perez  
+
+[Linux] JSTests/wasm/stress/oom.js should not run on Linux
+https://bugs.webkit.org/show_bug.cgi?id=175100
+
+Reviewed by Mark Lam.
+
+The JSC test JSTests/wasm/stress/oom.js tries to use all the
+available memory until an out of memory exception happens.
+
+The Linux kernel is more tuned for server workloads than for GUI
+responsiveness. When a process tries to use a lot of memory, Linux
+will do its best to serve the request. This usually translates to
+free physical RAM by writing to disk dirty pages and/or moving out
+less recently used pages to swap (disk storage).
+Meanwhile it does this, the system will become unresponsive and this
+leads to freezes that can last even some minutes on the worst cases.
+
+Therefore, let's skip this test on Linux as it will cause more harm
+than good on the Linux bots or on the machines of Linux developers.
+
+* wasm/stress/oom.js:
+
 2017-08-01  Oleksandr Skachkov  
 
 [JSC] Remove unnecessary print from stress\promise-finally.js test


Modified: trunk/JSTests/wasm/stress/oom.js (220172 => 220173)

--- trunk/JSTests/wasm/stress/oom.js	2017-08-03 01:33:16 UTC (rev 220172)
+++ trunk/JSTests/wasm/stress/oom.js	2017-08-03 01:42:13 UTC (rev 220173)
@@ -1,5 +1,5 @@
 // We don't need N versions of this simultaneously filling up RAM.
-//@ runDefault
+//@ if $hostOS == "linux" then skip else runDefault end
 
 const verbose = false;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219823] trunk/Source/WebCore/PAL

[clopez]

Title: [219823] trunk/Source/WebCore/PAL








Revision 219823
Author clo...@igalia.com
Date 2017-07-24 09:01:33 -0700 (Mon, 24 Jul 2017)


Log Message
[CMake] libtasn1 should not be required when not enabling subtle_crypto
https://bugs.webkit.org/show_bug.cgi?id=174785

Reviewed by Žan Doberšek.

* pal/PlatformGTK.cmake:
* pal/PlatformWPE.cmake:

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/PlatformGTK.cmake
trunk/Source/WebCore/PAL/pal/PlatformWPE.cmake




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (219822 => 219823)

--- trunk/Source/WebCore/PAL/ChangeLog	2017-07-24 15:43:43 UTC (rev 219822)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-07-24 16:01:33 UTC (rev 219823)
@@ -1,3 +1,13 @@
+2017-07-24  Carlos Alberto Lopez Perez  
+
+[CMake] libtasn1 should not be required when not enabling subtle_crypto
+https://bugs.webkit.org/show_bug.cgi?id=174785
+
+Reviewed by Žan Doberšek.
+
+* pal/PlatformGTK.cmake:
+* pal/PlatformWPE.cmake:
+
 2017-07-18  Andy Estes  
 
 [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS


Modified: trunk/Source/WebCore/PAL/pal/PlatformGTK.cmake (219822 => 219823)

--- trunk/Source/WebCore/PAL/pal/PlatformGTK.cmake	2017-07-24 15:43:43 UTC (rev 219822)
+++ trunk/Source/WebCore/PAL/pal/PlatformGTK.cmake	2017-07-24 16:01:33 UTC (rev 219823)
@@ -1,13 +1,17 @@
 list(APPEND PAL_SOURCES
 crypto/gcrypt/CryptoDigestGCrypt.cpp
 
-crypto/tasn1/Utilities.cpp
-
 system/gtk/SoundGtk.cpp
 
 text/KillRingNone.cpp
 )
 
+if (ENABLE_SUBTLE_CRYPTO)
+list(APPEND PAL_SOURCES
+crypto/tasn1/Utilities.cpp
+)
+endif ()
+
 list(APPEND PAL_SYSTEM_INCLUDE_DIRECTORIES
 ${GDK_INCLUDE_DIRS}
 )


Modified: trunk/Source/WebCore/PAL/pal/PlatformWPE.cmake (219822 => 219823)

--- trunk/Source/WebCore/PAL/pal/PlatformWPE.cmake	2017-07-24 15:43:43 UTC (rev 219822)
+++ trunk/Source/WebCore/PAL/pal/PlatformWPE.cmake	2017-07-24 16:01:33 UTC (rev 219823)
@@ -1,9 +1,13 @@
 list(APPEND PAL_SOURCES
 crypto/gcrypt/CryptoDigestGCrypt.cpp
 
-crypto/tasn1/Utilities.cpp
-
 system/SoundNone.cpp
 
 text/KillRingNone.cpp
 )
+
+if (ENABLE_SUBTLE_CRYPTO)
+list(APPEND PAL_SOURCES
+crypto/tasn1/Utilities.cpp
+)
+endif ()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219658] trunk/Source/WebCore

[clopez]

Title: [219658] trunk/Source/WebCore








Revision 219658
Author clo...@igalia.com
Date 2017-07-19 10:27:10 -0700 (Wed, 19 Jul 2017)


Log Message
[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=174628

Reviewed by Žan Doberšek.

* Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (219657 => 219658)

--- trunk/Source/WebCore/ChangeLog	2017-07-19 17:09:32 UTC (rev 219657)
+++ trunk/Source/WebCore/ChangeLog	2017-07-19 17:27:10 UTC (rev 219658)
@@ -1,3 +1,13 @@
+2017-07-18  Carlos Alberto Lopez Perez  
+
+[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
+https://bugs.webkit.org/show_bug.cgi?id=174628
+
+Reviewed by Žan Doberšek.
+
+* Modules/encryptedmedia/InitDataRegistry.cpp:
+(WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.
+
 2017-07-19  Matt Lewis  
 
 Unreviewed, rolling out r219646.


Modified: trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp (219657 => 219658)

--- trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp	2017-07-19 17:09:32 UTC (rev 219657)
+++ trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp	2017-07-19 17:27:10 UTC (rev 219658)
@@ -42,7 +42,9 @@
 {
 // 1. Format
 // https://w3c.github.io/encrypted-media/format-registry/initdata/keyids.html#format
-String json { buffer.data(), buffer.size() };
+if (buffer.size() > std::numeric_limits::max())
+return { };
+String json { buffer.data(), static_cast(buffer.size()) };
 
 RefPtr value;
 if (!InspectorValue::parseJSON(json, value))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219608] trunk/Source/WebDriver

[clopez]

Title: [219608] trunk/Source/WebDriver








Revision 219608
Author clo...@igalia.com
Date 2017-07-18 04:21:53 -0700 (Tue, 18 Jul 2017)


Log Message
[GTK] Fix build with Clang after r219605.
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

Clang-3.8 complains with the following error:
non-constant-_expression_ cannot be narrowed from type 'gboolean' (aka 'int') to 'bool' in initializer list [-Wc++11-narrowing]

* glib/SessionHostGlib.cpp: insert an explicit cast to silence this issue.

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/glib/SessionHostGlib.cpp




Diff

Modified: trunk/Source/WebDriver/ChangeLog (219607 => 219608)

--- trunk/Source/WebDriver/ChangeLog	2017-07-18 07:33:35 UTC (rev 219607)
+++ trunk/Source/WebDriver/ChangeLog	2017-07-18 11:21:53 UTC (rev 219608)
@@ -1,3 +1,15 @@
+2017-07-18  Carlos Alberto Lopez Perez  
+
+[GTK] Fix build with Clang after r219605.
+https://bugs.webkit.org/show_bug.cgi?id=166682
+
+Unreviewed build fix.
+
+Clang-3.8 complains with the following error:
+non-constant-_expression_ cannot be narrowed from type 'gboolean' (aka 'int') to 'bool' in initializer list [-Wc++11-narrowing]
+
+* glib/SessionHostGlib.cpp: insert an explicit cast to silence this issue.
+
 2017-07-13  Carlos Garcia Campos  
 
 Add initial implementation of WebDriver process to run the HTTP server


Modified: trunk/Source/WebDriver/glib/SessionHostGlib.cpp (219607 => 219608)

--- trunk/Source/WebDriver/glib/SessionHostGlib.cpp	2017-07-18 07:33:35 UTC (rev 219607)
+++ trunk/Source/WebDriver/glib/SessionHostGlib.cpp	2017-07-18 11:21:53 UTC (rev 219608)
@@ -77,7 +77,7 @@
 gboolean isPaired;
 while (g_variant_iter_loop(iter.get(), "(t)", , , , , )) {
 if (!g_strcmp0(type, "Automation"))
-targetList.uncheckedAppend({ targetID, name, isPaired });
+targetList.uncheckedAppend({ targetID, name, static_cast(isPaired) });
 }
 sessionHost->setTargetList(connectionID, WTFMove(targetList));
 g_dbus_method_invocation_return_value(invocation, nullptr);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219447] trunk

[clopez]

Title: [219447] trunk








Revision 219447
Author clo...@igalia.com
Date 2017-07-13 02:38:52 -0700 (Thu, 13 Jul 2017)


Log Message
REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests
https://bugs.webkit.org/show_bug.cgi?id=174395

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Covered by existing tests.

Before r219332 the height of the spin button widget was
calculated as the maximum value between the individual button
( the [+] or [-] ) width (33 pixels) and height (16 pixels).
And r219332 caused the height of the widget to be calculated as
the height of the button (16 pixels), which was incorrect as
each button should be first expanded vertically to fit the
preferred size of the widget.

Fix this by making the calculations about the spin button widget
on a new function spinButtonSize() that takes this into account,
and use this values both for adjusting the style of the input
field and the spin button widget itself.

* rendering/RenderThemeGtk.cpp:
(WebCore::spinButtonSize):
(WebCore::RenderThemeGtk::adjustTextFieldStyle):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

LayoutTests:

* fast/forms/number/number-spinbutton-in-multi-column.html: Instead of assuming that the width will be 100, calculate a -7 offset dinamically.
* platform/gtk/TestExpectations: Remove expected failures now orking.
* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Rebaseline.
* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/number/number-spinbutton-in-multi-column.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (219446 => 219447)

--- trunk/LayoutTests/ChangeLog	2017-07-13 09:21:52 UTC (rev 219446)
+++ trunk/LayoutTests/ChangeLog	2017-07-13 09:38:52 UTC (rev 219447)
@@ -1,3 +1,15 @@
+2017-07-12  Carlos Alberto Lopez Perez  
+
+REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests
+https://bugs.webkit.org/show_bug.cgi?id=174395
+
+Reviewed by Carlos Garcia Campos.
+
+* fast/forms/number/number-spinbutton-in-multi-column.html: Instead of assuming that the width will be 100, calculate a -7 offset dinamically.
+* platform/gtk/TestExpectations: Remove expected failures now orking.
+* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Rebaseline.
+* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Rebaseline.
+
 2017-07-13  Caio Lima  
 
 [ESnext] Implement Object Spread


Modified: trunk/LayoutTests/fast/forms/number/number-spinbutton-in-multi-column.html (219446 => 219447)

--- trunk/LayoutTests/fast/forms/number/number-spinbutton-in-multi-column.html	2017-07-13 09:21:52 UTC (rev 219446)
+++ trunk/LayoutTests/fast/forms/number/number-spinbutton-in-multi-column.html	2017-07-13 09:38:52 UTC (rev 219447)
@@ -58,7 +58,7 @@
 const spinId = "c" + formIndex + colIndex;
 const spin = document.getElementById(spinId);
 
-const clickX = pageX(column) + colWidth * colIndex + ofsX;
+const clickX = pageX(column) + colWidth * colIndex + spin.offsetWidth + ofsX;
 const clickY = pageY(column) + Math.floor(spin.offsetHeight / 3) + 2;
 
 eventSender.mouseMoveTo(clickX, clickY);
@@ -92,7 +92,7 @@
 
 for (var formIndex = 0; formIndex < numForms; formIndex++) {
 for (var colIndex = 0; colIndex < numCols; colIndex++) {
-  testIt(formIndex, colIndex, 93, 10);
+  testIt(formIndex, colIndex, -7, 10);
 }
 }
 }


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (219446 => 219447)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-13 09:21:52 UTC (rev 219446)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-13 09:38:52 UTC (rev 219447)
@@ -1256,17 +1256,6 @@
 # GTK port doesn't use the scrolling tree
 fast/scrolling/scrolling-tree-includes-frame.html [ Skip ]
 
-# Regressions on fast/forms spinbutton related tests after r219332
-webkit.org/b/174395 fast/events/touch/touch-before-pressing-spin-button.html [ Failure ]
-webkit.org/b/174395 fast/forms/input-number-click.html [ Failure ]
-webkit.org/b/174395 fast/forms/input-step-as-double.html [ Failure ]
-webkit.org/b/174395 fast/forms/number/number-large-padding.html [ Failure ]
-webkit.org/b/174395 fast/forms/number/number-spinbutton-capturing.html [ Failure ]
-webkit.org/b/174395 fast/forms/number/number-spinbutton-change-and-input-events.html [ Failure ]
-webkit.org/b/174395 

[webkit-changes] [219368] trunk/LayoutTests

[clopez]

Title: [219368] trunk/LayoutTests








Revision 219368
Author clo...@igalia.com
Date 2017-07-11 15:33:10 -0700 (Tue, 11 Jul 2017)


Log Message
REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests.
https://bugs.webkit.org/show_bug.cgi?id=174395

Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Mark the new failures. Further investigation pending.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (219367 => 219368)

--- trunk/LayoutTests/ChangeLog	2017-07-11 22:28:57 UTC (rev 219367)
+++ trunk/LayoutTests/ChangeLog	2017-07-11 22:33:10 UTC (rev 219368)
@@ -1,3 +1,12 @@
+2017-07-11  Carlos Alberto Lopez Perez  
+
+REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests.
+https://bugs.webkit.org/show_bug.cgi?id=174395
+
+Unreviewed GTK gardening.
+
+* platform/gtk/TestExpectations: Mark the new failures. Further investigation pending.
+
 2017-07-11  Said Abou-Hallawa  
 
 REGRESSION(r219045): The  element does not get repainted when its background image finishes decoding


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (219367 => 219368)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-11 22:28:57 UTC (rev 219367)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-11 22:33:10 UTC (rev 219368)
@@ -1262,6 +1262,17 @@
 # GTK port doesn't use the scrolling tree
 fast/scrolling/scrolling-tree-includes-frame.html [ Skip ]
 
+# Regressions on fast/forms spinbutton related tests after r219332
+webkit.org/b/174395 fast/events/touch/touch-before-pressing-spin-button.html [ Failure ]
+webkit.org/b/174395 fast/forms/input-number-click.html [ Failure ]
+webkit.org/b/174395 fast/forms/input-step-as-double.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-large-padding.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-spinbutton-capturing.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-spinbutton-change-and-input-events.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-spinbutton-in-multi-column.html [ Failure ]
+webkit.org/b/174395 fast/forms/number/number-spinbutton-state.html [ Failure ]
+
 #
 # End of Expected failures
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219344] trunk/Source/WebKit2

[clopez]

Title: [219344] trunk/Source/WebKit2








Revision 219344
Author clo...@igalia.com
Date 2017-07-11 11:08:28 -0700 (Tue, 11 Jul 2017)


Log Message
Changing the web page muted state for playing audio should not disable other tabs capture
https://bugs.webkit.org/show_bug.cgi?id=174349

Unreviewed.

Patch by Youenn Fablet  on 2017-07-11

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activateMediaStreamCaptureInPage): Fixes non MEDIA_STREAM builds.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (219343 => 219344)

--- trunk/Source/WebKit2/ChangeLog	2017-07-11 18:07:24 UTC (rev 219343)
+++ trunk/Source/WebKit2/ChangeLog	2017-07-11 18:08:28 UTC (rev 219344)
@@ -1,3 +1,13 @@
+2017-07-11  Youenn Fablet  
+
+Changing the web page muted state for playing audio should not disable other tabs capture
+https://bugs.webkit.org/show_bug.cgi?id=174349
+
+Unreviewed.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::activateMediaStreamCaptureInPage): Fixes non MEDIA_STREAM builds.
+
 2017-07-11  Wenson Hsieh  
 
 Address post-review feedback after http://trac.webkit.org/r219310


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (219343 => 219344)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2017-07-11 18:07:24 UTC (rev 219343)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2017-07-11 18:08:28 UTC (rev 219344)
@@ -1669,7 +1669,9 @@
 
 void WebPageProxy::activateMediaStreamCaptureInPage()
 {
+#if ENABLE(MEDIA_STREAM)
 UserMediaProcessManager::singleton().muteCaptureMediaStreamsExceptIn(*this);
+#endif
 setMuted(m_mutedState & ~WebCore::MediaProducer::CaptureDevicesAreMuted);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219332] trunk

[clopez]

Title: [219332] trunk








Revision 219332
Author clo...@igalia.com
Date 2017-07-11 08:34:41 -0700 (Tue, 11 Jul 2017)


Log Message
[GTK] Spin buttons on input type number appear over the value itself for small widths
https://bugs.webkit.org/show_bug.cgi?id=173572

Reviewed by Carlos Garcia Campos.

Source/WebCore:

When drawing the spin buttons, override the width of the input
element to increment it with the width of the spin button.
This ensures that we don't end up covering the input values with
the spin buttons.

Do this also for user controlled styles, because most web authors
won't test how their site renders on WebKitGTK+, and they will
assume spin buttons in the order of 13 pixels wide (that is what
most browsers use), but the GTK+ spin button is much wider (66 pixels).

Test: platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the theme's adjustTextFieldStyle() also for user controlled styles.
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

LayoutTests:

* fast/forms/number/number-size-expected.txt:
* fast/forms/number/number-size.html: Obtain the size of the spinbutton by inspecting the shadow dom (is more reliable)
  and make the test for user controlled style special for the case of GTK+.
* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Added.
* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Added.
* platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/number/number-size-expected.txt
trunk/LayoutTests/fast/forms/number/number-size.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp


Added Paths

trunk/LayoutTests/platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html




Diff

Modified: trunk/LayoutTests/ChangeLog (219331 => 219332)

--- trunk/LayoutTests/ChangeLog	2017-07-11 15:32:38 UTC (rev 219331)
+++ trunk/LayoutTests/ChangeLog	2017-07-11 15:34:41 UTC (rev 219332)
@@ -1,3 +1,17 @@
+2017-07-11  Carlos Alberto Lopez Perez  
+
+[GTK] Spin buttons on input type number appear over the value itself for small widths
+https://bugs.webkit.org/show_bug.cgi?id=173572
+
+Reviewed by Carlos Garcia Campos.
+
+* fast/forms/number/number-size-expected.txt:
+* fast/forms/number/number-size.html: Obtain the size of the spinbutton by inspecting the shadow dom (is more reliable)
+  and make the test for user controlled style special for the case of GTK+.
+* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png: Added.
+* platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt: Added.
+* platform/gtk/fast/forms/number/number-size-spinbutton-nocover.html: Added.
+
 2017-07-11  Youenn Fablet  
 
 We should do ICE candidate filtering at the Document level


Modified: trunk/LayoutTests/fast/forms/number/number-size-expected.txt (219331 => 219332)

--- trunk/LayoutTests/fast/forms/number/number-size-expected.txt	2017-07-11 15:32:38 UTC (rev 219331)
+++ trunk/LayoutTests/fast/forms/number/number-size-expected.txt	2017-07-11 15:34:41 UTC (rev 219332)
@@ -8,8 +8,8 @@
 PASS number.offsetWidth is text.offsetWidth
 
 The number whose width is specified should respect the setting
-PASS numberWithWidth.offsetWidth is 100
-PASS numberWithWidth.min = 0; numberWithWidth.max = 100; numberWithWidth.offsetWidth is 100
+PASS numberWithWidth.offsetWidth is widthSpecified(100)
+PASS numberWithWidth.min = 0; numberWithWidth.max = 100; numberWithWidth.offsetWidth is widthSpecified(100)
 
 The number input should ignore size attribute for layout
 PASS number.size = 10; number.offsetWidth is text.offsetWidth


Modified: trunk/LayoutTests/fast/forms/number/number-size.html (219331 => 219332)

--- trunk/LayoutTests/fast/forms/number/number-size.html	2017-07-11 15:32:38 UTC (rev 219331)
+++ trunk/LayoutTests/fast/forms/number/number-size.html	2017-07-11 15:34:41 UTC (rev 219332)
@@ -2,6 +2,8 @@
 
 
 

[webkit-changes] [219227] trunk/Tools

[clopez]

Title: [219227] trunk/Tools








Revision 219227
Author clo...@igalia.com
Date 2017-07-06 17:46:53 -0700 (Thu, 06 Jul 2017)


Log Message
[GTK][WPE] kill-old-process should kill more webkit related process
https://bugs.webkit.org/show_bug.cgi?id=174220

Reviewed by Michael Catanzaro.

Generate list of possible webkit-related process names and add
them to the list of process to kill.
Also update the possible system related process for GTK+/WPE.

* BuildSlaveSupport/kill-old-processes:
(listAllWebKitPrograms):
(main):

Modified Paths

trunk/Tools/BuildSlaveSupport/kill-old-processes
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/kill-old-processes (219226 => 219227)

--- trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-07-07 00:00:30 UTC (rev 219226)
+++ trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-07-07 00:46:53 UTC (rev 219227)
@@ -25,7 +25,15 @@
 
 import os, sys
 
+def listAllWebKitPrograms(builddir_bin):
+foundWebKitPrograms = []
+for root, dirs, files in os.walk(builddir_bin):
+for file in files:
+if os.access(os.path.join(root, file), os.X_OK):
+foundWebKitPrograms.append(file)
+return foundWebKitPrograms
 
+
 def main(user=None):
 tasksToKillWin = [
 "cl.exe",
@@ -93,18 +101,20 @@
 ]
 
 taskToKillUnix = [
-"apache2",
+# System process that are executed as part of the build process
 "cc1plus",
-"DumpRenderTree",
-"gold",
-"httpd",
+"ld.gold",
 "ld",
 "make",
-"ruby",
+"cmake",
 "svn",
-"webkit_unit_tests",
-"WebKitTestRunner",
+# System process that are executed as part of the test steps
 "Xvfb",
+"gdb",
+"ruby",
+"apache2",
+"httpd",
+# WebKit related process names are automatically generated for GTK+/WPE/JSCOnly
 ]
 
 # This allows to specify on the environment of the bot a list of process that should be killed.
@@ -123,7 +133,8 @@
 for task in tasksToKill + tasksToKillWin:
 os.system("taskkill /t /f /im " + task)
 elif sys.platform.startswith('linux'):
-for task in tasksToKill + taskToKillUnix:
+builddir_bin = "WebKitBuild/Release/bin" if os.path.isdir("WebKitBuild/Release/bin") else "WebKitBuild/Debug/bin"
+for task in tasksToKill + taskToKillUnix + listAllWebKitPrograms(builddir_bin):
 os.system("killall -9 -v " + task)
 os.system("ps aux | grep -P '.+/python .+(run_webkit_tests|run-webkit-tests|mod_pywebsocket)' | grep -v grep | awk '{print $2}' | xargs kill")
 else:


Modified: trunk/Tools/ChangeLog (219226 => 219227)

--- trunk/Tools/ChangeLog	2017-07-07 00:00:30 UTC (rev 219226)
+++ trunk/Tools/ChangeLog	2017-07-07 00:46:53 UTC (rev 219227)
@@ -1,3 +1,18 @@
+2017-07-06  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] kill-old-process should kill more webkit related process
+https://bugs.webkit.org/show_bug.cgi?id=174220
+
+Reviewed by Michael Catanzaro.
+
+Generate list of possible webkit-related process names and add
+them to the list of process to kill.
+Also update the possible system related process for GTK+/WPE.
+
+* BuildSlaveSupport/kill-old-processes:
+(listAllWebKitPrograms):
+(main):
+
 2017-07-06  Chris Dumez  
 
 FileMonitor should not be ref counted






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [219206] trunk/LayoutTests

[clopez]

Title: [219206] trunk/LayoutTests








Revision 219206
Author clo...@igalia.com
Date 2017-07-06 11:24:12 -0700 (Thu, 06 Jul 2017)


Log Message
[GTK] Layout test gardening.

Unreviewed.

* platform/gtk/TestExpectations: Update WebRTC related expectations and mark a new emoji related test failing after r218371.
* platform/gtk/fast/css/css2-system-fonts-expected.txt: Rebaseline after r218446.
* platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-stretch-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-style-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
* platform/gtk/fast/text/font-weight-parse-expected.txt: Removed Rebaseline after r218446 (use the general expectation).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/css/css2-system-fonts-expected.txt


Removed Paths

trunk/LayoutTests/platform/gtk/fast/css/getComputedStyle/
trunk/LayoutTests/platform/gtk/fast/text/font-stretch-parse-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/font-style-parse-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/font-weight-parse-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (219205 => 219206)

--- trunk/LayoutTests/ChangeLog	2017-07-06 18:22:44 UTC (rev 219205)
+++ trunk/LayoutTests/ChangeLog	2017-07-06 18:24:12 UTC (rev 219206)
@@ -1,3 +1,16 @@
+2017-07-06  Carlos Alberto Lopez Perez  
+
+[GTK] Layout test gardening.
+
+Unreviewed.
+
+* platform/gtk/TestExpectations: Update WebRTC related expectations and mark a new emoji related test failing after r218371.
+* platform/gtk/fast/css/css2-system-fonts-expected.txt: Rebaseline after r218446.
+* platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
+* platform/gtk/fast/text/font-stretch-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
+* platform/gtk/fast/text/font-style-parse-expected.txt: Removed. Rebaseline after r218446 (use the general expectation).
+* platform/gtk/fast/text/font-weight-parse-expected.txt: Removed Rebaseline after r218446 (use the general expectation).
+
 2017-07-06  Commit Queue  
 
 Unreviewed, rolling out r219194.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (219205 => 219206)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-06 18:22:44 UTC (rev 219205)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-06 18:24:12 UTC (rev 219206)
@@ -625,32 +625,36 @@
 # GTK uses OWR instead of libwebrtc
 webrtc/libwebrtc [ Skip ]
 # Some WebRTC features like datachannel are still not implemented
+webrtc/audio-replace-track.html [ Failure ]
+webrtc/captureCanvas-webrtc.html [ Failure ]
+webrtc/clone-audio-track.html [ Failure ]
+webrtc/closing-peerconnection.html [ Timeout ]
+webrtc/connection-state.html [ Failure ]
 webrtc/datachannel [ Skip ]
+webrtc/ephemeral-certificates-and-cnames.html [ Failure ]
+webrtc/multi-video.html [ Failure ]
 webrtc/no-port-zero-in-upd-candidates.html [ Timeout ]
+webrtc/peer-connection-audio-mute2.html [ Crash Failure ]
+webrtc/peer-connection-audio-mute.html [ Failure ]
+webrtc/peer-connection-audio-unmute.html [ Failure ]
+webrtc/peer-connection-remote-audio-mute2.html [ Crash Failure ]
+webrtc/peer-connection-remote-audio-mute.html [ Failure ]
+webrtc/peer-connection-track-end.html [ Failure ]
+webrtc/video-addTrack.html [ Crash ]
 webrtc/video-disabled-black.html [ Failure ]
+webrtc/video-getParameters.html [ Failure ]
 webrtc/video.html [ Failure ]
-webrtc/peer-connection-audio-mute.html [ Failure ]
-webrtc/peer-connection-audio-mute2.html [ Crash Failure ]
-webrtc/peer-connection-remote-audio-mute.html [ Failure ]
-webrtc/peer-connection-remote-audio-mute2.html [ Crash Failure ]
+webrtc/video-mediastreamtrack-stats.html [ Failure ]
 webrtc/video-mute.html [ Failure Timeout ]
 webrtc/video-remote-mute.html [ Failure ]
-webrtc/video-with-receiver.html [ Failure ]
-webrtc/connection-state.html [ Failure ]
+webrtc/video-replace-muted-track.html [ Failure ]
+webrtc/video-replace-track.html [ Failure ]
+webrtc/video-replace-track-to-null.html [ Failure ]
+webrtc/video-rotation.html [ Failure ]
 webrtc/video-stats.html [ Failure ]
-webrtc/audio-replace-track.html [ Failure ]
-webrtc/video-mediastreamtrack-stats.html [ Failure ]
-webrtc/video-replace-track-to-null.html [ Failure ]
-webrtc/video-replace-track.html [ Failure ]
-webrtc/video-getParameters.html [ Failure ]
-webrtc/multi-video.html [ Failure ]
+webrtc/video-unmute.html [ Failure Timeout ]
 webrtc/video-with-data-channel.html [ Failure ]

[webkit-changes] [218711] trunk/Websites/bugs.webkit.org

[clopez]

Title: [218711] trunk/Websites/bugs.webkit.org








Revision 218711
Author clo...@igalia.com
Date 2017-06-22 12:38:39 -0700 (Thu, 22 Jun 2017)


Log Message
pretty patch doesn't show image diffs with newer versions of git
https://bugs.webkit.org/show_bug.cgi?id=173691

A new security check added in git >= 2.3.3 causes it to abort
when the tool runs "git apply" to generate the images.
Detect if git supports the flag --unsafe-paths and pass it.

Reviewed by Darin Adler.

* PrettyPatch/PrettyPatch.rb:

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (218710 => 218711)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2017-06-22 18:56:15 UTC (rev 218710)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2017-06-22 19:38:39 UTC (rev 218711)
@@ -1,3 +1,16 @@
+2017-06-22  Carlos Alberto Lopez Perez  
+
+pretty patch doesn't show image diffs with newer versions of git
+https://bugs.webkit.org/show_bug.cgi?id=173691
+
+A new security check added in git >= 2.3.3 causes it to abort
+when the tool runs "git apply" to generate the images.
+Detect if git supports the flag --unsafe-paths and pass it.
+
+Reviewed by Darin Adler.
+
+* PrettyPatch/PrettyPatch.rb:
+
 2017-05-26  Devin Rousso  
 
 Provide bug information when https://webkit.org/b/# URLs are added in comments


Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (218710 => 218711)

--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2017-06-22 18:56:15 UTC (rev 218710)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2017-06-22 19:38:39 UTC (rev 218711)
@@ -777,7 +777,16 @@
 
 def self.run_git_apply_on_patch(output_filepath, patch)
 # Apply the git binary patch using git-apply.
-cmd = GIT_PATH + " apply --directory=" + File.dirname(output_filepath)
+cmd = GIT_PATH + " apply"
+# Check if we need to pass --unsafe-paths (git >= 2.3.3)
+helpcmd = GIT_PATH + " help apply"
+stdin, stdout, stderr = *Open3.popen3(helpcmd)
+begin
+if stdout.read().include? "--unsafe-paths"
+cmd += " --unsafe-paths"
+end
+end
+cmd += " --directory=" + File.dirname(output_filepath)
 stdin, stdout, stderr = *Open3.popen3(cmd)
 begin
 stdin.puts(patch)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [215561] trunk/LayoutTests

[clopez]

Title: [215561] trunk/LayoutTests








Revision 215561
Author clo...@igalia.com
Date 2017-04-20 09:46:04 -0700 (Thu, 20 Apr 2017)


Log Message
[GTK] Update layout tests expectations after r215556
https://bugs.webkit.org/show_bug.cgi?id=170942

Unreviewed gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (215560 => 215561)

--- trunk/LayoutTests/ChangeLog	2017-04-20 16:16:43 UTC (rev 215560)
+++ trunk/LayoutTests/ChangeLog	2017-04-20 16:46:04 UTC (rev 215561)
@@ -1,3 +1,12 @@
+2017-04-20  Carlos Alberto Lopez Perez  
+
+[GTK] Update layout tests expectations after r215556
+https://bugs.webkit.org/show_bug.cgi?id=170942
+
+Unreviewed gardening.
+
+* platform/gtk/TestExpectations:
+
 2017-04-20  Youenn Fablet  
 
 RTCPeerConnection is stopping its backend twice sometimes


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (215560 => 215561)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-04-20 16:16:43 UTC (rev 215560)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-04-20 16:46:04 UTC (rev 215561)
@@ -1230,6 +1230,21 @@
 # WebGPU is not enabled on GTK+.
 fast/canvas/webgpu [ Skip ]
 
+# Failure to identify mime-type of empty (zero byte) resources.
+webkit.org/b/171058 fast/preloader/document-write-noscript.html [ Failure ]
+webkit.org/b/171058 fast/preloader/document-write.html [ Failure ]
+webkit.org/b/171058 fast/preloader/first-base-tag-scanned-wins.html [ Failure ]
+webkit.org/b/171058 fast/preloader/first-base-tag-wins.html [ Failure ]
+webkit.org/b/171058 fast/preloader/image-srcset.html [ Failure ]
+webkit.org/b/171058 fast/preloader/image.html [ Failure ]
+webkit.org/b/171058 fast/preloader/input.html [ Failure ]
+webkit.org/b/171058 fast/preloader/link.html [ Failure ]
+webkit.org/b/171058 fast/preloader/noscript.html [ Failure ]
+webkit.org/b/171058 fast/preloader/script.html [ Failure ]
+webkit.org/b/171058 fast/preloader/style.html [ Failure ]
+webkit.org/b/171058 fast/preloader/understands-base-tag.html [ Failure ]
+webkit.org/b/171058 tables/mozilla/core/col_widths_fix_autoFixPer.html [ Failure ]
+
 #
 # End of Expected failures
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214960] trunk

[clopez]

Title: [214960] trunk








Revision 214960
Author clo...@igalia.com
Date 2017-04-05 12:14:36 -0700 (Wed, 05 Apr 2017)


Log Message
[WebRTC][OpenWebRTC] Add support for SDP BUNDLE ("a:group:BUNDLE" and "a=bundle-only" lines)
https://bugs.webkit.org/show_bug.cgi?id=170157

Reviewed by Alejandro G. Castro.

Source/WebCore:

This implements support on the SDPProcessor for generating an "a=group:BUNDLE"
attribute with the MID identifiers specified in the bundle group in the most
recent answer.
It also implements support for generating "a=bundle-only" attributes on the
"m=" sections of the SDP according to the bundlePolicy defined.

Test: fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createOfferTask):
(WebCore::MediaEndpointPeerConnection::createAnswerTask):
* Modules/mediastream/SDPProcessor.cpp:
(WebCore::getBundlePolicyName):
(WebCore::configurationToJSON):
* Modules/mediastream/sdp.js:
(SDP.generate):
* platform/mediastream/MediaEndpointSessionConfiguration.h:
(WebCore::MediaEndpointSessionConfiguration::bundlePolicy):
(WebCore::MediaEndpointSessionConfiguration::setBundlePolicy):
(WebCore::MediaEndpointSessionConfiguration::clone):

LayoutTests:

The test fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html
is used to check that we generate the "a=bundle-only" lines on the "m=" sections
according to the bundlePolicy. The 3 possible values of bundlePolicy are tested.
To properly test bundlePolicy:"balanced" we generate 5 extra tracks (6 in total)
for each one of the audio media type and video media type.

* TestExpectations: Set RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html
as failing in the general TestExpectations, because the libwebrtc backend currently
doesn't generate the expected a=bundle-only lines.
On the GTK+ port TestExpectations file this is overriden, and the test is marked to pass.
The whole fast/mediastream directory is already overriden to pass.
* fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html: Added.
* fast/mediastream/resources/sdp-utils.js:
(printComparableSessionDescription): Validate the a=group:BUNDLE line to contain the required MID identifiers.
* platform/gtk/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt: Added. Rebaseline with the expected a=group:BUNDLE line.
* platform/gtk/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt: Added. Rebaseline with the expected a=group:BUNDLE line.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/mediastream/resources/sdp-utils.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/SDPProcessor.cpp
trunk/Source/WebCore/Modules/mediastream/sdp.js
trunk/Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h


Added Paths

trunk/LayoutTests/fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (214959 => 214960)

--- trunk/LayoutTests/ChangeLog	2017-04-05 19:09:28 UTC (rev 214959)
+++ trunk/LayoutTests/ChangeLog	2017-04-05 19:14:36 UTC (rev 214960)
@@ -1,3 +1,28 @@
+2017-04-05  Carlos Alberto Lopez Perez  
+
+[WebRTC][OpenWebRTC] Add support for SDP BUNDLE ("a:group:BUNDLE" and "a=bundle-only" lines)
+https://bugs.webkit.org/show_bug.cgi?id=170157
+
+Reviewed by Alejandro G. Castro.
+
+The test fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html
+is used to check that we generate the "a=bundle-only" lines on the "m=" sections
+according to the bundlePolicy. The 3 possible values of bundlePolicy are tested.
+To properly test bundlePolicy:"balanced" we generate 5 extra tracks (6 in total)
+for each one of the audio media type and video media type.
+
+* TestExpectations: Set RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html
+as failing in the general TestExpectations, because the libwebrtc backend currently
+doesn't generate the expected a=bundle-only lines.
+On the GTK+ port TestExpectations file this is overriden, and the test is marked to pass.
+The whole fast/mediastream directory is already overriden to pass.
+* fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only-expected.txt: Added.
+* 

[webkit-changes] [214859] trunk/Tools

[clopez]

Title: [214859] trunk/Tools








Revision 214859
Author clo...@igalia.com
Date 2017-04-03 17:57:32 -0700 (Mon, 03 Apr 2017)


Log Message
[GTK][JHBuild] Update mesa repository url for tarballs
https://bugs.webkit.org/show_bug.cgi?id=170431

Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (214858 => 214859)

--- trunk/Tools/ChangeLog	2017-04-04 00:42:54 UTC (rev 214858)
+++ trunk/Tools/ChangeLog	2017-04-04 00:57:32 UTC (rev 214859)
@@ -1,3 +1,12 @@
+2017-04-03  Carlos Alberto Lopez Perez  
+
+[GTK][JHBuild] Update mesa repository url for tarballs
+https://bugs.webkit.org/show_bug.cgi?id=170431
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules:
+
 2017-04-03  Joseph Pecoraro  
 
 TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf


Modified: trunk/Tools/gtk/jhbuild.modules (214858 => 214859)

--- trunk/Tools/gtk/jhbuild.modules	2017-04-04 00:42:54 UTC (rev 214858)
+++ trunk/Tools/gtk/jhbuild.modules	2017-04-04 00:57:32 UTC (rev 214859)
@@ -72,8 +72,8 @@
   href=""
 href=""
-  +href=""
   @@ -503,9 +503,10 @@
 autogenargs="--disable-dri3 --enable-dri --enable-glx --enable-egl --with-egl-platforms=x11,wayland --with-dri-drivers=swrast --with-gallium-drivers=swrast">
 
-+ hash="sha256:8340e64cdc91999840404c211496f3de38e7b4cb38db34e2f72f1642c5134760">
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214854] trunk/Tools

[clopez]

Title: [214854] trunk/Tools








Revision 214854
Author clo...@igalia.com
Date 2017-04-03 16:40:10 -0700 (Mon, 03 Apr 2017)


Log Message
[GTK][JHBuild] Fetch libvpx from a release tarball instead of git
https://bugs.webkit.org/show_bug.cgi?id=170426

Reviewed by Michael Catanzaro.

* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (214853 => 214854)

--- trunk/Tools/ChangeLog	2017-04-03 23:11:25 UTC (rev 214853)
+++ trunk/Tools/ChangeLog	2017-04-03 23:40:10 UTC (rev 214854)
@@ -1,3 +1,12 @@
+2017-04-03  Carlos Alberto Lopez Perez  
+
+[GTK][JHBuild] Fetch libvpx from a release tarball instead of git
+https://bugs.webkit.org/show_bug.cgi?id=170426
+
+Reviewed by Michael Catanzaro.
+
+* gtk/jhbuild.modules:
+
 2017-04-03  Nan Wang  
 
 AX: Expose link children when doing search predication on iOS


Modified: trunk/Tools/gtk/jhbuild.modules (214853 => 214854)

--- trunk/Tools/gtk/jhbuild.modules	2017-04-03 23:11:25 UTC (rev 214853)
+++ trunk/Tools/gtk/jhbuild.modules	2017-04-03 23:40:10 UTC (rev 214854)
@@ -80,6 +80,8 @@
   href=""
  href=""
+   
   
 
@@ -526,8 +528,10 @@
 
autogen-template="%(srcdir)s/configure --prefix=%(prefix)s --enable-pic --as=yasm --disable-unit-tests --size-limit=16384x16384 --enable-postproc --enable-multi-res-encoding --enable-temporal-denoising --enable-vp9-temporal-denoising --enable-vp9-postproc --enable-shared">
-
-
+
   
 







___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214605] trunk/Tools

[clopez]

Title: [214605] trunk/Tools








Revision 214605
Author clo...@igalia.com
Date 2017-03-30 08:14:56 -0700 (Thu, 30 Mar 2017)


Log Message
Change my status to be a WebKit reviewer.

Unreviewed status update edit.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (214604 => 214605)

--- trunk/Tools/ChangeLog	2017-03-30 14:40:46 UTC (rev 214604)
+++ trunk/Tools/ChangeLog	2017-03-30 15:14:56 UTC (rev 214605)
@@ -1,3 +1,11 @@
+2017-03-30  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+Change my status to be a WebKit reviewer.
+
+Unreviewed status update edit.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2017-03-29  Tim Horton  <timothy_hor...@apple.com>
 
 Swipe gesture tests don't work on macOS Sierra


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (214604 => 214605)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-30 14:40:46 UTC (rev 214604)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2017-03-30 15:14:56 UTC (rev 214605)
@@ -1054,7 +1054,7 @@
   "nicks" : [
  "clopez"
   ],
-  "status" : "committer"
+  "status" : "reviewer"
},
"Carlos Garcia Campos" : {
   "emails" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214535] trunk/LayoutTests

[clopez]

Title: [214535] trunk/LayoutTests








Revision 214535
Author clo...@igalia.com
Date 2017-03-29 08:33:15 -0700 (Wed, 29 Mar 2017)


Log Message
[GTK][OWR] Rebaseline fast/mediastream/RTCPeerConnection-addIceCandidate.html after r214527
https://bugs.webkit.org/show_bug.cgi?id=170192

Unreviewed test gardening.

* platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (214534 => 214535)

--- trunk/LayoutTests/ChangeLog	2017-03-29 15:18:38 UTC (rev 214534)
+++ trunk/LayoutTests/ChangeLog	2017-03-29 15:33:15 UTC (rev 214535)
@@ -1,3 +1,12 @@
+2017-03-29  Carlos Alberto Lopez Perez  
+
+[GTK][OWR] Rebaseline fast/mediastream/RTCPeerConnection-addIceCandidate.html after r214527
+https://bugs.webkit.org/show_bug.cgi?id=170192
+
+Unreviewed test gardening.
+
+* platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
+
 2017-03-29  Youenn Fablet  
 
 Add test for differentiating camera versus canvas stream


Modified: trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt (214534 => 214535)

--- trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt	2017-03-29 15:18:38 UTC (rev 214534)
+++ trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt	2017-03-29 15:33:15 UTC (rev 214535)
@@ -21,9 +21,14 @@
 PASS promise pc.addIceCandidate(new RTCIceCandidate({candidate: 'bad content', sdpMid: sdpMid})) rejected with OperationError (DOM Exception 34): Invalid candidate content
 *** Test bad candidate content with valid sdpMLineIndex
 PASS promise pc.addIceCandidate(new RTCIceCandidate({candidate: 'bad content', sdpMLineIndex: sdpMLineIndex})) rejected with OperationError (DOM Exception 34): Invalid candidate content
+*** Test valid candidate with no mid and mlineindex
+PASS promise pc.addIceCandidate({candidate: validCandidate}) rejected with TypeError: Argument 1 ('candidate') to RTCPeerConnection.addIceCandidate must be an instance of RTCIceCandidate
 
 *** Test some OK input
 PASS promise pc.addIceCandidate({candidate: validCandidate, sdpMid: sdpMid}) fulfilled with undefined
+PASS promise pc.addIceCandidate({candidate: validCandidate, sdpMLineIndex: sdpMLineIndex}) fulfilled with undefined
+PASS promise pc.addIceCandidate(undefined) fulfilled with undefined
+PASS promise pc.addIceCandidate(null) fulfilled with undefined
 PASS promise pc.addIceCandidate(new RTCIceCandidate({candidate: validCandidate, sdpMLineIndex: sdpMLineIndex})) fulfilled with undefined
 *** A valid sdpMid takes precedesce over a bad sdpMLineIndex
 PASS promise pc.addIceCandidate(new RTCIceCandidate({candidate: validCandidate, sdpMid: sdpMid, sdpMLineIndex: badSdpMLineIndex})) fulfilled with undefined






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214533] trunk/LayoutTests

[clopez]

Title: [214533] trunk/LayoutTests








Revision 214533
Author clo...@igalia.com
Date 2017-03-29 06:34:21 -0700 (Wed, 29 Mar 2017)


Log Message
[WebRTC] Update test RTCPeerConnection-overloaded-operations-params.html after r214441
https://bugs.webkit.org/show_bug.cgi?id=170223

Reviewed by Youenn Fablet.

After r214441 the arguments of addIceCandidate() are nullable.

* fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:
* fast/mediastream/RTCPeerConnection-overloaded-operations-params.html:
* platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Removed. The expected result was the same than the general one.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt
trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params.html


Removed Paths

trunk/LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (214532 => 214533)

--- trunk/LayoutTests/ChangeLog	2017-03-29 09:39:41 UTC (rev 214532)
+++ trunk/LayoutTests/ChangeLog	2017-03-29 13:34:21 UTC (rev 214533)
@@ -1,3 +1,16 @@
+2017-03-28  Carlos Alberto Lopez Perez  
+
+[WebRTC] Update test RTCPeerConnection-overloaded-operations-params.html after r214441
+https://bugs.webkit.org/show_bug.cgi?id=170223
+
+Reviewed by Youenn Fablet.
+
+After r214441 the arguments of addIceCandidate() are nullable.
+
+* fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:
+* fast/mediastream/RTCPeerConnection-overloaded-operations-params.html:
+* platform/gtk/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt: Removed. The expected result was the same than the general one.
+
 2017-03-29  Antoine Quint  
 
 [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout


Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt (214532 => 214533)

--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt	2017-03-29 09:39:41 UTC (rev 214532)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt	2017-03-29 13:34:21 UTC (rev 214533)
@@ -50,7 +50,7 @@
 PASS promise pc.setLocalDescription(desc) did not reject with TypeError.
 PASS promise pc.setLocalDescription(desc, emptyFunc, emptyFunc) did not reject with TypeError.
 *** desc is not optional
-PASS promise pc.setLocalDescription() rejected with TypeError: Not enough arguments
+FAIL promise pc.setLocalDescription() rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription; expected reason TypeError: Not enough arguments
 *** desc is not nullable
 PASS promise pc.setLocalDescription(null) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription
 PASS promise pc.setLocalDescription(null, emptyFunc, emptyFunc) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setLocalDescription must be an instance of RTCSessionDescription
@@ -65,7 +65,7 @@
 PASS promise pc.setRemoteDescription(desc) did not reject with TypeError.
 PASS promise pc.setRemoteDescription(desc, emptyFunc, emptyFunc) did not reject with TypeError.
 *** desc is not optional
-PASS promise pc.setRemoteDescription() rejected with TypeError: Not enough arguments
+FAIL promise pc.setRemoteDescription() rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription; expected reason TypeError: Not enough arguments
 *** desc is not nullable
 PASS promise pc.setRemoteDescription(null) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription
 PASS promise pc.setRemoteDescription(null, emptyFunc, emptyFunc) rejected with TypeError: Argument 1 ('description') to RTCPeerConnection.setRemoteDescription must be an instance of RTCSessionDescription
@@ -79,11 +79,10 @@
 *** Test addIceCandidate
 PASS promise pc.addIceCandidate(candidate) did not reject with TypeError.
 PASS promise pc.addIceCandidate(candidate, emptyFunc, emptyFunc) did not reject with TypeError.
+PASS promise pc.addIceCandidate(null) did not reject with TypeError.
+PASS promise pc.addIceCandidate(null, emptyFunc, emptyFunc) did not reject with TypeError.
 *** candidate is not optional
 PASS promise pc.addIceCandidate() rejected with TypeError: Not enough arguments
-*** candidate is not nullable
-PASS promise pc.addIceCandidate(null) rejected with TypeError: Argument 1 ('candidate') to 

[webkit-changes] [214318] trunk/Tools

[clopez]

Title: [214318] trunk/Tools








Revision 214318
Author clo...@igalia.com
Date 2017-03-23 14:45:08 -0700 (Thu, 23 Mar 2017)


Log Message
buildbot: Fix mixing of tabs and spaces after r214172
https://bugs.webkit.org/show_bug.cgi?id=169793

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.evaluateCommand):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (214317 => 214318)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-03-23 21:07:40 UTC (rev 214317)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-03-23 21:45:08 UTC (rev 214318)
@@ -412,10 +412,10 @@
 return FAILURE
 
 # Return code from Tools/Scripts/layout_tests/run_webkit_tests.py.
- 	# This means that an exception was raised when running run-webkit-tests and
- 	# was never handled.
- 	if cmd.rc == 254:
- 	return EXCEPTION
+# This means that an exception was raised when running run-webkit-tests and
+# was never handled.
+if cmd.rc == 254:
+return EXCEPTION
 if cmd.rc != 0:
 return FAILURE
 


Modified: trunk/Tools/ChangeLog (214317 => 214318)

--- trunk/Tools/ChangeLog	2017-03-23 21:07:40 UTC (rev 214317)
+++ trunk/Tools/ChangeLog	2017-03-23 21:45:08 UTC (rev 214318)
@@ -1,3 +1,13 @@
+2017-03-23  Carlos Alberto Lopez Perez  
+
+buildbot: Fix mixing of tabs and spaces after r214172
+https://bugs.webkit.org/show_bug.cgi?id=169793
+
+Unreviewed.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunWebKitTests.evaluateCommand):
+
 2017-03-22  Andy Estes  
 
 [Cocoa] Add an option to exclude overflow when snapshotting a WKWebProcessPlugInNodeHandle






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214306] trunk/LayoutTests

[clopez]

Title: [214306] trunk/LayoutTests








Revision 214306
Author clo...@igalia.com
Date 2017-03-23 11:22:10 -0700 (Thu, 23 Mar 2017)


Log Message
[GTK] Mark compositing and css3/blending tests asserting on debug builds.

Unreviewed test gardening.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214305 => 214306)

--- trunk/LayoutTests/ChangeLog	2017-03-23 18:15:58 UTC (rev 214305)
+++ trunk/LayoutTests/ChangeLog	2017-03-23 18:22:10 UTC (rev 214306)
@@ -1,3 +1,11 @@
+2017-03-23  Carlos Alberto Lopez Perez  
+
+[GTK] Mark compositing and css3/blending tests asserting on debug builds.
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+
 2017-03-23  Carlos Garcia Campos  
 
 Unreviewed GTK+ gardening. Mark webrtc/connection-state.html as failing.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214305 => 214306)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-23 18:15:58 UTC (rev 214305)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-23 18:22:10 UTC (rev 214306)
@@ -284,20 +284,20 @@
 webkit.org/b/99028 fast/autoresize [ Failure ]
 
 # We need to set ENABLE_CSS_COMPOSITING=ON
-webkit.org/b/169916 css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts.html [ Failure ]
-webkit.org/b/169916 css3/blending/blend-mode-ancestor-clipping-layer.html [ Failure ]
-webkit.org/b/169916 css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-ancestor-clipping-layer.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-canvas.html [ Failure ]
-webkit.org/b/169916 css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-isolation-accelerated-overflow-hidden.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer1.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-off-self-painting-layer2.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-isolation-turn-on-self-painting-layer.html [ Failure ]
-webkit.org/b/169916 css3/blending/blend-mode-parent-of-composited-blended-has-layer.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-parent-of-composited-blended-has-layer.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-property-parsing.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-property.html [ Failure ]
 webkit.org/b/169916 css3/blending/blend-mode-transform-style.html [ Failure ]
-webkit.org/b/169916 css3/blending/blend-mode-with-composited-descendant-should-have-layer.html [ Failure ]
+webkit.org/b/169916 [ Release ] css3/blending/blend-mode-with-composited-descendant-should-have-layer.html [ Failure ]
 webkit.org/b/169916 css3/blending/isolation-parsing.html [ Failure ]
 webkit.org/b/169916 css3/blending/repaint/blend-mode-isolate-stacking-context.html [ Failure ]
 webkit.org/b/169916 css3/blending/repaint/blend-mode-turn-off-isolation.html [ Failure ]
@@ -349,37 +349,38 @@
 
 # Failures related with compositing tests.
 webkit.org/b/169918 compositing/animation/animation-backing.html [ Failure Pass ]
-webkit.org/b/169918 compositing/backing/no-backing-for-perspective.html [ Failure ]
-webkit.org/b/169918 compositing/backing/whitespace-nodes-no-backing.html [ Failure ]
-webkit.org/b/169918 compositing/canvas/accelerated-canvas-compositing-size-limit.html [ Failure ]
-webkit.org/b/169918 compositing/clipping/border-radius-overflow-hidden-stacking-context.html [ Failure ]
+webkit.org/b/169918 [ Release ] compositing/backing/no-backing-for-perspective.html [ Failure ]
+webkit.org/b/169918 [ Release ] compositing/backing/whitespace-nodes-no-backing.html [ Failure ]
+webkit.org/b/169918 [ Release ] compositing/canvas/accelerated-canvas-compositing-size-limit.html [ Failure ]
+webkit.org/b/169918 [ Release ] compositing/clipping/border-radius-overflow-hidden-stacking-context.html [ Failure ]
 webkit.org/b/169918 compositing/columns/composited-lr-paginated-repaint.html [ Failure ]
 webkit.org/b/169918 compositing/columns/composited-rl-paginated-repaint.html [ Failure ]
-webkit.org/b/169918 compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html [ Failure ]
-webkit.org/b/169918 

[webkit-changes] [214292] trunk/LayoutTests

[clopez]

Title: [214292] trunk/LayoutTests








Revision 214292
Author clo...@igalia.com
Date 2017-03-22 19:37:08 -0700 (Wed, 22 Mar 2017)


Log Message
[GTK] Enable CSS filters related tests.
https://bugs.webkit.org/show_bug.cgi?id=99026

Unreviewed test gardening.

* platform/gtk/TestExpectations:
* platform/gtk/css3/filters/composited-during-transition-layertree-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-blur-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-blur-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-blur-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-blur-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-combined-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-combined-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-combined-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-combined-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-contrast-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-contrast-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-contrast-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-contrast-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-grayscale-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-grayscale-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-grayscale-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-grayscale-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-hue-rotate-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-hue-rotate-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-hue-rotate-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-hue-rotate-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-invert-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-invert-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-invert-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-invert-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-opacity-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-opacity-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-opacity-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-opacity-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-composite-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-composite-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-composite-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-composite-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-ordering-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-ordering-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-ordering-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-reference-ordering-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-saturate-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-saturate-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-saturate-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-saturate-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-sepia-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-sepia-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/effect-sepia-hw-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/effect-sepia-hw-expected.txt: Added. Rebaselined.
* platform/gtk/css3/filters/regions-expanding-expected.png: Added. Rebaselined.
* platform/gtk/css3/filters/regions-expanding-expected.txt: Added. Rebaselined.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/css3/filters/
trunk/LayoutTests/platform/gtk/css3/filters/composited-during-transition-layertree-expected.txt
trunk/LayoutTests/platform/gtk/css3/filters/effect-blur-expected.png
trunk/LayoutTests/platform/gtk/css3/filters/effect-blur-expected.txt
trunk/LayoutTests/platform/gtk/css3/filters/effect-blur-hw-expected.png
trunk/LayoutTests/platform/gtk/css3/filters/effect-blur-hw-expected.txt

[webkit-changes] [214286] trunk/LayoutTests

[clopez]

Title: [214286] trunk/LayoutTests








Revision 214286
Author clo...@igalia.com
Date 2017-03-22 17:16:37 -0700 (Wed, 22 Mar 2017)


Log Message
[GTK] Update layout test expectations file.

Unreviewed test gardening.

* platform/gtk/TestExpectations: Update the list of expected failures.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214285 => 214286)

--- trunk/LayoutTests/ChangeLog	2017-03-22 23:43:32 UTC (rev 214285)
+++ trunk/LayoutTests/ChangeLog	2017-03-23 00:16:37 UTC (rev 214286)
@@ -1,3 +1,11 @@
+2017-03-22  Carlos Alberto Lopez Perez  
+
+[GTK] Update layout test expectations file.
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations: Update the list of expected failures.
+
 2017-03-22  Antoine Quint  
 
 [Modern Media Controls] Controls size lags behind media size


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214285 => 214286)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-22 23:43:32 UTC (rev 214285)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-23 00:16:37 UTC (rev 214286)
@@ -556,6 +556,7 @@
 webkit.org/b/169917 webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html [ Timeout ]
 webkit.org/b/169917 webgl/1.0.2/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Timeout ]
 webkit.org/b/169917 webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html [ Timeout ]
 webkit.org/b/169917 webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba.html [ Timeout ]
@@ -648,13 +649,9 @@
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/mock-media-source.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout ]
-webkit.org/b/79203 fast/mediastream/MediaStreamTrack-onended.html [ Failure ]
-webkit.org/b/79203 fast/mediastream/MediaStreamTrack.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-dtmf.html [ Timeout ]
-webkit.org/b/79203 fast/mediastream/RTCPeerConnection-events.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-ice.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Failure ]
-webkit.org/b/79203 fast/mediastream/RTCPeerConnection-statsSelector.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Failure ]
@@ -664,7 +661,6 @@
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-closed-state.html [ Crash ]
 webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Failure ]
 webkit.org/b/151344 fast/mediastream/MediaStream-add-ended-tracks.html [ Timeout ]
-webkit.org/b/151344 fast/mediastream/MediaStream-add-remove-tracks.html [ Failure ]
 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html [ Timeout ]
 webkit.org/b/160996 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ ImageOnlyFailure ]
 webkit.org/b/161956 fast/mediastream/MediaStream-video-element-displays-buffer.html [ Failure ]
@@ -1594,6 +1590,7 @@
 #Media controls
 webkit.org/b/132271 media/controls-styling-strict.html [ Failure Timeout Pass ]
 webkit.org/b/132271 media/controls-strict.html [ ImageOnlyFailure Timeout Pass ]
+webkit.org/b/132271 media/media-controls-timeline-updates.html [ Timeout Pass ]
 webkit.org/b/132271 media/media-controller-playbackrate.html [ Timeout Pass Crash ]
 webkit.org/b/132271 media/media-controller-time-clamp.html [ Timeout Pass ]
 webkit.org/b/132271 media/track/add-and-remove-track.html [ Timeout Pass ]
@@ -2982,6 +2979,8 @@
 webkit.org/b/149128 fast/text/control-characters [ ImageOnlyFailure ]
 
 # web-platform-tests XHR tests
+imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm [ Failure ]
+imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm [ Failure ]
 imported/w3c/web-platform-tests/XMLHttpRequest/headers-normalize-response.htm [ Failure ]
 imported/w3c/web-platform-tests/XMLHttpRequest/send-accept-language.htm [ Failure ]
 imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async.htm [ Failure ]
@@ -3225,7 +3224,7 @@
 webkit.org/b/168373 fullscreen/video-controls-rtl.html [ Failure ]
 webkit.org/b/168373 

[webkit-changes] [214250] trunk/Tools

[clopez]

Title: [214250] trunk/Tools








Revision 214250
Author clo...@igalia.com
Date 2017-03-22 07:36:32 -0700 (Wed, 22 Mar 2017)


Log Message
[Linux] determineArchitecture is not cross-compile aware
https://bugs.webkit.org/show_bug.cgi?id=169886

Reviewed by Michael Catanzaro.

Try to detect the target architecture name from the GCC triplet
when cross-building.

The aarch64 architecture is renamed to arm64 (this is coherent with
the rest of the perl tooling that consults the architecture determined
in determineArchitecture(), the check for this arch is always done
with the arm64 name).

* Scripts/webkitdirs.pm: Remove the isARM() function: its dead code
and not cross-build aware.
(determineArchitecture): When crossbuilding, try to detect the target
architecture name from the GCC triplet.
Remove also the fallback option to run the arch command, because this
command doesn't print the expected on Mac/BSD, and on Linux is the
same than uname -m. See https://bugs.webkit.org/show_bug.cgi?id=152958#c6
(isCrossCompilation): Some cross-compilers (buildroot one for example)
don't define the --host option. Add another option to detect that
we are cross-building by building a dummy program and checking if
we can run it.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (214249 => 214250)

--- trunk/Tools/ChangeLog	2017-03-22 11:59:33 UTC (rev 214249)
+++ trunk/Tools/ChangeLog	2017-03-22 14:36:32 UTC (rev 214250)
@@ -1,3 +1,30 @@
+2017-03-22  Carlos Alberto Lopez Perez  
+
+[Linux] determineArchitecture is not cross-compile aware
+https://bugs.webkit.org/show_bug.cgi?id=169886
+
+Reviewed by Michael Catanzaro.
+
+Try to detect the target architecture name from the GCC triplet
+when cross-building.
+
+The aarch64 architecture is renamed to arm64 (this is coherent with
+the rest of the perl tooling that consults the architecture determined
+in determineArchitecture(), the check for this arch is always done
+with the arm64 name).
+
+* Scripts/webkitdirs.pm: Remove the isARM() function: its dead code
+and not cross-build aware.
+(determineArchitecture): When crossbuilding, try to detect the target
+architecture name from the GCC triplet.
+Remove also the fallback option to run the arch command, because this
+command doesn't print the expected on Mac/BSD, and on Linux is the
+same than uname -m. See https://bugs.webkit.org/show_bug.cgi?id=152958#c6
+(isCrossCompilation): Some cross-compilers (buildroot one for example)
+don't define the --host option. Add another option to detect that
+we are cross-building by building a dummy program and checking if
+we can run it.
+
 2017-03-22  Carlos Garcia Campos  
 
 [GTK] Several WPT tests are failing since they were added in the last update in r213882


Modified: trunk/Tools/Scripts/webkitdirs.pm (214249 => 214250)

--- trunk/Tools/Scripts/webkitdirs.pm	2017-03-22 11:59:33 UTC (rev 214249)
+++ trunk/Tools/Scripts/webkitdirs.pm	2017-03-22 14:36:32 UTC (rev 214250)
@@ -40,6 +40,7 @@
 use File::Find;
 use File::Path qw(make_path mkpath rmtree);
 use File::Spec;
+use File::Temp qw(tempdir);
 use File::stat;
 use List::Util;
 use POSIX;
@@ -343,12 +344,16 @@
 }
 }
 } elsif (isCMakeBuild()) {
-if (open my $cmake_sysinfo, "cmake --system-information |") {
+if (isCrossCompilation()) {
+my $compiler = "gcc";
+$compiler = $ENV{'CC'} if (defined($ENV{'CC'}));
+my @compiler_machine = split('-', `$compiler -dumpmachine`);
+$architecture = $compiler_machine[0];
+} elsif (open my $cmake_sysinfo, "cmake --system-information |") {
 while (<$cmake_sysinfo>) {
 next unless index($_, 'CMAKE_SYSTEM_PROCESSOR') == 0;
 if (/^CMAKE_SYSTEM_PROCESSOR \"([^"]+)\"/) {
 $architecture = $1;
-$architecture = 'x86_64' if $architecture eq 'amd64';
 last;
 }
 }
@@ -358,12 +363,6 @@
 
 if (!isAnyWindows()) {
 if (!$architecture) {
-# Fall back to output of `arch', if it is present.
-$architecture = `arch`;
-chomp $architecture;
-}
-
-if (!$architecture) {
 # Fall back to output of `uname -m', if it is present.
 $architecture = `uname -m`;
 chomp $architecture;
@@ -370,7 +369,8 @@
 }
 }
 
-$architecture = 'x86_64' if ($architecture =~ /amd64/ && isBSD());
+$architecture = 'x86_64' if $architecture =~ /amd64/i;
+$architecture = 'arm64' if $architecture =~ /aarch64/i;
 }
 
 sub determineASanIsEnabled
@@ -1185,11 +1185,6 @@
 return ($^O eq "freebsd") || ($^O eq "openbsd") || ($^O eq "netbsd") || 0;
 }
 

[webkit-changes] [214229] trunk/LayoutTests

[clopez]

Title: [214229] trunk/LayoutTests








Revision 214229
Author clo...@igalia.com
Date 2017-03-21 13:52:51 -0700 (Tue, 21 Mar 2017)


Log Message
[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardening.

* platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
* platform/gtk/TestExpectations: This two tests seem flaky.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wayland/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214228 => 214229)

--- trunk/LayoutTests/ChangeLog	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 20:52:51 UTC (rev 214229)
@@ -1,5 +1,15 @@
 2017-03-21  Carlos Alberto Lopez Perez  
 
+[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
+https://bugs.webkit.org/show_bug.cgi?id=71849
+
+Unreviewed test gardening.
+
+* platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
+* platform/gtk/TestExpectations: This two tests seem flaky.
+
+2017-03-21  Carlos Alberto Lopez Perez  
+
 [GTK] Enable WebGL, 3D and compositing layout tests
 https://bugs.webkit.org/show_bug.cgi?id=71849
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214228 => 214229)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 20:52:51 UTC (rev 214229)
@@ -308,8 +308,8 @@
 webkit.org/b/169916 css3/blending/blend-mode-body-child-background-color.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-child-isolate-html-background-color.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-child.html [ ImageOnlyFailure ]
-webkit.org/b/169916 css3/blending/blend-mode-body-composited-child-background-color.html [ ImageOnlyFailure ]
-webkit.org/b/169916 css3/blending/blend-mode-body-composited-child.html [ ImageOnlyFailure ]
+webkit.org/b/169916 css3/blending/blend-mode-body-composited-child-background-color.html [ Pass ImageOnlyFailure ]
+webkit.org/b/169916 css3/blending/blend-mode-body-composited-child.html [ Pass ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-element.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-child.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-double.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/gtk-wayland/TestExpectations (214228 => 214229)

--- trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2017-03-21 20:52:51 UTC (rev 214229)
@@ -30,6 +30,77 @@
 webkit.org/b/156717 transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]
 webkit.org/b/156717 transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Failure ]
 
+# Diff of failures (and passes) related with WebGL and Compositing tests (compared to --display-server=xvfb)
+# When passing --display-server=wayland on an system running native Weston on an Intel GPU (like the GTK Wayland bot)
+webkit.org/b/169917 fast/canvas/webgl/drawingbuffer-test.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-npot-video.html [ Crash Pass ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Timeout Pass ]
+webkit.org/b/169917 webgl/1.0.3/conformance/glsl/bugs/temp-expressions-should-not-crash.html [ Timeout ]
+webkit.org/b/169917 webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/negative-one-index.html [ Timeout Pass ]
+webkit.org/b/169917 webgl/webgl-padding.html [ ImageOnlyFailure ]
+webkit.org/b/169917 webgl/webgl-backing-store-size-update.html [ ImageOnlyFailure ]
+webkit.org/b/169917 fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-mips.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-npot.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-size-limit.html [ Pass ]
+webkit.org/b/169918 compositing/scrolling/fixed-inside-scroll.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-padding.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html [ ImageOnlyFailure ]
+webkit.org/b/169918 

[webkit-changes] [214037] trunk

[clopez]

Title: [214037] trunk








Revision 214037
Author clo...@igalia.com
Date 2017-03-16 04:59:24 -0700 (Thu, 16 Mar 2017)


Log Message
[WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX.
https://bugs.webkit.org/show_bug.cgi?id=169681

Reviewed by Alejandro G. Castro.

Source/WebCore:

Use an int64_t type for storing sess-id and ensure that the value generated is always between 0 and LLONG_MAX (2^63-1).
To the JS world (sdp.js) we pass and read this value as a string type.

The JS world (sdp.js) was already using a string type for sess-id.
This caused a bug when reading the sess-id value at configurationFromJSON(): no value was obtained because a numeric type was expected.

So, after this patch, sess-id is passed and read as a string from sdp.js, and converted to an int64_t type for internal use.
This way we also avoid a rounding problem that happens with values near LLONG_MAX when converting from int64_t to double when passed to the JS world,
and that could cause that we end passing a number bigger than LLONG_MAX to sdp.js.

* Modules/mediastream/SDPProcessor.cpp:
(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):
* platform/mediastream/MediaEndpointSessionConfiguration.h:
(WebCore::MediaEndpointSessionConfiguration::sessionId):
(WebCore::MediaEndpointSessionConfiguration::setSessionId):
(WebCore::MediaEndpointSessionConfiguration::MediaEndpointSessionConfiguration):

LayoutTests:

Check that the generated sess-id value its between the limits before validating it.
This is covered by the tests fast/mediastream/RTCPeerConnection-inspect-answer.html
and fast/mediastream/RTCPeerConnection-inspect-offer.html.
Both tests will fail if the sess-id value generated is not within the limits.

* fast/mediastream/resources/sdp-utils.js:
(printComparableSessionDescription):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/resources/sdp-utils.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/SDPProcessor.cpp
trunk/Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h




Diff

Modified: trunk/LayoutTests/ChangeLog (214036 => 214037)

--- trunk/LayoutTests/ChangeLog	2017-03-16 11:55:13 UTC (rev 214036)
+++ trunk/LayoutTests/ChangeLog	2017-03-16 11:59:24 UTC (rev 214037)
@@ -1,3 +1,18 @@
+2017-03-16  Carlos Alberto Lopez Perez  
+
+[WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX.
+https://bugs.webkit.org/show_bug.cgi?id=169681
+
+Reviewed by Alejandro G. Castro.
+
+Check that the generated sess-id value its between the limits before validating it.
+This is covered by the tests fast/mediastream/RTCPeerConnection-inspect-answer.html
+and fast/mediastream/RTCPeerConnection-inspect-offer.html.
+Both tests will fail if the sess-id value generated is not within the limits.
+
+* fast/mediastream/resources/sdp-utils.js:
+(printComparableSessionDescription):
+
 2017-03-15  Zalan Bujtas  
 
 Do not reparent floating object until after intruding/overhanging dependency is cleared.


Modified: trunk/LayoutTests/fast/mediastream/resources/sdp-utils.js (214036 => 214037)

--- trunk/LayoutTests/fast/mediastream/resources/sdp-utils.js	2017-03-16 11:55:13 UTC (rev 214036)
+++ trunk/LayoutTests/fast/mediastream/resources/sdp-utils.js	2017-03-16 11:59:24 UTC (rev 214037)
@@ -27,9 +27,12 @@
 // Session block
 var oline;
 
-if (oline = match(line, regexp.oline))
-line = line.replace(oline[2], verified("session-id"));
-else if (match(line, regexp.msidsemantic)) {
+if (oline = match(line, regexp.oline)) {
+var sessid = parseInt(oline[2]);
+// The session-id should be a number between 0 and LLONG_MAX (2^63-1).
+if (sessid >= 0 && sessid <= 9223372036854775807)
+line = line.replace(oline[2], verified("session-id"));
+} else if (match(line, regexp.msidsemantic)) {
 mdescVariables.forEach(function (variables) {
 line = line.replace(variables.streamId, verified("media-stream-id"));
 });


Modified: trunk/Source/WebCore/ChangeLog (214036 => 214037)

--- trunk/Source/WebCore/ChangeLog	2017-03-16 11:55:13 UTC (rev 214036)
+++ trunk/Source/WebCore/ChangeLog	2017-03-16 11:59:24 UTC (rev 214037)
@@ -1,3 +1,28 @@
+2017-03-16  Carlos Alberto Lopez Perez  
+
+[WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX.
+https://bugs.webkit.org/show_bug.cgi?id=169681
+
+Reviewed by Alejandro G. Castro.
+
+Use an int64_t type for storing sess-id and ensure that the value generated is always between 0 and LLONG_MAX (2^63-1).
+To the JS world (sdp.js) we pass and 

[webkit-changes] [214025] trunk/Source/WTF

[clopez]

Title: [214025] trunk/Source/WTF








Revision 214025
Author clo...@igalia.com
Date 2017-03-15 20:15:03 -0700 (Wed, 15 Mar 2017)


Log Message
[CMake][JSCOnly] Fix build with GLib event loop
https://bugs.webkit.org/show_bug.cgi?id=169730

Reviewed by Michael Catanzaro.

* wtf/MainThread.cpp:
* wtf/PlatformJSCOnly.cmake: WorkQueueGLib was removed in r199713.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MainThread.cpp
trunk/Source/WTF/wtf/PlatformJSCOnly.cmake




Diff

Modified: trunk/Source/WTF/ChangeLog (214024 => 214025)

--- trunk/Source/WTF/ChangeLog	2017-03-16 02:48:28 UTC (rev 214024)
+++ trunk/Source/WTF/ChangeLog	2017-03-16 03:15:03 UTC (rev 214025)
@@ -1,3 +1,13 @@
+2017-03-15  Carlos Alberto Lopez Perez  
+
+[CMake][JSCOnly] Fix build with GLib event loop
+https://bugs.webkit.org/show_bug.cgi?id=169730
+
+Reviewed by Michael Catanzaro.
+
+* wtf/MainThread.cpp:
+* wtf/PlatformJSCOnly.cmake: WorkQueueGLib was removed in r199713.
+
 2017-03-15  Dean Jackson  
 
 Sort Xcode project files


Modified: trunk/Source/WTF/wtf/MainThread.cpp (214024 => 214025)

--- trunk/Source/WTF/wtf/MainThread.cpp	2017-03-16 02:48:28 UTC (rev 214024)
+++ trunk/Source/WTF/wtf/MainThread.cpp	2017-03-16 03:15:03 UTC (rev 214025)
@@ -178,7 +178,7 @@
 scheduleDispatchFunctionsOnMainThread();
 }
 
-#if !OS(DARWIN) && !PLATFORM(GTK)
+#if !OS(DARWIN) && !USE(GLIB_EVENT_LOOP)
 bool isMainThread()
 {
 return currentThread() == mainThreadIdentifier;


Modified: trunk/Source/WTF/wtf/PlatformJSCOnly.cmake (214024 => 214025)

--- trunk/Source/WTF/wtf/PlatformJSCOnly.cmake	2017-03-16 02:48:28 UTC (rev 214024)
+++ trunk/Source/WTF/wtf/PlatformJSCOnly.cmake	2017-03-16 03:15:03 UTC (rev 214025)
@@ -1,6 +1,8 @@
 list(APPEND WTF_SOURCES
 PlatformUserPreferredLanguagesUnix.cpp
 
+generic/WorkQueueGeneric.cpp
+
 text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp
 )
 
@@ -9,7 +11,6 @@
 glib/GRefPtr.cpp
 glib/MainThreadGLib.cpp
 glib/RunLoopGLib.cpp
-glib/WorkQueueGLib.cpp
 )
 list(APPEND WTF_SYSTEM_INCLUDE_DIRECTORIES
 ${GLIB_INCLUDE_DIRS}
@@ -23,7 +24,6 @@
 list(APPEND WTF_SOURCES
 generic/MainThreadGeneric.cpp
 generic/RunLoopGeneric.cpp
-generic/WorkQueueGeneric.cpp
 )
 endif ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213879] trunk/Source/WebCore

[clopez]

Title: [213879] trunk/Source/WebCore








Revision 213879
Author clo...@igalia.com
Date 2017-03-13 17:18:16 -0700 (Mon, 13 Mar 2017)


Log Message
[GTK][SOUP] Fix build after r213877
https://bugs.webkit.org/show_bug.cgi?id=140191

Unreviewed build fix.

* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::setCookie): Add missing setCookie() declaration.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (213878 => 213879)

--- trunk/Source/WebCore/ChangeLog	2017-03-13 23:05:49 UTC (rev 213878)
+++ trunk/Source/WebCore/ChangeLog	2017-03-14 00:18:16 UTC (rev 213879)
@@ -1,3 +1,13 @@
+2017-03-13  Carlos Alberto Lopez Perez  
+
+[GTK][SOUP] Fix build after r213877
+https://bugs.webkit.org/show_bug.cgi?id=140191
+
+Unreviewed build fix.
+
+* platform/network/soup/NetworkStorageSessionSoup.cpp:
+(WebCore::NetworkStorageSession::setCookie): Add missing setCookie() declaration.
+
 2017-03-13  Brady Eidson  
 
 WKWebView provides no access to cookies.


Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (213878 => 213879)

--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp	2017-03-13 23:05:49 UTC (rev 213878)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp	2017-03-14 00:18:16 UTC (rev 213879)
@@ -304,6 +304,11 @@
 soup_cookie_jar_add_cookie(cookieStorage(), toSoupCookie(cookie));
 }
 
+void NetworkStorageSession::setCookie(const Cookie&)
+{
+// FIXME: Implement for WK2 to use.
+}
+
 void NetworkStorageSession::deleteCookie(const Cookie&)
 {
 // FIXME: Implement for WK2 to use.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213868] trunk/Tools

[clopez]

Title: [213868] trunk/Tools








Revision 213868
Author clo...@igalia.com
Date 2017-03-13 14:26:11 -0700 (Mon, 13 Mar 2017)


Log Message
[GTK] install-dependencies needs to install Perl CGI modules on Debian based distros
https://bugs.webkit.org/show_bug.cgi?id=169563

Reviewed by Michael Catanzaro.

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (213867 => 213868)

--- trunk/Tools/ChangeLog	2017-03-13 21:14:43 UTC (rev 213867)
+++ trunk/Tools/ChangeLog	2017-03-13 21:26:11 UTC (rev 213868)
@@ -1,3 +1,12 @@
+2017-03-13  Carlos Alberto Lopez Perez  
+
+[GTK] install-dependencies needs to install Perl CGI modules on Debian based distros
+https://bugs.webkit.org/show_bug.cgi?id=169563
+
+Reviewed by Michael Catanzaro.
+
+* gtk/install-dependencies:
+
 2017-03-13  Devin Rousso  
 
 Unreviewed, fix accidental comma.


Modified: trunk/Tools/gtk/install-dependencies (213867 => 213868)

--- trunk/Tools/gtk/install-dependencies	2017-03-13 21:14:43 UTC (rev 213867)
+++ trunk/Tools/gtk/install-dependencies	2017-03-13 21:26:11 UTC (rev 213868)
@@ -150,6 +150,7 @@
 gdb \
 libapache2-mod-bw \
 $(aptIfElse libapache2-mod-php7.0 libapache2-mod-php5) \
+libcgi-pm-perl \
 libgpg-error-dev \
 psmisc \
 pulseaudio-utils \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213845] trunk/Tools

[clopez]

Title: [213845] trunk/Tools








Revision 213845
Author clo...@igalia.com
Date 2017-03-13 08:46:00 -0700 (Mon, 13 Mar 2017)


Log Message
[GTK] Remove dead code from previous autotools build in build-jsc
https://bugs.webkit.org/show_bug.cgi?id=169555

Reviewed by Carlos Garcia Campos.

* Scripts/build-jsc:
(buildMyProject):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc




Diff

Modified: trunk/Tools/ChangeLog (213844 => 213845)

--- trunk/Tools/ChangeLog	2017-03-13 14:42:38 UTC (rev 213844)
+++ trunk/Tools/ChangeLog	2017-03-13 15:46:00 UTC (rev 213845)
@@ -1,3 +1,13 @@
+2017-03-13  Carlos Alberto Lopez Perez  
+
+[GTK] Remove dead code from previous autotools build in build-jsc
+https://bugs.webkit.org/show_bug.cgi?id=169555
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/build-jsc:
+(buildMyProject):
+
 2017-03-13  Carlos Garcia Campos  
 
 MiniBrowser: a tab closed from _javascript_ always closes the window


Modified: trunk/Tools/Scripts/build-jsc (213844 => 213845)

--- trunk/Tools/Scripts/build-jsc	2017-03-13 14:42:38 UTC (rev 213844)
+++ trunk/Tools/Scripts/build-jsc	2017-03-13 15:46:00 UTC (rev 213845)
@@ -186,9 +186,6 @@
 if ($projectName ne "WTF") {
 $result = buildVisualStudioProject("$projectName.vcxproj/$projectName.sln");
 }
-} elsif (isGtk()) {
-checkForArgumentAndRemoveFromARGV("--gtk");
-$result = buildGtkProject($projectName, 0);
 } else {
 die "Building not defined for this platform!\n";
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213526] trunk/LayoutTests

[clopez]

Title: [213526] trunk/LayoutTests








Revision 213526
Author clo...@igalia.com
Date 2017-03-07 11:16:09 -0800 (Tue, 07 Mar 2017)


Log Message
Move webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
https://bugs.webkit.org/show_bug.cgi?id=169216

Unreviewed test gardening.

Move the test webrtc/descriptionGetters.html under the directory webrtc/libwebrtc
because its still not testing the spec, but the current libwebrtc based implementation.

This way the test is skipped on the GTK+ port (The whole directory webrtc/libwebrtc is skipped).

* webrtc/libwebrtc/descriptionGetters-expected.txt: Renamed from LayoutTests/webrtc/descriptionGetters-expected.txt.
* webrtc/libwebrtc/descriptionGetters.html: Renamed from LayoutTests/webrtc/descriptionGetters.html.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters-expected.txt
trunk/LayoutTests/webrtc/libwebrtc/descriptionGetters.html


Removed Paths

trunk/LayoutTests/webrtc/descriptionGetters-expected.txt
trunk/LayoutTests/webrtc/descriptionGetters.html




Diff

Modified: trunk/LayoutTests/ChangeLog (213525 => 213526)

--- trunk/LayoutTests/ChangeLog	2017-03-07 18:54:56 UTC (rev 213525)
+++ trunk/LayoutTests/ChangeLog	2017-03-07 19:16:09 UTC (rev 213526)
@@ -1,3 +1,18 @@
+2017-03-07  Carlos Alberto Lopez Perez  
+
+Move webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
+https://bugs.webkit.org/show_bug.cgi?id=169216
+
+Unreviewed test gardening.
+
+Move the test webrtc/descriptionGetters.html under the directory webrtc/libwebrtc
+because its still not testing the spec, but the current libwebrtc based implementation.
+
+This way the test is skipped on the GTK+ port (The whole directory webrtc/libwebrtc is skipped).
+
+* webrtc/libwebrtc/descriptionGetters-expected.txt: Renamed from LayoutTests/webrtc/descriptionGetters-expected.txt.
+* webrtc/libwebrtc/descriptionGetters.html: Renamed from LayoutTests/webrtc/descriptionGetters.html.
+
 2017-03-07  Youenn Fablet  
 
 Expose WebRTC current/pending description getters


Deleted: trunk/LayoutTests/webrtc/descriptionGetters-expected.txt (213525 => 213526)

--- trunk/LayoutTests/webrtc/descriptionGetters-expected.txt	2017-03-07 18:54:56 UTC (rev 213525)
+++ trunk/LayoutTests/webrtc/descriptionGetters-expected.txt	2017-03-07 19:16:09 UTC (rev 213526)
@@ -1,3 +0,0 @@
-
-PASS description getters when changing description from video to video & data channel 
-


Deleted: trunk/LayoutTests/webrtc/descriptionGetters.html (213525 => 213526)

--- trunk/LayoutTests/webrtc/descriptionGetters.html	2017-03-07 18:54:56 UTC (rev 213525)
+++ trunk/LayoutTests/webrtc/descriptionGetters.html	2017-03-07 19:16:09 UTC (rev 213526)
@@ -1,84 +0,0 @@
-
-
-
-
-Testing basic video exchange from offerer to receiver
-
-
-