[webkit-changes] [151276] trunk/LayoutTests
Title: [151276] trunk/LayoutTests
Revision 151276
Author eus...@chromium.org
Date 2013-06-06 09:29:23 -0700 (Thu, 06 Jun 2013)
Log Message
selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=117287
Reviewed by Darin Adler.
Qt-WK2 test crashes when eventSender.keyDown invocations are nested.
This patch unrolls recursion to avoid crash.
* editing/selection/caret-after-keypress.html:
unroll recursive eventSender.keyDown invocations
* platform/qt-5.0-wk2/TestExpectations: Unskip test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/caret-after-keypress.html
trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (151275 => 151276)
--- trunk/LayoutTests/ChangeLog 2013-06-06 16:27:16 UTC (rev 151275)
+++ trunk/LayoutTests/ChangeLog 2013-06-06 16:29:23 UTC (rev 151276)
@@ -1,3 +1,18 @@
+2013-06-06 Eugene Klyuchnikov
+
+selectionStart/selectionEnd return "obsolete" values when requested during "input" event
+https://bugs.webkit.org/show_bug.cgi?id=117287
+
+Reviewed by Darin Adler.
+
+Qt-WK2 test crashes when eventSender.keyDown invocations are nested.
+
+This patch unrolls recursion to avoid crash.
+
+* editing/selection/caret-after-keypress.html:
+unroll recursive eventSender.keyDown invocations
+* platform/qt-5.0-wk2/TestExpectations: Unskip test.
+
2013-06-06 Chris Fleizach
AX: iOS ignores ARIA progressbar elements
Modified: trunk/LayoutTests/editing/selection/caret-after-keypress.html (151275 => 151276)
--- trunk/LayoutTests/editing/selection/caret-after-keypress.html 2013-06-06 16:27:16 UTC (rev 151275)
+++ trunk/LayoutTests/editing/selection/caret-after-keypress.html 2013-06-06 16:29:23 UTC (rev 151276)
@@ -13,17 +13,18 @@
var input = ["a", "b", "c", backSpace, backSpace, backSpace];
var output = ["", "a", "ab", "abc", "ab", "a", ""];
-function step() {
+function dumpState() {
var expectedValue = output.shift();
shouldBeEqualToString("test.value", expectedValue);
shouldBe("test.selectionStart", "" + expectedValue.length);
shouldBe("test.selectionEnd", "" + expectedValue.length);
debug("");
-eventSender.keyDown(input.shift());
}
-test.addEventListener("input", step);
-step();
+test.addEventListener("input", dumpState);
+dumpState();
+while (input.length)
+eventSender.keyDown(input.shift());
[webkit-changes] [151015] trunk/LayoutTests
Title: [151015] trunk/LayoutTests Revision 151015 Author eus...@chromium.org Date 2013-05-31 08:21:40 -0700 (Fri, 31 May 2013) Log Message [Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing https://bugs.webkit.org/show_bug.cgi?id=117070 Unreviewed test expectations update. WebKitTestRunner needs a more-complete implementation of eventSender. Until then caret-after-keypress test is disabled See https://bugs.webkit.org/show_bug.cgi?id=42194 * platform/qt-5.0-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (151014 => 151015) --- trunk/LayoutTests/ChangeLog 2013-05-31 13:29:28 UTC (rev 151014) +++ trunk/LayoutTests/ChangeLog 2013-05-31 15:21:40 UTC (rev 151015) @@ -1,3 +1,17 @@ +2013-05-31 Eugene Klyuchnikov + +[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing +https://bugs.webkit.org/show_bug.cgi?id=117070 + +Unreviewed test expectations update. + +WebKitTestRunner needs a more-complete implementation of eventSender. +Until then caret-after-keypress test is disabled + +See https://bugs.webkit.org/show_bug.cgi?id=42194 + +* platform/qt-5.0-wk2/TestExpectations: + 2013-05-31 Zoltan Arvai [Qt] Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations (151014 => 151015) --- trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2013-05-31 13:29:28 UTC (rev 151014) +++ trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2013-05-31 15:21:40 UTC (rev 151015) @@ -39,6 +39,7 @@ editing/selection/doubleclick-whitespace-crash.html editing/selection/doubleclick-whitespace-img-crash.html editing/selection/doubleclick-whitespace.html +editing/selection/caret-after-keypress.html editing/selection/empty-cell-right-click.html editing/selection/move-begin-end.html editing/selection/select-out-of-editable.html @@ -752,6 +753,3 @@ # [Qt] Newly addded test in r150234 fast/frames/flattening/scrolling-in-object.html fails webkit.org/b/116810 fast/frames/flattening/scrolling-in-object.html [ Skip ] - -# [Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing -webkit.org/b/117070 editing/selection/caret-after-keypress.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [151009] trunk
Title: [151009] trunk
Revision 151009
Author eus...@chromium.org
Date 2013-05-30 22:14:45 -0700 (Thu, 30 May 2013)
Log Message
selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=110742
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch defers firing "webkitEditableContentChanged" until new
selection is applied to control. This makes selection during "input"
more consistent and reliable.
Background: "input" event is fired by "webkitEditableContentChanged"
dispatcher. But "input" is scoped event, so under some conditions its
dispatching may be deferred. When "input" dispatching is deferred,
dispatcher observes updated selectionStart and selectionEnd.
Otherwise values repersent state before applying editing command.
So, to make selectionStart/End to be more predictable and useful, we
need either always dispatch "input" before selection is updated, or
always dispatch "input" after selection is updated.
As it was mentioned, dispatching could be deferred by scoping. So
dispatching before updating selection couldn't be guaranteed.
Moreover, it will be hard to calculate updated selection in user
code. On the other side - old selection could be easily tracked.
So, it looks logically that we should guarantee dispatching "input"
after updating selection. There are no execution paths in
"webkitEditableContentChanged" dispatched that depends on current
selection. So it is safe to fire this event after selection is updated.
Test: editing/selection/caret-after-keypress.html
* editing/Editor.cpp:
Dispatch "input" event after new selection in applied.
LayoutTests:
Test that cursor is up-to-date during "input" event.
* editing/selection/caret-after-keypress-expected.txt: Added.
* editing/selection/caret-after-keypress.html: Added.
* platform/mac-wk2/TestExpectations: Exclude new test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
Added Paths
trunk/LayoutTests/editing/selection/caret-after-keypress-expected.txt
trunk/LayoutTests/editing/selection/caret-after-keypress.html
Diff
Modified: trunk/LayoutTests/ChangeLog (151008 => 151009)
--- trunk/LayoutTests/ChangeLog 2013-05-31 04:53:34 UTC (rev 151008)
+++ trunk/LayoutTests/ChangeLog 2013-05-31 05:14:45 UTC (rev 151009)
@@ -1,3 +1,16 @@
+2013-05-30 Eugene Klyuchnikov
+
+selectionStart/selectionEnd return "obsolete" values when requested during "input" event
+https://bugs.webkit.org/show_bug.cgi?id=110742
+
+Reviewed by Ryosuke Niwa.
+
+Test that cursor is up-to-date during "input" event.
+
+* editing/selection/caret-after-keypress-expected.txt: Added.
+* editing/selection/caret-after-keypress.html: Added.
+* platform/mac-wk2/TestExpectations: Exclude new test.
+
2013-05-30 Gyuyoung Kim
Unreviewed, EFL gardening.
Added: trunk/LayoutTests/editing/selection/caret-after-keypress-expected.txt (0 => 151009)
--- trunk/LayoutTests/editing/selection/caret-after-keypress-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/caret-after-keypress-expected.txt 2013-05-31 05:14:45 UTC (rev 151009)
@@ -0,0 +1,37 @@
+This tests that 'input' event listener gets correct caret position after keypress.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS test.value is ""
+PASS test.selectionStart is 0
+PASS test.selectionEnd is 0
+
+PASS test.value is "a"
+PASS test.selectionStart is 1
+PASS test.selectionEnd is 1
+
+PASS test.value is "ab"
+PASS test.selectionStart is 2
+PASS test.selectionEnd is 2
+
+PASS test.value is "abc"
+PASS test.selectionStart is 3
+PASS test.selectionEnd is 3
+
+PASS test.value is "ab"
+PASS test.selectionStart is 2
+PASS test.selectionEnd is 2
+
+PASS test.value is "a"
+PASS test.selectionStart is 1
+PASS test.selectionEnd is 1
+
+PASS test.value is ""
+PASS test.selectionStart is 0
+PASS test.selectionEnd is 0
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/editing/selection/caret-after-keypress.html (0 => 151009)
--- trunk/LayoutTests/editing/selection/caret-after-keypress.html (rev 0)
+++ trunk/LayoutTests/editing/selection/caret-after-keypress.html 2013-05-31 05:14:45 UTC (rev 151009)
@@ -0,0 +1,30 @@
+
+
+
+
+description("This tests that 'input' event listener gets correct caret position after keypress.");
+
+var test = document.createElement("input");
+document.body.appendChild(test);
+test.focus();
+
+const backSpace = String.fromCharCode(8);
+var input = ["a", "b", "c", backSpace, backSpace, backSpace];
+var output = ["", "a", "ab", "abc", "ab", "a", ""];
+
+function step() {
+var expectedValue = output.shift();
+shouldBeEqualToString("test.value", expectedValue);
+shouldBe("test.selectionStart", "" + expectedValue.
[webkit-changes] [147519] trunk/Source/WebCore
Title: [147519] trunk/Source/WebCore
Revision 147519
Author eus...@chromium.org
Date 2013-04-02 23:00:21 -0700 (Tue, 02 Apr 2013)
Log Message
Web Inspector: [Network] Split business logic and presentation for initiator column.
https://bugs.webkit.org/show_bug.cgi?id=113486
Reviewed by Pavel Feldman.
Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying
viewport rendering, because initiator sorting function
depends on data written when cell is rendered.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Removed business logic. Use "initiatorInfo".
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Use "initiatorInfo".
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.initiatorInfo):
Extracted business logic from "refreshInitiatorCell".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (147518 => 147519)
--- trunk/Source/WebCore/ChangeLog 2013-04-03 05:39:31 UTC (rev 147518)
+++ trunk/Source/WebCore/ChangeLog 2013-04-03 06:00:21 UTC (rev 147519)
@@ -1,3 +1,24 @@
+2013-04-02 Eugene Klyuchnikov
+
+Web Inspector: [Network] Split business logic and presentation for initiator column.
+https://bugs.webkit.org/show_bug.cgi?id=113486
+
+Reviewed by Pavel Feldman.
+
+Currently business logic and presentation are mixed.
+This prevents making cell renderer static and applying
+viewport rendering, because initiator sorting function
+depends on data written when cell is rendered.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
+Removed business logic. Use "initiatorInfo".
+(WebInspector.NetworkDataGridNode.InitiatorComparator):
+Use "initiatorInfo".
+* inspector/front-end/NetworkRequest.js:
+(WebInspector.NetworkRequest.prototype.initiatorInfo):
+Extracted business logic from "refreshInitiatorCell".
+
2013-04-02 Ryosuke Niwa
needsLeopardMailQuirks should be removed
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (147518 => 147519)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-04-03 05:39:31 UTC (rev 147518)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-04-03 06:00:21 UTC (rev 147519)
@@ -2236,55 +2236,40 @@
_refreshInitiatorCell: function()
{
+this._initiatorCell.removeChildren();
this._initiatorCell.removeStyleClass("network-dim-cell");
this._initiatorCell.removeStyleClass("network-script-initiated");
delete this._initiatorCell.request;
-this._initiatorCell.title = "";
-this._displayedInitiatorURL = "";
-this._displayedInitiatorLineNumber = -Infinity;
-this._displayedInitiatorType = "";
-var initiator = this._request.initiator;
-var initiatorTypes = WebInspector.NetworkRequest.InitiatorType;
-if ((initiator && initiator.type !== initiatorTypes.Other) || this._request.redirectSource) {
-this._initiatorCell.removeChildren();
-var redirectSource = this._request.redirectSource;
-if (redirectSource) {
-this._initiatorCell.title = redirectSource.url;
-this._initiatorCell.appendChild(WebInspector.linkifyRequestAsNode(redirectSource));
-this._displayedInitiatorType = WebInspector.UIString("Redirect");
-this._appendSubtitle(this._initiatorCell, this._displayedInitiatorType);
-this._displayedInitiatorURL = redirectSource.url;
-} else if (initiator.type === initiatorTypes.Script) {
-var topFrame = initiator.stackTrace[0];
-// This could happen when request loading was triggered by console.
-if (!topFrame.url) {
-this._initiatorCell.addStyleClass("network-dim-cell");
-this._displayedInitiatorType = WebInspector.UIString("Other");
-this._initiatorCell.setTextAndTitle(this._displayedInitiatorType);
-return;
-}
-var urlElement = this._parentView._linkifier.linkifyLocation(topFrame.url, topFrame.lineNumber - 1, 0);
-urlElement.title = "";
-this._initiatorCell.appendChild(urlElement);
-this._displayedInitiatorType = WebInspector.UIString("Script");
-this._appendSubtitle(this._initiatorCell, this._displayedInitiatorType);
-this._initiatorCell.addStyleClass("network-script-initiated");
-this._initiatorCell.request = this._request;
-this._displayedInitiatorURL = WebIns
[webkit-changes] [147412] trunk/Source/WebCore
Title: [147412] trunk/Source/WebCore Revision 147412 Author eus...@chromium.org Date 2013-04-02 02:52:29 -0700 (Tue, 02 Apr 2013) Log Message Web Inspector: [HeapProfiler] Table rows do not appear when resizing. https://bugs.webkit.org/show_bug.cgi?id=113760 Reviewed by Yury Semikhatsky. Analysis: custom-made split-view doesn't notify content panes about resizing. * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight): Notify content pane about resize. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js Diff Modified: trunk/Source/WebCore/ChangeLog (147411 => 147412) --- trunk/Source/WebCore/ChangeLog 2013-04-02 09:50:25 UTC (rev 147411) +++ trunk/Source/WebCore/ChangeLog 2013-04-02 09:52:29 UTC (rev 147412) @@ -1,3 +1,17 @@ +2013-04-02 Eugene Klyuchnikov + +Web Inspector: [HeapProfiler] Table rows do not appear when resizing. +https://bugs.webkit.org/show_bug.cgi?id=113760 + +Reviewed by Yury Semikhatsky. + +Analysis: custom-made split-view doesn't notify content panes about +resizing. + +* inspector/front-end/HeapSnapshotView.js: +(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight): +Notify content pane about resize. + 2013-04-02 Mihnea Ovidenie [CSSRegions] Clean-up RenderFlowThread::updateRegionsFlowThreadPortionRect Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (147411 => 147412) --- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2013-04-02 09:50:25 UTC (rev 147411) +++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js 2013-04-02 09:52:29 UTC (rev 147412) @@ -686,6 +686,7 @@ this.viewsContainer.style.bottom = (height + this.retainmentViewHeader.clientHeight) + "px"; this.retainmentView.element.style.height = height + "px"; this.retainmentViewHeader.style.bottom = height + "px"; +this.currentView.doResize(); }, _updateBaseOptions: function() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [147198] trunk/Source/WebCore
Title: [147198] trunk/Source/WebCore
Revision 147198
Author eus...@chromium.org
Date 2013-03-28 23:31:25 -0700 (Thu, 28 Mar 2013)
Log Message
Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
https://bugs.webkit.org/show_bug.cgi?id=113496
Reviewed by Pavel Feldman.
Integrate CookiesTable with DataGrid context menu
instead of overriding it.
* inspector/front-end/CookiesTable.js:
Pass context menu callback to DataGrid constructor.
* inspector/front-end/DataGrid.js:
Added context menu callback constructor parameter. Fixed JSDoc.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CookiesTable.js
trunk/Source/WebCore/inspector/front-end/DataGrid.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (147197 => 147198)
--- trunk/Source/WebCore/ChangeLog 2013-03-29 05:53:14 UTC (rev 147197)
+++ trunk/Source/WebCore/ChangeLog 2013-03-29 06:31:25 UTC (rev 147198)
@@ -1,3 +1,18 @@
+2013-03-28 Eugene Klyuchnikov
+
+Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
+https://bugs.webkit.org/show_bug.cgi?id=113496
+
+Reviewed by Pavel Feldman.
+
+Integrate CookiesTable with DataGrid context menu
+instead of overriding it.
+
+* inspector/front-end/CookiesTable.js:
+Pass context menu callback to DataGrid constructor.
+* inspector/front-end/DataGrid.js:
+Added context menu callback constructor parameter. Fixed JSDoc.
+
2013-03-28 Philip Rogers
Fix compiler warning in IDBTransaction::modeToString
Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (147197 => 147198)
--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2013-03-29 05:53:14 UTC (rev 147197)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2013-03-29 06:31:25 UTC (rev 147198)
@@ -55,11 +55,9 @@
];
if (readOnly)
-this._dataGrid = new WebInspector.DataGrid(columns, null, null, refreshCallback);
-else {
this._dataGrid = new WebInspector.DataGrid(columns);
-this._dataGrid.element.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), true);
-}
+else
+this._dataGrid = new WebInspector.DataGrid(columns, undefined, this._onDeleteCookie.bind(this), refreshCallback, this._onContextMenu.bind(this));
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._rebuildTable, this);
@@ -85,35 +83,22 @@
_clearAndRefresh: function(domain)
{
this.clear(domain);
-if (this._refreshCallback)
-this._refreshCallback();
+this._refresh();
},
-_handleContextMenuEvent: function(event)
+/**
+ * @param {!WebInspector.ContextMenu} contextMenu
+ * @param {WebInspector.DataGridNode} node
+ */
+_onContextMenu: function(contextMenu, node)
{
-var gridNode = this._dataGrid.dataGridNodeFromNode(event.target);
-
-if (!gridNode)
+if (node === this._dataGrid.creationNode)
return;
-
-var contextMenu = new WebInspector.ContextMenu(event);
-var cookie = gridNode.cookie;
-
-if (this._refreshCallback)
-contextMenu.appendItem(WebInspector.UIString("Refresh"), this._refreshCallback);
-
-if (cookie) {
-contextMenu.appendItem(WebInspector.UIString("Delete"), this._onDeleteCookie.bind(this, gridNode));
-contextMenu.appendSeparator();
-var cookieDomain = cookie.domain();
-
-contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear all from \"%s\"" : "Clear All from \"%s\"", cookieDomain), this._clearAndRefresh.bind(this, cookieDomain));
-} else
-contextMenu.appendSeparator();
-
+var cookie = node.cookie;
+var domain = cookie.domain();
+if (domain)
+contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear all from \"%s\"" : "Clear All from \"%s\"", domain), this._clearAndRefresh.bind(this, domain));
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Clear all" : "Clear All"), this._clearAndRefresh.bind(this, null));
-
-contextMenu.show();
},
/**
@@ -290,6 +275,11 @@
if (neighbour)
this._nextSelectedCookie = neighbour.cookie;
cookie.remove();
+this._refresh();
+},
+
+_refresh: function()
+{
if (this._refreshCallback)
this._refreshCallback();
},
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (147197 => 147198)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-29 05:53:14 UTC (rev 147197)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-29 06:31:25 UTC (rev 147198)
@@ -27,11 +27,12 @@
* @constructor
* @extends {WebInspector.View}
*
[webkit-changes] [147104] trunk/Source/WebCore
Title: [147104] trunk/Source/WebCore
Revision 147104
Author eus...@chromium.org
Date 2013-03-28 06:09:12 -0700 (Thu, 28 Mar 2013)
Log Message
Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375
Reviewed by Pavel Feldman.
Serialized "previouslyViewedFiles" may make local storage overflow.
Two fixed applied:
- limit number of history log items
- limit length of URIs that get serialized;
this would affect only data-url URIs.
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
Added length check.
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
Added output array length limit.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (147103 => 147104)
--- trunk/Source/WebCore/ChangeLog 2013-03-28 13:07:43 UTC (rev 147103)
+++ trunk/Source/WebCore/ChangeLog 2013-03-28 13:09:12 UTC (rev 147104)
@@ -1,3 +1,22 @@
+2013-03-28 Eugene Klyuchnikov
+
+Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
+https://bugs.webkit.org/show_bug.cgi?id=113375
+
+Reviewed by Pavel Feldman.
+
+Serialized "previouslyViewedFiles" may make local storage overflow.
+Two fixed applied:
+- limit number of history log items
+- limit length of URIs that get serialized;
+ this would affect only data-url URIs.
+
+* inspector/front-end/TabbedEditorContainer.js:
+(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
+Added length check.
+(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
+Added output array length limit.
+
2013-03-28 Alexei Filippov
Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
Modified: trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js (147103 => 147104)
--- trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2013-03-28 13:07:43 UTC (rev 147103)
+++ trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2013-03-28 13:09:12 UTC (rev 147104)
@@ -424,11 +424,14 @@
*/
WebInspector.TabbedEditorContainer.HistoryItem = function(url, selectionRange, scrollLineNumber)
{
-this.url = ""
+/** @const */ this.url = ""
+/** @const */ this._isSerializable = url.length < WebInspector.TabbedEditorContainer.HistoryItem.serializableUrlLengthLimit;
this.selectionRange = selectionRange;
this.scrollLineNumber = scrollLineNumber;
}
+WebInspector.TabbedEditorContainer.HistoryItem.serializableUrlLengthLimit = 4096;
+
/**
* @param {Object} serializedHistoryItem
* @return {WebInspector.TabbedEditorContainer.HistoryItem}
@@ -441,10 +444,12 @@
WebInspector.TabbedEditorContainer.HistoryItem.prototype = {
/**
- * @return {Object}
+ * @return {?Object}
*/
serializeToObject: function()
{
+if (!this._isSerializable)
+return null;
var serializedHistoryItem = {};
serializedHistoryItem.url = ""
serializedHistoryItem.selectionRange = this.selectionRange;
@@ -466,7 +471,7 @@
}
/**
- * @param {Object} serializedHistory
+ * @param {!Array.} serializedHistory
* @return {WebInspector.TabbedEditorContainer.History}
*/
WebInspector.TabbedEditorContainer.History.fromObject = function(serializedHistory)
@@ -584,13 +589,18 @@
},
/**
- * @return {Object}
+ * @return {!Array.}
*/
_serializeToObject: function()
{
var serializedHistory = [];
-for (var i = 0; i < this._items.length; ++i)
-serializedHistory.push(this._items[i].serializeToObject());
+for (var i = 0; i < this._items.length; ++i) {
+var serializedItem = this._items[i].serializeToObject();
+if (serializedItem)
+serializedHistory.push(serializedItem);
+if (serializedHistory.length === WebInspector.TabbedEditorContainer.maximalPreviouslyViewedFilesCount)
+break;
+}
return serializedHistory;
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146849] trunk/Source/WebCore
Title: [146849] trunk/Source/WebCore
Revision 146849
Author eus...@chromium.org
Date 2013-03-25 21:51:35 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177
Reviewed by Pavel Feldman.
Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.
Fix: make timeline-specific rule "important".
* inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make "bottom" value "important".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (146848 => 146849)
--- trunk/Source/WebCore/ChangeLog 2013-03-26 04:04:02 UTC (rev 146848)
+++ trunk/Source/WebCore/ChangeLog 2013-03-26 04:51:35 UTC (rev 146849)
@@ -1,3 +1,18 @@
+2013-03-25 Eugene Klyuchnikov
+
+Web Inspector: [Timeline] Records sidebar is clipped.
+https://bugs.webkit.org/show_bug.cgi?id=113177
+
+Reviewed by Pavel Feldman.
+
+Analysis: depending on CSS injection order sidebar rule that overwrites
+"bottom" property may win.
+
+Fix: make timeline-specific rule "important".
+
+* inspector/front-end/timelinePanel.css:
+(.timeline .sidebar): Make "bottom" value "important".
+
2013-03-25 Kent Tamura
Rename ENABLE_INPUT_TYPE_DATETIME
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (146848 => 146849)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-26 04:04:02 UTC (rev 146848)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-26 04:51:35 UTC (rev 146849)
@@ -42,7 +42,7 @@
.timeline .sidebar {
overflow-y: hidden;
min-height: 100%;
-bottom: auto;
+bottom: auto !important;
}
.timeline.split-view-vertical .split-view-resizer {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146757] trunk/Source/WebCore
Title: [146757] trunk/Source/WebCore
Revision 146757
Author eus...@chromium.org
Date 2013-03-25 04:35:11 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: Fix JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=113025
Reviewed by Pavel Feldman.
Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.
* inspector/InjectedScriptSource.js: Fix JSDocs.
* inspector/front-end/ConsoleModel.js: Ditto.
* inspector/front-end/CookieParser.js: Ditto.
* inspector/front-end/FileContentView.js: Ditto.
* inspector/front-end/HeapSnapshotView.js: Ditto.
* inspector/front-end/IndexedDBModel.js: Ditto.
* inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
* inspector/front-end/utilities.js: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/front-end/ConsoleModel.js
trunk/Source/WebCore/inspector/front-end/CookieParser.js
trunk/Source/WebCore/inspector/front-end/FileContentView.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js
trunk/Source/WebCore/inspector/front-end/utilities.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146756 => 146757)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 11:30:34 UTC (rev 146756)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 11:35:11 UTC (rev 146757)
@@ -1,3 +1,23 @@
+2013-03-25 Eugene Klyuchnikov
+
+Web Inspector: Fix JSDocs.
+https://bugs.webkit.org/show_bug.cgi?id=113025
+
+Reviewed by Pavel Feldman.
+
+Next version of JS compiler finds more inconsistencies
+and ambiguous declarations.
+Some of them are resolved in this patch.
+
+* inspector/InjectedScriptSource.js: Fix JSDocs.
+* inspector/front-end/ConsoleModel.js: Ditto.
+* inspector/front-end/CookieParser.js: Ditto.
+* inspector/front-end/FileContentView.js: Ditto.
+* inspector/front-end/HeapSnapshotView.js: Ditto.
+* inspector/front-end/IndexedDBModel.js: Ditto.
+* inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
+* inspector/front-end/utilities.js: Ditto.
+
2013-03-25 Mike West
Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (146756 => 146757)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2013-03-25 11:30:34 UTC (rev 146756)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2013-03-25 11:35:11 UTC (rev 146757)
@@ -484,7 +484,7 @@
* Resolves a value from CallArgument description.
* @param {RuntimeAgent.CallArgument} callArgumentJson
* @return {*} resolved value
- * @throw {string} error message
+ * @throws {string} error message
*/
_resolveCallArgument: function(callArgumentJson) {
var objectId = callArgumentJson.objectId;
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleModel.js (146756 => 146757)
--- trunk/Source/WebCore/inspector/front-end/ConsoleModel.js 2013-03-25 11:30:34 UTC (rev 146756)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleModel.js 2013-03-25 11:35:11 UTC (rev 146757)
@@ -192,6 +192,9 @@
// Implemented by concrete instances
},
+/**
+ * @return {WebInspector.DebuggerModel.Location}
+ */
location: function()
{
// Implemented by concrete instances
Modified: trunk/Source/WebCore/inspector/front-end/CookieParser.js (146756 => 146757)
--- trunk/Source/WebCore/inspector/front-end/CookieParser.js 2013-03-25 11:30:34 UTC (rev 146756)
+++ trunk/Source/WebCore/inspector/front-end/CookieParser.js 2013-03-25 11:35:11 UTC (rev 146757)
@@ -370,12 +370,15 @@
WebInspector.Cookies = {}
+/**
+ * @param {function(!Array., boolean)} callback
+ */
WebInspector.Cookies.getCookiesAsync = function(callback)
{
/**
* @param {?Protocol.Error} error
- * @param {Array.} cookies
- * @param {string} cookiesString
+ * @param {Array.} cookies
+ * @param {string} cookiesString
*/
function mycallback(error, cookies, cookiesString)
{
@@ -392,7 +395,7 @@
/**
* @param {string} rawCookieString
- * @return {Array.}
+ * @return {!Array.}
*/
WebInspector.Cookies.buildCookiesFromString = function(rawCookieString)
{
@@ -416,7 +419,7 @@
}
/**
- * @param {Object} protocolCookie
+ * @param {!PageAgent.Cookie} protocolCookie
* @return {!WebInspector.Cookie}
*/
WebInspector.Cookies.buildCookieProtocolObject = function(protocolCookie)
Modified: trunk/Source/WebCore/inspector/front-end/FileContentView.js (146756 => 146757)
--- trunk/Source/WebCore/inspector/front-end/FileContentView.js 2013-03-25 11:30:34 UTC (rev 146756)
+++ trunk/Source/WebCore/inspector/front-end/FileContentView.js 2013-03-25 11:35:11 UTC (rev 146757)
@@ -37,7 +37,7 @@
{
WebInspector.View.call(this);
-this._inn
[webkit-changes] [146753] trunk/Source/WebCore
Title: [146753] trunk/Source/WebCore
Revision 146753
Author eus...@chromium.org
Date 2013-03-25 02:50:44 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032
Reviewed by Pavel Feldman.
To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.
This feature is hard to discover.
Setting "move" cursor will make this feature more discoverable.
* inspector/front-end/inspectorCommon.css:
Set "move" cursor to draggable area.
* inspector/front-end/OverviewGrid.js: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/OverviewGrid.js
trunk/Source/WebCore/inspector/front-end/inspectorCommon.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (146752 => 146753)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 09:50:44 UTC (rev 146753)
@@ -1,5 +1,23 @@
2013-03-25 Eugene Klyuchnikov
+Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
+https://bugs.webkit.org/show_bug.cgi?id=113032
+
+Reviewed by Pavel Feldman.
+
+To move overview window user could drag-n-drop over
+time "ribbon" on OverviewGrid.
+
+This feature is hard to discover.
+
+Setting "move" cursor will make this feature more discoverable.
+
+* inspector/front-end/inspectorCommon.css:
+Set "move" cursor to draggable area.
+* inspector/front-end/OverviewGrid.js: Ditto.
+
+2013-03-25 Eugene Klyuchnikov
+
Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015
Modified: trunk/Source/WebCore/inspector/front-end/OverviewGrid.js (146752 => 146753)
--- trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-25 09:50:44 UTC (rev 146753)
@@ -179,7 +179,7 @@
this._dividersLabelBarElement = dividersLabelBarElement;
WebInspector.installDragHandle(this._parentElement, this._startWindowSelectorDragging.bind(this), this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), "ew-resize");
-WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "ew-resize");
+WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "move");
this.windowLeft = 0.0;
this.windowRight = 1.0;
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (146752 => 146753)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-25 09:50:44 UTC (rev 146753)
@@ -90,6 +90,7 @@
height: 20px;
z-index: 200;
pointer-events: none;
+cursor: move;
}
.resources-divider {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146752] trunk/Source/WebCore
Title: [146752] trunk/Source/WebCore
Revision 146752
Author eus...@chromium.org
Date 2013-03-25 02:33:30 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015
Reviewed by Pavel Feldman.
_profileGroupsForLinks is not used anymore.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146751 => 146752)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 09:33:14 UTC (rev 146751)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 09:33:30 UTC (rev 146752)
@@ -1,3 +1,15 @@
+2013-03-25 Eugene Klyuchnikov
+
+Web Inspector: [Profiles] Remove unused private member.
+https://bugs.webkit.org/show_bug.cgi?id=113015
+
+Reviewed by Pavel Feldman.
+
+_profileGroupsForLinks is not used anymore.
+
+* inspector/front-end/ProfilesPanel.js:
+(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.
+
2013-03-25 PhistucK
Web Inspector: Exception when turning on pretty print without any displayed source in the editor
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (146751 => 146752)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2013-03-25 09:33:14 UTC (rev 146751)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2013-03-25 09:33:30 UTC (rev 146752)
@@ -546,7 +546,6 @@
this.searchCanceled();
this._profileGroups = {};
-this._profileGroupsForLinks = {};
this._profilesWereRequested = false;
this.recordButton.toggled = false;
if (this._selectedProfileType)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146745] trunk/Source/WebCore
Title: [146745] trunk/Source/WebCore
Revision 146745
Author eus...@chromium.org
Date 2013-03-25 00:45:45 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: [Settings] Use registry to track settings objects.
https://bugs.webkit.org/show_bug.cgi?id=113008
Reviewed by Pavel Feldman.
Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.
To resolve this issue we can use registry to make .createSetting return
same object for specific key.
* inspector/front-end/Settings.js:
(WebInspector.Settings.prototype.createSetting): Use registry.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Settings.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146744 => 146745)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 04:58:36 UTC (rev 146744)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 07:45:45 UTC (rev 146745)
@@ -1,3 +1,19 @@
+2013-03-25 Eugene Klyuchnikov
+
+Web Inspector: [Settings] Use registry to track settings objects.
+https://bugs.webkit.org/show_bug.cgi?id=113008
+
+Reviewed by Pavel Feldman.
+
+Currently .createSetting creates new instance any time it is invoked.
+When one instance saves value, the other instance do not know about it.
+
+To resolve this issue we can use registry to make .createSetting return
+same object for specific key.
+
+* inspector/front-end/Settings.js:
+(WebInspector.Settings.prototype.createSetting): Use registry.
+
2013-03-24 Matt Falkenhagen
Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (146744 => 146745)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-25 04:58:36 UTC (rev 146744)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-25 07:45:45 UTC (rev 146745)
@@ -72,6 +72,7 @@
WebInspector.Settings = function()
{
this._eventSupport = new WebInspector.Object();
+this._registry = /** @type {!Object.} */ ({});
this.colorFormat = this.createSetting("colorFormat", "original");
this.consoleHistory = this.createSetting("consoleHistory", []);
@@ -132,11 +133,15 @@
WebInspector.Settings.prototype = {
/**
- * @return {WebInspector.Setting}
+ * @param {string} key
+ * @param {*} defaultValue
+ * @return {!WebInspector.Setting}
*/
createSetting: function(key, defaultValue)
{
-return new WebInspector.Setting(key, defaultValue, this._eventSupport, window.localStorage);
+if (!this._registry[key])
+this._registry[key] = new WebInspector.Setting(key, defaultValue, this._eventSupport, window.localStorage);
+return this._registry[key];
}
}
@@ -209,7 +214,7 @@
this._setting = WebInspector.settings.createSetting("experiments", {});
this._experiments = [];
this._enabledForTest = {};
-
+
// Add currently running experiments here.
this.snippetsSupport = this._createExperiment("snippetsSupport", "Snippets support");
this.nativeMemorySnapshots = this._createExperiment("nativeMemorySnapshots", "Native memory profiling");
@@ -238,7 +243,7 @@
{
return this._experiments.slice();
},
-
+
/**
* @return {boolean}
*/
@@ -246,7 +251,7 @@
{
return Preferences.experimentsEnabled || ("experiments" in WebInspector.queryParamsObject);
},
-
+
/**
* @param {string} experimentName
* @param {string} experimentTitle
@@ -258,7 +263,7 @@
this._experiments.push(experiment);
return experiment;
},
-
+
/**
* @param {string} experimentName
* @return {boolean}
@@ -274,7 +279,7 @@
var experimentsSetting = this._setting.get();
return experimentsSetting[experimentName];
},
-
+
/**
* @param {string} experimentName
* @param {boolean} enabled
@@ -328,7 +333,7 @@
{
return this._name;
},
-
+
/**
* @return {string}
*/
@@ -336,7 +341,7 @@
{
return this._title;
},
-
+
/**
* @return {boolean}
*/
@@ -344,7 +349,7 @@
{
return this._experimentsSettings.isEnabled(this._name);
},
-
+
/**
* @param {boolean} enabled
*/
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146442] trunk/Source/WebCore
Title: [146442] trunk/Source/WebCore
Revision 146442
Author eus...@chromium.org
Date 2013-03-21 00:15:08 -0700 (Thu, 21 Mar 2013)
Log Message
Web Inspector: [Settings] Fix JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=112879
Reviewed by Pavel Feldman.
Removed erroneous JSDoc.
* inspector/front-end/Settings.js: Removed erroneous JSDoc.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Settings.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146441 => 146442)
--- trunk/Source/WebCore/ChangeLog 2013-03-21 06:35:24 UTC (rev 146441)
+++ trunk/Source/WebCore/ChangeLog 2013-03-21 07:15:08 UTC (rev 146442)
@@ -1,3 +1,14 @@
+2013-03-21 Eugene Klyuchnikov
+
+Web Inspector: [Settings] Fix JS compiler warnings.
+https://bugs.webkit.org/show_bug.cgi?id=112879
+
+Reviewed by Pavel Feldman.
+
+Removed erroneous JSDoc.
+
+* inspector/front-end/Settings.js: Removed erroneous JSDoc.
+
2013-03-20 Simon Fraser
Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (146441 => 146442)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-21 06:35:24 UTC (rev 146441)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-21 07:15:08 UTC (rev 146442)
@@ -187,9 +187,6 @@
return this._value;
},
-/**
- * @param {!Object} value
- */
set: function(value)
{
this._value = value;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146333] trunk/Source/WebCore
Title: [146333] trunk/Source/WebCore
Revision 146333
Author eus...@chromium.org
Date 2013-03-20 05:43:13 -0700 (Wed, 20 Mar 2013)
Log Message
Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433
Reviewed by Pavel Feldman.
Fixed cell height to correspond grid step.
* inspector/front-end/dataGrid.css:
(.data-grid td): Fixed cell height to correspond grid step.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/dataGrid.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (146332 => 146333)
--- trunk/Source/WebCore/ChangeLog 2013-03-20 12:26:23 UTC (rev 146332)
+++ trunk/Source/WebCore/ChangeLog 2013-03-20 12:43:13 UTC (rev 146333)
@@ -1,3 +1,15 @@
+2013-03-20 Eugene Klyuchnikov
+
+Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
+https://bugs.webkit.org/show_bug.cgi?id=112433
+
+Reviewed by Pavel Feldman.
+
+Fixed cell height to correspond grid step.
+
+* inspector/front-end/dataGrid.css:
+(.data-grid td): Fixed cell height to correspond grid step.
+
2013-03-20 Allan Sandfeld Jensen
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
Modified: trunk/Source/WebCore/inspector/front-end/dataGrid.css (146332 => 146333)
--- trunk/Source/WebCore/inspector/front-end/dataGrid.css 2013-03-20 12:26:23 UTC (rev 146332)
+++ trunk/Source/WebCore/inspector/front-end/dataGrid.css 2013-03-20 12:43:13 UTC (rev 146333)
@@ -101,7 +101,7 @@
.data-grid td {
vertical-align: top;
-height: 12px;
+height: 16px; /* Keep in sync with .data-grid table.data @ -webkit-background-size */
line-height: 12px;
padding: 2px 4px;
white-space: nowrap;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146317] trunk/Source/WebCore
Title: [146317] trunk/Source/WebCore
Revision 146317
Author eus...@chromium.org
Date 2013-03-20 02:08:56 -0700 (Wed, 20 Mar 2013)
Log Message
Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=112667
Reviewed by Pavel Feldman.
New parameter will allow more options on how long setting will persist.
Possible options are: localStorage, sessionStorage and no-storage.
Additional change: use delete instead of .removeItem to make it possible
use any object as storage.
* inspector/front-end/Settings.js:
Added "storage" parameter and used is instead of "window.localStorage".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Settings.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146316 => 146317)
--- trunk/Source/WebCore/ChangeLog 2013-03-20 08:55:39 UTC (rev 146316)
+++ trunk/Source/WebCore/ChangeLog 2013-03-20 09:08:56 UTC (rev 146317)
@@ -1,3 +1,19 @@
+2013-03-20 Eugene Klyuchnikov
+
+Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
+https://bugs.webkit.org/show_bug.cgi?id=112667
+
+Reviewed by Pavel Feldman.
+
+New parameter will allow more options on how long setting will persist.
+Possible options are: localStorage, sessionStorage and no-storage.
+
+Additional change: use delete instead of .removeItem to make it possible
+use any object as storage.
+
+* inspector/front-end/Settings.js:
+Added "storage" parameter and used is instead of "window.localStorage".
+
2013-03-20 Pan Deng
Web Inspector: [Network] Fix the bug of WebSocketFrameView crash.
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (146316 => 146317)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-20 08:55:39 UTC (rev 146316)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2013-03-20 09:08:56 UTC (rev 146317)
@@ -135,18 +135,23 @@
*/
createSetting: function(key, defaultValue)
{
-return new WebInspector.Setting(key, defaultValue, this._eventSupport);
+return new WebInspector.Setting(key, defaultValue, this._eventSupport, window.localStorage);
}
}
/**
* @constructor
+ * @param {string} name
+ * @param {*} defaultValue
+ * @param {!WebInspector.Object} eventSupport
+ * @param {?Storage} storage
*/
-WebInspector.Setting = function(name, defaultValue, eventSupport)
+WebInspector.Setting = function(name, defaultValue, eventSupport, storage)
{
this._name = name;
this._defaultValue = defaultValue;
this._eventSupport = eventSupport;
+this._storage = storage;
}
WebInspector.Setting.prototype = {
@@ -171,22 +176,25 @@
return this._value;
this._value = this._defaultValue;
-if (window.localStorage != null && this._name in window.localStorage) {
+if (this._storage && this._name in this._storage) {
try {
-this._value = JSON.parse(window.localStorage[this._name]);
+this._value = JSON.parse(this._storage[this._name]);
} catch(e) {
-window.localStorage.removeItem(this._name);
+delete this._storage[this._name];
}
}
return this._value;
},
+/**
+ * @param {!Object} value
+ */
set: function(value)
{
this._value = value;
-if (window.localStorage != null) {
+if (this._storage) {
try {
-window.localStorage[this._name] = JSON.stringify(value);
+this._storage[this._name] = JSON.stringify(value);
} catch(e) {
console.error("Error saving setting with name:" + this._name);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146303] trunk/Source/WebCore
Title: [146303] trunk/Source/WebCore
Revision 146303
Author eus...@chromium.org
Date 2013-03-19 22:13:34 -0700 (Tue, 19 Mar 2013)
Log Message
Web Inspector: [Timeline] Tune status bar UI for limited-width window.
https://bugs.webkit.org/show_bug.cgi?id=112702
Reviewed by Pavel Feldman.
Reduce filter titles when there is not enough space.
* inspector/front-end/TimelinePanel.js: Add classnames to elements.
* inspector/front-end/timelinePanel.css: Specify "flex" behaviour.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (146302 => 146303)
--- trunk/Source/WebCore/ChangeLog 2013-03-20 04:31:02 UTC (rev 146302)
+++ trunk/Source/WebCore/ChangeLog 2013-03-20 05:13:34 UTC (rev 146303)
@@ -1,3 +1,15 @@
+2013-03-19 Eugene Klyuchnikov
+
+Web Inspector: [Timeline] Tune status bar UI for limited-width window.
+https://bugs.webkit.org/show_bug.cgi?id=112702
+
+Reviewed by Pavel Feldman.
+
+Reduce filter titles when there is not enough space.
+
+* inspector/front-end/TimelinePanel.js: Add classnames to elements.
+* inspector/front-end/timelinePanel.css: Specify "flex" behaviour.
+
2013-03-19 Nate Chapin
Merge MainResourceLoader into DocumentLoader
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (146302 => 146303)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-20 04:31:02 UTC (rev 146302)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-20 05:13:34 UTC (rev 146303)
@@ -274,9 +274,9 @@
this._statusBarItems.push(this._durationFilterSelector);
this._miscStatusBarItems = document.createElement("div");
-this._miscStatusBarItems.className = "status-bar-items";
+this._miscStatusBarItems.className = "status-bar-items timeline-misc-status-bar-items";
-this._statusBarFilters = this._miscStatusBarItems.createChild("div");
+this._statusBarFilters = this._miscStatusBarItems.createChild("div", "timeline-misc-status-bar-filters");
var categories = WebInspector.TimelinePresentationModel.categories();
for (var categoryName in categories) {
var category = categories[categoryName];
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (146302 => 146303)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-20 04:31:02 UTC (rev 146302)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-20 05:13:34 UTC (rev 146303)
@@ -175,6 +175,15 @@
color: inherit;
}
+.timeline-misc-status-bar-items {
+right: 64px;
+}
+
+.timeline-misc-status-bar-filters {
+display: -webkit-flex;
+-webkit-flex-orientation: row;
+}
+
.timeline-category-statusbar-item {
height: 24px;
line-height: 24px;
@@ -183,6 +192,8 @@
text-overflow: ellipsis;
overflow: hidden;
font-weight: bold;
+min-width: 20px;
+-webkit-flex: auto 0 1;
}
.timeline-category-statusbar-item,
@@ -406,6 +417,7 @@
.timeline-records-stats {
margin-top: 5px;
margin-left: 6px;
+-webkit-flex: 1;
}
.timeline-records-stats-container {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146066] trunk/Source/WebCore
Title: [146066] trunk/Source/WebCore
Revision 146066
Author eus...@chromium.org
Date 2013-03-18 08:11:12 -0700 (Mon, 18 Mar 2013)
Log Message
Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545
Reviewed by Vsevolod Vlasov.
F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.
* English.lproj/localizedStrings.js: Added string.
* inspector/front-end/inspector.js: Registered F1 / "?" shortcut.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146065 => 146066)
--- trunk/Source/WebCore/ChangeLog 2013-03-18 14:27:22 UTC (rev 146065)
+++ trunk/Source/WebCore/ChangeLog 2013-03-18 15:11:12 UTC (rev 146066)
@@ -1,3 +1,15 @@
+2013-03-18 Eugene Klyuchnikov
+
+Web Inspector: [Settings] Register "?" shortcut.
+https://bugs.webkit.org/show_bug.cgi?id=112545
+
+Reviewed by Vsevolod Vlasov.
+
+F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.
+
+* English.lproj/localizedStrings.js: Added string.
+* inspector/front-end/inspector.js: Registered F1 / "?" shortcut.
+
2013-03-18 Carlos Garcia Campos
Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (146065 => 146066)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-03-18 14:27:22 UTC (rev 146065)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-03-18 15:11:12 UTC (rev 146066)
@@ -390,6 +390,7 @@
localizedStrings["Show console."] = "Show console.";
localizedStrings["Show function definition"] = "Show function definition";
localizedStrings["Show inherited"] = "Show inherited";
+localizedStrings["Show keyboard shortcuts"] = "Show keyboard shortcuts";
localizedStrings["Show rulers"] = "Show rulers";
localizedStrings["Show Shadow DOM"] = "Show Shadow DOM";
localizedStrings["Show times as percentages."] = "Show times as percentages.";
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (146065 => 146066)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2013-03-18 14:27:22 UTC (rev 146065)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2013-03-18 15:11:12 UTC (rev 146066)
@@ -675,7 +675,7 @@
];
section.addRelatedKeys(keys, WebInspector.UIString("Go to the panel to the left/right"));
-var keys = [
+keys = [
shortcut.makeDescriptor("[", shortcut.Modifiers.CtrlOrMeta | shortcut.Modifiers.Alt),
shortcut.makeDescriptor("]", shortcut.Modifiers.CtrlOrMeta | shortcut.Modifiers.Alt)
];
@@ -700,6 +700,12 @@
var goToShortcut = WebInspector.GoToLineDialog.createShortcut();
section.addKey(goToShortcut, WebInspector.UIString("Go to line"));
+
+keys = [
+shortcut.Keys.F1,
+shortcut.makeDescriptor("?")
+];
+section.addAlternateKeys(keys, WebInspector.UIString("Show keyboard shortcuts"));
}
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [146057] trunk/Source/WebCore
Title: [146057] trunk/Source/WebCore
Revision 146057
Author eus...@chromium.org
Date 2013-03-18 05:52:47 -0700 (Mon, 18 Mar 2013)
Log Message
Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402
Reviewed by Alexander Pavlov.
When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.
If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.
With this patch the "no notification" scenario is fixed:
duplicate items are removed.
Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.
* inspector/front-end/DOMStorageItemsView.js:
Added workarounds for "no notification" and "useless notification".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DOMStorageItemsView.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (146056 => 146057)
--- trunk/Source/WebCore/ChangeLog 2013-03-18 11:59:18 UTC (rev 146056)
+++ trunk/Source/WebCore/ChangeLog 2013-03-18 12:52:47 UTC (rev 146057)
@@ -1,3 +1,27 @@
+2013-03-18 Eugene Klyuchnikov
+
+Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
+https://bugs.webkit.org/show_bug.cgi?id=112402
+
+Reviewed by Alexander Pavlov.
+
+When user creates new items or renames existing one some existing item
+may be overriden. If value is changed, then frontend will receive
+notification and update record appropriately.
+
+If item value hasn't been changed, then no notification comes.
+But UI still expect / rely on this notification.
+
+With this patch the "no notification" scenario is fixed:
+duplicate items are removed.
+
+Another scenario is when update notification comes when we started
+editing value (after entering / renaming key). In this case
+selected node should not be changed to leave user in editing mode.
+
+* inspector/front-end/DOMStorageItemsView.js:
+Added workarounds for "no notification" and "useless notification".
+
2013-03-18 Allan Sandfeld Jensen
Clean up RenderFrameSet::nodeAtPoint
Modified: trunk/Source/WebCore/inspector/front-end/DOMStorageItemsView.js (146056 => 146057)
--- trunk/Source/WebCore/inspector/front-end/DOMStorageItemsView.js 2013-03-18 11:59:18 UTC (rev 146056)
+++ trunk/Source/WebCore/inspector/front-end/DOMStorageItemsView.js 2013-03-18 12:52:47 UTC (rev 146057)
@@ -151,10 +151,12 @@
return;
}
keyFound = true;
-childNode.data.value = storageData.newValue;
-childNode.refresh();
-childNode.select();
-childNode.reveal();
+if (childNode.data.value !== storageData.newValue) {
+childNode.data.value = storageData.newValue;
+childNode.refresh();
+childNode.select();
+childNode.reveal();
+}
this.deleteButton.visible = true;
}
}
@@ -227,12 +229,26 @@
if ("key" === columnIdentifier) {
if (oldText)
domStorage.removeItem(oldText);
-
domStorage.setItem(newText, editingNode.data.value);
+this._removeDupes(editingNode);
} else
domStorage.setItem(editingNode.data.key, newText);
},
+/**
+ * @param {!WebInspector.DataGridNode} masterNode
+ */
+_removeDupes: function(masterNode)
+{
+var rootNode = this._dataGrid.rootNode();
+var children = rootNode.children;
+for (var i = children.length - 1; i >= 0; --i) {
+var childNode = children[i];
+if ((childNode.data.key === masterNode.data.key) && (masterNode !== childNode))
+rootNode.removeChild(childNode);
+}
+},
+
_deleteCallback: function(node)
{
if (!node || node.isCreationNode)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145926] trunk/Source/WebCore
Title: [145926] trunk/Source/WebCore
Revision 145926
Author eus...@chromium.org
Date 2013-03-15 11:47:18 -0700 (Fri, 15 Mar 2013)
Log Message
Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
https://bugs.webkit.org/show_bug.cgi?id=112412
Reviewed by Vsevolod Vlasov.
Return types for some members are confusing (Object).
* inspector/front-end/NetworkManager.js: Fixed JSDocs.
* inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145925 => 145926)
--- trunk/Source/WebCore/ChangeLog 2013-03-15 18:43:51 UTC (rev 145925)
+++ trunk/Source/WebCore/ChangeLog 2013-03-15 18:47:18 UTC (rev 145926)
@@ -1,3 +1,15 @@
+2013-03-15 Eugene Klyuchnikov
+
+Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
+https://bugs.webkit.org/show_bug.cgi?id=112412
+
+Reviewed by Vsevolod Vlasov.
+
+Return types for some members are confusing (Object).
+
+* inspector/front-end/NetworkManager.js: Fixed JSDocs.
+* inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.
+
2013-03-15 Andy Estes
REGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
Modified: trunk/Source/WebCore/inspector/front-end/NetworkManager.js (145925 => 145926)
--- trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2013-03-15 18:43:51 UTC (rev 145925)
+++ trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2013-03-15 18:47:18 UTC (rev 145926)
@@ -125,7 +125,7 @@
WebInspector.NetworkDispatcher.prototype = {
/**
* @param {NetworkAgent.Headers} headersMap
- * @return {Array.}
+ * @return {!Array.}
*/
_headersMapToHeadersArray: function(headersMap)
{
@@ -133,7 +133,7 @@
for (var name in headersMap) {
var values = headersMap[name].split("\n");
for (var i = 0; i < values.length; ++i)
-result.push({ name: name, value: values[i] });
+result.push({name: name, value: values[i]});
}
return result;
},
Modified: trunk/Source/WebCore/inspector/front-end/NetworkRequest.js (145925 => 145926)
--- trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-03-15 18:43:51 UTC (rev 145925)
+++ trunk/Source/WebCore/inspector/front-end/NetworkRequest.js 2013-03-15 18:47:18 UTC (rev 145926)
@@ -73,6 +73,9 @@
Other: "other",
}
+/** @typedef {{name: string, value: string}} */
+WebInspector.NetworkRequest.NameValue;
+
WebInspector.NetworkRequest.prototype = {
/**
* @return {NetworkAgent.RequestId}
@@ -453,7 +456,7 @@
},
/**
- * @return {Array.}
+ * @return {!Array.}
*/
get requestHeaders()
{
@@ -498,7 +501,7 @@
},
/**
- * @return {Array.}
+ * @return {!Array.}
*/
get sortedRequestHeaders()
{
@@ -555,7 +558,7 @@
},
/**
- * @return {Array.}
+ * @return {!Array.}
*/
get responseHeaders()
{
@@ -600,16 +603,16 @@
},
/**
- * @return {Array.}
+ * @return {!Array.}
*/
get sortedResponseHeaders()
{
if (this._sortedResponseHeaders !== undefined)
return this._sortedResponseHeaders;
-
+
this._sortedResponseHeaders = [];
this._sortedResponseHeaders = this.responseHeaders.slice();
-this._sortedResponseHeaders.sort(function(a,b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()) });
+this._sortedResponseHeaders.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()); });
return this._sortedResponseHeaders;
},
@@ -647,7 +650,7 @@
},
/**
- * @return {?Array.}
+ * @return {?Array.}
*/
get queryParameters()
{
@@ -661,7 +664,7 @@
},
/**
- * @return {?Array.}
+ * @return {?Array.}
*/
get formParameters()
{
@@ -687,34 +690,27 @@
/**
* @param {string} queryString
- * @return {Array.}
+ * @return {!Array.}
*/
_parseParameters: function(queryString)
{
function parseNameValue(pair)
{
-var parameter = {};
var splitPair = pair.split("=", 2);
-
-parameter.name = splitPair[0];
-if (splitPair.length === 1)
-parameter.value = "";
-else
-parameter.value = splitPair[1];
-return parameter;
+return {name: splitPair[0], value: splitPair[1] || ""};
}
return queryString.split("&").map(parseNameValue);
},
/**
- * @param {Object} headers
+ * @param {!Array.} headers
* @param {string} headerName
* @return {string|undefined}
*/
_headerValu
[webkit-changes] [145891] trunk/Source/WebCore
Title: [145891] trunk/Source/WebCore
Revision 145891
Author eus...@chromium.org
Date 2013-03-15 03:18:51 -0700 (Fri, 15 Mar 2013)
Log Message
Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
https://bugs.webkit.org/show_bug.cgi?id=112341
Reviewed by Vsevolod Vlasov.
When both objects do not have initiator: f(a, b) = f(b, a) = -1
Furthermore: redirected responses are mixed with "other".
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Remember "displayed" initiator type.
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Recall "diaplayed" initiator type for more precise comparison.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145890 => 145891)
--- trunk/Source/WebCore/ChangeLog 2013-03-15 10:17:14 UTC (rev 145890)
+++ trunk/Source/WebCore/ChangeLog 2013-03-15 10:18:51 UTC (rev 145891)
@@ -1,3 +1,19 @@
+2013-03-15 Eugene Klyuchnikov
+
+Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
+https://bugs.webkit.org/show_bug.cgi?id=112341
+
+Reviewed by Vsevolod Vlasov.
+
+When both objects do not have initiator: f(a, b) = f(b, a) = -1
+Furthermore: redirected responses are mixed with "other".
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
+Remember "displayed" initiator type.
+(WebInspector.NetworkDataGridNode.InitiatorComparator):
+Recall "diaplayed" initiator type for more precise comparison.
+
2013-03-15 Andrey Kosyakov
Web Inspector: show image decode performed off main thread on timeline
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (145890 => 145891)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-03-15 10:17:14 UTC (rev 145890)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-03-15 10:18:51 UTC (rev 145891)
@@ -2235,8 +2235,9 @@
this._initiatorCell.removeStyleClass("network-script-initiated");
delete this._initiatorCell.request;
this._initiatorCell.title = "";
-delete this._displayedInitiatorURL;
-delete this._displayedInitiatorLineNumber;
+this._displayedInitiatorURL = "";
+this._displayedInitiatorLineNumber = -Infinity;
+this._displayedInitiatorType = "";
var initiator = this._request.initiator;
var initiatorTypes = WebInspector.NetworkRequest.InitiatorType;
@@ -2246,20 +2247,23 @@
if (redirectSource) {
this._initiatorCell.title = redirectSource.url;
this._initiatorCell.appendChild(WebInspector.linkifyRequestAsNode(redirectSource));
-this._appendSubtitle(this._initiatorCell, WebInspector.UIString("Redirect"));
+this._displayedInitiatorType = WebInspector.UIString("Redirect");
+this._appendSubtitle(this._initiatorCell, this._displayedInitiatorType);
this._displayedInitiatorURL = redirectSource.url;
} else if (initiator.type === initiatorTypes.Script) {
var topFrame = initiator.stackTrace[0];
// This could happen when request loading was triggered by console.
if (!topFrame.url) {
this._initiatorCell.addStyleClass("network-dim-cell");
-this._initiatorCell.setTextAndTitle(WebInspector.UIString("Other"));
+this._displayedInitiatorType = WebInspector.UIString("Other");
+this._initiatorCell.setTextAndTitle(this._displayedInitiatorType);
return;
}
var urlElement = this._parentView._linkifier.linkifyLocation(topFrame.url, topFrame.lineNumber - 1, 0);
urlElement.title = "";
this._initiatorCell.appendChild(urlElement);
-this._appendSubtitle(this._initiatorCell, WebInspector.UIString("Script"));
+this._displayedInitiatorType = WebInspector.UIString("Script");
+this._appendSubtitle(this._initiatorCell, this._displayedInitiatorType);
this._initiatorCell.addStyleClass("network-script-initiated");
this._initiatorCell.request = this._request;
this._displayedInitiatorURL = WebInspector.displayNameForURL(topFrame.url);
@@ -2267,13 +2271,15 @@
} else { // initiator.type === initiatorTypes.Parser
this._initiatorCell.title = initiator.url + ":" + initiator.lineNumber;
this._initiatorCell.appendChild(WebInspector.linkifyResourceAsNode(initiator.url, initiator.lineNumber - 1));
-this._appendSubtitle(this._initiatorCell, WebInspector.UIString("Parser"));
+this._displayedIni
[webkit-changes] [145886] trunk/Source/WebCore
Title: [145886] trunk/Source/WebCore
Revision 145886
Author eus...@chromium.org
Date 2013-03-15 01:28:39 -0700 (Fri, 15 Mar 2013)
Log Message
Web Inspector: [Network] Sort columns context menu items alphabetically.
https://bugs.webkit.org/show_bug.cgi?id=112321
Reviewed by Pavel Feldman.
Problem: columns are presented in "natural" order,
so it is hard to find specific item.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
Generate list of column IDs sorted alphabetically.
(WebInspector.NetworkLogView.prototype._contextMenu):
Use alphabetically sorted list of column IDs.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145885 => 145886)
--- trunk/Source/WebCore/ChangeLog 2013-03-15 08:24:19 UTC (rev 145885)
+++ trunk/Source/WebCore/ChangeLog 2013-03-15 08:28:39 UTC (rev 145886)
@@ -1,3 +1,19 @@
+2013-03-13 Eugene Klyuchnikov
+
+Web Inspector: [Network] Sort columns context menu items alphabetically.
+https://bugs.webkit.org/show_bug.cgi?id=112321
+
+Reviewed by Pavel Feldman.
+
+Problem: columns are presented in "natural" order,
+so it is hard to find specific item.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
+Generate list of column IDs sorted alphabetically.
+(WebInspector.NetworkLogView.prototype._contextMenu):
+Use alphabetically sorted list of column IDs.
+
2013-03-15 Takashi Sakamoto
Crash at RenderStyle::inheritFrom reported by fuzzer
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (145885 => 145886)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-03-15 08:24:19 UTC (rev 145885)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-03-15 08:28:39 UTC (rev 145886)
@@ -161,7 +161,7 @@
columns.push({
id: "name",
titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Name"), WebInspector.UIString("Path")),
-name: WebInspector.UIString("Name"),
+title: WebInspector.UIString("Name"),
sortable: true,
weight: 20,
disclosure: true
@@ -177,7 +177,7 @@
columns.push({
id: "status",
titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Status"), WebInspector.UIString("Text")),
-name: WebInspector.UIString("Status"),
+title: WebInspector.UIString("Status"),
sortable: true,
weight: 6
});
@@ -222,7 +222,7 @@
columns.push({
id: "size",
titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Content")),
-name: WebInspector.UIString("Size"),
+title: WebInspector.UIString("Size"),
sortable: true,
weight: 6,
aligned: "right"
@@ -231,7 +231,7 @@
columns.push({
id: "time",
titleDOMFragment: this._makeHeaderFragment(WebInspector.UIString("Time"), WebInspector.UIString("Latency")),
-name: WebInspector.UIString("Time"),
+title: WebInspector.UIString("Time"),
sortable: true,
weight: 6,
aligned: "right"
@@ -239,8 +239,8 @@
columns.push({
id: "timeline",
-title: "",
-name: WebInspector.UIString("Timeline"),
+titleDOMFragment: document.createDocumentFragment(),
+title: WebInspector.UIString("Timeline"),
sortable: false,
weight: 40,
sort: "ascending"
@@ -1014,15 +1014,36 @@
this._updateColumns();
},
+/**
+ * @return {!Array.}
+ */
+_getConfigurableColumnIDs: function()
+{
+if (this._configurableColumnIDs)
+return this._configurableColumnIDs;
+
+var columns = this._dataGrid.columns;
+function compare(id1, id2)
+{
+return columns[id1].title.compareTo(columns[id2].title);
+}
+
+var columnIDs = Object.keys(this._coulmnsVisibilitySetting.get());
+this._configurableColumnIDs = columnIDs.sort(compare);
+return this._configurableColumnIDs;
+},
+
_contextMenu: function(event)
{
var contextMenu = new WebInspector.ContextMenu(event);
if (this._detailedMode && event.target.isSelfOrDescendant(this._dataGrid.headerTableBody)) {
var columnsVisibility = this._coulmnsVisibilitySetting.get();
-for (var columnIdentifier in columnsVisibility) {
+var columnIDs = this._getConfigurableColumnIDs();
+for (var i = 0; i < columnIDs.length; ++i) {
+var columnIdentifier = columnIDs[i];
[webkit-changes] [145548] trunk/Source/WebCore
Title: [145548] trunk/Source/WebCore
Revision 145548
Author eus...@chromium.org
Date 2013-03-12 08:19:37 -0700 (Tue, 12 Mar 2013)
Log Message
Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state
https://bugs.webkit.org/show_bug.cgi?id=112113
Reviewed by Alexander Pavlov.
Updated handlers missed in first patch. Added JSDocs to all handlers.
* inspector/front-end/Panel.js: Fixed JSDocs.
* inspector/front-end/CallStackSidebarPane.js:
Added return values. Added JSDocs.
* inspector/front-end/ScriptsPanel.js: Ditto.
* inspector/front-end/GoToLineDialog.js: Added JSDocs.
* inspector/front-end/TimelinePanel.js: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js
trunk/Source/WebCore/inspector/front-end/Panel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145547 => 145548)
--- trunk/Source/WebCore/ChangeLog 2013-03-12 15:17:58 UTC (rev 145547)
+++ trunk/Source/WebCore/ChangeLog 2013-03-12 15:19:37 UTC (rev 145548)
@@ -1,3 +1,19 @@
+2013-03-12 Eugene Klyuchnikov
+
+Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state
+https://bugs.webkit.org/show_bug.cgi?id=112113
+
+Reviewed by Alexander Pavlov.
+
+Updated handlers missed in first patch. Added JSDocs to all handlers.
+
+* inspector/front-end/Panel.js: Fixed JSDocs.
+* inspector/front-end/CallStackSidebarPane.js:
+Added return values. Added JSDocs.
+* inspector/front-end/ScriptsPanel.js: Ditto.
+* inspector/front-end/GoToLineDialog.js: Added JSDocs.
+* inspector/front-end/TimelinePanel.js: Ditto.
+
2013-03-12 Alberto Garcia
[BlackBerry] DisplayRefreshMonitor: rename m_timestamp back to m_monotonicAnimationStartTime
Modified: trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js (145547 => 145548)
--- trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-03-12 15:17:58 UTC (rev 145547)
+++ trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js 2013-03-12 15:19:37 UTC (rev 145548)
@@ -68,22 +68,35 @@
}
},
-_selectNextCallFrameOnStack: function()
+/**
+ * @param {Event=} event
+ * @return {boolean}
+ */
+_selectNextCallFrameOnStack: function(event)
{
var index = this._selectedCallFrameIndex();
if (index == -1)
-return;
+return true;
this._selectedPlacardByIndex(index + 1);
+return true;
},
-_selectPreviousCallFrameOnStack: function()
+/**
+ * @param {Event=} event
+ * @return {boolean}
+ */
+_selectPreviousCallFrameOnStack: function(event)
{
var index = this._selectedCallFrameIndex();
if (index == -1)
-return;
+return true;
this._selectedPlacardByIndex(index - 1);
+return true;
},
+/**
+ * @param {number} index
+ */
_selectedPlacardByIndex: function(index)
{
if (index < 0 || index >= this.placards.length)
@@ -91,6 +104,9 @@
this._placardSelected(this.placards[index])
},
+/**
+ * @return {number}
+ */
_selectedCallFrameIndex: function()
{
if (!this._model.selectedCallFrame())
@@ -117,7 +133,7 @@
},
/**
- * @param {function(!Array., function(KeyboardEvent))} registerShortcutDelegate
+ * @param {function(!Array., function(Event=):boolean)} registerShortcutDelegate
*/
registerShortcuts: function(registerShortcutDelegate)
{
Modified: trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js (145547 => 145548)
--- trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js 2013-03-12 15:17:58 UTC (rev 145547)
+++ trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js 2013-03-12 15:19:37 UTC (rev 145548)
@@ -64,9 +64,10 @@
/**
* @param {function():?WebInspector.View} viewGetter
+ * @param {Event=} event
* @return {boolean}
*/
-WebInspector.GoToLineDialog._show = function(viewGetter)
+WebInspector.GoToLineDialog._show = function(viewGetter, event)
{
var sourceView = viewGetter();
if (!sourceView || !sourceView.canHighlightLine())
Modified: trunk/Source/WebCore/inspector/front-end/Panel.js (145547 => 145548)
--- trunk/Source/WebCore/inspector/front-end/Panel.js 2013-03-12 15:17:58 UTC (rev 145547)
+++ trunk/Source/WebCore/inspector/front-end/Panel.js 2013-03-12 15:19:37 UTC (rev 145548)
@@ -39,7 +39,7 @@
this.element.addStyleClass(name);
this._panelName = name;
-this._shortcuts = {};
+this._shortcuts = /** !Object. */ ({});
WebInspector.settings[this._sidebarWidthSettingName()] = WebI
[webkit-changes] [145537] trunk/Source/WebCore
Title: [145537] trunk/Source/WebCore
Revision 145537
Author eus...@chromium.org
Date 2013-03-12 05:45:30 -0700 (Tue, 12 Mar 2013)
Log Message
Web Inspector: Fix JSDocs in TimelinePanel.js
https://bugs.webkit.org/show_bug.cgi?id=112137
Reviewed by Vsevolod Vlasov.
Fix parameter type annotation of _loadFromFile.
* inspector/front-end/TimelinePanel.js: Fixed JSDoc.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145536 => 145537)
--- trunk/Source/WebCore/ChangeLog 2013-03-12 12:42:14 UTC (rev 145536)
+++ trunk/Source/WebCore/ChangeLog 2013-03-12 12:45:30 UTC (rev 145537)
@@ -1,3 +1,14 @@
+2013-03-12 Eugene Klyuchnikov
+
+Web Inspector: Fix JSDocs in TimelinePanel.js
+https://bugs.webkit.org/show_bug.cgi?id=112137
+
+Reviewed by Vsevolod Vlasov.
+
+Fix parameter type annotation of _loadFromFile.
+
+* inspector/front-end/TimelinePanel.js: Fixed JSDoc.
+
2013-03-12 Vsevolod Vlasov
Web Inspector: Add a test for Workspace add/removeMapping methods.
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (145536 => 145537)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 12:42:14 UTC (rev 145536)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 12:45:30 UTC (rev 145537)
@@ -374,14 +374,14 @@
},
/**
- * @param {string} fileName
+ * @param {!File} file
*/
-_loadFromFile: function(fileName)
+_loadFromFile: function(file)
{
var progressIndicator = this._prepareToLoadTimeline();
if (!progressIndicator)
return;
-this._model.loadFromFile(fileName, progressIndicator);
+this._model.loadFromFile(file, progressIndicator);
this._createFileSelector();
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145496] trunk/Source/WebCore
Title: [145496] trunk/Source/WebCore
Revision 145496
Author eus...@chromium.org
Date 2013-03-12 00:59:18 -0700 (Tue, 12 Mar 2013)
Log Message
Web Inspector: [Timeline] File selector control becomes visible on "tab" navigation.
https://bugs.webkit.org/show_bug.cgi?id=111710
Reviewed by Pavel Feldman.
Solution: Exclude file selector control from tab-navigation flow.
* inspector/front-end/FileUtils.js: Set tab-index to control.
* inspector/front-end/TimelinePanel.js: Remove duplicating code.
* inspector/front-end/inspector.css:
(.status-bar-item): Make scroll height equal to offset height.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FileUtils.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (145495 => 145496)
--- trunk/Source/WebCore/ChangeLog 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/ChangeLog 2013-03-12 07:59:18 UTC (rev 145496)
@@ -1,3 +1,17 @@
+2013-03-12 Eugene Klyuchnikov
+
+Web Inspector: [Timeline] File selector control becomes visible on "tab" navigation.
+https://bugs.webkit.org/show_bug.cgi?id=111710
+
+Reviewed by Pavel Feldman.
+
+Solution: Exclude file selector control from tab-navigation flow.
+
+* inspector/front-end/FileUtils.js: Set tab-index to control.
+* inspector/front-end/TimelinePanel.js: Remove duplicating code.
+* inspector/front-end/inspector.css:
+(.status-bar-item): Make scroll height equal to offset height.
+
2013-03-12 Marja Hölttä
[V8] Get rid of function-level static FunctionTemplates in generated bindings code
Modified: trunk/Source/WebCore/inspector/front-end/FileUtils.js (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/FileUtils.js 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/FileUtils.js 2013-03-12 07:59:18 UTC (rev 145496)
@@ -301,6 +301,7 @@
WebInspector.createFileSelectorElement = function(callback) {
var fileSelectorElement = document.createElement("input");
fileSelectorElement.type = "file";
+fileSelectorElement.setAttribute("tabindex", -1);
fileSelectorElement.style.zIndex = -1;
fileSelectorElement.style.position = "absolute";
fileSelectorElement._onchange_ = function(event) {
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 07:59:18 UTC (rev 145496)
@@ -352,13 +352,8 @@
if (this._fileSelectorElement)
this.element.removeChild(this._fileSelectorElement);
-var fileSelectorElement = document.createElement("input");
-fileSelectorElement.type = "file";
-fileSelectorElement.style.zIndex = -1;
-fileSelectorElement.style.position = "absolute";
-fileSelectorElement._onchange_ = this._loadFromFile.bind(this);
-this.element.appendChild(fileSelectorElement);
-this._fileSelectorElement = fileSelectorElement;
+this._fileSelectorElement = WebInspector.createFileSelectorElement(this._loadFromFile.bind(this));
+this.element.appendChild(this._fileSelectorElement);
},
_contextMenu: function(event)
@@ -378,12 +373,15 @@
return true;
},
-_loadFromFile: function()
+/**
+ * @param {string} fileName
+ */
+_loadFromFile: function(fileName)
{
var progressIndicator = this._prepareToLoadTimeline();
if (!progressIndicator)
return;
-this._model.loadFromFile(this._fileSelectorElement.files[0], progressIndicator);
+this._model.loadFromFile(fileName, progressIndicator);
this._createFileSelector();
},
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2013-03-12 07:59:18 UTC (rev 145496)
@@ -624,7 +624,7 @@
display: inline-block;
pointer-events: auto;
cursor: default;
-height: 24px;
+height: 22px;
padding: 0;
margin-left: -1px;
margin-right: 0;
@@ -769,7 +769,6 @@
margin-right: -15px;
position: relative;
top: -1px;
-height: 23px;
}
select.status-bar-item, select.status-bar-item:hover {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145054] trunk/Source/WebCore
Title: [145054] trunk/Source/WebCore
Revision 145054
Author eus...@chromium.org
Date 2013-03-07 01:49:44 -0800 (Thu, 07 Mar 2013)
Log Message
Web Inspector: Refactorings: Prepare SuggestBox for reuse.
https://bugs.webkit.org/show_bug.cgi?id=111301
Reviewed by Alexander Pavlov.
1) Remove userEnteredText from delegate interface.
Pass prefix to updateSuggestions instead.
2) Clarify that suggestions array is never null.
* inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox): Renamed parameter/member.
(WebInspector.SuggestBox.prototype._updateItems):
Minor readability changes.
(WebInspector.SuggestBox.prototype._canShowBox):
Use userEnteredText parameter.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Pass userEnteredText to _canShowBox.
* inspector/front-end/DatabaseQueryView.js: Fix JSDocs.
* inspector/front-end/RuntimeModel.js: Ditto.
* inspector/front-end/TextPrompt.js: Ditto.
(WebInspector.TextPrompt.prototype._completionsReady):
Pass userEnteredText to updateSuggestions.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js
trunk/Source/WebCore/inspector/front-end/RuntimeModel.js
trunk/Source/WebCore/inspector/front-end/SuggestBox.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145053 => 145054)
--- trunk/Source/WebCore/ChangeLog 2013-03-07 09:29:10 UTC (rev 145053)
+++ trunk/Source/WebCore/ChangeLog 2013-03-07 09:49:44 UTC (rev 145054)
@@ -1,3 +1,28 @@
+2013-03-07 Eugene Klyuchnikov
+
+Web Inspector: Refactorings: Prepare SuggestBox for reuse.
+https://bugs.webkit.org/show_bug.cgi?id=111301
+
+Reviewed by Alexander Pavlov.
+
+1) Remove userEnteredText from delegate interface.
+ Pass prefix to updateSuggestions instead.
+2) Clarify that suggestions array is never null.
+
+* inspector/front-end/SuggestBox.js:
+(WebInspector.SuggestBox): Renamed parameter/member.
+(WebInspector.SuggestBox.prototype._updateItems):
+Minor readability changes.
+(WebInspector.SuggestBox.prototype._canShowBox):
+Use userEnteredText parameter.
+(WebInspector.SuggestBox.prototype.updateSuggestions):
+Pass userEnteredText to _canShowBox.
+* inspector/front-end/DatabaseQueryView.js: Fix JSDocs.
+* inspector/front-end/RuntimeModel.js: Ditto.
+* inspector/front-end/TextPrompt.js: Ditto.
+(WebInspector.TextPrompt.prototype._completionsReady):
+Pass userEnteredText to updateSuggestions.
+
2013-03-07 Victor Carbune
TextTrackRegion Constructor
Modified: trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js (145053 => 145054)
--- trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js 2013-03-07 09:29:10 UTC (rev 145053)
+++ trunk/Source/WebCore/inspector/front-end/DatabaseQueryView.js 2013-03-07 09:49:44 UTC (rev 145054)
@@ -65,7 +65,7 @@
* @param {Element} proxyElement
* @param {Range} wordRange
* @param {boolean} force
- * @param {function(Array., number=)} completionsReadyCallback
+ * @param {function(!Array., number=)} completionsReadyCallback
*/
completions: function(proxyElement, wordRange, force, completionsReadyCallback)
{
Modified: trunk/Source/WebCore/inspector/front-end/RuntimeModel.js (145053 => 145054)
--- trunk/Source/WebCore/inspector/front-end/RuntimeModel.js 2013-03-07 09:29:10 UTC (rev 145053)
+++ trunk/Source/WebCore/inspector/front-end/RuntimeModel.js 2013-03-07 09:49:44 UTC (rev 145054)
@@ -169,7 +169,7 @@
* @param {Element} proxyElement
* @param {Range} wordRange
* @param {boolean} force
- * @param {function(Array., number=)} completionsReadyCallback
+ * @param {function(!Array., number=)} completionsReadyCallback
*/
completionsForTextPrompt: function(proxyElement, wordRange, force, completionsReadyCallback)
{
@@ -184,7 +184,7 @@
* @param {string} expressionString
* @param {string} prefix
* @param {boolean} force
- * @param {function(Array., number=)} completionsReadyCallback
+ * @param {function(!Array., number=)} completionsReadyCallback
*/
_completionsForExpression: function(expressionString, prefix, force, completionsReadyCallback)
{
@@ -276,7 +276,7 @@
},
/**
- * @param {function(Array., number=)} completionsReadyCallback
+ * @param {function(!Array., number=)} completionsReadyCallback
* @param {boolean} dotNotation
* @param {boolean} bracketNotation
* @param {string} expressionString
Modified: trunk/Source/WebCore/inspector/front-end/SuggestBox.js (145053 => 145054)
--- trunk/Source/WebCore/inspector/front-end/SuggestBox.js 2013-03-07 09:29:10 UTC (rev 145053)
+++ trunk/Source/WebCore/inspector/front-end/SuggestBox.js 2013-03-07 09:49:44 UTC (rev 145054)
@@ -46,23 +46,18 @@
* acceptSuggestion will be alwa
[webkit-changes] [145045] trunk/Source/WebCore
Title: [145045] trunk/Source/WebCore
Revision 145045
Author eus...@chromium.org
Date 2013-03-07 00:08:58 -0800 (Thu, 07 Mar 2013)
Log Message
Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
https://bugs.webkit.org/show_bug.cgi?id=111357
Reviewed by Pavel Feldman.
Allow panel shortcut handlers to bubble event.
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.install): Minor refactoring, added JSDocs.
(WebInspector.GoToLineDialog._show): Added JSDocs and return value.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.handleShortcut):
Mark event as handled iff handler returned true.
* inspector/front-end/ScriptsPanel.js: Added return values to handlers.
* inspector/front-end/TimelinePanel.js: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js
trunk/Source/WebCore/inspector/front-end/Panel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (145044 => 145045)
--- trunk/Source/WebCore/ChangeLog 2013-03-07 07:52:44 UTC (rev 145044)
+++ trunk/Source/WebCore/ChangeLog 2013-03-07 08:08:58 UTC (rev 145045)
@@ -1,3 +1,21 @@
+2013-03-07 Eugene Klyuchnikov
+
+Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
+https://bugs.webkit.org/show_bug.cgi?id=111357
+
+Reviewed by Pavel Feldman.
+
+Allow panel shortcut handlers to bubble event.
+
+* inspector/front-end/GoToLineDialog.js:
+(WebInspector.GoToLineDialog.install): Minor refactoring, added JSDocs.
+(WebInspector.GoToLineDialog._show): Added JSDocs and return value.
+* inspector/front-end/Panel.js:
+(WebInspector.Panel.prototype.handleShortcut):
+Mark event as handled iff handler returned true.
+* inspector/front-end/ScriptsPanel.js: Added return values to handlers.
+* inspector/front-end/TimelinePanel.js: Ditto.
+
2013-03-06 Takashi Sakamoto
Box-shadow displayed improperly with border-radius.
Modified: trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js (145044 => 145045)
--- trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js 2013-03-07 07:52:44 UTC (rev 145044)
+++ trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js 2013-03-07 08:08:58 UTC (rev 145045)
@@ -54,25 +54,25 @@
/**
* @param {WebInspector.Panel} panel
+ * @param {function():?WebInspector.View} viewGetter
*/
WebInspector.GoToLineDialog.install = function(panel, viewGetter)
{
-function showGoToLineDialog()
-{
- var view = viewGetter();
- if (view)
- WebInspector.GoToLineDialog._show(view);
-}
-
var goToLineShortcut = WebInspector.GoToLineDialog.createShortcut();
-panel.registerShortcuts([goToLineShortcut], showGoToLineDialog);
+panel.registerShortcuts([goToLineShortcut], WebInspector.GoToLineDialog._show.bind(null, viewGetter));
}
-WebInspector.GoToLineDialog._show = function(sourceView)
+/**
+ * @param {function():?WebInspector.View} viewGetter
+ * @return {boolean}
+ */
+WebInspector.GoToLineDialog._show = function(viewGetter)
{
+var sourceView = viewGetter();
if (!sourceView || !sourceView.canHighlightLine())
-return;
+return false;
WebInspector.Dialog.show(sourceView.element, new WebInspector.GoToLineDialog(sourceView));
+return true;
}
/**
Modified: trunk/Source/WebCore/inspector/front-end/Panel.js (145044 => 145045)
--- trunk/Source/WebCore/inspector/front-end/Panel.js 2013-03-07 07:52:44 UTC (rev 145044)
+++ trunk/Source/WebCore/inspector/front-end/Panel.js 2013-03-07 08:08:58 UTC (rev 145045)
@@ -251,15 +251,13 @@
{
var shortcutKey = WebInspector.KeyboardShortcut.makeKeyFromEvent(event);
var handler = this._shortcuts[shortcutKey];
-if (handler) {
-handler(event);
+if (handler && handler(event))
event.handled = true;
-}
},
/**
* @param {!Array.} keys
- * @param {function(KeyboardEvent)} handler
+ * @param {function(KeyboardEvent):boolean} handler
*/
registerShortcuts: function(keys, handler)
{
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (145044 => 145045)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-03-07 07:52:44 UTC (rev 145044)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2013-03-07 08:08:58 UTC (rev 145045)
@@ -751,8 +751,10 @@
_evaluateSelectionInConsole: function()
{
var selection = window.getSelection();
-if (selection.type === "Range" && !selection.isCollapsed)
-WebInspector.evaluateInConsole(selection.toString());
+if (selection.type !== "Range" || selection.isCollapsed)
+return false;
+WebInspector.evaluateInConsole(selection.toString());
+return t
[webkit-changes] [144753] trunk/Source/WebCore
Title: [144753] trunk/Source/WebCore
Revision 144753
Author eus...@chromium.org
Date 2013-03-05 05:33:41 -0800 (Tue, 05 Mar 2013)
Log Message
Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=111427
Reviewed by Alexander Pavlov.
Goal: reflect in JSDoc that non-null array is passed to completionsReady callback.
* inspector/front-end/CSSMetadata.js:
Added JSDocs, avoided possible NPEs.
* inspector/front-end/StylesSidebarPane.js:
Fixed JSDocs, removed unused assignment.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSMetadata.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (144752 => 144753)
--- trunk/Source/WebCore/ChangeLog 2013-03-05 13:29:37 UTC (rev 144752)
+++ trunk/Source/WebCore/ChangeLog 2013-03-05 13:33:41 UTC (rev 144753)
@@ -1,3 +1,17 @@
+2013-03-05 Eugene Klyuchnikov
+
+Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs.
+https://bugs.webkit.org/show_bug.cgi?id=111427
+
+Reviewed by Alexander Pavlov.
+
+Goal: reflect in JSDoc that non-null array is passed to completionsReady callback.
+
+* inspector/front-end/CSSMetadata.js:
+Added JSDocs, avoided possible NPEs.
+* inspector/front-end/StylesSidebarPane.js:
+Fixed JSDocs, removed unused assignment.
+
2013-03-05 David Kilzer
BUILD FIX (r144727): Change type of columnRange and rowRange to pair
Modified: trunk/Source/WebCore/inspector/front-end/CSSMetadata.js (144752 => 144753)
--- trunk/Source/WebCore/inspector/front-end/CSSMetadata.js 2013-03-05 13:29:37 UTC (rev 144752)
+++ trunk/Source/WebCore/inspector/front-end/CSSMetadata.js 2013-03-05 13:33:41 UTC (rev 144753)
@@ -36,7 +36,7 @@
*/
WebInspector.CSSMetadata = function(properties)
{
-this._values = [];
+this._values = /** !Array. */ ([]);
this._longhands = {};
this._shorthands = {};
for (var i = 0; i < properties.length; ++i) {
@@ -67,9 +67,9 @@
}
/**
- * @type {WebInspector.CSSMetadata}
+ * @type {!WebInspector.CSSMetadata}
*/
-WebInspector.CSSMetadata.cssPropertiesMetainfo = null;
+WebInspector.CSSMetadata.cssPropertiesMetainfo = new WebInspector.CSSMetadata([]);
WebInspector.CSSMetadata.isColorAwareProperty = function(propertyName)
{
@@ -673,7 +673,7 @@
/**
* @param {string} propertyName
- * @return {WebInspector.CSSMetadata}
+ * @return {!WebInspector.CSSMetadata}
*/
WebInspector.CSSMetadata.keywordsForProperty = function(propertyName)
{
@@ -841,6 +841,10 @@
WebInspector.CSSMetadata.prototype = {
+/**
+ * @param {string} prefix
+ * @return {!Array.}
+ */
startsWith: function(prefix)
{
var firstIndex = this._firstIndexOfPrefix(prefix);
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (144752 => 144753)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2013-03-05 13:29:37 UTC (rev 144752)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2013-03-05 13:33:41 UTC (rev 144753)
@@ -2220,7 +2220,6 @@
if (!isEditingName) {
if (selectElement !== this.valueElement) {
// Click in the LI - start editing value.
-isEditingName = false;
selectElement = this.valueElement;
}
@@ -2647,9 +2646,11 @@
/**
* @constructor
* @extends {WebInspector.TextPrompt}
- * @param {function(*)=} acceptCallback
+ * @param {!WebInspector.CSSMetadata} cssCompletions
+ * @param {!WebInspector.StylePropertyTreeElement} sidebarPane
+ * @param {boolean} isEditingName
*/
-WebInspector.StylesSidebarPane.CSSPropertyPrompt = function(cssCompletions, sidebarPane, isEditingName, acceptCallback)
+WebInspector.StylesSidebarPane.CSSPropertyPrompt = function(cssCompletions, sidebarPane, isEditingName)
{
// Use the same callback both for applyItemCallback and acceptItemCallback.
WebInspector.TextPrompt.call(this, this._buildPropertyCompletions.bind(this), WebInspector.StyleValueDelimiters);
@@ -2721,7 +2722,7 @@
* @param {Element} proxyElement
* @param {Range} wordRange
* @param {boolean} force
- * @param {function(Array., number=)} completionsReadyCallback
+ * @param {function(!Array., number=)} completionsReadyCallback
*/
_buildPropertyCompletions: function(proxyElement, wordRange, force, completionsReadyCallback)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144722] trunk
Title: [144722] trunk
Revision 144722
Author eus...@chromium.org
Date 2013-03-04 22:12:18 -0800 (Mon, 04 Mar 2013)
Log Message
Web Inspector: Exceptions when WebInspector run in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=111326
Reviewed by Pavel Feldman.
Source/WebCore:
There is bug in commands code generation in InspectorBackend.js
As a consequence all protocol enums have wrong names and cause
exception when refererenced.
Currently protocol enums are referenced only from NetworkManager.
Test: inspector/inspector-backend-commands-generation.html
* inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
Use static method to generate code.
(InspectorBackendClass._generateCommands):
Extracted from loadFromJSONIfNeeded. Typo fixed.
LayoutTests:
Test runtime commands code generator output.
* inspector/inspector-backend-commands-generation-expected.txt: Added.
* inspector/inspector-backend-commands-generation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/InspectorBackend.js
Added Paths
trunk/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt
trunk/LayoutTests/inspector/inspector-backend-commands-generation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (144721 => 144722)
--- trunk/LayoutTests/ChangeLog 2013-03-05 06:09:40 UTC (rev 144721)
+++ trunk/LayoutTests/ChangeLog 2013-03-05 06:12:18 UTC (rev 144722)
@@ -1,3 +1,15 @@
+2013-03-04 Eugene Klyuchnikov
+
+Web Inspector: Exceptions when WebInspector run in hosted mode.
+https://bugs.webkit.org/show_bug.cgi?id=111326
+
+Reviewed by Pavel Feldman.
+
+Test runtime commands code generator output.
+
+* inspector/inspector-backend-commands-generation-expected.txt: Added.
+* inspector/inspector-backend-commands-generation.html: Added.
+
2013-03-04 Kinuko Yasuda
Rebaseline 4 virtual/softwarecompositing tests.
Added: trunk/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt (0 => 144722)
--- trunk/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/inspector-backend-commands-generation-expected.txt 2013-03-05 06:12:18 UTC (rev 144722)
@@ -0,0 +1,7 @@
+Tests correctness of code generated by InspectorBackend.
+
+InspectorBackend.registerEnum("Page.ResourceType", {Document: "Document", XHR: "XHR", ConsoleAPI: "console-api", Other: "other"});
+InspectorBackend.registerCommand("Page.addScriptToEvaluateOnLoad", [{"name": "scriptSource", "type": "string", "optional": false}], ["identifier"]);
+InspectorBackend.registerEvent("Page.domContentEventFired", ["timestamp"]);
+InspectorBackend.registerPageDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Page");
+
Added: trunk/LayoutTests/inspector/inspector-backend-commands-generation.html (0 => 144722)
--- trunk/LayoutTests/inspector/inspector-backend-commands-generation.html (rev 0)
+++ trunk/LayoutTests/inspector/inspector-backend-commands-generation.html 2013-03-05 06:12:18 UTC (rev 144722)
@@ -0,0 +1,40 @@
+
+
+
+
+function test()
+{
+var inspectorJson = {"domains": [{
+"domain": "Page",
+"types": [{
+"id": "ResourceType",
+"type": "string",
+"enum": ["Document", "XHR", "console-api", "other"]
+}],
+"commands": [{
+"name": "addScriptToEvaluateOnLoad",
+"parameters": [
+{"name": "scriptSource", "type": "string"}
+],
+"returns": [
+{"name": "identifier", "type": "string"}
+]
+}],
+"events": [{
+"name": "domContentEventFired",
+"parameters": [
+{"name": "timestamp", "type": "number"}
+]
+}]
+}]};
+var commands = InspectorBackendClass._generateCommands(inspectorJson);
+InspectorTest.addResult(commands);
+InspectorTest.completeTest();
+}
+
+
+
+Tests correctness of code generated by InspectorBackend.
+
+
Modified: trunk/Source/WebCore/ChangeLog (144721 => 144722)
--- trunk/Source/WebCore/ChangeLog 2013-03-05 06:09:40 UTC (rev 144721)
+++ trunk/Source/WebCore/ChangeLog 2013-03-05 06:12:18 UTC (rev 144722)
@@ -1,3 +1,24 @@
+2013-03-04 Eugene Klyuchnikov
+
+Web Inspector: Exceptions when WebInspector run in hosted mode.
+https://bugs.webkit.org/show_bug.cgi?id=111326
+
+Reviewed by Pavel Feldman.
+
+There is bug in commands code generation in InspectorBackend.js
+As a consequence all protocol enums have wrong names and cause
+exception when refererenced.
+
+Currently protocol enums are referenced only from NetworkManager.
+
+Test: inspector/inspector-backend-commands-generation.html
+
+* inspector/fro
[webkit-changes] [144718] branches/chromium/1410/Source/WebCore
Title: [144718] branches/chromium/1410/Source/WebCore
Revision 144718
Author eus...@chromium.org
Date 2013-03-04 21:31:10 -0800 (Mon, 04 Mar 2013)
Log Message
Merge 144437
> Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
> https://bugs.webkit.org/show_bug.cgi?id=111077
>
> Reviewed by Pavel Feldman.
>
> Analysis: DataGridNode.refresh removes all cells and then recreates them.
> The issue is that mandatory "corner" cell is not recreated.
>
> * inspector/front-end/DataGrid.js:
> (WebInspector.DataGridNode.prototype.refresh):
> Added "corner" cell restoration code.
>
TBR=eus...@chromium.org
Review URL: https://codereview.chromium.org/12414004
Modified Paths
branches/chromium/1410/Source/WebCore/ChangeLog
branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js
Diff
Modified: branches/chromium/1410/Source/WebCore/ChangeLog (144717 => 144718)
--- branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-05 05:27:04 UTC (rev 144717)
+++ branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-05 05:31:10 UTC (rev 144718)
@@ -1,3 +1,17 @@
+2013-03-01 Eugene Klyuchnikov
+
+Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
+https://bugs.webkit.org/show_bug.cgi?id=111077
+
+Reviewed by Pavel Feldman.
+
+Analysis: DataGridNode.refresh removes all cells and then recreates them.
+The issue is that mandatory "corner" cell is not recreated.
+
+* inspector/front-end/DataGrid.js:
+(WebInspector.DataGridNode.prototype.refresh):
+Added "corner" cell restoration code.
+
2013-02-27 Eugene Klyuchnikov
Web Inspector: timeline stops working on certain sites
Modified: branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js (144717 => 144718)
--- branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-05 05:27:04 UTC (rev 144717)
+++ branches/chromium/1410/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-05 05:31:10 UTC (rev 144718)
@@ -1256,6 +1256,7 @@
this._element.removeChildren();
this.createCells();
+this._element.createChild("td", "corner");
},
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144453] trunk/Source/WebCore
Title: [144453] trunk/Source/WebCore
Revision 144453
Author eus...@chromium.org
Date 2013-03-01 07:15:32 -0800 (Fri, 01 Mar 2013)
Log Message
Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
https://bugs.webkit.org/show_bug.cgi?id=108930
Reviewed by Pavel Feldman.
This feature will help developers to focus on events
that caused CPU bar.
* inspector/front-end/Popover.js: Added "arrowDirection" parameter.
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid): Added "curtains".
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
when mouse is over CPU bar.
* inspector/front-end/timelinePanel.css: Added "curtains" style rules.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Popover.js
trunk/Source/WebCore/inspector/front-end/TimelineGrid.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (144452 => 144453)
--- trunk/Source/WebCore/ChangeLog 2013-03-01 15:10:15 UTC (rev 144452)
+++ trunk/Source/WebCore/ChangeLog 2013-03-01 15:15:32 UTC (rev 144453)
@@ -1,3 +1,21 @@
+2013-03-01 Eugene Klyuchnikov
+
+Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
+https://bugs.webkit.org/show_bug.cgi?id=108930
+
+Reviewed by Pavel Feldman.
+
+This feature will help developers to focus on events
+that caused CPU bar.
+
+* inspector/front-end/Popover.js: Added "arrowDirection" parameter.
+* inspector/front-end/TimelineGrid.js:
+(WebInspector.TimelineGrid): Added "curtains".
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
+when mouse is over CPU bar.
+* inspector/front-end/timelinePanel.css: Added "curtains" style rules.
+
2013-03-01 Alexander Pavlov
Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
Modified: trunk/Source/WebCore/inspector/front-end/Popover.js (144452 => 144453)
--- trunk/Source/WebCore/inspector/front-end/Popover.js 2013-03-01 15:10:15 UTC (rev 144452)
+++ trunk/Source/WebCore/inspector/front-end/Popover.js 2013-03-01 15:15:32 UTC (rev 144453)
@@ -54,19 +54,20 @@
/**
* @param {Element} element
* @param {Element} anchor
- * @param {number=} preferredWidth
- * @param {number=} preferredHeight
+ * @param {?number=} preferredWidth
+ * @param {?number=} preferredHeight
+ * @param {?WebInspector.Popover.Orientation=} arrowDirection
*/
-show: function(element, anchor, preferredWidth, preferredHeight)
+show: function(element, anchor, preferredWidth, preferredHeight, arrowDirection)
{
-this._innerShow(null, element, anchor, preferredWidth, preferredHeight);
+this._innerShow(null, element, anchor, preferredWidth, preferredHeight, arrowDirection);
},
/**
* @param {WebInspector.View} view
* @param {Element} anchor
- * @param {number=} preferredWidth
- * @param {number=} preferredHeight
+ * @param {?number=} preferredWidth
+ * @param {?number=} preferredHeight
*/
showView: function(view, anchor, preferredWidth, preferredHeight)
{
@@ -77,10 +78,11 @@
* @param {WebInspector.View?} view
* @param {Element} contentElement
* @param {Element} anchor
- * @param {number=} preferredWidth
- * @param {number=} preferredHeight
+ * @param {?number=} preferredWidth
+ * @param {?number=} preferredHeight
+ * @param {?WebInspector.Popover.Orientation=} arrowDirection
*/
-_innerShow: function(view, contentElement, anchor, preferredWidth, preferredHeight)
+_innerShow: function(view, contentElement, anchor, preferredWidth, preferredHeight, arrowDirection)
{
if (this._disposed)
return;
@@ -103,7 +105,7 @@
else
this._contentDiv.appendChild(this.contentElement);
-this._positionElement(anchor, preferredWidth, preferredHeight);
+this._positionElement(anchor, preferredWidth, preferredHeight, arrowDirection);
if (this._popoverHelper) {
contentElement.addEventListener("mousemove", this._popoverHelper._killHidePopoverTimer.bind(this._popoverHelper), true);
@@ -135,7 +137,7 @@
this._contentDiv.addStyleClass("fixed-height");
},
-_positionElement: function(anchorElement, preferredWidth, preferredHeight)
+_positionElement: function(anchorElement, preferredWidth, preferredHeight, arrowDirection)
{
const borderWidth = 25;
const scrollerWidth = this._hasFixedHeight ? 0 : 11;
@@ -155,9 +157,9 @@
var roomAbove = anchorBox.y;
var roomBelow = totalHeight - anchorBox.y - anchorBox.height;
-if (roomAbove > room
[webkit-changes] [144439] trunk
Title: [144439] trunk
Revision 144439
Author eus...@chromium.org
Date 2013-03-01 04:04:24 -0800 (Fri, 01 Mar 2013)
Log Message
Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
https://bugs.webkit.org/show_bug.cgi?id=110819
Reviewed by Pavel Feldman.
To create event divider TimelinePresentation model checks if record
frame is main frame. With this patch check is moved to backend and
result is saved in record to avoid incoherence.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
Record "isMainFrame" flag.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createMarkData):
Added data object constructor.
* inspector/TimelineRecordFactory.h: Ditto.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.isEventDivider):
Use saved flag value instead of comparing with "current" main frame.
Modified Paths
trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Diff
Modified: trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt (144438 => 144439)
--- trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt 2013-03-01 12:01:57 UTC (rev 144438)
+++ trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt 2013-03-01 12:04:24 UTC (rev 144439)
@@ -5,6 +5,7 @@
{
counters :
data : {
+isMainFrame : true
}
frameId :
startTime :
Modified: trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt (144438 => 144439)
--- trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt 2013-03-01 12:01:57 UTC (rev 144438)
+++ trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt 2013-03-01 12:04:24 UTC (rev 144439)
@@ -5,6 +5,7 @@
{
counters :
data : {
+isMainFrame : true
}
frameId :
startTime :
Modified: trunk/Source/WebCore/ChangeLog (144438 => 144439)
--- trunk/Source/WebCore/ChangeLog 2013-03-01 12:01:57 UTC (rev 144438)
+++ trunk/Source/WebCore/ChangeLog 2013-03-01 12:04:24 UTC (rev 144439)
@@ -1,3 +1,26 @@
+2013-02-26 Eugene Klyuchnikov
+
+Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
+https://bugs.webkit.org/show_bug.cgi?id=110819
+
+Reviewed by Pavel Feldman.
+
+To create event divider TimelinePresentation model checks if record
+frame is main frame. With this patch check is moved to backend and
+result is saved in record to avoid incoherence.
+
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
+Record "isMainFrame" flag.
+(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.
+* inspector/TimelineRecordFactory.cpp:
+(WebCore::TimelineRecordFactory::createMarkData):
+Added data object constructor.
+* inspector/TimelineRecordFactory.h: Ditto.
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.isEventDivider):
+Use saved flag value instead of comparing with "current" main frame.
+
2013-03-01 Eugene Klyuchnikov
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (144438 => 144439)
--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2013-03-01 12:01:57 UTC (rev 144438)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2013-03-01 12:04:24 UTC (rev 144439)
@@ -465,12 +465,14 @@
void InspectorTimelineAgent::didMarkDOMContentEvent(Frame* frame)
{
-appendRecord(InspectorObject::create(), TimelineRecordType::MarkDOMContent, false, frame);
+bool isMainFrame = frame && m_pageAgent && (frame == m_pageAgent->mainFrame());
+appendRecord(TimelineRecordFactory::createMarkData(isMainFrame), TimelineRecordType::MarkDOMContent, false, frame);
}
void InspectorTimelineAgent::didMarkLoadEvent(Frame* frame)
{
-appendRecord(InspectorObject::create(), TimelineRecordType::MarkLoad, false, frame);
+bool isMainFrame = frame && m_pageAgent && (frame == m_pageAgent->mainFrame());
+appendRecord(TimelineRecordFactory::createMarkData(isMainFrame), TimelineRecordType::MarkLoad, false, frame);
}
void InspectorTimelineAgent::didCommitLoad()
Modified: trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp (144438 => 144439)
--- t
[webkit-changes] [144437] trunk/Source/WebCore
Title: [144437] trunk/Source/WebCore
Revision 144437
Author eus...@chromium.org
Date 2013-03-01 03:46:22 -0800 (Fri, 01 Mar 2013)
Log Message
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
https://bugs.webkit.org/show_bug.cgi?id=111077
Reviewed by Pavel Feldman.
Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.
* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DataGrid.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (144436 => 144437)
--- trunk/Source/WebCore/ChangeLog 2013-03-01 11:39:02 UTC (rev 144436)
+++ trunk/Source/WebCore/ChangeLog 2013-03-01 11:46:22 UTC (rev 144437)
@@ -1,3 +1,17 @@
+2013-03-01 Eugene Klyuchnikov
+
+Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
+https://bugs.webkit.org/show_bug.cgi?id=111077
+
+Reviewed by Pavel Feldman.
+
+Analysis: DataGridNode.refresh removes all cells and then recreates them.
+The issue is that mandatory "corner" cell is not recreated.
+
+* inspector/front-end/DataGrid.js:
+(WebInspector.DataGridNode.prototype.refresh):
+Added "corner" cell restoration code.
+
2013-02-28 Alexander Pavlov
Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (144436 => 144437)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-01 11:39:02 UTC (rev 144436)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-03-01 11:46:22 UTC (rev 144437)
@@ -1252,6 +1252,7 @@
this._element.removeChildren();
this.createCells();
+this._element.createChild("td", "corner");
},
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144418] branches/chromium/1410/Source/WebCore
Title: [144418] branches/chromium/1410/Source/WebCore
Revision 144418
Author eus...@chromium.org
Date 2013-02-28 22:23:57 -0800 (Thu, 28 Feb 2013)
Log Message
Merge 144161
> Web Inspector: timeline stops working on certain sites
> https://bugs.webkit.org/show_bug.cgi?id=110955
>
> Reviewed by Alexander Pavlov.
>
> Analysis: "timerId" value is number,
> so it is not wrapped to node as expected.
>
> Solution: wrap values of all types except Node.
>
> * inspector/front-end/TimelinePresentationModel.js:
> Wrap nonstring values to text nodes.
>
TBR=eus...@chromium.org
Review URL: https://codereview.chromium.org/12389044
Modified Paths
branches/chromium/1410/Source/WebCore/ChangeLog
branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Diff
Modified: branches/chromium/1410/Source/WebCore/ChangeLog (144417 => 144418)
--- branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-01 06:07:55 UTC (rev 144417)
+++ branches/chromium/1410/Source/WebCore/ChangeLog 2013-03-01 06:23:57 UTC (rev 144418)
@@ -1,3 +1,18 @@
+2013-02-27 Eugene Klyuchnikov
+
+Web Inspector: timeline stops working on certain sites
+https://bugs.webkit.org/show_bug.cgi?id=110955
+
+Reviewed by Alexander Pavlov.
+
+Analysis: "timerId" value is number,
+so it is not wrapped to node as expected.
+
+Solution: wrap values of all types except Node.
+
+* inspector/front-end/TimelinePresentationModel.js:
+Wrap nonstring values to text nodes.
+
2013-02-11 Zhenyao Mo
WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
Modified: branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (144417 => 144418)
--- branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2013-03-01 06:07:55 UTC (rev 144417)
+++ branches/chromium/1410/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2013-03-01 06:23:57 UTC (rev 144418)
@@ -1019,8 +1019,8 @@
break;
}
-if (typeof details === "string")
-return this._createSpanWithText(details);
+if (details && !(details instanceof Node))
+return this._createSpanWithText("" + details);
return details ? details : null;
},
@@ -1055,11 +1055,15 @@
},
/**
- * @param {string=} defaultValue
+ * @param {*=} defaultValue
+ * @return {Element|string}
*/
_linkifyScriptLocation: function(defaultValue)
{
-return this.scriptName ? this._linkifyLocation(this.scriptName, this.scriptLine, 0) : defaultValue;
+if (this.scriptName)
+return this._linkifyLocation(this.scriptName, this.scriptLine, 0);
+else
+return defaultValue ? "" + defaultValue : null;
},
calculateAggregatedStats: function(categories)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144265] trunk/Source/WebCore
Title: [144265] trunk/Source/WebCore
Revision 144265
Author eus...@chromium.org
Date 2013-02-27 23:50:22 -0800 (Wed, 27 Feb 2013)
Log Message
Web Inspector: [Protocol] Genarate JS enum definitions.
https://bugs.webkit.org/show_bug.cgi?id=110461
Reviewed by Pavel Feldman.
Generating corresponding type annotations
would help to compiler to point errors.
* inspector/CodeGeneratorInspector.py: Generate "registerEnum" records.
* inspector/InjectedScriptSource.js: Shadow compiler warning.
* inspector/front-end/InspectorBackend.js:
Added "registerEnum". Added "registerEnum" generation.
* inspector/front-end/NetworkManager.js: Use enum instead of literal.
* inspector/generate_protocol_externs.py: Generate enum typedefs.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/front-end/InspectorBackend.js
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/utilities.js
trunk/Source/WebCore/inspector/generate_protocol_externs.py
Diff
Modified: trunk/Source/WebCore/ChangeLog (144264 => 144265)
--- trunk/Source/WebCore/ChangeLog 2013-02-28 07:44:46 UTC (rev 144264)
+++ trunk/Source/WebCore/ChangeLog 2013-02-28 07:50:22 UTC (rev 144265)
@@ -1,3 +1,20 @@
+2013-02-27 Eugene Klyuchnikov
+
+Web Inspector: [Protocol] Genarate JS enum definitions.
+https://bugs.webkit.org/show_bug.cgi?id=110461
+
+Reviewed by Pavel Feldman.
+
+Generating corresponding type annotations
+would help to compiler to point errors.
+
+* inspector/CodeGeneratorInspector.py: Generate "registerEnum" records.
+* inspector/InjectedScriptSource.js: Shadow compiler warning.
+* inspector/front-end/InspectorBackend.js:
+Added "registerEnum". Added "registerEnum" generation.
+* inspector/front-end/NetworkManager.js: Use enum instead of literal.
+* inspector/generate_protocol_externs.py: Generate enum typedefs.
+
2013-02-27 Kunihiko Sakamoto
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (144264 => 144265)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2013-02-28 07:44:46 UTC (rev 144264)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2013-02-28 07:50:22 UTC (rev 144265)
@@ -32,6 +32,7 @@
import sys
import string
import optparse
+import re
try:
import json
except ImportError:
@@ -99,6 +100,16 @@
return ''.join(x.capitalize() or '-' for x in word.split('-'))
+def fix_camel_case(name):
+refined = re.sub(r'-(\w)', lambda pat: pat.group(1).upper(), name)
+refined = to_title_case(refined)
+return re.sub(r'(?i)HTML|XML|WML|API', lambda pat: pat.group(0).upper(), refined)
+
+
+def to_title_case(name):
+return name[:1].upper() + name[1:]
+
+
class Capitalizer:
@staticmethod
def lower_camel_case_to_upper(str):
@@ -1861,6 +1872,18 @@
if not domain_fixes.skip_js_bind:
Generator.backend_js_domain_initializer_list.append("InspectorBackend.register%sDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, \"%s\");\n" % (domain_name, domain_name))
+if "types" in json_domain:
+for json_type in json_domain["types"]:
+if "type" in json_type and json_type["type"] == "string" and "enum" in json_type:
+enum_name = "%s.%s" % (domain_name, json_type["id"])
+Generator.process_enum(json_type, enum_name)
+elif json_type["type"] == "object":
+if "properties" in json_type:
+for json_property in json_type["properties"]:
+if "type" in json_property and json_property["type"] == "string" and "enum" in json_property:
+enum_name = "%s.%s%s" % (domain_name, json_type["id"], to_title_case(json_property["name"]))
+Generator.process_enum(json_property, enum_name)
+
if "events" in json_domain:
for json_event in json_domain["events"]:
Generator.process_event(json_event, domain_name, frontend_method_declaration_lines)
@@ -1895,6 +1918,15 @@
Generator.backend_js_domain_initializer_list.append("\n")
@staticmethod
+def process_enum(json_enum, enum_name):
+enum_members = []
+for member in json_enum["enum"]:
+enum_members.append("%s: \"%s\"" % (fix_camel_case(member), member))
+
+Generator.backend_js_domain_initializer_list.append("InspectorBackend.registerEnum(\"%s\", {%s});\n" % (
+enum_name, ", ".join(enum_members)))
+
+@staticmethod
def process_event(json_event, domain
[webkit-changes] [144161] trunk/Source/WebCore
Title: [144161] trunk/Source/WebCore
Revision 144161
Author eus...@chromium.org
Date 2013-02-27 02:15:10 -0800 (Wed, 27 Feb 2013)
Log Message
Web Inspector: timeline stops working on certain sites
https://bugs.webkit.org/show_bug.cgi?id=110955
Reviewed by Alexander Pavlov.
Analysis: "timerId" value is number,
so it is not wrapped to node as expected.
Solution: wrap values of all types except Node.
* inspector/front-end/TimelinePresentationModel.js:
Wrap nonstring values to text nodes.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (144160 => 144161)
--- trunk/Source/WebCore/ChangeLog 2013-02-27 10:03:38 UTC (rev 144160)
+++ trunk/Source/WebCore/ChangeLog 2013-02-27 10:15:10 UTC (rev 144161)
@@ -1,3 +1,18 @@
+2013-02-27 Eugene Klyuchnikov
+
+Web Inspector: timeline stops working on certain sites
+https://bugs.webkit.org/show_bug.cgi?id=110955
+
+Reviewed by Alexander Pavlov.
+
+Analysis: "timerId" value is number,
+so it is not wrapped to node as expected.
+
+Solution: wrap values of all types except Node.
+
+* inspector/front-end/TimelinePresentationModel.js:
+Wrap nonstring values to text nodes.
+
2013-02-27 Adam Barth
HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty())
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (144160 => 144161)
--- trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2013-02-27 10:03:38 UTC (rev 144160)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2013-02-27 10:15:10 UTC (rev 144161)
@@ -1082,8 +1082,8 @@
break;
}
-if (typeof details === "string")
-return this._createSpanWithText(details);
+if (details && !(details instanceof Node))
+return this._createSpanWithText("" + details);
return details ? details : null;
},
@@ -1118,11 +1118,15 @@
},
/**
- * @param {string=} defaultValue
+ * @param {*=} defaultValue
+ * @return {Element|string}
*/
_linkifyScriptLocation: function(defaultValue)
{
-return this.scriptName ? this._linkifyLocation(this.scriptName, this.scriptLine, 0) : defaultValue;
+if (this.scriptName)
+return this._linkifyLocation(this.scriptName, this.scriptLine, 0);
+else
+return defaultValue ? "" + defaultValue : null;
},
calculateAggregatedStats: function(categories)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144061] trunk/Source/WebCore
Title: [144061] trunk/Source/WebCore
Revision 144061
Author eus...@chromium.org
Date 2013-02-26 08:14:12 -0800 (Tue, 26 Feb 2013)
Log Message
Web Inspector: Web Inspector: Specify return type of WebInspector.UIString
https://bugs.webkit.org/show_bug.cgi?id=110095
Reviewed by Pavel Feldman.
Specify return type of WebInspector.UIString.
Fix new js-compiler warnings.
This change will increase type coverage by 0.4% (to 81%)
* inspector/front-end/ObjectPropertiesSection.js: Fix type errors.
* inspector/front-end/UIString.js:
(WebInspector.UIString): Return type specified.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/UIString.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (144060 => 144061)
--- trunk/Source/WebCore/ChangeLog 2013-02-26 16:08:33 UTC (rev 144060)
+++ trunk/Source/WebCore/ChangeLog 2013-02-26 16:14:12 UTC (rev 144061)
@@ -1,3 +1,19 @@
+2013-02-18 Eugene Klyuchnikov
+
+Web Inspector: Web Inspector: Specify return type of WebInspector.UIString
+https://bugs.webkit.org/show_bug.cgi?id=110095
+
+Reviewed by Pavel Feldman.
+
+Specify return type of WebInspector.UIString.
+Fix new js-compiler warnings.
+
+This change will increase type coverage by 0.4% (to 81%)
+
+* inspector/front-end/ObjectPropertiesSection.js: Fix type errors.
+* inspector/front-end/UIString.js:
+(WebInspector.UIString): Return type specified.
+
2013-02-26 Eugene Klyuchnikov
Web Inspector: [Resources] Cookies table looks empty.
Modified: trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (144060 => 144061)
--- trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2013-02-26 16:08:33 UTC (rev 144060)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js 2013-02-26 16:14:12 UTC (rev 144061)
@@ -28,9 +28,9 @@
* @constructor
* @extends {WebInspector.PropertiesSection}
* @param {WebInspector.RemoteObject} object
- * @param {string|Element=} title
+ * @param {?string|Element=} title
* @param {string=} subtitle
- * @param {string=} emptyPlaceholder
+ * @param {?string=} emptyPlaceholder
* @param {boolean=} ignoreHasOwnProperty
* @param {Array.=} extraProperties
* @param {function(new:TreeElement, WebInspector.RemoteObjectProperty)=} treeElementConstructor
@@ -550,6 +550,9 @@
title = WebInspector.UIString("Global");
isTrueObject = true;
break;
+default:
+console.error("Unknown scope type: " + scope.type);
+continue;
}
var remoteObject = WebInspector.RemoteObject.fromPayload(scope.object);
Modified: trunk/Source/WebCore/inspector/front-end/UIString.js (144060 => 144061)
--- trunk/Source/WebCore/inspector/front-end/UIString.js 2013-02-26 16:08:33 UTC (rev 144060)
+++ trunk/Source/WebCore/inspector/front-end/UIString.js 2013-02-26 16:14:12 UTC (rev 144061)
@@ -28,9 +28,11 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+
/**
* @param {string} string
* @param {...*} vararg
+ * @return {string}
*/
WebInspector.UIString = function(string, vararg)
{
@@ -42,7 +44,7 @@
console.warn("Localized string \"" + string + "\" not found.");
WebInspector._missingLocalizedStrings[string] = true;
}
-
+
if (Preferences.showMissingLocalizedStrings)
string += " (not localized)";
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144060] trunk/Source/WebCore
Title: [144060] trunk/Source/WebCore
Revision 144060
Author eus...@chromium.org
Date 2013-02-26 08:08:33 -0800 (Tue, 26 Feb 2013)
Log Message
Web Inspector: [Resources] Cookies table looks empty.
https://bugs.webkit.org/show_bug.cgi?id=110870
Reviewed by Pavel Feldman.
Fixed data-grid selector.
* inspector/front-end/resourcesPanel.css:
(.storage-view .data-grid): Fixed selector.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/resourcesPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (144059 => 144060)
--- trunk/Source/WebCore/ChangeLog 2013-02-26 16:05:34 UTC (rev 144059)
+++ trunk/Source/WebCore/ChangeLog 2013-02-26 16:08:33 UTC (rev 144060)
@@ -1,3 +1,15 @@
+2013-02-26 Eugene Klyuchnikov
+
+Web Inspector: [Resources] Cookies table looks empty.
+https://bugs.webkit.org/show_bug.cgi?id=110870
+
+Reviewed by Pavel Feldman.
+
+Fixed data-grid selector.
+
+* inspector/front-end/resourcesPanel.css:
+(.storage-view .data-grid): Fixed selector.
+
2013-02-26 Vsevolod Vlasov
Web Inspector: Migrate FileSystem inspection support to ResourceTreeModel's SecurityOriginAdded/Removed events.
Modified: trunk/Source/WebCore/inspector/front-end/resourcesPanel.css (144059 => 144060)
--- trunk/Source/WebCore/inspector/front-end/resourcesPanel.css 2013-02-26 16:05:34 UTC (rev 144059)
+++ trunk/Source/WebCore/inspector/front-end/resourcesPanel.css 2013-02-26 16:08:33 UTC (rev 144060)
@@ -118,7 +118,7 @@
overflow: hidden;
}
-.storage-view > .data-grid {
+.storage-view .data-grid:not(.inline) {
border: none;
height: 100%;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143902] trunk/Source/WebCore
Title: [143902] trunk/Source/WebCore
Revision 143902
Author eus...@chromium.org
Date 2013-02-25 03:45:27 -0800 (Mon, 25 Feb 2013)
Log Message
Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
https://bugs.webkit.org/show_bug.cgi?id=109943
Reviewed by Pavel Feldman.
Look at network log: red bar (on load) is positioned to the right of
the last required load.
This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.
* inspector/front-end/DataGrid.js:
Fix - hidden columns can have non-zero width.
* inspector/front-end/NetworkPanel.js: Use correct width for calculator.
* inspector/front-end/networkLogView.css: Removed parasite paddinds.
Extracted common absolute "paddings".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DataGrid.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/networkLogView.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (143901 => 143902)
--- trunk/Source/WebCore/ChangeLog 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/ChangeLog 2013-02-25 11:45:27 UTC (rev 143902)
@@ -1,3 +1,22 @@
+2013-02-25 Eugene Klyuchnikov
+
+Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
+https://bugs.webkit.org/show_bug.cgi?id=109943
+
+Reviewed by Pavel Feldman.
+
+Look at network log: red bar (on load) is positioned to the right of
+the last required load.
+
+This is incorrect. For exmaple, in case of short event it should be
+positioned in the center of the bar.
+
+* inspector/front-end/DataGrid.js:
+Fix - hidden columns can have non-zero width.
+* inspector/front-end/NetworkPanel.js: Use correct width for calculator.
+* inspector/front-end/networkLogView.css: Removed parasite paddinds.
+Extracted common absolute "paddings".
+
2013-02-25 Keishi Hattori
Add list view for new calendar picker
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-02-25 11:45:27 UTC (rev 143902)
@@ -688,6 +688,10 @@
previousResizer.rightNeighboringColumnIndex = i;
previousResizer = resizer;
} else {
+if (previousResizer && previousResizer._position !== left) {
+previousResizer._position = left;
+previousResizer.style.left = left + "px";
+}
resizer.style.setProperty("display", "none");
resizer.leftNeighboringColumnIndex = 0;
resizer.rightNeighboringColumnIndex = 0;
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-25 11:45:27 UTC (rev 143902)
@@ -559,7 +559,6 @@
if (timelineColumn.ordinal === this._dataGrid.resizers[i].rightNeighboringColumnIndex) {
// Position timline grid location.
this._timelineGrid.element.style.left = this._dataGrid.resizers[i].style.left;
-this._timelineGrid.element.style.right = "18px";
}
}
@@ -568,7 +567,7 @@
this._scheduleRefresh();
proceed = false;
} else {
-this.calculator.setDisplayWindow(this._timelineGrid.element.clientWidth);
+this.calculator.setDisplayWindow(this._timelineGrid.dividersElement.clientWidth);
proceed = this._timelineGrid.updateDividers(this.calculator);
}
if (!proceed)
Modified: trunk/Source/WebCore/inspector/front-end/networkLogView.css (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-02-25 11:45:27 UTC (rev 143902)
@@ -216,7 +216,7 @@
.network-graph-side {
position: relative;
height: 36px;
-padding: 0 5px;
+padding: 0;
white-space: nowrap;
margin-top: 1px;
border-top: 1px solid transparent;
@@ -227,10 +227,16 @@
position: absolute;
top: 0;
bottom: 0;
-right: 8px;
-left: 9px;
}
+.network-graph-bar-area,
+.network-timeline-grid .resources-dividers,
+.network-timeline-grid .resources-event-dividers,
+.network-timeline-grid .resources-dividers-label-bar {
+right: 12px;
+left: 12px;
+}
+
.network-graph-label {
position: absolute;
top: 0;
@@ -381,10 +387,20 @@
top: 0;
bottom: 0;
left: 0;
-right: 0;
+right: 14px; /* Keep in sync wi
[webkit-changes] [143864] trunk/Source/WebCore
Title: [143864] trunk/Source/WebCore
Revision 143864
Author eus...@chromium.org
Date 2013-02-24 05:18:17 -0800 (Sun, 24 Feb 2013)
Log Message
Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
https://bugs.webkit.org/show_bug.cgi?id=110561
Reviewed by Pavel Feldman.
Area that causes frame information popup is overly "shaded" by CPU bars.
* inspector/front-end/timelinePanel.css:
(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/timelinePanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (143863 => 143864)
--- trunk/Source/WebCore/ChangeLog 2013-02-24 13:01:06 UTC (rev 143863)
+++ trunk/Source/WebCore/ChangeLog 2013-02-24 13:18:17 UTC (rev 143864)
@@ -1,3 +1,15 @@
+2013-02-24 Eugene Klyuchnikov
+
+Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
+https://bugs.webkit.org/show_bug.cgi?id=110561
+
+Reviewed by Pavel Feldman.
+
+Area that causes frame information popup is overly "shaded" by CPU bars.
+
+* inspector/front-end/timelinePanel.css:
+(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.
+
2013-02-24 Andreas Kling
Reduce include graph of JSDOMBinding.h
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (143863 => 143864)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-02-24 13:01:06 UTC (rev 143863)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-02-24 13:18:17 UTC (rev 143864)
@@ -667,9 +667,9 @@
.timeline-cpu-bars .timeline-graph-bar {
border-color: rgb(192, 192, 192);
-background-color: rgba(0, 0, 0, 0.15);
-top: 2px;
-bottom: 2px;
+background-color: rgba(0, 0, 0, 0.1);
+top: 4px;
+bottom: 4px;
height: auto;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143580] trunk
Title: [143580] trunk
Revision 143580
Author eus...@chromium.org
Date 2013-02-21 03:39:17 -0800 (Thu, 21 Feb 2013)
Log Message
Web Inspector: [Console] Add console API message types for profile/profileEnd.
https://bugs.webkit.org/show_bug.cgi?id=109790
Reviewed by Pavel Feldman.
With profile/profileEnd message types we will gain more control over
output messages.
* English.lproj/localizedStrings.js: Added corresponging strings.
* inspector/ConsoleAPITypes.h: Added enum members.
* inspector/Inspector.json: Ditto.
* inspector/front-end/ConsoleModel.js: Ditto.
* inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue): Added cases.
* inspector/InspectorProfilerAgent.cpp: Adopted changes.
* inspector/front-end/inspector.js: Ditto.
* inspector/front-end/ConsoleMessage.js:
Added message generators for introduced message types.
* inspector/front-end/ProfilesPanel.js:
Turned showProfileForURL(url) to showProfile(typeId, uid).
* inspector/front-end/ProfilesPanelDescriptor.js:
(WebInspector.ProfilesPanelDescriptor.resolveProfileTitle): Added.
* inspector/front-end/ResourceUtils.js: Removed linkifier plugins.
Modified Paths
trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html
trunk/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html
trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js
trunk/LayoutTests/inspector/profiler/profiler-test.js
trunk/PerformanceTests/inspector/heap-snapshot-performance-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/ConsoleAPITypes.h
trunk/Source/WebCore/inspector/ConsoleMessage.cpp
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/ConsoleModel.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js
trunk/Source/WebCore/inspector/front-end/ResourceUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html (143579 => 143580)
--- trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html 2013-02-21 10:44:04 UTC (rev 143579)
+++ trunk/LayoutTests/inspector/profiler/canvas2d/canvas-replay-log-grid.html 2013-02-21 11:39:17 UTC (rev 143580)
@@ -55,7 +55,7 @@
function didStartCapturingFrame(profilesPanel, frameId, error, traceLogId)
{
profileHeader = profilesPanel.getProfiles(WebInspector.CanvasProfileType.TypeId)[0];
-profilesPanel.showProfile(profileHeader);
+profilesPanel._showProfile(profileHeader);
InspectorTest.addSniffer(profileHeader, "_updateCapturingStatus", didReceiveFirstFrame);
InspectorTest.evaluateInConsole("doSomeCanvasCalls(2)");
}
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html (143579 => 143580)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html 2013-02-21 10:44:04 UTC (rev 143579)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html 2013-02-21 11:39:17 UTC (rev 143580)
@@ -19,7 +19,7 @@
function step0()
{
var profiles = WebInspector.panels.profiles.getProfiles("HEAP");
-WebInspector.panels.profiles.showProfile(profiles[profiles.length - 1]);
+WebInspector.panels.profiles._showProfile(profiles[profiles.length - 1]);
InspectorTest.addSniffer(WebInspector.panels.profiles, "_finishHeapSnapshot", step1);
}
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html (143579 => 143580)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html 2013-02-21 10:44:04 UTC (rev 143579)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html 2013-02-21 11:39:17 UTC (rev 143580)
@@ -45,7 +45,7 @@
InspectorTest.addSniffer(profileHeader, "_snapshotReceived", snapshotLoaded);
InspectorTest.override(HeapProfilerAgent, "getHeapSnapshot", getHeapSnapshotMock);
-panel.showProfile(profileHeader);
+panel._showProfile(profileHeader);
}
InspectorTest.runTestSuite([
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js (143579 => 143580)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2013-02-21 10:44:04 UTC (rev 143579)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2013-02-21 11:39:17 UTC (rev 143580)
@@ -738,7 +738,7 @@
InspectorTest.override(HeapProfilerAgent, "getHeapSnapshot", pushGeneratedSnapshot);
InspectorTest._takeAndOpenSnapshotCallback = callback;
WebInspector.panels.profiles.addProfileHeader(profile);
-WebInspector.panels.profiles.showProfile(profile);
+WebInspector.panels.profiles._showProfile(profile);
[webkit-changes] [143437] trunk/Source/WebCore
Title: [143437] trunk/Source/WebCore
Revision 143437
Author eus...@chromium.org
Date 2013-02-20 01:21:09 -0800 (Wed, 20 Feb 2013)
Log Message
Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224
Reviewed by Pavel Feldman.
This will cause CSS loading problems after "show".
* inspector/front-end/Drawer.js:
Ensure child view is detached before marked as root.
* inspector/front-end/View.js:
(WebInspector.View.prototype.markAsRoot): Added assertion.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Drawer.js
trunk/Source/WebCore/inspector/front-end/View.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (143436 => 143437)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 09:17:34 UTC (rev 143436)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 09:21:09 UTC (rev 143437)
@@ -1,3 +1,17 @@
+2013-02-20 Eugene Klyuchnikov
+
+Web Inspector: View.markAsRoot should never be invoked on attached view.
+https://bugs.webkit.org/show_bug.cgi?id=110224
+
+Reviewed by Pavel Feldman.
+
+This will cause CSS loading problems after "show".
+
+* inspector/front-end/Drawer.js:
+Ensure child view is detached before marked as root.
+* inspector/front-end/View.js:
+(WebInspector.View.prototype.markAsRoot): Added assertion.
+
2013-02-20 Nils Barth
File upload control doesn't apply CSS vertical padding or border to file name
Modified: trunk/Source/WebCore/inspector/front-end/Drawer.js (143436 => 143437)
--- trunk/Source/WebCore/inspector/front-end/Drawer.js 2013-02-20 09:17:34 UTC (rev 143436)
+++ trunk/Source/WebCore/inspector/front-end/Drawer.js 2013-02-20 09:21:09 UTC (rev 143437)
@@ -86,6 +86,7 @@
document.body.addStyleClass("drawer-visible");
this._floatingStatusBarContainer.insertBefore(document.getElementById("panel-status-bar"), this._floatingStatusBarContainer.firstElementChild);
this._bottomStatusBar.appendChild(this._viewStatusBar);
+this._view.detach();
this._view.markAsRoot();
this._view.show(this._drawerContentsElement);
Modified: trunk/Source/WebCore/inspector/front-end/View.js (143436 => 143437)
--- trunk/Source/WebCore/inspector/front-end/View.js 2013-02-20 09:17:34 UTC (rev 143436)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2013-02-20 09:21:09 UTC (rev 143437)
@@ -47,6 +47,7 @@
WebInspector.View.prototype = {
markAsRoot: function()
{
+WebInspector.View._assert(!this.element.parentElement, "Attempt to mark as root attached node");
this._isRoot = true;
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143427] trunk/Source/WebCore
Title: [143427] trunk/Source/WebCore
Revision 143427
Author eus...@chromium.org
Date 2013-02-19 21:24:35 -0800 (Tue, 19 Feb 2013)
Log Message
Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202
Reviewed by Pavel Feldman.
SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.
* inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SuggestBox.js
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (143426 => 143427)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 03:05:32 UTC (rev 143426)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 05:24:35 UTC (rev 143427)
@@ -1,3 +1,26 @@
+2013-02-19 Eugene Klyuchnikov
+
+Web Inspector: Cleanup and add JSDocs to SuggestBox
+https://bugs.webkit.org/show_bug.cgi?id=110202
+
+Reviewed by Pavel Feldman.
+
+SuggestBox contains some obsolete/unused code and not fully
+covered with JSDocs.
+
+* inspector/front-end/SuggestBox.js:
+(WebInspector.SuggestBox.prototype.visible):
+Replaced getter with function.
+(WebInspector.SuggestBox.prototype._onScrollOrResize):
+Use camel-case for function names.
+(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
+(WebInspector.SuggestBox.prototype.updateSuggestions):
+Removed unused code.
+(WebInspector.SuggestBox.prototype.hide): Adopt changes.
+(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.
+
2013-02-19 Hayato Ito
Calculate EventPath in EventDispatcher's constructor.
Modified: trunk/Source/WebCore/inspector/front-end/SuggestBox.js (143426 => 143427)
--- trunk/Source/WebCore/inspector/front-end/SuggestBox.js 2013-02-20 03:05:32 UTC (rev 143426)
+++ trunk/Source/WebCore/inspector/front-end/SuggestBox.js 2013-02-20 05:24:35 UTC (rev 143427)
@@ -66,33 +66,35 @@
this._length = 0;
this._selectedIndex = -1;
this._selectedElement = null;
-this._boundOnScroll = this._onscrollresize.bind(this, true);
-this._boundOnResize = this._onscrollresize.bind(this, false);
+this._boundOnScroll = this._onScrollOrResize.bind(this, true);
+this._boundOnResize = this._onScrollOrResize.bind(this, false);
window.addEventListener("scroll", this._boundOnScroll, true);
window.addEventListener("resize", this._boundOnResize, true);
this._bodyElement = inputElement.ownerDocument.body;
this._element = inputElement.ownerDocument.createElement("div");
this._element.className = "suggest-box " + (className || "");
-this._element.addEventListener("mousedown", this._onboxmousedown.bind(this), true);
+this._element.addEventListener("mousedown", this._onBoxMouseDown.bind(this), true);
this.containerElement = this._element.createChild("div", "container");
this.contentElement = this.containerElement.createChild("div", "content");
}
WebInspector.SuggestBox.prototype = {
-get visible()
+/**
+ * @return {boolean}
+ */
+visible: function()
{
return !!this._element.parentElement;
},
-get hasSelection()
+/**
+ * @param {boolean} isScroll
+ * @param {Event} event
+ */
+_onScrollOrResize: function(isScroll, event)
{
-return !!this._selectedElement;
-},
-
-_onscrollresize: function(isScroll, event)
-{
-if (isScroll && this._element.isAncestor(event.target) || !this.visible)
+if (isScroll && this._element.isAncestor(event.target) || !this.visible())
return;
this._updateBoxPositionWithExistingAnchor();
},
@@ -155,14 +157,17 @@
this._element.style.height = height + "px";
},
-_onboxmousedown: function(event)
+/**
+ * @param {Event} event
+ */
+_onBoxMouseDown: function(event)
{
event.preventDefault();
},
hide: function()
{
-if (!this.visible)
+if (!this.visible())
return;
this._element.parentElement.removeChild(this._element);
@@ -182,7 +187,7 @@
*/
_applySuggestion: function(text, isIntermediateSuggestion)
{
-if (!this.visible || !(text || this._selectedElement))
+
[webkit-changes] [143159] trunk
Title: [143159] trunk Revision 143159 Author eus...@chromium.org Date 2013-02-17 23:51:52 -0800 (Sun, 17 Feb 2013) Log Message Web Inspector: Introduce ProfilesPanelDescriptor. https://bugs.webkit.org/show_bug.cgi?id=109906 Reviewed by Pavel Feldman. Source/WebCore: Some constants/methods should be accesible before ProfilesPanel is instantiated. Extracted methods to check if profile is "user-initiated" and what is its index. Also profile URL regexp moved to ProfilesPanelDescriptor. * inspector/front-end/ProfilesPanelDescriptor.js: Added. * WebCore.gypi: Added ProfilesPanelDescriptor.js * WebCore.vcproj/WebCore.vcproj: Ditto. * inspector/compile-front-end.py: Ditto. * inspector/front-end/WebKit.qrc: Ditto. * inspector/front-end/inspector.html: Ditto. * inspector/front-end/HeapSnapshotView.js: Adopted changes. * inspector/front-end/ProfilesPanel.js: Ditto. * inspector/front-end/externs.js: Ditto. * inspector/front-end/inspector.js: Ditto. LayoutTests: * inspector/profiler/heap-snapshot-test.js: Adopted changes. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.py trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/inspector.html trunk/Source/WebCore/inspector/front-end/inspector.js Added Paths trunk/Source/WebCore/inspector/front-end/ProfilesPanelDescriptor.js Diff Modified: trunk/LayoutTests/ChangeLog (143158 => 143159) --- trunk/LayoutTests/ChangeLog 2013-02-18 07:47:23 UTC (rev 143158) +++ trunk/LayoutTests/ChangeLog 2013-02-18 07:51:52 UTC (rev 143159) @@ -1,3 +1,12 @@ +2013-02-15 Eugene Klyuchnikov + +Web Inspector: Introduce ProfilesPanelDescriptor. +https://bugs.webkit.org/show_bug.cgi?id=109906 + +Reviewed by Pavel Feldman. + +* inspector/profiler/heap-snapshot-test.js: Adopted changes. + 2013-02-17 Takashi Toyoshima Unreviewed, update test expectation for chromium. Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js (143158 => 143159) --- trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2013-02-18 07:47:23 UTC (rev 143158) +++ trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2013-02-18 07:51:52 UTC (rev 143159) @@ -722,7 +722,7 @@ var snapshot = generator(); var profileType = WebInspector.panels.profiles.getProfileType(WebInspector.HeapSnapshotProfileType.TypeId); var profile = "" -title: UserInitiatedProfileName + "." + uid, +title: WebInspector.ProfilesPanelDescriptor.UserInitiatedProfileName + "." + uid, uid: uid, maxJSObjectId: snapshot.maxJSObjectId }); Modified: trunk/Source/WebCore/ChangeLog (143158 => 143159) --- trunk/Source/WebCore/ChangeLog 2013-02-18 07:47:23 UTC (rev 143158) +++ trunk/Source/WebCore/ChangeLog 2013-02-18 07:51:52 UTC (rev 143159) @@ -1,3 +1,29 @@ +2013-02-15 Eugene Klyuchnikov + +Web Inspector: Introduce ProfilesPanelDescriptor. +https://bugs.webkit.org/show_bug.cgi?id=109906 + +Reviewed by Pavel Feldman. + +Some constants/methods should be accesible before ProfilesPanel +is instantiated. + +Extracted methods to check if profile is "user-initiated" and what is +its index. + +Also profile URL regexp moved to ProfilesPanelDescriptor. + +* inspector/front-end/ProfilesPanelDescriptor.js: Added. +* WebCore.gypi: Added ProfilesPanelDescriptor.js +* WebCore.vcproj/WebCore.vcproj: Ditto. +* inspector/compile-front-end.py: Ditto. +* inspector/front-end/WebKit.qrc: Ditto. +* inspector/front-end/inspector.html: Ditto. +* inspector/front-end/HeapSnapshotView.js: Adopted changes. +* inspector/front-end/ProfilesPanel.js: Ditto. +* inspector/front-end/externs.js: Ditto. +* inspector/front-end/inspector.js: Ditto. + 2013-02-17 Dimitri Glazkov Stop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated. Modified: trunk/Source/WebCore/WebCore.gypi (143158 => 143159) --- trunk/Source/WebCore/WebCore.gypi 2013-02-18 07:47:23 UTC (rev 143158) +++ trunk/Source/WebCore/WebCore.gypi 2013-02-18 07:51:52 UTC (rev 143159) @@ -5254,6 +5254,7 @@ 'inspector/front-end/Placard.js', 'inspector/front-end/Popover.js', 'inspector/front-end/PresentationConsoleMessageHelper.js', +'inspector/front-end/ProfilesPanelDescriptor.js', 'inspector/front-end/Progress.js', 'inspector/front-end/ProgressIndicator.js', 'inspector/front-end/PropertiesSect
[webkit-changes] [143153] trunk/Tools
Title: [143153] trunk/Tools
Revision 143153
Author eus...@chromium.org
Date 2013-02-17 22:50:19 -0800 (Sun, 17 Feb 2013)
Log Message
Unreviewed, add myself to commiters.py.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (143152 => 143153)
--- trunk/Tools/ChangeLog 2013-02-18 06:44:13 UTC (rev 143152)
+++ trunk/Tools/ChangeLog 2013-02-18 06:50:19 UTC (rev 143153)
@@ -1,3 +1,9 @@
+2013-02-18 Eugene Klyuchnikov
+
+Unreviewed, add myself to commiters.py.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2013-02-17 Dongwoo Joshua Im
Unreviewed. Add myself as a committer.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (143152 => 143153)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2013-02-18 06:44:13 UTC (rev 143152)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2013-02-18 06:50:19 UTC (rev 143153)
@@ -276,6 +276,7 @@
Committer("Erik Arvidsson", "a...@chromium.org", "arv"),
Committer("Eric Roman", "ero...@chromium.org", "eroman"),
Committer("Eric Uhrhane", "er...@chromium.org", "ericu"),
+Committer("Eugene Klyuchnikov", "eus...@chromium.org", "eustas"),
Committer("Evan Martin", "e...@chromium.org", "evmar"),
Committer("Evan Stade", "est...@chromium.org", "estade"),
Committer("Fady Samuel", "fsam...@chromium.org", "fsamuel"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
