[webkit-changes] [132781] trunk/Tools
Title: [132781] trunk/Tools Revision 132781 Author joc...@chromium.org Date 2012-10-29 03:50:29 -0700 (Mon, 29 Oct 2012) Log Message [chromium] remove remaining usages of webkit_support from the TestRunner library https://bugs.webkit.org/show_bug.cgi?id=100344 Reviewed by Adam Barth. The most important part is to not rely on calling out to gdk/X11 to translate keycodes to hardware keycodes, as this is not possible inside the sandbox. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/DRTTestRunner.h: (WebKit): (webkit_support): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: (WebTestRunner): (WebTestRunner::EventSender::doDragDrop): (WebTestRunner::EventSender::updateClickCountForButton): (WebTestRunner::EventSender::mouseDown): (WebTestRunner::EventSender::mouseUp): (WebTestRunner::EventSender::mouseMoveTo): (WebTestRunner::EventSender::keyDown): (WebTestRunner::EventSender::replaySavedEvents): (WebTestRunner::EventSender::contextClick): (WebTestRunner::EventSender::beginDragWithFiles): (WebTestRunner::EventSender::sendCurrentTouchEvent): (WebTestRunner::EventSender::handleMouseWheel): (WebTestRunner::EventSender::gestureEvent): (WebTestRunner::EventSender::gestureFlingCancel): (WebTestRunner::EventSender::gestureFlingStart): * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added. (WebTestRunner): (WebTestRunner::NativeKeyCodeForWindowsKeyCode): * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h. (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: (WebTestInterfaces::Internal): (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond): (WebTestRunner): (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::getCurrentTimeInMillisecond): (WebViewHost::getAbsoluteWebStringFromUTF8Path): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gypi trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Added Paths trunk/Tools/DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h Diff Modified: trunk/Tools/ChangeLog (132780 => 132781) --- trunk/Tools/ChangeLog 2012-10-29 10:28:01 UTC (rev 132780) +++ trunk/Tools/ChangeLog 2012-10-29 10:50:29 UTC (rev 132781) @@ -1,3 +1,57 @@ +2012-10-29 Jochen Eisinger + +[chromium] remove remaining usages of webkit_support from the TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=100344 + +Reviewed by Adam Barth. + +The most important part is to not rely on calling out to gdk/X11 to +translate keycodes to hardware keycodes, as this is not possible inside +the sandbox. + +* DumpRenderTree/DumpRenderTree.gypi: +* DumpRenderTree/chromium/DRTTestRunner.h: +(WebKit): +(webkit_support): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/src/CppVariant.h: +* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: +(WebTestRunner): +(WebTestRunner::EventSender::doDragDrop): +(WebTestRunner::EventSender::updateClickCountForButton): +(WebTestRunner::EventSender::mouseDown): +(WebTestRunner::EventSender::mouseUp): +(WebTestRunner::EventSender::mouseMoveTo): +(WebTestRunner::EventSender::keyDown): +(WebTestRunner::EventSender::replaySavedEvents): +(WebTestRunner::EventSender::contextClick): +(WebTestRunner::EventSender::beginDragWithFiles): +(WebTestRunner::EventSender::sendCurrentTouchEvent): +(WebTestRunner::EventSender::handleMouseWheel): +(WebTestRunner::EventSender::gestureEvent): +(WebTestRunner::EventSender::gestureFlingCancel): +(WebTestRunner::EventSender::gestureFlingSt
[webkit-changes] [132872] trunk/Tools
Title: [132872] trunk/Tools Revision 132872 Author joc...@chromium.org Date 2012-10-29 23:43:43 -0700 (Mon, 29 Oct 2012) Log Message [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build https://bugs.webkit.org/show_bug.cgi?id=100658 Reviewed by Tony Chang. Before, this was compiled into DumpRenderTree. I also dropped the include_dirs and dependencies block as TestRunner already has them. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp Diff Modified: trunk/Tools/ChangeLog (132871 => 132872) --- trunk/Tools/ChangeLog 2012-10-30 03:49:55 UTC (rev 132871) +++ trunk/Tools/ChangeLog 2012-10-30 06:43:43 UTC (rev 132872) @@ -1,3 +1,15 @@ +2012-10-29 Jochen Eisinger + +[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build +https://bugs.webkit.org/show_bug.cgi?id=100658 + +Reviewed by Tony Chang. + +Before, this was compiled into DumpRenderTree. I also dropped the +include_dirs and dependencies block as TestRunner already has them. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + 2012-10-29 Takashi Sakamoto Unreviewed. Adding myself as a committer. Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (132871 => 132872) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-30 03:49:55 UTC (rev 132871) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-30 06:43:43 UTC (rev 132872) @@ -116,6 +116,12 @@ '<(source_dir)/WebKit/chromium/public/gtk', ], }], +['inside_chromium_build==1 and component=="shared_library"', { +'sources': [ +'<(source_dir)/WebKit/chromium/src/ChromiumCurrentTime.cpp', +'<(source_dir)/WebKit/chromium/src/ChromiumThreading.cpp', +], +}], ], }, { @@ -348,18 +354,6 @@ ['exclude', 'Android\\.cpp$'], ], }], -['inside_chromium_build==1 and component=="shared_library"', { -'sources': [ -'<(source_dir)/WebKit/chromium/src/ChromiumCurrentTime.cpp', -'<(source_dir)/WebKit/chromium/src/ChromiumThreading.cpp', -], -'include_dirs': [ -'<(source_dir)/WebKit/chromium/public', -], -'dependencies': [ -'<(source_dir)/WTF/WTF.gyp/WTF.gyp:wtf', -], -}], ['inside_chromium_build==0', { 'dependencies': [ '<(chromium_src_dir)/webkit/support/setup_third_party.gyp:third_party_headers', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134027] trunk/Tools
Title: [134027] trunk/Tools Revision 134027 Author joc...@chromium.org Date 2012-11-09 01:00:52 -0800 (Fri, 09 Nov 2012) Log Message [chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests https://bugs.webkit.org/show_bug.cgi?id=101452 Reviewed by Adam Barth. The WebTestProxy is template, so it can derive from an implementation of the WebViewClient interface. That way, WebTestProxy can hook into individual methods of the WebViewClient and forward all the rest to the actual implementation. To demonstrate how I want to use this, I moved the postAccessibilityNotification method from WebViewHost to WebTestProxy. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added. (WebKit): (WebTestRunner): (WebTestProxyBase): (WebTestProxy): (WebTestRunner::WebTestProxy::WebTestProxy): (WebTestRunner::WebTestProxy::~WebTestProxy): (WebTestRunner::WebTestProxy::postAccessibilityNotification): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added. (WebTestRunner): (WebTestRunner::WebTestProxyBase::WebTestProxyBase): (WebTestRunner::WebTestProxyBase::~WebTestProxyBase): (WebTestRunner::WebTestProxyBase::setInterfaces): (WebTestRunner::WebTestProxyBase::setDelegate): (WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::createNewWindow): * DumpRenderTree/chromium/WebViewHost.cpp: * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gypi trunk/Tools/DumpRenderTree/chromium/TestShell.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Added Paths trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp Diff Modified: trunk/Tools/ChangeLog (134026 => 134027) --- trunk/Tools/ChangeLog 2012-11-09 08:54:16 UTC (rev 134026) +++ trunk/Tools/ChangeLog 2012-11-09 09:00:52 UTC (rev 134027) @@ -1,3 +1,40 @@ +2012-11-09 Jochen Eisinger + +[chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests +https://bugs.webkit.org/show_bug.cgi?id=101452 + +Reviewed by Adam Barth. + +The WebTestProxy is template, so it can derive from an implementation +of the WebViewClient interface. That way, WebTestProxy can hook into +individual methods of the WebViewClient and forward all the rest to the +actual implementation. + +To demonstrate how I want to use this, I moved the +postAccessibilityNotification method from WebViewHost to WebTestProxy. + +* DumpRenderTree/DumpRenderTree.gypi: +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added. +(WebKit): +(WebTestRunner): +(WebTestProxyBase): +(WebTestProxy): +(WebTestRunner::WebTestProxy::WebTestProxy): +(WebTestRunner::WebTestProxy::~WebTestProxy): +(WebTestRunner::WebTestProxy::postAccessibilityNotification): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added. +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::WebTestProxyBase): +(WebTestRunner::WebTestProxyBase::~WebTestProxyBase): +(WebTestRunner::WebTestProxyBase::setInterfaces): +(WebTestRunner::WebTestProxyBase::setDelegate): +(WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification): +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::createNewWindow): +* DumpRenderTree/chromium/WebViewHost.cpp: +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2012-11-09 Simon Hausmann [Qt] Build with MSVC fails to use nmake instead of make Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gypi (134026 => 134027) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gypi 2012-11-09 08:54:16 UTC (rev 134026) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gypi 2012-11-09 09:00:52 UTC (rev 134027) @@ -71,6 +71,7 @@ 'chromium/TestRunner/public/WebEventSender.h', 'chromium/TestRunner/public/WebTask.h', 'chromium/TestRunner/public/WebTestInterfaces.h', +'chromium/TestRunner/public/WebTestProxy.h', 'chromium/TestRunner/src/AccessibilityControllerChromium.cpp', 'chromium/TestRunner/src/AccessibilityControllerChromium.h', 'chromium/TestRunner/src/AccessibilityUIElementChromium.cpp', @@ -95,6 +96,7 @@ 'chromium/TestRunner/src/WebEventSender.cpp', 'chromium/TestRunner/src/WebTask.cpp', 'chromium/TestRunner/src/WebTestInterfaces.cpp', +'chromium/TestRunner/src/WebTestProxy.cpp', ],
[webkit-changes] [134203] trunk/Tools
Title: [134203] trunk/Tools Revision 134203 Author joc...@chromium.org Date 2012-11-12 03:42:37 -0800 (Mon, 12 Nov 2012) Log Message [chromium] move TestRunner implementation into WebTestRunner namespace https://bugs.webkit.org/show_bug.cgi?id=101837 Reviewed by Adam Barth. That way, we don't get collisions when linking e.g. against chromium's net test support library. * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/EventSender.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (WebTestRunner): (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: (WebTestRunner): (TestInterfaces): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: (WebTestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.h Diff Modified: trunk/Tools/ChangeLog (134202 => 134203) --- trunk/Tools/ChangeLog 2012-11-12 11:23:11 UTC (rev 134202) +++ trunk/Tools/ChangeLog 2012-11-12 11:42:37 UTC (rev 134203) @@ -1,3 +1,52 @@ +2012-11-12 Jochen Eisinger + +[chromium] move TestRunner implementation into WebTestRunner namespace +https://bugs.webkit.org/show_bug.cgi?id=101837 + +Reviewed by Adam Barth. + +That way, we don't get collisions when linking e.g. against chromium's +net test support library. + +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/CppVariant.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/EventSender.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/GamepadController.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: +(WebTestRunner): +(TestDelegate): +* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: +(WebTestRunner): +* DumpRenderTree/
[webkit-changes] [134392] trunk/Tools
Title: [134392] trunk/Tools Revision 134392 Author joc...@chromium.org Date 2012-11-13 02:53:50 -0800 (Tue, 13 Nov 2012) Log Message [chromium] move tracking of damaged regions from WebViewHost to WebTestProxy https://bugs.webkit.org/show_bug.cgi?id=101927 Reviewed by Adam Barth. This will allow for sharing the code with content_shell * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::display): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebKit): (WebTestProxyBase): (WebTestRunner::WebTestProxy::didInvalidateRect): (WebTestRunner::WebTestProxy::didScrollRect): (WebTestRunner::WebTestProxy::scheduleComposite): (WebTestRunner::WebTestProxy::scheduleAnimation): (WebTestRunner::WebTestProxy::setWindowRect): (WebTestRunner::WebTestProxy::show): (WebTestRunner::WebTestProxy::didAutoResize): (WebTestRunner::WebTestProxy::postAccessibilityNotification): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::setPaintRect): (WebTestRunner): (WebTestRunner::WebTestProxyBase::paintRect): (WebTestRunner::WebTestProxyBase::didInvalidateRect): (WebTestRunner::WebTestProxyBase::didScrollRect): (WebTestRunner::WebTestProxyBase::scheduleComposite): (WebTestRunner::WebTestProxyBase::scheduleAnimation): (WebTestRunner::WebTestProxyBase::show): (WebTestRunner::WebTestProxyBase::setWindowRect): (WebTestRunner::WebTestProxyBase::didAutoResize): (WebTestRunner::WebTestProxyBase::postAccessibilityNotification): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::createNewWindow): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleAnimation): (WebViewHost::show): (WebViewHost::setWindowRect): (WebViewHost::WebViewHost): (WebViewHost::proxy): (WebViewHost::setProxy): (WebViewHost::reset): (WebViewHost::paintInvalidatedRegion): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (134391 => 134392) --- trunk/Tools/ChangeLog 2012-11-13 10:25:21 UTC (rev 134391) +++ trunk/Tools/ChangeLog 2012-11-13 10:53:50 UTC (rev 134392) @@ -1,3 +1,51 @@ +2012-11-13 Jochen Eisinger + +[chromium] move tracking of damaged regions from WebViewHost to WebTestProxy +https://bugs.webkit.org/show_bug.cgi?id=101927 + +Reviewed by Adam Barth. + +This will allow for sharing the code with content_shell + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::display): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebKit): +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::didInvalidateRect): +(WebTestRunner::WebTestProxy::didScrollRect): +(WebTestRunner::WebTestProxy::scheduleComposite): +(WebTestRunner::WebTestProxy::scheduleAnimation): +(WebTestRunner::WebTestProxy::setWindowRect): +(WebTestRunner::WebTestProxy::show): +(WebTestRunner::WebTestProxy::didAutoResize): +(WebTestRunner::WebTestProxy::postAccessibilityNotification): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::setPaintRect): +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::paintRect): +(WebTestRunner::WebTestProxyBase::didInvalidateRect): +(WebTestRunner::WebTestProxyBase::didScrollRect): +(WebTestRunner::WebTestProxyBase::scheduleComposite): +(WebTestRunner::WebTestProxyBase::scheduleAnimation): +(WebTestRunner::WebTestProxyBase::show): +(WebTestRunner::WebTestProxyBase::setWindowRect): +(WebTestRunner::WebTestProxyBase::didAutoResize): +(WebTestRunner::WebTestProxyBase::postAccessibilityNotification): +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::createNewWindow): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::scheduleAnimation): +(WebViewHost::show): +(WebViewHost::setWindowRect): +(WebViewHost::WebViewHost): +(WebViewHost::proxy): +(WebViewHost::setProxy): +(WebViewHost::reset): +(WebViewHost::paintInvalidatedRegion): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2012-11-12 Dirk Pranke webkitpy: clean up lint errors, part 1 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (134391 => 134392) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-13 10:25:21 UTC (rev 134391) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-13 10:53:50 UTC (rev 134392) @@ -1266,7 +
[webkit-changes] [134394] trunk/Tools
Title: [134394] trunk/Tools Revision 134394 Author joc...@chromium.org Date 2012-11-13 03:31:25 -0800 (Tue, 13 Nov 2012) Log Message Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner https://bugs.webkit.org/show_bug.cgi?id=101957 Reviewed by Adam Barth. Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply. * Scripts/webkitpy/common/config/watchlist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (134393 => 134394) --- trunk/Tools/ChangeLog 2012-11-13 11:21:33 UTC (rev 134393) +++ trunk/Tools/ChangeLog 2012-11-13 11:31:25 UTC (rev 134394) @@ -1,3 +1,14 @@ +2012-11-12 Jochen Eisinger + +Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner +https://bugs.webkit.org/show_bug.cgi?id=101957 + +Reviewed by Adam Barth. + +Chromium now also depends on the TestRunner public API, and as such, similar rules as for the Chromium WebKit API should apply. + +* Scripts/webkitpy/common/config/watchlist: + 2012-11-13 Jochen Eisinger [chromium] move tracking of damaged regions from WebViewHost to WebTestProxy Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (134393 => 134394) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-11-13 11:21:33 UTC (rev 134393) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-11-13 11:31:25 UTC (rev 134394) @@ -17,8 +17,12 @@ }, "ChromiumPublicApi": { "filename": r"Source/WebKit/chromium/public/" -r"|Source/Platform/chromium/public/", +r"|Source/Platform/chromium/public/" +r"|Tools/DumpRenderTree/chromium/TestRunner/public", }, +"ChromiumTestRunner": { +"filename": r"Tools/DumpRenderTree/chromium/TestRunner", +}, "AppleMacPublicApi": { "filename": r"Source/WebCore/bindings/objc/PublicDOMInterfaces.h" }, @@ -295,6 +299,7 @@ "CSS": [ "ale...@webkit.org", "macpher...@chromium.org", "cmarc...@webkit.org"], "ChromiumGraphics": [ "jam...@chromium.org", "cc-b...@chromium.org" ], "ChromiumPublicApi": [ "aba...@webkit.org", "dglaz...@chromium.org", "fi...@chromium.org", "jam...@chromium.org", "tkent+wk...@chromium.org" ], +"ChromiumTestRunner": [ "joc...@chromium.org" ], "DOMAttributes": [ "cmarc...@webkit.org", ], "EFL": [ "rak...@webkit.org", "gyuyoung@samsung.com" ], "EFLWebKit2PlatformSpecific": [ "gyuyoung@samsung.com", "rak...@webkit.org" ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134409] trunk/Tools
Title: [134409] trunk/Tools Revision 134409 Author joc...@chromium.org Date 2012-11-13 06:49:58 -0800 (Tue, 13 Nov 2012) Log Message [chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself https://bugs.webkit.org/show_bug.cgi?id=102075 Reviewed by Pavel Feldman. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp Diff Modified: trunk/Tools/ChangeLog (134408 => 134409) --- trunk/Tools/ChangeLog 2012-11-13 14:21:28 UTC (rev 134408) +++ trunk/Tools/ChangeLog 2012-11-13 14:49:58 UTC (rev 134409) @@ -1,3 +1,12 @@ +2012-11-13 Jochen Eisinger + +[chromium] TestRunner should depend on webkit_wtf_support instead of compiling the files itself +https://bugs.webkit.org/show_bug.cgi?id=102075 + +Reviewed by Pavel Feldman. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + 2012-11-13 Raphael Kubo da Costa [EFL][DRT] Remove extra layoutFrame() call when preparing to send an event via EventSender. Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (134408 => 134409) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-11-13 14:21:28 UTC (rev 134408) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-11-13 14:49:58 UTC (rev 134409) @@ -83,6 +83,7 @@ 'dependencies': [ 'TestRunner_resources', '<(source_dir)/WebKit/chromium/WebKit.gyp:webkit', +'<(source_dir)/WebKit/chromium/WebKit.gyp:webkit_wtf_support', '<(source_dir)/WebKit/chromium/WebKit.gyp:webkit_test_support', '<(source_dir)/WTF/WTF.gyp/WTF.gyp:wtf', '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support', @@ -116,12 +117,6 @@ '<(source_dir)/WebKit/chromium/public/gtk', ], }], -['inside_chromium_build==1 and component=="shared_library"', { -'sources': [ -'<(source_dir)/WebKit/chromium/src/ChromiumCurrentTime.cpp', -'<(source_dir)/WebKit/chromium/src/ChromiumThreading.cpp', -], -}], ], }, { ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [134967] trunk/Tools
Title: [134967] trunk/Tools Revision 134967 Author joc...@chromium.org Date 2012-11-16 10:30:47 -0800 (Fri, 16 Nov 2012) Log Message [chromium] delete unused testRunner methods https://bugs.webkit.org/show_bug.cgi?id=102479 Reviewed by Adam Barth. These methods aren't used by any layout test. Remove them to avoid bit rot * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::shouldBeginEditing): (WebViewHost::shouldEndEditing): (WebViewHost::shouldInsertNode): (WebViewHost::shouldInsertText): (WebViewHost::shouldChangeSelectedRange): (WebViewHost::shouldDeleteRange): (WebViewHost::shouldApplyStyle): (WebViewHost::startDragging): (WebViewHost::enterFullScreenNow): (WebViewHost::exitFullScreenNow): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp Diff Modified: trunk/Tools/ChangeLog (134966 => 134967) --- trunk/Tools/ChangeLog 2012-11-16 18:19:04 UTC (rev 134966) +++ trunk/Tools/ChangeLog 2012-11-16 18:30:47 UTC (rev 134967) @@ -1,3 +1,29 @@ +2012-11-16 Jochen Eisinger + +[chromium] delete unused testRunner methods +https://bugs.webkit.org/show_bug.cgi?id=102479 + +Reviewed by Adam Barth. + +These methods aren't used by any layout test. Remove them to avoid bit rot + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::shouldBeginEditing): +(WebViewHost::shouldEndEditing): +(WebViewHost::shouldInsertNode): +(WebViewHost::shouldInsertText): +(WebViewHost::shouldChangeSelectedRange): +(WebViewHost::shouldDeleteRange): +(WebViewHost::shouldApplyStyle): +(WebViewHost::startDragging): +(WebViewHost::enterFullScreenNow): +(WebViewHost::exitFullScreenNow): + 2012-11-15 Alexey Proskuryakov Private Browsing is a per-page setting that sets a global value Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (134966 => 134967) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-16 18:19:04 UTC (rev 134966) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-16 18:30:47 UTC (rev 134967) @@ -111,7 +111,6 @@ // they will use when called by _javascript_. The actual binding of those // names to their methods will be done by calling bindToJavaScript() (defined // by CppBoundClass, the parent to DRTTestRunner). -bindMethod("addFileToPasteboardOnDrag", &DRTTestRunner::addFileToPasteboardOnDrag); #if ENABLE(INPUT_SPEECH) bindMethod("addMockSpeechInputResult", &DRTTestRunner::addMockSpeechInputResult); bindMethod("setMockSpeechInputDumpRect", &DRTTestRunner::setMockSpeechInputDumpRect); @@ -132,7 +131,6 @@ bindMethod("didNotAcquirePointerLock", &DRTTestRunner::didNotAcquirePointerLock); #endif bindMethod("disableAutoResizeMode", &DRTTestRunner::disableAutoResizeMode); -bindMethod("disableImageLoading", &DRTTestRunner::disableImageLoading); bindMethod("display", &DRTTestRunner::display); bindMethod("displayInvalidatedRegion", &DRTTestRunner::displayInvalidatedRegion); bindMethod("dumpAsText", &DRTTestRunner::dumpAsText); @@ -174,7 +172,6 @@ bindMethod("notifyDone", &DRTTestRunner::notifyDone); bindMethod("numberOfActiveAnimations", &DRTTestRunner::numberOfActiveAnimations); bindMethod("numberOfPendingGeolocationPermissionRequests", &DRTTestRunner:: numberOfPendingGeolocationPermissionRequests); -bindMethod("objCIdentityIsEqual", &DRTTestRunner::objCIdentityIsEqual); bindMethod("overridePreference", &DRTTestRunner::overridePreference); bindMethod("pathToLocalResource", &DRTTestRunner::pathToLocalResource); bindMethod("pauseAnimationAtTimeOnElementWithId", &DRTTestRunner::pauseAnimationAtTimeOnElementWithId); @@ -189,7 +186,6 @@ bindMethod("removeOriginAccessWhitelistEntry", &DRTTestRunner::removeOriginAccessWhitelistEntry); bindMethod("repaintSweepHorizontally", &DRTTestRunner::repaintSweepHorizontally); bindMethod("resetPageVisibility", &DRTTestRunner::resetPageVisibility); -bindMethod("setAcceptsEditing", &DRTTestRunner::setAcceptsEditing); bindMethod("setAllowDisplayOfInsecureContent", &a
[webkit-changes] [135006] trunk/Tools
Title: [135006] trunk/Tools Revision 135006 Author joc...@chromium.org Date 2012-11-16 14:51:12 -0800 (Fri, 16 Nov 2012) Log Message [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost https://bugs.webkit.org/show_bug.cgi?id=102495 Reviewed by Adam Barth. When a drag operation is initiated in a layout test, we need to simulate a corresponding drop event, otherwise the WebViewImpl will sit there waiting for it. Instead of having the embedder taking care of this, move this into the TestRunner library. * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebKit): (WebTestProxyBase): (WebTestRunner::WebTestProxy::startDragging): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::startDragging): (WebTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (135005 => 135006) --- trunk/Tools/ChangeLog 2012-11-16 22:48:30 UTC (rev 135005) +++ trunk/Tools/ChangeLog 2012-11-16 22:51:12 UTC (rev 135006) @@ -1,3 +1,26 @@ +2012-11-16 Jochen Eisinger + +[chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost +https://bugs.webkit.org/show_bug.cgi?id=102495 + +Reviewed by Adam Barth. + +When a drag operation is initiated in a layout test, we need to +simulate a corresponding drop event, otherwise the WebViewImpl will sit +there waiting for it. Instead of having the embedder taking care of +this, move this into the TestRunner library. + +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebKit): +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::startDragging): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::startDragging): +(WebTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2012-11-16 Tien-Ren Chen Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (135005 => 135006) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2012-11-16 22:48:30 UTC (rev 135005) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2012-11-16 22:51:12 UTC (rev 135006) @@ -33,10 +33,15 @@ #include "Platform/chromium/public/WebRect.h" #include "WebKit/chromium/public/WebAccessibilityNotification.h" +#include "WebKit/chromium/public/WebDragOperation.h" #include "WebKit/chromium/public/WebNavigationPolicy.h" namespace WebKit { class WebAccessibilityObject; +class WebDragData; +class WebFrame; +class WebImage; +struct WebPoint; struct WebSize; } @@ -65,6 +70,7 @@ void show(WebKit::WebNavigationPolicy); void didAutoResize(const WebKit::WebSize&); void postAccessibilityNotification(const WebKit::WebAccessibilityObject&, WebKit::WebAccessibilityNotification); +void startDragging(WebKit::WebFrame*, const WebKit::WebDragData&, WebKit::WebDragOperationsMask, const WebKit::WebImage&, const WebKit::WebPoint&); private: WebTestInterfaces* m_testInterfaces; @@ -125,6 +131,11 @@ WebTestProxyBase::postAccessibilityNotification(object, notification); WebViewClientImpl::postAccessibilityNotification(object, notification); } +virtual void startDragging(WebKit::WebFrame* frame, const WebKit::WebDragData& data, WebKit::WebDragOperationsMask mask, const WebKit::WebImage& image, const WebKit::WebPoint& point) +{ +WebTestProxyBase::startDragging(frame, data, mask, image, point); +WebViewClientImpl::startDragging(frame, data, mask, image, point); +} }; } Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp (135005 => 135006) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-11-16 22:48:30 UTC (rev 135005) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-11-16 22:51:12 UTC (rev 135006) @@ -35,6 +35,7 @@ #include "WebAccessibilityNotification.h" #include "WebAccessibilityObject.h" #include "WebElement.h" +#include "WebEventSender.h" #include "WebNode.h" #include "WebTestDelegate.h" #include "WebTestInterfaces.h" @@ -212,4 +213,11 @@ } } +void WebTestProxyBase::startDragging(WebFrame*, const WebDragDa
[webkit-changes] [135008] trunk/Tools
Title: [135008] trunk/Tools Revision 135008 Author joc...@chromium.org Date 2012-11-16 15:05:33 -0800 (Fri, 16 Nov 2012) Log Message [chromium] move stubs from DRTTestRunner to TestRunner https://bugs.webkit.org/show_bug.cgi?id=102489 Reviewed by Adam Barth. This is part of moving all methods from DRTTestRunner to TestRunner. Instead of keeping one stub per method, I'm using a shared stub to clean up the code. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner): (WebTestRunner::TestRunner::fallbackMethod): (WebTestRunner::TestRunner::notImplemented): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (WebTestRunner): (TestRunner): (WebTestRunner::TestRunner::setDelegate): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::createMainWindow): (TestShell::~TestShell): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Diff Modified: trunk/Tools/ChangeLog (135007 => 135008) --- trunk/Tools/ChangeLog 2012-11-16 23:02:52 UTC (rev 135007) +++ trunk/Tools/ChangeLog 2012-11-16 23:05:33 UTC (rev 135008) @@ -1,5 +1,33 @@ 2012-11-16 Jochen Eisinger +[chromium] move stubs from DRTTestRunner to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=102489 + +Reviewed by Adam Barth. + +This is part of moving all methods from DRTTestRunner to TestRunner. +Instead of keeping one stub per method, I'm using a shared stub to +clean up the code. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner): +(WebTestRunner::TestRunner::fallbackMethod): +(WebTestRunner::TestRunner::notImplemented): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(WebTestRunner): +(TestRunner): +(WebTestRunner::TestRunner::setDelegate): +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::createMainWindow): +(TestShell::~TestShell): + +2012-11-16 Jochen Eisinger + [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost https://bugs.webkit.org/show_bug.cgi?id=102495 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (135007 => 135008) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-16 23:02:52 UTC (rev 135007) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-11-16 23:05:33 UTC (rev 135008) @@ -137,7 +137,6 @@ bindMethod("dumpBackForwardList", &DRTTestRunner::dumpBackForwardList); bindMethod("dumpChildFramesAsText", &DRTTestRunner::dumpChildFramesAsText); bindMethod("dumpChildFrameScrollPositions", &DRTTestRunner::dumpChildFrameScrollPositions); -bindMethod("dumpDatabaseCallbacks", &DRTTestRunner::dumpDatabaseCallbacks); bindMethod("dumpEditingCallbacks", &DRTTestRunner::dumpEditingCallbacks); bindMethod("dumpFrameLoadCallbacks", &DRTTestRunner::dumpFrameLoadCallbacks); bindMethod("dumpProgressFinishedCallback", &DRTTestRunner::dumpProgressFinishedCallback); @@ -160,9 +159,6 @@ bindMethod("forceRedSelectionColors", &DRTTestRunner::forceRedSelectionColors); #if ENABLE(NOTIFICATIONS) bindMethod("grantWebNotificationPermission", &DRTTestRunner::grantWebNotificationPermission); -bindMethod("denyWebNotificationPermission", &DRTTestRunner::denyWebNotificationPermission); -bindMethod("removeAllWebNotificationPermissions", &DRTTestRunner::removeAllWebNotificationPermissions); -bindMethod("simulateWebNotificationClick", &DRTTestRunner::simulateWebNotificationClick); #endif bindMethod("findString", &DRTTestRunner::findString); bindMethod("isCommandEnabled", &DRTTestRunner::isCommandEnabled); @@ -201,7 +197,6 @@ bindMethod("setDomainRelaxationForbiddenForURLScheme", &DRTTestRunner::setDomainRelaxationForbiddenForURLScheme); bindMethod("setAudioData", &DRTTestRunner::setAudioData); bindMethod("setGeolocationPermission", &DRTTestRunner::setGeolocationPermission); -bindMethod("setIconDatabaseEnabled", &DRTTestRunner::s
[webkit-changes] [135583] trunk/Source/WebCore
Title: [135583] trunk/Source/WebCore Revision 135583 Author joc...@chromium.org Date 2012-11-23 03:22:39 -0800 (Fri, 23 Nov 2012) Log Message REGRESSION (r135455): Compilation without SVG enabled broken https://bugs.webkit.org/show_bug.cgi?id=103108 Reviewed by Yury Semikhatsky. Move SVG-only code behind #if ENABLE(SVG) that was accidentially moved outside of the #if block during the refactoring. * platform/graphics/filters/FilterOperation.h: (ReferenceFilterOperation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h Diff Modified: trunk/Source/WebCore/ChangeLog (135582 => 135583) --- trunk/Source/WebCore/ChangeLog 2012-11-23 11:17:50 UTC (rev 135582) +++ trunk/Source/WebCore/ChangeLog 2012-11-23 11:22:39 UTC (rev 135583) @@ -1,3 +1,16 @@ +2012-11-23 Jochen Eisinger + +REGRESSION (r135455): Compilation without SVG enabled broken +https://bugs.webkit.org/show_bug.cgi?id=103108 + +Reviewed by Yury Semikhatsky. + +Move SVG-only code behind #if ENABLE(SVG) that was accidentially moved +outside of the #if block during the refactoring. + +* platform/graphics/filters/FilterOperation.h: +(ReferenceFilterOperation): + 2012-11-23 Julian Pastarmov REGRESSION (r128633): td changes size during re-layout of table although it shouldn't Modified: trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h (135582 => 135583) --- trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2012-11-23 11:17:50 UTC (rev 135582) +++ trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2012-11-23 11:22:39 UTC (rev 135583) @@ -28,7 +28,6 @@ #if ENABLE(CSS_FILTERS) -#include "CachedSVGDocumentReference.h" #include "Color.h" #include "FilterEffect.h" #include "LayoutSize.h" @@ -42,6 +41,10 @@ #include #endif +#if ENABLE(SVG) +#include "CachedSVGDocumentReference.h" +#endif + // Annoyingly, wingdi.h #defines this. #ifdef PASSTHROUGH #undef PASSTHROUGH @@ -170,8 +173,10 @@ const String& url() const { return m_url; } const String& fragment() const { return m_fragment; } +#if ENABLE(SVG) CachedSVGDocumentReference* cachedSVGDocumentReference() const { return m_cachedSVGDocumentReference.get(); } void setCachedSVGDocumentReference(PassOwnPtr cachedSVGDocumentReference) { m_cachedSVGDocumentReference = cachedSVGDocumentReference; } +#endif FilterEffect* filterEffect() const { return m_filterEffect.get(); } void setFilterEffect(PassRefPtr filterEffect) { m_filterEffect = filterEffect; } @@ -195,7 +200,9 @@ String m_url; String m_fragment; +#if ENABLE(SVG) OwnPtr m_cachedSVGDocumentReference; +#endif RefPtr m_filterEffect; }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [136241] branches/chromium/1312
Title: [136241] branches/chromium/1312 Revision 136241 Author joc...@chromium.org Date 2012-11-30 07:32:36 -0800 (Fri, 30 Nov 2012) Log Message Merge 135578 - REGRESSION (r128633): td changes size during re-layout of table although it shouldn't https://bugs.webkit.org/show_bug.cgi?id=102802 Patch by Julian Pastarmov on 2012-11-23 Reviewed by Ojan Vafai. Source/WebCore: The bug was caused by incorrectly rewriting a nested condition which caused the else clause to trigger in wrong cases. Test: fast/table/nested-tables-with-div-offset.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computePercentageLogicalHeight): Reverted wrong combination of nested if statements. LayoutTests: This test checks that table layout of some nested tables in quirks mode is computed correctly. * fast/table/nested-tables-with-div-offset-expected.txt: Added. * fast/table/nested-tables-with-div-offset.html: Added. TBR=commit-qu...@webkit.org Review URL: https://codereview.chromium.org/11414259 Modified Paths branches/chromium/1312/Source/WebCore/rendering/RenderBox.cpp Added Paths branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset.html Diff Copied: branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt (from rev 135578, trunk/LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt) (0 => 136241) --- branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt (rev 0) +++ branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset-expected.txt 2012-11-30 15:32:36 UTC (rev 136241) @@ -0,0 +1 @@ +PASS Copied: branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset.html (from rev 135578, trunk/LayoutTests/fast/table/nested-tables-with-div-offset.html) (0 => 136241) --- branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset.html (rev 0) +++ branches/chromium/1312/LayoutTests/fast/table/nested-tables-with-div-offset.html 2012-11-30 15:32:36 UTC (rev 136241) @@ -0,0 +1,34 @@ +
[webkit-changes] [143213] trunk/Tools
Title: [143213] trunk/Tools Revision 143213 Author joc...@chromium.org Date 2013-02-18 06:47:25 -0800 (Mon, 18 Feb 2013) Log Message [chromium] remove log spew from dumpAllBackForwardLists https://bugs.webkit.org/show_bug.cgi?id=110108 Reviewed by Nico Weber. * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp Diff Modified: trunk/Tools/ChangeLog (143212 => 143213) --- trunk/Tools/ChangeLog 2013-02-18 14:45:15 UTC (rev 143212) +++ trunk/Tools/ChangeLog 2013-02-18 14:47:25 UTC (rev 143213) @@ -1,3 +1,12 @@ +2013-02-18 Jochen Eisinger + +[chromium] remove log spew from dumpAllBackForwardLists +https://bugs.webkit.org/show_bug.cgi?id=110108 + +Reviewed by Nico Weber. + +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: + 2013-02-18 Christophe Dumez [EFL][WK2] Disable failing API tests Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp (143212 => 143213) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2013-02-18 14:45:15 UTC (rev 143212) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2013-02-18 14:47:25 UTC (rev 143213) @@ -400,7 +400,6 @@ { string result; unsigned windowCount = delegate->windowCount(); -fprintf(stderr, "windowCount = %d\n", windowCount); for (unsigned i = 0; i < windowCount; ++i) { size_t currentEntryIndex = 0; WebVector history; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143261] trunk/LayoutTests
Title: [143261] trunk/LayoutTests Revision 143261 Author joc...@chromium.org Date 2013-02-18 13:52:00 -0800 (Mon, 18 Feb 2013) Log Message clear databases before running read-transactions-running-concurrently test https://bugs.webkit.org/show_bug.cgi?id=110144 Reviewed by Nico Weber. Otherwise, we might not have enough quota when running this tests and lots of databases from previous tests are hanging around. * storage/websql/read-transactions-running-concurrently.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/websql/read-transactions-running-concurrently.html Diff Modified: trunk/LayoutTests/ChangeLog (143260 => 143261) --- trunk/LayoutTests/ChangeLog 2013-02-18 21:44:10 UTC (rev 143260) +++ trunk/LayoutTests/ChangeLog 2013-02-18 21:52:00 UTC (rev 143261) @@ -1,3 +1,15 @@ +2013-02-18 Jochen Eisinger + +clear databases before running read-transactions-running-concurrently test +https://bugs.webkit.org/show_bug.cgi?id=110144 + +Reviewed by Nico Weber. + +Otherwise, we might not have enough quota when running this tests and lots +of databases from previous tests are hanging around. + +* storage/websql/read-transactions-running-concurrently.html: + 2013-02-18 Philip Rogers Fix scaling of tiled SVG backgrounds on high-dpi displays Modified: trunk/LayoutTests/storage/websql/read-transactions-running-concurrently.html (143260 => 143261) --- trunk/LayoutTests/storage/websql/read-transactions-running-concurrently.html 2013-02-18 21:44:10 UTC (rev 143260) +++ trunk/LayoutTests/storage/websql/read-transactions-running-concurrently.html 2013-02-18 21:52:00 UTC (rev 143261) @@ -41,6 +41,7 @@ function runTest() { if (window.testRunner) { +testRunner.clearAllDatabases(); testRunner.dumpAsText(); testRunner.waitUntilDone(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143310] trunk/Source/WebKit/chromium
Title: [143310] trunk/Source/WebKit/chromium Revision 143310 Author joc...@chromium.org Date 2013-02-19 01:27:21 -0800 (Tue, 19 Feb 2013) Log Message [chromium] fix ScrollAnimatorNoneTest after r143295 https://bugs.webkit.org/show_bug.cgi?id=110189 Reviewed by Nico Weber. * tests/ScrollAnimatorNoneTest.cpp: (MockScrollableArea): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (143309 => 143310) --- trunk/Source/WebKit/chromium/ChangeLog 2013-02-19 09:22:23 UTC (rev 143309) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-19 09:27:21 UTC (rev 143310) @@ -1,3 +1,13 @@ +2013-02-19 Jochen Eisinger + +[chromium] fix ScrollAnimatorNoneTest after r143295 +https://bugs.webkit.org/show_bug.cgi?id=110189 + +Reviewed by Nico Weber. + +* tests/ScrollAnimatorNoneTest.cpp: +(MockScrollableArea): + 2013-02-18 Simon Fraser Clean up the boolean argument to visibleContentRect Modified: trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp (143309 => 143310) --- trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 2013-02-19 09:22:23 UTC (rev 143309) +++ trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 2013-02-19 09:27:21 UTC (rev 143310) @@ -65,7 +65,7 @@ MOCK_CONST_METHOD0(enclosingScrollableArea, ScrollableArea*()); MOCK_CONST_METHOD0(minimumScrollPosition, IntPoint()); MOCK_CONST_METHOD0(maximumScrollPosition, IntPoint()); -MOCK_CONST_METHOD1(visibleContentRect, IntRect(bool)); +MOCK_CONST_METHOD1(visibleContentRect, IntRect(VisibleContentRectIncludesScrollbars)); MOCK_CONST_METHOD0(contentsSize, IntSize()); MOCK_CONST_METHOD0(overhangAmount, IntSize()); MOCK_CONST_METHOD0(scrollbarsCanBeActive, bool()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [143480] trunk/Tools
Title: [143480] trunk/Tools Revision 143480 Author joc...@chromium.org Date 2013-02-20 10:45:45 -0800 (Wed, 20 Feb 2013) Log Message [chromium] use a WebTestProxyBase pointer to identify the window we need the history for https://bugs.webkit.org/show_bug.cgi?id=110346 Reviewed by Adam Barth. Using an index is very brittle, as the TestRunner API does not define any ordering of windows. Also, make TestRunner::shouldDumpBackForwardList() so content shell can trigger the capturing in the browser process before generating the text dump. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner): (WebTestRunner::WebTestDelegate::captureHistoryForWindow): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::captureTree): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::captureHistoryForWindow): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (143479 => 143480) --- trunk/Tools/ChangeLog 2013-02-20 18:45:22 UTC (rev 143479) +++ trunk/Tools/ChangeLog 2013-02-20 18:45:45 UTC (rev 143480) @@ -1,3 +1,31 @@ +2013-02-20 Jochen Eisinger + +[chromium] use a WebTestProxyBase pointer to identify the window we need the history for +https://bugs.webkit.org/show_bug.cgi?id=110346 + +Reviewed by Adam Barth. + +Using an index is very brittle, as the TestRunner API does not define +any ordering of windows. + +Also, make TestRunner::shouldDumpBackForwardList() so content shell can +trigger the capturing in the browser process before generating the +text dump. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner): +(WebTestRunner::WebTestDelegate::captureHistoryForWindow): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::captureTree): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::captureHistoryForWindow): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-02-19 Rouslan Solomakhin [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (143479 => 143480) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-02-20 18:45:22 UTC (rev 143479) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-02-20 18:45:45 UTC (rev 143480) @@ -36,6 +36,8 @@ #include "Platform/chromium/public/WebVector.h" #include +#define WEBTESTRUNNER_NEW_HISTORY_CAPTURE + namespace WebKit { class WebGamepads; class WebHistoryItem; @@ -47,6 +49,7 @@ struct WebPreferences; class WebTask; +class WebTestProxyBase; class WebTestDelegate { public: @@ -93,7 +96,7 @@ virtual void reload() { } virtual void loadURLForFrame(const WebKit::WebURL&, const std::string&) { } virtual bool allowExternalPages() { return false; } -virtual void captureHistoryForWindow(size_t windowIndex, WebKit::WebVector* history, size_t* currentEntryIndex) { } +virtual void captureHistoryForWindow(WebTestProxyBase*, WebKit::WebVector* history, size_t* currentEntryIndex) { } }; } Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h (143479 => 143480) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h 2013-02-20 18:45:22 UTC (rev 143479) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h 2013-02-20 18:45:45 UTC (rev 143480) @@ -43,6 +43,7 @@ virtual bool shouldGeneratePixelResults() = 0; virtual bool shouldDumpAsAudio() const = 0; virtual const WebKit::WebArrayBufferView* audioData() const = 0; +virtual bool shouldDumpBackForwardList() const = 0; virtual WebKit::WebPermissionClient* webPermissions() const = 0; }; Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h (143479 => 143480) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h 2013-02-20 18:45:22 UTC (rev 143479) +++ trunk/Tools/DumpRend
[webkit-changes] [143638] trunk/Tools
Title: [143638] trunk/Tools Revision 143638 Author joc...@chromium.org Date 2013-02-21 12:31:41 -0800 (Thu, 21 Feb 2013) Log Message [chromium] document WebTestDelegate and WebTestRunner interfaces https://bugs.webkit.org/show_bug.cgi?id=110472 Reviewed by Adam Barth. Also remove the default implementation of the remaining WebTestDelegate methods now that all embedders provide this interface. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h Diff Modified: trunk/Tools/ChangeLog (143637 => 143638) --- trunk/Tools/ChangeLog 2013-02-21 20:00:33 UTC (rev 143637) +++ trunk/Tools/ChangeLog 2013-02-21 20:31:41 UTC (rev 143638) @@ -1,3 +1,18 @@ +2013-02-21 Jochen Eisinger + +[chromium] document WebTestDelegate and WebTestRunner interfaces +https://bugs.webkit.org/show_bug.cgi?id=110472 + +Reviewed by Adam Barth. + +Also remove the default implementation of the remaining WebTestDelegate +methods now that all embedders provide this interface. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner): + 2013-02-19 Mark Hahnenberg Objective-C API: Need a way to use the Objective-C _javascript_ API with WebKit Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (143637 => 143638) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-02-21 20:00:33 UTC (rev 143637) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-02-21 20:31:41 UTC (rev 143638) @@ -53,9 +53,15 @@ class WebTestDelegate { public: +// Set and clear the edit command to execute on the next call to +// WebViewClient::handleCurrentKeyboardEvent(). virtual void clearEditCommand() = 0; virtual void setEditCommand(const std::string& name, const std::string& value) = 0; + +// Set the gamepads to return from WebKitPlatformSupport::sampleGamepads(). virtual void setGamepadData(const WebKit::WebGamepads&) = 0; + +// Add a message to the text dump for the layout test. virtual void printMessage(const std::string& message) = 0; // The delegate takes ownership of the WebTask objects and is responsible @@ -63,40 +69,91 @@ virtual void postTask(WebTask*) = 0; virtual void postDelayedTask(WebTask*, long long ms) = 0; +// Register a new isolated filesystem with the given files, and return the +// new filesystem id. virtual WebKit::WebString registerIsolatedFileSystem(const WebKit::WebVector& absoluteFilenames) = 0; + +// Gets the current time in milliseconds since the UNIX epoch. virtual long long getCurrentTimeInMillisecond() = 0; + +// Convert the provided relative path into an absolute path. virtual WebKit::WebString getAbsoluteWebStringFromUTF8Path(const std::string& path) = 0; -// Methods used by TestRunner. -// FIXME: Make these methods pure virtual once the TestRunner is part of -// the public TestRunner API. -virtual WebKit::WebURL localFileToDataURL(const WebKit::WebURL&) { return WebKit::WebURL(); } -virtual WebKit::WebURL rewriteLayoutTestsURL(const std::string&) { return WebKit::WebURL(); } -virtual WebPreferences* preferences() { return 0; } -virtual void applyPreferences() { }; -virtual std::string makeURLErrorDescription(const WebKit::WebURLError&) { return std::string(); } -virtual void setClientWindowRect(const WebKit::WebRect&) { } -virtual void showDevTools() { } -virtual void closeDevTools() { } -virtual void evaluateInWebInspector(long, const std::string&) { } -virtual void clearAllDatabases() { } -virtual void setDatabaseQuota(int) { } -virtual void setDeviceScaleFactor(float) { } -virtual void setFocus(bool) { } -virtual void setAcceptAllCookies(bool) { } -virtual std::string pathToLocalResource(const std::string& resource) { return std::string(); } -virtual void setLocale(const std::string&) { } -virtual void testFinished() { } -virtual void testTimedOut() { } -virtual bool isBeingDebugged() { return false; } -virtual int layoutTestTimeout() { return 30 * 1000; } -virtual void closeRemainingWindows() { } -virtual int navigationEntryCount() { return 0; } -virtual void goToOffset(int) { } -virtual void reload() { } -virtual void loadURLForFrame(const WebKit::WebURL&, const std::string&) { } -virtual bool allowExternalPages() { return false; } -virtual void captureHistoryForWindow(WebTes
[webkit-changes] [143898] trunk/Tools
Title: [143898] trunk/Tools Revision 143898 Author joc...@chromium.org Date 2013-02-25 02:33:37 -0800 (Mon, 25 Feb 2013) Log Message [chromium] move WebRuntimeFeatures configuration to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=110712 Reviewed by Nico Weber. * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: (WebTestRunner::TestInterfaces::TestInterfaces): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Diff Modified: trunk/Tools/ChangeLog (143897 => 143898) --- trunk/Tools/ChangeLog 2013-02-25 10:04:57 UTC (rev 143897) +++ trunk/Tools/ChangeLog 2013-02-25 10:33:37 UTC (rev 143898) @@ -1,3 +1,15 @@ +2013-02-25 Jochen Eisinger + +[chromium] move WebRuntimeFeatures configuration to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=110712 + +Reviewed by Nico Weber. + +* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: +(WebTestRunner::TestInterfaces::TestInterfaces): +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::TestShell): + 2013-02-25 Nico Weber Make ninja the default build system for build-webkit --chromium on windows Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp (143897 => 143898) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp 2013-02-25 10:04:57 UTC (rev 143897) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp 2013-02-25 10:33:37 UTC (rev 143898) @@ -37,6 +37,7 @@ #include "TestRunner.h" #include "TextInputController.h" #include "WebCache.h" +#include "WebRuntimeFeatures.h" #include #include #include @@ -55,6 +56,33 @@ , m_webView(0) , m_delegate(0) { +WebRuntimeFeatures::enableDataTransferItems(true); +WebRuntimeFeatures::enableDeviceMotion(false); +WebRuntimeFeatures::enableGeolocation(true); +WebRuntimeFeatures::enableIndexedDatabase(true); +WebRuntimeFeatures::enableInputTypeDateTime(true); +WebRuntimeFeatures::enableInputTypeDateTimeLocal(true); +WebRuntimeFeatures::enableInputTypeMonth(true); +WebRuntimeFeatures::enableInputTypeTime(true); +WebRuntimeFeatures::enableInputTypeWeek(true); +WebRuntimeFeatures::enableFileSystem(true); +WebRuntimeFeatures::enableJavaScriptI18NAPI(true); +WebRuntimeFeatures::enableMediaSource(true); +WebRuntimeFeatures::enableEncryptedMedia(true); +WebRuntimeFeatures::enableMediaStream(true); +WebRuntimeFeatures::enablePeerConnection(true); +WebRuntimeFeatures::enableWebAudio(true); +WebRuntimeFeatures::enableVideoTrack(true); +WebRuntimeFeatures::enableGamepad(true); +WebRuntimeFeatures::enableShadowDOM(true); +WebRuntimeFeatures::enableCustomDOMElements(true); +WebRuntimeFeatures::enableStyleScoped(true); +WebRuntimeFeatures::enableScriptedSpeech(true); +WebRuntimeFeatures::enableRequestAutocomplete(true); +WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures(true); +WebRuntimeFeatures::enableSeamlessIFrames(true); +WebRuntimeFeatures::enableCanvasPath(true); + resetAll(); } Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (143897 => 143898) --- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-02-25 10:04:57 UTC (rev 143897) +++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-02-25 10:33:37 UTC (rev 143898) @@ -43,7 +43,6 @@ #include "WebHistoryItem.h" #include "WebIDBFactory.h" #include "WebTestingSupport.h" -#include "WebRuntimeFeatures.h" #include "WebSettings.h" #include "WebTestProxy.h" #include "WebTestRunner.h" @@ -126,33 +125,6 @@ , m_dumpWhenFinished(true) , m_isDisplayingModalDialog(false) { -WebRuntimeFeatures::enableDataTransferItems(true); -WebRuntimeFeatures::enableDeviceMotion(false); -WebRuntimeFeatures::enableGeolocation(true); -WebRuntimeFeatures::enableIndexedDatabase(true); -WebRuntimeFeatures::enableInputTypeDateTime(true); -WebRuntimeFeatures::enableInputTypeDateTimeLocal(true); -WebRuntimeFeatures::enableInputTypeMonth(true); -WebRuntimeFeatures::enableInputTypeTime(true); -WebRuntimeFeatures::enableInputTypeWeek(true); -WebRuntimeFeatures::enableFileSystem(true); -WebRuntimeFeatures::enableJavaScriptI18NAPI(true); -WebRuntimeFeatures::enableMediaSource(true); -WebRuntimeFeatures::enableEncryptedMedia(true); -WebRuntimeFeatures::enableMediaStream(true); -WebRuntimeFeatures::enablePeerConnection(true); -WebRuntimeFeatures::enableWebAudio(true); -WebRuntimeFeatures::enableVideoTrack(true); -WebRuntimeFeatures::enableGamepad(true); -WebRuntimeFeatures::enableS
[webkit-changes] [144034] trunk/LayoutTests
Title: [144034] trunk/LayoutTests Revision 144034 Author joc...@chromium.org Date 2013-02-26 03:22:45 -0800 (Tue, 26 Feb 2013) Log Message [chromium] add content shell specific TestExpectations https://bugs.webkit.org/show_bug.cgi?id=110710 Reviewed by Eric Seidel. For now, add tests that pass on content shell but fail on DRT. Next, I will file bugs for all the remaining failing tests and skip them here to ease the transition from DRT. * platform/chromium/ContentShellTestExpectations: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/ContentShellTestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (144033 => 144034) --- trunk/LayoutTests/ChangeLog 2013-02-26 11:09:16 UTC (rev 144033) +++ trunk/LayoutTests/ChangeLog 2013-02-26 11:22:45 UTC (rev 144034) @@ -1,3 +1,16 @@ +2013-02-26 Jochen Eisinger + +[chromium] add content shell specific TestExpectations +https://bugs.webkit.org/show_bug.cgi?id=110710 + +Reviewed by Eric Seidel. + +For now, add tests that pass on content shell but fail on DRT. +Next, I will file bugs for all the remaining failing tests and skip +them here to ease the transition from DRT. + +* platform/chromium/ContentShellTestExpectations: Added. + 2013-02-26 Zoltan Arvai [Qt] Unreviewed gardening. Added: trunk/LayoutTests/platform/chromium/ContentShellTestExpectations (0 => 144034) --- trunk/LayoutTests/platform/chromium/ContentShellTestExpectations (rev 0) +++ trunk/LayoutTests/platform/chromium/ContentShellTestExpectations 2013-02-26 11:22:45 UTC (rev 144034) @@ -0,0 +1,50 @@ +# These are additional layout test expectations for the Chromium port(s) of WebKit when using the content shell. +# +# See http://trac.webkit.org/wiki/TestExpectations for more information on this file. + +# - +# Expected to crash, but passed +# - +crbug.com/111316 [ Linux ] media/video-error-does-not-exist.html [ Pass ] +crbug.com/111316 [ Linux ] plugins/destroy-on-setwindow.html [ Pass ] +crbug.com/111316 [ Linux ] plugins/get-url-notify-with-url-that-fails-to-load.html [ Pass ] + +# - +# Expected to timeout, but passed +# - +crbug.com/111316 [ Linux ] fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html [ Pass ] +crbug.com/111316 [ Linux ] fast/loader/subresource-willSendRequest-null.html [ Pass ] +crbug.com/111316 [ Linux ] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm [ Pass ] +crbug.com/111316 [ Linux ] platform/chromium/virtual/gpu/fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html [ Pass ] +crbug.com/111316 [ Linux ] plugins/get-url-with-_javascript_-url.html [ Pass ] + +# - +# Expected to fail, but passed +# - +crbug.com/111316 [ Linux ] canvas/philip/tests/2d.gradient.interpolate.colouralpha.html [ Pass ] +crbug.com/111316 [ Linux ] compositing/color-matching/image-color-matching.html [ Pass ] +crbug.com/111316 [ Linux ] compositing/visibility/visibility-image-layers.html [ Pass ] +crbug.com/111316 [ Linux ] css3/selectors3/xhtml/css3-modsel-15c.xml [ Pass ] +crbug.com/111316 [ Linux ] editing/spelling/grammar.html [ Pass ] +crbug.com/111316 [ Linux ] fast/backgrounds/background-opaque-clipped-gradients.html [ Pass ] +crbug.com/111316 [ Linux ] fast/backgrounds/background-opaque-images-over-color.html [ Pass ] +crbug.com/111316 [ Linux ] fast/backgrounds/gradient-background-shadow.html [ Pass ] +crbug.com/111316 [ Linux ] fast/borders/fieldsetBorderRadius.html [ Pass ] +crbug.com/111316 [ Linux ] fast/css/sticky/sticky-left-percentage.html [ Pass ] +crbug.com/111316 [ Linux ] fast/filesystem/op-restricted-names.html [ Pass ] +crbug.com/111316 [ Linux ] fast/images/gif-loop-count.html [ Pass ] +crbug.com/111316 [ Linux ] fast/js/cross-frame-bad-time.html [ Pass ] +crbug.com/111316 [ Linux ] fast/loader/_javascript_-url-in-embed.html [ Pass ] +crbug.com/111316 [ Linux ] fast/regions/seamless-iframe-flowed-into-regions.html [ Pass ] +crbug.com/111316 [ Linux ] fast/sub-pixel/transformed-iframe-copy-on-scroll.html [ Pass ] +crbug.com/111316 [ Linux ] http/tests/cache/cancel-multiple-post-xhrs.html [ Pass ] +crbug.com/111316 [ Linux ] http/tests/loading/redirect-methods.html [ Pass ] +crbug.com/111316 [ Linux ] http/tests/loading/text-content-type-with-binary-extension.html [ Pass ] +crbug.com/111316 [ Linux ] http/tests/misc/favicon-loads-with-images-disabled.html [ Pass ] +crbug.com/111316 [ Linux ] platform/chromium/virtual/deferred/fast/images/gif-loop-count.html [ Pass ] +crbug.com/111316 [
[webkit-changes] [144187] trunk/LayoutTests
Title: [144187] trunk/LayoutTests Revision 144187 Author joc...@chromium.org Date 2013-02-27 08:03:01 -0800 (Wed, 27 Feb 2013) Log Message Add plugins test expectations for content_shell Unreviewed gardening. * platform/chromium/ContentShellTestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/ContentShellTestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (144186 => 144187) --- trunk/LayoutTests/ChangeLog 2013-02-27 15:48:34 UTC (rev 144186) +++ trunk/LayoutTests/ChangeLog 2013-02-27 16:03:01 UTC (rev 144187) @@ -1,3 +1,11 @@ +2013-02-27 Jochen Eisinger + +Add plugins test expectations for content_shell + +Unreviewed gardening. + +* platform/chromium/ContentShellTestExpectations: + 2013-02-27 Kent Tamura REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator Modified: trunk/LayoutTests/platform/chromium/ContentShellTestExpectations (144186 => 144187) --- trunk/LayoutTests/platform/chromium/ContentShellTestExpectations 2013-02-27 15:48:34 UTC (rev 144186) +++ trunk/LayoutTests/platform/chromium/ContentShellTestExpectations 2013-02-27 16:03:01 UTC (rev 144187) @@ -48,3 +48,15 @@ crbug.com/111316 [ Linux ] svg/custom/transform-with-shadow-and-gradient.svg [ Pass ] crbug.com/111316 [ Linux ] svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr.html [ Pass ] crbug.com/111316 [ Linux ] svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop.html [ Pass ] + +# - +# Triaged failures +# - +crbug.com/178709 plugins/document-open.html [ Text ] +crbug.com/178719 plugins/reloadplugins-and-pages.html [ Timeout ] +crbug.com/178724 platform/chromium/plugins/get-url-with-iframe-target-no-crash.html [ Timeout ] +crbug.com/178744 plugins/npruntime/browser-object-identity.html [ Text ] +crbug.com/178745 [ Debug ] plugins/geturlnotify-during-document-teardown.html [ Crash ] +crbug.com/178745 [ Debug ] plugins/open-and-close-window-with-plugin.html [ Crash ] +crbug.com/178745 [ Release ] plugins/geturlnotify-during-document-teardown.html [ Text ] +crbug.com/178745 [ Release ] plugins/open-and-close-window-with-plugin.html [ Text ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144224] trunk
Title: [144224] trunk Revision 144224 Author joc...@chromium.org Date 2013-02-27 12:38:31 -0800 (Wed, 27 Feb 2013) Log Message plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async https://bugs.webkit.org/show_bug.cgi?id=110973 Reviewed by Adam Barth. There is nothing that ensures that the log messages from the plugin come in before the layout test finished loading. Tools: * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: (PassDifferentNPPStruct::NPP_SetWindow): * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_SetWindow): LayoutTests: * platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed. * plugins/netscape-plugin-setwindow-size-2.html: * plugins/netscape-plugin-setwindow-size.html: * plugins/pass-different-npp-struct.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/plugins/netscape-plugin-setwindow-size-2.html trunk/LayoutTests/plugins/netscape-plugin-setwindow-size.html trunk/LayoutTests/plugins/pass-different-npp-struct.html trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp Removed Paths trunk/LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (144223 => 144224) --- trunk/LayoutTests/ChangeLog 2013-02-27 20:37:12 UTC (rev 144223) +++ trunk/LayoutTests/ChangeLog 2013-02-27 20:38:31 UTC (rev 144224) @@ -1,3 +1,18 @@ +2013-02-27 Jochen Eisinger + +plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async +https://bugs.webkit.org/show_bug.cgi?id=110973 + +Reviewed by Adam Barth. + +There is nothing that ensures that the log messages from the plugin +come in before the layout test finished loading. + +* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed. +* plugins/netscape-plugin-setwindow-size-2.html: +* plugins/netscape-plugin-setwindow-size.html: +* plugins/pass-different-npp-struct.html: + 2013-02-27 Manuel Rego Casasnovas Add smartInsertDeleteEnabled setting to WebCore::Page Deleted: trunk/LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt (144223 => 144224) --- trunk/LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt 2013-02-27 20:37:12 UTC (rev 144223) +++ trunk/LayoutTests/platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt 2013-02-27 20:38:31 UTC (rev 144224) @@ -1 +0,0 @@ -This tests that a hidden plug-in gets a correct NPP_SetWindow the first time. Modified: trunk/LayoutTests/plugins/netscape-plugin-setwindow-size-2.html (144223 => 144224) --- trunk/LayoutTests/plugins/netscape-plugin-setwindow-size-2.html 2013-02-27 20:37:12 UTC (rev 144223) +++ trunk/LayoutTests/plugins/netscape-plugin-setwindow-size-2.html 2013-02-27 20:38:31 UTC (rev 144224) @@ -3,6 +3,7 @@ </span><span class="cx"> if (window.testRunner) { </span><span class="cx"> testRunner.dumpAsText(); </span><ins>+testRunner.waitUntilDone(); </ins><span class="cx"> testRunner.setWindowIsKey(false); </span><span class="cx"> } </span><span class="cx"> </span></span></pre></div> <a rel="nofollow" id="trunkLayoutTestspluginsnetscapepluginsetwindowsizehtml"></a> <div class="modfile"><h4>Modified: trunk/LayoutTests/plugins/netscape-plugin-setwindow-size.html (144223 => 144224)</h4> <pre class="diff"><span> <span class="info">--- trunk/LayoutTests/plugins/netscape-plugin-setwindow-size.html 2013-02-27 20:37:12 UTC (rev 144223) +++ trunk/LayoutTests/plugins/netscape-plugin-setwindow-size.html 2013-02-27 20:38:31 UTC (rev 144224) </span><span class="lines">@@ -1,8 +1,10 @@ </span><span class="cx"> <html> </span><span class="cx"> <head> </span><span class="cx"> <script> </span><del>-if (window.testRunner) </del><ins>+if (window.testRunner) { </ins><span class="cx"> testRunner.dumpAsText(); </span><ins>+testRunner.waitUntilDone(); +} </ins><span class="cx"> Modified: trunk/LayoutTests/plugins/pass-different-npp-struct.html (144223 => 144224) --- trunk/LayoutTests/plugins/pass-different-npp-struct.html 2013-02-27 20:37:12 UTC (rev 144223) +++ trunk/LayoutTests/plugins/pass-different-npp-struct.html 2013-02-27 20:38:31 UTC (rev 144224) @@ -11,8 +11,10 @@ This test
[webkit-changes] [144230] trunk/LayoutTests
Title: [144230] trunk/LayoutTests Revision 144230 Author joc...@chromium.org Date 2013-02-27 12:58:05 -0800 (Wed, 27 Feb 2013) Log Message Skip media tests that fail on content_shell Unreviewed gardening. * platform/chromium/ContentShellTestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/ContentShellTestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (144229 => 144230) --- trunk/LayoutTests/ChangeLog 2013-02-27 20:50:35 UTC (rev 144229) +++ trunk/LayoutTests/ChangeLog 2013-02-27 20:58:05 UTC (rev 144230) @@ -1,5 +1,13 @@ 2013-02-27 Jochen Eisinger +Skip media tests that fail on content_shell + +Unreviewed gardening. + +* platform/chromium/ContentShellTestExpectations: + +2013-02-27 Jochen Eisinger + plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async https://bugs.webkit.org/show_bug.cgi?id=110973 Modified: trunk/LayoutTests/platform/chromium/ContentShellTestExpectations (144229 => 144230) --- trunk/LayoutTests/platform/chromium/ContentShellTestExpectations 2013-02-27 20:50:35 UTC (rev 144229) +++ trunk/LayoutTests/platform/chromium/ContentShellTestExpectations 2013-02-27 20:58:05 UTC (rev 144230) @@ -52,11 +52,32 @@ # - # Triaged failures # - -crbug.com/178709 plugins/document-open.html [ Text ] +crbug.com/178709 plugins/document-open.html [ Failure ] crbug.com/178719 plugins/reloadplugins-and-pages.html [ Timeout ] crbug.com/178724 platform/chromium/plugins/get-url-with-iframe-target-no-crash.html [ Timeout ] -crbug.com/178744 plugins/npruntime/browser-object-identity.html [ Text ] +crbug.com/178744 plugins/npruntime/browser-object-identity.html [ Failure ] crbug.com/178745 [ Debug ] plugins/geturlnotify-during-document-teardown.html [ Crash ] crbug.com/178745 [ Debug ] plugins/open-and-close-window-with-plugin.html [ Crash ] -crbug.com/178745 [ Release ] plugins/geturlnotify-during-document-teardown.html [ Text ] -crbug.com/178745 [ Release ] plugins/open-and-close-window-with-plugin.html [ Text ] +crbug.com/178745 [ Release ] plugins/geturlnotify-during-document-teardown.html [ Failure ] +crbug.com/178745 [ Release ] plugins/open-and-close-window-with-plugin.html [ Failure ] +crbug.com/178830 media/controls-after-reload.html [ ImageOnlyFailure ] +crbug.com/178830 media/controls-strict.html [ ImageOnlyFailure ] +crbug.com/178830 media/controls-styling-strict.html [ ImageOnlyFailure ] +crbug.com/178830 media/controls-styling.html [ ImageOnlyFailure ] +crbug.com/178830 media/controls-without-preload.html [ ImageOnlyFailure ] +crbug.com/178830 media/media-document-audio-repaint.html [ ImageOnlyFailure ] +crbug.com/178830 media/track/track-cue-rendering-horizontal.html [ ImageOnlyFailure ] +crbug.com/178830 media/track/track-cue-rendering-vertical.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-aspect-ratio.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-canvas-alpha.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-colorspace-yuv420.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-colorspace-yuv422.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-controls-rendering.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-display-toggle.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-frame-accurate-seek.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-layer-crash.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-no-audio.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-playing-and-pause.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-transformed.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-zoom-controls.html [ ImageOnlyFailure ] +crbug.com/178830 media/video-zoom.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144231] trunk/Source/Platform
Title: [144231] trunk/Source/Platform Revision 144231 Author joc...@chromium.org Date 2013-02-27 13:20:38 -0800 (Wed, 27 Feb 2013) Log Message [chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform https://bugs.webkit.org/show_bug.cgi?id=110953 Reviewed by Adam Barth. This patch makes it easier to mock the hyphenation related methods. * Platform.gypi: * chromium/public/Platform.h: (WebKit): (Platform): (WebKit::Platform::hyphenator): * chromium/public/WebHyphenator.h: Added. (WebKit): (WebHyphenator): (WebKit::WebHyphenator::canHyphenate): (WebKit::WebHyphenator::computeLastHyphenLocation): (WebKit::WebHyphenator::~WebHyphenator): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/Platform.gypi trunk/Source/Platform/chromium/public/Platform.h Added Paths trunk/Source/Platform/chromium/public/WebHyphenator.h Diff Modified: trunk/Source/Platform/ChangeLog (144230 => 144231) --- trunk/Source/Platform/ChangeLog 2013-02-27 20:58:05 UTC (rev 144230) +++ trunk/Source/Platform/ChangeLog 2013-02-27 21:20:38 UTC (rev 144231) @@ -1,3 +1,24 @@ +2013-02-27 Jochen Eisinger + +[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform +https://bugs.webkit.org/show_bug.cgi?id=110953 + +Reviewed by Adam Barth. + +This patch makes it easier to mock the hyphenation related methods. + +* Platform.gypi: +* chromium/public/Platform.h: +(WebKit): +(Platform): +(WebKit::Platform::hyphenator): +* chromium/public/WebHyphenator.h: Added. +(WebKit): +(WebHyphenator): +(WebKit::WebHyphenator::canHyphenate): +(WebKit::WebHyphenator::computeLastHyphenLocation): +(WebKit::WebHyphenator::~WebHyphenator): + 2013-02-27 Mark Pilgrim [Chromium] Remove unused WebKitPlatformSupport class Modified: trunk/Source/Platform/Platform.gypi (144230 => 144231) --- trunk/Source/Platform/Platform.gypi 2013-02-27 20:58:05 UTC (rev 144230) +++ trunk/Source/Platform/Platform.gypi 2013-02-27 21:20:38 UTC (rev 144231) @@ -74,6 +74,7 @@ 'chromium/public/WebHTTPBody.h', 'chromium/public/WebHTTPHeaderVisitor.h', 'chromium/public/WebHTTPLoadInfo.h', +'chromium/public/WebHyphenator.h', 'chromium/public/WebImage.h', 'chromium/public/WebImageLayer.h', 'chromium/public/WebIOSurfaceLayer.h', Modified: trunk/Source/Platform/chromium/public/Platform.h (144230 => 144231) --- trunk/Source/Platform/chromium/public/Platform.h 2013-02-27 20:58:05 UTC (rev 144230) +++ trunk/Source/Platform/chromium/public/Platform.h 2013-02-27 21:20:38 UTC (rev 144231) @@ -59,6 +59,7 @@ class WebFlingAnimator; class WebGestureCurveTarget; class WebGestureCurve; +class WebHyphenator; class WebMediaStreamCenter; class WebMediaStreamCenterClient; class WebMessagePortChannel; @@ -111,7 +112,10 @@ // May return null on some platforms. virtual WebThemeEngine* themeEngine() { return 0; } +// Must return non-null. +virtual WebHyphenator* hyphenator() { return 0; } + // Audio -- virtual double audioHardwareSampleRate() { return 0; } @@ -182,6 +186,8 @@ // Hyphenation - +// FIXME: Remove deprecated API. + // Returns whether we can support hyphenation for the given locale. virtual bool canHyphenate(const WebString& locale) { return false; } Added: trunk/Source/Platform/chromium/public/WebHyphenator.h (0 => 144231) --- trunk/Source/Platform/chromium/public/WebHyphenator.h (rev 0) +++ trunk/Source/Platform/chromium/public/WebHyphenator.h 2013-02-27 21:20:38 UTC (rev 144231) @@ -0,0 +1,53 @@ +/* + * Copyright (C) 2013 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES O
[webkit-changes] [144360] trunk
Title: [144360] trunk Revision 144360 Author joc...@chromium.org Date 2013-02-28 13:45:58 -0800 (Thu, 28 Feb 2013) Log Message Meta referrer isn't honored for window.open https://bugs.webkit.org/show_bug.cgi?id=111076 Reviewed by Adam Barth. Source/WebCore: Test: http/tests/security/referrer-policy-window-open.html * loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): loadFrameRequest() will set the correct referrer (WebCore::createWindow): This code is required for the inspector which doesn't set the referrer * page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): LayoutTests: * http/tests/security/referrer-policy-window-open-expected.txt: Added. * http/tests/security/referrer-policy-window-open.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/page/DOMWindow.cpp Added Paths trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html Diff Modified: trunk/LayoutTests/ChangeLog (144359 => 144360) --- trunk/LayoutTests/ChangeLog 2013-02-28 21:37:47 UTC (rev 144359) +++ trunk/LayoutTests/ChangeLog 2013-02-28 21:45:58 UTC (rev 144360) @@ -1,3 +1,13 @@ +2013-02-28 Jochen Eisinger + +Meta referrer isn't honored for window.open +https://bugs.webkit.org/show_bug.cgi?id=111076 + +Reviewed by Adam Barth. + +* http/tests/security/referrer-policy-window-open-expected.txt: Added. +* http/tests/security/referrer-policy-window-open.html: Added. + 2013-02-28 Kondapally Kalyan [EFL][WebGL] Enable compositing/webgl/webgl-reflection.html. Added: trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt (0 => 144360) --- trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/security/referrer-policy-window-open-expected.txt 2013-02-28 21:45:58 UTC (rev 144360) @@ -0,0 +1,5 @@ +This test opens a new window. It passes, if the referrer is the origin only. + +HTTP Referer header is http://127.0.0.1:8000/ +Referrer is http://127.0.0.1:8000/ + Added: trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html (0 => 144360) --- trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html (rev 0) +++ trunk/LayoutTests/http/tests/security/referrer-policy-window-open.html 2013-02-28 21:45:58 UTC (rev 144360) @@ -0,0 +1,34 @@ + + + + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.waitUntilDone(); +testRunner.setCanOpenWindows(); +} + +window.addEventListener("message", receiveMessage, false); + +function receiveMessage(evt) { +if (evt.data == "done") { +if (window.testRunner) +testRunner.notifyDone(); +} else { +document.getElementById("log").innerHTML += evt.data + "<br>"; +} +} + + + + +This test opens a new window. It passes, if the referrer is the origin +only. + + + + +window.open("resources/referrer-policy-postmessage.php"); + + + Modified: trunk/Source/WebCore/ChangeLog (144359 => 144360) --- trunk/Source/WebCore/ChangeLog 2013-02-28 21:37:47 UTC (rev 144359) +++ trunk/Source/WebCore/ChangeLog 2013-02-28 21:45:58 UTC (rev 144360) @@ -1,3 +1,18 @@ +2013-02-28 Jochen Eisinger + +Meta referrer isn't honored for window.open +https://bugs.webkit.org/show_bug.cgi?id=111076 + +Reviewed by Adam Barth. + +Test: http/tests/security/referrer-policy-window-open.html + +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::urlSelected): loadFrameRequest() will set the correct referrer +(WebCore::createWindow): This code is required for the inspector which doesn't set the referrer +* page/DOMWindow.cpp: +(WebCore::DOMWindow::createWindow): + 2013-02-28 Bruno de Oliveira Abinader [texmap] Remove redundant defines on TextureMapperGL Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (144359 => 144360) --- trunk/Source/WebCore/loader/FrameLoader.cpp 2013-02-28 21:37:47 UTC (rev 144359) +++ trunk/Source/WebCore/loader/FrameLoader.cpp 2013-02-28 21:45:58 UTC (rev 144360) @@ -311,8 +311,6 @@ if (shouldSendReferrer == NeverSendReferrer) m_suppressOpenerInNewFrame = true; -if (frameRequest.resourceRequest().httpReferrer().isEmpty()) -frameRequest.resourceRequest().setHTTPReferrer(outgoingReferrer()); addHTTPOriginIfNeeded(frameRequest.resourceRequest(), outgoingOrigin()); loadFrameRequest(frameRequest, lockHistory, lockBackForwardList, triggeringEvent, 0, shouldSendReferrer); @@ -3349,7 +3347,9 @@ // FIXME: Setting the referrer should be the caller's responsibility. FrameLoadRequest requestW
[webkit-changes] [144424] trunk/Source/WebKit/chromium
Title: [144424] trunk/Source/WebKit/chromium Revision 144424 Author joc...@chromium.org Date 2013-03-01 00:23:09 -0800 (Fri, 01 Mar 2013) Log Message REGRESSION(r144422): Broke compilation on chromium-mac https://bugs.webkit.org/show_bug.cgi?id=50 Unreviewed build fix. * src/WebFrameImpl.h: (WebCore): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebFrameImpl.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (144423 => 144424) --- trunk/Source/WebKit/chromium/ChangeLog 2013-03-01 07:48:35 UTC (rev 144423) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-01 08:23:09 UTC (rev 144424) @@ -1,3 +1,13 @@ +2013-03-01 Jochen Eisinger + +REGRESSION(r144422): Broke compilation on chromium-mac +https://bugs.webkit.org/show_bug.cgi?id=50 + +Unreviewed build fix. + +* src/WebFrameImpl.h: +(WebCore): + 2013-02-28 Alexey Proskuryakov Reduce amount of rebuilding when touching networking headers Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.h (144423 => 144424) --- trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2013-03-01 07:48:35 UTC (rev 144423) +++ trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2013-03-01 08:23:09 UTC (rev 144424) @@ -42,7 +42,6 @@ #include namespace WebCore { -class FrameLoadRequest; class GraphicsContext; class HTMLInputElement; class HistoryItem; @@ -51,6 +50,7 @@ class Node; class Range; class SubstituteData; +struct FrameLoadRequest; struct WindowFeatures; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144433] trunk/Tools
Title: [144433] trunk/Tools Revision 144433 Author joc...@chromium.org Date 2013-03-01 02:19:35 -0800 (Fri, 01 Mar 2013) Log Message [chromium] put WebTestProxy::scheduleComposite back in place https://bugs.webkit.org/show_bug.cgi?id=46 Reviewed by Nico Weber. The call was removed in http://trac.webkit.org/changeset/144398 because DRT doesn't need it. However, content shell depends on this call. * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestRunner::WebTestProxy::scheduleComposite): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h Diff Modified: trunk/Tools/ChangeLog (144432 => 144433) --- trunk/Tools/ChangeLog 2013-03-01 10:13:22 UTC (rev 144432) +++ trunk/Tools/ChangeLog 2013-03-01 10:19:35 UTC (rev 144433) @@ -1,3 +1,16 @@ +2013-03-01 Jochen Eisinger + +[chromium] put WebTestProxy::scheduleComposite back in place +https://bugs.webkit.org/show_bug.cgi?id=46 + +Reviewed by Nico Weber. + +The call was removed in http://trac.webkit.org/changeset/144398 because +DRT doesn't need it. However, content shell depends on this call. + +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestRunner::WebTestProxy::scheduleComposite): + 2013-02-28 Ryosuke Niwa Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (144432 => 144433) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-03-01 10:13:22 UTC (rev 144432) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-03-01 10:19:35 UTC (rev 144433) @@ -108,6 +108,7 @@ void setLogConsoleOutput(bool enabled); +// FIXME: Make this private again. void scheduleComposite(); #if WEBTESTRUNNER_IMPLEMENTATION @@ -252,6 +253,11 @@ WebTestProxyBase::didScrollRect(dx, dy, clipRect); Base::didScrollRect(dx, dy, clipRect); } +virtual void scheduleComposite() +{ +WebTestProxyBase::scheduleComposite(); +Base::scheduleComposite(); +} virtual void scheduleAnimation() { WebTestProxyBase::scheduleAnimation(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144635] trunk/Tools
Title: [144635] trunk/Tools Revision 144635 Author joc...@chromium.org Date 2013-03-04 09:04:36 -0800 (Mon, 04 Mar 2013) Log Message [chromium] pass all focus handling methods through the WebTestDelegate https://bugs.webkit.org/show_bug.cgi?id=111328 Reviewed by Nico Weber. In content_shell, the focus handling is asynchronous. To allow for switching the focus synchronously between WebViews, we need to intercept didFocus and didBlur and forward it to the WebTestDelegate. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): (WebTestRunner::WebTestDelegate::setFocus): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestRunner::WebTestProxy::didFocus): (WebTestRunner::WebTestProxy::didBlur): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::setWindowIsKey): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::didFocus): (WebTestRunner): (WebTestRunner::WebTestProxyBase::didBlur): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didFocus): (WebViewHost::didBlur): (WebViewHost::setFocus): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (144634 => 144635) --- trunk/Tools/ChangeLog 2013-03-04 16:50:01 UTC (rev 144634) +++ trunk/Tools/ChangeLog 2013-03-04 17:04:36 UTC (rev 144635) @@ -1,3 +1,33 @@ +2013-03-04 Jochen Eisinger + +[chromium] pass all focus handling methods through the WebTestDelegate +https://bugs.webkit.org/show_bug.cgi?id=111328 + +Reviewed by Nico Weber. + +In content_shell, the focus handling is asynchronous. To allow for +switching the focus synchronously between WebViews, we need to intercept +didFocus and didBlur and forward it to the WebTestDelegate. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +(WebTestRunner::WebTestDelegate::setFocus): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestRunner::WebTestProxy::didFocus): +(WebTestRunner::WebTestProxy::didBlur): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::setWindowIsKey): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::didFocus): +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::didBlur): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::didFocus): +(WebViewHost::didBlur): +(WebViewHost::setFocus): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-03-04 Claudio Saavedra [GTK] No need to manually add system paths to jhbuildrc Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (144634 => 144635) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-03-04 16:50:01 UTC (rev 144634) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-03-04 17:04:36 UTC (rev 144635) @@ -110,8 +110,10 @@ // Controls the device scale factor of the main WebView for hidpi tests. virtual void setDeviceScaleFactor(float) = 0; -// Controls whether or not the main WebView should be focused. -virtual void setFocus(bool) = 0; +// Controls which WebView should be focused. +virtual void setFocus(WebTestProxyBase*, bool enable) { setFocus(enable); } +// FIXME: remove deprecated method. +virtual void setFocus(bool) { } // Controls whether all cookies should be accepted or writing cookies in a // third-party context is blocked. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (144634 => 144635) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-03-04 16:50:01 UTC (rev 144634) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-03-04 17:04:36 UTC (rev 144635) @@ -162,6 +162,8 @@ bool requestPointerLock(); void requestPointerUnlock(); bool isPointerLocked(); +void didFocus(); +void didBlur(); void willPerformClientRedirect(WebKit::WebFrame*, const WebKit::WebURL& from, const WebKit::WebURL& to, double interval, double fire_time); void didCancelClientRedirect(WebKit::WebFrame*); @@ -419,6 +421,16 @@ { return WebTestProxyBase::isPointerLocked(); } +virtual void didFocus() +{ +WebTestProxyBase::didFocus
[webkit-changes] [144660] trunk/Source
Title: [144660] trunk/Source Revision 144660 Author joc...@chromium.org Date 2013-03-04 12:42:13 -0800 (Mon, 04 Mar 2013) Log Message [chromium] remove deprecated hyphenation methods from Platform https://bugs.webkit.org/show_bug.cgi?id=01 Reviewed by Adam Barth. Source/Platform: * chromium/public/Platform.h: (Platform): Source/WebCore: * platform/text/chromium/Hyphenation.cpp: (WebCore::canHyphenate): (WebCore::lastHyphenLocation): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/chromium/Hyphenation.cpp Diff Modified: trunk/Source/Platform/ChangeLog (144659 => 144660) --- trunk/Source/Platform/ChangeLog 2013-03-04 20:33:42 UTC (rev 144659) +++ trunk/Source/Platform/ChangeLog 2013-03-04 20:42:13 UTC (rev 144660) @@ -1,3 +1,13 @@ +2013-03-04 Jochen Eisinger + +[chromium] remove deprecated hyphenation methods from Platform +https://bugs.webkit.org/show_bug.cgi?id=01 + +Reviewed by Adam Barth. + +* chromium/public/Platform.h: +(Platform): + 2013-03-04 Sami Kyostila [chromium] Add ability to wait on async upload completion Modified: trunk/Source/Platform/chromium/public/Platform.h (144659 => 144660) --- trunk/Source/Platform/chromium/public/Platform.h 2013-03-04 20:33:42 UTC (rev 144659) +++ trunk/Source/Platform/chromium/public/Platform.h 2013-03-04 20:42:13 UTC (rev 144660) @@ -184,17 +184,6 @@ virtual bool isLinkVisited(unsigned long long linkHash) { return false; } -// Hyphenation - - -// FIXME: Remove deprecated API. - -// Returns whether we can support hyphenation for the given locale. -virtual bool canHyphenate(const WebString& locale) { return false; } - -// Returns the last position where we can add a hyphen before the given position. -virtual size_t computeLastHyphenLocation(const WebUChar* characters, size_t length, size_t beforeIndex, const WebString& locale) { return 0; } - - // Keygen -- // Handle the tag for generating client certificates Modified: trunk/Source/WebCore/ChangeLog (144659 => 144660) --- trunk/Source/WebCore/ChangeLog 2013-03-04 20:33:42 UTC (rev 144659) +++ trunk/Source/WebCore/ChangeLog 2013-03-04 20:42:13 UTC (rev 144660) @@ -1,3 +1,14 @@ +2013-03-04 Jochen Eisinger + +[chromium] remove deprecated hyphenation methods from Platform +https://bugs.webkit.org/show_bug.cgi?id=01 + +Reviewed by Adam Barth. + +* platform/text/chromium/Hyphenation.cpp: +(WebCore::canHyphenate): +(WebCore::lastHyphenLocation): + 2013-03-04 Benjamin Poulain Use initialization from literal for MediaFeatureNames Modified: trunk/Source/WebCore/platform/text/chromium/Hyphenation.cpp (144659 => 144660) --- trunk/Source/WebCore/platform/text/chromium/Hyphenation.cpp 2013-03-04 20:33:42 UTC (rev 144659) +++ trunk/Source/WebCore/platform/text/chromium/Hyphenation.cpp 2013-03-04 20:42:13 UTC (rev 144660) @@ -27,17 +27,18 @@ #include "Hyphenation.h" #include +#include namespace WebCore { bool canHyphenate(const AtomicString& localeIdentifier) { -return WebKit::Platform::current()->canHyphenate(localeIdentifier); +return WebKit::Platform::current()->hyphenator()->canHyphenate(localeIdentifier); } size_t lastHyphenLocation(const UChar* characters, size_t length, size_t beforeIndex, const AtomicString& localeIdentifier) { -return WebKit::Platform::current()->computeLastHyphenLocation(characters, length, beforeIndex, localeIdentifier); +return WebKit::Platform::current()->hyphenator()->computeLastHyphenLocation(characters, length, beforeIndex, localeIdentifier); } } // namespace WebCore ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144731] trunk/Tools
Title: [144731] trunk/Tools Revision 144731 Author joc...@chromium.org Date 2013-03-04 23:42:51 -0800 (Mon, 04 Mar 2013) Log Message Run the bindings generation tests on EWS and CQ bots https://bugs.webkit.org/show_bug.cgi?id=111358 Reviewed by Adam Barth. The tests are super fast and not flaky. * Scripts/webkitpy/common/config/ports.py: (DeprecatedPort.run_bindings_tests_command): * Scripts/webkitpy/common/config/ports_mock.py: (MockPort.run_webkit_tests_command): (MockPort): (MockPort.run_bindings_tests_command): * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.run): * Scripts/webkitpy/tool/steps/runtests_unittest.py: (RunTestsTest.test_webkit_run_unit_tests): * Scripts/webkitpy/tool/steps/steps_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/ports.py trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py Diff Modified: trunk/Tools/ChangeLog (144730 => 144731) --- trunk/Tools/ChangeLog 2013-03-05 07:33:23 UTC (rev 144730) +++ trunk/Tools/ChangeLog 2013-03-05 07:42:51 UTC (rev 144731) @@ -1,3 +1,25 @@ +2013-03-04 Jochen Eisinger + +Run the bindings generation tests on EWS and CQ bots +https://bugs.webkit.org/show_bug.cgi?id=111358 + +Reviewed by Adam Barth. + +The tests are super fast and not flaky. + +* Scripts/webkitpy/common/config/ports.py: +(DeprecatedPort.run_bindings_tests_command): +* Scripts/webkitpy/common/config/ports_mock.py: +(MockPort.run_webkit_tests_command): +(MockPort): +(MockPort.run_bindings_tests_command): +* Scripts/webkitpy/tool/commands/download_unittest.py: +* Scripts/webkitpy/tool/steps/runtests.py: +(RunTests.run): +* Scripts/webkitpy/tool/steps/runtests_unittest.py: +(RunTestsTest.test_webkit_run_unit_tests): +* Scripts/webkitpy/tool/steps/steps_unittest.py: + 2013-03-04 Eric Seidel run-webkit-tests should support --profile and --profiler= just like run-perf-tests does Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (144730 => 144731) --- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2013-03-05 07:33:23 UTC (rev 144730) +++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2013-03-05 07:42:51 UTC (rev 144731) @@ -117,7 +117,10 @@ def run_perl_unittests_command(self): return self.script_shell_command("test-webkitperl") +def run_bindings_tests_command(self): +return self.script_shell_command("run-bindings-tests") + class MacPort(DeprecatedPort): port_flag_name = "mac" Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py (144730 => 144731) --- trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2013-03-05 07:33:23 UTC (rev 144730) +++ trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2013-03-05 07:42:51 UTC (rev 144731) @@ -57,3 +57,6 @@ def run_webkit_tests_command(self): return ['mock-run-webkit-tests'] + +def run_bindings_tests_command(self): +return ['mock-run-bindings-tests'] Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (144730 => 144731) --- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2013-03-05 07:33:23 UTC (rev 144730) +++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2013-03-05 07:42:51 UTC (rev 144731) @@ -99,6 +99,7 @@ Running Python unit tests Running Perl unit tests Running _javascript_Core tests +Running bindings generation tests Running WebKit unit tests Running run-webkit-tests """ @@ -140,6 +141,7 @@ Running Python unit tests Running Perl unit tests Running _javascript_Core tests +Running bindings generation tests Running WebKit unit tests Running run-webkit-tests Committed r49824: @@ -167,6 +169,8 @@ MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout Running _javascript_Core tests MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout +Running bindings generation tests +MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout Running WebKit unit tests MOCK run_and_throw_if_fail: ['mock-run-webkit-unit-tests'], cwd=/mock-checkout Running run-webkit-tests @@ -183,6 +187,7 @@ Running Python unit tests Running Perl unit tests Running _javascript_Core tests +Running bindings generation tests Running WebKit unit tests Running run-webkit-tests Committed r49824: @@ -214,6 +219,7 @@ Running Python unit tests Running Perl unit tests Running _javascript_Core tests +Runnin
[webkit-changes] [144733] trunk/Tools
Title: [144733] trunk/Tools Revision 144733 Author joc...@chromium.org Date 2013-03-04 23:56:43 -0800 (Mon, 04 Mar 2013) Log Message [chromium] remove deprecated WebTestRunner::setFocus API https://bugs.webkit.org/show_bug.cgi?id=111354 Reviewed by James Robinson. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h Diff Modified: trunk/Tools/ChangeLog (144732 => 144733) --- trunk/Tools/ChangeLog 2013-03-05 07:44:47 UTC (rev 144732) +++ trunk/Tools/ChangeLog 2013-03-05 07:56:43 UTC (rev 144733) @@ -1,5 +1,15 @@ 2013-03-04 Jochen Eisinger +[chromium] remove deprecated WebTestRunner::setFocus API +https://bugs.webkit.org/show_bug.cgi?id=111354 + +Reviewed by James Robinson. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): + +2013-03-04 Jochen Eisinger + Run the bindings generation tests on EWS and CQ bots https://bugs.webkit.org/show_bug.cgi?id=111358 Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (144732 => 144733) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-03-05 07:44:47 UTC (rev 144732) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-03-05 07:56:43 UTC (rev 144733) @@ -111,9 +111,7 @@ virtual void setDeviceScaleFactor(float) = 0; // Controls which WebView should be focused. -virtual void setFocus(WebTestProxyBase*, bool enable) { setFocus(enable); } -// FIXME: remove deprecated method. -virtual void setFocus(bool) { } +virtual void setFocus(WebTestProxyBase*, bool) = 0; // Controls whether all cookies should be accepted or writing cookies in a // third-party context is blocked. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144739] trunk/Tools
Title: [144739] trunk/Tools Revision 144739 Author joc...@chromium.org Date 2013-03-05 00:46:24 -0800 (Tue, 05 Mar 2013) Log Message Add content shell bots to garden-o-matic for general failurse https://bugs.webkit.org/show_bug.cgi?id=68 Reviewed by Adam Barth. All but the WebKit (Content Shell) Android bot is stable enough. While they're not green yet, there must not be any non-layout test failures on them. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: (.): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (144738 => 144739) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2013-03-05 08:31:43 UTC (rev 144738) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2013-03-05 08:46:24 UTC (rev 144739) @@ -97,7 +97,7 @@ return builderName.indexOf('GPU') == -1 && builderName.indexOf('deps') == -1 && builderName.indexOf('ASAN') == -1 && - builderName.indexOf('Content Shell') == -1 && + builderName.indexOf('WebKit (Content Shell) Android') == -1 && builderName.indexOf('Mac10.8 Tests') == -1 && builderName.indexOf('WebKit Android') == -1; }, Modified: trunk/Tools/ChangeLog (144738 => 144739) --- trunk/Tools/ChangeLog 2013-03-05 08:31:43 UTC (rev 144738) +++ trunk/Tools/ChangeLog 2013-03-05 08:46:24 UTC (rev 144739) @@ -1,3 +1,17 @@ +2013-03-05 Jochen Eisinger + +Add content shell bots to garden-o-matic for general failurse +https://bugs.webkit.org/show_bug.cgi?id=68 + +Reviewed by Adam Barth. + +All but the WebKit (Content Shell) Android bot is stable enough. While +they're not green yet, there must not be any non-layout test failures on +them. + +* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: +(.): + 2013-03-04 Jochen Eisinger [chromium] remove deprecated WebTestRunner::setFocus API ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [144742] trunk/Source/WebCore
Title: [144742] trunk/Source/WebCore Revision 144742 Author joc...@chromium.org Date 2013-03-05 01:30:47 -0800 (Tue, 05 Mar 2013) Log Message Refactor UserGestureIndicator::Token to be a top-level class https://bugs.webkit.org/show_bug.cgi?id=111412 Reviewed by Nico Weber. This will allow for forward declaring the class in a public WebKit API header. The goal is to enable the embedder to hold on to a UserGestureToken. * dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): (WebCore::UserGestureIndicator::currentToken): * dom/UserGestureIndicator.h: (UserGestureToken): (WebCore::UserGestureToken::~UserGestureToken): (WebCore): (UserGestureIndicator): * page/DOMTimer.h: (DOMTimer): * page/EventHandler.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/UserGestureIndicator.cpp trunk/Source/WebCore/dom/UserGestureIndicator.h trunk/Source/WebCore/page/DOMTimer.h trunk/Source/WebCore/page/EventHandler.h Diff Modified: trunk/Source/WebCore/ChangeLog (144741 => 144742) --- trunk/Source/WebCore/ChangeLog 2013-03-05 09:15:59 UTC (rev 144741) +++ trunk/Source/WebCore/ChangeLog 2013-03-05 09:30:47 UTC (rev 144742) @@ -1,3 +1,26 @@ +2013-03-05 Jochen Eisinger + +Refactor UserGestureIndicator::Token to be a top-level class +https://bugs.webkit.org/show_bug.cgi?id=111412 + +Reviewed by Nico Weber. + +This will allow for forward declaring the class in a public WebKit +API header. The goal is to enable the embedder to hold on to a +UserGestureToken. + +* dom/UserGestureIndicator.cpp: +(WebCore::UserGestureIndicator::UserGestureIndicator): +(WebCore::UserGestureIndicator::currentToken): +* dom/UserGestureIndicator.h: +(UserGestureToken): +(WebCore::UserGestureToken::~UserGestureToken): +(WebCore): +(UserGestureIndicator): +* page/DOMTimer.h: +(DOMTimer): +* page/EventHandler.h: + 2013-03-05 Mike West Remove redundant code in Document::updateHoverActiveState. Modified: trunk/Source/WebCore/dom/UserGestureIndicator.cpp (144741 => 144742) --- trunk/Source/WebCore/dom/UserGestureIndicator.cpp 2013-03-05 09:15:59 UTC (rev 144741) +++ trunk/Source/WebCore/dom/UserGestureIndicator.cpp 2013-03-05 09:30:47 UTC (rev 144742) @@ -30,9 +30,9 @@ namespace { -class GestureToken : public UserGestureIndicator::Token { +class GestureToken : public UserGestureToken { public: -static PassRefPtr create() { return adoptRef(new GestureToken); } +static PassRefPtr create() { return adoptRef(new GestureToken); } virtual ~GestureToken() { } @@ -83,7 +83,7 @@ ASSERT(isDefinite(s_state)); } -UserGestureIndicator::UserGestureIndicator(PassRefPtr token) +UserGestureIndicator::UserGestureIndicator(PassRefPtr token) : m_previousState(s_state) { if (token && static_cast(token.get())->hasGestures()) { @@ -121,7 +121,7 @@ return static_cast(s_topmostIndicator->currentToken())->consumeGesture(); } -UserGestureIndicator::Token* UserGestureIndicator::currentToken() +UserGestureToken* UserGestureIndicator::currentToken() { if (!s_topmostIndicator) return 0; Modified: trunk/Source/WebCore/dom/UserGestureIndicator.h (144741 => 144742) --- trunk/Source/WebCore/dom/UserGestureIndicator.h 2013-03-05 09:15:59 UTC (rev 144741) +++ trunk/Source/WebCore/dom/UserGestureIndicator.h 2013-03-05 09:30:47 UTC (rev 144742) @@ -38,20 +38,21 @@ DefinitelyNotProcessingUserGesture }; +class UserGestureToken : public RefCounted { +public: +virtual ~UserGestureToken() { } +}; + + class UserGestureIndicator { WTF_MAKE_NONCOPYABLE(UserGestureIndicator); public: -class Token : public RefCounted { -public: -virtual ~Token() { } -}; - static bool processingUserGesture(); static bool consumeUserGesture(); -static Token* currentToken(); +static UserGestureToken* currentToken(); explicit UserGestureIndicator(ProcessingUserGestureState); -explicit UserGestureIndicator(PassRefPtr); +explicit UserGestureIndicator(PassRefPtr); ~UserGestureIndicator(); @@ -59,7 +60,7 @@ static ProcessingUserGestureState s_state; static UserGestureIndicator* s_topmostIndicator; ProcessingUserGestureState m_previousState; -RefPtr m_token; +RefPtr m_token; }; } Modified: trunk/Source/WebCore/page/DOMTimer.h (144741 => 144742) --- trunk/Source/WebCore/page/DOMTimer.h 2013-03-05 09:15:59 UTC (rev 144741) +++ trunk/Source/WebCore/page/DOMTimer.h 2013-03-05 09:30:47 UTC (rev 144742) @@ -68,7 +68,7 @@ int m_nestingLevel; OwnPtr m_action; int m_originalInterval; -RefPtr m_userGestureToken; +RefPtr m_userGestureToken; }; } // namespace WebCore Modified: trunk/Source/WebCore/page/EventHandler.h (144741 => 144742) --- trunk/Source/Web
[webkit-changes] [144951] trunk
Title: [144951] trunk Revision 144951 Author joc...@chromium.org Date 2013-03-06 11:08:03 -0800 (Wed, 06 Mar 2013) Log Message [chromium] introduce WebUserGestureIndicator https://bugs.webkit.org/show_bug.cgi?id=111531 Reviewed by Adam Barth. Source/WebKit/chromium: Currently, an embedder needs to have a WebFrame to check whether a user gesture is being processed and to consume a user gesture. However, the user gesture state is independed of a frame. * WebKit.gyp: * public/WebFrame.h: (WebFrame): * public/WebUserGestureIndicator.h: Added. (WebKit): (WebUserGestureIndicator): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isProcessingUserGesture): (WebKit::WebFrameImpl::consumeUserGesture): * src/WebUserGestureIndicator.cpp: Added. (WebKit): (WebKit::WebUserGestureIndicator::isProcessingUserGesture): (WebKit::WebUserGestureIndicator::consumeUserGesture): Tools: * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/public/WebFrame.h trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp Added Paths trunk/Source/WebKit/chromium/public/WebUserGestureIndicator.h trunk/Source/WebKit/chromium/src/WebUserGestureIndicator.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (144950 => 144951) --- trunk/Source/WebKit/chromium/ChangeLog 2013-03-06 19:05:03 UTC (rev 144950) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-06 19:08:03 UTC (rev 144951) @@ -1,3 +1,28 @@ +2013-03-06 Jochen Eisinger + +[chromium] introduce WebUserGestureIndicator +https://bugs.webkit.org/show_bug.cgi?id=111531 + +Reviewed by Adam Barth. + +Currently, an embedder needs to have a WebFrame to check whether a +user gesture is being processed and to consume a user gesture. However, +the user gesture state is independed of a frame. + +* WebKit.gyp: +* public/WebFrame.h: +(WebFrame): +* public/WebUserGestureIndicator.h: Added. +(WebKit): +(WebUserGestureIndicator): +* src/WebFrameImpl.cpp: +(WebKit::WebFrameImpl::isProcessingUserGesture): +(WebKit::WebFrameImpl::consumeUserGesture): +* src/WebUserGestureIndicator.cpp: Added. +(WebKit): +(WebKit::WebUserGestureIndicator::isProcessingUserGesture): +(WebKit::WebUserGestureIndicator::consumeUserGesture): + 2013-03-06 Sheriff Bot Unreviewed. Rolled Chromium DEPS to r186371. Requested by Modified: trunk/Source/WebKit/chromium/WebKit.gyp (144950 => 144951) --- trunk/Source/WebKit/chromium/WebKit.gyp 2013-03-06 19:05:03 UTC (rev 144950) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2013-03-06 19:08:03 UTC (rev 144951) @@ -276,6 +276,7 @@ 'public/WebTextRun.h', 'public/WebTimeRange.h', 'public/WebURLLoaderOptions.h', +'public/WebUserGestureIndicator.h', 'public/WebUserMediaClient.h', 'public/WebUserMediaRequest.h', 'public/WebView.h', @@ -575,6 +576,7 @@ 'src/WebURLLoadTiming.cpp', 'src/WebScopedUserGesture.cpp', 'src/WebTextFieldDecoratorClient.cpp', +'src/WebUserGestureIndicator.cpp', 'src/WebUserMediaRequest.cpp', 'src/WebViewBenchmarkSupportImpl.cpp', 'src/WebViewBenchmarkSupportImpl.h', Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (144950 => 144951) --- trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-06 19:05:03 UTC (rev 144950) +++ trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-06 19:08:03 UTC (rev 144951) @@ -402,10 +402,10 @@ // Returns the number of registered unload listeners. virtual unsigned unloadListenerCount() const = 0; -// Returns true if a user gesture is currently being processed. +// Returns true if a user gesture is currently being processed. Deprecated. virtual bool isProcessingUserGesture() const = 0; -// Returns true if a consumable gesture exists and has been successfully consumed. +// Returns true if a consumable gesture exists and has been successfully consumed. Deprecated. virtual bool consumeUserGesture() const = 0; // Returns true if this frame is in the process of opening a new frame Added: trunk/Source/WebKit/chromium/public/WebUserGestureIndicator.h (0 => 144951) --- trunk/Source/WebKit/chromium/public/WebUserGestureIndicator.h (rev 0) +++ trunk/Source/WebKit/chromium/public/WebUserGestureIndicator.h 2013-03-06 19:08:03 UTC (rev 144951) @@ -0,0 +1,49 @@ +/* + * Copyright (C) 2013 G
[webkit-changes] [145046] trunk/Source/WebKit/chromium
Title: [145046] trunk/Source/WebKit/chromium Revision 145046 Author joc...@chromium.org Date 2013-03-07 00:12:31 -0800 (Thu, 07 Mar 2013) Log Message [chromium] expose UserGestureToken via WebKit API so PPAPI plugins can correctly consume it https://bugs.webkit.org/show_bug.cgi?id=104268 Reviewed by Darin Fisher. Currently, the PPAPI creates a WebScopedUserGesture up to 10 seconds after a call with an currently active user gesture was made. It should use the newly added WebUserGestureToken to make sure this user gesture is not consumed multiple times. We can't require a WebUserGestureToken for a WebScopedUserGesture, since e.g. the extension API needs to be able to create a WebScopedUserGesture out of the blue. * WebKit.gyp: * WebKit.gypi: * public/WebScopedUserGesture.h: (WebKit): (WebKit::WebScopedUserGesture::WebScopedUserGesture): (WebScopedUserGesture): * public/WebUserGestureIndicator.h: (WebKit): (WebUserGestureIndicator): * public/WebUserGestureToken.h: Copied from Source/WebKit/chromium/public/WebScopedUserGesture.h. (WebCore): (WebKit): (WebUserGestureToken): (WebKit::WebUserGestureToken::WebUserGestureToken): (WebKit::WebUserGestureToken::operator=): (WebKit::WebUserGestureToken::~WebUserGestureToken): (WebKit::WebUserGestureToken::isNull): * src/WebScopedUserGesture.cpp: (WebKit::WebScopedUserGesture::initializeWithToken): (WebKit): * src/WebUserGestureIndicator.cpp: (WebKit::WebUserGestureIndicator::currentUserGestureToken): (WebKit): * src/WebUserGestureToken.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp. (WebKit): (WebKit::WebUserGestureToken::WebUserGestureToken): (WebKit::WebUserGestureToken::operator WebCore::UserGestureToken*): (WebKit::WebUserGestureToken::assign): (WebKit::WebUserGestureToken::reset): * tests/WebUserGestureTokenTest.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp. (WebCore): (WebCore::TEST): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/WebKit.gypi trunk/Source/WebKit/chromium/public/WebScopedUserGesture.h trunk/Source/WebKit/chromium/public/WebUserGestureIndicator.h trunk/Source/WebKit/chromium/src/WebScopedUserGesture.cpp trunk/Source/WebKit/chromium/src/WebUserGestureIndicator.cpp Added Paths trunk/Source/WebKit/chromium/public/WebUserGestureToken.h trunk/Source/WebKit/chromium/src/WebUserGestureToken.cpp trunk/Source/WebKit/chromium/tests/WebUserGestureTokenTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (145045 => 145046) --- trunk/Source/WebKit/chromium/ChangeLog 2013-03-07 08:08:58 UTC (rev 145045) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-07 08:12:31 UTC (rev 145046) @@ -1,3 +1,52 @@ +2013-03-07 Jochen Eisinger + +[chromium] expose UserGestureToken via WebKit API so PPAPI plugins can correctly consume it +https://bugs.webkit.org/show_bug.cgi?id=104268 + +Reviewed by Darin Fisher. + +Currently, the PPAPI creates a WebScopedUserGesture up to 10 seconds +after a call with an currently active user gesture was made. It should +use the newly added WebUserGestureToken to make sure this user gesture +is not consumed multiple times. + +We can't require a WebUserGestureToken for a WebScopedUserGesture, since +e.g. the extension API needs to be able to create a WebScopedUserGesture +out of the blue. + +* WebKit.gyp: +* WebKit.gypi: +* public/WebScopedUserGesture.h: +(WebKit): +(WebKit::WebScopedUserGesture::WebScopedUserGesture): +(WebScopedUserGesture): +* public/WebUserGestureIndicator.h: +(WebKit): +(WebUserGestureIndicator): +* public/WebUserGestureToken.h: Copied from Source/WebKit/chromium/public/WebScopedUserGesture.h. +(WebCore): +(WebKit): +(WebUserGestureToken): +(WebKit::WebUserGestureToken::WebUserGestureToken): +(WebKit::WebUserGestureToken::operator=): +(WebKit::WebUserGestureToken::~WebUserGestureToken): +(WebKit::WebUserGestureToken::isNull): +* src/WebScopedUserGesture.cpp: +(WebKit::WebScopedUserGesture::initializeWithToken): +(WebKit): +* src/WebUserGestureIndicator.cpp: +(WebKit::WebUserGestureIndicator::currentUserGestureToken): +(WebKit): +* src/WebUserGestureToken.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp. +(WebKit): +(WebKit::WebUserGestureToken::WebUserGestureToken): +(WebKit::WebUserGestureToken::operator WebCore::UserGestureToken*): +(WebKit::WebUserGestureToken::assign): +(WebKit::WebUserGestureToken::reset): +* tests/WebUserGestureTokenTest.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp. +(WebCore): +(WebCore::TEST): + 2013-03-06 David Dorwin [chrom
[webkit-changes] [145072] trunk/Tools
Title: [145072] trunk/Tools Revision 145072 Author joc...@chromium.org Date 2013-03-07 07:20:00 -0800 (Thu, 07 Mar 2013) Log Message [chromium] don't track the top loading frame if no layout test is currently running https://bugs.webkit.org/show_bug.cgi?id=111716 Reviewed by Kentaro Hara. In DRT, we synchronously stop the test and start loading the next test URL. However, in content_shell, this happens asynchronously. It's important that the top loading frame is not changed due to stray navigation events before the next test starts. * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::setTopLoadingFrame): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp Diff Modified: trunk/Tools/ChangeLog (145071 => 145072) --- trunk/Tools/ChangeLog 2013-03-07 14:23:27 UTC (rev 145071) +++ trunk/Tools/ChangeLog 2013-03-07 15:20:00 UTC (rev 145072) @@ -1,3 +1,18 @@ +2013-03-07 Jochen Eisinger + +[chromium] don't track the top loading frame if no layout test is currently running +https://bugs.webkit.org/show_bug.cgi?id=111716 + +Reviewed by Kentaro Hara. + +In DRT, we synchronously stop the test and start loading the next test +URL. However, in content_shell, this happens asynchronously. It's +important that the top loading frame is not changed due to stray +navigation events before the next test starts. + +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::setTopLoadingFrame): + 2013-03-06 Julie Parent Dashboard cleanup: Move all dashboard ui related code into ui.js. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp (145071 => 145072) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2013-03-07 14:23:27 UTC (rev 145071) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2013-03-07 15:20:00 UTC (rev 145072) @@ -634,6 +634,8 @@ { if (frame->top()->view() != m_webView) return; +if (!m_testIsRunning) +return; if (clear) { m_topLoadingFrame = 0; locationChangeDone(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145189] trunk/Tools
Title: [145189] trunk/Tools Revision 145189 Author joc...@chromium.org Date 2013-03-08 00:00:54 -0800 (Fri, 08 Mar 2013) Log Message [chromium] delay clearing the TestRunners until the main view was deleted https://bugs.webkit.org/show_bug.cgi?id=111823 Reviewed by Eric Seidel. During WebViewHost::shutdown, we navigate the WebView to about:blank. This may call into the test runners which assume that the delegate is always non-NULL. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Diff Modified: trunk/Tools/ChangeLog (145188 => 145189) --- trunk/Tools/ChangeLog 2013-03-08 07:57:01 UTC (rev 145188) +++ trunk/Tools/ChangeLog 2013-03-08 08:00:54 UTC (rev 145189) @@ -1,3 +1,17 @@ +2013-03-07 Jochen Eisinger + +[chromium] delay clearing the TestRunners until the main view was deleted +https://bugs.webkit.org/show_bug.cgi?id=111823 + +Reviewed by Eric Seidel. + +During WebViewHost::shutdown, we navigate the WebView to about:blank. +This may call into the test runners which assume that the delegate is +always non-NULL. + +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::~TestShell): + 2013-03-07 Alan Cutter Sheriffbot whois command can't search by full name Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (145188 => 145189) --- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-03-08 07:57:01 UTC (rev 145188) +++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-03-08 08:00:54 UTC (rev 145189) @@ -162,13 +162,13 @@ TestShell::~TestShell() { +if (m_webViewHost) +m_webViewHost->shutdown(); m_testInterfaces->setDelegate(0); m_testInterfaces->setWebView(0, 0); m_devToolsTestInterfaces->setDelegate(0); m_devToolsTestInterfaces->setWebView(0, 0); m_drtDevToolsAgent->setWebView(0); -if (m_webViewHost) -m_webViewHost->shutdown(); } void TestShell::createDRTDevToolsClient(DRTDevToolsAgent* agent) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [145345] trunk
Title: [145345] trunk Revision 145345 Author joc...@chromium.org Date 2013-03-11 01:32:10 -0700 (Mon, 11 Mar 2013) Log Message [chromium] remove obsolete user gesture methods from WebFrame https://bugs.webkit.org/show_bug.cgi?id=111696 Reviewed by Adam Barth. Source/WebKit/chromium: * public/WebFrame.h: (WebFrame): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage): * src/WebFrameImpl.cpp: * src/WebFrameImpl.h: (WebFrameImpl): Tools: * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: (WebTestRunner::TestPlugin::handleInputEvent): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebFrame.h trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp trunk/Source/WebKit/chromium/src/WebFrameImpl.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (145344 => 145345) --- trunk/Source/WebKit/chromium/ChangeLog 2013-03-11 08:30:59 UTC (rev 145344) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-11 08:32:10 UTC (rev 145345) @@ -1,3 +1,18 @@ +2013-03-11 Jochen Eisinger + +[chromium] remove obsolete user gesture methods from WebFrame +https://bugs.webkit.org/show_bug.cgi?id=111696 + +Reviewed by Adam Barth. + +* public/WebFrame.h: +(WebFrame): +* src/FrameLoaderClientImpl.cpp: +(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage): +* src/WebFrameImpl.cpp: +* src/WebFrameImpl.h: +(WebFrameImpl): + 2013-03-09 Sadrul Habib Chowdhury [chromium] Remove deprecated flingStart.sourceDevice from WebGestureEvent Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (145344 => 145345) --- trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-11 08:30:59 UTC (rev 145344) +++ trunk/Source/WebKit/chromium/public/WebFrame.h 2013-03-11 08:32:10 UTC (rev 145345) @@ -402,12 +402,6 @@ // Returns the number of registered unload listeners. virtual unsigned unloadListenerCount() const = 0; -// Returns true if a user gesture is currently being processed. Deprecated. -virtual bool isProcessingUserGesture() const = 0; - -// Returns true if a consumable gesture exists and has been successfully consumed. Deprecated. -virtual bool consumeUserGesture() const = 0; - // Returns true if this frame is in the process of opening a new frame // with a suppressed opener. virtual bool willSuppressOpenerInNewFrame() const = 0; Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (145344 => 145345) --- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2013-03-11 08:30:59 UTC (rev 145344) +++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp 2013-03-11 08:32:10 UTC (rev 145345) @@ -61,6 +61,7 @@ #endif #include "Settings.h" #include "SocketStreamHandleInternal.h" +#include "UserGestureIndicator.h" #if ENABLE(REQUEST_AUTOCOMPLETE) #include "WebAutofillClient.h" #endif @@ -689,11 +690,11 @@ // proper fix for this bug is identified and applied the following // block may no longer be required. // -// FIXME: Why do we call isProcessingUserGesture here but none of +// FIXME: Why do we call processingUserGesture here but none of // the other ports do? bool wasClientRedirect = (url == m_expectedClientRedirectDest && chainEnd == m_expectedClientRedirectSrc) -|| !m_webFrame->isProcessingUserGesture(); +|| !UserGestureIndicator::processingUserGesture(); if (wasClientRedirect) { if (m_webFrame->client()) Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (145344 => 145345) --- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-03-11 08:30:59 UTC (rev 145344) +++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-03-11 08:32:10 UTC (rev 145345) @@ -173,7 +173,6 @@ #include "WebScriptSource.h" #include "WebSecurityOrigin.h" #include "WebSerializedScriptValue.h" -#include "WebUserGestureIndicator.h" #include "WebViewImpl.h" #include "XPathResult.h" #include "htmlediting.h" @@ -1108,16 +1107,6 @@ return frame()->document()->domWindow()->pendingUnloadEventListeners(); } -bool WebFrameImpl::isProcessingUserGesture() const -{ -return WebUserGestureIndicator::isProcessingUserGesture(); -} - -bool WebFrameImpl::consumeUserGesture() const -{ -return WebUserGestureIndicator::consumeUserGesture(); -} - bool WebFrameImpl::willSuppressOpenerInNewFrame()
[webkit-changes] [131173] trunk/Tools
Title: [131173] trunk/Tools Revision 131173 Author joc...@chromium.org Date 2012-10-12 04:50:46 -0700 (Fri, 12 Oct 2012) Log Message Create a separate gyp target for dependencies of DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=99023 Reviewed by Tony Chang. This allows for pulling in the fonts and helpers required to run layout tests in the content_shell without depending on DumpRenderTree. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp Diff Modified: trunk/Tools/ChangeLog (131172 => 131173) --- trunk/Tools/ChangeLog 2012-10-12 11:44:58 UTC (rev 131172) +++ trunk/Tools/ChangeLog 2012-10-12 11:50:46 UTC (rev 131173) @@ -1,3 +1,15 @@ +2012-10-12 Jochen Eisinger + +Create a separate gyp target for dependencies of DumpRenderTree +https://bugs.webkit.org/show_bug.cgi?id=99023 + +Reviewed by Tony Chang. + +This allows for pulling in the fonts and helpers required to run layout +tests in the content_shell without depending on DumpRenderTree. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + 2012-10-12 Balazs Kelemen [Qt][WTR] Do a forced repaint before generating pixel results Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (131172 => 131173) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-12 11:44:58 UTC (rev 131172) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-12 11:50:46 UTC (rev 131173) @@ -78,6 +78,7 @@ 'target_name': 'TestRunner', 'type': 'static_library', 'dependencies': [ +'TestRunner_resources', '<(source_dir)/WebKit/chromium/WebKit.gyp:webkit', '<(source_dir)/WTF/WTF.gyp/WTF.gyp:wtf', '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support', @@ -111,13 +112,77 @@ ], }, { +'target_name': 'TestRunner_resources', +'type': 'none', +'dependencies': [ +'ImageDiff', +'copy_TestNetscapePlugIn', +], +'conditions': [ +['OS=="win"', { +'dependencies': [ +'LayoutTestHelper', +], +'copies': [{ +'destination': '<(PRODUCT_DIR)', +'files': ['<(ahem_path)'], +}], +}], +['OS=="mac"', { +'dependencies': [ +'LayoutTestHelper', +], +'mac_bundle_resources': [ +'<(ahem_path)', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher100.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher200.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher300.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher400.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher500.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher600.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher700.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher800.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher900.ttf', +'<(SHARED_INTERMEDIATE_DIR)/webkit/missingImage.png', +'<(SHARED_INTERMEDIATE_DIR)/webkit/textAreaResizeCorner.png', +], +}], +['use_x11 == 1', { +'copies': [{ +'destination': '<(PRODUCT_DIR)', +'files': [ +'<(ahem_path)', +'<(tools_dir)/DumpRenderTree/chromium/fonts.conf', +] +}], +}], +['OS=="android"', { +'dependencies!': [ +'ImageDiff', +'copy_TestNetsca
[webkit-changes] [131613] trunk/Tools
Title: [131613] trunk/Tools Revision 131613 Author joc...@chromium.org Date 2012-10-17 09:55:02 -0700 (Wed, 17 Oct 2012) Log Message [gyp] fix bundle resources for DumpRenderTree on mac https://bugs.webkit.org/show_bug.cgi?id=99558 Reviewed by Adam Barth. mac_bundle_resources doesn't propagate to targets that depend on it, so I'm wrapping it in an all_dependent_settings block. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp Diff Modified: trunk/Tools/ChangeLog (131612 => 131613) --- trunk/Tools/ChangeLog 2012-10-17 16:38:59 UTC (rev 131612) +++ trunk/Tools/ChangeLog 2012-10-17 16:55:02 UTC (rev 131613) @@ -1,3 +1,15 @@ +2012-10-17 Jochen Eisinger + +[gyp] fix bundle resources for DumpRenderTree on mac +https://bugs.webkit.org/show_bug.cgi?id=99558 + +Reviewed by Adam Barth. + +mac_bundle_resources doesn't propagate to targets that depend on it, +so I'm wrapping it in an all_dependent_settings block. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + 2012-10-17 Harald Alvestrand Add myself to the MediaStream watchlist Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (131612 => 131613) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-17 16:38:59 UTC (rev 131612) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-17 16:55:02 UTC (rev 131613) @@ -132,20 +132,22 @@ 'dependencies': [ 'LayoutTestHelper', ], -'mac_bundle_resources': [ -'<(ahem_path)', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher100.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher200.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher300.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher400.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher500.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher600.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher700.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher800.ttf', -'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher900.ttf', -'<(SHARED_INTERMEDIATE_DIR)/webkit/missingImage.png', -'<(SHARED_INTERMEDIATE_DIR)/webkit/textAreaResizeCorner.png', -], +'all_dependent_settings': { +'mac_bundle_resources': [ +'<(ahem_path)', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher100.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher200.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher300.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher400.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher500.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher600.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher700.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher800.ttf', +'<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher900.ttf', +'<(SHARED_INTERMEDIATE_DIR)/webkit/missingImage.png', +'<(SHARED_INTERMEDIATE_DIR)/webkit/textAreaResizeCorner.png', +], +}, }], ['use_x11 == 1', { 'copies': [{ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131821] trunk/Tools
Title: [131821] trunk/Tools Revision 131821 Author joc...@chromium.org Date 2012-10-18 16:13:10 -0700 (Thu, 18 Oct 2012) Log Message [chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface https://bugs.webkit.org/show_bug.cgi?id=99766 Reviewed by Adam Barth. This reverts http://trac.webkit.org/changeset/123240 * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: (TestInterfaces::TestInterfaces): (TestInterfaces::~TestInterfaces): (TestInterfaces::setWebView): (TestInterfaces::setDelegate): (TestInterfaces::bindTo): (TestInterfaces::resetAll): (TestInterfaces::accessibilityController): (TestInterfaces::eventSender): * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: (TestInterfaces): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h Diff Modified: trunk/Tools/ChangeLog (131820 => 131821) --- trunk/Tools/ChangeLog 2012-10-18 23:06:59 UTC (rev 131820) +++ trunk/Tools/ChangeLog 2012-10-18 23:13:10 UTC (rev 131821) @@ -1,3 +1,24 @@ +2012-10-18 Jochen Eisinger + +[chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface +https://bugs.webkit.org/show_bug.cgi?id=99766 + +Reviewed by Adam Barth. + +This reverts http://trac.webkit.org/changeset/123240 + +* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: +(TestInterfaces::TestInterfaces): +(TestInterfaces::~TestInterfaces): +(TestInterfaces::setWebView): +(TestInterfaces::setDelegate): +(TestInterfaces::bindTo): +(TestInterfaces::resetAll): +(TestInterfaces::accessibilityController): +(TestInterfaces::eventSender): +* DumpRenderTree/chromium/TestRunner/TestInterfaces.h: +(TestInterfaces): + 2012-10-18 Sheriff Bot Unreviewed, rolling out r131810. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp (131820 => 131821) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp 2012-10-18 23:06:59 UTC (rev 131820) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp 2012-10-18 23:13:10 UTC (rev 131821) @@ -37,33 +37,11 @@ #include "TextInputController.h" #include "platform/WebString.h" -#include - using WebKit::WebFrame; using WebKit::WebString; using WebKit::WebView; -class TestInterfaces::Internal { -public: -Internal(); -~Internal(); - -void setWebView(WebView*); -void setDelegate(TestDelegate*); -void bindTo(WebFrame*); -void resetAll(); - -AccessibilityController* accessibilityController() { return m_accessibilityController.get(); } -EventSender* eventSender() { return m_eventSender.get(); } - -private: -OwnPtr m_accessibilityController; -OwnPtr m_eventSender; -OwnPtr m_gamepadController; -OwnPtr m_textInputController; -}; - -TestInterfaces::Internal::Internal() +TestInterfaces::TestInterfaces() { m_accessibilityController = adoptPtr(new AccessibilityController()); m_eventSender = adoptPtr(new EventSender()); @@ -71,7 +49,7 @@ m_textInputController = adoptPtr(new TextInputController()); } -TestInterfaces::Internal::~Internal() +TestInterfaces::~TestInterfaces() { m_accessibilityController->setWebView(0); m_eventSender->setWebView(0); @@ -84,7 +62,7 @@ // m_textInputController doesn't depend on TestDelegate. } -void TestInterfaces::Internal::setWebView(WebView* webView) +void TestInterfaces::setWebView(WebView* webView) { m_accessibilityController->setWebView(webView); m_eventSender->setWebView(webView); @@ -92,7 +70,7 @@ m_textInputController->setWebView(webView); } -void TestInterfaces::Internal::setDelegate(TestDelegate* delegate) +void TestInterfaces::setDelegate(TestDelegate* delegate) { // m_accessibilityController doesn't depend on TestDelegate. m_eventSender->setDelegate(delegate); @@ -100,7 +78,7 @@ // m_textInputController doesn't depend on TestDelegate. } -void TestInterfaces::Internal::bindTo(WebFrame* frame) +void TestInterfaces::bindTo(WebFrame* frame) { m_accessibilityController->bindToJavascript(frame, WebString::fromUTF8("accessibilityController")); m_eventSender->bindToJavascript(frame, WebString::fromUTF8("eventSender")); @@ -108,7 +86,7 @@ m_textInputController->bindToJavascript(frame, WebString::fromUTF8("textInputController")); } -void TestInterfaces::Internal::resetAll() +void TestInterfaces::resetAll() { m_accessibilityController->reset(); m_eventSender->reset(); @@ -116,42 +94,12 @@ // m_textInputController doesn't have any state to reset. } -TestInterfaces::TestInterfaces() -: m_interna
[webkit-changes] [131835] trunk
Title: [131835] trunk Revision 131835 Author joc...@chromium.org Date 2012-10-18 18:13:41 -0700 (Thu, 18 Oct 2012) Log Message [chromium] Add a webkit_test_support target that WebTestingSupport https://bugs.webkit.org/show_bug.cgi?id=99772 Reviewed by Adam Barth. Source/WebKit/chromium: Before, embedders would need to compile the WebTestingSupport.cpp themselves, which in turn depends on WebCore headers. * WebKit.gyp: Tools: * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (131834 => 131835) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 01:06:09 UTC (rev 131834) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 01:13:41 UTC (rev 131835) @@ -1,3 +1,15 @@ +2012-10-18 Jochen Eisinger + +[chromium] Add a webkit_test_support target that WebTestingSupport +https://bugs.webkit.org/show_bug.cgi?id=99772 + +Reviewed by Adam Barth. + +Before, embedders would need to compile the WebTestingSupport.cpp +themselves, which in turn depends on WebCore headers. + +* WebKit.gyp: + 2012-10-18 W. James MacLean [chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (131834 => 131835) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 01:06:09 UTC (rev 131834) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 01:13:41 UTC (rev 131835) @@ -864,6 +864,26 @@ ], }, { +'target_name': 'webkit_test_support', +'type': 'static_library', +'dependencies': [ +'../../WTF/WTF.gyp/WTF.gyp:wtf', +'../../WebCore/WebCore.gyp/WebCore.gyp:webcore_test_support', +], +'include_dirs': [ +'public', +'../../WebCore/testing/v8', # for WebCoreTestSupport.h, needed to link in window.internals code. +], +'conditions': [ +['inside_chromium_build==0 or component!="shared_library"', { +'sources': [ +'src/WebTestingSupport.cpp', +'public/WebTestingSupport.h', +], +}], +], +}, +{ 'target_name': 'inspector_resources', 'type': 'none', 'dependencies': [ Modified: trunk/Tools/ChangeLog (131834 => 131835) --- trunk/Tools/ChangeLog 2012-10-19 01:06:09 UTC (rev 131834) +++ trunk/Tools/ChangeLog 2012-10-19 01:13:41 UTC (rev 131835) @@ -1,5 +1,14 @@ 2012-10-18 Jochen Eisinger +[chromium] Add a webkit_test_support target that WebTestingSupport +https://bugs.webkit.org/show_bug.cgi?id=99772 + +Reviewed by Adam Barth. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: + +2012-10-18 Jochen Eisinger + [chromium] move TestRunner files into a src/ sub directory https://bugs.webkit.org/show_bug.cgi?id=99776 Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (131834 => 131835) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-19 01:06:09 UTC (rev 131834) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-19 01:13:41 UTC (rev 131835) @@ -80,6 +80,7 @@ 'dependencies': [ 'TestRunner_resources', '<(source_dir)/WebKit/chromium/WebKit.gyp:webkit', +'<(source_dir)/WebKit/chromium/WebKit.gyp:webkit_test_support', '<(source_dir)/WTF/WTF.gyp/WTF.gyp:wtf', '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support', ], @@ -358,20 +359,6 @@ '<(chromium_src_dir)/webkit/support/setup_third_party.gyp:third_party_headers', ] }], -['inside_chromium_build==0 or component!="shared_library"', { -'dependencies': [ -'<(source_dir)/WebCore/WebCore.gyp/WebCore.gyp:webcore_test_support', -], -'include_dirs': [ -# WARNING: Do not view this particular case as a precedent for -# including WebCore headers in DumpRenderTree pro
[webkit-changes] [131906] trunk/Source/WebKit/chromium
Title: [131906] trunk/Source/WebKit/chromium Revision 131906 Author joc...@chromium.org Date 2012-10-19 09:37:23 -0700 (Fri, 19 Oct 2012) Log Message [chromium] Fix inside chromium build on Mac Unreviewed build fix. Xcode won't create a static library without any sources. So instead of ommitting the sources, just override the webkit_test_support's type with 'none'. * WebKit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (131905 => 131906) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 16:24:43 UTC (rev 131905) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 16:37:23 UTC (rev 131906) @@ -1,3 +1,15 @@ +2012-10-19 Jochen Eisinger + +[chromium] Fix inside chromium build on Mac + +Unreviewed build fix. + +Xcode won't create a static library without any sources. So instead of +ommitting the sources, just override the webkit_test_support's type +with 'none'. + +* WebKit.gyp: + 2012-10-17 Ilya Tikhonovsky Web Inspector: NMI provide data for mixing with tcmalloc heap dumps. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (131905 => 131906) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 16:24:43 UTC (rev 131905) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 16:37:23 UTC (rev 131906) @@ -874,12 +874,13 @@ 'public', '../../WebCore/testing/v8', # for WebCoreTestSupport.h, needed to link in window.internals code. ], +'sources': [ +'src/WebTestingSupport.cpp', +'public/WebTestingSupport.h', +], 'conditions': [ ['inside_chromium_build==0 or component!="shared_library"', { -'sources': [ -'src/WebTestingSupport.cpp', -'public/WebTestingSupport.h', -], +'type': 'none', }], ], }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131911] trunk/Source/WebKit/chromium
Title: [131911] trunk/Source/WebKit/chromium Revision 131911 Author joc...@chromium.org Date 2012-10-19 10:08:10 -0700 (Fri, 19 Oct 2012) Log Message [chromium] fix the fix Unreviewed build fix. Forgot to invert the condition when to set the type to none in the previous attempt. * WebKit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (131910 => 131911) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 16:56:24 UTC (rev 131910) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 17:08:10 UTC (rev 131911) @@ -1,5 +1,16 @@ 2012-10-19 Jochen Eisinger +[chromium] fix the fix + +Unreviewed build fix. + +Forgot to invert the condition when to set the type to none in the +previous attempt. + +* WebKit.gyp: + +2012-10-19 Jochen Eisinger + [chromium] Fix inside chromium build on Mac Unreviewed build fix. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (131910 => 131911) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 16:56:24 UTC (rev 131910) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 17:08:10 UTC (rev 131911) @@ -879,7 +879,7 @@ 'public/WebTestingSupport.h', ], 'conditions': [ -['inside_chromium_build==0 or component!="shared_library"', { +['inside_chromium_build==1 and component=="shared_library"', { 'type': 'none', }], ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [131950] trunk/Source/WebKit/chromium
Title: [131950] trunk/Source/WebKit/chromium Revision 131950 Author joc...@chromium.org Date 2012-10-19 15:24:08 -0700 (Fri, 19 Oct 2012) Log Message [chromium] when building a shared library component build, we must not depend on WebCore Unreviewed build fix. * WebKit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (131949 => 131950) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 22:11:22 UTC (rev 131949) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-19 22:24:08 UTC (rev 131950) @@ -1,3 +1,11 @@ +2012-10-19 Jochen Eisinger + +[chromium] when building a shared library component build, we must not depend on WebCore + +Unreviewed build fix. + +* WebKit.gyp: + 2012-10-19 Tony Chang Unreviewed, rolling out r131936. Modified: trunk/Source/WebKit/chromium/WebKit.gyp (131949 => 131950) --- trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 22:11:22 UTC (rev 131949) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-10-19 22:24:08 UTC (rev 131950) @@ -865,22 +865,23 @@ }, { 'target_name': 'webkit_test_support', -'type': 'static_library', -'dependencies': [ -'../../WTF/WTF.gyp/WTF.gyp:wtf', -'../../WebCore/WebCore.gyp/WebCore.gyp:webcore_test_support', -], -'include_dirs': [ -'public', -'../../WebCore/testing/v8', # for WebCoreTestSupport.h, needed to link in window.internals code. -], -'sources': [ -'src/WebTestingSupport.cpp', -'public/WebTestingSupport.h', -], 'conditions': [ ['inside_chromium_build==1 and component=="shared_library"', { 'type': 'none', +}, { # else: inside_chromium_build==0 or component!="shared_library" +'type': 'static_library', +'dependencies': [ +'../../WTF/WTF.gyp/WTF.gyp:wtf', +'../../WebCore/WebCore.gyp/WebCore.gyp:webcore_test_support', +], +'include_dirs': [ +'public', +'../../WebCore/testing/v8', # for WebCoreTestSupport.h, needed to link in window.internals code. +], +'sources': [ +'src/WebTestingSupport.cpp', +'public/WebTestingSupport.h', +], }], ], }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [132090] trunk/Tools
Title: [132090] trunk/Tools Revision 132090 Author joc...@chromium.org Date 2012-10-22 10:24:47 -0700 (Mon, 22 Oct 2012) Log Message [chromium] add a method for printing message to the WebTestDelegate https://bugs.webkit.org/show_bug.cgi?id=99960 Reviewed by Adam Barth. When using the TestRunner library from the content_shell, we can't print message directly but need to send them to the browser process. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: (WebTestRunner::AccessibilityController::fallbackCallback): * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: (WebTestRunner::AccessibilityController::setDelegate): (AccessibilityController): * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: (WebTestRunner): (WebTestRunner::EventSender::dumpFilenameBeingDragged): * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: (GamepadController::connect): (GamepadController::disconnect): (GamepadController::setId): (GamepadController::setButtonCount): (GamepadController::setButtonData): (GamepadController::setAxisCount): (GamepadController::setAxisData): (GamepadController::fallbackCallback): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: (TestInterfaces::~TestInterfaces): (TestInterfaces::setDelegate): * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: (WebTestInterfaces::Internal): (WebTestRunner::WebTestInterfaces::Internal::printMessage): (WebTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didBeginEditing): (WebViewHost::lastContextMenuData): (WebViewHost::clearContextMenuData): (WebViewHost::setEditCommand): (WebViewHost::clearEditCommand): (WebViewHost::fillSpellingSuggestionList): (WebViewHost::setGamepadData): (WebViewHost::printMessage): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (132089 => 132090) --- trunk/Tools/ChangeLog 2012-10-22 17:19:09 UTC (rev 132089) +++ trunk/Tools/ChangeLog 2012-10-22 17:24:47 UTC (rev 132090) @@ -1,3 +1,53 @@ +2012-10-22 Jochen Eisinger + +[chromium] add a method for printing message to the WebTestDelegate +https://bugs.webkit.org/show_bug.cgi?id=99960 + +Reviewed by Adam Barth. + +When using the TestRunner library from the content_shell, we can't print +message directly but need to send them to the browser process. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: +(WebTestRunner::AccessibilityController::fallbackCallback): +* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: +(WebTestRunner::AccessibilityController::setDelegate): +(AccessibilityController): +* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: +(WebTestRunner): +(WebTestRunner::EventSender::dumpFilenameBeingDragged): +* DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: +(GamepadController::connect): +(GamepadController::disconnect): +(GamepadController::setId): +(GamepadController::setButtonCount): +(GamepadController::setButtonData): +(GamepadController::setAxisCount): +(GamepadController::setAxisData): +(GamepadController::fallbackCallback): +* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: +(TestDelegate): +* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: +(TestInterfaces::~TestInterfaces): +(TestInterfaces::setDelegate): +* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: +(WebTestInterfaces::Internal): +(WebTestRunner::WebTestInterfaces::Internal::printMessage): +(WebTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::didBeginEditing): +(WebViewHost::lastContextMenuData): +(WebViewHost::clearContextMenuData): +(WebViewHost::s
[webkit-changes] [132166] trunk/Tools
Title: [132166] trunk/Tools Revision 132166 Author joc...@chromium.org Date 2012-10-22 17:42:42 -0700 (Mon, 22 Oct 2012) Log Message [chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface https://bugs.webkit.org/show_bug.cgi?id=100048 Reviewed by Adam Barth. The call needs to be done outside of the sandbox. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: (WebTestRunner): (WebTestRunner::EventSender::beginDragWithFiles): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: (WebTestInterfaces::Internal): (WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem): (WebTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::registerIsolatedFileSystem): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (132165 => 132166) --- trunk/Tools/ChangeLog 2012-10-23 00:39:59 UTC (rev 132165) +++ trunk/Tools/ChangeLog 2012-10-23 00:42:42 UTC (rev 132166) @@ -1,3 +1,28 @@ +2012-10-22 Jochen Eisinger + +[chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface +https://bugs.webkit.org/show_bug.cgi?id=100048 + +Reviewed by Adam Barth. + +The call needs to be done outside of the sandbox. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: +(WebTestRunner): +(WebTestRunner::EventSender::beginDragWithFiles): +* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: +(TestDelegate): +* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: +(WebTestInterfaces::Internal): +(WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem): +(WebTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::registerIsolatedFileSystem): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2012-10-22 Dirk Pranke webkitpy: remove unneeded debug messages from find_files() Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (132165 => 132166) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-23 00:39:59 UTC (rev 132165) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-23 00:42:42 UTC (rev 132166) @@ -57,6 +57,8 @@ // for deleting them. virtual void postTask(WebTask*) = 0; virtual void postDelayedTask(WebTask*, long long ms) = 0; + +virtual WebKit::WebString registerIsolatedFileSystem(const WebKit::WebVector& absoluteFilenames) = 0; }; } Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp (132165 => 132166) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp 2012-10-23 00:39:59 UTC (rev 132165) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp 2012-10-23 00:42:42 UTC (rev 132166) @@ -51,6 +51,7 @@ #include "platform/WebDragData.h" #include "platform/WebPoint.h" #include "platform/WebString.h" +#include "platform/WebVector.h" #include "webkit/support/webkit_support.h" #include #include @@ -901,15 +902,15 @@ { currentDragData.initialize(); Vector files = arguments[0].toStringVector(); -Vector absoluteFilenames; +WebVector absoluteFilenames(files.size()); for (size_t i = 0; i < files.size(); ++i) { WebDragData::Item item; item.storageType = WebDragData::Item::StorageTypeFilename; item.filenameData = webkit_support::GetAbsoluteWebStringFromUTF8Path(files[i]); currentDragData.addItem(item); -absoluteFilenames.append(item.filenameData); +absoluteFilenames[i] = item.filenameData; } -currentDragData.setFilesystemId(webkit_support::RegisterIsolatedFileSystem(absoluteFilenames)); +currentDragData.setFilesystemId(m_delegate->registerIsolatedFileSystem(absoluteFilenames)); currentDragEffectsAllowed = WebKit::WebDragOperationCopy; // Provide a drag source. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h (132165 => 132166) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h 2012-10-23 00:39:59 UTC (rev 132165) ++
[webkit-changes] [132241] trunk/Tools
Title: [132241] trunk/Tools Revision 132241 Author joc...@chromium.org Date 2012-10-23 10:25:36 -0700 (Tue, 23 Oct 2012) Log Message [chromium] remove the const qualifier from WebTestDelegate::printMessage https://bugs.webkit.org/show_bug.cgi?id=100082 Reviewed by Adam Barth. There's no reason the method should be const, and indeed for content_shell we want to send an IPC which is a non-const operation. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: (WebTestInterfaces::Internal): (WebTestRunner::WebTestInterfaces::Internal::printMessage): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::printMessage): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (132240 => 132241) --- trunk/Tools/ChangeLog 2012-10-23 17:12:47 UTC (rev 132240) +++ trunk/Tools/ChangeLog 2012-10-23 17:25:36 UTC (rev 132241) @@ -1,3 +1,25 @@ +2012-10-23 Jochen Eisinger + +[chromium] remove the const qualifier from WebTestDelegate::printMessage +https://bugs.webkit.org/show_bug.cgi?id=100082 + +Reviewed by Adam Barth. + +There's no reason the method should be const, and indeed for +content_shell we want to send an IPC which is a non-const operation. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: +(TestDelegate): +* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: +(WebTestInterfaces::Internal): +(WebTestRunner::WebTestInterfaces::Internal::printMessage): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::printMessage): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2012-10-23 Kenneth Rohde Christiansen Add support for resolution media query Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (132240 => 132241) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-23 17:12:47 UTC (rev 132240) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-23 17:25:36 UTC (rev 132241) @@ -51,7 +51,7 @@ virtual void setEditCommand(const std::string& name, const std::string& value) = 0; virtual WebKit::WebContextMenuData* lastContextMenuData() const = 0; virtual void setGamepadData(const WebKit::WebGamepads&) = 0; -virtual void printMessage(const std::string& message) const = 0; +virtual void printMessage(const std::string& message) = 0; // The delegate takes ownership of the WebTask objects and is responsible // for deleting them. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h (132240 => 132241) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h 2012-10-23 17:12:47 UTC (rev 132240) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h 2012-10-23 17:25:36 UTC (rev 132241) @@ -51,7 +51,7 @@ virtual void setEditCommand(const std::string& name, const std::string& value) = 0; virtual WebKit::WebContextMenuData* lastContextMenuData() const = 0; virtual void setGamepadData(const WebKit::WebGamepads&) = 0; -virtual void printMessage(const std::string& message) const = 0; +virtual void printMessage(const std::string& message) = 0; virtual void postTask(WebTestRunner::WebTask*) = 0; virtual void postDelayedTask(WebTestRunner::WebTask*, long long ms) = 0; virtual WebKit::WebString registerIsolatedFileSystem(const WebKit::WebVector& absoluteFilenames) = 0; Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp (132240 => 132241) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp 2012-10-23 17:12:47 UTC (rev 132240) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp 2012-10-23 17:25:36 UTC (rev 132241) @@ -63,7 +63,7 @@ virtual void setEditCommand(const std::string& name, const std::string& value); virtual WebContextMenuData* lastContextMenuData() const; virtual void setGamepadData(const WebGamepads&); -virtual void printMessage(const std::string& message) const; +virtual void printMessage(const std::string& message); virtual void postTask(WebTask*); virtual void postDelayedTask(WebT
[webkit-changes] [132370] trunk/Tools
Title: [132370] trunk/Tools Revision 132370 Author joc...@chromium.org Date 2012-10-24 10:44:06 -0700 (Wed, 24 Oct 2012) Log Message [chromium] Use include paths relative to Source/ in the TestRunner's public API https://bugs.webkit.org/show_bug.cgi?id=100079 Reviewed by Adam Barth. For a inside-chromium build, we usually don't add the WebKit API paths as include paths, so including files by name only does not work. Eventually we might want to move to a model where all includes are relative to Source/, so we're using that here already now. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h Diff Modified: trunk/Tools/ChangeLog (132369 => 132370) --- trunk/Tools/ChangeLog 2012-10-24 17:36:32 UTC (rev 132369) +++ trunk/Tools/ChangeLog 2012-10-24 17:44:06 UTC (rev 132370) @@ -1,3 +1,20 @@ +2012-10-24 Jochen Eisinger + +[chromium] Use include paths relative to Source/ in the TestRunner's public API +https://bugs.webkit.org/show_bug.cgi?id=100079 + +Reviewed by Adam Barth. + +For a inside-chromium build, we usually don't add the WebKit API paths +as include paths, so including files by name only does not work. + +Eventually we might want to move to a model where all includes are +relative to Source/, so we're using that here already now. + +* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: +* DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: + 2012-10-24 Ojan Vafai Show an error when there are no completed builds in the past 20 runs Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (132369 => 132370) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-24 17:36:32 UTC (rev 132369) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2012-10-24 17:44:06 UTC (rev 132370) @@ -93,10 +93,12 @@ '<(DEPTH)', '../chromium/TestRunner/public', '../chromium/TestRunner/src', +'../../../Source', ], 'direct_dependent_settings': { 'include_dirs': [ '../chromium/TestRunner/public', +'../../../Source', ], }, 'sources': [ Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h (132369 => 132370) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h 2012-10-24 17:36:32 UTC (rev 132369) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h 2012-10-24 17:44:06 UTC (rev 132370) @@ -31,7 +31,7 @@ #ifndef WebEventSender_h #define WebEventSender_h -#include "WebDragOperation.h" +#include "WebKit/chromium/public/WebDragOperation.h" namespace WebKit { class WebDragData; Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (132369 => 132370) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-24 17:36:32 UTC (rev 132369) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2012-10-24 17:44:06 UTC (rev 132370) @@ -31,8 +31,8 @@ #ifndef WebTestDelegate_h #define WebTestDelegate_h -#include "platform/WebString.h" -#include "platform/WebVector.h" +#include "Platform/chromium/public/WebString.h" +#include "Platform/chromium/public/WebVector.h" namespace WebKit { struct WebContextMenuData; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [132552] trunk/Tools
Title: [132552] trunk/Tools Revision 132552 Author joc...@chromium.org Date 2012-10-25 18:51:01 -0700 (Thu, 25 Oct 2012) Log Message [chromium] remove remaining usages of webkit_support from the TestRunner library https://bugs.webkit.org/show_bug.cgi?id=100344 Reviewed by Adam Barth. The most important part is to not rely on calling out to gdk/X11 to translate keycodes to hardware keycodes, as this is not possible inside the sandbox. * DumpRenderTree/DumpRenderTree.gypi: * DumpRenderTree/chromium/DRTTestRunner.h: (WebKit): (webkit_support): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: (WebTestRunner): (WebTestRunner::EventSender::doDragDrop): (WebTestRunner::EventSender::updateClickCountForButton): (WebTestRunner::EventSender::mouseDown): (WebTestRunner::EventSender::mouseUp): (WebTestRunner::EventSender::mouseMoveTo): (WebTestRunner::EventSender::keyDown): (WebTestRunner::EventSender::replaySavedEvents): (WebTestRunner::EventSender::contextClick): (WebTestRunner::EventSender::beginDragWithFiles): (WebTestRunner::EventSender::sendCurrentTouchEvent): (WebTestRunner::EventSender::handleMouseWheel): (WebTestRunner::EventSender::gestureEvent): (WebTestRunner::EventSender::gestureFlingCancel): (WebTestRunner::EventSender::gestureFlingStart): * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added. (WebTestRunner): (WebTestRunner::NativeKeyCodeForWindowsKeyCode): * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h. (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: (TestDelegate): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: (WebTestInterfaces::Internal): (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond): (WebTestRunner): (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::getCurrentTimeInMillisecond): (WebViewHost::getAbsoluteWebStringFromUTF8Path): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gypi trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Added Paths trunk/Tools/DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h Diff Modified: trunk/Tools/ChangeLog (132551 => 132552) --- trunk/Tools/ChangeLog 2012-10-26 01:49:41 UTC (rev 132551) +++ trunk/Tools/ChangeLog 2012-10-26 01:51:01 UTC (rev 132552) @@ -1,3 +1,57 @@ +2012-10-25 Jochen Eisinger + +[chromium] remove remaining usages of webkit_support from the TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=100344 + +Reviewed by Adam Barth. + +The most important part is to not rely on calling out to gdk/X11 to +translate keycodes to hardware keycodes, as this is not possible inside +the sandbox. + +* DumpRenderTree/DumpRenderTree.gypi: +* DumpRenderTree/chromium/DRTTestRunner.h: +(WebKit): +(webkit_support): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +* DumpRenderTree/chromium/TestRunner/src/CppVariant.h: +* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: +(WebTestRunner): +(WebTestRunner::EventSender::doDragDrop): +(WebTestRunner::EventSender::updateClickCountForButton): +(WebTestRunner::EventSender::mouseDown): +(WebTestRunner::EventSender::mouseUp): +(WebTestRunner::EventSender::mouseMoveTo): +(WebTestRunner::EventSender::keyDown): +(WebTestRunner::EventSender::replaySavedEvents): +(WebTestRunner::EventSender::contextClick): +(WebTestRunner::EventSender::beginDragWithFiles): +(WebTestRunner::EventSender::sendCurrentTouchEvent): +(WebTestRunner::EventSender::handleMouseWheel): +(WebTestRunner::EventSender::gestureEvent): +(WebTestRunner::EventSender::gestureFlingCancel): +(WebTestRunner::EventSender::gestureFlingSt
[webkit-changes] [136899] trunk
Title: [136899] trunk Revision 136899 Author joc...@chromium.org Date 2012-12-06 15:20:12 -0800 (Thu, 06 Dec 2012) Log Message [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture https://bugs.webkit.org/show_bug.cgi?id=104306 Reviewed by Dimitri Glazkov. Source/WebKit/chromium: In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was introduced in chromium's WebKit layer intended to fix a problem with plugins, however, it also affected regular event handling, so I removed it in http://trac.webkit.org/changeset/128273. Turns out it still is a problem for plugins. This change adds the UserGestureIndicator back, however, only for the WebPluginContainer. * public/WebInputEvent.h: (WebInputEvent): (WebKit::WebInputEvent::isUserGestureEventType): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): Tools: * DumpRenderTree/chromium/TestWebPlugin.cpp: (TestWebPlugin::TestWebPlugin): (TestWebPlugin::handleInputEvent): add support for printing the user gesture status * DumpRenderTree/chromium/TestWebPlugin.h: (TestWebPlugin): LayoutTests: * platform/chromium/plugins/user-gesture-expected.txt: Added. * platform/chromium/plugins/user-gesture.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebInputEvent.h trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.h Added Paths trunk/LayoutTests/platform/chromium/plugins/user-gesture-expected.txt trunk/LayoutTests/platform/chromium/plugins/user-gesture.html Diff Modified: trunk/LayoutTests/ChangeLog (136898 => 136899) --- trunk/LayoutTests/ChangeLog 2012-12-06 23:02:11 UTC (rev 136898) +++ trunk/LayoutTests/ChangeLog 2012-12-06 23:20:12 UTC (rev 136899) @@ -1,3 +1,13 @@ +2012-12-06 Jochen Eisinger + +[chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture +https://bugs.webkit.org/show_bug.cgi?id=104306 + +Reviewed by Dimitri Glazkov. + +* platform/chromium/plugins/user-gesture-expected.txt: Added. +* platform/chromium/plugins/user-gesture.html: Added. + 2012-12-06 David Grogan IndexedDB: Add webkitErrorMessage to IDBTransaction Added: trunk/LayoutTests/platform/chromium/plugins/user-gesture-expected.txt (0 => 136899) --- trunk/LayoutTests/platform/chromium/plugins/user-gesture-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/plugins/user-gesture-expected.txt 2012-12-06 23:20:12 UTC (rev 136899) @@ -0,0 +1,14 @@ +Plugin received event: MouseEnter +* not handling user gesture +Plugin received event: MouseMove +* not handling user gesture +Plugin received event: MouseDown +* handling user gesture +Plugin received event: MouseUp +* handling user gesture +Plugin received event: MouseDown +* not handling user gesture +Plugin received event: MouseUp +* not handling user gesture + +Test that the user gesture indicator is correctly set for events forwarded through the WebPluginContainer. The tests succeeds if the first mousedown/mouseup event pair is a user gesture, and the second is not. Added: trunk/LayoutTests/platform/chromium/plugins/user-gesture.html (0 => 136899) --- trunk/LayoutTests/platform/chromium/plugins/user-gesture.html (rev 0) +++ trunk/LayoutTests/platform/chromium/plugins/user-gesture.html 2012-12-06 23:20:12 UTC (rev 136899) @@ -0,0 +1,33 @@ + + + + + + Test that the user gesture indicator is correctly set for events forwarded + through the WebPluginContainer. The tests succeeds if the first + mousedown/mouseup event pair is a user gesture, and the second is not. + + +if (!window.testRunner || !window.eventSender) { +document.write("This test does not work in manual mode."); +} else { +testRunner.dumpAsText(); + +// Click on the plugin. +eventSender.mouseMoveTo(20, 20); +eventSender.mouseDown(); +eventSender.mouseUp(); + +// Fake mouse events +var plugin = document.getElementById("plugin"); +var evt = document.createEvent("MouseEvent"); +evt.initMouseEvent("mousedown", true, true, window, 1, 20, 20, 20, 20, false, false, false, false, 0, null); +plugin.dispatchEvent(evt); + +evt = document.createEvent("MouseEvent"); +evt.initMouseEvent("mouseup", true, true, window, 1, 20, 20, 20, 20, false, false, false, false, 0, null); +plugin.dispatchEvent(evt); +} + + + Modified: trunk/Source/WebKit/chromium/ChangeLog (136898 => 136899) --- trunk/Source/WebKit/chromium/ChangeLog 2012-12-06 23:02:11 UTC (rev 136898) +++ trunk/Source
[webkit-changes] [136962] trunk/Tools
Title: [136962] trunk/Tools Revision 136962 Author joc...@chromium.org Date 2012-12-07 10:26:02 -0800 (Fri, 07 Dec 2012) Log Message Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers https://bugs.webkit.org/show_bug.cgi?id=104355 Reviewed by Dirk Pranke. This enables chromium's content_shell driver to run with the full SUID sandbox. * Scripts/webkitpy/layout_tests/port/base.py: (Port.to.setup_environ_for_server): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py Diff Modified: trunk/Tools/ChangeLog (136961 => 136962) --- trunk/Tools/ChangeLog 2012-12-07 18:16:11 UTC (rev 136961) +++ trunk/Tools/ChangeLog 2012-12-07 18:26:02 UTC (rev 136962) @@ -1,3 +1,16 @@ +2012-12-07 Jochen Eisinger + +Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers +https://bugs.webkit.org/show_bug.cgi?id=104355 + +Reviewed by Dirk Pranke. + +This enables chromium's content_shell driver to run with the full SUID +sandbox. + +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.to.setup_environ_for_server): + 2012-12-07 KyungTae Kim [EFL] Fix tools for WebKit2-only builds Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (136961 => 136962) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-12-07 18:16:11 UTC (rev 136961) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-12-07 18:26:02 UTC (rev 136962) @@ -898,6 +898,9 @@ # Most ports (?): 'WEBKIT_TESTFONTS', 'WEBKITOUTPUTDIR', + +# Chromium: +'CHROME_DEVEL_SANDBOX', ] for variable in variables_to_copy: self._copy_value_from_environ_if_set(clean_env, variable) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137439] trunk/Tools
Title: [137439] trunk/Tools Revision 137439 Author joc...@chromium.org Date 2012-12-12 02:37:31 -0800 (Wed, 12 Dec 2012) Log Message [chromium] WebTestPlugin must not depend on WTF::String https://bugs.webkit.org/show_bug.cgi?id=104783 Reviewed by Kent Tamura. In a component build, we can't access the WTF that is part of the WebKit component. Accessing WTF instead will pull in a separate copy into the TestRunner library. Instead of WTF::String::number use snprintf() to print numbers. * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp Diff Modified: trunk/Tools/ChangeLog (137438 => 137439) --- trunk/Tools/ChangeLog 2012-12-12 10:23:51 UTC (rev 137438) +++ trunk/Tools/ChangeLog 2012-12-12 10:37:31 UTC (rev 137439) @@ -1,3 +1,17 @@ +2012-12-12 Jochen Eisinger + +[chromium] WebTestPlugin must not depend on WTF::String +https://bugs.webkit.org/show_bug.cgi?id=104783 + +Reviewed by Kent Tamura. + +In a component build, we can't access the WTF that is part of the +WebKit component. Accessing WTF instead will pull in a separate copy +into the TestRunner library. Instead of WTF::String::number use +snprintf() to print numbers. + +* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: + 2012-12-12 Jocelyn Turcotte [Qt] Do not automatically enable force_static_libs_as_shared when using debug_and_release Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp (137438 => 137439) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-12 10:23:51 UTC (rev 137438) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-12 10:37:31 UTC (rev 137439) @@ -37,7 +37,6 @@ #include "platform/WebKitPlatformSupport.h" #include #include -#include using namespace WebKit; @@ -104,8 +103,11 @@ void printTouchList(WebTestDelegate* delegate, const WebTouchPoint* points, int length) { -for (int i = 0; i < length; ++i) -delegate->printMessage(std::string("* ") + String::number(points[i].position.x).ascii().data() + ", " + String::number(points[i].position.y).ascii().data() + ": " + pointState(points[i].state) + "\n"); +for (int i = 0; i < length; ++i) { +char buffer[100]; +snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n", points[i].position.x, points[i].position.y, pointState(points[i].state)); +delegate->printMessage(buffer); +} } void printEventDetails(WebTestDelegate* delegate, const WebInputEvent& event) @@ -117,10 +119,14 @@ printTouchList(delegate, touch.targetTouches, touch.targetTouchesLength); } else if (WebInputEvent::isMouseEventType(event.type) || event.type == WebInputEvent::MouseWheel) { const WebMouseEvent& mouse = static_cast(event); -delegate->printMessage(std::string("* ") + String::number(mouse.x).ascii().data() + ", " + String::number(mouse.y).ascii().data() + "\n"); +char buffer[100]; +snprintf(buffer, sizeof(buffer), "* %d, %d\n", mouse.x, mouse.y); +delegate->printMessage(buffer); } else if (WebInputEvent::isGestureEventType(event.type)) { const WebGestureEvent& gesture = static_cast(event); -delegate->printMessage(std::string("* ") + String::number(gesture.x).ascii().data() + ", " + String::number(gesture.y).ascii().data() + "\n"); +char buffer[100]; +snprintf(buffer, sizeof(buffer), "* %d, %d\n", gesture.x, gesture.y); +delegate->printMessage(buffer); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137448] trunk/Tools
Title: [137448] trunk/Tools Revision 137448 Author joc...@chromium.org Date 2012-12-12 03:36:06 -0800 (Wed, 12 Dec 2012) Log Message [chromium] Fix build on chromium-win Unreviewed build-fix. MSVS indeed doesn't have snprintf, adding wtf/StringExtras.h include to work around that. * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp Diff Modified: trunk/Tools/ChangeLog (137447 => 137448) --- trunk/Tools/ChangeLog 2012-12-12 11:34:46 UTC (rev 137447) +++ trunk/Tools/ChangeLog 2012-12-12 11:36:06 UTC (rev 137448) @@ -1,3 +1,14 @@ +2012-12-12 Jochen Eisinger + +[chromium] Fix build on chromium-win + +Unreviewed build-fix. + +MSVS indeed doesn't have snprintf, adding wtf/StringExtras.h include +to work around that. + +* DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: + 2012-12-12 Simon Hausmann [Qt] Fix build on Mac Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp (137447 => 137448) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-12 11:34:46 UTC (rev 137447) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp 2012-12-12 11:36:06 UTC (rev 137448) @@ -36,6 +36,7 @@ #include "platform/WebGraphicsContext3D.h" #include "platform/WebKitPlatformSupport.h" #include +#include #include using namespace WebKit; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [137922] trunk/Tools
Title: [137922] trunk/Tools Revision 137922 Author joc...@chromium.org Date 2012-12-17 10:46:33 -0800 (Mon, 17 Dec 2012) Log Message [chromium] removed unused preferences from testRunner.overridePreference https://bugs.webkit.org/show_bug.cgi?id=105169 Reviewed by Tony Chang. Most notably this removes the code related to font family maps which is now handled via window.internals.settings * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: (WebPreferences): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::overridePreference): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: (WebTestRunner::WebPreferences::applyTo): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp Diff Modified: trunk/Tools/ChangeLog (137921 => 137922) --- trunk/Tools/ChangeLog 2012-12-17 18:44:44 UTC (rev 137921) +++ trunk/Tools/ChangeLog 2012-12-17 18:46:33 UTC (rev 137922) @@ -1,3 +1,22 @@ +2012-12-17 Jochen Eisinger + +[chromium] removed unused preferences from testRunner.overridePreference +https://bugs.webkit.org/show_bug.cgi?id=105169 + +Reviewed by Tony Chang. + +Most notably this removes the code related to font family maps which is +now handled via window.internals.settings + +* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: +(WebPreferences): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::overridePreference): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: +(WebTestRunner::WebPreferences::applyTo): + 2012-12-17 James Robinson [chromium] Move creation of WebLayerTreeView to WebWidgetClient Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h (137921 => 137922) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h 2012-12-17 18:44:44 UTC (rev 137921) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h 2012-12-17 18:46:33 UTC (rev 137922) @@ -34,7 +34,6 @@ #include "Platform/chromium/public/WebString.h" #include "Platform/chromium/public/WebURL.h" #include "WebKit/chromium/public/WebSettings.h" -#include namespace WebKit { class WebView; @@ -50,15 +49,6 @@ WebKit::WebString cursiveFontFamily; WebKit::WebString fantasyFontFamily; -// Map of UScriptCode to font such as USCRIPT_ARABIC to "My Arabic Font". -typedef std::map ScriptFontFamilyMap; -ScriptFontFamilyMap standardFontMap; -ScriptFontFamilyMap fixedFontMap; -ScriptFontFamilyMap serifFontMap; -ScriptFontFamilyMap sansSerifFontMap; -ScriptFontFamilyMap cursiveFontMap; -ScriptFontFamilyMap fantasyFontMap; - int defaultFontSize; int defaultFixedFontSize; int minimumFontSize; Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp (137921 => 137922) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2012-12-17 18:44:44 UTC (rev 137921) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2012-12-17 18:46:33 UTC (rev 137922) @@ -60,27 +60,6 @@ namespace WebTestRunner { -namespace { - -// Sets map based on scriptFontPairs, a collapsed vector of pairs of ISO 15924 -// four-letter script code and font such as: -// { "Arab", "My Arabic Font", "Grek", "My Greek Font" } -static void setFontMap(WebPreferences::ScriptFontFamilyMap& map, const Vector& scriptFontPairs) -{ -map.clear(); -size_t i = 0; -while (i + 1 < scriptFontPairs.size()) { -const WebString& script = scriptFontPairs[i++]; -const WebString& font = scriptFontPairs[i++]; - -int32_t code = u_getPropertyValueEnum(UCHAR_SCRIPT, script.utf8().data()); -if (code >= 0 && code < USCRIPT_CODE_LIMIT) -map[static_cast(code)] = font; -} -} - -} - TestRunner::TestRunner() : m_delegate(0) , m_webView(0) @@ -794,72 +773,26 @@ string key = arguments[0].toString(); CppVariant value = arguments[1]; WebPreferences* prefs = m_delegate->preferences(); -if (key == "WebKitStandardFont") -prefs->standardFontFamily = cppVariantToWebString(value); -else if (key == "WebKitFixedFont") -prefs->fixedFontFamily = cppVariantToWebString(value); -else if (key == "WebKitSerifFont") -prefs->serifFontFamily = cppVariantToWebSt
[webkit-changes] [137992] trunk/Tools
Title: [137992] trunk/Tools Revision 137992 Author joc...@chromium.org Date 2012-12-17 23:58:35 -0800 (Mon, 17 Dec 2012) Log Message [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences https://bugs.webkit.org/show_bug.cgi?id=105154 Reviewed by Tony Chang. If the settings are modified directly, the embedder can't keep track of them and might accidentially override the changed settings. * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: (WebPreferences): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled): (WebTestRunner): (WebTestRunner::TestRunner::setMinimumTimerInterval): (WebTestRunner::TestRunner::setTouchDragDropEnabled): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: (WebTestRunner::WebPreferences::reset): (WebTestRunner::WebPreferences::applyTo): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp Diff Modified: trunk/Tools/ChangeLog (137991 => 137992) --- trunk/Tools/ChangeLog 2012-12-18 07:34:20 UTC (rev 137991) +++ trunk/Tools/ChangeLog 2012-12-18 07:58:35 UTC (rev 137992) @@ -1,3 +1,27 @@ +2012-12-17 Jochen Eisinger + +[chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences +https://bugs.webkit.org/show_bug.cgi?id=105154 + +Reviewed by Tony Chang. + +If the settings are modified directly, the embedder can't keep track of +them and might accidentially override the changed settings. + +* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: +(WebPreferences): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled): +(WebTestRunner): +(WebTestRunner::TestRunner::setMinimumTimerInterval): +(WebTestRunner::TestRunner::setTouchDragDropEnabled): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: +(WebTestRunner::WebPreferences::reset): +(WebTestRunner::WebPreferences::applyTo): + 2012-12-17 Julien Chaffraix Unreviewed unit test skipping. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h (137991 => 137992) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h 2012-12-18 07:34:20 UTC (rev 137991) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h 2012-12-18 07:58:35 UTC (rev 137992) @@ -101,6 +101,9 @@ bool mockScrollbarsEnabled; bool cssCustomFilterEnabled; bool shouldRespectImageOrientation; +bool asynchronousSpellCheckingEnabled; +double minimumTimerInterval; +bool touchDragDropEnabled; WebPreferences() { reset(); } void reset(); Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp (137991 => 137992) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2012-12-18 07:34:20 UTC (rev 137991) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp 2012-12-18 07:58:35 UTC (rev 137992) @@ -66,7 +66,6 @@ { // Methods implemented in terms of chromium's public WebKit API. bindMethod("setTabKeyCyclesThroughElements", &TestRunner::setTabKeyCyclesThroughElements); -bindMethod("setAsynchronousSpellCheckingEnabled", &TestRunner::setAsynchronousSpellCheckingEnabled); bindMethod("execCommand", &TestRunner::execCommand); bindMethod("isCommandEnabled", &TestRunner::isCommandEnabled); bindMethod("pauseAnimationAtTimeOnElementWithId", &TestRunner::pauseAnimationAtTimeOnElementWithId); @@ -89,7 +88,6 @@ bindMethod("loseCompositorContext", &TestRunner::loseCompositorContext); bindMethod("markerTextForListItem", &TestRunner::markerTextForListItem); bindMethod("findString", &TestRunner::findString); -bindMethod("setMinimumTimerInterval", &TestRunner::setMinimumTimerInterval); bindMethod("setAutofilled", &TestRunner::setAutofilled); bindMethod("setValueForUser", &TestRunner::setValueForUser); bindMethod("enableFixedLayoutMode", &TestRunner::enableFixedLayoutMode); @@ -100,7 +98,6 @@ bindMethod("setPageVisibility", &TestRunner::setPageVis
[webkit-changes] [137997] trunk/Tools
Title: [137997] trunk/Tools Revision 137997 Author joc...@chromium.org Date 2012-12-18 01:05:03 -0800 (Tue, 18 Dec 2012) Log Message [chromium] move webintent related methods to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=105164 Reviewed by Darin Fisher. Also deleted the unused deliveredIntentFailure and deliveredIntentResult methods. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebKit): (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest): (WebTestRunner::WebTestDelegate::currentWebIntentRequest): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebKit): (WebTestProxyBase): (WebTestRunner::WebTestProxy::registerIntentService): (WebTestRunner::WebTestProxy::dispatchIntent): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::sendWebIntentResponse): (WebTestRunner): (WebTestRunner::TestRunner::deliverWebIntent): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::postAccessibilityNotification): (WebTestRunner::WebTestProxyBase::registerIntentService): (WebTestRunner): (WebTestRunner::WebTestProxyBase::dispatchIntent): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::setCurrentWebIntentRequest): (WebViewHost::currentWebIntentRequest): * DumpRenderTree/chromium/WebViewHost.h: (WebKit): (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (137996 => 137997) --- trunk/Tools/ChangeLog 2012-12-18 09:02:09 UTC (rev 137996) +++ trunk/Tools/ChangeLog 2012-12-18 09:05:03 UTC (rev 137997) @@ -1,5 +1,47 @@ 2012-12-18 Jochen Eisinger +[chromium] move webintent related methods to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=105164 + +Reviewed by Darin Fisher. + +Also deleted the unused deliveredIntentFailure and +deliveredIntentResult methods. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebKit): +(WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest): +(WebTestRunner::WebTestDelegate::currentWebIntentRequest): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebKit): +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::registerIntentService): +(WebTestRunner::WebTestProxy::dispatchIntent): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::sendWebIntentResponse): +(WebTestRunner): +(WebTestRunner::TestRunner::deliverWebIntent): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::postAccessibilityNotification): +(WebTestRunner::WebTestProxyBase::registerIntentService): +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::dispatchIntent): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::setCurrentWebIntentRequest): +(WebViewHost::currentWebIntentRequest): +* DumpRenderTree/chromium/WebViewHost.h: +(WebKit): +(WebViewHost): + +2012-12-18 Jochen Eisinger + [chromium] move editing callback dumping to the WebTestProxy https://bugs.webkit.org/show_bug.cgi?id=105013 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (137996 => 137997) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-12-18 09:02:09 UTC (rev 137996) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2012-12-18 09:05:03 UTC (rev 137997) @@ -50,8 +50,6 @@ #include "WebGeolocationClientMock.h" #include "WebIDBFactory.h" #include "WebInputElement.h" -#include "WebIntent.h" -#include "WebIntentRequest.h" #include "WebKit.h" #include "WebNotificationPresenter.h" #include &
[webkit-changes] [138239] trunk/Tools
Title: [138239] trunk/Tools Revision 138239 Author joc...@chromium.org Date 2012-12-20 02:39:42 -0800 (Thu, 20 Dec 2012) Log Message [chromium] fix stray printf in TestRunner's WebTestProxy https://bugs.webkit.org/show_bug.cgi?id=105515 Reviewed by Ryosuke Niwa. * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::shouldInsertNode): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp Diff Modified: trunk/Tools/ChangeLog (138238 => 138239) --- trunk/Tools/ChangeLog 2012-12-20 10:20:21 UTC (rev 138238) +++ trunk/Tools/ChangeLog 2012-12-20 10:39:42 UTC (rev 138239) @@ -1,3 +1,13 @@ +2012-12-20 Jochen Eisinger + +[chromium] fix stray printf in TestRunner's WebTestProxy +https://bugs.webkit.org/show_bug.cgi?id=105515 + +Reviewed by Ryosuke Niwa. + +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::shouldInsertNode): + 2012-12-20 Dominik Röttsches [WK2] WebAudio WKTR support Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp (138238 => 138239) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-12-20 10:20:21 UTC (rev 138238) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp 2012-12-20 10:39:42 UTC (rev 138239) @@ -323,7 +323,7 @@ printNodeDescription(m_delegate, node, 0); m_delegate->printMessage(" replacingDOMRange:"); printRangeDescription(m_delegate, range); -printf(" givenAction:%s\n", editingActionDescription(action).c_str()); +m_delegate->printMessage(string(" givenAction:") + editingActionDescription(action) + "\n"); } return true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138980] trunk/Tools
Title: [138980] trunk/Tools Revision 138980 Author joc...@chromium.org Date 2013-01-07 13:21:28 -0800 (Mon, 07 Jan 2013) Log Message [chromium] move dumpAsText and friends to the TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106222 Reviewed by Adam Barth. This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::shouldDumpAsText): (WebTestRunner::WebTestRunner::setShouldDumpAsText): (WebTestRunner::WebTestRunner::shouldGeneratePixelResults): (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults): (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions): (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::shouldDumpAsText): (WebTestRunner): (WebTestRunner::TestRunner::setShouldDumpAsText): (WebTestRunner::TestRunner::shouldGeneratePixelResults): (WebTestRunner::TestRunner::setShouldGeneratePixelResults): (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions): (WebTestRunner::TestRunner::shouldDumpChildFramesAsText): (WebTestRunner::TestRunner::dumpAsText): (WebTestRunner::TestRunner::dumpChildFrameScrollPositions): (WebTestRunner::TestRunner::dumpChildFramesAsText): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h Diff Modified: trunk/Tools/ChangeLog (138979 => 138980) --- trunk/Tools/ChangeLog 2013-01-07 20:58:46 UTC (rev 138979) +++ trunk/Tools/ChangeLog 2013-01-07 21:21:28 UTC (rev 138980) @@ -1,3 +1,40 @@ +2013-01-07 Jochen Eisinger + +[chromium] move dumpAsText and friends to the TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106222 + +Reviewed by Adam Barth. + +This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::shouldDumpAsText): +(WebTestRunner::WebTestRunner::setShouldDumpAsText): +(WebTestRunner::WebTestRunner::shouldGeneratePixelResults): +(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults): +(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions): +(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::shouldDumpAsText): +(WebTestRunner): +(WebTestRunner::TestRunner::setShouldDumpAsText): +(WebTestRunner::TestRunner::shouldGeneratePixelResults): +(WebTestRunner::TestRunner::setShouldGeneratePixelResults): +(WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions): +(WebTestRunner::TestRunner::shouldDumpChildFramesAsText): +(WebTestRunner::TestRunner::dumpAsText): +(WebTestRunner::TestRunner::dumpChildFrameScrollPositions): +(WebTestRunner::TestRunner::dumpChildFramesAsText): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): + 2013-01-07 Ryosuke Niwa Build fix attempt after r138810. Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (138979 => 138980) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-07 20:58:46 UTC (rev 138979) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-07 21:21:28 UTC (rev 138980) @@ -117,10 +117,7 @@ bindMethod("disableAutoResizeMode", &DRTTestRunner::disableAutoResizeMode); bindMethod("display", &DRTTestRunner::display); bindMethod("displayInvalidatedRegion", &DRTTestRunner::displayInvalidatedRegion); -bindMethod("dumpAsText", &DRTTestRunner::dumpAsText); bindMethod("dumpBackForwardList", &DRTTestRunner::dumpBackForwardList); -bindMethod("dumpChildFramesAsText", &DRTTestRunner::dumpChildFramesAsText); -
[webkit-changes] [138993] trunk/Tools
Title: [138993] trunk/Tools Revision 138993 Author joc...@chromium.org Date 2013-01-07 14:52:17 -0800 (Mon, 07 Jan 2013) Log Message [chromium] move web audio related methods to testrunner library https://bugs.webkit.org/show_bug.cgi?id=106211 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebKit): (WebTestRunner::WebTestRunner::shouldDumpAsAudio): (WebTestRunner::WebTestRunner::audioData): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::shouldDumpAsAudio): (WebTestRunner): (WebTestRunner::TestRunner::audioData): (WebTestRunner::TestRunner::setAudioData): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Diff Modified: trunk/Tools/ChangeLog (138992 => 138993) --- trunk/Tools/ChangeLog 2013-01-07 22:24:54 UTC (rev 138992) +++ trunk/Tools/ChangeLog 2013-01-07 22:52:17 UTC (rev 138993) @@ -1,3 +1,31 @@ +2013-01-07 Jochen Eisinger + +[chromium] move web audio related methods to testrunner library +https://bugs.webkit.org/show_bug.cgi?id=106211 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebKit): +(WebTestRunner::WebTestRunner::shouldDumpAsAudio): +(WebTestRunner::WebTestRunner::audioData): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::shouldDumpAsAudio): +(WebTestRunner): +(WebTestRunner::TestRunner::audioData): +(WebTestRunner::TestRunner::setAudioData): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::dump): + 2013-01-07 Mike West Make the IFRAME_SEAMLESS flag runtime-enabled. Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (138992 => 138993) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-07 22:24:54 UTC (rev 138992) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-07 22:52:17 UTC (rev 138993) @@ -153,7 +153,6 @@ bindMethod("setCustomPolicyDelegate", &DRTTestRunner::setCustomPolicyDelegate); bindMethod("setDatabaseQuota", &DRTTestRunner::setDatabaseQuota); bindMethod("setDeferMainResourceDataLoad", &DRTTestRunner::setDeferMainResourceDataLoad); -bindMethod("setAudioData", &DRTTestRunner::setAudioData); bindMethod("setGeolocationPermission", &DRTTestRunner::setGeolocationPermission); bindMethod("setMockDeviceOrientation", &DRTTestRunner::setMockDeviceOrientation); bindMethod("setMockGeolocationPositionUnavailableError", &DRTTestRunner::setMockGeolocationPositionUnavailableError); @@ -496,7 +495,6 @@ TestRunner::reset(); if (m_shell) m_shell->webViewHost()->setDeviceScaleFactor(1); -m_dumpAsAudio = false; m_dumpCreateView = false; m_dumpFrameLoadCallbacks = false; m_dumpProgressFinishedCallback = false; @@ -1039,23 +1037,6 @@ postTask(new InvokeCallbackTask(this, callbackArguments.release(), 1)); } -void DRTTestRunner::setAudioData(const CppArgumentList& arguments, CppVariant* result) -{ -result->setNull(); - -if (arguments.size() < 1 || !arguments[0].isObject()) -return; - -// Check that passed-in object is, in fact, an ArrayBufferView. -NPObject* npobject = NPVARIANT_TO_OBJECT(arguments[0]); -if (!npobject) -return; -if (!WebBindings::getArrayBufferView(npobject, &m_audioData)) -return; - -setShouldDumpAsAudio(true); -} - #if ENABLE(POINTER_LOCK) void DRTTestRunner::didAcquirePointerLock(const CppArgumentList&, CppVariant* result) { Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (138992 => 138993) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-07 22:24
[webkit-changes] [139043] trunk/Source/WebCore
Title: [139043] trunk/Source/WebCore Revision 139043 Author joc...@chromium.org Date 2013-01-08 00:40:10 -0800 (Tue, 08 Jan 2013) Log Message REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function https://bugs.webkit.org/show_bug.cgi?id=106311 Unreviewed build fix. * html/shadow/DateTimeSymbolicFieldElement.cpp: (WebCore::DateTimeSymbolicFieldElement::stepDown): (WebCore::DateTimeSymbolicFieldElement::stepUp): * html/shadow/DateTimeSymbolicFieldElement.h: (WebCore::DateTimeSymbolicFieldElement::indexIsInRange): renamed method to avoid hiding Element::isInRange Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (139042 => 139043) --- trunk/Source/WebCore/ChangeLog 2013-01-08 08:23:01 UTC (rev 139042) +++ trunk/Source/WebCore/ChangeLog 2013-01-08 08:40:10 UTC (rev 139043) @@ -1,3 +1,16 @@ +2013-01-08 Jochen Eisinger + +REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function +https://bugs.webkit.org/show_bug.cgi?id=106311 + +Unreviewed build fix. + +* html/shadow/DateTimeSymbolicFieldElement.cpp: +(WebCore::DateTimeSymbolicFieldElement::stepDown): +(WebCore::DateTimeSymbolicFieldElement::stepUp): +* html/shadow/DateTimeSymbolicFieldElement.h: +(WebCore::DateTimeSymbolicFieldElement::indexIsInRange): renamed method to avoid hiding Element::isInRange + 2013-01-08 Adam Barth HTMLTreeBuilder shouldn't keep a Document pointer Modified: trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp (139042 => 139043) --- trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp 2013-01-08 08:23:01 UTC (rev 139042) +++ trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp 2013-01-08 08:40:10 UTC (rev 139043) @@ -119,7 +119,7 @@ void DateTimeSymbolicFieldElement::stepDown() { if (hasValue()) { -if (!isInRange(--m_selectedIndex)) +if (!indexIsInRange(--m_selectedIndex)) m_selectedIndex = m_maximumIndex; } else m_selectedIndex = m_maximumIndex; @@ -129,7 +129,7 @@ void DateTimeSymbolicFieldElement::stepUp() { if (hasValue()) { -if (!isInRange(++m_selectedIndex)) +if (!indexIsInRange(++m_selectedIndex)) m_selectedIndex = m_minimumIndex; } else m_selectedIndex = m_minimumIndex; Modified: trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h (139042 => 139043) --- trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h 2013-01-08 08:23:01 UTC (rev 139042) +++ trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h 2013-01-08 08:40:10 UTC (rev 139043) @@ -49,7 +49,7 @@ static const int invalidIndex = -1; String visibleEmptyValue() const; -bool isInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; } +bool indexIsInRange(int index) const { return index >= m_minimumIndex && index <= m_maximumIndex; } // DateTimeFieldElement functions. virtual void handleKeyboardEvent(KeyboardEvent*) OVERRIDE FINAL; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [139234] trunk/Tools
Title: [139234] trunk/Tools Revision 139234 Author joc...@chromium.org Date 2013-01-09 13:44:18 -0800 (Wed, 09 Jan 2013) Log Message [chromium] move resource load callback dumping to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106449 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebKit): (WebTestRunner::WebTestDelegate::makeURLErrorDescription): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebKit): (WebTestProxyBase): (WebTestRunner::WebTestProxy::assignIdentifierToRequest): (WebTestRunner::WebTestProxy::willRequestResource): (WebTestRunner::WebTestProxy::willSendRequest): (WebTestRunner::WebTestProxy::didReceiveResponse): (WebTestRunner::WebTestProxy::didFinishResourceLoad): (WebTestRunner::WebTestProxy::didFailResourceLoad): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks): (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks): (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks): (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks): (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes): (WebTestRunner): (WebTestRunner::TestRunner::dumpResourceLoadCallbacks): (WebTestRunner::TestRunner::dumpResourceRequestCallbacks): (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::reset): (WebTestRunner): (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest): (WebTestRunner::WebTestProxyBase::willRequestResource): (WebTestRunner::WebTestProxyBase::willSendRequest): (WebTestRunner::WebTestProxyBase::didReceiveResponse): (WebTestRunner::WebTestProxyBase::didFinishResourceLoad): (WebTestRunner::WebTestProxyBase::didFailResourceLoad): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest): (WebViewHost::makeURLErrorDescription): (WebViewHost::reset): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139233 => 139234) --- trunk/Tools/ChangeLog 2013-01-09 21:44:08 UTC (rev 139233) +++ trunk/Tools/ChangeLog 2013-01-09 21:44:18 UTC (rev 139234) @@ -1,3 +1,59 @@ +2013-01-09 Jochen Eisinger + +[chromium] move resource load callback dumping to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106449 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebKit): +(WebTestRunner::WebTestDelegate::makeURLErrorDescription): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebKit): +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::assignIdentifierToRequest): +(WebTestRunner::WebTestProxy::willRequestResource): +(WebTestRunner::WebTestProxy::willSendRequest): +(WebTestRunner::WebTestProxy::didReceiveResponse): +(WebTestRunner::WebTestProxy::didFinishResourceLoad): +(WebTestRunner::WebTestProxy::didFailResourceLoad): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks): +(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks): +(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks): +(WebTestRunner::TestRun
[webkit-changes] [139419] trunk
Title: [139419] trunk Revision 139419 Author joc...@chromium.org Date 2013-01-11 02:07:49 -0800 (Fri, 11 Jan 2013) Log Message Connect UserGestureIndicator for mousedown and mouseup events https://bugs.webkit.org/show_bug.cgi?id=105138 Reviewed by Adam Barth. Source/WebCore: Ports that consume user gestures to prevent certain types of pop-ups need to be able to connect mousedown and mouseup events, otherwise, a single mouse click will allow for opening multiple pop-ups. Note that a mousedown is not always followed by a mouseup and vice versa, e.g. when the mousedown results in a context menu being shown, or something is dragged into the page. Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html * page/EventHandler.cpp: (WebCore::EventHandler::clear): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseReleaseEvent): * page/EventHandler.h: LayoutTests: * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added. * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h Added Paths trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html Diff Modified: trunk/LayoutTests/ChangeLog (139418 => 139419) --- trunk/LayoutTests/ChangeLog 2013-01-11 10:06:11 UTC (rev 139418) +++ trunk/LayoutTests/ChangeLog 2013-01-11 10:07:49 UTC (rev 139419) @@ -1,3 +1,13 @@ +2013-01-11 Jochen Eisinger + +Connect UserGestureIndicator for mousedown and mouseup events +https://bugs.webkit.org/show_bug.cgi?id=105138 + +Reviewed by Adam Barth. + +* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added. +* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added. + 2013-01-11 Eugene Klyuchnikov Web Inspector: [Resources] "Delete" cookie deletes all cookies with matching name. Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt (0 => 139419) --- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt 2013-01-11 10:07:49 UTC (rev 139419) @@ -0,0 +1,4 @@ +Test that only a single popup is allowed in response to a single user action, even if the the user action triggers multiple events. The test passes if only one popup is created. + +Click Here +PASSED Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html (0 => 139419) --- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html 2013-01-11 10:07:49 UTC (rev 139419) @@ -0,0 +1,45 @@ + + + + +Test that only a single popup is allowed in response to a single +user action, even if the the user action triggers multiple events. +The test passes if only one popup is created. + +Click Here + + +function popup1() { +window.open("about:blank", "window1"); +} + +function popup2() { +window.open("about:blank", "window2"); +if (window.testRunner) { +if (testRunner.windowCount() == windowCount + 1) +document.getElementById("console").innerText = "PASSED"; +else +document.getElementById("console").innerText = "FAILED"; +testRunner.notifyDone(); +} +} + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.setCanOpenWindows(); +testRunner.setPopupBlockingEnabled(true); +testRunner.setCloseRemainingWindowsWhenComplete(true); +testRunner.waitUntilDone(); +windowCount = testRunner.windowCount(); + +var button = document.getElementById("button"); + +if (window.eventSender) { +eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2); +eventSender.mouseDown(); +
[webkit-changes] [139549] trunk/Tools
Title: [139549] trunk/Tools Revision 139549 Author joc...@chromium.org Date 2013-01-12 05:57:28 -0800 (Sat, 12 Jan 2013) Log Message [chromium] move inspector related methods to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106654 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::showDevTools): (WebTestRunner::WebTestDelegate::closeDevTools): (WebTestRunner::WebTestDelegate::evaluateInWebInspector): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::showWebInspector): (WebTestRunner): (WebTestRunner::TestRunner::closeWebInspector): (WebTestRunner::TestRunner::evaluateInWebInspector): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::showDevTools): (WebViewHost::closeDevTools): (WebViewHost::evaluateInWebInspector): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139548 => 139549) --- trunk/Tools/ChangeLog 2013-01-12 12:59:55 UTC (rev 139548) +++ trunk/Tools/ChangeLog 2013-01-12 13:57:28 UTC (rev 139549) @@ -1,3 +1,33 @@ +2013-01-12 Jochen Eisinger + +[chromium] move inspector related methods to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106654 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::showDevTools): +(WebTestRunner::WebTestDelegate::closeDevTools): +(WebTestRunner::WebTestDelegate::evaluateInWebInspector): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::showWebInspector): +(WebTestRunner): +(WebTestRunner::TestRunner::closeWebInspector): +(WebTestRunner::TestRunner::evaluateInWebInspector): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::showDevTools): +(WebViewHost::closeDevTools): +(WebViewHost::evaluateInWebInspector): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-11 Julie Parent Builder should not be a valid parameter for stats dashboard Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139548 => 139549) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-12 12:59:55 UTC (rev 139548) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-12 13:57:28 UTC (rev 139549) @@ -107,7 +107,6 @@ bindMethod("wasMockSpeechRecognitionAborted", &DRTTestRunner::wasMockSpeechRecognitionAborted); #endif bindMethod("clearAllDatabases", &DRTTestRunner::clearAllDatabases); -bindMethod("closeWebInspector", &DRTTestRunner::closeWebInspector); #if ENABLE(POINTER_LOCK) bindMethod("didAcquirePointerLock", &DRTTestRunner::didAcquirePointerLock); bindMethod("didLosePointerLock", &DRTTestRunner::didLosePointerLock); @@ -119,7 +118,6 @@ bindMethod("dumpProgressFinishedCallback", &DRTTestRunner::dumpProgressFinishedCallback); bindMethod("dumpSelectionRect", &DRTTestRunner::dumpSelectionRect); bindMethod("dumpStatusCallbacks", &DRTTestRunner::dumpWindowStatusChanges); -bindMethod("evaluateInWebInspector", &DRTTestRunner::evaluateInWebInspector); #if ENABLE(NOTIFICATIONS) bindMethod("grantWebNotificationPermission", &DRTTestRunner::grantWebNotificationPermission); #endif @@ -154,7 +152,6 @@ bindMethod("setWillSendRequestReturnsNull", &DRTTestRunner::setWillSendRequestReturnsNull); bindMethod("setWillSendRequestReturnsNullOnRedirect", &DRTTestRunner::setWillSendRequestReturnsNullOnRedirect); bindMethod("setWindowIsKey", &DRTTestRunner::setWindowIsKey); -bindMethod("showWebInspector", &DRTTestRunner::showWebInspect
[webkit-changes] [139627] trunk/Tools
Title: [139627] trunk/Tools Revision 139627 Author joc...@chromium.org Date 2013-01-14 11:04:39 -0800 (Mon, 14 Jan 2013) Log Message [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106785 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestProxyBase): (WebTestRunner::WebTestProxy::setStatusText): (WebTestRunner::WebTestProxy::didStopLoading): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks): (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::shouldDumpStatusCallbacks): (WebTestRunner): (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback): (WebTestRunner::TestRunner::dumpWindowStatusChanges): (WebTestRunner::TestRunner::dumpProgressFinishedCallback): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::setStatusText): (WebTestRunner): (WebTestRunner::WebTestProxyBase::didStopLoading): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didStopLoading): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139626 => 139627) --- trunk/Tools/ChangeLog 2013-01-14 18:57:23 UTC (rev 139626) +++ trunk/Tools/ChangeLog 2013-01-14 19:04:39 UTC (rev 139627) @@ -1,3 +1,41 @@ +2013-01-14 Jochen Eisinger + +[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106785 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::setStatusText): +(WebTestRunner::WebTestProxy::didStopLoading): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks): +(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::shouldDumpStatusCallbacks): +(WebTestRunner): +(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback): +(WebTestRunner::TestRunner::dumpWindowStatusChanges): +(WebTestRunner::TestRunner::dumpProgressFinishedCallback): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::setStatusText): +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::didStopLoading): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::didStopLoading): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-14 Andrey Lushnikov Web Inspector: devtools front-end doesn't have focus in TestShell Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139626 => 139627) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-14 18:57:23 UTC (rev 139626) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-14 19:04:39 UTC (rev 139627) @@ -115,9 +115,7 @@ bindMethod("display", &DRTTestRunner::display); bindMethod("displayInvalidatedRegion", &DRTTestRunner::displayInvalidatedRegion); bindMethod("dumpBackForwardList", &DRTTestRunner::dumpBackForwardList); -bindMethod("dumpProgressFinishedCallback", &DRTTestRunner::dumpProgressFinishedCallback); bindMethod("dumpSelectionRect", &DRTTest
[webkit-changes] [139722] trunk/Tools
Title: [139722] trunk/Tools Revision 139722 Author joc...@chromium.org Date 2013-01-15 00:19:57 -0800 (Tue, 15 Jan 2013) Log Message [chromium] move remaining methods that just set a boolean flag to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106823 Reviewed by Darin Fisher. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::shouldDumpBackForwardList): (WebTestRunner::WebTestRunner::deferMainResourceDataLoad): (WebTestRunner::WebTestRunner::shouldDumpSelectionRect): (WebTestRunner::WebTestRunner::testRepaint): (WebTestRunner::WebTestRunner::sweepHorizontally): (WebTestRunner::WebTestRunner::isPrinting): (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::shouldDumpBackForwardList): (WebTestRunner): (WebTestRunner::TestRunner::deferMainResourceDataLoad): (WebTestRunner::TestRunner::shouldDumpSelectionRect): (WebTestRunner::TestRunner::testRepaint): (WebTestRunner::TestRunner::sweepHorizontally): (WebTestRunner::TestRunner::isPrinting): (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload): (WebTestRunner::TestRunner::dumpBackForwardList): (WebTestRunner::TestRunner::setDeferMainResourceDataLoad): (WebTestRunner::TestRunner::dumpSelectionRect): (WebTestRunner::TestRunner::repaintSweepHorizontally): (WebTestRunner::TestRunner::setPrinting): (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h Diff Modified: trunk/Tools/ChangeLog (139721 => 139722) --- trunk/Tools/ChangeLog 2013-01-15 07:55:47 UTC (rev 139721) +++ trunk/Tools/ChangeLog 2013-01-15 08:19:57 UTC (rev 139722) @@ -1,3 +1,43 @@ +2013-01-15 Jochen Eisinger + +[chromium] move remaining methods that just set a boolean flag to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106823 + +Reviewed by Darin Fisher. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::shouldDumpBackForwardList): +(WebTestRunner::WebTestRunner::deferMainResourceDataLoad): +(WebTestRunner::WebTestRunner::shouldDumpSelectionRect): +(WebTestRunner::WebTestRunner::testRepaint): +(WebTestRunner::WebTestRunner::sweepHorizontally): +(WebTestRunner::WebTestRunner::isPrinting): +(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::shouldDumpBackForwardList): +(WebTestRunner): +(WebTestRunner::TestRunner::deferMainResourceDataLoad): +(WebTestRunner::TestRunner::shouldDumpSelectionRect): +(WebTestRunner::TestRunner::testRepaint): +(WebTestRunner::TestRunner::sweepHorizontally): +(WebTestRunner::TestRunner::isPrinting): +(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload): +(WebTestRunner::TestRunner::dumpBackForwardList): +(WebTestRunner::TestRunner::setDeferMainResourceDataLoad): +(WebTestRunner::TestRunner::dumpSelectionRect): +(WebTestRunner::TestRunner::repaintSweepHorizontally): +(WebTestRunner::TestRunner::setPrinting): +(WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): + 2013-01-14 Dirk Pranke nrwt: stub out show_results_html for mock ports Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139721 => 139722) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 07:55:47 UTC (rev 139721) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 08:19:57 UTC (rev 139722) @@ -87,10 +87,8 @@ DRTTestRunner::DRTTestRunner(TestShell* shell) : m_shell(shell) , m_closeRemainingWindows(false) -, m_deferMainResourceDataLoad(false) , m_showDebugLayerTree
[webkit-changes] [139776] trunk/Tools
Title: [139776] trunk/Tools Revision 139776 Author joc...@chromium.org Date 2013-01-15 12:49:36 -0800 (Tue, 15 Jan 2013) Log Message [chromium] move WebDatabase related methods to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=106905 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::clearAllDatabases): (WebTestRunner::WebTestDelegate::setDatabaseQuota): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::clearAllDatabases): (WebTestRunner): (WebTestRunner::TestRunner::setDatabaseQuota): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::clearAllDatabases): (WebViewHost::setDatabaseQuota): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139775 => 139776) --- trunk/Tools/ChangeLog 2013-01-15 20:47:18 UTC (rev 139775) +++ trunk/Tools/ChangeLog 2013-01-15 20:49:36 UTC (rev 139776) @@ -1,3 +1,32 @@ +2013-01-15 Jochen Eisinger + +[chromium] move WebDatabase related methods to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=106905 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::clearAllDatabases): +(WebTestRunner::WebTestDelegate::setDatabaseQuota): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::clearAllDatabases): +(WebTestRunner): +(WebTestRunner::TestRunner::setDatabaseQuota): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::clearAllDatabases): +(WebViewHost::setDatabaseQuota): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-15 Tim 'mithro' Ansell Renaming CleanWorkingDirectory step to DiscardLocalChanges to make Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139775 => 139776) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 20:47:18 UTC (rev 139775) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 20:49:36 UTC (rev 139776) @@ -104,7 +104,6 @@ bindMethod("setMockSpeechRecognitionError", &DRTTestRunner::setMockSpeechRecognitionError); bindMethod("wasMockSpeechRecognitionAborted", &DRTTestRunner::wasMockSpeechRecognitionAborted); #endif -bindMethod("clearAllDatabases", &DRTTestRunner::clearAllDatabases); #if ENABLE(POINTER_LOCK) bindMethod("didAcquirePointerLock", &DRTTestRunner::didAcquirePointerLock); bindMethod("didLosePointerLock", &DRTTestRunner::didLosePointerLock); @@ -128,7 +127,6 @@ bindMethod("setAlwaysAcceptCookies", &DRTTestRunner::setAlwaysAcceptCookies); bindMethod("setCloseRemainingWindowsWhenComplete", &DRTTestRunner::setCloseRemainingWindowsWhenComplete); bindMethod("setCustomPolicyDelegate", &DRTTestRunner::setCustomPolicyDelegate); -bindMethod("setDatabaseQuota", &DRTTestRunner::setDatabaseQuota); bindMethod("setGeolocationPermission", &DRTTestRunner::setGeolocationPermission); bindMethod("setMockDeviceOrientation", &DRTTestRunner::setMockDeviceOrientation); bindMethod("setMockGeolocationPositionUnavailableError", &DRTTestRunner::setMockGeolocationPositionUnavailableError); @@ -401,9 +399,6 @@ webkit_support::SetAcceptAllCookies(false); -// Reset the default quota for each origin to 5MB -webkit_support::SetDatabaseQuota(5 * 1024 * 1024); - setlocale(LC_ALL, ""); if (m_closeRemainingWindows) @@ -587,19 +582,6 @@ result->setNull(); } -void DRTTest
[webkit-changes] [139779] trunk/Tools
Title: [139779] trunk/Tools Revision 139779 Author joc...@chromium.org Date 2013-01-15 13:34:59 -0800 (Tue, 15 Jan 2013) Log Message [chromium] add title text direction attribute to TestRunner https://bugs.webkit.org/show_bug.cgi?id=106907 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::setTitleTextDirection): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::setTitleTextDirection): (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::didReceiveTitle): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveTitle): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp Diff Modified: trunk/Tools/ChangeLog (139778 => 139779) --- trunk/Tools/ChangeLog 2013-01-15 21:04:09 UTC (rev 139778) +++ trunk/Tools/ChangeLog 2013-01-15 21:34:59 UTC (rev 139779) @@ -1,3 +1,28 @@ +2013-01-15 Jochen Eisinger + +[chromium] add title text direction attribute to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=106907 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::setTitleTextDirection): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::setTitleTextDirection): +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::didReceiveTitle): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::didReceiveTitle): + 2013-01-15 Dirk Pranke nrwt: change the default # of locked shards on chromium_win to 1 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139778 => 139779) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 21:04:09 UTC (rev 139778) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 21:34:59 UTC (rev 139779) @@ -152,7 +152,6 @@ // Shared properties. // webHistoryItemCount is used by tests in LayoutTests\http\tests\history bindProperty("webHistoryItemCount", &m_webHistoryItemCount); -bindProperty("titleTextDirection", &m_titleTextDirection); bindProperty("interceptPostMessage", &m_interceptPostMessage); } @@ -394,7 +393,6 @@ m_shell->webViewHost()->setDeviceScaleFactor(1); m_waitUntilDone = false; m_webHistoryItemCount.set(0); -m_titleTextDirection.set("ltr"); m_interceptPostMessage.set(false); webkit_support::SetAcceptAllCookies(false); Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (139778 => 139779) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-15 21:04:09 UTC (rev 139778) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-15 21:34:59 UTC (rev 139779) @@ -44,7 +44,6 @@ #include "TestRunner/src/TestRunner.h" #include "WebTask.h" -#include "WebTextDirection.h" #include "platform/WebArrayBufferView.h" #include "platform/WebString.h" #include "platform/WebURL.h" @@ -173,10 +172,6 @@ void setWorkQueueFrozen(bool frozen) { m_workQueue.setFrozen(frozen); } void setShowDebugLayerTree(bool value) { m_showDebugLayerTree = value; } -void setTitleTextDirection(WebKit::WebTextDirection dir) -{ -m_titleTextDirection.set(dir == WebKit::WebTextDirectionLeftToRight ? "ltr" : "rtl"); -} bool shouldInterceptPostMessage() { @@ -268,9 +263,6 @@ // Bound variable counting the number of top URLs visited. CppVariant m_webHistoryItemCount; -// Bound variable tracking the directionality of the tag. -CppVariant m_titleTextDirection; - // Bound variable t
[webkit-changes] [139792] trunk/Tools
Title: [139792] trunk/Tools Revision 139792 Author joc...@chromium.org Date 2013-01-15 14:21:43 -0800 (Tue, 15 Jan 2013) Log Message [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate https://bugs.webkit.org/show_bug.cgi?id=106904 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::notifyDone): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::setDeviceScaleFactor): (WebTestRunner::WebTestDelegate::setFocus): (WebTestRunner::WebTestDelegate::setAcceptAllCookies): (WebTestRunner::WebTestDelegate::pathToLocalResource): (WebTestRunner::WebTestDelegate::setLocale): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::setAlwaysAcceptCookies): (WebTestRunner): (WebTestRunner::TestRunner::setWindowIsKey): (WebTestRunner::TestRunner::pathToLocalResource): (WebTestRunner::TestRunner::setBackingScaleFactor): (WebTestRunner::TestRunner::setPOSIXLocale): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (WebTestRunner::TestRunner::taskList): (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::setDeviceScaleFactor): (WebViewHost::setFocus): (WebViewHost::setAcceptAllCookies): (WebViewHost::pathToLocalResource): (WebViewHost::setLocale): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139791 => 139792) --- trunk/Tools/ChangeLog 2013-01-15 22:20:51 UTC (rev 139791) +++ trunk/Tools/ChangeLog 2013-01-15 22:21:43 UTC (rev 139792) @@ -1,3 +1,43 @@ +2013-01-15 Jochen Eisinger + +[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate +https://bugs.webkit.org/show_bug.cgi?id=106904 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::notifyDone): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::setDeviceScaleFactor): +(WebTestRunner::WebTestDelegate::setFocus): +(WebTestRunner::WebTestDelegate::setAcceptAllCookies): +(WebTestRunner::WebTestDelegate::pathToLocalResource): +(WebTestRunner::WebTestDelegate::setLocale): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::setAlwaysAcceptCookies): +(WebTestRunner): +(WebTestRunner::TestRunner::setWindowIsKey): +(WebTestRunner::TestRunner::pathToLocalResource): +(WebTestRunner::TestRunner::setBackingScaleFactor): +(WebTestRunner::TestRunner::setPOSIXLocale): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(WebTestRunner::TestRunner::taskList): +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::setDeviceScaleFactor): +(WebViewHost::setFocus): +(WebViewHost::setAcceptAllCookies): +(WebViewHost::pathToLocalResource): +(WebViewHost::setLocale): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-15 Zan Dobersek Tests with WontFix expectation are (indirectly) skipped Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139791 => 139792) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 22:20:51 UTC (rev 139791) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-15 22:21:43 UTC (rev 139792) @@ -68,7 +68,6 @@ #include "webkit/support/webkit_support.h" #include #include -#include #include #include #include @@ -116,7 +115,6 @@ #endif bindMethod("notifyDone", &DRTTestRunner::notifyDone); bindMethod("numberOfPendingGeolocationPermissionRequests", &DRTTestRunner:: numberOfPendingGeolocationPermissionRequests); -bindMethod("pathToLocalResource", &DRTTestRunner::pathToLocalResource); bindMethod("queueBackNavigation", &DRTTestRunner::queueBackNavigation); bindMethod("queueForwardNavigation&q
[webkit-changes] [139843] branches/chromium/1364
Title: [139843] branches/chromium/1364 Revision 139843 Author joc...@chromium.org Date 2013-01-16 00:23:43 -0800 (Wed, 16 Jan 2013) Log Message Merge 139419 > Connect UserGestureIndicator for mousedown and mouseup events > https://bugs.webkit.org/show_bug.cgi?id=105138 > > Reviewed by Adam Barth. > > Source/WebCore: > > Ports that consume user gestures to prevent certain types of pop-ups > need to be able to connect mousedown and mouseup events, otherwise, a > single mouse click will allow for opening multiple pop-ups. > > Note that a mousedown is not always followed by a mouseup and vice > versa, e.g. when the mousedown results in a context menu being shown, or > something is dragged into the page. > > Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html > > * page/EventHandler.cpp: > (WebCore::EventHandler::clear): > (WebCore::EventHandler::handleMousePressEvent): > (WebCore::EventHandler::handleMouseReleaseEvent): > * page/EventHandler.h: > > LayoutTests: > > * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added. > * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added. > TBR=joc...@chromium.org Review URL: https://codereview.chromium.org/11975006 Modified Paths branches/chromium/1364/Source/WebCore/page/EventHandler.cpp branches/chromium/1364/Source/WebCore/page/EventHandler.h Added Paths branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html Diff Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt (from rev 139419, trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt) (0 => 139843) --- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt (rev 0) +++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt 2013-01-16 08:23:43 UTC (rev 139843) @@ -0,0 +1,4 @@ +Test that only a single popup is allowed in response to a single user action, even if the the user action triggers multiple events. The test passes if only one popup is created. + +Click Here +PASSED Copied: branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html (from rev 139419, trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html) (0 => 139843) --- branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html (rev 0) +++ branches/chromium/1364/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html 2013-01-16 08:23:43 UTC (rev 139843) @@ -0,0 +1,45 @@ + + + + +Test that only a single popup is allowed in response to a single +user action, even if the the user action triggers multiple events. +The test passes if only one popup is created. + +Click Here + + +function popup1() { +window.open("about:blank", "window1"); +} + +function popup2() { +window.open("about:blank", "window2"); +if (window.testRunner) { +if (testRunner.windowCount() == windowCount + 1) +document.getElementById("console").innerText = "PASSED"; +else +document.getElementById("console").innerText = "FAILED"; +testRunner.notifyDone(); +} +} + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.setCanOpenWindows(); +testRunner.setPopupBlockingEnabled(true); +testRunner.setCloseRemainingWindowsWhenComplete(true); +testRunner.waitUntilDone(); +windowCount = testRunner.windowCount(); + +var button = document.getElementById("button"); + +if (window.eventSender) { +eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2); +eventSender.mouseDown(); +eventSender.mouseUp(); +} +} + + + Modified: branches/chromium/1364/Source/WebCore/page/EventHandler.cpp (139842 => 139843) --- branches/chromium/1364/Source/WebCore/page/EventHandler.cpp 2013-01-16 08:05:55 UTC (rev 139842) +++ branches/chromium/1364/Source/WebCore/page/EventHandler
[webkit-changes] [139850] trunk/Tools
Title: [139850] trunk/Tools Revision 139850 Author joc...@chromium.org Date 2013-01-16 01:42:33 -0800 (Wed, 16 Jan 2013) Log Message [chromium] add title text direction attribute to TestRunner https://bugs.webkit.org/show_bug.cgi?id=106907 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::setTitleTextDirection): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::setTitleTextDirection): (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::didReceiveTitle): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveTitle): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp Diff Modified: trunk/Tools/ChangeLog (139849 => 139850) --- trunk/Tools/ChangeLog 2013-01-16 09:34:29 UTC (rev 139849) +++ trunk/Tools/ChangeLog 2013-01-16 09:42:33 UTC (rev 139850) @@ -1,3 +1,28 @@ +2013-01-16 Jochen Eisinger + +[chromium] add title text direction attribute to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=106907 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::setTitleTextDirection): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::setTitleTextDirection): +(WebTestRunner): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::didReceiveTitle): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::didReceiveTitle): + 2013-01-16 Jussi Kukkonen NRWT still confused about test count with --repeat-each and --iterations Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139849 => 139850) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-16 09:34:29 UTC (rev 139849) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-16 09:42:33 UTC (rev 139850) @@ -152,7 +152,6 @@ // Shared properties. // webHistoryItemCount is used by tests in LayoutTests\http\tests\history bindProperty("webHistoryItemCount", &m_webHistoryItemCount); -bindProperty("titleTextDirection", &m_titleTextDirection); bindProperty("interceptPostMessage", &m_interceptPostMessage); } @@ -394,7 +393,6 @@ m_shell->webViewHost()->setDeviceScaleFactor(1); m_waitUntilDone = false; m_webHistoryItemCount.set(0); -m_titleTextDirection.set("ltr"); m_interceptPostMessage.set(false); webkit_support::SetAcceptAllCookies(false); Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (139849 => 139850) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-16 09:34:29 UTC (rev 139849) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-16 09:42:33 UTC (rev 139850) @@ -44,7 +44,6 @@ #include "TestRunner/src/TestRunner.h" #include "WebTask.h" -#include "WebTextDirection.h" #include "platform/WebArrayBufferView.h" #include "platform/WebString.h" #include "platform/WebURL.h" @@ -173,10 +172,6 @@ void setWorkQueueFrozen(bool frozen) { m_workQueue.setFrozen(frozen); } void setShowDebugLayerTree(bool value) { m_showDebugLayerTree = value; } -void setTitleTextDirection(WebKit::WebTextDirection dir) -{ -m_titleTextDirection.set(dir == WebKit::WebTextDirectionLeftToRight ? "ltr" : "rtl"); -} bool shouldInterceptPostMessage() { @@ -268,9 +263,6 @@ // Bound variable counting the number of top URLs visited. CppVariant m_webHistoryItemCount; -// Bound variable tracking the directionality of the tag. -CppVariant m_titleTextDirection; -
[webkit-changes] [139872] trunk/Tools
Title: [139872] trunk/Tools Revision 139872 Author joc...@chromium.org Date 2013-01-16 04:41:47 -0800 (Wed, 16 Jan 2013) Log Message [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate https://bugs.webkit.org/show_bug.cgi?id=106904 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::notifyDone): (DRTTestRunner::reset): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::setDeviceScaleFactor): (WebTestRunner::WebTestDelegate::setFocus): (WebTestRunner::WebTestDelegate::setAcceptAllCookies): (WebTestRunner::WebTestDelegate::pathToLocalResource): (WebTestRunner::WebTestDelegate::setLocale): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::setAlwaysAcceptCookies): (WebTestRunner): (WebTestRunner::TestRunner::setWindowIsKey): (WebTestRunner::TestRunner::pathToLocalResource): (WebTestRunner::TestRunner::setBackingScaleFactor): (WebTestRunner::TestRunner::setPOSIXLocale): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (WebTestRunner::TestRunner::taskList): (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::setDeviceScaleFactor): (WebViewHost::setFocus): (WebViewHost::setAcceptAllCookies): (WebViewHost::pathToLocalResource): (WebViewHost::setLocale): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (139871 => 139872) --- trunk/Tools/ChangeLog 2013-01-16 12:16:41 UTC (rev 139871) +++ trunk/Tools/ChangeLog 2013-01-16 12:41:47 UTC (rev 139872) @@ -1,3 +1,43 @@ +2013-01-16 Jochen Eisinger + +[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate +https://bugs.webkit.org/show_bug.cgi?id=106904 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::notifyDone): +(DRTTestRunner::reset): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::setDeviceScaleFactor): +(WebTestRunner::WebTestDelegate::setFocus): +(WebTestRunner::WebTestDelegate::setAcceptAllCookies): +(WebTestRunner::WebTestDelegate::pathToLocalResource): +(WebTestRunner::WebTestDelegate::setLocale): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::setAlwaysAcceptCookies): +(WebTestRunner): +(WebTestRunner::TestRunner::setWindowIsKey): +(WebTestRunner::TestRunner::pathToLocalResource): +(WebTestRunner::TestRunner::setBackingScaleFactor): +(WebTestRunner::TestRunner::setPOSIXLocale): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(WebTestRunner::TestRunner::taskList): +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::setDeviceScaleFactor): +(WebViewHost::setFocus): +(WebViewHost::setAcceptAllCookies): +(WebViewHost::pathToLocalResource): +(WebViewHost::setLocale): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-16 Sergio Villar Senin [GTK] build-webkit fails if the jhbuild wrapper is not used Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139871 => 139872) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-16 12:16:41 UTC (rev 139871) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-16 12:41:47 UTC (rev 139872) @@ -68,7 +68,6 @@ #include "webkit/support/webkit_support.h" #include #include -#include #include #include #include @@ -116,7 +115,6 @@ #endif bindMethod("notifyDone", &DRTTestRunner::notifyDone); bindMethod("numberOfPendingGeolocationPermissionRequests", &DRTTestRunner:: numberOfPendingGeolocationPermissionRequests); -bindMethod("pathToLocalResource", &DRTTestRunner::pathToLocalResource); bindMethod("queueBackNavigation", &DRTTestRunner::queueBackNavigation); bindMethod("queu
[webkit-changes] [140269] trunk/Tools
Title: [140269] trunk/Tools Revision 140269 Author joc...@chromium.org Date 2013-01-20 01:40:09 -0800 (Sun, 20 Jan 2013) Log Message [chromium] move geolocation related methods to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107267 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests): (WebTestRunner::WebTestDelegate::setGeolocationPermission): (WebTestRunner::WebTestDelegate::setMockGeolocationPosition): (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests): (WebTestRunner): (WebTestRunner::TestRunner::setGeolocationPermission): (WebTestRunner::TestRunner::setMockGeolocationPosition): (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::numberOfPendingGeolocationPermissionRequests): (WebViewHost::setGeolocationPermission): (WebViewHost::setMockGeolocationPosition): (WebViewHost::setMockGeolocationPositionUnavailableError): * DumpRenderTree/chromium/WebViewHost.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140268 => 140269) --- trunk/Tools/ChangeLog 2013-01-20 07:14:27 UTC (rev 140268) +++ trunk/Tools/ChangeLog 2013-01-20 09:40:09 UTC (rev 140269) @@ -1,3 +1,35 @@ +2013-01-20 Jochen Eisinger + +[chromium] move geolocation related methods to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=107267 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests): +(WebTestRunner::WebTestDelegate::setGeolocationPermission): +(WebTestRunner::WebTestDelegate::setMockGeolocationPosition): +(WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests): +(WebTestRunner): +(WebTestRunner::TestRunner::setGeolocationPermission): +(WebTestRunner::TestRunner::setMockGeolocationPosition): +(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::numberOfPendingGeolocationPermissionRequests): +(WebViewHost::setGeolocationPermission): +(WebViewHost::setMockGeolocationPosition): +(WebViewHost::setMockGeolocationPositionUnavailableError): +* DumpRenderTree/chromium/WebViewHost.h: + 2013-01-19 Zan Dobersek Unreviewed build fix for Qt WK2 after r140258. Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140268 => 140269) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 07:14:27 UTC (rev 140268) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 09:40:09 UTC (rev 140269) @@ -45,7 +45,6 @@ #include "WebElement.h" #include "WebFindOptions.h" #include "WebFrame.h" -#include "WebGeolocationClientMock.h" #include "WebIDBFactory.h" #include "WebInputElement.h" #include "WebKit.h" @@ -107,7 +106,6 @@ bindMethod("grantWebNotificationPermission", &DRTTestRunner::grantWebNotificationPermission); #endif bindMethod("notifyDone", &DRTTestRunner::notifyDone); -bindMethod("numberOfPendingGeolocationPermissionRequests", &DRTTestRunner:: numberOfPendingGeolocationPermissionRequests); bindMethod("queueBackNavigation", &DRTTestRunner::queueBackNavigation); bindMethod("queueForwardNavigation", &DRTTestRunner::queueForwardNavigation); bindMethod("que
[webkit-changes] [140271] trunk/Tools
Title: [140271] trunk/Tools Revision 140271 Author joc...@chromium.org Date 2013-01-20 02:50:07 -0800 (Sun, 20 Jan 2013) Log Message [chromium] move notification related methods to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107269 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): (WebTestRunner::WebTestDelegate::grantWebNotificationPermission): (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner): (WebTestRunner::TestRunner::grantWebNotificationPermission): (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::grantWebNotificationPermission): (WebViewHost::simulateLegacyWebNotificationClick): * DumpRenderTree/chromium/WebViewHost.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140270 => 140271) --- trunk/Tools/ChangeLog 2013-01-20 10:35:00 UTC (rev 140270) +++ trunk/Tools/ChangeLog 2013-01-20 10:50:07 UTC (rev 140271) @@ -1,5 +1,32 @@ 2013-01-20 Jochen Eisinger +[chromium] move notification related methods to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=107269 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +(WebTestRunner::WebTestDelegate::grantWebNotificationPermission): +(WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner): +(WebTestRunner::TestRunner::grantWebNotificationPermission): +(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::grantWebNotificationPermission): +(WebViewHost::simulateLegacyWebNotificationClick): +* DumpRenderTree/chromium/WebViewHost.h: + +2013-01-20 Jochen Eisinger + [chromium] move geolocation related methods to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107267 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140270 => 140271) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 10:35:00 UTC (rev 140270) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 10:50:07 UTC (rev 140271) @@ -48,7 +48,6 @@ #include "WebIDBFactory.h" #include "WebInputElement.h" #include "WebKit.h" -#include "WebNotificationPresenter.h" #include "WebPrintParams.h" #include "WebScriptSource.h" #include "WebSecurityPolicy.h" @@ -102,9 +101,6 @@ #endif bindMethod("display", &DRTTestRunner::display); bindMethod("displayInvalidatedRegion", &DRTTestRunner::displayInvalidatedRegion); -#if ENABLE(NOTIFICATIONS) -bindMethod("grantWebNotificationPermission", &DRTTestRunner::grantWebNotificationPermission); -#endif bindMethod("notifyDone", &DRTTestRunner::notifyDone); bindMethod("queueBackNavigation", &DRTTestRunner::queueBackNavigation); bindMethod("queueForwardNavigation", &DRTTestRunner::queueForwardNavigation); @@ -118,9 +114,6 @@ bindMethod("setWillSendRequestClearHeader", &DRTTestRunner::setWillSendRequestClearHeader); bindMethod("setWillSendRequestReturnsNull", &DRTTestRunner::setWillSendRequestReturnsNull); bindMethod("setWillSendRequestReturnsNullOnRedirect", &DRTTestRunner::setWillSendRequestReturnsNullOnRedirect); -#if ENABLE(NOTIFICATIONS) -bindMethod("simulateLegacyWebNotificationClick", &DRTTestRunner::simulateLegacyWebNotificationClick); -#endif bindMethod("waitForPolicyDelegate", &DRTTestRunner::waitForPolicyDelegate); bindMethod("waitUntilD
[webkit-changes] [140277] trunk/Tools
Title: [140277] trunk/Tools Revision 140277 Author joc...@chromium.org Date 2013-01-20 12:16:24 -0800 (Sun, 20 Jan 2013) Log Message [chromium] move speech related methods to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=107266 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::displayInvalidatedRegion): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestDelegate): (WebTestRunner::WebTestDelegate::addMockSpeechInputResult): (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect): (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult): (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError): (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner): (WebTestRunner::TestRunner::addMockSpeechInputResult): (WebTestRunner::TestRunner::setMockSpeechInputDumpRect): (WebTestRunner::TestRunner::addMockSpeechRecognitionResult): (WebTestRunner::TestRunner::setMockSpeechRecognitionError): (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::addMockSpeechInputResult): (WebViewHost::setMockSpeechInputDumpRect): (WebViewHost::addMockSpeechRecognitionResult): (WebViewHost::setMockSpeechRecognitionError): (WebViewHost::wasMockSpeechRecognitionAborted): * DumpRenderTree/chromium/WebViewHost.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140276 => 140277) --- trunk/Tools/ChangeLog 2013-01-20 20:06:05 UTC (rev 140276) +++ trunk/Tools/ChangeLog 2013-01-20 20:16:24 UTC (rev 140277) @@ -1,5 +1,42 @@ 2013-01-20 Jochen Eisinger +[chromium] move speech related methods to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=107266 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::displayInvalidatedRegion): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestDelegate): +(WebTestRunner::WebTestDelegate::addMockSpeechInputResult): +(WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect): +(WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult): +(WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError): +(WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner): +(WebTestRunner::TestRunner::addMockSpeechInputResult): +(WebTestRunner::TestRunner::setMockSpeechInputDumpRect): +(WebTestRunner::TestRunner::addMockSpeechRecognitionResult): +(WebTestRunner::TestRunner::setMockSpeechRecognitionError): +(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::addMockSpeechInputResult): +(WebViewHost::setMockSpeechInputDumpRect): +(WebViewHost::addMockSpeechRecognitionResult): +(WebViewHost::setMockSpeechRecognitionError): +(WebViewHost::wasMockSpeechRecognitionAborted): +* DumpRenderTree/chromium/WebViewHost.h: + +2013-01-20 Jochen Eisinger + [chromium] move notification related methods to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107269 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140276 => 140277) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 20:06:05 UTC (rev 140276) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 20:16:24 UTC (rev 140277) @@ -34,8 +34,6 @@ #include "DRTTestRunner.h" #include "DRTDevToolsAgent.h" -#include "MockWebSpeechInputController.h" -#include "MockWebSpeechRecognizer.h" #include "Task.h" #include "TestShell.h" #include "WebAnimationController.h" @@ -90,15 +88,6 @@ // they will use when called by _javascript_. The actual binding of those // names to
[webkit-changes] [140281] trunk/Tools
Title: [140281] trunk/Tools Revision 140281 Author joc...@chromium.org Date 2013-01-20 13:30:37 -0800 (Sun, 20 Jan 2013) Log Message [chromium] move frame generation related methods to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107268 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::setWillSendRequestReturnsNull): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: (WebTestRunner::WebTestDelegate::display): (WebTestRunner::WebTestDelegate::displayInvalidatedRegion): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::display): (WebTestRunner): (WebTestRunner::TestRunner::displayInvalidatedRegion): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::display): (WebViewHost::displayInvalidatedRegion): * DumpRenderTree/chromium/WebViewHost.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140280 => 140281) --- trunk/Tools/ChangeLog 2013-01-20 20:45:16 UTC (rev 140280) +++ trunk/Tools/ChangeLog 2013-01-20 21:30:37 UTC (rev 140281) @@ -1,5 +1,32 @@ 2013-01-20 Jochen Eisinger +[chromium] move frame generation related methods to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=107268 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::setWillSendRequestReturnsNull): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +(WebTestRunner::WebTestDelegate::display): +(WebTestRunner::WebTestDelegate::displayInvalidatedRegion): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::display): +(WebTestRunner): +(WebTestRunner::TestRunner::displayInvalidatedRegion): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::display): +(WebViewHost::displayInvalidatedRegion): +* DumpRenderTree/chromium/WebViewHost.h: + +2013-01-20 Jochen Eisinger + [chromium] move speech related methods to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=107266 Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140280 => 140281) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 20:45:16 UTC (rev 140280) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-20 21:30:37 UTC (rev 140281) @@ -88,8 +88,6 @@ // they will use when called by _javascript_. The actual binding of those // names to their methods will be done by calling bindToJavaScript() (defined // by CppBoundClass, the parent to DRTTestRunner). -bindMethod("display", &DRTTestRunner::display); -bindMethod("displayInvalidatedRegion", &DRTTestRunner::displayInvalidatedRegion); bindMethod("notifyDone", &DRTTestRunner::notifyDone); bindMethod("queueBackNavigation", &DRTTestRunner::queueBackNavigation); bindMethod("queueForwardNavigation", &DRTTestRunner::queueForwardNavigation); @@ -431,22 +429,3 @@ m_shell->webViewHost()->setRequestReturnNull(arguments[0].value.boolValue); result->setNull(); } - -void DRTTestRunner::display(const CppArgumentList& arguments, CppVariant* result) -{ -WebViewHost* host = m_shell->webViewHost(); -const WebKit::WebSize& size = m_shell->webView()->size(); -WebRect rect(0, 0, size.width, size.height); -host->proxy()->setPaintRect(rect); -host->paintInvalidatedRegion(); -host->displayRepaintMask(); -result->setNull(); -} - -void DRTTestRunner::displayInvalidatedRegion(const CppArgumentList& arguments, CppVariant* result) -{ -WebViewHost* host = m_shell->webViewHost(); -host->paintInvalidatedRegion(); -host->displayRepaintMask(); -result->setNull(); -} Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (140280 => 140281) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h 2013-01-20 20:45:16 UTC (rev 140280) +++ trunk/Tools/Dump
[webkit-changes] [140318] trunk/Tools
Title: [140318] trunk/Tools Revision 140318 Author joc...@chromium.org Date 2013-01-21 03:16:22 -0800 (Mon, 21 Jan 2013) Log Message [chromium] move methods interacting with willSendRequest to TestRunner https://bugs.webkit.org/show_bug.cgi?id=107270 Reviewed by Kent Tamura. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::DRTTestRunner): (DRTTestRunner::waitForPolicyDelegate): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload): (WebTestRunner::WebTestRunner::httpHeadersToClear): (WebTestRunner::WebTestRunner::shouldBlockRedirects): (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::httpHeadersToClear): (WebTestRunner): (WebTestRunner::TestRunner::shouldBlockRedirects): (WebTestRunner::TestRunner::willSendRequestShouldReturnNull): (WebTestRunner::TestRunner::setWillSendRequestClearHeader): (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect): (WebTestRunner::TestRunner::setWillSendRequestReturnsNull): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::willSendRequest): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest): (WebViewHost::reset): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140317 => 140318) --- trunk/Tools/ChangeLog 2013-01-21 11:10:27 UTC (rev 140317) +++ trunk/Tools/ChangeLog 2013-01-21 11:16:22 UTC (rev 140318) @@ -1,3 +1,40 @@ +2013-01-21 Jochen Eisinger + +[chromium] move methods interacting with willSendRequest to TestRunner +https://bugs.webkit.org/show_bug.cgi?id=107270 + +Reviewed by Kent Tamura. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::DRTTestRunner): +(DRTTestRunner::waitForPolicyDelegate): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload): +(WebTestRunner::WebTestRunner::httpHeadersToClear): +(WebTestRunner::WebTestRunner::shouldBlockRedirects): +(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::httpHeadersToClear): +(WebTestRunner): +(WebTestRunner::TestRunner::shouldBlockRedirects): +(WebTestRunner::TestRunner::willSendRequestShouldReturnNull): +(WebTestRunner::TestRunner::setWillSendRequestClearHeader): +(WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect): +(WebTestRunner::TestRunner::setWillSendRequestReturnsNull): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::willSendRequest): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::willSendRequest): +(WebViewHost::reset): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-21 Zan Dobersek [GTK] Stop building WebKit2 on GTK EWSs Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140317 => 140318) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-21 11:10:27 UTC (rev 140317) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-21 11:16:22 UTC (rev 140318) @@ -98,9 +98,6 @@ bindMethod("queueReload", &DRTTestRunner::queueReload); bindMethod("setCloseRemainingWindowsWhenComplete", &DRTTestRunner::setCloseRemainingWindowsWhenComplete); bindMethod("setCustomPolicyDelegate", &DRTTestRunner::setCustomPolicyDelegate); -bindMethod("setWillSendRequestClearHeader", &DRTTestRunner::setWillSendRequestClearHeader); -bindMethod("setWillSendRequestReturnsNull", &DRTTestRunner::setWillSendR
[webkit-changes] [140561] trunk/Tools
Title: [140561] trunk/Tools Revision 140561 Author joc...@chromium.org Date 2013-01-23 11:45:52 -0800 (Wed, 23 Jan 2013) Log Message [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html https://bugs.webkit.org/show_bug.cgi?id=107556 Reviewed by Tony Chang. WebViewHost initiates a navigation to about:blank in its destructor. However, since WebTestProxy inherits from WebViewHost, at this point the WebViewClient and WebFrameClient interfaces are already partially destructed resulting in the use after free. This does not affect the chromium implementation since it doesn't invoke WebKit API methods in its destructor. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): (TestShell::closeWindow): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::~WebViewHost): (WebViewHost::shutdown): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestShell.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140560 => 140561) --- trunk/Tools/ChangeLog 2013-01-23 19:27:38 UTC (rev 140560) +++ trunk/Tools/ChangeLog 2013-01-23 19:45:52 UTC (rev 140561) @@ -1,3 +1,28 @@ +2013-01-23 Jochen Eisinger + +[chromium] Use after free in plugins/geturlnotify-during-document-teardown.html +https://bugs.webkit.org/show_bug.cgi?id=107556 + +Reviewed by Tony Chang. + +WebViewHost initiates a navigation to about:blank in its destructor. +However, since WebTestProxy inherits from WebViewHost, at this point +the WebViewClient and WebFrameClient interfaces are already partially +destructed resulting in the use after free. + +This does not affect the chromium implementation since it doesn't +invoke WebKit API methods in its destructor. + +* DumpRenderTree/chromium/TestShell.cpp: +(TestShell::~TestShell): +(TestShell::closeWindow): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::WebViewHost): +(WebViewHost::~WebViewHost): +(WebViewHost::shutdown): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-23 Andrei Bucur [CSS Regions] Create Regions watchlist Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (140560 => 140561) --- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-01-23 19:27:38 UTC (rev 140560) +++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2013-01-23 19:45:52 UTC (rev 140561) @@ -202,6 +202,8 @@ m_testRunner->setDelegate(0); m_testRunner->setWebView(0); m_drtDevToolsAgent->setWebView(0); +if (m_webViewHost) +m_webViewHost->shutdown(); } void TestShell::createDRTDevToolsClient(DRTDevToolsAgent* agent) @@ -795,6 +797,7 @@ if (window->webWidget() == m_focusedWidget) focusedWidget = 0; +window->shutdown(); delete window; // We set the focused widget after deleting the web view host because it // can change the focus. Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (140560 => 140561) --- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2013-01-23 19:27:38 UTC (rev 140560) +++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2013-01-23 19:45:52 UTC (rev 140561) @@ -1128,12 +1128,22 @@ : m_shell(shell) , m_proxy(0) , m_webWidget(0) +, m_shutdownWasInvoked(false) { reset(); } WebViewHost::~WebViewHost() { +ASSERT(m_shutdownWasInvoked); +if (m_inModalLoop) +webkit_support::QuitMessageLoop(); +} + +void WebViewHost::shutdown() +{ +ASSERT(!m_shutdownWasInvoked); + // DevTools frontend page is supposed to be navigated only once and // loading another URL in that Page is an error. if (m_shell->devToolsWebView() != this) { @@ -1148,8 +1158,8 @@ m_layerTreeView.clear(); webWidget()->close(); -if (m_inModalLoop) -webkit_support::QuitMessageLoop(); +m_webWidget = 0; +m_shutdownWasInvoked = true; } void WebViewHost::setWebWidget(WebKit::WebWidget* widget) Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.h (140560 => 140561) --- trunk/Tools/DumpRenderTree/chromium/WebViewHost.h 2013-01-23 19:27:38 UTC (rev 140560) +++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.h 2013-01-23 19:45:52 UTC (rev 140561) @@ -79,6 +79,7 @@ public: WebViewHost(TestShell*); virtual ~WebViewHost(); +void shutdown(); void setWebWidget(WebKit::WebWidget*); WebKit::WebView* webView() const; WebKit::WebWidget* webWidget() const; @@ -372,6 +373,9 @@ bool m_hasWindow; bool m_inModalLoop; + +bool m_shutdownWasInvoked; + WebKit::WebRect m_windowRect; //
[webkit-changes] [140889] trunk/Tools
Title: [140889] trunk/Tools Revision 140889 Author joc...@chromium.org Date 2013-01-25 17:32:15 -0800 (Fri, 25 Jan 2013) Log Message [chromium] move tracking of the top loading frame to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=107948 Reviewed by Adam Barth. * DumpRenderTree/chromium/DRTTestRunner.cpp: (DRTTestRunner::WorkQueue::processWorkSoon): (DRTTestRunner::WorkQueue::processWork): (DRTTestRunner::completeNotifyDone): * DumpRenderTree/chromium/DRTTestRunner.h: (DRTTestRunner): * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestProxyBase): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::setTopLoadingFrame): (WebTestRunner::WebTestRunner::topLoadingFrame): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::setTopLoadingFrame): (WebTestRunner): (WebTestRunner::TestRunner::topLoadingFrame): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): (WebTestRunner::TestRunner::locationChangeDone): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad): (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad): (WebTestRunner::WebTestProxyBase::didFailLoad): (WebTestRunner::WebTestProxyBase::didFinishLoad): (WebTestRunner::WebTestProxyBase::locationChangeDone): (WebTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset): (WebViewHost::updateURL): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (140888 => 140889) --- trunk/Tools/ChangeLog 2013-01-26 01:29:06 UTC (rev 140888) +++ trunk/Tools/ChangeLog 2013-01-26 01:32:15 UTC (rev 140889) @@ -1,3 +1,43 @@ +2013-01-25 Jochen Eisinger + +[chromium] move tracking of the top loading frame to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=107948 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/DRTTestRunner.cpp: +(DRTTestRunner::WorkQueue::processWorkSoon): +(DRTTestRunner::WorkQueue::processWork): +(DRTTestRunner::completeNotifyDone): +* DumpRenderTree/chromium/DRTTestRunner.h: +(DRTTestRunner): +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestProxyBase): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::setTopLoadingFrame): +(WebTestRunner::WebTestRunner::topLoadingFrame): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::TestRunner): +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::setTopLoadingFrame): +(WebTestRunner): +(WebTestRunner::TestRunner::topLoadingFrame): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +(WebTestRunner::TestRunner::locationChangeDone): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad): +(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad): +(WebTestRunner::WebTestProxyBase::didFailLoad): +(WebTestRunner::WebTestProxyBase::didFinishLoad): +(WebTestRunner::WebTestProxyBase::locationChangeDone): +(WebTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::reset): +(WebViewHost::updateURL): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-25 Sheriff Bot Unreviewed, rolling out r140774. Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (140888 => 140889) --- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-26 01:29:06 UTC (rev 140888) +++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp 2013-01-26 01:32:15 UTC (rev 140889) @@ -120,7 +120,7 @@ void DRTTestRunner::WorkQueue::processWorkSoon() { -if (m_controller->m_shell->webViewHost()->topLoadingFrame()) +if (m_controller->topLoadingFrame()) return; if (!m_queue.isEmpty()) { @@ -141,7 +141,7 @@ return; } -if (!m_controller->m_waitUntilDone && !shell->webViewHost()->topLoadingFrame()) +
[webkit-changes] [140927] trunk
Title: [140927] trunk Revision 140927 Author joc...@chromium.org Date 2013-01-27 02:58:30 -0800 (Sun, 27 Jan 2013) Log Message Check notification permissions in the show() method https://bugs.webkit.org/show_bug.cgi?id=108009 Reviewed by Adam Barth. Source/WebCore: Tests: fast/notifications/notifications-constructor-with-permission.html fast/notifications/notifications-constructor-without-permission.html * Modules/notifications/Notification.cpp: (WebCore::Notification::show): (WebCore::Notification::taskTimerFired): LayoutTests: * fast/notifications/notifications-constructor-with-permission-expected.txt: Added. * fast/notifications/notifications-constructor-with-permission.html: Added. * fast/notifications/notifications-constructor-without-permission-expected.txt: Added. * fast/notifications/notifications-constructor-without-permission.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/notifications/Notification.cpp Added Paths trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission.html trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission.html Diff Modified: trunk/LayoutTests/ChangeLog (140926 => 140927) --- trunk/LayoutTests/ChangeLog 2013-01-27 07:02:45 UTC (rev 140926) +++ trunk/LayoutTests/ChangeLog 2013-01-27 10:58:30 UTC (rev 140927) @@ -1,3 +1,15 @@ +2013-01-27 Jochen Eisinger + +Check notification permissions in the show() method +https://bugs.webkit.org/show_bug.cgi?id=108009 + +Reviewed by Adam Barth. + +* fast/notifications/notifications-constructor-with-permission-expected.txt: Added. +* fast/notifications/notifications-constructor-with-permission.html: Added. +* fast/notifications/notifications-constructor-without-permission-expected.txt: Added. +* fast/notifications/notifications-constructor-without-permission.html: Added. + 2013-01-26 Sheriff Bot Unreviewed, rolling out r140880. Added: trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt (0 => 140927) --- trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt 2013-01-27 10:58:30 UTC (rev 140927) @@ -0,0 +1,5 @@ +DESKTOP NOTIFICATION: icon , title Hello world, text +Sending notifications with permission... + +PASS: show event fired. + Added: trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission.html (0 => 140927) --- trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission.html (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission.html 2013-01-27 10:58:30 UTC (rev 140927) @@ -0,0 +1,37 @@ + + + + +function log(message) +{ +document.getElementById("result").innerHTML += message + "<br>"; +} + +function runTests() +{ +if (window.testRunner) { +testRunner.grantWebNotificationPermission("file://"); +testRunner.dumpAsText(); +testRunner.waitUntilDone(); +} + +if (!window.Notification) { +log("FAIL: No Notification constructor!"); +} + +var N = new Notification("Hello world"); +N._onshow_ = function() { log("PASS: show event fired."); } +N._onerror_ = function() { log("FAIL: error event fired."); } +setTimeout(function() { testRunner.notifyDone(); }, 100); +} + + + +Sending notifications with permission... + + + +runTests(); + + + Added: trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt (0 => 140927) --- trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt 2013-01-27 10:58:30 UTC (rev 140927) @@ -0,0 +1,4 @@ +Sending notifications without permission... + +PASS: error event fired. + Added: trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission.html (0 => 140927) --- trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission.html (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission.html 2013-01-27 10:58:30 UTC (rev 140927) @@ -0,0 +1,37 @@ + + + + +
[webkit-changes] [140928] trunk
Title: [140928] trunk Revision 140928 Author joc...@chromium.org Date 2013-01-27 13:04:20 -0800 (Sun, 27 Jan 2013) Log Message [chromium] add missing plumbing for Notification.requestPermission https://bugs.webkit.org/show_bug.cgi?id=108012 Reviewed by Adam Barth. Source/WebKit/chromium: * src/NotificationPresenterImpl.cpp: (WebKit): (WebKit::VoidCallbackClient::VoidCallbackClient): (NotificationPermissionCallbackClient): (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient): (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete): (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient): (WebKit::NotificationPresenterImpl::requestPermission): * src/NotificationPresenterImpl.h: (NotificationPresenterImpl): LayoutTests: * fast/notifications/notifications-constructor-request-permission-expected.txt: Added. * fast/notifications/notifications-constructor-request-permission.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.h Added Paths trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission.html Diff Modified: trunk/LayoutTests/ChangeLog (140927 => 140928) --- trunk/LayoutTests/ChangeLog 2013-01-27 10:58:30 UTC (rev 140927) +++ trunk/LayoutTests/ChangeLog 2013-01-27 21:04:20 UTC (rev 140928) @@ -1,5 +1,15 @@ 2013-01-27 Jochen Eisinger +[chromium] add missing plumbing for Notification.requestPermission +https://bugs.webkit.org/show_bug.cgi?id=108012 + +Reviewed by Adam Barth. + +* fast/notifications/notifications-constructor-request-permission-expected.txt: Added. +* fast/notifications/notifications-constructor-request-permission.html: Added. + +2013-01-27 Jochen Eisinger + Check notification permissions in the show() method https://bugs.webkit.org/show_bug.cgi?id=108009 Added: trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt (0 => 140928) --- trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt 2013-01-27 21:04:20 UTC (rev 140928) @@ -0,0 +1,5 @@ +DESKTOP NOTIFICATION PERMISSION REQUESTED: file:// +Requesting notification permission... + +PASS: Permission callback invoked. + Added: trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission.html (0 => 140928) --- trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission.html (rev 0) +++ trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission.html 2013-01-27 21:04:20 UTC (rev 140928) @@ -0,0 +1,36 @@ + + + + +function log(message) +{ +document.getElementById("result").innerHTML += message + "<br>"; +} + +function runTests() +{ +if (window.testRunner) { +testRunner.dumpAsText(); +} + +if (!window.Notification) { +log("FAIL: No Notification interface!"); +} + +var N = window.Notification.requestPermission( +function() { log("PASS: Permission callback invoked."); } +); +} + + + +Requesting notification permission... + + + +runTests(); + + + + + Modified: trunk/Source/WebKit/chromium/ChangeLog (140927 => 140928) --- trunk/Source/WebKit/chromium/ChangeLog 2013-01-27 10:58:30 UTC (rev 140927) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-27 21:04:20 UTC (rev 140928) @@ -1,3 +1,21 @@ +2013-01-27 Jochen Eisinger + +[chromium] add missing plumbing for Notification.requestPermission +https://bugs.webkit.org/show_bug.cgi?id=108012 + +Reviewed by Adam Barth. + +* src/NotificationPresenterImpl.cpp: +(WebKit): +(WebKit::VoidCallbackClient::VoidCallbackClient): +(NotificationPermissionCallbackClient): +(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient): +(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete): +(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient): +(WebKit::NotificationPresenterImpl::requestPermission): +* src/NotificationPresenterImpl.h: +(NotificationPresenterImpl): + 2013-01-26 James Simonsen [chromium] Export ResourceRequest's priority through WebURLRequest Modified: trunk/Source/WebKit/chromium/
[webkit-changes] [140979] trunk/Tools
Title: [140979] trunk/Tools Revision 140979 Author joc...@chromium.org Date 2013-01-28 11:09:38 -0800 (Mon, 28 Jan 2013) Log Message [chromium] remove temporary define used for updating TestRunner API Unreviewed. Clean-up change. * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h Diff Modified: trunk/Tools/ChangeLog (140978 => 140979) --- trunk/Tools/ChangeLog 2013-01-28 18:36:28 UTC (rev 140978) +++ trunk/Tools/ChangeLog 2013-01-28 19:09:38 UTC (rev 140979) @@ -1,3 +1,11 @@ +2013-01-28 Jochen Eisinger + +[chromium] remove temporary define used for updating TestRunner API + +Unreviewed. Clean-up change. + +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: + 2013-01-28 James Craig HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match. Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (140978 => 140979) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-01-28 18:36:28 UTC (rev 140978) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-01-28 19:09:38 UTC (rev 140979) @@ -41,8 +41,6 @@ #include #include -#define TEST_RUNNER_MOVED_PRINTING 1 - namespace WebKit { class WebAccessibilityObject; class WebCachedURLRequest; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141071] trunk/Source/WebCore
Title: [141071] trunk/Source/WebCore Revision 141071 Author joc...@chromium.org Date 2013-01-29 00:18:54 -0800 (Tue, 29 Jan 2013) Log Message REGRESSION(r141070): Broke debug build https://bugs.webkit.org/show_bug.cgi?id=108159 Unreviewed build fix. * html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (141070 => 141071) --- trunk/Source/WebCore/ChangeLog 2013-01-29 08:01:37 UTC (rev 141070) +++ trunk/Source/WebCore/ChangeLog 2013-01-29 08:18:54 UTC (rev 141071) @@ -1,3 +1,13 @@ +2013-01-29 Jochen Eisinger + +REGRESSION(r141070): Broke debug build +https://bugs.webkit.org/show_bug.cgi?id=108159 + +Unreviewed build fix. + +* html/parser/HTMLDocumentParser.cpp: +(WebCore::HTMLDocumentParser::pumpTokenizer): + 2013-01-28 Adam Barth HTMLDocumentParser should hold the HTMLToken using an OwnPtr Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (141070 => 141071) --- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-29 08:01:37 UTC (rev 141070) +++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-29 08:18:54 UTC (rev 141071) @@ -361,7 +361,7 @@ } constructTreeFromHTMLToken(token()); -ASSERT(m_token.isUninitialized()); +ASSERT(token().isUninitialized()); } // Ensure we haven't been totally deref'ed after pumping. Any caller of this ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141072] branches/chromium/1364
Title: [141072] branches/chromium/1364 Revision 141072 Author joc...@chromium.org Date 2013-01-29 00:25:19 -0800 (Tue, 29 Jan 2013) Log Message Merge 140927 > Check notification permissions in the show() method > https://bugs.webkit.org/show_bug.cgi?id=108009 > > Reviewed by Adam Barth. > > Source/WebCore: > > Tests: fast/notifications/notifications-constructor-with-permission.html >fast/notifications/notifications-constructor-without-permission.html > > * Modules/notifications/Notification.cpp: > (WebCore::Notification::show): > (WebCore::Notification::taskTimerFired): > > LayoutTests: > > * fast/notifications/notifications-constructor-with-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-with-permission.html: Added. > * fast/notifications/notifications-constructor-without-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-without-permission.html: Added. > TBR=joc...@chromium.org Review URL: https://codereview.chromium.org/12087048 Modified Paths branches/chromium/1364/Source/WebCore/Modules/notifications/Notification.cpp Added Paths branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission.html branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission.html Diff Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt (from rev 140927, trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt) (0 => 141072) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt 2013-01-29 08:25:19 UTC (rev 141072) @@ -0,0 +1,5 @@ +DESKTOP NOTIFICATION: icon , title Hello world, text +Sending notifications with permission... + +PASS: show event fired. + Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission.html (from rev 140927, trunk/LayoutTests/fast/notifications/notifications-constructor-with-permission.html) (0 => 141072) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission.html (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-with-permission.html 2013-01-29 08:25:19 UTC (rev 141072) @@ -0,0 +1,37 @@ + + + + +function log(message) +{ +document.getElementById("result").innerHTML += message + "
"; +} + +function runTests() +{ +if (window.testRunner) { +testRunner.grantWebNotificationPermission("file://"); +testRunner.dumpAsText(); +testRunner.waitUntilDone(); +} + +if (!window.Notification) { +log("FAIL: No Notification constructor!"); +} + +var N = new Notification("Hello world"); +N._onshow_ = function() { log("PASS: show event fired."); } +N._onerror_ = function() { log("FAIL: error event fired."); } +setTimeout(function() { testRunner.notifyDone(); }, 100); +} + + + +Sending notifications with permission... + + + +runTests(); + + + Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt (from rev 140927, trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt) (0 => 141072) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt 2013-01-29 08:25:19 UTC (rev 141072) @@ -0,0 +1,4 @@ +Sending notifications without permission... + +PASS: error event fired. + Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission.html (from rev 140927, trunk/LayoutTests/fast/notifications/notifications-constructor-without-permission.html) (0 => 141072) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission.html (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-without-permission.html 2013-01-29 08:25:19 UTC (rev 141072) @@ -0,0 +1,37 @@ + + + + +function log(message) +{ +document.getElementById("result").innerHTML += message + "
"; +
[webkit-changes] [141076] branches/chromium/1364
Title: [141076] branches/chromium/1364 Revision 141076 Author joc...@chromium.org Date 2013-01-29 00:39:51 -0800 (Tue, 29 Jan 2013) Log Message Merge 140928 > [chromium] add missing plumbing for Notification.requestPermission > https://bugs.webkit.org/show_bug.cgi?id=108012 > > Reviewed by Adam Barth. > > Source/WebKit/chromium: > > * src/NotificationPresenterImpl.cpp: > (WebKit): > (WebKit::VoidCallbackClient::VoidCallbackClient): > (NotificationPermissionCallbackClient): > (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient): > (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete): > (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient): > (WebKit::NotificationPresenterImpl::requestPermission): > * src/NotificationPresenterImpl.h: > (NotificationPresenterImpl): > > LayoutTests: > > * fast/notifications/notifications-constructor-request-permission-expected.txt: Added. > * fast/notifications/notifications-constructor-request-permission.html: Added. > TBR=joc...@chromium.org Review URL: https://codereview.chromium.org/12086041 Modified Paths branches/chromium/1364/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp branches/chromium/1364/Source/WebKit/chromium/src/NotificationPresenterImpl.h Added Paths branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission.html Diff Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt (from rev 140928, trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt) (0 => 141076) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission-expected.txt 2013-01-29 08:39:51 UTC (rev 141076) @@ -0,0 +1,5 @@ +DESKTOP NOTIFICATION PERMISSION REQUESTED: file:// +Requesting notification permission... + +PASS: Permission callback invoked. + Copied: branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission.html (from rev 140928, trunk/LayoutTests/fast/notifications/notifications-constructor-request-permission.html) (0 => 141076) --- branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission.html (rev 0) +++ branches/chromium/1364/LayoutTests/fast/notifications/notifications-constructor-request-permission.html 2013-01-29 08:39:51 UTC (rev 141076) @@ -0,0 +1,36 @@ + + + + +function log(message) +{ +document.getElementById("result").innerHTML += message + "
"; +} + +function runTests() +{ +if (window.testRunner) { +testRunner.dumpAsText(); +} + +if (!window.Notification) { +log("FAIL: No Notification interface!"); +} + +var N = window.Notification.requestPermission( +function() { log("PASS: Permission callback invoked."); } +); +} + + + +Requesting notification permission... + + + +runTests(); + + + + + Modified: branches/chromium/1364/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp (141075 => 141076) --- branches/chromium/1364/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2013-01-29 08:33:33 UTC (rev 141075) +++ branches/chromium/1364/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2013-01-29 08:39:51 UTC (rev 141076) @@ -49,9 +49,10 @@ namespace WebKit { +#if ENABLE(LEGACY_NOTIFICATIONS) class VoidCallbackClient : public WebNotificationPermissionCallback { public: -VoidCallbackClient(PassRefPtr callback) +explicit VoidCallbackClient(PassRefPtr callback) : m_callback(callback) { } @@ -68,7 +69,34 @@ RefPtr m_callback; }; +#endif // ENABLE(LEGACY_NOTIFICATIONS) +#if ENABLE(NOTIFICATIONS) +class NotificationPermissionCallbackClient : public WebNotificationPermissionCallback { +public: +NotificationPermissionCallbackClient(WebNotificationPresenter* presenter, PassRefPtr securityOrigin, PassRefPtr callback) +: m_presenter(presenter) +, m_securityOrigin(securityOrigin) +, m_callback(callback) +{ +} + +virtual void permissionRequestComplete() +{ +if (m_callback) +m_callback->handleEvent(Notification::permissionString(static_cast(m_presenter->checkPermission(WebSecurityOrigin(m_securityOrigin); +delete this; +} + +private: +virtual ~NotificationPermissionCallbackClient() { } + +WebNotificationPresenter* m_presenter; +RefPtr m_securityOrigin; +RefP
[webkit-changes] [128270] trunk/LayoutTests
Title: [128270] trunk/LayoutTests Revision 128270 Author joc...@chromium.org Date 2012-09-12 00:29:52 -0700 (Wed, 12 Sep 2012) Log Message Change fast/events/popup-blocking-timers.html to generate a user action for each popup https://bugs.webkit.org/show_bug.cgi?id=96475 Reviewed by Adam Barth. The chromium port only allows one user gesture gated action per user gesture. * fast/events/popup-blocking-timers-expected.txt: * fast/events/popup-blocking-timers.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers.html Diff Modified: trunk/LayoutTests/ChangeLog (128269 => 128270) --- trunk/LayoutTests/ChangeLog 2012-09-12 07:02:02 UTC (rev 128269) +++ trunk/LayoutTests/ChangeLog 2012-09-12 07:29:52 UTC (rev 128270) @@ -1,3 +1,16 @@ +2012-09-12 Jochen Eisinger + +Change fast/events/popup-blocking-timers.html to generate a user action for each popup +https://bugs.webkit.org/show_bug.cgi?id=96475 + +Reviewed by Adam Barth. + +The chromium port only allows one user gesture gated action per user +gesture. + +* fast/events/popup-blocking-timers-expected.txt: +* fast/events/popup-blocking-timers.html: + 2012-09-11 Kent Tamura [Chromium] Test expectation update Modified: trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt (128269 => 128270) --- trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-09-12 07:02:02 UTC (rev 128269) +++ trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-09-12 07:29:52 UTC (rev 128270) @@ -1,4 +1,4 @@ -Click Here +Click Here (6 times) Test calling window.open() directly. A popup should be allowed. PASS newWindow is non-null. Test calling window.open() with a 0 ms delay. A popup should be allowed. Modified: trunk/LayoutTests/fast/events/popup-blocking-timers.html (128269 => 128270) --- trunk/LayoutTests/fast/events/popup-blocking-timers.html 2012-09-12 07:02:02 UTC (rev 128269) +++ trunk/LayoutTests/fast/events/popup-blocking-timers.html 2012-09-12 07:29:52 UTC (rev 128270) @@ -4,6 +4,7 @@ var newWindow; var intervalId; var firstIntervalExecution = true; +var clickNumber = 0; if (window.testRunner) { testRunner.dumpAsText(); @@ -13,57 +14,59 @@ } function clickHandler() { -newWindow = window.open("about:blank"); -self.focus(); -debug("Test calling window.open() directly. A popup should be allowed."); -shouldBeNonNull("newWindow"); - -setTimeout(function() { +clickNumber++; +if (clickNumber == 1) { newWindow = window.open("about:blank"); self.focus(); -debug("Test calling window.open() with a 0 ms delay. A popup should be allowed.") +debug("Test calling window.open() directly. A popup should be allowed."); shouldBeNonNull("newWindow"); -}, 0); - -setTimeout(function() { -newWindow = window.open("about:blank"); -self.focus(); -debug("Test calling window.open() with a 1000 ms delay. A popup should be allowed.") -shouldBeNonNull("newWindow"); -}, 1000); - -setTimeout(function() { -newWindow = window.open("about:blank"); -self.focus(); -debug("Test calling window.open() with a 1001 ms delay. A popup should not be allowed.") -shouldBeUndefined("newWindow"); - -if (window.testRunner) -testRunner.notifyDone(); -}, 1001); - -intervalId = setInterval(function() { -debug("Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval."); -newWindow = window.open("about:blank"); -self.focus(); -if (firstIntervalExecution) { +} else if (clickNumber == 2) { +setTimeout(function() { +newWindow = window.open("about:blank"); +self.focus(); +debug("Test calling window.open() with a 0 ms delay. A popup should be allowed.") shouldBeNonNull("newWindow"); -firstIntervalExecution = false; -} else { -shouldBeUndefined("newWindow"); -clearInterval(intervalId); -} -}, 100); -
[webkit-changes] [128273] trunk
Title: [128273] trunk Revision 128273 Author joc...@chromium.org Date 2012-09-12 00:53:59 -0700 (Wed, 12 Sep 2012) Log Message Source/WebKit/chromium: [chromium] consumable user gesture count off for input events https://bugs.webkit.org/show_bug.cgi?id=96373 Reviewed by Adam Barth. Don't create a UserGestureIndicator in the chromium layer, as it will already be created by webcore's event handler. Creating multiple UserGestureIndicator objects for the same object would allow to execute multiple user-gesture-gated actions per user gesture such as opening a new window. * public/WebInputEvent.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent): Tools: [chromium] Consume a user gesture when creating a new view. https://bugs.webkit.org/show_bug.cgi?id=96373 Reviewed by Adam Barth. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): LayoutTests: [chromium] Only allow one user-gesture gated action per user action. https://bugs.webkit.org/show_bug.cgi?id=96373 Reviewed by Adam Barth. * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt: Added. * platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebInputEvent.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp Added Paths trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html Diff Modified: trunk/LayoutTests/ChangeLog (128272 => 128273) --- trunk/LayoutTests/ChangeLog 2012-09-12 07:39:51 UTC (rev 128272) +++ trunk/LayoutTests/ChangeLog 2012-09-12 07:53:59 UTC (rev 128273) @@ -1,5 +1,15 @@ 2012-09-12 Jochen Eisinger +[chromium] Only allow one user-gesture gated action per user action. +https://bugs.webkit.org/show_bug.cgi?id=96373 + +Reviewed by Adam Barth. + +* platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt: Added. +* platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html: Added. + +2012-09-12 Jochen Eisinger + Change fast/events/popup-blocking-timers.html to generate a user action for each popup https://bugs.webkit.org/show_bug.cgi?id=96475 Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt (0 => 128273) --- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-expected.txt 2012-09-12 07:53:59 UTC (rev 128273) @@ -0,0 +1,4 @@ +Test that only a single popup is allowed in response to a single user action. The test passes if only one popup is created. + +Click Here +PASSED Added: trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html (0 => 128273) --- trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once.html 2012-09-12 07:53:59 UTC (rev 128273) @@ -0,0 +1,41 @@ + + + + +Test that only a single popup is allowed in response to a single +user action. The test passes if only one popup is created. + +Click Here + + +function popup() { +window.open("about:blank", "window1"); +window.open("about:blank", "window2"); +if (window.testRunner) { +if (testRunner.windowCount() == windowCount + 1) +document.getElementById("console").innerText = "PASSED"; +else +document.getElementById("console").innerText = "FAILED"; +testRunner.notifyDone(); +} +} + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.setCanOpenWindows(); +testRunner.setPopupBlockingEnabled(true); +testRunner.setCloseRemainingWindowsWhenComplete(true); +testRunner.waitUntilDone(); +windowCount = testRunner.windowCount(); + +var button = document.getElementById("button"); + +if (window.eventSender) { +eventSender.mouseMoveTo(button.offsetLeft + button.offsetWidth / 2, button.offsetTop + button.offsetHeight / 2); +eventSender.mouseDown(); +eventSender.mouseUp(); +
[webkit-changes] [128324] trunk/Tools
Title: [128324] trunk/Tools Revision 128324 Author joc...@chromium.org Date 2012-09-12 09:25:34 -0700 (Wed, 12 Sep 2012) Log Message [chromium] remove deprecated and unused sets import from chromium_android driver https://bugs.webkit.org/show_bug.cgi?id=96485 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium_android.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Diff Modified: trunk/Tools/ChangeLog (128323 => 128324) --- trunk/Tools/ChangeLog 2012-09-12 16:16:14 UTC (rev 128323) +++ trunk/Tools/ChangeLog 2012-09-12 16:25:34 UTC (rev 128324) @@ -1,3 +1,12 @@ +2012-09-12 Jochen Eisinger + +[chromium] remove deprecated and unused sets import from chromium_android driver +https://bugs.webkit.org/show_bug.cgi?id=96485 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/port/chromium_android.py: + 2012-09-12 Zan Dobersek Flakiness dashboard doesn't recognize new Chromium Android test builder Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (128323 => 128324) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-12 16:16:14 UTC (rev 128323) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-12 16:25:34 UTC (rev 128324) @@ -31,7 +31,6 @@ import logging import os import re -import sets import subprocess import threading import time ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129002] trunk/LayoutTests
Title: [129002] trunk/LayoutTests Revision 129002 Author joc...@chromium.org Date 2012-09-19 07:12:37 -0700 (Wed, 19 Sep 2012) Log Message [chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests Unreviewed gardening. * storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (129001 => 129002) --- trunk/LayoutTests/ChangeLog 2012-09-19 14:11:48 UTC (rev 129001) +++ trunk/LayoutTests/ChangeLog 2012-09-19 14:12:37 UTC (rev 129002) @@ -1,3 +1,11 @@ +2012-09-19 Jochen Eisinger + +[chromium] Update test expectation for indexeddb test that is currently only run using content_browsertests + +Unreviewed gardening. + +* storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt: + 2012-09-19 Rick Byers Do touch adjustment on GestureTapDown Modified: trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt (129001 => 129002) --- trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt 2012-09-19 14:11:48 UTC (rev 129001) +++ trunk/LayoutTests/storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt 2012-09-19 14:12:37 UTC (rev 129002) @@ -39,3 +39,4 @@ PASS successfullyParsed is true TEST COMPLETE + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129137] branches/chromium/1271/Source/WebKit/chromium/features.gypi
Title: [129137] branches/chromium/1271/Source/WebKit/chromium/features.gypi Revision 129137 Author joc...@chromium.org Date 2012-09-20 08:25:06 -0700 (Thu, 20 Sep 2012) Log Message Disable CSP_NEXT on Chromium M23 branch. BUG=148060 Modified Paths branches/chromium/1271/Source/WebKit/chromium/features.gypi Diff Modified: branches/chromium/1271/Source/WebKit/chromium/features.gypi (129136 => 129137) --- branches/chromium/1271/Source/WebKit/chromium/features.gypi 2012-09-20 15:05:30 UTC (rev 129136) +++ branches/chromium/1271/Source/WebKit/chromium/features.gypi 2012-09-20 15:25:06 UTC (rev 129137) @@ -37,7 +37,7 @@ 'ENABLE_BLOB=1', 'ENABLE_BLOB_SLICE=1', 'ENABLE_CHANNEL_MESSAGING=1', - 'ENABLE_CSP_NEXT=1', + 'ENABLE_CSP_NEXT=0', 'ENABLE_CSS3_TEXT_DECORATION=0', 'ENABLE_CSS_BOX_DECORATION_BREAK=1', 'ENABLE_CSS_COMPOSITING=0', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130062] trunk/Source/WebCore
Title: [130062] trunk/Source/WebCore Revision 130062 Author joc...@chromium.org Date 2012-10-01 12:07:57 -0700 (Mon, 01 Oct 2012) Log Message [chromium] ASSERT that the embedder has set a default locale https://bugs.webkit.org/show_bug.cgi?id=98001 Reviewed by Adam Barth. The callsites assume that the default language is always defined, e.g. Document::getCachedLocalizer. Add an ASSERT() statement so an embedder doesn't have to guess what they did wrong. * platform/chromium/LanguageChromium.cpp: (WebCore::platformLanguage): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (130061 => 130062) --- trunk/Source/WebCore/ChangeLog 2012-10-01 19:05:24 UTC (rev 130061) +++ trunk/Source/WebCore/ChangeLog 2012-10-01 19:07:57 UTC (rev 130062) @@ -1,3 +1,17 @@ +2012-10-01 Jochen Eisinger + +[chromium] ASSERT that the embedder has set a default locale +https://bugs.webkit.org/show_bug.cgi?id=98001 + +Reviewed by Adam Barth. + +The callsites assume that the default language is always defined, e.g. +Document::getCachedLocalizer. Add an ASSERT() statement so an embedder +doesn't have to guess what they did wrong. + +* platform/chromium/LanguageChromium.cpp: +(WebCore::platformLanguage): + 2012-10-01 Christophe Dumez Fix compilation warnings Modified: trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp (130061 => 130062) --- trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp 2012-10-01 19:05:24 UTC (rev 130061) +++ trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp 2012-10-01 19:07:57 UTC (rev 130062) @@ -40,8 +40,10 @@ static String platformLanguage() { DEFINE_STATIC_LOCAL(String, computedDefaultLanguage, ()); -if (computedDefaultLanguage.isEmpty()) +if (computedDefaultLanguage.isEmpty()) { computedDefaultLanguage.append(WebKit::Platform::current()->defaultLocale()); +ASSERT(!computedDefaultLanguage.isEmpty()); +} return computedDefaultLanguage; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130141] trunk/Source/WebKit/chromium
Title: [130141] trunk/Source/WebKit/chromium Revision 130141 Author joc...@chromium.org Date 2012-10-02 02:29:01 -0700 (Tue, 02 Oct 2012) Log Message Use correct gtest macros for tests for true/false Unreviewed build-fix. Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert true to a pointer. Tests should use EXPECT_TRUE instead. * tests/WebFrameTest.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (130140 => 130141) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-02 08:59:39 UTC (rev 130140) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-02 09:29:01 UTC (rev 130141) @@ -1,3 +1,14 @@ +2012-10-02 Jochen Eisinger + +Use correct gtest macros for tests for true/false + +Unreviewed build-fix. + +Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert +true to a pointer. Tests should use EXPECT_TRUE instead. + +* tests/WebFrameTest.cpp: + 2012-10-02 Sheriff Bot Unreviewed, rolling out r130129. Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (130140 => 130141) --- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-10-02 08:59:39 UTC (rev 130140) +++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-10-02 09:29:01 UTC (rev 130141) @@ -363,14 +363,14 @@ EXPECT_NEAR(wideDiv.x * scale, scroll.x, 20); int vScroll = (wideDiv.y + wideDiv.height / 2) * scale - (viewportHeight / 2); EXPECT_NEAR(vScroll, scroll.y, 1); -EXPECT_EQ(false, isAnchor); +EXPECT_FALSE(isAnchor); setScaleAndScrollAndLayout(webViewImpl, scroll, scale); // Test zoom out back to minimum scale. webViewImpl->computeScaleAndScrollForHitRect(doubleTapPointWide, WebViewImpl::DoubleTap, scale, scroll, isAnchor); EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); -EXPECT_EQ(true, isAnchor); +EXPECT_TRUE(isAnchor); setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), scale); @@ -380,7 +380,7 @@ EXPECT_NEAR(viewportWidth / (float) tallDiv.width, scale, 0.1); EXPECT_NEAR(tallDiv.x * scale, scroll.x, 20); EXPECT_NEAR(tallDiv.y * scale, scroll.y, 20); -EXPECT_EQ(false, isAnchor); +EXPECT_FALSE(isAnchor); // Test for Non-doubletap scaling // Test zooming into div. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130152] trunk/Source/WebCore
Title: [130152] trunk/Source/WebCore Revision 130152 Author joc...@chromium.org Date 2012-10-02 04:41:17 -0700 (Tue, 02 Oct 2012) Log Message [chromium] ASSERT that the embedder has set a default locale https://bugs.webkit.org/show_bug.cgi?id=98001 Reviewed by Adam Barth. The callsites assume that the default language is always defined, e.g. Document::getCachedLocalizer. Add an ASSERT() statement so an embedder doesn't have to guess what they did wrong. * platform/chromium/LanguageChromium.cpp: (WebCore::platformLanguage): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (130151 => 130152) --- trunk/Source/WebCore/ChangeLog 2012-10-02 11:33:12 UTC (rev 130151) +++ trunk/Source/WebCore/ChangeLog 2012-10-02 11:41:17 UTC (rev 130152) @@ -1,3 +1,17 @@ +2012-10-02 Jochen Eisinger + +[chromium] ASSERT that the embedder has set a default locale +https://bugs.webkit.org/show_bug.cgi?id=98001 + +Reviewed by Adam Barth. + +The callsites assume that the default language is always defined, e.g. +Document::getCachedLocalizer. Add an ASSERT() statement so an embedder +doesn't have to guess what they did wrong. + +* platform/chromium/LanguageChromium.cpp: +(WebCore::platformLanguage): + 2012-10-02 Vsevolod Vlasov Web Inspector: Fix _javascript_Source error found by compiler Modified: trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp (130151 => 130152) --- trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp 2012-10-02 11:33:12 UTC (rev 130151) +++ trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp 2012-10-02 11:41:17 UTC (rev 130152) @@ -40,8 +40,10 @@ static String platformLanguage() { DEFINE_STATIC_LOCAL(String, computedDefaultLanguage, ()); -if (computedDefaultLanguage.isEmpty()) +if (computedDefaultLanguage.isEmpty()) { computedDefaultLanguage.append(WebKit::Platform::current()->defaultLocale()); +ASSERT(!computedDefaultLanguage.isEmpty()); +} return computedDefaultLanguage; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130200] trunk/LayoutTests
Title: [130200] trunk/LayoutTests Revision 130200 Author joc...@chromium.org Date 2012-10-02 13:11:10 -0700 (Tue, 02 Oct 2012) Log Message Split popup-blocking-timers.html into individual tests https://bugs.webkit.org/show_bug.cgi?id=96480 Reviewed by Daniel Bates. That should avoid failures from the log messages coming in in the wrong order. * fast/events/popup-blocking-timers-expected.txt: Removed. * fast/events/popup-blocking-timers.html: Removed. * fast/events/popup-blocking-timers1-expected.txt: Added. * fast/events/popup-blocking-timers1.html: Added. * fast/events/popup-blocking-timers2-expected.txt: Added. * fast/events/popup-blocking-timers2.html: Added. * fast/events/popup-blocking-timers3-expected.txt: Added. * fast/events/popup-blocking-timers3.html: Added. * fast/events/popup-blocking-timers4-expected.txt: Added. * fast/events/popup-blocking-timers4.html: Added. * fast/events/popup-blocking-timers5-expected.txt: Added. * fast/events/popup-blocking-timers5.html: Added. * fast/events/popup-blocking-timers6-expected.txt: Added. * fast/events/popup-blocking-timers6.html: Added. * platform/chromium/TestExpectations: * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/qt-5.0-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations Added Paths trunk/LayoutTests/fast/events/popup-blocking-timers1-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers1.html trunk/LayoutTests/fast/events/popup-blocking-timers2-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers2.html trunk/LayoutTests/fast/events/popup-blocking-timers3-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers3.html trunk/LayoutTests/fast/events/popup-blocking-timers4-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers4.html trunk/LayoutTests/fast/events/popup-blocking-timers5-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers5.html trunk/LayoutTests/fast/events/popup-blocking-timers6-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers6.html Removed Paths trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt trunk/LayoutTests/fast/events/popup-blocking-timers.html Diff Modified: trunk/LayoutTests/ChangeLog (130199 => 130200) --- trunk/LayoutTests/ChangeLog 2012-10-02 20:09:16 UTC (rev 130199) +++ trunk/LayoutTests/ChangeLog 2012-10-02 20:11:10 UTC (rev 130200) @@ -1,3 +1,31 @@ +2012-10-02 Jochen Eisinger + +Split popup-blocking-timers.html into individual tests +https://bugs.webkit.org/show_bug.cgi?id=96480 + +Reviewed by Daniel Bates. + +That should avoid failures from the log messages coming in in the wrong order. + +* fast/events/popup-blocking-timers-expected.txt: Removed. +* fast/events/popup-blocking-timers.html: Removed. +* fast/events/popup-blocking-timers1-expected.txt: Added. +* fast/events/popup-blocking-timers1.html: Added. +* fast/events/popup-blocking-timers2-expected.txt: Added. +* fast/events/popup-blocking-timers2.html: Added. +* fast/events/popup-blocking-timers3-expected.txt: Added. +* fast/events/popup-blocking-timers3.html: Added. +* fast/events/popup-blocking-timers4-expected.txt: Added. +* fast/events/popup-blocking-timers4.html: Added. +* fast/events/popup-blocking-timers5-expected.txt: Added. +* fast/events/popup-blocking-timers5.html: Added. +* fast/events/popup-blocking-timers6-expected.txt: Added. +* fast/events/popup-blocking-timers6.html: Added. +* platform/chromium/TestExpectations: +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: +* platform/qt-5.0-wk2/TestExpectations: + 2012-10-02 David Grogan IndexedDB: Don't wedge if page reloads with pending upgradeneeded Deleted: trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt (130199 => 130200) --- trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-10-02 20:09:16 UTC (rev 130199) +++ trunk/LayoutTests/fast/events/popup-blocking-timers-expected.txt 2012-10-02 20:11:10 UTC (rev 130200) @@ -1,16 +0,0 @@ -Click Here (6 times) -Test calling window.open() directly. A popup should be allowed. -PASS newWindow is non-null. -Test calling window.open() with a 0 ms delay. A popup should be allowed. -PASS newWindow is non-null. -Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval. -PASS newWindow is non-null. -Test calling window.open() in a 100 ms interval. A popup should only be allowed on the first execution of the interval. -PASS newWindow is undefined. -Test calling window.open() in a nested call to setTimeout
[webkit-changes] [130267] trunk
Title: [130267] trunk Revision 130267 Author joc...@chromium.org Date 2012-10-03 02:45:35 -0700 (Wed, 03 Oct 2012) Log Message Make sure that user gestures can't be consumed twice https://bugs.webkit.org/show_bug.cgi?id=97483 Reviewed by Adam Barth. Source/WebCore: Instead of a simple counter, use a ref counted token to track how many user gestures happened and where consumed. When creating a timer that is supposed to forward the user gesture, take a reference to this token and reinstantiate the UserGestureIndicator with that token when the timer is triggered. Tests: platform/chromium/fast/events/popup-forwarded-gesture-blocked.html platform/chromium/fast/events/popup-forwarded-gesture.html * dom/UserGestureIndicator.cpp: (WebCore): (WebCore::UserGestureIndicator::UserGestureIndicator): (WebCore::UserGestureIndicator::~UserGestureIndicator): (WebCore::UserGestureIndicator::processingUserGesture): (WebCore::UserGestureIndicator::consumeUserGesture): (WebCore::UserGestureIndicator::currentToken): * dom/UserGestureIndicator.h: (Token): (WebCore::UserGestureIndicator::Token::~Token): (UserGestureIndicator): * page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): * page/DOMTimer.h: (DOMTimer): LayoutTests: * platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt: Added. * platform/chromium/fast/events/popup-forwarded-gesture-blocked.html: Added. * platform/chromium/fast/events/popup-forwarded-gesture-expected.txt: Added. * platform/chromium/fast/events/popup-forwarded-gesture.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/UserGestureIndicator.cpp trunk/Source/WebCore/dom/UserGestureIndicator.h trunk/Source/WebCore/page/DOMTimer.cpp trunk/Source/WebCore/page/DOMTimer.h Added Paths trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked.html trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-expected.txt trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture.html Diff Modified: trunk/LayoutTests/ChangeLog (130266 => 130267) --- trunk/LayoutTests/ChangeLog 2012-10-03 09:23:30 UTC (rev 130266) +++ trunk/LayoutTests/ChangeLog 2012-10-03 09:45:35 UTC (rev 130267) @@ -1,3 +1,15 @@ +2012-10-03 Jochen Eisinger + +Make sure that user gestures can't be consumed twice +https://bugs.webkit.org/show_bug.cgi?id=97483 + +Reviewed by Adam Barth. + +* platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt: Added. +* platform/chromium/fast/events/popup-forwarded-gesture-blocked.html: Added. +* platform/chromium/fast/events/popup-forwarded-gesture-expected.txt: Added. +* platform/chromium/fast/events/popup-forwarded-gesture.html: Added. + 2012-10-03 Dominic Mazzoni AX: Heap-use-after-free when deleting a ContainerNode with an AX object Added: trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt (0 => 130267) --- trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked-expected.txt 2012-10-03 09:45:35 UTC (rev 130267) @@ -0,0 +1,4 @@ +Test that a forwarded user gesture that is consumed before the time fires is resurrected. + +Click Here +PASSED Added: trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked.html (0 => 130267) --- trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked.html (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/popup-forwarded-gesture-blocked.html 2012-10-03 09:45:35 UTC (rev 130267) @@ -0,0 +1,45 @@ + + + + +Test that a forwarded user gesture that is consumed before the +time fires is resurrected. + +Click Here + + +function timer() { +window.open("about:blank", "window2"); +if (window.testRunner) { +if (testRunner.windowCount() == windowCount + 1) +document.getElementById("console").innerText = "PASSED"; +else +document.getElementById("console").innerText = "FAILED"; +testRunner.notifyDone(); +} +} + +function popup() { +setTimeout(timer, 0); +window.open("about:blank", "window1"); +} + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.setCanOpenWindows(); +testRunner.s
[webkit-changes] [126986] trunk/Source/WebCore
Title: [126986] trunk/Source/WebCore Revision 126986 Author joc...@chromium.org Date 2012-08-29 04:24:24 -0700 (Wed, 29 Aug 2012) Log Message REGRESSION(r126816): Missing includes when compiling without SVG https://bugs.webkit.org/show_bug.cgi?id=95312 Reviewed by Eric Seidel. * rendering/FilterEffectRenderer.h: * rendering/RenderLayerFilterInfo.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/FilterEffectRenderer.h trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h Diff Modified: trunk/Source/WebCore/ChangeLog (126985 => 126986) --- trunk/Source/WebCore/ChangeLog 2012-08-29 11:19:23 UTC (rev 126985) +++ trunk/Source/WebCore/ChangeLog 2012-08-29 11:24:24 UTC (rev 126986) @@ -1,3 +1,13 @@ +2012-08-29 Jochen Eisinger + +REGRESSION(r126816): Missing includes when compiling without SVG +https://bugs.webkit.org/show_bug.cgi?id=95312 + +Reviewed by Eric Seidel. + +* rendering/FilterEffectRenderer.h: +* rendering/RenderLayerFilterInfo.h: + 2012-08-29 Adam Barth Improve string efficiency using StringBuilder and StringOperations Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.h (126985 => 126986) --- trunk/Source/WebCore/rendering/FilterEffectRenderer.h 2012-08-29 11:19:23 UTC (rev 126985) +++ trunk/Source/WebCore/rendering/FilterEffectRenderer.h 2012-08-29 11:24:24 UTC (rev 126986) @@ -32,6 +32,7 @@ #include "FilterEffect.h" #include "FilterOperations.h" #include "FloatRect.h" +#include "FractionalLayoutRect.h" #include "GraphicsContext.h" #include "ImageBuffer.h" #include "SVGFilterBuilder.h" Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h (126985 => 126986) --- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2012-08-29 11:19:23 UTC (rev 126985) +++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2012-08-29 11:24:24 UTC (rev 126986) @@ -36,6 +36,7 @@ #include "CachedSVGDocument.h" #endif #include "FilterOperation.h" +#include "FractionalLayoutRect.h" #include "LayoutTypes.h" #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127122] trunk/Tools
Title: [127122] trunk/Tools Revision 127122 Author joc...@chromium.org Date 2012-08-30 04:00:55 -0700 (Thu, 30 Aug 2012) Log Message [NRWT] Add support for recognizing arbitrary process names in crash lines https://bugs.webkit.org/show_bug.cgi?id=95435 Reviewed by Adam Barth. When running layout tests in the chromium port using the content shell, we want to be able to report sub-process crashes as well. * Scripts/webkitpy/layout_tests/port/driver.py: (Driver._check_for_driver_crash): * Scripts/webkitpy/layout_tests/port/driver_unittest.py: (DriverTest.test_check_for_driver_crash): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py Diff Modified: trunk/Tools/ChangeLog (127121 => 127122) --- trunk/Tools/ChangeLog 2012-08-30 10:26:19 UTC (rev 127121) +++ trunk/Tools/ChangeLog 2012-08-30 11:00:55 UTC (rev 127122) @@ -1,3 +1,18 @@ +2012-08-30 Jochen Eisinger + +[NRWT] Add support for recognizing arbitrary process names in crash lines +https://bugs.webkit.org/show_bug.cgi?id=95435 + +Reviewed by Adam Barth. + +When running layout tests in the chromium port using the content shell, +we want to be able to report sub-process crashes as well. + +* Scripts/webkitpy/layout_tests/port/driver.py: +(Driver._check_for_driver_crash): +* Scripts/webkitpy/layout_tests/port/driver_unittest.py: +(DriverTest.test_check_for_driver_crash): + 2012-08-29 Zan Dobersek Random test-webkitpy failures on the buildbot Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (127121 => 127122) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-08-30 10:26:19 UTC (rev 127121) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-08-30 11:00:55 UTC (rev 127122) @@ -307,18 +307,17 @@ # See http://trac.webkit.org/changeset/65537. self._crashed_process_name = self._server_process.name() self._crashed_pid = self._server_process.pid() -elif (error_line.startswith("#CRASHED - WebProcess") -or error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess")): +elif (error_line.startswith("#CRASHED - ") +or error_line.startswith("#PROCESS UNRESPONSIVE - ")): # WebKitTestRunner uses this to report that the WebProcess subprocess crashed. -pid = None -m = re.search('pid (\d+)', error_line) -if m: -pid = int(m.group(1)) -self._crashed_process_name = 'WebProcess' +match = re.match('#(?:CRASHED|PROCESS UNRESPONSIVE) - (\S+)', error_line) +self._crashed_process_name = match.group(1) if match else 'WebProcess' +match = re.search('pid (\d+)', error_line) +pid = int(match.group(1)) if match else None self._crashed_pid = pid # FIXME: delete this after we're sure this code is working :) -_log.debug('WebProcess crash, pid = %s, error_line = %s' % (str(pid), error_line)) -if error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess"): +_log.debug('%s crash, pid = %s, error_line = %s' % (self._crashed_process_name, str(pid), error_line)) +if error_line.startswith("#PROCESS UNRESPONSIVE - "): self._subprocess_was_unresponsive = True # We want to show this since it's not a regular crash and probably we don't have a crash log. self.error_from_test += error_line Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py (127121 => 127122) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py 2012-08-30 10:26:19 UTC (rev 127121) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py 2012-08-30 11:00:55 UTC (rev 127122) @@ -221,6 +221,12 @@ driver._crashed_process_name = None driver._crashed_pid = None +driver._server_process = FakeServerProcess(False) +driver._subprocess_was_unresponsive = False +assert_crash(driver, '#CRASHED - renderer (pid 8675)\n', True, 'renderer', 8675) + +driver._crashed_process_name = None +driver._crashed_pid = None driver._server_process = FakeServerProcess(True) driver._subprocess_was_unresponsive = False assert_crash(driver, '', True, 'FakeServerProcess', 1234) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [128224] trunk/Tools
Title: [128224] trunk/Tools Revision 128224 Author joc...@chromium.org Date 2012-09-11 14:03:12 -0700 (Tue, 11 Sep 2012) Log Message [chromium] don't include content shell builders in the garden-o-matic view https://bugs.webkit.org/show_bug.cgi?id=96418 Reviewed by James Robinson. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (128223 => 128224) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-09-11 20:54:05 UTC (rev 128223) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2012-09-11 21:03:12 UTC (rev 128224) @@ -86,7 +86,7 @@ // FIXME: Should garden-o-matic show these? I can imagine showing the deps bots being useful at least so // that the gardener only need to look at garden-o-matic and never at the waterfall. Not really sure who // watches the GPU bots. -return builderName.indexOf('GPU') == -1 && builderName.indexOf('deps') == -1 && builderName.indexOf('ASAN') == -1; +return builderName.indexOf('GPU') == -1 && builderName.indexOf('deps') == -1 && builderName.indexOf('ASAN') == -1 && builderName.indexOf('Content Shell') == -1; }, }, 'gtk' : { Modified: trunk/Tools/ChangeLog (128223 => 128224) --- trunk/Tools/ChangeLog 2012-09-11 20:54:05 UTC (rev 128223) +++ trunk/Tools/ChangeLog 2012-09-11 21:03:12 UTC (rev 128224) @@ -1,3 +1,12 @@ +2012-09-11 Jochen Eisinger + +[chromium] don't include content shell builders in the garden-o-matic view +https://bugs.webkit.org/show_bug.cgi?id=96418 + +Reviewed by James Robinson. + +* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: + 2012-09-11 Adam Klein Garden-o-matic should ignore a wider variety of warnings in buildbot json ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141234] trunk/Source/WebKit/chromium
Title: [141234] trunk/Source/WebKit/chromium Revision 141234 Author joc...@chromium.org Date 2013-01-30 01:37:54 -0800 (Wed, 30 Jan 2013) Log Message [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416) https://bugs.webkit.org/show_bug.cgi?id=108004 http://code.google.com/p/chromium/issues/detail?id=172416 console.debug triggers a NOTREACHED() assertation in Chromium. This is because WebCore::MessageLevel contains 5 levels, including debug, where WebConsoleMessage::Level is missing a "debug" level. Add a WebConsoleMessage::LevelDebug so that it can get passed up to the renderer even if it doesn't make use of that now. Requires another patch to chromium itself to fix chromium bug 172416 but this is a prerequisite. Also add an enum compile time check to AssertMatchingEnums.cpp, Patch by Kevin Day on 2013-01-28 Reviewed by Jochen Eisinger. * public/WebConsoleMessage.h: * src/AssertMatchingEnums.cpp: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::addMessageToConsole): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebConsoleMessage.h trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (141233 => 141234) --- trunk/Source/WebKit/chromium/ChangeLog 2013-01-30 09:28:19 UTC (rev 141233) +++ trunk/Source/WebKit/chromium/ChangeLog 2013-01-30 09:37:54 UTC (rev 141234) @@ -1,3 +1,28 @@ +2013-01-30 Jochen Eisinger + +[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416) +https://bugs.webkit.org/show_bug.cgi?id=108004 +http://code.google.com/p/chromium/issues/detail?id=172416 + +console.debug triggers a NOTREACHED() assertation in Chromium. This +is because WebCore::MessageLevel contains 5 levels, including debug, +where WebConsoleMessage::Level is missing a "debug" level. Add a +WebConsoleMessage::LevelDebug so that it can get passed up to the +renderer even if it doesn't make use of that now. + +Requires another patch to chromium itself to fix chromium bug 172416 +but this is a prerequisite. + +Also add an enum compile time check to AssertMatchingEnums.cpp, + +Patch by Kevin Day on 2013-01-28 +Reviewed by Jochen Eisinger. + +* public/WebConsoleMessage.h: +* src/AssertMatchingEnums.cpp: +* src/WebFrameImpl.cpp: +(WebKit::WebFrameImpl::addMessageToConsole): + 2013-01-30 Xianzhu Wang [Chromium] Correct zoom for focused node when using compositor scaling Modified: trunk/Source/WebKit/chromium/public/WebConsoleMessage.h (141233 => 141234) --- trunk/Source/WebKit/chromium/public/WebConsoleMessage.h 2013-01-30 09:28:19 UTC (rev 141233) +++ trunk/Source/WebKit/chromium/public/WebConsoleMessage.h 2013-01-30 09:37:54 UTC (rev 141234) @@ -40,7 +40,8 @@ LevelTip, LevelLog, LevelWarning, -LevelError +LevelError, +LevelDebug }; Level level; Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (141233 => 141234) --- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2013-01-30 09:28:19 UTC (rev 141233) +++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2013-01-30 09:37:54 UTC (rev 141234) @@ -635,3 +635,9 @@ COMPILE_ASSERT_MATCHING_ENUM(WebURLRequest::PriorityMedium, ResourceLoadPriorityMedium); COMPILE_ASSERT_MATCHING_ENUM(WebURLRequest::PriorityHigh, ResourceLoadPriorityHigh); COMPILE_ASSERT_MATCHING_ENUM(WebURLRequest::PriorityVeryHigh, ResourceLoadPriorityVeryHigh); + +COMPILE_ASSERT_MATCHING_ENUM(WebConsoleMessage::LevelTip, TipMessageLevel); +COMPILE_ASSERT_MATCHING_ENUM(WebConsoleMessage::LevelLog, LogMessageLevel); +COMPILE_ASSERT_MATCHING_ENUM(WebConsoleMessage::LevelWarning, WarningMessageLevel); +COMPILE_ASSERT_MATCHING_ENUM(WebConsoleMessage::LevelError, ErrorMessageLevel); +COMPILE_ASSERT_MATCHING_ENUM(WebConsoleMessage::LevelDebug, DebugMessageLevel); Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (141233 => 141234) --- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-01-30 09:28:19 UTC (rev 141233) +++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2013-01-30 09:37:54 UTC (rev 141234) @@ -837,6 +837,9 @@ case WebConsoleMessage::LevelError: webCoreMessageLevel = ErrorMessageLevel; break; +case WebConsoleMessage::LevelDebug: +webCoreMessageLevel = DebugMessageLevel; +break; default: ASSERT_NOT_REACHED(); return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [141237] trunk/Tools
Title: [141237] trunk/Tools Revision 141237 Author joc...@chromium.org Date 2013-01-30 02:13:22 -0800 (Wed, 30 Jan 2013) Log Message [chromium] move methods from WebTestDelegate to WebTestRunner https://bugs.webkit.org/show_bug.cgi?id=108309 Reviewed by Adam Barth. By moving more logic to the TestRunner library, we can share more code with content shell. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestProxyBase): (WebTestRunner::WebTestProxy::createView): (WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled): (WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled): (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::isSmartInsertDeleteEnabled): (WebTestRunner): (WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled): (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled): (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::createView): (WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled): (WebTestRunner): (WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled): * DumpRenderTree/chromium/TestShell.h: (TestShell): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): (WebViewHost::didStartLoading): (WebViewHost::didStopLoading): (WebViewHost::isSmartInsertDeleteEnabled): (WebViewHost::isSelectTrailingWhitespaceEnabled): (WebViewHost::reset): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.h trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (141236 => 141237) --- trunk/Tools/ChangeLog 2013-01-30 09:50:30 UTC (rev 141236) +++ trunk/Tools/ChangeLog 2013-01-30 10:13:22 UTC (rev 141237) @@ -1,3 +1,48 @@ +2013-01-30 Jochen Eisinger + +[chromium] move methods from WebTestDelegate to WebTestRunner +https://bugs.webkit.org/show_bug.cgi?id=108309 + +Reviewed by Adam Barth. + +By moving more logic to the TestRunner library, we can share more +code with content shell. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::createView): +(WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled): +(WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled): +(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::isSmartInsertDeleteEnabled): +(WebTestRunner): +(WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled): +(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled): +(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::createView): +(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled): +(WebTestRunner): +(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled): +* DumpRenderTree/chromium/TestShell.h: +(TestShell): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::createView): +(WebViewHost::didStartLoading): +(WebViewHost::didStopLoading): +(WebViewHost::isSmartInsertDeleteEnabled): +(WebViewHost::isSelectTrailingWhitespaceEnabled): +(WebViewHost::reset): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-30 Kwang Yul Seo Unreviewed. Add Jae Hyun Park to contributor list. Modified: trunk/Tools/DumpRenderTree/chrom
[webkit-changes] [141298] trunk/Tools
Title: [141298] trunk/Tools Revision 141298 Author joc...@chromium.org Date 2013-01-30 12:46:15 -0800 (Wed, 30 Jan 2013) Log Message [chromium] move custom policy delegate to TestRunner library https://bugs.webkit.org/show_bug.cgi?id=108328 Reviewed by Adam Barth. * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: (WebTestProxyBase): (WebTestRunner::WebTestProxy::decidePolicyForNavigation): * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: (WebTestRunner::WebTestRunner::policyDelegateEnabled): (WebTestRunner::WebTestRunner::policyDelegateIsPermissive): (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::reset): (WebTestRunner::TestRunner::policyDelegateEnabled): (WebTestRunner): (WebTestRunner::TestRunner::policyDelegateIsPermissive): (WebTestRunner::TestRunner::policyDelegateShouldNotifyDone): (WebTestRunner::TestRunner::setCustomPolicyDelegate): (WebTestRunner::TestRunner::waitForPolicyDelegate): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: (WebTestRunner::WebTestProxyBase::decidePolicyForNavigation): (WebTestRunner): * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::decidePolicyForNavigation): (WebViewHost::reset): * DumpRenderTree/chromium/WebViewHost.h: (WebViewHost): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp trunk/Tools/DumpRenderTree/chromium/WebViewHost.h Diff Modified: trunk/Tools/ChangeLog (141297 => 141298) --- trunk/Tools/ChangeLog 2013-01-30 20:42:40 UTC (rev 141297) +++ trunk/Tools/ChangeLog 2013-01-30 20:46:15 UTC (rev 141298) @@ -1,3 +1,37 @@ +2013-01-30 Jochen Eisinger + +[chromium] move custom policy delegate to TestRunner library +https://bugs.webkit.org/show_bug.cgi?id=108328 + +Reviewed by Adam Barth. + +* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: +* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: +(WebTestProxyBase): +(WebTestRunner::WebTestProxy::decidePolicyForNavigation): +* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: +(WebTestRunner::WebTestRunner::policyDelegateEnabled): +(WebTestRunner::WebTestRunner::policyDelegateIsPermissive): +(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: +(WebTestRunner::TestRunner::reset): +(WebTestRunner::TestRunner::policyDelegateEnabled): +(WebTestRunner): +(WebTestRunner::TestRunner::policyDelegateIsPermissive): +(WebTestRunner::TestRunner::policyDelegateShouldNotifyDone): +(WebTestRunner::TestRunner::setCustomPolicyDelegate): +(WebTestRunner::TestRunner::waitForPolicyDelegate): +* DumpRenderTree/chromium/TestRunner/src/TestRunner.h: +(TestRunner): +* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: +(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation): +(WebTestRunner): +* DumpRenderTree/chromium/WebViewHost.cpp: +(WebViewHost::decidePolicyForNavigation): +(WebViewHost::reset): +* DumpRenderTree/chromium/WebViewHost.h: +(WebViewHost): + 2013-01-30 Allan Sandfeld Jensen [Qt][WK1] Support better testing of Web Notifications Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (141297 => 141298) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-01-30 20:42:40 UTC (rev 141297) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h 2013-01-30 20:46:15 UTC (rev 141298) @@ -117,8 +117,6 @@ virtual void closeRemainingWindows() { } virtual int navigationEntryCount() { return 0; } virtual int windowCount() { return 0; } -virtual void setCustomPolicyDelegate(bool, bool) { } -virtual void waitForPolicyDelegate() { } virtual void goToOffset(int) { } virtual void reload() { } virtual void loadURLForFrame(const WebKit::WebURL&, const std::string&) { } Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h (141297 => 141298) --- trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h 2013-01-30 20:42:40 UTC (rev 141297) +++ trunk/Tools/DumpRenderTree/chromium/TestRunner/public/We