[webkit-changes] [238604] trunk

2018-11-28 Thread rwlbuis 
Title: [238604] trunk








Revision 238604
Author rwlb...@webkit.org
Date 2018-11-28 00:28:12 -0800 (Wed, 28 Nov 2018)


Log Message
Block more ports (427, 548, 6697)
https://bugs.webkit.org/show_bug.cgi?id=186092

Reviewed by Frédéric Wang.

Update request-bad-port.html to latest version.

* web-platform-tests/fetch/api/request/request-bad-port-expected.txt:
* web-platform-tests/fetch/api/request/request-bad-port.html:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URL.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (238603 => 238604)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-28 06:53:58 UTC (rev 238603)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-11-28 08:28:12 UTC (rev 238604)
@@ -1,3 +1,15 @@
+2018-11-27  Rob Buis  
+
+Block more ports (427, 548, 6697)
+https://bugs.webkit.org/show_bug.cgi?id=186092
+
+Reviewed by Frédéric Wang.
+
+Update request-bad-port.html to latest version.
+
+* web-platform-tests/fetch/api/request/request-bad-port-expected.txt:
+* web-platform-tests/fetch/api/request/request-bad-port.html:
+
 2018-11-27  Chris Dumez  
 
 Resync service-workers web platform tests from upstream


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt (238603 => 238604)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt	2018-11-28 06:53:58 UTC (rev 238603)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt	2018-11-28 08:28:12 UTC (rev 238604)
@@ -1,131 +1,137 @@
 Blocked access to external URL http://example.com:1/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:1/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:1/ due to access control checks.
 Blocked access to external URL http://example.com:7/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:7/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:7/ due to access control checks.
 Blocked access to external URL http://example.com:9/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:9/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:9/ due to access control checks.
 Blocked access to external URL http://example.com:11/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:11/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:11/ due to access control checks.
 Blocked access to external URL http://example.com:13/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:13/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:13/ due to access control checks.
 Blocked access to external URL http://example.com:15/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:15/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:15/ due to access control checks.
 Blocked access to external URL http://example.com:17/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:17/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:17/ due to access control checks.
 Blocked access to external URL http://example.com:19/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:19/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:19/ due to access control checks.
 Blocked access to external URL http://example.com:20/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:20/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:20/ due to access control checks.
 Blocked access to external URL http://example.com:21/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:21/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:21/ due to access control checks.
 Blocked access to external URL http://example.com:22/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:22/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:22/ due to access control checks.
 Blocked access to external URL http://example.com:23/
-CONSOLE MESSAGE: line 79: Fetch API cannot load http://example.com:23/ due to access control checks.
+CONSOLE MESSAGE: line 80: Fetch API cannot load http://example.com:23/ due to access control checks

[webkit-changes] [236663] trunk

2018-10-01 Thread rwlbuis 
Title: [236663] trunk








Revision 236663
Author rwlb...@webkit.org
Date 2018-10-01 09:17:36 -0700 (Mon, 01 Oct 2018)


Log Message
Patch for landing

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ParsedContentType.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236662 => 236663)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-10-01 16:17:29 UTC (rev 236662)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-10-01 16:17:36 UTC (rev 236663)
@@ -1,3 +1,12 @@
+2018-10-01  Rob Buis  
+
+Align XMLHttpRequest's overrideMimeType() with the standard
+https://bugs.webkit.org/show_bug.cgi?id=169276
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt:
+
 2018-10-01  Chris Dumez  
 
 Make crossOriginObject.then undefined for promises


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt (236662 => 236663)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt	2018-10-01 16:17:29 UTC (rev 236662)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt	2018-10-01 16:17:36 UTC (rev 236663)
@@ -1,5 +1,5 @@
 
 PASS Bogus MIME type does not override encoding 
-FAIL Bogus MIME type does not override encoding, 2 assert_equals: expected "ÿ" but got "\x1a"
+PASS Bogus MIME type does not override encoding, 2 
 PASS Bogus MIME type does override MIME type 
 


Modified: trunk/Source/WebCore/ChangeLog (236662 => 236663)

--- trunk/Source/WebCore/ChangeLog	2018-10-01 16:17:29 UTC (rev 236662)
+++ trunk/Source/WebCore/ChangeLog	2018-10-01 16:17:36 UTC (rev 236663)
@@ -1,3 +1,29 @@
+2018-10-01  Rob Buis  
+
+Align XMLHttpRequest's overrideMimeType() with the standard
+https://bugs.webkit.org/show_bug.cgi?id=169276
+
+Reviewed by Chris Dumez.
+
+Implement the overrideMimeType() as specified in that standard, i.e.
+add a check that the passed mime type is valid and if not fallback
+to application/octet-stream.
+
+In order for this patch to have any effect, I went ahead and
+made an improvement to the ContentType parsing, parseContentType now
+will reject mime types that do not match the type / subtype format, I
+believe this is required by both RFC2045 and mimesniff specs.
+
+This behavior matches Chrome and Firefox.
+
+Test: web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm
+
+* platform/network/ParsedContentType.cpp:
+(WebCore::parseContentType):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::overrideMimeType):
+
+
 2018-10-01  Chris Dumez  
 
 Make crossOriginObject.then undefined for promises


Modified: trunk/Source/WebCore/platform/network/ParsedContentType.cpp (236662 => 236663)

--- trunk/Source/WebCore/platform/network/ParsedContentType.cpp	2018-10-01 16:17:29 UTC (rev 236662)
+++ trunk/Source/WebCore/platform/network/ParsedContentType.cpp	2018-10-01 16:17:36 UTC (rev 236663)
@@ -160,14 +160,32 @@
 return false;
 }
 
+unsigned contentTypeStart = index;
+auto typeRange = parseToken(contentType, index);
+if (!typeRange.second) {
+LOG_ERROR("Invalid Content-Type, invalid type value.");
+return false;
+}
+
+if (contentType[index++] != '/') {
+LOG_ERROR("Invalid Content-Type, missing '/'.");
+return false;
+}
+
+auto subTypeRange = parseToken(contentType, index);
+if (!subTypeRange.second) {
+LOG_ERROR("Invalid Content-Type, invalid subtype value.");
+return false;
+}
+
 // There should not be any quoted strings until we reach the parameters.
-size_t semiColonIndex = contentType.find(';', index);
+size_t semiColonIndex = contentType.find(';', contentTypeStart);
 if (semiColonIndex == notFound) {
-receiver.setContentType(SubstringRange(index, contentTypeLength - index));
+receiver.setContentType(SubstringRange(contentTypeStart, contentTypeLength - contentTypeStart));
 return true;
 }
 
-receiver.setContentType(SubstringRange(index, semiColonIndex - index));
+receiver.setContentType(SubstringRange(contentTypeStart, semiColonIndex - contentTypeStart));
 index = semiColonIndex + 1;
 while (true) {
 skipSpaces(contentType, index);


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (236662 => 236663)

--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2018-10-01 16:17:29 UTC (rev 236662)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2018-10-01 16:17:36 UTC (rev 236663)
@@ -776,12 +776,15 @@
 unsetPendingActivity(this);
 }

[webkit-changes] [236031] trunk

2018-09-15 Thread rwlbuis 
Title: [236031] trunk








Revision 236031
Author rwlb...@webkit.org
Date 2018-09-15 07:08:47 -0700 (Sat, 15 Sep 2018)


Log Message
2018-09-15  Rob Buis  

XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
https://bugs.webkit.org/show_bug.cgi?id=189627

Reviewed by Alexey Proskuryakov.

Right now we return an empty Blob without type when the response is empty, but
it should always include the type [1].

Test: web-platform-tests/xhr/overridemimetype-blob.html

[1] https://xhr.spec.whatwg.org/#blob-response

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createResponseBlob):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/files/xhr-response-blob-expected.txt
trunk/LayoutTests/fast/files/xhr-response-blob.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (236030 => 236031)

--- trunk/LayoutTests/ChangeLog	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/LayoutTests/ChangeLog	2018-09-15 14:08:47 UTC (rev 236031)
@@ -1,3 +1,13 @@
+2018-09-15  Rob Buis  
+
+XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
+https://bugs.webkit.org/show_bug.cgi?id=189627
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/files/xhr-response-blob-expected.txt:
+* fast/files/xhr-response-blob.html:
+
 2018-09-14  Megan Gardner  
 
 Additional tests for conic gradients


Modified: trunk/LayoutTests/fast/files/xhr-response-blob-expected.txt (236030 => 236031)

--- trunk/LayoutTests/fast/files/xhr-response-blob-expected.txt	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/LayoutTests/fast/files/xhr-response-blob-expected.txt	2018-09-15 14:08:47 UTC (rev 236031)
@@ -16,5 +16,5 @@
 PASS xhr.responseType is "blob"
 PASS xhr.response is null
 PASS xhr.response instanceof Blob is true
-PASS xhr.response.type is ""
+PASS xhr.response.type is "application/octet-stream"
 


Modified: trunk/LayoutTests/fast/files/xhr-response-blob.html (236030 => 236031)

--- trunk/LayoutTests/fast/files/xhr-response-blob.html	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/LayoutTests/fast/files/xhr-response-blob.html	2018-09-15 14:08:47 UTC (rev 236031)
@@ -34,7 +34,7 @@
 
 testBlob("resources/UTF8.txt", "text/plain", function() {
 testBlob("resources/does_not_exist.txt", "", function() {
-testBlob("resources/empty-file", "", function() {
+testBlob("resources/empty-file", "application/octet-stream", function() {
 if (window.testRunner)
 testRunner.notifyDone();
 })


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236030 => 236031)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-09-15 14:08:47 UTC (rev 236031)
@@ -1,3 +1,12 @@
+2018-09-15  Rob Buis  
+
+XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
+https://bugs.webkit.org/show_bug.cgi?id=189627
+
+Reviewed by Alexey Proskuryakov.
+
+* web-platform-tests/xhr/overridemimetype-blob-expected.txt:
+
 2018-09-14  Ms2ger  
 
 Remove some obsolete XHR tests


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt (236030 => 236031)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/overridemimetype-blob-expected.txt	2018-09-15 14:08:47 UTC (rev 236031)
@@ -1,5 +1,5 @@
 
-FAIL Use text/xml as fallback MIME type assert_equals: expected "text/xml" but got ""
+PASS Use text/xml as fallback MIME type 
 PASS Use text/xml as fallback MIME type, 2 
 FAIL Loading data… promise_test: Unhandled rejection with value: object "TypeError: undefined is not a function (near '...tests.forEach...')"
 


Modified: trunk/Source/WebCore/ChangeLog (236030 => 236031)

--- trunk/Source/WebCore/ChangeLog	2018-09-15 01:20:27 UTC (rev 236030)
+++ trunk/Source/WebCore/ChangeLog	2018-09-15 14:08:47 UTC (rev 236031)
@@ -1,3 +1,20 @@
+2018-09-15  Rob Buis  
+
+XMLHttpRequest::createResponseBlob() should create a Blob with type for empty response
+https://bugs.webkit.org/show_bug.cgi?id=189627
+
+Reviewed by Alexey Proskuryakov.
+
+Right now we return an empty Blob without type when the response is empty, but
+it should always include the type [1].
+
+Test: web-platform-tests/xhr/overridemimetype-blob.html
+
+[1] https://xhr.spec.whatwg.org/#blob-response
+
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::createResponseBlob):
+
 2018-09-14  Basuke Suzuki

[webkit-changes] [235887] trunk/Tools/Scripts/webkitpy/common/config/contributors.json

2018-09-11 Thread rwlbuis 
Title: [235887] trunk/Tools/Scripts/webkitpy/common/config/contributors.json








Revision 235887
Author rwlb...@webkit.org
Date 2018-09-11 00:10:35 -0700 (Tue, 11 Sep 2018)


Log Message
Unreviewed, add yet another email address to the collection.

Modified Paths

trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (235886 => 235887)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-09-11 05:18:31 UTC (rev 235886)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-09-11 07:10:35 UTC (rev 235887)
@@ -4868,7 +4868,8 @@
  "rwlb...@webkit.org",
  "rob.b...@samsung.com",
  "rb...@blackberry.com",
- "rb...@rim.com"
+ "rb...@rim.com",
+ "rb...@igalia.com"
   ],
   "expertise" : "KDE contributor, The QtWebKit Port, SVG (Scalable Vector Graphics)",
   "nicks" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160770] trunk

2013-12-18 Thread rwlbuis 
Title: [160770] trunk








Revision 160770
Author rwlb...@webkit.org
Date 2013-12-18 09:27:58 -0800 (Wed, 18 Dec 2013)


Log Message
2013-12-18  Rob Buis  

[CSS Shapes] Implement interpolation between keywords in basic shapes
https://bugs.webkit.org/show_bug.cgi?id=125108

Reviewed by Simon Fraser.

Allow blending for all center coordinates since top/left and bottom/right default to correct
Length values of 0% and 100%. For mixed keyword and value positions compute the length's used
for blending to percentages. This is possible since we compute the reference box bounds given the
renderer.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Pass additional RenderBox parameter.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Don't check circle/ellipse center anymore, but do check that both
shapes use the same reference box.
(WebCore::BasicShape::referenceBoxSize): Compute box dimension depending on reference box.
(WebCore::BasicShapeCenterCoordinate::lengthForBlending): Convert to percentage for Bottom/Right.
(WebCore::BasicShapeRectangle::blend):
(WebCore::DeprecatedBasicShapeCircle::blend):
(WebCore::BasicShapeCircle::blend):
(WebCore::DeprecatedBasicShapeEllipse::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInsetRectangle::blend):
(WebCore::BasicShapeInset::blend):
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::blend): Use new lengthForBlending.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt
trunk/LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt
trunk/LayoutTests/fast/shapes/parsing/parsing-test-utils.js
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.h




Diff

Modified: trunk/LayoutTests/ChangeLog (160769 => 160770)

--- trunk/LayoutTests/ChangeLog	2013-12-18 17:26:21 UTC (rev 160769)
+++ trunk/LayoutTests/ChangeLog	2013-12-18 17:27:58 UTC (rev 160770)
@@ -1,3 +1,19 @@
+2013-12-18  Rob Buis  
+
+[CSS Shapes] Implement interpolation between keywords in basic shapes
+https://bugs.webkit.org/show_bug.cgi?id=125108
+
+Reviewed by Simon Fraser.
+
+Add tests to shape-outside-animation when animating using keywords for the circle/ellipse center positions.
+Also add tests for invalid mixing of keyword and values in the center coordinate to parsing-test-utils.js.
+
+* fast/shapes/parsing/parsing-shape-inside-expected.txt:
+* fast/shapes/parsing/parsing-shape-outside-expected.txt:
+* fast/shapes/parsing/parsing-test-utils.js:
+* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
+* fast/shapes/shape-outside-floats/shape-outside-animation.html:
+
 2013-12-18  Dániel Bátyai  
 
 CSS: Null-pointer dereference with negative 'orphans' value.


Modified: trunk/LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt (160769 => 160770)

--- trunk/LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	2013-12-18 17:26:21 UTC (rev 160769)
+++ trunk/LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	2013-12-18 17:27:58 UTC (rev 160770)
@@ -191,6 +191,8 @@
 PASS getComputedStyleValue("-webkit-shape-inside", "circle(10px at 10px 10px at center)") is "auto"
 PASS getCSSText("-webkit-shape-inside", "circle(10px at center center 10px)") is ""
 PASS getComputedStyleValue("-webkit-shape-inside", "circle(10px at center center 10px)") is "auto"
+PASS getCSSText("-webkit-shape-inside", "circle(10px at 10% left)") is ""
+PASS getComputedStyleValue("-webkit-shape-inside", "circle(10px at 10% left)") is "auto"
 PASS getCSSText("-webkit-shape-inside", "circle(at 10px 10px 10px)") is ""
 PASS getComputedStyleValue("-webkit-shape-inside", "circle(at 10px 10px 10px)") is "auto"
 PASS getCSSText("-webkit-shape-inside", "circle(at 10px 10px at center)") is ""
@@ -211,6 +213,8 @@
 PASS getComputedStyleValue("-webkit-shape-inside", "ellipse(10px at 10px 10px at center)") is "auto"
 PASS getCSSText("-webkit-shape-inside", "ellipse(10px at center center 10px)") is ""
 PASS getComputedStyleValue("-webkit-shape-inside", "ellipse(10px at center center 10px)") is "auto"
+PASS getCSSText("-webkit-shape-inside", "ellipse(10px 10px at 10% left)") is ""
+PASS getComputedStyleValue("-webkit-shape-inside", "ellipse(10px 10px at 10% left)") is "auto"
 PASS getCSSText("-webkit-shape-inside", "ellipse(10px 20px 30px a

[webkit-changes] [160689] trunk/Tools

2013-12-16 Thread rwlbuis 
Title: [160689] trunk/Tools








Revision 160689
Author rwlb...@webkit.org
Date 2013-12-16 18:43:52 -0800 (Mon, 16 Dec 2013)


Log Message
Add my Samsung email address.

Unreviewed.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (160688 => 160689)

--- trunk/Tools/ChangeLog	2013-12-17 02:43:26 UTC (rev 160688)
+++ trunk/Tools/ChangeLog	2013-12-17 02:43:52 UTC (rev 160689)
@@ -1,3 +1,11 @@
+2013-12-16  Rob Buis  
+
+Add my Samsung email address.
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2013-12-16  Oliver Hunt  
 
 Cache getters and custom accessors on the prototype chain


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (160688 => 160689)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2013-12-17 02:43:26 UTC (rev 160688)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2013-12-17 02:43:52 UTC (rev 160689)
@@ -4143,6 +4143,7 @@
  "emails" : [
 "rwlb...@gmail.com",
 "rwlb...@webkit.org",
+"rob.b...@samsung.com",
 "rb...@blackberry.com",
 "rb...@rim.com"
  ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160623] trunk

2013-12-15 Thread rwlbuis 
Title: [160623] trunk








Revision 160623
Author rwlb...@webkit.org
Date 2013-12-15 14:34:08 -0800 (Sun, 15 Dec 2013)


Log Message
[CSS Shapes] shape-outside animation does not handle 'auto' well
https://bugs.webkit.org/show_bug.cgi?id=125700

Reviewed by Dirk Schulze.

Source/WebCore:

Handle the case where we are blending/animating with a null ShapeValue due to 'auto'.

Adapted LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html for testing this.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):

LayoutTests:

Test a shape-outside animation where one keyframe uses 'auto'.

* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
* fast/shapes/shape-outside-floats/shape-outside-animation.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (160622 => 160623)

--- trunk/LayoutTests/ChangeLog	2013-12-15 21:13:54 UTC (rev 160622)
+++ trunk/LayoutTests/ChangeLog	2013-12-15 22:34:08 UTC (rev 160623)
@@ -1,3 +1,15 @@
+2013-12-15  Rob Buis  
+
+[CSS Shapes] shape-outside animation does not handle 'auto' well
+https://bugs.webkit.org/show_bug.cgi?id=125700
+
+Reviewed by Dirk Schulze.
+
+Test a shape-outside animation where one keyframe uses 'auto'.
+
+* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
+* fast/shapes/shape-outside-floats/shape-outside-animation.html:
+
 2013-12-14  Darin Adler  
 
 Crash in CSSImageGeneratorValue and RenderScrollbar


Modified: trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt (160622 => 160623)

--- trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt	2013-12-15 21:13:54 UTC (rev 160622)
+++ trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt	2013-12-15 22:34:08 UTC (rev 160623)
@@ -3,9 +3,11 @@
 Moving Text
 Moving Text
 Moving Text
+Moving Text
 PASS - "webkitShapeOutside" property for "rectangle-box" element at 1s saw something close to: rectangle(10%, 10%, 80%, 80%, 0px, 0px)
 PASS - "webkitShapeOutside" property for "circle-box" element at 1s saw something close to: circle(35% at 35% 35%)
 PASS - "webkitShapeOutside" property for "ellipse-box" element at 1s saw something close to: ellipse(35% 30% at 35% 35%)
 PASS - "webkitShapeOutside" property for "polygon-box" element at 1s saw something close to: polygon(nonzero, 10% 10%, 90% 10%, 90% 90%, 10% 90%)
 PASS - "webkitShapeOutside" property for "polygon2-box" element at 1s saw something close to: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%)
+PASS - "webkitShapeOutside" property for "circle-auto-box" element at 1s saw something close to: circle(50% at 50% 50%)
 


Modified: trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html (160622 => 160623)

--- trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html	2013-12-15 21:13:54 UTC (rev 160622)
+++ trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html	2013-12-15 22:34:08 UTC (rev 160623)
@@ -34,6 +34,10 @@
   -webkit-animation: polygon2-anim 2s linear
 }
 
+#circle-auto-box {
+  -webkit-animation: circle-auto-anim 2s linear
+}
+
 @-webkit-keyframes rectangle-anim {
 from { -webkit-shape-outside: rectangle(0%, 0%, 100%, 100%); }
 to   { -webkit-shape-outside: rectangle(20%, 20%, 60%, 60%); }
@@ -59,6 +63,11 @@
 to   { -webkit-shape-outside: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80%); }
 }
 
+@-webkit-keyframes circle-auto-anim {
+from { -webkit-shape-outside: auto }
+to   { -webkit-shape-outside: circle(50% at 50% 50%); }
+}
+

[webkit-changes] [160544] trunk

2013-12-13 Thread rwlbuis 
Title: [160544] trunk








Revision 160544
Author rwlb...@webkit.org
Date 2013-12-13 06:13:26 -0800 (Fri, 13 Dec 2013)


Log Message
Clean up SVGScriptElement
https://bugs.webkit.org/show_bug.cgi?id=125527

Reviewed by Darin Adler.

Source/WebCore:

>From the Blink port of this bug it becomes clear that svg/dom/SVGScriptElement/script-set-href.svg and
svg/dom/svg-element-attribute-js-null.xhtml still hit an assert in Debug because SVGNames::typeAttr can't
be used with fastGetAttribute in all cases, because it can be animatable. However for SVGScriptElement
it is not animatable, so make isAnimatableAttribute virtual (note Debug only method) and allow typeAttr
in the SVGScriptElement case to be useable for fastGetAttribute.

Test: svg/dom/SVGScriptElement/script-type-attribute.svg

* svg/SVGElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isAnimatableAttribute):
* svg/SVGScriptElement.h:

LayoutTests:

Add test to verify the new type getter/setter behavior on SVScriptElement.
Specifically, the old behavior was setting the JS type property did not reflect in
the actual content attribute being set, the new behavior is to do set the content
attribute when setting the JS type property.

* svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
* svg/dom/SVGScriptElement/script-type-attribute.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.h
trunk/Source/WebCore/svg/SVGScriptElement.cpp
trunk/Source/WebCore/svg/SVGScriptElement.h


Added Paths

trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute-expected.txt
trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (160543 => 160544)

--- trunk/LayoutTests/ChangeLog	2013-12-13 12:40:06 UTC (rev 160543)
+++ trunk/LayoutTests/ChangeLog	2013-12-13 14:13:26 UTC (rev 160544)
@@ -1,3 +1,18 @@
+2013-12-13  Rob Buis  
+
+Clean up SVGScriptElement
+https://bugs.webkit.org/show_bug.cgi?id=125527
+
+Reviewed by Darin Adler.
+
+Add test to verify the new type getter/setter behavior on SVScriptElement.
+Specifically, the old behavior was setting the JS type property did not reflect in
+the actual content attribute being set, the new behavior is to do set the content
+attribute when setting the JS type property.
+
+* svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
+* svg/dom/SVGScriptElement/script-type-attribute.svg: Added.
+
 2013-12-13  Michał Pakuła vel Rutka  
 
 Unreviewed EFL gardening


Added: trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute-expected.txt (0 => 160544)

--- trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute-expected.txt	2013-12-13 14:13:26 UTC (rev 160544)
@@ -0,0 +1,3 @@
+Test that getting/setting the type JS property on SVGScriptElement keeps sync with the type content attribute.
+
+PASS


Added: trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute.svg (0 => 160544)

--- trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute.svg	(rev 0)
+++ trunk/LayoutTests/svg/dom/SVGScriptElement/script-type-attribute.svg	2013-12-13 14:13:26 UTC (rev 160544)
@@ -0,0 +1,24 @@
+
+
+function test() {
+if (window.testRunner) {
+testRunner.dumpAsText();
+}
+
+var script = document.createElementNS("http://www.w3.org/2000/svg", "svg:script");
+script.type = "text/_javascript_";
+if (script.type != "text/_javascript_" || script.getAttribute("type") != "text/_javascript_") {
+document.getElementById("p0").innerHTML = "FAIL";
+return;
+}
+
+script.setAttribute("type", "text/fooscript");
+if (script.type != "text/fooscript" || script.getAttribute("type") != "text/fooscript")
+document.getElementById("p0").innerHTML = "FAIL";
+}
+
+
+Test that getting/setting the type JS property on SVGScriptElement keeps sync with the type content attribute.
+PASS
+
+


Modified: trunk/Source/WebCore/ChangeLog (160543 => 160544)

--- trunk/Source/WebCore/ChangeLog	2013-12-13 12:40:06 UTC (rev 160543)
+++ trunk/Source/WebCore/ChangeLog	2013-12-13 14:13:26 UTC (rev 160544)
@@ -1,3 +1,23 @@
+2013-12-13  Rob Buis  
+
+Clean up SVGScriptElement
+https://bugs.webkit.org/show_bug.cgi?id=125527
+
+Reviewed by Darin Adler.
+
+From the Blink port of this bug it becomes clear that svg/dom/SVGScriptElement/script-set-href.svg and
+svg/dom/svg-element-attribute-js-null.xhtml still hit an assert in Debug because SVGNames::typeAttr can't
+be used with fastGetAttribute in all cases, because it can be animatable. However for SVGScriptElement
+it is not animatable, so make isAnimatableAttribute virtual (note Debug only method) and

[webkit-changes] [160429] trunk

2013-12-11 Thread rwlbuis 
Title: [160429] trunk








Revision 160429
Author rwlb...@webkit.org
Date 2013-12-11 05:38:59 -0800 (Wed, 11 Dec 2013)


Log Message
[CSS Shapes] Take into account fill-rule for polygon interpolation
https://bugs.webkit.org/show_bug.cgi?id=125508

Reviewed by Dirk Schulze.

Source/WebCore:

Implement the polygon fill-rule part of http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation.

Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html.

* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):

LayoutTests:

Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html so it also tests polygon animation
when using different fill rules.

* animations/resources/animation-test-helpers.js:
(parseBasicShape): also allow evenodd when parsing the polygon
* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
* fast/shapes/shape-outside-floats/shape-outside-animation.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/resources/animation-test-helpers.js
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/BasicShapes.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (160428 => 160429)

--- trunk/LayoutTests/ChangeLog	2013-12-11 12:42:50 UTC (rev 160428)
+++ trunk/LayoutTests/ChangeLog	2013-12-11 13:38:59 UTC (rev 160429)
@@ -1,3 +1,18 @@
+2013-12-11  Rob Buis  
+
+[CSS Shapes] Take into account fill-rule for polygon interpolation
+https://bugs.webkit.org/show_bug.cgi?id=125508
+
+Reviewed by Dirk Schulze.
+
+Adapt fast/shapes/shape-outside-floats/shape-outside-animation.html so it also tests polygon animation
+when using different fill rules.
+
+* animations/resources/animation-test-helpers.js:
+(parseBasicShape): also allow evenodd when parsing the polygon
+* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
+* fast/shapes/shape-outside-floats/shape-outside-animation.html:
+
 2013-12-11  Michal Poteralski  
 
 Test results of postMessage-clone-port-error.html test are broken


Modified: trunk/LayoutTests/animations/resources/animation-test-helpers.js (160428 => 160429)

--- trunk/LayoutTests/animations/resources/animation-test-helpers.js	2013-12-11 12:42:50 UTC (rev 160428)
+++ trunk/LayoutTests/animations/resources/animation-test-helpers.js	2013-12-11 13:38:59 UTC (rev 160429)
@@ -222,7 +222,7 @@
 matches = s.match("ellipse\\((.*)\\s+(.*)\\s+at\\s+(.*)\\s+(.*)\\)");
 break;
 case "polygon":
-matches = s.match("polygon\\(nonzero, (.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\)");
+matches = s.match("polygon\\((evenodd|nonzero), (.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\s*,\\s*(.*)\\s+(.*)\\)");
 break;
 default:
 return null;
@@ -232,9 +232,12 @@
 return null;
 
 matches.shift();
+var i = 0;
+if (shapeFunction[1] == "polygon")
+i++; // skip nonzero|evenodd below
 
 // Normalize percentage values.
-for (var i = 0; i < matches.length; ++i) {
+for (; i < matches.length; ++i) {
 var param = matches[i];
 matches[i] = parseFloat(matches[i]);
 if (param.indexOf('%') != -1)
@@ -309,7 +312,13 @@
 if (paramList1.shape != paramList2.shape
 || paramList1.params.length != paramList2.params.length)
 return false;
-for (var i = 0; i < paramList1.params.length; ++i) {
+var i = 0;
+if (paramList1.shape == "polygon") {
+if (paramList1.params[0] != paramList2.params[0])
+return false; // fill-rule's don't match
+i++;
+}
+for (; i < paramList1.params.length; ++i) {
 var param1 = paramList1.params[i], 
 param2 = paramList2.params[i];
 var match = isCloseEnough(param1, param2, tolerance);


Modified: trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt (160428 => 160429)

--- trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt	2013-12-11 12:42:50 UTC (rev 160428)
+++ trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt	2013-12-11 13:38:59 UTC (rev 160429)
@@ -2,8 +2,10 @@
 Moving Text
 Moving Text
 Moving Text
+Moving Text
 PASS - "webkitShapeOutside" property for "rectangle-box" element at 1s saw something close to: rectangle(10%, 10%, 80%, 80%, 0px, 0px)
 PASS - "webkitShapeOutside" property for "circle-box" element at 1s saw something close to: circle(35% at 35% 35%)
 PASS - "webkitShapeOutside" property for "ellipse-box" element at 1s saw something close to: ellipse(35% 30% at 35% 35%)
 PASS - "webkitShapeOutside" property for "polygon-box" element at 1s saw something close to: polygon(nonzero, 10% 10%

[webkit-changes] [160009] trunk/Source/WebCore

2013-12-03 Thread rwlbuis 
Title: [160009] trunk/Source/WebCore








Revision 160009
Author rwlb...@webkit.org
Date 2013-12-03 09:26:36 -0800 (Tue, 03 Dec 2013)


Log Message
Fix build break after r160007.

* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/BasicShapes.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (160008 => 160009)

--- trunk/Source/WebCore/ChangeLog	2013-12-03 17:25:54 UTC (rev 160008)
+++ trunk/Source/WebCore/ChangeLog	2013-12-03 17:26:36 UTC (rev 160009)
@@ -1,5 +1,12 @@
 2013-12-03  Rob Buis  
 
+Fix build break after r160007.
+
+* rendering/style/BasicShapes.cpp:
+(WebCore::BasicShape::canBlend):
+
+2013-12-03  Rob Buis  
+
 [css shapes] layout for new ellipse syntax
 https://bugs.webkit.org/show_bug.cgi?id=124621
 


Modified: trunk/Source/WebCore/rendering/style/BasicShapes.cpp (160008 => 160009)

--- trunk/Source/WebCore/rendering/style/BasicShapes.cpp	2013-12-03 17:25:54 UTC (rev 160008)
+++ trunk/Source/WebCore/rendering/style/BasicShapes.cpp	2013-12-03 17:26:36 UTC (rev 160009)
@@ -65,11 +65,10 @@
 
 const BasicShapeEllipse* thisEllipse = static_cast(this);
 const BasicShapeEllipse* otherEllipse = static_cast(other);
-if (!thisEllipse->radiusX().canBlend(otherEllipse->radiusX())
-|| !thisEllipse->radiusY().canBlend(otherEllipse->radiusY())
-|| !thisEllipse->centerX().canBlend(otherEllipse->centerX())
-|| !thisEllipse->centerY().canBlend(otherEllipse->centerY()))
-return false;
+return (thisEllipse->radiusX().canBlend(otherEllipse->radiusX())
+&& thisEllipse->radiusY().canBlend(otherEllipse->radiusY())
+&& thisEllipse->centerX().canBlend(otherEllipse->centerX())
+&& thisEllipse->centerY().canBlend(otherEllipse->centerY()));
 }
 
 void BasicShapeRectangle::path(Path& path, const FloatRect& boundingBox)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160007] trunk

2013-12-03 Thread rwlbuis 
Title: [160007] trunk








Revision 160007
Author rwlb...@webkit.org
Date 2013-12-03 09:18:01 -0800 (Tue, 03 Dec 2013)


Log Message
[css shapes] layout for new ellipse syntax
https://bugs.webkit.org/show_bug.cgi?id=124621

Source/WebCore:

Reviewed by Dirk Schulze.

Implement support for doing layout with the new ellipse shape syntax,
including basic animation support.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html

* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Convert new ellipse to a layout shape.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Ignore ellipses with values that
cannot be interpolated.
(WebCore::BasicShapeEllipse::floatValueForRadiusInBox): Helper function to calculate
either radiusX or radiusY, shared by clip-path and shape code paths.
(WebCore::BasicShapeEllipse::path):
* rendering/style/BasicShapes.h:

LayoutTests:

Add a new test for the new ellipse syntax. Also update existing shape-inside, animation, and clip-path tests to
test the new ellipse syntax for clipping and shape-inside.

Reviewed by Dirk Schulze.

* animations/resources/animation-test-helpers.js:
(parseBasicShape):
* css3/masking/clip-path-animation-expected.txt:
* css3/masking/clip-path-animation.html:
* css3/masking/clip-path-ellipse.html:
* fast/shapes/shape-inside/shape-inside-animation-expected.txt:
* fast/shapes/shape-inside/shape-inside-animation.html:
* fast/shapes/shape-inside/shape-inside-ellipse-padding.html:
* fast/shapes/shape-inside/shape-inside-ellipse.html:
* fast/shapes/shape-inside/shape-inside-empty-expected.html:
* fast/shapes/shape-inside/shape-inside-empty.html:
* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
* fast/shapes/shape-outside-floats/shape-outside-animation.html:
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/resources/animation-test-helpers.js
trunk/LayoutTests/css3/masking/clip-path-animation-expected.txt
trunk/LayoutTests/css3/masking/clip-path-animation.html
trunk/LayoutTests/css3/masking/clip-path-ellipse.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-animation-expected.txt
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse-padding.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-ellipse.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html
trunk/LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/shapes/Shape.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.h


Added Paths

trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html
trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html




Diff

Modified: trunk/LayoutTests/ChangeLog (160006 => 160007)

--- trunk/LayoutTests/ChangeLog	2013-12-03 17:15:18 UTC (rev 160006)
+++ trunk/LayoutTests/ChangeLog	2013-12-03 17:18:01 UTC (rev 160007)
@@ -1,3 +1,29 @@
+2013-12-03  Rob Buis  
+
+[css shapes] layout for new ellipse syntax
+https://bugs.webkit.org/show_bug.cgi?id=124621
+
+Add a new test for the new ellipse syntax. Also update existing shape-inside, animation, and clip-path tests to
+test the new ellipse syntax for clipping and shape-inside.
+
+Reviewed by Dirk Schulze.
+
+* animations/resources/animation-test-helpers.js:
+(parseBasicShape):
+* css3/masking/clip-path-animation-expected.txt:
+* css3/masking/clip-path-animation.html:
+* css3/masking/clip-path-ellipse.html:
+* fast/shapes/shape-inside/shape-inside-animation-expected.txt:
+* fast/shapes/shape-inside/shape-inside-animation.html:
+* fast/shapes/shape-inside/shape-inside-ellipse-padding.html:
+* fast/shapes/shape-inside/shape-inside-ellipse.html:
+* fast/shapes/shape-inside/shape-inside-empty-expected.html:
+* fast/shapes/shape-inside/shape-inside-empty.html:
+* fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
+* fast/shapes/shape-outside-floats/shape-outside-animation.html:
+* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000-expected.html: Added.
+* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html: Added.
+
 2013-12-03  Frédéric Wang  
 
 Add an MathMLSelectElement class to implement  and .


Modified: trunk/LayoutTests/animations/resources/animation-test-hel

[webkit-changes] [154932] trunk

2013-08-31 Thread rwlbuis 
Title: [154932] trunk








Revision 154932
Author rwlb...@webkit.org
Date 2013-08-31 14:05:58 -0700 (Sat, 31 Aug 2013)


Log Message
XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
https://bugs.webkit.org/show_bug.cgi?id=120490

Reviewed by Ryosuke Niwa.

Source/WebCore:

Retain the key of the namespaces map by using AtomicString as key instead of AtomicStringImpl*.

* editing/MarkupAccumulator.h:

LayoutTests:

Unskip these previously failing tests.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MarkupAccumulator.h




Diff

Modified: trunk/LayoutTests/ChangeLog (154931 => 154932)

--- trunk/LayoutTests/ChangeLog	2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/LayoutTests/ChangeLog	2013-08-31 21:05:58 UTC (rev 154932)
@@ -1,3 +1,14 @@
+2013-08-31  Rob Buis  
+
+XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
+https://bugs.webkit.org/show_bug.cgi?id=120490
+
+Reviewed by Ryosuke Niwa.
+
+Unskip these previously failing tests.
+
+* TestExpectations:
+
 2013-08-30  Simon Fraser  
 
 Fix the Mac results.


Modified: trunk/LayoutTests/TestExpectations (154931 => 154932)

--- trunk/LayoutTests/TestExpectations	2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/LayoutTests/TestExpectations	2013-08-31 21:05:58 UTC (rev 154932)
@@ -38,8 +38,3 @@
 # This test will run slowly in debug mode, but is plenty fast in release.
 [ Debug ] fast/js/regress/emscripten-memops.html [ Skip ]
 
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html [ Skip ]
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html [ Skip ]
-[ Debug ] webkit.org/b/120490 fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html [ Skip ]
-[ Debug ] webkit.org/b/120490 svg/custom/xlink-prefix-generation-in-attributes.html [ Skip ]
-


Modified: trunk/Source/WebCore/ChangeLog (154931 => 154932)

--- trunk/Source/WebCore/ChangeLog	2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/Source/WebCore/ChangeLog	2013-08-31 21:05:58 UTC (rev 154932)
@@ -1,3 +1,14 @@
+2013-08-31  Rob Buis  
+
+XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
+https://bugs.webkit.org/show_bug.cgi?id=120490
+
+Reviewed by Ryosuke Niwa.
+
+Retain the key of the namespaces map by using AtomicString as key instead of AtomicStringImpl*.
+
+* editing/MarkupAccumulator.h:
+
 2013-08-31  Andreas Kling  
 
 InlineBox::renderer() and pals should return references.


Modified: trunk/Source/WebCore/editing/MarkupAccumulator.h (154931 => 154932)

--- trunk/Source/WebCore/editing/MarkupAccumulator.h	2013-08-31 18:34:23 UTC (rev 154931)
+++ trunk/Source/WebCore/editing/MarkupAccumulator.h	2013-08-31 21:05:58 UTC (rev 154932)
@@ -39,7 +39,7 @@
 class Node;
 class Range;
 
-typedef HashMap Namespaces;
+typedef HashMap Namespaces;
 
 enum EntityMask {
 EntityAmp = 0x0001,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154896] trunk

2013-08-30 Thread rwlbuis 
Title: [154896] trunk








Revision 154896
Author rwlb...@webkit.org
Date 2013-08-30 10:51:53 -0700 (Fri, 30 Aug 2013)


Log Message
SVG error parsing empty path
https://bugs.webkit.org/show_bug.cgi?id=78980

Reviewed by Darin Adler.

Source/WebCore:

According to the spec (http://www.w3.org/TR/SVG/paths.html#PathData), path 'd' attribute can be empty.
No error should be reported in this case.

* svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::parsePathDataFromSource):
* svg/SVGPathUtilities.cpp:
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):

LayoutTests:

Adapt fuzz-path-parser.html and dynamic-empty-path.svg to also test empty paths.
Adjust expectations to not expect an error message for empty paths.

* platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/gtk/svg/custom/dynamic-empty-path-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/qt/svg/custom/dynamic-empty-path-expected.txt:
* svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* svg/custom/dynamic-empty-path-expected.txt:
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/fuzz-path-parser.html: also test empty path
* svg/dom/path-parser-expected.txt:
* svg/dom/script-tests/path-parser.js: also test empty path

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt
trunk/LayoutTests/platform/gtk/svg/custom/dynamic-empty-path-expected.txt
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt
trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/dynamic-empty-path-expected.txt
trunk/LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt
trunk/LayoutTests/svg/custom/dynamic-empty-path-expected.txt
trunk/LayoutTests/svg/dom/fuzz-path-parser-expected.txt
trunk/LayoutTests/svg/dom/fuzz-path-parser.html
trunk/LayoutTests/svg/dom/path-parser-expected.txt
trunk/LayoutTests/svg/dom/script-tests/path-parser.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGPathParser.cpp
trunk/Source/WebCore/svg/SVGPathUtilities.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (154895 => 154896)

--- trunk/LayoutTests/ChangeLog	2013-08-30 17:50:52 UTC (rev 154895)
+++ trunk/LayoutTests/ChangeLog	2013-08-30 17:51:53 UTC (rev 154896)
@@ -1,3 +1,25 @@
+2013-08-30  Rob Buis  
+
+SVG error parsing empty path
+https://bugs.webkit.org/show_bug.cgi?id=78980
+
+Reviewed by Darin Adler.
+
+Adapt fuzz-path-parser.html and dynamic-empty-path.svg to also test empty paths.
+Adjust expectations to not expect an error message for empty paths.
+
+* platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
+* platform/gtk/svg/custom/dynamic-empty-path-expected.txt:
+* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
+* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
+* platform/qt/svg/custom/dynamic-empty-path-expected.txt:
+* svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
+* svg/custom/dynamic-empty-path-expected.txt:
+* svg/dom/fuzz-path-parser-expected.txt:
+* svg/dom/fuzz-path-parser.html: also test empty path
+* svg/dom/path-parser-expected.txt:
+* svg/dom/script-tests/path-parser.js: also test empty path
+
 2013-08-30  Arpita Bahuguna  
 
 setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.


Modified: trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt (154895 => 154896)

--- trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt	2013-08-30 17:50:52 UTC (rev 154895)
+++ trunk/LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt	2013-08-30 17:51:53 UTC (rev 154896)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 267: Error: Problem parsing d=""
 layer at (0,0) size 480x360
   RenderView at (0,0) size 480x360
 layer at (0,0) size 480x360


Modified: trunk/LayoutTests/platform/gtk/svg/custom/dynamic-empty-path-expected.txt (154895 => 154896)

--- trunk/LayoutTests/platform/gtk/svg/custom/dynamic-empty-path-expected.txt	2013-08-30 17:50:52 UTC (rev 154895)
+++ trunk/LayoutTests/platform/gtk/svg/custom/dynamic-empty-path-expected.txt	2013-08-30 17:51:53 UTC (rev 154896)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: line 9: Error: Problem parsing d=""
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 151x151


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/paths-dom

[webkit-changes] [154779] trunk

2013-08-28 Thread rwlbuis 
Title: [154779] trunk








Revision 154779
Author rwlb...@webkit.org
Date 2013-08-28 15:25:19 -0700 (Wed, 28 Aug 2013)


Log Message
Namespace prefix is blindly followed when serializing
https://bugs.webkit.org/show_bug.cgi?id=19121
Serializer doesn't handling inconsistent prefixes properly
https://bugs.webkit.org/show_bug.cgi?id=117764
Attribute namespaces are serialized as if they were element ones
https://bugs.webkit.org/show_bug.cgi?id=22958

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add code to make sure unique prefixes and namespace declarations are generated.
Unique prefix generation happens when:
- the same prefix is used to map to different namespaces or
- no prefix is given but the attribute is in a namespace.

This is done in order to not violate constraints listed in http://www.w3.org/TR/xml-names11/. In general
the pseudo code listed in http://www.w3.org/TR/DOM-Level-3-Core/namespaces-algorithms.html#normalizeDocumentAlgo
is used, doing the following for attributes:
if the attribute has a namespace then
  if the attribute has no prefix OR prefix is not declared OR conflicts with existing prefix mapping to different NS then
try to find the matching in-scope declaration by looking up the prefix in the namespace -> prefix mapping, if found use that prefix
else if the attribute prefix is not null AND not mapped in-scope, declare the prefix
else generate a unique prefix for the namespace

To keep track of in-scope namespaces a prefix to namespace mapping is used.

Tests: fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html
   fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html
   fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html
   svg/custom/xlink-prefix-generation-in-attributes.html

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::generateUniquePrefix):
(WebCore::MarkupAccumulator::appendAttribute):
* editing/MarkupAccumulator.h:

LayoutTests:

Add tests to make sure unique prefixes and namespace declarations are generated for the
case when the same prefix is used to map to different namespaces. All testcases are based
on the testcases attached to the bugs.

* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt: Added.
* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html: Added.
* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.txt: Added.
* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html: Added.
* fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix-expected.txt: Added.
* fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html: Added.
* svg/custom/xlink-prefix-generation-in-attributes-expected.txt: Added.
* svg/custom/xlink-prefix-generation-in-attributes.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MarkupAccumulator.cpp
trunk/Source/WebCore/editing/MarkupAccumulator.h


Added Paths

trunk/LayoutTests/fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html
trunk/LayoutTests/fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html
trunk/LayoutTests/fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix-expected.txt
trunk/LayoutTests/fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html
trunk/LayoutTests/svg/custom/xlink-prefix-generation-in-attributes-expected.txt
trunk/LayoutTests/svg/custom/xlink-prefix-generation-in-attributes.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154778 => 154779)

--- trunk/LayoutTests/ChangeLog	2013-08-28 22:19:25 UTC (rev 154778)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 22:25:19 UTC (rev 154779)
@@ -1,3 +1,27 @@
+2013-08-28  Rob Buis  
+
+Namespace prefix is blindly followed when serializing
+https://bugs.webkit.org/show_bug.cgi?id=19121
+Serializer doesn't handling inconsistent prefixes properly
+https://bugs.webkit.org/show_bug.cgi?id=117764
+Attribute namespaces are serialized as if they were element ones
+https://bugs.webkit.org/show_bug.cgi?id=22958
+
+Reviewed by Ryosuke Niwa.
+
+Add tests to make sure unique prefixes and namespace declarations are generated for the
+case when the same prefix is used to map to different namespaces. All testcases are based
+on the testcases attached to the bugs.
+
+* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts-expected.txt: Added.
+* fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html: Added.
+* fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict-expected.

[webkit-changes] [154713] trunk

2013-08-27 Thread rwlbuis 
Title: [154713] trunk








Revision 154713
Author rwlb...@webkit.org
Date 2013-08-27 16:09:28 -0700 (Tue, 27 Aug 2013)


Log Message
feImage fails if referenced node contains radialGradient declaration
https://bugs.webkit.org/show_bug.cgi?id=118735

Reviewed by Darin Adler.

Source/WebCore:

Only call parent's updateRelativeLengthsInformation for graphics elements.

Tests: svg/custom/feImage-pserver-with-percentage-expected.svg
   svg/custom/feImage-pserver-with-percentage.svg

* svg/SVGElement.cpp:
(WebCore::SVGElement::updateRelativeLengthsInformation):

LayoutTests:

Add testcase from bug with small adjustments.

* svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
* svg/custom/feImage-pserver-with-percentage.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp


Added Paths

trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage-expected.svg
trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (154712 => 154713)

--- trunk/LayoutTests/ChangeLog	2013-08-27 22:25:19 UTC (rev 154712)
+++ trunk/LayoutTests/ChangeLog	2013-08-27 23:09:28 UTC (rev 154713)
@@ -1,3 +1,15 @@
+2013-08-27  Rob Buis  
+
+feImage fails if referenced node contains radialGradient declaration
+https://bugs.webkit.org/show_bug.cgi?id=118735
+
+Reviewed by Darin Adler.
+
+Add testcase from bug with small adjustments.
+
+* svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
+* svg/custom/feImage-pserver-with-percentage.svg: Added.
+
 2013-08-27  Chris Fleizach  
 
  AX:  contents are exposed as static text


Added: trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage-expected.svg (0 => 154713)

--- trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage-expected.svg	(rev 0)
+++ trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage-expected.svg	2013-08-27 23:09:28 UTC (rev 154713)
@@ -0,0 +1,14 @@
+
+  
+
+  
+
+  
+  
+
+  
+
+  
+
+  
+


Added: trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage.svg (0 => 154713)

--- trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage.svg	(rev 0)
+++ trunk/LayoutTests/svg/custom/feImage-pserver-with-percentage.svg	2013-08-27 23:09:28 UTC (rev 154713)
@@ -0,0 +1,15 @@
+
+  
+
+  
+
+
+
+
+  
+
+
+  
+
+  
+


Modified: trunk/Source/WebCore/ChangeLog (154712 => 154713)

--- trunk/Source/WebCore/ChangeLog	2013-08-27 22:25:19 UTC (rev 154712)
+++ trunk/Source/WebCore/ChangeLog	2013-08-27 23:09:28 UTC (rev 154713)
@@ -1,3 +1,18 @@
+2013-08-27  Rob Buis  
+
+feImage fails if referenced node contains radialGradient declaration
+https://bugs.webkit.org/show_bug.cgi?id=118735
+
+Reviewed by Darin Adler.
+
+Only call parent's updateRelativeLengthsInformation for graphics elements.
+
+Tests: svg/custom/feImage-pserver-with-percentage-expected.svg
+   svg/custom/feImage-pserver-with-percentage.svg
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::updateRelativeLengthsInformation):
+
 2013-08-27  Darin Adler  
 
 No need for generalPasteboard (aside from "global selection mode")


Modified: trunk/Source/WebCore/svg/SVGElement.cpp (154712 => 154713)

--- trunk/Source/WebCore/svg/SVGElement.cpp	2013-08-27 22:25:19 UTC (rev 154712)
+++ trunk/Source/WebCore/svg/SVGElement.cpp	2013-08-27 23:09:28 UTC (rev 154713)
@@ -1121,6 +1121,9 @@
 m_elementsWithRelativeLengths.remove(element);
 }
 
+if (!element->isSVGGraphicsElement())
+return;
+
 // Find first styled parent node, and notify it that we've changed our relative length state.
 ContainerNode* node = parentNode();
 while (node) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154644] trunk

2013-08-26 Thread rwlbuis 
Title: [154644] trunk








Revision 154644
Author rwlb...@webkit.org
Date 2013-08-26 14:53:05 -0700 (Mon, 26 Aug 2013)


Log Message
Lonely stop crashes
https://bugs.webkit.org/show_bug.cgi?id=87964

Reviewed by Darin Adler.

Source/WebCore:

Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.

Test: svg/custom/stop-crash-hittest.svg

* rendering/svg/RenderSVGGradientStop.h:

LayoutTests:

Add testcase by taking stop-crash.svg and adding hittest instructions.

* svg/custom/stop-crash-hittest-expected.txt: Added.
* svg/custom/stop-crash-hittest.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h


Added Paths

trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt
trunk/LayoutTests/svg/custom/stop-crash-hittest.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (154643 => 154644)

--- trunk/LayoutTests/ChangeLog	2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/LayoutTests/ChangeLog	2013-08-26 21:53:05 UTC (rev 154644)
@@ -1,3 +1,15 @@
+2013-08-26  Rob Buis  
+
+Lonely stop crashes
+https://bugs.webkit.org/show_bug.cgi?id=87964
+
+Reviewed by Darin Adler.
+
+Add testcase by taking stop-crash.svg and adding hittest instructions.
+
+* svg/custom/stop-crash-hittest-expected.txt: Added.
+* svg/custom/stop-crash-hittest.svg: Added.
+
 2013-08-26  Bem Jones-Bey  
 
 Optimize FloatIntervalSearchAdapter::collectIfNeeded


Added: trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt (0 => 154644)

--- trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt	2013-08-26 21:53:05 UTC (rev 154644)
@@ -0,0 +1 @@
+PASS -- if this test doesn't crash it passes.


Added: trunk/LayoutTests/svg/custom/stop-crash-hittest.svg (0 => 154644)

--- trunk/LayoutTests/svg/custom/stop-crash-hittest.svg	(rev 0)
+++ trunk/LayoutTests/svg/custom/stop-crash-hittest.svg	2013-08-26 21:53:05 UTC (rev 154644)
@@ -0,0 +1,13 @@
+
+  
+  
+  if (window.testRunner)
+ testRunner.dumpAsText();
+  if (window.eventSender) {
+ eventSender.mouseMoveTo(200, 200);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+  }
+  
+  PASS -- if this test doesn't crash it passes.
+


Modified: trunk/Source/WebCore/ChangeLog (154643 => 154644)

--- trunk/Source/WebCore/ChangeLog	2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/Source/WebCore/ChangeLog	2013-08-26 21:53:05 UTC (rev 154644)
@@ -1,3 +1,16 @@
+2013-08-26  Rob Buis  
+
+Lonely stop crashes
+https://bugs.webkit.org/show_bug.cgi?id=87964
+
+Reviewed by Darin Adler.
+
+Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.
+
+Test: svg/custom/stop-crash-hittest.svg
+
+* rendering/svg/RenderSVGGradientStop.h:
+
 2013-08-26  Sam Weinig  
 
 Editor::spellChecker() should return a reference


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h (154643 => 154644)

--- trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h	2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h	2013-08-26 21:53:05 UTC (rev 154644)
@@ -47,6 +47,7 @@
 virtual FloatRect objectBoundingBox() const { return FloatRect(); }
 virtual FloatRect strokeBoundingBox() const { return FloatRect(); }
 virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
+virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint&, HitTestAction) OVERRIDE { return false; }
 
 protected:
 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154628] trunk

2013-08-26 Thread rwlbuis 
Title: [154628] trunk








Revision 154628
Author rwlb...@webkit.org
Date 2013-08-26 12:03:46 -0700 (Mon, 26 Aug 2013)


Log Message
Computed style of fill/stroke properties incorrect on references
https://bugs.webkit.org/show_bug.cgi?id=114761

Reviewed by Darin Adler.

Source/WebCore:

The computed style of the fill and stroke properties did not include
the url() function. Added the url() string to output.

Updated existing tests to cover the issue.

* css/CSSPrimitiveValue.cpp: Cleanup.
(WebCore::CSSPrimitiveValue::customCssText):
* svg/SVGPaint.cpp: Added "url("
(WebCore::SVGPaint::customCssText):

LayoutTests:

Add tests to verify that url function is included for references.

* svg/css/script-tests/svg-attribute-parser-mode.js:
* svg/css/svg-attribute-parser-mode-expected.txt:
* transitions/svg-transitions-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/css/script-tests/svg-attribute-parser-mode.js
trunk/LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt
trunk/LayoutTests/transitions/svg-transitions-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/svg/SVGPaint.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (154627 => 154628)

--- trunk/LayoutTests/ChangeLog	2013-08-26 19:01:23 UTC (rev 154627)
+++ trunk/LayoutTests/ChangeLog	2013-08-26 19:03:46 UTC (rev 154628)
@@ -1,3 +1,16 @@
+2013-08-26  Rob Buis  
+
+Computed style of fill/stroke properties incorrect on references
+https://bugs.webkit.org/show_bug.cgi?id=114761
+
+Reviewed by Darin Adler.
+
+Add tests to verify that url function is included for references.
+
+* svg/css/script-tests/svg-attribute-parser-mode.js:
+* svg/css/svg-attribute-parser-mode-expected.txt:
+* transitions/svg-transitions-expected.txt:
+
 2013-08-26  Robert Hogan  
 
 Avoid painting every non-edge collapsed border twice over


Modified: trunk/LayoutTests/svg/css/script-tests/svg-attribute-parser-mode.js (154627 => 154628)

--- trunk/LayoutTests/svg/css/script-tests/svg-attribute-parser-mode.js	2013-08-26 19:01:23 UTC (rev 154627)
+++ trunk/LayoutTests/svg/css/script-tests/svg-attribute-parser-mode.js	2013-08-26 19:03:46 UTC (rev 154628)
@@ -50,8 +50,19 @@
 rect.setAttribute("fill", "green");
 shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).fill", "#008000");
 
+rect.setAttribute("fill", "url(#reference)");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).fill", "url(#reference)");
+// Reset to green.
+rect.setAttribute("fill", "green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).fill", "#008000");
 
+rect.setAttribute("fill", "url(#reference) green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).fill", "url(#reference) #008000");
+// Reset to green.
+rect.setAttribute("fill", "green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).fill", "#008000");
 
+
 // Testing 'stroke'
 // The default stroke value should be 'none'.
 shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "none");
@@ -91,7 +102,19 @@
 rect.setAttribute("stroke", "green");
 shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "#008000");
 
+rect.setAttribute("stroke", "url(#reference)");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "url(#reference)");
+// Reset to green.
+rect.setAttribute("stroke", "green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "#008000");
 
+rect.setAttribute("stroke", "url(#reference) green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "url(#reference) #008000");
+// Reset to green.
+rect.setAttribute("stroke", "green");
+shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).stroke", "#008000");
+
+
 // Testing 'color'
 // The default for color is rgb(0, 0, 0).
 shouldBeEqualToString("document.defaultView.getComputedStyle(rect, null).color", "rgb(0, 0, 0)");


Modified: trunk/LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt (154627 => 154628)

--- trunk/LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt	2013-08-26 19:01:23 UTC (rev 154627)
+++ trunk/LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt	2013-08-26 19:03:46 UTC (rev 154628)
@@ -15,6 +15,10 @@
 PASS document.defaultView.getComputedStyle(rect, null).fill is "#008000"
 PASS document.defaultView.getComputedStyle(rect, null).fill is "#00"
 PASS document.defaultView.getComputedStyle(rect, null).fill is "#008000"
+PASS document.defaultView.getComputedStyle(rect, null).fill is "url(#reference)"
+PASS document.defaultView.getComputedStyle(rect, null).fill is "#008000"
+PASS document.defaultView.getComputedStyle(rect, null).fill is "url(#reference) #008000"
+PASS document.defaultView.getComputedStyle(rec

[webkit-changes] [154441] trunk

2013-08-22 Thread rwlbuis 
Title: [154441] trunk








Revision 154441
Author rwlb...@webkit.org
Date 2013-08-22 04:50:44 -0700 (Thu, 22 Aug 2013)


Log Message
REGRESSION: Assertion failure !collection->hasExactlyOneItem() in WebCore::namedItemGetter
https://bugs.webkit.org/show_bug.cgi?id=118056

Reviewed by Ryosuke Niwa.

Source/WebCore:

The assert is hit in Debug mode because the DocumentOrderedMap in HTMLDocument::m_windowNamedItem
includes matched SVG elements, but the WindowNameCollection used to collect the elements does not.
This means the HTMLCollection stripped of SVG elements could end up hitting the empty or single item
assertion, which the testcase verifies.
To fix this change WindowNameCollection to include both SVG and HTML elements so it matches DocumentOrderedMap.

Tests: svg/custom/document-all-includes-svg.html
   svg/custom/window-named-item-lookup.html

* html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::updateNameCache):

LayoutTests:

Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties.

* svg/custom/document-all-includes-svg-expected.txt: Added.
* svg/custom/document-all-includes-svg.html: Added.
* svg/custom/window-named-item-lookup-expected.txt: Added.
* svg/custom/window-named-item-lookup.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCollection.cpp


Added Paths

trunk/LayoutTests/svg/custom/document-all-includes-svg-expected.txt
trunk/LayoutTests/svg/custom/document-all-includes-svg.html
trunk/LayoutTests/svg/custom/window-named-item-lookup-expected.txt
trunk/LayoutTests/svg/custom/window-named-item-lookup.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154440 => 154441)

--- trunk/LayoutTests/ChangeLog	2013-08-22 11:43:25 UTC (rev 154440)
+++ trunk/LayoutTests/ChangeLog	2013-08-22 11:50:44 UTC (rev 154441)
@@ -1,3 +1,17 @@
+2013-08-22  Rob Buis  
+
+REGRESSION: Assertion failure !collection->hasExactlyOneItem() in WebCore::namedItemGetter
+https://bugs.webkit.org/show_bug.cgi?id=118056
+
+Reviewed by Ryosuke Niwa.
+
+Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties.
+
+* svg/custom/document-all-includes-svg-expected.txt: Added.
+* svg/custom/document-all-includes-svg.html: Added.
+* svg/custom/window-named-item-lookup-expected.txt: Added.
+* svg/custom/window-named-item-lookup.html: Added.
+
 2013-08-22  Renata Hodovan  
 
 ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement


Added: trunk/LayoutTests/svg/custom/document-all-includes-svg-expected.txt (0 => 154441)

--- trunk/LayoutTests/svg/custom/document-all-includes-svg-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/document-all-includes-svg-expected.txt	2013-08-22 11:50:44 UTC (rev 154441)
@@ -0,0 +1,9 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS document.all['test1'].length is 2
+PASS document.all['test2'].length is 2
+PASS document.all['test3'].nodeName is "A"
+PASS document.all['test4'].length is 2
+PASS document.all['test5'].length is 2
+


Added: trunk/LayoutTests/svg/custom/document-all-includes-svg.html (0 => 154441)

--- trunk/LayoutTests/svg/custom/document-all-includes-svg.html	(rev 0)
+++ trunk/LayoutTests/svg/custom/document-all-includes-svg.html	2013-08-22 11:50:44 UTC (rev 154441)
@@ -0,0 +1,33 @@
+
+
+  
+
+  function runTest()
+  {
+shouldBe("document.all['test1'].length", "2");
+shouldBe("document.all['test2'].length", "2");
+shouldBeEqualToString("document.all['test3'].nodeName", 'A');
+shouldBe("document.all['test4'].length", "2");
+shouldBe("document.all['test5'].length", "2");
+  }
+ 
+ 
+  
+
+
+
+
+
+
+
+
+
+

+
+
+
+
+  
+