[webkit-changes] [202211] trunk/Source/WebCore
Title: [202211] trunk/Source/WebCore
Revision 202211
Author youenn.fab...@crf.canon.fr
Date 2016-06-19 10:51:51 -0700 (Sun, 19 Jun 2016)
Log Message
The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
https://bugs.webkit.org/show_bug.cgi?id=158834
Reviewed by Eric Carlson.
No change of behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Explicitly setting DOMWrapped type definition from
JSXX class deriving from another JSYY class.
* bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
* bindings/scripts/test/JS/JSTestNode.h: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (202210 => 202211)
--- trunk/Source/WebCore/ChangeLog 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/ChangeLog 2016-06-19 17:51:51 UTC (rev 202211)
@@ -1,3 +1,18 @@
+2016-06-19 Youenn Fablet
+
+The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
+https://bugs.webkit.org/show_bug.cgi?id=158834
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader): Explicitly setting DOMWrapped type definition from
+JSXX class deriving from another JSYY class.
+* bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
+* bindings/scripts/test/JS/JSTestNode.h: Ditto.
+
2016-06-18 Antti Koivisto
Use time literals in WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-06-19 17:51:51 UTC (rev 202211)
@@ -1104,6 +1104,8 @@
# Static create methods
push(@headerContent, "public:\n");
push(@headerContent, "typedef $parentClassName Base;\n");
+push(@headerContent, "typedef $implType DOMWrapped;\n") if $interface->parent;
+
if ($interfaceName eq "DOMWindow") {
push(@headerContent, "static $className* create(JSC::VM& vm, JSC::Structure* structure, Ref<$implType>&& impl, JSDOMWindowShell* windowShell)\n");
push(@headerContent, "{\n");
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h 2016-06-19 17:51:51 UTC (rev 202211)
@@ -28,6 +28,7 @@
class JSTestEventTarget : public JSEventTarget {
public:
typedef JSEventTarget Base;
+typedef TestEventTarget DOMWrapped;
static JSTestEventTarget* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref&& impl)
{
globalObject->masqueradesAsUndefinedWatchpoint()->fireAll("Allocated masquerading object");
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h (202210 => 202211)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h 2016-06-19 17:48:54 UTC (rev 202210)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h 2016-06-19 17:51:51 UTC (rev 202211)
@@ -28,6 +28,7 @@
class WEBCORE_TESTSUPPORT_EXPORT JSTestNode : public JSNode {
public:
typedef JSNode Base;
+typedef TestNode DOMWrapped;
static JSTestNode* create(JSC::Structure* structure, JSDOMGlobalObject* globalObject, Ref&& impl)
{
JSTestNode* ptr = new (NotNull, JSC::allocateCell(globalObject->vm().heap)) JSTestNode(structure, *globalObject, WTFMove(impl));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [202162] trunk
Title: [202162] trunk
Revision 202162
Author youenn.fab...@crf.canon.fr
Date 2016-06-17 03:34:02 -0700 (Fri, 17 Jun 2016)
Log Message
CORS preflight with a non-200 response should be a preflight failure
https://bugs.webkit.org/show_bug.cgi?id=111008
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/XMLHttpRequest/data-uri-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/fetch/FetchResponse.h: Making use of ResourceResponse::isSuccessful.
* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse): Checking that response status is code is
successful. If not, calling preflight failure callback.
(WebCore::CrossOriginPreflightChecker::startPreflight): Putting in manual redirection mode so that redirection
responses are processed as other responses.
* loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::fetchOptions): Adding a non-const getter and fixing const getter to return a
const reference.
(WebCore::ResourceLoaderOptions::setFetchOptions): Passing options by reference.
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isSuccessful): Utility function.
* platform/network/ResourceResponseBase.h:
LayoutTests:
* http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
* http/tests/xmlhttprequest/access-control-and-redirects-async.html:
* http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html
trunk/LayoutTests/http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/data-uri-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/loader/CrossOriginPreflightChecker.cpp
trunk/Source/WebCore/loader/ResourceLoaderOptions.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
Diff
Modified: trunk/LayoutTests/ChangeLog (202161 => 202162)
--- trunk/LayoutTests/ChangeLog 2016-06-17 09:24:49 UTC (rev 202161)
+++ trunk/LayoutTests/ChangeLog 2016-06-17 10:34:02 UTC (rev 202162)
@@ -1,3 +1,15 @@
+2016-06-17 Youenn Fablet
+
+CORS preflight with a non-200 response should be a preflight failure
+https://bugs.webkit.org/show_bug.cgi?id=111008
+
+Reviewed by Darin Adler.
+
+* http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
+* http/tests/xmlhttprequest/access-control-and-redirects-async.html:
+* http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
+* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
+
2016-06-17 Frederic Wang
MathOperator: Add fallback mechanisms for stretching and mirroring radical symbols
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt (202161 => 202162)
--- trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt 2016-06-17 09:24:49 UTC (rev 202161)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt 2016-06-17 10:34:02 UTC (rev 202162)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/redirect-cors.php?redirect-preflight=true&%20%20url=http://localhost:8000/xmlhttprequest/resources/access-control-basic-allow-star.cgi&%20%20access-control-allow-origin=*. Preflight response is not successful
Tests that asynchronous XMLHttpRequests handle redirects according to the CORS standard.
Testing http://localhost:8000/xmlhttprequest/resources/redirect-cors.php?url="" without credentials
Modified: trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html (202161 => 202162)
--- trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html 2016-06-17 09:24:49 UTC (rev 202161)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async.html 2016-06-17 10:34:02 UTC (rev 202162)
@@ -24,12 +24,13 @@
xhr._onload_ = function() {
log((expectSuccess ? "PASS" : "FAIL") + ": " + xhr.responseText);
-nextTest();
}
xhr._onerror_ = function() {
log((expectSuccess ? "FAIL" : "PASS") + ": " + xhr.stat
[webkit-changes] [202046] trunk/Tools
Title: [202046] trunk/Tools
Revision 202046
Author youenn.fab...@crf.canon.fr
Date 2016-06-14 09:32:50 -0700 (Tue, 14 Jun 2016)
Log Message
Activate CMake export compile commands option
https://bugs.webkit.org/show_bug.cgi?id=158734
Reviewed by Alex Christensen.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
This allows using ymcd for WebKit hacking.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (202045 => 202046)
--- trunk/Tools/ChangeLog 2016-06-14 16:32:01 UTC (rev 202045)
+++ trunk/Tools/ChangeLog 2016-06-14 16:32:50 UTC (rev 202046)
@@ -1,3 +1,14 @@
+2016-06-14 Youenn Fablet
+
+Activate CMake export compile commands option
+https://bugs.webkit.org/show_bug.cgi?id=158734
+
+Reviewed by Alex Christensen.
+
+* Scripts/webkitdirs.pm:
+(generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
+This allows using ymcd for WebKit hacking.
+
2016-06-14 David Kilzer
Modernize DumpRenderTreeMac.h
Modified: trunk/Tools/Scripts/webkitdirs.pm (202045 => 202046)
--- trunk/Tools/Scripts/webkitdirs.pm 2016-06-14 16:32:01 UTC (rev 202045)
+++ trunk/Tools/Scripts/webkitdirs.pm 2016-06-14 16:32:50 UTC (rev 202046)
@@ -1975,7 +1975,7 @@
my @args;
push @args, "-DPORT=\"$port\"";
push @args, "-DCMAKE_INSTALL_PREFIX=\"$prefixPath\"" if $prefixPath;
-push @args, "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" if isGtk();
+push @args, "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON";
if ($config =~ /release/i) {
push @args, "-DCMAKE_BUILD_TYPE=Release";
} elsif ($config =~ /debug/i) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201930] trunk
Title: [201930] trunk Revision 201930 Author youenn.fab...@crf.canon.fr Date 2016-06-10 11:17:11 -0700 (Fri, 10 Jun 2016) Log Message Origin header is not included in CORS requests for preloaded cross-origin resources https://bugs.webkit.org/show_bug.cgi?id=155761 Reviewed by Alex Christensen. Source/WebCore: Making HTML preloader fully aware of crossorigin attribute value. Introducing CachedResourceRequest::setAsPotentiallyCrossOrigin as a helper routine to activate CORS mode. Making HTMLLinkElement and HTMLResourcePreloader use that routine. Making TokenPreloadScanner store the crossorigin attribute value in preload requests. Making TokenPreloadScanner store the crossorigin attribute value for link elements. Test: http/tests/security/cross-origin-css-9.html * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): * html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest): (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): * html/parser/HTMLResourcePreloader.cpp: (WebCore::crossOriginModeAllowsCookies): (WebCore::PreloadRequest::resourceRequest): * html/parser/HTMLResourcePreloader.h: (WebCore::PreloadRequest::setCrossOriginMode): (WebCore::PreloadRequest::PreloadRequest): Deleted. (WebCore::PreloadRequest::resourceType): Deleted. * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin): * loader/cache/CachedResourceRequest.h: LayoutTests: * http/tests/security/cross-origin-css-9-expected.txt: Added. * http/tests/security/cross-origin-css-9.html: Added. * http/tests/security/resources/get-css-if-origin-header.php: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLLinkElement.cpp trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp trunk/Source/WebCore/html/parser/HTMLResourcePreloader.cpp trunk/Source/WebCore/html/parser/HTMLResourcePreloader.h trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.h Added Paths trunk/LayoutTests/http/tests/security/cross-origin-css-9-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-css-9.html trunk/LayoutTests/http/tests/security/resources/get-css-if-origin-header.php Diff Modified: trunk/LayoutTests/ChangeLog (201929 => 201930) --- trunk/LayoutTests/ChangeLog 2016-06-10 18:01:54 UTC (rev 201929) +++ trunk/LayoutTests/ChangeLog 2016-06-10 18:17:11 UTC (rev 201930) @@ -1,3 +1,15 @@ +2016-06-10 Youenn Fablet + +Origin header is not included in CORS requests for preloaded cross-origin resources +https://bugs.webkit.org/show_bug.cgi?id=155761 + + +Reviewed by Alex Christensen. + +* http/tests/security/cross-origin-css-9-expected.txt: Added. +* http/tests/security/cross-origin-css-9.html: Added. +* http/tests/security/resources/get-css-if-origin-header.php: Added. + 2016-06-10 Ryan Haddad Marking fast/hidpi/hidpi-3x-device-pixel-ratio.html as failing on ios-simulator Added: trunk/LayoutTests/http/tests/security/cross-origin-css-9-expected.txt (0 => 201930) --- trunk/LayoutTests/http/tests/security/cross-origin-css-9-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/security/cross-origin-css-9-expected.txt 2016-06-10 18:17:11 UTC (rev 201930) @@ -0,0 +1,9 @@ + +PASS Testing that link element to load stylesheets correctly handle crossorigin mode. +PASS Same-origin URL link without crossorigin attribute should be loaded without an Origin header +PASS Cross-origin URL link without crossorigin attribute should be loaded without an Origin header +PASS Same-origin URL link with crossorigin="" attribute should be loaded with an Origin header +PASS Cross-origin URL link with crossorigin="" should be loaded with an Origin header +PASS Cross-origin URL link with crossorigin="anonymous" should be loaded with an Origin header +PASS Cross-origin URL link with crossorigin="credentials" should be loaded with an Origin header + Added: trunk/LayoutTests/http/tests/security/cross-origin-css-9.html (0 => 201930) --- trunk/LayoutTests/http/tests/security/cross-origin-css-9.html (rev 0) +++ trunk/LayoutTests/http/tests/security/cross-origin-css-9.html 2016-06-10 18:17:11 UTC (rev 201930) @@ -0,0 +1,62 @@ + + + +Cross-origin CSS: Origin header should be set when fetching stylesheet in cors mode + +</link> +<link id="link-id3" rel="stylesheet" type="text/css" href="" crossorigin=""></link> +<link id="link-id4" rel="stylesheet" type="text/css" href="" crossorigin="anonymous"></link> +<link id="link-id5" rel="stylesheet" type="text/css" href="" cro
[webkit-changes] [201924] trunk/Source/WebCore
Title: [201924] trunk/Source/WebCore Revision 201924 Author youenn.fab...@crf.canon.fr Date 2016-06-10 06:26:30 -0700 (Fri, 10 Jun 2016) Log Message Move preflight check code outside of DocumentThreadableLoader https://bugs.webkit.org/show_bug.cgi?id=158425 Reviewed by Darin Adler. Moving preflight check code in its own class. This allows code to be easier to read, use/reuse and update. Behavior should be the same as before except in the case of a preflight response being a 3XX redirect response. Before this patch, the 3XX response was directly passed to the code processing regular responses. To keep compatibility with existing tests, a didFailRedirectCheck callback is called. This should be change to a preflight failure. Covered by existing tests. * CMakeLists.txt: * WebCore.xcodeproj/project.pbxproj: * loader/CrossOriginPreflightChecker.cpp: Added. (WebCore::CrossOriginPreflightChecker::CrossOriginPreflightChecker): (WebCore::CrossOriginPreflightChecker::~CrossOriginPreflightChecker): (WebCore::CrossOriginPreflightChecker::handleLoadingFailure): (WebCore::CrossOriginPreflightChecker::validatePreflightResponse): (WebCore::CrossOriginPreflightChecker::notifyFinished): (WebCore::CrossOriginPreflightChecker::startPreflight): (WebCore::CrossOriginPreflightChecker::doPreflight): (WebCore::CrossOriginPreflightChecker::redirectReceived): (WebCore::CrossOriginPreflightChecker::setDefersLoading): (WebCore::CrossOriginPreflightChecker::isXMLHttpRequest): * loader/CrossOriginPreflightChecker.h: Added. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest): (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): (WebCore::DocumentThreadableLoader::setDefersLoading): (WebCore::DocumentThreadableLoader::clearResource): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::notifyFinished): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::preflightSuccess): (WebCore::DocumentThreadableLoader::preflightFailure): (WebCore::DocumentThreadableLoader::loadRequest): (WebCore::DocumentThreadableLoader::responseReceived): Deleted. (WebCore::DocumentThreadableLoader::dataReceived): Deleted. (WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy): Deleted. * loader/DocumentThreadableLoader.h: (WebCore::DocumentThreadableLoader::options): (WebCore::DocumentThreadableLoader::isLoading): (WebCore::DocumentThreadableLoader::document): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.h Added Paths trunk/Source/WebCore/loader/CrossOriginPreflightChecker.cpp trunk/Source/WebCore/loader/CrossOriginPreflightChecker.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (201923 => 201924) --- trunk/Source/WebCore/CMakeLists.txt 2016-06-10 12:58:12 UTC (rev 201923) +++ trunk/Source/WebCore/CMakeLists.txt 2016-06-10 13:26:30 UTC (rev 201924) @@ -1900,6 +1900,7 @@ loader/ContentFilter.cpp loader/CookieJar.cpp loader/CrossOriginAccessControl.cpp +loader/CrossOriginPreflightChecker.cpp loader/CrossOriginPreflightResultCache.cpp loader/DocumentLoadTiming.cpp loader/DocumentLoader.cpp Modified: trunk/Source/WebCore/ChangeLog (201923 => 201924) --- trunk/Source/WebCore/ChangeLog 2016-06-10 12:58:12 UTC (rev 201923) +++ trunk/Source/WebCore/ChangeLog 2016-06-10 13:26:30 UTC (rev 201924) @@ -1,3 +1,57 @@ +2016-06-10 Youenn Fablet + +Move preflight check code outside of DocumentThreadableLoader +https://bugs.webkit.org/show_bug.cgi?id=158425 + +Reviewed by Darin Adler. + +Moving preflight check code in its own class. +This allows code to be easier to read, use/reuse and update. + +Behavior should be the same as before except in the case of a preflight response +being a 3XX redirect response. +Before this patch, the 3XX response was directly passed to the code processing regular responses. +To keep compatibility with existing tests, a didFailRedirectCheck callback is called. +This should be change to a preflight failure. + +Covered by existing tests. + +* CMakeLists.txt: +* WebCore.xcodeproj/project.pbxproj: +* loader/CrossOriginPreflightChecker.cpp: Added. +(WebCore::CrossOriginPreflightChecker::CrossOriginPreflightChecker): +(WebCore::CrossOriginPreflightChecker::~CrossOriginPreflightChecker): +(WebCore::CrossOriginPreflightChecker::handleLoadingFailure): +(WebCore::CrossOriginPreflightChecker::validatePreflightResponse): +(W
[webkit-changes] [201856] trunk/Source
Title: [201856] trunk/Source Revision 201856 Author youenn.fab...@crf.canon.fr Date 2016-06-08 23:55:26 -0700 (Wed, 08 Jun 2016) Log Message Introduce ResourceErrorBase::type https://bugs.webkit.org/show_bug.cgi?id=158299 Reviewed by Alex Christensen. Source/WebCore: Introducing an enum type for ResourceErrorBase. In most cases, the type is set at construction time. By default, constructor with no parameters will set type to Null. Constructor with parameters will set type to General. Removed boolean state error fields. Introduced a type setter. It should only be used to make the type more precise (when type is Null or General). Updating related calling code. No change of behavior. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoadingForPolicyChange): * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::cancel): * loader/EmptyClients.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::blockedError): * loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): * platform/network/ResourceErrorBase.cpp: (WebCore::ResourceErrorBase::isolatedCopy): (WebCore::ResourceErrorBase::setType): (WebCore::ResourceErrorBase::compare): * platform/network/ResourceErrorBase.h: (WebCore::ResourceErrorBase::isNull): (WebCore::ResourceErrorBase::isCancellation): (WebCore::ResourceErrorBase::isTimeout): (WebCore::ResourceErrorBase::type): (WebCore::ResourceErrorBase::ResourceErrorBase): (WebCore::ResourceErrorBase::domain): * platform/network/cf/ResourceError.h: (WebCore::ResourceError::ResourceError): * platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::cfError): * platform/network/curl/ResourceError.h: (WebCore::ResourceError::ResourceError): * platform/network/mac/ResourceErrorMac.mm: (WebCore::m_platformError): (WebCore::ResourceError::nsError): (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::platformLazyInit): * platform/network/soup/ResourceError.h: (WebCore::ResourceError::ResourceError): * platform/network/soup/ResourceErrorSoup.cpp: (WebCore::ResourceError::timeoutError): Source/WebKit2: * Shared/soup/WebCoreArgumentCodersSoup.cpp: (IPC::ArgumentCoder::encodePlatformData): (IPC::ArgumentCoder::decodePlatformData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp trunk/Source/WebCore/platform/network/ResourceErrorBase.h trunk/Source/WebCore/platform/network/cf/ResourceError.h trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp trunk/Source/WebCore/platform/network/curl/ResourceError.h trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm trunk/Source/WebCore/platform/network/soup/ResourceError.h trunk/Source/WebCore/platform/network/soup/ResourceErrorSoup.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201855 => 201856) --- trunk/Source/WebCore/ChangeLog 2016-06-09 06:20:55 UTC (rev 201855) +++ trunk/Source/WebCore/ChangeLog 2016-06-09 06:55:26 UTC (rev 201856) @@ -1,3 +1,62 @@ +2016-06-08 Youenn Fablet + +Introduce ResourceErrorBase::type +https://bugs.webkit.org/show_bug.cgi?id=158299 + +Reviewed by Alex Christensen. + +Introducing an enum type for ResourceErrorBase. +In most cases, the type is set at construction time. +By default, constructor with no parameters will set type to Null. +Constructor with parameters will set type to General. + +Removed boolean state error fields. + +Introduced a type setter. It should only be used to make the type +more precise (when type is Null or General). + +Updating related calling code. + +No change of behavior. + +* loader/DocumentLoader.cpp: +(WebCore::DocumentLoader::stopLoadingForPolicyChange): +* loader/DocumentThreadableLoader.cpp: +(WebCore::DocumentThreadableLoader::cancel): +* loader/EmptyClients.h: +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::cancelledError): +(WebCore::FrameLoader::blockedError): +* loader/WorkerThreadableLoader.cpp: +(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): +* platform/network/ResourceErrorBase.cpp: +(WebCore::ResourceErrorBase::isolatedCopy): +(WebCore::ResourceErrorBase::setType): +(WebCore::ResourceErrorBase::compare): +* platform/network/ResourceErrorBase.h: +(WebCore::ResourceErrorBase::isNull): +(WebCore::ResourceErrorBase::isCancellation): +(WebC
[webkit-changes] [201642] trunk/Tools
Title: [201642] trunk/Tools Revision 201642 Author youenn.fab...@crf.canon.fr Date 2016-06-03 08:40:40 -0700 (Fri, 03 Jun 2016) Log Message [GTK] Update YouCompleteMe script to make all include paths absolute https://bugs.webkit.org/show_bug.cgi?id=158301 Reviewed by Michael Catanzaro. Before this patch, some include paths were not made absolute. This could make YouCompleteMe plugin to fail extracting information or validating cpp files. * gtk/ycm_extra_conf.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/ycm_extra_conf.py Diff Modified: trunk/Tools/ChangeLog (201641 => 201642) --- trunk/Tools/ChangeLog 2016-06-03 14:53:16 UTC (rev 201641) +++ trunk/Tools/ChangeLog 2016-06-03 15:40:40 UTC (rev 201642) @@ -1,3 +1,15 @@ +2016-06-03 Youenn Fablet + +[GTK] Update YouCompleteMe script to make all include paths absolute +https://bugs.webkit.org/show_bug.cgi?id=158301 + +Reviewed by Michael Catanzaro. + +Before this patch, some include paths were not made absolute. +This could make YouCompleteMe plugin to fail extracting information or validating cpp files. + +* gtk/ycm_extra_conf.py: + 2016-06-03 Nael Ouedraogo Unreviewed: add myself to the committers list. Modified: trunk/Tools/gtk/ycm_extra_conf.py (201641 => 201642) --- trunk/Tools/gtk/ycm_extra_conf.py 2016-06-03 14:53:16 UTC (rev 201641) +++ trunk/Tools/gtk/ycm_extra_conf.py 2016-06-03 15:40:40 UTC (rev 201642) @@ -47,8 +47,7 @@ elif argument in FLAGS_PRECEDING_PATHS: # Some flags precede the path in the list. For those we make the # next argument absolute. -if argument == flag: -make_next_absolute = True +make_next_absolute = True else: # Some argument contain the flag and the path together. For these # we parse the argument out of the path. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201596] trunk/Source
/ChangeLog (201595 => 201596)
--- trunk/Source/WebCore/ChangeLog 2016-06-02 07:36:21 UTC (rev 201595)
+++ trunk/Source/WebCore/ChangeLog 2016-06-02 08:45:14 UTC (rev 201596)
@@ -1,3 +1,48 @@
+2016-06-02 Youenn Fablet
+
+Use more references in ResourceLoader related code
+https://bugs.webkit.org/show_bug.cgi?id=158222
+
+Reviewed by Darin Adler.
+
+No change of behavior.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::load):
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::clearDocument):
+(WebCore::CSSFontSelector::beginLoadingFontSoon):
+(WebCore::CSSFontSelector::beginLoadTimerFired):
+* css/CSSFontSelector.h:
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::scheduleArchiveLoad):
+* loader/DocumentLoader.h:
+* loader/LoaderStrategy.h:
+* loader/NetscapePlugInStreamLoader.cpp:
+(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
+(WebCore::NetscapePlugInStreamLoader::create):
+* loader/NetscapePlugInStreamLoader.h:
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::ResourceLoader):
+(WebCore::ResourceLoader::start):
+* loader/ResourceLoader.h:
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::RequestCountTracker::RequestCountTracker):
+(WebCore::SubresourceLoader::SubresourceLoader):
+(WebCore::SubresourceLoader::create):
+(WebCore::SubresourceLoader::didReceiveResponse):
+(WebCore::SubresourceLoader::notifyDone):
+* loader/SubresourceLoader.h:
+* loader/appcache/ApplicationCacheHost.cpp:
+(WebCore::ApplicationCacheHost::maybeLoadResource):
+* loader/appcache/ApplicationCacheHost.h:
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::load):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::incrementRequestCount):
+(WebCore::CachedResourceLoader::decrementRequestCount):
+* loader/cache/CachedResourceLoader.h:
+
2016-06-02 Carlos Garcia Campos
[Wayland] PlatformDisplayWayland destructor is super crashy
Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (201595 => 201596)
--- trunk/Source/WebCore/css/CSSFontFaceSource.cpp 2016-06-02 07:36:21 UTC (rev 201595)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp 2016-06-02 08:45:14 UTC (rev 201596)
@@ -124,7 +124,8 @@
{
setStatus(Status::Loading);
-fontSelector.beginLoadingFontSoon(m_font.get());
+ASSERT(m_font);
+fontSelector.beginLoadingFontSoon(*m_font);
}
RefPtr CSSFontFaceSource::font(const FontDescription& fontDescription, bool syntheticBold, bool syntheticItalic, const FontFeatureSettings& fontFaceFeatures, const FontVariantSettings& fontFaceVariantSettings)
Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (201595 => 201596)
--- trunk/Source/WebCore/css/CSSFontSelector.cpp 2016-06-02 07:36:21 UTC (rev 201595)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp 2016-06-02 08:45:14 UTC (rev 201596)
@@ -262,7 +262,7 @@
CachedResourceLoader& cachedResourceLoader = m_document->cachedResourceLoader();
for (auto& fontHandle : m_fontsToBeginLoading) {
// Balances incrementRequestCount() in beginLoadingFontSoon().
-cachedResourceLoader.decrementRequestCount(fontHandle.get());
+cachedResourceLoader.decrementRequestCount(*fontHandle);
}
m_fontsToBeginLoading.clear();
@@ -273,12 +273,12 @@
m_clients.clear();
}
-void CSSFontSelector::beginLoadingFontSoon(CachedFont* font)
+void CSSFontSelector::beginLoadingFontSoon(CachedFont& font)
{
if (!m_document)
return;
-m_fontsToBeginLoading.append(font);
+m_fontsToBeginLoading.append(&font);
// Increment the request count now, in order to prevent didFinishLoad from being dispatched
// after this font has been requested but before it began loading. Balanced by
// decrementRequestCount() in beginLoadTimerFired() and in clearDocument().
@@ -298,7 +298,7 @@
for (auto& fontHandle : fontsToBeginLoading) {
fontHandle->beginLoadIfNeeded(cachedResourceLoader);
// Balances incrementRequestCount() in beginLoadingFontSoon().
-cachedResourceLoader.decrementRequestCount(fontHandle.get());
+cachedResourceLoader.decrementRequestCount(*fontHandle);
}
// Ensure that if the request count reaches zero, the frame loader will know about it.
cachedResourceLoader.loadDone(nullptr);
Modified: trunk/Source/WebCore/css/CSSFontSelector.h (201595 => 201596)
--- trunk/Source/WebCore/css/CSSFontSelector.h 2016-06-02 07:36:21 UTC (rev 201595)
+++ trunk/Source/WebCore/css/CSSFontSelector.h 2016-06-02 08:45:14 UTC (rev 201596)
@@ -78,7 +78,7 @@
Document* document() const { return m_document; }
-
[webkit-changes] [201556] trunk/Source/WebCore
Title: [201556] trunk/Source/WebCore
Revision 201556
Author youenn.fab...@crf.canon.fr
Date 2016-06-01 09:58:08 -0700 (Wed, 01 Jun 2016)
Log Message
Remove allocation of SubresourceLoader::m_requestCountTracker
https://bugs.webkit.org/show_bug.cgi?id=158255
Reviewed by Chris Dumez.
No change of behavior.
Making m_requestCountTracker an Optional in lieu of a unique_ptr.
This requires constructing m_requestCountTracker in place so that constructor and destructor are called only once.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):
* loader/SubresourceLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (201555 => 201556)
--- trunk/Source/WebCore/ChangeLog 2016-06-01 16:22:01 UTC (rev 201555)
+++ trunk/Source/WebCore/ChangeLog 2016-06-01 16:58:08 UTC (rev 201556)
@@ -1,3 +1,21 @@
+2016-06-01 Youenn Fablet
+
+Remove allocation of SubresourceLoader::m_requestCountTracker
+https://bugs.webkit.org/show_bug.cgi?id=158255
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+Making m_requestCountTracker an Optional in lieu of a unique_ptr.
+This requires constructing m_requestCountTracker in place so that constructor and destructor are called only once.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::SubresourceLoader):
+(WebCore::SubresourceLoader::didReceiveResponse):
+(WebCore::SubresourceLoader::notifyDone):
+* loader/SubresourceLoader.h:
+
2016-06-01 Antti Koivisto
Remove accidental fprintf.
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (201555 => 201556)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2016-06-01 16:22:01 UTC (rev 201555)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2016-06-01 16:58:08 UTC (rev 201556)
@@ -78,7 +78,7 @@
, m_resource(resource)
, m_loadingMultipartContent(false)
, m_state(Uninitialized)
-, m_requestCountTracker(std::make_unique(frame->document()->cachedResourceLoader(), resource))
+, m_requestCountTracker(InPlace, frame->document()->cachedResourceLoader(), resource)
{
#ifndef NDEBUG
subresourceLoaderCounter.increment();
@@ -283,7 +283,7 @@
m_loadingMultipartContent = true;
// We don't count multiParts in a CachedResourceLoader's request count
-m_requestCountTracker = nullptr;
+m_requestCountTracker = Nullopt;
if (!m_resource->isImage()) {
cancel();
return;
@@ -514,7 +514,7 @@
if (reachedTerminalState())
return;
-m_requestCountTracker = nullptr;
+m_requestCountTracker = Nullopt;
#if PLATFORM(IOS)
m_documentLoader->cachedResourceLoader().loadDone(m_resource, m_state != CancelledWhileInitializing);
#else
Modified: trunk/Source/WebCore/loader/SubresourceLoader.h (201555 => 201556)
--- trunk/Source/WebCore/loader/SubresourceLoader.h 2016-06-01 16:22:01 UTC (rev 201555)
+++ trunk/Source/WebCore/loader/SubresourceLoader.h 2016-06-01 16:58:08 UTC (rev 201556)
@@ -125,7 +125,7 @@
CachedResource* m_resource;
bool m_loadingMultipartContent;
SubresourceLoaderState m_state;
-std::unique_ptr m_requestCountTracker;
+Optional m_requestCountTracker;
RefPtr m_origin;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201555] trunk/LayoutTests/imported/w3c
Title: [201555] trunk/LayoutTests/imported/w3c Revision 201555 Author youenn.fab...@crf.canon.fr Date 2016-06-01 09:22:01 -0700 (Wed, 01 Jun 2016) Log Message Close wptserve response file handles explicitly https://bugs.webkit.org/show_bug.cgi?id=158253 Reviewed by Alexey Proskuryakov. See https://github.com/youennf/wptserve/commit/fc902e97a21b8470dcdaab8c70691aea1fecbc12 * resources/web-platform-tests-modules.json: Updating wptserve module to close response file handles once written. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (201554 => 201555) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-06-01 15:53:29 UTC (rev 201554) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-06-01 16:22:01 UTC (rev 201555) @@ -1,3 +1,14 @@ +2016-06-01 Youenn Fablet + +Close wptserve response file handles explicitly +https://bugs.webkit.org/show_bug.cgi?id=158253 + +Reviewed by Alexey Proskuryakov. + +See https://github.com/youennf/wptserve/commit/fc902e97a21b8470dcdaab8c70691aea1fecbc12 + +* resources/web-platform-tests-modules.json: Updating wptserve module to close response file handles once written. + 2016-05-28 Youenn Fablet Adding wptserve logging for 404 file-serving responses Modified: trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json (201554 => 201555) --- trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-06-01 15:53:29 UTC (rev 201554) +++ trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-06-01 16:22:01 UTC (rev 201555) @@ -87,7 +87,7 @@ "tools", "wptserve" ], -"url": "https://github.com/youennf/wptserve/archive/9c84ebd90130bef40d440981e0f55947418678b3.tar.gz", -"url_subpath": "wptserve-9c84ebd90130bef40d440981e0f55947418678b3" +"url": "https://github.com/youennf/wptserve/archive/fc902e97a21b8470dcdaab8c70691aea1fecbc12.tar.gz", +"url_subpath": "wptserve-fc902e97a21b8470dcdaab8c70691aea1fecbc12" } ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201491] trunk/LayoutTests/imported/w3c
Title: [201491] trunk/LayoutTests/imported/w3c Revision 201491 Author youenn.fab...@crf.canon.fr Date 2016-05-28 12:53:27 -0700 (Sat, 28 May 2016) Log Message Adding wptserve logging for 404 file-serving responses https://bugs.webkit.org/show_bug.cgi?id=158183 Reviewed by Alexey Proskuryakov. * resources/web-platform-tests-modules.json: Modifying wptserve module to log 404 FileHandler exceptions. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (201490 => 201491) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-28 19:18:48 UTC (rev 201490) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-28 19:53:27 UTC (rev 201491) @@ -1,3 +1,12 @@ +2016-05-28 Youenn Fablet + +Adding wptserve logging for 404 file-serving responses +https://bugs.webkit.org/show_bug.cgi?id=158183 + +Reviewed by Alexey Proskuryakov. + +* resources/web-platform-tests-modules.json: Modifying wptserve module to log 404 FileHandler exceptions. + 2016-05-24 Youenn Fablet [Fetch API] Implement Fetch redirect mode Modified: trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json (201490 => 201491) --- trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-05-28 19:18:48 UTC (rev 201490) +++ trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-05-28 19:53:27 UTC (rev 201491) @@ -87,7 +87,7 @@ "tools", "wptserve" ], -"url": "https://github.com/w3c/wptserve/archive/01ed915048fae7a57b81d9f424889eb1ab6ece79.tar.gz", -"url_subpath": "wptserve-01ed915048fae7a57b81d9f424889eb1ab6ece79" +"url": "https://github.com/youennf/wptserve/archive/9c84ebd90130bef40d440981e0f55947418678b3.tar.gz", +"url_subpath": "wptserve-9c84ebd90130bef40d440981e0f55947418678b3" } -] \ No newline at end of file +] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201324] trunk
Log 2016-05-24 06:29:58 UTC (rev 201323)
+++ trunk/LayoutTests/ChangeLog 2016-05-24 07:35:09 UTC (rev 201324)
@@ -1,3 +1,16 @@
+2016-05-24 Youenn Fablet
+
+[Fetch API] Implement Fetch redirect mode
+https://bugs.webkit.org/show_bug.cgi?id=157837
+
+Reviewed by Alex Christensen.
+
+* http/tests/fetch/caching-with-different-options-expected.txt: Added.
+* http/tests/fetch/caching-with-different-options.html: Added.
+* http/tests/fetch/resources/redirect-with-cache.php: Added.
+* platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
+* platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-expected.txt:
+
2016-05-23 Yoav Weiss
Add a few initiator tests to resource timing.
Added: trunk/LayoutTests/http/tests/fetch/caching-with-different-options-expected.txt (0 => 201324)
--- trunk/LayoutTests/http/tests/fetch/caching-with-different-options-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/fetch/caching-with-different-options-expected.txt 2016-05-24 07:35:09 UTC (rev 201324)
@@ -0,0 +1,5 @@
+
+PASS Manual redirect fetch should not disrupt follow redirect fetch of the same resource
+PASS Follow redirect fetch should not disrupt manual redirect fetch of the same resource
+PASS Being loaded resources with different redirect mode should not break each other
+
Added: trunk/LayoutTests/http/tests/fetch/caching-with-different-options.html (0 => 201324)
--- trunk/LayoutTests/http/tests/fetch/caching-with-different-options.html (rev 0)
+++ trunk/LayoutTests/http/tests/fetch/caching-with-different-options.html 2016-05-24 07:35:09 UTC (rev 201324)
@@ -0,0 +1,55 @@
+
+
+
+
+Fetch: retrieve response's body progressively
+
+
+
+
+
+var redirectUrl = "./resources/redirect-with-cache.php?url=""
+function redirectMode(test, redirect, urlSuffix) {
+ var requestInit = {"redirect": redirect};
+ requestInit.headers = [["enablecaching", "true"]];
+ if (redirect === "manual") {
+return fetch(redirectUrl + urlSuffix, requestInit).then(function(response) {
+ assert_equals(response.type, "opaqueredirect", "Response type is opaqueredirect");
+ assert_equals(response.status, 0, "Response status is 0");
+});
+ }
+ else {
+return fetch(redirectUrl + urlSuffix, requestInit).then(function(response) {
+ assert_equals(response.type, "basic", "Response type is basic");
+ assert_equals(response.status, 200, "Response status is 200");
+});
+ }
+}
+
+promise_test(function(test) {
+ return redirectMode(test, "manual", "test1").then(() => {
+return redirectMode(test, "follow", "test1");
+ });
+}, "Manual redirect fetch should not disrupt follow redirect fetch of the same resource");
+
+promise_test(function(test) {
+ return redirectMode(test, "follow", "test2").then(() => {
+return redirectMode(test, "manual", "test2");
+ });
+}, "Follow redirect fetch should not disrupt manual redirect fetch of the same resource");
+
+promise_test(function(test) {
+ return Promise.all([
+redirectMode(test, "follow", "test3"),
+redirectMode(test, "manual", "test3")
+ ]);
+}, "Being loaded resources with different redirect mode should not break each other");
+
+
+
+
Added: trunk/LayoutTests/http/tests/fetch/resources/redirect-with-cache.php (0 => 201324)
--- trunk/LayoutTests/http/tests/fetch/resources/redirect-with-cache.php (rev 0)
+++ trunk/LayoutTests/http/tests/fetch/resources/redirect-with-cache.php 2016-05-24 07:35:09 UTC (rev 201324)
@@ -0,0 +1,14 @@
+
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (201323 => 201324)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-24 06:29:58 UTC (rev 201323)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-24 07:35:09 UTC (rev 201324)
@@ -1,3 +1,16 @@
+2016-05-24 Youenn Fablet
+
+[Fetch API] Implement Fetch redirect mode
+https://bugs.webkit.org/show_bug.cgi?id=157837
+
+Reviewed by Alex Christensen.
+
+* web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
+* web-platform-tests/fetch/api/redirect/redirect-location.js:
+* web-platform-tests/fetch/api/redirect/redirect-method.js:
+* web-platform-tests/fetch/api/redirect/redirect-method-expected.txt:
+* web-platform-tests/fetch/api/redirect/redirect-mode-expected.txt:
+
2016-05-18 Antti Koivisto
Cascading order for !important properties in ::slotted and ::host rules is incorrect
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/
[webkit-changes] [201160] trunk/Source/WebCore
Title: [201160] trunk/Source/WebCore
Revision 201160
Author youenn.fab...@crf.canon.fr
Date 2016-05-19 07:15:09 -0700 (Thu, 19 May 2016)
Log Message
Remove castDOMMobjectForWrapperCreation(T&)
https://bugs.webkit.org/show_bug.cgi?id=157886
Reviewed by Andreas Kling.
No change of behavior.
* bindings/js/JSDOMBinding.h:
(WebCore::castDOMObjectForWrapperCreation): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (201159 => 201160)
--- trunk/Source/WebCore/ChangeLog 2016-05-19 13:22:18 UTC (rev 201159)
+++ trunk/Source/WebCore/ChangeLog 2016-05-19 14:15:09 UTC (rev 201160)
@@ -1,3 +1,15 @@
+2016-05-19 Youenn Fablet
+
+Remove castDOMMobjectForWrapperCreation(T&)
+https://bugs.webkit.org/show_bug.cgi?id=157886
+
+Reviewed by Andreas Kling.
+
+No change of behavior.
+
+* bindings/js/JSDOMBinding.h:
+(WebCore::castDOMObjectForWrapperCreation): Deleted.
+
2016-05-18 Antti Koivisto
Style resolution for explicitly inherited properties is inefficient
Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (201159 => 201160)
--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-19 13:22:18 UTC (rev 201159)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-19 14:15:09 UTC (rev 201160)
@@ -154,9 +154,7 @@
bool clearInlineCachedWrapper(DOMWrapperWorld&, ScriptWrappable*, JSDOMObject* wrapper);
bool clearInlineCachedWrapper(DOMWrapperWorld&, JSC::ArrayBuffer*, JSC::JSArrayBuffer* wrapper);
-template Ref inline castDOMObjectForWrapperCreation(T& object) { return Ref(*static_cast(&object)); }
template Ref inline castDOMObjectForWrapperCreation(Ref&& object) { return static_reference_cast(WTFMove(object)); }
-
#define CREATE_DOM_WRAPPER(globalObject, className, object) createWrapper(globalObject, castDOMObjectForWrapperCreation(object))
template JSC::JSObject* getCachedWrapper(DOMWrapperWorld&, DOMClass&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201129] trunk/Source/WebCore
/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201128 => 201129) --- trunk/Source/WebCore/ChangeLog 2016-05-19 07:14:45 UTC (rev 201128) +++ trunk/Source/WebCore/ChangeLog 2016-05-19 07:32:48 UTC (rev 201129) @@ -1,5 +1,109 @@ 2016-05-19 Youenn Fablet +Refactor toJS functions to use toJSNewlyCreated +https://bugs.webkit.org/show_bug.cgi?id=157835 + +Reviewed by Chris Dumez. + +Moving checks generated by binding generator from toJS to toJSNewlyCreated. +Changing wrap template function to use toJSNewlyCreated function. +This allows DOMClass toJS() to be equivalent to wrap template function. + +Refactored custom binding code to take benefit of this. + +Covered by existing tests. + +* bindings/js/JSAnimationTimelineCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSBlobCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSCSSRuleCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSCSSValueCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSCanvasRenderingContextCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSDOMBinding.h: +(WebCore::wrap): +(WebCore::toJS): +* bindings/js/JSDocumentCustom.cpp: +(WebCore::toJS): +(WebCore::cachedDocumentWrapper): Deleted. +* bindings/js/JSDocumentFragmentCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSEventCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSHTMLCollectionCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSHTMLDocumentCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSHTMLTemplateElementCustom.cpp: +(WebCore::JSHTMLTemplateElement::content): +* bindings/js/JSIDBCursorCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSImageDataCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSMediaStreamCapabilitiesCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSNodeListCustom.h: +(WebCore::toJS): +* bindings/js/JSPerformanceEntryCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSSVGPathSegCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSStyleSheetCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSTextCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSTextTrackCueCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSTrackCustom.cpp: +(WebCore::toJS): +* bindings/js/JSXMLDocumentCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/scripts/CodeGeneratorJS.pm: +(GenerateImplementation): +* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: +* bindings/scripts/test
[webkit-changes] [201128] trunk/Source/WebCore
Title: [201128] trunk/Source/WebCore Revision 201128 Author youenn.fab...@crf.canon.fr Date 2016-05-19 00:14:45 -0700 (Thu, 19 May 2016) Log Message Make binding DOM constructor use toJSNewlyCreated instead of toJS https://bugs.webkit.org/show_bug.cgi?id=157832 Reviewed by Chris Dumez. Using toJSNewlyCreated in generated constructors instead of toJS. Enabling generation of toJS and toJSNewlyCreated for constructable DOM objects. This ensures that toJSNewlyCreated call in constructor will compile properly. Updating some custom code to implement toJSNewlyCreated. Covered by existing tests. * bindings/js/JSImageDataCustom.cpp: (WebCore::toJSNewlyCreated): (WebCore::toJS): * bindings/js/JSTextTrackCueCustom.cpp: (WebCore::toJSNewlyCreated): (WebCore::toJS): * bindings/scripts/CodeGeneratorJS.pm: (ShouldGenerateToJSDeclaration): (GenerateConstructorDefinition): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::construct): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructorNamedConstructor::construct): * bindings/scripts/test/JS/JSTestNode.cpp: (WebCore::JSTestNodeConstructor::construct): (WebCore::toJSNewlyCreated): (WebCore::toJS): * bindings/scripts/test/JS/JSTestNode.h: (WebCore::toJS): (WebCore::toJSNewlyCreated): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::construct): * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::constructJSTestOverloadedConstructors1): (WebCore::constructJSTestOverloadedConstructors2): (WebCore::constructJSTestOverloadedConstructors3): (WebCore::constructJSTestOverloadedConstructors4): (WebCore::constructJSTestOverloadedConstructors5): * bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::JSTestTypedefsConstructor::construct): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSImageDataCustom.cpp trunk/Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201127 => 201128) --- trunk/Source/WebCore/ChangeLog 2016-05-19 05:20:03 UTC (rev 201127) +++ trunk/Source/WebCore/ChangeLog 2016-05-19 07:14:45 UTC (rev 201128) @@ -1,3 +1,49 @@ +2016-05-19 Youenn Fablet + +Make binding DOM constructor use toJSNewlyCreated instead of toJS +https://bugs.webkit.org/show_bug.cgi?id=157832 + +Reviewed by Chris Dumez. + +Using toJSNewlyCreated in generated constructors instead of toJS. +Enabling generation of toJS and toJSNewlyCreated for constructable DOM objects. +This ensures that toJSNewlyCreated call in constructor will compile properly. + +Updating some custom code to implement toJSNewlyCreated. + +Covered by existing tests. + +* bindings/js/JSImageDataCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/js/JSTextTrackCueCustom.cpp: +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/scripts/CodeGeneratorJS.pm: +(ShouldGenerateToJSDeclaration): +(GenerateConstructorDefinition): +* bindings/scripts/test/JS/JSTestInterface.cpp: +(WebCore::JSTestInterfaceConstructor::construct): +* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: +(WebCore::JSTestNamedConstructorNamedConstructor::construct): +* bindings/scripts/test/JS/JSTestNode.cpp: +(WebCore::JSTestNodeConstructor::construct): +(WebCore::toJSNewlyCreated): +(WebCore::toJS): +* bindings/scripts/test/JS/JSTestNode.h: +(WebCore::toJS): +(WebCore::toJSNewlyCreated): +* bindings/scripts/test/JS/JSTestObj.cpp: +(WebCore::JSTestObjConstructor::construct): +* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: +(WebCore::constructJSTestOverloadedConstructors1): +(WebCore::constructJSTestOverloadedConstructors2): +(WebCore::constructJSTestOverloadedConstructors3): +(WebCore::constructJSTestOverloadedConstructors4): +(WebCore::constructJSTestOverloadedConstructors5): +* bindings/scripts/test/JS/JSTestTypedefs.cpp: +(WebCore::JSTestTypedefsConstructor::construct): + 2016-05-18 Zalan Bujtas Make LayoutUnit::operator bool() explicit. Modified: trunk/Source/WebCore/bindings/js/JSImageDataCustom.cpp (201127 => 201128) --- trunk/Source/WebCore/bindings/js/JSImageDataCust
[webkit-changes] [201080] trunk
/error.html trunk/LayoutTests/fast/mediastream/getusermedia-expected.txt trunk/LayoutTests/fast/mediastream/mock-media-source-expected.txt trunk/LayoutTests/fast/regions/selection/crash-deselect-expected.txt trunk/LayoutTests/http/tests/media/media-stream/disconnected-frame-permission-denied-expected.txt trunk/LayoutTests/http/tests/media/media-stream/disconnected-frame-permission-denied.html trunk/LayoutTests/inspector/debugger/regress-133182-expected.txt trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-all-expected.txt trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-none-expected.txt trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-uncaught-expected.txt trunk/LayoutTests/platform/efl/fast/dynamic/015-expected.txt trunk/LayoutTests/platform/gtk/fast/dynamic/015-expected.txt trunk/LayoutTests/platform/ios-simulator/fast/dynamic/015-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-ltr-2-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-ltr-2-left-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-ltr-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-ltr-right-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-rtl-2-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-rtl-2-left-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-rtl-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/editing/selection/caret-rtl-right-expected.txt trunk/LayoutTests/platform/mac/fast/dynamic/015-expected.txt trunk/LayoutTests/platform/win/fast/dynamic/015-expected.txt trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.cpp trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/mediastream/MediaDevices.h trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp trunk/Source/WebCore/bindings/js/JSDOMPromise.h trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/dom/DOMCoreException.cpp trunk/Source/WebCore/dom/ExceptionCode.h trunk/Source/WebCore/html/HTMLMediaElement.cpp Removed Paths trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.cpp trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.h trunk/Source/WebCore/Modules/mediastream/NavigatorUserMediaError.idl Diff Modified: trunk/LayoutTests/ChangeLog (201079 => 201080) --- trunk/LayoutTests/ChangeLog 2016-05-18 14:52:20 UTC (rev 201079) +++ trunk/LayoutTests/ChangeLog 2016-05-18 15:22:37 UTC (rev 201080) @@ -1,3 +1,43 @@ +2016-05-18 Youenn Fablet + +Sync DOM exception types with WebIDL and update promise rejections +https://bugs.webkit.org/show_bug.cgi?id=157792 + +Reviewed by Eric Carlson. + +* fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt: +* fast/inspector-support/uncaught-dom1-exception-expected.txt: +* fast/inspector-support/uncaught-dom3-exception-expected.txt: +* fast/inspector-support/uncaught-dom8-exception-expected.txt: +* fast/mediastream/MediaDevices-getUserMedia-expected.txt: +* fast/mediastream/MediaDevices-getUserMedia.html: +* fast/mediastream/delayed-permission-denied-expected.txt: +* fast/mediastream/delayed-permission-denied.html: +* fast/mediastream/error-expected.txt: +* fast/mediastream/error.html: +* fast/mediastream/getusermedia-expected.txt: +* fast/mediastream/mock-media-source-expected.txt: +* fast/regions/selection/crash-deselect-expected.txt: +* http/tests/media/media-stream/disconnected-frame-permission-denied-expected.txt: +* http/tests/media/media-stream/disconnected-frame-permission-denied.html: +* inspector/debugger/regress-133182-expected.txt: +* inspector/debugger/setPauseOnExceptions-all-expected.txt: +* inspector/debugger/setPauseOnExceptions-none-expected.txt: +* inspector/debugger/setPauseOnExceptions-uncaught-expected.txt: +* platform/efl/fast/dynamic/015-expected.txt: +* platform/gtk/fast/dynamic/015-expected.txt: +* platform/ios-simulator/fast/dynamic/015-expected.txt: +* platform/ios-simulator-wk2/editing/selection/caret-ltr-2-expected.txt: +* platform/ios-simulator-wk2/editing/selection/caret-ltr-2-left-expected.txt: +* platform/ios-simulator-wk2/editing/selection/caret-ltr-expected.txt: +* platform/ios-simulator-wk2/editing/selection/ca
[webkit-changes] [201070] trunk/Source/WebCore
Title: [201070] trunk/Source/WebCore Revision 201070 Author youenn.fab...@crf.canon.fr Date 2016-05-17 20:29:22 -0700 (Tue, 17 May 2016) Log Message Remove toJS template methods taking const Ref and const RefPtr https://bugs.webkit.org/show_bug.cgi?id=157791 Reviewed by Chris Dumez. Updating toJS template method taking a const Ref& to take a Ref&&. Updating toJS template method taking a const RefPtr& to take a RefPtr&&. Updating binding generator to generate rvalue references. Covered by existing tests. * bindings/js/JSDOMBinding.h: (WebCore::toJS): * bindings/scripts/CodeGeneratorJS.pm: (GenerateConstructorDefinition): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::construct): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructorNamedConstructor::construct): * bindings/scripts/test/JS/JSTestNode.cpp: (WebCore::JSTestNodeConstructor::construct): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::construct): * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::constructJSTestOverloadedConstructors1): (WebCore::constructJSTestOverloadedConstructors2): (WebCore::constructJSTestOverloadedConstructors3): (WebCore::constructJSTestOverloadedConstructors4): (WebCore::constructJSTestOverloadedConstructors5): * bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::JSTestTypedefsConstructor::construct): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp trunk/Source/WebCore/html/HTMLMediaElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201069 => 201070) --- trunk/Source/WebCore/ChangeLog 2016-05-18 02:53:45 UTC (rev 201069) +++ trunk/Source/WebCore/ChangeLog 2016-05-18 03:29:22 UTC (rev 201070) @@ -1,3 +1,39 @@ +2016-05-17 Youenn Fablet + +Remove toJS template methods taking const Ref and const RefPtr +https://bugs.webkit.org/show_bug.cgi?id=157791 + +Reviewed by Chris Dumez. + +Updating toJS template method taking a const Ref& to take a Ref&&. +Updating toJS template method taking a const RefPtr& to take a RefPtr&&. +Updating binding generator to generate rvalue references. + +Covered by existing tests. + +* bindings/js/JSDOMBinding.h: +(WebCore::toJS): +* bindings/scripts/CodeGeneratorJS.pm: +(GenerateConstructorDefinition): +* bindings/scripts/test/JS/JSTestInterface.cpp: +(WebCore::JSTestInterfaceConstructor::construct): +* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: +(WebCore::JSTestNamedConstructorNamedConstructor::construct): +* bindings/scripts/test/JS/JSTestNode.cpp: +(WebCore::JSTestNodeConstructor::construct): +* bindings/scripts/test/JS/JSTestObj.cpp: +(WebCore::JSTestObjConstructor::construct): +* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: +(WebCore::constructJSTestOverloadedConstructors1): +(WebCore::constructJSTestOverloadedConstructors2): +(WebCore::constructJSTestOverloadedConstructors3): +(WebCore::constructJSTestOverloadedConstructors4): +(WebCore::constructJSTestOverloadedConstructors5): +* bindings/scripts/test/JS/JSTestTypedefs.cpp: +(WebCore::JSTestTypedefsConstructor::construct): +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): + 2016-05-17 Nan Wang AX: Adding children incorrectly when there are nested inline continuations Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (201069 => 201070) --- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-18 02:53:45 UTC (rev 201069) +++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-18 03:29:22 UTC (rev 201070) @@ -255,8 +255,8 @@ JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, JSC::ArrayBuffer*); JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, JSC::ArrayBufferView*); JSC::JSValue toJS(JSC::ExecState*, JSC::JSGlobalObject*, JSC::ArrayBufferView*); -template JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const RefPtr&); -template JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, const Ref&); +template JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, Ref&&); +template JSC::JSValue toJS(JSC::Exec
[webkit-changes] [201013] trunk/Source
Title: [201013] trunk/Source
Revision 201013
Author youenn.fab...@crf.canon.fr
Date 2016-05-17 03:20:11 -0700 (Tue, 17 May 2016)
Log Message
DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307
Reviewed by Darin Adler.
Source/WebCore:
Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).
Updated DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Relanding without touching JSDOMBinding.h as this seemed to be impacting performances.
Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.
Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.
Covered by existing tests.
Changes should not be visible from user scripts.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
* Modules/fetch/FetchResponse.h:
* Modules/mediastream/MediaDevices.h:
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
* Modules/streams/ReadableStreamSource.h:
* Modules/webaudio/AudioContext.h:
* bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithJSON):
* bindings/js/JSDOMPromise.h:
(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):
* css/FontFace.h:
* css/FontFaceSet.cpp:
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):
* css/FontFaceSet.h:
* html/HTMLMediaElement.h:
Source/WTF:
* wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
* wtf/RefPtr.h: Ditto.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Ref.h
trunk/Source/WTF/wtf/RefPtr.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/mediastream/MediaDevices.h
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.h
trunk/Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp
trunk/Source/WebCore/css/FontFace.h
trunk/Source/WebCore/css/FontFaceSet.cpp
trunk/Source/WebCore/css/FontFaceSet.h
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WTF/ChangeLog (201012 => 201013)
--- trunk/Source/WTF/ChangeLog 2016-05-17 08:47:24 UTC (rev 201012)
+++ trunk/Source/WTF/ChangeLog 2016-05-17 10:20:11 UTC (rev 201013)
@@ -1,3 +1,13 @@
+2016-05-17 Youenn Fablet
+
+DOMPromise should only restrict the resolution type
+https://bugs.webkit.org/show_bug.cgi?id=157307
+
+Reviewed by Darin Adler.
+
+* wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
+* wtf/RefPtr.h: Ditto.
+
2016-05-16 Michael Saboff
ARMV7K: Crash at _javascript_Core: WTF::ScopedLambdaFunctor
Modified: trunk/Source/WTF/wtf/Ref.h (201012 => 201013)
--- trunk/Source/WTF/wtf/Ref.h 2016-05-17 08:47:24 UTC (rev 201012)
+++ trunk/Source/WTF/wtf/Ref.h 2016-05-17 10:20:11 UTC (rev 201013)
@@ -46,6 +46,8 @@
template class Ref {
public:
+static constexpr bool isRef = true;
+
~Ref()
{
#if ASAN_ENABLED
Modified: trunk/Source/WTF/wtf/RefPtr.h (201012 => 201013)
--- trunk/Source/WTF/wtf/RefPtr.h 2016-05-17 08:47:24 UTC (rev 201012)
+++ trunk/Source/WTF/wtf/RefPtr.h 2016-05-17 10:20:11 UTC (rev 201013)
@@ -39,6 +39,8 @@
typedef T ValueType;
typedef ValueType* PtrType;
+static constexpr bool isRefPtr = true;
+
ALWAYS_INLINE RefPtr() : m_ptr(nullptr) { }
ALW
[webkit-changes] [200837] trunk/Source
Title: [200837] trunk/Source
Revision 200837
Author youenn.fab...@crf.canon.fr
Date 2016-05-13 04:03:00 -0700 (Fri, 13 May 2016)
Log Message
DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307
Reviewed by Darin Adler.
Source/WebCore:
Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).
Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted.
This in turn created an unecessary churn count when calling toJS.
Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.
Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.
Covered by existing tests.
Changes should not be visible from user scripts.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
* Modules/fetch/FetchResponse.h:
* Modules/mediastream/MediaDevices.h:
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
* Modules/streams/ReadableStreamSource.h:
* Modules/webaudio/AudioContext.h:
* bindings/js/JSDOMBinding.h:
(WebCore::toJS):
(WebCore::jsPair):
* bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithJSON):
* bindings/js/JSDOMPromise.h:
(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):
* css/FontFace.h:
* css/FontFaceSet.cpp:
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):
* css/FontFaceSet.h:
* html/HTMLMediaElement.h:
Source/WTF:
* wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
* wtf/RefPtr.h: Ditto.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Ref.h
trunk/Source/WTF/wtf/RefPtr.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/mediastream/MediaDevices.h
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.h
trunk/Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp
trunk/Source/WebCore/css/FontFace.h
trunk/Source/WebCore/css/FontFaceSet.cpp
trunk/Source/WebCore/css/FontFaceSet.h
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WTF/ChangeLog (200836 => 200837)
--- trunk/Source/WTF/ChangeLog 2016-05-13 11:02:27 UTC (rev 200836)
+++ trunk/Source/WTF/ChangeLog 2016-05-13 11:03:00 UTC (rev 200837)
@@ -1,3 +1,13 @@
+2016-05-13 Youenn Fablet
+
+DOMPromise should only restrict the resolution type
+https://bugs.webkit.org/show_bug.cgi?id=157307
+
+Reviewed by Darin Adler.
+
+* wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
+* wtf/RefPtr.h: Ditto.
+
2016-05-12 Daniel Bates
Use SecTask SPI to retrieve code signing identifier for user directory suffix
Modified: trunk/Source/WTF/wtf/Ref.h (200836 => 200837)
--- trunk/Source/WTF/wtf/Ref.h 2016-05-13 11:02:27 UTC (rev 200836)
+++ trunk/Source/WTF/wtf/Ref.h 2016-05-13 11:03:00 UTC (rev 200837)
@@ -46,6 +46,8 @@
template class Ref {
public:
+static constexpr bool isRef = true;
+
~Ref()
{
#if ASAN_ENABLED
Modified: trunk/Source/WTF/wtf/RefPtr.h (200836 => 200837)
--- trunk/Source/WTF/wtf/RefPtr.h 2016-05-13 11:02:27 UTC (rev 200836)
+++ trunk/Source/WTF/wtf/RefPt
[webkit-changes] [200766] trunk/Source/WebCore
Title: [200766] trunk/Source/WebCore Revision 200766 Author youenn.fab...@crf.canon.fr Date 2016-05-12 02:36:00 -0700 (Thu, 12 May 2016) Log Message DOMPromise should only restrict the resolution type https://bugs.webkit.org/show_bug.cgi?id=157307 Reviewed by Darin Adler. Removing from DOMPromise the rejection template parameter. Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically). Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&. Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted. This in turn created an unecessary churn count when calling toJS. Changes also allow in most cases to remove the need for explictly declaring the rejection/resolution type. Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper. Covered by existing tests. Changes should not be visible from user scripts. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeText): (WebCore::blobFromArrayBuffer): (WebCore::FetchBody::loadingFailed): * Modules/fetch/FetchBody.h: (WebCore::FetchBody::formData): * Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::arrayBuffer): (WebCore::FetchBodyOwner::blob): (WebCore::FetchBodyOwner::formData): (WebCore::FetchBodyOwner::json): (WebCore::FetchBodyOwner::text): * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::BodyLoader::didReceiveResponse): * Modules/fetch/FetchResponse.h: * Modules/mediastream/MediaDevices.h: * Modules/mediastream/PeerConnectionBackend.h: * Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::didCreateStream): * Modules/streams/ReadableStreamSource.h: * Modules/webaudio/AudioContext.h: * bindings/js/JSDOMBinding.h: (WebCore::toJS): (WebCore::jsPair): * bindings/js/JSDOMPromise.cpp: (WebCore::fulfillPromiseWithJSON): * bindings/js/JSDOMPromise.h: (WebCore::TypeInspector::decltype): (WebCore::TypeInspector::testIsVector): (WebCore::TypeInspector::testIsRefOrRefPtr): (WebCore::DeferredWrapper::resolve): (WebCore::DeferredWrapper::reject): (WebCore::DOMPromise::resolve): (WebCore::DOMPromise::reject): (WebCore::DeferredWrapper::resolveWithValue): (WebCore::DeferredWrapper::rejectWithValue): (WebCore::callPromiseFunction): * bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::importKey): (WebCore::JSSubtleCrypto::unwrapKey): * css/FontFace.h: * css/FontFaceSet.cpp: (WebCore::FontFaceSet::PendingPromise::PendingPromise): (WebCore::FontFaceSet::load): (WebCore::FontFaceSet::registerReady): * css/FontFaceSet.h: * html/HTMLMediaElement.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/Modules/mediastream/MediaDevices.h trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h trunk/Source/WebCore/Modules/webaudio/AudioContext.h trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp trunk/Source/WebCore/bindings/js/JSDOMPromise.h trunk/Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp trunk/Source/WebCore/css/FontFace.h trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/css/FontFaceSet.h trunk/Source/WebCore/html/HTMLMediaElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (200765 => 200766) --- trunk/Source/WebCore/ChangeLog 2016-05-12 09:28:04 UTC (rev 200765) +++ trunk/Source/WebCore/ChangeLog 2016-05-12 09:36:00 UTC (rev 200766) @@ -1,3 +1,74 @@ +2016-05-12 Youenn Fablet + +DOMPromise should only restrict the resolution type +https://bugs.webkit.org/show_bug.cgi?id=157307 + +Reviewed by Darin Adler. + +Removing from DOMPromise the rejection template parameter. +Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically). + +Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&. +Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted. +This in turn created an unecessary churn count when calling toJS. + +Changes also allow in most cases to remove the need for explictly declaring the +rejection/resolution type. + +Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper. + +Covered by existing tests. +Changes should not be visible from user scripts. + +* Modules/fetch/FetchBody.cpp: +(WebCore::FetchBody::consume): +(WebCore::FetchBody::consumeTex
[webkit-changes] [200678] trunk
Title: [200678] trunk Revision 200678 Author youenn.fab...@crf.canon.fr Date 2016-05-11 00:50:49 -0700 (Wed, 11 May 2016) Log Message Ensure DOM iterators remain done https://bugs.webkit.org/show_bug.cgi?id=157453 Reviewed by Darin Adler. Source/WebCore: Covered by updated test. Making DOMWrapped::Iterator an Optional. Setting it to Nullopt on the first time Iterator is returning null. For set iterators, incrementing a counter which value is used in forEach callbacks and entries iterators. * bindings/js/JSDOMIterator.h: (WebCore::JSDOMIterator::asJS): (WebCore::appendForEachArguments): (WebCore::iteratorForEach): (WebCore::JSDOMIterator::next): LayoutTests: * fast/dom/nodeListIterator-expected.txt: * fast/text/font-face-set-_javascript_-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMIterator.h Diff Modified: trunk/LayoutTests/ChangeLog (200677 => 200678) --- trunk/LayoutTests/ChangeLog 2016-05-11 07:14:31 UTC (rev 200677) +++ trunk/LayoutTests/ChangeLog 2016-05-11 07:50:49 UTC (rev 200678) @@ -1,3 +1,13 @@ +2016-05-11 Youenn Fablet + +Ensure DOM iterators remain done +https://bugs.webkit.org/show_bug.cgi?id=157453 + +Reviewed by Darin Adler. + +* fast/dom/nodeListIterator-expected.txt: +* fast/text/font-face-set-_javascript_-expected.txt: + 2016-05-11 Joanmarie Diggs [GTK] accessibility/aria-readonly.html is failing Modified: trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt (200677 => 200678) --- trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt 2016-05-11 07:14:31 UTC (rev 200677) +++ trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt 2016-05-11 07:50:49 UTC (rev 200678) @@ -9,10 +9,10 @@ PASS pair[0] is children[0] PASS pair[1] is children[1] PASS forEachContainer is nodeList -FAIL forEachIndex should be 0 (of type number). Was [object HTMLDivElement] (of type object). +PASS forEachIndex is index PASS node is children[index++] PASS forEachContainer is nodeList -FAIL forEachIndex should be 1 (of type number). Was [object HTMLOListElement] (of type object). +PASS forEachIndex is index PASS node is children[index++] PASS iterator.next().value is children[0] PASS iterator.next().value is children[1] @@ -23,15 +23,15 @@ PASS end.done is true PASS end.value is undefined PASS pair.length is 2 -FAIL pair[0] should be 0 (of type number). Was [object HTMLDivElement] (of type object). +PASS pair[0] is 0 PASS pair[1] is children[0] PASS pair.length is 2 -FAIL pair[0] should be 1 (of type number). Was [object HTMLOListElement] (of type object). +PASS pair[0] is 1 PASS pair[1] is children[1] PASS end.done is true PASS end.value is undefined -FAIL end.done should be true. Was false. -FAIL end.value should be undefined (of type undefined). Was [object HTMLParagraphElement],[object HTMLParagraphElement] (of type object). +PASS end.done is true +PASS end.value is undefined PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt (200677 => 200678) --- trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2016-05-11 07:14:31 UTC (rev 200677) +++ trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt 2016-05-11 07:50:49 UTC (rev 200678) @@ -4,7 +4,7 @@ PASS fontFaceSet.status is "loaded" PASS item.done is false PASS item.value.length is 2 -FAIL item.value[0] should be 0 (of type number). Was [object FontFace] (of type object). +PASS item.value[0] is 0 PASS item.value[1] is fontFace1 PASS item.done is true PASS item.value is undefined Modified: trunk/Source/WebCore/ChangeLog (200677 => 200678) --- trunk/Source/WebCore/ChangeLog 2016-05-11 07:14:31 UTC (rev 200677) +++ trunk/Source/WebCore/ChangeLog 2016-05-11 07:50:49 UTC (rev 200678) @@ -1,3 +1,23 @@ +2016-05-11 Youenn Fablet + +Ensure DOM iterators remain done +https://bugs.webkit.org/show_bug.cgi?id=157453 + +Reviewed by Darin Adler. + +Covered by updated test. + +Making DOMWrapped::Iterator an Optional. +Setting it to Nullopt on the first time Iterator is returning null. + +For set iterators, incrementing a counter which value is used in forEach callbacks and entries iterators. + +* bindings/js/JSDOMIterator.h: +(WebCore::JSDOMIterator::asJS): +(WebCore::appendForEachArguments): +(WebCore::iteratorForEach): +(WebCore::JSDOMIterator::next): + 2016-05-11 Joanmarie Diggs [GTK] accessibility/aria-readonly.html is failing Modified: trunk/Source/WebCore/bindings/js/JSDOMIterator.h (200677 => 200678) --- trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2016-05-11 07:14:31 UTC (rev 200677) +++ trunk/S
[webkit-changes] [200619] trunk
Title: [200619] trunk Revision 200619 Author youenn.fab...@crf.canon.fr Date 2016-05-10 02:47:44 -0700 (Tue, 10 May 2016) Log Message NodeList should be iterable https://bugs.webkit.org/show_bug.cgi?id=131443 Reviewed by Darin Adler. Source/WebCore: Test: fast/dom/nodeListIterator.html Updating JSKeyValueIterator to support map and set iterators, depending on the signature of the result type of DOMClass::Iterator::next method. Symbol.iterator method is made the same as values method for set iterators. Adding support for NodeList. Updating FontFaceSet to take benefit of that. * bindings/js/JSDOMBinding.h: (WebCore::jsPair):. * bindings/js/JSKeyValueIterator.h: (WebCore::IteratorInspector::decltype): IteratorInspector detects whether the iterator is a set or map iterator. (WebCore::IteratorInspector::test): (WebCore::fillForEachArgumentsWithIteratorValue): Specializing according set/map iterator. (WebCore::iteratorValueToJS): Ditto. (WebCore::keyValueIteratorForEach): (WebCore::JSKeyValueIterator::next): * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementationIterableFunctions): Removed the line forbidding set iterators. Making Symbol.iterator function equal to values for set iterators. * bindings/scripts/test/JS/JSTestNode.cpp: Rebasing with set iterator functions. * bindings/scripts/test/JS/JSTestObj.cpp: Rebasing according updated function names. * bindings/scripts/test/TestNode.idl: Making TestNode set iterable. * css/FontFaceSet.cpp: (WebCore::FontFaceSet::Iterator::next): Refactoring to make it a set iterator. * css/FontFaceSet.h: * css/FontFaceSet.idl: * dom/NodeList.h: Making NodeList iterable. (WebCore::NodeList::Iterator::Iterator): (WebCore::NodeList::Iterator::next): (WebCore::NodeList::createIterator): * dom/NodeList.idl: LayoutTests: * fast/dom/domListEnumeration-expected.txt: * fast/dom/nodeListIterator-expected.txt: Added. * fast/dom/nodeListIterator.html: Added. * fast/dom/script-tests/domListEnumeration.js: * fast/text/font-face-set-_javascript_-expected.txt: * fast/text/font-face-set-_javascript_.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt trunk/LayoutTests/fast/dom/script-tests/domListEnumeration.js trunk/LayoutTests/fast/text/font-face-set-_javascript_-expected.txt trunk/LayoutTests/fast/text/font-face-set-_javascript_.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/js/JSDOMIterator.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/TestNode.idl trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/css/FontFaceSet.h trunk/Source/WebCore/css/FontFaceSet.idl trunk/Source/WebCore/dom/NodeList.h trunk/Source/WebCore/dom/NodeList.idl Added Paths trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt trunk/LayoutTests/fast/dom/nodeListIterator.html Diff Modified: trunk/LayoutTests/ChangeLog (200618 => 200619) --- trunk/LayoutTests/ChangeLog 2016-05-10 07:46:08 UTC (rev 200618) +++ trunk/LayoutTests/ChangeLog 2016-05-10 09:47:44 UTC (rev 200619) @@ -1,3 +1,18 @@ +2016-05-10 Youenn Fablet + +NodeList should be iterable +https://bugs.webkit.org/show_bug.cgi?id=131443 + + +Reviewed by Darin Adler. + +* fast/dom/domListEnumeration-expected.txt: +* fast/dom/nodeListIterator-expected.txt: Added. +* fast/dom/nodeListIterator.html: Added. +* fast/dom/script-tests/domListEnumeration.js: +* fast/text/font-face-set-_javascript_-expected.txt: +* fast/text/font-face-set-_javascript_.html: + 2016-05-09 Sergio Villar Senin [css-grid] Implement auto-repeat computation Modified: trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt (200618 => 200619) --- trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt 2016-05-10 07:46:08 UTC (rev 200618) +++ trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt 2016-05-10 09:47:44 UTC (rev 200619) @@ -5,7 +5,7 @@ [object NodeList] -PASS resultArray.length is 11 +PASS resultArray.length is 15 PASS resultArray[0].i is '0' PASS resultArray[0].item is nodeList.item(0) PASS resultArray[1].i is '1' Added: trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt (0 => 200619) --- trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/nodeListIterator-expected.txt 2016-05-10 09:47:44 UTC (rev 200619) @@ -0,0 +1,38 @@ +Testing of NodeList iterable capacities. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS nodeList.length is 2 +PASS item is children[index++] +PASS item is children[index++] +PASS pair[0] is children[0] +PASS pair[1] is children[1] +PAS
[webkit-changes] [200546] trunk/Source/WebCore
Title: [200546] trunk/Source/WebCore Revision 200546 Author youenn.fab...@crf.canon.fr Date 2016-05-07 13:04:27 -0700 (Sat, 07 May 2016) Log Message Rework FontFace promise attribute handling https://bugs.webkit.org/show_bug.cgi?id=157310 Reviewed by Myles C. Maxfield. Making promise attributes cached attributes, so that they are created only once. They are created in the custom binding code and passed to DOM class as needed. Removed usage of ExecState& from DOM iterators. No change should be visible from user scripts. * Modules/fetch/FetchHeaders.cpp: (WebCore::FetchHeaders::Iterator::next): Removing ExecState parameter. * Modules/fetch/FetchHeaders.h: * bindings/js/JSDOMIterator.h: (WebCore::keyValueIteratorForEach): (WebCore::JSDOMIterator::next): Ditto. * bindings/js/JSDOMPromise.cpp: (WebCore::DeferredWrapper::promise): Removed deferred() and added access to promise directly. * bindings/js/JSDOMPromise.h: * bindings/js/JSFontFaceCustom.cpp: (WebCore::JSFontFace::loaded): Using cached attribute to call FontFace::loaded only once. * bindings/js/JSFontFaceSetCustom.cpp: (WebCore::JSFontFaceSet::ready): Using cached attribute to call FontFaceSet::ready only once. * css/CSSFontFace.cpp: (WebCore::CSSFontFace::wrapper): Removing ExecState parameter. * css/CSSFontFace.h: * css/FontFace.cpp: (WebCore::FontFace::create): Ditto. (WebCore::FontFace::FontFace): Ditto. (WebCore::FontFace::fontStateChanged): Updating promise handling. (WebCore::FontFace::registerLoaded): Resolving/rejecting promise if backing CSSFontFace loading is ended. (WebCore::FontFace::load): Calling backing load. * css/FontFace.h: * css/FontFaceSet.cpp: (WebCore::FontFaceSet::Iterator::next): Removing ExecState parameter. (WebCore::FontFaceSet::load): Removing ExecState and ExceptionCode parameter. (WebCore::FontFaceSet::registerReady): Resolving promise if ready otherwise storing it for resolving it later. (WebCore::FontFaceSet::completedLoading): Resolving promise if any is stored. (WebCore::FontFaceSet::create): Deleted. * css/FontFaceSet.h: * css/FontFaceSet.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/bindings/js/JSDOMIterator.h trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp trunk/Source/WebCore/bindings/js/JSDOMPromise.h trunk/Source/WebCore/bindings/js/JSFontFaceCustom.cpp trunk/Source/WebCore/bindings/js/JSFontFaceSetCustom.cpp trunk/Source/WebCore/css/CSSFontFace.cpp trunk/Source/WebCore/css/CSSFontFace.h trunk/Source/WebCore/css/FontFace.cpp trunk/Source/WebCore/css/FontFace.h trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/css/FontFaceSet.h trunk/Source/WebCore/css/FontFaceSet.idl Diff Modified: trunk/Source/WebCore/ChangeLog (200545 => 200546) --- trunk/Source/WebCore/ChangeLog 2016-05-07 20:02:44 UTC (rev 200545) +++ trunk/Source/WebCore/ChangeLog 2016-05-07 20:04:27 UTC (rev 200546) @@ -1,3 +1,49 @@ +2016-05-07 Youenn Fablet + +Rework FontFace promise attribute handling +https://bugs.webkit.org/show_bug.cgi?id=157310 + +Reviewed by Myles C. Maxfield. + +Making promise attributes cached attributes, so that they are created only once. +They are created in the custom binding code and passed to DOM class as needed. + +Removed usage of ExecState& from DOM iterators. + +No change should be visible from user scripts. + +* Modules/fetch/FetchHeaders.cpp: +(WebCore::FetchHeaders::Iterator::next): Removing ExecState parameter. +* Modules/fetch/FetchHeaders.h: +* bindings/js/JSDOMIterator.h: +(WebCore::keyValueIteratorForEach): +(WebCore::JSDOMIterator::next): Ditto. +* bindings/js/JSDOMPromise.cpp: +(WebCore::DeferredWrapper::promise): Removed deferred() and added access to promise directly. +* bindings/js/JSDOMPromise.h: +* bindings/js/JSFontFaceCustom.cpp: +(WebCore::JSFontFace::loaded): Using cached attribute to call FontFace::loaded only once. +* bindings/js/JSFontFaceSetCustom.cpp: +(WebCore::JSFontFaceSet::ready): Using cached attribute to call FontFaceSet::ready only once. +* css/CSSFontFace.cpp: +(WebCore::CSSFontFace::wrapper): Removing ExecState parameter. +* css/CSSFontFace.h: +* css/FontFace.cpp: +(WebCore::FontFace::create): Ditto. +(WebCore::FontFace::FontFace): Ditto. +(WebCore::FontFace::fontStateChanged): Updating promise handling. +(WebCore::FontFace::registerLoaded): Resolving/rejecting promise if backing CSSFontFace loading is ended. +(WebCore::FontFace::load): Calling backing load. +* css/FontFace.h: +* css/FontFaceSet.cpp: +(WebCore::FontFaceSet::Iterator::next): Removing ExecState parameter. +(WebCore::FontFaceSet::load): Removing ExecState and ExceptionCode parameter. +
[webkit-changes] [200414] trunk
Title: [200414] trunk
Revision 200414
Author youenn.fab...@crf.canon.fr
Date 2016-05-04 05:51:28 -0700 (Wed, 04 May 2016)
Log Message
Clicks inside button elements are sometimes discarded when the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=39620
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/events/click-over-descendant-elements.html
* dom/Node.cpp:
(WebCore::ancestor):
(WebCore::commonAncestor): Method inspired from
http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
(WebCore::commonAncestorCrossingShadowBoundary): Helper routine
that handles the case of nodes into a shadow node.
* dom/Node.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent): Selecting click event
target node according commonAncestorOverShadowBoundary method.
(WebCore::EventHandler::targetNodeForClickEvent): Deleted.
LayoutTests:
Test coming from http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
Modified to ensure click events do not end up being considered as double click events.
* fast/events/click-over-descendant-elements-expected.txt: Added.
* fast/events/click-over-descendant-elements.html: Added.
* platform/ios-simulator/TestExpectations: Marked new test as failing.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/fast/events/click-over-descendant-elements-expected.txt
trunk/LayoutTests/fast/events/click-over-descendant-elements.html
Diff
Modified: trunk/LayoutTests/ChangeLog (200413 => 200414)
--- trunk/LayoutTests/ChangeLog 2016-05-04 10:26:29 UTC (rev 200413)
+++ trunk/LayoutTests/ChangeLog 2016-05-04 12:51:28 UTC (rev 200414)
@@ -1,3 +1,17 @@
+2016-05-04 Youenn Fablet
+
+Clicks inside button elements are sometimes discarded when the mouse moves
+https://bugs.webkit.org/show_bug.cgi?id=39620
+
+Reviewed by Darin Adler.
+
+Test coming from http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
+Modified to ensure click events do not end up being considered as double click events.
+
+* fast/events/click-over-descendant-elements-expected.txt: Added.
+* fast/events/click-over-descendant-elements.html: Added.
+* platform/ios-simulator/TestExpectations: Marked new test as failing.
+
2016-05-03 Filip Pizlo
REGRESSION(r200383): Setting lazily initialized properties across frame boundaries crashes
Added: trunk/LayoutTests/fast/events/click-over-descendant-elements-expected.txt (0 => 200414)
--- trunk/LayoutTests/fast/events/click-over-descendant-elements-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/click-over-descendant-elements-expected.txt 2016-05-04 12:51:28 UTC (rev 200414)
@@ -0,0 +1,27 @@
+Check if any mousedown-mouseup pairs in one element dispatch click events.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Very normal click on container:
+PASS lastClickTarget is container
+Move inside container:
+PASS lastClickTarget is container
+Move from container to a child:
+PASS lastClickTarget is container
+Move from a child to container:
+PASS lastClickTarget is container
+Move from a child to another child:
+PASS lastClickTarget is container
+Move out from a child:
+PASS lastClickTarget is document.body
+Removing a child element in the light DOM during a click:
+FAIL lastClickTarget should be null. Was [object HTMLDivElement].
+Click on escaping button content:
+PASS lastClickTarget is button1
+Click on disappearing INPUT value:
+PASS lastClickTarget is input1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/click-over-descendant-elements.html (0 => 200414)
--- trunk/LayoutTests/fast/events/click-over-descendant-elements.html (rev 0)
+++ trunk/LayoutTests/fast/events/click-over-descendant-elements.html 2016-05-04 12:51:28 UTC (rev 200414)
@@ -0,0 +1,144 @@
+
+
+
+body {
+margin: 0;
+padding: 0;
+-webkit-user-select: none;
+}
+
+#container {
+padding: 40px;
+}
+
+#inner1, #inner2 {
+height: 40px;
+}
+
+#button1 {
+padding-top: 4px;
+}
+#button1:active {
+padding-top: 40px;
+}
+</style>
+<div id="container">
+<div id="inner1"></div>
+<div id="inner2"></div>
+</div>
+<button id="button1"><span id="button-span">Click me</span></button>
+<input id="input1" value="A quick brown fox jumps over the lazy dog. A quick brown fox jumps over the lazy dog.">
+<!-- Avoid to create a console element before the above elements -->
+<div id="console"></di
[webkit-changes] [200411] trunk/Source/WebCore
Title: [200411] trunk/Source/WebCore
Revision 200411
Author youenn.fab...@crf.canon.fr
Date 2016-05-04 01:22:18 -0700 (Wed, 04 May 2016)
Log Message
Rename JSKeyValueIterator as JSDOMIterator
https://bugs.webkit.org/show_bug.cgi?id=157308
Reviewed by Darin Adler.
No change of behavior.
* bindings/js/JSDOMIterator.h: Renamed from Source/WebCore/bindings/js/JSKeyValueIterator.h.
(WebCore::JSDOMIteratorPrototype::create):
(WebCore::JSDOMIteratorPrototype::createStructure):
(WebCore::JSDOMIteratorPrototype::JSDOMIteratorPrototype):
(WebCore::createKeyValueIterator):
(WebCore::keyValueIteratorForEach):
(WebCore::JSDOMIterator::destroy):
(WebCore::JSDOMIterator::next):
(WebCore::JSDOMIteratorPrototype::next):
(WebCore::JSDOMIteratorPrototype::finishCreation):
* bindings/js/JSFontFaceSetCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationIterableFunctions):
* bindings/scripts/test/JS/JSTestObj.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSFontFaceSetCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
Added Paths
trunk/Source/WebCore/bindings/js/JSDOMIterator.h
Removed Paths
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (200410 => 200411)
--- trunk/Source/WebCore/ChangeLog 2016-05-04 07:44:40 UTC (rev 200410)
+++ trunk/Source/WebCore/ChangeLog 2016-05-04 08:22:18 UTC (rev 200411)
@@ -1,3 +1,27 @@
+2016-05-04 Youenn Fablet
+
+Rename JSKeyValueIterator as JSDOMIterator
+https://bugs.webkit.org/show_bug.cgi?id=157308
+
+Reviewed by Darin Adler.
+
+No change of behavior.
+
+* bindings/js/JSDOMIterator.h: Renamed from Source/WebCore/bindings/js/JSKeyValueIterator.h.
+(WebCore::JSDOMIteratorPrototype::create):
+(WebCore::JSDOMIteratorPrototype::createStructure):
+(WebCore::JSDOMIteratorPrototype::JSDOMIteratorPrototype):
+(WebCore::createKeyValueIterator):
+(WebCore::keyValueIteratorForEach):
+(WebCore::JSDOMIterator::destroy):
+(WebCore::JSDOMIterator::next):
+(WebCore::JSDOMIteratorPrototype::next):
+(WebCore::JSDOMIteratorPrototype::finishCreation):
+* bindings/js/JSFontFaceSetCustom.cpp:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementationIterableFunctions):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+
2016-05-04 Jiewen Tan
CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
Copied: trunk/Source/WebCore/bindings/js/JSDOMIterator.h (from rev 200410, trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h) (0 => 200411)
--- trunk/Source/WebCore/bindings/js/JSDOMIterator.h (rev 0)
+++ trunk/Source/WebCore/bindings/js/JSDOMIterator.h 2016-05-04 08:22:18 UTC (rev 200411)
@@ -0,0 +1,188 @@
+/*
+ * Copyright (C) 2016 Canon, Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY CANON INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL CANON INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef JSDOMIterator_h
+#define JSDOMIterator_h
+
+#include "JSDOMBinding.h"
+#include
+#include
+
+namespace WebCore {
+
+template
+class JSDOMIteratorPrototype : public JSC::JSNonFinalObject {
+public:
+using Base = JSC::JSNonFinalObject;
+using DOMWrapped = typename JSWrapper::DOMWrapped;
+
+static JSDOMIteratorPrototype* create(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::Structure* structure)
+{
+JSDOMIteratorPrototype* prototype = new (NotNull, JSC::allocateCell(vm.heap)) JSDOMIteratorPrototype(vm, structure);
+prototype->finishCreation(vm, globalO
[webkit-changes] [200303] trunk/LayoutTests/imported/w3c
Title: [200303] trunk/LayoutTests/imported/w3c Revision 200303 Author youenn.fab...@crf.canon.fr Date 2016-05-01 07:09:27 -0700 (Sun, 01 May 2016) Log Message Fix 157169 Update W3C importer files related to csswg-test files after r200234 https://bugs.webkit.org/show_bug.cgi?id=157169 Reviewed by Ryosuke Niwa. Updating ImportExpectations to import css-scoping-1 test suite only from css wg test repository. Updating TestRepositories to set the current csswg-test revision to b2daa426addd5ccb8e9ce1c5d800f9d82603f1ec. Rerun test importer to add some additional files (document, license...). * csswg-test/CONTRIBUTING.md: Added. * csswg-test/LICENSE: Added. * csswg-test/README.md: Added. * csswg-test/w3c-import.log: Added. * resources/ImportExpectations: * resources/TestRepositories: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/ImportExpectations trunk/LayoutTests/imported/w3c/resources/TestRepositories Added Paths trunk/LayoutTests/imported/w3c/csswg-test/CONTRIBUTING.md trunk/LayoutTests/imported/w3c/csswg-test/LICENSE trunk/LayoutTests/imported/w3c/csswg-test/README.md trunk/LayoutTests/imported/w3c/csswg-test/w3c-import.log Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (200302 => 200303) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-01 06:07:35 UTC (rev 200302) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-05-01 14:09:27 UTC (rev 200303) @@ -1,3 +1,23 @@ +2016-05-01 Youenn Fablet + +Fix 157169 + +Update W3C importer files related to csswg-test files after r200234 +https://bugs.webkit.org/show_bug.cgi?id=157169 + +Reviewed by Ryosuke Niwa. + +Updating ImportExpectations to import css-scoping-1 test suite only from css wg test repository. +Updating TestRepositories to set the current csswg-test revision to b2daa426addd5ccb8e9ce1c5d800f9d82603f1ec. +Rerun test importer to add some additional files (document, license...). + +* csswg-test/CONTRIBUTING.md: Added. +* csswg-test/LICENSE: Added. +* csswg-test/README.md: Added. +* csswg-test/w3c-import.log: Added. +* resources/ImportExpectations: +* resources/TestRepositories: + 2016-04-29 Youenn Fablet Regnerate w3c-import.log files after r200109 Added: trunk/LayoutTests/imported/w3c/csswg-test/CONTRIBUTING.md (0 => 200303) --- trunk/LayoutTests/imported/w3c/csswg-test/CONTRIBUTING.md (rev 0) +++ trunk/LayoutTests/imported/w3c/csswg-test/CONTRIBUTING.md 2016-05-01 14:09:27 UTC (rev 200303) @@ -0,0 +1,33 @@ +Grant of License + + +By contributing to this repository, you and the company you +represent, if the company holds any copyrights in the contribution, +grant to the W3C a perpetual, non-exclusive, royalty-free, world- +wide right and license under all of your copyrights in this +contribution to copy, publish, use, and modify the contribution and +to distribute the contribution under a BSD License or one with +more restrictive terms, as well as a right and license of the same +scope to any derivative works prepared by the W3C and based on or +incorporating all or part of the contribution. You further agree +that any derivative works of this contribution prepared by the W3C +shall be solely owned by the W3C. + +You state, to the best of your knowledge, that you, or the company +you represent, have all rights necessary to contribute the materials. + +W3C will retain attribution of initial authorship to you. The W3C +makes no a-priori commitment to support or distribute contributions. + +Disclaimer +-- + +All content from this repository is provided as is, and W3C makes no +representations or warranties, express or implied, including, but +not limited to, warranties of merchantability, fitness for a +particular purpose, non-infringement, or title; nor that the +contents of this repository are suitable for any purpose. We make no +representations, express or implied, that the content of this +repository or the use thereof indicates conformance to a +specification. All content is provided as-is to help reach +interoperability. Added: trunk/LayoutTests/imported/w3c/csswg-test/LICENSE (0 => 200303) --- trunk/LayoutTests/imported/w3c/csswg-test/LICENSE (rev 0) +++ trunk/LayoutTests/imported/w3c/csswg-test/LICENSE 2016-05-01 14:09:27 UTC (rev 200303) @@ -0,0 +1,3 @@ +This repository is covered by the dual-licensing approach described in: + +http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html \ No newline at end of file Added: trunk/LayoutTests/imported/w3c/csswg-test/README.md (0 => 200303) --- trunk/LayoutTests/imported/w3c/csswg-test/README.md (rev 0) +++ trunk/LayoutTests/imported/w3c/csswg-test/README.md 2016-05-01 14:09:27 UTC (rev 200303) @@ -0,0 +1,91 @@ +W3C CSS Test Suite Repository +-
[webkit-changes] [200236] trunk/Source/WebCore
Title: [200236] trunk/Source/WebCore
Revision 200236
Author youenn.fab...@crf.canon.fr
Date 2016-04-29 01:29:13 -0700 (Fri, 29 Apr 2016)
Log Message
Remove UsePointersEvenForNonNullableObjectArguments keyword
https://bugs.webkit.org/show_bug.cgi?id=156844
Reviewed by Darin Adler.
No change of behavior.
* bindings/scripts/CodeGenerator.pm:
(ShouldPassWrapperByReference): Removed UsePointersEvenForNonNullableObjectArguments support.
* bindings/scripts/IDLAttributes.txt: Removed UsePointersEvenForNonNullableObjectArguments.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
Diff
Modified: trunk/Source/WebCore/ChangeLog (200235 => 200236)
--- trunk/Source/WebCore/ChangeLog 2016-04-29 08:15:10 UTC (rev 200235)
+++ trunk/Source/WebCore/ChangeLog 2016-04-29 08:29:13 UTC (rev 200236)
@@ -1,5 +1,18 @@
2016-04-29 Youenn Fablet
+Remove UsePointersEvenForNonNullableObjectArguments keyword
+https://bugs.webkit.org/show_bug.cgi?id=156844
+
+Reviewed by Darin Adler.
+
+No change of behavior.
+
+* bindings/scripts/CodeGenerator.pm:
+(ShouldPassWrapperByReference): Removed UsePointersEvenForNonNullableObjectArguments support.
+* bindings/scripts/IDLAttributes.txt: Removed UsePointersEvenForNonNullableObjectArguments.
+
+2016-04-29 Youenn Fablet
+
FetchResponse should return a ReadableStream even if disturbed
https://bugs.webkit.org/show_bug.cgi?id=156911
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (200235 => 200236)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-04-29 08:15:10 UTC (rev 200235)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-04-29 08:29:13 UTC (rev 200236)
@@ -896,7 +896,6 @@
return 0 if $parameter->isNullable;
return 0 if !$object->IsWrapperType($parameter->type) && !$object->IsTypedArrayType($parameter->type);
return 0 if $object->IsSVGTypeNeedingTearOff($parameter->type);
-return 0 if $interface->extendedAttributes->{"UsePointersEvenForNonNullableObjectArguments"};
return 1;
}
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (200235 => 200236)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-04-29 08:15:10 UTC (rev 200235)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2016-04-29 08:29:13 UTC (rev 200236)
@@ -125,5 +125,4 @@
TypedArray=*
URL
Unforgeable
-UsePointersEvenForNonNullableObjectArguments
WindowEventHandler
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200235] trunk
Title: [200235] trunk
Revision 200235
Author youenn.fab...@crf.canon.fr
Date 2016-04-29 01:15:10 -0700 (Fri, 29 Apr 2016)
Log Message
FetchResponse should return a ReadableStream even if disturbed
https://bugs.webkit.org/show_bug.cgi?id=156911
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt: Rebasing test.
Source/WebCore:
Covered by rebased test.
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::createReadableStreamSource): Asserting in case response is disturbed.
* bindings/js/JSFetchResponseCustom.cpp:
(WebCore::JSFetchResponse::body): Creating a locked empty readable stream if response is disturbed.
* bindings/js/ReadableStreamController.cpp:
(WebCore::createReadableStream): Constructing a readable stream even if source is null.
(WebCore::getReadableStreamReader): Retrieving the reader from a readable stream. Stream must not be locked.
* bindings/js/ReadableStreamController.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/bindings/js/JSFetchResponseCustom.cpp
trunk/Source/WebCore/bindings/js/ReadableStreamController.cpp
trunk/Source/WebCore/bindings/js/ReadableStreamController.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (200234 => 200235)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-29 08:09:36 UTC (rev 200234)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-29 08:15:10 UTC (rev 200235)
@@ -1,3 +1,12 @@
+2016-04-29 Youenn Fablet
+
+FetchResponse should return a ReadableStream even if disturbed
+https://bugs.webkit.org/show_bug.cgi?id=156911
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt: Rebasing test.
+
2016-04-29 Ryosuke Niwa
Import W3C CSS WG tests for shadow DOM
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt (200234 => 200235)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt 2016-04-29 08:09:36 UTC (rev 200234)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt 2016-04-29 08:15:10 UTC (rev 200235)
@@ -1,6 +1,6 @@
-FAIL Getting a body reader after consuming as blob assert_not_equals: got disallowed value null
-FAIL Getting a body reader after consuming as text assert_not_equals: got disallowed value null
-FAIL Getting a body reader after consuming as json assert_not_equals: got disallowed value null
-FAIL Getting a body reader after consuming as arrayBuffer assert_not_equals: got disallowed value null
+PASS Getting a body reader after consuming as blob
+PASS Getting a body reader after consuming as text
+PASS Getting a body reader after consuming as json
+PASS Getting a body reader after consuming as arrayBuffer
Modified: trunk/Source/WebCore/ChangeLog (200234 => 200235)
--- trunk/Source/WebCore/ChangeLog 2016-04-29 08:09:36 UTC (rev 200234)
+++ trunk/Source/WebCore/ChangeLog 2016-04-29 08:15:10 UTC (rev 200235)
@@ -1,3 +1,21 @@
+2016-04-29 Youenn Fablet
+
+FetchResponse should return a ReadableStream even if disturbed
+https://bugs.webkit.org/show_bug.cgi?id=156911
+
+Reviewed by Darin Adler.
+
+Covered by rebased test.
+
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::createReadableStreamSource): Asserting in case response is disturbed.
+* bindings/js/JSFetchResponseCustom.cpp:
+(WebCore::JSFetchResponse::body): Creating a locked empty readable stream if response is disturbed.
+* bindings/js/ReadableStreamController.cpp:
+(WebCore::createReadableStream): Constructing a readable stream even if source is null.
+(WebCore::getReadableStreamReader): Retrieving the reader from a readable stream. Stream must not be locked.
+* bindings/js/ReadableStreamController.h:
+
2016-04-29 Yoav Weiss
Move ResourceTiming behind a runtime flag
Modified: trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp (200234 => 200235)
--- trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp 2016-04-29 08:09:36 UTC (rev 200234)
+++ trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp 2016-04-29 08:15:10 UTC (rev 200235)
@@ -293,7 +293,9 @@
ReadableStreamSource* FetchResponse::createReadableStreamSource()
{
ASSERT(!m_readableStreamSource);
-if (body().isEmpty() || isDisturbed())
+ASSERT(!isDisturbed());
+
+if (body().isEmpty())
return nullptr;
m_readableStreamSource = adoptRef(*new FetchResponseSource(*this));
Modified: trunk/Source/WebCore/bindings/js/JSFetchRespon
[webkit-changes] [200231] trunk
Title: [200231] trunk Revision 200231 Author youenn.fab...@crf.canon.fr Date 2016-04-29 00:18:30 -0700 (Fri, 29 Apr 2016) Log Message Drop [UsePointersEvenForNonNullableObjectArguments] from MediaStream interfaces https://bugs.webkit.org/show_bug.cgi?id=156905 Reviewed by Darin Adler. Source/WebCore: Removing UsePointersEvenForNonNullableObjectArguments from MediaStream, RTCPeerConnection and RTCRtpSender. Updating methods to take references and making some related refactoring. Test: fast/mediastream/MediaStream-add-remove-null-undefined-tracks.html Changes also covered by updated tests. * Modules/mediastream/MediaEndpointPeerConnection.cpp: (WebCore::MediaEndpointPeerConnection::createOfferTask): * Modules/mediastream/MediaStream.cpp: (WebCore::MediaStream::create): (WebCore::MediaStream::addTrack): (WebCore::MediaStream::removeTrack): (WebCore::MediaStream::didAddTrack): (WebCore::MediaStream::didRemoveTrack): (WebCore::MediaStream::internalAddTrack): (WebCore::MediaStream::internalRemoveTrack): * Modules/mediastream/MediaStream.h: * Modules/mediastream/MediaStream.idl: * Modules/mediastream/RTCDataChannel.cpp: (WebCore::RTCDataChannel::send): * Modules/mediastream/RTCDataChannel.h: * Modules/mediastream/RTCDataChannel.idl: * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::addTrack): (WebCore::RTCPeerConnection::removeTrack): (WebCore::RTCPeerConnection::queuedSetLocalDescription): (WebCore::RTCPeerConnection::queuedSetRemoteDescription): (WebCore::RTCPeerConnection::queuedAddIceCandidate): (WebCore::RTCPeerConnection::privateGetStats): (WebCore::RTCPeerConnection::queuedCreateOffer): Deleted. (WebCore::RTCPeerConnection::localDescription): Deleted. (WebCore::RTCPeerConnection::currentLocalDescription): Deleted. (WebCore::RTCPeerConnection::remoteDescription): Deleted. (WebCore::RTCPeerConnection::currentRemoteDescription): Deleted. (WebCore::RTCPeerConnection::signalingState): Deleted. (WebCore::RTCPeerConnection::createDataChannel): Deleted. (WebCore::RTCPeerConnection::close): Deleted. * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/RTCPeerConnection.idl: * Modules/mediastream/RTCRtpReceiver.cpp: (WebCore::RTCRtpReceiver::RTCRtpReceiver): * Modules/mediastream/RTCRtpReceiver.h: (WebCore::RTCRtpReceiver::create): * Modules/mediastream/RTCRtpSender.cpp: (WebCore::RTCRtpSender::RTCRtpSender): (WebCore::RTCRtpSender::replaceTrack): * Modules/mediastream/RTCRtpSender.h: (WebCore::RTCRtpSender::create): * Modules/mediastream/RTCRtpSender.idl: * Modules/mediastream/RTCRtpSenderReceiverBase.h: (WebCore::RTCRtpSenderReceiverBase::track): (WebCore::RTCRtpSenderReceiverBase::RTCRtpSenderReceiverBase): LayoutTests: * fast/mediastream/MediaStream-add-remove-null-undefined-tracks-expected.txt: Added. * fast/mediastream/MediaStream-add-remove-null-undefined-tracks.html: Added. * fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt: Rebasing. * fast/mediastream/RTCPeerConnection-add-removeTrack.html: Adding null/undefined tests for addTrack/removeTrack. * fast/mediastream/RTCPeerConnection-datachannel.html: Adding test for send() method. Test expectation is not rebased as test is timing out and marked as skip. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt trunk/LayoutTests/fast/mediastream/RTCPeerConnection-add-removeTrack.html trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp trunk/Source/WebCore/Modules/mediastream/MediaStream.h trunk/Source/WebCore/Modules/mediastream/MediaStream.idl trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.cpp trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.h trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.idl trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.cpp trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.cpp trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.h trunk/Source/WebCore/Modules/mediastream/RTCRtpSender.idl trunk/Source/WebCore/Modules/mediastream/RTCRtpSenderReceiverBase.h Added Paths trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-null-undefined-tracks-expected.txt trunk/LayoutTests/fast/mediastream/MediaStream-add-remove-null-undefined-tracks.html Diff Modified: trunk/LayoutTests/ChangeLog (200230 => 200231) --- trunk/LayoutTests/ChangeLog 2016-04-29 06:04:06 UTC (rev 200230) +++ trunk/LayoutTests/ChangeLog 2016-04-29 07:18:30 UTC (rev 200231) @@ -1,3 +1,17 @@ +2016-04-29 Youenn Fablet + +D
[webkit-changes] [200204] trunk/LayoutTests
Title: [200204] trunk/LayoutTests Revision 200204 Author youenn.fab...@crf.canon.fr Date 2016-04-28 12:35:30 -0700 (Thu, 28 Apr 2016) Log Message imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots https://bugs.webkit.org/show_bug.cgi?id=157145 Unreviewed. * TestExpectations: Marking imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html as failing and passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (200203 => 200204) --- trunk/LayoutTests/ChangeLog 2016-04-28 19:22:21 UTC (rev 200203) +++ trunk/LayoutTests/ChangeLog 2016-04-28 19:35:30 UTC (rev 200204) @@ -1,3 +1,12 @@ +2016-04-28 Youenn Fablet + +imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html is failing on some bots +https://bugs.webkit.org/show_bug.cgi?id=157145 + +Unreviewed. + +* TestExpectations: Marking imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html as failing and passing. + 2016-04-28 Brady Eidson REGRESSION(r200163): inspector/indexeddb/requestDatabaseNames.html is flaky on Mac. Modified: trunk/LayoutTests/TestExpectations (200203 => 200204) --- trunk/LayoutTests/TestExpectations 2016-04-28 19:22:21 UTC (rev 200203) +++ trunk/LayoutTests/TestExpectations 2016-04-28 19:35:30 UTC (rev 200204) @@ -345,6 +345,7 @@ imported/w3c/web-platform-tests/fetch/nosniff/worker.html [ Skip ] webkit.org/b/157068 imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Skip ] +webkit.org/b/157145 imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html [ Failure Pass ] # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200198] trunk
Title: [200198] trunk
Revision 200198
Author youenn.fab...@crf.canon.fr
Date 2016-04-28 10:36:33 -0700 (Thu, 28 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from MediaSource interfaces
https://bugs.webkit.org/show_bug.cgi?id=156904
Reviewed by Darin Adler.
Source/WebCore:
MediaSource::addSourceBuffer will now throw a TypeError if a null parameter is passed.
MediaSource::removeSourceBuffer will now throw a TypeError if a null parameter is passed.
SourceBuffer::appendBuffer will now throw a TypeError if a null parameter is passed.
Did some refactoring to use more references.
Covered by updated test.
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
* Modules/mediasource/MediaSource.h:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBuffer):
* Modules/mediasource/SourceBuffer.h:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::add):
(WebCore::SourceBufferList::remove):
* Modules/mediasource/SourceBufferList.h:
LayoutTests:
* http/tests/media/media-source/mediasource-addsourcebuffer.html: Changing expected exception to TypeError.
* http/tests/media/media-source/mediasource-append-buffer-expected.txt:
* http/tests/media/media-source/mediasource-append-buffer.html: Checking passing null or undefined to
appendBuffer, addSourceBuffer and removeSourceBuffer.
* media/media-source/media-source-addsourcebuffer-expected.txt:
* media/media-source/media-source-addsourcebuffer.html: Removing redundant test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html
trunk/LayoutTests/http/tests/media/media-source/mediasource-append-buffer-expected.txt
trunk/LayoutTests/http/tests/media/media-source/mediasource-append-buffer.html
trunk/LayoutTests/media/media-source/media-source-addsourcebuffer-expected.txt
trunk/LayoutTests/media/media-source/media-source-addsourcebuffer.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
trunk/Source/WebCore/Modules/mediasource/MediaSource.idl
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.h
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl
trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp
trunk/Source/WebCore/Modules/mediasource/SourceBufferList.h
Diff
Modified: trunk/LayoutTests/ChangeLog (200197 => 200198)
--- trunk/LayoutTests/ChangeLog 2016-04-28 17:35:45 UTC (rev 200197)
+++ trunk/LayoutTests/ChangeLog 2016-04-28 17:36:33 UTC (rev 200198)
@@ -1,3 +1,18 @@
+2016-04-28 Youenn Fablet
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from MediaSource interfaces
+https://bugs.webkit.org/show_bug.cgi?id=156904
+
+Reviewed by Darin Adler.
+
+* http/tests/media/media-source/mediasource-addsourcebuffer.html: Changing expected exception to TypeError.
+* http/tests/media/media-source/mediasource-append-buffer-expected.txt:
+* http/tests/media/media-source/mediasource-append-buffer.html: Checking passing null or undefined to
+appendBuffer, addSourceBuffer and removeSourceBuffer.
+* media/media-source/media-source-addsourcebuffer-expected.txt:
+* media/media-source/media-source-addsourcebuffer.html: Removing redundant test.
+
+
2016-04-27 Ada Chan
Set overflow: hidden on ::-webkit-media-controls in mediaControlsApple.css
Modified: trunk/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html (200197 => 200198)
--- trunk/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html 2016-04-28 17:35:45 UTC (rev 200197)
+++ trunk/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html 2016-04-28 17:36:33 UTC (rev 200198)
@@ -10,7 +10,7 @@
</span><span class="cx"> mediasource_test(function(test, mediaElement, mediaSource)
</span><span class="cx"> {
</span><del>- assert_throws("InvalidAccessError",
</del><ins>+ assert_throws(new TypeError(),
</ins><span class="cx"> function() { mediaSource.addSourceBuffer(""); },
</span><span class="cx"> "addSourceBuffer() threw an exception when passed an empty string.");
</span><span class="cx"> test.done();
</span></span></pre></div>
<a rel="nofollow" id="trunkLayoutTestshttptestsmediamediasourcemediasourceappendbufferexpectedtxt"></a>
<div
[webkit-changes] [200197] trunk/Source/WebCore
Title: [200197] trunk/Source/WebCore Revision 200197 Author youenn.fab...@crf.canon.fr Date 2016-04-28 10:35:45 -0700 (Thu, 28 Apr 2016) Log Message Drop [UsePointersEvenForNonNullableObjectArguments] from Node https://bugs.webkit.org/show_bug.cgi?id=156978 Reviewed by Chris Dumez. No change of behavior. * dom/Node.idl: Marking some parameters nullable. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Node.idl Diff Modified: trunk/Source/WebCore/ChangeLog (200196 => 200197) --- trunk/Source/WebCore/ChangeLog 2016-04-28 17:34:24 UTC (rev 200196) +++ trunk/Source/WebCore/ChangeLog 2016-04-28 17:35:45 UTC (rev 200197) @@ -1,3 +1,14 @@ +2016-04-28 Youenn Fablet + +Drop [UsePointersEvenForNonNullableObjectArguments] from Node +https://bugs.webkit.org/show_bug.cgi?id=156978 + +Reviewed by Chris Dumez. + +No change of behavior. + +* dom/Node.idl: Marking some parameters nullable. + 2016-04-27 Ada Chan Set overflow: hidden on ::-webkit-media-controls in mediaControlsApple.css Modified: trunk/Source/WebCore/dom/Node.idl (200196 => 200197) --- trunk/Source/WebCore/dom/Node.idl 2016-04-28 17:34:24 UTC (rev 200196) +++ trunk/Source/WebCore/dom/Node.idl 2016-04-28 17:35:45 UTC (rev 200197) @@ -19,14 +19,13 @@ */ [ +CustomIsReachable, +CustomToJSObject, +ExportMacro=WEBCORE_EXPORT, JSCustomHeader, JSCustomMarkFunction, JSCustomPushEventHandlerScope, -CustomIsReachable, -CustomToJSObject, -UsePointersEvenForNonNullableObjectArguments, ObjCPolymorphic, -ExportMacro=WEBCORE_EXPORT, ] interface Node #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C : Object, EventTarget @@ -64,12 +63,16 @@ readonly attribute Node rootNode; -[ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node newChild, -Node refChild); -[ObjCLegacyUnnamedParameters, Custom, RaisesException] Node replaceChild(Node newChild, -[CustomReturn] Node oldChild); -[Custom, RaisesException] Node removeChild([CustomReturn] Node oldChild); -[Custom, RaisesException] Node appendChild([CustomReturn] Node newChild); +// FIXME: newChild should not be nullable. +[ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node? newChild, +Node? refChild); +// FIXME: newChild and oldChild should not be nullable. +[ObjCLegacyUnnamedParameters, Custom, RaisesException] Node replaceChild(Node? newChild, +[CustomReturn] Node? oldChild); +// FIXME: oldChild should not be nullable. +[Custom, RaisesException] Node removeChild([CustomReturn] Node? oldChild); +// FIXME: newChild should not be nullable. +[Custom, RaisesException] Node appendChild([CustomReturn] Node? newChild); booleanhasChildNodes(); @@ -101,8 +104,10 @@ // FIXME: the spec says this can also raise on retrieval. [SetterRaisesException] attribute DOMString? textContent; -booleanisSameNode(optional Node other = null); -booleanisEqualNode(optional Node other = null); +// FIXME: other should not be optional. +booleanisSameNode(optional Node? other = null); +// FIXME: other should not be optional. +booleanisEqualNode(optional Node? other = null); DOMString? lookupPrefix(optional DOMString? namespaceURI = null); booleanisDefaultNamespace(optional DOMString? namespaceURI = null); @@ -116,10 +121,12 @@ const unsigned short DOCUMENT_POSITION_CONTAINED_BY = 0x10; const unsigned short DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20; -unsigned short compareDocumentPosition(optional Node other = null); +// FIXME: other should be neither optional nor nullable. +unsigned short compareDocumentPosition(optional Node? other = null); // Introduced in DOM4 -boolean contains(optional Node other = null); +// FIXME: other should not be optional. +boolean contains(optional Node? other = null); // IE extensions readonly attribute Element parentElement; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200123] trunk/Source/WebCore
Title: [200123] trunk/Source/WebCore
Revision 200123
Author youenn.fab...@crf.canon.fr
Date 2016-04-27 02:37:40 -0700 (Wed, 27 Apr 2016)
Log Message
[Fetch API] Remove FetchResponse::redirect overload
https://bugs.webkit.org/show_bug.cgi?id=157034
Reviewed by Darin Adler.
No change of behavior.
* Modules/fetch/FetchResponse.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (200122 => 200123)
--- trunk/Source/WebCore/ChangeLog 2016-04-27 08:35:24 UTC (rev 200122)
+++ trunk/Source/WebCore/ChangeLog 2016-04-27 09:37:40 UTC (rev 200123)
@@ -1,3 +1,14 @@
+2016-04-27 Youenn Fablet
+
+[Fetch API] Remove FetchResponse::redirect overload
+https://bugs.webkit.org/show_bug.cgi?id=157034
+
+Reviewed by Darin Adler.
+
+No change of behavior.
+
+* Modules/fetch/FetchResponse.h:
+
2016-04-27 Csaba Osztrogonác
[Mac][cmake] Unreviewed speculative buildfix after r200116, just for fun.
Modified: trunk/Source/WebCore/Modules/fetch/FetchResponse.h (200122 => 200123)
--- trunk/Source/WebCore/Modules/fetch/FetchResponse.h 2016-04-27 08:35:24 UTC (rev 200122)
+++ trunk/Source/WebCore/Modules/fetch/FetchResponse.h 2016-04-27 09:37:40 UTC (rev 200123)
@@ -52,8 +52,6 @@
static Ref create(ScriptExecutionContext& context) { return adoptRef(*new FetchResponse(context, Type::Default, { }, FetchHeaders::create(FetchHeaders::Guard::Response), ResourceResponse())); }
static Ref error(ScriptExecutionContext&);
static RefPtr redirect(ScriptExecutionContext&, const String&, int, ExceptionCode&);
-// FIXME: Binding generator should not require below method to handle optional status parameter.
-static RefPtr redirect(ScriptExecutionContext& context, const String& url, ExceptionCode& ec) { return redirect(context, url, 302, ec); }
using FetchPromise = DOMPromise, ExceptionCode>;
static void fetch(ScriptExecutionContext&, FetchRequest&, const Dictionary&, FetchPromise&&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200080] trunk
Title: [200080] trunk
Revision 200080
Author youenn.fab...@crf.canon.fr
Date 2016-04-26 06:20:38 -0700 (Tue, 26 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=156901
Reviewed by Darin Adler.
Source/WebCore:
SpeechSynthesis.speak will now throw in case of bad parameters instead of silently failing.
Started refactoring to use more references where possible.
Covered by updated test.
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::startSpeakingImmediately): Refactored to get a reference.
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::fireEvent):
(WebCore::SpeechSynthesis::handleSpeakingCompleted): Removing first item in utteranceQueue unconditionally,
since that would crash in Debug mode otherwise.
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
* Modules/speech/SpeechSynthesis.h:
* Modules/speech/SpeechSynthesis.idl:
LayoutTests:
Updated test to handle speak throwing behavior in case of bad parameters.
* fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt:
* fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt
trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.cpp
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.h
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (200079 => 200080)
--- trunk/LayoutTests/ChangeLog 2016-04-26 13:17:27 UTC (rev 200079)
+++ trunk/LayoutTests/ChangeLog 2016-04-26 13:20:38 UTC (rev 200080)
@@ -1,5 +1,17 @@
2016-04-26 Youenn Fablet
+Drop [UsePointersEvenForNonNullableObjectArguments] from SpeechSynthesis
+https://bugs.webkit.org/show_bug.cgi?id=156901
+
+Reviewed by Darin Adler.
+
+Updated test to handle speak throwing behavior in case of bad parameters.
+
+* fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt:
+* fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html:
+
+2016-04-26 Youenn Fablet
+
Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
https://bugs.webkit.org/show_bug.cgi?id=156977
Modified: trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt (200079 => 200080)
--- trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt 2016-04-26 13:17:27 UTC (rev 200079)
+++ trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt 2016-04-26 13:20:38 UTC (rev 200080)
@@ -3,6 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS speechSynthesis.speak('Hello World') threw exception TypeError: Type error.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html (200079 => 200080)
--- trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html 2016-04-26 13:17:27 UTC (rev 200079)
+++ trunk/LayoutTests/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html 2016-04-26 13:20:38 UTC (rev 200080)
@@ -12,7 +12,7 @@
description("This tests that passing in the wrong type of data won't crash speech synthesis code");
// Don't crash. Speak is supposed to take an utterance, not a string.
- speechSynthesis.speak('Hello World');
+ shouldThrow("speechSynthesis.speak('Hello World')");
// Don't crash. An utterance voice is supposed to take a voice object, not a string.
var x = new SpeechSynthesisUtterance('Hello World');
Modified: trunk/Source/WebCore/ChangeLog (200079 => 200080)
--- trunk/Source/WebCore/ChangeLog 2016-04-26 13:17:27 UTC (rev 200079)
+++ trunk/Source/WebCore/ChangeLog 2016-04-26 13:20:38 UTC (rev 200080)
@@ -1,5 +1,32 @@
2016-04-26 Youenn Fablet
+Drop [UsePointersEvenForNonNullableObjectArguments] from SpeechSynthesis
+https://bugs.webkit.org/show_bug.cgi?id=156901
+
+Reviewed by Darin Adler.
+
+SpeechSynthesis.speak will now throw in case of bad parameters instead of silently failing.
+Started refactoring to use more references where possible.
+
+Covered by updated test.
+
+* Modules/speech/SpeechSynthesis.cpp:
+(WebCore::SpeechSynthesis::startSpeakin
[webkit-changes] [200079] trunk/Source/WebCore
Title: [200079] trunk/Source/WebCore
Revision 200079
Author youenn.fab...@crf.canon.fr
Date 2016-04-26 06:17:27 -0700 (Tue, 26 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
https://bugs.webkit.org/show_bug.cgi?id=156979
Reviewed by Chris Dumez.
No change of behavior.
* dom/WebKitNamedFlow.idl: Marking contentNode parameter as nullable.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitNamedFlow.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (200078 => 200079)
--- trunk/Source/WebCore/ChangeLog 2016-04-26 13:03:13 UTC (rev 200078)
+++ trunk/Source/WebCore/ChangeLog 2016-04-26 13:17:27 UTC (rev 200079)
@@ -1,5 +1,16 @@
2016-04-26 Youenn Fablet
+Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
+https://bugs.webkit.org/show_bug.cgi?id=156979
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+* dom/WebKitNamedFlow.idl: Marking contentNode parameter as nullable.
+
+2016-04-26 Youenn Fablet
+
Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
https://bugs.webkit.org/show_bug.cgi?id=156977
Modified: trunk/Source/WebCore/dom/WebKitNamedFlow.idl (200078 => 200079)
--- trunk/Source/WebCore/dom/WebKitNamedFlow.idl 2016-04-26 13:03:13 UTC (rev 200078)
+++ trunk/Source/WebCore/dom/WebKitNamedFlow.idl 2016-04-26 13:17:27 UTC (rev 200079)
@@ -28,15 +28,15 @@
*/
[
-UsePointersEvenForNonNullableObjectArguments,
+GenerateIsReachable=ImplOwnerNodeRoot,
NoInterfaceObject,
-GenerateIsReachable=ImplOwnerNodeRoot,
] interface WebKitNamedFlow : EventTarget
{
readonly attribute DOMString name;
readonly attribute boolean overset;
readonly attribute long firstEmptyRegionIndex;
-NodeList getRegionsByContent(Node contentNode);
+// FIXME: contentNode should not be nullable.
+NodeList getRegionsByContent(Node? contentNode);
NodeList getRegions();
NodeList getContent();
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [200078] trunk
Title: [200078] trunk
Revision 200078
Author youenn.fab...@crf.canon.fr
Date 2016-04-26 06:03:13 -0700 (Tue, 26 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
https://bugs.webkit.org/show_bug.cgi?id=156977
Reviewed by Chris Dumez.
Source/WebCore:
No change of behavior.
* dom/EventTarget.idl:
LayoutTests:
* fast/events/dispatchEvent-crash-expected.txt:
* fast/events/dispatchEvent-crash.html: Ensuring exceptions are logged.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt
trunk/LayoutTests/fast/events/dispatchEvent-crash.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventTarget.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (200077 => 200078)
--- trunk/LayoutTests/ChangeLog 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/ChangeLog 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1,3 +1,13 @@
+2016-04-26 Youenn Fablet
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from EventTarget
+https://bugs.webkit.org/show_bug.cgi?id=156977
+
+Reviewed by Chris Dumez.
+
+* fast/events/dispatchEvent-crash-expected.txt:
+* fast/events/dispatchEvent-crash.html: Ensuring exceptions are logged.
+
2016-04-25 Ryosuke Niwa
Update template element tests
Modified: trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt (200077 => 200078)
--- trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/fast/events/dispatchEvent-crash-expected.txt 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1 +1,28 @@
This is a test for https://bugs.webkit.org/show_bug.cgi?id=21063 (NULL pointer crash in dispatchEvent(null)). It passes if it does not crash.
+
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+Exception thrown for null: TypeError: Type error
+Exception thrown for undefined: TypeError: Type error
+Exception thrown for string: TypeError: Type error
+Exception thrown for 0: TypeError: Type error
+Exception thrown for object: TypeError: Type error
+
Modified: trunk/LayoutTests/fast/events/dispatchEvent-crash.html (200077 => 200078)
--- trunk/LayoutTests/fast/events/dispatchEvent-crash.html 2016-04-26 08:16:24 UTC (rev 200077)
+++ trunk/LayoutTests/fast/events/dispatchEvent-crash.html 2016-04-26 13:03:13 UTC (rev 200078)
@@ -1,5 +1,10 @@
This is a test for https://bugs.webkit.org/show_bug.cgi?id=21063 (NULL pointer crash in dispatchEvent(null)). It passes if it does not crash.
+
</span><ins>+function log(message) {
+document.getElementById("log").innerHTML += message + "<br>";
+}
+
</ins><span class="cx"> if (window.testRunner)
</span><span class="cx"> testRunner.dumpAsText();
</span><span class="cx">
</span><span class="lines">@@ -11,26 +16,31 @@
</span><span class="cx"> try {
</span><span class="cx"> eventTarget.dispatchEvent(null);
</span><span class="cx"> } catch(e) {
</span><ins>+log("Exception thrown for null: " + e);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> try {
</span><span class="cx"> eventTarget.dispatchEvent(undefined);
</span><span class="cx"> } catch(e) {
</span><ins>+log("Exception thrown for undefined: " + e);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> try {
</span><span class="cx"> eventTarget.dispatchEvent("string&qu
[webkit-changes] [199986] trunk/Source/WebCore
Title: [199986] trunk/Source/WebCore Revision 199986 Author youenn.fab...@crf.canon.fr Date 2016-04-25 03:26:53 -0700 (Mon, 25 Apr 2016) Log Message Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack https://bugs.webkit.org/show_bug.cgi?id=156899 Reviewed by Chris Dumez. No behavior changes. * html/track/TextTrack.idl: Marking cue and region parameter as nullable. Also marking cues and activeCues as nullable attributes. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/track/TextTrack.idl Diff Modified: trunk/Source/WebCore/ChangeLog (199985 => 199986) --- trunk/Source/WebCore/ChangeLog 2016-04-25 10:23:41 UTC (rev 199985) +++ trunk/Source/WebCore/ChangeLog 2016-04-25 10:26:53 UTC (rev 199986) @@ -1,5 +1,17 @@ 2016-04-25 Youenn Fablet +Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack +https://bugs.webkit.org/show_bug.cgi?id=156899 + +Reviewed by Chris Dumez. + +No behavior changes. + +* html/track/TextTrack.idl: Marking cue and region parameter as nullable. +Also marking cues and activeCues as nullable attributes. + +2016-04-25 Youenn Fablet + Drop [UsePointersEvenForNonNullableObjectArguments] from File API interfaces https://bugs.webkit.org/show_bug.cgi?id=156898 Modified: trunk/Source/WebCore/html/track/TextTrack.idl (199985 => 199986) --- trunk/Source/WebCore/html/track/TextTrack.idl 2016-04-25 10:23:41 UTC (rev 199985) +++ trunk/Source/WebCore/html/track/TextTrack.idl 2016-04-25 10:26:53 UTC (rev 199986) @@ -28,7 +28,6 @@ [ Conditional=VIDEO_TRACK, -UsePointersEvenForNonNullableObjectArguments, GenerateIsReachable=ImplElementRoot, JSCustomMarkFunction, SkipVTableValidation, @@ -41,17 +40,19 @@ attribute TextTrackMode mode; -readonly attribute TextTrackCueList cues; -readonly attribute TextTrackCueList activeCues; +readonly attribute TextTrackCueList? cues; +readonly attribute TextTrackCueList? activeCues; -[RaisesException] void addCue(TextTrackCue cue); -[RaisesException] void removeCue(TextTrackCue cue); +// FIXME: cue parameter should not be nullable in addCue and removeCue. +[RaisesException] void addCue(TextTrackCue? cue); +[RaisesException] void removeCue(TextTrackCue? cue); attribute EventHandler oncuechange; #if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT // Work around shortcomings in the gobject binding generator handling of conditional features by turning these off for gobject. readonly attribute VTTRegionList regions; -void addRegion(VTTRegion region); -[RaisesException] void removeRegion(VTTRegion region); +// FIXME: region parameter should not be nullable in addRegion and removeRegion. +void addRegion(VTTRegion? region); +[RaisesException] void removeRegion(VTTRegion? region); #endif }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [199985] trunk
Title: [199985] trunk Revision 199985 Author youenn.fab...@crf.canon.fr Date 2016-04-25 03:23:41 -0700 (Mon, 25 Apr 2016) Log Message Drop [UsePointersEvenForNonNullableObjectArguments] from File API interfaces https://bugs.webkit.org/show_bug.cgi?id=156898 Reviewed by Chris Dumez. Source/WebCore: Making FileReaderSync API API throwing a TypeError in case of null parameters, in lieu of a NOT_FOUND_ERR. Making FileReader API taking nullable parameters as a temporary fix. Test: fast/files/workers/worker-file-reader-sync-bad-parameter.html * Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processOutgoingFrameQueue): Updated to cope with FileReaderLoader::start taking a Blob&. * fileapi/FileReader.cpp: (WebCore::FileReader::readAsArrayBuffer): Updated to cope with readInternal taking a Blob&. (WebCore::FileReader::readAsBinaryString): Ditto. (WebCore::FileReader::readAsText): Ditto. (WebCore::FileReader::readAsDataURL): Ditto. (WebCore::FileReader::readInternal): Updated to cope with FileReaderLoader::start taking a Blob&. * fileapi/FileReader.h: * fileapi/FileReader.idl: Marking the readXX methods as taking a nullable blob parameter to keep compatibility, at least temporarily. * fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::start): It now takes a Blob& as input. * fileapi/FileReaderLoader.h: * fileapi/FileReaderSync.cpp: (WebCore::FileReaderSync::readAsArrayBuffer): Taking a Blob& as input. (WebCore::FileReaderSync::readAsBinaryString): Ditto. (WebCore::FileReaderSync::readAsText): Ditto. (WebCore::FileReaderSync::readAsDataURL): Ditto. (WebCore::FileReaderSync::startLoading) Ditto. * fileapi/FileReaderSync.h: (WebCore::FileReaderSync::readAsText): Ditto. * fileapi/FileReaderSync.idl: LayoutTests: Checking FileReaderSync send method in case of null or undefined blob parameter. worker-read-blob-sync.html and worker-read-file-sync check the case of badly typed parameters. In all cases, TypeError is thrown. * fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js: Added. (test): * fast/files/workers/worker-file-reader-sync-bad-parameter-expected.txt: Added. * fast/files/workers/worker-file-reader-sync-bad-parameter.html: Added. * fast/files/workers/worker-read-blob-sync-expected.txt: Rebasing expectation. * fast/files/workers/worker-read-file-sync-expected.txt: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/files/workers/worker-read-blob-sync-expected.txt trunk/LayoutTests/fast/files/workers/worker-read-file-sync-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp trunk/Source/WebCore/fileapi/FileReader.cpp trunk/Source/WebCore/fileapi/FileReader.h trunk/Source/WebCore/fileapi/FileReader.idl trunk/Source/WebCore/fileapi/FileReaderLoader.cpp trunk/Source/WebCore/fileapi/FileReaderLoader.h trunk/Source/WebCore/fileapi/FileReaderSync.cpp trunk/Source/WebCore/fileapi/FileReaderSync.h trunk/Source/WebCore/fileapi/FileReaderSync.idl Added Paths trunk/LayoutTests/fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js trunk/LayoutTests/fast/files/workers/worker-file-reader-sync-bad-parameter-expected.txt trunk/LayoutTests/fast/files/workers/worker-file-reader-sync-bad-parameter.html Diff Modified: trunk/LayoutTests/ChangeLog (199984 => 199985) --- trunk/LayoutTests/ChangeLog 2016-04-25 10:08:13 UTC (rev 199984) +++ trunk/LayoutTests/ChangeLog 2016-04-25 10:23:41 UTC (rev 199985) @@ -1,3 +1,21 @@ +2016-04-25 Youenn Fablet + +Drop [UsePointersEvenForNonNullableObjectArguments] from File API interfaces +https://bugs.webkit.org/show_bug.cgi?id=156898 + +Reviewed by Chris Dumez. + +Checking FileReaderSync send method in case of null or undefined blob parameter. +worker-read-blob-sync.html and worker-read-file-sync check the case of badly typed parameters. +In all cases, TypeError is thrown. + +* fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js: Added. +(test): +* fast/files/workers/worker-file-reader-sync-bad-parameter-expected.txt: Added. +* fast/files/workers/worker-file-reader-sync-bad-parameter.html: Added. +* fast/files/workers/worker-read-blob-sync-expected.txt: Rebasing expectation. +* fast/files/workers/worker-read-file-sync-expected.txt: Ditto. + 2016-04-25 Manuel Rego Casasnovas [css-grid] Fix grid-template-columns|rows computed style with content alignment Added: trunk/LayoutTests/fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js (0 => 199985) --- trunk/LayoutTests/fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js (rev 0) +++ trunk/LayoutTests/fast/files/workers/resources/worker-file-reader-sync-bad-parameter.js 2016-04-25 10:23:41 UTC (rev 199985) @@ -0,0 +1,19 @@ +if (self.importScripts) + self.importScri
[webkit-changes] [199963] trunk/Source/WebCore
Title: [199963] trunk/Source/WebCore
Revision 199963
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:45:44 -0700 (Sun, 24 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from MediaControlsHost
https://bugs.webkit.org/show_bug.cgi?id=156903
Reviewed by Chris Dumez.
No change of behavior.
* Modules/mediacontrols/MediaControlsHost.idl: Marking some parameters as nullable.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (199962 => 199963)
--- trunk/Source/WebCore/ChangeLog 2016-04-24 12:45:06 UTC (rev 199962)
+++ trunk/Source/WebCore/ChangeLog 2016-04-24 12:45:44 UTC (rev 199963)
@@ -1,5 +1,16 @@
2016-04-24 Youenn Fablet
+Drop [UsePointersEvenForNonNullableObjectArguments] from MediaControlsHost
+https://bugs.webkit.org/show_bug.cgi?id=156903
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+* Modules/mediacontrols/MediaControlsHost.idl: Marking some parameters as nullable.
+
+2016-04-24 Youenn Fablet
+
Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=156909
Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl (199962 => 199963)
--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl 2016-04-24 12:45:06 UTC (rev 199962)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl 2016-04-24 12:45:44 UTC (rev 199963)
@@ -30,19 +30,18 @@
};
[
-NoInterfaceObject,
Conditional=MEDIA_CONTROLS_SCRIPT,
-UsePointersEvenForNonNullableObjectArguments,
ImplementationLacksVTable,
+NoInterfaceObject,
] interface MediaControlsHost {
-TextTrack[] sortedTrackListForMenu(TextTrackList trackList);
-AudioTrack[] sortedTrackListForMenu(AudioTrackList trackList);
-DOMString displayNameForTrack(TextTrack track);
-DOMString displayNameForTrack(AudioTrack track);
+TextTrack[] sortedTrackListForMenu(TextTrackList? trackList);
+AudioTrack[] sortedTrackListForMenu(AudioTrackList? trackList);
+DOMString displayNameForTrack(TextTrack? track);
+DOMString displayNameForTrack(AudioTrack? track);
readonly attribute TextTrack captionMenuOffItem;
readonly attribute TextTrack captionMenuAutomaticItem;
readonly attribute DOMString captionDisplayMode;
-void setSelectedTextTrack(TextTrack track);
+void setSelectedTextTrack(TextTrack? track);
readonly attribute HTMLElement textTrackContainer;
readonly attribute boolean allowsInlineMediaPlayback;
readonly attribute boolean supportsFullscreen;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [199962] trunk/Source/WebCore
Title: [199962] trunk/Source/WebCore
Revision 199962
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:45:06 -0700 (Sun, 24 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=156909
Reviewed by Chris Dumez.
No change of behavior.
Marking a lot of method parameters as nullable.
* html/canvas/WebGLRenderingContextBase.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (199961 => 199962)
--- trunk/Source/WebCore/ChangeLog 2016-04-24 12:37:43 UTC (rev 199961)
+++ trunk/Source/WebCore/ChangeLog 2016-04-24 12:45:06 UTC (rev 199962)
@@ -1,5 +1,18 @@
2016-04-24 Youenn Fablet
+Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
+https://bugs.webkit.org/show_bug.cgi?id=156909
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+Marking a lot of method parameters as nullable.
+
+* html/canvas/WebGLRenderingContextBase.idl:
+
+2016-04-24 Youenn Fablet
+
Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
https://bugs.webkit.org/show_bug.cgi?id=156897
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl (199961 => 199962)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl 2016-04-24 12:37:43 UTC (rev 199961)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl 2016-04-24 12:45:06 UTC (rev 199962)
@@ -39,11 +39,10 @@
typedef unrestricted float GLclampf;
[
-NoInterfaceObject,
Conditional=WEBGL,
-JSCustomMarkFunction,
-UsePointersEvenForNonNullableObjectArguments,
DoNotCheckConstants,
+JSCustomMarkFunction,
+NoInterfaceObject,
] interface WebGLRenderingContextBase : CanvasRenderingContext {
/* ClearBufferMask */
@@ -469,12 +468,12 @@
readonly attribute GLsizei drawingBufferHeight;
[StrictTypeChecking, RaisesException] void activeTexture(GLenum texture);
-[StrictTypeChecking, RaisesException] void attachShader(WebGLProgram program, WebGLShader shader);
-[StrictTypeChecking, RaisesException] void bindAttribLocation(WebGLProgram program, GLuint index, DOMString name);
-[StrictTypeChecking, RaisesException] void bindBuffer(GLenum target, WebGLBuffer buffer);
-[StrictTypeChecking, RaisesException] void bindFramebuffer(GLenum target, WebGLFramebuffer framebuffer);
-[StrictTypeChecking, RaisesException] void bindRenderbuffer(GLenum target, WebGLRenderbuffer renderbuffer);
-[StrictTypeChecking, RaisesException] void bindTexture(GLenum target, WebGLTexture texture);
+[StrictTypeChecking, RaisesException] void attachShader(WebGLProgram? program, WebGLShader? shader);
+[StrictTypeChecking, RaisesException] void bindAttribLocation(WebGLProgram? program, GLuint index, DOMString name);
+[StrictTypeChecking, RaisesException] void bindBuffer(GLenum target, WebGLBuffer? buffer);
+[StrictTypeChecking, RaisesException] void bindFramebuffer(GLenum target, WebGLFramebuffer? framebuffer);
+[StrictTypeChecking, RaisesException] void bindRenderbuffer(GLenum target, WebGLRenderbuffer? renderbuffer);
+[StrictTypeChecking, RaisesException] void bindTexture(GLenum target, WebGLTexture? texture);
[StrictTypeChecking] void blendColor(GLclampf red, GLclampf green, GLclampf blue, GLclampf alpha);
[StrictTypeChecking] void blendEquation(GLenum mode);
[StrictTypeChecking] void blendEquationSeparate(GLenum modeRGB, GLenum modeAlpha);
@@ -492,7 +491,7 @@
[StrictTypeChecking] void clearDepth(GLclampf depth);
[StrictTypeChecking] void clearStencil(GLint s);
[StrictTypeChecking] void colorMask(GLboolean red, GLboolean green, GLboolean blue, GLboolean alpha);
-[StrictTypeChecking, RaisesException] void compileShader(WebGLShader shader);
+[StrictTypeChecking, RaisesException] void compileShader(WebGLShader? shader);
[StrictTypeChecking] void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,
GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
@@ -511,17 +510,17 @@
[StrictTypeChecking] void cullFace(GLenum mode);
-[StrictTypeChecking] void deleteBuffer(WebGLBuffer buffer);
-[StrictTypeChecking] void deleteFramebuffer(WebGLFramebuffer framebuffer);
-[StrictTypeChecking] void deleteProgram(WebGLProgram program);
-[StrictTypeChecking] void deleteRenderbuffer(WebGLRenderbuffer renderbuffer);
-[StrictTypeChecking] void deleteShader(WebGLShader shader);
-[StrictTypeChecking] void deleteT
[webkit-changes] [199961] trunk/Source/WebCore
Title: [199961] trunk/Source/WebCore
Revision 199961
Author youenn.fab...@crf.canon.fr
Date 2016-04-24 05:37:43 -0700 (Sun, 24 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
https://bugs.webkit.org/show_bug.cgi?id=156897
Reviewed by Chris Dumez.
No change of behavior.
Updating WebSocket::send methods to take references, except for ArrayBufferView, which is not yet supported by the binding generator.
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocket.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp
trunk/Source/WebCore/Modules/websockets/WebSocket.h
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (199960 => 199961)
--- trunk/Source/WebCore/ChangeLog 2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/ChangeLog 2016-04-24 12:37:43 UTC (rev 199961)
@@ -1,3 +1,19 @@
+2016-04-24 Youenn Fablet
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from WebSocket
+https://bugs.webkit.org/show_bug.cgi?id=156897
+
+Reviewed by Chris Dumez.
+
+No change of behavior.
+
+Updating WebSocket::send methods to take references, except for ArrayBufferView, which is not yet supported by the binding generator.
+
+* Modules/websockets/WebSocket.cpp:
+(WebCore::WebSocket::send):
+* Modules/websockets/WebSocket.h:
+* Modules/websockets/WebSocket.idl:
+
2016-04-23 Andy Estes
Fix issues found by the clang static analyzer
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (199960 => 199961)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2016-04-24 12:37:43 UTC (rev 199961)
@@ -322,22 +322,21 @@
}
}
-void WebSocket::send(ArrayBuffer* binaryData, ExceptionCode& ec)
+void WebSocket::send(ArrayBuffer& binaryData, ExceptionCode& ec)
{
-LOG(Network, "WebSocket %p send() Sending ArrayBuffer %p", this, binaryData);
-ASSERT(binaryData);
+LOG(Network, "WebSocket %p send() Sending ArrayBuffer %p", this, &binaryData);
if (m_state == CONNECTING) {
ec = INVALID_STATE_ERR;
return;
}
if (m_state == CLOSING || m_state == CLOSED) {
-unsigned payloadSize = binaryData->byteLength();
+unsigned payloadSize = binaryData.byteLength();
m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, payloadSize);
m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, getFramingOverhead(payloadSize));
return;
}
ASSERT(m_channel);
-m_channel->send(*binaryData, 0, binaryData->byteLength());
+m_channel->send(binaryData, 0, binaryData.byteLength());
}
void WebSocket::send(ArrayBufferView* arrayBufferView, ExceptionCode& ec)
@@ -359,21 +358,21 @@
m_channel->send(*arrayBuffer, arrayBufferView->byteOffset(), arrayBufferView->byteLength());
}
-void WebSocket::send(Blob* binaryData, ExceptionCode& ec)
+void WebSocket::send(Blob& binaryData, ExceptionCode& ec)
{
-LOG(Network, "WebSocket %p send() Sending Blob '%s'", this, binaryData->url().stringCenterEllipsizedToLength().utf8().data());
+LOG(Network, "WebSocket %p send() Sending Blob '%s'", this, binaryData.url().stringCenterEllipsizedToLength().utf8().data());
if (m_state == CONNECTING) {
ec = INVALID_STATE_ERR;
return;
}
if (m_state == CLOSING || m_state == CLOSED) {
-unsigned long payloadSize = static_cast(binaryData->size());
+unsigned long payloadSize = static_cast(binaryData.size());
m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, payloadSize);
m_bufferedAmountAfterClose = saturateAdd(m_bufferedAmountAfterClose, getFramingOverhead(payloadSize));
return;
}
ASSERT(m_channel);
-m_channel->send(*binaryData);
+m_channel->send(binaryData);
}
void WebSocket::close(int code, const String& reason, ExceptionCode& ec)
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (199960 => 199961)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.h 2016-04-24 02:49:49 UTC (rev 199960)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h 2016-04-24 12:37:43 UTC (rev 199961)
@@ -72,9 +72,9 @@
void connect(const String& url, const Vector& protocols, ExceptionCode&);
void send(const String& message, ExceptionCode&);
-void send(JSC::ArrayBuffer*, ExceptionCode&);
+void send(JSC::ArrayBuffer&, ExceptionCode&);
void send(JSC::ArrayBufferView*, ExceptionCode&);
-void send(Blob*, Exce
[webkit-changes] [199879] trunk/Source/WebCore
Title: [199879] trunk/Source/WebCore
Revision 199879
Author youenn.fab...@crf.canon.fr
Date 2016-04-22 09:13:05 -0700 (Fri, 22 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from InspectorFrontendHost
https://bugs.webkit.org/show_bug.cgi?id=156908
Reviewed by Timothy Hatcher.
No change of behavior.
* inspector/InspectorFrontendHost.idl: Marking event parameter as nullable to keep compatibility.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (199878 => 199879)
--- trunk/Source/WebCore/ChangeLog 2016-04-22 15:59:10 UTC (rev 199878)
+++ trunk/Source/WebCore/ChangeLog 2016-04-22 16:13:05 UTC (rev 199879)
@@ -1,3 +1,14 @@
+2016-04-22 Youenn Fablet
+
+Drop [UsePointersEvenForNonNullableObjectArguments] from InspectorFrontendHost
+https://bugs.webkit.org/show_bug.cgi?id=156908
+
+Reviewed by Timothy Hatcher.
+
+No change of behavior.
+
+* inspector/InspectorFrontendHost.idl: Marking event parameter as nullable to keep compatibility.
+
2016-04-22 Chris Dumez
Drop [UsePointersEvenForNonNullableObjectArguments] from MutationObserver
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (199878 => 199879)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2016-04-22 15:59:10 UTC (rev 199878)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2016-04-22 16:13:05 UTC (rev 199879)
@@ -31,9 +31,8 @@
*/
[
+ImplementationLacksVTable,
NoInterfaceObject,
-UsePointersEvenForNonNullableObjectArguments,
-ImplementationLacksVTable
] interface InspectorFrontendHost {
void loaded();
void closeWindow();
@@ -67,7 +66,7 @@
DOMString port();
[Custom] void showContextMenu(MouseEvent event, any items);
-void dispatchEventAsContextMenuEvent(Event event);
+void dispatchEventAsContextMenuEvent(Event? event);
void sendMessageToBackend(DOMString message);
void unbufferedLog(DOMString message);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [199825] trunk/LayoutTests/imported/w3c
Title: [199825] trunk/LayoutTests/imported/w3c
Revision 199825
Author youenn.fab...@crf.canon.fr
Date 2016-04-21 11:11:28 -0700 (Thu, 21 Apr 2016)
Log Message
[Fetch API] Improve some fetch response streams tests
https://bugs.webkit.org/show_bug.cgi?id=156848
Reviewed by Darin Adler.
Most important changes are for response-stream-disturbed-2.html and response-stream-disturbed-5.html which were broken.
response-stream-disturbed-2.html was calling an undefined function and was expecting to get a resolved promise while it should be rejected.
response-stream-disturbed-5.html was expecting to have a null body if data is consumed.
After rereading the spec, this test is non conformant, as the body should not be null, but getting the reader should throw.
* web-platform-tests/fetch/api/resources/utils.js: Adding delay helper function.
* web-platform-tests/fetch/api/response/response-cancel-stream.html: Using delay function.
* web-platform-tests/fetch/api/response/response-stream-disturbed-1.html: Removing unused function.
* web-platform-tests/fetch/api/response/response-stream-disturbed-2-expected.txt: Rebasing
* web-platform-tests/fetch/api/response/response-stream-disturbed-2.html: Fixing test.
* web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt: Rebasing
* web-platform-tests/fetch/api/response/response-stream-disturbed-5.html: Fixing test.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-cancel-stream.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-1.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-2-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-2.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-5.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (199824 => 199825)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-21 18:11:17 UTC (rev 199824)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-21 18:11:28 UTC (rev 199825)
@@ -1,3 +1,23 @@
+2016-04-21 Youenn Fablet
+
+[Fetch API] Improve some fetch response streams tests
+https://bugs.webkit.org/show_bug.cgi?id=156848
+
+Reviewed by Darin Adler.
+
+Most important changes are for response-stream-disturbed-2.html and response-stream-disturbed-5.html which were broken.
+response-stream-disturbed-2.html was calling an undefined function and was expecting to get a resolved promise while it should be rejected.
+response-stream-disturbed-5.html was expecting to have a null body if data is consumed.
+After rereading the spec, this test is non conformant, as the body should not be null, but getting the reader should throw.
+
+* web-platform-tests/fetch/api/resources/utils.js: Adding delay helper function.
+* web-platform-tests/fetch/api/response/response-cancel-stream.html: Using delay function.
+* web-platform-tests/fetch/api/response/response-stream-disturbed-1.html: Removing unused function.
+* web-platform-tests/fetch/api/response/response-stream-disturbed-2-expected.txt: Rebasing
+* web-platform-tests/fetch/api/response/response-stream-disturbed-2.html: Fixing test.
+* web-platform-tests/fetch/api/response/response-stream-disturbed-5-expected.txt: Rebasing
+* web-platform-tests/fetch/api/response/response-stream-disturbed-5.html: Fixing test.
+
2016-04-19 Youenn Fablet
imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js (199824 => 199825)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js 2016-04-21 18:11:17 UTC (rev 199824)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js 2016-04-21 18:11:28 UTC (rev 199825)
@@ -74,3 +74,11 @@
validateBufferFromString(retrievedArrayBuffer, expectedValue, "Retrieve and verify stream");
});
}
+
+// From streams tests
+function delay(milliseconds)
+{
+return new Promise(function(resolve) {
+step_timeout(resolve, milliseconds);
+});
+}
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-cancel-stream.html (199824 => 199825)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-cancel-stream.html 2016-04-21 18:11:17 UTC (rev 199824)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-cancel-stream.html 2016-04-21 18:11:28 UTC (re
[webkit-changes] [199736] trunk/LayoutTests
Title: [199736] trunk/LayoutTests
Revision 199736
Author youenn.fab...@crf.canon.fr
Date 2016-04-19 12:06:47 -0700 (Tue, 19 Apr 2016)
Log Message
imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=155760
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Flakiness was coming from a callback being called after a timeout.
Timeout was set so that a double promise resolution (promise resolved
in another promise resolution callback) is done before calling the callback.
On some slow bots, the timeout was not big enough.
* web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.
LayoutTests:
* TestExpectations: removed flaky expectation.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js
Diff
Modified: trunk/LayoutTests/ChangeLog (199735 => 199736)
--- trunk/LayoutTests/ChangeLog 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/ChangeLog 2016-04-19 19:06:47 UTC (rev 199736)
@@ -1,3 +1,12 @@
+2016-04-19 Youenn Fablet
+
+imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=155760
+
+Reviewed by Alexey Proskuryakov.
+
+* TestExpectations: removed flaky expectation.
+
2016-04-19 Mark Lam
Re-landing: ES6: Implement String.prototype.split and RegExp.prototype[@@split].
Modified: trunk/LayoutTests/TestExpectations (199735 => 199736)
--- trunk/LayoutTests/TestExpectations 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/TestExpectations 2016-04-19 19:06:47 UTC (rev 199736)
@@ -742,7 +742,6 @@
webkit.org/b/148805 imported/w3c/css/css-multicol-1/multicol-span-all-child-001.xht [ ImageOnlyFailure ]
webkit.org/b/148884 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection.html [ Pass Failure ]
-webkit.org/b/155760 imported/w3c/web-platform-tests/streams/readable-streams/general.https.html [ Pass Failure ]
webkit.org/b/148922 svg/as-object/svg-in-object-dynamic-attribute-change.html [ Pass ImageOnlyFailure ]
webkit.org/b/148925 svg/dom/svg-root-lengths.html [ Pass Failure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (199735 => 199736)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-04-19 19:06:47 UTC (rev 199736)
@@ -1,3 +1,17 @@
+2016-04-19 Youenn Fablet
+
+imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=155760
+
+Reviewed by Alexey Proskuryakov.
+
+Flakiness was coming from a callback being called after a timeout.
+Timeout was set so that a double promise resolution (promise resolved
+in another promise resolution callback) is done before calling the callback.
+On some slow bots, the timeout was not big enough.
+
+* web-platform-tests/streams/readable-streams/general.js: Increased the callback delay.
+
2016-04-17 Youenn Fablet
[Fetch API] Consume HTTP data as a ReadableStream
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js (199735 => 199736)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js 2016-04-19 18:39:09 UTC (rev 199735)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js 2016-04-19 19:06:47 UTC (rev 199736)
@@ -292,7 +292,8 @@
}
});
- return delay(1).then(() => {
+ // WEBKIT modification: delay(1) replaced by delay(10) to ensure that pull promise is resolved before calling below thened code.
+ return delay(10).then(() => {
assert_equals(pullCount, 1, 'pull should be called once start finishes');
const reader = rs.getReader();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [199228] trunk/LayoutTests
Title: [199228] trunk/LayoutTests Revision 199228 Author youenn.fab...@crf.canon.fr Date 2016-04-08 09:11:00 -0700 (Fri, 08 Apr 2016) Log Message Unreviewed. Rebasing LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList.html expectation after https://trac.webkit.org/changeset/199225. Removing its Timeout expectation. Modified Paths trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt Diff Modified: trunk/LayoutTests/TestExpectations (199227 => 199228) --- trunk/LayoutTests/TestExpectations 2016-04-08 16:05:20 UTC (rev 199227) +++ trunk/LayoutTests/TestExpectations 2016-04-08 16:11:00 UTC (rev 199228) @@ -299,7 +299,6 @@ # WPT tests that fail after doing full test repository reimport and need further investigation imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm [ Pass Failure ] -imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList.html [ Timeout ] imported/w3c/web-platform-tests/dom/nodes/Document-createElement-namespace.html [ Pass Failure ] webkit.org/b/155516 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html [ Skip ] webkit.org/b/155516 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html [ Failure ] Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt (199227 => 199228) --- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt 2016-04-08 16:05:20 UTC (rev 199227) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt 2016-04-08 16:11:00 UTC (rev 199228) @@ -1,6 +1,8 @@ MutationObservers: childList mutations +Harness Error (TIMEOUT), message = null + PASS childList Node.nodeValue: no mutation PASS childList Node.textContent: replace content mutation PASS childList Node.textContent: no previous content mutation @@ -23,6 +25,7 @@ PASS childList Node.replaceChild: replacement mutation PASS childList Node.replaceChild: removal mutation PASS childList Node.replaceChild: internal replacement mutation +TIMEOUT childList Node.replaceChild: self internal replacement mutation Test timed out PASS childList Node.removeChild: removal mutation PASS Range (r70) is created PASS childList Range.deleteContents: child removal mutation ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [199225] trunk
Title: [199225] trunk Revision 199225 Author youenn.fab...@crf.canon.fr Date 2016-04-08 07:45:24 -0700 (Fri, 08 Apr 2016) Log Message LayoutTests/imported/w3c: Testharness-based tests that time out should be able to produce detailed output https://bugs.webkit.org/show_bug.cgi?id=145313 Reviewed by Xabier Rodriguez-Calvar. Rebasing tests that produce output after testharness timeout() is called. * web-platform-tests/fetch/api/request/request-cache-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01-expected.txt: * web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt: Tools: Testharness-based tests that time out should be able to produce a detailed output https://bugs.webkit.org/show_bug.cgi?id=145313 Reviewed by Xabier Rodriguez-Calvar. Adding timeout readonly accessor to TestRunner for both WK1 and WK2. * DumpRenderTree/TestRunner.cpp: (getTimeoutCallback): The js "timeout" property getter. (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value. * DumpRenderTree/TestRunner.h: (TestRunner::timeout): Adding access to DRT m_timeout private value. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS. * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition. (WTR::TestRunner::timeout): LayoutTests: Testharness-based tests that time out should be able to produce a detailled output https://bugs.webkit.org/show_bug.cgi?id=145313 Reviewed by Xabier Rodriguez-Calvar. * TestExpectations: Removed TIMEOUT for some tests for which testharness.timeout will be called just before WTR times out. * platform/gtk/imported/w3c/web-platform-tests/fetch/api/request/request-cache-expected.txt: GTK specific baseline. * resources/testharnessreport.js: (add_completion_callback): Improving error logging message. Dumping of the tests status in error case. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-cache-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt trunk/LayoutTests/resources/testharnessreport.js trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestRunner.cpp trunk/Tools/DumpRenderTree/TestRunner.h trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/request/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/request/request-cache-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (199224 => 199225) --- trunk/LayoutTests/ChangeLog 2016-04-08 09:04:17 UTC (rev 199224) +++ trunk/LayoutTests/ChangeLog 2016-04-08 14:45:24 UTC (rev 199225) @@ -1,3 +1,15 @@ +2016-04-08 Youenn Fablet + +Testharness-based tests that time out should be able to produce a detailled output +https://bugs.webkit.org/show_bug.cgi?id=145313 + +Reviewed by Xabier Rodriguez-Calvar. + +* TestExpectations: Removed TIMEOUT for some tests for which testharness.timeout will be called just before WTR times out. +* platform/gtk/imported/w3c/web-platform-tests/fetch/api/request/request-cache-expected.txt: GTK specific baseline. +* resources/testharnessreport.js: +(add_completion_callback): Improving error logging message. Dumping of the tests status in error case. + 2016-04-08 Manuel Rego Casasnovas [css-grid] Fix positioned items with grid gaps Modified: trunk/LayoutTests/TestExpectations (199224 => 199225) --- trunk/LayoutTests/TestExpectations 2016-04-08 09:04:17 UTC (rev 199224) +++ trunk/LayoutTests/TestExpectations 2016-04-08 14:45:24 UTC (rev 199225) @@ -323,8 +323,6 @@ imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm [ Skip ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors.htm [ Skip ] -imported/w3c/web-platform-tests/fetch/api/request/request-cache.html [ Timeout ] - # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFai
[webkit-changes] [198891] trunk
Title: [198891] trunk Revision 198891 Author youenn.fab...@crf.canon.fr Date 2016-03-31 04:05:11 -0700 (Thu, 31 Mar 2016) Log Message [Fetch API] Add basic loading of resources for Workers https://bugs.webkit.org/show_bug.cgi?id=155886 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Updating test expectations as new tests are passing. * web-platform-tests/fetch/api/basic/accept-header-worker-expected.txt: * web-platform-tests/fetch/api/basic/integrity-worker-expected.txt: * web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: * web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt: * web-platform-tests/fetch/api/basic/request-forbidden-headers-worker-expected.txt: * web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt: * web-platform-tests/fetch/api/basic/scheme-about-worker-expected.txt: * web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt: * web-platform-tests/fetch/api/basic/scheme-data-worker-expected.txt: * web-platform-tests/fetch/api/basic/scheme-others-worker-expected.txt: * web-platform-tests/fetch/api/basic/stream-response-worker-expected.txt: Source/WebCore: Adding impplementation to WorkerGlobalScopeFetch::fetch similarly to DOMWindowFetch::fetch. Refactored code in FetchResponse to share code between the two. Updated WorkerThreadableLoader to cope with an ASSERT. The ASSERT ensures that a DocumentThreadableLoader::create returns non null. In our case, it might happen as all cross origin fetch requests are denied at the moment. This leads to calling didFail in DocumentThreadableLoader::create call and DocumentThreadableLoader::create to return null. Updated the ASSERT to ensures that either the load is finished or DocumentThreadableLoader::create does not return null. Covered by rebased tests. * Modules/fetch/DOMWindowFetch.cpp: (WebCore::DOMWindowFetch::fetch): * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::startFetching): (WebCore::FetchResponse::fetch): * Modules/fetch/FetchResponse.h: * Modules/fetch/WorkerGlobalScopeFetch.cpp: (WebCore::WorkerGlobalScopeFetch::fetch): * Modules/fetch/WorkerGlobalScopeFetch.h: * loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): * loader/WorkerThreadableLoader.h: LayoutTests: Soup and Mac HTTP backends differ on Content-Length header handling. * platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-forbidden-headers-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-data-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-others-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/stream-response-worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/DOMWindowFetch.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/Modules/fetch/WorkerGlobalScopeFetch.cpp trunk/Source/WebCore/Modules/fetch/WorkerGlobalScopeFetch.h trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp trunk/Source/WebCore/loader/WorkerThreadableLoader.h Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (198890 => 198891) --- trunk/LayoutTests/ChangeLog 2016-03-31 10:31:28 UTC (rev 198890) +++ trunk/LayoutTests/ChangeLog 2016-03-31 11:05:11 UTC (rev 198891) @@ -1,5 +1,16 @@ 2016-03-31 Youenn Fablet +[Fetch API] Add basic loading of resources for Workers +https://bugs.webkit.org/show_bug.cgi?id=155886 + +Reviewed by Alex Christensen. + +Soup and Mac HTTP backends dif
[webkit-changes] [198890] trunk/Source/WebCore
Title: [198890] trunk/Source/WebCore
Revision 198890
Author youenn.fab...@crf.canon.fr
Date 2016-03-31 03:31:28 -0700 (Thu, 31 Mar 2016)
Log Message
[Fetch API] Move isDisturbed handling to FetchBodyOwner
https://bugs.webkit.org/show_bug.cgi?id=155968
Reviewed by Darin Adler.
Moved isDisturbed handling in FetchBodyOwner.
This includes promise rejection in case of disturbed bodies.
No behavior change observable from user scripts.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::json):
(WebCore::FetchBody::text):
(WebCore::FetchBody::extractFromBody):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeArrayBuffer):
(WebCore::FetchBody::processIfEmptyOrDisturbed): Deleted.
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::isEmpty): Deleted.
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
* Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::isDisturbed):
(WebCore::FetchBodyOwner::setDisturbed):
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::create):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::clone):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h
trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (198889 => 198890)
--- trunk/Source/WebCore/ChangeLog 2016-03-31 08:31:25 UTC (rev 198889)
+++ trunk/Source/WebCore/ChangeLog 2016-03-31 10:31:28 UTC (rev 198890)
@@ -1,5 +1,42 @@
2016-03-31 Youenn Fablet
+[Fetch API] Move isDisturbed handling to FetchBodyOwner
+https://bugs.webkit.org/show_bug.cgi?id=155968
+
+Reviewed by Darin Adler.
+
+Moved isDisturbed handling in FetchBodyOwner.
+This includes promise rejection in case of disturbed bodies.
+
+No behavior change observable from user scripts.
+
+* Modules/fetch/FetchBody.cpp:
+(WebCore::FetchBody::arrayBuffer):
+(WebCore::FetchBody::blob):
+(WebCore::FetchBody::json):
+(WebCore::FetchBody::text):
+(WebCore::FetchBody::extractFromBody):
+(WebCore::FetchBody::consume):
+(WebCore::FetchBody::consumeArrayBuffer):
+(WebCore::FetchBody::processIfEmptyOrDisturbed): Deleted.
+* Modules/fetch/FetchBody.h:
+(WebCore::FetchBody::isEmpty): Deleted.
+* Modules/fetch/FetchBodyOwner.cpp:
+(WebCore::FetchBodyOwner::arrayBuffer):
+(WebCore::FetchBodyOwner::blob):
+(WebCore::FetchBodyOwner::formData):
+(WebCore::FetchBodyOwner::json):
+(WebCore::FetchBodyOwner::text):
+* Modules/fetch/FetchBodyOwner.h:
+(WebCore::FetchBodyOwner::isDisturbed):
+(WebCore::FetchBodyOwner::setDisturbed):
+* Modules/fetch/FetchRequest.cpp:
+(WebCore::FetchRequest::create):
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::clone):
+
+2016-03-31 Youenn Fablet
+
Remove forEach use from Fetch Headers builtin constructor
https://bugs.webkit.org/show_bug.cgi?id=155967
Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.cpp (198889 => 198890)
--- trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-31 08:31:25 UTC (rev 198889)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-31 10:31:28 UTC (rev 198890)
@@ -33,7 +33,6 @@
#include "DOMRequestState.h"
#include "Dictionary.h"
-#include "ExceptionCode.h"
#include "FetchBodyOwner.h"
#include "FormData.h"
#include "HTTPParsers.h"
@@ -82,60 +81,24 @@
if (!body)
return { };
-body->m_isDisturbed = true;
return FetchBody(WTFMove(*body));
}
-bool FetchBody::processIfEmptyOrDisturbed(Consumer::Type type, DeferredWrapper& promise)
-{
-if (m_type == Type::None) {
-switch (type) {
-case Consumer::Type::Text:
-promise.resolve(String());
-return true;
-case Consumer::Type::Blob:
-promise.resolve>(Blob::create());
-return true;
-case Consumer::Type::JSON:
-promise.reject(SYNTAX_ERR);
-return true;
-case Consumer::Type::ArrayBuffer:
-fulfillPromiseWithArrayBuffer(promise, nullptr, 0);
-return true;
-default:
-ASSERT_NOT_REACHED();
-promise.reject(0);
-return true;
-};
-}
-
-if (m_isDisturbed) {
-promise.reject(TypeError);
-return true;
-}
-m_isDisturbed = true
[webkit-changes] [198889] trunk
Title: [198889] trunk
Revision 198889
Author youenn.fab...@crf.canon.fr
Date 2016-03-31 01:31:25 -0700 (Thu, 31 Mar 2016)
Log Message
Remove forEach use from Fetch Headers builtin constructor
https://bugs.webkit.org/show_bug.cgi?id=155967
Reviewed by Joseph Pecoraro.
Source/WebCore:
Tests: fetch/shadowing-forEach.html
streams/shadowing-Promise.html
streams/shadowing-defineProperty.html
* Modules/fetch/FetchHeaders.idl: Adding fillFromJS private method.
* Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders): Using fillFromJS private method. Using
instanceof test to check whether parameter is Headers or subclass of it.
* bindings/js/WebCoreBuiltinNames.h: Adding fillFromJS private symbol.
LayoutTests:
Renaming tests covering user scripts breaking some WebCore JS built ins.
* fetch/header-constructor-subclass-expected.txt: Added.
* fetch/header-constructor-subclass.html: Added.
* fetch/shadowing-forEach-expected.txt: Renamed from LayoutTests/streams/builtin-overrides-expected.txt.
* fetch/shadowing-forEach.html: Renamed from LayoutTests/fetch/builtin-overrides.html.
* streams/shadowing-Promise-expected.txt: Renamed from LayoutTests/streams/streams-promises-expected.txt.
* streams/shadowing-Promise.html: Renamed from LayoutTests/streams/streams-promises.html.
* streams/shadowing-defineProperty-expected.txt: Renamed from LayoutTests/fetch/builtin-overrides-expected.txt.
* streams/shadowing-defineProperty.html: Renamed from LayoutTests/streams/builtin-overrides.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl
trunk/Source/WebCore/Modules/fetch/FetchHeaders.js
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
Added Paths
trunk/LayoutTests/fetch/header-constructor-subclass-expected.txt
trunk/LayoutTests/fetch/header-constructor-subclass.html
trunk/LayoutTests/fetch/shadowing-forEach-expected.txt
trunk/LayoutTests/fetch/shadowing-forEach.html
trunk/LayoutTests/streams/shadowing-Promise-expected.txt
trunk/LayoutTests/streams/shadowing-Promise.html
trunk/LayoutTests/streams/shadowing-defineProperty-expected.txt
trunk/LayoutTests/streams/shadowing-defineProperty.html
Removed Paths
trunk/LayoutTests/fetch/builtin-overrides-expected.txt
trunk/LayoutTests/fetch/builtin-overrides.html
trunk/LayoutTests/streams/builtin-overrides-expected.txt
trunk/LayoutTests/streams/builtin-overrides.html
trunk/LayoutTests/streams/streams-promises-expected.txt
trunk/LayoutTests/streams/streams-promises.html
Diff
Modified: trunk/LayoutTests/ChangeLog (19 => 198889)
--- trunk/LayoutTests/ChangeLog 2016-03-31 08:26:29 UTC (rev 19)
+++ trunk/LayoutTests/ChangeLog 2016-03-31 08:31:25 UTC (rev 198889)
@@ -1,5 +1,23 @@
2016-03-31 Youenn Fablet
+Remove forEach use from Fetch Headers builtin constructor
+https://bugs.webkit.org/show_bug.cgi?id=155967
+
+Reviewed by Joseph Pecoraro.
+
+Renaming tests covering user scripts breaking some WebCore JS built ins.
+
+* fetch/header-constructor-subclass-expected.txt: Added.
+* fetch/header-constructor-subclass.html: Added.
+* fetch/shadowing-forEach-expected.txt: Renamed from LayoutTests/streams/builtin-overrides-expected.txt.
+* fetch/shadowing-forEach.html: Renamed from LayoutTests/fetch/builtin-overrides.html.
+* streams/shadowing-Promise-expected.txt: Renamed from LayoutTests/streams/streams-promises-expected.txt.
+* streams/shadowing-Promise.html: Renamed from LayoutTests/streams/streams-promises.html.
+* streams/shadowing-defineProperty-expected.txt: Renamed from LayoutTests/fetch/builtin-overrides-expected.txt.
+* streams/shadowing-defineProperty.html: Renamed from LayoutTests/streams/builtin-overrides.html.
+
+2016-03-31 Youenn Fablet
+
[Fetch API] Update web-platform-test fetch API tests
https://bugs.webkit.org/show_bug.cgi?id=155969
Deleted: trunk/LayoutTests/fetch/builtin-overrides-expected.txt (19 => 198889)
--- trunk/LayoutTests/fetch/builtin-overrides-expected.txt 2016-03-31 08:26:29 UTC (rev 19)
+++ trunk/LayoutTests/fetch/builtin-overrides-expected.txt 2016-03-31 08:31:25 UTC (rev 198889)
@@ -1,9 +0,0 @@
-This test should run without throwing an exception.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fetch/builtin-overrides.html (19 => 198889)
--- trunk/LayoutTests/fetch/builtin-overrides.html 2016-03-31 08:26:29 UTC (rev 19)
+++ trunk/LayoutTests/fetch/builtin-overrides.html 2016-03-31 08:31:25 UTC (rev 198889)
@@ -1,18 +0,0 @@
-
-
-
-
-<body>
-<script>
-description("This test should run without throwing an exception.");
-
-Array.prototype.forEach = function() {
-throw "User overriden";
-};
-
-new Headers({a:1})
[webkit-changes] [198888] trunk/LayoutTests
Title: [19] trunk/LayoutTests Revision 19 Author youenn.fab...@crf.canon.fr Date 2016-03-31 01:26:29 -0700 (Thu, 31 Mar 2016) Log Message [Fetch API] Update web-platform-test fetch API tests https://bugs.webkit.org/show_bug.cgi?id=155969 Reviewed by Darin Adler. LayoutTests/imported/w3c: Resyncing tests and updated expectations. New test web-platform-tests/fetch/api/request/request-cache.html is timing out. * web-platform-tests/fetch/api/basic/scheme-blob-expected.txt: * web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt: * web-platform-tests/fetch/api/basic/scheme-blob.js: (checkFetchResponse): * web-platform-tests/fetch/api/headers/headers-basic.html: * web-platform-tests/fetch/api/request/request-cache-expected.txt: Added. * web-platform-tests/fetch/api/request/request-cache.html: Added. * web-platform-tests/fetch/api/request/request-consume-empty.html: * web-platform-tests/fetch/api/request/request-consume.html: * web-platform-tests/fetch/api/request/request-idl-expected.txt: * web-platform-tests/fetch/api/request/request-idl.html: * web-platform-tests/fetch/api/request/request-init-002-expected.txt: * web-platform-tests/fetch/api/request/request-init-002.html: * web-platform-tests/fetch/api/request/resources/cache.py: Added. (main): * web-platform-tests/fetch/api/resources/utils.js: (stringToArray): (validateBufferFromString): (validateStreamFromString): * web-platform-tests/fetch/api/response/response-clone.html: * web-platform-tests/fetch/api/response/response-consume-empty.html: * web-platform-tests/fetch/api/response/response-consume.html: * web-platform-tests/fetch/api/response/response-init-002.html: LayoutTests: * TestExpectations: Marking imported/w3c/web-platform-tests/fetch/api/request/request-cache.html as timing out. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.js trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-002.html Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-cache-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-cache.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/resources/ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/resources/cache.py Diff Modified: trunk/LayoutTests/ChangeLog (198887 => 19) --- trunk/LayoutTests/ChangeLog 2016-03-31 06:18:22 UTC (rev 198887) +++ trunk/LayoutTests/ChangeLog 2016-03-31 08:26:29 UTC (rev 19) @@ -1,3 +1,12 @@ +2016-03-31 Youenn Fablet + +[Fetch API] Update web-platform-test fetch API tests +https://bugs.webkit.org/show_bug.cgi?id=155969 + +Reviewed by Darin Adler. + +* TestExpectations: Marking imported/w3c/web-platform-tests/fetch/api/request/request-cache.html as timing out. + 2016-03-30 Konstantin Tokarev Fixed typo in fast/css/viewport-vmin-border test. Modified: trunk/LayoutTests/TestExpectations (198887 => 19) --- trunk/LayoutTests/TestExpectations 2016-03-31 06:18:22 UTC (rev 198887) +++ trunk/LayoutTests/TestExpectations 2016-03-31 08:26:29 UTC (rev 19) @@ -317,6 +317,8 @@ imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm [ Skip ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors.htm [ Skip ] +imported/w3c/web-platform-tests/fetch/api/request/request-cache.html [ Timeout ] + # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/im
[webkit-changes] [198833] trunk/Source/WebCore
/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/Modules/fetch/WorkerGlobalScopeFetch.cpp trunk/Source/WebCore/Modules/fetch/WorkerGlobalScopeFetch.h trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl trunk/Source/WebCore/Modules/mediasource/MediaSource.idl trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl trunk/Source/WebCore/Modules/mediastream/MediaStream.idl trunk/Source/WebCore/Modules/speech/SpeechSynthesis.idl trunk/Source/WebCore/Modules/webaudio/AudioContext.idl trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl trunk/Source/WebCore/Modules/websockets/WebSocket.idl trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/css/FontFaceSet.idl trunk/Source/WebCore/css/WebKitCSSMatrix.idl trunk/Source/WebCore/dom/CompositionEvent.idl trunk/Source/WebCore/dom/DataTransfer.idl trunk/Source/WebCore/dom/Document.idl trunk/Source/WebCore/dom/Element.idl trunk/Source/WebCore/dom/EventTarget.idl trunk/Source/WebCore/dom/KeyboardEvent.idl trunk/Source/WebCore/dom/MouseEvent.idl trunk/Source/WebCore/dom/MutationEvent.idl trunk/Source/WebCore/dom/MutationObserver.idl trunk/Source/WebCore/dom/NamedNodeMap.idl trunk/Source/WebCore/dom/Node.idl trunk/Source/WebCore/dom/Range.idl trunk/Source/WebCore/dom/TextEvent.idl trunk/Source/WebCore/dom/TouchEvent.idl trunk/Source/WebCore/dom/UIEvent.idl trunk/Source/WebCore/dom/WebKitNamedFlow.idl trunk/Source/WebCore/dom/WheelEvent.idl trunk/Source/WebCore/fileapi/FileReader.idl trunk/Source/WebCore/fileapi/FileReaderSync.idl trunk/Source/WebCore/html/DOMURL.idl trunk/Source/WebCore/html/HTMLElement.idl trunk/Source/WebCore/html/HTMLMediaElement.idl trunk/Source/WebCore/html/HTMLOptionsCollection.idl trunk/Source/WebCore/html/HTMLSelectElement.idl trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl trunk/Source/WebCore/html/canvas/DOMPath.idl trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl trunk/Source/WebCore/html/canvas/WebGLDebugShaders.idl trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl trunk/Source/WebCore/html/track/TextTrack.idl trunk/Source/WebCore/inspector/InspectorFrontendHost.idl trunk/Source/WebCore/page/DOMSelection.idl trunk/Source/WebCore/storage/StorageEvent.idl trunk/Source/WebCore/svg/SVGGraphicsElement.idl trunk/Source/WebCore/svg/SVGLengthList.idl trunk/Source/WebCore/svg/SVGNumberList.idl trunk/Source/WebCore/svg/SVGPathSegList.idl trunk/Source/WebCore/svg/SVGPointList.idl trunk/Source/WebCore/svg/SVGSVGElement.idl trunk/Source/WebCore/svg/SVGTransformList.idl trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebCore/xml/XMLSerializer.idl trunk/Source/WebCore/xml/XPathEvaluator.idl trunk/Source/WebCore/xml/XPathExpression.idl trunk/Source/WebCore/xml/XSLTProcessor.idl Diff Modified: trunk/Source/WebCore/ChangeLog (198832 => 198833) --- trunk/Source/WebCore/ChangeLog 2016-03-30 07:17:14 UTC (rev 198832) +++ trunk/Source/WebCore/ChangeLog 2016-03-30 08:18:19 UTC (rev 198833) @@ -1,3 +1,121 @@ +2016-03-30 Youenn Fablet + +Binding generator should allow passing DOM objects parameters as references +https://bugs.webkit.org/show_bug.cgi?id=155953 + +Reviewed by Alex Christensen. + +Updating binding generator to pass DOM object parameters as references. +Introducing UsePointersEvenForNonNullableObjectArguments to disable that change. + +Updating FetchRequest.idl and DOMWindowFetch.idl to pass parameters as references. + +Updated other IDL interfaces to keep passing DOM object parameters as pointers. +This should not change the behavior for these interfaces. +UsePointersEvenForNonNullableObjectArguments should be progressively removed on those interfaces. + +Binding generator tests covered by rebased binding tests. + +* Modules/encryptedmedia/MediaKeySession.idl: +* Modules/encryptedmedia/MediaKeys.idl: +* Modules/fetch/DOMWindowFetch.cpp: +(WebCore::DOMWindowFetch::fetch): +* Modules/fetch/DOMWindowFetch.h: +* Modules/fetch/DOMWindowFetch.idl: +* Modules/fetch/FetchRequest.cpp: +(WebCore::FetchRequest::create): +* Modules/fetch/FetchRequest.h: +* Modules/fetch/WorkerGlobalScopeFetch.cpp: +(WebCore::WorkerGlobalScopeFetch::fetch): +* Modules/fetch/WorkerGlobalScopeFetch.h: +* Modules/mediacontrols/MediaControlsHost.idl: +* Modules/mediasource/MediaSource.idl: +* Modules/mediasource/SourceBuffer.idl: +* Modules/mediastream/MediaStream.idl: +* Modules/spe
[webkit-changes] [198665] trunk
-expected.txt: Added. * http/tests/fetch/closing-while-fetching.html: Added. * http/tests/fetch/get-response-body-while-loading-expected.txt: Added. * http/tests/fetch/get-response-body-while-loading.html: Added. * http/tests/resources/download-json-with-delay.php: Added. * platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-forbidden-headers-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.js trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-data-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-others-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/stream-response-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/DOMWindowFetch.cpp trunk/Source/WebCore/Modules/fetch/DOMWindowFetch.h trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp trunk/Source/WebCore/Modules/fetch/FetchLoader.h trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp trunk/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp Added Paths trunk/LayoutTests/http/tests/fetch/ trunk/LayoutTests/http/tests/fetch/closing-while-fetching-expected.txt trunk/LayoutTests/http/tests/fetch/closing-while-fetching.html trunk/LayoutTests/http/tests/fetch/get-response-body-while-loading-expected.txt trunk/LayoutTests/http/tests/fetch/get-response-body-while-loading.html trunk/LayoutTests/http/tests/resources/download-json-with-delay.php trunk/LayoutTests/platform/gtk/imported/w3c/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (198664 => 198665) --- trunk/LayoutTests/ChangeLog 2016-03-25 14:08:56 UTC (rev 198664) +++ trunk/LayoutTests/ChangeLog 2016-03-25 14:19:31 UTC (rev 198665) @@ -1,3 +1,18 @@ +2016-03-25 Youenn Fablet + +[Fetch API] Add basic loading of resources +https://bugs.webkit.org/show_bug.cgi?id=155637 + +Reviewed by Darin Adler. + +* TestExpectations: Removed flaky test expectations. +* http/tests/fetch/closing-while-fetching-expected.txt: Added. +* http/tests/fetch/closing-while-fetching.html: Added. +* http/tests/fetch/get-response-body-while-loading-expected.txt: Added. +* http/tests/fetch/get-response-body-while-loading.html: Added. +* http/tests/resources/download-json-with-delay.php: Added. +* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added. + 2016-03-25 Gyuyoung Kim Unreviewed EFL gardening. Modified: trunk/LayoutTests/TestExpectations (198664 => 198665) --- trunk/LayoutTests/TestExpectations 2016-03-25 14:08:56 UTC (rev 198664) +++ trunk/LayoutTests/TestExpectations 2016-03-25 14:19:31 UTC (rev 198665) @@ -317,10 +317,6 @@ imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm [ Skip ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors.htm [ Skip ] -# Tests that are flaky as failing assertions print a new token generated for each test run. -imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.html [ Failure ] -imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-worke
[webkit-changes] [198627] trunk
-expected.txt: Added. * http/tests/fetch/closing-while-fetching.html: Added. * http/tests/fetch/get-response-body-while-loading-expected.txt: Added. * http/tests/fetch/get-response-body-while-loading.html: Added. * http/tests/resources/download-json-with-delay.php: Added. * platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/integrity-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-forbidden-headers-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.js trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-data-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-others-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/stream-response-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/DOMWindowFetch.cpp trunk/Source/WebCore/Modules/fetch/DOMWindowFetch.h trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp trunk/Source/WebCore/Modules/fetch/FetchLoader.h trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp trunk/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp Added Paths trunk/LayoutTests/http/tests/fetch/ trunk/LayoutTests/http/tests/fetch/closing-while-fetching-expected.txt trunk/LayoutTests/http/tests/fetch/closing-while-fetching.html trunk/LayoutTests/http/tests/fetch/get-response-body-while-loading-expected.txt trunk/LayoutTests/http/tests/fetch/get-response-body-while-loading.html trunk/LayoutTests/http/tests/resources/download-json-with-delay.php trunk/LayoutTests/platform/gtk/imported/w3c/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (198626 => 198627) --- trunk/LayoutTests/ChangeLog 2016-03-24 16:20:44 UTC (rev 198626) +++ trunk/LayoutTests/ChangeLog 2016-03-24 16:53:36 UTC (rev 198627) @@ -1,3 +1,18 @@ +2016-03-24 Youenn Fablet + +[Fetch API] Add basic loading of resources +https://bugs.webkit.org/show_bug.cgi?id=155637 + +Reviewed by Darin Adler. + +* TestExpectations: Removed flaky test expectations. +* http/tests/fetch/closing-while-fetching-expected.txt: Added. +* http/tests/fetch/closing-while-fetching.html: Added. +* http/tests/fetch/get-response-body-while-loading-expected.txt: Added. +* http/tests/fetch/get-response-body-while-loading.html: Added. +* http/tests/resources/download-json-with-delay.php: Added. +* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added. + 2016-03-24 Michael Saboff [ES6] Greedy unicode RegExp's don't properly backtrack past non BMP characters Modified: trunk/LayoutTests/TestExpectations (198626 => 198627) --- trunk/LayoutTests/TestExpectations 2016-03-24 16:20:44 UTC (rev 198626) +++ trunk/LayoutTests/TestExpectations 2016-03-24 16:53:36 UTC (rev 198627) @@ -317,10 +317,6 @@ imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm [ Skip ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors.htm [ Skip ] -# Tests that are flaky as failing assertions print a new token generated for each test run. -imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.html [ Failure ] -
[webkit-changes] [198622] trunk/Source/WebCore
Title: [198622] trunk/Source/WebCore
Revision 198622
Author youenn.fab...@crf.canon.fr
Date 2016-03-24 03:36:45 -0700 (Thu, 24 Mar 2016)
Log Message
Remove DeferredWrapper::resolve>
https://bugs.webkit.org/show_bug.cgi?id=154849
Reviewed by Darin Adler.
Adding fulfillPromiseWithArrayBuffer to resolve a promise with an ArrayBuffer.
If the ArrayBuffer is null, the promise is rejected with an OutOfMemory exception.
Not covered by tests since we would need to make tryCreate return null on failing allocation.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::loadedAsArrayBuffer):
* bindings/js/JSDOMPromise.cpp:
(WebCore::fulfillPromiseWithArrayBuffer):
* bindings/js/JSDOMPromise.h:
(WebCore::DeferredWrapper::resolve): Deleted.
(WebCore::DeferredWrapper::resolve): Deleted.
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.h
trunk/Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (198621 => 198622)
--- trunk/Source/WebCore/ChangeLog 2016-03-24 09:02:55 UTC (rev 198621)
+++ trunk/Source/WebCore/ChangeLog 2016-03-24 10:36:45 UTC (rev 198622)
@@ -1,3 +1,31 @@
+2016-03-24 Youenn Fablet
+
+Remove DeferredWrapper::resolve>
+https://bugs.webkit.org/show_bug.cgi?id=154849
+
+Reviewed by Darin Adler.
+
+Adding fulfillPromiseWithArrayBuffer to resolve a promise with an ArrayBuffer.
+If the ArrayBuffer is null, the promise is rejected with an OutOfMemory exception.
+
+Not covered by tests since we would need to make tryCreate return null on failing allocation.
+
+* Modules/fetch/FetchBody.cpp:
+(WebCore::FetchBody::processIfEmptyOrDisturbed):
+(WebCore::FetchBody::loadedAsArrayBuffer):
+* bindings/js/JSDOMPromise.cpp:
+(WebCore::fulfillPromiseWithArrayBuffer):
+* bindings/js/JSDOMPromise.h:
+(WebCore::DeferredWrapper::resolve): Deleted.
+(WebCore::DeferredWrapper::resolve): Deleted.
+* bindings/js/JSSubtleCryptoCustom.cpp:
+(WebCore::JSSubtleCrypto::encrypt):
+(WebCore::JSSubtleCrypto::decrypt):
+(WebCore::JSSubtleCrypto::sign):
+(WebCore::JSSubtleCrypto::digest):
+(WebCore::JSSubtleCrypto::exportKey):
+(WebCore::JSSubtleCrypto::wrapKey):
+
2016-03-23 Daniel Bates
CSP: Simplify logic for checking policies
Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.cpp (198621 => 198622)
--- trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-24 09:02:55 UTC (rev 198621)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-24 10:36:45 UTC (rev 198622)
@@ -97,7 +97,7 @@
promise.reject(SYNTAX_ERR);
return true;
case Consumer::Type::ArrayBuffer:
-promise.resolve(ArrayBuffer::tryCreate(nullptr, 0));
+fulfillPromiseWithArrayBuffer(promise, nullptr, 0);
return true;
default:
ASSERT_NOT_REACHED();
@@ -174,7 +174,7 @@
if (type == Consumer::Type::ArrayBuffer) {
Vector data = ""
-promise.resolve>(ArrayBuffer::tryCreate(data.data(), data.size()));
+fulfillPromiseWithArrayBuffer(promise, data.data(), data.size());
return;
}
String contentType = Blob::normalizedContentType(extractMIMETypeFromMediaType(m_mimeType));
@@ -226,7 +226,7 @@
ASSERT(m_consumer);
ASSERT(m_consumer->type == Consumer::Type::Blob || m_consumer->type == Consumer::Type::ArrayBuffer);
if (m_consumer->type == Consumer::Type::ArrayBuffer)
-m_consumer->promise.resolve(buffer);
+fulfillPromiseWithArrayBuffer(m_consumer->promise, buffer.get());
else {
ASSERT(m_blob);
Vector data;
Modified: trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp (198621 => 198622)
--- trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2016-03-24 09:02:55 UTC (rev 198621)
+++ trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp 2016-03-24 10:36:45 UTC (rev 198622)
@@ -93,4 +93,18 @@
promise.resolve(value);
}
+void fulfillPromiseWithArrayBuffer(DeferredWrapper& promise, ArrayBuffer* arrayBuffer)
+{
+if (!arrayBuffer) {
+promise.reject(createOutOfMemoryError(promise.globalObject().globalExec()));
+return;
+}
+promise.resolve(arrayBuffer);
}
+
+void fulfillPromiseWithArrayBuffer(DeferredWrapper& promise, const void* data, size_t length)
+{
+fulfillPromiseWithArrayBuffer(promise, ArrayBuffer::tryCreate(data, lengt
[webkit-changes] [198487] trunk/LayoutTests/platform/mac/TestExpectations
Title: [198487] trunk/LayoutTests/platform/mac/TestExpectations Revision 198487 Author youenn.fab...@crf.canon.fr Date 2016-03-21 05:58:24 -0700 (Mon, 21 Mar 2016) Log Message Unreviewed. Marking imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-2.html as flaky (Pass, Crash) Modified Paths trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/platform/mac/TestExpectations (198486 => 198487) --- trunk/LayoutTests/platform/mac/TestExpectations 2016-03-21 10:42:33 UTC (rev 198486) +++ trunk/LayoutTests/platform/mac/TestExpectations 2016-03-21 12:58:24 UTC (rev 198487) @@ -1278,6 +1278,7 @@ webkit.org/b/152436 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.https.html [ Pass Crash ] webkit.org/b/153781 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-1.html [ Pass Crash ] +webkit.org/b/153781 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-2.html [ Pass Crash ] # WOFF2 is only supported on certain Operating Systems. webkit.org/b/150830 [ Yosemite ElCapitan ] fast/text/woff2.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [198326] trunk
Title: [198326] trunk
Revision 198326
Author youenn.fab...@crf.canon.fr
Date 2016-03-17 04:25:10 -0700 (Thu, 17 Mar 2016)
Log Message
[Fetch API] response-consume.html is crashing on Mac WK1 Debug builds
https://bugs.webkit.org/show_bug.cgi?id=155490
Reviewed by Darin Adler.
Source/WebCore:
Covered by existing tests.
Ensured to lock state before calling JSC:JSONParse.
Adding fulfillPromiseWithJSON routine to handle it.
Applied it to FetchBody.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::json):
(WebCore::FetchBody::loadedAsText):
(WebCore::FetchBody::resolveAsJSON): Deleted.
* Modules/fetch/FetchBody.h:
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::loadedBlobAsText):
* bindings/js/JSDOMPromise.cpp:
(WebCore::parseAsJSON):
(WebCore::fulfillPromiseWithJSON):
* bindings/js/JSDOMPromise.h:
LayoutTests:
* TestExpectations: Removed crash debug expectation of response-consume.html
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.cpp
trunk/Source/WebCore/bindings/js/JSDOMPromise.h
Diff
Modified: trunk/LayoutTests/ChangeLog (198325 => 198326)
--- trunk/LayoutTests/ChangeLog 2016-03-17 10:52:20 UTC (rev 198325)
+++ trunk/LayoutTests/ChangeLog 2016-03-17 11:25:10 UTC (rev 198326)
@@ -1,3 +1,12 @@
+2016-03-17 Youenn Fablet
+
+[Fetch API] response-consume.html is crashing on Mac WK1 Debug builds
+https://bugs.webkit.org/show_bug.cgi?id=155490
+
+Reviewed by Darin Adler.
+
+* TestExpectations: Removed crash debug expectation of response-consume.html
+
2016-03-17 Adam Bergkvist
WebRTC: Update RTCIceCandidate
Modified: trunk/LayoutTests/TestExpectations (198325 => 198326)
--- trunk/LayoutTests/TestExpectations 2016-03-17 10:52:20 UTC (rev 198325)
+++ trunk/LayoutTests/TestExpectations 2016-03-17 11:25:10 UTC (rev 198326)
@@ -324,9 +324,6 @@
# New W3C ref tests that are failing.
webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ]
-# Fetch API tests
-[ Debug ] imported/w3c/web-platform-tests/fetch/api/response/response-consume.html [ Pass Crash ]
-
# @supports W3C Failures
webkit.org/b/137566 css3/conditional/w3c/at-supports-010.html [ ImageOnlyFailure ]
webkit.org/b/137568 css3/conditional/w3c/at-supports-014.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (198325 => 198326)
--- trunk/Source/WebCore/ChangeLog 2016-03-17 10:52:20 UTC (rev 198325)
+++ trunk/Source/WebCore/ChangeLog 2016-03-17 11:25:10 UTC (rev 198326)
@@ -1,3 +1,28 @@
+2016-03-17 Youenn Fablet
+
+[Fetch API] response-consume.html is crashing on Mac WK1 Debug builds
+https://bugs.webkit.org/show_bug.cgi?id=155490
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+Ensured to lock state before calling JSC:JSONParse.
+Adding fulfillPromiseWithJSON routine to handle it.
+Applied it to FetchBody.
+
+* Modules/fetch/FetchBody.cpp:
+(WebCore::FetchBody::json):
+(WebCore::FetchBody::loadedAsText):
+(WebCore::FetchBody::resolveAsJSON): Deleted.
+* Modules/fetch/FetchBody.h:
+* Modules/fetch/FetchBodyOwner.cpp:
+(WebCore::FetchBodyOwner::loadedBlobAsText):
+* bindings/js/JSDOMPromise.cpp:
+(WebCore::parseAsJSON):
+(WebCore::fulfillPromiseWithJSON):
+* bindings/js/JSDOMPromise.h:
+
2016-03-17 Adam Bergkvist
WebRTC: Update RTCIceCandidate
Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.cpp (198325 => 198326)
--- trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-17 10:52:20 UTC (rev 198325)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-03-17 11:25:10 UTC (rev 198326)
@@ -38,7 +38,6 @@
#include "HTTPParsers.h"
#include "JSBlob.h"
#include "JSDOMFormData.h"
-#include
namespace WebCore {
@@ -135,11 +134,8 @@
if (processIfEmptyOrDisturbed(Consumer::Type::JSON, promise))
return;
-if (!owner.scriptExecutionContext())
-return;
-
if (m_type == Type::Text) {
-resolveAsJSON(*owner.scriptExecutionContext(), m_text, WTFMove(promise));
+fulfillPromiseWithJSON(promise, m_text);
return;
}
consume(owner, Consumer::Type::JSON, WTFMove(promise));
@@ -208,16 +204,6 @@
owner.loadBlob(*m_blob, loadingType(type));
}
-void FetchBody::resolveAsJSON(ScriptExecutionContext& context, const String& data, DeferredWrapper&& promise)
-{
-DOMRequestState state(&context);
-JSC::JSValue value = JSC::JSONParse(state.exec(), data);
-if (!value)
-promise.reject(SYNTAX
[webkit-changes] [198395] trunk
Title: [198395] trunk Revision 198395 Author youenn.fab...@crf.canon.fr Date 2016-03-18 04:17:09 -0700 (Fri, 18 Mar 2016) Log Message crossorigin element resource loading should check HTTP redirection https://bugs.webkit.org/show_bug.cgi?id=130578 Reviewed by Daniel Bates and Brent Fulgham. Source/WebCore: Moved part of DocumentThreadableLoader redirection cross origin control code into functions in CrossOriginAccessControl.cpp. Added cross origin control for redirections in SubResourceLoader when policy is set to PotentiallyCrossOriginEnabled using CrossOriginAccessControl.cpp new functions. Added a new test that checks that cross-origin redirections are checked against CORS. Test: http/tests/security/shape-image-cors-redirect.html * loader/CrossOriginAccessControl.cpp: (WebCore::isValidCrossOriginRedirectionURL): Returns true if the redirected URL is a valid URL for cross-origin requests. (WebCore::cleanRedirectedRequestForAccessControl): Removes all headers added by the network backend that may cause the response CORS validation to fail. * loader/CrossOriginAccessControl.h: Added above function prototypes. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::redirectReceived): Used new CORS redirection methods of CrossOriginAccessControl.cpp. * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::init): Initialize the SecurityOrigin to be used for loading the resource. (WebCore::SubresourceLoader::willSendRequest): Added cross-origin redirection response check. (WebCore::SubresourceLoader::checkCrossOriginAccessControl): Checks CORS and update request if needed. Returns true if control checks passed. * loader/SubresourceLoader.h: Added checkCrossOriginAccessControl declaration and m_origin declaration. LayoutTests: shape-image-cors-redirect.html checks that cross-origin redirections are checked against CORS. It also checks that same-origin redirections are not checked against CORS. * http/tests/security/resources/redirect-allow-star.php: Added. * http/tests/security/shape-image-cors-redirect-expected.html: Added. * http/tests/security/shape-image-cors-redirect.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp trunk/Source/WebCore/loader/CrossOriginAccessControl.h trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/SubresourceLoader.cpp trunk/Source/WebCore/loader/SubresourceLoader.h Added Paths trunk/LayoutTests/http/tests/security/resources/redirect-allow-star.php trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1.html trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2.html trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3.html trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4.html trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-expected.html trunk/LayoutTests/http/tests/security/shape-image-cors-redirect.html Diff Modified: trunk/LayoutTests/ChangeLog (198394 => 198395) --- trunk/LayoutTests/ChangeLog 2016-03-18 10:15:53 UTC (rev 198394) +++ trunk/LayoutTests/ChangeLog 2016-03-18 11:17:09 UTC (rev 198395) @@ -1,5 +1,19 @@ 2016-03-18 Youenn Fablet +crossorigin element resource loading should check HTTP redirection +https://bugs.webkit.org/show_bug.cgi?id=130578 + +Reviewed by Daniel Bates and Brent Fulgham. + +shape-image-cors-redirect.html checks that cross-origin redirections are checked against CORS. +It also checks that same-origin redirections are not checked against CORS. + +* http/tests/security/resources/redirect-allow-star.php: Added. +* http/tests/security/shape-image-cors-redirect-expected.html: Added. +* http/tests/security/shape-image-cors-redirect.html: Added. + +2016-03-18 Youenn Fablet + Move IndexedDB regular test to web-platform-tests https://bugs.webkit.org/show_bug.cgi?id=155581 Modified: trunk/LayoutTests/TestExpectations (198394 => 198395) --- trunk/LayoutTests/TestExpectations 2016-03-18 10:15:53 UTC (rev 198394) +++ trunk/LayoutTests/TestExpectations 2016-03-18 11:17:09 UTC (rev 198395) @@ -805,6 +805,11 @@ webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ] +webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-1.html [ Pass F
[webkit-changes] [198151] trunk
Title: [198151] trunk
Revision 198151
Author youenn.fab...@crf.canon.fr
Date 2016-03-14 13:13:30 -0700 (Mon, 14 Mar 2016)
Log Message
[Fetch API] FetchLoader should check for empty bodies
https://bugs.webkit.org/show_bug.cgi?id=155440
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
* web-platform-tests/fetch/api/request/request-consume-empty.html:
* web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
* web-platform-tests/fetch/api/response/response-consume-empty.html:
Source/WebCore:
Covered by added tests.
* Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::didFinishLoading): returning empty array buffer/empty string if no data received during loading.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (198150 => 198151)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 20:07:16 UTC (rev 198150)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 20:13:30 UTC (rev 198151)
@@ -1,5 +1,17 @@
2016-03-14 Youenn Fablet
+[Fetch API] FetchLoader should check for empty bodies
+https://bugs.webkit.org/show_bug.cgi?id=155440
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
+* web-platform-tests/fetch/api/request/request-consume-empty.html:
+* web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
+* web-platform-tests/fetch/api/response/response-consume-empty.html:
+
+2016-03-14 Youenn Fablet
+
[Fetch API] Implement data resolution for blob stored in Body
https://bugs.webkit.org/show_bug.cgi?id=155359
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt (198150 => 198151)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt 2016-03-14 20:07:16 UTC (rev 198150)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt 2016-03-14 20:13:30 UTC (rev 198151)
@@ -4,4 +4,8 @@
PASS Consume request's body as arrayBuffer
PASS Consume request's body as json
FAIL Consume request's body as formData promise_test: Unhandled rejection with value: undefined
+PASS Consume empty blob request body as arrayBuffer
+PASS Consume empty text request body as arrayBuffer
+PASS Consume empty blob request body as text
+PASS Consume empty text request body as text
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html (198150 => 198151)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html 2016-03-14 20:07:16 UTC (rev 198150)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html 2016-03-14 20:13:30 UTC (rev 198151)
@@ -61,7 +61,7 @@
});
}
-function checkRequestBody(bodyType, checkFunction) {
+function checkRequestWithNoBody(bodyType, checkFunction) {
promise_test(function(test) {
var request = new Request("", {"method": "POST"});
assert_false(request.bodyUsed);
@@ -70,12 +70,34 @@
}
var formData = new FormData();
-checkRequestBody("text", checkBodyText);
-checkRequestBody("blob", checkBodyBlob);
-checkRequestBody("arrayBuffer", checkBodyArrayBuffer);
-checkRequestBody("json", checkBodyJSON);
-checkRequestBody("formData", checkBodyFormData);
+checkRequestWithNoBody("text", checkBodyText);
+checkRequestWithNoBody("blob", checkBodyBlob);
+checkRequestWithNoBody("arrayBuffer", checkBodyArrayBuffer);
+checkRequestWithNoBody("json", checkBodyJSON);
+checkRequestWithNoBody("formData", checkBodyFormData);
+function checkRequestWithEmptyBody(bodyType, body, asText) {
+ promise_test(function(test) {
+var request = new Request("", {"method": "POST", "body" : body});
+assert_false(request.bodyUsed, "bodyUsed is false at init");
+if (asText) {
+ return request.text().then(function(bodyAsString) {
+assert_equals(bodyAsString.length, 0, "Resol
[webkit-changes] [198139] trunk/LayoutTests/TestExpectations
Title: [198139] trunk/LayoutTests/TestExpectations Revision 198139 Author youenn.fab...@crf.canon.fr Date 2016-03-14 10:30:03 -0700 (Mon, 14 Mar 2016) Log Message Unreviewed. Marking imported/fetch/api/request/request-consume.html as flaky on debug builds. Modified Paths trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/TestExpectations (198138 => 198139) --- trunk/LayoutTests/TestExpectations 2016-03-14 17:22:54 UTC (rev 198138) +++ trunk/LayoutTests/TestExpectations 2016-03-14 17:30:03 UTC (rev 198139) @@ -323,6 +323,9 @@ # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ] +# Fetch API tests +[ Debug ] imported/w3c/web-platform-tests/fetch/api/response/response-consume.html [ Pass Crash ] + # @supports W3C Failures webkit.org/b/137566 css3/conditional/w3c/at-supports-010.html [ ImageOnlyFailure ] webkit.org/b/137568 css3/conditional/w3c/at-supports-014.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [198133] trunk
Title: [198133] trunk Revision 198133 Author youenn.fab...@crf.canon.fr Date 2016-03-14 08:58:14 -0700 (Mon, 14 Mar 2016) Log Message [Fetch API] Implement data resolution for blob stored in Body https://bugs.webkit.org/show_bug.cgi?id=155359 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/request/request-consume-expected.txt: * web-platform-tests/fetch/api/request/request-consume.html: * web-platform-tests/fetch/api/request/request-init-002-expected.txt: * web-platform-tests/fetch/api/response/response-consume-expected.txt: * web-platform-tests/fetch/api/response/response-consume.html: * web-platform-tests/fetch/api/response/response-init-002-expected.txt: Source/WebCore: Introducing FetchLoader as a wrapper around ThreadableLoader to load resources. FetchLoader can retrieve data as text or array buffer. It only supports blob currently. Introducing FetchLoaderClient interface and FetchBodyOwner::BlobLoader as specifc blob loader client. Covered by existing rebased tests. * CMakeLists.txt: * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::loadingType): (WebCore::FetchBody::loadedAsArrayBuffer): (WebCore::FetchBody::loadedAsText): * Modules/fetch/FetchBody.h: * Modules/fetch/FetchBodyOwner.cpp: Added. (WebCore::FetchBodyOwner::FetchBodyOwner): (WebCore::FetchBodyOwner::loadBlob): (WebCore::FetchBodyOwner::finishBlobLoading): (WebCore::FetchBodyOwner::blobLoadingFailed): (WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse): * Modules/fetch/FetchBodyOwner.h: (WebCore::FetchBodyOwner::loadedBlobAsText): (WebCore::FetchBodyOwner::loadedBlobAsArrayBuffer): (WebCore::FetchBodyOwner::blobLoadingSucceeded): * Modules/fetch/FetchLoader.cpp: Added. (WebCore::FetchLoader::start): (WebCore::FetchLoader::FetchLoader): (WebCore::FetchLoader::stop): (WebCore::FetchLoader::didReceiveResponse): (WebCore::FetchLoader::didReceiveData): (WebCore::FetchLoader::didFinishLoading): (WebCore::FetchLoader::didFail): * Modules/fetch/FetchLoader.h: Added. * Modules/fetch/FetchLoaderClient.h: Added. (WebCore::FetchLoaderClient::~FetchLoaderClient): (WebCore::FetchLoaderClient::didReceiveResponse): (WebCore::FetchLoaderClient::didFinishLoadingAsText): (WebCore::FetchLoaderClient::didFinishLoadingAsArrayBuffer): * WebCore.xcodeproj/project.pbxproj: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-002-expected.txt trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj Added Paths trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp trunk/Source/WebCore/Modules/fetch/FetchLoader.h trunk/Source/WebCore/Modules/fetch/FetchLoaderClient.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (198132 => 198133) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 15:42:54 UTC (rev 198132) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 15:58:14 UTC (rev 198133) @@ -1,5 +1,19 @@ 2016-03-14 Youenn Fablet +[Fetch API] Implement data resolution for blob stored in Body +https://bugs.webkit.org/show_bug.cgi?id=155359 + +Reviewed by Darin Adler. + +* web-platform-tests/fetch/api/request/request-consume-expected.txt: +* web-platform-tests/fetch/api/request/request-consume.html: +* web-platform-tests/fetch/api/request/request-init-002-expected.txt: +* web-platform-tests/fetch/api/response/response-consume-expected.txt: +* web-platform-tests/fetch/api/response/response-consume.html: +* web-platform-tests/fetch/api/response/response-init-002-expected.txt: + +2016-03-14 Youenn Fablet + Web platform test server should not try to launch servers on already bound sockets https://bugs.webkit.org/show_bug.cgi?id=141157 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt (198132 => 198133) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt 2016-03-14 15:42:54 UTC (rev 198132) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/r
[webkit-changes] [198116] trunk
Title: [198116] trunk
Revision 198116
Author youenn.fab...@crf.canon.fr
Date 2016-03-14 05:10:23 -0700 (Mon, 14 Mar 2016)
Log Message
Web platform test server should not try to launch servers on already bound sockets
https://bugs.webkit.org/show_bug.cgi?id=141157
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* resources/config.json: Changed wpt https port from 8443 to 9443.
* web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Updated according https port change.
* web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Ditto.
* web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt: Ditto.
* web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt: Ditto.
Tools:
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
(base_url): Refactored to use wpt_config_json routine.
(WebPlatformTestServer.__init__): Fill port mappings according WPT config.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/config.json
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (198115 => 198116)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 12:02:21 UTC (rev 198115)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-14 12:10:23 UTC (rev 198116)
@@ -1,3 +1,16 @@
+2016-03-14 Youenn Fablet
+
+Web platform test server should not try to launch servers on already bound sockets
+https://bugs.webkit.org/show_bug.cgi?id=141157
+
+Reviewed by Darin Adler.
+
+* resources/config.json: Changed wpt https port from 8443 to 9443.
+* web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Updated according https port change.
+* web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Ditto.
+* web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt: Ditto.
+* web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt: Ditto.
+
2016-03-11 Youenn Fablet
[Fetch API] Use DeferredWrapper directly in FetchBody promise handling
Modified: trunk/LayoutTests/imported/w3c/resources/config.json (198115 => 198116)
--- trunk/LayoutTests/imported/w3c/resources/config.json 2016-03-14 12:02:21 UTC (rev 198115)
+++ trunk/LayoutTests/imported/w3c/resources/config.json 2016-03-14 12:10:23 UTC (rev 198116)
@@ -1,6 +1,6 @@
{"host": "localhost",
"ports":{"http":[8800, 8801],
- "https":[8443],
+ "https":[9443],
"ws":[49001]},
"check_subdomains": false,
"log_level":"debug",
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt (198115 => 198116)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt 2016-03-14 12:02:21 UTC (rev 198115)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt 2016-03-14 12:10:23 UTC (rev 198116)
@@ -1,6 +1,6 @@
FAIL Fetch ../resources/top.txt with no-cors mode promise_test: Unhandled rejection with value: "Fetch is not yet implemented"
FAIL Fetch http://localhost:8800/fetch/api/resources/top.txt with no-cors mode promise_test: Unhandled rejection with value: "Fetch is not yet implemented"
-FAIL Fetch https://localhost:8443/fetch/api/resources/top.txt with no-cors mode promise_test: Unhandled rejection with value: "Fetch is not yet implemented"
+FAIL Fetch https://localhost:9443/fetch/api/resources/top.txt with no-cors mode promise_test: Unhandled rejection with value: "Fetch is not yet implemented"
FAIL Fetch http://www.localhost:8800/fetch/api/resources/top.txt with no-cors mode promise_test: Unhandled rejection with value: "Fetch is not yet implemented"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt (198115 => 198116)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt 2016-03-14 12:02:21 UTC (rev 198115)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt 2016-03-14 12:10:23 UTC (rev 198116)
@@ -1,6 +1,6 @@
FAIL Fetch ../resources/top.txt with no-cors mode promise_test: Unhandled rejection with
[webkit-changes] [198102] trunk/Source/WebCore
Title: [198102] trunk/Source/WebCore Revision 198102 Author youenn.fab...@crf.canon.fr Date 2016-03-14 02:44:44 -0700 (Mon, 14 Mar 2016) Log Message Introduce CallWith=Document in binding generator https://bugs.webkit.org/show_bug.cgi?id=155358 Reviewed by Darin Adler. Covered by existing tests and binding test. * Modules/notifications/Notification.cpp: (WebCore::Notification::permission): Taking a Document& instead of ScriptExecutionContext&. (WebCore::Notification::requestPermission): Ditto. * Modules/notifications/Notification.h: * Modules/notifications/Notification.idl: Using CallWith=Document. * bindings/scripts/CodeGeneratorJS.pm: Adding support for CallWith=Document and changed name from scriptContext to context. (GenerateCallWith): (GenerateConstructorDefinition): * bindings/scripts/IDLAttributes.txt: Adding support for CallWith=Document. * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_document_argument): * bindings/scripts/test/GObject/WebKitDOMTestObj.h: * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjWithScriptExecutionContextAttribute): (WebCore::jsTestObjWithScriptExecutionContextAttributeRaises): (WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): (WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises): (WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): (WebCore::setJSTestObjWithScriptExecutionContextAttribute): (WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises): (WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext): (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): (WebCore::jsTestObjPrototypeFunctionWithDocumentArgument): * bindings/scripts/test/ObjC/DOMTestObj.h: * bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withDocumentArgument]): * bindings/scripts/test/TestObj.idl: Adding binding test. * page/DOMWindow.cpp: (WebCore::DOMWindow::focus): Taking a Document& instead of ScriptExecutionContext&. (WebCore::DOMWindow::close): Ditto. * page/DOMWindow.h: * page/DOMWindow.idl: * page/History.cpp: (WebCore::History::back): Ditto. (WebCore::History::forward): Ditto. (WebCore::History::go): Ditto. * page/History.h: * page/History.idl: * testing/Internals.cpp: (WebCore::InspectorStubFrontend::closeWindow): Calling DOMWindow::close() directly. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/notifications/Notification.cpp trunk/Source/WebCore/Modules/notifications/Notification.h trunk/Source/WebCore/Modules/notifications/Notification.idl trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm trunk/Source/WebCore/bindings/scripts/test/TestObj.idl trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebCore/page/DOMWindow.h trunk/Source/WebCore/page/DOMWindow.idl trunk/Source/WebCore/page/History.cpp trunk/Source/WebCore/page/History.h trunk/Source/WebCore/page/History.idl trunk/Source/WebCore/testing/Internals.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (198101 => 198102) --- trunk/Source/WebCore/ChangeLog 2016-03-14 09:21:56 UTC (rev 198101) +++ trunk/Source/WebCore/ChangeLog 2016-03-14 09:44:44 UTC (rev 198102) @@ -1,3 +1,61 @@ +2016-03-14 Youenn Fablet + +Introduce CallWith=Document in binding generator +https://bugs.webkit.org/show_bug.cgi?id=155358 + +Reviewed by Darin Adler. + +Covered by existing tests and binding test. + +* Modules/notifications/Notification.cpp: +(WebCore::Notification::permission): Taking a Document& instead of ScriptExecutionContext&. +(WebCore::Notification::requestPermission): Ditto. +* Modules/notifications/Notification.h: +* Modules/notifications/Notification.idl: Using CallWith=Document. +* bindings/scripts/CodeGeneratorJS.pm: Adding support for CallWith=Document and changed name from scriptContext to context.
[webkit-changes] [198019] trunk
Title: [198019] trunk
Revision 198019
Author youenn.fab...@crf.canon.fr
Date 2016-03-11 07:10:18 -0800 (Fri, 11 Mar 2016)
Log Message
WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
https://bugs.webkit.org/show_bug.cgi?id=153419
Reviewed by Darin Adler.
Source/WebCore:
Covered by added unint tests.
* Modules/fetch/FetchHeaders.cpp:
(WebCore::isForbiddenHeaderName): Using startsWithLettersIgnoringASCIICase.
Source/WTF:
Introducing startsWithLettersIgnoringASCIICase, to check the beginning of a string.
Moving some code from WTF::equalLettersIgnoringASCIICaseCommonWithoutLength in
WTF::hasPrefixWithLettersIgnoringASCIICaseCommon to enable reuse in
WTF::startsWithLettersIgnoringASCIICaseCommon.
* wtf/text/StringCommon.h:
(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):
(WTF::equalLettersIgnoringASCIICaseCommonWithoutLength):
(WTF::startsWithLettersIgnoringASCIICaseCommonWithoutLength):
(WTF::startsWithLettersIgnoringASCIICaseCommon):
* wtf/text/StringImpl.h:
(WTF::startsWithLettersIgnoringASCIICase):
* wtf/text/WTFString.h:
(WTF::startsWithLettersIgnoringASCIICase):
Tools:
* TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringCommon.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (198018 => 198019)
--- trunk/Source/WTF/ChangeLog 2016-03-11 14:45:14 UTC (rev 198018)
+++ trunk/Source/WTF/ChangeLog 2016-03-11 15:10:18 UTC (rev 198019)
@@ -1,3 +1,25 @@
+2016-03-11 Youenn Fablet
+
+WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
+https://bugs.webkit.org/show_bug.cgi?id=153419
+
+Reviewed by Darin Adler.
+
+Introducing startsWithLettersIgnoringASCIICase, to check the beginning of a string.
+Moving some code from WTF::equalLettersIgnoringASCIICaseCommonWithoutLength in
+WTF::hasPrefixWithLettersIgnoringASCIICaseCommon to enable reuse in
+WTF::startsWithLettersIgnoringASCIICaseCommon.
+
+* wtf/text/StringCommon.h:
+(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):
+(WTF::equalLettersIgnoringASCIICaseCommonWithoutLength):
+(WTF::startsWithLettersIgnoringASCIICaseCommonWithoutLength):
+(WTF::startsWithLettersIgnoringASCIICaseCommon):
+* wtf/text/StringImpl.h:
+(WTF::startsWithLettersIgnoringASCIICase):
+* wtf/text/WTFString.h:
+(WTF::startsWithLettersIgnoringASCIICase):
+
2016-03-10 Frederic Wang
[GTK] Add support for WOFF2
Modified: trunk/Source/WTF/wtf/text/StringCommon.h (198018 => 198019)
--- trunk/Source/WTF/wtf/text/StringCommon.h 2016-03-11 14:45:14 UTC (rev 198018)
+++ trunk/Source/WTF/wtf/text/StringCommon.h 2016-03-11 15:10:18 UTC (rev 198019)
@@ -590,22 +590,39 @@
return charactersLength == lowercaseLettersStringLength && equalLettersIgnoringASCIICase(characters, lowercaseLetters, lowercaseLettersStringLength);
}
-// This is intentionally not marked inline because it's used often and is not speed-critical enough to want it inlined everywhere.
-template bool equalLettersIgnoringASCIICaseCommonWithoutLength(const StringClass& string, const char* lowercaseLetters)
+template bool inline hasPrefixWithLettersIgnoringASCIICaseCommon(const StringClass& string, const char* lowercaseLetters, unsigned length)
{
#if !ASSERT_DISABLED
ASSERT(*lowercaseLetters);
for (const char* letter = lowercaseLetters; *letter; ++letter)
ASSERT(toASCIILowerUnchecked(*letter) == *letter);
#endif
-unsigned length = string.length();
-if (length != strlen(lowercaseLetters))
-return false;
+ASSERT(string.length() >= length);
+
if (string.is8Bit())
return equalLettersIgnoringASCIICase(string.characters8(), lowercaseLetters, length);
return equalLettersIgnoringASCIICase(string.characters16(), lowercaseLetters, length);
}
+// This is intentionally not marked inline because it's used often and is not speed-critical enough to want it inlined everywhere.
+template bool equalLettersIgnoringASCIICaseCommonWithoutLength(const StringClass& string, const char* lowercaseLetters)
+{
+unsigned length = string.length();
+if (length != strlen(lowercaseLetters))
+return false;
+return hasPrefixWithLettersIgnoringASCIICaseCommon(string, lowercaseLetters, length);
+}
+
+template bool startsWithLettersIgnoringASCIICaseCommonWithoutLength(const StringClass& string, const char* lowercaseLetters)
+{
+size_t prefixLength = strlen(lowercaseLetters);
+if (!prefixLength)
+
[webkit-changes] [198005] trunk
Title: [198005] trunk Revision 198005 Author youenn.fab...@crf.canon.fr Date 2016-03-11 04:08:22 -0800 (Fri, 11 Mar 2016) Log Message [Fetch API] Use DeferredWrapper directly in FetchBody promise handling https://bugs.webkit.org/show_bug.cgi?id=155291 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: Added. * web-platform-tests/fetch/api/request/request-consume-empty.html: Added. * web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: Added. * web-platform-tests/fetch/api/response/response-consume-empty.html: Added. Source/WebCore: Moved from typed DOMPromise to DeferredWrapper as there can only be one promise resolved. Started preparing the handling of blobs translation to other resolved types. Fixed the case of empty body, in which case promises should resolve with empty objects (strings, buffers...) and not null. Added Consumer structure to handle asynchronous resolution/rejection of promises. Added preliminary API to resolve promises based on data stored as a Blob. FetchBodyOwner will be responsible to do/stop blob loading. Tests: imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty.html * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::processIfEmptyOrDisturbed): Fixed empty body case. (WebCore::FetchBody::arrayBuffer): (WebCore::FetchBody::blob): (WebCore::FetchBody::json): (WebCore::FetchBody::text): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeText): (WebCore::FetchBody::loadingType): (WebCore::FetchBody::consumeBlob): (WebCore::FetchBody::resolveAsJSON): (WebCore::FetchBody::loadingFailed): (WebCore::FetchBody::loadedAsBlob): * Modules/fetch/FetchBody.h: (WebCore::FetchBody::formData): (WebCore::FetchBody::Consumer::Consumer): * Modules/fetch/FetchBody.idl: * Modules/fetch/FetchBodyOwner.h: (WebCore::FetchBodyOwner::arrayBuffer): (WebCore::FetchBodyOwner::blob): (WebCore::FetchBodyOwner::formData): (WebCore::FetchBodyOwner::json): (WebCore::FetchBodyOwner::text): (WebCore::FetchBodyOwner::loadBlob): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchBody.idl trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (198004 => 198005) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-11 11:13:25 UTC (rev 198004) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-11 12:08:22 UTC (rev 198005) @@ -1,3 +1,15 @@ +2016-03-11 Youenn Fablet + +[Fetch API] Use DeferredWrapper directly in FetchBody promise handling +https://bugs.webkit.org/show_bug.cgi?id=155291 + +Reviewed by Darin Adler. + +* web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: Added. +* web-platform-tests/fetch/api/request/request-consume-empty.html: Added. +* web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-consume-empty.html: Added. + 2016-03-09 Chris Dumez focus() / blur() should be on HTMLElement / SVGElement, not Element Added: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt (0 => 198005) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt 2016-03-11 12:08:22 UTC (rev 198005) @@ -0,0 +1,7 @@ + +PASS Consume request's body as text +PASS Consume request's body as blob +PASS Consume request's body as arrayBuffer +PASS Consume request's body as json +FAIL Consume request's body as formData promise_test: Unhandled rejection with value: undefined + Added: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html (0 => 198005) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty.html 2016-03-11 12:08:22 UTC (rev 198005) @@ -0,0 +1,81 @@ + + + + +Request consume empty bodies + + + +
[webkit-changes] [197778] trunk/Source/WebCore
Title: [197778] trunk/Source/WebCore Revision 197778 Author youenn.fab...@crf.canon.fr Date 2016-03-08 10:09:40 -0800 (Tue, 08 Mar 2016) Log Message [Fetch API] Commonalize handling of FetchBody by FetchRequest and FetchResponse https://bugs.webkit.org/show_bug.cgi?id=154959 Reviewed by Darin Adler. Introducing FetchBodyOwner class as base class of FetchRequest and FetchResponse. This class is an ActiveDOMObject and is responsible of handling the Body API implemented by Request and Response. Covered by existing tests. * Modules/fetch/FetchBodyOwner.h: Added. (WebCore::FetchBodyOwner::isDisturbed): (WebCore::FetchBodyOwner::arrayBuffer): (WebCore::FetchBodyOwner::formData): (WebCore::FetchBodyOwner::blob): (WebCore::FetchBodyOwner::json): (WebCore::FetchBodyOwner::text): (WebCore::FetchBodyOwner::body): (WebCore::FetchBodyOwner::FetchBodyOwner): * Modules/fetch/FetchRequest.h: (WebCore::FetchRequest::FetchRequest): * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::FetchResponse): * Modules/fetch/FetchResponse.h: * WebCore.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj Added Paths trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h Diff Modified: trunk/Source/WebCore/ChangeLog (19 => 197778) --- trunk/Source/WebCore/ChangeLog 2016-03-08 18:06:08 UTC (rev 19) +++ trunk/Source/WebCore/ChangeLog 2016-03-08 18:09:40 UTC (rev 197778) @@ -1,3 +1,31 @@ +2016-03-08 Youenn Fablet + +[Fetch API] Commonalize handling of FetchBody by FetchRequest and FetchResponse +https://bugs.webkit.org/show_bug.cgi?id=154959 + +Reviewed by Darin Adler. + +Introducing FetchBodyOwner class as base class of FetchRequest and FetchResponse. +This class is an ActiveDOMObject and is responsible of handling the Body API implemented by Request and Response. + +Covered by existing tests. + +* Modules/fetch/FetchBodyOwner.h: Added. +(WebCore::FetchBodyOwner::isDisturbed): +(WebCore::FetchBodyOwner::arrayBuffer): +(WebCore::FetchBodyOwner::formData): +(WebCore::FetchBodyOwner::blob): +(WebCore::FetchBodyOwner::json): +(WebCore::FetchBodyOwner::text): +(WebCore::FetchBodyOwner::body): +(WebCore::FetchBodyOwner::FetchBodyOwner): +* Modules/fetch/FetchRequest.h: +(WebCore::FetchRequest::FetchRequest): +* Modules/fetch/FetchResponse.cpp: +(WebCore::FetchResponse::FetchResponse): +* Modules/fetch/FetchResponse.h: +* WebCore.xcodeproj/project.pbxproj: + 2016-03-08 Chris Dumez Unreviewed, fix 32-bit build after r197726. Copied: trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h (from rev 19, trunk/Source/WebCore/Modules/fetch/FetchRequest.h) (0 => 197778) --- trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h (rev 0) +++ trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h 2016-03-08 18:09:40 UTC (rev 197778) @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2016 Canon Inc. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted, provided that the following conditions + * are required to be met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of Canon Inc. nor the names of + * its contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY CANON INC. AND ITS CONTRIBUTORS "AS IS" AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL CANON INC. AND ITS CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef FetchBodyOwner_h +#define FetchBodyOwner_h + +#if ENABLE(FETCH_API) + +#include "ActiveDOMObject.h" +#include "FetchBody.h" + +namespace WebCor
[webkit-changes] [197744] trunk/Source/WebCore
Title: [197744] trunk/Source/WebCore
Revision 197744
Author youenn.fab...@crf.canon.fr
Date 2016-03-08 01:10:09 -0800 (Tue, 08 Mar 2016)
Log Message
[Fetch API] Make FetchRequest and FetchResponse ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=154729
Reviewed by Darin Adler.
Covered by existing tests.
Making FetchRequest and FetchResponse ActiveDOMObject.
Both objects can always be suspended now.
This might be updated when blob conversion is added or when fetching data to fill in FetchResponse.
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::create):
(WebCore::FetchRequest::clone):
(WebCore::FetchRequest::activeDOMObjectName):
(WebCore::FetchRequest::canSuspendForDocumentSuspension):
* Modules/fetch/FetchRequest.h:
(WebCore::FetchRequest::FetchRequest):
* Modules/fetch/FetchRequest.idl:
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::error):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::FetchResponse):
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::activeDOMObjectName):
(WebCore::FetchResponse::canSuspendForDocumentSuspension):
* Modules/fetch/FetchResponse.h:
(WebCore::FetchResponse::create):
* Modules/fetch/FetchResponse.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp
trunk/Source/WebCore/Modules/fetch/FetchRequest.h
trunk/Source/WebCore/Modules/fetch/FetchRequest.idl
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (197743 => 197744)
--- trunk/Source/WebCore/ChangeLog 2016-03-08 09:08:11 UTC (rev 197743)
+++ trunk/Source/WebCore/ChangeLog 2016-03-08 09:10:09 UTC (rev 197744)
@@ -1,3 +1,35 @@
+2016-03-08 Youenn Fablet
+
+[Fetch API] Make FetchRequest and FetchResponse ActiveDOMObject
+https://bugs.webkit.org/show_bug.cgi?id=154729
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+Making FetchRequest and FetchResponse ActiveDOMObject.
+Both objects can always be suspended now.
+This might be updated when blob conversion is added or when fetching data to fill in FetchResponse.
+
+* Modules/fetch/FetchRequest.cpp:
+(WebCore::FetchRequest::create):
+(WebCore::FetchRequest::clone):
+(WebCore::FetchRequest::activeDOMObjectName):
+(WebCore::FetchRequest::canSuspendForDocumentSuspension):
+* Modules/fetch/FetchRequest.h:
+(WebCore::FetchRequest::FetchRequest):
+* Modules/fetch/FetchRequest.idl:
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::error):
+(WebCore::FetchResponse::redirect):
+(WebCore::FetchResponse::FetchResponse):
+(WebCore::FetchResponse::clone):
+(WebCore::FetchResponse::activeDOMObjectName):
+(WebCore::FetchResponse::canSuspendForDocumentSuspension):
+* Modules/fetch/FetchResponse.h:
+(WebCore::FetchResponse::create):
+* Modules/fetch/FetchResponse.idl:
+
2016-03-08 Nikos Andronikos
[SVG2] Implement marker orient='auto-start-reverse'
Modified: trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp (197743 => 197744)
--- trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp 2016-03-08 09:08:11 UTC (rev 197743)
+++ trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp 2016-03-08 09:10:09 UTC (rev 197744)
@@ -266,7 +266,7 @@
return nullptr;
}
-return adoptRef(*new FetchRequest(WTFMove(body), headers.releaseNonNull(), WTFMove(internalRequest)));
+return adoptRef(*new FetchRequest(context, WTFMove(body), headers.releaseNonNull(), WTFMove(internalRequest)));
}
RefPtr FetchRequest::create(ScriptExecutionContext& context, FetchRequest* input, const Dictionary& init, ExceptionCode& ec)
@@ -297,7 +297,7 @@
return nullptr;
}
-return adoptRef(*new FetchRequest(WTFMove(body), headers.releaseNonNull(), WTFMove(internalRequest)));
+return adoptRef(*new FetchRequest(context, WTFMove(body), headers.releaseNonNull(), WTFMove(internalRequest)));
}
String FetchRequest::type() const
@@ -435,7 +435,7 @@
return String();
}
-RefPtr FetchRequest::clone(ExceptionCode& ec)
+RefPtr FetchRequest::clone(ScriptExecutionContext* context, ExceptionCode& ec)
{
if (isDisturbed()) {
ec = TypeError;
@@ -443,9 +443,19 @@
}
// FIXME: Validate body teeing.
-return adoptRef(*new FetchRequest(FetchBody(m_body), FetchHeaders::create(m_headers.get()), FetchRequest::InternalRequest(m_internalRequest)));
+return adoptRef(*new FetchRequest(*context, FetchBody(m_body), FetchHeaders::create(m_headers.get()), FetchRequest::InternalRequest(m_internalRequest)));
}
+const char* FetchRequest::activeDOMObjectName() const
+{
+return "Request";
+}
+
+bool FetchRequest::canSuspendFor
[webkit-changes] [197642] trunk/Source/WebCore
Title: [197642] trunk/Source/WebCore
Revision 197642
Author youenn.fab...@crf.canon.fr
Date 2016-03-06 12:44:49 -0800 (Sun, 06 Mar 2016)
Log Message
Enable DOM class create functions to take parameters in case of JSBuiltinConstructor
https://bugs.webkit.org/show_bug.cgi?id=155022
Reviewed by Darin Adler.
Introducing JSDOMObjectInspector to check whether a given JS class is built-in (no DOM class).
If that is not the case, the JS class wraps a DOM class.
The inspector detects whether the DOM class create static method takes no parameter or some parameters.
This is used in JSDOMConstructor.h to generate correctly the createJSObject functions needed by JSBuiltinConstructor.
Updated binding generator to not generate anymore createJSObject as it is handled directly in JSDOMConstructor.h.
Covered by existing tests.
* bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor::callConstructor):
(WebCore::createJSObject):
(WebCore::JSBuiltinConstructor::construct):
* bindings/js/JSDOMWrapper.h:
* bindings/js/JSKeyValueIterator.h: Taking benefit of JSClass::DOMWrapper type declaration.
* bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::initializeExecutable): Deleted.
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::initializeExecutable): Deleted.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition): Deleted.
* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::JSTestClassWithJSBuiltinConstructorConstructor::prototypeForStructure): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMConstructor.h
trunk/Source/WebCore/bindings/js/JSDOMWrapper.h
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
trunk/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (197641 => 197642)
--- trunk/Source/WebCore/ChangeLog 2016-03-06 20:11:09 UTC (rev 197641)
+++ trunk/Source/WebCore/ChangeLog 2016-03-06 20:44:49 UTC (rev 197642)
@@ -1,3 +1,33 @@
+2016-03-06 Youenn Fablet
+
+Enable DOM class create functions to take parameters in case of JSBuiltinConstructor
+https://bugs.webkit.org/show_bug.cgi?id=155022
+
+Reviewed by Darin Adler.
+
+Introducing JSDOMObjectInspector to check whether a given JS class is built-in (no DOM class).
+If that is not the case, the JS class wraps a DOM class.
+The inspector detects whether the DOM class create static method takes no parameter or some parameters.
+This is used in JSDOMConstructor.h to generate correctly the createJSObject functions needed by JSBuiltinConstructor.
+
+Updated binding generator to not generate anymore createJSObject as it is handled directly in JSDOMConstructor.h.
+
+Covered by existing tests.
+
+* bindings/js/JSDOMConstructor.h:
+(WebCore::JSBuiltinConstructor::callConstructor):
+(WebCore::createJSObject):
+(WebCore::JSBuiltinConstructor::construct):
+* bindings/js/JSDOMWrapper.h:
+* bindings/js/JSKeyValueIterator.h: Taking benefit of JSClass::DOMWrapper type declaration.
+* bindings/js/JSReadableStreamPrivateConstructors.cpp:
+(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::initializeExecutable): Deleted.
+(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::initializeExecutable): Deleted.
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorDefinition): Deleted.
+* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
+(WebCore::JSTestClassWithJSBuiltinConstructorConstructor::prototypeForStructure): Deleted.
+
2016-03-06 Antti Koivisto
RenderTextControlSingleLine shouldn't mutate placeholder element inline style
Modified: trunk/Source/WebCore/bindings/js/JSDOMConstructor.h (197641 => 197642)
--- trunk/Source/WebCore/bindings/js/JSDOMConstructor.h 2016-03-06 20:11:09 UTC (rev 197641)
+++ trunk/Source/WebCore/bindings/js/JSDOMConstructor.h 2016-03-06 20:44:49 UTC (rev 197642)
@@ -104,7 +104,7 @@
template class JSBuiltinConstructor : public DOMConstructorJSBuiltinObject {
public:
-typedef DOMConstructorJSBuiltinObject Base;
+using Base = DOMConstructorJSBuiltinObject;
static JSBuiltinConstructor* create(JSC::VM&, JSC::Structure*, JSDOMGlobalObject&);
static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue prototype);
@@ -119,8 +119,10 @@
void finishCreation(JSC::VM&, JSDOMGlobalObject&);
static JSC::ConstructType getConstructData(JSC::JSCell*, JSC::ConstructData&);
static JSC::EncodedJSValue JSC_HOST_CALL construct(JSC::ExecState*);
-JSC:
[webkit-changes] [197551] trunk/Source/WebCore
Title: [197551] trunk/Source/WebCore
Revision 197551
Author youenn.fab...@crf.canon.fr
Date 2016-03-04 00:27:36 -0800 (Fri, 04 Mar 2016)
Log Message
Remove PassRefPtr from ThreadableLoader and relatives
https://bugs.webkit.org/show_bug.cgi?id=154966
Reviewed by Darin Adler.
Covered by existing tests.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::create):
* loader/DocumentThreadableLoader.h:
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
* loader/ThreadableLoader.h:
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
* loader/WorkerThreadableLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/DocumentThreadableLoader.h
trunk/Source/WebCore/loader/ThreadableLoader.cpp
trunk/Source/WebCore/loader/ThreadableLoader.h
trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp
trunk/Source/WebCore/loader/WorkerThreadableLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (197550 => 197551)
--- trunk/Source/WebCore/ChangeLog 2016-03-04 07:41:45 UTC (rev 197550)
+++ trunk/Source/WebCore/ChangeLog 2016-03-04 08:27:36 UTC (rev 197551)
@@ -1,3 +1,23 @@
+2016-03-04 Youenn Fablet
+
+Remove PassRefPtr from ThreadableLoader and relatives
+https://bugs.webkit.org/show_bug.cgi?id=154966
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+* loader/DocumentThreadableLoader.cpp:
+(WebCore::DocumentThreadableLoader::create):
+* loader/DocumentThreadableLoader.h:
+* loader/ThreadableLoader.cpp:
+(WebCore::ThreadableLoader::create):
+* loader/ThreadableLoader.h:
+* loader/WorkerThreadableLoader.cpp:
+(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
+(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
+* loader/WorkerThreadableLoader.h:
+
2016-03-03 Ryosuke Niwa
Let XCode have its own way and also sort the file.
Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (197550 => 197551)
--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2016-03-04 07:41:45 UTC (rev 197550)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2016-03-04 08:27:36 UTC (rev 197551)
@@ -66,17 +66,17 @@
loadResourceSynchronously(document, request, client, options, nullptr);
}
-PassRefPtr DocumentThreadableLoader::create(Document& document, ThreadableLoaderClient& client, const ResourceRequest& request, const ThreadableLoaderOptions& options, std::unique_ptr&& contentSecurityPolicy)
+RefPtr DocumentThreadableLoader::create(Document& document, ThreadableLoaderClient& client, const ResourceRequest& request, const ThreadableLoaderOptions& options, std::unique_ptr&& contentSecurityPolicy)
{
RefPtr loader = adoptRef(new DocumentThreadableLoader(document, client, LoadAsynchronously, request, options, WTFMove(contentSecurityPolicy)));
if (!loader->m_resource)
loader = nullptr;
-return loader.release();
+return loader;
}
-PassRefPtr DocumentThreadableLoader::create(Document& document, ThreadableLoaderClient& client, const ResourceRequest& request, const ThreadableLoaderOptions& options)
+RefPtr DocumentThreadableLoader::create(Document& document, ThreadableLoaderClient& client, const ResourceRequest& request, const ThreadableLoaderOptions& options)
{
-return DocumentThreadableLoader::create(document, client, request, options, nullptr);
+return create(document, client, request, options, nullptr);
}
DocumentThreadableLoader::DocumentThreadableLoader(Document& document, ThreadableLoaderClient& client, BlockingBehavior blockingBehavior, const ResourceRequest& request, const ThreadableLoaderOptions& options, std::unique_ptr&& contentSecurityPolicy)
Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.h (197550 => 197551)
--- trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2016-03-04 07:41:45 UTC (rev 197550)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.h 2016-03-04 08:27:36 UTC (rev 197551)
@@ -34,8 +34,6 @@
#include "CachedRawResourceClient.h"
#include "CachedResourceHandle.h"
#include "ThreadableLoader.h"
-#include
-#include
namespace WebCore {
class CachedRawResource;
@@ -52,8 +50,8 @@
static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, std::unique_ptr&&);
static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);
-static PassRefPtr create(D
[webkit-changes] [197396] trunk
Title: [197396] trunk
Revision 197396
Author youenn.fab...@crf.canon.fr
Date 2016-03-01 02:34:17 -0800 (Tue, 01 Mar 2016)
Log Message
[Fetch API] Support Request and Response blob() when body data is a blob
https://bugs.webkit.org/show_bug.cgi?id=154820
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Adding blob specific tests. New tests are not covered yet as they require converting data from a blob into another form (JSON, text...).
Rebasing expectations with test that is now passing and new failing tests.
Fixing typos in test (Json -> JSON and removing TextDecoder use).
* web-platform-tests/fetch/api/request/request-consume-expected.txt:
* web-platform-tests/fetch/api/request/request-consume.html:
* web-platform-tests/fetch/api/response/response-consume-expected.txt:
* web-platform-tests/fetch/api/response/response-consume.html:
Source/WebCore:
Adding support for returning the same Blob that is stored in Body in case JS blob() is called.
Adding support for Blob creation when data is stored as text.
Updated JSDOMBinding and JSDOMPromise to return a JS ArrayBuffer for Vector as well as Vector.
Covered by added tests.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::extractFromText):
* Modules/fetch/FetchBody.h:
* bindings/js/JSDOMBinding.h:
(WebCore::toJS):
* bindings/js/JSDOMPromise.h:
(WebCore::DeferredWrapper::resolve): Deleted.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197395 => 197396)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-01 09:05:37 UTC (rev 197395)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-03-01 10:34:17 UTC (rev 197396)
@@ -1,3 +1,19 @@
+2016-03-01 Youenn Fablet
+
+[Fetch API] Support Request and Response blob() when body data is a blob
+https://bugs.webkit.org/show_bug.cgi?id=154820
+
+Reviewed by Darin Adler.
+
+Adding blob specific tests. New tests are not covered yet as they require converting data from a blob into another form (JSON, text...).
+Rebasing expectations with test that is now passing and new failing tests.
+Fixing typos in test (Json -> JSON and removing TextDecoder use).
+
+* web-platform-tests/fetch/api/request/request-consume-expected.txt:
+* web-platform-tests/fetch/api/request/request-consume.html:
+* web-platform-tests/fetch/api/response/response-consume-expected.txt:
+* web-platform-tests/fetch/api/response/response-consume.html:
+
2016-02-29 Chris Dumez
Use HTML parsing rules for textarea.maxLength
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt (197395 => 197396)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt 2016-03-01 09:05:37 UTC (rev 197395)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume-expected.txt 2016-03-01 10:34:17 UTC (rev 197396)
@@ -1,9 +1,13 @@
PASS Consume request's body as text
-FAIL Consume request's body as blob promise_test: Unhandled rejection with value: undefined
+PASS Consume request's body as blob
PASS Consume request's body as arrayBuffer
PASS Consume request's body as json
FAIL Consume request's body as formData promise_test: Unhandled rejection with value: undefined
+PASS Consume blob response's body as blob
+FAIL Consume blob response's body as text promise_test: Unhandled rejection with value: undefined
+FAIL Consume blob response's body as json promise_test: Unhandled rejection with value: undefined
+FAIL Consume blob response's body as arrayBuffer promise_test: Unhandled rejection with value: undefined
PASS Consume JSON from text: '"null"'
PASS Consume JSON from text: '"1"'
PASS Consume JSON from text: '"true"'
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html (197395 => 197396)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html 2016-03-01 09:05:37 UTC (rev 197395)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-consume.html 2016-03-01 10:34:17 UTC (rev 197396)
@@ -79,12 +79,28 @@
var formData = new FormData();
formData.append("nam
[webkit-changes] [197359] trunk/LayoutTests
Title: [197359] trunk/LayoutTests
Revision 197359
Author youenn.fab...@crf.canon.fr
Date 2016-02-29 10:51:28 -0800 (Mon, 29 Feb 2016)
Log Message
streams/pipe-to.html flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=154687
Reviewed by Darin Adler.
* TestExpectations: Marking streams/pipe-to.html as slow.
* streams/pipe-to.html: Increasing the timeout value.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/streams/pipe-to.html
Diff
Modified: trunk/LayoutTests/ChangeLog (197358 => 197359)
--- trunk/LayoutTests/ChangeLog 2016-02-29 18:33:24 UTC (rev 197358)
+++ trunk/LayoutTests/ChangeLog 2016-02-29 18:51:28 UTC (rev 197359)
@@ -1,3 +1,13 @@
+2016-02-29 Youenn Fablet
+
+streams/pipe-to.html flaky on mac-wk1 debug
+https://bugs.webkit.org/show_bug.cgi?id=154687
+
+Reviewed by Darin Adler.
+
+* TestExpectations: Marking streams/pipe-to.html as slow.
+* streams/pipe-to.html: Increasing the timeout value.
+
2016-02-29 Adrien Plazas
[GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent()
Modified: trunk/LayoutTests/TestExpectations (197358 => 197359)
--- trunk/LayoutTests/TestExpectations 2016-02-29 18:33:24 UTC (rev 197358)
+++ trunk/LayoutTests/TestExpectations 2016-02-29 18:51:28 UTC (rev 197359)
@@ -798,6 +798,7 @@
webkit.org/b/150598 fast/repaint/table-hover-on-link.html [ Pass Failure ]
webkit.org/b/151949 streams/reference-implementation/pipe-to.html [ Failure ]
+webkit.org/b/154687 streams/pipe-to.html [ Slow ]
webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/streams/pipe-to.html (197358 => 197359)
--- trunk/LayoutTests/streams/pipe-to.html 2016-02-29 18:33:24 UTC (rev 197358)
+++ trunk/LayoutTests/streams/pipe-to.html 2016-02-29 18:51:28 UTC (rev 197359)
@@ -8,7 +8,7 @@
// This test is alone here for timing reasons though it should be at streams/reference-implementation/pipe-to.html.
var test24 = async_test('Piping to a writable stream that does not consume the writes fast enough exerts backpressure on the source');
test24.step(function() {
-const timeoutMultiplier = 5;
+const timeoutMultiplier = 15;
var desiredSizes = [];
var rs = new ReadableStream({
start: function(c) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [197347] trunk/Source/WebCore
Title: [197347] trunk/Source/WebCore
Revision 197347
Author youenn.fab...@crf.canon.fr
Date 2016-02-29 05:01:51 -0800 (Mon, 29 Feb 2016)
Log Message
Refactor FetchBody constructors
https://bugs.webkit.org/show_bug.cgi?id=154721
Reviewed by Sam Weinig and Darin Adler.
Covered by existing tests.
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract): Renamed from "fromJSValue"
(WebCore::FetchBody::extractFromBody): Renamed from "fromRequestBody" and making use of move constructor.
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::FetchBody): Making default constructor public and removing empty static method.
* Modules/fetch/FetchRequest.cpp:
(WebCore::buildBody):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::error):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::initializeWith):
* Modules/fetch/FetchResponse.h:
(WebCore::FetchResponse::create):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (197346 => 197347)
--- trunk/Source/WebCore/ChangeLog 2016-02-29 11:47:14 UTC (rev 197346)
+++ trunk/Source/WebCore/ChangeLog 2016-02-29 13:01:51 UTC (rev 197347)
@@ -1,3 +1,26 @@
+2016-02-29 Youenn Fablet
+
+Refactor FetchBody constructors
+https://bugs.webkit.org/show_bug.cgi?id=154721
+
+Reviewed by Sam Weinig and Darin Adler.
+
+Covered by existing tests.
+
+* Modules/fetch/FetchBody.cpp:
+(WebCore::FetchBody::extract): Renamed from "fromJSValue"
+(WebCore::FetchBody::extractFromBody): Renamed from "fromRequestBody" and making use of move constructor.
+* Modules/fetch/FetchBody.h:
+(WebCore::FetchBody::FetchBody): Making default constructor public and removing empty static method.
+* Modules/fetch/FetchRequest.cpp:
+(WebCore::buildBody):
+* Modules/fetch/FetchResponse.cpp:
+(WebCore::FetchResponse::error):
+(WebCore::FetchResponse::redirect):
+(WebCore::FetchResponse::initializeWith):
+* Modules/fetch/FetchResponse.h:
+(WebCore::FetchResponse::create):
+
2016-02-28 Antti Koivisto
::slotted doesn't work in nested shadow trees
Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.cpp (197346 => 197347)
--- trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-02-29 11:47:14 UTC (rev 197346)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.cpp 2016-02-29 13:01:51 UTC (rev 197347)
@@ -61,7 +61,7 @@
{
}
-FetchBody FetchBody::fromJSValue(JSC::ExecState& state, JSC::JSValue value)
+FetchBody FetchBody::extract(JSC::ExecState& state, JSC::JSValue value)
{
if (value.inherits(JSBlob::info()))
return FetchBody(*JSBlob::toWrapped(value));
@@ -69,27 +69,16 @@
return FetchBody(*JSDOMFormData::toWrapped(value));
if (value.isString())
return FetchBody(value.toWTFString(&state));
-return FetchBody();
+return { };
}
-// FIXME: Once FetchResponse is added, check whether using a move constructor instead.
-// Ensure whether resetting m_mimeType to the empty string be not observable.
-FetchBody FetchBody::fromRequestBody(FetchBody* body)
+FetchBody FetchBody::extractFromBody(FetchBody* body)
{
if (!body)
-return FetchBody();
+return { };
-FetchBody result;
-result.m_type = body->m_type;
-result.m_mimeType = body->m_mimeType;
-
-result.m_blob = WTFMove(body->m_blob);
-result.m_formData = WTFMove(body->m_formData);
-result.m_text = WTFMove(body->m_text);
-
body->m_isDisturbed = true;
-
-return result;
+return FetchBody(WTFMove(*body));
}
template inline bool FetchBody::processIfEmptyOrDisturbed(DOMPromise& promise)
Modified: trunk/Source/WebCore/Modules/fetch/FetchBody.h (197346 => 197347)
--- trunk/Source/WebCore/Modules/fetch/FetchBody.h 2016-02-29 11:47:14 UTC (rev 197346)
+++ trunk/Source/WebCore/Modules/fetch/FetchBody.h 2016-02-29 13:01:51 UTC (rev 197347)
@@ -68,9 +68,9 @@
void setMimeType(const String& mimeType) { m_mimeType = mimeType; }
String mimeType() const { return m_mimeType; }
-static FetchBody fromJSValue(JSC::ExecState&, JSC::JSValue);
-static FetchBody fromRequestBody(FetchBody*);
-static FetchBody empty() { return FetchBody(); }
+static FetchBody extract(JSC::ExecState&, JSC::JSValue);
+static FetchBody extractFromBody(FetchBody*);
+FetchBody() = default;
private:
template bool processIfEmptyOrDisturbed(DOMPromise&);
@@ -80,7 +80,6 @@
FetchBody(Ref&&);
FetchBody(Ref&&);
FetchBody(String&&);
-FetchBody() { }
[webkit-changes] [197163] trunk/Tools
Title: [197163] trunk/Tools
Revision 197163
Author youenn.fab...@crf.canon.fr
Date 2016-02-26 02:10:06 -0800 (Fri, 26 Feb 2016)
Log Message
W3C test importer should have an option to clean the destination directory
https://bugs.webkit.org/show_bug.cgi?id=152685
Reviewed by Darin Adler.
Adding --clean-dest-dir option to W3C test importer.
When this option is set, all files in the destination directory will be deleted
except for WebKit specific files (test expectations, .gitignore...) before new tests import.
Dangling test expectations are removed after tests import.'
Adding unit test and minor refactoring for the other tests.
* Scripts/webkitpy/w3c/test_importer.py:
(parse_args): Add '--clean-dest-dir' option.
(TestImporter.do_import):
(TestImporter._is_baseline): helper routine to capture -expected.txt files.
(TestImporter):
(TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
(TestImporter.clean_destination_directory):
(TestImporter.remove_dangling_expectations):
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest._parse_options):
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest.test_import_dir_with_empty_init_py):
(test_clean_directory_option):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_importer.py
trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (197162 => 197163)
--- trunk/Tools/ChangeLog 2016-02-26 08:55:07 UTC (rev 197162)
+++ trunk/Tools/ChangeLog 2016-02-26 10:10:06 UTC (rev 197163)
@@ -1,3 +1,32 @@
+2016-02-26 Youenn Fablet
+
+W3C test importer should have an option to clean the destination directory
+https://bugs.webkit.org/show_bug.cgi?id=152685
+
+Reviewed by Darin Adler.
+
+Adding --clean-dest-dir option to W3C test importer.
+When this option is set, all files in the destination directory will be deleted
+except for WebKit specific files (test expectations, .gitignore...) before new tests import.
+Dangling test expectations are removed after tests import.'
+
+Adding unit test and minor refactoring for the other tests.
+
+* Scripts/webkitpy/w3c/test_importer.py:
+(parse_args): Add '--clean-dest-dir' option.
+(TestImporter.do_import):
+(TestImporter._is_baseline): helper routine to capture -expected.txt files.
+(TestImporter):
+(TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
+(TestImporter.clean_destination_directory):
+(TestImporter.remove_dangling_expectations):
+* Scripts/webkitpy/w3c/test_importer_unittest.py:
+(TestImporterTest._parse_options):
+(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
+(TestImporterTest.test_import_dir_with_no_tests):
+(TestImporterTest.test_import_dir_with_empty_init_py):
+(test_clean_directory_option):
+
2016-02-25 Myles C. Maxfield
REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_importer.py (197162 => 197163)
--- trunk/Tools/Scripts/webkitpy/w3c/test_importer.py 2016-02-26 08:55:07 UTC (rev 197162)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_importer.py 2016-02-26 10:10:06 UTC (rev 197163)
@@ -147,6 +147,9 @@
parser.add_argument('--import-all', action='', default=False,
help='Ignore the ImportExpectations file. All tests will be imported. This option only applies when tests are downloaded from W3C repository')
+parser.add_argument('--clean-dest-dir', action='', dest='clean_destination_directory', default=False,
+ help='Clean destination directory. All files in the destination directory will be deleted except for WebKit specific files (test expectations, .gitignore...) before new tests import. Dangling test expectations (expectation file that is no longer related to a test) are removed after tests import.')
+
options, args = parser.parse_known_args(args)
if len(args) > 1:
parser.error('Incorrect number of arguments')
@@ -185,14 +188,20 @@
self.filesystem.maybe_make_directory(self.source_directory)
self.test_downloader().download_tests(self.source_directory, self.options.test_paths)
-if not self.options.test_paths or self._importing_downloaded_tests:
-self.find_importable_tests(self.source_directory)
-else:
-for test_path in self.options.test_paths:
-self.find_importable_tests(self.filesystem.join(self.source_directory, test_path))
+test_paths = self.options.test_paths if self.options
[webkit-changes] [197049] trunk
-attributes-expected.txt trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.cpp trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-clone.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-consume.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-error-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-error.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-idl-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-idl.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-001-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-init-002.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-error-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-error.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-redirect-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/response/response-static-redirect.html trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/Modules/fetch/FetchResponse.h trunk/Source/WebCore/Modules/fetch/FetchResponse.idl trunk/Source/WebCore/Modules/fetch/FetchResponse.js Diff Modified: trunk/LayoutTests/ChangeLog (197048 => 197049) --- trunk/LayoutTests/ChangeLog 2016-02-24 21:37:24 UTC (rev 197048) +++ trunk/LayoutTests/ChangeLog 2016-02-24 21:41:51 UTC (rev 197049) @@ -1,3 +1,22 @@ +2016-02-24 Youenn Fablet + +[Fetch API] Implement Fetch API Response +https://bugs.webkit.org/show_bug.cgi?id=154536 + +Reviewed by Alex Christensen. + +Adding Response as constructor in global and worker scopes. + +* js/dom/global-constructors-attributes-dedicated-worker-expected.txt: +* js/dom/global-constructors-attributes-expected.txt: +* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: +* platform/efl/js/dom/global-constructors-attributes-expected.txt: +* platform/gtk/js/dom/global-constructors-attributes-expected.txt: +* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: +* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: +* platform/mac/js/dom/global-constructors-attributes-expected.txt: +* platform/win/js/dom/global-constructors-attributes-expected.txt: + 2016-02-24 Commit Queue Unreviewed, rolling out r197033. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197048 => 197049) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-24 21:37:24 UTC (rev 197048) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-24 21:41:51 UTC (rev 197049) @@ -1,5 +1,31 @@ 2016-02-24 Youenn Fablet +[Fetch API] Implement Fetch API Response +https://bugs.webkit.org/show_bug.cgi?id=154536 + +Reviewed by Alex Christensen. + +New tests covering fetch API. + +* web-platform-tests/fetch/api/response/response-clone-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-clone.html: Added. +* web-platform-tests/fetch/api/response/response-consume-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-consume.html: Added. +* web-platform-tests/fetch/api/response/response-error-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-error.html: Added. +* web-platform-tests/fetch/api/response/response-idl-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-idl.html: Added. +* web-platform-tests/fetch/api/response/response-init-001-expected.txt: Added. +* web-platform-tests/fetch/api/response/response-init-001.html: Added. +* web-platform-tests/fetch/api/response/response-in
[webkit-changes] [197028] trunk/Source/WebCore
Title: [197028] trunk/Source/WebCore
Revision 197028
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 06:17:48 -0800 (Wed, 24 Feb 2016)
Log Message
Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
https://bugs.webkit.org/show_bug.cgi?id=154577
Reviewed by Myles C. Maxfield.
No change of behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (197027 => 197028)
--- trunk/Source/WebCore/ChangeLog 2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/ChangeLog 2016-02-24 14:17:48 UTC (rev 197028)
@@ -1,5 +1,19 @@
2016-02-24 Youenn Fablet
+Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
+https://bugs.webkit.org/show_bug.cgi?id=154577
+
+Reviewed by Myles C. Maxfield.
+
+No change of behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
+* bindings/scripts/test/JS/JSTestObj.h:
+(WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.
+
+2016-02-24 Youenn Fablet
+
[Fetch API] Refactor FetchHeaders initialization with iterators
https://bugs.webkit.org/show_bug.cgi?id=154537
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (197027 => 197028)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-02-24 14:17:48 UTC (rev 197028)
@@ -1050,16 +1050,6 @@
push(@headerContent, "static void destroy(JSC::JSCell*);\n");
}
-if ($interface->iterable) {
-push(@headerContent, "\n");
-if ($interface->iterable->keyType) {
-my $keyType = GetNativeType($interface->iterable->keyType);
-push(@headerContent, "using IteratorKey = $keyType;\n");
-}
-my $valueType = GetNativeType($interface->iterable->valueType);
-push(@headerContent, "using IteratorValue = $valueType;\n");
-}
-
# Class info
if ($interfaceName eq "Node") {
push(@headerContent, "\n");
@@ -4039,7 +4029,6 @@
my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
return "${svgNativeType}*" if $svgNativeType;
return "RefPtr" if $type eq "DOMStringList";
-return "RefPtr" if $type eq "FontFace";
return "RefPtr<${type}>" if $codeGenerator->IsTypedArrayType($type) and not $type eq "ArrayBuffer";
return $nativeType{$type} if exists $nativeType{$type};
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (197027 => 197028)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2016-02-24 14:17:48 UTC (rev 197028)
@@ -45,9 +45,6 @@
static bool getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&);
static void destroy(JSC::JSCell*);
-using IteratorKey = String;
-using IteratorValue = TestObj*;
-
DECLARE_INFO;
static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [197027] trunk
Title: [197027] trunk
Revision 197027
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 04:14:30 -0800 (Wed, 24 Feb 2016)
Log Message
W3C importer should generate all web-platform-tests submodules descriptions
https://bugs.webkit.org/show_bug.cgi?id=154587
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* resources/TestRepositories: Reactivated submodules description generation.
* resources/web-platform-tests-modules.json: Updated according modified scripts.
Tools:
Updated submodules description format (removing submodule name as it is the last string of the path really).
Added git subroutines.
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.origin_url):
(Git):
(Git.init_submodules):
(Git.submodules_status):
(Git.deinit_submodules):
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer._install_modules): Updated to submodule name removal.
* Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_submodules_generation): Reactivated partially this test.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/TestRepositories
trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
trunk/Tools/Scripts/webkitpy/w3c/test_downloader.py
trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197026 => 197027)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-24 12:14:30 UTC (rev 197027)
@@ -1,3 +1,13 @@
+2016-02-24 Youenn Fablet
+
+W3C importer should generate all web-platform-tests submodules descriptions
+https://bugs.webkit.org/show_bug.cgi?id=154587
+
+Reviewed by Darin Adler.
+
+* resources/TestRepositories: Reactivated submodules description generation.
+* resources/web-platform-tests-modules.json: Updated according modified scripts.
+
2016-02-23 Chris Dumez
[Reflected] IDL attributes of integer types should use HTML rules for parsing integers
Modified: trunk/LayoutTests/imported/w3c/resources/TestRepositories (197026 => 197027)
--- trunk/LayoutTests/imported/w3c/resources/TestRepositories 2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/resources/TestRepositories 2016-02-24 12:14:30 UTC (rev 197027)
@@ -30,6 +30,6 @@
"config.default.json",
"serve.py"
],
-"import_options": []
+"import_options": ["generate_git_submodules_description"]
}
]
Modified: trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json (197026 => 197027)
--- trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json 2016-02-24 12:14:30 UTC (rev 197027)
@@ -1,58 +1,77 @@
[
{
-"name": "resources",
"path": [
-"."
+"resources"
],
-"url": "https://github.com/w3c/testharness.js/archive/698441212391d5177b2f1806d97c7fd15cc46715.tar.gz",
+"url": "https://github.com/w3c/testharness.js/archive/698441212391d5177b2f1806d97c7fd15cc46715.tar.gz",
"url_subpath": "testharness.js-698441212391d5177b2f1806d97c7fd15cc46715"
},
{
-"name": "webidl2",
"path": [
-"resources"
-],
-"url": "https://github.com/darobin/webidl2.js/archive/bd216bcd5596d60734450adc938155deab1e1a80.tar.gz",
+"resources",
+"webidl2"
+],
+"url": "https://github.com/darobin/webidl2.js/archive/bd216bcd5596d60734450adc938155deab1e1a80.tar.gz",
"url_subpath": "webidl2.js-bd216bcd5596d60734450adc938155deab1e1a80"
-},
+},
{
-"name": "tools",
"path": [
-"."
+"resources",
+"webidl2",
+"test",
+"widlproc"
],
+"url": "https://github.com/dontcallmedom/widlproc/archive/4ef8dde69c0ba3d0167bccfa2775eea7f0d6c7fe.tar.gz",
+"url_subpath": "widlproc-4ef8dde69c0ba3d0167bccfa2775eea7f0d6c7fe"
+},
+{
+
[webkit-changes] [197026] trunk/Source/WebCore
Title: [197026] trunk/Source/WebCore
Revision 197026
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 04:11:15 -0800 (Wed, 24 Feb 2016)
Log Message
[Fetch API] Refactor FetchHeaders initialization with iterators
https://bugs.webkit.org/show_bug.cgi?id=154537
Reviewed by Darin Adler.
Covered by existing tests.
* Modules/fetch/FetchHeaders.cpp:
(WebCore::initializeWith): Deleted.
* Modules/fetch/FetchHeaders.h: Removed FetchHeaders::initializeWith.
* Modules/fetch/FetchHeaders.idl: Ditto.
* Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders): Making use of iterators to fill headers.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp
trunk/Source/WebCore/Modules/fetch/FetchHeaders.h
trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl
trunk/Source/WebCore/Modules/fetch/FetchHeaders.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (197025 => 197026)
--- trunk/Source/WebCore/ChangeLog 2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/ChangeLog 2016-02-24 12:11:15 UTC (rev 197026)
@@ -1,3 +1,19 @@
+2016-02-24 Youenn Fablet
+
+[Fetch API] Refactor FetchHeaders initialization with iterators
+https://bugs.webkit.org/show_bug.cgi?id=154537
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+* Modules/fetch/FetchHeaders.cpp:
+(WebCore::initializeWith): Deleted.
+* Modules/fetch/FetchHeaders.h: Removed FetchHeaders::initializeWith.
+* Modules/fetch/FetchHeaders.idl: Ditto.
+* Modules/fetch/FetchHeaders.js:
+(initializeFetchHeaders): Making use of iterators to fill headers.
+
2016-02-24 Carlos Garcia Campos
Unreviewed. Fix GObject DOM bindings API break after r196998.
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp (197025 => 197026)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp 2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp 2016-02-24 12:11:15 UTC (rev 197026)
@@ -36,13 +36,6 @@
namespace WebCore {
-void FetchHeaders::initializeWith(const FetchHeaders* headers, ExceptionCode&)
-{
-if (!headers)
-return;
-m_headers = headers->m_headers;
-}
-
// FIXME: Optimize these routines for HTTPHeaderMap keys and/or refactor them with XMLHttpRequest code.
static bool isForbiddenHeaderName(const String& name)
{
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.h (197025 => 197026)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.h 2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.h 2016-02-24 12:11:15 UTC (rev 197026)
@@ -62,7 +62,6 @@
bool has(const String&, ExceptionCode&) const;
void set(const String& name, const String& value, ExceptionCode&);
-void initializeWith(const FetchHeaders*, ExceptionCode&);
void fill(const FetchHeaders*);
String fastGet(HTTPHeaderName name) const { return m_headers.get(name); }
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl (197025 => 197026)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl 2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl 2016-02-24 12:11:15 UTC (rev 197026)
@@ -43,5 +43,4 @@
iterable;
[Private, RaisesException, ImplementedAs=append] void appendFromJS(DOMString name, DOMString value);
-[Private, RaisesException] void initializeWith(FetchHeaders headers);
};
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.js (197025 => 197026)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.js 2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.js 2016-02-24 12:11:15 UTC (rev 197026)
@@ -36,8 +36,9 @@
throw new @TypeError("headersInit must be an object");
if (this.constructor === headersInit.constructor) {
- // FIXME: Use iterators when available?
- this.@initializeWith(headersInit);
+ headersInit.forEach((value, name) => {
+ this.@appendFromJS(name, value);
+ });
}
if (headersInit instanceof @Array) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [196973] trunk/Source/WebCore
Title: [196973] trunk/Source/WebCore
Revision 196973
Author youenn.fab...@crf.canon.fr
Date 2016-02-23 01:39:30 -0800 (Tue, 23 Feb 2016)
Log Message
Refactor DOM Iterator next signature
https://bugs.webkit.org/show_bug.cgi?id=154531
Reviewed by Myles C. Maxfield.
Covered by existing tests.
* Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next): Using Optional to return iterator value.
* Modules/fetch/FetchHeaders.h:
* bindings/js/JSKeyValueIterator.h: Using Optional as returned iterator value.
(WebCore::keyValueIteratorForEach):
(WebCore::JSKeyValueIterator::next):
* css/FontFaceSet.cpp:
(WebCore::FontFaceSet::Iterator::next): Using Optional to return iterator value.
* css/FontFaceSet.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp
trunk/Source/WebCore/Modules/fetch/FetchHeaders.h
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
trunk/Source/WebCore/css/FontFaceSet.cpp
trunk/Source/WebCore/css/FontFaceSet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (196972 => 196973)
--- trunk/Source/WebCore/ChangeLog 2016-02-23 07:59:02 UTC (rev 196972)
+++ trunk/Source/WebCore/ChangeLog 2016-02-23 09:39:30 UTC (rev 196973)
@@ -1,3 +1,22 @@
+2016-02-23 Youenn Fablet
+
+Refactor DOM Iterator next signature
+https://bugs.webkit.org/show_bug.cgi?id=154531
+
+Reviewed by Myles C. Maxfield.
+
+Covered by existing tests.
+
+* Modules/fetch/FetchHeaders.cpp:
+(WebCore::FetchHeaders::Iterator::next): Using Optional to return iterator value.
+* Modules/fetch/FetchHeaders.h:
+* bindings/js/JSKeyValueIterator.h: Using Optional as returned iterator value.
+(WebCore::keyValueIteratorForEach):
+(WebCore::JSKeyValueIterator::next):
+* css/FontFaceSet.cpp:
+(WebCore::FontFaceSet::Iterator::next): Using Optional to return iterator value.
+* css/FontFaceSet.h:
+
2016-02-22 Gavin Barraclough
Some timer alignment cleanup.
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp (196972 => 196973)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp 2016-02-23 07:59:02 UTC (rev 196972)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp 2016-02-23 09:39:30 UTC (rev 196973)
@@ -179,19 +179,16 @@
}
}
-bool FetchHeaders::Iterator::next(JSC::ExecState&, String& nextKey, String& nextValue)
+Optional> FetchHeaders::Iterator::next(JSC::ExecState&)
{
while (m_currentIndex < m_keys.size()) {
-auto& key = m_keys[m_currentIndex++];
+String key = m_keys[m_currentIndex++];
String value = m_headers->m_headers.get(key);
-if (!value.isNull()) {
-nextKey = key;
-nextValue = WTFMove(value);
-return false;
-}
+if (!value.isNull())
+return WTF::KeyValuePair(WTFMove(key), WTFMove(value));
}
m_keys.clear();
-return true;
+return Nullopt;
}
FetchHeaders::Iterator::Iterator(FetchHeaders& headers)
Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.h (196972 => 196973)
--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.h 2016-02-23 07:59:02 UTC (rev 196972)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.h 2016-02-23 09:39:30 UTC (rev 196973)
@@ -32,6 +32,8 @@
#if ENABLE(FETCH_API)
#include "HTTPHeaderMap.h"
+#include
+#include
namespace JSC {
class ExecState;
@@ -69,7 +71,7 @@
class Iterator {
public:
explicit Iterator(FetchHeaders&);
-bool next(JSC::ExecState&, String& nextKey, String& nextValue);
+Optional> next(JSC::ExecState&);
private:
Ref m_headers;
Modified: trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h (196972 => 196973)
--- trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-23 07:59:02 UTC (rev 196972)
+++ trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-23 09:39:30 UTC (rev 196973)
@@ -88,7 +88,7 @@
JSKeyValueIteratorPrototype::createStructure(vm, globalObject, globalObject->objectPrototype()));
}
-bool next(JSC::ExecState&, JSC::JSValue&);
+JSC::JSValue next(JSC::ExecState&);
private:
JSKeyValueIterator(JSC::Structure* structure, JSWrapper& iteratedObject, IterationKind kind)
@@ -126,13 +126,11 @@
if (callType == JSC::CallTypeNone)
return throwVMTypeError(&state);
-typename JSWrapper::IteratorKey nextKey;
-typename JSWrapper::IteratorValue nextValue;
auto iterator = wrapper->wrapped().createIterator();
-while (!iterator.next(state, nextKey, nextValue)) {
+while (auto value = iterator.next(state)) {
JSC::MarkedArgumentBuffer arguments;
-arguments.append(toJS(&state, wrapper->globalObject(), nextValue));
-arguments.append(toJS(&state, wrapper->globalObject(), nextKey));
[webkit-changes] [196900] trunk
Title: [196900] trunk Revision 196900 Author youenn.fab...@crf.canon.fr Date 2016-02-22 00:31:14 -0800 (Mon, 22 Feb 2016) Log Message Binding generator should support key value iterable https://bugs.webkit.org/show_bug.cgi?id=154413 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/headers/headers-basic-expected.txt: * web-platform-tests/fetch/api/headers/headers-basic.html: Source/WebCore: Covered by added layout and binding tests. iterable in a IDL file will trigger the generation of entries, keys, values, [Symbol.iterator] and forEach methods to the prototype. Updated FetchHeaders and FontFaceSet to use it. IDLParser.pm parses the iterable<> and adds an iterable field in the interface containing the iterable information and objects for the five operations. IDLParser.pm is cleaned up a bit to remove previous Iterator support, which does not seem to be supported. CodeGeneratorJS.pm is updated to generate the code for the five operations, using JSKeyValueIterator. Set iterators are not yet supported. Moved definition of Iterator Key and Value Type to binding generated JSXX class based on iterable<> declaration in the IDL. Added binding test and Fetch Headers tests. * CMakeLists.txt: * Modules/fetch/FetchHeaders.idl: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSFetchHeadersCustom.cpp: Removed. * bindings/js/JSFontFaceSetCustom.cpp: (WebCore::JSFontFaceSet::ready): Removed iterable custom methods. * bindings/js/JSKeyValueIterator.h: (WebCore::createKeyValueIterator): (WebCore::keyValueIteratorForEach): * bindings/scripts/CodeGeneratorJS.pm: (GetFunctionName): (PrototypeFunctionCount): (PrototypePropertyCount): (GeneratePropertiesHashTable): (GenerateImplementation): (GenerateImplementationFunctionCall): (GenerateImplementationIterableFunctions): * bindings/scripts/IDLParser.pm: (parseOperationOrIterator): (parseOperationOrIteratorRest): (parseIterableRest): (parseOptionalIterableInterface): (applyMemberList): (parseSpecial): Deleted. * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjPrototype::finishCreation): (WebCore::jsTestObjPrototypeFunctionSymbolIterator): (WebCore::jsTestObjPrototypeFunctionEntries): (WebCore::jsTestObjPrototypeFunctionKeys): (WebCore::jsTestObjPrototypeFunctionValues): (WebCore::jsTestObjPrototypeFunctionForEach): * bindings/scripts/test/TestObj.idl: * css/FontFaceSet.idl: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-errors-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp trunk/Source/WebCore/bindings/js/JSFontFaceSetCustom.cpp trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/IDLParser.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h trunk/Source/WebCore/bindings/scripts/test/TestObj.idl trunk/Source/WebCore/css/FontFaceSet.cpp trunk/Source/WebCore/css/FontFaceSet.h trunk/Source/WebCore/css/FontFaceSet.idl Removed Paths trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196899 => 196900) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-22 08:14:59 UTC (rev 196899) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-22 08:31:14 UTC (rev 196900) @@ -1,3 +1,13 @@ +2016-02-22 Youenn Fablet + +Binding generator should support key value iterable +https://bugs.webkit.org/show_bug.cgi?id=154413 + +Reviewed by Darin Adler. + +* web-platform-tests/fetch/api/headers/headers-basic-expected.txt: +* web-platform-tests/fetch/api/headers/headers-basic.html: + 2016-02-21 Chris Dumez Unreviewed, rebaseline html/dom/interfaces.html. Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt (196899 => 196900) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-22 08:14:59 UTC (rev 196899) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-22 08:31:14 UTC (rev 196900) @@ -15,4 +15,6 @@ PASS Check keys method PASS Check values method PASS Check entries method +PASS Check Symbol.iterator method +PASS Check forEach me
[webkit-changes] [196170] trunk/Source/WebCore
Title: [196170] trunk/Source/WebCore
Revision 196170
Author youenn.fab...@crf.canon.fr
Date 2016-02-05 01:59:15 -0800 (Fri, 05 Feb 2016)
Log Message
Remove DOMWrapped parameter from JSKeyValueIterator
https://bugs.webkit.org/show_bug.cgi?id=153859
Reviewed by Sam Weinig.
No change in behavior.
Using std::declval to infer DOMWrapped from JSWrapper::wrapped.
* bindings/js/JSFetchHeadersCustom.cpp:
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
* bindings/js/JSKeyValueIterator.h:
(WebCore::createIterator):
(WebCore::JSKeyValueIterator::destroy):
(WebCore::JSKeyValueIterator::next):
(WebCore::JSKeyValueIteratorPrototypeFunctionNext):
(WebCore::JSKeyValueIteratorPrototype::finishCreation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (196169 => 196170)
--- trunk/Source/WebCore/ChangeLog 2016-02-05 09:03:28 UTC (rev 196169)
+++ trunk/Source/WebCore/ChangeLog 2016-02-05 09:59:15 UTC (rev 196170)
@@ -1,3 +1,25 @@
+2016-02-05 Youenn Fablet
+
+Remove DOMWrapped parameter from JSKeyValueIterator
+https://bugs.webkit.org/show_bug.cgi?id=153859
+
+Reviewed by Sam Weinig.
+
+No change in behavior.
+
+Using std::declval to infer DOMWrapped from JSWrapper::wrapped.
+
+* bindings/js/JSFetchHeadersCustom.cpp:
+(WebCore::JSFetchHeaders::entries):
+(WebCore::JSFetchHeaders::keys):
+(WebCore::JSFetchHeaders::values):
+* bindings/js/JSKeyValueIterator.h:
+(WebCore::createIterator):
+(WebCore::JSKeyValueIterator::destroy):
+(WebCore::JSKeyValueIterator::next):
+(WebCore::JSKeyValueIteratorPrototypeFunctionNext):
+(WebCore::JSKeyValueIteratorPrototype::finishCreation):
+
2016-02-05 Nan Wang
AX: WebKit hanging when VoiceOver attempts to focus in on page
Modified: trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp (196169 => 196170)
--- trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp 2016-02-05 09:03:28 UTC (rev 196169)
+++ trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp 2016-02-05 09:59:15 UTC (rev 196170)
@@ -36,8 +36,8 @@
namespace WebCore {
// FIXME: Move this code to JSFetchHeaders.
-using FetchHeadersIterator = JSKeyValueIterator;
-using FetchHeadersIteratorPrototype = JSKeyValueIteratorPrototype;
+using FetchHeadersIterator = JSKeyValueIterator;
+using FetchHeadersIteratorPrototype = JSKeyValueIteratorPrototype;
template<>
const JSC::ClassInfo FetchHeadersIterator::s_info = { "Headers Iterator", &Base::s_info, 0, CREATE_METHOD_TABLE(FetchHeadersIterator) };
@@ -47,17 +47,17 @@
JSC::JSValue JSFetchHeaders::entries(JSC::ExecState&)
{
-return createIterator(*globalObject(), *this, IterationKind::KeyValue);
+return createIterator(*globalObject(), *this, IterationKind::KeyValue);
}
JSC::JSValue JSFetchHeaders::keys(JSC::ExecState&)
{
-return createIterator(*globalObject(), *this, IterationKind::Key);
+return createIterator(*globalObject(), *this, IterationKind::Key);
}
JSC::JSValue JSFetchHeaders::values(JSC::ExecState&)
{
-return createIterator(*globalObject(), *this, IterationKind::Value);
+return createIterator(*globalObject(), *this, IterationKind::Value);
}
}
Modified: trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h (196169 => 196170)
--- trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-05 09:03:28 UTC (rev 196169)
+++ trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-05 09:59:15 UTC (rev 196170)
@@ -28,14 +28,15 @@
#include "JSDOMBinding.h"
#include
+#include
namespace WebCore {
-// FIXME: Update binding generator to allow getting DOMWrapped from JSWrapper.
-template
+template
class JSKeyValueIteratorPrototype : public JSC::JSNonFinalObject {
public:
-typedef JSC::JSNonFinalObject Base;
+using DOMWrapped = typename std::remove_reference().wrapped())>::type;
+using Base = JSC::JSNonFinalObject;
static JSKeyValueIteratorPrototype* create(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::Structure* structure)
{
@@ -61,10 +62,11 @@
enum class IterationKind { Key, Value, KeyValue };
-template
+template
class JSKeyValueIterator: public JSDOMObject {
public:
-typedef JSDOMObject Base;
+using DOMWrapped = typename std::remove_reference().wrapped())>::type;
+using Base = JSDOMObject;
DECLARE_INFO;
@@ -80,10 +82,10 @@
return instance;
}
-static JSKeyValueIteratorPrototype* createPrototype(JSC::VM& vm, JSC::JSGlobalObject* globalObject)
+static JSKeyValueIteratorPrototype* createPrototype(JSC::VM& vm, JSC::JSGlobalObject* globalObject)
{
-return JSKeyValueIteratorPrototy
[webkit-changes] [196128] trunk
Title: [196128] trunk Revision 196128 Author youenn.fab...@crf.canon.fr Date 2016-02-04 09:43:05 -0800 (Thu, 04 Feb 2016) Log Message [Fetch API] Add support for iterating over Headers https://bugs.webkit.org/show_bug.cgi?id=153787 Reviewed by Darin Adler. LayoutTests/imported/w3c: Relanding. * web-platform-tests/fetch/api/headers/headers-basic-expected.txt: * web-platform-tests/fetch/api/headers/headers-basic.html: * web-platform-tests/fetch/api/headers/headers-structure-expected.txt: * web-platform-tests/fetch/api/request/request-clone.sub-expected.txt: * web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt: * web-platform-tests/fetch/api/resources/utils.js: (checkRequest): (readTextStream): Source/WebCore: Relanding, updating bindings/js/JSKeyValueIterator.h for Windows bots. Covered by updated tests. Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes. Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods. Binding generator should be updated to generate directly these custom methods and handle iterator Symbol. * CMakeLists.txt: * Modules/fetch/FetchHeaders.cpp: (WebCore::FetchHeaders::Iterator::next): (WebCore::FetchHeaders::Iterator::Iterator): * Modules/fetch/FetchHeaders.h: (WebCore::FetchHeaders::createIterator): * Modules/fetch/FetchHeaders.idl: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSDOMBinding.h: (WebCore::jsPair): * bindings/js/JSFetchHeadersCustom.cpp: Added. (WebCore::JSFetchHeaders::entries): (WebCore::JSFetchHeaders::keys): (WebCore::JSFetchHeaders::values): * bindings/js/JSKeyValueIterator.h: Added. (WebCore::JSKeyValueIteratorPrototype::create): (WebCore::JSKeyValueIteratorPrototype::createStructure): (WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype): (WebCore::createIterator): (WebCore::DOMWrapped>::destroy): (WebCore::DOMWrapped>::next): (WebCore::DOMWrapped>::finishCreation): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-structure-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp trunk/Source/WebCore/bindings/js/JSDOMBinding.h Added Paths trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196127 => 196128) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-04 17:39:11 UTC (rev 196127) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-04 17:43:05 UTC (rev 196128) @@ -1,3 +1,21 @@ +2016-02-04 Youenn Fablet + +[Fetch API] Add support for iterating over Headers +https://bugs.webkit.org/show_bug.cgi?id=153787 + +Reviewed by Darin Adler. + +Relanding. + +* web-platform-tests/fetch/api/headers/headers-basic-expected.txt: +* web-platform-tests/fetch/api/headers/headers-basic.html: +* web-platform-tests/fetch/api/headers/headers-structure-expected.txt: +* web-platform-tests/fetch/api/request/request-clone.sub-expected.txt: +* web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt: +* web-platform-tests/fetch/api/resources/utils.js: +(checkRequest): +(readTextStream): + 2016-02-04 Chris Dumez Merge DOMTokenList and DOMSettableTokenList Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt (196127 => 196128) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-04 17:39:11 UTC (rev 196127) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-04 17:43:05 UTC (rev 196128) @@ -12,4 +12,7 @@ PASS Check has method PASS Check delete method PASS Check get method +PASS Check keys method +PASS Check values method +PASS Check entries method Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html (196127 => 196128) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html 2
[webkit-changes] [196118] trunk
(rev 196118)
@@ -4,7 +4,7 @@
PASS Headers has get method
PASS Headers has has method
PASS Headers has set method
-PASS Headers has entries method
-PASS Headers has keys method
-PASS Headers has values method
+FAIL Headers has entries method assert_true: headers has entries method expected true got false
+FAIL Headers has keys method assert_true: headers has keys method expected true got false
+FAIL Headers has values method assert_true: headers has values method expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub-expected.txt (196117 => 196118)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub-expected.txt 2016-02-04 11:39:31 UTC (rev 196117)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub-expected.txt 2016-02-04 12:46:12 UTC (rev 196118)
@@ -1,4 +1,4 @@
-PASS Check cloning a request
+FAIL Check cloning a request ExpectedValuesDict["headers"].keys is not a function. (In 'ExpectedValuesDict["headers"].keys()', 'ExpectedValuesDict["headers"].keys' is undefined)
PASS Check cloning a request copies the headers
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt (196117 => 196118)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt 2016-02-04 11:39:31 UTC (rev 196117)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt 2016-02-04 12:46:12 UTC (rev 196118)
@@ -1,6 +1,6 @@
-PASS Check request values when initialized from Request
-PASS Check request values when initialized from Request and init values
+FAIL Check request values when initialized from Request ExpectedValuesDict["headers"].keys is not a function. (In 'ExpectedValuesDict["headers"].keys()', 'ExpectedValuesDict["headers"].keys' is undefined)
+FAIL Check request values when initialized from Request and init values ExpectedValuesDict["headers"].keys is not a function. (In 'ExpectedValuesDict["headers"].keys()', 'ExpectedValuesDict["headers"].keys' is undefined)
FAIL Check request values when initialized from url string assert_equals: Check url attribute expected "http://url.test:1234/path/subpath?query=true" but got "http://url.test:1234/path/subpath?query=true#fragment"
-FAIL Check request values when initialized from url and init values assert_equals: Check url attribute expected "http://url.test:1234/path/subpath?query=true" but got "http://url.test:1234/path/subpath?query=true#fragment"
+FAIL Check request values when initialized from url and init values ExpectedValuesDict["headers"].keys is not a function. (In 'ExpectedValuesDict["headers"].keys()', 'ExpectedValuesDict["headers"].keys' is undefined)
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js (196117 => 196118)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js 2016-02-04 11:39:31 UTC (rev 196117)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js 2016-02-04 12:46:12 UTC (rev 196118)
@@ -15,7 +15,7 @@
for (var attribute in ExpectedValuesDict) {
switch(attribute) {
case "headers":
- for (var key in ExpectedValuesDict["headers"].keys())
+ for (var key of ExpectedValuesDict["headers"].keys())
assert_equals(request["headers"].get(key), ExpectedValuesDict["headers"].get(key),
"Check headers attribute has " + key + ":" + ExpectedValuesDict["headers"].get(key));
break;
@@ -63,4 +63,4 @@
asyncTest.done();
});
});
-}
+}
\ No newline at end of file
Modified: trunk/Source/WebCore/CMakeLists.txt (196117 => 196118)
--- trunk/Source/WebCore/CMakeLists.txt 2016-02-04 11:39:31 UTC (rev 196117)
+++ trunk/Source/WebCore/CMakeLists.txt 2016-02-04 12:46:12 UTC (rev 196118)
@@ -1164,7 +1164,6 @@
bindings/js/JSEventListener.cpp
bindings/js/JSEventTargetCustom.cpp
bindings/js/JSExceptionBase.cpp
-bindings/js/JSFetchHeadersCustom.cpp
bindings/js/JSFileReaderCustom.cpp
bindings/js/JSGeolocationCustom.cpp
bindings/js/JSHTMLAllCollectionCustom.cpp
Modified: trunk/Source/WebCore/ChangeLog (196117 => 196118)
--- trunk/Source/WebCore/ChangeLog 2016-02-04 11:39:31 UTC (rev 196117)
+++ trunk/Source/WebCore/ChangeLog 2016-02-04 12:46:12 UTC (rev 196118)
@@ -1,3 +1,8 @@
+2016-02-04 Youenn Fablet
+
+Unreviewed.
+Reverting r196115 and r19116, related tohttps://bugs.webkit.org/show_bug.cgi?id=153787.
+
2016-02-04
[webkit-changes] [196116] trunk/Source/WebCore/bindings/js
Title: [196116] trunk/Source/WebCore/bindings/js
Revision 196116
Author youenn.fab...@crf.canon.fr
Date 2016-02-04 03:14:04 -0800 (Thu, 04 Feb 2016)
Log Message
Unreviewed. Speculative Win Build fix
Modified Paths
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
Diff
Modified: trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp (196115 => 196116)
--- trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp 2016-02-04 10:39:37 UTC (rev 196115)
+++ trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp 2016-02-04 11:14:04 UTC (rev 196116)
@@ -77,7 +77,7 @@
#include "JSEventListener.cpp"
#include "JSEventTargetCustom.cpp"
#include "JSExceptionBase.cpp"
-#include "JSFetchHeaderCustom.cpp"
+#include "JSFetchHeadersCustom.cpp"
#include "JSFileReaderCustom.cpp"
#include "JSGeolocationCustom.cpp"
#include "JSHTMLAllCollectionCustom.cpp"
Modified: trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp (196115 => 196116)
--- trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp 2016-02-04 10:39:37 UTC (rev 196115)
+++ trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp 2016-02-04 11:14:04 UTC (rev 196116)
@@ -29,6 +29,8 @@
#include "config.h"
#include "JSFetchHeaders.h"
+#if ENABLE(FETCH_API)
+
#include "JSKeyValueIterator.h"
namespace WebCore {
@@ -59,3 +61,5 @@
}
}
+
+#endif
Modified: trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h (196115 => 196116)
--- trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-04 10:39:37 UTC (rev 196115)
+++ trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h 2016-02-04 11:14:04 UTC (rev 196116)
@@ -64,7 +64,7 @@
public:
typedef JSDOMObject Base;
-DECLARE_EXPORT_INFO;
+DECLARE_INFO;
static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [196115] trunk
Title: [196115] trunk
Revision 196115
Author youenn.fab...@crf.canon.fr
Date 2016-02-04 02:39:37 -0800 (Thu, 04 Feb 2016)
Log Message
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
* web-platform-tests/fetch/api/headers/headers-basic.html:
* web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
* web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
* web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
* web-platform-tests/fetch/api/resources/utils.js: fixed typo in test.
Source/WebCore:
Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.
* CMakeLists.txt:
* Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
* Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
* Modules/fetch/FetchHeaders.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
* bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::JSKeyValueIteratorPrototypeFuncNext):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-structure-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/utils.js
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp
trunk/Source/WebCore/Modules/fetch/FetchHeaders.h
trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
Added Paths
trunk/Source/WebCore/bindings/js/JSFetchHeadersCustom.cpp
trunk/Source/WebCore/bindings/js/JSKeyValueIterator.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196114 => 196115)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-04 10:10:01 UTC (rev 196114)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-04 10:39:37 UTC (rev 196115)
@@ -1,3 +1,17 @@
+2016-02-04 Youenn Fablet
+
+[Fetch API] Add support for iterating over Headers
+https://bugs.webkit.org/show_bug.cgi?id=153787
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
+* web-platform-tests/fetch/api/headers/headers-basic.html:
+* web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
+* web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
+* web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
+* web-platform-tests/fetch/api/resources/utils.js: fixed typo in test.
+
2016-02-03 Chris Dumez
Re-sync W3C HTML web-platform-tests
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt (196114 => 196115)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-04 10:10:01 UTC (rev 196114)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt 2016-02-04 10:39:37 UTC (rev 196115)
@@ -12,4 +12,7 @@
PASS Check has method
PASS Check delete method
PASS Check get method
+PASS Check keys method
+PASS Check values method
+PASS Check entries method
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html (196114 => 196115)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html 2016-02-04 10:10:01 UTC (rev 196114)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html 2016-02-04 10:39:37 UTC (rev 196115)
@@ -111,6 +111,58 @@
assert_equals(headers.get("nameNotInHeaders&qu
[webkit-changes] [195959] trunk/LayoutTests
Title: [195959] trunk/LayoutTests
Revision 195959
Author youenn.fab...@crf.canon.fr
Date 2016-02-01 04:33:22 -0800 (Mon, 01 Feb 2016)
Log Message
Unreviewed. Updating global-constructors-attributes expectations after introducing Request in r195954.
Modified Paths
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
Diff
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (195958 => 195959)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-02-01 12:31:44 UTC (rev 195958)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-02-01 12:33:22 UTC (rev 195959)
@@ -938,11 +938,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'Request').value is Request
-PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').value is RGBColor
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
@@ -973,6 +968,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'Rect').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'Rect').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'Request').value is Request
+PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is SQLException
PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (195958 => 195959)
--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-02-01 12:31:44 UTC (rev 195958)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt 2016-02-01 12:33:22 UTC (rev 195959)
@@ -998,11 +998,6 @@
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'ProgressEvent').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'Request').value is Request
-PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'Request').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').value is RGBColor
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'RGBColor').hasOwnProperty('set') is false
@@ -1053,6 +1048,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'Rect').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'Rect').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'Rect').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'Request').value is Request
+PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Request').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is
[webkit-changes] [195924] trunk/LayoutTests/imported/w3c
Title: [195924] trunk/LayoutTests/imported/w3c
Revision 195924
Author youenn.fab...@crf.canon.fr
Date 2016-01-31 01:20:05 -0800 (Sun, 31 Jan 2016)
Log Message
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436
Reviewed by Darin Adler.
GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.
* web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
* web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195923 => 195924)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-31 05:57:01 UTC (rev 195923)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-31 09:20:05 UTC (rev 195924)
@@ -1,3 +1,16 @@
+2016-01-31 Youenn Fablet
+
+imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
+https://bugs.webkit.org/show_bug.cgi?id=152436
+
+Reviewed by Darin Adler.
+
+GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
+Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.
+
+* web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
+* web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:
+
2016-01-30 Chris Dumez
[JS Bindings] prototype.constructor should be writable
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt (195923 => 195924)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt 2016-01-31 05:57:01 UTC (rev 195923)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt 2016-01-31 09:20:05 UTC (rev 195924)
@@ -1,6 +1,4 @@
PASS ReadableStreamController methods should continue working properly when scripts lose their reference to the readable stream
PASS ReadableStream closed promise should fulfill even if the stream and reader JS references are lost
-PASS ReadableStream closed promise should reject even if stream and reader JS references are lost
-PASS Garbage-collecting a ReadableStreamReader should not unlock its stream
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html (195923 => 195924)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html 2016-01-31 05:57:01 UTC (rev 195923)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html 2016-01-31 09:20:05 UTC (rev 195924)
@@ -9,5 +9,40 @@
</span><span class="cx"> 'use strict';
</span><del>-fetch_tests_from_worker(new Worker('garbage-collection.js'));
</del><ins>+
+promise_test(() => {
+
+ let controller;
+ new ReadableStream({
+start(c) {
+ controller = c;
+}
+ });
+
+ garbageCollect();
+
+ return delay(50).then(() => {
+controller.close();
+assert_throws(new TypeError(), () => controller.close(), 'close should throw a TypeError the second time');
+assert_throws(new TypeError(), () => controller.error(), 'error should throw a TypeError on a closed stream');
+ });
+
+}, 'ReadableStreamController methods should continue working properly when scripts lose their reference to the ' +
+ 'readable stream');
+
+promise_test(() => {
+
+ let controller;
+
+ const closedPromise = new ReadableStream({
+start(c) {
+ controller = c;
+}
+ }).getReader().closed;
+
+ garbageCollect();
+
+ return delay(50).then(() => controller.close()).then(() => closedPromise);
+
+}, 'ReadableStream closed promise should fulfill even if the stream and reader JS references are lost');
</ins><span class="cx">
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [195672] trunk/LayoutTests
Title: [195672] trunk/LayoutTests
Revision 195672
Author youenn.fab...@crf.canon.fr
Date 2016-01-27 07:35:58 -0800 (Wed, 27 Jan 2016)
Log Message
[GTK] Problem running promises code in workers
https://bugs.webkit.org/show_bug.cgi?id=152340
Reviewed by Carlos Garcia Campos.
Test file that creates two testharness promise tests. Each test creates 1 promises, pushes them into an
array and vends them in a timeout.
* js/promises-tests/promises-in-workers-expected.txt: Added.
* js/promises-tests/promises-in-workers.html: Added.
* js/promises-tests/promises-in-workers.js: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/js/promises-tests/promises-in-workers-expected.txt
trunk/LayoutTests/js/promises-tests/promises-in-workers.html
trunk/LayoutTests/js/promises-tests/promises-in-workers.js
Diff
Modified: trunk/LayoutTests/ChangeLog (195671 => 195672)
--- trunk/LayoutTests/ChangeLog 2016-01-27 15:20:03 UTC (rev 195671)
+++ trunk/LayoutTests/ChangeLog 2016-01-27 15:35:58 UTC (rev 195672)
@@ -1,3 +1,17 @@
+2016-01-27 Xabier Rodriguez Calvar and Youenn Fablet
+
+[GTK] Problem running promises code in workers
+https://bugs.webkit.org/show_bug.cgi?id=152340
+
+Reviewed by Carlos Garcia Campos.
+
+Test file that creates two testharness promise tests. Each test creates 1 promises, pushes them into an
+array and vends them in a timeout.
+
+* js/promises-tests/promises-in-workers-expected.txt: Added.
+* js/promises-tests/promises-in-workers.html: Added.
+* js/promises-tests/promises-in-workers.js: Added.
+
2016-01-26 Jer Noble
Calling video.controls=true during a scrub operation cancels scrub.
Added: trunk/LayoutTests/js/promises-tests/promises-in-workers-expected.txt (0 => 195672)
--- trunk/LayoutTests/js/promises-tests/promises-in-workers-expected.txt (rev 0)
+++ trunk/LayoutTests/js/promises-tests/promises-in-workers-expected.txt 2016-01-27 15:35:58 UTC (rev 195672)
@@ -0,0 +1,4 @@
+
+PASS Test
+PASS Test
+
Added: trunk/LayoutTests/js/promises-tests/promises-in-workers.html (0 => 195672)
--- trunk/LayoutTests/js/promises-tests/promises-in-workers.html (rev 0)
+++ trunk/LayoutTests/js/promises-tests/promises-in-workers.html 2016-01-27 15:35:58 UTC (rev 195672)
@@ -0,0 +1,6 @@
+
+'use strict';
+fetch_tests_from_worker(new Worker('promises-in-workers.js'));
+
Added: trunk/LayoutTests/js/promises-tests/promises-in-workers.js (0 => 195672)
--- trunk/LayoutTests/js/promises-tests/promises-in-workers.js (rev 0)
+++ trunk/LayoutTests/js/promises-tests/promises-in-workers.js 2016-01-27 15:35:58 UTC (rev 195672)
@@ -0,0 +1,21 @@
+'use strict';
+
+if (self.importScripts) {
+ self.importScripts('../../resources/testharness.js');
+}
+
+var a = [];
+
+// Changing from 2 to 1 makes the test pass.
+for (let i = 0; i < 2; i++) {
+ promise_test(t => {
+
+for (let j = 0; j < 1; j++)
+ a.push(new Promise(function() {}));
+
+return new Promise(resolve => step_timeout(resolve, 500));
+
+ }, 'Test');
+}
+
+done();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [195584] trunk/Source/WebCore
Title: [195584] trunk/Source/WebCore
Revision 195584
Author youenn.fab...@crf.canon.fr
Date 2016-01-25 23:32:28 -0800 (Mon, 25 Jan 2016)
Log Message
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
* Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
* Modules/mediastream/NavigatorUserMedia.js: Making it @conditional.
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.js
trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.js
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (195583 => 195584)
--- trunk/Source/WebCore/ChangeLog 2016-01-26 07:28:11 UTC (rev 195583)
+++ trunk/Source/WebCore/ChangeLog 2016-01-26 07:32:28 UTC (rev 195584)
@@ -1,3 +1,20 @@
+2016-01-25 Youenn Fablet
+
+WebCoreJSBuiltins do not use to do conditional include
+https://bugs.webkit.org/show_bug.cgi?id=153306
+
+Reviewed by Alex Christensen.
+
+Removing compilation guards as builtin generator adds them in the files themselves.
+Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
+
+No change in behavior.
+
+* Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
+* Modules/mediastream/NavigatorUserMedia.js: Making it @conditional.
+* bindings/js/WebCoreJSBuiltins.cpp:
+* bindings/js/WebCoreJSBuiltins.h:
+
2016-01-25 Alex Christensen
Fix internal Windows build
Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevices.js (195583 => 195584)
--- trunk/Source/WebCore/Modules/mediastream/MediaDevices.js 2016-01-26 07:28:11 UTC (rev 195583)
+++ trunk/Source/WebCore/Modules/mediastream/MediaDevices.js 2016-01-26 07:32:28 UTC (rev 195584)
@@ -26,7 +26,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// @optional=MEDIA_STREAM
+// @conditional=ENABLE(MEDIA_STREAM)
function getUserMedia(options)
{
Modified: trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.js (195583 => 195584)
--- trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.js 2016-01-26 07:28:11 UTC (rev 195583)
+++ trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.js 2016-01-26 07:32:28 UTC (rev 195584)
@@ -23,6 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// @conditional=ENABLE(MEDIA_STREAM)
+
function webkitGetUserMedia(options, successCallback, errorCallback)
{
"use strict";
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp (195583 => 195584)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-26 07:28:11 UTC (rev 195583)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-26 07:32:28 UTC (rev 195584)
@@ -26,20 +26,13 @@
#include "config.h"
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.cpp"
+#include "CountQueuingStrategyBuiltins.cpp"
#include "FetchHeadersBuiltins.cpp"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.cpp"
#include "NavigatorUserMediaBuiltins.cpp"
#include "RTCPeerConnectionBuiltins.cpp"
#include "RTCPeerConnectionInternalsBuiltins.cpp"
-#endif
-
-#if ENABLE(STREAMS_API)
-#include "ByteLengthQueuingStrategyBuiltins.cpp"
-#include "CountQueuingStrategyBuiltins.cpp"
#include "ReadableStreamBuiltins.cpp"
#include "ReadableStreamControllerBuiltins.cpp"
#include "ReadableStreamInternalsBuiltins.cpp"
@@ -47,4 +40,3 @@
#include "StreamInternalsBuiltins.cpp"
#include "WritableStreamBuiltins.cpp"
#include "WritableStreamInternalsBuiltins.cpp"
-#endif
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h (195583 => 195584)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-26 07:28:11 UTC (rev 195583)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-26 07:32:28 UTC (rev 195584)
@@ -27,20 +27,13 @@
#ifndef WebCoreJSBuiltins_h
#define WebCoreJSBuiltins_h
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.h"
+#include "CountQueuingStrategyBuiltins.h"
#include "FetchHeadersBuiltins.h"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.h"
#include "NavigatorUserMediaBuiltins.h"
#include "RTCPeerConnectionBuiltins.h"
#include "RTCPeerConnectionInternalsBuiltins.h"
[webkit-changes] [195583] trunk/LayoutTests
Title: [195583] trunk/LayoutTests Revision 195583 Author youenn.fab...@crf.canon.fr Date 2016-01-25 23:28:11 -0800 (Mon, 25 Jan 2016) Log Message imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently https://bugs.webkit.org/show_bug.cgi?id=152436 Reviewed by Alexey Proskuryakov. LayoutTests/imported/w3c: Adding temporary tests that splits garbage collection readable stream tests in worker and window mode. * web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt: Added. * web-platform-tests/streams-api/readable-streams/garbage-collection-1.html: Added. * web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt: Added. * web-platform-tests/streams-api/readable-streams/garbage-collection-2.html: Added. LayoutTests: * platform/mac/TestExpectations: Marked imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html as crash/pass. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html Diff Modified: trunk/LayoutTests/ChangeLog (195582 => 195583) --- trunk/LayoutTests/ChangeLog 2016-01-26 06:12:50 UTC (rev 195582) +++ trunk/LayoutTests/ChangeLog 2016-01-26 07:28:11 UTC (rev 195583) @@ -1,3 +1,12 @@ +2016-01-25 Youenn Fablet + +imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently +https://bugs.webkit.org/show_bug.cgi?id=152436 + +Reviewed by Alexey Proskuryakov. + +* platform/mac/TestExpectations: Marked imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html as crash/pass. + 2016-01-25 Skachkov Oleksandr [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments" Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195582 => 195583) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-26 06:12:50 UTC (rev 195582) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-26 07:28:11 UTC (rev 195583) @@ -1,5 +1,20 @@ 2016-01-25 Youenn Fablet +imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently +https://bugs.webkit.org/show_bug.cgi?id=152436 + +Reviewed by Alexey Proskuryakov. + +Adding temporary tests that splits garbage collection readable stream +tests in worker and window mode. + +* web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt: Added. +* web-platform-tests/streams-api/readable-streams/garbage-collection-1.html: Added. +* web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt: Added. +* web-platform-tests/streams-api/readable-streams/garbage-collection-2.html: Added. + +2016-01-25 Youenn Fablet + [Fetch API] Implement Fetch API Headers https://bugs.webkit.org/show_bug.cgi?id=152384 Added: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt (0 => 195583) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt 2016-01-26 07:28:11 UTC (rev 195583) @@ -0,0 +1,6 @@ + +PASS ReadableStreamController methods should continue working properly when scripts lose their reference to the readable stream +PASS ReadableStream closed promise should fulfill even if the stream and reader JS references are lost +PASS ReadableStream closed promise should reject even if stream and reader JS references are lost +PASS Garbage-collecting a ReadableStreamReader should not unlock its stream + Added: trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html (0 => 195583) --- trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html 2016-01-26 07:28:11 UTC (rev 195583) @@ -0,0 +1,10 @@ + + + +<script src="" </ins></span></pre></div> <a rel="nofollow" id="trunkLayoutTestsimportedw3cwebplatformtestsstreamsapireadablestreamsgarbagec
[webkit-changes] [195533] trunk/Source/WebCore
Title: [195533] trunk/Source/WebCore
Revision 195533
Author youenn.fab...@crf.canon.fr
Date 2016-01-25 06:06:53 -0800 (Mon, 25 Jan 2016)
Log Message
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
* Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.js
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (195532 => 195533)
--- trunk/Source/WebCore/ChangeLog 2016-01-25 11:57:41 UTC (rev 195532)
+++ trunk/Source/WebCore/ChangeLog 2016-01-25 14:06:53 UTC (rev 195533)
@@ -1,3 +1,19 @@
+2016-01-25 Youenn Fablet
+
+WebCoreJSBuiltins do not use to do conditional include
+https://bugs.webkit.org/show_bug.cgi?id=153306
+
+Reviewed by Alex Christensen.
+
+Removing compilation guards as builtin generator adds them in the files themselves.
+Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
+
+No change in behavior.
+
+* Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
+* bindings/js/WebCoreJSBuiltins.cpp:
+* bindings/js/WebCoreJSBuiltins.h:
+
2016-01-25 Commit Queue
Unreviewed, rolling out r195531.
Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevices.js (195532 => 195533)
--- trunk/Source/WebCore/Modules/mediastream/MediaDevices.js 2016-01-25 11:57:41 UTC (rev 195532)
+++ trunk/Source/WebCore/Modules/mediastream/MediaDevices.js 2016-01-25 14:06:53 UTC (rev 195533)
@@ -26,7 +26,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// @optional=MEDIA_STREAM
+// @conditional=ENABLE(MEDIA_STREAM)
function getUserMedia(options)
{
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp (195532 => 195533)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-25 11:57:41 UTC (rev 195532)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-25 14:06:53 UTC (rev 195533)
@@ -26,20 +26,13 @@
#include "config.h"
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.cpp"
+#include "CountQueuingStrategyBuiltins.cpp"
#include "FetchHeadersBuiltins.cpp"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.cpp"
#include "NavigatorUserMediaBuiltins.cpp"
#include "RTCPeerConnectionBuiltins.cpp"
#include "RTCPeerConnectionInternalsBuiltins.cpp"
-#endif
-
-#if ENABLE(STREAMS_API)
-#include "ByteLengthQueuingStrategyBuiltins.cpp"
-#include "CountQueuingStrategyBuiltins.cpp"
#include "ReadableStreamBuiltins.cpp"
#include "ReadableStreamControllerBuiltins.cpp"
#include "ReadableStreamInternalsBuiltins.cpp"
@@ -47,4 +40,3 @@
#include "StreamInternalsBuiltins.cpp"
#include "WritableStreamBuiltins.cpp"
#include "WritableStreamInternalsBuiltins.cpp"
-#endif
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h (195532 => 195533)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-25 11:57:41 UTC (rev 195532)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-25 14:06:53 UTC (rev 195533)
@@ -27,20 +27,13 @@
#ifndef WebCoreJSBuiltins_h
#define WebCoreJSBuiltins_h
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.h"
+#include "CountQueuingStrategyBuiltins.h"
#include "FetchHeadersBuiltins.h"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.h"
#include "NavigatorUserMediaBuiltins.h"
#include "RTCPeerConnectionBuiltins.h"
#include "RTCPeerConnectionInternalsBuiltins.h"
-#endif
-
-#if ENABLE(STREAMS_API)
-#include "ByteLengthQueuingStrategyBuiltins.h"
-#include "CountQueuingStrategyBuiltins.h"
#include "ReadableStreamBuiltins.h"
#include "ReadableStreamControllerBuiltins.h"
#include "ReadableStreamInternalsBuiltins.h"
@@ -48,8 +41,6 @@
#include "StreamInternalsBuiltins.h"
#include "WritableStreamBuiltins.h"
#include "WritableStreamInternalsBuiltins.h"
-#endif
-
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [195531] trunk/Source/WebCore
Title: [195531] trunk/Source/WebCore
Revision 195531
Author youenn.fab...@crf.canon.fr
Date 2016-01-25 03:36:14 -0800 (Mon, 25 Jan 2016)
Log Message
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
No change in behavior.
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (195530 => 195531)
--- trunk/Source/WebCore/ChangeLog 2016-01-25 10:53:53 UTC (rev 195530)
+++ trunk/Source/WebCore/ChangeLog 2016-01-25 11:36:14 UTC (rev 195531)
@@ -1,5 +1,19 @@
2016-01-25 Youenn Fablet
+WebCoreJSBuiltins do not use to do conditional include
+https://bugs.webkit.org/show_bug.cgi?id=153306
+
+Reviewed by Alex Christensen.
+
+Removing compilation guards as builtin generator adds them in the files themselves.
+
+No change in behavior.
+
+* bindings/js/WebCoreJSBuiltins.cpp:
+* bindings/js/WebCoreJSBuiltins.h:
+
+2016-01-25 Youenn Fablet
+
[Fetch API] Implement Fetch API Headers
https://bugs.webkit.org/show_bug.cgi?id=152384
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp (195530 => 195531)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-25 10:53:53 UTC (rev 195530)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp 2016-01-25 11:36:14 UTC (rev 195531)
@@ -26,20 +26,13 @@
#include "config.h"
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.cpp"
+#include "CountQueuingStrategyBuiltins.cpp"
#include "FetchHeadersBuiltins.cpp"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.cpp"
#include "NavigatorUserMediaBuiltins.cpp"
#include "RTCPeerConnectionBuiltins.cpp"
#include "RTCPeerConnectionInternalsBuiltins.cpp"
-#endif
-
-#if ENABLE(STREAMS_API)
-#include "ByteLengthQueuingStrategyBuiltins.cpp"
-#include "CountQueuingStrategyBuiltins.cpp"
#include "ReadableStreamBuiltins.cpp"
#include "ReadableStreamControllerBuiltins.cpp"
#include "ReadableStreamInternalsBuiltins.cpp"
@@ -47,4 +40,3 @@
#include "StreamInternalsBuiltins.cpp"
#include "WritableStreamBuiltins.cpp"
#include "WritableStreamInternalsBuiltins.cpp"
-#endif
Modified: trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h (195530 => 195531)
--- trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-25 10:53:53 UTC (rev 195530)
+++ trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h 2016-01-25 11:36:14 UTC (rev 195531)
@@ -27,20 +27,13 @@
#ifndef WebCoreJSBuiltins_h
#define WebCoreJSBuiltins_h
-#if ENABLE(FETCH_API)
+#include "ByteLengthQueuingStrategyBuiltins.h"
+#include "CountQueuingStrategyBuiltins.h"
#include "FetchHeadersBuiltins.h"
-#endif
-
-#if ENABLE(MEDIA_STREAM)
#include "MediaDevicesBuiltins.h"
#include "NavigatorUserMediaBuiltins.h"
#include "RTCPeerConnectionBuiltins.h"
#include "RTCPeerConnectionInternalsBuiltins.h"
-#endif
-
-#if ENABLE(STREAMS_API)
-#include "ByteLengthQueuingStrategyBuiltins.h"
-#include "CountQueuingStrategyBuiltins.h"
#include "ReadableStreamBuiltins.h"
#include "ReadableStreamControllerBuiltins.h"
#include "ReadableStreamInternalsBuiltins.h"
@@ -48,8 +41,6 @@
#include "StreamInternalsBuiltins.h"
#include "WritableStreamBuiltins.h"
#include "WritableStreamInternalsBuiltins.h"
-#endif
-
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [195530] trunk
/HTTPHeaderMap.h Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-casing-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-casing.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-errors-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-idl-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-nameshake-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-nameshake.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-normalize-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-normalize.html trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-structure-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-structure.html trunk/Source/WebCore/Modules/fetch/ trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp trunk/Source/WebCore/Modules/fetch/FetchHeaders.h trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl trunk/Source/WebCore/Modules/fetch/FetchHeaders.js Diff Modified: trunk/LayoutTests/ChangeLog (195529 => 195530) --- trunk/LayoutTests/ChangeLog 2016-01-25 09:24:19 UTC (rev 195529) +++ trunk/LayoutTests/ChangeLog 2016-01-25 10:53:53 UTC (rev 195530) @@ -1,3 +1,20 @@ +2016-01-25 Youenn Fablet + +[Fetch API] Implement Fetch API Headers +https://bugs.webkit.org/show_bug.cgi?id=152384 + +Reviewed by Darin Adler. + +* js/dom/global-constructors-attributes-dedicated-worker-expected.txt: +* js/dom/global-constructors-attributes-expected.txt: +* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: +* platform/efl/js/dom/global-constructors-attributes-expected.txt: +* platform/gtk/js/dom/global-constructors-attributes-expected.txt: +* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: +* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: +* platform/mac/js/dom/global-constructors-attributes-expected.txt: +* platform/win/js/dom/global-constructors-attributes-expected.txt: + 2016-01-22 Sergio Villar Senin [css-grid] grid shorthand must reset gap properties to their initial values Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195529 => 195530) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-25 09:24:19 UTC (rev 195529) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-25 10:53:53 UTC (rev 195530) @@ -1,3 +1,25 @@ +2016-01-25 Youenn Fablet + +[Fetch API] Implement Fetch API Headers +https://bugs.webkit.org/show_bug.cgi?id=152384 + +Reviewed by Darin Adler. + +* web-platform-tests/fetch/api/headers/headers-basic-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-basic.html: Added. +* web-platform-tests/fetch/api/headers/headers-casing-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-casing.html: Added. +* web-platform-tests/fetch/api/headers/headers-errors-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-errors.html: Added. +* web-platform-tests/fetch/api/headers/headers-idl-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-idl.html: Added. +* web-platform-tests/fetch/api/headers/headers-nameshake-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-nameshake.html: Added. +* web-platform-tests/fetch/api/headers/headers-normalize-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-normalize.html: Added. +* web-platform-tests/fetch/api/headers/headers-structure-expected.txt: Added. +* web-platform-tests/fetch/api/headers/headers-structure.html: Added. + 2016-01-24 Chris Dumez An XMLDocument interface should be exposed on the global Window object Added: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt (0 => 195530) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/headers-basic-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/head
[webkit-changes] [195450] trunk/Source
Title: [195450] trunk/Source Revision 195450 Author youenn.fab...@crf.canon.fr Date 2016-01-22 06:51:16 -0800 (Fri, 22 Jan 2016) Log Message Remove PassRefPtr from ResourceRequest and FormData https://bugs.webkit.org/show_bug.cgi?id=153229 Reviewed by Chris Dumez. Source/WebCore: Covered by existing tests. Making ResourceRequest::setHTTPBody take a RefPtr&&. Moving FormData from PassRefPtr to RefPtr. * html/parser/XSSAuditorDelegate.cpp: (WebCore::XSSAuditorDelegate::didBlockScript): * loader/FormSubmission.cpp: (WebCore::FormSubmission::populateFrameLoadRequest): * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::loadDifferentDocumentItem): * loader/PingLoader.cpp: (WebCore::PingLoader::sendViolationReport): * loader/PingLoader.h: * page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation): * platform/network/FormData.cpp: (WebCore::FormData::create): (WebCore::FormData::createMultiPart): (WebCore::FormData::copy): (WebCore::FormData::deepCopy): (WebCore::FormData::resolveBlobReferences): * platform/network/FormData.h: (WebCore::FormData::decode): * platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::setHTTPBody): * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::setHTTPBody): * platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): * platform/network/cf/FormDataStreamCFNet.h: * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): * platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): * platform/network/curl/ResourceHandleManager.cpp: (WebCore::getFormElementsCount): * platform/network/mac/FormDataStreamMac.h: * platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::doRedirect): * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Source/WebKit/win: * WebMutableURLRequest.cpp: (WebMutableURLRequest::setHTTPBody): Source/WebKit2: * NetworkProcess/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::decode): * NetworkProcess/cache/NetworkCacheEntry.cpp: (WebKit::NetworkCache::Entry::Entry): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/FormSubmission.cpp trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/PingLoader.cpp trunk/Source/WebCore/loader/PingLoader.h trunk/Source/WebCore/page/ContentSecurityPolicy.cpp trunk/Source/WebCore/platform/network/FormData.cpp trunk/Source/WebCore/platform/network/FormData.h trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp trunk/Source/WebCore/platform/network/ResourceRequestBase.h trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.h trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp trunk/Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.h trunk/Source/WebCore/platform/network/mac/FormDataStreamMac.mm trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp trunk/Source/WebCore/xml/XMLHttpRequest.cpp trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebMutableURLRequest.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadParameters.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (195449 => 195450) --- trunk/Source/WebCore/ChangeLog 2016-01-22 11:06:05 UTC (rev 195449) +++ trunk/Source/WebCore/ChangeLog 2016-01-22 14:51:16 UTC (rev 195450) @@ -1,3 +1,58 @@ +2016-01-22 Youenn Fablet + +Remove PassRefPtr from ResourceRequest and FormData +https://bugs.webkit.org/show_bug.cgi?id=153229 + +Reviewed by Chris Dumez. + +Covered by existing tests. + +Making ResourceRequest::setHTTPBody take a RefPtr&&. +Moving FormData from PassRefPtr to RefPtr. + +* html/parser/XSSAuditorDelegate.cpp: +(WebCore::XSSAuditorDelegate::didBlockScript): +* loader/FormSubmission.cpp: +(WebCore::FormSubmission::populateFrameLoadRequest): +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::loadPostRequest): +(WebCore::FrameLoader::loadDifferentDocumentItem): +* loader/PingLoader.cpp: +(WebCore::PingLoader::sendViolationReport): +* loader/PingLoader.h: +* page/ContentSecurityPolicy.cpp: +(WebCore::ContentSecurityPolicy::reportViolation): +* platform/network/FormData.cpp: +(WebCore::FormData::create): +(WebCore::FormData::createMultiPart): +(WebCore::FormData::copy): +(WebCore::FormData::deepCopy): +
[webkit-changes] [195101] trunk
Title: [195101] trunk Revision 195101 Author youenn.fab...@crf.canon.fr Date 2016-01-15 01:14:36 -0800 (Fri, 15 Jan 2016) Log Message [Streams API] Expose ReadableStream and relatives to Worker https://bugs.webkit.org/show_bug.cgi?id=152066 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebasing tests as Worker tests are now running. * web-platform-tests/streams-api/byte-length-queuing-strategy-expected.txt: * web-platform-tests/streams-api/count-queuing-strategy-expected.txt: * web-platform-tests/streams-api/readable-streams/bad-underlying-sources-expected.txt: * web-platform-tests/streams-api/readable-streams/bad-strategies-expected.txt: * web-platform-tests/streams-api/readable-streams/brand-checks-expected.txt: * web-platform-tests/streams-api/readable-streams/cancel-expected.txt: * web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration-expected.txt: * web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt: * web-platform-tests/streams-api/readable-streams/general-expected.txt: * web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: * web-platform-tests/streams-api/readable-streams/readable-stream-reader-expected.txt: * web-platform-tests/streams-api/readable-streams/tee-expected.txt: * web-platform-tests/streams-api/readable-streams/templated-expected.txt: Source/WebCore: Covered by rebased tests. * Modules/streams/ByteLengthQueuingStrategy.idl: * Modules/streams/CountQueuingStrategy.idl: * Modules/streams/ReadableStream.idl: * Modules/streams/ReadableStreamController.idl: * Modules/streams/ReadableStreamReader.idl: LayoutTests: Rebasing tests as ReadableStream is now available in workers. * js/dom/global-constructors-attributes-dedicated-worker-expected.txt: * platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/byte-length-queuing-strategy-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/count-queuing-strategy-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-underlying-sources-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/brand-checks-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/cancel-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/general-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/readable-stream-reader-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/tee-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/templated-expected.txt trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ByteLengthQueuingStrategy.idl trunk/Source/WebCore/Modules/streams/CountQueuingStrategy.idl trunk/Source/WebCore/Modules/streams/ReadableStream.idl trunk/Source/WebCore/Modules/streams/ReadableStreamController.idl trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl Diff Modified: trunk/LayoutTests/ChangeLog (195100 => 195101) --- trunk/LayoutTests/ChangeLog 2016-01-15 09:11:52 UTC (rev 195100) +++ trunk/LayoutTests/ChangeLog 2016-01-15 09:14:36 UTC (rev 195101) @@ -1,5 +1,17 @@ 2016-01-15 Youenn Fablet +[Streams API] Expose ReadableStream and relatives to Worker +https://bugs.webkit.org/show_bug.cgi?id=152066 + +Reviewed by Darin Adler. + +Rebasing tests as ReadableStream is now available in workers. + +* js/dom/global-constructors-attributes-dedicated-worker-expected.txt: +* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: + +2016-01-15 Youenn Fablet + CORS: Fix the handling of redirected request containing Origin null. https://bugs.webkit.org/show_bug.cgi?id=128816 Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195100 => 195101) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-15 09:11:52 UTC (rev 195100) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-01-15 09:14:36 UTC (rev 195101) @@ -1,3 +1,26 @@ +2016-01-15 Youenn
[webkit-changes] [195100] trunk
Title: [195100] trunk Revision 195100 Author youenn.fab...@crf.canon.fr Date 2016-01-15 01:11:52 -0800 (Fri, 15 Jan 2016) Log Message CORS: Fix the handling of redirected request containing Origin null. https://bugs.webkit.org/show_bug.cgi?id=128816 Reviewed by Brent Fulgham. Source/WebCore: Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002). This patch removes the check for securityOrigin->isUnique() in passesAccessControlCheck(). This check prevented a redirected request with "Origin: null" from being successful even when the response contains "Access-Control-Allow-Origin: null" Tests: http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html http/tests/xmlhttprequest/redirect-cors-origin-null.html * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): LayoutTests: Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002) Added two tests to check CORS with Origin null in HTTP redirect and iframe cases. Updated two test sandboxed iframes test expectations (requests are still denied but error messages are different). * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html: Added. * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: * http/tests/xmlhttprequest/redirect-cors-origin-null-expected.txt: Added. * http/tests/xmlhttprequest/redirect-cors-origin-null.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null-iframe.html: Added. * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null.cgi: Added. * http/tests/xmlhttprequest/resources/redirect-cors-origin-null-pass.php: Added. * http/tests/xmlhttprequest/resources/redirect-cors-origin-null.php: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp Added Paths trunk/LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cors-origin-null-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cors-origin-null.html trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null-iframe.html trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null.cgi trunk/LayoutTests/http/tests/xmlhttprequest/resources/redirect-cors-origin-null-pass.php trunk/LayoutTests/http/tests/xmlhttprequest/resources/redirect-cors-origin-null.php Diff Modified: trunk/LayoutTests/ChangeLog (195099 => 195100) --- trunk/LayoutTests/ChangeLog 2016-01-15 09:04:08 UTC (rev 195099) +++ trunk/LayoutTests/ChangeLog 2016-01-15 09:11:52 UTC (rev 195100) @@ -1,3 +1,26 @@ +2016-01-15 Youenn Fablet + +CORS: Fix the handling of redirected request containing Origin null. +https://bugs.webkit.org/show_bug.cgi?id=128816 + +Reviewed by Brent Fulgham. + +Merging Blink patch from George Ancil (https://chromiumcodereview.appspot.com/20735002) + +Added two tests to check CORS with Origin null in HTTP redirect and iframe cases. +Updated two test sandboxed iframes test expectations (requests are still denied but error messages are different). + +* http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt: Added. +* http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null.html: Added. +* http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: +* http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: +* http/tests/xmlhttprequest/redirect-cors-origin-null-expected.txt: Added. +* http/tests/xmlhttprequest/redirect-cors-origin-null.html: Added. +* http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null-iframe.html: Added. +* http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-origin-null.cgi: Added. +* http/tests/xmlhttprequest/resources/redirect-cors-origin-null-pass.php: Added. +* http/tests/xmlhttprequest/resources/redirect-cors-origin-null.php: Added. + 2016-01-14 Commit Queue Unreviewed, rolling out r195064. Added: tr
[webkit-changes] [195060] trunk/LayoutTests
Title: [195060] trunk/LayoutTests
Revision 195060
Author youenn.fab...@crf.canon.fr
Date 2016-01-14 10:18:19 -0800 (Thu, 14 Jan 2016)
Log Message
Move streams/webkitGetUserMedia-shadowing-then.html to fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=152973
Reviewed by Brent Fulgham.
Moved the test, made it asynchronous to ensure that the error callback is called.
* fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt.
* fast/mediastream/webkitGetUserMedia-shadowing-then.html: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then.html.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt
trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html
Removed Paths
trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt
trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then.html
Diff
Modified: trunk/LayoutTests/ChangeLog (195059 => 195060)
--- trunk/LayoutTests/ChangeLog 2016-01-14 17:50:12 UTC (rev 195059)
+++ trunk/LayoutTests/ChangeLog 2016-01-14 18:18:19 UTC (rev 195060)
@@ -1,3 +1,15 @@
+2016-01-14 Youenn Fablet
+
+Move streams/webkitGetUserMedia-shadowing-then.html to fast/mediastream
+https://bugs.webkit.org/show_bug.cgi?id=152973
+
+Reviewed by Brent Fulgham.
+
+Moved the test, made it asynchronous to ensure that the error callback is called.
+
+* fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt.
+* fast/mediastream/webkitGetUserMedia-shadowing-then.html: Renamed from LayoutTests/streams/webkitGetUserMedia-shadowing-then.html.
+
2016-01-14 Commit Queue
Unreviewed, rolling out r195002.
Added: trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt (0 => 195060)
--- trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then-expected.txt 2016-01-14 18:18:19 UTC (rev 195060)
@@ -0,0 +1 @@
+PASS
Copied: trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html (from rev 195059, trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then.html) (0 => 195060)
--- trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html (rev 0)
+++ trunk/LayoutTests/fast/mediastream/webkitGetUserMedia-shadowing-then.html 2016-01-14 18:18:19 UTC (rev 195060)
@@ -0,0 +1,44 @@
+
+
+
+
+Shadowing then()
+
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function endTest(testStatus) {
+document.getElementById("output").textContent = testStatus;
+testRunner.notifyDone();
+}
+
+// Shadow Promise.prototype.then
+Promise.prototype.then = (function () {
+const realThen = Promise.prototype.then;
+return function () {
+endTest("FAIL: Executed shadowed, public .then()");
+}
+})();
+
+function gotUserMedia(mediaStream) {
+endTest("FAIL: Got user media");
+}
+
+function userMediaError(error) {
+endTest("PASS");
+}
+
+var options = { audio: false, video: false };
+navigator.webkitGetUserMedia(options, gotUserMedia, userMediaError);
+
+
+
+
Deleted: trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt (195059 => 195060)
--- trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt 2016-01-14 17:50:12 UTC (rev 195059)
+++ trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then-expected.txt 2016-01-14 18:18:19 UTC (rev 195060)
@@ -1,2 +0,0 @@
-This test verifies that the implementation of navigator.webkitGetUserMedia does not use public promise APIs. Test passes if no message about a shadowed public .then() is printed.
-
Deleted: trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then.html (195059 => 195060)
--- trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then.html 2016-01-14 17:50:12 UTC (rev 195059)
+++ trunk/LayoutTests/streams/webkitGetUserMedia-shadowing-then.html 2016-01-14 18:18:19 UTC (rev 195060)
@@ -1,36 +0,0 @@
-
-
-
-
-Shadowing then()
-
-
-This test verifies that the implementation of navigator.webkitGetUserMedia does not use public promise APIs. Test passes if no message about a shadowed public .then() is printed.
-
-
-// Shadow Promise.prototype.then
-Promise.prototype.then = (function () {
-const realThen = Promise.prototype.then;
-return function (successCallback, errorCallback) {
-document.getElementById("output").textContent = "Executed shado
[webkit-changes] [195010] trunk
redirects.html trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/MediaResourceLoader.cpp trunk/Source/WebCore/loader/NetscapePlugInStreamLoader.cpp trunk/Source/WebCore/loader/ResourceLoaderOptions.h trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp trunk/Source/WebCore/loader/icon/IconLoader.cpp trunk/Source/WebCore/page/EventSource.cpp trunk/Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm trunk/Source/WebCore/platform/network/ResourceHandleTypes.h trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp trunk/Source/WebCore/platform/network/ResourceRequestBase.h trunk/Source/WebCore/xml/XMLHttpRequest.cpp Added Paths trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html trunk/LayoutTests/http/tests/xmlhttprequest/resources/access-control-basic-allow-no-credentials.cgi Diff Modified: trunk/LayoutTests/ChangeLog (195009 => 195010) --- trunk/LayoutTests/ChangeLog 2016-01-14 07:34:09 UTC (rev 195009) +++ trunk/LayoutTests/ChangeLog 2016-01-14 08:39:13 UTC (rev 195010) @@ -1,3 +1,28 @@ +2016-01-14 Youenn Fablet + +Fix problems with cross-origin redirects +https://bugs.webkit.org/show_bug.cgi?id=116075 + +Reviewed by Daniel Bates. + +Merging https://chromium.googlesource.com/chromium/blink/+/7ea774e478f84f355748108d2aaabca15355d512 by Ken Russell +This merge adds tests for cross origin requests triggered from same origin redirection responses with and without credentials). +Rebaseline of some tests due to console error messages generated from newly hit CORS checks. + +* TestExpectations: Disabled WPT tests that require access to non localhost URLs which are currently blocked by DTR/WTR. +* http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt: +* http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin-expected.txt: Added. +* http/tests/xmlhttprequest/access-control-and-redirects-async-same-origin.html: Added. +* http/tests/xmlhttprequest/access-control-and-redirects-async.html: +* http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: +* http/tests/xmlhttprequest/access-control-and-redirects.html: +* http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: +* http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: +* http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: +* http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt: +* http/tests/xmlhttprequest/resources/access-control-basic-allow-no-credentials.cgi: Added. +* http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: + 2016-01-13 Ryan Haddad Marking test as flaky: sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.3_encodeURI/S15.1.3.3_A2.4_T2.html Modified: trunk/LayoutTests/TestExpectations (195009 => 195010) --- trunk/LayoutTests/TestExpectations 2016-01-14 07:34:09 UTC (rev 195009) +++ trunk/LayoutTests/TestExpectations 2016-01-14 08:39:13 UTC (rev 195010) @@ -299,7 +299,12 @@ imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-simple.html [ Slow ] imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-synconworker.html [ Slow ] imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-twice.html [ Slow ] +# XMLHttpRequest tests requiring DTR/WTR to allow other URLs than localhost to not be blocked and be reachable (www2.localhost) +imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-bogus.htm [ Skip ] +imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm [ Skip ] +imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-to-non-cors.htm [ Skip ] + # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/http/tests/xmlhttprequest/access-c
[webkit-changes] [194960] trunk/Source/WebCore
Title: [194960] trunk/Source/WebCore Revision 194960 Author youenn.fab...@crf.canon.fr Date 2016-01-13 01:54:24 -0800 (Wed, 13 Jan 2016) Log Message [Streams API] Refactor builtin internals to prepare support for streams API in worker https://bugs.webkit.org/show_bug.cgi?id=152535 Reviewed by Darin Adler. Moving the code that links internal functions to the GlobalObject in WebCoreJSBuiltinInternals.cpp. This file should be generated by the builtin generator once refactoring is done. This code is located in JSBuiltinInternalFunctions::initialize. Adding private controller and reader constructors to the JS DOM constructor map so that they do not get garbage collected. No change in behavior, except that private builtins are usable in workers (but not actually used). * CMakeLists.txt: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::addBuiltinGlobals): (WebCore::JSDOMGlobalObject::finishCreation): (WebCore::JSDOMGlobalObject::visitChildren): * bindings/js/JSDOMGlobalObject.h: * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::finishCreation): (WebCore::JSDOMWindowBase::visitChildren): * bindings/js/JSDOMWindowBase.h: * bindings/js/WebCoreJSBuiltinInternals.cpp: Added. (WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): (WebCore::JSBuiltinInternalFunctions::visit): (WebCore::JSBuiltinInternalFunctions::initialize): * bindings/js/WebCoreJSBuiltinInternals.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp trunk/Source/WebCore/bindings/js/JSDOMGlobalObject.h trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h trunk/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.cpp trunk/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.h trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h Added Paths trunk/Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (194959 => 194960) --- trunk/Source/WebCore/CMakeLists.txt 2016-01-13 08:15:44 UTC (rev 194959) +++ trunk/Source/WebCore/CMakeLists.txt 2016-01-13 09:54:24 UTC (rev 194960) @@ -1233,6 +1233,7 @@ bindings/js/ScriptGlobalObject.cpp bindings/js/ScriptState.cpp bindings/js/SerializedScriptValue.cpp +bindings/js/WebCoreJSBuiltinInternals.cpp bindings/js/WebCoreJSBuiltins.cpp bindings/js/WebCoreTypedArrayController.cpp bindings/js/WorkerScriptController.cpp Modified: trunk/Source/WebCore/ChangeLog (194959 => 194960) --- trunk/Source/WebCore/ChangeLog 2016-01-13 08:15:44 UTC (rev 194959) +++ trunk/Source/WebCore/ChangeLog 2016-01-13 09:54:24 UTC (rev 194960) @@ -1,3 +1,37 @@ +2016-01-13 Youenn Fablet + +[Streams API] Refactor builtin internals to prepare support for streams API in worker +https://bugs.webkit.org/show_bug.cgi?id=152535 + +Reviewed by Darin Adler. + +Moving the code that links internal functions to the GlobalObject in WebCoreJSBuiltinInternals.cpp. +This file should be generated by the builtin generator once refactoring is done. +This code is located in JSBuiltinInternalFunctions::initialize. + +Adding private controller and reader constructors to the JS DOM constructor map so that they do not get garbage collected. + +No change in behavior, except that private builtins are usable in workers (but not actually used). + +* CMakeLists.txt: +* WebCore.vcxproj/WebCore.vcxproj: +* WebCore.xcodeproj/project.pbxproj: +* bindings/js/JSDOMGlobalObject.cpp: +(WebCore::JSDOMGlobalObject::JSDOMGlobalObject): +(WebCore::JSDOMGlobalObject::addBuiltinGlobals): +(WebCore::JSDOMGlobalObject::finishCreation): +(WebCore::JSDOMGlobalObject::visitChildren): +* bindings/js/JSDOMGlobalObject.h: +* bindings/js/JSDOMWindowBase.cpp: +(WebCore::JSDOMWindowBase::finishCreation): +(WebCore::JSDOMWindowBase::visitChildren): +* bindings/js/JSDOMWindowBase.h: +* bindings/js/WebCoreJSBuiltinInternals.cpp: Added. +(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): +(WebCore::JSBuiltinInternalFunctions::visit): +(WebCore::JSBuiltinInternalFunctions::initialize): +* bindings/js/WebCoreJSBuiltinInternals.h: + 2016-01-13 Gyuyoung Kim [EFL] Fix wrong return value of paintThemePart in RenderThemeEfl Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (194959 => 194960) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2016-01-13 08:15:44 UTC (rev 194959) +++ trunk/Sourc
[webkit-changes] [194761] trunk/Tools
Title: [194761] trunk/Tools Revision 194761 Author youenn.fab...@crf.canon.fr Date 2016-01-08 00:36:47 -0800 (Fri, 08 Jan 2016) Log Message webkit-patch build-and-test should have an option to iterate over new tests https://bugs.webkit.org/show_bug.cgi?id=143093 Reviewed by Michael Catanzaro. This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test. It allows running run-webkit-tests on modified or new paths in LayoutTests. Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests It implements the translation of -expected.* paths to their related tests. It also implements the removal of skipped tests. * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: (LayoutTestFinder.find_touched_tests): * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added. (MockPort): (MockPort.__init__): (MockPort.tests): (LayoutTestFinderTests): (LayoutTestFinderTests.touched_files): (LayoutTestFinderTests.test_touched_test): (LayoutTestFinderTests.test_expected_touched_test): (LayoutTestFinderTests.test_platform_expected_touched_test): (LayoutTestFinderTests.test_platform_duplicate_touched_test): (LayoutTestFinderTests.test_touched_but_skipped_test): * Scripts/webkitpy/port/base.py: (Port.potential_test_names_from_expected_file): * Scripts/webkitpy/tool/commands/download_unittest.py: (DownloadCommandsTest._default_options): * Scripts/webkitpy/tool/steps/options.py: (Options): * Scripts/webkitpy/tool/steps/runtests.py: (RunTests.options): (RunTests.run): (RunTests): (RunTests._new_or_modified_tests): (RunTests._run_webkit_tests): * Scripts/webkitpy/tool/steps/runtests_unittest.py: (RunTestsTest.test_webkit_run_unit_tests): * Scripts/webkitpy/tool/steps/steps_unittest.py: (StepsTest._step_options): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/options.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py Added Paths trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py Diff Modified: trunk/Tools/ChangeLog (194760 => 194761) --- trunk/Tools/ChangeLog 2016-01-08 06:17:59 UTC (rev 194760) +++ trunk/Tools/ChangeLog 2016-01-08 08:36:47 UTC (rev 194761) @@ -1,3 +1,46 @@ +2016-01-08 Youenn Fablet + +webkit-patch build-and-test should have an option to iterate over new tests +https://bugs.webkit.org/show_bug.cgi?id=143093 + +Reviewed by Michael Catanzaro. + +This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test. +It allows running run-webkit-tests on modified or new paths in LayoutTests. +Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests +It implements the translation of -expected.* paths to their related tests. +It also implements the removal of skipped tests. + +* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: +(LayoutTestFinder.find_touched_tests): +* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added. +(MockPort): +(MockPort.__init__): +(MockPort.tests): +(LayoutTestFinderTests): +(LayoutTestFinderTests.touched_files): +(LayoutTestFinderTests.test_touched_test): +(LayoutTestFinderTests.test_expected_touched_test): +(LayoutTestFinderTests.test_platform_expected_touched_test): +(LayoutTestFinderTests.test_platform_duplicate_touched_test): +(LayoutTestFinderTests.test_touched_but_skipped_test): +* Scripts/webkitpy/port/base.py: +(Port.potential_test_names_from_expected_file): +* Scripts/webkitpy/tool/commands/download_unittest.py: +(DownloadCommandsTest._default_options): +* Scripts/webkitpy/tool/steps/options.py: +(Options): +* Scripts/webkitpy/tool/steps/runtests.py: +(RunTests.options): +(RunTests.run): +(RunTests): +(RunTests._new_or_modified_tests): +(RunTests._run_webkit_tests): +* Scripts/webkitpy/tool/steps/runtests_unittest.py: +(RunTestsTest.test_webkit_run_unit_tests): +* Scripts/webkitpy/tool/steps/steps_unittest.py: +(StepsTest._step_options): + 2016-01-07 Joseph Pecoraro prepare-ChangeLog should include radar number Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py (194760 => 194761) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py 2016-01-08 06:17:59 UTC (rev 194760) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py 2016
[webkit-changes] [194696] trunk/Tools
Title: [194696] trunk/Tools Revision 194696 Author youenn.fab...@crf.canon.fr Date 2016-01-07 06:00:00 -0800 (Thu, 07 Jan 2016) Log Message [buildbot] clean-build script should remove untracked files and revert local changes too https://bugs.webkit.org/show_bug.cgi?id=142400 Reviewed by Ryosuke Niwa. This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files. A helper routine SCM.discard_untracked_files is added for that purpose. * BuildSlaveSupport/clean-build: (main): Making call to Scripts/clean-webkit * Scripts/clean-webkit: Added. (main): Revert changes and delete untracked files. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest._shared_test_discard_untracked_files): (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly. Modified Paths trunk/Tools/BuildSlaveSupport/clean-build trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py Added Paths trunk/Tools/Scripts/clean-webkit Diff Modified: trunk/Tools/BuildSlaveSupport/clean-build (194695 => 194696) --- trunk/Tools/BuildSlaveSupport/clean-build 2016-01-07 08:17:03 UTC (rev 194695) +++ trunk/Tools/BuildSlaveSupport/clean-build 2016-01-07 14:00:00 UTC (rev 194696) @@ -53,7 +53,10 @@ webkit_build_directory = subprocess.Popen(['perl', os.path.join(os.path.dirname(__file__), "..", "Scripts", "webkit-build-directory"), "--" + platform, "--" + options.configuration, '--top-level'], stdout=subprocess.PIPE).communicate()[0].strip() -shutil.rmtree(webkit_build_directory) +if (os.path.isdir(webkit_build_directory)): +shutil.rmtree(webkit_build_directory) +subprocess.Popen(['python', os.path.join(os.path.dirname(__file__), "..", "Scripts", "clean-webkit")]) + if __name__ == '__main__': sys.exit(main()) Modified: trunk/Tools/ChangeLog (194695 => 194696) --- trunk/Tools/ChangeLog 2016-01-07 08:17:03 UTC (rev 194695) +++ trunk/Tools/ChangeLog 2016-01-07 14:00:00 UTC (rev 194696) @@ -1,3 +1,23 @@ +2016-01-07 Youenn Fablet + +[buildbot] clean-build script should remove untracked files and revert local changes too +https://bugs.webkit.org/show_bug.cgi?id=142400 + +Reviewed by Ryosuke Niwa. + +This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files. +A helper routine SCM.discard_untracked_files is added for that purpose. + +* BuildSlaveSupport/clean-build: +(main): Making call to Scripts/clean-webkit +* Scripts/clean-webkit: Added. +(main): Revert changes and delete untracked files. +* Scripts/webkitpy/common/checkout/scm/scm.py: +(SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM. +* Scripts/webkitpy/common/checkout/scm/scm_unittest.py: +(SCMTest._shared_test_discard_untracked_files): +(test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly. + 2016-01-06 Simon Fraser Add a setting and preferences to enable display-list drawing. Does nothing yet. Added: trunk/Tools/Scripts/clean-webkit (0 => 194696) --- trunk/Tools/Scripts/clean-webkit (rev 0) +++ trunk/Tools/Scripts/clean-webkit 2016-01-07 14:00:00 UTC (rev 194696) @@ -0,0 +1,46 @@ +#!/usr/bin/env python + +# Copyright (C) 2015 Canon Incorporated. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# 1. Redistributions of source code must retain the above +#copyright notice, this list of conditions and the following +#disclaimer. +# 2. Redistributions in binary form must reproduce the above +#copyright notice, this list of conditions and the following +#disclaimer in the documentation and/or other materials +#provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER "AS IS" AND ANY +# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE +# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, +# OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, +# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR +# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEO
[webkit-changes] [194634] trunk/Tools
Title: [194634] trunk/Tools
Revision 194634
Author youenn.fab...@crf.canon.fr
Date 2016-01-06 02:15:14 -0800 (Wed, 06 Jan 2016)
Log Message
Python SCM should be able to retrieve untracked files - Add GIT support
https://bugs.webkit.org/show_bug.cgi?id=143135
Reviewed by Michael Catanzaro.
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.untracked_files): Adding support for git.
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTest.setUp):
(GitTest.test_untracked_files): Adding test.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (194633 => 194634)
--- trunk/Tools/ChangeLog 2016-01-06 07:17:00 UTC (rev 194633)
+++ trunk/Tools/ChangeLog 2016-01-06 10:15:14 UTC (rev 194634)
@@ -1,3 +1,16 @@
+2016-01-06 Youenn Fablet
+
+Python SCM should be able to retrieve untracked files - Add GIT support
+https://bugs.webkit.org/show_bug.cgi?id=143135
+
+Reviewed by Michael Catanzaro.
+
+* Scripts/webkitpy/common/checkout/scm/git.py:
+(Git.untracked_files): Adding support for git.
+* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
+(GitTest.setUp):
+(GitTest.test_untracked_files): Adding test.
+
2016-01-05 Mark Lam
Rename badly named JSC_timeout env var to JSCTEST_timeout.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (194633 => 194634)
--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2016-01-06 07:17:00 UTC (rev 194633)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2016-01-06 10:15:14 UTC (rev 194634)
@@ -214,6 +214,15 @@
updated_in_index_regexp = '^M[ M] (?P.+)$'
return self.run_status_and_extract_filenames(status_command, updated_in_index_regexp)
+def untracked_files(self, include_ignored_files=False):
+status_command = [self.executable_name, 'status', '--short']
+if include_ignored_files:
+status_command.append('--ignored')
+status_command.extend(self._patch_directories)
+# Remove the last / for folders to match SVN behavior.
+extractor = "^[?!][?!] (?P.+)$"
+return [value if not value.endswith('/') else value[:-1] for value in self.run_status_and_extract_filenames(status_command, extractor)]
+
def changed_files(self, git_commit=None):
# FIXME: --diff-filter could be used to avoid the "extract_filenames" step.
status_command = [self.executable_name, 'diff', '-r', '--name-status', "--no-renames", "--no-ext-diff", "--full-index", self.merge_base(git_commit), '--']
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py (194633 => 194634)
--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py 2016-01-06 07:17:00 UTC (rev 194633)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py 2016-01-06 10:15:14 UTC (rev 194634)
@@ -947,6 +947,8 @@
os.chdir(self.untracking_checkout_path)
write_into_file_at_path('foo_file', 'foo')
run_command(['git', 'add', 'foo_file'])
+write_into_file_at_path('.gitignore', '*.pyc')
+run_command(['git', 'add', '.gitignore'])
run_command(['git', 'commit', '-am', 'dummy commit'])
self.untracking_scm = detect_scm_system(self.untracking_checkout_path)
@@ -1055,7 +1057,10 @@
self.assertNotRegexpMatches(patch, r'rename from ')
self.assertNotRegexpMatches(patch, r'rename to ')
+def test_untracked_files(self):
+self._shared_test_untracked_files(self.tracking_scm)
+
class GitSVNTest(SCMTest):
def _setup_git_checkout(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
