[webkit-changes] [WebKit/WebKit] 914c17: Introduce a MediaSessionCaptureToggleAPIEnabled flag

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 914c17aba23e1ba5865db243ba11bb74eb599f3f
  
https://github.com/WebKit/WebKit/commit/914c17aba23e1ba5865db243ba11bb74eb599f3f
  Author: Youenn Fablet 
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
A LayoutTests/http/wpt/mediasession/disabledToggleCapture-expected.txt
A LayoutTests/http/wpt/mediasession/disabledToggleCapture.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/mediasession/MediaSession.cpp
M Source/WebCore/Modules/mediasession/MediaSession.h

  Log Message:
  ---
  Introduce a MediaSessionCaptureToggleAPIEnabled flag
rdar://132885518
https://bugs.webkit.org/show_bug.cgi?id=277411

Reviewed by Jean-Yves Avenard.

Make sure to throw when using a toggle capture action when 
MediaSessionCaptureToggleAPIEnabled is false.

* LayoutTests/http/wpt/mediasession/disabledToggleCapture-expected.txt: Added.
* LayoutTests/http/wpt/mediasession/disabledToggleCapture.html: Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::setActionHandler):
* Source/WebCore/Modules/mediasession/MediaSession.h:

Canonical link: https://commits.webkit.org/281752@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ee97a: Fix missing r in inactiveMediaCaptureSteamReprompt...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ee97aa00a72937962454c5162d83add4cb1c033
  
https://github.com/WebKit/WebKit/commit/7ee97aa00a72937962454c5162d83add4cb1c033
  Author: Youenn Fablet 
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
M Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm

  Log Message:
  ---
  Fix missing r in inactiveMediaCaptureSteamRepromptIntervalInMinutes preference
https://bugs.webkit.org/show_bug.cgi?id=277487
rdar://problem/132983393

Reviewed by Chris Dumez.

We fix the typo and update The C and ObjC corresponding APIs.
This is ok updating the APIs since they are only used within WebKit.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetInactiveMediaCaptureStreamRepromptIntervalInMinutes):
(WKPreferencesGetInactiveMediaCaptureStreamRepromptIntervalInMinutes):
(WKPreferencesSetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Deleted.
(WKPreferencesGetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Deleted.
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _inactiveMediaCaptureStreamRepromptIntervalInMinutes]):
(-[WKPreferences _setInactiveMediaCaptureStreamRepromptIntervalInMinutes:]):
(-[WKPreferences _inactiveMediaCaptureSteamRepromptIntervalInMinutes]): Deleted.
(-[WKPreferences _setInactiveMediaCaptureSteamRepromptIntervalInMinutes:]): 
Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged):
* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::(WebKit2, EnumerateDevicesAfterMuting)):
* Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
(TestWebKitAPI::TEST(WebKit2, GetUserMediaReprompt)):

Canonical link: https://commits.webkit.org/281749@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 144685: H265BitstreamParser::ParseSlice needs to check for...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1446850b522c7ef2121f61c61018229b898f6b74
  
https://github.com/WebKit/WebKit/commit/1446850b522c7ef2121f61c61018229b898f6b74
  Author: Youenn Fablet 
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_bitstream_parser.cc

  Log Message:
  ---
  H265BitstreamParser::ParseSlice needs to check for empty slices
https://bugs.webkit.org/show_bug.cgi?id=277408
rdar://132779200

Reviewed by Jean-Yves Avenard.

Apply the same empty slice check as done for H264.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_bitstream_parser.cc:

Canonical link: https://commits.webkit.org/281644@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 926c05: Fix NetworkRTCMonitor gatherNetworkMap

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 926c05cb3c2a6cb7804f902b8680050d11a59e37
  
https://github.com/WebKit/WebKit/commit/926c05cb3c2a6cb7804f902b8680050d11a59e37
  Author: Youenn Fablet 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp

  Log Message:
  ---
  Fix NetworkRTCMonitor gatherNetworkMap
https://bugs.webkit.org/show_bug.cgi?id=277329
rdar://132591641

Reviewed by Chris Dumez.

The utf8 string may be deallocated before the span, we are now using the span 
within RTCNetwork constructor.
I also use more spans to reduce string allocation.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::gatherNetworkMap):

Canonical link: https://commits.webkit.org/281618@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6b9d0d: Trigger toggle capture actions in case page muted ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b9d0d0c4172149e7d2fc204a083ca16c27e3b16
  
https://github.com/WebKit/WebKit/commit/6b9d0d0c4172149e7d2fc204a083ca16c27e3b16
  Author: Youenn Fablet 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
A LayoutTests/http/wpt/mediasession/resources/toggleCapture-iframe.html
A LayoutTests/http/wpt/mediasession/toggleCapture-expected.txt
A LayoutTests/http/wpt/mediasession/toggleCapture.html
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WebCore/Modules/mediasession/MediaSession.cpp
M Source/WebCore/Modules/mediasession/MediaSessionAction.h
M Source/WebCore/Modules/mediasession/MediaSessionAction.idl
M Source/WebCore/Modules/mediasession/MediaSessionActionDetails.h
M Source/WebCore/Modules/mediasession/MediaSessionActionDetails.idl
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/page/Page.cpp

  Log Message:
  ---
  Trigger toggle capture actions in case page muted state changes
https://bugs.webkit.org/show_bug.cgi?id=277261
rdar://132725520

Reviewed by Jean-Yves Avenard.

When user is toggling capture mute/unmute buttons, this triggers a call to 
Page::setMuted.
We pipe this information to MediaSession.
We make sure to call the MediaSession action handlers:
- for documents that have live capture tracks
- before live capture tracks fire the corresponding mute/unmute event.

* LayoutTests/http/wpt/mediasession/resources/toggleCapture-iframe.html: Added.
* LayoutTests/http/wpt/mediasession/toggleCapture-expected.txt: Added.
* LayoutTests/http/wpt/mediasession/toggleCapture.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::platformCommandForMediaSessionAction):
(WebCore::MediaSession::callActionHandler):
* Source/WebCore/Modules/mediasession/MediaSessionAction.h:
* Source/WebCore/Modules/mediasession/MediaSessionAction.idl:
* Source/WebCore/Modules/mediasession/MediaSessionActionDetails.h:
* Source/WebCore/Modules/mediasession/MediaSessionActionDetails.idl:
* Source/WebCore/dom/Document.cpp:
(WebCore::hasRealtimeMediaSource):
(WebCore::Document::processCaptureStateDidChange):
(WebCore::Document::cameraCaptureStateDidChange):
(WebCore::Document::microphoneCaptureStateDidChange):
(WebCore::Document::screenshareCaptureStateDidChange):
* Source/WebCore/dom/Document.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setMuted):

Canonical link: https://commits.webkit.org/281596@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 709ec7: Update libwebrtc to M128

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 709ec78d82966e476e61c08a8c33a8dcbcc34947
  
https://github.com/WebKit/WebKit/commit/709ec78d82966e476e61c08a8c33a8dcbcc34947
  Author: Youenn Fablet 
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/.gn
M Source/ThirdParty/libwebrtc/Source/webrtc/AUTHORS
M Source/ThirdParty/libwebrtc/Source/webrtc/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/webrtc/DEPS
M Source/ThirdParty/libwebrtc/Source/webrtc/PRESUBMIT.py
M Source/ThirdParty/libwebrtc/Source/webrtc/api/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/webrtc/api/DEPS
M Source/ThirdParty/libwebrtc/Source/webrtc/api/adaptation/BUILD.gn
R Source/ThirdParty/libwebrtc/Source/webrtc/api/adaptation/DEPS
M Source/ThirdParty/libwebrtc/Source/webrtc/api/adaptation/resource.h
M Source/ThirdParty/libwebrtc/Source/webrtc/api/array_view.h
M Source/ThirdParty/libwebrtc/Source/webrtc/api/array_view_unittest.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/audio_frame.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/audio_frame.h
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/audio_mixer.h
A Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/audio_view.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/echo_canceller3_factory.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/test/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/test/audio_frame_unittest.cc
A 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio/test/audio_view_unittest.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/L16/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/L16/audio_decoder_L16.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/L16/audio_encoder_L16.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_decoder.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_decoder_factory_template.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_encoder.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_encoder.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_encoder_factory.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_encoder_factory_template.h
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/audio_format.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/builtin_audio_encoder_factory.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g711/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g711/audio_decoder_g711.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g711/audio_encoder_g711.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g722/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g722/audio_decoder_g722.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/g722/audio_encoder_g722.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/ilbc/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/ilbc/audio_decoder_ilbc.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/ilbc/audio_encoder_ilbc.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/audio_decoder_multi_channel_opus.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/audio_decoder_opus.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/audio_encoder_multi_channel_opus_config.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/audio_encoder_opus.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus/audio_encoder_opus.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus_audio_decoder_factory.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/opus_audio_encoder_factory.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/test/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/api/audio_options.h
M Source/ThirdParty/libwebrtc/Source/webrtc/api/call/transport.cc
M 

[webkit-changes] [WebKit/WebKit] 1608cc: Update boringssl to M128

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1608ccb290309a0fbea722867c0df2ee4f64765e
  
https://github.com/WebKit/WebKit/commit/1608ccb290309a0fbea722867c0df2ee4f64765e
  Author: Youenn Fablet 
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/third_party/boringssl/.gitignore
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/CMakeLists.txt
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/MODULE.bazel.lock
M Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/PORTING.md
M Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/README.md
M Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/build.json
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/base64/base64.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/base64/base64_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/bio/bio_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/bio/connect.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/bytestring/cbs.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/chacha/asm/chacha-x86_64.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/cipher_extra/e_chacha20poly1305.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/conf/conf.c
R 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/conf/conf_def.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/conf/conf_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/cpu_arm_linux.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/cpu_intel.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/crypto.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/crypto_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/curve25519/x25519_test.cc
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/dilithium.c
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/dilithium_test.cc
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/dilithium_tests.txt
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/edge_cases_draft_dilithium3_sign.txt
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/edge_cases_draft_dilithium3_verify.txt
A 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dilithium/internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dsa/dsa.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dsa/dsa_asn1.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dsa/dsa_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/dsa/internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/aes.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/aes_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aesni-x86.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aesni-x86_64.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aesv8-armx.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bcm.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/asm/bn-586.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/asm/x86-mont.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/asm/x86_64-mont5.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/bn_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/exponentiation.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/bn/internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/ec/p256-nistz.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/fips_shared_support.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/modes/asm/aesni-gcm-x86_64.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/modes/asm/ghash-ssse3-x86_64.pl
M 

[webkit-changes] [WebKit/WebKit] 9a3a6d: Rename setFrameRateAndZoomWithPreset to applyFrame...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a3a6d9ef649bd2d35065a76943400e805c93989
  
https://github.com/WebKit/WebKit/commit/9a3a6d9ef649bd2d35065a76943400e805c93989
  Author: Youenn Fablet 
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/platform/mock/MockRealtimeVideoSource.h

  Log Message:
  ---
  Rename setFrameRateAndZoomWithPreset to applyFrameRateAndZoomWithPreset
rdar://132474156
https://bugs.webkit.org/show_bug.cgi?id=277069

Reviewed by Eric Carlson.

We do the renaming to clarify that two things are happening whhen applying 
constraints:
1. Update the underlying state of the source, done in 
applyFrameRateAndZoomWithPreset.
2. Update the RealtimeMediaSource members related settings.

We also introduce RealtimeVideoCaptureSource::setSizeFrameRateAndZoomForPhoto 
to share more code between going to photo mode and exiting photo mode.

* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoomForPhoto):
(WebCore::RealtimeVideoCaptureSource::takePhoto):
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::applyFrameRateAndZoomWithPreset):
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset): Deleted.
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::applyFrameRateAndZoomWithPreset):
(WebCore::MockRealtimeVideoSource::setFrameRateAndZoomWithPreset): Deleted.
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:

Canonical link: https://commits.webkit.org/281469@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b0a1d: Update libvpx to M128

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b0a1de6117b08a0f5ea1742104036581e54e82c
  
https://github.com/WebKit/WebKit/commit/3b0a1de6117b08a0f5ea1742104036581e54e82c
  Author: Youenn Fablet 
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/AUTHORS
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/README
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/build/make/configure.sh
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/build/make/rtcd.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/examples/vpx_dec_fuzzer.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/libs.mk
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/rate_hist.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/cpu_speed_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/decode_perf_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/encode_api_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/encode_perf_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/vp9_ethread_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/vp9_ext_ratectrl_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/tools/set_analyzer_env.sh
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/tools/tiny_ssim.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/firstpass.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_aq_cyclicrefresh.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_bitstream.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_ext_ratectrl.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_ext_ratectrl.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_firstpass.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_ratectrl.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_svc_layercontext.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_tpl_model.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/src/vpx_image.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/vpx_decoder.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/vpx_encoder.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/vpx_ext_ratectrl.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx_ports/aarch32_cpudetect.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx_ports/aarch64_cpudetect.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx_ports/arm_cpudetect.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpxenc.c

  Log Message:
  ---
  Update libvpx to M128
https://bugs.webkit.org/show_bug.cgi?id=277139
rdar://132564959

Reviewed by Eric Carlson.

* Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx: Resynced:

Canonical link: https://commits.webkit.org/281467@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5b5b15: Update libaom to M128

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b5b15a0a88121d313385b3c0d52e721c3dd2eb6
  
https://github.com/WebKit/WebKit/commit/5b5b15a0a88121d313385b3c0d52e721c3dd2eb6
  Author: Youenn Fablet 
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
A Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/.gitignore
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/CHANGELOG
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/CMakeLists.txt
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/README.md
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_codec.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_decoder.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_encoder.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_external_partition.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_frame_buffer.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_image.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aom_integer.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aomcx.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/aomdx.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/internal/aom_codec_internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/internal/aom_image_internal.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/src/aom_codec.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/src/aom_decoder.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/src/aom_encoder.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/src/aom_image.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom/src/aom_integer.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_convolve.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_dsp.cmake
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_dsp_common.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_dsp_rtcd.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_dsp_rtcd_defs.pl
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_filter.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_simd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/aom_simd_inline.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_convolve8_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_convolve8_neon.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_convolve8_neon_dotprod.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_convolve8_neon_i8mm.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_convolve_copy_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_filter.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_neon_sve2_bridge.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_neon_sve_bridge.h
A 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_scaled_convolve8_neon.c
A 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_scaled_convolve8_neon_dotprod.c
A 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/aom_scaled_convolve8_neon_i8mm.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/avg_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/avg_pred_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/avg_sve.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/blend_a64_mask_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/blend_neon.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/blk_sse_sum_neon.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/aom_dsp/arm/blk_sse_sum_sve.c
M 

[webkit-changes] [WebKit/WebKit] a11cfd: AVVideoCaptureSource should not update torch while...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a11cfdc1cd143c1bdbcc9cabfd97a15bb0b32a2e
  
https://github.com/WebKit/WebKit/commit/a11cfdc1cd143c1bdbcc9cabfd97a15bb0b32a2e
  Author: Youenn Fablet 
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  AVVideoCaptureSource should not update torch while setting camera preset
rdar://132554327
https://bugs.webkit.org/show_bug.cgi?id=277128

Reviewed by Eric Carlson.

According testing, locking/unlocking an AVCaptureDevice within a session 
configuration can lead to issues.
In AVVideoCaptureSource, this leads to torch being turned of right after being 
turned off, if we change the camera preset at the same time.

To workaround this, we asynchronously change white balanche and torch.
The longer term plan is to refactor AVVideoCaptureSource in 
https://bugs.webkit.org/show_bug.cgi?id=277088, to do one 
beginConfiguration/lock/unlock/commitConfiguration per applyConstraints call.

We make sure to call startApplyingConstraints/endApplyingConstraints whenever 
calling updateTorch and updateWhiteBalanceMode.
Manually tested.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settingsDidChange):
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):

Canonical link: https://commits.webkit.org/281410@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 111586: startApplyingConstraints is called twice when appl...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11158678aa4ef3d613394dfc01f9cccec6687104
  
https://github.com/WebKit/WebKit/commit/11158678aa4ef3d613394dfc01f9cccec6687104
  Author: Youenn Fablet 
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp

  Log Message:
  ---
  startApplyingConstraints is called twice when applying constraints with size 
changes
rdar://132339561
https://bugs.webkit.org/show_bug.cgi?id=277068

Reviewed by Eric Carlson.

startApplyingConstraints was called first in 
RealtimeMediaSource::applyConstraints and then in 
RealtimeVideoCaptureSource::setSizeFrameRateAndZoom.
Although it was paired with two calls to endApplyingConstraints, the 
implementation of 
AVVideoCaptureSource::startApplyingConstraints/endApplyingConstraints
is not handling nested calls like this.
This was triggering unbalanced AVVideoCaptureSource session 
beginConfiguration/commitConfiguration calls, which caused zoom/torch values to 
not always be applied properly.
This also fixes the exception that is sometimes raised when calling 
AVVideoCaptureSource::stopSession().

To fix this, we update RealtimeVideoCaptureSource::setSizeFrameRateAndZoom to 
not call directly startApplyingConstraints/endApplyingConstraints.
This is ok since it is only called from RealtimeMediaSource::applyConstraints 
which already does these calls.
This change is covered in 
MockRealtimeVideoSource::startApplyingConstraints/endApplyingConstraints by 
adding debug ASSERTS which are exercised by current layout tests.

The other call site of setFrameRateAndZoomWithPreset is for handling preset 
changes for photo.
Here we need to keep the calls to 
startApplyingConstraints/endApplyingConstraints, like done today.

* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeFrameRateAndZoom): 
Deleted.
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::startApplyingConstraints):
(WebCore::MockRealtimeVideoSource::endApplyingConstraints):

Canonical link: https://commits.webkit.org/281349@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71b7d7: Migrate WebKitUtilities pixel buffer routines to W...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71b7d7d91dbfafa67952ed468e72fd14fbeaba14
  
https://github.com/WebKit/WebKit/commit/71b7d7d91dbfafa67952ed468e72fd14fbeaba14
  Author: Youenn Fablet 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoFrameBuffer.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_frame_buffer/RTCCVPixelBuffer.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/native/src/objc_frame_buffer.h
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm
M Source/WebCore/platform/graphics/cv/VideoFrameCV.mm
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp
A Source/WebCore/platform/libwebrtc/LibWebRTCVideoFrameUtilities.h
A Source/WebCore/platform/libwebrtc/LibWebRTCVideoFrameUtilities.mm
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCMacros.h
M Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h
M Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h
M 
Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
M 
Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp

  Log Message:
  ---
  Migrate WebKitUtilities pixel buffer routines to WebCore
rdar://132323043
https://bugs.webkit.org/show_bug.cgi?id=276957

Reviewed by Jean-Yves Avenard.

As a first step towards removing using libwebrtc sdk source folder, we migrate 
pixel buffer routines from libwebrtc to WebCore.
We update libyuv header setup so that we can include them from WebCore.
We add a temporary WEBCORE_OR_WEBKIT_INCLUDE to LibWebRTCMacros to handle the 
paths for libwebrtc sdk header files that we temporarily include in WebCore.
A follow-up patch will migrate these files to WebCore or remove the need to use 
them.

We modernize the code that is moded from libwebrtc to WebCore by using 
RetainPtr.
We update the WebCore/WebKit call sites accordingly.

We keep libwebrtc versions of some of these buffer routines until we move VP8 
and VP9 WebKitDecoder.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoFrameBuffer.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_frame_buffer/RTCCVPixelBuffer.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/native/src/objc_frame_buffer.h:
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm:
(WebCore::SharedVideoFrameInfo::writeVideoFrameBuffer):
* Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:
(WebCore::VideoFrame::createI420):
(WebCore::VideoFrame::createI420A):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp:
(WebCore::LibWebRTCVPXInternalVideoDecoder::createPixelBuffer):
(WebCore::LibWebRTCVPXInternalVideoDecoder::Decoded):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp:
(WebCore::LibWebRTCVPXInternalVideoEncoder::encode):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCMacros.h:
* Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h:
* Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
* Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
(WebCore::RealtimeIncomingVideoSourceCocoa::toVideoFrame):
* Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
(WebCore::RealtimeOutgoingVideoSourceCocoa::videoFrameAvailable):
(WebCore::RealtimeOutgoingVideoSourceCocoa::createBlackFrame):
* Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::writeBuffer):

Canonical link: https://commits.webkit.org/281291@main



To unsubscribe from these emails, 

[webkit-changes] [WebKit/WebKit] ff2a05: Remove libwebrtc network thread with socket server...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff2a05f6674c75d2a78a179ca31270c3bd1aa3db
  
https://github.com/WebKit/WebKit/commit/ff2a05f6674c75d2a78a179ca31270c3bd1aa3db
  Author: Youenn Fablet 
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h

  Log Message:
  ---
  Remove libwebrtc network thread with socket server from NetworkRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=276779
rdar://132008878

Reviewed by Chris Dumez.

We remove the creation of the rtc network thread from NetworkRTCProvider on 
Cocoa ports.
We no longer need it as we are not using it for sockets nor for monitoring the 
network.
Some code is being moved to either a Cocoa section or a non Cocoa section.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::sendToSocket):
(WebKit::NetworkRTCProvider::closeSocket):
(WebKit::NetworkRTCProvider::setSocketOption):
(WebKit::NetworkRTCProvider::addSocket):
(WebKit::NetworkRTCProvider::takeSocket):
(WebKit::NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::callOnRTCNetworkThread):
(WebKit::NetworkRTCProvider::assertIsRTCNetworkThread):
(WebKit::NetworkRTCProvider::rtcNetworkThread):
(WebKit::NetworkRTCProvider::createSocket):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:

Canonical link: https://commits.webkit.org/281248@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7ff85: Revert https://commits.webkit.org/281222@main

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7ff8558f4fff60144987505063db2c30ca70bf0
  
https://github.com/WebKit/WebKit/commit/f7ff8558f4fff60144987505063db2c30ca70bf0
  Author: Youenn Fablet 
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h
M Source/WebCore/page/DeprecatedGlobalSettings.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/Shared/RTCNetwork.cpp
M Source/WebKit/Shared/RTCNetwork.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h

  Log Message:
  ---
  Revert https://commits.webkit.org/281222@main
rdar://132317575
https://bugs.webkit.org/show_bug.cgi?id=276954

Unreviewed.

We reverted two commits in https://commits.webkit.org/281222@main but this 
proved not needed.
Relanding these two commits by reverting the revert commit.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
(webrtc::createWebKitEncoderFactory):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:
(-[RTCDefaultVideoEncoderFactory initWithH265:vp9Profile0:vp9Profile2:av1:]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):
(-[RTCDefaultVideoEncoderFactory 
initWithH265:vp9Profile0:vp9Profile2:lowLatencyH264:av1:]): Deleted.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::webRTCH264LowLatencyEncoderEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCH264LowLatencyEncoderEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformTCPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformTCPSocketsEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformUDPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformUDPSocketsEnabled): 
Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::endSuspension): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processDidResume):
* Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
* Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::networkManager):
(WebKit::NetworkManager::NetworkManager):
(WebKit::NetworkManager::addListener):
(WebKit::NetworkManager::removeListener):
(WebKit::addressFromInterface):
(WebKit::interfaceAdapterType):
(WebKit::gatherNetworkMap):
(WebKit::connectToRemoteAddress):
(WebKit::getSocketLocalAddress):
(WebKit::getDefaultIPAddress):
(WebKit::NetworkManager::updateNetworks):
(WebKit::isEqual):
(WebKit::hasNetworkChanged):
(WebKit::sortNetworks):
(WebKit::NetworkManager::onGatheredNetworks):
(WebKit::NetworkRTCMonitor::~NetworkRTCMonitor):
(WebKit::NetworkRTCMonitor::ref):
(WebKit::NetworkRTCMonitor::deref):

[webkit-changes] [WebKit/WebKit] bb644d: WebRTCProvider::setActive is no longer useful

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb644dcd08fd77cfe5f5324bd9490e6136f001ce
  
https://github.com/WebKit/WebKit/commit/bb644dcd08fd77cfe5f5324bd9490e6136f001ce
  Author: Youenn Fablet 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm
M Source/WebCore/page/Page.cpp
M Source/WebCore/platform/mediastream/WebRTCProvider.cpp
M Source/WebCore/platform/mediastream/WebRTCProvider.h
M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h

  Log Message:
  ---
  WebRTCProvider::setActive is no longer useful
rdar://132235693
https://bugs.webkit.org/show_bug.cgi?id=276882

Reviewed by Eric Carlson.

WebRTCProvider::setActive was used to forward whether the page is visible or 
not to libwebrtc.
This was used notably on iOS in the past but is nowadays a no-op.
We can safely remove the code.
Since webrtc::setApplicationStatus was used to detect libwebrtc availability, 
we switch to the function that is used to create a peer connection factory.
This last part was manually tested.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::setApplicationStatus): Deleted.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::applicationDidEnterBackground):
(WebCore::Page::applicationWillEnterForeground):
* Source/WebCore/platform/mediastream/WebRTCProvider.cpp:
(WebCore::WebRTCProvider::setActive): Deleted.
* Source/WebCore/platform/mediastream/WebRTCProvider.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp:
(WebCore::WebRTCProvider::setActive): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::WebRTCProvider::setActive): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::WebRTCProvider::webRTCAvailable):
(WebCore::LibWebRTCProviderCocoa::setActive): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:

Canonical link: https://commits.webkit.org/281202@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c2fef: Remove unneeded protobuf cmake generated files

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c2fef17e043af0f0b820d1e1d39d720ba1b6508
  
https://github.com/WebKit/WebKit/commit/0c2fef17e043af0f0b820d1e1d39d720ba1b6508
  Author: Youenn Fablet 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CMakeCCompiler.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CMakeCXXCompiler.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CMakeDetermineCompilerABI_C.bin
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CMakeDetermineCompilerABI_CXX.bin
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CMakeSystem.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CompilerIdC/CMakeCCompilerId.c
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/3.30.0/CompilerIdCXX/CMakeCXXCompilerId.cpp
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/CMakeConfigureLog.yaml
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/CMakeDirectoryInformation.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/Export/5a0f10ea4324979995731323bb365f6f/protobuf-targets-noconfig.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/Export/5a0f10ea4324979995731323bb365f6f/protobuf-targets.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/Makefile.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/Makefile2
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/TargetDirectories.txt
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/cmake.check_cache
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/DependInfo.cmake
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/any_lite.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/arena.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/arenastring.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/arenaz_sampler.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/extension_set.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/generated_enum_util.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/generated_message_tctable_lite.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/generated_message_util.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/implicit_weak_message.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/inlined_string_field.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/io/coded_stream.cc.o.d
R 
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/CMakeFiles/libprotobuf-lite.dir/Users/youenn/dev/Apple/OpenSource/Source/ThirdParty/libwebrtc/Source/third_party/protobuf/src/google/protobuf/io/io_win32.cc.o.d
R 

[webkit-changes] [WebKit/WebKit] 180bfb: [Cocoa] nw_parameters_allow_sharing_port_with_list...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 180bfb4f1a6ef44cc14e4c8fdabfd134a60a5a42
  
https://github.com/WebKit/WebKit/commit/180bfb4f1a6ef44cc14e4c8fdabfd134a60a5a42
  Author: Youenn Fablet 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm

  Log Message:
  ---
  [Cocoa] nw_parameters_allow_sharing_port_with_listener is available 
unconditionally
https://bugs.webkit.org/show_bug.cgi?id=276817
rdar://132092612

Reviewed by Eric Carlson.

Remove the workaround since it is no longer needed.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection):

Canonical link: https://commits.webkit.org/281186@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4aa16f: [COCOA] Remove usage of libwebrtc network manager ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4aa16f26e567b8eccc6b55f4406f979c09e9fe33
  
https://github.com/WebKit/WebKit/commit/4aa16f26e567b8eccc6b55f4406f979c09e9fe33
  Author: Youenn Fablet 
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h
M Source/WebKit/Shared/RTCNetwork.cpp
M Source/WebKit/Shared/RTCNetwork.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp

  Log Message:
  ---
  [COCOA] Remove usage of libwebrtc network manager in NetworkRTCMonitor
https://bugs.webkit.org/show_bug.cgi?id=276776
rdar://132001134

Reviewed by Eric Carlson.

We remove usage of libwebrtc network manager from NetworkRTCMonitor.
Instead we reimplement the functionality through POSIX API, following what is 
done in libwebrtc.
This version is simpler as WebKit is only exposing interfaces that are actually 
in use (the default interface plus the interface that the page may use if 
different from the default one).
A future patch should use more nw API for Cocoa platforms.

Manually tested.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::networkManager):
(WebKit::NetworkManager::NetworkManager):
(WebKit::NetworkManager::addListener):
(WebKit::NetworkManager::removeListener):
(WebKit::addressFromInterface):
(WebKit::interfaceAdapterType):
(WebKit::gatherNetworkMap):
(WebKit::connectToRemoteAddress):
(WebKit::getSocketLocalAddress):
(WebKit::getDefaultIPAddress):
(WebKit::NetworkManager::updateNetworks):
(WebKit::isEqual):
(WebKit::hasNetworkChanged):
(WebKit::sortNetworks):
(WebKit::NetworkManager::onGatheredNetworks):
(WebKit::NetworkRTCMonitor::ref):
(WebKit::NetworkRTCMonitor::deref):
(WebKit::NetworkManagerWrapper::addListener): Deleted.
(WebKit::NetworkManagerWrapper::removeListener): Deleted.
(WebKit::NetworkManagerWrapper::onNetworksChanged): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h:
* Source/WebKit/Shared/RTCNetwork.h:

Canonical link: https://commits.webkit.org/281185@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 89195d: http/wpt/mediastream/mediastreamtrackprocessor-vid...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89195dc481e87b991401fecb081d71567d596939
  
https://github.com/WebKit/WebKit/commit/89195dc481e87b991401fecb081d71567d596939
  Author: Youenn Fablet 
  Date:   2024-07-19 (Fri, 19 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp

  Log Message:
  ---
  http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is 
flakey
rdar://131979190
https://bugs.webkit.org/show_bug.cgi?id=276763

Reviewed by Eric Carlson.

The test is synchronously observing a VideoTrackGenerator via a 
MediaStreamTrackProcessor and enqueuing a VideoFrame in the VideoTrackGenerator.
Before the patch, the observer registration would require hopping to the main 
thread, which would race with the enqueuing of the VideoFrame.
We are now using callOnMainThreadAndWait to stop the worker until the observer 
is registered.
The enqueuing of the VideoFrame will happen after the registration and the test 
will be able to proceed without any issue.

* LayoutTests/TestExpectations:
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp:
(WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::start):

Canonical link: https://commits.webkit.org/281125@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e0531: Remove no longer needed WebRTC runtime preferences

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e0531623ae70d27cccd31e701361486df5bc198
  
https://github.com/WebKit/WebKit/commit/8e0531623ae70d27cccd31e701361486df5bc198
  Author: Youenn Fablet 
  Date:   2024-07-19 (Fri, 19 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/page/DeprecatedGlobalSettings.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h

  Log Message:
  ---
  Remove no longer needed WebRTC runtime preferences
https://bugs.webkit.org/show_bug.cgi?id=276774
rdar://132000721

Reviewed by Eric Carlson.

We remove WebRTCH264LowLatencyEncoderEnabled preference, which is only useful 
on cocoa ports and on by default.
We remove WebRTCPlatformTCPSocketsEnabled and WebRTCPlatformUDPSocketsEnabled 
preferences which are also unique to COCOA and on by default.

This allows to simplify a bit the code, in particular in NetworkRTCProvider 
where we want to remove the use of libwebrtc socket server.
As a first step, we compile out in COCOA the use of libwebrtc packet socket 
factory which is no longer needed given we use the nw API instead.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
(webrtc::createWebKitEncoderFactory):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCDefaultVideoEncoderFactory.m:
(-[RTCDefaultVideoEncoderFactory initWithH265:vp9Profile0:vp9Profile2:av1:]):
(-[RTCDefaultVideoEncoderFactory createEncoder:]):
(-[RTCDefaultVideoEncoderFactory 
initWithH265:vp9Profile0:vp9Profile2:lowLatencyH264:av1:]): Deleted.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::webRTCH264LowLatencyEncoderEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCH264LowLatencyEncoderEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformTCPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformTCPSocketsEnabled): 
Deleted.
(WebCore::DeprecatedGlobalSettings::webRTCPlatformUDPSocketsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCPlatformUDPSocketsEnabled): 
Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProviderCocoa::createEncoderFactory):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::endSuspension): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processDidResume):
* Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::createSocket):
(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):
(WebKit::NetworkRTCProvider::sendToSocket):
(WebKit::NetworkRTCProvider::closeSocket):
(WebKit::NetworkRTCProvider::setSocketOption):
(WebKit::NetworkRTCProvider::addSocket):
(WebKit::NetworkRTCProvider::takeSocket):
(WebKit::NetworkRTCProvider::callOnRTCNetworkThread):
(WebKit::NetworkRTCProvider::wrapNewTCPConnection): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:
(WebKit::NetworkRTCProvider::authorizeListeningSockets): Deleted.

[webkit-changes] [WebKit/WebKit] 4a6ee0: REGRESSION:(280765@main) [ iOS ] [ Debug ] 48x Med...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a6ee0b6b1b9292b2725c90155261f167be3a071
  
https://github.com/WebKit/WebKit/commit/4a6ee0b6b1b9292b2725c90155261f167be3a071
  Author: Youenn Fablet 
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp

  Log Message:
  ---
  REGRESSION:(280765@main) [ iOS ] [ Debug ] 48x Media (layout-tests) are 
constantly asserting
https://bugs.webkit.org/show_bug.cgi?id=276495
rdar://131551575

Reviewed by Eric Carlson.

280765@main set contextOptions.useHostable to true, following what was done for 
the RemoteMediaPlayerProxy.
We revert this change since this is crashing on iOS debug, and this is not 
needed to allow locked screen rendering.

* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::initialize):

Canonical link: https://commits.webkit.org/280895@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7aac03: H265 WebRTC negotiation sometimes fails

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aac03437a367d8e7b059235ea0e734d041534ba
  
https://github.com/WebKit/WebKit/commit/7aac03437a367d8e7b059235ea0e734d041534ba
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h265_profile_tier_level.cc

  Log Message:
  ---
  H265 WebRTC negotiation sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=276369
rdar://131388275

Reviewed by Eric Carlson.

After the resync to M126, libwebrtc is now matching HEVC codec profiles.
We revert to the past behavior by disabling the precise checks if one of the 
codec has no parameter.
https://bugs.webkit.org/show_bug.cgi?id=276486 will handle the population of 
the decoder/encoder factories to handle the proper negotiation.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h265_profile_tier_level.cc:

Canonical link: https://commits.webkit.org/280863@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d87737: Relax the size checks in ScreenCaptureKitCaptureSo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d877379c8d5d090714a9575e23d7ac10fcb9c2a8
  
https://github.com/WebKit/WebKit/commit/d877379c8d5d090714a9575e23d7ac10fcb9c2a8
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  Relax the size checks in 
ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer to prevent 
excessive reconfigurations
rdar://129309166
https://bugs.webkit.org/show_bug.cgi?id=276483

Reviewed by Eric Carlson.

In case of full presenter overlay mode with multiple windows captured, we 
sometimes switch between two sizes that are close one from th eother.
It is not worth reconfiguring since this is not stable, the size is rougthly 
the same and reconfiguration is costly.
We add a size check that allows some deviations and prevent reconfiguration 
when sizes do not really matter.
We do the same check when deciding whether cropping or not, for efficiency 
purposes.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):

Canonical link: https://commits.webkit.org/280862@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f441f3: [iOS] Reconfiguring the device is often switching ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f441f31ce48366303d274c59d56d232d65727eca
  
https://github.com/WebKit/WebKit/commit/f441f31ce48366303d274c59d56d232d65727eca
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  [iOS] Reconfiguring the device is often switching off the torch
rdar://131130489
https://bugs.webkit.org/show_bug.cgi?id=276478

Reviewed by Eric Carlson.

When we reconfigure the device (for frame rate, zoom or size), this often 
switches off the torch.
To reenable it properly, we asynchronously switch it on again.
We do that asynchronously as switching it on in the same 
beginConfiguration/commitConfiguration does not seem to work properly.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):

Canonical link: https://commits.webkit.org/280857@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d14f1: Do not dispatch fetch event if its client is alrea...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d14f119e11e9b20df828804d9c76cac7517fad8
  
https://github.com/WebKit/WebKit/commit/5d14f119e11e9b20df828804d9c76cac7517fad8
  Author: Youenn Fablet 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A 
LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt
A LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html
M Source/WebCore/workers/service/context/ServiceWorkerFetch.h
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h

  Log Message:
  ---
  Do not dispatch fetch event if its client is already cancelled
https://bugs.webkit.org/show_bug.cgi?id=276417
rdar://131072280

Reviewed by Chris Dumez.

We are adding a fetch task and cancelling it when receiving IPC messages.
We are then queuing a task on the event loop to dispatch the fetch event.
If the cancel message happens before the dispatch of the fetch event, we are no 
longer dispatching the event since it is unnecessary.
To do so, we update the ServiceWorkerFetch::Client class to add a isCancelled 
getter and use it before dispatching the event.

* 
LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt:
 Added.
* LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html: 
Added.
* Source/WebCore/workers/service/context/ServiceWorkerFetch.h:
(WebCore::ServiceWorkerFetch::Client::isCancelled const):
(WebCore::ServiceWorkerFetch::Client::cancel):
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent):
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::doCancel):
(WebKit::WebServiceWorkerFetchTaskClient::cancel): Deleted.
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:

Canonical link: https://commits.webkit.org/280819@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec6570: [Cocoa] Do not include libwebrtc static libraries ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec65702b7bf4cc2ed99ff22ce103a4cdb0f9f23a
  
https://github.com/WebKit/WebKit/commit/ec65702b7bf4cc2ed99ff22ce103a4cdb0f9f23a
  Author: Youenn Fablet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig

  Log Message:
  ---
  [Cocoa] Do not include libwebrtc static libraries in SDK except for boringssl
https://bugs.webkit.org/show_bug.cgi?id=268910
rdar://122345708

Reviewed by Elliott Williams and Eric Carlson.

This is unnecessary since we are using the dylib instead, and avoids other 
applications using those libraries.

* Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:

Canonical link: https://commits.webkit.org/280786@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2f2cb: Cherry-pick libvpx af599a0c5fc4529ce0b70368eb2ba63...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2f2cbd39eb3d93293f890af12fa9b3e50987561
  
https://github.com/WebKit/WebKit/commit/a2f2cbd39eb3d93293f890af12fa9b3e50987561
  Author: Youenn Fablet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/firstpass.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_firstpass.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_ratectrl.c

  Log Message:
  ---
  Cherry-pick libvpx af599a0c5fc4529ce0b70368eb2ba63eda320fe9 and 
4ac9c4ba32bde8beb86da2553f5e75a9c124fcc7
https://bugs.webkit.org/show_bug.cgi?id=276311
rdar://130809006

Reviewed by Jean-Yves Avenard.

* 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/firstpass.c:
(saturate_cast_double_to_int):
(frame_max_bits):
(define_gf_group):
* 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_firstpass.c:
(vp9_rc_get_second_pass_params):
(vp9_twopass_postencode_update):
* 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_ratectrl.c:
(vbr_rate_correction):

Canonical link: https://commits.webkit.org/280782@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 37dfb4: Calling configure on WebCodecs Video Encoder trigg...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37dfb4fa3c73132a0d3b5d90aa0cb6253cad64bb
  
https://github.com/WebKit/WebKit/commit/37dfb4fa3c73132a0d3b5d90aa0cb6253cad64bb
  Author: Youenn Fablet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
A LayoutTests/http/wpt/webcodecs/encode-bitrate-change-expected.txt
A LayoutTests/http/wpt/webcodecs/encode-bitrate-change.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoderConfig.h
M Source/WebCore/platform/VideoEncoder.h
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h
M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h

  Log Message:
  ---
  Calling configure on WebCodecs Video Encoder triggers a new key frame each 
time even if the configuration is only changing the bitrate
https://bugs.webkit.org/show_bug.cgi?id=261402
rdar://115482127

Reviewed by Jean-Yves Avenard.

Check the new configuration is the same as the new one, except for bitrate and 
framerate.
If that is the case, we call setRate instead of recreating the encoder.
Implement setRate for VPX and remote encoders.

Covered by newly added test.

* LayoutTests/http/wpt/webcodecs/encode-bitrate-change-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/encode-bitrate-change.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::WebCodecsVideoEncoder::updateRates):
(WebCore::WebCodecsVideoEncoder::configure):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoderConfig.h:
(WebCore::isSameConfigurationExceptBitrateAndFramerate):
* Source/WebCore/platform/VideoEncoder.h:
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp:
(WebCore::LibWebRTCVPXVideoEncoder::setRates):
(WebCore::computeAllocation):
(WebCore::LibWebRTCVPXInternalVideoEncoder::initialize):
(WebCore::LibWebRTCVPXInternalVideoEncoder::encode):
(WebCore::LibWebRTCVPXInternalVideoEncoder::setRates):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h:
* Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp:
(WebKit::RemoteVideoEncoder::setRates):
(WebKit::RemoteVideoEncoder::flush):
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::setEncodeRatesCallback):
(WebKit::LibWebRTCCodecs::setEncodeRates):
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h:

Originally-landed-as: 4c9425f9126b. rdar://115482127
Canonical link: https://commits.webkit.org/280771@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f4a06: [iOS] Allow media to play in lock screen

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f4a06b21d82b347d6f091ca79af9bcfa3a8a834
  
https://github.com/WebKit/WebKit/commit/5f4a06b21d82b347d6f091ca79af9bcfa3a8a834
  Author: Youenn Fablet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/html/HTMLVideoElement.cpp
M Source/WebCore/html/HTMLVideoElement.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/PageConfiguration.h
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h
M 
Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h
M 
Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  ---
  [iOS] Allow media to play in lock screen
https://bugs.webkit.org/show_bug.cgi?id=271228
rdar://122881278

Reviewed by Jean-Yves Avenard.

To allow media to play in lock screen, we need to create the layer hosting 
context canShowWhileLocked option in GPUProcess.
We pipe it from WebProcess to GPUProcess for 
RemoteSampleBufferDisplayLayerManager and RemoteMediaPlayerProxy code paths.
We introduce a MediaPlayer getter which is implemented in HTMLVideoElement by 
looking at its page object.

We move the page canShowWhileLocked boolean from WebKit::WebPage to 
WebCore::Page so that HTMLVideoElement gets access to it.

* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::canShowWhileLocked const):
* Source/WebCore/html/HTMLVideoElement.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
* Source/WebCore/page/Page.h:
(WebCore::Page::canShowWhileLocked const):
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::canShowWhileLocked const):
* Source/WebCore/platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::canShowWhileLocked const):
* Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
(WebCore::SampleBufferDisplayLayer::canShowWhileLocked):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::canShowWhileLocked const):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
* 
Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in:
* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::initialize):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
* 
Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::initialize):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::canShowWhileLocked const):

Canonical link: https://commits.webkit.org/280765@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1ae506: SampleBufferDisplayLayerClient should be refable

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ae5061e826a81dd0f5e082a5a313aba473a3626
  
https://github.com/WebKit/WebKit/commit/1ae5061e826a81dd0f5e082a5a313aba473a3626
  Author: Youenn Fablet 
  Date:   2024-07-08 (Mon, 08 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp
M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp

  Log Message:
  ---
  SampleBufferDisplayLayerClient should be refable
https://bugs.webkit.org/show_bug.cgi?id=276243
rdar://131153843

Reviewed by Eric Carlson.

Make SampleBufferDisplayLayerClient refable and take ref whenever calling a 
client method from a client weak pointer.

* Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
(WebKit::RemoteSampleBufferDisplayLayer::create):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
* Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::setDidFail):
(WebKit::SampleBufferDisplayLayer::gpuProcessConnectionDidClose):

Canonical link: https://commits.webkit.org/280729@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 883f93: Cherry-pick libwebrtc "Allow for reordering around...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 883f937925d83f349e138abd59ef4d8619ea66f1
  
https://github.com/WebKit/WebKit/commit/883f937925d83f349e138abd59ef4d8619ea66f1
  Author: Youenn Fablet 
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer_unittest.cc

  Log Message:
  ---
  Cherry-pick libwebrtc "Allow for reordering around IRAPs."
https://bugs.webkit.org/show_bug.cgi?id=276178
rdar://problem/131059517

Reviewed by Jean-Yves Avenard.

We cherry-pick https://webrtc-review.googlesource.com/c/src/+/355482 to improve 
H265 packetization support.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer.cc:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/h26x_packet_buffer_unittest.cc:

Canonical link: https://commits.webkit.org/280677@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 101b7d: Restrict libwebrtc.dylib usage to WebKit clients

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 101b7d616411906c9faae9d49207a03fecbbbf43
  
https://github.com/WebKit/WebKit/commit/101b7d616411906c9faae9d49207a03fecbbbf43
  Author: Youenn Fablet 
  Date:   2024-07-04 (Thu, 04 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig

  Log Message:
  ---
  Restrict libwebrtc.dylib usage to WebKit clients
rdar://122465795
https://bugs.webkit.org/show_bug.cgi?id=268913

Reviewed by Eric Carlson.

Use allowable_client to limit usage to WebCore/WebKit clients only.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:

Canonical link: https://commits.webkit.org/280666@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21bb83: RtpPacketizerH265::RtpPacketizerH265 should check ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21bb838633ee9c63b5f9d0306fec5818b1b00b64
  
https://github.com/WebKit/WebKit/commit/21bb838633ee9c63b5f9d0306fec5818b1b00b64
  Author: Youenn Fablet 
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_packetizer_h265.cc

  Log Message:
  ---
  RtpPacketizerH265::RtpPacketizerH265 should check for empty nalus
https://bugs.webkit.org/show_bug.cgi?id=276174
rdar://130815764

Reviewed by David Kilzer.

We are doing an early return in case there are some empty nalus.
This ensures we do not hit a release assert when generating packets.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_packetizer_h265.cc:

Canonical link: https://commits.webkit.org/280627@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3702b6: Use protectedConnection in LibWebRTCNetworkManager

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3702b6bbedb895ba708ce8ea05ae707f111666fd
  
https://github.com/WebKit/WebKit/commit/3702b6bbedb895ba708ce8ea05ae707f111666fd
  Author: Youenn Fablet 
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp

  Log Message:
  ---
  Use protectedConnection in LibWebRTCNetworkManager
https://bugs.webkit.org/show_bug.cgi?id=276168
rdar://131027170

Reviewed by Charlie Wolfe.

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::networksChanged):

Canonical link: https://commits.webkit.org/280618@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ca0992: Take libaom 52ba0aed29cccb1560d9dad41eefeede0ef285...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca0992a491dc552b03695861b6520b5cb0fbc5e3
  
https://github.com/WebKit/WebKit/commit/ca0992a491dc552b03695861b6520b5cb0fbc5e3
  Author: Youenn Fablet 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/pass2_strategy.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.c

  Log Message:
  ---
  Take libaom 52ba0aed29cccb1560d9dad41eefeede0ef28565 commit
https://bugs.webkit.org/show_bug.cgi?id=276116

Reviewed by Eric Carlson.

* 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/pass2_strategy.c:
(av1_twopass_postencode_update):
* 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/libaom/av1/encoder/ratectrl.c:
(av1_rc_compute_frame_size_bounds):
(av1_rc_postencode_update):

Canonical link: https://commits.webkit.org/280577@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 312f06: Finalize implementation of MediaStreamTrack powerE...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 312f06335038c0c43733c76223f9a53806a002c1
  
https://github.com/WebKit/WebKit/commit/312f06335038c0c43733c76223f9a53806a002c1
  Author: Youenn Fablet 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt
M LayoutTests/fast/mediastream/MediaStreamTrack-getSettings-expected.txt
M LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt
M LayoutTests/fast/mediastream/camera-powerEfficient-track.html
M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
M Source/WebCore/Modules/mediastream/MediaStreamTrack.idl
M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp
M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.h
M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.idl
M Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h
M Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h
M 
Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Finalize implementation of MediaStreamTrack powerEfficient constraint
https://bugs.webkit.org/show_bug.cgi?id=276075
rdar://130897389

Reviewed by Eric Carlson.

We were previoudly not exposing powerEfficient settings and capabilities.
Now that the spec changes have landed in 
https://w3c.github.io/mediacapture-extensions/#the-powerefficient-constraint,
we can expose them.
We only set powerEfficient to [false, true] if there are presets that are power 
efficients and others that are not.
Otherwise we set it to [false].

* LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt:
* LayoutTests/fast/mediastream/camera-powerEfficient-track.html:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::getSettings const):
* Source/WebCore/Modules/mediastream/MediaStreamTrack.h:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.idl:
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp:
(WebCore::powerEfficientCapabilityVector):
(WebCore::toMediaTrackCapabilities):
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.h:
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.idl:
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:
(WebCore::RealtimeMediaSourceCapabilities::RealtimeMediaSourceCapabilities):
(WebCore::RealtimeMediaSourceCapabilities::supportsPowerEfficient const):
(WebCore::RealtimeMediaSourceCapabilities::powerEfficient const):
(WebCore::RealtimeMediaSourceCapabilities::setPowerEfficient):
(WebCore::RealtimeMediaSourceCapabilities::isolatedCopy const):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp:
(WebCore::RealtimeMediaSourceSettings::isolatedCopy const):
(WebCore::RealtimeMediaSourceSettings::convertFlagsToString):
(WebCore::RealtimeMediaSourceSettings::difference const):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h:
(WebCore::RealtimeMediaSourceSettings::allFlags):
(WebCore::RealtimeMediaSourceSettings::RealtimeMediaSourceSettings):
(WebCore::RealtimeMediaSourceSettings::supportsPowerEfficient const):
(WebCore::RealtimeMediaSourceSettings::powerEfficient const):
(WebCore::RealtimeMediaSourceSettings::setPowerEfficient):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
(WebCore::RealtimeMediaSourceSupportedConstraints::RealtimeMediaSourceSupportedConstraints):
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsPowerEfficient 
const):
(WebCore::RealtimeMediaSourceSupportedConstraints::setSupportsPowerEfficient):
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::canBePowerEfficient):
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::capabilities):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::capabilities):
(WebCore::MockRealtimeVideoSource::settings):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isMediaStreamTrackPowerEfficient const): Deleted.
* Source/WebCore/testing/Internals.h:
* 

[webkit-changes] [WebKit/WebKit] 397921: [Regression 280415@main] Fix RemoteMediaPlayerMana...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 397921da8b2ee0570ec8c6303aa55ba2243e7b92
  
https://github.com/WebKit/WebKit/commit/397921da8b2ee0570ec8c6303aa55ba2243e7b92
  Author: Youenn Fablet 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp

  Log Message:
  ---
  [Regression 280415@main] Fix 
RemoteMediaPlayerManager::gpuProcessConnectionDidClose assertion
rdar://130922121
https://bugs.webkit.org/show_bug.cgi?id=276117

Reviewed by Eric Carlson.

We need to move the ASSERT out of the if statement since we are protecting the 
player in that if statement.

* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::gpuProcessConnectionDidClose):

Canonical link: https://commits.webkit.org/280575@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b5877b: Allow WebRTC network traffic on the interface used...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5877b229ffa2ae13da637a0fd8910e30ffafc29
  
https://github.com/WebKit/WebKit/commit/b5877b229ffa2ae13da637a0fd8910e30ffafc29
  Author: Youenn Fablet 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
A LayoutTests/http/wpt/webrtc/resources/cacheable-iframe.py
A LayoutTests/http/wpt/webrtc/rtcNetworkInterface-expected.txt
A LayoutTests/http/wpt/webrtc/rtcNetworkInterface.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediastream/RTCNetworkManager.h
M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h

  Log Message:
  ---
  Allow WebRTC network traffic on the interface used to load the document main 
resource even if it is not the default interface
https://bugs.webkit.org/show_bug.cgi?id=275986
rdar://problem/130748643

Reviewed by Eric Carlson.

With split VPN, HTTP trafic may go through either default interface or the VPN 
interface.
But WebRTC UDP traffic will only go through the default interface as we do not 
enumerate all interfaces even post getUserMedia.

To improve the support of split VPN, we use the following heuristic:
- We continue allow using the default network interface.
- We get the interface that would be used to create a TCP connection to the 
document's host.

In case of no VPN, or full VPN, the same interface will be used.
In case of split VPN, two interfaces may be used.
This only happens post getUserMedia and is controlled by 
EnumeratingVisibleNetworkInterfacesEnabled flag.

* LayoutTests/http/wpt/webrtc/resources/cacheable-iframe.py: Added.
(main):
* LayoutTests/http/wpt/webrtc/rtcNetworkInterface-expected.txt: Added.
* LayoutTests/http/wpt/webrtc/rtcNetworkInterface.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/RTCNetworkManager.h:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::rtcNetworkInterfaceName const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::getInterfaceName):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
(WebKit::createNWConnection):
(WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa):
(WebKit::NetworkRTCTCPSocketCocoa::getInterfaceName):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::networksChanged):
(WebKit::LibWebRTCNetworkManager::interfaceNameForTesting const):
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h:

Canonical link: https://commits.webkit.org/280535@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a86d52: REGRESSION(280288@main): [ macOS iOS ] 3 tests in ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a86d5277d089a78d42fc276b63b9556619cb7ed1
  
https://github.com/WebKit/WebKit/commit/a86d5277d089a78d42fc276b63b9556619cb7ed1
  Author: Youenn Fablet 
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc

  Log Message:
  ---
  REGRESSION(280288@main): [ macOS iOS ] 3 tests in TestWebKitAPI.WebKit2 are 
constant failures
rdar://130761153
https://bugs.webkit.org/show_bug.cgi?id=275996

Reviewed by David Kilzer.

Decreasing the debug default logging level to LS_NONE like for release.
This ensures that the API tests do not fail due to excessive logging.

* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:

Canonical link: https://commits.webkit.org/280506@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 28a159: MediaPlayerPrivateRemote does not need to be an IP...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28a15960cf150a21c0c31cdfefb3c037ab158629
  
https://github.com/WebKit/WebKit/commit/28a15960cf150a21c0c31cdfefb3c037ab158629
  Author: Youenn Fablet 
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h

  Log Message:
  ---
  MediaPlayerPrivateRemote does not need to be an IPC::MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=275984
rdar://problem/130748477

Reviewed by Chris Dumez.

* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

Canonical link: https://commits.webkit.org/280462@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 777429: AVVideoCaptureSource::setSessionSizeFrameRateAndZo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 777429a3054a57247989c4e333839404c02a7bb3
  
https://github.com/WebKit/WebKit/commit/777429a3054a57247989c4e333839404c02a7bb3
  Author: Youenn Fablet 
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  AVVideoCaptureSource::setSessionSizeFrameRateAndZoom is exiting too early in 
case of different frame rate
rdar://130112520
https://bugs.webkit.org/show_bug.cgi?id=275952

Reviewed by Eric Carlson.

We wew only checking that frame rate range is matching, not that the frame rate 
is matching.
The range is something like [1, 30] or [1, 60], so we need to do actual frame 
rate matching.
This issue was hidden as frame rate adaptation happens later in the pipeline, 
but this is not good from a CPU point of view.

We change areSettingsMatching() to check whether the frame rate we want is 
matching with the device active min and max frame rate.

Manually tested on iPhone 15 Pro.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::isFrameRateMatching):
(WebCore::AVVideoCaptureSource::areSettingsMatching const):
(WebCore::AVVideoCaptureSource::setSessionSizeFrameRateAndZoom):
(WebCore::isSameFrameRateRange): Deleted.

Canonical link: https://commits.webkit.org/280417@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c54171: MediaPlayerPrivateRemote should derive privately f...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c54171089372d22c1838e8ce92e1ec9dc638d3d6
  
https://github.com/WebKit/WebKit/commit/c54171089372d22c1838e8ce92e1ec9dc638d3d6
  Author: Youenn Fablet 
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h
M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm

  Log Message:
  ---
  MediaPlayerPrivateRemote should derive privately from IPC::MessageReceiver
rdar://130574962
https://bugs.webkit.org/show_bug.cgi?id=275896

Reviewed by Eric Carlson.

This clarifies which base class weak pointer to take for 
MediaPlayerPrivateRemote.

* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::performTaskAtTime):
(WebKit::MediaPlayerPrivateRemote::requestHostingContextID):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::deleteRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::findRemotePlayerId):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnectionDidClose):
* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h:
* Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
(-[WKVideoLayerRemote mediaPlayerPrivateRemote]):
(-[WKVideoLayerRemote resizePreservingGravity]):
(-[WKVideoLayerRemote layoutSublayers]):
(-[WKVideoLayerRemote resolveBounds]):

Canonical link: https://commits.webkit.org/280415@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff1c06: MediaStreamTrackPrivate::clone should use toDataHo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff1c06111b4475d741a31938f0c2cb9f792b66e9
  
https://github.com/WebKit/WebKit/commit/ff1c06111b4475d741a31938f0c2cb9f792b66e9
  Author: Youenn Fablet 
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
A LayoutTests/fast/mediastream/clone-track-in-worker-expected.txt
A LayoutTests/fast/mediastream/clone-track-in-worker.html
M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h

  Log Message:
  ---
  MediaStreamTrackPrivate::clone should use toDataHolder
https://bugs.webkit.org/show_bug.cgi?id=275841
rdar://130262516

Reviewed by Eric Carlson.

* LayoutTests/fast/mediastream/clone-track-in-worker-expected.txt: Added.
* LayoutTests/fast/mediastream/clone-track-in-worker.html: Added.
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::clone):
(WebCore::MediaStreamTrackPrivate::toDataHolder):
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:

Canonical link: https://commits.webkit.org/280350@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a302d: Reject getUserMedia promise for disallowed require...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a302dc75a52f0980323c35cda808e49c28a8f3c
  
https://github.com/WebKit/WebKit/commit/4a302dc75a52f0980323c35cda808e49c28a8f3c
  Author: Youenn Fablet 
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
A 
LayoutTests/fast/mediastream/getUserMedia-mandatory-constraint-expected.txt
A LayoutTests/fast/mediastream/getUserMedia-mandatory-constraint.html
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.h

  Log Message:
  ---
  Reject getUserMedia promise for disallowed required constraints
rdar://130365953
https://bugs.webkit.org/show_bug.cgi?id=275790

Reviewed by Eric Carlson.

Implement 
https://w3c.github.io/mediacapture-main/#dfn-allowed-required-constraints-for-device-selection
 to ensure new constraints are not used for restricting device selection.

* LayoutTests/fast/mediastream/getUserMedia-mandatory-constraint-expected.txt: 
Added.
* LayoutTests/fast/mediastream/getUserMedia-mandatory-constraint.html: Added.
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia):
* Source/WebCore/platform/mediastream/MediaConstraints.cpp:
(WebCore::isAllowedRequiredConstraintForDeviceSelection):
(WebCore::MediaConstraints::hasDisallowedRequiredConstraintForDeviceSelection 
const):
* Source/WebCore/platform/mediastream/MediaConstraints.h:
(WebCore::MediaConstraint::MediaConstraint):
(WebCore::MediaConstraint::isRequired const):

Canonical link: https://commits.webkit.org/280325@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 231fb0: RemoteMediaPlayerManager::didReceivePlayerMessage ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 231fb0f77a069122493f64421747b9bd7133429e
  
https://github.com/WebKit/WebKit/commit/231fb0f77a069122493f64421747b9bd7133429e
  Author: Youenn Fablet 
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp

  Log Message:
  ---
  RemoteMediaPlayerManager::didReceivePlayerMessage should protect is player
https://bugs.webkit.org/show_bug.cgi?id=275791
rdar://130369517

Reviewed by Eric Carlson.

Apply coding style to RemoteMediaPlayerManager::didReceivePlayerMessage.

* Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::didReceivePlayerMessage):

Canonical link: https://commits.webkit.org/280298@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2c5594: Rename MediaStreamTrack powerEfficientPixelFormat ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c5594788b6c784f3512556b7e2328bd727a6e5d
  
https://github.com/WebKit/WebKit/commit/2c5594788b6c784f3512556b7e2328bd727a6e5d
  Author: Youenn Fablet 
  Date:   2024-06-23 (Sun, 23 Jun 2024)

  Changed paths:
M 
LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt
M LayoutTests/fast/mediastream/camera-powerEfficient-track.html
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl
M Source/WebCore/platform/mediastream/MediaConstraintType.cpp
M Source/WebCore/platform/mediastream/MediaConstraintType.h
M Source/WebCore/platform/mediastream/MediaConstraints.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M 
Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Rename MediaStreamTrack powerEfficientPixelFormat constraint to powerEfficient
https://bugs.webkit.org/show_bug.cgi?id=275729
rdar://problem/130265584

Reviewed by Eric Carlson.

As per WebRTC WG discussion, the standard is moving to powerEfficient instead 
of powerEfficientPixelFormat.
Renaming accordingly.

* LayoutTests/fast/mediastream/camera-powerEfficient-track.html:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::hasInvalidGetDisplayMediaConstraint):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp:
(WebCore::convertToInternalForm):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl:
* Source/WebCore/platform/mediastream/MediaConstraintType.cpp:
(WebCore::convertToString):
* Source/WebCore/platform/mediastream/MediaConstraintType.h:
* Source/WebCore/platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaTrackConstraintSetMap::filter const):
(WebCore::MediaTrackConstraintSetMap::set):
(WebCore::MediaTrackConstraintSetMap::merge):
(WebCore::MediaTrackConstraintSetMap::isValid const):
(WebCore::MediaConstraints::setDefaultVideoConstraints):
(WebCore::MediaTrackConstraintSetMap::isolatedCopy const):
* Source/WebCore/platform/mediastream/MediaConstraints.h:
(WebCore::MediaTrackConstraintSetMap::MediaTrackConstraintSetMap):
(WebCore::MediaTrackConstraintSetMap::powerEfficient const):
(WebCore::MediaTrackConstraintSetMap::powerEfficientPixelFormat const): Deleted.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::RealtimeMediaSource::applyConstraint):
(WebCore::RealtimeMediaSource::selectSettings):
(WebCore::RealtimeMediaSource::supportsConstraint):
(WebCore::RealtimeMediaSource::hasAnyInvalidConstraint):
(WebCore::RealtimeMediaSource::extractVideoPresetConstraints):
* 
Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/280289@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 94d70d: Replace webrtc LogMessage::SetLogOutput with LibWe...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94d70d33e766baa6e8a4e25b5ff0c8f98382fd93
  
https://github.com/WebKit/WebKit/commit/94d70d33e766baa6e8a4e25b5ff0c8f98382fd93
  Author: Youenn Fablet 
  Date:   2024-06-23 (Sun, 23 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h
M Source/WebCore/Modules/mediastream/RTCController.cpp
M Source/WebCore/Modules/mediastream/RTCController.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp

  Log Message:
  ---
  Replace webrtc LogMessage::SetLogOutput with LibWebRTCLogSink
rdar://130199443
https://bugs.webkit.org/show_bug.cgi?id=275681

Reviewed by Eric Carlson.

We remove from libwebrtc the WebKit specific logging mechanism.
Instead we use an existing mechanism via LibWebRTCLogSink.

We update LibWebRTCLogSink to send logs without hopping to main thread to keep 
the
same performance as the previous mechanism.
This removes the need for LibWebRTCLogSink to be a CanMakeWeakPtr.

We update RTCController to be RefCounted so that we can protect a RTCController 
from a WeakPtr.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h:
* Source/WebCore/Modules/mediastream/RTCController.cpp:
(WebCore::toWebRTCLogLevel):
(WebCore::RTCController::startGatheringLogs):
* Source/WebCore/Modules/mediastream/RTCController.h:
(WebCore::RTCController::create):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::disableICECandidateFiltering):
(WebCore::Page::enableICECandidateFiltering):
(WebCore::Page::didChangeMainDocument):
* Source/WebCore/page/Page.h:
(WebCore::Page::rtcController):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.cpp:
(WebCore::LibWebRTCLogSink::~LibWebRTCLogSink):
(WebCore::LibWebRTCLogSink::logMessage):
(WebCore::LibWebRTCLogSink::start):
(WebCore::LibWebRTCLogSink::stop):
(WebCore::toWebRTCLogLevel): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCLogSink.h:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::getRTCLogSink):
(WebCore::LibWebRTCProvider::setRTCLogging):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::doReleaseLogging): Deleted.

Canonical link: https://commits.webkit.org/280288@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 383082: Navigation loads that go through a service worker ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3830822c935e6fa0e851781b1cf7def6d3f66f66
  
https://github.com/WebKit/WebKit/commit/3830822c935e6fa0e851781b1cf7def6d3f66f66
  Author: Youenn Fablet 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
A 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate-worker.js
A 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate.https-expected.txt
A 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate.https.html
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
M Source/WebCore/workers/service/context/SWContextManager.cpp
M Source/WebCore/workers/service/context/SWContextManager.h
M Source/WebCore/workers/service/context/ServiceWorkerFetch.h
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
M 
Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h

  Log Message:
  ---
  Navigation loads that go through a service worker should finish in case of 
service worker termination
rdar://130079675
https://bugs.webkit.org/show_bug.cgi?id=275613

Reviewed by Chris Dumez.

We now store navigation fetch tasks in WebSWContextManagerConnection.
This allows to directly ask them to continueDidReceiveFetchResponse or 
convertFetchToDownload without hopping to the worker thread.
This is useful as the worker thread may be dead by the time we hop to it, which 
will prevent the load to finish or fail.

Since we are now calling continueDidReceiveFetchResponse or 
convertFetchToDownload from WebSWContextManagerConnection queue, we add a 
connection lock to WebServiceWorkerFetchTaskClient.

When a service worker gets stopped, we are now explicitly cancelling the 
ongoing fetch tasks by calling 
WebServiceWorkerFetchTaskClient::contextIsStopping.
It will cancel the load except if the load is already terminated but waiting to 
proceed (which happens for navigation loads waiting for a response check).

* 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate-worker.js:
 Added.
(doTest):
* 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate.https-expected.txt:
 Added.
* 
LayoutTests/http/wpt/service-workers/navigation-fetch-worker-terminate.https.html:
 Added.
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::prepareForDestruction):
* Source/WebCore/workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::removeFetch):
* Source/WebCore/workers/service/context/SWContextManager.h:
* Source/WebCore/workers/service/context/ServiceWorkerFetch.h:
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::cancelFetch):
(WebCore::ServiceWorkerThreadProxy::convertFetchToDownload): Deleted.
(WebCore::ServiceWorkerThreadProxy::continueDidReceiveFetchResponse): Deleted.
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::cancelFetch):
(WebKit::WebSWContextManagerConnection::continueDidReceiveFetchResponse):
(WebKit::WebSWContextManagerConnection::startFetch):
(WebKit::WebSWContextManagerConnection::convertFetchToDownload):
(WebKit::WebSWContextManagerConnection::removeNavigationFetch):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h:
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveRedirection):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveResponse):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveDataInternal):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinishInternal):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
(WebKit::WebServiceWorkerFetchTaskClient::didFail):
(WebKit::WebServiceWorkerFetchTaskClient::didFailInternal):
(WebKit::WebServiceWorkerFetchTaskClient::didFinish):
(WebKit::WebServiceWorkerFetchTaskClient::didFinishInternal):
(WebKit::WebServiceWorkerFetchTaskClient::didNotHandle):
(WebKit::WebServiceWorkerFetchTaskClient::didNotHandleInternal):
(WebKit::WebServiceWorkerFetchTaskClient::cancel):
(WebKit::WebServiceWorkerFetchTaskClient::usePreload):
(WebKit::WebServiceWorkerFetchTaskClient::continueDidReceiveResponse):

[webkit-changes] [WebKit/WebKit] 01a643: Stop storing FetchEvent in WebServiceWorkerFetchTa...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01a643acd37aaf87c26ee65dc46250df3eb9eb0c
  
https://github.com/WebKit/WebKit/commit/01a643acd37aaf87c26ee65dc46250df3eb9eb0c
  Author: Youenn Fablet 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
M Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp
M Source/WebCore/workers/service/context/ServiceWorkerFetch.h
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThread.h
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h

  Log Message:
  ---
  Stop storing FetchEvent in WebServiceWorkerFetchTaskClient
rdar://129926640
https://bugs.webkit.org/show_bug.cgi?id=275610

Reviewed by Chris Dumez.

We do not want to extend the lifetime of FetchEvents, so we mvoe them out of 
WebServiceWorkerFetchTaskClient.
Instead we store the ongoing fetch tasks in ServiceWorkerGlobalScope (both 
WebServiceWorkerFetchTaskClient and FetchEvent).
And we handle navigation preloads from there.

Covered by existing tests.

* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::skipWaiting):
(WebCore::ServiceWorkerGlobalScope::prepareForDestruction):
(WebCore::ServiceWorkerGlobalScope::addFetchTask):
(WebCore::ServiceWorkerGlobalScope::addFetchEvent):
(WebCore::ServiceWorkerGlobalScope::removeFetchTask):
(WebCore::ServiceWorkerGlobalScope::fetchTask):
(WebCore::ServiceWorkerGlobalScope::takeFetchTask):
(WebCore::ServiceWorkerGlobalScope::hasFetchTask const):
(WebCore::ServiceWorkerGlobalScope::navigationPreloadFailed):
(WebCore::ServiceWorkerGlobalScope::navigationPreloadIsReady):
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.h:
* Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
* Source/WebCore/workers/service/context/ServiceWorkerFetch.h:
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent):
* Source/WebCore/workers/service/context/ServiceWorkerThread.h:
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::startFetch):
(WebCore::ServiceWorkerThreadProxy::cancelFetch):
(WebCore::ServiceWorkerThreadProxy::convertFetchToDownload):
(WebCore::ServiceWorkerThreadProxy::navigationPreloadIsReady):
(WebCore::ServiceWorkerThreadProxy::navigationPreloadFailed):
(WebCore::ServiceWorkerThreadProxy::continueDidReceiveFetchResponse):
(WebCore::ServiceWorkerThreadProxy::removeFetch):
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::cleanup):
(WebKit::WebServiceWorkerFetchTaskClient::setFetchEvent): Deleted.
(WebKit::WebServiceWorkerFetchTaskClient::navigationPreloadIsReady): Deleted.
(WebKit::WebServiceWorkerFetchTaskClient::navigationPreloadFailed): Deleted.
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:

Canonical link: https://commits.webkit.org/280242@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c0e08: Remove WebRTC DTLS1.0 testing support

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c0e08f9310c9f8d4f9a8a24f5b8f80e2c83ad12
  
https://github.com/WebKit/WebKit/commit/1c0e08f9310c9f8d4f9a8a24f5b8f80e2c83ad12
  Author: Youenn Fablet 
  Date:   2024-06-21 (Fri, 21 Jun 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
R LayoutTests/webrtc/datachannel/dtls10-expected.txt
R LayoutTests/webrtc/datachannel/dtls10.html
M 
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/openssl_stream_adapter.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/openssl_stream_adapter.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  Remove WebRTC DTLS1.0 testing support
rdar://130201031
https://bugs.webkit.org/show_bug.cgi?id=275684

Reviewed by Eric Carlson.

We removed DTLS1.0 support a long time ago and kept a hack to turn it on for 
testing purposes only.
To reduce the differences between upstream libwebrtc and our copy, we remove 
this testing infrastructure, including the corresponding test.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/webrtc/datachannel/dtls10-expected.txt: Removed.
* LayoutTests/webrtc/datachannel/dtls10.html: Removed.
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/openssl_stream_adapter.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/openssl_stream_adapter.h:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::setEnableWebRTCEncryption):
(WebCore::LibWebRTCProvider::setUseDTLS10): Deleted.
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setUseDTLS10): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/280241@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 25d868: Remove WebRTCH264SimulcastEnabled flag

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25d8682496410c1aa7142baeb5380d1601fa4059
  
https://github.com/WebKit/WebKit/commit/25d8682496410c1aa7142baeb5380d1601fa4059
  Author: Youenn Fablet 
  Date:   2024-06-20 (Thu, 20 Jun 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/page/DeprecatedGlobalSettings.h

  Log Message:
  ---
  Remove WebRTCH264SimulcastEnabled flag
rdar://130199876
https://bugs.webkit.org/show_bug.cgi?id=275682

Reviewed by Eric Carlson.

The field trial was removed in libwebrtc so this feature flag is a no-op.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setWebRTCH264LowLatencyEncoderEnabled):
(WebCore::DeprecatedGlobalSettings::webRTCH264SimulcastEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setWebRTCH264SimulcastEnabled): Deleted.

Canonical link: https://commits.webkit.org/280203@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dbc751: Use more weak pointers for AVVideoCaptureSource

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbc751acf0c3a99864984e6404fd0fb421a11eb8
  
https://github.com/WebKit/WebKit/commit/dbc751acf0c3a99864984e6404fd0fb421a11eb8
  Author: Youenn Fablet 
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  Use more weak pointers for AVVideoCaptureSource
rdar://107135221
https://bugs.webkit.org/show_bug.cgi?id=275557

Reviewed by Eric Carlson.

Move from raw pointer in WebCoreAVVideoCaptureSourceObserver to a weak pointer.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(-[WebCoreAVVideoCaptureSourceObserver initWithCaptureSource:]):
(-[WebCoreAVVideoCaptureSourceObserver disconnect]):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver 
captureOutput:didOutputSampleBuffer:fromConnection:]):
(-[WebCoreAVVideoCaptureSourceObserver 
captureOutput:didFinishProcessingPhoto:error:]):
(-[WebCoreAVVideoCaptureSourceObserver 
observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVVideoCaptureSourceObserver deviceConnectedDidChange:]):
(-[WebCoreAVVideoCaptureSourceObserver sessionRuntimeError:]):
(-[WebCoreAVVideoCaptureSourceObserver beginSessionInterrupted:]):
(-[WebCoreAVVideoCaptureSourceObserver endSessionInterrupted:]):
(-[WebCoreAVVideoCaptureSourceObserver initWithCallback:]): Deleted.

Canonical link: https://commits.webkit.org/280071@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f55a27: Sec-Fetch-Destination is invalid for service worke...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f55a27a7a6fa99d9870f187d6b06471991672b5d
  
https://github.com/WebKit/WebKit/commit/f55a27a7a6fa99d9870f187d6b06471991672b5d
  Author: Youenn Fablet 
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-headers.https-expected.txt
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/loader/ResourceLoaderOptions.h
M Source/WebCore/loader/cache/CachedResourceLoader.cpp

  Log Message:
  ---
  Sec-Fetch-Destination is invalid for service worker intercepted loads
https://bugs.webkit.org/show_bug.cgi?id=275474
rdar://129832604

Reviewed by Alex Christensen.

We are updating destination when empty based on the resource type.
We are then using destination to compute sec-fetch-dest which has a specific 
handling of empty.
To cover the case of mismatch (which happens only for service worker 
intercepted fetches), we are storing whether the load is a fetch.
In which case, we are using empty string as a the value of sec-fetch-dest.
.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-headers.https-expected.txt:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::updateRequestFetchMetadataHeaders):

Canonical link: https://commits.webkit.org/280070@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c2dab: Update libwebrtc libaom to M126

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c2dabfd396bcc0c98b337ea09b06b6f55d6dbd8
  
https://github.com/WebKit/WebKit/commit/8c2dabfd396bcc0c98b337ea09b06b6f55d6dbd8
  Author: Youenn Fablet 
  Date:   2024-06-17 (Mon, 17 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/DIR_METADATA
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/README.chromium
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/cmake_update.sh
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/libaom_srcs.gni
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/libaom_test_srcs.gni
M Source/ThirdParty/libwebrtc/Source/third_party/libaom/options.gni
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/config/aom_version.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/av1_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm-neon/config/av1_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm/config/av1_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/arm64-cpu-detect/config/av1_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/generic/config/av1_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/aom_config.c
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/aom_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/aom_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/aom_scale_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libaom/source/config/linux/ia32/config/av1_rtcd.h
M 

[webkit-changes] [WebKit/WebKit] deeefb: Incorrect Sec-Fetch-Site values on sandboxed iframes

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: deeefb52b7fdf76d21c9d747106deb3045e14119
  
https://github.com/WebKit/WebKit/commit/deeefb52b7fdf76d21c9d747106deb3045e14119
  Author: Youenn Fablet 
  Date:   2024-06-16 (Sun, 16 Jun 2024)

  Changed paths:
A LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-expected.txt
A 
LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-reuse-expected.txt
A LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-reuse.html
A LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes.html
A LayoutTests/http/wpt/fetch/resources/sec-fetch-site.py
M Source/WebCore/loader/SubresourceLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.h

  Log Message:
  ---
  Incorrect Sec-Fetch-Site values on sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=260284
rdar://114340186

Reviewed by Brady Eidson.

For navigation loads, we were always using the frame origin to compute 
sec-fetch-site.
This does not work for initial iframe loads, since the load is made on behalf 
of the context that created the iframe.
For navigation loads, we are now reyling on the requester origin info from the 
document loader if available.

* LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-expected.txt: 
Added.
* 
LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-reuse-expected.txt:
 Added.
* LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes-reuse.html: 
Added.
* LayoutTests/http/wpt/fetch/fetch-metadata-for-sandbox-iframes.html: Added.
* LayoutTests/http/wpt/fetch/resources/sec-fetch-site.py: Added.
(main):
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequestInternal):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::convertEnumerationToString):
(WebCore::computeFetchMetadataSiteInternal):
(WebCore::CachedResourceLoader::computeFetchMetadataSite):
(WebCore::CachedResourceLoader::computeFetchMetadataSiteAfterRedirection):
(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):
* Source/WebCore/loader/cache/CachedResourceLoader.h:

Canonical link: https://commits.webkit.org/280065@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3664d7: Prefer videoBinned camera presets in case resizing...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3664d7d244e0924b68bd6fd9b24f0f6aa3a7821a
  
https://github.com/WebKit/WebKit/commit/3664d7d244e0924b68bd6fd9b24f0f6aa3a7821a
  Author: Youenn Fablet 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M 
LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt
A LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt
A LayoutTests/fast/mediastream/camera-powerEfficient-track.html
M LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h
M Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl
M Source/WebCore/platform/mediastream/MediaConstraintType.cpp
M Source/WebCore/platform/mediastream/MediaConstraintType.h
M Source/WebCore/platform/mediastream/MediaConstraints.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M 
Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mediastream/VideoPreset.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockMediaDevice.h
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h

  Log Message:
  ---
  Prefer videoBinned camera presets in case resizing is needed
https://bugs.webkit.org/show_bug.cgi?id=275317
rdar://129506159

Reviewed by Eric Carlson.

In case we select a preset that might require downsampling, it is good to favor 
binned presets as this is better for power efficiency.
Previously, we were favoring videoBinned presets if they were closer to the 
final size.

We can be more aggressive than that and favor videoBinned presets even if they 
are further from the final size.
We still try to select the smallest possible videoBinned preset.
This is implemented in RealtimeVideoCaptureSource.

As video binned format may not always be the best preset, we use the 
powerEfficientPixelFormat as a constraint that can be given to 
getUserMedia/applyConstraints
to aggressively select binned presets.
We do not expose settings and capabilities for this constraint since we only 
use it as a hint that the web application is wanting power efficiency.

We update some code to allow testing this feature.
We add a isEfficient field to VideoPreset so that we can mock efficient presets.
We have one such mock preset (environment camera, 1920 x 1080) that we use for 
testing.

We add the infrastructure to check whether a given capture track is power 
efficient or not.

We have to update 
LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html given it will 
now favor 1920x1080 preset, which is 16/9.

* 
LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt:
* LayoutTests/fast/mediastream/camera-powerEfficient-track-expected.txt: Added.
* LayoutTests/fast/mediastream/camera-powerEfficient-track.html: Added.
* LayoutTests/fast/mediastream/getUserMedia-video-rescaling.html:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::hasInvalidGetDisplayMediaConstraint):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp:
(WebCore::convertToInternalForm):
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h:
* Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl:
* Source/WebCore/platform/mediastream/MediaConstraintType.cpp:

[webkit-changes] [WebKit/WebKit] dcc6c1: Prevent crash when calling [AVCaptureSession init]...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcc6c1646e3a0cc654c7cf3210536bc05c05e6e5
  
https://github.com/WebKit/WebKit/commit/dcc6c1646e3a0cc654c7cf3210536bc05c05e6e5
  Author: Youenn Fablet 
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  ---
  Prevent crash when calling [AVCaptureSession init] in AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=275476
rdar://129801303

Reviewed by Eric Carlson.

We partially revert https://commits.webkit.org/277415@main, as it reintroduce 
the crash for safari view services.
We disable the checks specifically for iOS simulator, since there is no support 
for media endowments.

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::startProducingData):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::startProducingData):

Canonical link: https://commits.webkit.org/280020@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b80314: W3C exporter is exporting WebKit dummy html files ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b80314108a391e5c8f417d7b496ed4a4437b05a2
  
https://github.com/WebKit/WebKit/commit/b80314108a391e5c8f417d7b496ed4a4437b05a2
  Author: Youenn Fablet 
  Date:   2024-06-13 (Thu, 13 Jun 2024)

  Changed paths:
M Tools/Scripts/webkitpy/w3c/test_exporter.py
M Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py

  Log Message:
  ---
  W3C exporter is exporting WebKit dummy html files for 
sharedworker/serviceworker templated tests
https://bugs.webkit.org/show_bug.cgi?id=275358
rdar://129583053

Reviewed by Jean-Yves Avenard.

Excluding files with .any.sharedwoker.html and .any.servicewoker.html like done 
for other WebKit files.

* Tools/Scripts/webkitpy/w3c/test_exporter.py:
* Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:

Canonical link: https://commits.webkit.org/279985@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aa49cd: Introduce VideoPresetConstraints to more easily ad...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa49cd4d27107bd400dbbffc2542ddd5e30ab8ed
  
https://github.com/WebKit/WebKit/commit/aa49cd4d27107bd400dbbffc2542ddd5e30ab8ed
  Author: Youenn Fablet 
  Date:   2024-06-13 (Thu, 13 Jun 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
M 
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  ---
  Introduce VideoPresetConstraints to more easily add constraints that can 
influence camera preset selection
https://bugs.webkit.org/show_bug.cgi?id=275395
rdar://129666559

Reviewed by Philippe Normand and Eric Carlson.

Instead of passing multiple parameters together, let's use a 
VideoPresetConstraints struct instead.
We can in the future extend the number of parameters used to compute the camera 
preset without too much changes.

* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::supportsSizeFrameRateAndZoom):
(WebCore::RealtimeMediaSource::hasInvalidSizeFrameRateAndZoomConstraints):
(WebCore::RealtimeMediaSource::setSizeFrameRateAndZoom):
(WebCore::RealtimeMediaSource::extractVideoPresetConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):
(WebCore::RealtimeMediaSource::extractVideoFrameSizeConstraints): Deleted.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::supportsSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::bestSupportedSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::bestSupportedSizeFrameRateAndZoomConsideringObservers):
(WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoom):
(WebCore::RealtimeVideoCaptureSource::takePhoto):
* Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::setSizeFrameRateAndZoom):
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::setSizeFrameRateAndZoom):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
* 
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockRealtimeVideoSourceGStreamer::setSizeFrameRateAndZoom):
* 
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::supportsSizeFrameRateAndZoom):
(WebCore::MockRealtimeVideoSource::setSizeFrameRateAndZoom):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

Canonical link: https://commits.webkit.org/279982@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c47f4c: `navigator.storage.getDirectory()` fails in servic...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c47f4cabd53d3a7ac9b68677900bc678c11eeb33
  
https://github.com/WebKit/WebKit/commit/c47f4cabd53d3a7ac9b68677900bc678c11eeb33
  Author: Youenn Fablet 
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.serviceworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.worker.html
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M 
Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp

  Log Message:
  ---
  `navigator.storage.getDirectory()` fails in service workers with an 
`NotSupportedError: The operation is not supported`
https://bugs.webkit.org/show_bug.cgi?id=273906
rdar://127775672

Reviewed by Ben Nham.

Add a storage provider to shared workers and service workers.
We reuse the one used for documents since shared workers and service workers 
use a WorkerStorageConnection which will use the document's one.

* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.js:
 Added.
(promise_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.serviceworker-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.serviceworker.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.sharedworker-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.sharedworker.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.worker-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/file-system-access/getDirectory.https.any.worker.html:
 Added.
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
* Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):

Canonical link: https://commits.webkit.org/279908@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf758a: FileSystemDirectoryHandle::getFileHandle should su...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf758a90a435b2e02b182c4b6444c4bfb590049e
  
https://github.com/WebKit/WebKit/commit/cf758a90a435b2e02b182c4b6444c4bfb590049e
  Author: Youenn Fablet 
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp
M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h

  Log Message:
  ---
  FileSystemDirectoryHandle::getFileHandle should succeed even if 'this' is GCed
https://bugs.webkit.org/show_bug.cgi?id=275252
rdar://problem/129395480

Reviewed by Ben Nham.

Stop taking a weak pointer of FileSystemDirectoryHandle in 
FileSystemDirectoryHandle::getFileHandle and 
FileSystemDirectoryHandle::getDirectoryHandle.
Instead, we take a weak pointer of its context and return early if the context 
is gone.

This change will be covered by test added in 
https://github.com/WebKit/WebKit/pull/29615.

Since we do not need FileSystemHandle to be thread safe or weak pointer, we 
move it to a simple RefCounted object.

* Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp:
(WebCore::FileSystemDirectoryHandle::getFileHandle):
(WebCore::FileSystemDirectoryHandle::getDirectoryHandle):
(WebCore::FileSystemDirectoryHandle::getHandle):
* Source/WebCore/Modules/filesystemaccess/FileSystemHandle.h:

Canonical link: https://commits.webkit.org/279879@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 34f0fd: Update libwebrtc libyuv to M126

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34f0fd85da2d8e6abb922028d8ffd57c1714865e
  
https://github.com/WebKit/WebKit/commit/34f0fd85da2d8e6abb922028d8ffd57c1714865e
  Author: Youenn Fablet 
  Date:   2024-06-09 (Sun, 09 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/Android.bp
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/Android.mk
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/CMakeLists.txt
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/DEPS
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/README.chromium
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/docs/environment_variables.md
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/docs/getting_started.md
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/compare_row.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/convert_argb.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/cpu_id.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/planar_functions.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/rotate_row.h
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/row.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/scale.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/scale_row.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/include/libyuv/version.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/infra/config/cr-buildbucket.cfg
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/infra/config/main.star
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/infra/config/project.cfg
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/libyuv.gni
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/linux.mk
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/riscv_script/riscv-clang.cmake
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/convert.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/convert_argb.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/convert_from.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/convert_from_argb.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/cpu_id.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/mjpeg_decoder.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/planar_functions.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/rotate.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/rotate_argb.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/rotate_common.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_common.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_gcc.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_lasx.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_lsx.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_neon.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_neon64.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_rvv.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_argb.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_common.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_rvv.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_uv.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/tools_libyuv/autoroller/roll_deps.py
A 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/convert_argb_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/convert_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/cpu_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/planar_test.cc
A 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/scale_plane_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/scale_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/unit_test.cc
M Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/cpuid.c

  Log Message:
  ---
  Update libwebrtc libyuv to M126
https://bugs.webkit.org/show_bug.cgi?id=274526
rdar://128543715

Reviewed by Jean-Yves Avenard.

* Source/ThirdParty/libwebrtc/Source/third_party/libyuv: Resynced.

Canonical link: 

[webkit-changes] [WebKit/WebKit] 631189: Remove RTCStats default constructors

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6311892c70d834b4aede4a04d4ce4ccc136063f4
  
https://github.com/WebKit/WebKit/commit/6311892c70d834b4aede4a04d4ce4ccc136063f4
  Author: Youenn Fablet 
  Date:   2024-06-08 (Sat, 08 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/applepay/ApplePayAutomaticReloadPaymentRequest.idl
M Source/WebCore/Modules/applepay/ApplePayDateComponents.idl
M Source/WebCore/Modules/applepay/ApplePayDateComponentsRange.idl
M Source/WebCore/Modules/applepay/ApplePayDeferredPaymentRequest.idl
M Source/WebCore/Modules/applepay/ApplePayDisbursementRequest.idl
M Source/WebCore/Modules/applepay/ApplePayInstallmentConfiguration.idl
M Source/WebCore/Modules/applepay/ApplePayInstallmentItem.idl
M Source/WebCore/Modules/applepay/ApplePayLineItem.idl
M Source/WebCore/Modules/applepay/ApplePayPaymentContact.idl
M Source/WebCore/Modules/applepay/ApplePayPaymentMethod.idl
M Source/WebCore/Modules/applepay/ApplePayPaymentPass.idl
M Source/WebCore/Modules/applepay/ApplePayPaymentTokenContext.idl
M Source/WebCore/Modules/applepay/ApplePayRecurringPaymentRequest.idl
M Source/WebCore/Modules/applepay/ApplePaySetupConfiguration.idl
M Source/WebCore/Modules/applepay/ApplePayShippingMethod.idl
M Source/WebCore/Modules/cookie-store/CookieListItem.idl
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemConfiguration.idl
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemMediaCapability.idl
M Source/WebCore/Modules/mediacapabilities/AudioConfiguration.idl
M Source/WebCore/Modules/mediacapabilities/MediaDecodingConfiguration.idl
M Source/WebCore/Modules/mediacapabilities/MediaEncodingConfiguration.idl
M Source/WebCore/Modules/mediacapabilities/VideoConfiguration.idl
M Source/WebCore/Modules/mediasession/MediaImage.idl
M Source/WebCore/Modules/mediasession/MediaMetadataInit.idl
M Source/WebCore/Modules/mediasession/MediaPositionState.idl
M Source/WebCore/Modules/mediasession/MediaSessionActionDetails.idl
M Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl
M Source/WebCore/Modules/mediastream/PhotoSettings.idl
M Source/WebCore/Modules/mediastream/RTCConfiguration.idl
M Source/WebCore/Modules/mediastream/RTCIceCandidateInit.idl
M Source/WebCore/Modules/mediastream/RTCIceServer.idl
M Source/WebCore/Modules/mediastream/RTCRtcpParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpCodecCapability.idl
M Source/WebCore/Modules/mediastream/RTCRtpCodecParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpEncodingParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpFecParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpHeaderExtensionParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpRtxParameters.idl
M Source/WebCore/Modules/mediastream/RTCRtpSendParameters.idl
M Source/WebCore/Modules/mediastream/RTCSessionDescriptionInit.idl
M Source/WebCore/Modules/mediastream/RTCStatsReport.h
M Source/WebCore/Modules/mediastream/RTCStatsReport.idl
M Source/WebCore/Modules/model-element/HTMLModelElementCamera.idl
M Source/WebCore/Modules/webaudio/AudioWorkletNodeOptions.idl
M Source/WebCore/Modules/webcodecs/AacEncoderConfig.idl
M Source/WebCore/Modules/webcodecs/AvcEncoderConfig.idl
M Source/WebCore/Modules/webcodecs/FlacEncoderConfig.idl
M Source/WebCore/Modules/webcodecs/OpusEncoderConfig.idl
M Source/WebCore/Modules/webcodecs/PlaneLayout.idl
M Source/WebCore/Modules/webcodecs/VideoColorSpaceInit.idl
M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl
M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoderConfig.idl
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoderConfig.idl
M Source/WebCore/animation/EffectTiming.idl
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/IDLAttributes.json
M Source/WebCore/bindings/scripts/test/ExposedToWorkerAndWindow.idl
A Source/WebCore/bindings/scripts/test/JS/JSTestDictionaryNoToNative.cpp
A Source/WebCore/bindings/scripts/test/JS/JSTestDictionaryNoToNative.h
M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep
M Source/WebCore/bindings/scripts/test/TestDerivedDictionary.idl
M Source/WebCore/bindings/scripts/test/TestDerivedDictionary2.idl
A Source/WebCore/bindings/scripts/test/TestDictionaryNoToNative.idl
M 
Source/WebCore/bindings/scripts/test/TestDictionaryWithOnlyConditionalMembers.idl
M Source/WebCore/bindings/scripts/test/TestEmptyDictionary.idl
M Source/WebCore/bindings/scripts/test/TestInheritedDictionary.idl
M Source/WebCore/bindings/scripts/test/TestInheritedDictionary2.idl
M Source/WebCore/bindings/scripts/test/TestObj.idl
M 

[webkit-changes] [WebKit/WebKit] 459356: Update libwebrtc libvpx to M126

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4593568f2fd131b431b5ff4c7bc43ec700355b82
  
https://github.com/WebKit/WebKit/commit/4593568f2fd131b431b5ff4c7bc43ec700355b82
  Author: Youenn Fablet 
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/BUILD.gn
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/DIR_METADATA
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/README.chromium
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/generate_gni.sh
M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/libvpx_srcs.gni
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp9_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vp9_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/generic/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/generic/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/generic/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/ia32/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/ia32/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/ia32/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/loongarch/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/loongarch/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/mips64el/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/mips64el/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/mipsel/vpx_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/mipsel/vpx_dsp_rtcd.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/ppc64/vpx_config.asm
M 
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/ppc64/vpx_config.h
M 

[webkit-changes] [WebKit/WebKit] 413b6d: Do not hit main thread when using CacheStorageConn...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 413b6df42e717eff645d3c4ca47a332ddb64edfe
  
https://github.com/WebKit/WebKit/commit/413b6df42e717eff645d3c4ca47a332ddb64edfe
  Author: Youenn Fablet 
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/cache/WindowOrWorkerGlobalScopeCaches.cpp
R Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
R Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
M Source/WebCore/Modules/identity/DigitalCredential.cpp
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.cpp

  Log Message:
  ---
  Do not hit main thread when using CacheStorageConnection from a worker
https://bugs.webkit.org/show_bug.cgi?id=274967
rdar://129062867

Reviewed by Sihui Liu.

We make WebCacheStorageConnection thread safe to be called.
To do so, we add locks for getting the connection and for the hash maps.
To keep consistency between connection and hash maps, as was ensured before 
this patch, we lock both map lock and connection lock when updating the map.

We block the worker thread to get the connection and then we can use it 
directly from the worker.
In case of network process crash, we might have to block again the worker on 
main thread.

Covered by existing tests.

* Source/WebCore/Modules/cache/WindowOrWorkerGlobalScopeCaches.cpp:
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp: Removed.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h: Removed.
* Source/WebCore/Modules/identity/DigitalCredential.cpp:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::cacheStorageConnection):
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::~WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::connection):
(WebKit::WebCacheStorageConnection::open):
(WebKit::WebCacheStorageConnection::remove):
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::reference):
(WebKit::WebCacheStorageConnection::dereference):
(WebKit::WebCacheStorageConnection::lockStorage):
(WebKit::WebCacheStorageConnection::unlockStorage):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
(WebKit::WebCacheStorageConnection::updateQuotaBasedOnSpaceUsage):
(WebKit::WebCacheStorageConnection::networkProcessConnectionClosed):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:
* Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.cpp:
(WebKit::WebCacheStorageProvider::createCacheStorageConnection):

Canonical link: https://commits.webkit.org/279805@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 251159: Update libwebrtc abseil-cpp to M126

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 251159731dd9d9f888c075212911363f4f82d018
  
https://github.com/WebKit/WebKit/commit/251159731dd9d9f888c075212911363f4f82d018
  Author: Youenn Fablet 
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/BUILD.bazel
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/CMake/AbseilDll.cmake
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/CMake/AbseilHelpers.cmake
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/CMakeLists.txt
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/DIR_METADATA
A Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/MODULE.bazel
A 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/PrivacyInfo.xcprivacy
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/README.chromium
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/WORKSPACE
A Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/WORKSPACE.bzlmod
M Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl.gni
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/abseil.podspec.gen.py
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/algorithm/BUILD.bazel
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/algorithm/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/algorithm/CMakeLists.txt
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/algorithm/container.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/algorithm/container_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/BUILD.bazel
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/CMakeLists.txt
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/attributes.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/call_once.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/casts.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/dynamic_annotations.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/endian.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/identity.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/inline_variable.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/low_level_alloc.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/raw_logging.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/raw_logging.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/spinlock.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/spinlock_benchmark.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/unaligned_access.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/unscaledcycleclock.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/internal/unscaledcycleclock_config.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/log_severity.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/log_severity_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/macros.h
A 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/no_destructor.h
A 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/no_destructor_benchmark.cc
A 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/no_destructor_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/options.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/prefetch.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/cleanup/cleanup_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/BUILD.bazel
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/BUILD.gn
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/CMakeLists.txt
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/btree_map.h
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/btree_test.cc
M 
Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/container/flat_hash_map.h

[webkit-changes] [WebKit/WebKit] 819dab: Reverse sendWithPromisedReply first and second tem...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 819dab4131c790b064fae8c1d99f5a155ce392f9
  
https://github.com/WebKit/WebKit/commit/819dab4131c790b064fae8c1d99f5a155ce392f9
  Author: Youenn Fablet 
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageSenderInlines.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp

  Log Message:
  ---
  Reverse sendWithPromisedReply first and second template parameters
https://bugs.webkit.org/show_bug.cgi?id=275119
rdar://129230812

Reviewed by Jean-Yves Avenard.

To go back to previous sendWithPromisedReply style, we reverse the Message and 
PromiseConverter termplate parameter order.
We also further simplify the PromiseConverter by only handling error and not 
result types.
This removes the need for the PromiseConverter to define how to convert results 
(usually a no-op).
We use type deduction to compute the converted promise so that the 
PromiseConverter no longer has to define the converted promise type.
Covered by existing tests.

* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::NoOpPromiseConverter::convertError):
(IPC::Connection::sendWithPromisedReply):
(IPC::Connection::makeAsyncReplyHandlerWithDispatcher):
(IPC::Connection::PromiseConverter::convertResult): Deleted.
(IPC::Connection::PromiseConverter::convertError): Deleted.
* Source/WebKit/Platform/IPC/MessageSenderInlines.h:
(IPC::MessageSender::sendWithPromisedReply):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::PromiseConverter::convertError):
(WebKit::WebCacheStorageConnection::open):
(WebKit::WebCacheStorageConnection::remove):
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
(WebKit::WebCacheStorageConnection::PromiseConverter::convertResult): Deleted.
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::encodeFrameInternal):
(WebKit::LibWebRTCCodecs::flushEncoder):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
(WebKit::RemoteRealtimeMediaSourceProxy::PromiseConverter::convertError):
(WebKit::RemoteRealtimeMediaSourceProxy::takePhoto):
(WebKit::RemoteRealtimeMediaSourceProxy::getPhotoCapabilities):
(WebKit::RemoteRealtimeMediaSourceProxy::getPhotoSettings):
(WebKit::RemoteRealtimeMediaSourceProxy::PromiseConverter::convertResult): 
Deleted.
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):
(TestWebKitAPI::PromiseConverter::convertError):
(TestWebKitAPI::PromiseConverter::convertResult): Deleted.
* Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/279758@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e4d9db: [Cocoa] Enable HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4d9dbf26e7fab3549fdf527f4f5d74e82c5958b
  
https://github.com/WebKit/WebKit/commit/e4d9dbf26e7fab3549fdf527f4f5d74e82c5958b
  Author: Youenn Fablet 
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  [Cocoa] Enable HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT
rdar://129222031
https://bugs.webkit.org/show_bug.cgi?id=275109

Reviewed by Eric Carlson.

It is no longer needed as all macOS versions support it.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSessionSizeFrameRateAndZoom):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::avVideoCapturePixelBufferFormat): Deleted.

Canonical link: https://commits.webkit.org/279737@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22a4b2: REGRESSION (279647@main): [ MacOS iOS ] 2K TestIPC...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22a4b2c1b41ba1565bbcacfe986f05031539493d
  
https://github.com/WebKit/WebKit/commit/22a4b2c1b41ba1565bbcacfe986f05031539493d
  Author: Youenn Fablet 
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp

  Log Message:
  ---
  REGRESSION (279647@main): [ MacOS iOS ] 2K 
TestIPC.ConnectionTest/ConnectionRunLoopTest.SendWithConvertedPromisedReply are 
consistent crashes
rdar://129189916
https://bugs.webkit.org/show_bug.cgi?id=275080

Reviewed by Jean-Yves Avenard.

We need to delay the task until the promise is resolved.

* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/279734@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d7759d: Add libwebrtc specific WebCore RTCStat object cons...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7759dc9cbb90b3fda92a54521c132c18cc5a0df
  
https://github.com/WebKit/WebKit/commit/d7759dc9cbb90b3fda92a54521c132c18cc5a0df
  Author: Youenn Fablet 
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/RTCStatsReport.h
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp

  Log Message:
  ---
  Add libwebrtc specific WebCore RTCStat object constructors
rdar://129205417
https://bugs.webkit.org/show_bug.cgi?id=275096

Reviewed by Jean-Yves Avenard.

Refactoring to do more initialization in constructors.
This makes it easier to initialize all values and will help code analysis.

* Source/WebCore/Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::InboundRtpStreamStats::InboundRtpStreamStats): 
Deleted.
(WebCore::RTCStatsReport::RemoteInboundRtpStreamStats::RemoteInboundRtpStreamStats):
 Deleted.
(WebCore::RTCStatsReport::OutboundRtpStreamStats::OutboundRtpStreamStats): 
Deleted.
(WebCore::RTCStatsReport::RemoteOutboundRtpStreamStats::RemoteOutboundRtpStreamStats):
 Deleted.
(WebCore::RTCStatsReport::DataChannelStats::DataChannelStats): Deleted.
(WebCore::RTCStatsReport::IceCandidatePairStats::IceCandidatePairStats): 
Deleted.
(WebCore::RTCStatsReport::CertificateStats::CertificateStats): Deleted.
(WebCore::RTCStatsReport::CodecStats::CodecStats): Deleted.
(WebCore::RTCStatsReport::TransportStats::TransportStats): Deleted.
(WebCore::RTCStatsReport::AudioPlayoutStats::AudioPlayoutStats): Deleted.
(WebCore::RTCStatsReport::PeerConnectionStats::PeerConnectionStats): Deleted.
(WebCore::RTCStatsReport::AudioSourceStats::AudioSourceStats): Deleted.
(WebCore::RTCStatsReport::VideoSourceStats::VideoSourceStats): Deleted.
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::RTCStatsReport::Stats::Stats):
(WebCore::RTCStatsReport::RtpStreamStats::RtpStreamStats):
(WebCore::RTCStatsReport::ReceivedRtpStreamStats::ReceivedRtpStreamStats):
(WebCore::RTCStatsReport::InboundRtpStreamStats::InboundRtpStreamStats):
(WebCore::RTCStatsReport::RemoteInboundRtpStreamStats::RemoteInboundRtpStreamStats):
(WebCore::RTCStatsReport::SentRtpStreamStats::SentRtpStreamStats):
(WebCore::convertQualityLimitationReason):
(WebCore::RTCStatsReport::OutboundRtpStreamStats::OutboundRtpStreamStats):
(WebCore::RTCStatsReport::RemoteOutboundRtpStreamStats::RemoteOutboundRtpStreamStats):
(WebCore::RTCStatsReport::DataChannelStats::DataChannelStats):
(WebCore::RTCStatsReport::IceCandidatePairStats::IceCandidatePairStats):
(WebCore::RTCStatsReport::IceCandidateStats::IceCandidateStats):
(WebCore::RTCStatsReport::CertificateStats::CertificateStats):
(WebCore::RTCStatsReport::CodecStats::CodecStats):
(WebCore::convertIceRole):
(WebCore::convertDtlsRole):
(WebCore::RTCStatsReport::TransportStats::TransportStats):
(WebCore::RTCStatsReport::PeerConnectionStats::PeerConnectionStats):
(WebCore::RTCStatsReport::MediaSourceStats::MediaSourceStats):
(WebCore::RTCStatsReport::AudioSourceStats::AudioSourceStats):
(WebCore::RTCStatsReport::AudioPlayoutStats::AudioPlayoutStats):
(WebCore::RTCStatsReport::VideoSourceStats::VideoSourceStats):
(WebCore::addToStatsMap):
(WebCore::initializeRTCStatsReportBackingMap):
(WebCore::fillRTCStats): Deleted.
(WebCore::fillRtpStreamStats): Deleted.
(WebCore::fillReceivedRtpStreamStats): Deleted.
(WebCore::fillInboundRtpStreamStats): Deleted.
(WebCore::fillRemoteInboundRtpStreamStats): Deleted.
(WebCore::fillSentRtpStreamStats): Deleted.
(WebCore::qualityLimitationReason): Deleted.
(WebCore::fillOutboundRtpStreamStats): Deleted.
(WebCore::fillRemoteOutboundRtpStreamStats): Deleted.
(WebCore::fillRTCDataChannelStats): Deleted.
(WebCore::fillRTCIceCandidatePairStats): Deleted.
(WebCore::fillRTCIceCandidateStats): Deleted.
(WebCore::fillRTCCertificateStats): Deleted.
(WebCore::fillRTCCodecStats): Deleted.
(WebCore::iceRole): Deleted.
(WebCore::dtlsRole): Deleted.
(WebCore::fillRTCTransportStats): Deleted.
(WebCore::fillRTCPeerConnectionStats): Deleted.
(WebCore::fillRTCMediaSourceStats): Deleted.
(WebCore::fillRTCAudioSourceStats): Deleted.
(WebCore::fillRTCAudioPlayoutStats): Deleted.
(WebCore::fillRTCVideoSourceStats): Deleted.

Canonical link: https://commits.webkit.org/279731@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b88d5c: Allow to easily convert IPC NativePromises

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b88d5c1970f976abeb9fe6d74e0433a922613818
  
https://github.com/WebKit/WebKit/commit/b88d5c1970f976abeb9fe6d74e0433a922613818
  Author: Youenn Fablet 
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageSenderInlines.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp

  Log Message:
  ---
  Allow to easily convert IPC NativePromises
https://bugs.webkit.org/show_bug.cgi?id=274957
rdar://129054558

Reviewed by Jean-Yves Avenard.

We sometimes use NativePromise in WebCore code and end up creating IPC 
NativePromises.
But the types between the two may not always match, for instance due to the 
handling of IPC::Error.
We used to use settle to adapt but it is more convenient to be able to convert 
directly before resolving/rejecting the promise.

We use this in WebCacheStorageConnection that has Promises defined in 
WebCore::CacheStorageConnection.
We use this for RemoteRealtimeMediaSourceProxy which has promises defined in 
WebCore::RemoteRealtimeMediaSource.

We update NetworkStorageManager::cacheStorageClearMemoryRepresentation as it is 
not returning any error.
We use a void completion handler instead.

* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::cacheStorageClearMemoryRepresentation):
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.messages.in:
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::PromiseConverter::convertResult):
(IPC::Connection::PromiseConverter::convertError):
(IPC::Connection::sendWithPromisedReply):
(IPC::Connection::makeAsyncReplyHandlerWithDispatcher):
* Source/WebKit/Platform/IPC/MessageSenderInlines.h:
(IPC::MessageSender::sendWithPromisedReply):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::PromiseConverter::convertResult):
(WebKit::WebCacheStorageConnection::PromiseConverter::convertError):
(WebKit::WebCacheStorageConnection::open):
(WebKit::WebCacheStorageConnection::remove):
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::encodeFrameInternal):
(WebKit::LibWebRTCCodecs::flushEncoder):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
(WebKit::RemoteRealtimeMediaSourceProxy::PromiseConverter::convertResult):
(WebKit::RemoteRealtimeMediaSourceProxy::PromiseConverter::convertError):
(WebKit::RemoteRealtimeMediaSourceProxy::takePhoto):
(WebKit::RemoteRealtimeMediaSourceProxy::getPhotoCapabilities):
(WebKit::RemoteRealtimeMediaSourceProxy::getPhotoSettings):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):
* Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/279647@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ed3e7: Mark libwebrtc as a product dependency of WebCore

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ed3e7ebcd2a6226206ed1a4cc4ee62a603c67d1
  
https://github.com/WebKit/WebKit/commit/0ed3e7ebcd2a6226206ed1a4cc4ee62a603c67d1
  Author: Youenn Fablet 
  Date:   2024-06-02 (Sun, 02 Jun 2024)

  Changed paths:
M Source/WebCore/Configurations/Base.xcconfig
M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  ---
  Mark libwebrtc as a product dependency of WebCore
rdar://128785444
https://bugs.webkit.org/show_bug.cgi?id=274747

Reviewed by Elliott Williams.

XCode does not always know that libwebrtc.dylib is a pre-requisite to build 
WebCore.
We add it as a product dependency of the generate unified files step similarly 
to what has been done for libWTF.a.
We restrict this to iOS, macOS and tvOS. This should be a no-op for production 
builds.

* Source/WebCore/Configurations/Base.xcconfig:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/279635@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 522508: Softlink a few more VideoToolbox functions

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 522508831be2bd7fee8e42d992f42111a109e954
  
https://github.com/WebKit/WebKit/commit/522508831be2bd7fee8e42d992f42111a109e954
  Author: Youenn Fablet 
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
M Source/WebCore/Configurations/WebCore.xcconfig
M Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp
M Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h

  Log Message:
  ---
  Softlink a few more VideoToolbox functions
https://bugs.webkit.org/show_bug.cgi?id=274897
rdar://129002682

Reviewed by Jean-Yves Avenard.

By soft linking a few more VT functions, we can remove linking to VT and 
CoreMedia frameworks.

* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp:
* Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h:

Canonical link: https://commits.webkit.org/279574@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f5ebbc: [macOS Sonoma] [WKWebView] navigator.mediaDevices....

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5ebbc5ed1246dc29ed91c1edb1b53810195074a
  
https://github.com/WebKit/WebKit/commit/f5ebbc5ed1246dc29ed91c1edb1b53810195074a
  Author: Youenn Fablet 
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm

  Log Message:
  ---
  [macOS Sonoma] [WKWebView] navigator.mediaDevices.getDisplayMedia() not 
working anymore as long as 
webView(_:requestMediaCapturePermissionFor:initiatedByFrame:type:decisionHandler:)
 gets implemented
https://bugs.webkit.org/show_bug.cgi?id=274896
rdar://128988615

Reviewed by Eric Carlson.

When no capture delegates are implemented, we rely on doing the capture request 
default action.
For display capture, it will prompt the user to choose the capture surface.

When adding a getUserMedia delegate, we no longer rely for getDisplayMedia on 
the default action.
Instead we rely on using the getDisplayMedia private delegate or we deny the 
request otherwise.

To fix this, we are now checking first whether the request is getUserMedia or 
getDisplayMedia.
In the former case, we use the default action if there is no getUserMedia 
delegate.
In the latter case, we use the default action if there is no getDisplayMedia 
delegate.

Covered by added test.

* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::isDelegateRespondingToDisplayCapturePermission):
(WebKit::UIDelegate::UIClient::promptForDisplayCapturePermission):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(-[MediaCaptureUIDelegate 
webView:requestMediaCapturePermissionForOrigin:initiatedByFrame:type:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::SetUp):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::GetDisplayMediaTest::SetUpInternal):
(TestWebKitAPI::GetDisplayMediaTest::hasDisplayCaptureDelegate const):
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/279566@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d24496: Move all CacheStorageConnection callbacks to Nativ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d244968bca644b6ae5f293054c1c1ba757cef5a2
  
https://github.com/WebKit/WebKit/commit/d244968bca644b6ae5f293054c1c1ba757cef5a2
  Author: Youenn Fablet 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/Modules/cache/CacheStorageConnection.h
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/cache/DOMCacheEngine.h
M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/page/CacheStorageProvider.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h

  Log Message:
  ---
  Move all CacheStorageConnection callbacks to NativePromise
https://bugs.webkit.org/show_bug.cgi?id=274726
rdar://128755510

Reviewed by Jean-Yves Avenard and Sihui Liu.

We move from completion handlers to native promise as a simplification.
We introduce a new enqueueTaskWhenSettled version that can take completion 
handler and a finalizer.
Covered by existing tests.

* Source/WebCore/Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::clearMemoryRepresentation):
(WebCore::CacheStorageConnection::engineRepresentation):
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
* Source/WebCore/Modules/cache/DOMCacheEngine.h:
* Source/WebCore/Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::retrieveCaches):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
(WebCore::WorkerCacheStorageConnection::retrieveCachesCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::retrieveRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::deleteRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::putRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::clearPendingRequests): Deleted.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::enqueueTaskWhenSettled):
* Source/WebCore/page/CacheStorageProvider.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::clearCacheStorageMemoryRepresentation):
(WebCore::Internals::cacheStorageEngineRepresentation):
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::prepareForDestruction):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:

Canonical link: https://commits.webkit.org/279505@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1f8560: Add WebCore Internals Additions

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f85606a727c19870a78d005b9e2dd315fb18257
  
https://github.com/WebKit/WebKit/commit/1f85606a727c19870a78d005b9e2dd315fb18257
  Author: Youenn Fablet 
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
M Source/WebCore/testing/Internals.mm

  Log Message:
  ---
  Add WebCore Internals Additions
rdar://128785269
https://bugs.webkit.org/show_bug.cgi?id=274746

Reviewed by Andy Estes.

It is useful to add Additions to WebCoreTestSupport, for instance as part of 
rdar://125828208.
We include WebCoreAdditions.mm for internal builds if the file is available.

* Source/WebCore/testing/Internals.mm:

Canonical link: https://commits.webkit.org/279459@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0200b0: Use native promise for CacheStorageConnection::remove

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0200b038d629471c44af42122601f71e35e26982
  
https://github.com/WebKit/WebKit/commit/0200b038d629471c44af42122601f71e35e26982
  Author: Youenn Fablet 
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
M Source/WebCore/Modules/cache/CacheStorageConnection.h
M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
M Source/WebCore/page/CacheStorageProvider.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h

  Log Message:
  ---
  Use native promise for CacheStorageConnection::remove
rdar://128529826
https://bugs.webkit.org/show_bug.cgi?id=274514

Reviewed by Sihui Liu.

Refactoring to use native promise for CacheStorageConnection::remove allows to 
simplify code.
This might pave the way towards sending IPC message to the network process from 
the worker thread directly as well.

* Source/WebCore/Modules/cache/CacheStorageConnection.h:
* Source/WebCore/Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::doRemove):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::remove):
(WebCore::WorkerCacheStorageConnection::clearPendingRequests):
(WebCore::WorkerCacheStorageConnection::removeCompleted): Deleted.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:
* Source/WebCore/page/CacheStorageProvider.h:
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::remove):
(WebKit::WebCacheStorageConnection::retrieveCaches): Deleted.
(WebKit::WebCacheStorageConnection::retrieveRecords): Deleted.
(WebKit::WebCacheStorageConnection::batchDeleteOperation): Deleted.
(WebKit::WebCacheStorageConnection::batchPutOperation): Deleted.
(WebKit::WebCacheStorageConnection::reference): Deleted.
(WebKit::WebCacheStorageConnection::dereference): Deleted.
(WebKit::WebCacheStorageConnection::lockStorage): Deleted.
(WebKit::WebCacheStorageConnection::unlockStorage): Deleted.
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation): Deleted.
(WebKit::WebCacheStorageConnection::engineRepresentation): Deleted.
(WebKit::WebCacheStorageConnection::updateQuotaBasedOnSpaceUsage): Deleted.
(WebKit::WebCacheStorageConnection::networkProcessConnectionClosed): Deleted.

Canonical link: https://commits.webkit.org/279192@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 625de0: Disable thread-safety-reference-return warnings in...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 625de0728603e766a988d7a6ea9f712806162a3f
  
https://github.com/WebKit/WebKit/commit/625de0728603e766a988d7a6ea9f712806162a3f
  Author: Youenn Fablet 
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig

  Log Message:
  ---
  Disable thread-safety-reference-return warnings in libwebrtc
rdar://126802873
https://bugs.webkit.org/show_bug.cgi?id=274508

Reviewed by David Kilzer.

We disable thread-safety-reference-return as libwebrtc is not yet ready for 
this.
A few places would need additional annotations, and some other places are 
checking that the method is called in the right thread,
not that a mutex is held.

* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/279140@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05456a: [macOS Sonoma+] Enable microphone capture in GPUPr...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05456ae93aa145c7f52bb3876fa296469d9424d7
  
https://github.com/WebKit/WebKit/commit/05456ae93aa145c7f52bb3876fa296469d9424d7
  Author: Youenn Fablet 
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

  Log Message:
  ---
  [macOS Sonoma+] Enable microphone capture in GPUProcess for all applications
https://bugs.webkit.org/show_bug.cgi?id=274464
rdar://128463834

Reviewed by Jean-Yves Avenard.

Given rdar://problem/29448368 is fixed in Sonoma, we can enable GPU process 
microphone capture.
This allows to reuse VPIO for audio rendering like Safari does.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCaptureAudioInGPUProcessEnabled):

Canonical link: https://commits.webkit.org/279113@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a270d6: Most of WPT webrtc/RTCSctpTransport-maxMessageSize...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a270d67c53417c216ccfa1ed3bbc30a20e7d4512
  
https://github.com/WebKit/WebKit/commit/a270d67c53417c216ccfa1ed3bbc30a20e7d4512
  Author: Youenn Fablet 
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
M Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp
M Source/WebCore/Modules/mediastream/RTCSctpTransport.h
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

  Log Message:
  ---
  Most of WPT webrtc/RTCSctpTransport-maxMessageSize.html tests are failing
https://bugs.webkit.org/show_bug.cgi?id=274442
rdar://128444396

Reviewed by Philippe Normand.

We implement https://w3c.github.io/webrtc-pc/#sctp-transport-update-mms.
This is called when successfully applying a SDP description as per 
specification.
In this implementation, the assumption is that canSendSize is 0.
The specific value of 65536 is handled by libwebrtc.

* 
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::updateSctpBackend):
* Source/WebCore/Modules/mediastream/RTCPeerConnection.h:
* Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp:
(WebCore::RTCSctpTransport::onStateChanged):
(WebCore::RTCSctpTransport::updateMaxMessageSize):
* Source/WebCore/Modules/mediastream/RTCSctpTransport.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::SctpTransportState::maxMessageSize const):
(WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionSucceeded):
(WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionSucceeded):

Canonical link: https://commits.webkit.org/279111@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] da8086: [iOS] Camera track is sometimes muted/unmuted when...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da808677339de833db3e1d36ca34dda8464b4638
  
https://github.com/WebKit/WebKit/commit/da808677339de833db3e1d36ca34dda8464b4638
  Author: Youenn Fablet 
  Date:   2024-05-18 (Sat, 18 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  [iOS] Camera track is sometimes muted/unmuted when starting to capture
https://bugs.webkit.org/show_bug.cgi?id=274211
rdar://125475254

Reviewed by Eric Carlson.

There is a race condition below WebKit between media endowment activation and 
camera start-u.
This sometimes triggers spurious notification of being muted on iOS.
We add a timer that will delay mute notifications at startup time for 1 second.

Manually tested.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::startupTimerFired):
(WebCore::AVVideoCaptureSource::startProducingData):
(WebCore::AVVideoCaptureSource::captureSessionIsRunningDidChange):

Canonical link: https://commits.webkit.org/278952@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29cddc: If torch is on on a track, muting and unmuting it ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29cddce2522b69778bd95c60e2d9eb60bbd17714
  
https://github.com/WebKit/WebKit/commit/29cddce2522b69778bd95c60e2d9eb60bbd17714
  Author: Youenn Fablet 
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  If torch is on on a track, muting and unmuting it will switch off the torch
https://bugs.webkit.org/show_bug.cgi?id=270840
rdar://124435440

Reviewed by Eric Carlson.

When restarting to capture, we were not setting back torch to what it should be.
This would trigger the issue of having torch on, muting capture, unmuting 
capture and having torch off.
We fix this by ensuring that torch is updated when (re)starting capture.

We do a drive-by fix in AVVideoCaptureSource::reconfigureIfNeeded.
We need to call startApplyingConstraints/endApplyingConstraints instead of 
beginConfiguration/commitConfiguration, to keep the balance.
Otherwise updateTorch would do an additional beginConfiguration call without 
any corresponding commitConfiguration.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::reconfigureIfNeeded):

Canonical link: https://commits.webkit.org/278948@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4238f6: Do not delay getUserMedia promise resolution on VP...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4238f637a2833b0e91b07bacbf786517df549a7d
  
https://github.com/WebKit/WebKit/commit/4238f637a2833b0e91b07bacbf786517df549a7d
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  ---
  Do not delay getUserMedia promise resolution on VPIO unit prewarming
https://bugs.webkit.org/show_bug.cgi?id=274203
rdar://128112002

Reviewed by Eric Carlson.

Before this patch, we were delaying the resolution of the getUserMedia promise 
upon VPIO creation prewarming.
This was ensuring that there would be no freeze and audio capture would start 
right away.
But this delays the web page processing.

We are now doing the following when starting capture:
- Prewarm the VPIO unit when GPU process is instructed that it will start audio 
capture soon.
- Create sources in GPU process, do not wait for warming up to finish..
- Resolve getUserMedia promise.
- Start the sources. When starting microphone capture, complete the prewarming 
if needed before starting the VPIO unit.

This change allows the web page to manipulate the getUserMedia tracks sooner.
It can then use the tracks to set up a VC call for instance, in parallel to the 
prewarming of the VPIO unit.
We keep prewarming of the VPIO unit as fast as we can.

Manually tested on macOS, should be a no op on iOS.

* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:
(WebCore::BaseAudioSharedUnit::startProducingData):
(WebCore::BaseAudioSharedUnit::prepareForNewCapture):
* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h:
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::whenReady): Deleted.
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::prewarmAudioUnitCreation):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

Canonical link: https://commits.webkit.org/278860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b14793: Resuming audio playing of HTMLMediaElement via Aud...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1479358ffa916a136356f5ded70b22f22a1b7c2
  
https://github.com/WebKit/WebKit/commit/b1479358ffa916a136356f5ded70b22f22a1b7c2
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
A LayoutTests/webaudio/audiomix-bufferingpolicy-expected.txt
A LayoutTests/webaudio/audiomix-bufferingpolicy.html
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  Resuming audio playing of HTMLMediaElement via AudioContext does not work if 
user switched from tab
https://bugs.webkit.org/show_bug.cgi?id=270352
rdar://123901202

Reviewed by Eric Carlson.

When switching from one tab to the other, we are setting AVPlayer 
resourceConservationLevelWhilePaused to 
AVPlayerResourceConservationLevelReuseActivePlayerResources.
When getting back to the tab, we set it back to 
AVPlayerResourceConservationLevelNone.
But the AVPlayer audio mix is not functional anymore.

We implement a workaround at WebKit level by recreating the audio mix if needed 
whenever moving out of 
AVPlayerResourceConservationLevelReuseActivePlayerResources.

Covered by added test.

* LayoutTests/webaudio/audiomix-bufferingpolicy-expected.txt: Added.
* LayoutTests/webaudio/audiomix-bufferingpolicy.html: Added.
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::recreateAudioMixIfNeeded):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setBufferingPolicy):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setMediaElementelementBufferingPolicy):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/278859@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87d9f2: AVVideoCaptureSource is slower due to resolution r...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87d9f26a3a2ea1b59dbbeef61603a21972757f76
  
https://github.com/WebKit/WebKit/commit/87d9f26a3a2ea1b59dbbeef61603a21972757f76
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  AVVideoCaptureSource is slower due to resolution reconfiguration happening 
when session is running
https://bugs.webkit.org/show_bug.cgi?id=274206
rdar://128113983

Reviewed by Eric Carlson.

Before https://commits.webkit.org/276773@main, we were configuring the session 
before running it.
This caused issues with torch, so we decided to configure once the session was 
running.
This is triggering a perf issue as configuring the resolution takes time, 0.5 
seconds on macOS.
To go back to a good start time, we partially revert 
https://commits.webkit.org/276773@main,
by configuring the resolution and frame rate before starting the session.
We continue to configure once the session is running for torch and white 
balance.

Manually tested.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSessionSizeFrameRateAndZoom):
(WebCore::AVVideoCaptureSource::reconfigureIfNeeded):

Canonical link: https://commits.webkit.org/278853@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db2778: Rename CoreAudioSharedInternalUnit::m_ioUnit to m_...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db277866eade69b4c06fcb17b61dc3aeb679cba9
  
https://github.com/WebKit/WebKit/commit/db277866eade69b4c06fcb17b61dc3aeb679cba9
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp

  Log Message:
  ---
  Rename CoreAudioSharedInternalUnit::m_ioUnit to m_audioUnit
https://bugs.webkit.org/show_bug.cgi?id=274200
rdar://128111716

Reviewed by Eric Carlson.

CoreAudioSharedInternalUnit::m_ioUnit is conflicting with 
CoreAudioSharedUnit:m_ioUnit which makes the code less easy to read/search.
Renaming CoreAudioSharedInternalUnit::m_ioUnit to 
CoreAudioSharedInternalUnit::m_audioUnit instead.

* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedInternalUnit::CoreAudioSharedInternalUnit):
(WebCore::CoreAudioSharedInternalUnit::~CoreAudioSharedInternalUnit):
(WebCore::CoreAudioSharedInternalUnit::initialize):
(WebCore::CoreAudioSharedInternalUnit::uninitialize):
(WebCore::CoreAudioSharedInternalUnit::start):
(WebCore::CoreAudioSharedInternalUnit::stop):
(WebCore::CoreAudioSharedInternalUnit::set):
(WebCore::CoreAudioSharedInternalUnit::get):
(WebCore::CoreAudioSharedInternalUnit::render):

Canonical link: https://commits.webkit.org/278852@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63db44: Do not delay getUserMedia promise resolution on VP...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63db44388a491904569503778ea0c7a18b55acb0
  
https://github.com/WebKit/WebKit/commit/63db44388a491904569503778ea0c7a18b55acb0
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

  Log Message:
  ---
  Do not delay getUserMedia promise resolution on VPIO unit prewarming
https://bugs.webkit.org/show_bug.cgi?id=274203
rdar://128112002

Reviewed by Eric Carlson.

Before this patch, we were delaying the resolution of the getUserMedia promise 
upon VPIO creation prewarming.
This was ensuring that there would be no freeze and audio capture would start 
right away.
But this delays the web page processing.

We are now doing the following when starting capture:
- Prewarm the VPIO unit when GPU process is instructed that it will start audio 
capture soon.
- Create sources in GPU process, do not wait for warming up to finish..
- Resolve getUserMedia promise.
- Start the sources. When starting microphone capture, complete the prewarming 
if needed before starting the VPIO unit.

This change allows the web page to manipulate the getUserMedia tracks sooner.
It can then use the tracks to set up a VC call for instance, in parallel to the 
prewarming of the VPIO unit.
We keep prewarming of the VPIO unit as fast as we can.

Manually tested on macOS, should be a no op on iOS.

* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:
(WebCore::BaseAudioSharedUnit::startProducingData):
(WebCore::BaseAudioSharedUnit::prepareForNewCapture):
* Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h:
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::whenReady): Deleted.
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::prewarmAudioUnitCreation):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

Canonical link: https://commits.webkit.org/278851@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a6b4a4: Reduce VPIO destruction timer delay to the delay a...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6b4a4b6fc0ee708c282a831b4f87a171c69063a
  
https://github.com/WebKit/WebKit/commit/a6b4a4b6fc0ee708c282a831b4f87a171c69063a
  Author: Youenn Fablet 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp

  Log Message:
  ---
  Reduce VPIO destruction timer delay to the delay applied to capture indicators
https://bugs.webkit.org/show_bug.cgi?id=274201
rdar://128111934

Reviewed by Eric Carlson.

We keep VPIO unit to reuse it in case page stops capture and restarts capture 
very quickly.
We do not need a long timer of 60 seconds, we reduce it to 3 seconds, which is 
the equivalent delay when capture indicator goes from live to not capturing.
This will further reduce the drawback of having an allocated but unused VPIO 
unit.

* Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedUnit::setStoredVPIOUnit):

Canonical link: https://commits.webkit.org/278850@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7bfec4: BlobStreamSource does not seem to enqueue aggressi...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bfec45dfb8bebb0915202c524fc5ee48efd4d93
  
https://github.com/WebKit/WebKit/commit/7bfec45dfb8bebb0915202c524fc5ee48efd4d93
  Author: Youenn Fablet 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/files/blob-stream-chunks-expected.txt
A LayoutTests/fast/files/blob-stream-chunks.html
M Source/WebCore/fileapi/Blob.cpp

  Log Message:
  ---
  BlobStreamSource does not seem to enqueue aggressively received buffers
rdar://127653288
https://bugs.webkit.org/show_bug.cgi?id=273813

Reviewed by Alex Christensen.

Instead of pushing data coming from blobs as array buffers on the internal 
ReadableStream queue,
we are now keeping the blob data within a queue owned by the source.
This reduces the need to convert blob data to JS objects to the time when web 
page actually needs it.

Skipping the test in debug as the test is timing out due to the created buffer 
size.

* LayoutTests/TestExpectations:
* LayoutTests/fast/files/blob-stream-chunks-expected.txt: Added.
* LayoutTests/fast/files/blob-stream-chunks.html: Added.
* Source/WebCore/fileapi/Blob.cpp:
(WebCore::Blob::stream):

Canonical link: https://commits.webkit.org/278693@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac508f: ExtendableMessageEvent.ports should return the sam...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac508ff120502d26793f9b60113f36baf69091db
  
https://github.com/WebKit/WebKit/commit/ac508ff120502d26793f9b60113f36baf69091db
  Author: Youenn Fablet 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports-worker.js
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https.html
M Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp
M Source/WebCore/workers/service/ExtendableMessageEvent.h
M Source/WebCore/workers/service/ExtendableMessageEvent.idl

  Log Message:
  ---
  ExtendableMessageEvent.ports should return the same object
https://bugs.webkit.org/show_bug.cgi?id=273542
rdar://127350353

Reviewed by Chris Dumez.

Reuse what was done for MessageEvent.ports in ExtendableMessageEvent.ports.
We use a JSValueInWrappedObject to store the JS ports object so that we always 
return the same JS object.

* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports-worker.js:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/message-event-ports.https.html:
 Added.
* Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:
(WebCore::JSExtendableMessageEvent::ports const):
(WebCore::JSExtendableMessageEvent::visitAdditionalChildren):
* Source/WebCore/workers/service/ExtendableMessageEvent.h:
* Source/WebCore/workers/service/ExtendableMessageEvent.idl:

Originally-landed-as: bb2720bcf112. 
https://bugs.webkit.org/show_bug.cgi?id=273542
Canonical link: https://commits.webkit.org/278690@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec6f4d: ScreenCaptureKitCaptureSource should not reconfigu...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec6f4da2341ed9b831b175e61003eafe53b10c92
  
https://github.com/WebKit/WebKit/commit/ec6f4da2341ed9b831b175e61003eafe53b10c92
  Author: Youenn Fablet 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  ScreenCaptureKitCaptureSource should not reconfigure if video effect is on 
but overlay rect is not filled
rdar://127882407
https://bugs.webkit.org/show_bug.cgi?id=274076

Reviewed by Eric Carlson and Jean-Yves Avenard.

In rdar://125925090, https://commits.webkit.org/278390@main, we started 
detecting presenter overlay mode by looking at 
SCStreamFrameInfoPresenterOverlayContentRect.
We were checking whether the origin was not (0, 0) and not (Inf, Inf).
(0, 0) is to ensure we are not in small overlay mode.
(Inf, Inf) was to ensure there was some overlay.

When starting large presenter overlay mode, (Inf, Inf) may be used for a couple 
of video frames, in particular when going from small to large overlay mode.
This triggered sometimes reconfiguration, which was further delaying a correct 
overlay, ending in a loop of reconfiguration.

To prevent this, we only allow reconfiguration when we are sure we are in small 
presenter overlay mode, thus origin is (0, 0).
We rename hasLargePresenterOverlay to shouldDisallowReconfiguration as this is 
more consistent.
Manually tested.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):

Canonical link: https://commits.webkit.org/278685@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e46ffa: ScreenCaptureKitCaptureSource::streamDidOutputVide...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e46ffa98cd5d3466abcf9621b01e1b712921ff48
  
https://github.com/WebKit/WebKit/commit/e46ffa98cd5d3466abcf9621b01e1b712921ff48
  Author: Youenn Fablet 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
M Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp
M Source/WebCore/platform/cocoa/CoreVideoSoftLink.h
M Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp
M Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h
M Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h
M Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer should crop 
video frames as needed
rdar://127598482
https://bugs.webkit.org/show_bug.cgi?id=273764

Reviewed by Jean-Yves Avenard.

ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer receives 
buffers with black stripes.
This happens in case of resizing or when large presenter overlay is enabled.
To fix this, we crop via ImageTransferSessionVT the pixel buffer to remove 
those black stripes.

We update ImageTransferSessionVT to allow setting a cropping rectangle.
We set kCVImageBufferCleanApertureKey on the source buffer before doing the 
transfer to the new buffer.

Manually tested by:
- Capture screen, capture camera and go to large presenter overlay
- Capture screen and resize captured window (w/o presenter overlay).

* Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp:
* Source/WebCore/platform/cocoa/CoreVideoSoftLink.h:
* Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp:
* Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h:
* Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h:
* Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::setCroppingRectangle):
(WebCore::ImageTransferSessionVT::convertPixelBuffer):
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):

Canonical link: https://commits.webkit.org/278475@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1fb6c8: [Cocoa] WebCodecs HEVC decoder is not always reord...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fb6c8c6fa42fb5a3168beff6b3e059cebc2f0fd
  
https://github.com/WebKit/WebKit/commit/1fb6c8c6fa42fb5a3168beff6b3e059cebc2f0fd
  Author: Youenn Fablet 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
A 
LayoutTests/http/tests/webcodecs/hevc-reordering-array-completeness-expected.txt
A LayoutTests/http/tests/webcodecs/hevc-reordering-array-completeness.html
A 
LayoutTests/media/media-source/content/test-bframes-hevc-array-completeness.mp4
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm

  Log Message:
  ---
  [Cocoa] WebCodecs HEVC decoder is not always reordering frames according 
presentation time
rdar://12769
https://bugs.webkit.org/show_bug.cgi?id=270645

Reviewed by Eric Carlson.

We were not computing correctly the nal unit type in case array_completeness is 
set to 1.
We fix this by masking with 0x3F to also make sure to not be disturbed by the 
reserved bit after array_completness.
We copy test-bframes-hevc.mp4 to test-bframes-hevc-array-completeness.mp4 and 
update the array_completness bit to 1 there.

* 
LayoutTests/http/tests/webcodecs/hevc-reordering-array-completeness-expected.txt:
 Added.
* LayoutTests/http/tests/webcodecs/hevc-reordering-array-completeness.html: 
Added.
* 
LayoutTests/media/media-source/content/test-bframes-hevc-array-completeness.mp4:
 Added.
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm:
(vpsDataFromHvcc):

Canonical link: https://commits.webkit.org/278462@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 060839: NotReadableError: The I/O read operation failed fo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0608392ae72e8a6c652e8cd407d0cceade20e3c2
  
https://github.com/WebKit/WebKit/commit/0608392ae72e8a6c652e8cd407d0cceade20e3c2
  Author: Youenn Fablet 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
M Source/WebCore/fileapi/FileReaderLoader.cpp
M Source/WebCore/fileapi/FileReaderLoader.h

  Log Message:
  ---
  NotReadableError: The I/O read operation failed for large files of size 4G+
https://bugs.webkit.org/show_bug.cgi?id=272600
rdar://126863800

Reviewed by Alex Christensen.

FileReaderLoader is limiting the size of data that can be read.
This restriction is not needed when reading data via a ReadableStream.
We stop allocating a buffer in FileReaderLoader for 
ReadType::ReadAsBinaryChunks as this is unnecessary.
Instead, we let the client store the buffers.

Manually tested for big files.

* Source/WebCore/fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveResponse):
* Source/WebCore/fileapi/FileReaderLoader.h:

Canonical link: https://commits.webkit.org/278457@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bbf537: WebCodecsVideoFrame::create from another WebCodecs...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbf537ea1dbb7e545f33b2cea59f304fff963016
  
https://github.com/WebKit/WebKit/commit/bbf537ea1dbb7e545f33b2cea59f304fff963016
  Author: Youenn Fablet 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
A LayoutTests/http/wpt/webcodecs/videoFrame-clone-timestamp-expected.txt
A LayoutTests/http/wpt/webcodecs/videoFrame-clone-timestamp.html
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp

  Log Message:
  ---
  WebCodecsVideoFrame::create from another WebCodecsVideoFrame is not correct 
with regards to timestamp
rdar://127474678
https://bugs.webkit.org/show_bug.cgi?id=273775

Reviewed by Jean-Yves Avenard.

Make sure to clone in case of a different timestamp to keep WebCodecsVideoFrame 
and VideoFrame timestamps the same.

* LayoutTests/http/wpt/webcodecs/videoFrame-clone-timestamp-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/videoFrame-clone-timestamp.html: Added.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::WebCodecsVideoFrame::create):

Canonical link: https://commits.webkit.org/278454@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a2c5a: Timing-Allow-Origin works with 302

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a2c5a3042534caf2df6952d1d7d151d3e3c76bc
  
https://github.com/WebKit/WebKit/commit/6a2c5a3042534caf2df6952d1d7d151d3e3c76bc
  Author: Youenn Fablet 
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
M LayoutTests/http/wpt/resource-timing/resources/rt-utilities.sub.js
A LayoutTests/http/wpt/resource-timing/rt-cors-2-expected.txt
A LayoutTests/http/wpt/resource-timing/rt-cors-2.html
A LayoutTests/http/wpt/resource-timing/rt-cors-2.js
M Source/WebKit/NetworkProcess/NetworkDataTask.h
M Source/WebKit/NetworkProcess/NetworkLoad.cpp
M Source/WebKit/NetworkProcess/NetworkLoad.h
M Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
M Source/WebKit/NetworkProcess/NetworkLoadChecker.h
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h
M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h

  Log Message:
  ---
  Timing-Allow-Origin works with 302
https://bugs.webkit.org/show_bug.cgi?id=272682
rdar://126531139

Reviewed by Alex Christensen.

We move the TAO check from platform specific NetworkDataTask implementations to 
NetworkLoadChecker.
This allows us to implement the algorithm as defined in fetch, including 
checking the response tainting.
This aligns behavior with Chrome and Firefox.
For top level navigation, we were using the source origin, but we should use 
the top origin for top level navigations,
as top level navigations are same origin.

* LayoutTests/http/wpt/resource-timing/resources/rt-utilities.sub.js:
(addACAOHeader):
* LayoutTests/http/wpt/resource-timing/rt-cors-2-expected.txt: Added.
* LayoutTests/http/wpt/resource-timing/rt-cors-2.html: Added.
* LayoutTests/http/wpt/resource-timing/rt-cors-2.js: Added.
(assertAlways):
(assertRedirectWithDisallowedTimingData):
(assertDisallowedTimingData):
(promise_test):
* Source/WebKit/NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::setTimingAllowFailedFlag):
* Source/WebKit/NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::setTimingAllowFailedFlag):
* Source/WebKit/NetworkProcess/NetworkLoad.h:
* Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::validateResponse):
(WebKit::NetworkLoadChecker::checkTAO):
* Source/WebKit/NetworkProcess/NetworkLoadChecker.h:
(WebKit::NetworkLoadChecker::timingAllowFailedFlag const):
(WebKit::NetworkLoadChecker::isSameOriginRequest const):
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::willSendRedirectedRequestInternal):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::setTimingAllowFailedFlag):
(WebKit::NetworkDataTaskCocoa::checkTAO): Deleted.
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate 
URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate 
URLSession:dataTask:didReceiveResponse:completionHandler:]):
* Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::updateNetworkLoadMetrics):
(WebKit::NetworkDataTaskCurl::setTimingAllowFailedFlag):
* Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h:
* Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::setTimingAllowFailedFlag):
* Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h:

Canonical link: https://commits.webkit.org/278448@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fddda8: messageerror event doesn't fire on ServiceWorkerGl...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fddda893fc92edb8d258d2b12b126db11c3ba264
  
https://github.com/WebKit/WebKit/commit/fddda893fc92edb8d258d2b12b126db11c3ba264
  Author: Youenn Fablet 
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event-worker.js
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event.https.html
M 
LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/window-serviceworker-failure.https-expected.txt
M Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp
M Source/WebCore/workers/service/ExtendableMessageEvent.cpp
M Source/WebCore/workers/service/ExtendableMessageEvent.h
M Source/WebCore/workers/service/ExtendableMessageEvent.idl
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp

  Log Message:
  ---
  messageerror event doesn't fire on ServiceWorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=272967
rdar://127104436

Reviewed by Chris Dumez.

Like for messages on worker, we now deserialize the data just before firing the 
event.
If deserialization fails, we use messageerror event, other wise we keep using 
message event.

We update ExtendableMessageEvent to use a JSValueInWrappedObject instead of a 
SerializedScriptValue.
This allows to store a JSValue, which also simplifies the custom binding.

We reuse the same principle for the JS constructor.
We continue using the custom constructor as we create the JS wrapper in 
ExtendableMessageEvent::create.

* 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event-worker.js:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/error-message-event.https.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/window-serviceworker-failure.https-expected.txt:
* Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:
(WebCore::constructJSExtendableMessageEvent):
(WebCore::JSExtendableMessageEvent::visitAdditionalChildren):
(WebCore::JSExtendableMessageEvent::data const): Deleted.
* Source/WebCore/workers/service/ExtendableMessageEvent.cpp:
(WebCore::createWrapperAndSetData):
(WebCore::ExtendableMessageEvent::create):
(WebCore::ExtendableMessageEvent::ExtendableMessageEvent):
* Source/WebCore/workers/service/ExtendableMessageEvent.h:
* Source/WebCore/workers/service/ExtendableMessageEvent.idl:
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::fireMessageEvent):

Canonical link: https://commits.webkit.org/278408@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 85f983: NUL bytes in header values allowed for fetch-API

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85f98322e6a68f91eff9a5c02bce5d9ea908bb84
  
https://github.com/WebKit/WebKit/commit/85f98322e6a68f91eff9a5c02bce5d9ea908bb84
  Author: Youenn Fablet 
  Date:   2024-05-05 (Sun, 05 May 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/resources/cookie-test.js
M 
LayoutTests/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fetch/h1-parsing/resources-with-0x00-in-header.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/fetch/h1-parsing/resources-with-0x00-in-header.window.js
M 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt
R 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt
R 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/loader/SubresourceLoader.cpp
M Source/WebCore/platform/network/ResourceErrorBase.cpp
M Source/WebCore/platform/network/ResourceErrorBase.h
M Source/WebCore/platform/network/ResourceResponseBase.h
M Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp

  Log Message:
  ---
  NUL bytes in header values allowed for fetch-API
https://bugs.webkit.org/show_bug.cgi?id=272740
rdar://126913166

Reviewed by Chris Dumez and Alex Christensen.

In no-cors mode, we are filtering responses before sending them to web process.
This can remove NUL header values.
We add a check in NetworkLoadChecker for NUL header values and fail the load as 
done in web pProcess.
We introduce a badResponseHeadersError routine to share more code between web 
process and network process.

We add a test in 
LayoutTests/imported/w3c/web-platform-tests/fetch/h1-parsing/resources-with-0x00-in-header.window.js
 to cover the change.
We have to update 
LayoutTests/imported/w3c/web-platform-tests/cookies/resources/cookie-test.js to 
make sure cookie removal is done one at a time since our test runner has this 
constraint.

* 
LayoutTests/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/cookies/resources/cookie-test.js:
* 
LayoutTests/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fetch/h1-parsing/resources-with-0x00-in-header.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/fetch/h1-parsing/resources-with-0x00-in-header.window.js:
(promise_test.async t):
* 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt:
 Removed.
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt:
 Removed.
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
* Source/WebCore/platform/network/ResourceErrorBase.cpp:
(WebCore::badResponseHeadersError):
* Source/WebCore/platform/network/ResourceErrorBase.h:
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::validateResponse):

Canonical link: https://commits.webkit.org/278389@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bbca2d: Update webrtc build and code to prepare for tvOS

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbca2d7c1fe0a5db650202e53d2f4bbef81cc28a
  
https://github.com/WebKit/WebKit/commit/bbca2d7c1fe0a5db650202e53d2f4bbef81cc28a
  Author: Youenn Fablet 
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-monterey-wk2/TestExpectations
M Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig
M Source/WebCore/platform/VideoDecoder.cpp
M Source/WebCore/platform/VideoEncoder.cpp
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.h
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp
M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp
M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h

  Log Message:
  ---
  Update webrtc build and code to prepare for tvOS
rdar://126747824
https://bugs.webkit.org/show_bug.cgi?id=272974

Reviewed by Andy Estes and Elliott Williams.

Compile out some libwebrtc code in case AV1 is not supported, as is the case in 
tvOS, where dav1d is not needed.
Ditto for some WEB_CODECS code specific code.
Update xcconfig files for tvOS.

* LayoutTests/platform/mac-monterey-wk2/TestExpectations: Skipping AV1 tests as 
ENABLE(AV1) is not 1 in Monterey.
* Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
* Source/WebCore/platform/VideoDecoder.cpp:
(WebCore::VideoDecoder::createLocalDecoder):
* Source/WebCore/platform/VideoEncoder.cpp:
(WebCore::VideoEncoder::createLocalEncoder):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp:
(WebCore::createInternalDecoder):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.h:
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp:
(WebCore::createInternalEncoder):
(WebCore::LibWebRTCVPXInternalVideoEncoder::initialize):
* Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp:
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::setEncodingConfiguration):
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h:

Canonical link: https://commits.webkit.org/278103@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes