[webkit-changes] [WebKit/WebKit] 3f7c48: Remove a MSVC workaround in JSC::Heap::addCoreCons...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f7c488869b5fd3182ec543a20b831a6969196b4
  
https://github.com/WebKit/WebKit/commit/3f7c488869b5fd3182ec543a20b831a6969196b4
  Author: Fujii Hironori 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/heap/Heap.cpp

  Log Message:
  ---
  Remove a MSVC workaround in JSC::Heap::addCoreConstraints
https://bugs.webkit.org/show_bug.cgi?id=276514

Reviewed by Ross Kirsling.

https://commits.webkit.org/234335@main added a MSVC workaround in
JSC::Heap::addCoreConstraints. MSVC is no longer supported.

* Source/JavaScriptCore/heap/Heap.cpp:

Canonical link: https://commits.webkit.org/280885@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e92596: Simplify length comparison by using `isAuto()` dir...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e92596580f72e6f6fdf0551a898661946cc66e73
  
https://github.com/WebKit/WebKit/commit/e92596580f72e6f6fdf0551a898661946cc66e73
  Author: Ahmad Saleem 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/rendering/FixedTableLayout.cpp

  Log Message:
  ---
  Simplify length comparison by using `isAuto()` directly

https://bugs.webkit.org/show_bug.cgi?id=276507

Reviewed by Alan Baradlay.

This patch is to simplify length comparison by directly using
`isAuto()` rather than `!= LengthType::Auto`.

* Source/WebCore/rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):

Canonical link: https://commits.webkit.org/280884@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e96ff3: webkitpy: Remove common/config/ews.json

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e96ff3e1860da218932e659fcf71a5ca5540f19c
  
https://github.com/WebKit/WebKit/commit/e96ff3e1860da218932e659fcf71a5ca5540f19c
  Author: Fujii Hironori 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
R Tools/Scripts/webkitpy/common/config/ews.json

  Log Message:
  ---
  webkitpy: Remove common/config/ews.json
https://bugs.webkit.org/show_bug.cgi?id=276458

Reviewed by Ross Kirsling.

ews.json was for the old EWS. It was no longer used.

* Tools/Scripts/webkitpy/common/config/ews.json: Removed.

Canonical link: https://commits.webkit.org/280883@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 07a6a9: REGRESSION (280643@main): [ macOS Sonoma iOS wk2] ...

[Anfernee V]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07a6a9bd283fd7041d10be19549d5913591d717f
  
https://github.com/WebKit/WebKit/commit/07a6a9bd283fd7041d10be19549d5913591d717f
  Author: Anfernee Viduya 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
A LayoutTests/platform/ios/compositing/video/video-object-fit-expected.txt
A LayoutTests/platform/mac-sonoma-wk1/video/video-object-fit-expected.txt
A 
LayoutTests/platform/mac-sonoma-wk1/video/video-object-position-expected.txt
A 
LayoutTests/platform/mac-ventura-wk2/compositing/video/video-object-position-expected.txt

  Log Message:
  ---
  REGRESSION (280643@main): [ macOS Sonoma iOS wk2] 2x 
compositing/video/video-object-* are constantly failing.
rdar://131182735
https://bugs.webkit.org/show_bug.cgi?id=276260

Unreviewed test re-baseline.

Last re-baseline attempt caused other test queues to fail while resolved 
original issues. This should fix issues with the other test queues.

* LayoutTests/platform/ios/compositing/video/video-object-fit-expected.txt: 
Added.
* LayoutTests/platform/mac-sonoma-wk1/video/video-object-fit-expected.txt: 
Added.
* LayoutTests/platform/mac-sonoma-wk1/video/video-object-position-expected.txt: 
Added.
* 
LayoutTests/platform/mac-ventura-wk2/compositing/video/video-object-position-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/280882@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 99cb6b: results.html generates wrong links for test names ...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99cb6b1f2f9e2885a54a5ade9b5d0a3073f5e398
  
https://github.com/WebKit/WebKit/commit/99cb6b1f2f9e2885a54a5ade9b5d0a3073f5e398
  Author: Sam Sneddon 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/fast/harness/results.html
M 
Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

  Log Message:
  ---
  results.html generates wrong links for test names include percent
https://bugs.webkit.org/show_bug.cgi?id=276506
rdar://131409141

Reviewed by Tim Nguyen.

* LayoutTests/fast/harness/results.html: Add a singular encodeURI call to go 
from a path to URL.
* 
Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_expected_filename): Add some more tests about what 
expected names actually are.

Canonical link: https://commits.webkit.org/280881@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2124f5: Remove `other` from 'SFrameTransformErrorEventType...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2124f58f2daec34666ef4d615789384f47576c90
  
https://github.com/WebKit/WebKit/commit/2124f58f2daec34666ef4d615789384f47576c90
  Author: Ahmad Saleem 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.h
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl

  Log Message:
  ---
  Remove `other` from 'SFrameTransformErrorEventType' interface as per web 
specification

https://bugs.webkit.org/show_bug.cgi?id=276297

Reviewed by Brent Fulgham.

This patch aligns WebKit with Web Specification [1]:

[1] 
https://w3c.github.io/webrtc-encoded-transform/#enumdef-sframetransformerroreventtype

As per web specification, the 'SFrameTransformErrorEventType' enum
does not have 'other', so this patch removes it.

* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:
(WebCore::errorTypeFromInformation):
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.h:
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:

Canonical link: https://commits.webkit.org/280880@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c29e6: [Remote Inspection] `elementAndAncestorsAreOnlyRen...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c29e60b7f0a3238a625297d8c6a6c6b57ec1bb7
  
https://github.com/WebKit/WebKit/commit/0c29e60b7f0a3238a625297d8c6a6c6b57ec1bb7
  Author: Wenson Hsieh 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
A 
LayoutTests/fast/element-targeting/target-container-with-anonymous-sibling-expected.txt
A 
LayoutTests/fast/element-targeting/target-container-with-anonymous-sibling.html
M LayoutTests/resources/ui-helper.js
M Source/WebCore/page/ElementTargetingController.cpp

  Log Message:
  ---
  [Remote Inspection] `elementAndAncestorsAreOnlyRenderedChildren` sometimes 
yields false positives
https://bugs.webkit.org/show_bug.cgi?id=276503
rdar://131535241

Reviewed by Megan Gardner and Abrar Rahman Protyasha.

`elementAndAncestorsAreOnlyRenderedChildren` is currently incorrect in the case 
where a parent
renderer has anonymous renderers as children, for which `element()` is null. 
This causes us to
(falsely) assume that certain elements are only children in the render tree 
(along with all of their
ancestors), and avoid surfacing them as target candidates.

Fix this by refactoring the function, such that it doesn't ignore anonymous 
renderers.

* 
LayoutTests/fast/element-targeting/target-container-with-anonymous-sibling-expected.txt:
 Added.
* 
LayoutTests/fast/element-targeting/target-container-with-anonymous-sibling.html:
 Added.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.adjustVisibilityForFrontmostTarget):
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::elementAndAncestorsAreOnlyRenderedChildren):

Canonical link: https://commits.webkit.org/280879@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b4dbf7: Remove unnecessary trailing semicolons

[Andrew-Fryer]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4dbf7a9e46007ef1db2d1ae69cc3b428ef2dd25
  
https://github.com/WebKit/WebKit/commit/b4dbf7a9e46007ef1db2d1ae69cc3b428ef2dd25
  Author: Andrew Fryer 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/css/SelectorChecker.cpp
M Source/WebCore/platform/ScrollView.h

  Log Message:
  ---
  Remove unnecessary trailing semicolons
https://bugs.webkit.org/show_bug.cgi?id=247694
rdar://102434342

Reviewed by Tim Nguyen.

remove unecessary semicolons after closing brace

* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
* Source/WebCore/platform/ScrollView.h:
(WebCore::ScrollView::setVerticalScrollbarMode):

Canonical link: https://commits.webkit.org/280878@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f4a28d: [WTF] Define _STRINGIFY in all cases

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4a28dad0dbe15ca4eeb7c058d7ee547fe21945a
  
https://github.com/WebKit/WebKit/commit/f4a28dad0dbe15ca4eeb7c058d7ee547fe21945a
  Author: Dennis Camera 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WTF/wtf/Assertions.h

  Log Message:
  ---
  [WTF] Define _STRINGIFY in all cases
https://bugs.webkit.org/show_bug.cgi?id=276440

Reviewed by Fujii Hironori.

The _STRINGIFY macro is also used by ETFEmitSignpost() when
JOURNALD_LOG is not enabled.

* Source/WTF/wtf/Assertions.h: move _STRINGIFY out of #elif ENABLE(JOURNALD_LOG)

Canonical link: https://commits.webkit.org/280877@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d08faf: REGRESSION (276531@main): Content flash when expan...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d08faf9fab62fcbe230979774bacbdc53684e816
  
https://github.com/WebKit/WebKit/commit/d08faf9fab62fcbe230979774bacbdc53684e816
  Author: Antoine Quint 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-prevents-starting-in-subtree-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-prevents-starting-in-subtree.html
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/style/Styleable.h

  Log Message:
  ---
  REGRESSION (276531@main): Content flash when expanding image viewer on eBay 
page
https://bugs.webkit.org/show_bug.cgi?id=275739
rdar://128178476

Reviewed by Alan Baradlay.

Listings on eBay can display a photo gallery which is contained within a 
subtree where
the `hidden` presentation attribute is toggled to show and hide the gallery. 
The `hidden`
attribute really governs whether `display: none` is applied. In that subtree, a 
forwards-filling
`opacity` CSS Animation is applied.

Prior to `276531@main`, when `Style::TreeResolver::resolveElement()` would be 
called under
`Style::TreeResolver::resolveComposedTree()` for an element with `display: 
none`, an empty
`ElementUpdate` would be returned and `resolveComposedTree()` would not process 
its children.

In `276531@main`, we modified `resolveElement()` such that this behavior would 
not only apply
to elements with a newly-set `display: none` style associated with them, 
excluding those with
a cached `display: none` style. This was done in the static function 
`affectsRenderedSubtree()`.

This meant that now, if an element within a `display: none` subtree had its 
style modified,
`resolveElement()` would be called for that entire subtree when it previously 
wouldn't have.
As a result, `createAnimatedElementUpdate()` would now be called and since this 
method had
only ever been called for elements not contained within a `display: none` 
subtree, it would
not consider that possibility and start CSS Animations in that subtree.

This is what caused the eBay regression because the forwards-filling animation 
meant to fade
the photo gallery in would be reapplied soon after the photo gallery was hidden 
after an
additional style update, and when that photo gallery would become visible 
again, the animation
was already in effect and the gallery did not have the expected computed 
`opacity` value.

To fix this, we capture a new `isInDisplayNoneTree` state on the `Parent` 
objects created as
we iterate through the composed tree in `resolveComposedTree()`. That new 
member identifies
whether that element or a parent has `display: none` set on it. Now we can pass 
that state
down to `createAnimatedElementUpdate()` and ultimately to 
`Styleable::updateCSSAnimations()`
and ultimately neglect to start new CSS Animations when the element in question 
is contained
within a `display: none` subtree.

We also removed the `affectsRenderedSubtree()` changed introduced in 
`276531@main` which simply
did not make much sense, and to ensure that elements with `display: none` that 
had their style
updated correctly updated their cached `display: none` style, we now return a 
non-empty
`ElementUpdate` and add that `ElementUpdate` to `m_update` in 
`resolveComposedTree()`.

Finally, we add a new WPT test that reduces the eBay behavior.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-prevents-starting-in-subtree-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-prevents-starting-in-subtree.html:
 Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::Parent::Parent):
(WebCore::Style::affectsRenderedSubtree):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::pushParent):
(WebCore::Style::TreeResolver::resolveComposedTree):
* Source/WebCore/style/StyleTreeResolver.h:
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::updateCSSAnimations const):
* Source/WebCore/style/Styleable.h:

Canonical link: https://commits.webkit.org/280876@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c8fc8c: [webkitpy] Remove WinCairoPort class, --platform=w...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8fc8c9e214ac645769900a3f1315b3c9976cd34
  
https://github.com/WebKit/WebKit/commit/c8fc8c9e214ac645769900a3f1315b3c9976cd34
  Author: Fujii Hironori 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/port/factory.py
M Tools/Scripts/webkitpy/port/factory_unittest.py
M Tools/Scripts/webkitpy/port/win.py
M Tools/Scripts/webkitpy/port/win_unittest.py

  Log Message:
  ---
  [webkitpy] Remove WinCairoPort class, --platform=wincairo should be an alias 
of --platform=win
https://bugs.webkit.org/show_bug.cgi?id=276469

Reviewed by Don Olmstead.

For renaming wincairo port to win port, all scripts should accept both
--platform=win and --platform=wincairo during the transition period.
This change modified webkitpy as the first step.

Other scripts also need changes. And, LayoutTests/platform/wincairo
directory should be renamed to LayoutTests/platform/win.

* Tools/Scripts/webkitdirs.pm:
(determinePortName):
* Tools/Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.all_port_names):
* Tools/Scripts/webkitpy/port/factory_unittest.py:
(FactoryTest.test_win):
(FactoryTest):
(FactoryTest.test_wincairo):
* Tools/Scripts/webkitpy/port/win.py:
(WinPort._search_paths):
(WinPort.configuration_for_upload):
* Tools/Scripts/webkitpy/port/win_unittest.py:
(WinPortTest):
(WinPortTest.test_baseline_search_path):
(WinPortTest._assert_version):

Canonical link: https://commits.webkit.org/280875@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69f43e: Crash in WebKit::RemoteLayerBackingStore::needsDis...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69f43e22401674b905bb6762846ce2f1814146be
  
https://github.com/WebKit/WebKit/commit/69f43e22401674b905bb6762846ce2f1814146be
  Author: Matt Woodrow 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm

  Log Message:
  ---
  Crash in WebKit::RemoteLayerBackingStore::needsDisplay due to owner() being 
null.
https://bugs.webkit.org/show_bug.cgi?id=276352


Reviewed by Dan Glastonbury.

When a layer subtree has rendering suppression, we just want add its backing 
store
to m_reachableBackingStoreInLatestFlush to stop it from being purged.

It is entirely possible for the owner() (the GraphicsLayer) to have gone away, 
and
we want to continue to display the old content until suppression ends.

The existing code for 
RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayed
checked for invalidation via needsDisplay(), which then crashed if the owner 
had gone
away.

This adds a new alternative that doesn't check for invalidation, with very 
explicit
rendering suppression naming.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::layerWillBeDisplayedWithRenderingSuppression):
(WebKit::RemoteLayerBackingStore::needsDisplay const):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayedWithRenderingSuppression):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm:
(WebKit::PlatformCALayerRemote::recursiveMarkWillBeDisplayedWithRenderingSuppresion):
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::recursiveMarkWillBeDisplayed): Deleted.

Canonical link: https://commits.webkit.org/280874@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 306889: YouTube: Unable to move the volume slider by dragg...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 306889650017bc78e563434ff46d5a2567735c8a
  
https://github.com/WebKit/WebKit/commit/306889650017bc78e563434ff46d5a2567735c8a
  Author: Dana Estra 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  ---
  YouTube: Unable to move the volume slider by dragging after disabling Video 
Viewer
https://bugs.webkit.org/show_bug.cgi?id=276496
rdar://128587639

Reviewed by Eric Carlson.

When entering fullscreen, we add a dragstart event listener to the window that 
we never remove.
This makes it so that after we have exited fullscreen, the dragstart event 
listener is still
active, and it has a side effect of making the elements on the page to be 
draggable. This is
noticeable when the user is moving youtube's volume slider. Instead of this 
moving the knob on
the slider, this drags an image of the slider.

To fix this, we should remove the dragstart event listener on the window when 
we exit fullscreen.
This will remove the event listener's side effect that is causing this bug.

* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.disable):
(MediaControls):
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):

Canonical link: https://commits.webkit.org/280873@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 42d626: ImageQualityController thrashes a timer

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42d62602b5645e08527e41e02f7752c3c73aa373
  
https://github.com/WebKit/WebKit/commit/42d62602b5645e08527e41e02f7752c3c73aa373
  Author: Simon Fraser 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/rendering/ImageQualityController.cpp
M Source/WebCore/rendering/ImageQualityController.h

  Log Message:
  ---
  ImageQualityController thrashes a timer
https://bugs.webkit.org/show_bug.cgi?id=276347
rdar://131352675

Reviewed by Tim Horton.

For content with lots of images, 
`ImageQualityController::chooseInterpolationQuality()` is called each time
an image paints and potentially restarts a timer. Use a DeferrableOneShotTimer 
instead, which is designed
for this kind of use case.

Also do some other minor optimizations; only call 
`context.getCTM().isIdentityOrTranslationOrFlipped()` if we need to,
and only set a new value in the hash tables if the size changed.

* Source/WebCore/rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::restartTimer):
* Source/WebCore/rendering/ImageQualityController.h:

Canonical link: https://commits.webkit.org/280872@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1be557: [ Gardening ] REGRESSION(https://commits.webkit.or...

[Dawn Morningstar]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1be5578a5695d69acba1282cff2c89ef539ca9d2
  
https://github.com/WebKit/WebKit/commit/1be5578a5695d69acba1282cff2c89ef539ca9d2
  Author: Dawn Morningstar 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [ Gardening ] REGRESSION(https://commits.webkit.org/280643@main): [ iOS EWS ] 
11x media* (layout-tests) are constant/flaky failures
https://bugs.webkit.org/show_bug.cgi?id=276499
rdar://131558048

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/280871@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19ad27: WritingTools tests are failing/crashing on mac deb...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19ad276d70970698f0dcfcf1bbec8d65ff8b59af
  
https://github.com/WebKit/WebKit/commit/19ad276d70970698f0dcfcf1bbec8d65ff8b59af
  Author: Megan Gardner 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  ---
  WritingTools tests are failing/crashing on mac debug builds.
https://bugs.webkit.org/show_bug.cgi?id=276405
rdar://131429390

Reviewed by Richard Robinson.

We need to wait a bit longer than a presentation update to let the animations
run long enough for the test to be replaced, so that the next call is
operating on the correct ranges.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, ProofreadingWithStreamingSuggestions)):
(TEST(WritingTools, ProofreadingWithAttemptedEditing)):
(TEST(WritingTools, CompositionWithAttemptedEditing)):
(TEST(WritingTools, CompositionWithUndoAfterEnding)):
(TEST(WritingTools, CompositionWithUndo)):
(TEST(WritingTools, CompositionWithMultipleUndosAndRestarts)):
(TEST(WritingTools, CompositionWithUndoAndRestart)):
(TEST(WritingTools, CompositionWithAttributedStringAttributes)):
(TEST(WritingTools, CompositionWithImageRoundTrip)):
(TEST(WritingTools, CompositionWithNonImageAttachmentRoundTrip)):
(TEST(WritingTools, CompositionWithSystemFont)):
(TEST(WritingTools, CompositionWithMultipleChunks)):
(TEST(WritingTools, CompositionWithTrailingNewlines)):
(TEST(WritingTools, CompositionWithTrailingBreaks)):
(TEST(WritingTools, SmartRepliesMatchStyle)):
(TEST(WritingTools, ContextRangeFromCaretSelection)):
(TEST(WritingTools, ContextRangeFromRangeSelection)):
(TEST(WritingTools, SuggestedTextIsSelectedAfterSmartReply)):

Canonical link: https://commits.webkit.org/280870@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b9a63: [ews] Add validation to prevent SDK or OS version ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b9a637b40a0096c88677a48b105ac608aac3d97
  
https://github.com/WebKit/WebKit/commit/4b9a637b40a0096c88677a48b105ac608aac3d97
  Author: Aakash Jain 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add validation to prevent SDK or OS version mismatch between 
corresponding builds on tester and builder queues
https://bugs.webkit.org/show_bug.cgi?id=276379

Unreviewed follow-up fix. Remove debugging code.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):

Canonical link: https://commits.webkit.org/280869@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7aa271: Add my GitHub name (aviduya) to contributors.json

[Anfernee V]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aa271ba2ef2dec594e58965eca4048ba2d61347
  
https://github.com/WebKit/WebKit/commit/7aa271ba2ef2dec594e58965eca4048ba2d61347
  Author: Anfernee Viduya 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add my GitHub name (aviduya) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=276493
rdar://131549090

Reviewed by Ryan Haddad.

Adding my name to contributors.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/280868@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 150fb3: Lower rotations in B3LowerInt64.cpp

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 150fb392dc81ea95c919164e42825cd65a049964
  
https://github.com/WebKit/WebKit/commit/150fb392dc81ea95c919164e42825cd65a049964
  Author: Angelos Oikonomopoulos 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/b3/B3LowerInt64.cpp

  Log Message:
  ---
  Lower rotations in B3LowerInt64.cpp
https://bugs.webkit.org/show_bug.cgi?id=276487

Reviewed by Justin Michaud.

Implement RotR/RotL on Int64s using Int32 shifts, similar to how we
handle shifts.

* Source/JavaScriptCore/b3/B3LowerInt64.cpp:

Canonical link: https://commits.webkit.org/280867@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0947bc: More WebAuthn feature flag cleanup

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0947bca58fdb441e0b10287815920c570b65bb61
  
https://github.com/WebKit/WebKit/commit/0947bca58fdb441e0b10287815920c570b65bb61
  Author: Garrett Davidson 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp
M 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  ---
  More WebAuthn feature flag cleanup
https://bugs.webkit.org/show_bug.cgi?id=275269
rdar://127761460

Reviewed by Wenson Hsieh.

Continue cleaning up WebAuthn feature flags to ensure consistency between the 
old and new flags.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
* 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
* Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:

Canonical link: https://commits.webkit.org/280866@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 862cea: [JSC] Materialize JITData register in DFG

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 862ceab95094435cebe11828c7ba2a2d33422d89
  
https://github.com/WebKit/WebKit/commit/862ceab95094435cebe11828c7ba2a2d33422d89
  Author: Yusuke Suzuki 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
M Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/jit/JIT.cpp
M Source/JavaScriptCore/jit/JIT.h
M Source/JavaScriptCore/jit/JITInlines.h
M Source/JavaScriptCore/jit/JITOpcodes.cpp
M Source/JavaScriptCore/jit/JITPropertyAccess.cpp

  Log Message:
  ---
  [JSC] Materialize JITData register in DFG
https://bugs.webkit.org/show_bug.cgi?id=276474
rdar://131519305

Reviewed by Yijia Huang.

This patch adds code materializing JITData register in DFG regardless of 
whether DFG is unlinked or not.
So Handler IC code can use JITData register in DFG too.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::resetBaselineJITData):
* Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):
* Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
* Source/JavaScriptCore/jit/JIT.cpp:
(JSC::JIT::emitMaterializeMetadataAndConstantPoolRegisters):
(JSC::JIT::consistencyCheckGenerator):
* Source/JavaScriptCore/jit/JIT.h:
* Source/JavaScriptCore/jit/JITInlines.h:
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::loadPtrFromMetadata):
(JSC::JIT::load32FromMetadata):
(JSC::JIT::load8FromMetadata):
(JSC::JIT::store8ToMetadata):
(JSC::JIT::store32ToMetadata):
(JSC::JIT::materializePointerIntoMetadata):
(JSC::JIT::loadConstant):
(JSC::JIT::loadGlobalObject):
(JSC::JIT::loadStructureStubInfo):
* Source/JavaScriptCore/jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* Source/JavaScriptCore/jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):

Canonical link: https://commits.webkit.org/280865@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 414c1f: [Cocoa] Default subtitle font is wrong (serif vs. ...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 414c1f8ec90f29e67980711d76f99522ddd5ea3a
  
https://github.com/WebKit/WebKit/commit/414c1f8ec90f29e67980711d76f99522ddd5ea3a
  Author: Jer Noble 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp

  Log Message:
  ---
  [Cocoa] Default subtitle font is wrong (serif vs. sans-serif)
https://bugs.webkit.org/show_bug.cgi?id=276449
rdar://126094074

Reviewed by Eric Carlson.

MediaAccessibility will vend a CTFontDescription whose font name is non-public 
(starting with a "."). In this case,
convert the font name to either "system-ui" or "system-ui-monospaced" depending 
on the non-public font name.

* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS const):

Canonical link: https://commits.webkit.org/280864@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7aac03: H265 WebRTC negotiation sometimes fails

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aac03437a367d8e7b059235ea0e734d041534ba
  
https://github.com/WebKit/WebKit/commit/7aac03437a367d8e7b059235ea0e734d041534ba
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h265_profile_tier_level.cc

  Log Message:
  ---
  H265 WebRTC negotiation sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=276369
rdar://131388275

Reviewed by Eric Carlson.

After the resync to M126, libwebrtc is now matching HEVC codec profiles.
We revert to the past behavior by disabling the precise checks if one of the 
codec has no parameter.
https://bugs.webkit.org/show_bug.cgi?id=276486 will handle the population of 
the decoder/encoder factories to handle the proper negotiation.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h265_profile_tier_level.cc:

Canonical link: https://commits.webkit.org/280863@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d87737: Relax the size checks in ScreenCaptureKitCaptureSo...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d877379c8d5d090714a9575e23d7ac10fcb9c2a8
  
https://github.com/WebKit/WebKit/commit/d877379c8d5d090714a9575e23d7ac10fcb9c2a8
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  Relax the size checks in 
ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer to prevent 
excessive reconfigurations
rdar://129309166
https://bugs.webkit.org/show_bug.cgi?id=276483

Reviewed by Eric Carlson.

In case of full presenter overlay mode with multiple windows captured, we 
sometimes switch between two sizes that are close one from th eother.
It is not worth reconfiguring since this is not stable, the size is rougthly 
the same and reconfiguration is costly.
We add a size check that allows some deviations and prevent reconfiguration 
when sizes do not really matter.
We do the same check when deciding whether cropping or not, for efficiency 
purposes.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputVideoSampleBuffer):

Canonical link: https://commits.webkit.org/280862@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4721b6: Unreviewed, reverting 280781@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4721b69e7b5a4b91de23c9dfc17ef1971f37b85c
  
https://github.com/WebKit/WebKit/commit/4721b69e7b5a4b91de23c9dfc17ef1971f37b85c
  Author: Commit Queue 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
R 
LayoutTests/fast/flexbox/percent-child-with-flex-basis-flex-item-expected.html
R LayoutTests/fast/flexbox/percent-child-with-flex-basis-flex-item.html
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  ---
  Unreviewed, reverting 280781@main.
https://bugs.webkit.org/show_bug.cgi?id=276489

Caused PLT regression

Reverted changeset:

"[Flex] If a flex item's flex basis is definite, then its post-flexing main 
size is also definite."
https://bugs.webkit.org/show_bug.cgi?id=276349
https://commits.webkit.org/280781@main

Canonical link: https://commits.webkit.org/280861@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c6f1d2: [Writing Tools] Writing Tools do not appear in Safari

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6f1d258f36020774be60e54590b2b581d4c0f43
  
https://github.com/WebKit/WebKit/commit/c6f1d258f36020774be60e54590b2b581d4c0f43
  Author: Richard Robinson 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  [Writing Tools] Writing Tools do not appear in Safari
https://bugs.webkit.org/show_bug.cgi?id=276470
rdar://131501232

Reviewed by Aditya Keerthi.

The new implementation of the Writing Tools context menu item depends on the 
editor state having
post-layout data. However, this is not the case in Safari due to 
`shouldAvoidComputingPostLayoutDataForEditorState`
returning `true`.

Fix by ensuring that post-layout data is always available in this case by 
making `shouldAvoidComputingPostLayoutDataForEditorState`
return `false` if a context menu has ever been shown.

* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuWritingTools):
* Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::showContextMenuFromFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldAvoidComputingPostLayoutDataForEditorState const):

Canonical link: https://commits.webkit.org/280860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f2972: [GStreamer] Move gstStructureGet definition to ...

[Carlos Bentzen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f2972a007a277a88260b3a433e500fdf9d62e6e
  
https://github.com/WebKit/WebKit/commit/3f2972a007a277a88260b3a433e500fdf9d62e6e
  Author: Carlos Bentzen 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

  Log Message:
  ---
  [GStreamer] Move gstStructureGet definition to cpp file
https://bugs.webkit.org/show_bug.cgi?id=276484

Reviewed by Xabier Rodriguez-Calvar and Philippe Normand.

Move gstStructureGet's definition to the cpp file, because it improves
recompilation times when adding new types.

Driving by, since the function isn't inlined anymore, we don't hit
the miscompilation bug with Clang 18 bug fixed by 280669@main anymore, so
we can remove the workaround with UNLIKELY.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureGet):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::gstStructureGet): Deleted.

Canonical link: https://commits.webkit.org/280859@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 23af62: [WPE][GTK] IPC socket should use SOCK_CLOEXEC on L...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23af623a3a7e6b6458b1f51cf2af9c2fe77b30e8
  
https://github.com/WebKit/WebKit/commit/23af623a3a7e6b6458b1f51cf2af9c2fe77b30e8
  Author: Michael Catanzaro 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WTF/wtf/UniStdExtras.h
M Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp
M Source/WTF/wtf/unix/UniStdExtrasUnix.cpp
M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp

  Log Message:
  ---
  [WPE][GTK] IPC socket should use SOCK_CLOEXEC on Linux
https://bugs.webkit.org/show_bug.cgi?id=275690

Reviewed by Carlos Garcia Campos.

Instead of creating the IPC socket without CLOEXEC and then setting it
afterwards if requested, instead create the socket with CLOEXEC and
unset it afterwards if not requested. This closes the race window where
the socket may leak into a subprocess spawned by another thread (which
seems unlikely, but you never know what applications will do).

In practice, this ensures the server socket will never leak to a
subprocess. The client socket might still get leaked because CLOEXEC has
to get unset at some point for the child process to receive the socket.

* Source/WTF/wtf/UniStdExtras.h:
* Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp:
(WTF::unsetCloseOnExec):
* Source/WTF/wtf/unix/UniStdExtrasUnix.cpp:
(WTF::unsetCloseOnExec):
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::createPlatformConnection):

Canonical link: https://commits.webkit.org/280858@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f441f3: [iOS] Reconfiguring the device is often switching ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f441f31ce48366303d274c59d56d232d65727eca
  
https://github.com/WebKit/WebKit/commit/f441f31ce48366303d274c59d56d232d65727eca
  Author: Youenn Fablet 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  ---
  [iOS] Reconfiguring the device is often switching off the torch
rdar://131130489
https://bugs.webkit.org/show_bug.cgi?id=276478

Reviewed by Eric Carlson.

When we reconfigure the device (for frame rate, zoom or size), this often 
switches off the torch.
To reenable it properly, we asynchronously switch it on again.
We do that asynchronously as switching it on in the same 
beginConfiguration/commitConfiguration does not seem to work properly.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):

Canonical link: https://commits.webkit.org/280857@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cfba0b: [Pagination] Huge vertical space on some books pag...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfba0b14d62853e5eba2ce72f1cdf85d93ea2fa1
  
https://github.com/WebKit/WebKit/commit/cfba0b14d62853e5eba2ce72f1cdf85d93ea2fa1
  Author: Alan Baradlay 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
A LayoutTests/fast/multicol/line-offset-after-widow-adjustment-expected.html
A LayoutTests/fast/multicol/line-offset-after-widow-adjustment.html
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.h

  Log Message:
  ---
  [Pagination] Huge vertical space on some books pages with widows
https://bugs.webkit.org/show_bug.cgi?id=276446


Reviewed by Antti Koivisto.

We use _accumulated_ offset to restart partial inline layout to deal with 
widows/orphans
which makes the start position of the "new content" incorrect when we arrive to 
this windows/orphans restart through multiple pages.

The fix is to keep track of the _actual_ offset where the new content is 
supposed to start taking widows/orphans into account.

* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::adjustContentForPagination):
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::computeAdjustmentsForPagination):
* Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.h:

Canonical link: https://commits.webkit.org/280856@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aed572: [GStreamer][WebRTC] Incoming video track handling ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aed57210e6b345f50f0292484ad08e1d88c7415c
  
https://github.com/WebKit/WebKit/commit/aed57210e6b345f50f0292484ad08e1d88c7415c
  Author: Philippe Normand 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h

  Log Message:
  ---
  [GStreamer][WebRTC] Incoming video track handling improvements
https://bugs.webkit.org/show_bug.cgi?id=276419

Reviewed by Xabier Rodriguez-Calvar.

The h265.html test now consistently fails, due to bug #269285. Before this 
patch it was consistently
timing out, due to a caps negotiation issue triggered when the MediaStreamTrack 
was disabled. The
framerate not being set on the black video frames triggered variable framerate 
code paths, messing
up downstream elements.

After fixing the framerate issue, another bug surfaced, the buffers coming from 
the RealtimeIncoming
source had no video meta information, leading to glupload failing to handle 
frames and raising
errors. By using fakevideosink instead of appsink in the WebRTC pipeline for 
incoming video tracks
that are decoded the tee element will perform no allocation query shenanigans 
and the decoder will
correctly attach video metas to buffers.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::configureAppSink):
(WebCore::RealtimeIncomingSourceGStreamer::configureFakeVideoSink):
(WebCore::RealtimeIncomingSourceGStreamer::handleDownstreamEvent):
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h:

Canonical link: https://commits.webkit.org/280855@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b632a: Resync Geolocation tests from upstream

[Marcos Cáceres]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b632a4d10230463bf9ebfb97cf58a15fc0b9611
  
https://github.com/WebKit/WebKit/commit/9b632a4d10230463bf9ebfb97cf58a15fc0b9611
  Author: Marcos Caceres 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M .github/CODEOWNERS
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/import-expectations.json
R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/META.yml
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub.html.headers
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute.https.sub-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub.html.headers
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub.html.headers
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_allow.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_allow.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_deny.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_deny.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/idlharness.https.window-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/idlharness.https.window.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/idlharness.https.window.js
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/non-fully-active.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/non-fully-active.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/non-secure-contexts.http-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/non-secure-contexts.http.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/permission.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/permission.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/resources/iframe.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/resources/w3c-import.log
R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/support.js
R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/w3c-import.log
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_permission_deny.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_permission_deny.https.html
A LayoutTests/imported/w3c/web-platform-tests/geolocation/META.yml
A 

[webkit-changes] [WebKit/WebKit] 80329f: CISupport: built-product-archive and test-result-a...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80329f1d5c7dfbbb9f782591faecc859d9abf55b
  
https://github.com/WebKit/WebKit/commit/80329f1d5c7dfbbb9f782591faecc859d9abf55b
  Author: Fujii Hironori 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Tools/CISupport/built-product-archive
M Tools/CISupport/test-result-archive

  Log Message:
  ---
  CISupport: built-product-archive and test-result-archive should accept both 
--platform=win and --platform=wincairo
https://bugs.webkit.org/show_bug.cgi?id=276473

Reviewed by Ross Kirsling.

For renaming wincairo port to win port, all scripts should accept both
--platform=win and --platform=wincairo for the transition period.

* Tools/CISupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
* Tools/CISupport/test-result-archive:
(archive_test_results):

Canonical link: https://commits.webkit.org/280853@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5db705: [GTK4] Ensure that clipboard read operations work ...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5db7057e3b2f627f2d8df8f8af1a98ed3a89272e
  
https://github.com/WebKit/WebKit/commit/5db7057e3b2f627f2d8df8f8af1a98ed3a89272e
  Author: Carlos Garcia Campos 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/UIProcess/WebPasteboardProxy.h
M Source/WebKit/UIProcess/gtk/Clipboard.h
M Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp
M Source/WebKit/UIProcess/gtk/ClipboardGtk4.cpp
M Source/WebKit/UIProcess/gtk/WebPasteboardProxyGtk.cpp

  Log Message:
  ---
  [GTK4] Ensure that clipboard read operations work synchronously
https://bugs.webkit.org/show_bug.cgi?id=265088

Reviewed by Alejandro G. Castro.

When running layout tests clipboard operations are usually
triggered by an injected bundle synchronous message from
the web process to the UI process. Pasteboard operations are
also handled using synchronous IPC messages, but GTK4 clipboard
reads are asynchronous, and this can easily cause deadlocks.

This can happen, for example, when the test calls 
testRunner.execCommand("Paste"),
which is implemented as a synchronous injected bundle message.
The UI process receives the message that ends up calling 
WKPageExecuteCommandForTesting,
which sends a synchronous message with reply to the web process. The web
process then handles the paste editing command asking the UI process
pasteboard sending another synchronous API message. In the UI process
a clipboard request is started, but the GdkClipboard GTask can't finish
because the run loop is blocked by the initial injected bundle message
that is waiting to provide a reply. This works if we can reply to the
pasteboard request synchronously, by running a nested main loop that
allows the GdkClipboard GTask to complete in an idle.

Running nested main loops can be dangerous, but we only need to do that
when a pasteboard read request is done while already dispatching a
synchronous message, which probably only happens in tests.

This fixes many pasteboard tests that are timing out only when running
on GTK4 builds.

Co-authored-by: Claudio Saavedra 

* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::inDispatchSyncMessageCount const):
* Source/WebKit/UIProcess/WebPasteboardProxy.h:
* Source/WebKit/UIProcess/gtk/Clipboard.h:
* Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp:
(WebKit::Clipboard::readText):
(WebKit::Clipboard::readFilePaths):
(WebKit::Clipboard::readURL):
(WebKit::Clipboard::readBuffer):
* Source/WebKit/UIProcess/gtk/ClipboardGtk4.cpp:
(WebKit::Clipboard::readText):
(WebKit::Clipboard::readFilePaths):
(WebKit::Clipboard::readBuffer):
(WebKit::Clipboard::readURL):
(WebKit::ReadTextAsyncData::ReadTextAsyncData): Deleted.
(WebKit::ReadFilePathsAsyncData::ReadFilePathsAsyncData): Deleted.
(WebKit::ReadBufferAsyncData::ReadBufferAsyncData): Deleted.
(WebKit::ReadURLAsyncData::ReadURLAsyncData): Deleted.
* Source/WebKit/UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::readText):
(WebKit::WebPasteboardProxy::readFilePaths):
(WebKit::WebPasteboardProxy::readBuffer):
(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):
(WebKit::WebPasteboardProxy::readURLFromPasteboard):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):

Canonical link: https://commits.webkit.org/280852@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7099dc: Support padding/border/margin on RenderMathMLToken

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7099dcb8c935e105be857d6f565c42358065a5fb
  
https://github.com/WebKit/WebKit/commit/7099dcb8c935e105be857d6f565c42358065a5fb
  Author: Frédéric Wang 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
A 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-004-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-004.html
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/w3c-import.log
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp

  Log Message:
  ---
  Support padding/border/margin on RenderMathMLToken
https://bugs.webkit.org/show_bug.cgi?id=276317

Reviewed by Rob Buis.

This patch imports the WPT reftest from [1] and implements
padding/border/margin for RenderMathMLToken when a mathVariantGlyph is
used. That improves the rendering of the test but is not enough to
make it pass [2].

[1] 
https://github.com/web-platform-tests/wpt/commit/8d6df04645f8106a474da0e187e132d0923adf7c
[2] https://bugs.webkit.org/show_bug.cgi?id=276413

Canonical link: https://commits.webkit.org/280851@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e6676: [WPE] Unreviewed test gardening

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e6676188d6fc0f61a42fc574eb0843c19261c00
  
https://github.com/WebKit/WebKit/commit/2e6676188d6fc0f61a42fc574eb0843c19261c00
  Author: Diego Pino Garcia 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [WPE] Unreviewed test gardening

Remove test and flaky tests passing.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/280850@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c1afd: Remove Tools/CISupport/win/kill-old-processes

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c1afd1b7852bf1458dfa0be465fe2ee102947e8
  
https://github.com/WebKit/WebKit/commit/4c1afd1b7852bf1458dfa0be465fe2ee102947e8
  Author: Fujii Hironori 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
R Tools/CISupport/win/kill-old-processes

  Log Message:
  ---
  Remove Tools/CISupport/win/kill-old-processes
https://bugs.webkit.org/show_bug.cgi?id=276472

Reviewed by Ross Kirsling.

After https://commits.webkit.org/86072@main, it was no longer used.

* Tools/CISupport/win/kill-old-processes: Removed.

Canonical link: https://commits.webkit.org/280849@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d5fddb: [LinearMediaPlayer] Blank video frames seen before...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5fddb160c2739f7d90e5a4b9b5ed1d6e30d69eb
  
https://github.com/WebKit/WebKit/commit/d5fddb160c2739f7d90e5a4b9b5ed1d6e30d69eb
  Author: Andy Estes 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/MediaPlayerEnums.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm

  Log Message:
  ---
  [LinearMediaPlayer] Blank video frames seen before docking and after undocking
https://bugs.webkit.org/show_bug.cgi?id=276453
rdar://130425275

Reviewed by Jer Noble.

Two issues resulted in blank frames briefly appearing in an  element in 
element fullscreen:

1. Just prior to docking, an LMPlayableViewController is presented that 
obscures the web view.
Since this VC's presentationMode is immediately changed to 
`.fullscreenFromInline` which hides the
web view's scene and presents a new fullscreen scene, we should hide the view 
controller while it's
in `.inline` mode (by setting its root view's alpha to 0).

2. Right after undocking, when committing the staged 
AVSampleBufferDisplayLayer, MediaPlayerPrivate
would call renderingModeChanged(), which calls 
Element::invalidateStyleAndLayerComposition(). This
results in the  element briefly rendering a black frame. To avoid this, 
changed
MediaPlayerPrivate to call renderingModeChanged() as soon as the 
AVSampleBufferDisplayLayer is
staged, while the LinearMediaKit scene is still occluding the web view.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/MediaPlayerEnums.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateDisplayLayerAndDecompressionSession):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyDecompressionSession):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayerOrVideoRenderer):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::updateDisplayLayerAndDecompressionSession):
(WebCore::MediaPlayerPrivateWebM::destroyDecompressionSession):
(WebCore::MediaPlayerPrivateWebM::ensureLayerOrVideoRenderer):
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::ensurePlayableViewController):

Canonical link: https://commits.webkit.org/280848@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c22363: AXObjectCache::characterOffsetFromVisiblePosition ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c223637aad47dceef3291a95636ceb9fc10ee1ab
  
https://github.com/WebKit/WebKit/commit/c223637aad47dceef3291a95636ceb9fc10ee1ab
  Author: Tyler Wilcock 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A LayoutTests/accessibility/mac/role-img-selection-hang-expected.txt
A LayoutTests/accessibility/mac/role-img-selection-hang.html
M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  ---
  AXObjectCache::characterOffsetFromVisiblePosition can iterate infinitely when 
moving through role="img" container
https://bugs.webkit.org/show_bug.cgi?id=276464
rdar://problem/131502510

Reviewed by Ryosuke Niwa.

Given this markup:


X
Y


When we create a VisiblePosition from this Position:

(Position
  (anchor node: #text 0x159003ec0 length=1 "Y")
  (offset: 0)
  (anchor type: offset in anchor))

We get its `canonicalPosition` in the VisiblePosition constructor, which 
computes:

(Position
  (anchor node: DIV 0x159003c40)
  (offset: 0)
  (anchor type: before anchor))

This starts iteration for `nextVisuallyDistinctCandidate` back at the beginning 
of the div, repeating until we get back
to the "Y" position, in turn computing the before-anchor-div position, 
repeating forever.

This happens because the div is role="img", which was special cased to be 
`Element::canContainRangeEndPoint()` in:

https://bugs.webkit.org/attachment.cgi?id=229259=prettypatch (Find on 
Page can get stuck in a loop when the search string occurs in an input in a 
fieldset).

Making it `canContainRangeEndPoint` also makes it `editingIgnoresContent == 
true`, in turn making it `Position::isCandidate() == true`.

I tried to solve the core editing bug in 
https://github.com/WebKit/WebKit/pull/30614, but my approach (removing this
special role="img" logic in Element::canContainRangeEndPoint()) caused other 
undesirable effects (more details in
https://github.com/WebKit/WebKit/pull/30614#issuecomment-2221064954), so some 
other fix is needed (tracked by
https://bugs.webkit.org/show_bug.cgi?id=276460).

For now, this commit works around this foundational bug by changing 
`AXObjectCache::characterOffsetFromVisiblePosition`
to detect we've moved back to the start position, and breaking to prevent an 
infinite loop.

* LayoutTests/accessibility/mac/role-img-selection-hang-expected.txt: Added.
* LayoutTests/accessibility/mac/role-img-selection-hang.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):

Canonical link: https://commits.webkit.org/280847@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e660d5: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e660d510f966a861848c3b2818afc17ef6001c63
  
https://github.com/WebKit/WebKit/commit/e660d510f966a861848c3b2818afc17ef6001c63
  Author: Fujii Hironori 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/280846@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 79c138: Add an extension point for PlatformHave.h

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79c13893532268733225cca1ef9e68031688775d
  
https://github.com/WebKit/WebKit/commit/79c13893532268733225cca1ef9e68031688775d
  Author: Tim Horton 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h

  Log Message:
  ---
  Add an extension point for PlatformHave.h
https://bugs.webkit.org/show_bug.cgi?id=276457

Reviewed by Aditya Keerthi.

* Source/WTF/wtf/PlatformHave.h:
The order of includes in Platform.h is such that PlatformHave comes before
AdditionalFeatureDefines, so we need a custom extension point here.

Canonical link: https://commits.webkit.org/280845@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c7836: [WebKit] Pass full paths to generate-serializers.p...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c78362876edce207c947b1c56de1a4a628b1023
  
https://github.com/WebKit/WebKit/commit/3c78362876edce207c947b1c56de1a4a628b1023
  Author: Elliott Williams 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources.make
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Scripts/webkit/tests/Makefile

  Log Message:
  ---
  [WebKit] Pass full paths to generate-serializers.py and support derived 
.serialization.in files
https://bugs.webkit.org/show_bug.cgi?id=276461
rdar://131500106

Reviewed by Ryosuke Niwa.

* Source/WebKit/CMakeLists.txt: Pass fully-qualified paths to
  serialization profiles.
* Source/WebKit/DerivedSources.make:
  - Pass fully-qualified paths to serialization profiles.
  - As a drive-by fix, turn the generate-serializers.py recipe into a
pattern rule so that Make only invokes it once instead of once per
output file.
* Source/WebKit/Scripts/generate-serializers.py:
(main): Remove the "DIRECTORY" argument parsing logic.
* Source/WebKit/Scripts/webkit/tests/Makefile:

Canonical link: https://commits.webkit.org/280844@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb9b05: Messages::GPUConnectionToWebProcess::CreateGraphic...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb9b0517ea6e2e1b9772f0929b29f445f1a64248
  
https://github.com/WebKit/WebKit/commit/cb9b0517ea6e2e1b9772f0929b29f445f1a64248
  Author: Gerald Squelart 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp

  Log Message:
  ---
  
Messages::GPUConnectionToWebProcess::CreateGraphicsContextGL/ReleaseGraphicsContextGL
 should only be handled when UseGPUProcessForWebGLEnabled is true
https://bugs.webkit.org/show_bug.cgi?id=276355
rdar://107941430

Reviewed by Dan Glastonbury.

GPUProcessPreferencesForWebProcess::isWebGLEnabled is now
dependant on UseGPUProcessForWebGLEnabled, so that in case that
the GPU process is not to be used for WebGL, messages from the
GPU process related to WebGL will simply be ignored.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::preferencesForGPUProcess const):

Canonical link: https://commits.webkit.org/280843@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6027f: Disable support for git submodules in some configu...

[Russell Epstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6027f4124113e78624ed739e09cbb56c63a37a9
  
https://github.com/WebKit/WebKit/commit/b6027f4124113e78624ed739e09cbb56c63a37a9
  Author: Russell Epstein 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M .submitproject

  Log Message:
  ---
  Disable support for git submodules in some configurations.
rdar://131500339

Reviewed by Ryan Haddad.

* .submitproject: Disable git submodules for consumers of this
  configuration.

Canonical link: https://commits.webkit.org/280842@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 024291: Negative exponent exception for BigInt not thrown ...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02429197cd90525288d0a2681640e4236c62d783
  
https://github.com/WebKit/WebKit/commit/02429197cd90525288d0a2681640e4236c62d783
  Author: Yijia Huang 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A JSTests/stress/dead-code-eliminiation-with-side-effect-node.js
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/runtime/JSBigInt.h
M Source/JavaScriptCore/runtime/JSCJSValue.h
M Source/JavaScriptCore/runtime/JSCJSValueInlines.h

  Log Message:
  ---
  Negative exponent exception for BigInt not thrown in JIT compiler
https://bugs.webkit.org/show_bug.cgi?id=275939
rdar://131051084

Reviewed by Yusuke Suzuki.

Some DFG nodes can have side effects even if their results
are not used by others. In that case, we shouldn't clear the
NodeMustGenerate flags unless they are proven not having side effects.

* JSTests/stress/dead-code-eliminiation-with-side-effect-node.js: Added.
(assert):
(let.iteration.1e3.opt):
(i.assert.opt.opt):
(i.assert.opt):
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/runtime/JSBigInt.h:
* Source/JavaScriptCore/runtime/JSCJSValue.h:
* Source/JavaScriptCore/runtime/JSCJSValueInlines.h:
(JSC::JSValue::isZeroBigInt const):
(JSC::JSValue::isNegativeBigInt const):

Canonical link: https://commits.webkit.org/280841@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1bd46d: Add more release logging in RemoteLayerTreeDrawing...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bd46d2bfa1bbcbea92fdda7080772ba32d7abdf
  
https://github.com/WebKit/WebKit/commit/1bd46d2bfa1bbcbea92fdda7080772ba32d7abdf
  Author: Ryosuke Niwa 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebKit/UIProcess/DrawingAreaProxy.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  ---
  Add more release logging in RemoteLayerTreeDrawingAreaProxyMac
https://bugs.webkit.org/show_bug.cgi?id=276412

Reviewed by Simon Fraser.

Add loggings when RemoteLayerTreeDrawingAreaProxyMac adds observer or its 
observer gets called
for the first time after WKWebView becomes visible.

* Source/WebKit/UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::viewIsBecomingVisible):
(WebKit::DrawingAreaProxy::viewIsBecomingInvisible):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::scheduleDisplayRefreshCallbacks):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::viewIsBecomingVisible):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::viewIsBecomingInvisible):
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::didRefreshDisplay):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::viewIsBecomingVisible):
(WebKit::WebPageProxy::viewIsBecomingInvisible):
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/280840@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad9437: Allow WKWebView clients to toggle fullscreen video

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad94373263a77c433dc04da03a3029c58962182b
  
https://github.com/WebKit/WebKit/commit/ad94373263a77c433dc04da03a3029c58962182b
  Author: Andy Estes 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSpatialTrackingLabels.mm
M Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm
M Tools/TestWebKitAPI/Utilities.h

  Log Message:
  ---
  Allow WKWebView clients to toggle fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=276376
rdar://131394306

Reviewed by Jer Noble.

Added APIs to WKWebViewPrivate.h that allow clients to (a) determine whether 
they can enter
fullscreen video (-_canEnterFullscreen), and (b) enter fullscreen 
programatically (-_enterFullscreen).
-_canEnterFullscreen is key-value observable.

While here, made it possible to create a CheckedPtr to PlaybackSessionModel and
WebFullScreenManagerProxy and fixed a bug with how 
PlaybackSessionManager::(enter|exit)Fullscreen
created UserGestureIndicators.

Added an API test.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModel.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::enterFullscreen):
(WebCore::PlaybackSessionModelMediaElement::exitFullscreen):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _canEnterFullscreen]):
(-[WKWebView _enterFullscreen]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::videoControlsManagerDidChange):
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
(WebKit::PlaybackSessionManagerProxy::hasControlsManagerInterface const):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canEnterFullscreen):
(WebKit::WebPageProxy::enterFullscreen):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::videoControlsManagerDidChange):
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::videoControlsManagerDidChange):
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::enterFullscreen):
(WebKit::PlaybackSessionManager::exitFullscreen):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLifecycle.mm: Added.
(-[FullscreenLifecycleObserver 
observeValueForKeyPath:ofObject:change:context:]):
(TEST(Fullscreen, Lifecycle)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSpatialTrackingLabels.mm:
(TEST(WKWebView, DefaultSTSLabel)):
* Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm:
(TestWebKitAPI::TEST(InWindowFullscreen, CanToggleAfterPlaybackStarts)):
(TestWebKitAPI::TEST(InWindowFullscreen, ToggleChangesIsActive)):
(TestWebKitAPI::TEST(InWindowFullscreen, 
ToggleChangesIsActiveWithoutUserGesture)):
(TestWebKitAPI::testEventually): Deleted.
* Tools/TestWebKitAPI/Utilities.h:
(TestWebKitAPI::Util::waitFor):

Canonical link: https://commits.webkit.org/280839@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a053f: Clicking and dragging video viewer drags a layer ...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a053f41c96e04f9c7747d6fad34251896c44542
  
https://github.com/WebKit/WebKit/commit/8a053f41c96e04f9c7747d6fad34251896c44542
  Author: Dana Estra 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  ---
  Clicking and dragging  video viewer drags a layer on top of the other
https://bugs.webkit.org/show_bug.cgi?id=276400
rdar://127512495

Reviewed by Jer Noble and Antoine Quint.

On YouTube.com, clicking and dragging on a video in Video Viewer causes 
elements on
the page behind the video to come to the forefront. This is because YouTube 
gives
a draggable=true attribute to the parent div of the video element.

To fix this, now when we enter fullscreen on macOS, we add a dragstart event 
listener
to the window, which calls preventDefault() when the dragstart event occurs. We
remove this event listener when we enter inline.

* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.handleEvent):
(MediaController.prototype._updateControlsIfNeeded):

Canonical link: https://commits.webkit.org/280838@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 36f50a: [JSC] Disallow yield/await expressions in class fi...

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36f50aab423c74d3b9b941e41a49b7ca2d581668
  
https://github.com/WebKit/WebKit/commit/36f50aab423c74d3b9b941e41a49b7ca2d581668
  Author: Dan Hecht 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A JSTests/stress/yield-await-class-field-initializer-expr.js
M Source/JavaScriptCore/parser/Parser.cpp

  Log Message:
  ---
  [JSC] Disallow yield/await expressions in class field initializers
https://bugs.webkit.org/show_bug.cgi?id=276438
rdar://119044881

Reviewed by Yusuke Suzuki.

The language spec doesn't explictly disallow yield and await expressions
in class field initializers, however it implicitly does given that
the expression is effectively evaluated as if it's inside a method.
Additionally, the consensus seems to be that these expressions
should not be allowed, see:

https://github.com/tc39/ecma262/issues/

The yield and await expressions are now handled differently, but
similar to how they are each handled in other contexts. This also
seems to be the least disruptive way to handle existing scripts,
as well as consistent with other engines:

yield: raise syntax error
await: parse as an identifier

Also adding a new test that generates and verifies scripts containing
a class with a field initializer containing yield and await, where the
class is either not nested or nested inside generator or async functions
to verify the behavior of various combinations.

* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser::parseYieldExpression):
(JSC::Parser::parseAwaitExpression):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseUnaryExpression):

Canonical link: https://commits.webkit.org/280837@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69db44: [libpas] PGM Crash Testing: Align allocation to pa...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69db44623766e6e27c87f20d7cb5add5220d59e9
  
https://github.com/WebKit/WebKit/commit/69db44623766e6e27c87f20d7cb5add5220d59e9
  Author: Brandon Stewart 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp

  Log Message:
  ---
  [libpas] PGM Crash Testing: Align allocation to page size
https://bugs.webkit.org/show_bug.cgi?id=276181
rdar://problem/13106

Reviewed by David Kilzer.

PGM will align pages left or right, so by allocating the entire length of the 
page
it will give the same result whether left or right aligned. This will make 
testing guard pages reliable again.

* Source/JavaScriptCore/jsc.cpp:
(crashPGMUAF):
(crashPGMUpperGuardPage):
(crashPGMLowerGuardPage):

Canonical link: https://commits.webkit.org/280836@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5172cd: Import wpts for css-scrollbars

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5172cde601cc8795578f60f068b187b283a296bf
  
https://github.com/WebKit/WebKit/commit/5172cde601cc8795578f60f068b187b283a296bf
  Author: Nikolaos Mouchtaris 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/auto-scrollbar-inline-children.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/multicol-in-orthogonal-writing-mode-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-mis-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-mis-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-mis-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-mis-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-mis-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-mis-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-011.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-012.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-mis-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-1.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-mis-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-2.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-dynamic-3-mis-ref.html
 

[webkit-changes] [WebKit/WebKit] e2cefb: http/tests/xmlhttprequest/gzip-content-type.html g...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2cefb9ce6aa390c827015ad65ab440ac2745bbc
  
https://github.com/WebKit/WebKit/commit/e2cefb9ce6aa390c827015ad65ab440ac2745bbc
  Author: Chris Dumez 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/http/conf/apache2.4-darwin-httpd.conf

  Log Message:
  ---
  http/tests/xmlhttprequest/gzip-content-type.html gives a different output 
depending on Apache version
https://bugs.webkit.org/show_bug.cgi?id=276406
rdar://131423730

Reviewed by Brady Eidson and Aakash Jain.

Some of out bots recently got an updated Apache version. When this happened, 2 
XHR tests dealing with
gzip-compressed responses have had a different output. In particular, the 
`Content-Length` HTTP header
is no longer present on the response.

Set the `ap_trust_cgilike_cl` Apache environment variable to allow CGI scripts 
to set the
`Content-Length` HTTP header again, for backward compatibility:
- https://httpd.apache.org/docs/current/env.html

* LayoutTests/http/conf/apache2.4-darwin-httpd.conf:

Canonical link: https://commits.webkit.org/280834@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a0185: Support border/padding/margin on RenderMathMLOperator

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a01858119398922a3baa934a4eb225786d15cda
  
https://github.com/WebKit/WebKit/commit/9a01858119398922a3baa934a4eb225786d15cda
  Author: Frédéric Wang 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp

  Log Message:
  ---
  Support border/padding/margin on RenderMathMLOperator
https://bugs.webkit.org/show_bug.cgi?id=276357

Reviewed by Rob Buis.

This patch adds support for border/padding/margin on `` elements
for which useMathOperator() returns true and therefore uses use
special layout and painting instead of deferring to RenderMathMLToken.

* LayoutTests/TestExpectations: Mark borders/paddings/margins reftests
  for largeop/stretchy operators as passing.
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchTo): Include borders/paddings in
  logical width/height.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Include
  borders/paddings in preferred width. Children are text nodes, no need
  to consider margins.
(WebCore::RenderMathMLOperator::layoutBlock): Include borders/paddings
  for in logical width/height. Also call recomputeLogicalWidth() to set
  the inline margins on the element (block margins are handled by the
  parent). Children are text nodes, no need to consider margins for them.
(WebCore::RenderMathMLOperator::firstLineBaseline const):
  Include border/padding in the ascent.
(WebCore::RenderMathMLOperator::paint): Shift painting by the left/top
  border/padding.

Canonical link: https://commits.webkit.org/280833@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c0b0d: iOS 18 expectations migration: update one test exp...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c0b0d8e9424e00098979be2ddbe08a3672afe99
  
https://github.com/WebKit/WebKit/commit/5c0b0d8e9424e00098979be2ddbe08a3672afe99
  Author: Ben Schwartz 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/platform/ios-17/TestExpectations

  Log Message:
  ---
  iOS 18 expectations migration: update one test expectation.
https://bugs.webkit.org/show_bug.cgi?id=276370
rdar://131389611

Unreviewed test gardening.

Updating test expectation for one straggling test after the iOS 18 baselines/
expectations migration completed in 280829@main.

* LayoutTests/platform/ios-17/TestExpectations:

Canonical link: https://commits.webkit.org/280832@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 099cda: Move methods of WinCairoPort class to the super class

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 099cdafc1313f7d09867dc8c86ee1fde67c4fdaa
  
https://github.com/WebKit/WebKit/commit/099cdafc1313f7d09867dc8c86ee1fde67c4fdaa
  Author: Fujii Hironori 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
M Tools/Scripts/webkitpy/port/win.py

  Log Message:
  ---
  Move methods of WinCairoPort class to the super class
https://bugs.webkit.org/show_bug.cgi?id=271244

Reviewed by Don Olmstead.

Apple Windows port has gone. WinCairoPort class should be renamed to
WinPort. This is a preparation for it.

* Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py:
* Tools/Scripts/webkitpy/port/win.py:

Canonical link: https://commits.webkit.org/280831@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fce181: [JSC] Should use WeakPtr for Waiter's TicketData

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fce181433e3b5225ab4b92a9be2491415964291a
  
https://github.com/WebKit/WebKit/commit/fce181433e3b5225ab4b92a9be2491415964291a
  Author: Yijia Huang 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/WaiterListManager.cpp
M Source/JavaScriptCore/runtime/WaiterListManager.h

  Log Message:
  ---
  [JSC] Should use WeakPtr for Waiter's TicketData
https://bugs.webkit.org/show_bug.cgi?id=276410
rdar://131442732

Reviewed by Yusuke Suzuki.

Previously, we fixed the memory issue in DeferredWorkTimer::TicketData
by letting JSGlobalObject to strong reference TicketData's dependencies[1].
Later, we fixed the tracked TicketData with WeakHashSet in JSGlobalObject[2].
This patch fixed a similar issue by applying WeakPtr to Waiter's TicketData.
I've confirmed that all DeferredWorkTimer::TicketData uses are guarded by
WeakPtr, WeakHashSet, Ref, or RefPtr.

[1] https://commits.webkit.org/279852@main
[2] https://commits.webkit.org/280180@main

* Source/JavaScriptCore/runtime/WaiterListManager.cpp:
(JSC::Waiter::scheduleWorkAndClearTicket):
(JSC::WaiterListManager::cancelAsyncWaiter):
(JSC::Waiter::dump const):
* Source/JavaScriptCore/runtime/WaiterListManager.h:

Canonical link: https://commits.webkit.org/280830@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4840a7: Migrate internal iOS 18 test baselines/expectation...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4840a7f165cbfa5794f7196737072336469ebb1c
  
https://github.com/WebKit/WebKit/commit/4840a7f165cbfa5794f7196737072336469ebb1c
  Author: Ben Schwartz 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A LayoutTests/platform/ios-17/TestExpectations
A LayoutTests/platform/ios-17/css2.1/t0805-c5518-brdr-t-01-e-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0805-c5519-brdr-r-00-a-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0805-c5520-brdr-b-01-e-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0805-c5521-brdr-l-00-a-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0805-c5521-brdr-l-01-e-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-02-c-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-03-c-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c414-flt-04-c-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltblck-01-d-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt
A 
LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt
A 
LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt
A 
LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt
A LayoutTests/platform/ios-17/css2.1/t0905-c5525-fltwrap-00-b-expected.txt
A LayoutTests/platform/ios-17/css2.1/t090501-c414-flt-01-b-expected.txt
A LayoutTests/platform/ios-17/css2.1/t090501-c414-flt-03-b-g-expected.txt
A LayoutTests/platform/ios-17/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt
A LayoutTests/platform/ios-17/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt
A LayoutTests/platform/ios-17/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt
A 
LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-in-loose-expected.txt
A 
LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-normal-expected.txt
A 
LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-strict-expected.txt
A 
LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-normal-expected.txt
A 
LayoutTests/platform/ios-17/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-strict-expected.txt
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/ios/css2.1/t0805-c5518-brdr-t-01-e-expected.txt
M LayoutTests/platform/ios/css2.1/t0805-c5519-brdr-r-00-a-expected.txt
M LayoutTests/platform/ios/css2.1/t0805-c5520-brdr-b-01-e-expected.txt
M LayoutTests/platform/ios/css2.1/t0805-c5521-brdr-l-00-a-expected.txt
M LayoutTests/platform/ios/css2.1/t0805-c5521-brdr-l-01-e-expected.txt
M LayoutTests/platform/ios/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c414-flt-02-c-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c414-flt-03-c-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c414-flt-04-c-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltblck-01-d-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt
M LayoutTests/platform/ios/css2.1/t0905-c5525-fltwrap-00-b-expected.txt
M LayoutTests/platform/ios/css2.1/t090501-c414-flt-01-b-expected.txt
M LayoutTests/platform/ios/css2.1/t090501-c414-flt-03-b-g-expected.txt
M LayoutTests/platform/ios/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt
M LayoutTests/platform/ios/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt
M LayoutTests/platform/ios/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-in-loose-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-normal-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/ja/css-text-line-break-ja-pr-strict-expected.txt
A 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-normal-expected.txt
A 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-text/i18n/zh/css-text-line-break-zh-pr-strict-expected.txt

  Log Message:
  ---
  Migrate internal iOS 18 test baselines/expectations to OpenSource.
https://bugs.webkit.org/show_bug.cgi?id=276370
rdar://131389611

Reviewed by Ryan Haddad.

[webkit-changes] [WebKit/WebKit] 5666c1: PROGRESSION(275095@main): [ macOS ] workers/wasm-h...

[Anfernee V]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5666c1cb7742fac72df76acfb78b3e2ecedc4aa9
  
https://github.com/WebKit/WebKit/commit/5666c1cb7742fac72df76acfb78b3e2ecedc4aa9
  Author: Anfernee Viduya 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  PROGRESSION(275095@main): [ macOS ] workers/wasm-hashset-many.h tml is flakey 
crashing.
https://bugs.webkit.org/show_bug.cgi?id=276434
rdar://131474541

Unreviewed test gardening.

Setting test expectations.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/280828@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41ccf2: Fix internal builds after 280824@main

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41ccf2c1317837ebe0d888bfeaa7027afa800665
  
https://github.com/WebKit/WebKit/commit/41ccf2c1317837ebe0d888bfeaa7027afa800665
  Author: Tim Horton 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h

  Log Message:
  ---
  Fix internal builds after 280824@main
https://bugs.webkit.org/show_bug.cgi?id=276439
rdar://131476601

Unreviewed build fix.

* Source/WTF/wtf/PlatformHave.h:

Canonical link: https://commits.webkit.org/280827@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c94d8: Unreviewed, reverting 280317@main (c6894f128e9b)

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c94d8cc6f1a7d386f656539ae4afb3db7f28519
  
https://github.com/WebKit/WebKit/commit/0c94d8cc6f1a7d386f656539ae4afb3db7f28519
  Author: Dan Hecht 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/bmalloc/libpas/src/libpas/pas_bitfit_heap.c
M Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c
M Source/bmalloc/libpas/src/test/BmallocTests.cpp

  Log Message:
  ---
  Unreviewed, reverting 280317@main (c6894f128e9b)
https://bugs.webkit.org/show_bug.cgi?id=276430
rdar://131470729

PAS_ASSERT at pas_segregated_size_directory_enable_exclusive_views + 2032

Reverted change:

[libpas] 
pas_segregated_heap_ensure_size_directory_for_size/check_medium_directories 
assert fail due to creating overlapping directories
https://bugs.webkit.org/show_bug.cgi?id=275820
rdar://129774839
280317@main (c6894f128e9b)

Canonical link: https://commits.webkit.org/280826@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 03191f: [ews] Add validation to prevent SDK or OS version ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03191fc211d8c2f79172f58e36fc435b20e092f4
  
https://github.com/WebKit/WebKit/commit/03191fc211d8c2f79172f58e36fc435b20e092f4
  Author: Aakash Jain 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add validation to prevent SDK or OS version mismatch between 
corresponding builds on tester and builder queues
https://bugs.webkit.org/show_bug.cgi?id=276379

Reviewed by Sam Sneddon.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):
(PrintConfiguration):
(PrintConfiguration.run):
(PrintConfiguration.parseAndValidate):
(PrintConfiguration.getResultSummary):

Canonical link: https://commits.webkit.org/280825@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91279c: Clean up some Apple Pay related feature flags

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91279c62cb946d291e35eb9e67ae0f73eedc855c
  
https://github.com/WebKit/WebKit/commit/91279c62cb946d291e35eb9e67ae0f73eedc855c
  Author: Tim Horton 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WTF/wtf/PlatformHave.h
M Source/WTF/wtf/PlatformUse.h
M Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm
M Source/WebCore/PAL/pal/spi/cocoa/PassKitInstallmentsSPI.h
M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm

  Log Message:
  ---
  Clean up some Apple Pay related feature flags
https://bugs.webkit.org/show_bug.cgi?id=276396
rdar://131420608

Reviewed by Abrar Rahman Protyasha and Sam Weinig.

* Source/WTF/wtf/PlatformEnableCocoa.h:
Assume ENABLE_APPLE_PAY_FEATURES if ENABLE_APPLE_PAY.
Add ENABLE_APPLE_PAY_SETUP.

* Source/WTF/wtf/PlatformHave.h:
Add HAVE_PASSKIT and make it toggle all of the universally available 
HAVE_PASSKIT_* flags.
Squish a bunch of the aforementioned flags together, removing some always-true 
version checks.

* Source/WTF/wtf/PlatformUse.h:
Define USE_PASSKIT in only one place.

* Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::convert):
Drive-by workaround for a warning with PassKit on some recent SDKs.

* Source/WebCore/PAL/pal/spi/cocoa/PassKitInstallmentsSPI.h:
Remove PASSKIT_INSTALLMENTS_IN_SDK, just use APPLE_INTERNAL_SDK like other SPI 
headers.

* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformBeginApplePaySetup):
(WebKit::WebPaymentCoordinatorProxy::platformEndApplePaySetup):
Respect ENABLE_APPLE_PAY_SETUP. Fail immediately if it's not available.

* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(operator==):
(TEST(IPCSerialization, Basic)):
USE(PASSKIT) already covers these platform exclusions; stop duplicating them.

Canonical link: https://commits.webkit.org/280824@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ca870: WKWebView _loadAndDecodeImage's maximum size param...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ca87096bd024ce32d7bfe87e86883db12a145fa
  
https://github.com/WebKit/WebKit/commit/7ca87096bd024ce32d7bfe87e86883db12a145fa
  Author: Tim Horton 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/DestinationColorSpace.cpp
M Source/WebCore/platform/graphics/DestinationColorSpace.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm

  Log Message:
  ---
  WKWebView _loadAndDecodeImage's maximum size parameter crops the image 
instead of scaling it
https://bugs.webkit.org/show_bug.cgi?id=276384
rdar://131406675

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadAndDecodeImage):
The _loadAndDecodeImage method has an optional parameter allowing clients to
choose a maximum size for the image to be scaled into. However, the 
implementation
crops the image into the maximum size, instead of scaling into it. Also, it
currently scales images *up* to fit in the maximum size, instead of leaving
smaller images alone.

Fix both of these issues.

Also, drive-by add a fallback to an sRGB destination in cases where the decoded
image has a colorspace that it is not possible for us to draw into.

Canonical link: https://commits.webkit.org/280823@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a5621e: Web Inspector: Update COMPATIBILITY (macOS X.0, iO...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5621e0c9b61812f4b37be8c0e79dcdbfc96cc3e
  
https://github.com/WebKit/WebKit/commit/a5621e0c9b61812f4b37be8c0e79dcdbfc96cc3e
  Author: Razvan Caliman 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
M Source/WebInspectorUI/UserInterface/Models/DOMNode.js
M Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js
M Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js
M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

  Log Message:
  ---
  Web Inspector: Update COMPATIBILITY (macOS X.0, iOS X.0) comments with latest 
versions
https://bugs.webkit.org/show_bug.cgi?id=276232
rdar://129159284

Reviewed by Devin Rousso.

* Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.messagesCleared):
(WI.ConsoleManager.prototype._setConsoleClearAPIEnabled):
* Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
* Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createConsoleSettingsView):

Canonical link: https://commits.webkit.org/280822@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] de89aa: Optimize RenderBlock::paintCarets()

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de89aaf09e387343d31cc8ae0c5a3a599f368894
  
https://github.com/WebKit/WebKit/commit/de89aaf09e387343d31cc8ae0c5a3a599f368894
  Author: Simon Fraser 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  ---
  Optimize RenderBlock::paintCarets()
https://bugs.webkit.org/show_bug.cgi?id=276407
rdar://131436270

Reviewed by Alan Baradlay.

`paintCarets()` calls `paintCaret()` for the two caret types, and in each 
branch we access
either `frame().selection()` twice, or `page().dragCaretController()` twice, 
and compute
`isContentEditable` even when we won't use it.

Refactor `RenderBlock::paintCaret()` to just switch once for each caret type, 
using a lambda
for the tiny bit of common code. Add early returns for the common case of no 
selection node,
thus no renderer.

`DragCaretController::caretRenderer()` can early return to avoid copying a 
`Position` by value.

Move some variables in 
`TextBoxPainter::paintCompositionForeground()` to their point of 
first use.

* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::DragCaretController::caretRenderer const):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintCompositionForeground):

Canonical link: https://commits.webkit.org/280821@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a37ba2: Adopt more smart pointers in loading

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a37ba25938493f786b6241403547d8c805ba4e71
  
https://github.com/WebKit/WebKit/commit/a37ba25938493f786b6241403547d8c805ba4e71
  Author: Rob Buis 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/ResourceLoadNotifier.cpp
M Source/WebCore/loader/ResourceLoader.cpp
M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp

  Log Message:
  ---
  Adopt more smart pointers in loading
https://bugs.webkit.org/show_bug.cgi?id=276363

Reviewed by Chris Dumez.

Adopt more smart pointers in loading involving
DocumentLoader accessing. This PR also fixes a few
places where DocumentLoader was accessed unnecessarily.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateRequestAndAddExtraFields):
(WebCore::FrameLoader::loadDifferentDocumentItem):
* Source/WebCore/loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::update):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):

Canonical link: https://commits.webkit.org/280820@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d14f1: Do not dispatch fetch event if its client is alrea...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d14f119e11e9b20df828804d9c76cac7517fad8
  
https://github.com/WebKit/WebKit/commit/5d14f119e11e9b20df828804d9c76cac7517fad8
  Author: Youenn Fablet 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A 
LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt
A LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html
M Source/WebCore/workers/service/context/ServiceWorkerFetch.h
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h

  Log Message:
  ---
  Do not dispatch fetch event if its client is already cancelled
https://bugs.webkit.org/show_bug.cgi?id=276417
rdar://131072280

Reviewed by Chris Dumez.

We are adding a fetch task and cancelling it when receiving IPC messages.
We are then queuing a task on the event loop to dispatch the fetch event.
If the cancel message happens before the dispatch of the fetch event, we are no 
longer dispatching the event since it is unnecessary.
To do so, we update the ServiceWorkerFetch::Client class to add a isCancelled 
getter and use it before dispatching the event.

* 
LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https-expected.txt:
 Added.
* LayoutTests/http/wpt/service-workers/navigation-iframe-cancel.https.html: 
Added.
* Source/WebCore/workers/service/context/ServiceWorkerFetch.h:
(WebCore::ServiceWorkerFetch::Client::isCancelled const):
(WebCore::ServiceWorkerFetch::Client::cancel):
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireFetchEvent):
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::doCancel):
(WebKit::WebServiceWorkerFetchTaskClient::cancel): Deleted.
* Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:

Canonical link: https://commits.webkit.org/280819@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 72c9c0: Disable chronod when booting simulated devices for...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72c9c0bd54a86cce02e64a1b9fe8b6c3e57851b4
  
https://github.com/WebKit/WebKit/commit/72c9c0bd54a86cce02e64a1b9fe8b6c3e57851b4
  Author: Ben Schwartz 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Tools/Scripts/webkitpy/xcode/simulated_device.py
M Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py

  Log Message:
  ---
  Disable chronod when booting simulated devices for testing.
rdar://13023
https://bugs.webkit.org/show_bug.cgi?id=275623

Reviewed by Elliott Williams.

We're observing abnormally large memory usage from widgets-related processes on 
the
iOS simulator. To combat this during investigation, we should unload `chronod` 
at
simulator startup.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.Runtime.__init__): Add runtime.root (path to simulator 
runtime root).
(SimulatedDeviceManager._create_device_with_runtime): Pass runtime root path to 
device init method.
(SimulatedDevice.__init__): Add device.runtime_root (path to simulator runtime 
root).
* Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py: Update mock data 
to include runtimeRoot.

Canonical link: https://commits.webkit.org/280818@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 88b600: Debug assertion `ASSERT(editingRange.location != n...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88b600d040a8c6caf2c28647720de8087aad63de
  
https://github.com/WebKit/WebKit/commit/88b600d040a8c6caf2c28647720de8087aad63de
  Author: Richard Robinson 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebKit/Shared/EditingRange.cpp

  Log Message:
  ---
  Debug assertion `ASSERT(editingRange.location != notFound)` is frequently hit 
in Mail compose
https://bugs.webkit.org/show_bug.cgi?id=276403
rdar://131427649

Reviewed by Ryosuke Niwa.

The pattern of clients calling `selectedRangeWithCompletionHandler`, then 
passing the resulting range
to `attributedSubstringForProposedRange` is not uncommon and happens in several 
circumstances (for example,
AppKit does this when replying to an email in Mail, and WritingTools does this 
when showing the affordance).

Since it is perfectly valid for `selectedRangeWithCompletionHandler` to return 
`NSNotFound`, and also valid
for `attributedSubstringForProposedRange` to receive `NSNotFound`, and also 
results in valid behavior (when
it is notFound, the behavior is just to return the whole range of the editable 
content), this assertion can
and should be removed.

* Source/WebKit/Shared/EditingRange.cpp:
(WebKit::EditingRange::toRange):

Canonical link: https://commits.webkit.org/280817@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c49be9: Web Inspector: Add Versioned Protocol for iOS 18.0...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c49be90e170a4f8966126ca17ad32223fa95155f
  
https://github.com/WebKit/WebKit/commit/c49be90e170a4f8966126ca17ad32223fa95155f
  Author: Razvan Caliman 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A 
Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js
A 
Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js
A Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json
A Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json

  Log Message:
  ---
  Web Inspector: Add Versioned Protocol for iOS 18.0 and macOS 15.0
https://bugs.webkit.org/show_bug.cgi?id=276234
rdar://131129905

Reviewed by Devin Rousso.

Add a snapshot of protocol definitions used while inspecting iOS 18.0 and macOS 
15.0.

* 
Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/18.0/InspectorBackendCommands.js:
 Added.
* 
Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/15.0/InspectorBackendCommands.js:
 Added.
* Source/WebInspectorUI/Versions/Inspector-iOS-18.0.json: Added.
* Source/WebInspectorUI/Versions/Inspector-macOS-15.0.json: Added.

Canonical link: https://commits.webkit.org/280816@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 89f95d: Add missing `required` for RTCCodecStats dictionar...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89f95d2d94f9d1659c4a4243861bf740cfa77b8c
  
https://github.com/WebKit/WebKit/commit/89f95d2d94f9d1659c4a4243861bf740cfa77b8c
  Author: Ahmad Saleem 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/RTCStatsReport.h
M Source/WebCore/Modules/mediastream/RTCStatsReport.idl
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp

  Log Message:
  ---
  Add missing `required` for RTCCodecStats dictionary in RTCStatsReport.idl

https://bugs.webkit.org/show_bug.cgi?id=274026
rdar://problem/128306882

Reviewed by Youenn Fablet and Philippe Normand.

This patch aligns 'RTCCodecStats' as per web specification [1]:

[1] https://w3c.github.io/webrtc-stats/#dom-rtccodecstats

WebKit was missing `required` for 'payloadType', 'transportId' and
'mimeType' and this patch adds it.

* Source/WebCore/Modules/mediastream/RTCStatsReport.h:
* Source/WebCore/Modules/mediastream/RTCStatsReport.idl:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::RTCStatsReport::CodecStats::CodecStats):

Canonical link: https://commits.webkit.org/280815@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2931ba: [WPE] WPE Platform: fix handling of view to send t...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2931ba164f1ce2d8f9b0ddc448df90ad17222a68
  
https://github.com/WebKit/WebKit/commit/2931ba164f1ce2d8f9b0ddc448df90ad17222a68
  Author: Carlos Garcia Campos 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp
M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWaylandPrivate.h
M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp

  Log Message:
  ---
  [WPE] WPE Platform: fix handling of view to send touch events under wayland
https://bugs.webkit.org/show_bug.cgi?id=276423

Reviewed by Alejandro G. Castro.

Touch events are only sent to the right WPEView if the current toplevel
has the keyboard focus. We need to track the toplevel currently under
touch the same way we do for pointer and keyboard events.

* Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp:
(wpeToplevelWaylandSetIsUnderTouch):
(wpeToplevelWaylandGetVisibleViewUnderTouch):
* Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWaylandPrivate.h:
* Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp:

Canonical link: https://commits.webkit.org/280814@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04cc4a: [MSE][GStreamer] block data flow until source pad ...

[Enrique Ocaña González]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04cc4a4e2fc235ab43cc38dbe880d9ddb6b6e5dd
  
https://github.com/WebKit/WebKit/commit/04cc4a4e2fc235ab43cc38dbe880d9ddb6b6e5dd
  Author: Enrique Ocaña González 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

  Log Message:
  ---
  [MSE][GStreamer] block data flow until source pad is exposed
https://bugs.webkit.org/show_bug.cgi?id=276251

Reviewed by Xabier Rodriguez-Calvar.

In WebKitMediaSrc, there could be a race between main thread (linking
typefind element, see gsturisourcebin.c:setup_typefind) and streaming
thread (pushing data). webKitMediaSrcLoop does wait for source pad to
linked. However, there is no guarantee that peer pad is already active
at that point. This may lead to data loss while peer the pad is being
activated.

This change blocks downstream flow during pad addition, allowing
urisourcebin to link/activate typefind sink pad.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1355

Original patch by Eugene Mutavchi .

* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcEmitStreams): Add blocking probes to the Streams Pads, which 
will be removed after the pad has been added to the element.

Canonical link: https://commits.webkit.org/280813@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efacbb: Fix error in flexbox alignment overflow calculations.

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efacbbdcc42539c57f1fe9c5dcf40251ce703eef
  
https://github.com/WebKit/WebKit/commit/efacbbdcc42539c57f1fe9c5dcf40251ce703eef
  Author: Elika Etemad 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
A LayoutTests/fast/overflow/flexbox-abspos-overflow-expected.html
A LayoutTests/fast/overflow/flexbox-abspos-overflow.html
A LayoutTests/fast/overflow/flexbox-multiline-overflow-expected.html
A LayoutTests/fast/overflow/flexbox-multiline-overflow.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt
M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  ---
  Fix error in flexbox alignment overflow calculations.
https://bugs.webkit.org/show_bug.cgi?id=276382
rdar://131201271

Reviewed by Alan Baradlay.

This patch fixes the logic in contentAlignmentStartOverflow correctly
clamp overflow, by handling reversed flows properly rather than returning
an overly-large value in some cases. It also fixes the error where we only
account for the last flex line.

* LayoutTests/fast/overflow/flexbox-abspos-overflow-expected.html: Added.
* LayoutTests/fast/overflow/flexbox-abspos-overflow.html: Added.
* LayoutTests/fast/overflow/flexbox-multiline-overflow-expected.html: Added.
* LayoutTests/fast/overflow/flexbox-multiline-overflow.html: Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt:
 Partial revert of 273737@main
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt:
 Partial revert of 273737@main
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Shift reset for 
m_justifyContentStartOverflow out of the flex line loop.
(WebCore::contentAlignmentStartOverflow): Fix logic to correctly account for 
reversing.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Update call to pass 
reversing parameter.
(WebCore::RenderFlexibleBox::alignFlexLines): Update call to pass reversing 
parameter, and fix multiline handling.

Canonical link: https://commits.webkit.org/280812@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf10e5: Import updated WebCryptoAPI/derive_bits_keys from WPT

[Javier Fernandez Garcia-Boente]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf10e505bfe2c38e0b30c91e404b12f013d6237b
  
https://github.com/WebKit/WebKit/commit/cf10e505bfe2c38e0b30c91e404b12f013d6237b
  Author: Javier Fernandez 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits.js
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_bits_fixtures.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/cfrg_curves_keys.js
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.https.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length.js
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length_testcases.js
A 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/derived_bits_length_vectors.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ecdh_bits.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_1-1000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_1001-2000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_2001-3000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any.worker_3001-last-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_1-1000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_1001-2000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_2001-3000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.https.any_3001-last-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.js
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_1-1000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_1001-2000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_2001-3000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_3001-4000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_4001-5000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_5001-6000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_6001-7000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_7001-8000-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.worker_8001-last-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any_1-1000-expected.txt
M 

[webkit-changes] [WebKit/WebKit] 9a8589: margin and preferred width calculation for MathML ...

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a8589b0774a9bb9b5c19ec152cc229dc00bf0f7
  
https://github.com/WebKit/WebKit/commit/9a8589b0774a9bb9b5c19ec152cc229dc00bf0f7
  Author: Frédéric Wang 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp

  Log Message:
  ---
  margin and preferred width calculation for MathML elements
https://bugs.webkit.org/show_bug.cgi?id=276358

Reviewed by Rob Buis.

During calculation of MathML preferred widths, replace
marginLogicalWidth() with marginIntrinsicLogicalWidthForChild(), as
the margins are only set in layoutBlock (when recomputeLogicalWidth is
called).

This also fixes previous mistakes from 280733@main and 280768@main,
when margin support was introduced for mroot and msup.

* LayoutTests/TestExpectations: See 
https://bugs.webkit.org/show_bug.cgi?id=276358#c1
* 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-002-expected.txt:
 Mark all tests as PASSing.
* 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt:
 Ditto. Note that mroot was even failing for the layout, not only the preferred 
width.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt:
 Removed, same as the generic file.
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
 (WebCore::RenderMathMLFraction::computePreferredLogicalWidths): Use 
marginIntrinsicLogicalWidthForChild().
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
 (WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Add missing 
marginIntrinsicLogicalWidthForChild() for mroot's index/base.
 (WebCore::RenderMathMLRoot::layoutBlock): Use the margin box for mroot's 
index/base ().
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
 (WebCore::RenderMathMLRow::preferredLogicalWidthOfRowItems): Use 
marginIntrinsicLogicalWidthForChild().
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
 (WebCore::RenderMathMLScripts::computePreferredLogicalWidths): Use 
marginIntrinsicLogicalWidthForChild() and add one missing call.
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
 (WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths): Use 
marginIntrinsicLogicalWidthForChild().

Canonical link: https://commits.webkit.org/280810@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 487628: [Navigation] Implement NavigationDestination.getState

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4876281cfad6c0e881c669a99b48e564b7234f3e
  
https://github.com/WebKit/WebKit/commit/4876281cfad6c0e881c669a99b48e564b7234f3e
  Author: Rob Buis 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/NavigationDestination.cpp
M Source/WebCore/page/NavigationDestination.h
M Source/WebCore/page/NavigationDestination.idl

  Log Message:
  ---
  [Navigation] Implement NavigationDestination.getState
https://bugs.webkit.org/show_bug.cgi?id=276320

Reviewed by Alex Christensen.

Implement NavigationDestination.getState functionality [1].

Note that state is not set yet in the traversal case and although it
improves behaviour, it is obscured by an unrelated problem that makes
those tests fail before getState is called.

[1] 
https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-getstate

* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-navigate-expected.txt:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):
(WebCore::Navigation::dispatchPushReplaceReloadNavigateEvent):
* Source/WebCore/page/NavigationDestination.cpp:
(WebCore::NavigationDestination::getState const):
* Source/WebCore/page/NavigationDestination.h:
* Source/WebCore/page/NavigationDestination.idl:

Canonical link: https://commits.webkit.org/280809@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a4113: [GStreamer] Paused pipelines accumulate when scrol...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a41131cab31450174e2b86e985cdbcfd0c60a19
  
https://github.com/WebKit/WebKit/commit/5a41131cab31450174e2b86e985cdbcfd0c60a19
  Author: Philippe Normand 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Paused pipelines accumulate when scrolling on Reddit pages with 
many videos
https://bugs.webkit.org/show_bug.cgi?id=276296

Reviewed by Xabier Rodriguez-Calvar.

Dispose the GStreamer pipeline if the destination 
TextureMapperPlatformLayerProxy becomes inactive,
meaning that either the compositor is gone or the target layer no longer exists.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::tearDown):
(WebCore::MediaPlayerPrivateGStreamer::isPipelineWaitingPreroll const):
(WebCore::MediaPlayerPrivateGStreamer::buffered const):
(WebCore::MediaPlayerPrivateGStreamer::pausedTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
(WebCore::MediaPlayerPrivateGStreamer::setVisibleInViewport):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/280808@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e166d: [GStreamer] Caps updates fixes for VideoFrame impl...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e166d523ba140df8193012a9b4583bad59946a0
  
https://github.com/WebKit/WebKit/commit/8e166d523ba140df8193012a9b4583bad59946a0
  Author: Philippe Normand 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Caps updates fixes for VideoFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=276359

Reviewed by Xabier Rodriguez-Calvar.

Copy the caps before updating them and also make sure the sample is writable 
before changing its
caps.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrameGStreamer::setFrameRate):
(WebCore::VideoFrameGStreamer::setMaxFrameRate):

Canonical link: https://commits.webkit.org/280807@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ab89e: Fix a bug that a root for an A/B test can be prune...

[dewei-zhu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ab89ec17812da9b0187990f789cf32fad6cdff7
  
https://github.com/WebKit/WebKit/commit/7ab89ec17812da9b0187990f789cf32fad6cdff7
  Author: Dewei Zhu 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Websites/perf.webkit.org/public/include/uploaded-file-helpers.php
M Websites/perf.webkit.org/server-tests/privileged-api-upload-file-tests.js
M Websites/perf.webkit.org/server-tests/resources/test-server.js

  Log Message:
  ---
  Fix a bug that a root for an A/B test can be pruned during A/B test creation
https://bugs.webkit.org/show_bug.cgi?id=276265
rdar://122118306

Reviewed by Ryosuke Niwa.

Fix a bug that a root uploaded during creation of an A/B test can be pruned 
because of other
root upload for current test or other tests by introducing 
'uploadFileGracePeriodInHours' config.
Fix a pruning issue that file can be double counted during pruning because a 
root can be referenced
by multiple commit sets.
Improve a pruning query to use 'commitset_requires_build' isntead of 
'commitset_patch_file IS NOT NULL'
to determine if a root is built for a configuration. This increase the accuracy 
of the query because
a build request will be built if the other side of build request requires 
building.
Fix a bug that API response for '/api/upload-root' may contain stale file 
information if re-upload
happens.
Update file creation time while re-uploading a pruned file so that it will 
qualify the grace period for
a new uploaded file.

* Websites/perf.webkit.org/public/include/uploaded-file-helpers.php:
Add support for 'uploadFileGracePeriodInHours'.
Fix a bug that '/api/upload-root' does not return latest information for a 
re-uploaded file.
Fix and improve the pruning query.
* Websites/perf.webkit.org/server-tests/privileged-api-upload-file-tests.js: 
Fix and add unit tests.
* Websites/perf.webkit.org/server-tests/resources/test-server.js: Add support 
to overwrite test config.
(TestServer.prototype.start):
(TestServer.prototype.writeTestConfig):
(TestServer.prototype.overwriteTestConfig):
(TestServer.prototype.inject):
(TestServer):

Canonical link: https://commits.webkit.org/280806@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a05188: [WebXR] Fix immersive VR rendering for shared layout.

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a05188f93c2ae18909898ae4fbef87323b0f5289
  
https://github.com/WebKit/WebKit/commit/a05188f93c2ae18909898ae4fbef87323b0f5289
  Author: Dan Glastonbury 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp

  Log Message:
  ---
  [WebXR] Fix immersive VR rendering for shared layout.
https://bugs.webkit.org/show_bug.cgi?id=276402
rdar://131356393

Reviewed by Mike Wyrzykowski.

After https://commits.webkit.org/280523@main, WebXR immersive sessions render
black in simulator.

Outside of the simulator, we always blit from a staging texture to the final
output because we need to place each eye into the correct layer of a Metal
texture. In the simulator, the code tried to optimize to avoid the extra
copy. To fix the issue, I've made the shared layout case work exactly like the
layered layout case.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::blitShared):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):

Canonical link: https://commits.webkit.org/280805@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cbbcae: MediaSession artwork only uses the first item in t...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbbcae6e1ae3ca3c2b11a499fa133b07746e2820
  
https://github.com/WebKit/WebKit/commit/cbbcae6e1ae3ca3c2b11a499fa133b07746e2820
  Author: Jean-Yves Avenard 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/Modules/mediasession/MediaMetadata.cpp
M Source/WebCore/Modules/mediasession/MediaMetadata.h

  Log Message:
  ---
  MediaSession artwork only uses the first item in the artwork array
https://bugs.webkit.org/show_bug.cgi?id=276351
rdar://81160539

Reviewed by Youenn Fablet.

If `sizes` metadata artwork attribute is provided we will use them to determine 
the "best"
image to select. We do so by giving each resolution a score between 0 and 1. We 
aim to download
an image that is 512x512 with an aspect ratio of 1.
If the `sizes` attribute contains invalid content or if not provided, we will 
iterate through
all the available images and download them. We will then either select the one 
with the highest
score, or the first one found with a resolution greater than 512 pixels.

Test will be added once https://bugs.webkit.org/show_bug.cgi?id=276133 lands as 
it adds some
internal APIs to check which URL was selected with Now Playing.
For now, manually tested.

* Source/WebCore/Modules/mediasession/MediaMetadata.cpp:
(WebCore::MediaMetadata::imageDimensionsScore const):
(WebCore::MediaMetadata::refreshArtworkImage):
(WebCore::MediaMetadata::tryNextArtworkImage):
* Source/WebCore/Modules/mediasession/MediaMetadata.h:

Canonical link: https://commits.webkit.org/280804@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9e0bae: QuickLook Image dismissal animation lands in the w...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e0bae9552cc178945e9187e52a742c052056305
  
https://github.com/WebKit/WebKit/commit/9e0bae9552cc178945e9187e52a742c052056305
  Author: Abrar Rahman Protyasha 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  QuickLook Image dismissal animation lands in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=276401
rdar://129983325

Reviewed by Wenson Hsieh.

After the changes in (presumably) rdar://125669602, UIKit has started
calling into the QLPreviewControllerDelegate method
`previewController:transitionImageForPreviewItem:contentRect:` twice
during one dismissal animation. Since we transform our image bounds from
content view coordinates to window coordinates through
`convertRect:toView:`, the second delegate call returns the wrong
content rect, since by then we are in the middle of an animation and our
coordinate system has changed. This leads to the image dismissal
animation to end in the wrong place.

To work around this issue, we can compute this image bound only once per
presentation. We cache the image bound (in window coordinates) on the
first call to `previewController:transitionImageForPreviewItem:contentRect:`,
and we keep reusing it until the preview controller is dismissed, at
which point we let go of this cached value.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView previewController:transitionImageForPreviewItem:contentRect:]):
(-[WKContentView previewControllerDidDismiss:]):

Canonical link: https://commits.webkit.org/280803@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c8c3aa: REGRESSION (visionOS 2): Yahoo and AOL login pages...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8c3aac34000d459e3d3a3408a891f934d8ed262
  
https://github.com/WebKit/WebKit/commit/c8c3aac34000d459e3d3a3408a891f934d8ed262
  Author: Wenson Hsieh 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/platform/ios/LocalCurrentTraitCollection.h
M Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  ---
  REGRESSION (visionOS 2): Yahoo and AOL login pages flicker when adding a new 
Mail account
https://bugs.webkit.org/show_bug.cgi?id=276387
rdar://129308652

Reviewed by Aditya Keerthi.

On visionOS 2, after (what are probably) the changes in either rdar://117186193 
or rdar://117807846,
the following logic:

```
auto userInterfaceStyleTrait = [UITraitCollection 
traitCollectionWithUserInterfaceStyle:UIUserInterfaceStyleLight];
auto backgroundLevelTrait = [UITraitCollection 
traitCollectionWithUserInterfaceLevel:UIUserInterfaceLevelBase];
auto combinedTrait = [UITraitCollection 
traitCollectionWithTraitsFromCollections:@[ originalTrait.get(), 
userInterfaceStyleTrait, backgroundLevelTrait ]];
```

...no longer yields a `combinedTrait` that has a user interface idiom of 
`vision`, in the case
where `originalTrait` had a user interface of `vision`. Instead, the idiom 
reverts to `unspecified`,
which breaks downstream logic that attempts to override the user interface 
idiom in visionOS to be
equal to `pad`.

Subsequently, this causes `+[UIColor systemBackgroundColor]` to return 
transparent black instead of
white in `RenderThemeIOS::cssValueToSystemColorMap()`, which ultimately causes 
the page background
to be (incorrectly) transparent in `SLYahooAuthService`, leading to a flash as 
the page loads.

Interestingly...

(1) `+traitCollectionWithTraitsFromCollections:` is deprecated anyways, in 
favor of
`-traitCollectionByModifyingTraits:` or `+traitCollectionWithTraits:`.

(2) `-traitCollectionByModifyingTraits:` doesn't have the same issue, and 
adopting it fixes the bug.

With that in mind, we can address the regression by moving from the deprecated 
API to one of the
replacements (`-traitCollectionByModifyingTraits:`).

* Source/WebCore/platform/ios/LocalCurrentTraitCollection.h:
* Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm:

Adopt `-traitCollectionByModifyingTraits:`.

(WebCore::traitCollectionWithAdjustedIdiomForSystemColors):

Rename this from `adjustedTraitCollection` to 
`traitCollectionWithAdjustedIdiomForSystemColors` to
make the intent more obvious. Also, export it for use in the client layer.

(WebCore::LocalCurrentTraitCollection::LocalCurrentTraitCollection):
(WebCore::adjustedTraitCollection): Deleted.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(scrollViewBackgroundColor):

Also add a missing idiom adjustment here, when determining the scroll view 
background color. This
ensures that `+systemBackgroundColor` is white to match the iPad idiom here as 
well.

Canonical link: https://commits.webkit.org/280802@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 094276: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 094276215e5d9ad01b6d493042756767b92cf3e0
  
https://github.com/WebKit/WebKit/commit/094276215e5d9ad01b6d493042756767b92cf3e0
  Author: Fujii Hironori 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/280801@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bff583: REGRESSION(280537@main): Memory leak in `variation...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bff583f365f736bcd119a893068eda88f2b5570e
  
https://github.com/WebKit/WebKit/commit/bff583f365f736bcd119a893068eda88f2b5570e
  Author: Charlie Wolfe 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

  Log Message:
  ---
  REGRESSION(280537@main): Memory leak in `variationAxes()`
https://bugs.webkit.org/show_bug.cgi?id=276391
rdar://131414216

Reviewed by Aditya Keerthi.

`CTFontCopyFontDescriptor()` returns an object with a +1 retain count.

* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::variationAxes):

Canonical link: https://commits.webkit.org/280800@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f288b9: RemotePlayback watchAvailability callback can leak...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f288b9088d1b74b980c3b7a8d5add134f7689bdb
  
https://github.com/WebKit/WebKit/commit/f288b9088d1b74b980c3b7a8d5add134f7689bdb
  Author: Ryan Reno 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
A 
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt
A 
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak.html
A 
LayoutTests/media/media-source/resources/remoteplayback-watch-availability-frame.html
A 
LayoutTests/platform/glib/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt
M LayoutTests/resources/document-leak-test.js
M Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp
M Source/WebCore/Modules/remoteplayback/RemotePlayback.h

  Log Message:
  ---
  RemotePlayback watchAvailability callback can leak the Document object.
https://bugs.webkit.org/show_bug.cgi?id=276344
rdar://131345363

Reviewed by Ryosuke Niwa.

RemotePlayback's watchAvailibility callback can leak captures, including
the Document object, if cancelWatchAvailability is not called by the web
author. This change will clear all registered callbacks when
ActiveDOMObject::stop is called allowing the callback and captures to be
garbage collected.

* 
LayoutTests/platform/glib/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt:
 Added.
* 
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak-expected.txt:
 Added.
* 
LayoutTests/media/media-source/remoteplayback-availability-callback-does-not-leak.html:
* 
LayoutTests/media/media-source/resources/remoteplayback-watch-availability-frame.html:
* LayoutTests/resources/document-leak-test.js:
(iframeSentMessage):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:
(WebCore::RemotePlayback::stop):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.h:

Canonical link: https://commits.webkit.org/280799@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 746fa2: [iOS] Allow additional CoreMedia endpoint to suppo...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 746fa2c96a997d39da48e7886281c81c36ca04b3
  
https://github.com/WebKit/WebKit/commit/746fa2c96a997d39da48e7886281c81c36ca04b3
  Author: Brent Fulgham 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in

  Log Message:
  ---
  [iOS] Allow additional CoreMedia endpoint to support mediaserverd refactoring 
effort
https://bugs.webkit.org/show_bug.cgi?id=276386


Reviewed by Per Arne Vollan.

CoreMedia has complete additional refactoring work that requires WebKit to use 
an additional
mach endpoint on mobile platforms. No new features are exposed by this mach 
port (existing
features were moved to this connection).

WebKit needs access to 
`com.apple.coremedia.mediaplaybackd.figmetriceventtimeline.xpc to support
the new iOS 18 AVMetrics API:

https://developer.apple.com/documentation/avfoundation/avmetrics/

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/280798@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5b02a3: GARDENING: REGRESSION (280643@main): [ macOS Sonom...

[Anfernee V]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b02a3c1df44051070526ae2fb376e1eaa0c612d
  
https://github.com/WebKit/WebKit/commit/5b02a3c1df44051070526ae2fb376e1eaa0c612d
  Author: Anfernee Viduya 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M LayoutTests/platform/ios/media/video-transformed-expected.txt
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  GARDENING: REGRESSION (280643@main): [ macOS Sonoma iOS wk2] 
media/video-transformed.html is constantly failing
https://bugs.webkit.org/show_bug.cgi?id=276389
rdar://131412992

Unreviewed test gardening

Re-baseline for iOS.
Set expectation on mac wk2 since its a flaky failure.

* LayoutTests/platform/ios/media/video-transformed-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/280797@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aeeb8d: Drop WebPageTesting::m_identifier

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeeb8d70d6edbf7dcc681ab161715ed46bc31066
  
https://github.com/WebKit/WebKit/commit/aeeb8d70d6edbf7dcc681ab161715ed46bc31066
  Author: Sihui Liu 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp
M Source/WebKit/WebProcess/WebPage/WebPageTesting.h

  Log Message:
  ---
  Drop WebPageTesting::m_identifier
https://bugs.webkit.org/show_bug.cgi?id=276374
rdar://131393272

Reviewed by Charlie Wolfe.

WebPage::m_identifier is unchanged after initialization, so we could just use 
that.

* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp:
(WebKit::WebPageTesting::WebPageTesting):
(WebKit::WebPageTesting::~WebPageTesting):
* Source/WebKit/WebProcess/WebPage/WebPageTesting.h:

Canonical link: https://commits.webkit.org/280796@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e8caf: [Gardening]: [Sequoia+ Release wk2] Multiple tests...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e8caf12aec0bbd989458728fd35f7b6d18ed66f
  
https://github.com/WebKit/WebKit/commit/4e8caf12aec0bbd989458728fd35f7b6d18ed66f
  Author: Marta Darbinyan 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [Sequoia+ Release wk2] Multiple tests in 
imported/w3c/web-platform-tests/html/browsers/browsing-the-web are flaky 
failures
https://bugs.webkit.org/show_bug.cgi?id=276392
rdar://131401031

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/280795@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3771d0: Drop WebFrame::getFrameInfo()

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3771d038ccd1c794d63f6827c0410ba56f04ee4c
  
https://github.com/WebKit/WebKit/commit/3771d038ccd1c794d63f6827c0410ba56f04ee4c
  Author: Sihui Liu 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Drop WebFrame::getFrameInfo()
https://bugs.webkit.org/show_bug.cgi?id=276378
rdar://131395236

Reviewed by Charlie Wolfe.

It is the same as WebFrame::info().

* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getFrameInfo): Deleted.
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getFrameInfo):

Canonical link: https://commits.webkit.org/280794@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 280273: REGRESSION (280643@main): [ macOS Sonoma iOS wk2] ...

[Anfernee V]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 280273d47f7b25193c8ba6ff60b91a3b38ee0c0c
  
https://github.com/WebKit/WebKit/commit/280273d47f7b25193c8ba6ff60b91a3b38ee0c0c
  Author: Anfernee Viduya 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M 
LayoutTests/platform/ios/compositing/video/video-object-position-expected.txt
A 
LayoutTests/platform/mac-ventura-wk1/compositing/video/video-object-position-expected.txt
A 
LayoutTests/platform/mac-ventura/compositing/video/video-object-fit-expected.txt
A 
LayoutTests/platform/mac-ventura/compositing/video/video-object-position-expected.txt
M LayoutTests/platform/mac/compositing/video/video-object-fit-expected.txt
A 
LayoutTests/platform/mac/compositing/video/video-object-position-expected.txt

  Log Message:
  ---
  REGRESSION (280643@main): [ macOS Sonoma iOS wk2] 2x 
compositing/video/video-object-* are constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=276260
rdar://131182735

Unreviewed test re-baseline

Re-baselining constantly failing test.

* LayoutTests/platform/ios/compositing/video/video-object-position-expected.txt:
* 
LayoutTests/platform/mac-ventura/compositing/video/video-object-fit-expected.txt:
 Copied from 
LayoutTests/platform/mac/compositing/video/video-object-fit-expected.txt.
* LayoutTests/platform/mac/compositing/video/video-object-fit-expected.txt:
* 
LayoutTests/platform/mac/compositing/video/video-object-position-expected.txt: 
Copied from 
LayoutTests/platform/ios/compositing/video/video-object-position-expected.txt.

Canonical link: https://commits.webkit.org/280793@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 971540: REGRESSION (280542@main): Unable to select text af...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97154054bc3972ec909071838bba2c7cca25db47
  
https://github.com/WebKit/WebKit/commit/97154054bc3972ec909071838bba2c7cca25db47
  Author: Aditya Keerthi 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/editing/cocoa/HTMLConverter.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  ---
  REGRESSION (280542@main): Unable to select text after using Writing Tools to 
summarize
https://bugs.webkit.org/show_bug.cgi?id=276372
rdar://131388499

Reviewed by Richard Robinson.

280542@main introduced a Web Content hang when generating attributed strings
for Writing Tools, due to the use of `HashMap::ensure` with a recursive method.

Fix by using `HashMap::contains` instead.

* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(hasAncestorQualifyingForWritingToolsPreservation):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, EphemeralSessionWithDeeplyNestedContent)):

Canonical link: https://commits.webkit.org/280792@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b4bb62: Create PermissionsPolicy from Document

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4bb6216f8304dd9e2bab2648aad261546d4dad5
  
https://github.com/WebKit/WebKit/commit/b4bb6216f8304dd9e2bab2648aad261546d4dad5
  Author: Sihui Liu 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/Document.cpp
A Source/WebCore/html/Allowlist.h
A Source/WebCore/html/OwnerPermissionsPolicyData.h
M Source/WebCore/html/PermissionsPolicy.cpp
M Source/WebCore/html/PermissionsPolicy.h
M Source/WebCore/page/LocalFrame.h

  Log Message:
  ---
  Create PermissionsPolicy from Document
https://bugs.webkit.org/show_bug.cgi?id=276353
rdar://131357201

Reviewed by Youenn Fablet.

This patch makes a few changes that will help add support for permissions 
policy with site isolation:
1. Replace BitSet with HashSet for InheritedPolicy in PermissionsPolicy, so 
that we could use strongly typed enum for
getting and setting, which makes the code easier to understand and it is more 
safe to use it in IPC later. (We will
need to pass the policy between UI process and web processes).
2. Introduce OwnerPermissionsPolicyData struct, which contains information that 
Document needs from its owner element to
compute permissions policy. With site isolation, Document may not have access 
to owner element, so we need to store the
information elsewhere. In this patch, we store it in LocalFrame.
3. Allow PermissionsPolicy to be created from Document, and PermissionsPolicy 
can decide whether to construct object
from owner element or owner policy.
4. Split Allowlist from PermissionsPolicy so that it's easier to add IPC 
serialization format for it later.

The owner policy of LocalFrame is not set yet, so there is no behavior change.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::permissionsPolicy const):
* Source/WebCore/html/Allowlist.h: Added.
(WebCore::Allowlist::Allowlist):
(WebCore::Allowlist::origins const):
(WebCore::Allowlist::matches const):
* Source/WebCore/html/OwnerPermissionsPolicyData.h: Added.
(WebCore::OwnerPermissionsPolicyData::OwnerPermissionsPolicyData):
* Source/WebCore/html/PermissionsPolicy.cpp:
(WebCore::forEachFeature):
(WebCore::parseAllowlist):
(WebCore::PermissionsPolicy::processPermissionsPolicyAttribute):
(WebCore::featureValueForOrigin):
(WebCore::PermissionsPolicy::computeInheritedPolicyValueInContainer const):
(WebCore::PermissionsPolicy::inheritedPolicyValueForFeature const):
(WebCore::PermissionsPolicy::PermissionsPolicy):
(WebCore::PermissionsPolicy::Allowlist::matches const): Deleted.
(WebCore::index): Deleted.
* Source/WebCore/html/PermissionsPolicy.h:
(WebCore::PermissionsPolicy::PermissionsPolicy):
(WebCore::PermissionsPolicy::inheritedPolicy const):
(): Deleted.
(WebCore::PermissionsPolicy::Allowlist::Allowlist): Deleted.
* Source/WebCore/page/LocalFrame.h:

Canonical link: https://commits.webkit.org/280791@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6fd96: [cocoa] Improve respecting X-Content-Type-Options:...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6fd96e4f3a29cd55a3bf351660298e6dddc0b9a
  
https://github.com/WebKit/WebKit/commit/f6fd96e4f3a29cd55a3bf351660298e6dddc0b9a
  Author: Matthew Finkel 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
A LayoutTests/http/tests/mime/html-with-html-expected.txt
A LayoutTests/http/tests/mime/html-with-html.html
A LayoutTests/http/tests/mime/html-with-nosniff-html-expected.txt
A LayoutTests/http/tests/mime/html-with-nosniff-html.html
M LayoutTests/http/tests/mime/resources/.htaccess
A LayoutTests/http/tests/mime/resources/html-document.html
A LayoutTests/http/tests/mime/resources/nosniff-html.html
A 
LayoutTests/platform/glib/http/tests/mime/html-with-nosniff-html-expected.txt
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations
M Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm
M 
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
M Source/WebCore/platform/network/mac/WebCoreURLResponse.h
M Source/WebCore/platform/network/mac/WebCoreURLResponse.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  ---
  [cocoa] Improve respecting X-Content-Type-Options: nosniff
https://bugs.webkit.org/show_bug.cgi?id=274242
rdar://109049343

Reviewed by Alex Christensen.

Respect the X-Content-Type-Options: nosniff header, instead of trying to guess
the best MIME type for the document based on the file extension.

Also convert isMainResourceLoad into an enum class, so it's consistent with 
isNoSniffSet.

* LayoutTests/http/tests/mime/html-with-html-expected.txt: Added.
* LayoutTests/http/tests/mime/html-with-html.html: Added.
* LayoutTests/http/tests/mime/html-with-nosniff-html-expected.txt: Added.
* LayoutTests/http/tests/mime/html-with-nosniff-html.html: Added.
* LayoutTests/http/tests/mime/resources/.htaccess:
* LayoutTests/http/tests/mime/resources/html-document.html: Added.
* LayoutTests/http/tests/mime/resources/nosniff-html.html: Added.
* 
LayoutTests/platform/glib/http/tests/mime/html-with-nosniff-html-expected.txt: 
Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
* 
Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate 
connection:didReceiveResponse:]):
* Source/WebCore/platform/network/mac/WebCoreURLResponse.h:
* Source/WebCore/platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate 
URLSession:dataTask:didReceiveResponse:completionHandler:]):

Canonical link: https://commits.webkit.org/280790@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c35467: [WebGPU] OOB buffer access as offset is not consid...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c354673f409eb379afab8a289de881ad2fa968e3
  
https://github.com/WebKit/WebKit/commit/c354673f409eb379afab8a289de881ad2fa968e3
  Author: Mike Wyrzykowski 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] OOB buffer access as offset is not considered in max vertex counts
https://bugs.webkit.org/show_bug.cgi?id=276368


Reviewed by Tadeu Zagallo.

Vertex / instance count calculations failed to account for the buffer offset.

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount const):

Canonical link: https://commits.webkit.org/280789@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 862f9b: [CSS] Use "enum class" for AllowedRules and RuleTy...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 862f9be99bf8270a492823b80df82404ebde1b1d
  
https://github.com/WebKit/WebKit/commit/862f9be99bf8270a492823b80df82404ebde1b1d
  Author: Matthieu Dubet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSParserImpl.cpp
M Source/WebCore/css/parser/CSSParserImpl.h
M Source/WebCore/inspector/InspectorStyleSheet.cpp

  Log Message:
  ---
  [CSS] Use "enum class" for AllowedRules and RuleType in CSSParserImpl
https://bugs.webkit.org/show_bug.cgi?id=276345

Reviewed by Tim Nguyen.

* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::parseRule):
(WebCore::CSSParserImpl::parseStyleSheet):
(WebCore::CSSParserImpl::parseStyleSheetForInspector):
(WebCore::computeNewAllowedRules):
(WebCore::CSSParserImpl::consumeRuleList):
(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeQualifiedRule):
(WebCore::CSSParserImpl::consumeNestedGroupRules):
(WebCore::CSSParserImpl::consumeFontFeatureValuesRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumeBlockContent):
* Source/WebCore/css/parser/CSSParserImpl.h:
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::isValidRuleHeaderText):

Canonical link: https://commits.webkit.org/280788@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c9d0f: [ews] Reduce accumulation of pending build-request...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c9d0f2ee7c56183f27826b2d845ffc5dbe12dff
  
https://github.com/WebKit/WebKit/commit/3c9d0f2ee7c56183f27826b2d845ffc5dbe12dff
  Author: Aakash Jain 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews] Reduce accumulation of pending build-requests in testing environments
https://bugs.webkit.org/show_bug.cgi?id=276373

Reviewed by Sam Sneddon.

Reduce accumulation of pending build-requests by ignoring 90% of the PRs in
testing environment.

* Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits.handle_pull_request):

Canonical link: https://commits.webkit.org/280787@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec6570: [Cocoa] Do not include libwebrtc static libraries ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec65702b7bf4cc2ed99ff22ce103a4cdb0f9f23a
  
https://github.com/WebKit/WebKit/commit/ec65702b7bf4cc2ed99ff22ce103a4cdb0f9f23a
  Author: Youenn Fablet 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig

  Log Message:
  ---
  [Cocoa] Do not include libwebrtc static libraries in SDK except for boringssl
https://bugs.webkit.org/show_bug.cgi?id=268910
rdar://122345708

Reviewed by Elliott Williams and Eric Carlson.

This is unnecessary since we are using the dylib instead, and avoids other 
applications using those libraries.

* Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
* Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:

Canonical link: https://commits.webkit.org/280786@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes