[webkit-changes] [214226] trunk/Source/WebCore

[simon . fraser]

Title: [214226] trunk/Source/WebCore








Revision 214226
Author simon.fra...@apple.com
Date 2017-03-21 11:18:35 -0700 (Tue, 21 Mar 2017)


Log Message
Remove logging left in by mistake.

* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::willBeDestroyed):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (214225 => 214226)

--- trunk/Source/WebCore/ChangeLog	2017-03-21 16:54:04 UTC (rev 214225)
+++ trunk/Source/WebCore/ChangeLog	2017-03-21 18:18:35 UTC (rev 214226)
@@ -1,3 +1,10 @@
+2017-03-21  Simon Fraser  
+
+Remove logging left in by mistake.
+
+* rendering/RenderNamedFlowThread.cpp:
+(WebCore::RenderNamedFlowThread::willBeDestroyed):
+
 2017-03-21  Jon Lee  
 
 Clean up RTCSdpType, RTC enums and headers


Modified: trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp (214225 => 214226)

--- trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2017-03-21 16:54:04 UTC (rev 214225)
+++ trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp	2017-03-21 18:18:35 UTC (rev 214226)
@@ -61,8 +61,6 @@
 
 void RenderNamedFlowThread::willBeDestroyed()
 {
-WTFLogAlways("RenderNamedFlowThread %p willBeDestroyed", this);
-
 // The flow thread can be destroyed without unregistering the content nodes if the document is destroyed.
 // This can lead to problems because the nodes are still marked as belonging to a flow thread.
 clearContentElements();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214211] trunk/LayoutTests/imported/w3c

[jonlee]

Title: [214211] trunk/LayoutTests/imported/w3c








Revision 214211
Author jon...@apple.com
Date 2017-03-20 23:07:14 -0700 (Mon, 20 Mar 2017)


Log Message
Update progression in wpt test for WebRTC.

* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (214210 => 214211)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-21 03:27:48 UTC (rev 214210)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-21 06:07:14 UTC (rev 214211)
@@ -1,3 +1,9 @@
+2017-03-20  Jon Lee  
+
+Update progression in wpt test for WebRTC.
+
+* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
+
 2017-03-19  Chris Dumez  
 
 Implement self.origin


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt (214210 => 214211)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt	2017-03-21 03:27:48 UTC (rev 214210)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt	2017-03-21 06:07:14 UTC (rev 214211)
@@ -88,9 +88,7 @@
 FAIL new RTCPeerConnection({ certificates: [undefined] }) assert_throws: function "function () {
 eval(expr);
   }" did not throw
-FAIL new RTCPeerConnection({ iceCandidatePoolSize: toNumberThrows }) assert_throws: function "function () {
-eval(expr);
-  }" did not throw
+PASS new RTCPeerConnection({ iceCandidatePoolSize: toNumberThrows }) 
 FAIL new RTCPeerConnection({ certificates: [certificate] }) RTCPeerConnection.generateCertificate is not a function. (In 'RTCPeerConnection.generateCertificate({ name: "ECDSA", namedCurve: "P-256" })', 'RTCPeerConnection.generateCertificate' is undefined)
 FAIL new RTCPeerConnection({ certificates: [expiredCertificate] }) RTCPeerConnection.generateCertificate is not a function. (In 'RTCPeerConnection.generateCertificate({ name: "ECDSA", namedCurve: "P-256", expires: 0 })', 'RTCPeerConnection.generateCertificate' is undefined)
 PASS localDescription initial value 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214214] trunk/LayoutTests

[carlosgc]

Title: [214214] trunk/LayoutTests








Revision 214214
Author carlo...@webkit.org
Date 2017-03-21 01:59:27 -0700 (Tue, 21 Mar 2017)


Log Message
Unreviewed GTK+ gardening. Mark several tests as failing and skip others.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214213 => 214214)

--- trunk/LayoutTests/ChangeLog	2017-03-21 08:34:50 UTC (rev 214213)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 08:59:27 UTC (rev 214214)
@@ -1,3 +1,9 @@
+2017-03-21  Carlos Garcia Campos  
+
+Unreviewed GTK+ gardening. Mark several tests as failing and skip others.
+
+* platform/gtk/TestExpectations:
+
 2017-03-20  Jon Lee  
 
 Add iceCandidatePoolSize to RTCConfiguration


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214213 => 214214)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 08:34:50 UTC (rev 214213)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 08:59:27 UTC (rev 214214)
@@ -342,6 +342,7 @@
 webrtc/peer-connection-remote-audio-mute2.html [ Failure ]
 webrtc/video-mute.html [ Failure ]
 webrtc/video-remote-mute.html [ Failure ]
+webrtc/video-with-receiver.html [ Failure ]
 imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html [ Failure ]
 imported/w3c/web-platform-tests/webrtc/no-media-call.html [ Failure ]
 imported/w3c/web-platform-tests/webrtc/promises-call.html [ Failure ]
@@ -366,6 +367,7 @@
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html [ Failure ]
+webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-closed-state.html [ Crash ]
 webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Failure ]
@@ -903,6 +905,9 @@
 fast/animation/request-animation-frame-throttling-detached-iframe.html [ Failure ]
 fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ]
 
+# WebGPU is not enabled on GTK+.
+fast/canvas/webgpu [ Skip ]
+
 #
 # End of Expected failures
 #
@@ -2980,6 +2985,12 @@
 webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ]
 webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ]
 
+webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-raised-rl.html [ ImageOnlyFailure ]
+webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-raised.html [ ImageOnlyFailure ]
+webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-sunken-rl.html [ ImageOnlyFailure ]
+webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-sunken.html [ ImageOnlyFailure ]
+
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214215] trunk

[commit-queue]

Title: [214215] trunk








Revision 214215
Author commit-qu...@webkit.org
Date 2017-03-21 02:11:05 -0700 (Tue, 21 Mar 2017)


Log Message
[GTK] Add function webkit_dom_element_get_bounding_client_rect
https://bugs.webkit.org/show_bug.cgi?id=163892

Patch by Aidan Holm  on 2017-03-21
Reviewed by Carlos Garcia Campos.

Wrap WebCore::ClientRect as WebKitDOMClientRect.
Wrap WebCore::ClientRectList as WebKitDOMClientRectList.
Implement webkit_dom_element_get_bounding_client_rect().
Implement webkit_dom_element_get_client_rects().

* PlatformGTK.cmake:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp: Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp: Added.
(WebKit::kit):
(WebKit::core):
(WebKit::wrapClientRect):
(webkit_dom_client_rect_finalize):
(webkit_dom_client_rect_get_property):
(webkit_dom_client_rect_constructed):
(webkit_dom_client_rect_class_init):
(webkit_dom_client_rect_init):
(webkit_dom_client_rect_get_top):
(webkit_dom_client_rect_get_right):
(webkit_dom_client_rect_get_bottom):
(webkit_dom_client_rect_get_left):
(webkit_dom_client_rect_get_width):
(webkit_dom_client_rect_get_height):
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.h: Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectPrivate.h: Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.h: Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectListPrivate.h: Added.
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:
(webkit_dom_element_get_property):
(webkit_dom_element_class_init):
(webkit_dom_element_get_scroll_height):
(webkit_dom_element_get_bounding_client_rect):
(webkit_dom_element_get_client_rects):
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:
(WebKit::wrap):
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.h:
* WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt:
* WebProcess/InjectedBundle/API/gtk/DOM/webkitdom.h:
* WebProcess/InjectedBundle/API/gtk/DOM/webkitdomautocleanups.h:
* WebProcess/InjectedBundle/API/gtk/DOM/webkitdomdefines.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/webkitdom.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/webkitdomautocleanups.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/webkitdomdefines.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt


Added Paths

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectListPrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectPrivate.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (214214 => 214215)

--- trunk/Source/WebKit2/ChangeLog	2017-03-21 08:59:27 UTC (rev 214214)
+++ trunk/Source/WebKit2/ChangeLog	2017-03-21 09:11:05 UTC (rev 214215)
@@ -1,3 +1,51 @@
+2017-03-21  Aidan Holm  
+
+[GTK] Add function webkit_dom_element_get_bounding_client_rect
+https://bugs.webkit.org/show_bug.cgi?id=163892
+
+Reviewed by Carlos Garcia Campos.
+
+Wrap WebCore::ClientRect as WebKitDOMClientRect.
+Wrap WebCore::ClientRectList as WebKitDOMClientRectList.
+Implement webkit_dom_element_get_bounding_client_rect().
+Implement webkit_dom_element_get_client_rects().
+
+* PlatformGTK.cmake:
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp: Added.
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp: Added.
+(WebKit::kit):
+(WebKit::core):
+(WebKit::wrapClientRect):
+(webkit_dom_client_rect_finalize):
+(webkit_dom_client_rect_get_property):
+(webkit_dom_client_rect_constructed):
+(webkit_dom_client_rect_class_init):
+(webkit_dom_client_rect_init):
+(webkit_dom_client_rect_get_top):
+(webkit_dom_client_rect_get_right):
+(webkit_dom_client_rect_get_bottom):
+(webkit_dom_client_rect_get_left):
+(webkit_dom_client_rect_get_width):
+(webkit_dom_client_rect_get_height):
+* 

[webkit-changes] [214213] trunk/Source/JavaScriptCore

[commit-queue]

Title: [214213] trunk/Source/_javascript_Core








Revision 214213
Author commit-qu...@webkit.org
Date 2017-03-21 01:34:50 -0700 (Tue, 21 Mar 2017)


Log Message
[jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.
https://bugs.webkit.org/show_bug.cgi?id=169717

Patch by Zan Dobersek  on 2017-03-21
Reviewed by Yusuke Suzuki.

* assembler/MacroAssembler.h: Expose branchPtr() on MIPS as well.
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchPtr): Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (214212 => 214213)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-21 07:50:04 UTC (rev 214212)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-21 08:34:50 UTC (rev 214213)
@@ -1,3 +1,14 @@
+2017-03-21  Zan Dobersek  
+
+[jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.
+https://bugs.webkit.org/show_bug.cgi?id=169717
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/MacroAssembler.h: Expose branchPtr() on MIPS as well.
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::branchPtr): Added.
+
 2017-03-20  Filip Pizlo  
 
 Graph coloring should use coalescable moves when spilling


Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (214212 => 214213)

--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2017-03-21 07:50:04 UTC (rev 214212)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2017-03-21 08:34:50 UTC (rev 214213)
@@ -117,7 +117,7 @@
 using MacroAssemblerBase::and32;
 using MacroAssemblerBase::branchAdd32;
 using MacroAssemblerBase::branchMul32;
-#if CPU(ARM64) || CPU(ARM_THUMB2) || CPU(ARM_TRADITIONAL) || CPU(X86_64)
+#if CPU(ARM64) || CPU(ARM_THUMB2) || CPU(ARM_TRADITIONAL) || CPU(X86_64) || CPU(MIPS)
 using MacroAssemblerBase::branchPtr;
 #endif
 using MacroAssemblerBase::branchSub32;


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h (214212 => 214213)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h	2017-03-21 07:50:04 UTC (rev 214212)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h	2017-03-21 08:34:50 UTC (rev 214213)
@@ -1512,6 +1512,12 @@
 return branch32(cond, dataTempRegister, immTempRegister);
 }
 
+Jump branchPtr(RelationalCondition cond, BaseIndex left, RegisterID right)
+{
+load32(left, dataTempRegister);
+return branch32(cond, dataTempRegister, right);
+}
+
 Jump branch32(RelationalCondition cond, RegisterID left, RegisterID right)
 {
 if (cond == Equal)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214216] trunk/LayoutTests

[carlosgc]

Title: [214216] trunk/LayoutTests








Revision 214216
Author carlo...@webkit.org
Date 2017-03-21 02:12:45 -0700 (Tue, 21 Mar 2017)


Log Message
Unreviewed GTK+ gardening. Mark more tests that are failing.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214215 => 214216)

--- trunk/LayoutTests/ChangeLog	2017-03-21 09:11:05 UTC (rev 214215)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 09:12:45 UTC (rev 214216)
@@ -1,5 +1,11 @@
 2017-03-21  Carlos Garcia Campos  
 
+Unreviewed GTK+ gardening. Mark more tests that are failing.
+
+* platform/gtk/TestExpectations:
+
+2017-03-21  Carlos Garcia Campos  
+
 Unreviewed GTK+ gardening. Mark several tests as failing and skip others.
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214215 => 214216)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 09:11:05 UTC (rev 214215)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 09:12:45 UTC (rev 214216)
@@ -561,6 +561,7 @@
 webkit.org/b/131347 fast/hidpi/image-set-background-dynamic.html [ Failure Pass Missing ]
 webkit.org/b/131347 fast/hidpi/image-set-border-image-dynamic.html [ Failure Pass Missing ]
 webkit.org/b/131347 fast/hidpi/image-srcset-png-canvas.html [ ImageOnlyFailure Pass ]
+webkit.org/b/131347 fast/hidpi/percent-height-image-nested.html [ ImageOnlyFailure ]
 webkit.org/b/131347 fast/hidpi/video-controls-in-hidpi.html [ Failure ]
 webkit.org/b/131347 fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ ImageOnlyFailure ]
 webkit.org/b/131347 fast/inline/hidpi-inline-selection-leaves-gap.html [ ImageOnlyFailure ]
@@ -2989,7 +2990,9 @@
 webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-raised.html [ ImageOnlyFailure ]
 webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-sunken-rl.html [ ImageOnlyFailure ]
 webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-sunken.html [ ImageOnlyFailure ]
+webkit.org/b/169909 fast/block/lineboxcontain/block-with-ideographs.xhtml [ Failure ]
 
+webkit.org/b/169910 fast/multicol/simple-line-layout-line-index-after-strut.html [ ImageOnlyFailure ]
 
 #
 # End of non-crashing, non-flaky tests failing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214218] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [214218] trunk/Source/_javascript_Core








Revision 214218
Author utatane@gmail.com
Date 2017-03-21 04:16:47 -0700 (Tue, 21 Mar 2017)


Log Message
[JSC] Add JSPromiseDeferred::reject(ExecState*, Exception*) interface
https://bugs.webkit.org/show_bug.cgi?id=169908

Reviewed by Sam Weinig.

To avoid calling reject(ExecState*, JSValue) with Exception* accidentally,
we add a new interface reject(ExecState*, Exception*).
Such an interface is already added in DOMPromise in WebCore.

* runtime/JSInternalPromiseDeferred.cpp:
(JSC::JSInternalPromiseDeferred::reject):
* runtime/JSInternalPromiseDeferred.h:
* runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::reject):
* runtime/JSPromiseDeferred.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.cpp
trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.h
trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.cpp
trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (214217 => 214218)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-21 09:43:14 UTC (rev 214217)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-21 11:16:47 UTC (rev 214218)
@@ -1,3 +1,21 @@
+2017-03-21  Yusuke Suzuki  
+
+[JSC] Add JSPromiseDeferred::reject(ExecState*, Exception*) interface
+https://bugs.webkit.org/show_bug.cgi?id=169908
+
+Reviewed by Sam Weinig.
+
+To avoid calling reject(ExecState*, JSValue) with Exception* accidentally,
+we add a new interface reject(ExecState*, Exception*).
+Such an interface is already added in DOMPromise in WebCore.
+
+* runtime/JSInternalPromiseDeferred.cpp:
+(JSC::JSInternalPromiseDeferred::reject):
+* runtime/JSInternalPromiseDeferred.h:
+* runtime/JSPromiseDeferred.cpp:
+(JSC::JSPromiseDeferred::reject):
+* runtime/JSPromiseDeferred.h:
+
 2017-03-21  Zan Dobersek  
 
 [jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.


Modified: trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.cpp (214217 => 214218)

--- trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.cpp	2017-03-21 09:43:14 UTC (rev 214217)
+++ trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.cpp	2017-03-21 11:16:47 UTC (rev 214218)
@@ -75,4 +75,9 @@
 return promise();
 }
 
+JSInternalPromise* JSInternalPromiseDeferred::reject(ExecState* exec, Exception* reason)
+{
+return reject(exec, reason->value());
+}
+
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.h (214217 => 214218)

--- trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.h	2017-03-21 09:43:14 UTC (rev 214217)
+++ trunk/Source/_javascript_Core/runtime/JSInternalPromiseDeferred.h	2017-03-21 11:16:47 UTC (rev 214218)
@@ -48,6 +48,7 @@
 JS_EXPORT_PRIVATE JSInternalPromise* promise() const;
 JS_EXPORT_PRIVATE JSInternalPromise* resolve(ExecState*, JSValue);
 JS_EXPORT_PRIVATE JSInternalPromise* reject(ExecState*, JSValue);
+JS_EXPORT_PRIVATE JSInternalPromise* reject(ExecState*, Exception*);
 
 private:
 JSInternalPromiseDeferred(VM&);


Modified: trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.cpp (214217 => 214218)

--- trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.cpp	2017-03-21 09:43:14 UTC (rev 214217)
+++ trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.cpp	2017-03-21 11:16:47 UTC (rev 214218)
@@ -106,6 +106,11 @@
 callFunction(exec, m_reject.get(), reason);
 }
 
+void JSPromiseDeferred::reject(ExecState* exec, Exception* reason)
+{
+reject(exec, reason->value());
+}
+
 void JSPromiseDeferred::finishCreation(VM& vm, JSObject* promise, JSValue resolve, JSValue reject)
 {
 Base::finishCreation(vm);


Modified: trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.h (214217 => 214218)

--- trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.h	2017-03-21 09:43:14 UTC (rev 214217)
+++ trunk/Source/_javascript_Core/runtime/JSPromiseDeferred.h	2017-03-21 11:16:47 UTC (rev 214218)
@@ -30,6 +30,7 @@
 
 namespace JSC {
 
+class Exception;
 class JSPromiseConstructor;
 
 class JSPromiseDeferred : public JSCell {
@@ -53,6 +54,7 @@
 
 JS_EXPORT_PRIVATE void resolve(ExecState*, JSValue);
 JS_EXPORT_PRIVATE void reject(ExecState*, JSValue);
+JS_EXPORT_PRIVATE void reject(ExecState*, Exception*);
 
 protected:
 JSPromiseDeferred(VM&, Structure*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214217] trunk/LayoutTests

[carlosgc]

Title: [214217] trunk/LayoutTests








Revision 214217
Author carlo...@webkit.org
Date 2017-03-21 02:43:14 -0700 (Tue, 21 Mar 2017)


Log Message
Unreviewed GTK+ gardening. Remove duplicated entry.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214216 => 214217)

--- trunk/LayoutTests/ChangeLog	2017-03-21 09:12:45 UTC (rev 214216)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 09:43:14 UTC (rev 214217)
@@ -1,5 +1,11 @@
 2017-03-21  Carlos Garcia Campos  
 
+Unreviewed GTK+ gardening. Remove duplicated entry.
+
+* platform/gtk/TestExpectations:
+
+2017-03-21  Carlos Garcia Campos  
+
 Unreviewed GTK+ gardening. Mark more tests that are failing.
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214216 => 214217)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 09:12:45 UTC (rev 214216)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 09:43:14 UTC (rev 214217)
@@ -361,13 +361,11 @@
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-ice.html [ Timeout ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-statsSelector.html [ Failure ]
-webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Timeout Pass ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html [ Failure ]
-webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-closed-state.html [ Crash ]
 webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214240] trunk/Source/JavaScriptCore

[mark . lam]

Title: [214240] trunk/Source/_javascript_Core








Revision 214240
Author mark@apple.com
Date 2017-03-21 18:55:00 -0700 (Tue, 21 Mar 2017)


Log Message
The DFG Integer Check Combining phase should force an OSR exit for CheckInBounds on a negative constant min bound.
https://bugs.webkit.org/show_bug.cgi?id=169933


Reviewed by Filip Pizlo and Geoffrey Garen.

Also fixed the bit-rotted RangeKey::dump() function.

* dfg/DFGIntegerCheckCombiningPhase.cpp:
(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGIntegerCheckCombiningPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (214239 => 214240)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-22 01:44:21 UTC (rev 214239)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-22 01:55:00 UTC (rev 214240)
@@ -1,3 +1,16 @@
+2017-03-21  Mark Lam  
+
+The DFG Integer Check Combining phase should force an OSR exit for CheckInBounds on a negative constant min bound.
+https://bugs.webkit.org/show_bug.cgi?id=169933
+
+
+Reviewed by Filip Pizlo and Geoffrey Garen.
+
+Also fixed the bit-rotted RangeKey::dump() function.
+
+* dfg/DFGIntegerCheckCombiningPhase.cpp:
+(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
+
 2017-03-21  Csaba Osztrogonác  
 
 [ARM] Add missing MacroAssembler functions after r214187


Modified: trunk/Source/_javascript_Core/dfg/DFGIntegerCheckCombiningPhase.cpp (214239 => 214240)

--- trunk/Source/_javascript_Core/dfg/DFGIntegerCheckCombiningPhase.cpp	2017-03-22 01:44:21 UTC (rev 214239)
+++ trunk/Source/_javascript_Core/dfg/DFGIntegerCheckCombiningPhase.cpp	2017-03-22 01:55:00 UTC (rev 214240)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -105,7 +105,16 @@
 out.print("ArrayBounds(");
 break;
 }
-out.print(m_source, ", ", m_key, ")");
+if (m_source)
+out.print(m_source);
+else
+out.print("null");
+out.print(", ");
+if (m_key)
+out.print(m_key);
+else
+out.print("null");
+out.print(")");
 }
 
 RangeKind m_kind;
@@ -249,7 +258,13 @@
 Node* maxNode;
 
 if (!data.m_key.m_source) {
-minNode = 0;
+// data.m_key.m_source being null means that we're comparing against int32 constants (see rangeKeyAndAddend()).
+// Since CheckInBounds does an unsigned comparison, if the minBound >= 0, it is also covered by the
+// maxBound comparison. However, if minBound < 0, then CheckInBounds should always fail its speculation check.
+// We'll force an OSR exit in that case.
+minNode = nullptr;
+if (range.m_minBound < 0)
+m_insertionSet.insertNode(nodeIndex, SpecNone, ForceOSRExit, node->origin);
 maxNode = m_insertionSet.insertConstant(
 nodeIndex, maxOrigin, jsNumber(range.m_maxBound));
 } else {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214238] trunk/Tools

[aakash_jain]

Title: [214238] trunk/Tools








Revision 214238
Author aakash_j...@apple.com
Date 2017-03-21 17:45:15 -0700 (Tue, 21 Mar 2017)


Log Message
EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
https://bugs.webkit.org/show_bug.cgi?id=169937


Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title. 
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (214237 => 214238)

--- trunk/Tools/ChangeLog	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/ChangeLog	2017-03-22 00:45:15 UTC (rev 214238)
@@ -1,5 +1,17 @@
 2017-03-21  Aakash Jain  
 
+EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
+https://bugs.webkit.org/show_bug.cgi?id=169937
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title. 
+* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
+
+2017-03-21  Aakash Jain  
+
 ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
 https://bugs.webkit.org/show_bug.cgi?id=169927
 


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (214237 => 214238)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-22 00:45:15 UTC (rev 214238)
@@ -486,11 +486,14 @@
 
 def _parse_bug_id_from_attachment_page(self, page):
 # The "Up" relation happens to point to the bug.
-up_link = BeautifulSoup(page).find('link', rel='Up')
-if not up_link:
+title = BeautifulSoup(page).find('div', attrs={'id':'bug_title'})
+if not title :
 _log.warning("This attachment does not exist (or you don't have permissions to view it).")
 return None
-match = re.search("show_bug.cgi\?id=(?P\d+)", up_link['href'])
+match = re.search("show_bug.cgi\?id=(?P\d+)", str(title))
+if not match:
+_log.warning("Unable to parse bug id from attachment")
+return None
 return int(match.group('bug_id'))
 
 def bug_id_for_attachment_id(self, attachment_id):


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py (214237 => 214238)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py	2017-03-22 00:08:40 UTC (rev 214237)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py	2017-03-22 00:45:15 UTC (rev 214238)
@@ -238,8 +238,9 @@
   
 
   Attachment 41073 Details for Bug 27314
-+
+  Attachment 41073 Details for
+  : Sample bug
 """
 
 def test_attachment_detail_bug_parsing(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214239] trunk

[mrajca]

Title: [214239] trunk








Revision 214239
Author mra...@apple.com
Date 2017-03-21 18:44:21 -0700 (Tue, 21 Mar 2017)


Log Message
Loosen audio playback restrictions when the volume is 0.
https://bugs.webkit.org/show_bug.cgi?id=169897

Reviewed by Eric Carlson.

Source/WebCore:

Added API tests.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Added.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (214238 => 214239)

--- trunk/Source/WebCore/ChangeLog	2017-03-22 00:45:15 UTC (rev 214238)
+++ trunk/Source/WebCore/ChangeLog	2017-03-22 01:44:21 UTC (rev 214239)
@@ -1,3 +1,15 @@
+2017-03-20  Matt Rajca  
+
+Loosen audio playback restrictions when the volume is 0.
+https://bugs.webkit.org/show_bug.cgi?id=169897
+
+Reviewed by Eric Carlson.
+
+Added API tests.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::playbackPermitted):
+
 2017-03-21  Brady Eidson  
 
 Disable all virtual tables.


Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (214238 => 214239)

--- trunk/Source/WebCore/html/MediaElementSession.cpp	2017-03-22 00:45:15 UTC (rev 214238)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp	2017-03-22 01:44:21 UTC (rev 214239)
@@ -169,7 +169,7 @@
 return MediaPlaybackDenialReason::UserGestureRequired;
 }
 
-if (m_restrictions & RequireUserGestureForAudioRateChange && (!element.isVideo() || element.hasAudio()) && !element.muted() && !ScriptController::processingUserGestureForMedia()) {
+if (m_restrictions & RequireUserGestureForAudioRateChange && (!element.isVideo() || element.hasAudio()) && !element.muted() && element.volume() && !ScriptController::processingUserGestureForMedia()) {
 LOG(Media, "MediaElementSession::playbackPermitted - returning FALSE because of audio rate change restriction");
 return MediaPlaybackDenialReason::UserGestureRequired;
 }


Modified: trunk/Tools/ChangeLog (214238 => 214239)

--- trunk/Tools/ChangeLog	2017-03-22 00:45:15 UTC (rev 214238)
+++ trunk/Tools/ChangeLog	2017-03-22 01:44:21 UTC (rev 214239)
@@ -1,3 +1,15 @@
+2017-03-20  Matt Rajca  
+
+Loosen audio playback restrictions when the volume is 0.
+https://bugs.webkit.org/show_bug.cgi?id=169897
+
+Reviewed by Eric Carlson.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Added.
+* TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
+(TEST):
+
 2017-03-21  Aakash Jain  
 
 EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (214238 => 214239)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-03-22 00:45:15 UTC (rev 214238)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-03-22 01:44:21 UTC (rev 214239)
@@ -537,6 +537,7 @@
 		C99B675C1E39721A00FC6C80 /* autoplay-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99B675A1E3971FC00FC6C80 /* autoplay-with-controls.html */; };
 		C99B675D1E39722000FC6C80 /* js-play-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99B675B1E3971FC00FC6C80 /* js-play-with-controls.html */; };
 		C99B675F1E39736F00FC6C80 /* no-autoplay-with-controls.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99B675E1E39735C00FC6C80 /* no-autoplay-with-controls.html */; };
+		C99BDF891E80980400C7170E /* autoplay-zero-volume-check.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C99BDF881E8097E300C7170E /* autoplay-zero-volume-check.html */; };
 		C9C60E651E53A9DC006DA181 /* autoplay-check-frame.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9C60E631E53A9BA006DA181 /* autoplay-check-frame.html */; };
 		C9C60E661E53A9DC006DA181 /* autoplay-check-in-iframe.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C9C60E641E53A9BA006DA181 /* autoplay-check-in-iframe.html */; };
 		CD321B041E3A85FA00EB21C8 /* video-with-muted-audio-and-webaudio.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CD321B031E3A84B700EB21C8 /* video-with-muted-audio-and-webaudio.html */; };
@@ -653,6 +654,7 @@
 			dstPath = TestWebKitAPI.resources;
 			dstSubfolderSpec = 7;
 			files = (
+

[webkit-changes] [214228] tags/Safari-604.1.13/Source/WebKit2

[jmarcell]

Title: [214228] tags/Safari-604.1.13/Source/WebKit2








Revision 214228
Author jmarc...@apple.com
Date 2017-03-21 12:49:36 -0700 (Tue, 21 Mar 2017)


Log Message
Merge r214179. rdar://problem/31030944

Modified Paths

tags/Safari-604.1.13/Source/WebKit2/ChangeLog
tags/Safari-604.1.13/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm




Diff

Modified: tags/Safari-604.1.13/Source/WebKit2/ChangeLog (214227 => 214228)

--- tags/Safari-604.1.13/Source/WebKit2/ChangeLog	2017-03-21 19:45:38 UTC (rev 214227)
+++ tags/Safari-604.1.13/Source/WebKit2/ChangeLog	2017-03-21 19:49:36 UTC (rev 214228)
@@ -1,3 +1,20 @@
+2017-03-21  Jason Marcell  
+
+Merge r214179. rdar://problem/31030944
+
+2017-03-20  Anders Carlsson  
+
+Fix a paste-o in WebPaymentCoordinatorProxy::platformCompletePaymentSession
+https://bugs.webkit.org/show_bug.cgi?id=169881
+rdar://problem/31030944
+
+Reviewed by Dan Bernstein.
+
+Don't always pass PKPaymentAuthorizationStatusFailure to the completion handler.
+
+* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
+(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentSession):
+
 2017-03-19  Brian Burg  
 
 [Cocoa] Web Automation: non-sticky virtual keys like 'left arrow' don't work properly


Modified: tags/Safari-604.1.13/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm (214227 => 214228)

--- tags/Safari-604.1.13/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm	2017-03-21 19:45:38 UTC (rev 214227)
+++ tags/Safari-604.1.13/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm	2017-03-21 19:49:36 UTC (rev 214228)
@@ -631,7 +631,7 @@
 m_paymentAuthorizationViewControllerDelegate->_didReachFinalState = WebCore::isFinalStateStatus(status);
 
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11)
-auto pkPaymentAuthorizationResult = adoptNS([allocPKPaymentAuthorizationResultInstance() initWithStatus:PKPaymentAuthorizationStatusFailure errors:result ? toNSErrors(result->errors).get() : @[ ]]);
+auto pkPaymentAuthorizationResult = adoptNS([allocPKPaymentAuthorizationResultInstance() initWithStatus:toPKPaymentAuthorizationStatus(status) errors:result ? toNSErrors(result->errors).get() : @[ ]]);
 m_paymentAuthorizationViewControllerDelegate->_paymentAuthorizedCompletion(pkPaymentAuthorizationResult.get());
 #else
 m_paymentAuthorizationViewControllerDelegate->_paymentAuthorizedCompletion(toPKPaymentAuthorizationStatus(status));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214232] trunk

[zalan]

Title: [214232] trunk








Revision 214232
Author za...@apple.com
Date 2017-03-21 14:39:01 -0700 (Tue, 21 Mar 2017)


Log Message
2017-03-21  Zalan Bujtas  

Tear down descendant renderers when 's display value is set to no "contents".
https://bugs.webkit.org/show_bug.cgi?id=169921


Reviewed by Antti Koivisto.

Since "display: contents" does not generate a renderer, when an element's display value is
changed to something other than "contents", we not only create a renderer but also reparent its descendant
subtree (e.g from slot's parent to the newly constructed slot renderer). During this reparenting, we
need to tear down the descendant subtree tree and build it up again to reflect the new rendering context.

Test: fast/shadow-dom/slot-with-continuation-descendants.html

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/RenderTreeUpdater.cpp


Added Paths

trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants-expected.txt
trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants.html




Diff

Modified: trunk/LayoutTests/ChangeLog (214231 => 214232)

--- trunk/LayoutTests/ChangeLog	2017-03-21 21:25:47 UTC (rev 214231)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 21:39:01 UTC (rev 214232)
@@ -1,3 +1,14 @@
+2017-03-21  Zalan Bujtas  
+
+Tear down descendant renderers when 's display value is set to no "contents".
+https://bugs.webkit.org/show_bug.cgi?id=169921
+
+
+Reviewed by Antti Koivisto.
+
+* fast/shadow-dom/slot-with-continuation-descendants-expected.txt: Added.
+* fast/shadow-dom/slot-with-continuation-descendants.html: Added.
+
 2017-03-21  Carlos Alberto Lopez Perez  
 
 [GTK][Wayland] Enable WebGL, 3D and compositing layout tests


Added: trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants-expected.txt (0 => 214232)

--- trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants-expected.txt	2017-03-21 21:39:01 UTC (rev 214232)
@@ -0,0 +1,2 @@
+PASS if no crash
+or assert.


Added: trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants.html (0 => 214232)

--- trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants.html	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/slot-with-continuation-descendants.html	2017-03-21 21:39:01 UTC (rev 214232)
@@ -0,0 +1,17 @@
+
+
+
+This tests that we can handle continuation when "display: contents" element becomes non-contents
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+PASS if no crashor assert.
+
+document.body.offsetHeight;
+slot.style.display = "inline";
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (214231 => 214232)

--- trunk/Source/WebCore/ChangeLog	2017-03-21 21:25:47 UTC (rev 214231)
+++ trunk/Source/WebCore/ChangeLog	2017-03-21 21:39:01 UTC (rev 214232)
@@ -1,3 +1,21 @@
+2017-03-21  Zalan Bujtas  
+
+Tear down descendant renderers when 's display value is set to no "contents".
+https://bugs.webkit.org/show_bug.cgi?id=169921
+
+
+Reviewed by Antti Koivisto.
+
+Since "display: contents" does not generate a renderer, when an element's display value is
+changed to something other than "contents", we not only create a renderer but also reparent its descendant
+subtree (e.g from slot's parent to the newly constructed slot renderer). During this reparenting, we
+need to tear down the descendant subtree tree and build it up again to reflect the new rendering context.
+
+Test: fast/shadow-dom/slot-with-continuation-descendants.html
+
+* style/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::updateElementRenderer):
+
 2017-03-19  Wenson Hsieh  
 
 Teach TextIndicator to estimate the background color of the given Range


Modified: trunk/Source/WebCore/style/RenderTreeUpdater.cpp (214231 => 214232)

--- trunk/Source/WebCore/style/RenderTreeUpdater.cpp	2017-03-21 21:25:47 UTC (rev 214231)
+++ trunk/Source/WebCore/style/RenderTreeUpdater.cpp	2017-03-21 21:39:01 UTC (rev 214232)
@@ -257,7 +257,8 @@
 CheckForVisibilityChange checkForVisibilityChange(element);
 #endif
 
-bool shouldTearDownRenderers = update.change == Style::Detach && (element.renderer() || element.isNamedFlowContentElement());
+bool shouldTearDownRenderers = update.change == Style::Detach
+&& (element.renderer() || element.isNamedFlowContentElement() || element.hasDisplayContents());
 if (shouldTearDownRenderers)
 tearDownRenderers(element, 

[webkit-changes] [214227] trunk/Source/WebCore

[jer . noble]

Title: [214227] trunk/Source/WebCore








Revision 214227
Author jer.no...@apple.com
Date 2017-03-21 12:45:38 -0700 (Tue, 21 Mar 2017)


Log Message
Crash in WebCore: WebCore::CARingBuffer::getCurrentFrameBounds + 28
https://bugs.webkit.org/show_bug.cgi?id=169887


Reviewed by Eric Carlson.

Because AudioSourceProviderAVFObjC::prepareCallback() can concievably be called after the AudioSourceProviderAVFObjC
it refers to has been destroyed, add an extra layer of indirection between the tap and the provider, and invalidate
that level of indirection before the AudioSourceProviderAVFObjC is destroyed.

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::initCallback):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
(WebCore::AudioSourceProviderAVFObjC::prepareCallback):
(WebCore::AudioSourceProviderAVFObjC::unprepareCallback):
(WebCore::AudioSourceProviderAVFObjC::processCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (214226 => 214227)

--- trunk/Source/WebCore/ChangeLog	2017-03-21 18:18:35 UTC (rev 214226)
+++ trunk/Source/WebCore/ChangeLog	2017-03-21 19:45:38 UTC (rev 214227)
@@ -1,3 +1,23 @@
+2017-03-20  Jer Noble  
+
+Crash in WebCore: WebCore::CARingBuffer::getCurrentFrameBounds + 28
+https://bugs.webkit.org/show_bug.cgi?id=169887
+
+
+Reviewed by Eric Carlson.
+
+Because AudioSourceProviderAVFObjC::prepareCallback() can concievably be called after the AudioSourceProviderAVFObjC
+it refers to has been destroyed, add an extra layer of indirection between the tap and the provider, and invalidate
+that level of indirection before the AudioSourceProviderAVFObjC is destroyed.
+
+* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
+* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
+(WebCore::AudioSourceProviderAVFObjC::initCallback):
+(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
+(WebCore::AudioSourceProviderAVFObjC::prepareCallback):
+(WebCore::AudioSourceProviderAVFObjC::unprepareCallback):
+(WebCore::AudioSourceProviderAVFObjC::processCallback):
+
 2017-03-21  Simon Fraser  
 
 Remove logging left in by mistake.


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h (214226 => 214227)

--- trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h	2017-03-21 18:18:35 UTC (rev 214226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h	2017-03-21 19:45:38 UTC (rev 214227)
@@ -30,7 +30,6 @@
 
 #include "AudioSourceProvider.h"
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -90,7 +89,6 @@
 std::unique_ptr m_outputDescription;
 std::unique_ptr m_ringBuffer;
 
-Lock m_mutex;
 MediaTime m_startTimeAtLastProcess;
 MediaTime m_endTimeAtLastProcess;
 std::atomic m_writeAheadCount { 0 };
@@ -99,6 +97,9 @@
 std::atomic m_seekTo { NoSeek };
 bool m_paused { true };
 AudioSourceProviderClient* m_client { nullptr };
+
+struct TapStorage;
+TapStorage* m_tapStorage { nullptr };
 };
 
 }


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm (214226 => 214227)

--- trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm	2017-03-21 18:18:35 UTC (rev 214226)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm	2017-03-21 19:45:38 UTC (rev 214227)
@@ -40,6 +40,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 
 #if !LOG_DISABLED
@@ -70,6 +71,12 @@
 
 static const double kRingBufferDuration = 1;
 
+struct AudioSourceProviderAVFObjC::TapStorage {
+TapStorage(AudioSourceProviderAVFObjC* _this) : _this(_this) { }
+AudioSourceProviderAVFObjC* _this;
+Lock mutex;
+};
+
 RefPtr AudioSourceProviderAVFObjC::create(AVPlayerItem *item)
 {
 if (!canLoadMTAudioProcessingTapCreate())
@@ -85,6 +92,11 @@
 AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC()
 {
 setClient(nullptr);
+if (m_tapStorage) {
+std::unique_lock lock(m_tapStorage->mutex);
+m_tapStorage->_this = nullptr;
+m_tapStorage = nullptr;
+}
 }
 
 void AudioSourceProviderAVFObjC::provideInput(AudioBus* bus, size_t framesToProcess)
@@ -92,7 +104,12 @@
 // Protect access to m_ringBuffer by try_locking the mutex. If we failed
 // to aquire, a re-configure is underway, and m_ringBuffer is unsafe to access.
 // Emit silence.
-std::unique_lock lock(m_mutex, std::try_to_lock);
+if (!m_tapStorage) {
+bus->zero();

[webkit-changes] [214231] trunk/Source

[wenson_hsieh]

Title: [214231] trunk/Source








Revision 214231
Author wenson_hs...@apple.com
Date 2017-03-21 14:25:47 -0700 (Tue, 21 Mar 2017)


Log Message
Teach TextIndicator to estimate the background color of the given Range
https://bugs.webkit.org/show_bug.cgi?id=169869


Reviewed by Anders Carlsson and Simon Fraser.

Source/WebCore:

Introduces a simple heuristic to compute a background color that is appropriate to use as a border surrounding
the snapshot of the given Range. This work is only carried out if TextIndicatorOptionComputeEstimatedBackgroundColor
is specified. The details of how this background color is estimated (as well as when to fall back) can be improved
in several ways (one idea is to sample colors along the edge of the snapshot). For the time being, this patch
naively walks up the render tree in search of enclosing parent renderers that have background colors. If any
renderers have a style that is deemed too complex to capture in a single background color, then fall back to the
base document background color; otherwise, the estimated background color is the result of blending these
background colors together.

* page/TextIndicator.cpp:
(WebCore::styleContainsComplexBackground):

Bail out of the background color codepath if the renderer has backdrop filters, has a background image, or uses
a non-normal blend mode.

(WebCore::fallbackBackgroundColorForTextSelection):
(WebCore::estimatedBackgroundColorForRange):
(WebCore::initializeIndicator):
* page/TextIndicator.h:

Source/WebKit/mac:

Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.

* WebView/WebView.mm:
(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
(-[WebUITextIndicatorData dealloc]):
* WebView/WebViewPrivate.h:

Source/WebKit2:

Send the estimated background color over XPC, and adopt TextIndicatorOptionComputeEstimatedBackgroundColor when
snapshotting after performing an edit data interaction.

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didConcludeEditDataInteraction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/TextIndicator.cpp
trunk/Source/WebCore/page/TextIndicator.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewPrivate.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (214230 => 214231)

--- trunk/Source/WebCore/ChangeLog	2017-03-21 21:08:21 UTC (rev 214230)
+++ trunk/Source/WebCore/ChangeLog	2017-03-21 21:25:47 UTC (rev 214231)
@@ -1,3 +1,31 @@
+2017-03-19  Wenson Hsieh  
+
+Teach TextIndicator to estimate the background color of the given Range
+https://bugs.webkit.org/show_bug.cgi?id=169869
+
+
+Reviewed by Anders Carlsson and Simon Fraser.
+
+Introduces a simple heuristic to compute a background color that is appropriate to use as a border surrounding
+the snapshot of the given Range. This work is only carried out if TextIndicatorOptionComputeEstimatedBackgroundColor
+is specified. The details of how this background color is estimated (as well as when to fall back) can be improved
+in several ways (one idea is to sample colors along the edge of the snapshot). For the time being, this patch
+naively walks up the render tree in search of enclosing parent renderers that have background colors. If any
+renderers have a style that is deemed too complex to capture in a single background color, then fall back to the
+base document background color; otherwise, the estimated background color is the result of blending these
+background colors together.
+
+* page/TextIndicator.cpp:
+(WebCore::styleContainsComplexBackground):
+
+Bail out of the background color codepath if the renderer has backdrop filters, has a background image, or uses
+a non-normal blend mode.
+
+(WebCore::fallbackBackgroundColorForTextSelection):
+(WebCore::estimatedBackgroundColorForRange):
+(WebCore::initializeIndicator):
+* page/TextIndicator.h:
+
 2017-03-20  Jer Noble  
 
 Crash in WebCore: WebCore::CARingBuffer::getCurrentFrameBounds + 28


Modified: trunk/Source/WebCore/page/TextIndicator.cpp (214230 => 214231)

--- trunk/Source/WebCore/page/TextIndicator.cpp	2017-03-21 21:08:21 UTC (rev 214230)
+++ trunk/Source/WebCore/page/TextIndicator.cpp	2017-03-21 21:25:47 UTC (rev 214231)
@@ -39,6 +39,7 @@
 #include "IntRect.h"
 #include "NodeTraversal.h"
 #include "Range.h"
+#include "RenderElement.h"
 #include "RenderObject.h"
 
 #if PLATFORM(IOS)
@@ -200,8 +201,61 @@
 
 #endif
 
+static bool styleContainsComplexBackground(const 

[webkit-changes] [214230] trunk/Source/WebKit2

[cdumez]

Title: [214230] trunk/Source/WebKit2








Revision 214230
Author cdu...@apple.com
Date 2017-03-21 14:08:21 -0700 (Tue, 21 Mar 2017)


Log Message
[WK2] Call processDidCrash() right away when terminating a process that exceeded background CPU limit
https://bugs.webkit.org/show_bug.cgi?id=169573


Reviewed by Andreas Kling.

Call processDidCrash() right away when terminating a process that exceeded background CPU limit
and let the client decide when to reload the content.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::terminateProcess):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (214229 => 214230)

--- trunk/Source/WebKit2/ChangeLog	2017-03-21 20:52:51 UTC (rev 214229)
+++ trunk/Source/WebKit2/ChangeLog	2017-03-21 21:08:21 UTC (rev 214230)
@@ -1,3 +1,22 @@
+2017-03-21  Chris Dumez  
+
+[WK2] Call processDidCrash() right away when terminating a process that exceeded background CPU limit
+https://bugs.webkit.org/show_bug.cgi?id=169573
+
+
+Reviewed by Andreas Kling.
+
+Call processDidCrash() right away when terminating a process that exceeded background CPU limit
+and let the client decide when to reload the content.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::reattachToWebProcess):
+(WebKit::WebPageProxy::dispatchActivityStateChange):
+(WebKit::WebPageProxy::terminateProcess):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):
+
 2017-03-21  Aidan Holm  
 
 [GTK] Add function webkit_dom_element_get_bounding_client_rect


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (214229 => 214230)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2017-03-21 20:52:51 UTC (rev 214229)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2017-03-21 21:08:21 UTC (rev 214230)
@@ -709,7 +709,6 @@
 ASSERT(m_process->state() == WebProcessProxy::State::Terminated);
 
 m_isValid = true;
-m_wasTerminatedDueToResourceExhaustionWhileInBackground = false;
 m_process->removeWebPage(m_pageID);
 m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
 
@@ -1522,13 +1521,8 @@
 m_activityStateChangeDispatcher->invalidate();
 #endif
 
-if (!isValid()) {
-if (m_potentiallyChangedActivityStateFlags & ActivityState::IsVisible && m_wasTerminatedDueToResourceExhaustionWhileInBackground) {
-m_wasTerminatedDueToResourceExhaustionWhileInBackground = false;
-processDidCrash();
-}
+if (!isValid())
 return;
-}
 
 // If the visibility state may have changed, then so may the visually idle & occluded agnostic state.
 if (m_potentiallyChangedActivityStateFlags & ActivityState::IsVisible)
@@ -2391,7 +2385,7 @@
 m_process->send(Messages::WebPage::SetCustomTextEncodingName(encodingName), m_pageID);
 }
 
-void WebPageProxy::terminateProcess(TerminationReason terminationReason)
+void WebPageProxy::terminateProcess()
 {
 // NOTE: This uses a check of m_isValid rather than calling isValid() since
 // we want this to run even for pages being closed or that already closed.
@@ -2400,7 +2394,6 @@
 
 m_process->requestTermination();
 resetStateAfterProcessExited();
-m_wasTerminatedDueToResourceExhaustionWhileInBackground = terminationReason == TerminationReason::ResourceExhaustionWhileInBackground;
 }
 
 SessionState WebPageProxy::sessionState(const std::function& filter) const


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (214229 => 214230)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2017-03-21 20:52:51 UTC (rev 214229)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2017-03-21 21:08:21 UTC (rev 214230)
@@ -680,8 +680,7 @@
 
 double estimatedProgress() const;
 
-enum class TerminationReason { ResourceExhaustionWhileInBackground, Other };
-void terminateProcess(TerminationReason = TerminationReason::Other);
+void terminateProcess();
 
 SessionState sessionState(const std::function& = nullptr) const;
 RefPtr restoreFromSessionState(SessionState, bool navigate);
@@ -1977,7 +1976,6 @@
 #endif
 
 bool m_isUsingHighPerformanceWebGL { false };
-bool m_wasTerminatedDueToResourceExhaustionWhileInBackground { false };
 
 WeakPtrFactory m_weakPtrFactory;
 


Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (214229 => 214230)

--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	

[webkit-changes] [214229] trunk/LayoutTests

[clopez]

Title: [214229] trunk/LayoutTests








Revision 214229
Author clo...@igalia.com
Date 2017-03-21 13:52:51 -0700 (Tue, 21 Mar 2017)


Log Message
[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardening.

* platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
* platform/gtk/TestExpectations: This two tests seem flaky.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wayland/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214228 => 214229)

--- trunk/LayoutTests/ChangeLog	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 20:52:51 UTC (rev 214229)
@@ -1,5 +1,15 @@
 2017-03-21  Carlos Alberto Lopez Perez  
 
+[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
+https://bugs.webkit.org/show_bug.cgi?id=71849
+
+Unreviewed test gardening.
+
+* platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
+* platform/gtk/TestExpectations: This two tests seem flaky.
+
+2017-03-21  Carlos Alberto Lopez Perez  
+
 [GTK] Enable WebGL, 3D and compositing layout tests
 https://bugs.webkit.org/show_bug.cgi?id=71849
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214228 => 214229)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 20:52:51 UTC (rev 214229)
@@ -308,8 +308,8 @@
 webkit.org/b/169916 css3/blending/blend-mode-body-child-background-color.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-child-isolate-html-background-color.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-child.html [ ImageOnlyFailure ]
-webkit.org/b/169916 css3/blending/blend-mode-body-composited-child-background-color.html [ ImageOnlyFailure ]
-webkit.org/b/169916 css3/blending/blend-mode-body-composited-child.html [ ImageOnlyFailure ]
+webkit.org/b/169916 css3/blending/blend-mode-body-composited-child-background-color.html [ Pass ImageOnlyFailure ]
+webkit.org/b/169916 css3/blending/blend-mode-body-composited-child.html [ Pass ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-body-element.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-child.html [ ImageOnlyFailure ]
 webkit.org/b/169916 css3/blending/blend-mode-clip-accelerated-blending-double.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/gtk-wayland/TestExpectations (214228 => 214229)

--- trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2017-03-21 19:49:36 UTC (rev 214228)
+++ trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2017-03-21 20:52:51 UTC (rev 214229)
@@ -30,6 +30,77 @@
 webkit.org/b/156717 transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]
 webkit.org/b/156717 transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Failure ]
 
+# Diff of failures (and passes) related with WebGL and Compositing tests (compared to --display-server=xvfb)
+# When passing --display-server=wayland on an system running native Weston on an Intel GPU (like the GTK Wayland bot)
+webkit.org/b/169917 fast/canvas/webgl/drawingbuffer-test.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-npot-video.html [ Crash Pass ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Timeout Pass ]
+webkit.org/b/169917 webgl/1.0.3/conformance/glsl/bugs/temp-expressions-should-not-crash.html [ Timeout ]
+webkit.org/b/169917 webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html [ Failure ]
+webkit.org/b/169917 webgl/1.0.3/conformance/rendering/negative-one-index.html [ Timeout Pass ]
+webkit.org/b/169917 webgl/webgl-padding.html [ ImageOnlyFailure ]
+webkit.org/b/169917 webgl/webgl-backing-store-size-update.html [ ImageOnlyFailure ]
+webkit.org/b/169917 fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-mips.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-npot.html [ Pass ]
+webkit.org/b/169917 webgl/1.0.2/conformance/textures/texture-size-limit.html [ Pass ]
+webkit.org/b/169918 compositing/scrolling/fixed-inside-scroll.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-padding.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing.html [ ImageOnlyFailure ]
+webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html [ ImageOnlyFailure ]
+webkit.org/b/169918 

[webkit-changes] [214221] trunk/LayoutTests

[carlosgc]

Title: [214221] trunk/LayoutTests








Revision 214221
Author carlo...@webkit.org
Date 2017-03-21 07:12:09 -0700 (Tue, 21 Mar 2017)


Log Message
Unreviewed GTK+ gardening. Remove expectations for imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm.

It no longer works with current version of wptserve and it's already skipped globally.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (214220 => 214221)

--- trunk/LayoutTests/ChangeLog	2017-03-21 11:42:36 UTC (rev 214220)
+++ trunk/LayoutTests/ChangeLog	2017-03-21 14:12:09 UTC (rev 214221)
@@ -1,5 +1,13 @@
 2017-03-21  Carlos Garcia Campos  
 
+Unreviewed GTK+ gardening. Remove expectations for imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm.
+
+It no longer works with current version of wptserve and it's already skipped globally.
+
+* platform/gtk/TestExpectations:
+
+2017-03-21  Carlos Garcia Campos  
+
 Unreviewed GTK+ gardening. Remove duplicated entry.
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (214220 => 214221)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 11:42:36 UTC (rev 214220)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-03-21 14:12:09 UTC (rev 214221)
@@ -2698,7 +2698,6 @@
 imported/w3c/web-platform-tests/XMLHttpRequest/status-basic.htm [ Failure ]
 imported/w3c/web-platform-tests/XMLHttpRequest/status-error.htm [ Failure ]
 imported/w3c/web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm [ Slow ]
-imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm [ Pass ]
 imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none.htm [ Pass ]
 imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty.htm  [ Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214233] trunk/Tools

[aakash_jain]

Title: [214233] trunk/Tools








Revision 214233
Author aakash_j...@apple.com
Date 2017-03-21 15:33:30 -0700 (Tue, 21 Mar 2017)


Log Message
ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
https://bugs.webkit.org/show_bug.cgi?id=169927

Reviewed by  Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py




Diff

Modified: trunk/Tools/ChangeLog (214232 => 214233)

--- trunk/Tools/ChangeLog	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/ChangeLog	2017-03-21 22:33:30 UTC (rev 214233)
@@ -1,3 +1,13 @@
+2017-03-21  Aakash Jain  
+
+ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
+https://bugs.webkit.org/show_bug.cgi?id=169927
+
+Reviewed by  Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.
+
 2017-03-20  Simon Fraser  
 
 Add a system trace point for memory warning handling


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (214232 => 214233)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 21:39:01 UTC (rev 214232)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2017-03-21 22:33:30 UTC (rev 214233)
@@ -488,8 +488,7 @@
 # The "Up" relation happens to point to the bug.
 up_link = BeautifulSoup(page).find('link', rel='Up')
 if not up_link:
-# This attachment does not exist (or you don't have permissions to
-# view it).
+_log.warning("This attachment does not exist (or you don't have permissions to view it).")
 return None
 match = re.search("show_bug.cgi\?id=(?P\d+)", up_link['href'])
 return int(match.group('bug_id'))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214234] branches/safari-603-branch/Source

[jmarcell]

Title: [214234] branches/safari-603-branch/Source








Revision 214234
Author jmarc...@apple.com
Date 2017-03-21 16:02:30 -0700 (Tue, 21 Mar 2017)


Log Message
Versioning.

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig (214233 => 214234)

--- branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-03-21 22:33:30 UTC (rev 214233)
+++ branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-03-21 23:02:30 UTC (rev 214234)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig (214233 => 214234)

--- branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-03-21 22:33:30 UTC (rev 214233)
+++ branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig	2017-03-21 23:02:30 UTC (rev 214234)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (214233 => 214234)

--- branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-03-21 22:33:30 UTC (rev 214233)
+++ branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-03-21 23:02:30 UTC (rev 214234)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig (214233 => 214234)

--- branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-03-21 22:33:30 UTC (rev 214233)
+++ branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-03-21 23:02:30 UTC (rev 214234)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig (214233 => 214234)

--- branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-03-21 22:33:30 UTC (rev 214233)
+++ branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-03-21 23:02:30 UTC (rev 214234)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 2;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214235] trunk/Source

[andersca]

Title: [214235] trunk/Source








Revision 214235
Author ander...@apple.com
Date 2017-03-21 16:40:26 -0700 (Tue, 21 Mar 2017)


Log Message
Remove bogus availability annotations from DOM SPI headers.
rdar://problem/31015675

Rubber-stamped by Dan Bernstein.

Source/WebCore:

* platform/cocoa/WebKitAvailability.h:
Remove __NSi_9876_5 #define.

Source/WebKit/mac:

* DOM/DOMHTMLMediaElement.h:
* DOM/DOMHTMLVideoElement.h:
* DOM/DOMMediaError.h:
* DOM/DOMTextEvent.h:
* DOM/DOMTimeRanges.h:
* DOM/DOMTokenList.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/WebKitAvailability.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/DOM/DOMHTMLMediaElement.h
trunk/Source/WebKit/mac/DOM/DOMHTMLVideoElement.h
trunk/Source/WebKit/mac/DOM/DOMMediaError.h
trunk/Source/WebKit/mac/DOM/DOMTextEvent.h
trunk/Source/WebKit/mac/DOM/DOMTimeRanges.h
trunk/Source/WebKit/mac/DOM/DOMTokenList.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (214234 => 214235)

--- trunk/Source/WebCore/ChangeLog	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebCore/ChangeLog	2017-03-21 23:40:26 UTC (rev 214235)
@@ -1,3 +1,13 @@
+2017-03-21  Anders Carlsson  
+
+Remove bogus availability annotations from DOM SPI headers.
+rdar://problem/31015675
+
+Rubber-stamped by Dan Bernstein.
+
+* platform/cocoa/WebKitAvailability.h:
+Remove __NSi_9876_5 #define.
+
 2017-03-21  Zalan Bujtas  
 
 Tear down descendant renderers when 's display value is set to no "contents".


Modified: trunk/Source/WebCore/platform/cocoa/WebKitAvailability.h (214234 => 214235)

--- trunk/Source/WebCore/platform/cocoa/WebKitAvailability.h	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebCore/platform/cocoa/WebKitAvailability.h	2017-03-21 23:40:26 UTC (rev 214235)
@@ -31,10 +31,6 @@
 #if !TARGET_OS_IPHONE
 #import 
 
-#ifndef __NSi_9876_5
-#define __NSi_9876_5 introduced=9876.5
-#endif
-
 #define WEBKIT_AVAILABLE_MAC(introduced) NS_AVAILABLE_MAC(introduced)
 #define WEBKIT_CLASS_AVAILABLE_MAC(introduced) NS_CLASS_AVAILABLE_MAC(introduced)
 #define WEBKIT_ENUM_AVAILABLE_MAC(introduced) NS_ENUM_AVAILABLE_MAC(introduced)


Modified: trunk/Source/WebKit/mac/ChangeLog (214234 => 214235)

--- trunk/Source/WebKit/mac/ChangeLog	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-03-21 23:40:26 UTC (rev 214235)
@@ -1,3 +1,17 @@
+2017-03-21  Anders Carlsson  
+
+Remove bogus availability annotations from DOM SPI headers.
+rdar://problem/31015675
+
+Rubber-stamped by Dan Bernstein.
+
+* DOM/DOMHTMLMediaElement.h:
+* DOM/DOMHTMLVideoElement.h:
+* DOM/DOMMediaError.h:
+* DOM/DOMTextEvent.h:
+* DOM/DOMTimeRanges.h:
+* DOM/DOMTokenList.h:
+
 2017-03-19  Wenson Hsieh  
 
 Teach TextIndicator to estimate the background color of the given Range


Modified: trunk/Source/WebKit/mac/DOM/DOMHTMLMediaElement.h (214234 => 214235)

--- trunk/Source/WebKit/mac/DOM/DOMHTMLMediaElement.h	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebKit/mac/DOM/DOMHTMLMediaElement.h	2017-03-21 23:40:26 UTC (rev 214235)
@@ -39,9 +39,9 @@
 DOM_HAVE_CURRENT_DATA = 2,
 DOM_HAVE_FUTURE_DATA = 3,
 DOM_HAVE_ENOUGH_DATA = 4
-} WEBKIT_ENUM_AVAILABLE_MAC(9876_5);
+};
 
-WEBKIT_CLASS_AVAILABLE_MAC(9876_5)
+__attribute__((visibility("default")))
 @interface DOMHTMLMediaElement : DOMHTMLElement
 @property (readonly, strong) DOMMediaError *error;
 @property (copy) NSString *src;


Modified: trunk/Source/WebKit/mac/DOM/DOMHTMLVideoElement.h (214234 => 214235)

--- trunk/Source/WebKit/mac/DOM/DOMHTMLVideoElement.h	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebKit/mac/DOM/DOMHTMLVideoElement.h	2017-03-21 23:40:26 UTC (rev 214235)
@@ -27,7 +27,7 @@
 
 @class NSString;
 
-WEBKIT_CLASS_AVAILABLE_MAC(9876_5)
+__attribute__((visibility("default")))
 @interface DOMHTMLVideoElement : DOMHTMLMediaElement
 @property unsigned width;
 @property unsigned height;


Modified: trunk/Source/WebKit/mac/DOM/DOMMediaError.h (214234 => 214235)

--- trunk/Source/WebKit/mac/DOM/DOMMediaError.h	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebKit/mac/DOM/DOMMediaError.h	2017-03-21 23:40:26 UTC (rev 214235)
@@ -31,9 +31,9 @@
 DOM_MEDIA_ERR_DECODE = 3,
 DOM_MEDIA_ERR_SRC_NOT_SUPPORTED = 4,
 DOM_MEDIA_ERR_ENCRYPTED = 5
-} WEBKIT_ENUM_AVAILABLE_MAC(9876_5);
+};
 
-WEBKIT_CLASS_AVAILABLE_MAC(9876_5)
+__attribute__((visibility("default")))
 @interface DOMMediaError : DOMObject
 @property (readonly) unsigned short code;
 @end


Modified: trunk/Source/WebKit/mac/DOM/DOMTextEvent.h (214234 => 214235)

--- trunk/Source/WebKit/mac/DOM/DOMTextEvent.h	2017-03-21 23:02:30 UTC (rev 214234)
+++ trunk/Source/WebKit/mac/DOM/DOMTextEvent.h	2017-03-21 23:40:26 UTC (rev 214235)
@@ -28,7 +28,7 @@
 @class DOMAbstractView;
 @class 

[webkit-changes] [214236] branches/safari-603-branch/Source/WebCore

[jmarcell]

Title: [214236] branches/safari-603-branch/Source/WebCore








Revision 214236
Author jmarc...@apple.com
Date 2017-03-21 17:06:26 -0700 (Tue, 21 Mar 2017)


Log Message
Merge r214014. rdar://problem/30921815

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/history/CachedFrame.cpp
branches/safari-603-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-603-branch/Source/WebCore/loader/FrameLoader.h
branches/safari-603-branch/Source/WebCore/page/FrameTree.cpp
branches/safari-603-branch/Source/WebCore/page/FrameTree.h




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (214235 => 214236)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-03-21 23:40:26 UTC (rev 214235)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-03-22 00:06:26 UTC (rev 214236)
@@ -1,3 +1,34 @@
+2017-03-21  Jason Marcell  
+
+Merge r214014. rdar://problem/30921815
+
+2017-03-15  Daniel Bates  
+
+Iteratively dispatch DOM events after restoring a cached page
+https://bugs.webkit.org/show_bug.cgi?id=169703
+
+
+Reviewed by Brady Eidson.
+
+Make dispatching of DOM events when restoring a page from the page cache symmetric with
+dispatching of events when saving a page to the page cache.
+
+* history/CachedFrame.cpp:
+(WebCore::CachedFrameBase::restore): Move code to dispatch events from here to FrameLoader::didRestoreFromCachedPage().
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad): Ensure that no DOM events are dispatched during
+restoration of a cached page. Call didRestoreFromCachedPage() after restoring the page to
+dispatch DOM events on the restored frames.
+(WebCore::FrameLoader::willRestoreFromCachedPage): Renamed; formerly named prepareForCachedPageRestore().
+(WebCore::FrameLoader::didRestoreFromCachedPage): Added.
+(WebCore::FrameLoader::prepareForCachedPageRestore): Renamed to willRestoreFromCachedPage().
+* loader/FrameLoader.h:
+* page/FrameTree.cpp:
+(WebCore::FrameTree::traverseNextInPostOrderWithWrap): Returns the next Frame* in a post-order
+traversal of the frame tree optionally wrapping around to the deepest first child in the tree.
+(WebCore::FrameTree::deepFirstChild): Added.
+* page/FrameTree.h:
+
 2017-03-20  Matthew Hanson  
 
 Merge r213949. rdar://problem/31049771


Modified: branches/safari-603-branch/Source/WebCore/history/CachedFrame.cpp (214235 => 214236)

--- branches/safari-603-branch/Source/WebCore/history/CachedFrame.cpp	2017-03-21 23:40:26 UTC (rev 214235)
+++ branches/safari-603-branch/Source/WebCore/history/CachedFrame.cpp	2017-03-22 00:06:26 UTC (rev 214236)
@@ -35,13 +35,10 @@
 #include "FrameLoader.h"
 #include "FrameLoaderClient.h"
 #include "FrameView.h"
-#include "HistoryController.h"
-#include "HistoryItem.h"
 #include "Logging.h"
 #include "MainFrame.h"
 #include "Page.h"
 #include "PageCache.h"
-#include "PageTransitionEvent.h"
 #include "SVGDocumentExtensions.h"
 #include "ScriptController.h"
 #include "SerializedScriptValue.h"
@@ -102,6 +99,7 @@
 for (unsigned i = 0; i < m_childFrames.size(); ++i) {
 frame.tree().appendChild(_childFrames[i]->view()->frame());
 m_childFrames[i]->open();
+ASSERT_WITH_SECURITY_IMPLICATION(m_document == frame.document());
 }
 
 #if PLATFORM(IOS)
@@ -117,14 +115,6 @@
 }
 #endif
 
-// FIXME: update Page Visibility state here.
-// https://bugs.webkit.org/show_bug.cgi?id=116770
-m_document->enqueuePageshowEvent(PageshowEventPersisted);
-
-HistoryItem* historyItem = frame.loader().history().currentItem();
-if (historyItem && historyItem->stateObject())
-m_document->enqueuePopstateEvent(historyItem->stateObject());
-
 #if ENABLE(TOUCH_EVENTS) && !PLATFORM(IOS)
 if (m_document->hasTouchEventHandlers())
 m_document->page()->chrome().client().needTouchEvents(true);


Modified: branches/safari-603-branch/Source/WebCore/loader/FrameLoader.cpp (214235 => 214236)

--- branches/safari-603-branch/Source/WebCore/loader/FrameLoader.cpp	2017-03-21 23:40:26 UTC (rev 214235)
+++ branches/safari-603-branch/Source/WebCore/loader/FrameLoader.cpp	2017-03-22 00:06:26 UTC (rev 214236)
@@ -86,6 +86,7 @@
 #include "MainFrame.h"
 #include "MemoryCache.h"
 #include "MemoryRelease.h"
+#include "NoEventDispatchAssertion.h"
 #include "Page.h"
 #include "PageCache.h"
 #include "PageTransitionEvent.h"
@@ -1817,7 +1818,7 @@
 // commit to happen before any changes to viewport arguments and dealing with this there is difficult.
 m_frame.page()->chrome().setDispatchViewportDataDidChangeSuppressed(true);
 #endif
-

[webkit-changes] [214237] trunk

[beidson]

Title: [214237] trunk








Revision 214237
Author beid...@apple.com
Date 2017-03-21 17:08:40 -0700 (Tue, 21 Mar 2017)


Log Message
Disable all virtual tables.
 and https://bugs.webkit.org/show_bug.cgi?id=169928
Source/WebCore:

Reviewed by Jer Noble.

No new tests (Covered by changes to existing test).

* Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

LayoutTests:

Reviewed by Jer Noble.

* storage/websql/test-authorizer-expected.txt:
* storage/websql/test-authorizer.js:
(createStatementsCallback):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/websql/test-authorizer-expected.txt
trunk/LayoutTests/storage/websql/test-authorizer.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (214236 => 214237)

--- trunk/LayoutTests/ChangeLog	2017-03-22 00:06:26 UTC (rev 214236)
+++ trunk/LayoutTests/ChangeLog	2017-03-22 00:08:40 UTC (rev 214237)
@@ -1,3 +1,14 @@
+2017-03-21  Brady Eidson  
+
+Disable all virtual tables.
+ and https://bugs.webkit.org/show_bug.cgi?id=169928
+
+Reviewed by Jer Noble.
+
+* storage/websql/test-authorizer-expected.txt:
+* storage/websql/test-authorizer.js:
+(createStatementsCallback):
+
 2017-03-21  Zalan Bujtas  
 
 Tear down descendant renderers when 's display value is set to no "contents".


Modified: trunk/LayoutTests/storage/websql/test-authorizer-expected.txt (214236 => 214237)

--- trunk/LayoutTests/storage/websql/test-authorizer-expected.txt	2017-03-22 00:06:26 UTC (rev 214236)
+++ trunk/LayoutTests/storage/websql/test-authorizer-expected.txt	2017-03-22 00:08:40 UTC (rev 214237)
@@ -7,6 +7,7 @@
 SQLITE_CREATE_TRIGGER statement succeeded.
 SQLITE_CREATE_VIEW statement succeeded.
 SQLITE_CREATE_VTABLE statement failed: could not prepare statement (23 not authorized)
+SQLITE_CREATE_VTABLE (FTS3) statement failed: could not prepare statement (23 not authorized)
 SQLITE_READ statement succeeded.
 SQLITE_SELECT statement succeeded.
 SQLITE_DELETE statement succeeded.
@@ -40,6 +41,7 @@
 SQLITE_CREATE_TRIGGER statement failed: could not prepare statement (1 not authorized)
 SQLITE_CREATE_VIEW statement failed: could not prepare statement (23 not authorized)
 SQLITE_CREATE_VTABLE statement failed: could not prepare statement (23 not authorized)
+SQLITE_CREATE_VTABLE (FTS3) statement failed: could not prepare statement (23 not authorized)
 SQLITE_CREATE_INDEX statement succeeded.
 SQLITE_CREATE_TEMP_TABLE statement succeeded.
 SQLITE_CREATE_TEMP_TRIGGER statement succeeded.
@@ -47,6 +49,7 @@
 SQLITE_CREATE_TRIGGER statement succeeded.
 SQLITE_CREATE_VIEW statement succeeded.
 SQLITE_CREATE_VTABLE statement failed: could not prepare statement (23 not authorized)
+SQLITE_CREATE_VTABLE (FTS3) statement failed: could not prepare statement (23 not authorized)
 SQLITE_READ statement succeeded.
 SQLITE_SELECT statement succeeded.
 SQLITE_DELETE statement failed: could not prepare statement (23 not authorized)


Modified: trunk/LayoutTests/storage/websql/test-authorizer.js (214236 => 214237)

--- trunk/LayoutTests/storage/websql/test-authorizer.js	2017-03-22 00:06:26 UTC (rev 214236)
+++ trunk/LayoutTests/storage/websql/test-authorizer.js	2017-03-22 00:08:40 UTC (rev 214237)
@@ -58,6 +58,7 @@
 executeStatement(tx, "CREATE TRIGGER TestTrigger INSERT ON Test BEGIN SELECT COUNT(*) FROM Test; END;", "SQLITE_CREATE_TRIGGER");
 executeStatement(tx, "CREATE VIEW TestView AS SELECT COUNT(*) FROM Test;", "SQLITE_CREATE_VIEW");
 executeStatement(tx, "CREATE VIRTUAL TABLE TestVirtualTable USING MissingModule;", "SQLITE_CREATE_VTABLE");
+executeStatement(tx, "CREATE VIRTUAL TABLE TestVirtualTableFTS USING fts3;", "SQLITE_CREATE_VTABLE (FTS3)");
 }
 
 function otherStatementsCallback(tx)


Modified: trunk/Source/WebCore/ChangeLog (214236 => 214237)

--- trunk/Source/WebCore/ChangeLog	2017-03-22 00:06:26 UTC (rev 214236)
+++ trunk/Source/WebCore/ChangeLog	2017-03-22 00:08:40 UTC (rev 214237)
@@ -1,3 +1,16 @@
+2017-03-21  Brady Eidson  
+
+Disable all virtual tables.
+ and https://bugs.webkit.org/show_bug.cgi?id=169928
+
+Reviewed by Jer Noble.
+
+No new tests (Covered by changes to existing test).
+
+* Modules/webdatabase/DatabaseAuthorizer.cpp:
+(WebCore::DatabaseAuthorizer::createVTable):
+(WebCore::DatabaseAuthorizer::dropVTable):
+
 2017-03-21  Anders Carlsson  
 
 Remove bogus availability annotations from DOM SPI headers.


Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.cpp (214236 => 214237)

--- trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.cpp	2017-03-22 00:06:26 UTC (rev 214236)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseAuthorizer.cpp	

[webkit-changes] [214241] trunk/Source/WebCore

[simon . fraser]

Title: [214241] trunk/Source/WebCore








Revision 214241
Author simon.fra...@apple.com
Date 2017-03-21 20:49:50 -0700 (Tue, 21 Mar 2017)


Log Message
Make non-decoded image flashing less intrusive
https://bugs.webkit.org/show_bug.cgi?id=169942

Reviewed by Said Abou-Hallawa.

When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
frame. Give this yellow 50% alpha to make it less intrusive

Also log to the images log channel when we destroy decoded data.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (214240 => 214241)

--- trunk/Source/WebCore/ChangeLog	2017-03-22 01:55:00 UTC (rev 214240)
+++ trunk/Source/WebCore/ChangeLog	2017-03-22 03:49:50 UTC (rev 214241)
@@ -1,3 +1,19 @@
+2017-03-21  Simon Fraser  
+
+Make non-decoded image flashing less intrusive
+https://bugs.webkit.org/show_bug.cgi?id=169942
+
+Reviewed by Said Abou-Hallawa.
+
+When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
+frame. Give this yellow 50% alpha to make it less intrusive
+
+Also log to the images log channel when we destroy decoded data.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::destroyDecodedData):
+(WebCore::BitmapImage::draw):
+
 2017-03-20  Matt Rajca  
 
 Loosen audio playback restrictions when the volume is 0.


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (214240 => 214241)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-03-22 01:55:00 UTC (rev 214240)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-03-22 03:49:50 UTC (rev 214241)
@@ -65,6 +65,8 @@
 
 void BitmapImage::destroyDecodedData(bool destroyAll)
 {
+LOG(Images, "BitmapImage::%s - %p - url: %s", __FUNCTION__, this, sourceURL().utf8().data());
+
 if (!destroyAll)
 m_source.destroyDecodedDataBeforeFrame(m_currentFrame);
 else if (m_source.hasAsyncDecodingQueue())
@@ -169,7 +171,7 @@
 
 StartAnimationResult result = internalStartAnimation();
 if (result == StartAnimationResult::DecodingActive && showDebugBackground()) {
-fillWithSolidColor(context, destRect, Color::yellow, op);
+fillWithSolidColor(context, destRect, Color(Color::yellow).colorWithAlpha(0.5), op);
 return;
 }
 
@@ -188,7 +190,7 @@
 
 if (!frameHasDecodedNativeImage(m_currentFrame)) {
 if (showDebugBackground())
-fillWithSolidColor(context, destRect, Color::yellow, op);
+fillWithSolidColor(context, destRect, Color(Color::yellow).colorWithAlpha(0.5), op);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214219] trunk

[utatane . tea]

Title: [214219] trunk








Revision 214219
Author utatane@gmail.com
Date 2017-03-21 04:31:43 -0700 (Tue, 21 Mar 2017)


Log Message
[JSC] Optimize Number.prototype.toString on Int32 / Int52 / Double
https://bugs.webkit.org/show_bug.cgi?id=167454

Reviewed by Saam Barati.

JSTests:

* stress/number-to-string-abstract-operation.js: Added.
(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):
* stress/number-to-string-radix.js: Added.
(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):
* stress/number-to-string.js: Added.
(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

Source/_javascript_Core:

This patch improves Number.toString(radix) performance
by introducing NumberToStringWithRadix DFG node. It directly
calls the operation and it always returns String.

   baseline  patched

stanford-crypto-sha256-iterative45.130+-0.928 44.032+-1.184   might be 1.0250x faster

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/CCallHelpers.h
trunk/Source/_javascript_Core/jit/JITOperations.h
trunk/Source/_javascript_Core/runtime/Intrinsic.h
trunk/Source/_javascript_Core/runtime/NumberPrototype.cpp
trunk/Source/_javascript_Core/runtime/NumberPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp


Added Paths

trunk/JSTests/stress/number-to-string-abstract-operation.js
trunk/JSTests/stress/number-to-string-radix.js
trunk/JSTests/stress/number-to-string.js




Diff

Modified: trunk/JSTests/ChangeLog (214218 => 214219)

--- trunk/JSTests/ChangeLog	2017-03-21 11:16:47 UTC (rev 214218)
+++ trunk/JSTests/ChangeLog	2017-03-21 11:31:43 UTC (rev 214219)
@@ -1,3 +1,29 @@
+2017-03-21  Yusuke Suzuki  
+
+[JSC] Optimize Number.prototype.toString on Int32 / Int52 / Double
+https://bugs.webkit.org/show_bug.cgi?id=167454
+
+Reviewed by Saam Barati.
+
+* stress/number-to-string-abstract-operation.js: Added.
+(shouldBe):
+(int32ToString):
+(shouldBe.int32ToString.new.Number.int52ToString):
+(shouldBe.int32ToString.new.Number):
+(shouldBe.doubleToString):
+* stress/number-to-string-radix.js: Added.
+(shouldBe):
+(int32ToString):
+(shouldBe.int32ToString.new.Number.int52ToString):
+(shouldBe.int32ToString.new.Number):
+(shouldBe.doubleToString):
+* stress/number-to-string.js: Added.
+(shouldBe):
+(int32ToString):
+(shouldBe.int32ToString.new.Number.int52ToString):
+(shouldBe.int32ToString.new.Number):
+(shouldBe.doubleToString):
+
 2017-03-19  Chris Dumez  
 
 `const location = "foo"` throws in a worker


Added: trunk/JSTests/stress/number-to-string-abstract-operation.js (0 => 214219)

--- trunk/JSTests/stress/number-to-string-abstract-operation.js	(rev 0)
+++ trunk/JSTests/stress/number-to-string-abstract-operation.js	2017-03-21 11:31:43 UTC (rev 214219)
@@ -0,0 +1,80 @@
+function shouldBe(actual, expected)
+{
+if (actual !== expected)
+throw new Error(`bad value: expected:(${expected}),actual:(${actual})`);
+}
+
+function expected(num, radix)
+{
+let characters = "0123456789abcdefghijklmnopqrstuvwxyz";
+let result = "";
+let negative = false;
+if (num < 0) {
+negative = true;
+num = -num;
+}
+
+do {
+const index = num % radix;
+result = characters[index] + result;
+num = (num - index) / radix;
+} while (num);
+
+if (negative)
+return '-' + result;
+return result;
+}
+
+{
+function int32ToString(num)
+{
+return `${num}`;

[webkit-changes] [214220] trunk/Source/JavaScriptCore

[ossy]

Title: [214220] trunk/Source/_javascript_Core








Revision 214220
Author o...@webkit.org
Date 2017-03-21 04:42:36 -0700 (Tue, 21 Mar 2017)


Log Message
[ARM] Add missing MacroAssembler functions after r214187
https://bugs.webkit.org/show_bug.cgi?id=169912

Reviewed by Yusuke Suzuki.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::storeFloat):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (214219 => 214220)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-21 11:31:43 UTC (rev 214219)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-21 11:42:36 UTC (rev 214220)
@@ -1,3 +1,14 @@
+2017-03-21  Csaba Osztrogonác  
+
+[ARM] Add missing MacroAssembler functions after r214187
+https://bugs.webkit.org/show_bug.cgi?id=169912
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::loadFloat):
+(JSC::MacroAssemblerARM::storeFloat):
+
 2017-03-21  Yusuke Suzuki  
 
 [JSC] Optimize Number.prototype.toString on Int32 / Int52 / Double


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (214219 => 214220)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2017-03-21 11:31:43 UTC (rev 214219)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2017-03-21 11:42:36 UTC (rev 214220)
@@ -1185,6 +1185,12 @@
 static bool supportsFloatingPointAbs() { return false; }
 static bool supportsFloatingPointRounding() { return false; }
 
+
+void loadFloat(ImplicitAddress address, FPRegisterID dest)
+{
+m_assembler.dataTransferFloat(ARMAssembler::LoadFloat, dest, address.base, address.offset);
+}
+
 void loadFloat(BaseIndex address, FPRegisterID dest)
 {
 m_assembler.baseIndexTransferFloat(ARMAssembler::LoadFloat, dest, address.base, address.index, static_cast(address.scale), address.offset);
@@ -1224,6 +1230,11 @@
 CRASH();
 }
 
+void storeFloat(FPRegisterID src, ImplicitAddress address)
+{
+m_assembler.dataTransferFloat(ARMAssembler::StoreFloat, src, address.base, address.offset);
+}
+
 void storeFloat(FPRegisterID src, BaseIndex address)
 {
 m_assembler.baseIndexTransferFloat(ARMAssembler::StoreFloat, src, address.base, address.index, static_cast(address.scale), address.offset);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214222] trunk/Websites/planet.webkit.org

[rego]

Title: [214222] trunk/Websites/planet.webkit.org








Revision 214222
Author r...@igalia.com
Date 2017-03-21 07:34:36 -0700 (Tue, 21 Mar 2017)


Log Message
[Planet WebKit] Use HTTPS instead of HTTP for Igalia blog

Unreviewed patch just updating the Igalia WebKit blog configuration.

* config.ini:

Modified Paths

trunk/Websites/planet.webkit.org/ChangeLog
trunk/Websites/planet.webkit.org/config.ini




Diff

Modified: trunk/Websites/planet.webkit.org/ChangeLog (214221 => 214222)

--- trunk/Websites/planet.webkit.org/ChangeLog	2017-03-21 14:12:09 UTC (rev 214221)
+++ trunk/Websites/planet.webkit.org/ChangeLog	2017-03-21 14:34:36 UTC (rev 214222)
@@ -1,3 +1,11 @@
+2017-03-21  Manuel Rego Casasnovas  
+
+[Planet WebKit] Use HTTPS instead of HTTP for Igalia blog
+
+Unreviewed patch just updating the Igalia WebKit blog configuration.
+
+* config.ini:
+
 2016-05-15  Frederic Wang  
 
 Remove Frédéric Wang's blog from the planet


Modified: trunk/Websites/planet.webkit.org/config.ini (214221 => 214222)

--- trunk/Websites/planet.webkit.org/config.ini	2017-03-21 14:12:09 UTC (rev 214221)
+++ trunk/Websites/planet.webkit.org/config.ini	2017-03-21 14:34:36 UTC (rev 214222)
@@ -118,5 +118,5 @@
 name = Bruno de Oliveira Abinader
 nick = abinader
 
-[http://planet.igalia.com/webkit/rss20.xml]
+[https://planet.igalia.com/webkit/rss20.xml]
 name = Igalia WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [214225] trunk/Websites/bugs.webkit.org

[ddkilzer]

Title: [214225] trunk/Websites/bugs.webkit.org








Revision 214225
Author ddkil...@apple.com
Date 2017-03-21 09:54:04 -0700 (Tue, 21 Mar 2017)


Log Message
Commit local changes for Bugzilla 5.0.3

* images/favicon.ico: Update favicon from Dec 11, 2015.
* data/params.json: Deleted.

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/images/favicon.ico


Removed Paths

trunk/Websites/bugs.webkit.org/data/params.json




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (214224 => 214225)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2017-03-21 16:27:49 UTC (rev 214224)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2017-03-21 16:54:04 UTC (rev 214225)
@@ -1,5 +1,12 @@
 2017-03-21  David Kilzer  
 
+Commit local changes for Bugzilla 5.0.3
+
+* images/favicon.ico: Update favicon from Dec 11, 2015.
+* data/params.json: Deleted.
+
+2017-03-21  David Kilzer  
+
 Upgrade to Bugzilla 5.0.3.
 
 2017-02-01  Joseph Pecoraro  


Deleted: trunk/Websites/bugs.webkit.org/data/params.json (214224 => 214225)

--- trunk/Websites/bugs.webkit.org/data/params.json	2017-03-21 16:27:49 UTC (rev 214224)
+++ trunk/Websites/bugs.webkit.org/data/params.json	2017-03-21 16:54:04 UTC (rev 214225)
@@ -1,104 +0,0 @@
-{
-   "LDAPBaseDN" : "",
-   "LDAPbinddn" : "",
-   "LDAPfilter" : "",
-   "LDAPmailattribute" : "mail",
-   "LDAPserver" : "",
-   "LDAPstarttls" : "0",
-   "LDAPuidattribute" : "uid",
-   "RADIUS_NAS_IP" : "",
-   "RADIUS_email_suffix" : "",
-   "RADIUS_secret" : "",
-   "RADIUS_server" : "",
-   "ajax_user_autocompletion" : "0",
-   "allow_attachment_deletion" : "1",
-   "allow_attachment_display" : "1",
-   "allowbugdeletion" : "1",
-   "allowemailchange" : "1",
-   "allowuserdeletion" : "0",
-   "announcehtml" : "",
-   "attachment_base" : "https://bug-%bugid%-attachments.webkit.org/",
-   "auth_env_email" : "",
-   "auth_env_id" : "",
-   "auth_env_realname" : "",
-   "chartgroup" : "editbugs",
-   "collapsed_comment_tags" : "obsolete, spam",
-   "comment_taggers_group" : "editbugs",
-   "commentonchange_resolution" : "0",
-   "commentonduplicate" : "0",
-   "confirmuniqueusermatch" : "0",
-   "cookiedomain" : "",
-   "cookiepath" : "/",
-   "createemailregexp" : ".*",
-   "debug_group" : "admin",
-   "default_search_limit" : "1000",
-   "defaultopsys" : "Unspecified",
-   "defaultplatform" : "Unspecified",
-   "defaultpriority" : "P2",
-   "defaultquery" : "bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_to1=1_to2=1=1=1_contact2=1=Importance_desc_type=substring",
-   "defaultseverity" : "Normal",
-   "duplicate_or_move_bug_status" : "RESOLVED",
-   "emailregexp" : "^[\\w\\.\\+\\-=]+@[\\w\\.\\-]+\\.[\\w\\-]+$",
-   "emailregexpdesc" : "A legal address must contain exactly one '@', and at least one '.' after the @.",
-   "emailsuffix" : "",
-   "font_file" : "",
-   "globalwatchers" : "",
-   "inbound_proxies" : "",
-   "insidergroup" : "",
-   "last_visit_keep_days" : "10",
-   "letsubmitterchoosemilestone" : "1",
-   "letsubmitterchoosepriority" : "1",
-   "mail_delivery_method" : "SMTP",
-   "mailfrom" : "bugzilla-dae...@webkit.org",
-   "maintainer" : "ad...@webkit.org",
-   "makeproductgroups" : "0",
-   "max_search_results" : "1",
-   "maxattachmentsize" : "20480",
-   "maxlocalattachment" : "1024",
-   "maxusermatches" : "1000",
-   "memcached_namespace" : "bugzilla:",
-   "memcached_servers" : "",
-   "musthavemilestoneonaccept" : "0",
-   "mybugstemplate" : "buglist.cgi?bug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDemail1=%userid%emailtype1=exactemailassigned_to1=1emailreporter1=1",
-   "noresolveonopenblockers" : "0",
-   "or_groups" : "0",
-   "password_check_on_login" : "1",
-   "password_complexity" : "no_constraints",
-   "proxy_url" : "http://rpms2.macosforge.org:3128/",
-   "querysharegroup" : "editbugs",
-   "quip_list_entry_control" : "moderated",
-   "rememberlogin" : "on",
-   "requirelogin" : "0",
-   "search_allow_no_criteria" : "0",
-   "shadowdb" : "",
-   "shadowdbhost" : "",
-   "shadowdbport" : "3306",
-   "shadowdbsock" : "",
-   "shutdownhtml" : "",
-   "smtp_debug" : "0",
-   "smtp_password" : "",
-   "smtp_ssl" : "0",
-   "smtp_username" : "",
-   "smtpserver" : "bz.apple.com",
-   "ssl_redirect" : "1",
-   "sslbase" : "https://bugs.webkit.org/",
-   "strict_isolation" : "0",
-   "strict_transport_security" : "off",
-   "timetrackinggroup" : "",
-   "upgrade_notification" : "latest_stable_release",
-   "urlbase" : "https://bugs.webkit.org/",
-   "use_mailer_queue" : "1",
-   "use_see_also" : "1",
-   "useclassification" : "0",
-   "usemenuforusers" : "0",
-   "useqacontact" : "0",
-   "user_info_class" : "CGI",
-   "user_verify_class" : "DB",
-   "usestatuswhiteboard" : "0",
-   "usetargetmilestone" : "0",
-   "usevisibilitygroups" : "0",
-   "utf8" : "1",
-   "webdotbase" :