Re: [webkit-dev] Lots of “BREW” patches up for review
I will check the issue as soon as possible and let you know the result. In case there is a legal problem with BREW with regard to NDA, BREW MP can be used instead because BREW MP is an open platform. On Thu, Jan 14, 2010 at 6:27 AM, Holger Freyther ze...@selfish.org wrote: On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: Someone is porting WebKit to Qualcomm’s BREW. And there are many patches for that port; now a significant fraction of the unreviewed WebKit patches. Who’s going to review these? Is this a one-time code drop or is there an intent to maintain this port ongoing? Does the test suite work on the BREW platform yet? Will someone maintain a buildbot? I won’t be reviewing these patches myself until I know the answers to some of those questions. Last time I checked one needs to have a contract with Qualcomm (NDA) to get information (header files, documentation) that is beyond marketing bla bla. I would be interested if we are allowed to host and distribute the sourcecode that has used information which is under a NDA. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
Okay. I will add a new wiki page for the BREW port. Thanks. Regards, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat ariya.hida...@gmail.com wrote: This is not a one-time code drop. We want to maintain the BREW port ongoing and will do everything that are required to keep the BREW port up and running. Porting DumpRenderTree is still under work, but we have a complete BREW port which works fine both in BREW device and simulator. Kwang, can you add the all information about the port to http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page for that and add it to that list. -- Ariya Hidayat http://www.linkedin.com/in/ariyahidayat ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software products. Kenneth On Wed, Jan 13, 2010 at 9:32 PM, Darin Fisher da...@chromium.org wrote: On Wed, Jan 13, 2010 at 4:17 PM, Evan Martin e...@chromium.org wrote: On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach check-webkit-style about these cases 2) Remove the underscore check entirely My inclination is to do (2) because I haven't seen this check find many actual style problems. However, if we think that (1) is the better road, I'll be happy to make that happen. I frequently forget the underscore rule (since all the other code I work on prefers underscores). As a beneficiary of the style checker, I'd prefer to avoid (2) if possible. ditto. this is a problem for many folks who work in both the chromium and webkit repositories. levin's idea sounds best :) -darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I created a wiki for the BREW port of WebKit. https://trac.webkit.org/wiki/BREW Currently it contains preliminary information. I will add more contents gradually. Thanks, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat ariya.hida...@gmail.com wrote: This is not a one-time code drop. We want to maintain the BREW port ongoing and will do everything that are required to keep the BREW port up and running. Porting DumpRenderTree is still under work, but we have a complete BREW port which works fine both in BREW device and simulator. Kwang, can you add the all information about the port to http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page for that and add it to that list. -- Ariya Hidayat http://www.linkedin.com/in/ariyahidayat ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit.org/pending-review
On Jan 14, 2010, at 12:25 AM, Eric Seidel wrote: Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. The page that pending-review points to actually has some nice properties in the way it lays things out, but in other ways its harder to read. I'd really like it if we could make a review queue page that's combines their best features and is nicer than either. This may be hard. The queries I personally like to use these days are: http://tinyurl.com/y98qfjs (general patches, no bracket) http://tinyurl.com/yjr2xru (patches needing port-specific review, [bracket] prefix) Their main downside is that they do not sort by date of review request. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Video feature request
Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within Javascript without necessarily wanting to play it, but rather I want to be able to extract frames out of it as image objects and/or to extract the corresponding sound portions of frames. Thanks. _ Your E-mail and More On-the-Go. Get Windows Live Hotmail Free. http://clk.atdmt.com/GBL/go/196390709/direct/01/___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Video feature request
On Jan 14, 2010, at 9:00 AM, Zack S wrote: Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within Javascript without necessarily wanting to play it, but rather I want to be able to extract frames out of it as image objects and/or to extract the corresponding sound portions of frames. I can't speak to the sound aspect of this, but you can get pixel data by painting a video to the canvas element. --Oliver ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit.org/pending-review
I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: https://bugs.webkit.org/request.cgi?action=queuerequester=product=type=reviewrequestee=component=group=requestee Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Based on the web form, I don't see a way to filter out commit-queue? attachments while keeping request? flagged attachments, though. Dave - Original Message From: Eric Seidel e...@webkit.org To: WebKit Development webkit-dev@lists.webkit.org Sent: Thu, January 14, 2010 12:25:15 AM Subject: [webkit-dev] webkit.org/pending-review Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] webkit.org/pending-review
Yes, it is in the apache configs. Just email me or assign the bug to me when you've figured out where you want it to go. -Bill On Jan 14, 2010, at 9:23 AM, David Kilzer wrote: I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: https://bugs.webkit.org/request.cgi?action=queuerequester=product=type=reviewrequestee=component=group=requestee Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Based on the web form, I don't see a way to filter out commit-queue? attachments while keeping request? flagged attachments, though. Dave - Original Message From: Eric Seidel e...@webkit.org To: WebKit Development webkit-dev@lists.webkit.org Sent: Thu, January 14, 2010 12:25:15 AM Subject: [webkit-dev] webkit.org/pending-review Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some possible suggestions as to better URLs. Maciej is the man with the real URL magic though. :) I'm not sure how /pending-review is managed, it does not seem to be stored in WebKitSite/, perhaps someone on this list would know how to change it? Or would maybe folks have their own suggestions as to what URL we should use for /pending-review (if so please update the bug). /pending-review is used by http://nightly.webkit.org/start and may be linked to from other places in the site, I don't know. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Video feature request
On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: On Jan 14, 2010, at 9:00 AM, Zack S wrote: Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within Javascript without necessarily wanting to play it, but rather I want to be able to extract frames out of it as image objects and/or to extract the corresponding sound portions of frames. I can't speak to the sound aspect of this, but you can get pixel data by painting a video to the canvas element. There are cross-domain restrictions on this functionality, right? - ~Chris cmar...@apple.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Video feature request
On Jan 14, 2010, at 10:06 AM, Chris Marrin wrote: On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: On Jan 14, 2010, at 9:00 AM, Zack S wrote: Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within Javascript without necessarily wanting to play it, but rather I want to be able to extract frames out of it as image objects and/or to extract the corresponding sound portions of frames. I can't speak to the sound aspect of this, but you can get pixel data by painting a video to the canvas element. There are cross-domain restrictions on this functionality, right? The cross-origin restrictions are only present when reading back from the canvas - but any api that allowed someone to read or transmit the content of a video element from js would need to have the same restrictions. --Oliver - ~Chris cmar...@apple.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Did I break the build?
We've seen some remarkable progress towards greener bots in the last week! I've seen all of the bots roll green straight across 3 times in the last 24 hours! Small achievement, but better than before. :) Still a huge number of flakey tests to de-flake though: https://bugs.webkit.org/showdependencytree.cgi?id=33296hide_resolved=1 -eric On Thu, Jan 7, 2010 at 4:24 PM, Eric Seidel e...@webkit.org wrote: Oh, btw, you should see green all the way across, always. I'm currently chasing down the tests which are making some of the bots less reliable. The leaves of https://bugs.webkit.org/showdependencytree.cgi?id=33296hide_resolved=1 are all the bot reliability issues I've seen in the last 12 hours. :( -eric On Thu, Jan 7, 2010 at 4:21 PM, Eric Seidel e...@webkit.org wrote: http://build.webkit.org/console Will let you know. The tree has been very red today, and even redder yesterday. I'm working on yet another bot to help with this... -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] global new/delete operator in WebKit
On Jan 13, 2010, at 6:25 PM, Yong Li wrote: Sorry for my English. does should be will. I think your question is unclear. The WebKit project will not “ban” use of a global new/delete operator. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Video feature request
On Thu, 14 Jan 2010, Adam Barth wrote: I'm not sure if we've implemented it yet, but we could let video providers opt out of these protections using CORS. That will be specified in HTML5 around the same time that the cross-site subtitle stuff is added (since that has the same problem). -- Ian Hickson U+1047E)\._.,--,'``.fL http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,. Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.' ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Remove underscore check in check-webkit-style?
Date: Wed, 13 Jan 2010 15:49:05 -0800 From: David Levin le...@google.com 3) Stop checking code in gtk/qt platform directories for underscores? I think there are several other checks that code in some of these directories typically fail due to various issues (public api that should follow the standard public api format for that platform, etc.) I made a bug report for this issue: https://bugs.webkit.org/show_bug.cgi?id=33684 (This is distinct from the qt_ underscore issue, which has its own report: https://bugs.webkit.org/show_bug.cgi?id=33663 ) --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Database in Worker context
My main feedback on this plan would be to land and review the work in pieces that are as small as possible. For example, factoring out the database bits into a separate database manager class should be done in an initial first pass that does not make other changes. I’m also not sure I like classes with Manager in their name, but I suppose we have a lot of such classes (controllers, managers, etc.) in WebKit already. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Database in Worker context
Trying again; webkit-dev doesn't seem to like my @google.com address. On Thu, Jan 14, 2010 at 2:31 PM, Eric Uhrhane er...@google.com wrote: Dmitry requested that I not pull stuff out into DatabaseManager at all, so that step got skipped. The first changelist [currently in review] does a bunch of refactoring to make the database-in-workers possible, but does not yet expose any new functionality. I'm trying to keep the steps small, but I think it would have been hard to break this chunk any smaller. Eric On Thu, Jan 14, 2010 at 2:24 PM, Darin Adler da...@apple.com wrote: My main feedback on this plan would be to land and review the work in pieces that are as small as possible. For example, factoring out the database bits into a separate database manager class should be done in an initial first pass that does not make other changes. I’m also not sure I like classes with Manager in their name, but I suppose we have a lot of such classes (controllers, managers, etc.) in WebKit already. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Database in Worker context
On Jan 14, 2010, at 2:35 PM, Eric Uhrhane wrote: I think it would have been hard to break this chunk any smaller. Any time you have a chunk and you’re wondering how it could be broken up smaller, please feel free to ask that question after cc'ing me on a bug. Maciej and I, in particular, have a lot of experience with this, much of dating from the first year of the Safari project. I made changes that were too large and learned “no apologies” strategies to break them up into much smaller pieces that were easier to get right and to read and review. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Database in Worker context
+1 to small patches. I've reviewed a couple of iterations of the patch in https://bugs.webkit.org/show_bug.cgi?id=22725 and it was so far manageable, although it could be split in 2 at least (inheritance change and WorkerThread termination change). For future patches, definitely lets split into smaller ones, 60kb is on a biggish side. There is no DatabaseManager class anymore since the database-supporting methods are being moved to ScriptExecutionContext from which both Document and WorkerContext are derived from. Having a 'Context' to own another 'Manager' seemed like too much layers. I lean to r+ the first patch after latest set of notes is addressed, more eyes are always welcome though :-) Dmitry On Thu, Jan 14, 2010 at 3:06 PM, Darin Adler da...@apple.com wrote: On Jan 14, 2010, at 2:35 PM, Eric Uhrhane wrote: I think it would have been hard to break this chunk any smaller. Any time you have a chunk and you’re wondering how it could be broken up smaller, please feel free to ask that question after cc'ing me on a bug. Maciej and I, in particular, have a lot of experience with this, much of dating from the first year of the Safari project. I made changes that were too large and learned “no apologies” strategies to break them up into much smaller pieces that were easier to get right and to read and review. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
Sure. I will open a public Git repository for potential reviewers. I need to clean up the code before opening the complete source code because some device-specific information is from a phone manufacturer under NDA. I think it will take one or two days.Third party libraries with BREW specific patches will also be available by then. Thanks, Kwang Yul Seo On Fri, Jan 15, 2010 at 4:05 AM, Adam Treat tr...@kde.org wrote: You have a complete port of BREW already? Interesting. Can you point to the complete sources so potential reviewers can have a look at what the state is? On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: I created a wiki for the BREW port of WebKit. https://trac.webkit.org/wiki/BREW Currently it contains preliminary information. I will add more contents gradually. Thanks, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat ariya.hida...@gmail.com wrote: This is not a one-time code drop. We want to maintain the BREW port ongoing and will do everything that are required to keep the BREW port up and running. Porting DumpRenderTree is still under work, but we have a complete BREW port which works fine both in BREW device and simulator. Kwang, can you add the all information about the port to http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page for that and add it to that list. -- Ariya Hidayat http://www.linkedin.com/in/ariyahidayat ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for r eview
I don't feel like this question was ever answered. Folks seem to be moving forward with setting up infrastructure for a real port (which is good), but at least this question still remains. Also, does the BREW port already have a DumpRenderTree implementation? When should we expect such? -eric On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther ze...@selfish.org wrote: On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: Someone is porting WebKit to Qualcomm’s BREW. And there are many patches for that port; now a significant fraction of the unreviewed WebKit patches. Who’s going to review these? Is this a one-time code drop or is there an intent to maintain this port ongoing? Does the test suite work on the BREW platform yet? Will someone maintain a buildbot? I won’t be reviewing these patches myself until I know the answers to some of those questions. Last time I checked one needs to have a contract with Qualcomm (NDA) to get information (header files, documentation) that is beyond marketing bla bla. I would be interested if we are allowed to host and distribute the sourcecode that has used information which is under a NDA. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for r eview
Most of the BREW patches look fine. I'm happy to review them once there is consensus on the list that WebKit is ready and willing to accept a BREW port. -eric On Thu, Jan 14, 2010 at 5:26 PM, Eric Seidel e...@webkit.org wrote: I don't feel like this question was ever answered. Folks seem to be moving forward with setting up infrastructure for a real port (which is good), but at least this question still remains. Also, does the BREW port already have a DumpRenderTree implementation? When should we expect such? -eric On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther ze...@selfish.org wrote: On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: Someone is porting WebKit to Qualcomm’s BREW. And there are many patches for that port; now a significant fraction of the unreviewed WebKit patches. Who’s going to review these? Is this a one-time code drop or is there an intent to maintain this port ongoing? Does the test suite work on the BREW platform yet? Will someone maintain a buildbot? I won’t be reviewing these patches myself until I know the answers to some of those questions. Last time I checked one needs to have a contract with Qualcomm (NDA) to get information (header files, documentation) that is beyond marketing bla bla. I would be interested if we are allowed to host and distribute the sourcecode that has used information which is under a NDA. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] questions about allow-tabs
I have some background questions about the allow-tabs property. I imagine it pre-dates check-webkit-style by quite a while. (1) What's the reason and history behind our use of the property? (2) What component actually does the pre-commit check? I didn't find a reference to allow-tabs in WebKitTools/, but maybe I searched incorrectly. (3) Roughly speaking, how many and what types of files have the property set? (4) Are there any issues to be aware of with it when using a Git repository for development? While I'm asking, I might as well also ask -- what other subversion properties do we use? Thanks, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] MathML Patch - Current Code
I've create a new patch that contains all the current code that I have on MathML at: https://bugs.webkit.org/show_bug.cgi?id=33703 I don't expect anyone to review this patch (unless they want to do so). Since I can't create a branch, I'm using this patch to store the current working copy of my MathML code. This patch handles stretchy operators and row layout fairly well. It also supports fractions, sub/superscripts, over/under, fencing, and tables. I'm working on a status table that I'll put on the wiki somewhere that will detail what works, partially works, or is not implemented. I'll update this patch as I make progress or get smaller patches committed. I plan on creating smaller patches that contain code from this patch and as that gets committed, I'll update this bug with a new patch against the trunk. This pretty much invalidates the previous bug [1] I had for MathML support as the code as change fairly significantly. [1] https://bugs.webkit.org/show_bug.cgi?id=29529 -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] MathML Patch - Current Code
On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski a...@milowski.org wrote: I've create a new patch that contains all the current code that I have on MathML at: https://bugs.webkit.org/show_bug.cgi?id=33703 I don't expect anyone to review this patch (unless they want to do so). Since I can't create a branch, I'm using this patch to store the current working copy of my MathML code. Have you considered using git and creating local branches for yourself? This patch handles stretchy operators and row layout fairly well. It also supports fractions, sub/superscripts, over/under, fencing, and tables. I'm working on a status table that I'll put on the wiki somewhere that will detail what works, partially works, or is not implemented. I'll update this patch as I make progress or get smaller patches committed. I plan on creating smaller patches that contain code from this patch and as that gets committed, I'll update this bug with a new patch against the trunk. This pretty much invalidates the previous bug [1] I had for MathML support as the code as change fairly significantly. [1] https://bugs.webkit.org/show_bug.cgi?id=29529 -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] MathML Patch - Current Code
On Thu, Jan 14, 2010 at 8:27 PM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski a...@milowski.org wrote: I've create a new patch that contains all the current code that I have on MathML at: https://bugs.webkit.org/show_bug.cgi?id=33703 I don't expect anyone to review this patch (unless they want to do so). Since I can't create a branch, I'm using this patch to store the current working copy of my MathML code. Have you considered using git and creating local branches for yourself? Unless I'm missing something, that doesn't help me with distributing the code to others who want to work with it. ...and I'd have to learn to use git. Implementing MathML, learning all its secrets, and understand rendering in WebKit has made my brain full. ;) -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] questions about allow-tabs
On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: I have some background questions about the allow-tabs property. I imagine it pre-dates check-webkit-style by quite a while. (1) What's the reason and history behind our use of the property? The allow-tabs property (and the svn commit pre-hook) are the ultimate in style enforcement. The project didn't want tabs in source files (or ChangeLog files) committed accidentally, so any file with tabs needs the special allow-tabs svn property set. (2) What component actually does the pre-commit check? I didn't find a reference to allow-tabs in WebKitTools/, but maybe I searched incorrectly. It's on the server itself. I don't think it's available from the repository. (3) Roughly speaking, how many and what types of files have the property set? Mostly test files and (potentially) legacy source files are the only ones with the property set. (4) Are there any issues to be aware of with it when using a Git repository for development? No, just that you won't be able to use git svn dcommit when committing new files with tabs (or adding tabs to existing files). While I'm asking, I might as well also ask -- what other subversion properties do we use? In the past, svn:eol-style has been applied so that when files are checked out on Windows, they have the proper line endings. There is also a concerted effort to keep svn:mime-type set correctly on *-expected.png results for pixel tests committed via git. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] MathML Project Contact etc.
I'm presenting my MathML in WebKit work tomorrow at the Joint AMS/MAA meeting here in San Francisco. After looking through my slides I feel that I'm unsatisfied with what I'm telling people about where to go for more information or to contribute to the project. I'd like a better way for: * MathML in WebKit related discussions to take place, * dissemination of status, * collection of test cases, plans, roadmaps, * builds of a MathML enabled WebKit for testers. While some of this can take place on the wiki, a separate mailing list might be better for MathML+WebKit specific discussions. What's the standard practice for this kind of thing? I could certainly go start a google group for this kind of discussion. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] support for svg handler element
On 10/01/2010, at 1:27 AM, nagarjuna atluri wrote: Hai all, Is handler element for svg supported in webkit.. can anyone help me out.. If you're talking about the XML Events handler element that is mentioned in SVG 1.2, then the answer is no - it isn't supported. Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
