[webkit-dev] Best way to rebaseline 400+ tests?

2011-01-21 Thread Yuzo Fujishima

Hi, webkit-dev,

I'm preparing a change (https://bugs.webkit.org/show_bug.cgi?id=41363)
that will require rebaselining 400+ tests per platform.

What is the best way to do the rebaselining? (My assumption is that
the rebaselining tool is only for Chromium port).

I can certainly handle my platform (Snow Leopard) by removing the
existing expectations and having run-webkit-test generate new ones.
But what should I do for other platforms?

Yuzo
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Best way to rebaseline 400+ tests?

2011-01-21 Thread Adam Barth
Unfortunately, we don't have a good solution to this problem at the
moment.  Mihai can comment on the status of webkit-patch
rebaseline-server, which is pretty awesome.  webkit-patch rebaseline
is another option, but it's pretty bare-bones.

Koz is working on a new rebaseline command to rule them all in
https://bugs.webkit.org/show_bug.cgi?id=50098, but I'm not sure it's
ready quite yet.  His command will replace the exiting webkit-patch
rebaseline command and possibly integrate with the rebaseline-server
when its ready.

Adam


On Fri, Jan 21, 2011 at 1:21 AM, Yuzo Fujishima y...@google.com wrote:
 Hi, webkit-dev,
 I'm preparing a change (https://bugs.webkit.org/show_bug.cgi?id=41363)
 that will require rebaselining 400+ tests per platform.
 What is the best way to do the rebaselining? (My assumption is that
 the rebaselining tool is only for Chromium port).
 I can certainly handle my platform (Snow Leopard) by removing the
 existing expectations and having run-webkit-test generate new ones.
 But what should I do for other platforms?
 Yuzo
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Best way to rebaseline 400+ tests?

2011-01-21 Thread Mihai Parparita
The rebaseline server is checked in.
https://trac.webkit.org/wiki/RebaselineServer has instructions on how
to use it, please let me know if anything is unclear.

Right now it only works well with local layout test results. I have a
patch up at https://bugs.webkit.org/show_bug.cgi?id=52039 that makes
it work with results from bots, but you still have to download the
results (zip file) from the bot yourself. Next patch after that will
hopefully do the downloading automatically.

In either case, you first have to land your patch, have the tests fail
(ideally, for bots that use NRWT you can pre-emptively add failing
expectations to test_expectations.txt), and then rebaseline. There's
still no easy to rebaseline ahead of time unless you have access to
machines that can build the various affected ports. Coordinating with
the (Chromium) gardener and other build cop-type people is helpful.

Mihai

On Fri, Jan 21, 2011 at 2:22 AM, Adam Barth aba...@webkit.org wrote:
 Unfortunately, we don't have a good solution to this problem at the
 moment.  Mihai can comment on the status of webkit-patch
 rebaseline-server, which is pretty awesome.  webkit-patch rebaseline
 is another option, but it's pretty bare-bones.

 Koz is working on a new rebaseline command to rule them all in
 https://bugs.webkit.org/show_bug.cgi?id=50098, but I'm not sure it's
 ready quite yet.  His command will replace the exiting webkit-patch
 rebaseline command and possibly integrate with the rebaseline-server
 when its ready.

 Adam


 On Fri, Jan 21, 2011 at 1:21 AM, Yuzo Fujishima y...@google.com wrote:
 Hi, webkit-dev,
 I'm preparing a change (https://bugs.webkit.org/show_bug.cgi?id=41363)
 that will require rebaselining 400+ tests per platform.
 What is the best way to do the rebaselining? (My assumption is that
 the rebaselining tool is only for Chromium port).
 I can certainly handle my platform (Snow Leopard) by removing the
 existing expectations and having run-webkit-test generate new ones.
 But what should I do for other platforms?
 Yuzo
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Modification to WebKit reviewer nominations.

2011-01-21 Thread David Levin
As the WebKit community continues to grow rapidly, it is useful to consider
how to retain its health and culture. One important aspect of our community
has been the way that people work together regardless of their affiliations.

In order to emphasize this tradition, the WebKit reviewers have agreed to
update the policy for new reviewers nominations. In short, new nominations
will require one more supporting reviewer who is not in the same place of
employment or project as the nominee.

You can see the change here: http://trac.webkit.org/changeset/76367

Thank you,
dave on behalf of the WebKit reviewers
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev