[webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Unless we missed something, sources tied to GSTREAMER (like wtf\gobject\GlibUtilities.cpp) appear, sort of, unobtainable. Anyone under position to shed lights on these missing .CPP files required by Webkit ? -- gstreamerForEver On Sun, 2013-10-13 at 14:22 +0200, Urbain EGIS wrote: Probably a painful and hackful job in sight, as we have been told. And as a prototype, to start with. Your forewords are appreciate of course. Would you mind providing some guidance to where/how to source files may be located. Example : \wtf\gobject\GlibUtilities.cpp Thanks in advance, Philippe. Regards, EGIS On Sat, Oct 12, 2013 at 3:59 PM, Philippe Normand ph...@igalia.com wrote: On Sat, 2013-10-12 at 14:53 +0200, Urbain EGIS wrote: Of course, I'm part of the challenge, Hugo. I started to analyse .diff files gently provided by Alex. Let's focus on one example : --- Source/WTF/WTF.vcxproj/WTF.vcxproj (revision 156730) +++ Source/WTF/WTF.vcxproj/WTF.vcxproj (working copy) @@ -73,6 +73,9 @@ ... +ClCompile Include=..\wtf\gobject \GlibUtilities.cpp / ... Then my question is : where can I find this CPP file wtf\gobject \GlibUtilities.cpp ? I have done: git clone http://git.igalia.com/webkit.git but is it the right way to get GSTREAMER-centric source files for/by WebKit ? It seems it's not enough/accurate Please don't forget that branch is more than 3 years old. A lot of code changed in WebKit since then. And most of the commits in that branch were not really ready to be upstreamed as it was mostly a proof-of-concept. Philippe On Fri, Oct 11, 2013 at 11:05 PM, Hugo Machefer hugo.mache...@gmail.com wrote: Utterly, I'd be glad to take a serious and deep step forwards into this direction. Therefore, on both Brendan Alex's instructions I'm gona opt for GSTREAMER as a default player, oviously. Urbain, are you with me/us ? The more, the merrier, you know ;-) First, as mentionned earlier, check with ENABLE(VIDEO) = shall be disclosing as a consequence many CPP files impacted. On my side, I am gona set WTF_USE_GSTREAMER, and look closely at previous clues by http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst. Of course, Alex, any piece of your updated code (off of the webkit-dev list) will be more than welcome. On Fri, Oct 11, 2013 at 10:34 PM, Alex Christensen alex.christen...@flexsim.com wrote: I would like WinCairo to have video enabled, also, but it would take some work. This was done successfully a few years ago by Phillippe Normand, but his code needs to be updated. I got it compiling a few days ago, but something was wrong with my GStreamer installation. Here's Phillippe's branch: http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst If anyone wants to look at my updated code, let me know and I'll email a diff off of the webkit-dev list. Alex Christensen On Fri, Oct 11, 2013 at 2:25 PM, Brendan Long s...@brendanlong.com wrote: On 10/11/2013 02:13 PM, Urbain EGIS wrote: Playing a bit with WebKit sources for Windows (using WinCairo port) I expected to activate HTML5 video tag. I just simply put : #define ENABLE_VIDEO 1 and rebuilt everything. But I realized that only few files are concerned by USE(ENABLE_VIDEO) and are not even .CPP files. It would be ENABLE(VIDEO), not USE(ENABLE_VIDEO). So
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On Mon, 2013-10-14 at 11:51 +0200, gstreamer MACOSX wrote: Unless we missed something, sources tied to GSTREAMER (like wtf \gobject\GlibUtilities.cpp) appear, sort of, unobtainable. Anyone under position to shed lights on these missing .CPP files required by Webkit ? Have you actually searched in source tree? See Source/WTF/wtf/gobject/GlibUtilities.cpp ... Philippe -- gstreamerForEver On Sun, 2013-10-13 at 14:22 +0200, Urbain EGIS wrote: Probably a painful and hackful job in sight, as we have been told. And as a prototype, to start with. Your forewords are appreciate of course. Would you mind providing some guidance to where/how to source files may be located. Example : \wtf\gobject\GlibUtilities.cpp Thanks in advance, Philippe. Regards, EGIS On Sat, Oct 12, 2013 at 3:59 PM, Philippe Normand ph...@igalia.com wrote: On Sat, 2013-10-12 at 14:53 +0200, Urbain EGIS wrote: Of course, I'm part of the challenge, Hugo. I started to analyse .diff files gently provided by Alex. Let's focus on one example : --- Source/WTF/WTF.vcxproj/WTF.vcxproj (revision 156730) +++ Source/WTF/WTF.vcxproj/WTF.vcxproj (working copy) @@ -73,6 +73,9 @@ ... +ClCompile Include=..\wtf\gobject \GlibUtilities.cpp / ... Then my question is : where can I find this CPP file wtf\gobject \GlibUtilities.cpp ? I have done: git clone http://git.igalia.com/webkit.git but is it the right way to get GSTREAMER-centric source files for/by WebKit ? It seems it's not enough/accurate Please don't forget that branch is more than 3 years old. A lot of code changed in WebKit since then. And most of the commits in that branch were not really ready to be upstreamed as it was mostly a proof-of-concept. Philippe On Fri, Oct 11, 2013 at 11:05 PM, Hugo Machefer hugo.mache...@gmail.com wrote: Utterly, I'd be glad to take a serious and deep step forwards into this direction. Therefore, on both Brendan Alex's instructions I'm gona opt for GSTREAMER as a default player, oviously. Urbain, are you with me/us ? The more, the merrier, you know ;-) First, as mentionned earlier, check with ENABLE(VIDEO) = shall be disclosing as a consequence many CPP files impacted. On my side, I am gona set WTF_USE_GSTREAMER, and look closely at previous clues by http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst. Of course, Alex, any piece of your updated code (off of the webkit-dev list) will be more than welcome. On Fri, Oct 11, 2013 at 10:34 PM, Alex Christensen alex.christen...@flexsim.com wrote: I would like WinCairo to have video enabled, also, but it would take some work. This was done successfully a few years ago by Phillippe Normand, but his code needs to be updated. I got it compiling a few days ago, but something was wrong with my GStreamer installation. Here's Phillippe's branch: http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst If anyone wants to look at my updated code, let me know and I'll email a diff off of the webkit-dev list. Alex Christensen On Fri, Oct 11, 2013 at 2:25 PM, Brendan Long s...@brendanlong.com wrote: On 10/11/2013 02:13 PM, Urbain EGIS wrote: Playing a bit with WebKit sources for Windows (using WinCairo port) I expected to activate HTML5 video tag. I just simply put : #define ENABLE_VIDEO 1 and rebuilt everything. But I realized that only few
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Exactly, Philippe: I searched everywhere by D:\Users\gstreamermacosx\webkit\Source but without any success. I applyed this command like my counterparts ... : *git clone http://git.igalia.com/webkit.git* Is it correct ? In fact, there is not even any Source/*WTF *sub-folder. -- gstreamerForEver On Mon, Oct 14, 2013 at 11:59 AM, Philippe Normand ph...@igalia.com wrote: On Mon, 2013-10-14 at 11:51 +0200, gstreamer MACOSX wrote: Unless we missed something, sources tied to GSTREAMER (like wtf \gobject\GlibUtilities.cpp) appear, sort of, unobtainable. Anyone under position to shed lights on these missing .CPP files required by Webkit ? Have you actually searched in source tree? See Source/WTF/wtf/gobject/GlibUtilities.cpp ... Philippe -- gstreamerForEver On Sun, 2013-10-13 at 14:22 +0200, Urbain EGIS wrote: Probably a painful and hackful job in sight, as we have been told. And as a prototype, to start with. Your forewords are appreciate of course. Would you mind providing some guidance to where/how to source files may be located. Example : \wtf\gobject\GlibUtilities.cpp Thanks in advance, Philippe. Regards, EGIS On Sat, Oct 12, 2013 at 3:59 PM, Philippe Normand ph...@igalia.com wrote: On Sat, 2013-10-12 at 14:53 +0200, Urbain EGIS wrote: Of course, I'm part of the challenge, Hugo. I started to analyse .diff files gently provided by Alex. Let's focus on one example : --- Source/WTF/WTF.vcxproj/WTF.vcxproj (revision 156730) +++ Source/WTF/WTF.vcxproj/WTF.vcxproj (working copy) @@ -73,6 +73,9 @@ ... +ClCompile Include=..\wtf\gobject \GlibUtilities.cpp / ... Then my question is : where can I find this CPP file wtf\gobject \GlibUtilities.cpp ? I have done: git clone http://git.igalia.com/webkit.git but is it the right way to get GSTREAMER-centric source files for/by WebKit ? It seems it's not enough/accurate Please don't forget that branch is more than 3 years old. A lot of code changed in WebKit since then. And most of the commits in that branch were not really ready to be upstreamed as it was mostly a proof-of-concept. Philippe On Fri, Oct 11, 2013 at 11:05 PM, Hugo Machefer hugo.mache...@gmail.com wrote: Utterly, I'd be glad to take a serious and deep step forwards into this direction. Therefore, on both Brendan Alex's instructions I'm gona opt for GSTREAMER as a default player, oviously. Urbain, are you with me/us ? The more, the merrier, you know ;-) First, as mentionned earlier, check with ENABLE(VIDEO) = shall be disclosing as a consequence many CPP files impacted. On my side, I am gona set WTF_USE_GSTREAMER, and look closely at previous clues by http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst. Of course, Alex, any piece of your updated code (off of the webkit-dev list) will be more than welcome. On Fri, Oct 11, 2013 at 10:34 PM, Alex Christensen alex.christen...@flexsim.com wrote: I would like WinCairo to have video enabled, also, but it would take some work. This was done successfully a few years ago by Phillippe Normand, but his code needs to be updated. I got it compiling a few days ago, but something was wrong with my GStreamer installation. Here's Phillippe's branch: http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst If anyone wants to look at my updated code, let me know and I'll email a diff off of the webkit-dev list. Alex Christensen On Fri, Oct 11, 2013 at 2:25 PM, Brendan Long s...@brendanlong.com wrote: On 10/11/2013
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On Mon, 2013-10-14 at 12:14 +0200, gstreamer MACOSX wrote: Exactly, Philippe: I searched everywhere by D:\Users\gstreamermacosx \webkit\Source but without any success. I applyed this command like my counterparts ... : git clone http://git.igalia.com/webkit.git Is it correct ? In fact, there is not even any Source/WTF sub-folder. Like I said earlier, that repository is 3 years old, a lot of changes were made, including the move of wtf from JavascriptCore/ to Source/ Seriously, get in touch with Alexander. IIUC he got the patches updated for trunk already... Philippe -- gstreamerForEver On Mon, Oct 14, 2013 at 11:59 AM, Philippe Normand ph...@igalia.com wrote: On Mon, 2013-10-14 at 11:51 +0200, gstreamer MACOSX wrote: Unless we missed something, sources tied to GSTREAMER (like wtf \gobject\GlibUtilities.cpp) appear, sort of, unobtainable. Anyone under position to shed lights on these missing .CPP files required by Webkit ? Have you actually searched in source tree? See Source/WTF/wtf/gobject/GlibUtilities.cpp ... Philippe -- gstreamerForEver On Sun, 2013-10-13 at 14:22 +0200, Urbain EGIS wrote: Probably a painful and hackful job in sight, as we have been told. And as a prototype, to start with. Your forewords are appreciate of course. Would you mind providing some guidance to where/how to source files may be located. Example : \wtf\gobject\GlibUtilities.cpp Thanks in advance, Philippe. Regards, EGIS On Sat, Oct 12, 2013 at 3:59 PM, Philippe Normand ph...@igalia.com wrote: On Sat, 2013-10-12 at 14:53 +0200, Urbain EGIS wrote: Of course, I'm part of the challenge, Hugo. I started to analyse .diff files gently provided by Alex. Let's focus on one example : --- Source/WTF/WTF.vcxproj/WTF.vcxproj (revision 156730) +++ Source/WTF/WTF.vcxproj/WTF.vcxproj (working copy) @@ -73,6 +73,9 @@ ... +ClCompile Include=..\wtf\gobject \GlibUtilities.cpp / ... Then my question is : where can I find this CPP file wtf \gobject \GlibUtilities.cpp ? I have done: git clone http://git.igalia.com/webkit.git but is it the right way to get GSTREAMER-centric source files for/by WebKit ? It seems it's not enough/accurate Please don't forget that branch is more than 3 years old. A lot of code changed in WebKit since then. And most of the commits in that branch were not really ready to be upstreamed as it was mostly a proof-of-concept. Philippe On Fri, Oct 11, 2013 at 11:05 PM, Hugo Machefer hugo.mache...@gmail.com wrote: Utterly, I'd be glad to take a serious and deep step forwards into this direction. Therefore, on both Brendan Alex's instructions I'm gona opt for GSTREAMER as a default player, oviously. Urbain, are you with me/us ? The more, the merrier, you know ;-) First, as mentionned earlier, check with ENABLE(VIDEO) = shall be disclosing as a consequence many CPP files impacted. On my side, I am gona set WTF_USE_GSTREAMER, and look closely at previous clues by http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst. Of course, Alex, any piece of your updated code (off of the webkit-dev list) will be more
Re: [webkit-dev] Heads-up: ENABLE_GESTURE_EVENTS removal
Hi, I've successfully removed GESTURE_EVENTS dependency on Nix but there is a minor issue: we lost touch adjustment functionality and layout tests won't work. Is there any other port using touch adjustment that will be removed by ENABLE_GESTURE_EVENTS patch? Cheers, Luciano On Thu, Oct 10, 2013 at 9:43 PM, Sam Weinig wei...@apple.com wrote: Sounds good. -Sam On Oct 10, 2013, at 3:18 PM, Anders Carlsson ander...@apple.com wrote: Hello, I’m planning to remove the ENABLE_GESTURE_EVENTS ifdef and related code. It was used by Chromium (and perhaps to some extent Qt) as well as WebKit2 for trackpad events before we switched over to wheel events (which is the recommended way to do things). From what I can see all the code in both WebKit2 and WebCore is dead. - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 04:14 AM, gstreamer MACOSX wrote: Exactly, Philippe: I searched everywhere by D:\Users\gstreamermacosx\webkit\Source but without any success. I applyed this command like my counterparts ... : *git clone /http://git.igalia.com/webkit.git/* Is it correct ? In fact, there is not even any Source/*WTF *sub-folder. I think he meant you should use the normal repo: git clone git://git.webkit.org/WebKit.git (Or use SVN if you're into that?) Rebasing a patch from a 3-year-old checkout would be extremely difficult, so it's easier to figure out what the patch does, and re-apply it manually on a new checkout. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Hi, I have few questions regarding move to Gstreamer. * are we gonna replace the existing openssl and curl with libsoup ? * are we considering any other possibilities besides gstreamer like ffmpeg ( http://www.ffmpeg.org/) or any other. By moving to gstreamer would increase dependencies size a lot as the all GTK base libraries would be included by default and this would be concern to atleast few of us who does not want to increase the webkit base dependencies library by huge amount. I may be missing something here.. can anybody clarify the advantages of moving to gtk based gstreamer over the other side like the binary size increase. Regards, Mital Vora. On Mon, Oct 14, 2013 at 9:54 PM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 04:14 AM, gstreamer MACOSX wrote: Exactly, Philippe: I searched everywhere by D:\Users\gstreamermacosx\webkit\Source but without any success. I applyed this command like my counterparts ... : *git clone http://git.igalia.com/webkit.git* Is it correct ? In fact, there is not even any Source/*WTF *sub-folder. I think he meant you should use the normal repo: git clone git://git.webkit.org/WebKit.git (Or use SVN if you're into that?) Rebasing a patch from a 3-year-old checkout would be extremely difficult, so it's easier to figure out what the patch does, and re-apply it manually on a new checkout. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On Mon, 2013-10-14 at 22:09 +0530, Mital Vora wrote: Hi, I have few questions regarding move to Gstreamer. * are we gonna replace the existing openssl and curl with libsoup ? 1. GStreamer doesn't depend on those libraries. 2. For HTTP(S) media access we have a dedicated source element in WebKit that uses the WebCore ResourceLoader to fetch data. * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. Feel free to provide a MediaPlayerPrivateFFMpeg if you want. But be ready to maintain it too :) By moving to gstreamer would increase dependencies size a lot as the all GTK base libraries would be included by default and this would be concern to atleast few of us who does not want to increase the webkit base dependencies library by huge amount. I may be missing something here.. can anybody clarify the advantages of moving to gtk based gstreamer over the other side like the binary size increase. Regards, Mital Vora. On Mon, Oct 14, 2013 at 9:54 PM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 04:14 AM, gstreamer MACOSX wrote: Exactly, Philippe: I searched everywhere by D:\Users \gstreamermacosx\webkit\Source but without any success. I applyed this command like my counterparts ... : git clone http://git.igalia.com/webkit.git Is it correct ? In fact, there is not even any Source/WTF sub-folder. I think he meant you should use the normal repo: git clone git://git.webkit.org/WebKit.git (Or use SVN if you're into that?) Rebasing a patch from a 3-year-old checkout would be extremely difficult, so it's easier to figure out what the patch does, and re-apply it manually on a new checkout. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 10:39 AM, Mital Vora wrote: I have few questions regarding move to Gstreamer. * are we gonna replace the existing openssl and curl with libsoup ? The GStreamer media player https://github.com/WebKit/webkit/tree/master/Source/WebCore/platform/graphics/gstreamer already exists. You don't need to write it from scratch, you just need to make your port use it. * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. Chrome uses FFMPEG, so if you look at the source when the Blink fork happened, there might be a working FFMPEG media player. I'm not familiar enough to say why it might be better, but Chrome and Firefox both use FFMPEG, so it's clearly workable. The downside will be that no other ports are currently using FFMPEG, so your media player might get less attention. By moving to gstreamer would increase dependencies size a lot as the all GTK base libraries would be included by default and this would be concern to atleast few of us who does not want to increase the webkit base dependencies library by huge amount. GStreamer depends on GLib, not GTK. I don't know how GLib will effect the binary size though. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundation https://en.wikipedia.org/wiki/Media_Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since WinCairo is pretty solidly Windows-only. -Brent On Oct 14, 2013, at 10:00 AM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Commit queue down due to Apple internal network issues
This problem appears to have been worked out over the weekend. The commit queue should be working as expected by now. - R. Niwa On Fri, Oct 11, 2013 at 9:53 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It appears that the machines running commit queue cannot reach svn.webkit.org due to some network issues. Please land patches manually until a further notice. If you're not a committer yet, please reply to this thread with a bug number and I'll land it manually for you (as long as it has been reviewed). - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. -Brent On Oct 14, 2013, at 10:23 AM, Brent Fulgham bfulg...@apple.com wrote: Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since WinCairo is pretty solidly Windows-only. -Brent On Oct 14, 2013, at 10:00 AM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 12:08 PM, Brent Fulgham wrote: The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. Does WebKit still build on XP? signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
On 10/14/2013 12:18 PM, Brent Fulgham wrote: On Oct 14, 2013, at 11:12 AM, Brendan Long s...@brendanlong.com wrote: Does WebKit still build on XP? Yes. And it is intended to stay that way for the foreseeable future. In that case, it may be better to use DirectShow https://en.wikipedia.org/wiki/DirectShow. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Fri, Oct 11, 2013 at 12:14 AM, Chris Fleizach cfleiz...@apple.comwrote: Hi The naming of these methods also made it a bit confusing for me. It appears that drawCustomFocusRing just updates the accessibility rectangle -- while the system variant does that, and draws the normal focus ring. In the former case, it doesn't really draw anything, it just allows an AT to retrieve the bounding box of the focused item. It seems that for this to be useful for ATs, you'd have to iterate every object in your canvas and call at least drawCustomFocusRing once. Then when the item actually did become focused, you'd have to call drawSystemFocusRing. I don't know what others think, but I think accessibility work is best done on demand. In this case I could imagine something like a RectangleRequestEvent be dispatched that the canvas could intercept. The event would have the Element in question as a data member of the Event. The canvas could set the rectangle in the event for that element Then this work would only have to be done when requested This doesn't seem very workable and forces the developer to do more work. If you think about how a canvas application woks, during the drawing cycle, there's an understanding that a control is drawn. At that point, it's straightforward to call drawCustom/SystemFocusRing and draw the focus area. I suspect that most UI implementations do the same (probably by checking the focused attribute). Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. On Oct 10, 2013, at 7:32 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 7:21 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, Oct 10, 2013 at 7:19 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 10, 2013 at 7:14 PM, Rik Cabanier caban...@gmail.comwrote: On Thu, Oct 10, 2013 at 7:07 PM, Ryosuke Niwa rn...@webkit.orgwrote: The spec. text is also misleading in saying that The drawSystemFocusRing(element) method, when invoked, must run the following steps: If I understood your reply correctly, these are steps that need to be ran continuously? Or is it that steps 2 3 must run upon the currently focused element being changed. The specification needs to revised to clarify this. I think non-normative text or a note could be added to make this more clear. In general, the function should be called when the focus changes or the element is relocated and the canvas should be redrawn. ... As is, the specification reads as if the author needs to repaint and call drawSystemFocusRing upon focus change. That is correct and what should happen. That seems to contract what you've said earlier: What is an AT? :-) You don't call drawSystemFocusRing when an element is focused. You *always* call it and if it is focused, a ring will be drawn. In all cases, the accessibility software is notified of the area. (AT stands for http://en.wikipedia.org/wiki/Assistive_technology). Am I correct in saying that the author needs to call this function each and every time an element inside the canvas is focused? No, he needs to ALWAYS call this function wether it's focused or not. I understand that. My point is that the author has to explicitly repaint the canvas and call drawSystemFocusRing when the focus changed for the focus ring to be drawn. i.e. UA can't later decide to draw the focus ring on its own. That is correct. The accessibility software can though since it just draws on top of the browser windows (and so can the web inspector) ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) — Timothy Hatcher ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] [WinCairo] : Gstreamer claimed as a default player = CPP files needed (ex: ...gobject\GlibUtilities.cpp)
We came to obvious conclusions that a new topic shall be opened, not to break other parallel discussions yielded around Video tag by https://lists.webkit.org/pipermail/webkit-dev/2013-October/025723.html Our request remains highly common, much simple (we hope ;-) Alex: could you pls provide us with Webkit files related to Gstreamer integration ? Thanks in advance. Best Regards. -- Egis ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : Gstreamer claimed as a default player = CPP files needed (ex: ...gobject\GlibUtilities.cpp)
On 10/14/2013 02:33 PM, Urbain EGIS wrote: Alex: could you pls provide us with Webkit files related to Gstreamer integration ? GStreamer support is already included in the main WebKit repo. Look in Source/WebCore/platform/graphics/gstreamer. signature.asc Description: OpenPGP digital signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Isn't focus ring drawn on the canvas? If so, it's important the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, the entire focus ring would be drawn inside of the visible region. Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? It may, for example, leak information as to whether user's machine in high contrast mode, which is another dimension for finger-printing user. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? It may, for example, leak information as to whether user's machine is in high contrast mode, which is another dimension for finger-printing user. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? Hi, I think it would be likely that the OS would draw their focus ring on top in a different context and the canvas wouldn't have to be responsible to repaint. Which leaves the case where the canvas sees drawCursor fails and then tries to draw its own, which seems somewhat strange to me. How would the web page know what the user wanted. There could be a variety of high contrast cursors that the user might want to use Thanks ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. True. That sounds like bad design though. Wouldn't you have the same problem with focusable content in an overflow:hidden element that just fits its child? Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? It may, for example, leak information as to whether user's machine is in high contrast mode, which is another dimension for finger-printing user. Yes, maybe this should taint. Dominic, what do you think? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 2:46 PM, Chris Fleizach cfleiz...@apple.com wrote: On Oct 14, 2013, at 2:28 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? Hi, I think it would be likely that the OS would draw their focus ring on top in a different context and the canvas wouldn't have to be responsible to repaint. Doesn't that require another buffer that has the same memory size as the canvas? Or did you mean that it draws the focus ring on top right after the canvas backing store is composited? drawSystemFocusRing would be dropped with this proposal, right? Which leaves the case where the canvas sees drawCursor fails and then tries to draw its own, which seems somewhat strange to me. How would the web page know what the user wanted. I'm unsure what you mean. could you rephrase? There could be a variety of high contrast cursors that the user might want to use My patch looks like this: GraphicsContext* c = drawingContext(); if (c) c-drawFocusRing(m_path, 1, 1, RenderTheme::focusRingColor()); Should that use the focus ring color and style that the user picked? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 2:50 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.comwrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. True. That sounds like bad design though. Why? It doesn't seem particularly strange to have an element occupy the entire canvas momentarily. Wouldn't you have the same problem with focusable content in an overflow:hidden element that just fits its child? Even if this was broken, we could fix that because the focus ring is currently drawn by the UA. On the other hand, we're exposing an API to manually draw the focus ring on the canvas, then it's much harder to fix it. And I'm getting totally confused by this whole discussion because you've been kept telling us that UA could draw focus ring later to mitigate issues/concerns we've raised while at the same time telling us that authors have to call these functions whenever focus changes to redraw the focus ring. It's one or the other. The focus ring should be either drawn by this API, in which case, all the concerns we've raised thus far stands; or that the focus ring is drawn by UA at its discretion (potentially synchronously) in which case the function name should be changed. Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? It may, for example, leak information as to whether user's machine is in high contrast mode, which is another dimension for finger-printing user. Yes, maybe this should taint. Dominic, what do you think? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Commit queue down due to Apple internal network issues
https://bugs.webkit.org/show_bug.cgi?id=122534 Not sure why this one failed to commit. Rebased just incase, but nothing indicates that this is an issue with the patch (at least to me). Possibly related? Thanks for taking a look. - Sam On Oct 14, 2013, at 10:45 AM, Ryosuke Niwa rn...@webkit.org wrote: This problem appears to have been worked out over the weekend. The commit queue should be working as expected by now. - R. Niwa On Fri, Oct 11, 2013 at 9:53 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It appears that the machines running commit queue cannot reach svn.webkit.org due to some network issues. Please land patches manually until a further notice. If you're not a committer yet, please reply to this thread with a bug number and I'll land it manually for you (as long as it has been reviewed). - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 2:58 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:50 PM, Rik Cabanier caban...@gmail.com wrote: On Mon, Oct 14, 2013 at 2:38 PM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, the original email had lots of typos. I've fixed them below: On Mon, Oct 14, 2013 at 2:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 14, 2013 at 2:28 PM, Rik Cabanier caban...@gmail.comwrote: On Mon, Oct 14, 2013 at 1:31 PM, Timothy Hatcher timo...@apple.comwrote: On Oct 14, 2013, at 12:43 PM, Rik Cabanier caban...@gmail.com wrote: Also, how would your suggestion tell the UA about what areas are associated with the elements? What happens if an element is no longer focused? The ring is drawn into the canvas bitmap so those pixels have to be regenerated. Focus rings are usually larger than the control they surround. How is the developer suppose to know the pixel padding needed for each platform's focus ring? Guess and hope for the best? Why would he need to know this? Is it for the path that describes the ring? Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. True. That sounds like bad design though. Why? It doesn't seem particularly strange to have an element occupy the entire canvas momentarily. No, but I wouldn't never make the focus ring as large as the canvas. Wouldn't you have the same problem with focusable content in an overflow:hidden element that just fits its child? Even if this was broken, we could fix that because the focus ring is currently drawn by the UA. On the other hand, we're exposing an API to manually draw the focus ring on the canvas, then it's much harder to fix it. And I'm getting totally confused by this whole discussion because you've been kept telling us that UA could draw focus ring later to mitigate issues/concerns we've raised while at the same time telling us that authors have to call these functions whenever focus changes to redraw the focus ring. It's one or the other. The focus ring should be either drawn by this API, in which case, all the concerns we've raised thus far stands; or that the focus ring is drawn by UA at its discretion (potentially synchronously) in which case the function name should be changed. Sorry if I was confusing. These API are a bit odd so it could be that some subtleties were lost. For drawSystemFocusRing, the UA will always draw the ring immediately/synchronously when you call drawSystemFocusRing. For drawCustomFocusRing, the UA *could* draw the ring immediately (in case of high contrast), or it returns true so the author should draw it. The author can decide when he draws the ring. Would drawing the system focus ring taint the canvas pixels? (Drawing form controls into canvas via SVG images and foreignObject has been considered taint worthy because it could leak the user's UI theme.) I'm unsure if it should taint the canvas. How much information would be leaked that isn't already available through other means? It may, for example, leak information as to whether user's machine is in high contrast mode, which is another dimension for finger-printing user. Yes, maybe this should taint. Dominic, what do you think? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. True. That sounds like bad design though. Why? It doesn't seem particularly strange to have an element occupy the entire canvas momentarily. No, but I wouldn't never make the focus ring as large as the canvas. Even if you don't make it full size, if the focus ring is drawn into the canvas buffer, you don't know how much room you need to account for. (If the focused control is near the edge of the canvas.) — Timothy Hatcher ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for focus rings in Canvas 2d
On Mon, Oct 14, 2013 at 4:13 PM, Timothy Hatcher timo...@apple.com wrote: On Oct 14, 2013, at 3:44 PM, Rik Cabanier caban...@gmail.com wrote: Isn't focus ring drawn on the canvas? If so, it's important that the focus ring fits within the canvas. e.g. consider focusing an element of 100px by 100px inside a canvas of the same size. If the focus ring were to be drawn around the element that currently has focus, then the entire focus ring would be drawn outside of the visible region. True. That sounds like bad design though. Why? It doesn't seem particularly strange to have an element occupy the entire canvas momentarily. No, but I wouldn't never make the focus ring as large as the canvas. Even if you don't make it full size, if the focus ring is drawn into the canvas buffer, you don't know how much room you need to account for. (If the focused control is near the edge of the canvas.) The spec says: draw a focus ring of the appropriate style along the intended path, following platform conventions. In one of the email threads I have asked what along the path meant but there hasn't been an answer... I think it's assumed that you leave enough space so the ring fits. There isn't even anything in the spec that says that the path should fall in the canvas region. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Commit queue down due to Apple internal network issues
It appears that some CQ and EWS bots are still experience some issues. Please re-set cq+ should CQ fails to land your patch. - R. Niwa On Mon, Oct 14, 2013 at 3:44 PM, Samuel White samuel_wh...@apple.comwrote: https://bugs.webkit.org/show_bug.cgi?id=122534 Not sure why this one failed to commit. Rebased just incase, but nothing indicates that this is an issue with the patch (at least to me). Possibly related? Thanks for taking a look. - Sam On Oct 14, 2013, at 10:45 AM, Ryosuke Niwa rn...@webkit.org wrote: This problem appears to have been worked out over the weekend. The commit queue should be working as expected by now. - R. Niwa On Fri, Oct 11, 2013 at 9:53 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It appears that the machines running commit queue cannot reach svn.webkit.org due to some network issues. Please land patches manually until a further notice. If you're not a committer yet, please reply to this thread with a bug number and I'll land it manually for you (as long as it has been reviewed). - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Hi Alex, So Our Choices so far: GStreamer FFMPeg (http://www.ffmpeg.org/) Media Foundation ( http://msdn.microsoft.com/en-us/library/windows/desktop/ms696274(v=vs.85).aspx ) WebM (http://www.webmproject.org/) Chrome's part source code for: FFMpeg: http://src.chromium.org/viewvc/chrome/trunk/src/media/ffmpeg/ WebM: http://src.chromium.org/viewvc/chrome/trunk/src/media/webm/ Regards, Mital Vora. On Mon, Oct 14, 2013 at 11:38 PM, Brent Fulgham bfulg...@apple.com wrote: The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. -Brent On Oct 14, 2013, at 10:23 AM, Brent Fulgham bfulg...@apple.com wrote: Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since WinCairo is pretty solidly Windows-only. -Brent On Oct 14, 2013, at 10:00 AM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundation https://en.wikipedia.org/wiki/Media_Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?
Would it be possible to use Media Foundation with a fall back? You can't depend on Media Foundation even on Windows Vista+ anyway (N editions don't have it), but it's a COM API so you can detect that it is not available to use something else. From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Mital Vora Sent: Monday, October 14, 2013 10:29 PM To: Brent Fulgham Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ? Hi Alex, So Our Choices so far: GStreamer FFMPeg (http://www.ffmpeg.org/) Media Foundation (http://msdn.microsoft.com/en-us/library/windows/desktop/ms696274(v=vs.85).aspx) WebM (http://www.webmproject.org/) Chrome's part source code for: FFMpeg: http://src.chromium.org/viewvc/chrome/trunk/src/media/ffmpeg/ WebM: http://src.chromium.org/viewvc/chrome/trunk/src/media/webm/ Regards, Mital Vora. On Mon, Oct 14, 2013 at 11:38 PM, Brent Fulgham bfulg...@apple.commailto:bfulg...@apple.com wrote: The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. -Brent On Oct 14, 2013, at 10:23 AM, Brent Fulgham bfulg...@apple.commailto:bfulg...@apple.com wrote: Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since WinCairo is pretty solidly Windows-only. -Brent On Oct 14, 2013, at 10:00 AM, Brendan Long s...@brendanlong.commailto:s...@brendanlong.com wrote: On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other possibilities besides gstreamer like ffmpeg (http://www.ffmpeg.org/) or any other. By the way, if this is just for Windows, you may want to look at Media Foundationhttps://en.wikipedia.org/wiki/Media_Foundation. Also, I took at look at the media players before Chromium was removed, and I didn't see an FFMPEG media player. Maybe Chromium's media player has always been in the Chromium tree instead of the WebKit tree. ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
