Re: [webkit-dev] Code cleaning: LEGACY_VIEWPORT_ADAPTION
On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain benja...@webkit.org wrote: Hi WebKit, Hi, I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices that don't render well if this feature is disabled, the original list includes: m.yahoo.com m.google.com m.facebook.com All this if you do not use some apple-like user agent, I did test them again today to check the current status and just m.google.com is still using those legacy DTD causing WebKit to render the page into a 980px canvas where it was designed to be rendered into a 320px canvas. There may be other (old) sites not rendering well but at least at the time of the bug report this small list with very popular websites was enough to add this feature to a product (N9 phone) then to WebCore. I also found that besides Blackberry, Chromium turned on this flag[2] last year, but I didn't check if it still enabled on blink. Support legacy stuff is a pain and just inject undesirable code in the codebase, but I would like to know if there are other options rather than just removing the feature and let few, but some important, website not working? [1] https://bugs.webkit.org/show_bug.cgi?id=85425 [2] https://bugs.webkit.org/show_bug.cgi?id=90991 Regards, Hugo The reason is: this code is mostly incorrect and leads to valid viewport configurations only with the most trival cases. It seems to be only enabled by Nix and Blackberry but I can't tell if it is intentional. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Watchlist cc rules.
Hey everyone, I’d like to add myself to the “Accessibility” cc rule in the WebKit/Tools/Scripts/webkitpy/common/config/watchlist script. Should I simply file a bug and attach a patch as usual, or does touching this area involve a different procedure (since it’s not really a bug)? Thanks for your help. - Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Watchlist cc rules.
Hi Sam, You should file a bug with a patch for doing this. Cheers, Zoltan On Wed, Oct 30, 2013 at 10:06 AM, Samuel White samuel_wh...@apple.comwrote: Hey everyone, I’d like to add myself to the “Accessibility” cc rule in the WebKit/Tools/Scripts/webkitpy/common/config/watchlist script. Should I simply file a bug and attach a patch as usual, or does touching this area involve a different procedure (since it’s not really a bug)? Thanks for your help. - Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Watchlist cc rules.
Hi, I don't agree with Zoltán. Adding yourself to the watchlist doesn't need bug report and review. You are a committer, you can simple add yourself to the watchlist directly as others did it in the past. But you should run test-webkitpy tests before committing to make sure you don't break webkitpy with an accidental change. Ossy On 10/30/2013 06:09 PM, Zoltan Horvath wrote: Hi Sam, You should file a bug with a patch for doing this. Cheers, Zoltan On Wed, Oct 30, 2013 at 10:06 AM, Samuel White samuel_wh...@apple.com mailto:samuel_wh...@apple.com wrote: Hey everyone, I’d like to add myself to the “Accessibility” cc rule in the WebKit/Tools/Scripts/webkitpy/common/config/watchlist script. Should I simply file a bug and attach a patch as usual, or does touching this area involve a different procedure (since it’s not really a bug)? Thanks for your help. - Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Code cleaning: LEGACY_VIEWPORT_ADAPTION
On 10/30/13, 7:44 AM, Hugo Lima wrote: On Tue, Oct 29, 2013 at 9:00 PM, Benjamin Poulain benja...@webkit.org wrote: I plan to remove the code guarded by LEGACY_VIEWPORT_ADAPTION and the flag itself. I was reading the original bug report[1] to find a list of websites targeting mobile devices that don't render well if this feature is disabled, the original list includes: m.yahoo.com m.google.com m.facebook.com All this if you do not use some apple-like user agent, I did test them again today to check the current status and just m.google.com is still using those legacy DTD causing WebKit to render the page into a 980px canvas where it was designed to be rendered into a 320px canvas. There may be other (old) sites not rendering well but at least at the time of the bug report this small list with very popular websites was enough to add this feature to a product (N9 phone) then to WebCore. I also found that besides Blackberry, Chromium turned on this flag[2] last year, but I didn't check if it still enabled on blink. It is okay to adapt the viewport for the mobile doctypes. WebKit on iOS also does that for the reasons you mentioned. The problem here is the code is not correct. Support legacy stuff is a pain and just inject undesirable code in the codebase, but I would like to know if there are other options rather than just removing the feature and let few, but some important, website not working? If Nix really relies on that code, I will leave it in for now. When the relevant iOS bits and pieces will be upstream, it will be easier to implement viewport adaptation and I'll remove LEGACY_VIEWPORT_ADAPTION then. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Watchlist cc rules.
Yeah, we've historically added people to the watchlist without reviews. So file a bug upload a patch only if you're not a committer. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
