Re: [webkit-dev] Lots of “BREW” patches up for review
Hi, I am Kwang Yul Seo and I work for Company 100, Inc. (http://www.company100.net). I have started to submit patches that are required to port WebKit to Qualcomm's BREW platform. This is not a one-time code drop. We want to maintain the BREW port ongoing and will do everything that are required to keep the BREW port up and running. Porting DumpRenderTree is still under work, but we have a complete BREW port which works fine both in BREW device and simulator. Regards, Kwang Yul Seo On Thu, Jan 14, 2010 at 2:23 AM, Darin Adler wrote: > Someone is porting WebKit to Qualcomm’s BREW. And there are many patches for > that port; now a significant fraction of the unreviewed WebKit patches. Who’s > going to review these? Is this a one-time code drop or is there an intent to > maintain this port ongoing? Does the test suite work on the BREW platform > yet? Will someone maintain a buildbot? > > I won’t be reviewing these patches myself until I know the answers to some of > those questions. > > -- Darin > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I will check the issue as soon as possible and let you know the result. In case there is a legal problem with BREW with regard to NDA, BREW MP can be used instead because BREW MP is an open platform. On Thu, Jan 14, 2010 at 6:27 AM, Holger Freyther wrote: > On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: >> Someone is porting WebKit to Qualcomm’s BREW. And there are many patches >> for that port; now a significant fraction of the unreviewed WebKit >> patches. Who’s going to review these? Is this a one-time code drop or is >> there an intent to maintain this port ongoing? Does the test suite work on >> the BREW platform yet? Will someone maintain a buildbot? >> >> I won’t be reviewing these patches myself until I know the answers to some >> of those questions. > > Last time I checked one needs to have a contract with Qualcomm (NDA) to get > information (header files, documentation) that is beyond marketing bla bla. > > I would be interested if we are allowed to host and distribute the sourcecode > that has used information which is under a NDA. > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
Okay. I will add a new wiki page for the BREW port. Thanks. Regards, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat wrote: >> This is not a one-time code drop. We want to maintain the BREW port >> ongoing and will do everything that are required to keep the BREW port >> up and running. Porting DumpRenderTree is still under work, but we >> have a complete BREW port which works fine both in BREW device and >> simulator. > > Kwang, can you add the all information about the port to > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page > for that and add it to that list. > > > -- > Ariya Hidayat > http://www.linkedin.com/in/ariyahidayat > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I created a wiki for the BREW port of WebKit. https://trac.webkit.org/wiki/BREW Currently it contains preliminary information. I will add more contents gradually. Thanks, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat wrote: >> This is not a one-time code drop. We want to maintain the BREW port >> ongoing and will do everything that are required to keep the BREW port >> up and running. Porting DumpRenderTree is still under work, but we >> have a complete BREW port which works fine both in BREW device and >> simulator. > > Kwang, can you add the all information about the port to > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page > for that and add it to that list. > > > -- > Ariya Hidayat > http://www.linkedin.com/in/ariyahidayat > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
You have a complete port of BREW already? Interesting. Can you point to the complete sources so potential reviewers can have a look at what the state is? On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: > I created a wiki for the BREW port of WebKit. > > https://trac.webkit.org/wiki/BREW > > Currently it contains preliminary information. I will add more > contents gradually. > > Thanks, > Kwang Yul Seo > > On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat wrote: > >> This is not a one-time code drop. We want to maintain the BREW port > >> ongoing and will do everything that are required to keep the BREW port > >> up and running. Porting DumpRenderTree is still under work, but we > >> have a complete BREW port which works fine both in BREW device and > >> simulator. > > > > Kwang, can you add the all information about the port to > > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page > > for that and add it to that list. > > > > > > -- > > Ariya Hidayat > > http://www.linkedin.com/in/ariyahidayat > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
Sure. I will open a public Git repository for potential reviewers. I need to clean up the code before opening the complete source code because some device-specific information is from a phone manufacturer under NDA. I think it will take one or two days.Third party libraries with BREW specific patches will also be available by then. Thanks, Kwang Yul Seo On Fri, Jan 15, 2010 at 4:05 AM, Adam Treat wrote: > You have a complete port of BREW already? Interesting. Can you point to the > complete sources so potential reviewers can have a look at what the state is? > > On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: >> I created a wiki for the BREW port of WebKit. >> >> https://trac.webkit.org/wiki/BREW >> >> Currently it contains preliminary information. I will add more >> contents gradually. >> >> Thanks, >> Kwang Yul Seo >> >> On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat > wrote: >> >> This is not a one-time code drop. We want to maintain the BREW port >> >> ongoing and will do everything that are required to keep the BREW port >> >> up and running. Porting DumpRenderTree is still under work, but we >> >> have a complete BREW port which works fine both in BREW device and >> >> simulator. >> > >> > Kwang, can you add the all information about the port to >> > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page >> > for that and add it to that list. >> > >> > >> > -- >> > Ariya Hidayat >> > http://www.linkedin.com/in/ariyahidayat >> > ___ >> > webkit-dev mailing list >> > webkit-dev@lists.webkit.org >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
[1] NDA I checked the issue with Qualcomm and drew two conclusions: 1) For BREW MP, we can open source our code without any limitation. 2) For BREW, it is not clear if we can open source our code or not due to the NDA with Qualcomm. Hosting and distributing the code can cause a potential problem. This situation is interesting because BREW and BREW MP shares most of the API. I should change the official port name to BREW MP. [2] DumpRenderTree We are actively working on DumpRenderTree, but it is not ready yet. We plan to open it next month. On Fri, Jan 15, 2010 at 10:26 AM, Eric Seidel wrote: > I don't feel like this question was ever answered. > > Folks seem to be moving forward with setting up infrastructure for a > real port (which is good), but at least this question still remains. > > Also, does the BREW port already have a DumpRenderTree implementation? > When should we expect such? > > -eric > > On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther > wrote: > > On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: > >> Someone is porting WebKit to Qualcomm’s BREW. And there are many patches > >> for that port; now a significant fraction of the unreviewed WebKit > >> patches. Who’s going to review these? Is this a one-time code drop or > is > >> there an intent to maintain this port ongoing? Does the test suite work > on > >> the BREW platform yet? Will someone maintain a buildbot? > >> > >> I won’t be reviewing these patches myself until I know the answers to > some > >> of those questions. > > > > Last time I checked one needs to have a contract with Qualcomm (NDA) to > get > > information (header files, documentation) that is beyond marketing bla > bla. > > > > I would be interested if we are allowed to host and distribute the > sourcecode > > that has used information which is under a NDA. > > > > > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I opened a public git repository for WebKit BREW MP port. Third party libraries are available in ThirdPartyLibraries directory. You can get the source code from the following location with git-clone: http://www.dorothybrowser.com/git/WebKitBrew.git The port is complete, but minimal. It contains a very simple WebKit API which needs to be rewritten in accordance with BREW API style. I removed the launcher for BREW 4.x due to a legal issue. Sooner or later, I will add a simple BREWLauncher which runs in BREW MP simulator. Port details: - The port can be compiled with BREW MP 1.0 SDK. - The port is initially ported to BREW 4.0.4 so the code still uses PLATFORM(BREW) guard. PLATFORM(BREWMP) or PLATFORM(BMP) might be a better name. Any suggestion? - ResourceHandle is implemented with BREW's native HTTP backend, IWeb. - skia is used for graphics backend and freetype is used for font rendering within skia. Regards, Kwang Yul Seo On Fri, Jan 15, 2010 at 10:17 AM, KwangYul Seo wrote: > Sure. I will open a public Git repository for potential reviewers. I > need to clean up the code before opening the complete source code > because some device-specific information is from a phone manufacturer > under NDA. I think it will take one or two days.Third party libraries > with BREW specific patches will also be available by then. > > Thanks, > Kwang Yul Seo > > > On Fri, Jan 15, 2010 at 4:05 AM, Adam Treat wrote: >> You have a complete port of BREW already? Interesting. Can you point to the >> complete sources so potential reviewers can have a look at what the state is? >> >> On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: >>> I created a wiki for the BREW port of WebKit. >>> >>> https://trac.webkit.org/wiki/BREW >>> >>> Currently it contains preliminary information. I will add more >>> contents gradually. >>> >>> Thanks, >>> Kwang Yul Seo >>> >>> On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat >> wrote: >>> >> This is not a one-time code drop. We want to maintain the BREW port >>> >> ongoing and will do everything that are required to keep the BREW port >>> >> up and running. Porting DumpRenderTree is still under work, but we >>> >> have a complete BREW port which works fine both in BREW device and >>> >> simulator. >>> > >>> > Kwang, can you add the all information about the port to >>> > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki page >>> > for that and add it to that list. >>> > >>> > >>> > -- >>> > Ariya Hidayat >>> > http://www.linkedin.com/in/ariyahidayat >>> > ___ >>> > webkit-dev mailing list >>> > webkit-dev@lists.webkit.org >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
Git over HTTP seems to be too slow. Use git protocol instead. git-clone git://www.dorothybrowser.com/WebKitBrew.git On Wed, Jan 20, 2010 at 10:09 AM, KwangYul Seo wrote: > I opened a public git repository for WebKit BREW MP port. Third party > libraries are available in ThirdPartyLibraries directory. You can get the > source code from the following location with git-clone: > > http://www.dorothybrowser.com/git/WebKitBrew.git > > The port is complete, but minimal. It contains a very simple WebKit API > which needs to be rewritten in accordance with BREW API style. > > I removed the launcher for BREW 4.x due to a legal issue. Sooner or > later, I will add a simple BREWLauncher which runs in BREW MP simulator. > > > Port details: > > - The port can be compiled with BREW MP 1.0 SDK. > > - The port is initially ported to BREW 4.0.4 so the code still uses > PLATFORM(BREW) guard. PLATFORM(BREWMP) or PLATFORM(BMP) might be a better > name. Any suggestion? > > - ResourceHandle is implemented with BREW's native HTTP backend, IWeb. > > - skia is used for graphics backend and freetype is used for font rendering > within skia. > > > Regards, > Kwang Yul Seo > > > On Fri, Jan 15, 2010 at 10:17 AM, KwangYul Seo > wrote: > > Sure. I will open a public Git repository for potential reviewers. I > > need to clean up the code before opening the complete source code > > because some device-specific information is from a phone manufacturer > > under NDA. I think it will take one or two days.Third party libraries > > with BREW specific patches will also be available by then. > > > > Thanks, > > Kwang Yul Seo > > > > > > On Fri, Jan 15, 2010 at 4:05 AM, Adam Treat wrote: > >> You have a complete port of BREW already? Interesting. Can you point > to the > >> complete sources so potential reviewers can have a look at what the > state is? > >> > >> On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: > >>> I created a wiki for the BREW port of WebKit. > >>> > >>> https://trac.webkit.org/wiki/BREW > >>> > >>> Currently it contains preliminary information. I will add more > >>> contents gradually. > >>> > >>> Thanks, > >>> Kwang Yul Seo > >>> > >>> On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat < > ariya.hida...@gmail.com> > >> wrote: > >>> >> This is not a one-time code drop. We want to maintain the BREW port > >>> >> ongoing and will do everything that are required to keep the BREW > port > >>> >> up and running. Porting DumpRenderTree is still under work, but we > >>> >> have a complete BREW port which works fine both in BREW device and > >>> >> simulator. > >>> > > >>> > Kwang, can you add the all information about the port to > >>> > http://trac.webkit.org/wiki#WebKitPorts? I guess, make a new wiki > page > >>> > for that and add it to that list. > >>> > > >>> > > >>> > -- > >>> > Ariya Hidayat > >>> > http://www.linkedin.com/in/ariyahidayat > >>> > ___ > >>> > webkit-dev mailing list > >>> > webkit-dev@lists.webkit.org > >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >>> > >>> ___ > >>> webkit-dev mailing list > >>> webkit-dev@lists.webkit.org > >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I will update the patches with BREW_MP tag. Thanks, Kwang Yul Seo On Sat, Jan 23, 2010 at 3:00 AM, David Levin wrote: > Based on this, it sounds like all [BREW] patches should be r-'ed and > appropriate BREW_MP ones submitted? > > On Sun, Jan 17, 2010 at 6:23 PM, KwangYul Seo > wrote: >> >> [1] NDA >> >> I checked the issue with Qualcomm and drew two conclusions: >> 1) For BREW MP, we can open source our code without any limitation. >> 2) For BREW, it is not clear if we can open source our code or not due to >> the NDA with Qualcomm. Hosting and distributing the code can cause a >> potential problem. >> This situation is interesting because BREW and BREW MP shares most of the >> API. I should change the official port name to BREW MP. >> >> [2] DumpRenderTree >> We are actively working on DumpRenderTree, but it is not ready yet. We >> plan to open it next month. >> >> On Fri, Jan 15, 2010 at 10:26 AM, Eric Seidel wrote: >>> >>> I don't feel like this question was ever answered. >>> >>> Folks seem to be moving forward with setting up infrastructure for a >>> real port (which is good), but at least this question still remains. >>> >>> Also, does the BREW port already have a DumpRenderTree implementation? >>> When should we expect such? >>> >>> -eric >>> >>> On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther >>> wrote: >>> > On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: >>> >> Someone is porting WebKit to Qualcomm’s BREW. And there are many >>> >> patches >>> >> for that port; now a significant fraction of the unreviewed WebKit >>> >> patches. Who’s going to review these? Is this a one-time code drop or >>> >> is >>> >> there an intent to maintain this port ongoing? Does the test suite >>> >> work on >>> >> the BREW platform yet? Will someone maintain a buildbot? >>> >> >>> >> I won’t be reviewing these patches myself until I know the answers to >>> >> some >>> >> of those questions. >>> > >>> > Last time I checked one needs to have a contract with Qualcomm (NDA) to >>> > get >>> > information (header files, documentation) that is beyond marketing bla >>> > bla. >>> > >>> > I would be interested if we are allowed to host and distribute the >>> > sourcecode >>> > that has used information which is under a NDA. >>> > >>> > >>> > >>> > ___ >>> > webkit-dev mailing list >>> > webkit-dev@lists.webkit.org >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> > >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Lots of “BREW” patches up for review
I changed the platform defines from BREW to BREWMP to match the official port name. As BREWMP is backward compatible with BREW, there is no much differences. As Eric mentioned, a port without the DRT and a working buildbot is too fragile We will upstream the DRT implementation to webkit.org ASAP once it is ready and will setup a build bot. I will update the Wiki page with detailed schedule and todo list. Thanks, Kwang Yul Seo On Sat, Jan 23, 2010 at 8:36 AM, Eric Seidel wrote: > Ok, so my reading of this thread is that WebKit is ready to accept a > BREW/BREW-MP port. > > > I'm not sure how much the platform defines (BREW vs. BREWMP) matter, > but it's fine to change them to match whatever the official port is. > > Sounds like you have an in-progress DRT implementation. Can we expect > it to move to webkit.org soon? > > I'm glad to see you already have build instructions: > http://trac.webkit.org/wiki/BREW > > Have any of the BREW folks started work on a buildbot slave? No huge > rush, but until the port has a builder at build.webkit.org it will > likely break daily. :) > http://trac.webkit.org/browser/trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config > > I would also encourage you to read (and update!): > http://trac.webkit.org/wiki/SuccessfulPortHowTo > > Thanks! > > -eric > > On Fri, Jan 22, 2010 at 3:04 PM, KwangYul Seo wrote: >> I will update the patches with BREW_MP tag. >> >> Thanks, >> Kwang Yul Seo >> >> >> On Sat, Jan 23, 2010 at 3:00 AM, David Levin wrote: >>> Based on this, it sounds like all [BREW] patches should be r-'ed and >>> appropriate BREW_MP ones submitted? >>> >>> On Sun, Jan 17, 2010 at 6:23 PM, KwangYul Seo >>> wrote: [1] NDA I checked the issue with Qualcomm and drew two conclusions: 1) For BREW MP, we can open source our code without any limitation. 2) For BREW, it is not clear if we can open source our code or not due to the NDA with Qualcomm. Hosting and distributing the code can cause a potential problem. This situation is interesting because BREW and BREW MP shares most of the API. I should change the official port name to BREW MP. [2] DumpRenderTree We are actively working on DumpRenderTree, but it is not ready yet. We plan to open it next month. On Fri, Jan 15, 2010 at 10:26 AM, Eric Seidel wrote: > > I don't feel like this question was ever answered. > > Folks seem to be moving forward with setting up infrastructure for a > real port (which is good), but at least this question still remains. > > Also, does the BREW port already have a DumpRenderTree implementation? > When should we expect such? > > -eric > > On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther > wrote: > > On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: > >> Someone is porting WebKit to Qualcomm’s BREW. And there are many > >> patches > >> for that port; now a significant fraction of the unreviewed WebKit > >> patches. Who’s going to review these? Is this a one-time code drop or > >> is > >> there an intent to maintain this port ongoing? Does the test suite > >> work on > >> the BREW platform yet? Will someone maintain a buildbot? > >> > >> I won’t be reviewing these patches myself until I know the answers to > >> some > >> of those questions. > > > > Last time I checked one needs to have a contract with Qualcomm (NDA) to > > get > > information (header files, documentation) that is beyond marketing bla > > bla. > > > > I would be interested if we are allowed to host and distribute the > > sourcecode > > that has used information which is under a NDA. > > > > > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >>> >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
