I changed the platform defines from BREW to BREWMP to match the official port name. As BREWMP is backward compatible with BREW, there is no much differences.
As Eric mentioned, a port without the DRT and a working buildbot is too fragile We will upstream the DRT implementation to webkit.org ASAP once it is ready and will setup a build bot. I will update the Wiki page with detailed schedule and todo list. Thanks, Kwang Yul Seo On Sat, Jan 23, 2010 at 8:36 AM, Eric Seidel <e...@webkit.org> wrote: > Ok, so my reading of this thread is that WebKit is ready to accept a > BREW/BREW-MP port. > > > I'm not sure how much the platform defines (BREW vs. BREWMP) matter, > but it's fine to change them to match whatever the official port is. > > Sounds like you have an in-progress DRT implementation. Can we expect > it to move to webkit.org soon? > > I'm glad to see you already have build instructions: > http://trac.webkit.org/wiki/BREW > > Have any of the BREW folks started work on a buildbot slave? No huge > rush, but until the port has a builder at build.webkit.org it will > likely break daily. :) > http://trac.webkit.org/browser/trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config > > I would also encourage you to read (and update!): > http://trac.webkit.org/wiki/SuccessfulPortHowTo > > Thanks! > > -eric > > On Fri, Jan 22, 2010 at 3:04 PM, KwangYul Seo <kwangyul....@gmail.com> wrote: >> I will update the patches with BREW_MP tag. >> >> Thanks, >> Kwang Yul Seo >> >> >> On Sat, Jan 23, 2010 at 3:00 AM, David Levin <le...@chromium.org> wrote: >>> Based on this, it sounds like all [BREW] patches should be r-'ed and >>> appropriate BREW_MP ones submitted? >>> >>> On Sun, Jan 17, 2010 at 6:23 PM, KwangYul Seo <kwangyul....@gmail.com> >>> wrote: >>>> >>>> [1] NDA >>>> >>>> I checked the issue with Qualcomm and drew two conclusions: >>>> 1) For BREW MP, we can open source our code without any limitation. >>>> 2) For BREW, it is not clear if we can open source our code or not due to >>>> the NDA with Qualcomm. Hosting and distributing the code can cause a >>>> potential problem. >>>> This situation is interesting because BREW and BREW MP shares most of the >>>> API. I should change the official port name to BREW MP. >>>> >>>> [2] DumpRenderTree >>>> We are actively working on DumpRenderTree, but it is not ready yet. We >>>> plan to open it next month. >>>> >>>> On Fri, Jan 15, 2010 at 10:26 AM, Eric Seidel <e...@webkit.org> wrote: >>>>> >>>>> I don't feel like this question was ever answered. >>>>> >>>>> Folks seem to be moving forward with setting up infrastructure for a >>>>> real port (which is good), but at least this question still remains. >>>>> >>>>> Also, does the BREW port already have a DumpRenderTree implementation? >>>>> When should we expect such? >>>>> >>>>> -eric >>>>> >>>>> On Wed, Jan 13, 2010 at 1:27 PM, Holger Freyther <ze...@selfish.org> >>>>> wrote: >>>>> > On Wednesday 13 January 2010 18:23:21 Darin Adler wrote: >>>>> >> Someone is porting WebKit to Qualcomm’s BREW. And there are many >>>>> >> patches >>>>> >> for that port; now a significant fraction of the unreviewed WebKit >>>>> >> patches. Who’s going to review these? Is this a one-time code drop or >>>>> >> is >>>>> >> there an intent to maintain this port ongoing? Does the test suite >>>>> >> work on >>>>> >> the BREW platform yet? Will someone maintain a buildbot? >>>>> >> >>>>> >> I won’t be reviewing these patches myself until I know the answers to >>>>> >> some >>>>> >> of those questions. >>>>> > >>>>> > Last time I checked one needs to have a contract with Qualcomm (NDA) to >>>>> > get >>>>> > information (header files, documentation) that is beyond marketing bla >>>>> > bla. >>>>> > >>>>> > I would be interested if we are allowed to host and distribute the >>>>> > sourcecode >>>>> > that has used information which is under a NDA. >>>>> > >>>>> > >>>>> > >>>>> > _______________________________________________ >>>>> > webkit-dev mailing list >>>>> > webkit-dev@lists.webkit.org >>>>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>>>> > >>>>> _______________________________________________ >>>>> webkit-dev mailing list >>>>> webkit-dev@lists.webkit.org >>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>>> >>>> >>>> _______________________________________________ >>>> webkit-dev mailing list >>>> webkit-dev@lists.webkit.org >>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>>> >>> >>> >> > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev