[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jozef Hartinger updated WELD-999: - Fix Version/s: 2.0.0.Alpha2 > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1, 2.0.0.Alpha2 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko Lukša resolved WELD-999. -- Resolution: Done > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on WELD-999 started by Marko Lukša. > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672838#comment-12672838 ] Marius Bogoevici commented on WELD-999: --- AFAICT the current implementation is wrong and resolveInterceptors should take into account the transitive closure of the interceptor binding set passed as an argument. > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672685#comment-12672685 ] Pete Muir commented on WELD-999: resolveInterceptors should resolve transitive interceptors, if that is what you are asking. > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[
https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672517#comment-12672517
]
Marko Lukša commented on WELD-999:
--
Actually, it's not broken. I have added another test - one that actually
invokes an intercepted method and checks if both interceptors were invoked. The
test passes.
So the actual problem is only with
{{BeanManager.resolveInterceptors(InterceptionType type, Annotation...
interceptorBindings)}}.
In weld-core, the {{interceptorBindings}} parameter is always flattened
({{AbstractClassBean.flattenInterceptorBindings()}}) before being passed to the
method.
In {{InterceptorBindingTransitivityTest}} however, {{resolveInterceptors()}} is
called without flattening interceptor bindings first (e.g.
{{resolveInterceptors(InterceptionType.AROUND_INVOKE, new
UltraSynchronizedLiteral())}}.
So the real question is whether {{BeanManager.resolveInterceptors()}} should
flatten the interceptorBindings itself or whether the caller should to this.
> Interceptor binding transitivity broken
> ---
>
> Key: WELD-999
> URL: https://issues.jboss.org/browse/WELD-999
> Project: Weld
> Issue Type: Bug
> Components: Interceptors and Decorators
>Affects Versions: 1.1.2.Final
>Reporter: Jozef Hartinger
>Assignee: Marko Lukša
> Fix For: 1.2.0.Beta1
>
>
> See
> org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ales Justin reassigned WELD-999: Assignee: Marko Lukša > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger >Assignee: Marko Lukša > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
[ https://issues.jboss.org/browse/WELD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ales Justin updated WELD-999: - Fix Version/s: 1.2.0.Beta1 (was: 1.1.3.Final) > Interceptor binding transitivity broken > --- > > Key: WELD-999 > URL: https://issues.jboss.org/browse/WELD-999 > Project: Weld > Issue Type: Bug > Components: Interceptors and Decorators >Affects Versions: 1.1.2.Final >Reporter: Jozef Hartinger > Fix For: 1.2.0.Beta1 > > > See > org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-999) Interceptor binding transitivity broken
Interceptor binding transitivity broken --- Key: WELD-999 URL: https://issues.jboss.org/browse/WELD-999 Project: Weld Issue Type: Bug Components: Interceptors and Decorators Affects Versions: 1.1.2.Final Reporter: Jozef Hartinger Fix For: 1.2.0.Beta1 See org.jboss.weld.tests.interceptors.binding.transitivity.InterceptorBindingTransitivityTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
