RE: Compile problem (and possible fix)
MS Visual Studio 5 (don't remember which sp level): yes. Current, as in Visual Studio 6 current sp (iirc 6, can't check now) doesn't have any problems. Heiko -- -- PREVINET S.p.A.[EMAIL PROTECTED] -- Via Ferretto, 1ph x39-041-5907073 -- I-31021 Mogliano V.to (TV) fax x39-041-5907087 -- ITALY >-Original Message- >From: Hack Kampbjørn [mailto:[EMAIL PROTECTED]] >Sent: Sunday, November 11, 2001 10:01 PM >To: Wget List >Subject: Re: Compile problem (and possible fix) > > >Ian Abbott wrote: >> >> On 7 Nov 2001, at 23:07, Hack Kampbjørn wrote: >> >> Agreed that you don't want to use Apple's precompiler, but I >> couldn't tell from the links you posted what platform the "fix" >> fails to compile on. There was one reference to VC++ 5.0 breaking, >> but that was for the "unfixed" version. > >On Monday, June 25, 2001, at 05:54 PM, Hrvoje Niksic wrote: >> Perhaps the problem is that the '"' constant is within the assert, >> which might indeed hurt some compilers. In fact, I originally used >> '\"', but a Microsoft compiler couldn't swallow it in the `assert' >> expression. > >I read that as '\"' (which the original poster proposed) breaks M$ >Visual Studio. > >-- >Med venlig hilsen / Kind regards > >Hack Kampbjørn >
Re: Compile problem (and possible fix)
Ian Abbott wrote: > > On 7 Nov 2001, at 23:07, Hack Kampbjørn wrote: > > Agreed that you don't want to use Apple's precompiler, but I > couldn't tell from the links you posted what platform the "fix" > fails to compile on. There was one reference to VC++ 5.0 breaking, > but that was for the "unfixed" version. On Monday, June 25, 2001, at 05:54 PM, Hrvoje Niksic wrote: > Perhaps the problem is that the '"' constant is within the assert, > which might indeed hurt some compilers. In fact, I originally used > '\"', but a Microsoft compiler couldn't swallow it in the `assert' > expression. I read that as '\"' (which the original poster proposed) breaks M$ Visual Studio. -- Med venlig hilsen / Kind regards Hack Kampbjørn
Re: Compile problem (and possible fix)
On 7 Nov 2001, at 23:07, Hack Kampbjørn wrote: > Ed Powell wrote: > > I had to change: > > > > assert (ch == '\'' || ch == '"'); > > > > to: > > > > assert (ch == '\'' || ch == '\"'); > > > > Otherwise, it would not compile... it was, I think, interpreting the ", > > rather than using it literally. Escaping it appears to have fixed the > > problem. > > Right conclusion, wrong fix. Fix the broken software not the correct > one, i.e. your fix breaks wget on another broken platform (read the > below links if cannot guess which). You don't want to use Apple's > precompiler anyway. Agreed that you don't want to use Apple's precompiler, but I couldn't tell from the links you posted what platform the "fix" fails to compile on. There was one reference to VC++ 5.0 breaking, but that was for the "unfixed" version.
Re: Compile problem (and possible fix)
Ed Powell wrote: > > I was compiling wget 1.7 on MacOS X 10.1 (Darwin 1.4). Around line 435 in > html-parse.c there's the section: > > case AC_S_QUOTE1: > assert (ch == '\'' || ch == '"'); > quote_char = ch; /* cheating -- I really don't feel like >introducing more different states for >different quote characters. */ > ch = *p++; > state = AC_S_IN_QUOTE; > break; > > I had to change: > > assert (ch == '\'' || ch == '"'); > > to: > > assert (ch == '\'' || ch == '\"'); > > Otherwise, it would not compile... it was, I think, interpreting the ", > rather than using it literally. Escaping it appears to have fixed the > problem. Right conclusion, wrong fix. Fix the broken software not the correct one, i.e. your fix breaks wget on another broken platform (read the below links if cannot guess which). You don't want to use Apple's precompiler anyway. http://www.mail-archive.com/cgi-bin/htsearch?method=and&format=short&config=wget_sunsite_dk&restrict=&exclude=&words=darwin http://www.mail-archive.com/wget@sunsite.dk/msg01532.html http://www.mail-archive.com/wget@sunsite.dk/msg01289.html > > The compiling process was simply doing a 'configure' then 'make'. After > making the change described above, I ran 'make' again, and everything was > fine. > > -- > Ed Powell - "Meus Navis Aerius est Plena Anguillarum" > http://www.visi.com/~epowell -- Med venlig hilsen / Kind regards Hack Kampbjørn
Compile problem (and possible fix)
I was compiling wget 1.7 on MacOS X 10.1 (Darwin 1.4). Around line 435 in html-parse.c there's the section: case AC_S_QUOTE1: assert (ch == '\'' || ch == '"'); quote_char = ch; /* cheating -- I really don't feel like introducing more different states for different quote characters. */ ch = *p++; state = AC_S_IN_QUOTE; break; I had to change: assert (ch == '\'' || ch == '"'); to: assert (ch == '\'' || ch == '\"'); Otherwise, it would not compile... it was, I think, interpreting the ", rather than using it literally. Escaping it appears to have fixed the problem. The compiling process was simply doing a 'configure' then 'make'. After making the change described above, I ran 'make' again, and everything was fine. -- Ed Powell - "Meus Navis Aerius est Plena Anguillarum" http://www.visi.com/~epowell
