Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Just making sure it didn't get lost in some sourceforge tracker. Thx for submitting! Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Yes, it is. I am sorry. I guess I confused some transaction ID with an issue ID... Eelco Hillenius wrote: It's this http://issues.apache.org/jira/browse/WICKET-220 Eelco On 1/18/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Where did you create this issue? in Jira at apache? The issue id doesn't seem to fit the profile. For the core projects (found at the download site at http://sf.net/projects/wicket) we exclusively use JIRA at apache. Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8440976 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
handleMultiPart() has been made protected non-final -igor On 1/19/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Just making sure it didn't get lost in some sourceforge tracker. Thx for submitting! Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Yes, it is. I am sorry. I guess I confused some transaction ID with an issue ID... Eelco Hillenius wrote: It's this http://issues.apache.org/jira/browse/WICKET-220 Eelco On 1/18/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Where did you create this issue? in Jira at apache? The issue id doesn't seem to fit the profile. For the core projects (found at the download site at http://sf.net/projects/wicket) we exclusively use JIRA at apache. Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8440976 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
I tried overriding newWebRequest() [and defining our custom
MultipartWebRequest] on the application level and it seems to work for us.
Also, I extracted the base StreamUploadField class (which doesn't rely on
File-s being the result of the upload) from FileUploadField and used that
extracted class in our code. Works just fine. The modified FileUploadField
and new StreamUploadField classes attached. Notice that those files were
obtained from FileUploadField.java as it is in version 1.2.4 of Wicket. If
you want me to produce those same files for a diferent version, please, let
me know. Also, please let me know what your plans for making method
protected are (starting with which version)...
-boris
igor.vaynberg wrote:
i dont know if it is a workaround, it is just how the api is designed
currently.
what i am interested in is if doing this will solve your problem?
i also think we should make handlemultipart protected with a javadoc
warning
that overrides may break fileuploadfields
-igor
On 1/17/07, beboris [EMAIL PROTECTED] wrote:
So, I guess you suggest we do it on the application level by overriding
newWebRequest() method inside the whole WebApplication, so it returns our
custom WebRequest subclass globally, as follows:
protected WebRequest newWebRequest(HttpServletRequest servletRequest) {
return new CustomWebRequest(servletRequest);
}
Then our CustomWebRequest class would in turn override
newMultipartWebRequest() method and do custom processing globally, as
opposed to working on the specific Form level which we could achieve
should
our CustomForm's handleMultiPart() method be overridable. Is that
correct?
If yes - do you see it as a workaround for a simple case or a generic
solution for anyone who needs custom behavior of multi-part HTTP POST-s
from
forms?
-boris
igor.vaynberg wrote:
you can already substitute your own implementation of
IMultipartWebRequest
globally. the ajax-upload-progressbar does it
-igor
On 1/17/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
IMHO, linking FileUploadField-s (which we need to browse for the
correct
input file in the browser) with the specific (FileUpload, File)
implementation of the results of the multi-part HTTP POST streams
(created
when the form is submitted) is too strong (and limiting) for a
generic
[and the only available!] contract for multi-part HTTP POST streams
in
a
generic-purpose web framework like wicket. So, I'd suggest either
leaving
things the way they are (FileUploadField-s will return null for
FileUpload
when File upload is not used) or eliminating those
FileUpload-related
methods (let the user get this info from
(IMultipartWebRequest)request
instead), or creating an extra layer of objects
(StreamUploadField-s,
which
would be a super-class for FileUploadField-s without
FileUpload-related
contract obligations). In the latter case, you'd give users those
needed
generic components that look and feel (and smell :) ) like files
on
the
client side, but are free for interpretation on the server side.
Still,
today's FileUploadField-s would be there as subclasses (in all their
full-contract glory) for backward compatibility...
In general this sounds good to me. It would be a great help to us if
someone (you) could provide us with a patch to make this concrete.
Without a patch, I'm afraid this would be on the bottom of our current
priority list (though we can do the change in Form anyway).
Eelco
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to
share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
--
View this message in context:
http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8420808
Sent from the Wicket - User mailing list archive at Nabble.com.
-
Take Surveys. Earn Cash. Influence the Future of
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Where did you create this issue? in Jira at apache? The issue id doesn't seem to fit the profile. For the core projects (found at the download site at http://sf.net/projects/wicket) we exclusively use JIRA at apache. Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
It's this http://issues.apache.org/jira/browse/WICKET-220 Eelco On 1/18/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Where did you create this issue? in Jira at apache? The issue id doesn't seem to fit the profile. For the core projects (found at the download site at http://sf.net/projects/wicket) we exclusively use JIRA at apache. Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Yes, it is. I am sorry. I guess I confused some transaction ID with an issue ID... Eelco Hillenius wrote: It's this http://issues.apache.org/jira/browse/WICKET-220 Eelco On 1/18/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Where did you create this issue? in Jira at apache? The issue id doesn't seem to fit the profile. For the core projects (found at the download site at http://sf.net/projects/wicket) we exclusively use JIRA at apache. Martijn On 1/18/07, beboris [EMAIL PROTECTED] wrote: Done (issue ID=12360795) Eelco Hillenius wrote: If you could open up a feature request for that Boris, we can put it in the next version. Eelco Also, please let me know what your plans for making method protected are (starting with which version)... - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8436538 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user -- View this message in context: http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8440976 Sent from the Wicket - User mailing list archive at Nabble.com. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
IMHO, linking FileUploadField-s (which we need to browse for the correct input file in the browser) with the specific (FileUpload, File) implementation of the results of the multi-part HTTP POST streams (created when the form is submitted) is too strong (and limiting) for a generic [and the only available!] contract for multi-part HTTP POST streams in a generic-purpose web framework like wicket. So, I'd suggest either leaving things the way they are (FileUploadField-s will return null for FileUpload when File upload is not used) or eliminating those FileUpload-related methods (let the user get this info from (IMultipartWebRequest)request instead), or creating an extra layer of objects (StreamUploadField-s, which would be a super-class for FileUploadField-s without FileUpload-related contract obligations). In the latter case, you'd give users those needed generic components that look and feel (and smell :) ) like files on the client side, but are free for interpretation on the server side. Still, today's FileUploadField-s would be there as subclasses (in all their full-contract glory) for backward compatibility... In general this sounds good to me. It would be a great help to us if someone (you) could provide us with a patch to make this concrete. Without a patch, I'm afraid this would be on the bottom of our current priority list (though we can do the change in Form anyway). Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
I am glad you are open to making the handleMultiPart() method protected.
While we understand your concern about existing contracts, the dangers of
giving user ability to override and control multi-part stream handling may well
be exaggerated - especially considering getRequest/setRequest methods are
already available in the RequestCycle class. And, yes, if the user overrides
handleMultiPart() method he will be on his own as far as the upload results are
concerned. Consider it the price of freedom... [See the note on
FileUploadField-s later...]
Let me first tell you what we do today and how that will change once we have
the protected handleMultiPart() method available to us. In our today's code
we are forced to use files, but even today we don't rely on getting info on
those files from the form fields. We use the following code in the onSubmit()
method of our Form subclass to get to the results of the upload:
final Request request = getRequest();
if (request instanceof IMultipartWebRequest) {
IMultipartWebRequest multiReq = (IMultipartWebRequest)request;
Map fileItems = multiReq.getFiles();
...
}
As you see, we don't use FileUploadField contracts and live happily
thereafter... (well, except we don't need those intermediary files to start
with...:) ).
In case handleMultiPart() method is made protected all we need to do is create
our own wrapper (similar to MultipartServletWebRequest used inside Form) like
this:
class CustomForm extends Form {
...
private final boolean handleMultiPart() {
if (multiPart) {
try {
final CustomMultipartServletWebRequest customMultipartWebRequest =
new
CustomMultipartServletWebRequest((HttpServletRequest)getRequest(),this.maxSize);
getRequestCycle().setRequest(customMultipartWebRequest);
}
...
}
Then we'd handle streams our way inside that CustomMultipartServletWebRequest
class...
class CustomMultipartServletWebRequest {
...
CustomMultipartServletWebRequest( HttpServletRequest request, Bytes maxSize)
{...}
...
}
An example of MultipartServletWebRequest class would be of help, but otherwise,
it would be our class with our own logic. And it will be our responsibility to
handle stream parts any way we see fit... That's the goal...
IMHO, linking FileUploadField-s (which we need to browse for the correct input
file in the browser) with the specific (FileUpload, File) implementation of the
results of the multi-part HTTP POST streams (created when the form is
submitted) is too strong (and limiting) for a generic [and the only
available!] contract for multi-part HTTP POST streams in a generic-purpose web
framework like wicket. So, I'd suggest either leaving things the way they are
(FileUploadField-s will return null for FileUpload when File upload is not
used) or eliminating those FileUpload-related methods (let the user get this
info from (IMultipartWebRequest)request instead), or creating an extra layer of
objects (StreamUploadField-s, which would be a super-class for
FileUploadField-s without FileUpload-related contract obligations). In the
latter case, you'd give users those needed generic components that look and
feel (and smell :) ) like files on the client side, but are free for
interpretation on the server side. Still, today's FileUploadField-s would be
there as subclasses (in all their full-contract glory) for backward
compatibility...
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
you can already substitute your own implementation of IMultipartWebRequest globally. the ajax-upload-progressbar does it -igor On 1/17/07, Eelco Hillenius [EMAIL PROTECTED] wrote: IMHO, linking FileUploadField-s (which we need to browse for the correct input file in the browser) with the specific (FileUpload, File) implementation of the results of the multi-part HTTP POST streams (created when the form is submitted) is too strong (and limiting) for a generic [and the only available!] contract for multi-part HTTP POST streams in a generic-purpose web framework like wicket. So, I'd suggest either leaving things the way they are (FileUploadField-s will return null for FileUpload when File upload is not used) or eliminating those FileUpload-related methods (let the user get this info from (IMultipartWebRequest)request instead), or creating an extra layer of objects (StreamUploadField-s, which would be a super-class for FileUploadField-s without FileUpload-related contract obligations). In the latter case, you'd give users those needed generic components that look and feel (and smell :) ) like files on the client side, but are free for interpretation on the server side. Still, today's FileUploadField-s would be there as subclasses (in all their full-contract glory) for backward compatibility... In general this sounds good to me. It would be a great help to us if someone (you) could provide us with a patch to make this concrete. Without a patch, I'm afraid this would be on the bottom of our current priority list (though we can do the change in Form anyway). Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
So, I guess you suggest we do it on the application level by overriding
newWebRequest() method inside the whole WebApplication, so it returns our
custom WebRequest subclass globally, as follows:
protected WebRequest newWebRequest(HttpServletRequest servletRequest) {
return new CustomWebRequest(servletRequest);
}
Then our CustomWebRequest class would in turn override
newMultipartWebRequest() method and do custom processing globally, as
opposed to working on the specific Form level which we could achieve should
our CustomForm's handleMultiPart() method be overridable. Is that correct?
If yes - do you see it as a workaround for a simple case or a generic
solution for anyone who needs custom behavior of multi-part HTTP POST-s from
forms?
-boris
igor.vaynberg wrote:
you can already substitute your own implementation of IMultipartWebRequest
globally. the ajax-upload-progressbar does it
-igor
On 1/17/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
IMHO, linking FileUploadField-s (which we need to browse for the
correct
input file in the browser) with the specific (FileUpload, File)
implementation of the results of the multi-part HTTP POST streams
(created
when the form is submitted) is too strong (and limiting) for a
generic
[and the only available!] contract for multi-part HTTP POST streams in
a
generic-purpose web framework like wicket. So, I'd suggest either
leaving
things the way they are (FileUploadField-s will return null for
FileUpload
when File upload is not used) or eliminating those FileUpload-related
methods (let the user get this info from (IMultipartWebRequest)request
instead), or creating an extra layer of objects (StreamUploadField-s,
which
would be a super-class for FileUploadField-s without FileUpload-related
contract obligations). In the latter case, you'd give users those
needed
generic components that look and feel (and smell :) ) like files on
the
client side, but are free for interpretation on the server side. Still,
today's FileUploadField-s would be there as subclasses (in all their
full-contract glory) for backward compatibility...
In general this sounds good to me. It would be a great help to us if
someone (you) could provide us with a patch to make this concrete.
Without a patch, I'm afraid this would be on the bottom of our current
priority list (though we can do the change in Form anyway).
Eelco
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
--
View this message in context:
http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8420808
Sent from the Wicket - User mailing list archive at Nabble.com.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
i dont know if it is a workaround, it is just how the api is designed
currently.
what i am interested in is if doing this will solve your problem?
i also think we should make handlemultipart protected with a javadoc warning
that overrides may break fileuploadfields
-igor
On 1/17/07, beboris [EMAIL PROTECTED] wrote:
So, I guess you suggest we do it on the application level by overriding
newWebRequest() method inside the whole WebApplication, so it returns our
custom WebRequest subclass globally, as follows:
protected WebRequest newWebRequest(HttpServletRequest servletRequest) {
return new CustomWebRequest(servletRequest);
}
Then our CustomWebRequest class would in turn override
newMultipartWebRequest() method and do custom processing globally, as
opposed to working on the specific Form level which we could achieve
should
our CustomForm's handleMultiPart() method be overridable. Is that correct?
If yes - do you see it as a workaround for a simple case or a generic
solution for anyone who needs custom behavior of multi-part HTTP POST-s
from
forms?
-boris
igor.vaynberg wrote:
you can already substitute your own implementation of
IMultipartWebRequest
globally. the ajax-upload-progressbar does it
-igor
On 1/17/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
IMHO, linking FileUploadField-s (which we need to browse for the
correct
input file in the browser) with the specific (FileUpload, File)
implementation of the results of the multi-part HTTP POST streams
(created
when the form is submitted) is too strong (and limiting) for a
generic
[and the only available!] contract for multi-part HTTP POST streams
in
a
generic-purpose web framework like wicket. So, I'd suggest either
leaving
things the way they are (FileUploadField-s will return null for
FileUpload
when File upload is not used) or eliminating those FileUpload-related
methods (let the user get this info from
(IMultipartWebRequest)request
instead), or creating an extra layer of objects (StreamUploadField-s,
which
would be a super-class for FileUploadField-s without
FileUpload-related
contract obligations). In the latter case, you'd give users those
needed
generic components that look and feel (and smell :) ) like files on
the
client side, but are free for interpretation on the server side.
Still,
today's FileUploadField-s would be there as subclasses (in all their
full-contract glory) for backward compatibility...
In general this sounds good to me. It would be a great help to us if
someone (you) could provide us with a patch to make this concrete.
Without a patch, I'm afraid this would be on the bottom of our current
priority list (though we can do the change in Form anyway).
Eelco
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
--
View this message in context:
http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8420808
Sent from the Wicket - User mailing list archive at Nabble.com.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
This was what I meant with: 'It can, though not very obvious. Look at
wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest'.
Guess I wasn't clear enough. But as I also stated in that answer, I
would be fine with making that method protected non-final if no urgent
objection arise in this thread.
Eelco
On 1/17/07, beboris [EMAIL PROTECTED] wrote:
So, I guess you suggest we do it on the application level by overriding
newWebRequest() method inside the whole WebApplication, so it returns our
custom WebRequest subclass globally, as follows:
protected WebRequest newWebRequest(HttpServletRequest servletRequest) {
return new CustomWebRequest(servletRequest);
}
Then our CustomWebRequest class would in turn override
newMultipartWebRequest() method and do custom processing globally, as
opposed to working on the specific Form level which we could achieve should
our CustomForm's handleMultiPart() method be overridable. Is that correct?
If yes - do you see it as a workaround for a simple case or a generic
solution for anyone who needs custom behavior of multi-part HTTP POST-s from
forms?
-boris
igor.vaynberg wrote:
you can already substitute your own implementation of IMultipartWebRequest
globally. the ajax-upload-progressbar does it
-igor
On 1/17/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
IMHO, linking FileUploadField-s (which we need to browse for the
correct
input file in the browser) with the specific (FileUpload, File)
implementation of the results of the multi-part HTTP POST streams
(created
when the form is submitted) is too strong (and limiting) for a
generic
[and the only available!] contract for multi-part HTTP POST streams in
a
generic-purpose web framework like wicket. So, I'd suggest either
leaving
things the way they are (FileUploadField-s will return null for
FileUpload
when File upload is not used) or eliminating those FileUpload-related
methods (let the user get this info from (IMultipartWebRequest)request
instead), or creating an extra layer of objects (StreamUploadField-s,
which
would be a super-class for FileUploadField-s without FileUpload-related
contract obligations). In the latter case, you'd give users those
needed
generic components that look and feel (and smell :) ) like files on
the
client side, but are free for interpretation on the server side. Still,
today's FileUploadField-s would be there as subclasses (in all their
full-contract glory) for backward compatibility...
In general this sounds good to me. It would be a great help to us if
someone (you) could provide us with a patch to make this concrete.
Without a patch, I'm afraid this would be on the bottom of our current
priority list (though we can do the change in Form anyway).
Eelco
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
--
View this message in context:
http://www.nabble.com/Impossible-to-customize-multi-part-POST-s-from-Form-s-in-Wicket-due-to-%22final%22-methods-tf3025509.html#a8420808
Sent from the Wicket - User mailing list archive at Nabble.com.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys - and earn cash
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Anybody here knows if wicket can be extended to process Multi-part HTTP POST streams in a custom way? It can, though not very obvious. Look at wicket.extensions.ajax.markup.html.form.upload.UploadWebRequest, which is a custom WebRequest. That works for the case where you want all of your multipart requests to be handled in the same fashion. And, if not, may be the respected members of the wicket team could consider simply making that method private final boolean handleMultiPart() protected and not private final in the next version... That sounds fine by me: +1. Other developers? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
On 1/16/07, Eelco Hillenius [EMAIL PROTECTED] wrote: And, if not, may be the respected members of the wicket team could consider simply making that method private final boolean handleMultiPart() protected and not private final in the next version... That sounds fine by me: +1. Other developers? +1, however we do need to consider how this will effect the contract with fileuploadfield. if this is overridden then you can no longer count on the fileuploadfield's model to be properly populated and since the form is the intermediary it may not be obvious as to why. -igor Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
+1, however we do need to consider how this will effect the contract with fileuploadfield. if this is overridden then you can no longer count on the fileuploadfield's model to be properly populated and since the form is the intermediary it may not be obvious as to why. Yeah. Boris, you kind of mentioned you weren't particularly happy with the current contract anyway. Do you have suggestions as to how to improve this? Thanks, Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
what i meant is that if someone overrides handlemultipart() on the form, unless they do what we do they will break fileuploadfields -igor On 1/16/07, Eelco Hillenius [EMAIL PROTECTED] wrote: +1, however we do need to consider how this will effect the contract with fileuploadfield. if this is overridden then you can no longer count on the fileuploadfield's model to be properly populated and since the form is the intermediary it may not be obvious as to why. Yeah. Boris, you kind of mentioned you weren't particularly happy with the current contract anyway. Do you have suggestions as to how to improve this? Thanks, Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] Impossible to customize multi-part POST-s from Form-s in Wicket due to final methods
Yeah, I got that. And they also likely break the contract of WebRequest#newMultipartWebRequest, as they probably won't honor calling that. Boris mentioned he wasn't happy about the file-centric-ness of the current API, and I was wondering whether he has suggestions to improve that. Eelco On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: what i meant is that if someone overrides handlemultipart() on the form, unless they do what we do they will break fileuploadfields -igor On 1/16/07, Eelco Hillenius [EMAIL PROTECTED] wrote: +1, however we do need to consider how this will effect the contract with fileuploadfield. if this is overridden then you can no longer count on the fileuploadfield's model to be properly populated and since the form is the intermediary it may not be obvious as to why. Yeah. Boris, you kind of mentioned you weren't particularly happy with the current contract anyway. Do you have suggestions as to how to improve this? Thanks, Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
