Re: [Wicket-user] VOTE: one more api break for AbstractChoice
+1 Eelco Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So that you can use detachable models much more easy. We could change it to: public AbstractChoice(final String id, IModel model, final IListDatasource choices, final IChoiceRenderer renderer) But this i don't think i want. Just use IModel everywhere and let the model object be specific to a certain interface if needed Then with 1.5 we could say: public AbstractChoice(final String id, IModel model, final IModelList choices, final IChoiceRenderer renderer) or public AbstractChoice(final String id, IModel model, final IModelIListDatasource choices, final IChoiceRenderer renderer) So anybody +1 or -1 for the change to List-IModel johan --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] VOTE: one more api break for AbstractChoice
+1 Juergen On 7/29/05, Eelco Hillenius [EMAIL PROTECTED] wrote: +1 Eelco Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So that you can use detachable models much more easy. We could change it to: public AbstractChoice(final String id, IModel model, final IListDatasource choices, final IChoiceRenderer renderer) But this i don't think i want. Just use IModel everywhere and let the model object be specific to a certain interface if needed Then with 1.5 we could say: public AbstractChoice(final String id, IModel model, final IModelList choices, final IChoiceRenderer renderer) or public AbstractChoice(final String id, IModel model, final IModelIListDatasource choices, final IChoiceRenderer renderer) So anybody +1 or -1 for the change to List-IModel johan --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] VOTE: one more api break for AbstractChoice
+/- 0 (+1) I like the option discussed in the wicket 1.1b2-rc1 string. keep both and make the old one deprecated. But if you can't have both, then break Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So that you can use detachable models much more easy. We could change it to: public AbstractChoice(final String id, IModel model, final IListDatasource choices, final IChoiceRenderer renderer) But this i don't think i want. Just use IModel everywhere and let the model object be specific to a certain interface if needed Then with 1.5 we could say: public AbstractChoice(final String id, IModel model, final IModelList choices, final IChoiceRenderer renderer) or public AbstractChoice(final String id, IModel model, final IModelIListDatasource choices, final IChoiceRenderer renderer) So anybody +1 or -1 for the change to List-IModel johan --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
RE: [Wicket-user] VOTE: one more api break for AbstractChoice
+1 the javadoc should be clear that the underlying model object needs to be a list or whatever. It would be nice to switch to imodelt right now. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner Sent: Friday, July 29, 2005 4:33 AM To: wicket-user@lists.sourceforge.net Subject: [Wicket-user] VOTE: one more api break for AbstractChoice We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So that you can use detachable models much more easy. We could change it to: public AbstractChoice(final String id, IModel model, final IListDatasource choices, final IChoiceRenderer renderer) But this i don't think i want. Just use IModel everywhere and let the model object be specific to a certain interface if needed Then with 1.5 we could say: public AbstractChoice(final String id, IModel model, final IModelList choices, final IChoiceRenderer renderer) or public AbstractChoice(final String id, IModel model, final IModelIListDatasource choices, final IChoiceRenderer renderer) So anybody +1 or -1 for the change to List-IModel johan --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] VOTE: one more api break for AbstractChoice
that is not an option (using generics) i think this will be an option After 1.2 not earlier because wicket is a framework that will be used on servers and servers are pretty slow to adapt to new java versions. Especially things like Websphere where versions are build on a specific jvm I will add 4 more constructors.. and wrap the current list constructors in a new Model(list) johan Igor Vaynberg wrote: +1 the javadoc should be clear that the underlying model object needs to be a list or whatever. It would be nice to switch to imodelt right now. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner Sent: Friday, July 29, 2005 4:33 AM To: wicket-user@lists.sourceforge.net Subject: [Wicket-user] VOTE: one more api break for AbstractChoice We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So that you can use detachable models much more easy. We could change it to: public AbstractChoice(final String id, IModel model, final IListDatasource choices, final IChoiceRenderer renderer) But this i don't think i want. Just use IModel everywhere and let the model object be specific to a certain interface if needed Then with 1.5 we could say: public AbstractChoice(final String id, IModel model, final IModelList choices, final IChoiceRenderer renderer) or public AbstractChoice(final String id, IModel model, final IModelIListDatasource choices, final IChoiceRenderer renderer) So anybody +1 or -1 for the change to List-IModel johan --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user --- SF.Net email is Sponsored by the Better Software Conference EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile Plan-Driven Development * Managing Projects Teams * Testing QA Security * Process Improvement Measurement * http://www.sqe.com/bsce5sf ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
