[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands
Continuous integration builds have changed state: Travis build 3802. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416115952. Appveyor build 3601. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_frisian_trainingsites_food_help-3601. -- https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands.
Commit message:
Added cleanup function to map_info.cc and initializing the sound system. This
gets rid of some error messages and a memory leak. Pulled out common code for
the website binaries.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1776603 in widelands: "ASAN: wl_map_object_info leaks memory"
https://bugs.launchpad.net/widelands/+bug/1776603
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1776603_map_info_memory_leak/+merge/353140
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands.
=== modified file 'src/graphic/gl/initialize.cc'
--- src/graphic/gl/initialize.cc 2018-04-07 16:59:00 +
+++ src/graphic/gl/initialize.cc 2018-08-15 03:33:41 +
@@ -84,6 +84,8 @@
// See graphic/gl/system_headers.h for an explanation of the next line.
glewExperimental = GL_TRUE;
GLenum err = glewInit();
+ // LeakSanitizer reports a memory leak which is triggered somewhere above this line, probably coming from the gaphics drivers
+
if (err != GLEW_OK) {
log("glewInit returns %i\nYour OpenGL installation must be __very__ broken. %s\n", err,
glewGetErrorString(err));
=== modified file 'src/graphic/graphic.cc'
--- src/graphic/graphic.cc 2018-06-01 08:54:25 +
+++ src/graphic/graphic.cc 2018-08-15 03:33:41 +
@@ -85,6 +85,7 @@
window_mode_width_, window_mode_height_, SDL_WINDOW_OPENGL);
GLint max;
+ // LeakSanitizer reports a memory leak which is triggered somewhere in this function call, probably coming from the gaphics drivers
gl_context_ = Gl::initialize(
trace_gl == TraceGl::kYes ? Gl::Trace::kYes : Gl::Trace::kNo, sdl_window_, );
=== modified file 'src/website/CMakeLists.txt'
--- src/website/CMakeLists.txt 2017-11-20 13:50:51 +
+++ src/website/CMakeLists.txt 2018-08-15 03:33:41 +
@@ -1,7 +1,20 @@
+wl_library(website_common
+ SRCS
+website_common.cc
+website_common.h
+ USES_SDL2
+ DEPENDS
+base_exceptions
+base_i18n
+graphic
+io_filesystem
+sound
+)
+
+
wl_binary(wl_map_info
SRCS
map_info.cc
- USES_SDL2
DEPENDS
base_log
graphic
@@ -12,6 +25,7 @@
io_filesystem
logic
map_io_map_loader
+website_common
)
wl_binary(wl_map_object_info
@@ -19,7 +33,6 @@
map_object_info.cc
USES_SDL2
DEPENDS
-base_i18n
base_log
base_macros
graphic
@@ -27,5 +40,5 @@
io_filesystem
logic
logic_tribe_basic_info
-sound
+website_common
)
=== modified file 'src/website/map_info.cc'
--- src/website/map_info.cc 2018-04-07 16:59:00 +
+++ src/website/map_info.cc 2018-08-15 03:33:41 +
@@ -36,26 +36,10 @@
#include "logic/editor_game_base.h"
#include "logic/map.h"
#include "map_io/widelands_map_loader.h"
+#include "website/website_common.h"
using namespace Widelands;
-namespace {
-
-// Setup the static objects Widelands needs to operate and initializes systems.
-void initialize() {
- if (SDL_Init(SDL_INIT_VIDEO) != 0) {
- throw wexception("Unable to initialize SDL: %s", SDL_GetError());
- }
-
- g_fs = new LayeredFileSystem();
- g_fs->add_file_system(::create(INSTALL_DATADIR));
-
- g_gr = new Graphic();
- g_gr->initialize(Graphic::TraceGl::kNo, 1, 1, false);
-}
-
-} // namespace
-
int main(int argc, char** argv) {
if (!(2 <= argc && argc <= 3)) {
log("Usage: %s \n", argv[0]);
@@ -142,9 +126,12 @@
write_string("}\n");
fw.write(*in_out_filesystem, (map_file + ".json").c_str());
}
+ egbase.cleanup_objects();
} catch (std::exception& e) {
log("Exception: %s.\n", e.what());
+ cleanup();
return 1;
}
+ cleanup();
return 0;
}
=== modified file 'src/website/map_object_info.cc'
--- src/website/map_object_info.cc 2018-04-07 16:59:00 +
+++ src/website/map_object_info.cc 2018-08-15 03:33:41 +
@@ -24,7 +24,6 @@
#include
#include
-#include "base/i18n.h"
#include "base/log.h"
#include "base/macros.h"
#include "config.h"
@@ -36,7 +35,7 @@
#include "logic/map_objects/tribes/tribe_basic_info.h"
#include "logic/map_objects/tribes/tribes.h"
#include "logic/map_objects/world/world.h"
-#include "sound/sound_handler.h"
+#include "website/website_common.h"
using namespace Widelands;
@@ -44,52 +43,6 @@
/*
==
- SETUP
- ==
- */
-
-// Setup the static objects Widelands needs to operate and initializes systems.
-std::unique_ptr initialize(const std::string& output_path) {
- i18n::set_locale("en");
-
- if (SDL_Init(SDL_INIT_VIDEO) != 0) {
- throw wexception("Unable to initialize SDL: %s", SDL_GetError());
- }
-
- g_fs = new LayeredFileSystem();
- g_fs->add_file_system(::create(INSTALL_DATADIR));
-
-
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
> SirVer, Gun: do we have that Ticket still in some Archive? There is nothing relevant with the "macos" tag in the archive. Of course, such a bug might have been fix released before I did the tag cleanup. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands
Continuous integration builds have changed state: Travis build 3801. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/416088423. Appveyor build 3600. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-3600. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ferry into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Continuous integration builds have changed state: Travis build 3800. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/416061570. Appveyor build 3599. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_macos_build_app_compiler-3599. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Here are the clang builds: http://fosuta.org/widelands_64bit_r8786.dmg http://fosuta.org/widelands_64bit_r8786_Debug.dmg -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
I rember that SirVer used brew as well for R19 and I used macports and we had some significat differences in the end, was much bigger, or such. SirVer, Gun: do we have that Ticket still in some Archive? Once we target R20 we should use all variants and use the smalles/fastest on. Lets see. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
$ ./build_app.sh clang debug ../macos_build_app_compiler gives me this output later on -- Using AddressSanitizer http://clang.llvm.org/docs/AddressSanitizer.html So it is using it without explicitly declaring it. Does work with clang. gcc currently gives me headaches, though. It seems to use the clangs dylib. Still do some testings and gonna add some stuff to the script. When done I'll give you some .dmg -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Mmh, this does not contain the ASAN Flags as we have them in compile.sh, this would make sense for a debug build (yes, it _is_ slower :-) OTOH wee need this just for the release in then End, I would guess. I use macports so lets try this now wlbuild klaus$ ./build_app.sh clang debug ../macos_build_app_compiler Source: ../macos_build_app_compiler Version: r8783 Destination: WidelandsRelease Type:Debug macOS: 10.13 Compiler:Apple LLVM version 9.1.0 (clang-902.0.39.2) ./build_app.sh: line 140: brew: command not found OK so this is tied to homebrew (will not install this here) There is a script / reciept for macports, too. Are you interested to get into contact with the maintainer? (I think there is some howto for macports on the homepage, too) Code LGTM. so maybe you want to provide me with some .dmg derived from your script? As this will not affect any build this can go in. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Toni, you re doing a great job! Just give me some time to catch up with your speed :-) You may contact me via PM or such, so we can align on our skills. Ill try to review this this week but will not promise anything ... -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands
Continuous integration builds have changed state: Travis build 3790. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415596858. Appveyor build 3589. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-3589. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ferry into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
Continuous integration builds have changed state: Travis build 3791. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415624736. Appveyor build 3590. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1786613_500ms_return_skipped-3590. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Continuous integration builds have changed state: Travis build 3796. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415851588. Appveyor build 3595. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_macos_build_app_compiler-3595. -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/remove_executable_bit/+merge/353012 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_executable_bit. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands
Continuous integration builds have changed state: Travis build 3789. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415567854. Appveyor build 3588. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_remove_executable_bit-3588. -- https://code.launchpad.net/~widelands-dev/widelands/remove_executable_bit/+merge/353012 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_executable_bit. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands
Continuous integration builds have changed state: Travis build 3788. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415541252. Appveyor build 3587. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1619402_port_work_area_on_expedition-3587. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
@ypopezios: In principle you are right. It is somewhat arbitrary or you might say it is try and error. On the other hand I don't know how to handle this in a different way, cause more frequent calls of the working programs will always consume more processing power. so the value of 500 to 1000ms was chosen due to the consumed processing power on my machine while knowing the kind of measurement had some big uncertainties. Therefore I asked to test his issue on an even more underpowered system. For my understanding the more underpowered a testsystem would be the more visible would be the effect of this change. @Toni Förster: I was thinking to have this tested on a netbook or similar. As we support 1024x600 resolution we should support the processing power of those configs as well. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands
Continuous integration builds have changed state: Travis build 3787. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415539866. Appveyor build 3586. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_lenient_allowed_buildings-3586. -- https://code.launchpad.net/~widelands-dev/widelands/lenient_allowed_buildings/+merge/351749 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lenient_allowed_buildings. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/lenient_allowed_buildings/+merge/351749 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lenient_allowed_buildings. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
In principle, if I was given a range to compromise with, I would go the conservative route and pick the edge of the range which is closer to the previous value. In this case, the given range is 500 to 1000ms, the previous value is 1ms, so I would go with 1000ms. Having said that, in my eyes an arbitrary value gets replaced by another arbitrary value. More tests of that kind won't make that value any less arbitrary. Therefore, I would comment this code for redesign in a future build. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
> Looks good from my side now. > Would be good though if somebody with an underpowered machine would confirm > minimal effect on performance Do you think it gets much more underpowered. Your processor is basically the same as mine. Just a few MHz slower. The only difference is RAM. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/missing_animations_barbarians_wood_hardener into lp:~widelands-dev/widelands/mines-worldsavior
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/missing_animations_barbarians_wood_hardener/+merge/352980 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
Review: Approve Looks good from my side now. Would be good though if somebody with an underpowered machine would confirm minimal effect on performance -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands
Review: Approve Code LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1785404-chat-scrolling. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands
Continuous integration builds have changed state: Travis build 3786. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415538286. Appveyor build 3585. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1785404_chat_scrolling-3585. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1785404-chat-scrolling. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
