[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
Toni Förster has proposed merging
lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands.
Commit message:
reduce waiting time to 500ms for skipped programs
Requested reviews:
hessenfarmer (stephan-lutz)
Related bugs:
Bug #1786613 in widelands: "production times are 10s longer when
return=skipped"
https://bugs.launchpad.net/widelands/+bug/1786613
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028
That "penalty" is reduced to 500ms. Which, according to @hessenfarmer's testing
may be the sweetspot
--
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped.
=== modified file 'src/logic/map_objects/tribes/productionsite.cc'
--- src/logic/map_objects/tribes/productionsite.cc 2018-06-19 08:52:49 +
+++ src/logic/map_objects/tribes/productionsite.cc 2018-08-13 20:06:37 +
@@ -899,7 +899,7 @@
SkippedPrograms::const_iterator i = skipped_programs_.find(program_name);
if (i != skipped_programs_.end()) {
uint32_t const gametime = game.get_gametime();
- uint32_t const earliest_allowed_start_time = i->second + 1;
+ uint32_t const earliest_allowed_start_time = i->second + 500;
if (gametime + tdelta < earliest_allowed_start_time)
tdelta = earliest_allowed_start_time - gametime;
}
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
Continuous integration builds have changed state: Travis build 3791. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415624736. Appveyor build 3590. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1786613_500ms_return_skipped-3590. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
Review: Approve Looks good from my side now. Would be good though if somebody with an underpowered machine would confirm minimal effect on performance -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
> Looks good from my side now. > Would be good though if somebody with an underpowered machine would confirm > minimal effect on performance Do you think it gets much more underpowered. Your processor is basically the same as mine. Just a few MHz slower. The only difference is RAM. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
In principle, if I was given a range to compromise with, I would go the conservative route and pick the edge of the range which is closer to the previous value. In this case, the given range is 500 to 1000ms, the previous value is 1ms, so I would go with 1000ms. Having said that, in my eyes an arbitrary value gets replaced by another arbitrary value. More tests of that kind won't make that value any less arbitrary. Therefore, I would comment this code for redesign in a future build. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands
@ypopezios: In principle you are right. It is somewhat arbitrary or you might say it is try and error. On the other hand I don't know how to handle this in a different way, cause more frequent calls of the working programs will always consume more processing power. so the value of 500 to 1000ms was chosen due to the consumed processing power on my machine while knowing the kind of measurement had some big uncertainties. Therefore I asked to test his issue on an even more underpowered system. For my understanding the more underpowered a testsystem would be the more visible would be the effect of this change. @Toni Förster: I was thinking to have this tested on a netbook or similar. As we support 1024x600 resolution we should support the processing power of those configs as well. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
