[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 db changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||duplicate...@googlemail.com Resolution|--- |FIXED --- Comment #20 from db --- Status Merged -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #19 from Gerrit Notification Bot --- Change 104203 merged by jenkins-bot: wfRunHooks() return value no longer implies whether variable value was found https://gerrit.wikimedia.org/r/104203 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #18 from Gerrit Notification Bot --- Change 104203 had a related patch set uploaded by Siebrand: wfRunHooks() return value no longer implies whether variable value was found. Bug: 12837 https://gerrit.wikimedia.org/r/104203 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #17 from Gerrit Notification Bot --- Change 104206 abandoned by Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found Reason: Regenerated one https://gerrit.wikimedia.org/r/104206 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #16 from Gerrit Notification Bot --- Change 104490 abandoned by Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found Reason: Regenerated copy https://gerrit.wikimedia.org/r/104490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #15 from Gerrit Notification Bot --- Change 104490 had a related patch set uploaded by Vishnunk90: wfRunHooks() return value no longer implies whether variable value was found https://gerrit.wikimedia.org/r/104490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #14 from Gerrit Notification Bot --- Change 104206 had a related patch set uploaded by Siebrand: wfRunHooks() return value no longer implies whether variable value was found https://gerrit.wikimedia.org/r/104206 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #13 from Gerrit Notification Bot --- Change 104203 had a related patch set uploaded by Siebrand: wfRunHooks() return value no longer implies whether variable value was found. Bug: 12837 https://gerrit.wikimedia.org/r/104203 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 au changed: What|Removed |Added CC||audr...@audreyt.org --- Comment #12 from au 2012-06-17 18:40:55 UTC --- Hi Daniel, thank you for the patch! As you may already know, MediaWiki is currently revamping its PHP-based parser into a "Parsoid" prototype component, to support the rich-text Visual Editor project: https://www.mediawiki.org/wiki/Parsoid https://www.mediawiki.org/wiki/Visual_editor Folks interested in enhancing the parser's capabilities are very much welcome to join the Parsoid project, and contribute patches as Git branches: https://www.mediawiki.org/wiki/Git/Tutorial#How_to_submit_a_patch Compared to .diff attachments in Bugzilla tickets, Git branches are much easier for us to review, refine and merge features together. Each change set has a distinct URL generated by the "git review" tool, which can be referenced in Bugzilla by pasting its gerrit.wikimedia.org URL as a comment. If you run into any issues with the patch process, please feel free to ask on irc.freenode.net #wikimedia-dev and the wikitext-l mailing list. Thank you! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 --- Comment #11 from Sumana Harihareswara 2012-03-23 22:04:03 UTC --- Daniel, sorry for the wait in review. I encourage you to get a Git account https://www.mediawiki.org/wiki/Git to make it easier for you to submit patches to MediaWiki and to get them reviewed faster. Thanks! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 Sumana Harihareswara changed: What|Removed |Added Keywords|reviewed|need-review --- Comment #10 from Sumana Harihareswara 2011-11-08 17:36:36 UTC --- (adding need-review keyword re: DanWe's new patch) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 Daniel Werner changed: What|Removed |Added Attachment #4650|0 |1 is obsolete|| --- Comment #9 from Daniel Werner 2011-11-08 17:35:20 UTC --- Created attachment 9380 --> https://bugzilla.wikimedia.org/attachment.cgi?id=9380 wfRunHooks() return value no longer implies whether variable value was found. Only $ret is important. returning false within hook call will improve performance since it will prevent wfRunHooks() to do any other calls, returning true still works with old extensions and has no specific meaning. This wil primarily fix extensions which have followed the old description on http://www.mediawiki.org/wiki/Manual:Hooks/ParserGetVariableValueSwitch It allows to improve performance for extensions which do not want to keep compatibility with previous MW versions by returning false when value found. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 Sumana Harihareswara changed: What|Removed |Added Keywords|need-review |reviewed CC||suma...@panix.com --- Comment #8 from Sumana Harihareswara 2011-11-08 17:34:52 UTC --- Charlie -- thanks for the patch. We appreciate it. I'm sorry it took so long for us to respond. MediaWiki developers are currently rewriting the parser -- you can participate on https://lists.wikimedia.org/mailman/listinfo/wikitext-l and https://www.mediawiki.org/wiki/Future . Thanks again. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 12837] Incorrect MagicVariable hook implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=12837 Daniel Werner changed: What|Removed |Added CC||danwe...@web.de --- Comment #7 from Daniel Werner 2011-11-08 17:02:13 UTC --- The patch of attachment 4650 would break lots of compatibility, right now all functions hooked in return 'true' (or otherwise break things), so if you only return the $ret value on 'false' returned, all of the current calls, even if they set $ret, imply they found nothing. So the best compromise I think would be to always return $ret (it is set to null before the wfRunHooks() call) and leave the 'false' handling to wfRunHooks(), so returning 'false' simply would improve performance and won't break things no longer in versions after the bugfix. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
