[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #31 from Nemo_bis 2010-11-30 10:26:16 UTC --- (In reply to comment #30) > If we still really need to revisit this issue, please file a more specific > feature request. The current title/description is too far-reaching, but a > more > specific request for a new "autoreview on rollback" right might fly. I've reopened bug 13751. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Rob Lanphier changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WONTFIX --- Comment #30 from Rob Lanphier 2010-11-29 23:00:50 UTC --- Ok, I've read though this one enough that I feel comfortable marking this as "wontfix". I share Aaron's concern that mixing privileges is a bad idea. If we still really need to revisit this issue, please file a more specific feature request. The current title/description is too far-reaching, but a more specific request for a new "autoreview on rollback" right might fly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Bawolff changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #29 from Bawolff 2010-11-29 22:40:17 UTC --- Note, there is the case on Wikinews where reviewers don't have autoreview rights, so rollback to sighted revision not being auto-sighted for reviewers is kind of annoying, but still a rather minor annoyance. (I know this is similar to other cases mentioned above, I only mention it as 99% of wikis the reviewers would have autoreview, so this bug being fixed (if it were to be fixed) would have a somewhat different effect for wikinews) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Rob Lanphier changed: What|Removed |Added CC||ro...@wikimedia.org --- Comment #28 from Rob Lanphier 2010-11-29 22:14:45 UTC --- We're discussing this issue now. Our inclination is to mark this as "wontfix", but I'd like to read through this to make sure that we stand by this assessment. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Aaron Schulz changed: What|Removed |Added Priority|High|Low -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #27 from Aaron Schulz 2010-09-01 22:20:55 UTC --- (In reply to comment #26) > I would prefer to have identical flaggs for the original and for the reverted > version. If you don't want to activate that per default for every rollback, > you > can as well create a new user right like 'restoreflagg' so the stewards could > set it for the global rollbackers This would be like comment #21. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #26 from Hoo man 2010-08-31 11:38:35 UTC --- I would prefer to have identical flaggs for the original and for the reverted version. If you don't want to activate that per default for every rollback, you can as well create a new user right like 'restoreflagg' so the stewards could set it for the global rollbackers -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978
--- Comment #25 from Aaron Schulz 2010-08-26 21:05:16
UTC ---
The core commitRollback() function always auto-patrols. FR can't really control
that nicely. Eventually most of FR's usage of RC patrol will be removed, which
already started with the (pending review) and (unreviewed) links on
RC/watchlist/RLC pages (to replace ! marks).
I don't have *strong* feelings on making rollback implicitly autoreview (to the
lowest level). Is that what this comes down to and nothing else? Or should the
flags be identical to the base revision that the page was reverted to? The only
thing I worry about ("exploits") are template/file vandalism/misinformation
that slips through on a page that uses them (the templates) without notice (on
rollback).
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #24 from Nemo_bis 2010-08-26 09:12:14 UTC --- (In reply to comment #23) > Therefore, the current behaviour of rollback with regard to FlaggedRevs is > inconsistent. Excuse me, I was not clear here: I meant that this a sort of autopatrol right implicit in rollback right, and that making also "autoreview on rollback" implicit in rollback seems analogous to me. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #23 from Nemo_bis 2010-08-26 09:07:38 UTC --- (In reply to comment #17) > rollback has a different behaviour from > normal reverts also with regard to patrolled revisions (rollbacked revisions > are marked as patrolled, even if this doesn't appear in logs). You can see an example on pt.wiki, where rollbackers (and autoconfirmed) don't have autopatrol (http://pt.wikipedia.org/wiki/Especial:Lista_de_privil%C3%A9gios_de_grupos?uselang=en ), if you pick a rollbacker who is not autopatroller (http://pt.wikipedia.org/w/index.php?title=Especial:Lista_de_utilizadores&group=rollbacker&uselang=en ): if you're autoconfirmed, you'll see that e.g. this edit http://pt.wikipedia.org/w/index.php?title=Chuva_%C3%A1cida&diff=21560746&oldid=21359167 is shown as patrolled because it was implicitly autopatrolled by the subsequent rollback http://pt.wikipedia.org/w/index.php?title=Chuva_%C3%A1cida&diff=next&oldid=21560746 (it was not explicitly patrolled because otherwise it would be listed in the log and it is not: http://pt.wikipedia.org/w/index.php?title=Especial:Registo&dir=prev&offset=20100809003204&limit=3&page=Chuva+ácida&hide_patrol_log=0 ). Therefore, the current behaviour of rollback with regard to FlaggedRevs is inconsistent. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #22 from Nemo_bis 2010-08-26 08:42:35 UTC --- (In reply to comment #21) > So is this to make rollback by anyone, regardless of rights, auto-review that > revision? That would be a bad separation rights. Why? You said that the problem was the possibility that someone made an old version the new stable version, but this doesn't apply to rollbacks. On bug 13751 you said that there are "some exploits" but you didn't specify them (but you said also «I'll probably make it at least basic reviewed»). So, what's the problem? > Is the request to make a new > right for "autoreview on rollback" and then grant that to "global > rollbackers"? If you want to say so; but I think that such a right should be implicit in the "rollback" right. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #21 from Aaron Schulz 2010-08-25 23:03:23 UTC --- So is this to make rollback by anyone, regardless of rights, auto-review that revision? That would be a bad separation rights. Is the request to make a new right for "autoreview on rollback" and then grant that to "global rollbackers"? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #20 from Nemo_bis 2010-08-25 22:55:40 UTC --- (In reply to comment #19) > But even if you don't have autoreview, it doesn't make sense that, if you > restore an old version of the page, that version now has a different flag. Oops, I suppose this is bug 13751. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #19 from Nemo_bis 2010-08-25 22:52:27 UTC --- (In reply to comment #18) > (In reply to comment #15) > > (In reply to comment #14) > > > I thought you didn't have 'autoreview'? Why *would* it be autoreviewed? > > Because I'm restoring a version, which somebody else already marked as > > "Ok", so > > there is no need to review it again, is there? :) > > So it the request to give 'autoreview' to "global rollbackers"? That should be > a separate "site request" and might require discussion. No, because "autoreview" would apply also to non-rollback edits. But even if you don't have autoreview, it doesn't make sense that, if you restore an old version of the page, that version now has a different flag. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #18 from Aaron Schulz 2010-08-25 22:39:57 UTC --- (In reply to comment #15) > (In reply to comment #14) > > I thought you didn't have 'autoreview'? Why *would* it be autoreviewed? > Because I'm restoring a version, which somebody else already marked as "Ok", > so > there is no need to review it again, is there? :) So it the request to give 'autoreview' to "global rollbackers"? That should be a separate "site request" and might require discussion. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Nemo_bis changed: What|Removed |Added Status|RESOLVED|REOPENED CC||federicol...@tiscali.it Resolution|FIXED | --- Comment #17 from Nemo_bis 2010-08-25 19:17:45 UTC --- (In reply to comment #16) > That would let vandals just revert to super old versions, which could become > the stable version. That doesn't seem acceptable. You didn't understand. Hoo was talking about rollbacks, not generic reverts. Rollbackers are trusted users, and rollback has a different behaviour from normal reverts also with regard to patrolled revisions (rollbacked revisions are marked as patrolled, even if this doesn't appear in logs). Rollback restores the most recent revision (excluding those from the rollbacked user). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 Aaron Schulz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #16 from Aaron Schulz 2010-08-25 18:25:20 UTC --- That would let vandals just revert to super old versions, which could become the stable version. That doesn't seem acceptable. This report was about sysops (or trusted users at least). A more general request should be made as a separate report. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #15 from Hoo man 2010-08-25 12:49:13 UTC --- (In reply to comment #14) > I thought you didn't have 'autoreview'? Why *would* it be autoreviewed? Because I'm restoring a version, which somebody else already marked as "Ok", so there is no need to review it again, is there? :) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #14 from Aaron Schulz 2010-08-24 20:37:28 UTC --- (In reply to comment #13) > (In reply to comment #12) > > > > Only self-reverts to the stable version are allowed for people without > > 'autoreview'. > I tested it again on testwiki (with another account as vandal) > http://test.wikipedia.org/w/index.php?title=Parent_page/subpage&action=history > and it's not autoreviewing the change... > Will this be changed in the future? I thought you didn't have 'autoreview'? Why *would* it be autoreviewed? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #13 from Hoo man 2010-08-24 11:47:26 UTC --- (In reply to comment #12) > > Only self-reverts to the stable version are allowed for people without > 'autoreview'. I tested it again on testwiki (with another account as vandal) http://test.wikipedia.org/w/index.php?title=Parent_page/subpage&action=history and it's not autoreviewing the change... Will this be changed in the future? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #12 from Aaron Schulz 2010-08-24 03:25:53 UTC --- (In reply to comment #11) > (In reply to comment #10) > > Are you a reviewer? > I just have the usual autoconfirmed rights in both wikis (which do not include > either review of autoreview) + the global rollbacker rights, which do not > include autoreview or review as well. > (http://meta.wikimedia.org/wiki/Global_rollback) Only self-reverts to the stable version are allowed for people without 'autoreview'. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #11 from Hoo man 2010-08-23 13:16:40 UTC --- (In reply to comment #10) > Are you a reviewer? I just have the usual autoconfirmed rights in both wikis (which do not include either review of autoreview) + the global rollbacker rights, which do not include autoreview or review as well. (http://meta.wikimedia.org/wiki/Global_rollback) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 --- Comment #10 from Aaron Schulz 2010-08-22 22:14:09 UTC --- (In reply to comment #9) > The fix doesn't work on all WMF wikis, see for example the two following > historys: > http://test.wikipedia.org/w/index.php?title=Parent_page/subpage&action=history > and > http://en.wikibooks.org/w/index.php?title=Microprocessor_Design/Design_Steps&action=history > both wikis are running 1.16wmf4 (r70933) and I have no 'autoreview' in both. Are you a reviewer? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 13978] Reverting to a flagged revision should automatically mark the resulting revision as flagged, too
https://bugzilla.wikimedia.org/show_bug.cgi?id=13978 h...@online.de changed: What|Removed |Added Status|RESOLVED|REOPENED CC||h...@online.de Resolution|FIXED | --- Comment #9 from h...@online.de 2010-08-16 19:37:16 UTC --- The fix doesn't work on all WMF wikis, see for example the two following historys: http://test.wikipedia.org/w/index.php?title=Parent_page/subpage&action=history and http://en.wikibooks.org/w/index.php?title=Microprocessor_Design/Design_Steps&action=history both wikis are running 1.16wmf4 (r70933) and I have no 'autoreview' in both. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
