[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546 --- Comment #6 from Splarka 2009-07-07 23:49:51 UTC --- (In reply to comment #5) > Done better in r52849 > Sweet! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546 Roan Kattouw changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #5 from Roan Kattouw 2009-07-07 17:46:46 UTC --- Done better in r52849 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546 Raimond Spekking changed: What|Removed |Added CC||raimond.spekk...@gmail.com --- Comment #4 from Raimond Spekking 2009-07-07 07:57:59 UTC --- *** Bug 19486 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546 Splarka changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #3 from Splarka 2009-07-07 00:38:39 UTC --- > Fixed this logic to do proper skin detection in r52821. Yes the original code was bad, but this is worse. >_< This presumably breaks it in chick, myskin, and simple, as well as any other user-defined monobook+template skins, which use the same HTML as Monobook (and are basically "Monobook" skins), but have a different name. You shouldn't rely on a js-based skin-name check, but fix the underlying problems with vector. Or do what the code suggests: // We special-case skin structures provided by the software. Skins that // choose to abandon or significantly modify our formatting can just define // an mw-js-message div to start with. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546
Roan Kattouw changed:
What|Removed |Added
CC||roan.katt...@gmail.com
Status|NEW |RESOLVED
Resolution||FIXED
--- Comment #2 from Roan Kattouw 2009-07-07 00:07:44
UTC ---
(In reply to comment #1)
> That's how Modern does it. Some other skins like Monobook created the div
> dynamically, using the following code from wikiBits:
>
> if ( document.getElementById( 'column-content' )
> && document.getElementById( 'content' ) ) {
> // MonoBook, presumably
> document.getElementById( 'content' ).insertBefore(
> messageDiv,
> document.getElementById( 'content' ).firstChild
> );
> } else if ( document.getElementById('content')
> && document.getElementById( 'article' ) ) {
> // Non-Monobook but still recognizable (old-style)
> document.getElementById( 'article').insertBefore(
> messageDiv,
> document.getElementById( 'article' ).firstChild
> );
> }
>
> That's of course ugly enough. I think the best way would be to change the
> "Monobook, presumably" way to always insert the message div right before the
> #top element. Or better yet, do that and change all skins so that they *have*
> a
> #top element (which would be useful in any case) and remove the skin branching
> from wikibits.js.
>
Fixed this logic to do proper skin detection in r52821.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 19546] Vector skin does not support jsMsg() javascript function
https://bugzilla.wikimedia.org/show_bug.cgi?id=19546
Amalthea changed:
What|Removed |Added
CC||amalthea.wikime...@googlemai
||l.com
--- Comment #1 from Amalthea 2009-07-06
11:48:40 UTC ---
That's how Modern does it. Some other skins like Monobook created the div
dynamically, using the following code from wikiBits:
if ( document.getElementById( 'column-content' )
&& document.getElementById( 'content' ) ) {
// MonoBook, presumably
document.getElementById( 'content' ).insertBefore(
messageDiv,
document.getElementById( 'content' ).firstChild
);
} else if ( document.getElementById('content')
&& document.getElementById( 'article' ) ) {
// Non-Monobook but still recognizable (old-style)
document.getElementById( 'article').insertBefore(
messageDiv,
document.getElementById( 'article' ).firstChild
);
}
That's of course ugly enough. I think the best way would be to change the
"Monobook, presumably" way to always insert the message div right before the
#top element. Or better yet, do that and change all skins so that they *have* a
#top element (which would be useful in any case) and remove the skin branching
from wikibits.js.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
