[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-03-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Conrad Irwin conrad.ir...@gmail.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #10 from Conrad Irwin conrad.ir...@gmail.com 2010-03-16 17:55:09 
UTC ---
Sorry, this particular change was not reverted by Tim, and is in 1.16beta.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-02-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Conrad Irwin conrad.ir...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #9 from Conrad Irwin conrad.ir...@gmail.com 2010-02-19 11:55:42 
UTC ---
Reverted by Tim in r62689. Branched to
http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/pathpath=%2Fbranches%2Fconrad

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Stewart Gordon s...@iname.com changed:

   What|Removed |Added

 CC||s...@iname.com

--- Comment #8 from Stewart Gordon s...@iname.com 2010-02-10 15:05:13 UTC ---
*** Bug 11670 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Conrad Irwin conrad.ir...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #7 from Conrad Irwin conrad.ir...@gmail.com 2010-01-30 12:10:33 
UTC ---
I applied a patch that adds safesubst: in r61710.

The syntax was retained as alternative suggestions are (to my mind) no more
clear in purpose, and in the case of {{subst}} (above) or nosubst,
substonly bug 4484, have their own problems. Alternative names for the prefix
trysubst:, subst-if-substed: are not noticably improvements.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #6 from Conrad Irwin conrad.ir...@gmail.com 2010-01-29 22:37:01 
UTC ---
Created an attachment (id=7050)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7050)
A for interest patch implementing {{subst}}

This is an alternative solution, instead of having subst: and safesubst:, we
have subst: and {{subst}}. 

{{subst}} is a magic word that is automatically substituted (i.e.
{{subst:subst}} == {{subst}}) and which returns subst: during the PST and 
thereafter. The `problem` with this is that it feels too magic; I don't
expect things to substitute themselves unless they are prefixed by subst:
(obviously if the patch were changed to require {{subst:subst}} to be used
intstead of {{subst}}, the magic happens in the other direction). - maybe
this isn't so much of a problem?

includeonlysubst}}#if:{{subst}}||Please substitute this
template}}/includeonly

may be clearer than

includeonly{{safesubst:#if:{{subst:ns:0}}||Please substitute this template}}
/includeonly

In the examples above, safesubst: may be replaced directly by {{subst}} and
preserve the intended meaning; however I feel sticking to an alternative prefix
is more consistent.

(Sorry Voyagerfan, I'll just let it lie)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #1 from Conrad Irwin conrad.ir...@gmail.com 2010-01-28 14:49:22 
UTC ---
Created an attachment (id=7043)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7043)
A patch to provide this

I have attached a patch which implements the proposed change by adding another
special-cased magic word to Parser::braceSubstitution.

There is some thought on #mediawiki that instead of hacking it in like this, a
more general framework should allow for any magic word to take specific action
at this point in the parse. The process by which this might be done, and the
concrete benefits of such an approach are not immediately obvious to me.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Conrad Irwin conrad.ir...@gmail.com changed:

   What|Removed |Added

   Keywords||patch

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #2 from Conrad Irwin conrad.ir...@gmail.com 2010-01-28 15:20:19 
UTC ---
Created an attachment (id=7044)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7044)
Same as previous patch with subst-if-substed: instead of safesubst:

This patch incorporates the suggestion that subst-if-substed: it a better
prefix than safesubst:. I have no opinion on which is better, it would likely
be more consistent to chose a name that doesn't quite mean anything :).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Danny B. dann...@email.cz changed:

   What|Removed |Added

 CC||dann...@email.cz

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #3 from Voyagerfan5761 mediaw...@technobabbl.es 2010-01-28 
19:28:18 UTC ---
(In reply to comment #1)
 Created an attachment (id=7043)
 -- (https://bugzilla.wikimedia.org/attachment.cgi?id=7043) [details]
 A patch to provide this
 
 I have attached a patch which implements the proposed change by adding another
 special-cased magic word to Parser::braceSubstitution.
 
 There is some thought on #mediawiki that instead of hacking it in like this, a
 more general framework should allow for any magic word to take specific action
 at this point in the parse. The process by which this might be done, and the
 concrete benefits of such an approach are not immediately obvious to me.

Adding a hook at this point in the parse would be similar to WordPress'
shortcode system, the way I see it. That system has proven to be useful for
many, many plugins and I'm sure MediaWiki extension developers would find such
a hook useful, too.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #4 from Conrad Irwin conrad.ir...@gmail.com 2010-01-28 20:16:52 
UTC ---
(In reply to comment #3)
 
 Adding a hook at this point in the parse would be similar to WordPress'
 shortcode system, the way I see it. That system has proven to be useful for
 many, many plugins and I'm sure MediaWiki extension developers would find such
 a hook useful, too.

As a feature requst, I think this belongs in a separate bug. The shortcode
system looks more like normal tag extensions/parser functions/templates to me,
which people can {{subst:#tag: if they wish.

At the moment the five transclusion modifiers (subst:, safesubst:, msg:,
msgnw:, raw:), are fairly orthogonal, though it would not be impossible to
create a new MagicWordArray to handle them all.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

--- Comment #5 from Voyagerfan5761 mediaw...@technobabbl.es 2010-01-29 
03:21:49 UTC ---
(In reply to comment #4)
 As a feature requst, I think this belongs in a separate bug. The shortcode
 system looks more like normal tag extensions/parser functions/templates to me,
 which people can {{subst:#tag: if they wish.
 
 At the moment the five transclusion modifiers (subst:, safesubst:, msg:,
 msgnw:, raw:), are fairly orthogonal, though it would not be impossible to
 create a new MagicWordArray to handle them all.

I think I've been misunderstood. I was reacting to the suggestion of a more
general framework for any magic word to hook in at this point in the parse and
giving what I thought was a good example implementation. Obviously the
shortcodes themselves are more like tag extensions or templates, but the
concept of the parser acting on hooks registered by different magic words is
what I was presenting. Hopefully that clears it up. I'm not entering a feature
request. :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 22297] There should be syntax for substitution that doesn't break normal transclusion

2010-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=22297

Voyagerfan5761 mediaw...@technobabbl.es changed:

   What|Removed |Added

 CC||mediaw...@technobabbl.es

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l