[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #17 from Subfader subfa...@gmail.com 2011-07-17 14:27:11 UTC ---
Started all over again with a fresh dump and update.php worked fine this time.
Sorry for all the confusion. You guys rock.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #16 from Bawolff bawolff...@gmail.com 2011-07-10 20:58:43 UTC ---
Hmm, the command line update.php script should have updated the sorting. The
web upgrader might not have (bug 29574)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #11 from Subfader subfa...@gmail.com 2011-07-09 22:37:03 UTC ---
Thanks for adding the hook. I downloaded the latest dump (r91785, including
GetDefaultSortkey() in Title.php), added

$wgHooks['GetDefaultSortkey'][] = 'wfFixSortorder';
function wfFixSortorder( $title, $sortkey ) {
 $sortkey = $title-getPrefixedText();
 return true;
}

to LocalSetting.php and ran updateCollation.php --force.

But I can't get it working. Pages in the Chart namespace still sort under C,
even after editing them (to be sure sorting is updated).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #12 from Bawolff bawolff...@gmail.com 2011-07-09 22:41:17 UTC ---
But I can't get it working. Pages in the Chart namespace still sort under C,
even after editing them (to be sure sorting is updated).

I'm confused, I thought that's what you wanted (Things to sort under
{{FULLPAGENAME}} not {{PAGENAME}})?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #13 from Subfader subfa...@gmail.com 2011-07-09 22:48:02 UTC ---
Hmh, no? {{FULLPAGENAME}} is the forced sorting now since
$wgCategoryPrefixedDefaultSortkey was removed.

But the solution is easy :) $sortkey = $title-getText();

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #14 from Bawolff bawolff...@gmail.com 2011-07-09 22:52:45 UTC ---
(In reply to comment #13)
 Hmh, no? {{FULLPAGENAME}} is the forced sorting now since
 $wgCategoryPrefixedDefaultSortkey was removed.
 
 But the solution is easy :) $sortkey = $title-getText();

No. $wgCategoryPrefixedDefaultSortkey was removed, and now behaves as if it was
always false. Everything behaves as if its sorted under {{PAGENAME}} since 1.17

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #15 from Subfader subfa...@gmail.com 2011-07-09 23:24:17 UTC ---
Oh noes, you're right. It does sort this way. I guess the problem in the first
place was that no maintenance script I tried updated the sorting.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org

--- Comment #8 from Mark A. Hershberger m...@everybody.org 2011-07-05 
14:12:30 UTC ---
(In reply to comment #7)
 I propose adding a hook to Title::getCategorySortkey so that people can
 override the $unprefixed = $this-getText() line. This would address both this
 and bug 22911. The only downside to this is that whenever changing the
 algorithm used by the hook or enabling/disabling one would have to run
 updateCollation.php --force . Any thoughts?

If it would provide Subfader a way to resolve this, I'm in favor. :)

Make it so?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |Low

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #9 from Aryeh Gregor simetrical+wikib...@gmail.com 2011-07-05 
22:18:31 UTC ---
(In reply to comment #5)
 You're not playing fair here. I gace reasons above. My article links using
 icons globally and 2 columns instead of 3 are no category based hacks and not
 related to this bug report...

They are related.  Your categories aren't broken up into sections according to
first letter.  If they were, then you'd have one section per category for
categories that consist only of non-main space pages.  This is as I explained.

For instance, look at this category:

http://en.wikipedia.org/wiki/Category:User_he-1

It consists entirely of User: pages.  It's automatically split up into sections
based on the first letter of the page name.  Formerly, unless users overrode
the sortkey on every single page, every page in the category would be under U
for User:.  This is bad, and people were forced to work around it by manually
overriding millions of sortkeys.

This isn't a problem for you, but only because you hacked the software to not
show the letters for the sections.  If you hadn't hacked the software, the
change would have benefited you too.

 Really? No way I will do this. That's not a solution.
 I have over 16,000 categories and I won't{{#defaultsort:{{PAGENAME to them
 and tell my users to add this for no reason in the future.

I'm telling you that when it *didn't* work this way, everyone on Wikipedia
*did* have to add {{#defaultsort:}} or similar to millions of pages.  That's
why I changed it.  We're not going to change it back and cause more work for
everyone on Wikipedia to save work for you.  We also shouldn't add a preference
for something where the only reason you'd want to change it is if you hacked
MediaWiki, IMO.

 Instead, I now ask where the advantage is in sorting the namespace letter?

I already told you in comment #4, but maybe my explanation here is clearer.

(In reply to comment #7)
 I propose adding a hook to Title::getCategorySortkey so that people can
 override the $unprefixed = $this-getText() line. This would address both this
 and bug 22911. The only downside to this is that whenever changing the
 algorithm used by the hook or enabling/disabling one would have to run
 updateCollation.php --force . Any thoughts?

That sounds reasonable to me.  The Wikibooks use-case makes sense, and this
seems like a good way to address it.  Subfader could also use the hook if he
wanted.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #10 from Bawolff bawolff...@gmail.com 2011-07-06 00:53:41 UTC ---
Added a hook in r91510 (MW 1.19)

Subfader: To change the sort order to do what you want, add something like the
following to the bottom of LocalSettings.php:



function wfFixSortorder( $title, $sortkey ) {
 $sortkey = $title-getPrefixedText();
 return true;
}
$wgHooks['GetDefaultSortkey'][] = 'wfFixSortorder';

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #6 from Bawolff bawolff...@gmail.com 2011-07-04 15:53:13 UTC ---
related (borderline dupe): bug 22911

I tend to agree that given the way we normally display categories, sorting by
default under {{PAGENAME}} (not {{FULLPAGENAME}}) makes sense.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #7 from Bawolff bawolff...@gmail.com 2011-07-05 01:44:20 UTC ---
I propose adding a hook to Title::getCategorySortkey so that people can
override the $unprefixed = $this-getText() line. This would address both this
and bug 22911. The only downside to this is that whenever changing the
algorithm used by the hook or enabling/disabling one would have to run
updateCollation.php --force . Any thoughts?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Aryeh Gregor simetrical+wikib...@gmail.com changed:

   What|Removed |Added

 CC||Simetrical+wikibugs@gmail.c
   ||om

--- Comment #2 from Aryeh Gregor simetrical+wikib...@gmail.com 2011-07-03 
17:28:48 UTC ---
I don't understand the problem.  Can you give an example of a specific category
that exhibits the issue, point out what you don't like about it, and explain
why you don't like it?

Was some wiki using custom namespaces as a hack to get certain pages to sort
after all other pages?  If so, what were the exact circumstances?  What wiki,
what pages did it want to sort after all other pages, why did it want them to
sort after all other pages, and what namespace name did it pick to allow it? 
Why isn't {{#defaultsort:{{FULLPAGENAME a good enough solution?

It's to be expected that some category-related hacks will break when the
category system is reformed.  We also had people who got annoyed when sorting
became case-insensitive, because that messed up their use of Greek lowercase
letters to prefix certain sortkeys on English wikis.  The answer here isn't
that we can't ever change the category system, it's that people who are
controlling sort order by relying on hacks will have to update the hacks once
in a blue moon when we change the system.  We're not going to compromise
quality of the default behavior to accommodate a small quantity of existing
content that could be ported to work with the new system with a little effort.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #3 from Subfader subfa...@gmail.com 2011-07-03 18:30:36 UTC ---
 Can you give an example of a specific category
that exhibits the issue, point out what you don't like about it, and explain
why you don't like it?
http://www.mixesdb.com/db17/index.php/Category:Dave_Clarke (I will
password-protect the directory again after a reply)
What I don't like: In the pages section you wouldn't expect pages in the
Chart namespace to be listed. Instead, they should also sort by page title. 
Why I don't like it: Because users expect them to sort by title as well? Don't
make me think! is one of the most important rules for usability.
There might be worse examples on commons or WP, but I dunno the diversity of
categories there. I understand that on WP content pages in a category may be
mostly from teh same NS, but as you can se eon my example, there are other
wikis too besides the holy WP.
What I don't like most about all this is that there is no option anymore.

Why isn't {{#defaultsort:{{FULLPAGENAME a good enough solution?
Because I want this behaviour by default for all cats.
Previously there was $wgCategoryPrefixedDefaultSortkey, no I have no more
option to switch the behaviour.

I understand the argument about compability for hacks. But I'm not updating
hacks here, you force me to create one, because the option was removed.
If this behaviour is needed for the performance you got my amen, cos categories
play a major role in my wiki.

Private solution atm: I use a manual list of regex replacements in the sortkey
called in convertCategoryKey() in languages/Language.php so I remove
^CustomNS from the beginning of all cl_sortkeys (as well as other useful ones
like ^The\s etc.).
It works quite well (except maintenance/refreshLinks.php not working here),
maybe it's worth to be implented?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

Subfader subfa...@gmail.com changed:

   What|Removed |Added

Summary|$wgCategoryPrefixedDefaultS |Cannot sort pages of
   |ortkey should be re-added   |different namespaces
   |(allow sorting with |properly on category pages
   |namespace prefix by |
   |default)|

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 29680] Cannot sort pages of different namespaces properly on category pages

2011-07-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=29680

--- Comment #1 from Subfader subfa...@gmail.com 2011-07-02 13:01:38 UTC ---
The main problem is that on category pages with more 200 articles, cutom
namespace pages are listed after all articles, which is the same old problem
again which 1.17 actually wanted to solve with its improved category.

* A Brand New Article
* CustomNS:A Custom NS Page
* Another Article
* CustomNS:Some Different Article
* Some Other Article
* Test Article

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l