[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #7 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-11-02 06:24:13 UTC --- Added warning message in r101585 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 Reedy s...@reedyboy.net changed: What|Removed |Added Priority|Unprioritized |High -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-10-26 23:38:57 UTC --- So far for the build in PHP mail validation function... wtf... The email address field in the signup form should default to your set email address if you have any. Just had a look, and this appears to work as it should. You are right that changing the address should cause it to be in non-validated state, this is something I overlooked. However, the change of the user email field is deliberate, and was discussed before creating the extension. The idea here is that it makes little sense to have separate storage for the email address of a user, as it's really one piece of info, hence the usage of the user_email field in the user table. The field in the contest extension is there to keep a copy that cannot be changed after contest end. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 Jeroen De Dauw jeroen_ded...@yahoo.com changed: What|Removed |Added AssignedTo|wikibugs-l@lists.wikimedia. |jeroen_ded...@yahoo.com |org | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 --- Comment #2 from MZMcBride b...@mzmcbride.com 2011-10-26 23:49:55 UTC --- (In reply to comment #1) So far for the build in PHP mail validation function... wtf... I imagine it's accounting for something like... user@localhost. The email address field in the signup form should default to your set email address if you have any. Just had a look, and this appears to work as it should. Yes, it does. But... You are right that changing the address should cause it to be in non-validated state, this is something I overlooked. Much more importantly, if it's going to change user.user_email to a new value, it should first confirm this with the user. Your e-mail address is currently set to f...@bar.com. You've indicated that your e-mail address is b...@bang.com. Would you like to update your Wikimedia account? Or something. However, the change of the user email field is deliberate, and was discussed before creating the extension. Changing the e-mail address is fine. _Silently_ changing it is not. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 --- Comment #3 from Brion Vibber br...@wikimedia.org 2011-10-26 23:53:58 UTC --- wtf yes this should definitely not be changing your user account settings without warning... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 --- Comment #4 from Jeroen De Dauw jeroen_ded...@yahoo.com 2011-10-27 00:36:19 UTC --- Right. Will add a warning then. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 p858snake p858sn...@gmail.com changed: What|Removed |Added CC||p858sn...@gmail.com --- Comment #5 from p858snake p858sn...@gmail.com 2011-10-27 01:43:12 UTC --- (In reply to comment #0) I was playing around with the Contest extension and used @f as my e-mail address. The extension accepted this e-mail address (which ought to be the subject of another bug), That is a perfectly valid address per the RFC from my understanding... This should not be changed. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 31965] Contest extension silently screws with user e-mail address
https://bugzilla.wikimedia.org/show_bug.cgi?id=31965 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com --- Comment #6 from Daniel Friesen mediawiki-b...@nadir-seen-fire.com 2011-10-27 02:27:09 UTC --- (In reply to comment #5) (In reply to comment #0) I was playing around with the Contest extension and used @f as my e-mail address. The extension accepted this e-mail address (which ought to be the subject of another bug), That is a perfectly valid address per the RFC from my understanding... This should not be changed. Cept unless the MediaWiki install has a local hosts modification or is running in an intranet with custom hosts there's no way MediaWiki can send to that address. It would probably be useful to validate the tlds used in e-mail addresses to ensure the domain in the e-mail is valid for use. Of course with a config option to disable it for intranets and whatnot. Mozilla's Public Suffix List project would be useful for this: http://publicsuffix.org/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
