[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-11-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

--- Comment #6 from Anja Jentzsch  2012-11-29 
12:37:49 UTC ---
Verified in Wikidata demo time for sprint 7

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-11-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Anja Jentzsch  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

--- Comment #5 from denny vrandecic  2012-06-26 
09:41:45 UTC ---
Added item #37958 for improving the design/UX issues.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #4 from Daniel Kinzler  2012-06-26 
09:23:02 UTC ---
fixed now, though design/UX issues remain.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Bug 37496 depends on bug 37747, which changed state.

Bug 37747 Summary: Adjust diff headers in Wikibase\DifferenceEngine
https://bugzilla.wikimedia.org/show_bug.cgi?id=37747

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Bug 37496 depends on bug 37680, which changed state.

Bug 37680 Summary: ItemDiff does not work for label and description
https://bugzilla.wikimedia.org/show_bug.cgi?id=37680

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Depends on||37747

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #3 from Daniel Kinzler  2012-06-21 
10:36:14 UTC ---
revision headers still need to be fixed

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #2 from Daniel Kinzler  2012-06-19 
13:43:32 UTC ---
https://gerrit.wikimedia.org/r/11865 was merged

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Depends on||37680

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 37496] Display a diff between two revisions of a Wikidata item

2012-06-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=37496

Daniel Kinzler  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||daniel.kinz...@wikimedia.de
 AssignedTo|wikidata-bugs@lists.wikimed |daniel.kinz...@wikimedia.de
   |ia.org  |

--- Comment #1 from Daniel Kinzler  2012-06-18 
15:14:52 UTC ---
Implementation is in gerrit for review: https://gerrit.wikimedia.org/r/11865

I have implemented this based on the normal wikitext diff, using the same
side-by-side layout and recycling the CSS. As a context (instead of the line
number), the path to the changed value is shown, using the keys from our
internal JSON representation. That sucks, of course.

This implementation doesn't work correctly at the moment, because it depends on
some other things to be fixed, most importantly bug 37680, but also bug 37691
and bug 37683.

Anyway, some actual UI design seems in Order here. Some thoughts:

* side-by-side seems useless.
* instead, show added, removed and modified properties in a single column
* for modified properties, show a word-based diff
* it may be nice to just show the (old) item with highlighted modifications
(inline diff)
* diffs will often be for a single atomic change. It could be useful to make
this a special case.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l