[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

Krenair kren...@gmail.com changed:

   What|Removed |Added

 CC||kren...@gmail.com

--- Comment #1 from Krenair kren...@gmail.com 2012-07-11 15:49:02 UTC ---
For most languages arr.join(', ') will work.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

--- Comment #2 from Jarry1250 jarry1...@gmail.com 2012-07-11 16:17:25 UTC ---
(In reply to comment #1)
 For most languages arr.join(', ') will work.

Yes, but which? :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

--- Comment #3 from Krenair kren...@gmail.com 2012-07-11 16:19:41 UTC ---
MessagesAn.php:'comma-separator' = ',#32;',
MessagesAr.php:'comma-separator' = '،#32;',
MessagesArz.php:'comma-separator' = '،#32;',
MessagesCkb.php:'comma-separator' = '،#32;',
MessagesDiq.php:'comma-separator' = ',#32;',
MessagesEn.php:'comma-separator' = ',#32;', # only translate this message
to other languages if you have to change it
MessagesEs.php:'comma-separator' = ',#32;',
MessagesFa.php:'comma-separator' = '،#32;',
MessagesGan_hans.php:'comma-separator' = '、',
MessagesGan_hant.php:'comma-separator' = '、',
MessagesJa.php:'comma-separator' = '、',
MessagesKa.php:'comma-separator' = ',#32;',
MessagesKk_arab.php:'comma-separator' = '،#32;',
MessagesLzh.php:'comma-separator' = '、',
MessagesNe.php:'comma-separator' = ',#32;',
MessagesQqq.php:'comma-separator' = '{{optional}}',
MessagesRoa_tara.php:'comma-separator' = ',#32;',
MessagesSc.php:'comma-separator' = ',#32;',
MessagesSr_ec.php:'comma-separator' = ',#32;',
MessagesSr_el.php:'comma-separator' = ',#32;',
MessagesUk.php:'comma-separator' = ',#32;',
MessagesWuu.php:'comma-separator' = '、',
MessagesYue.php:'comma-separator' = '、',
MessagesZh_hans.php:'comma-separator' = '、',
MessagesZh_hant.php:'comma-separator' = '、',

Looks like it won't work for Gan_hans, Gan_hant, Ja, Lzh, Wuu, Yue, Zh_hans or
Zh_hant.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

--- Comment #4 from Jarry1250 jarry1...@gmail.com 2012-07-11 17:58:52 UTC ---
Do the JavaScript bits duplicate PHP descriptions though, or load on top of
them?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #5 from Krinkle krinklem...@gmail.com 2012-07-11 20:06:32 UTC ---
(In reply to comment #4)
 Do the JavaScript bits duplicate PHP descriptions though, or load on top of
 them?

There are no javascript bits yet, hence this request.

Once implemented they should use the same messages.

Come to think of it, this logic is not in the Language class (despite the fact
that we use it as Language:: commaList, it actually just uses Message.

So in ResourceLoader:

* Add message key comma-separator to your module definition
* Use array.join( mw.msg( 'comma-separator' ) );

So although it can be simplified, its really trivial to just do yourself.

And in case you're wondering if this is inconsistent with the server side, it
isn't, because the server side implementation of Language::commaLIst is
essentially the same:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=languages/Language.php;h=3ee959eb7a8314d7192acf32e17139994aa5d03f;hb=905d83e3ad0bc3e85438349537ff80dd999e7fc3#l3016

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38307] JavaScript's mw.language should provide a parallel to Language-commaList( $arr );

2012-07-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38307

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |Lowest
Version|1.19|unspecified

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l