[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2012-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

James Forrester  changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |roan.katt...@gmail.com
   |org |
   Severity|normal  |minor

--- Comment #1 from James Forrester  2012-07-31 
21:39:35 UTC ---
Of course, I meant
https://translatewiki.net/wiki/MediaWiki:Titleblacklist-forbidden-new-account/en
rather than the enwiki issue. :-)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2012-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Roan Kattouw  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||roan.katt...@gmail.com
 Resolution||FIXED

--- Comment #2 from Roan Kattouw  2012-07-31 21:57:18 
UTC ---
https://gerrit.wikimedia.org/r/17132 (already deployed as a live hack) seems to
fix this.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2012-07-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Roan Kattouw  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #3 from Roan Kattouw  2012-07-31 22:16:52 
UTC ---
Not actually fixed.

This is because CentralAuth uses the same hook function for AbortNewAccount and
AbortAutoAccount. This is a problem because AbortNewAccount expects the
returned error to be an HTML string, while AbortAutoAccount expects it to be a
message key. The hook outputs an HTML string to both, which causes the latter
to interpret the HTML string as a message key, which obviously fails terribly.
What's even worse is that docs/hooks.txt claims that both hooks take a message
key. Ugh.

The message key approach is inflexible, though, because TitleBlacklist needs to
pass parameters to the message (like the rule that triggered the block), so I
think a reasonable way to fix this would be to allow the hook to return either
a string or a Message object.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-08-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Matthew Flaschen  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=44718

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-08-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Tyler Romeo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||tylerro...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #12 from Tyler Romeo  ---


*** This bug has been marked as a duplicate of bug 44718 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #8 from Matthew Flaschen  ---
(In reply to comment #3)
> The message key approach is inflexible, though, because TitleBlacklist needs
> to pass parameters to the message (like the rule that triggered the block), 
> so I
> think a reasonable way to fix this would be to allow the hook to return
> either a string or a Message object.

And if it returns a string, it will be treated as a message key?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #9 from Gerrit Notification Bot  ---
Related URL: https://gerrit.wikimedia.org/r/64645 (Gerrit Change
I0d728a9645644fe95a7a7c680f568b8206e202a4)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #10 from MZMcBride  ---
(In reply to comment #9)
> Related URL: https://gerrit.wikimedia.org/r/64645 (Gerrit Change
> I0d728a9645644fe95a7a7c680f568b8206e202a4)

This is not accessible for me. Perhaps it's marked as a draft?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #11 from Steven Walling  ---
(In reply to comment #10)
> (In reply to comment #9)
> > Related URL: https://gerrit.wikimedia.org/r/64645 (Gerrit Change
> > I0d728a9645644fe95a7a7c680f568b8206e202a4)
> 
> This is not accessible for me. Perhaps it's marked as a draft?

Yeah it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2012-12-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Andre Klapper  changed:

   What|Removed |Added

 CC||mj94w...@gmail.com

--- Comment #4 from Andre Klapper  ---
*** Bug 44120 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Andre Klapper  changed:

   What|Removed |Added

 CC||morme...@centrum.cz

--- Comment #5 from Andre Klapper  ---
*** Bug 42228 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-01-18 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Andre Klapper  changed:

   What|Removed |Added

 Blocks||38638

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-01-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Opraco  changed:

   What|Removed |Added

 CC||opr...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Robin Pepermans (SPQRobin)  changed:

   What|Removed |Added

 CC||robinp.1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #6 from Matthew Bowker  ---
Created attachment 11943
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=11943&action=edit
Image of the error on the English Wikipedia

Just experienced this on the English Wikipedia.  Screenshot attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

Matthew Bowker  changed:

   What|Removed |Added

 CC||matthewrbowker.w...@me.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2013-05-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

James Forrester  changed:

   What|Removed |Added

   Priority|Normal  |High
 Status|REOPENED|NEW
 CC||jforres...@wikimedia.org
   Assignee|roan.katt...@gmail.com  |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #7 from James Forrester  ---
Not actually being worked on by Roan; de-assigning. Do we need to create a
separate bug for the need for core to be altered?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38894] Bad escaping of characters in Titleblacklist-forbidden-new-account when triggered

2014-03-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38894

--- Comment #13 from Gerrit Notification Bot  ---
Change 64645 abandoned by Krinkle:
(Bug 38894) Abort{New,Auto}Account: error may be Message or HTML.

Reason:
Abandoning for now.

https://gerrit.wikimedia.org/r/64645

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l