[Bug 42715] Duplicate translation notifications are generated

2013-12-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Tilman Bayer tba...@wikimedia.org changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=57896

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-07-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #34 from Andre Klapper aklap...@wikimedia.org ---
Meh. Might be worth a new bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #33 from Tilman Bayer tba...@wikimedia.org ---
Duplicate notifications were just sent out again (both by email and on talk
pages), and on MEta, Translation Notification Bot was briefly blocked because
of this. 
https://meta.wikimedia.org/w/index.php?diff=5654816oldid=5654815

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-04-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #32 from Nemo federicol...@tiscali.it ---
This happened again on March 14, with first notification sent after all
Wikipedias were switched to 1.21wmf11.

https://it.wikipedia.org/w/index.php?title=Discussioni_utente:Davidbottandiff=prevoldid=57453634
https://it.wikipedia.org/w/index.php?title=Discussioni_utente:Davidbottandiff=prevoldid=57453811

I don't remember if it was expected that the update would bring some breakage;
but if it was, apparently the translation administrators didn't know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Tilman Bayer tba...@wikimedia.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #24 from Tilman Bayer tba...@wikimedia.org ---
Duplicate talk page notification messages have just occurred again. Examples: 

https://meta.wikimedia.org/w/index.php?diff=prevoldid=5240374

https://es.wikipedia.org/w/index.php?diff=prevoldid=63778964

The second round of notifications occurred more than 13 hours after the first.
There is no duplicate entry in the notification log
(https://meta.wikimedia.org/w/index.php?title=Special%3ALogtype=notifytranslators
), and fortunately email notifications do not seem to have been duplicated (at
least I haven't received a second one).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #25 from Aaron Schulz aschulz4...@gmail.com ---
Last time the bug was TranslationNotificationJob not overriding the parent
constructor properly. This time it is the fact that
TranslationNotificationJob::run() doesn't return true/false like the docs say
to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

   Keywords||patch-in-gerrit

--- Comment #26 from Siebrand s.mazel...@xs4all.nl ---
(In reply to comment #25)
 Last time the bug was TranslationNotificationJob not overriding the parent
 constructor properly. This time it is the fact that
 TranslationNotificationJob::run() doesn't return true/false like the docs say
 to.

Gerrit 48852 should fix this. Please review asap. It's almost midnight here in
India. Needs to be backported and deployed, too.

Niklas has already deleted the failed jobs, but when TN is used again, the
issue may occur again...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #27 from Sumana Harihareswara suma...@wikimedia.org ---
Gerrit change #48852 is now merged but is there a backport?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #28 from Niklas Laxström niklas.laxst...@gmail.com ---
48852 is for Translate and it does not need to be backported.
48848 is for TN and it has been backported and deployed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Sumana Harihareswara suma...@wikimedia.org changed:

   What|Removed |Added

 CC||suma...@wikimedia.org

--- Comment #29 from Sumana Harihareswara suma...@wikimedia.org ---
Thanks all. Marking as closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #30 from Andre Klapper aklap...@wikimedia.org ---
Thanks, and please reopen if there are still issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=44960,
   ||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=44962,
   ||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=44963

--- Comment #31 from Siebrand s.mazel...@xs4all.nl ---
Timeline:

16:09 UTC Reported by Tilman in comment 24
18:09 UTC Report noticed by Siebrand (22:39 IST local time)
19:03 UTC First patch set with fix, Gerrit 48852
19:07 UTC Second patch set based on Siebrand's review
19:17 UTC Aaron reviews and approves
19:18 UTC Patch merged
19:24 UTC Patch backported to 1.21wmf9 by Aaron, Gerrit 48853
19:26 UTC Patch merged in 1.21wmf9
19:30 UTC Patch deployed on Wikimedia wikis running 1.21wmf9
(http://hexm.de/victory )

Based on this issue, I have also checked the return values of other Job::run()
functions in the 188 extensions I have on my local machine. Luckily, jobs
aren't used all over the place, so I was only able to locate 3 extensions with
bugs, next to Translate which was already fixed by Niklas in Gerrit 48852.

I reported bug 44960 (AFTv5), bug 44962 (Wikidata) and bug 44963 (TMH).

To minimise damage from incorrect jobs, Aaron and I have also made changes to
job queue:
* Gerrit 48860 treats a non-boolean return value of Job::run() as true
* Gerrit 48858 makes sure MediaWiki starts yelling if a job's run() method does
not return a boolean.

1h11m as time to fix from issue noticed to deployment, while the report was
noticed at 22:39 IST isn't bad at all, I think. Thanks to all involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #20 from Nemo federicol...@tiscali.it ---
(In reply to comment #18)
 (In reply to comment #17)
  Is there a ticket against MediaWiki extensions  TranslationNotifications
  to
  follow yet?
 
 The situation is still being analysed.

https://wikitech.wikimedia.org/view/TranslationNotifications_issues_2012-12#Timeline
was published.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #21 from Antoine hashar Musso has...@free.fr ---
Permanent link:

https://wikitech.wikimedia.org/index.php?title=TranslationNotifications_issues_2012-12oldid=54502#Timeline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #22 from Tilman Bayer tba...@wikimedia.org ---
(In reply to comment #20)
 (In reply to comment #18)
  (In reply to comment #17)
   Is there a ticket against MediaWiki extensions  
   TranslationNotifications
   to
   follow yet?
  
  The situation is still being analysed.
 
 https://wikitech.wikimedia.org/view/TranslationNotifications_issues_2012-
 12#Timeline
 was published.

Since that report is not on a generally editable wiki, let me note here instead
that while it gives the impression that the first duplicate notifications were
observed at the end of November, this has in fact happened at least twice
before, in July and August:

https://meta.wikimedia.org/wiki/Talk:Translation_requests#Double_notification

Examples: https://meta.wikimedia.org/w/index.php?diff=3964877oldid=3964809 ,
https://meta.wikimedia.org/w/index.php?diff=4049992oldid=4049949


Back then, the time between the redundant notifications was much shorter, so
the reason may have been a different one.

Thanks to everyone who worked to resolve the present bug! I have a small
notification (Portuguese only) to send out soon, which should make a good test
case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #23 from Nemo federicol...@tiscali.it ---
(In reply to comment #22)
 Back then, the time between the redundant notifications was much shorter, so
 the reason may have been a different one.

Yes, it was definitely another problem; from what I remember, it was also not
systematic but related to some ephemeral conditions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #17 from Andre Klapper aklap...@wikimedia.org ---
(In reply to comment #16)
  ack() fails for some reason
 I've made https://gerrit.wikimedia.org/r/#/c/37372/2 to work around 
 this problem, but the extension should be fixed.

Is there a ticket against MediaWiki extensions  TranslationNotifications to
follow yet?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #18 from Nemo federicol...@tiscali.it ---
(In reply to comment #17)
 Is there a ticket against MediaWiki extensions  TranslationNotifications
 to
 follow yet?

The situation is still being analysed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #19 from Nemo federicol...@tiscali.it ---
Gerrit change 37459 was merged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Romaine romaine_w...@yahoo.com changed:

   What|Removed |Added

   Priority|Normal  |Highest

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

   Priority|Highest |High

--- Comment #6 from Nemo federicol...@tiscali.it ---
This is not highest priority. There's another bug with higher priority in this
component which is more severe than this (and Highest now requires an
assignee, but Aaron is not working on this bug AFAIK).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #7 from Siebrand s.mazel...@xs4all.nl ---
Here's an update that Joseph made on translators-l: The extension still is
sending out repeating notifications a day after the last request. As as a
result we have blocked my meta staff account and locked out the translation
notification bot that delivers local notifications to you guys in hope that
this will at least stem more duplicates

Not sure how much this helps, as the delivery process is active on all
Wikimedia wikis, not only on Meta-Wiki.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

justincheng12...@gmail.com changed:

   What|Removed |Added

 CC||justincheng12...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #8 from Nemo federicol...@tiscali.it ---
(In reply to comment #7)
 Not sure how much this helps, as the delivery process is active on all
 Wikimedia wikis, not only on Meta-Wiki.

It's a lock, not a block, for the bot; Jhs said it should work to prevent
edits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #9 from Jon Harald Søby jhs...@gmail.com ---
(In reply to comment #8)
 (In reply to comment #7)
  Not sure how much this helps, as the delivery process is active on all
  Wikimedia wikis, not only on Meta-Wiki.
 
 It's a lock, not a block, for the bot; Jhs said it should work to prevent
 edits.

Yeah, if I understand the code from line 62 correcly here [1], the extension
checks if the bot is logged in before posting, and returns an error if it can't
log in. Since locking (which is global) logs the user out and prevents logging
in, I'm pretty sure this will fix the problem with multiple user talk messages
at least – e-mails I don't know about, but this should fix half the problem.


[1]
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/TranslationNotifications.git;a=blob;f=TranslationNotificationJob.php;h=da900499081bdf8b57166a86499d1ddcede104e1;hb=HEAD

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #10 from Joseph Seddon jsed...@wikimedia.org ---
hasharmetawiki has 2213 translationNotificationJobs pending
hasharI get three translationNotificationJob jobs for it
hasharfrom Nov 27th, Dec 04 and Dec 01.
hashareach of them have job_attempts = 3
Seddonlooking over the edits, it seems like the job gets half done and
then stops and starts all over again. 
hasharthe jobs do end up with an error
hasharbut that is an empty error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 CC||has...@free.fr

--- Comment #11 from Antoine hashar Musso has...@free.fr ---
I have patched the notification job to always return a boolean:
https://gerrit.wikimedia.org/r/37211

runJobs.php always logged the job as being in error because the job run()
returned null.  Probably cause the new Job queue to reattempt the job run.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #12 from Siebrand s.mazel...@xs4all.nl ---
Thanks a bunch for looking into this, Antoine!

This makes me fear for the other gazillion extensions that have jobs. Is this a
regression in the job queue that must be fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #13 from Antoine hashar Musso has...@free.fr ---
I dont think the patch solve the issue though.  I am unfamiliar with the
JobQueue and how it handle deduplicate or the removal of the jobs once they are
finished.  At least Gerrit change #37211 will give let us log an error message
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Assignee|wikibugs-l@lists.wikimedia. |aschulz4...@gmail.com
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

   Priority|High|Highest
 CC||aklap...@wikimedia.org
   Severity|normal  |major

--- Comment #14 from Andre Klapper aklap...@wikimedia.org ---
I'm bumping this up as this seems to affected a lot of people whose
notification volumes suddenly increase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #15 from Aaron Schulz aschulz4...@gmail.com ---
(In reply to comment #12)
 Thanks a bunch for looking into this, Antoine!
 
 This makes me fear for the other gazillion extensions that have jobs. Is
 this a
 regression in the job queue that must be fixed?

runJobs always calls ack() even if run() returned false. The only way it won't
is if:
a) the runner dies in the middle of the job (e.g. some serious fatal or
exception)
b) ack() fails for some reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #16 from Aaron Schulz aschulz4...@gmail.com ---
(In reply to comment #15)
 (In reply to comment #12)
  Thanks a bunch for looking into this, Antoine!
  
  This makes me fear for the other gazillion extensions that have jobs. Is
  this a
  regression in the job queue that must be fixed?
 
 runJobs always calls ack() even if run() returned false. The only way it
 won't
 is if:
 a) the runner dies in the middle of the job (e.g. some serious fatal or
 exception)
 b) ack() fails for some reason

And it's (b). The translation notification job constructor is missing the $id
parameter (it should have one like all the under job classes under /job). I've
made https://gerrit.wikimedia.org/r/#/c/37372/2 to work around this problem,
but the extension should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Aaron Schulz aschulz4...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
   Severity|major   |normal

--- Comment #1 from Siebrand s.mazel...@xs4all.nl ---
Suspecting recent changes to the job queue system, as there were no recent
changes to TranslationNotifications. Will investigate in next sprint, starting
11/12, running through 27/12.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #2 from Joseph Seddon jsed...@wikimedia.org ---
https://bugzilla.wikimedia.org/show_bug.cgi?id=42614 is the bug currently
related to the job queue issues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Joseph Seddon jsed...@wikimedia.org changed:

   What|Removed |Added

 CC||jhs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Siebrand s.mazel...@xs4all.nl changed:

   What|Removed |Added

   Keywords||code-update-regression
 CC||aschulz4...@gmail.com,
   ||niklas.laxst...@gmail.com,
   ||ro...@robla.net,
   ||ro...@wikimedia.org,
   ||tstarl...@wikimedia.org

--- Comment #3 from Siebrand s.mazel...@xs4all.nl ---
The code for TranslationNotifications hasn't changed, the job queue has...

Adding keyword code-update-regression, and adding Aaron and Tim to CC,
because they reworked the job queue recently, as well as RobLa for being the
platform engineering manager.

Niklas is telling me that he doesn't want to touch job related issues anymore,
because things have gotten way too complicated, something I'm not really used
hearing from him, so something must be off there... He also refers to bug
42614.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

  Component|TranslationNotifications|JobQueue
Version|unspecified |1.21-git
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=42614
Product|MediaWiki extensions|MediaWiki
   Target Milestone|--- |1.20.x release

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

Tilman Bayer tba...@wikimedia.org changed:

   What|Removed |Added

 CC||tba...@wikimedia.org

--- Comment #4 from Tilman Bayer tba...@wikimedia.org ---
Note that this occurs not just on Meta, but also - with User:Translation
Notification Bot - on other wikis. See e.g.
https://mg.wiktionary.org/w/index.php?title=Dinika_amin%27ny_mpikambana:Jagwardir=prevoffset=2012112700limit=11action=historyuselang=en
(sending the same notification four times over the course of seven days).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 42715] Duplicate translation notifications are generated

2012-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #5 from Siebrand s.mazel...@xs4all.nl ---
(In reply to comment #4)
 Note that this occurs not just on Meta, but also - with User:Translation
 Notification Bot - on other wikis.

That's not surprising. These edits are triggered from the same code. It's a
good thing (relatively speaking :P) that everything is going wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l