[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board. Krinkle added a comment. Might be a good candidate for a "structure" test with PHPUnit. This would be similar to what we do with autoloader, config artefacts, and other generated files in core. TASK DETAIL https://phabricator.wikimedia.org/T317180 WORKBOARD https://phabricator.wikimedia.org/project/board/313/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Lmlmljs, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Marostegui, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema
Krinkle triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T317180 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Lmlmljs, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Marostegui, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317180: Auto-verify in CI the SQL files generated by Rdbms abstract schema
Krinkle renamed this task from "Consistently generate schema (change) files in Wikibase" to "Auto-verify in CI the SQL files generated by Rdbms abstract schema". Krinkle added a project: MediaWiki-Core-Tests. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T317180 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Lmlmljs, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Marostegui, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context
Krinkle closed this task as "Resolved". Krinkle assigned this task to ArthurTaylor. TASK DETAIL https://phabricator.wikimedia.org/T363797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Krinkle Cc: Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T361190: [REPO][CLIENT] Split PHPUnit test suite for wmf-quibble-vendor-mysql-php74-docker
Krinkle closed subtask T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T361190 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, Krinkle Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T363797: DifferenceEngineTest::testMapDiffPrevNext fails when run standalone in CI / Quibble context
Krinkle added a parent task: T50217: Speed up MediaWiki PHPUnit build by running integration tests in parallel. TASK DETAIL https://phabricator.wikimedia.org/T363797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages
Krinkle added a comment. Still happening, got it on https://commons.wikimedia.org/wiki/File:MediaWiki_1.41.0_database_schema.png just now. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Pols12, Samwilson, Michael, WMDE-leszek, ItamarWMDE, TheDJ, karapayneWMDE, Lydia_Pintscher, Lucas_Werkmeister_WMDE, thiemowmde, Jdlrobson, Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, Ullasoff, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, Trngsh15, toberto, Invadibot, Mengs21, GFontenelle_WMF, maantietaja, FRomeo_WMF, EgbeRef, Vaibhav0199, Nintendofan885, Akuckartz, Dringsim, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, Nandana, JKSTNK, Mh-3110, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, enigmaeth, rohitt, KimKelting, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Dixtosa, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board. Restricted Application added a project: Moderator-Tools-Team. TASK DETAIL https://phabricator.wikimedia.org/T353076 WORKBOARD https://phabricator.wikimedia.org/project/board/274/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Michael, simon04, SD0001, Jdlrobson, Novem_Linguae, Soda, Chlod, DannyS712, Aklapper, Jdforrester-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Hey_man_im_josh, S8321414, Jersione, HuanNguyen, Hellket777, MPGuy2824, LisafBia6531, IAmChaos, Astuthiodit_1, STH, G1964j, 786, Zekwn, Sgs, DMburugu, Biggs657, karapayneWMDE, the0001, Invadibot, Zabe, Selby, AndreCstr, maantietaja, XeroS_SkalibuR, GhostInTheMachine, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dringsim, Demian, Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Mirahamira, Gaboe420, Jony, lucamauri, Giuliamocci, Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Flycatchr, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Volker_E, Izno, SBisson, Samwalton9-WMF, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Tgr ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph
Krinkle added a comment. FYI: Periodic updates about this topic appear to be posted to https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/WDQS_backend_update#Current_status, including several updates since the filing of this task, and the last one was a few days ago. TASK DETAIL https://phabricator.wikimedia.org/T330525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Daniel_Mietchen, tfmorris, diegodlh, Sj, Gehel, Aklapper, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, KimKelting, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T330525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daniel_Mietchen, tfmorris, diegodlh, Sj, Gehel, Aklapper, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, KimKelting, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T330525: Migrate Wikidata off of Blazegraph
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T330525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daniel_Mietchen, tfmorris, diegodlh, Sj, Gehel, Aklapper, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, KimKelting, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353076: Deprecate and then drop mw.Map, obviated now we require ES6
Krinkle added a project: MediaWiki-ResourceLoader. Krinkle added a comment. Restricted Application added a project: MediaWiki-Platform-Team. > mw.Map is an ES3-compatible re-implementation of Map from ES6. It is not. The naming similarity between `mw.Map` and ES6 Map is a coincidence and predates our awareness of ES6 by many years. The two are not related to each other. In the past we did ship inlined ES6 polyfills and we could have (and still can) implement one atop the other. The reason mw.Map is written in a few lines of plain JavaScript, is that mw.Map would be larger, slower, and more complicated if we wrote it any other way. We did simplify the code over the years by adopting modern `Object.create( null );`, `for-in` and `Array.isArray`. If there's ways to simplify the implementation further, patches are welcome! Note that it isn't a general-purpose public API, rather it exists primarily as backend for the public `mw.config` and `mw.user.options` APIs. Last I tried, I found trying to put ES6 Map underneath, I didn't help in size, speed, or simplicity, so I didn't. Some examples of features are are incompatible with ES6 Map: - `mw.Map#get()` returns an object of all values. - `mw.Map#get(key, default)` takes a `default` parameter, widely used, e.g. `mw.config.get( 'wgUserGroups', [] )`. - `mw.Map#get(keys)` takes an array `keys` parameter for returning a subset of keys, widely used, e.g. `mw.config.get( [ 'wgTitle', 'wgNamespaceId' ])`. - `mw.Map#set(values)` takes an Object `values` parameter to set multiple key-value pairs in one go, or two separate key-value arguments, widely used. - `mw.Map#exists(key)` is a boolean method for checking key existence. The coincidental overlap with ES6 starts and stops at `.get(key)` and `.set(key, value)`. TASK DETAIL https://phabricator.wikimedia.org/T353076 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Michael, simon04, SD0001, Jdlrobson, Novem_Linguae, Soda, Chlod, DannyS712, Aklapper, Jdforrester-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Hey_man_im_josh, Jersione, HuanNguyen, Hellket777, MPGuy2824, LisafBia6531, IAmChaos, Astuthiodit_1, STH, G1964j, 786, Zekwn, Sgs, Biggs657, karapayneWMDE, the0001, Invadibot, Zabe, Selby, AndreCstr, maantietaja, XeroS_SkalibuR, GhostInTheMachine, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Mirahamira, Gaboe420, Jony, lucamauri, Giuliamocci, Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Flycatchr, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Neuronton, Scott_WUaS, Volker_E, Izno, SBisson, Samwalton9-WMF, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Tgr ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround
Krinkle added a comment. In T356402#9536675 <https://phabricator.wikimedia.org/T356402#9536675>, @hashar wrote: > `$wgLocalisationCacheConf['store'] = 'array';` that is the format used to store the cache. […] it gets the localization cache from Memcached: > > [MessageCache] MessageCache using store MemcachedPhpBagOStuff > [memcached] MemCache: got WANCache:wikidb:messages:en|#|t There does not exist a Memcached backend for LocalisationCache. LCStore has only file-based (CDB or PHP) and DB-based implementations. What you see here is the MessageCache, which is a layer on top of LocalisationCache, where we cache the message overrides from NS_MEDIAWIKI pages. > Start request GET / > … > [localisation] LocalisationCache using store LCStoreStaticArray > … It uses the static PHP files for LocalisationCache. TASK DETAIL https://phabricator.wikimedia.org/T356402 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, hashar, Michael, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, KimKelting, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, thcipriani, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle added a comment. With the last patch merged, feel free to close it. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T255706: [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock
Krinkle added a comment. In T255706#9415091 <https://phabricator.wikimedia.org/T255706#9415091>, @Lucas_Werkmeister_WMDE wrote: > […] I’m also not entirely sure if mwdebug ensures that jobs queued by it only run on mwdebug as well; […] Not only do we not ensure this, jobs never run somewhere besides jobrunners. Not on regular appservers, api_appservers, mwmaint, or indeed mwdebug servers. Queuing a job adds an event to Kafka, after which the jobrunner (changeprop-jobqueue at WMF) executes them over RPC on jobrunner servers. Origin hostname is not part of job metadata, and given the longevity of some jobs (e.g. video transcode, and recursive refreshLinks) we might not want to (always) run jobs on mwdebug. Having a way to construct and then run a single concrete job on mwmaint or mwdebug shell would definitely be nice though, i.e. without queuing it. This is currently possible via eval.php, but we don't have documented examples of this afaik. Doing so would allow you to capture the verbose debug output of it (e.g. eval.php -d 2). The other option you have for jobs, is the AdhocDebug channel <https://wikitech.wikimedia.org/wiki/Debugging_in_production#Ad-hoc_log_messages>, which is enabled even in production. You'd want to make sure the job is low frequency, or make the logger conditional in a wmf-branch patch to certain page titles only (or other job params). TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: ArthurTaylor, hoo, Lucas_Werkmeister_WMDE, ItamarWMDE, Ladsgroup, Krinkle, eprodromou, aaron, Michael, Aklapper, thcipriani, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle added a comment. @DAlangi_WMF The problematic hook that initiated this task (via the parent task) is `onPageContentLanguage()` which is called by Title->getPageViewLanguage(), but not directly. The hook call resides in `ContentHandler::getPageViewLanguage() -> ContentHandler->getPageViewLanguage()`. The reason Wikibase is out of scope, is that it implements a custom method called `getPageViewLanguage` in a subclass of ContentHandler, and shares no code with the base class in core. After we deprecate and remove this, the Wikibase continues to work on its own. CommonsMetadata, however, does call into the affected core code. It makes the same kind of mistake as the other extensions we patched in this task, namely it deals with a ParserOutput, but instead of asking the ParserOutput object what the language of the HTML is, it tries to "guess" by invoking global state of `ContentHandler::getPageViewLanguage`. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle removed a project: User-xSavitar. Krinkle reassigned this task from xSavitar to DAlangi_WMF. Krinkle added a subscriber: xSavitar. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAlangi_WMF, Krinkle Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle assigned this task to xSavitar. Restricted Application added a project: User-xSavitar. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: xSavitar, Krinkle Cc: Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
Krinkle created this task. Krinkle added projects: MediaWiki-Platform-Team (Radar), Data-Engineering, Wikidata, MediaWiki-extensions-WikibaseRepository, Structured Data Engineering, CommonsMetadata, DiscussionTools, MediaWiki-extensions-Scribunto. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Structured-Data-Backlog. TASK DESCRIPTION Background -- See T341244: ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir <https://phabricator.wikimedia.org/T341244>. In a nut shell, it is (unfortunately) common today for extensions to try to "guess" the language and directionality of embedded content. The reason for this is largely that a better API didn't exist, and classes like `mw-content-ltr` are important to set for correct styling, and are difficult to set by any means other than `Title::getPageViewLanguage`. But, Title::getPageViewLanguage involves global state and a lot of guess work. Scope - https://codesearch.wmcloud.org/deployed/?q=%3EgetPageViewLanguage [ ] EventLogging (MetricsPlatform/ContextAttributesFactory.php). #data-engineering <https://phabricator.wikimedia.org/tag/data-engineering/> [ ] TemplateSandbox (Hook, SpecialPage). **Unassigned: No owner**. [ ] Wikibase (EntityHandler.php). #wikidata <https://phabricator.wikimedia.org/tag/wikidata/> [ ] CommonsMetadata (Hook). #structured_data_engineering <https://phabricator.wikimedia.org/tag/structured_data_engineering/> [ ] DiscussionTools (SpecialDiscussionToolsDebug.php). #editing-team <https://phabricator.wikimedia.org/tag/editing-team/> [ ] Scribunto (ScribuntoContentHandler.php). **Unassigned: No owner**. Outcome --- Remove use of Title::getPageViewLanguage. Example migration: - **HTML workarounds**: In cases where it is used to manually create CSS classes like `mw-content-ltr` and `mw-parser-output`, and the `lang` and `dir` attributes, this can probably removed given that nowadays ParserOutput will take care of setting these already. Be sure to test the end-user workflow and confirm that your workarounds are redundant before removing them. When not possible to remove or if not feasible in the short-term, at least use `ParserOutput->getLanguage()` to inform your current workarounds instead of the global guesswork from Title::getPageViewLanguage. - **Language code**. If using Title::getPageViewLanguage to associate page language outside a pageview perspective, it is likely incorrect. Consider using `Title->getPageLanguage()` instead. TASK DETAIL https://phabricator.wikimedia.org/T350806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr, Slack_connector_for_Editing_team_triage ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T349118: Migrate node-based services in production to node18
Krinkle edited projects, added MediaWiki-Engineering; removed MediaWiki-Platform-Team. Krinkle added a comment. > Platform: > > mediawiki/services/example-node-api > mediawiki/services/image-suggestion-api > mediawiki/services/restbase > mediawiki/services/service-scaffold-node I assume #mediawiki-platform-team <https://phabricator.wikimedia.org/tag/mediawiki-platform-team/> is tagged in relation to these services. These refer to services that used to be owned by the "Wikimedia Services Team", later merged into "Core Platform Team" and eventually "Platform Engineering Group". This teams was discontinued in the July 2023 reorg. Its closest successor, I suppose, is the #mediawiki-engineering <https://phabricator.wikimedia.org/tag/mediawiki-engineering/> Group. Specifically, not the #MediaWiki-Platform-Team <https://phabricator.wikimedia.org/tag/mediawiki-platform-team/> which has its components listed on mw:Maintainers, and owns no "services" right now. Re-tagging as such. TASK DETAIL https://phabricator.wikimedia.org/T349118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Jdforrester-WMF, ney.pimenta, Danny_Benjafield_WMDE, BartTerpstra, Kappakayala, Mohamed-Awnallah, Astuthiodit_1, JKieserman, DMartin-WMF, lbowmaker, VPuffetMichel, Arnoldokoth, BTullis, karapayneWMDE, Kritisinghh, Vyaki, bwang, Deek9399, Invadibot, Surya742, Dasgupta002, Deveshprasad577, Atharva17, Tsiruot, Aseleste, sobhanbera, UOzurumba, Bharatkhatri351, gengh, Ywats0ns, Ponor, diegodlh, Dolphyb, Nikolay_Komarov, GrounderUK, Aishik_Rehman, maantietaja, AndrewEells, wkandek, JMeybohm, Rileych, ItamarWMDE, Nintendofan885, Akuckartz, Ironie, darthmon_wmde, Tris_T7, Nandana, jijiki, Mihailo, Jony, Lahi, Gq86, GoranSMilovanovic, chapulina, Mahir256, QZanden, srishakatux, YULdigitalpreservation, Alfa80, LawExplorer, _jensen, rosalieper, Jdrewniak, Jason_Quinn, Nizil, Scott_WUaS, Shangkuanlc, Ixocactus, Verdy_p, Wikidata-bugs, Base, aude, Amire80, Mvolz, Lydia_Pintscher, Jsahleen, mxn, ssastry, Arrbee, santhosh, KartikMistry, Arlolra, TheDJ, Mbch331, Jay8g, Krenair, ori, Tgr, Clement_Goubert ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T174022: Implement multi-content revisions
Krinkle closed subtask T324910: Slot-aware action raw as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T174022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Magol, Lokal_Profil, AfroThundr3007730, Agabi10, Liuxinyu970226, TomT0m, Smalyshev, -jem-, Aklapper, daniel, me, Danny_Benjafield_WMDE, Astuthiodit_1, BeautifulBold, Suran38, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, Naike, Peteosx1x, NavinRizwi, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, eprodromou, DannyS712, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter
Krinkle removed a project: MediaWiki-Core-Hooks. TASK DETAIL https://phabricator.wikimedia.org/T25 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Daimona, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 94rain, Nandana, Lahi, Gq86, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Litanwei, JJMC89, _jensen, rosalieper, Scott_WUaS, Wong128hk, Nirmos, Wikidata-bugs, aude, Nullzero, Huji, Billinghurst, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336952: Wikibase\DataModel\Services\Lookup\ReferencedEntityIdLookupException: Referenced entity id lookup failed. Tried to find a referenced entity out of Q16334295 linked
Krinkle assigned this task to hoo. Krinkle closed this task as "Resolved". Krinkle added a comment. No mathces on Logstash mediawiki-errors dashboard for `message:"Referenced entity id lookup failed."` in the past 30 days. TASK DETAIL https://phabricator.wikimedia.org/T336952 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Krinkle Cc: Krinkle, hoo, Novem_Linguae, Pikne, Swpb, hashar, brennen, Nux, Aklapper, TheresNoTime, Danny_Benjafield_WMDE, HuanNguyen, Astuthiodit_1, G1964j, Zekwn, karapayneWMDE, the0001, Invadibot, Zabe, Selby, AndreCstr, maantietaja, XeroS_SkalibuR, ItamarWMDE, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Mirahamira, Lahi, Gq86, Markhalsey, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T267848: ResourceLoader duplicate registration warning. Another module has already been registered as wikibase.Site
Krinkle removed a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T267848 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: toan, RShigapov, Addshore, Aklapper, Danny_Benjafield_WMDE, Jon.b.amar, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Vali.matei ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: KSiebert, WMDE-Fisch, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, Ltrlg, AntiCompositeNumber, kostajh, Universal_Omega, Michael, alistair3149, Jdlrobson, Uata1122, fbalicchia, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, isarantopoulos, KLawal-WMF, Adamm71, PMenon-WMF, gonzalez.actor, Jersione, Hellket777, LisafBia6531, vyuen, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, BTullis, Biggs657, toberto, Simonmaignan, LaMagiaaa, DesignerThan, Func, Zabe, Ywats0ns, H0bby, Asartea, Bebiezaza, Parlautan, calbon, Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Anerka, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Soda, Demian, apaskulin, Dzaky17, Hook696, CptViraj, darthmon_wmde, Hakimi97, Eihel, Jtneill, abi_, taavi, MJL, Kent7301, Chambersjay, FriedrickMILBarbarossa, joker88john, Dinadineke, DannyS712, wildly_boy, CucyNoiD, Chief_Mike, Klaas_Z4us_V, Matlin, Tumz24, Gaboe420, Urfiner, Jony, lucamauri, Patriccck, CycloneIsaac, Giuliamocci, tabish.shaikh91, Cpaulf30, Af420, Xinbenlv, Vacio, Ramsey-WMF, SapphieWillie, dmaza, Bsandipan, Daimona, tsca, Xover, Lucas_Werkmeister_WMDE, Gboyers, Fz-29, Chicocvenancio, JakeTheDeveloper, Mahir256, cmadeo, srishakatux, Viveksr96, Esc3300, merbst, spatton, RIT_RAJARSHI, Flycatchr, Samuele2002, Lewizho99, Lemondoge, Maathavan, Wugapodes, elukey, Assassas77, YonaB, Jseddon, Agabi10, Bodhisattwa, Mkdw, XanonymusX, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, mb, Cirdan, Samwilson, DStrine, Volker_E, XenoRyet, Izno, SBisson, Wong128hk, Luke081515, freephile, Unapersona, IKhitron, abian, Zache, Hsarrazin, Wikidata-bugs, Snowolf, Base, AndyRussG, Ebe123, Pcoombe, Dinoguy1000, Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Kipod, Shizhao, fbstj, Paladox, Arrbee, santhosh, KartikMistry, Isarra, Alchimista, Billinghurst, TheDJ, Ladsgroup, Jackmcbarn, jayantanth, Jay8g, ashley, jeremyb, Vali.matei ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T204792: [20h] Why is the url key undefined in language objects for categories?
Krinkle removed a project: Platform Team Workboards (MW Expedition). TASK DETAIL https://phabricator.wikimedia.org/T204792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, daniel, AMooney, Tonina_Zhelyazkova_WMDE, noarave, Silvan_WMDE, toan, Lucas_Werkmeister_WMDE, WMDE-leszek, Lydia_Pintscher, Amire80, Jdlrobson, pmiazga, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Naike, eprodromou ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T226976: Convert linkitem module away from jQuery UI
Krinkle removed a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T226976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: ItamarWMDE, Sarai-WMDE, Michael, stjn, Pablo-WMDE, WMDE-leszek, Lydia_Pintscher, Aklapper, Jdforrester-WMF, Ricordisamoa, Ltrlg, Prtksxna, Glaisher, Danmichaelo, Volker_E, Paladox, Danny_B, Liuxinyu970226, AndyRussG, Amorymeltzer, Ladsgroup, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, caldera, maantietaja, Akuckartz, Demian, Nandana, Remagoxer, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Psychoslave, Wikidata-bugs, aude, Mbch331, Jay8g, Vali.matei ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324318: Update Wikibase code bases to WebdriverIO v8
Krinkle added a subtask: T293080: Refactor Wikibase WebdriverIO tests from sync to async mode. TASK DETAIL https://phabricator.wikimedia.org/T324318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T293080: Refactor Wikibase WebdriverIO tests from sync to async mode
Krinkle added a parent task: T324318: Update Wikibase code bases to WebdriverIO v8. TASK DETAIL https://phabricator.wikimedia.org/T293080 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: vaughnwalters, Krinkle Cc: Aklapper, zeljkofilipin, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T293080: Refactor Wikibase WebdriverIO tests from sync to async mode
Krinkle added a parent task: T324685: Upgrade WebdriverIO to v8 in all repositories. TASK DETAIL https://phabricator.wikimedia.org/T293080 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: vaughnwalters, Krinkle Cc: Aklapper, zeljkofilipin, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279585: Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)
Krinkle removed projects: Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T279585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, Addshore, Krinkle, RhinosF1, matmarex, dduvall, Aklapper, LucasWerkmeister, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, WDoranWMF, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Sethakill, dg711, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, jayvdb, Mbch331, Naike, eprodromou, darthmon_wmde, Rosalie_WMDE, Agabi10, Pchelolo, Verdy_p, Jdforrester-WMF, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328144: Drop PNG fallback for SVG icons / etc. across all Wikimedia products
Krinkle removed a project: ArticleFeedbackv5. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T328144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Nikerabbit, Nikki, jhsoby, Michael, Volker_E, thiemowmde, Lucas_Werkmeister_WMDE, Aklapper, Jdforrester-WMF, Isabelladantes1983, Themindcoder, Adamm71, JCW555, Jersione, HuanNguyen, Hellket777, Arbolitoloco, LisafBia6531, Rwv37, Astuthiodit_1, STH, G1964j, 786, Zekwn, Sgs, Biggs657, karapayneWMDE, the0001, Invadibot, Zabe, Selby, H0bby, AndreCstr, maantietaja, XeroS_SkalibuR, GhostInTheMachine, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, dlo, Hook696, darthmon_wmde, Tombolano, abi_, Kent7301, BryghtShadow, Aram, joker88john, CucyNoiD, Nandana, JamesDriscoll, Mirahamira, Tumz24, Gaboe420, Jony, Mmiller0712, Bhaskargoyal24, priyanshu_varshney, Giuliamocci, AbhinavKhare, Nikhil-nk, 2angelic1, Cpaulf30, AkinkuotuFunmi, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, Jonathan3, QZanden, Xephyr826, LawExplorer, spatton, Flycatchr, Vali.matei, Lewizho99, Maathavan, _jensen, Jseddon, rosalieper, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, Scott_WUaS, DStrine, XenoRyet, Izno, SBisson, MGChecker, Lmorillas, Oetterer, Wikidata-bugs, Yaron_Koren, Base, aude, AndyRussG, Pcoombe, SuperHamster, Dinoguy1000, Amire80, Tacsipacsi, fbstj, Lydia_Pintscher, Arrbee, santhosh, KartikMistry, Isarra, Mbch331, Jay8g, Goutham0306, Macszymk ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)
Krinkle added a comment. The Wikibase code is using `IDatabase::unionQueries()`. It seems the Rdbms library currently doesn't offer any other way to run union queries. TASK DETAIL https://phabricator.wikimedia.org/T332941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Aklapper, Krinkle, ItamarWMDE, Akuckartz, lucamauri, Vali.matei, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)
Krinkle added a parent task: T326181: Stop doing regex on SQL in Database. TASK DETAIL https://phabricator.wikimedia.org/T332941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Aklapper, Krinkle, ItamarWMDE, Akuckartz, lucamauri, Vali.matei, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable)
Krinkle created this task. Krinkle added projects: Performance-Team (Radar), MediaWiki-extensions-WikibaseClient. TASK DESCRIPTION The immediate reason for the warning is that it is calling `query()` without indication of whether it is a write query or not, thus requiring Rdbms to perform its legacy regexes on the SQL text to guess it. However, more important than whether it passes the second parameter of `query()`, is that it calls `query()` at all, as this should not be used outside Rdbms internals. It exposes raw SQL and should be avoided in favour of safe interfaces like `SelectQueryBuilder` or `IDatabase::select()`. It is currently triggered approximately 100K/hour, making it the most common entry on the mediawiki-warnings dashboard in Logstash, across all MW channels and components. The instrumentation was added last month in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/894110 to detect exactly this issue, on the assumption it will likely not trigger anything in production. Wikibase's use was one of two callers we found in production. name=message Wikimedia\Rdbms\Platform\SQLPlatform::isWriteQuery fallback to regex name=trace #0 /srv/mediawiki/php-1.41.0-wmf.1/includes/libs/rdbms/database/Database.php(934): Wikimedia\Rdbms\Platform\SQLPlatform->isWriteQuery(string, integer) … #4 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(474): Wikimedia\Rdbms\DBConnRef->query(string, string) #5 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(407): Wikibase\Client\Usage\Sql\EntityUsageTable->getUsedEntityIdStringsMySql(array, Wikimedia\Rdbms\DBConnRef) #6 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(389): Wikibase\Client\Usage\Sql\EntityUsageTable->getUsedEntityIdStrings(array) #7 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Usage/Sql/SqlUsageTracker.php(273): Wikibase\Client\Usage\Sql\EntityUsageTable->getUnusedEntities(array) #8 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Usage/ImplicitDescriptionUsageLookup.php(303): Wikibase\Client\Usage\Sql\SqlUsageTracker->getUnusedEntities(array) #9 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Store/UsageUpdater.php(80): Wikibase\Client\Usage\ImplicitDescriptionUsageLookup->getUnusedEntities(array) #10 /srv/mediawiki/php-1.41.0-wmf.1/extensions/Wikibase/client/includes/Store/AddUsagesForPageJob.php(121): Wikibase\Client\Store\UsageUpdater->addUsagesForPage(integer, array) #11 /srv/mediawiki/php-1.41.0-wmf.1/extensions/EventBus/includes/JobExecutor.php(79): Wikibase\Client\Store\AddUsagesForPageJob->run() #12 /srv/mediawiki/rpc/RunSingleJob.php(77): MediaWiki\Extension\EventBus\JobExecutor->execute(array) TASK DETAIL https://phabricator.wikimedia.org/T332941 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Aklapper, Krinkle, ItamarWMDE, Akuckartz, lucamauri, Vali.matei, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages
Krinkle reopened this task as "Open". Krinkle added projects: Wikimedia-production-error, SDC General. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, toberto, GFontenelle_WMF, FRomeo_WMF, ItamarWMDE, Nintendofan885, darthmon_wmde, Rosalie_WMDE, JKSTNK, Lahi, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, Tramullas, Acer, Salgo60, Silverfish, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, Daniel_Mietchen, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332305: Error “View mediainfoview does not exist” on SDC pages
Krinkle closed this task as a duplicate of T321532: [commons-wmf.6] Console error - Error: View mediainfoview does not exist on File pages. TASK DETAIL https://phabricator.wikimedia.org/T332305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CBogen, SimoneThisDot, matthiasmullie, vadim-kovalenko, Etonkovidova, mdaniels5757, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, toberto, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, ItamarWMDE, Nintendofan885, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions
Krinkle moved this task from Inbox, needs triage to Radar on the Performance-Team board. Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T328497 WORKBOARD https://phabricator.wikimedia.org/project/board/1212/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: KSiebert, WMDE-Fisch, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, JohanahoJ, Ltrlg, AntiCompositeNumber, Lens0021, kostajh, Universal_Omega, Michael, alistair3149, Jdlrobson, Themindcoder, 1313, Mohamed-Awnallah, KLawal-WMF, Adamm71, PMenon-WMF, gonzalez.actor, Jersione, PWaigi-WMF, Hellket777, LisafBia6531, Wangombe, vyuen, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, MaryMunyoki, VPuffetMichel, BTullis, Biggs657, ycrepeau, toberto, Simonmaignan, LaMagiaaa, UOzurumba, DesignerThan, Func, Zabe, MPhamWMF, Ywats0ns, H0bby, Asartea, Devnull, Dentonius, diegodlh, Mohammadmalek554, Bebiezaza, Timbaaa, Parlautan, calbon, Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Pietrasagh, Rost_WMDE, Anerka, Alter-paule, Beast1978, CBogen, Rileych, GeneralNotability, Un1tY, Nintendofan885, Soda, keithbrianpadilla, Ironie, Demian, apaskulin, Dzaky17, Hook696, CptViraj, Bouzinac, Erdinc_Ciftci_WMDE, darthmon_wmde, Saimongoltinio, Eihel, Jtneill, WikimeSteve, abi_, taavi, MJL, Kent7301, ppelberg, Chambersjay, FriedrickMILBarbarossa, Jd3main, joker88john, Tris_T7, Dinadineke, DannyS712, wildly_boy, CucyNoiD, Chief_Mike, Klaas_Z4us_V, Tks4Fish, marcella, Matlin, Tumz24, Gaboe420, Revansx, Urfiner, Jony, lucamauri, Patriccck, OhKayeSierra, CycloneIsaac, Giuliamocci, tabish.shaikh91, Cpaulf30, takidelfin, Af420, Xinbenlv, Vacio, Ramsey-WMF, mojoaxel, Necroarcano, SapphieWillie, Inductiveload, dmaza, Bsandipan, Daimona, Robinma, Xover, Lucas_Werkmeister_WMDE, Gboyers, Fz-29, TheDragonFire, Maosef, chapulina, Chicocvenancio, JakeTheDeveloper, Mahir256, EBjune, cmadeo, Pppery, Viveksr96, Esc3300, Alfa80, merbst, spatton, RIT_RAJARSHI, Flycatchr, Vali.matei, Samuele2002, Lewizho99, Lemondoge, JJMC89, Maathavan, Wugapodes, Wess, elukey, Assassas77, Tshrinivasan, Iniquity, YonaB, Debenben, Jseddon, Jason_Quinn, Agabi10, Bodhisattwa, Mkdw, XanonymusX, Taiwania_Justo, Neuronton, Nizil, shinjiman, gabriel-wmde, mb, Srdjan, Cirdan, Info-farmer, Samwilson, DStrine, Shangkuanlc, Volker_E, XenoRyet, Ixocactus, Izno, SBisson, Wong128hk, Luke081515, freephile, Unapersona, IKhitron, Jrf, Uzume, Husun1297, abian, MusikAnimal, Zache, Hsarrazin, Wikidata-bugs, Snowolf, Base, fredw, SPQRobin, Candalua, AndyRussG, Ebe123, Pcoombe, Huji, Physikerwelt, Pkra, Dinoguy1000, Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Kipod, Shizhao, Swainr, fbstj, Lydia_Pintscher, Yurik, Jsahleen, Paladox, Tpt, Arrbee, santhosh, scfc, KartikMistry, Isarra, Alchimista, Billinghurst, TheDJ, Ladsgroup, Jackmcbarn, jayantanth, Jay8g, ashley, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324991: Make Wikibase not rely on the ResourceLoader target system
Krinkle removed projects: Performance-Team, MediaWiki-ResourceLoader. TASK DETAIL https://phabricator.wikimedia.org/T324991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, JohanahoJ, Ltrlg, AntiCompositeNumber, Lens0021, kostajh, Universal_Omega, Michael, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g, Vali.matei, xSavitar, Nirmos ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges
Krinkle closed this task as "Resolved". Krinkle claimed this task. Krinkle added a comment. In general when WANCache/getWithSet and purge is used, it works correctly both for single-DC and multi-DC. Using raw sets or deletes to local memcached has been discouraged for a while now, and we've have many years of 2 switchovers a year without memcached being wiped as precaution. Presumed solved as of T270223: FY2021-2022: Enable basic Multi-DC operations for read traffic (tracking) <https://phabricator.wikimedia.org/T270223>. If bugs are found, new tasks can be filed for specific issues. TASK DETAIL https://phabricator.wikimedia.org/T93142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, aaron, daniel, JanZerebecki, Lydia_Pintscher, aude, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, RhinosF1, Nandana, jijiki, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T316487 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aaron, Krinkle Cc: WMDE-leszek, Addshore, Krinkle, CtrlZvi, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T316853: ResourcesTest::testUnsatisfiableDependencies: The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true
Krinkle removed projects: MediaWiki-ResourceLoader, Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T316853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Krinkle Cc: Physikerwelt, Stegmujo, Jakob_WMDE, Silvan_WMDE, dcausse, kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Vali.matei, xSavitar, Nirmos, Dinoguy1000 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1
Krinkle moved this task from Inbox to Backlog: Maintenance on the Performance-Team board. Krinkle assigned this task to aaron. Krinkle added a comment. Thanks. We'll review the patch and backport to stable REL branches. TASK DETAIL https://phabricator.wikimedia.org/T316487 WORKBOARD https://phabricator.wikimedia.org/project/board/1212/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aaron, Krinkle Cc: Krinkle, CtrlZvi, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, waldyrious, Lydia_Pintscher, Nikerabbit, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315350: Beta cluster Error: 502, Next Hop Connection Failed
Krinkle renamed this task from "Known, Beta cluster Error: 502, Next Hop Connection Failed" to "Beta cluster Error: 502, Next Hop Connection Failed". TASK DETAIL https://phabricator.wikimedia.org/T315350 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: jnuche, jbond, thcipriani, ori, Zabe, ArielGlenn, bking, RhinosF1, Ryasmeen, matmarex, ppelberg, Daimona, TheresNoTime, Aklapper, Hellket777, LisafBia6531, Astuthiodit_1, AWesterinen, 786, TheReadOnly, Biggs657, karapayneWMDE, Invadibot, MPhamWMF, LSobanski, maantietaja, lmata, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, PatsagornY, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Namenlos314, jijiki, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, Neuronton, Liudvikas, Scott_WUaS, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Bawolff, Manybubbles, He7d3r, Jdforrester-WMF, Mbch331, Jay8g, Krenair, akosiaris ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T251286: Investigate restricting the ability to create sql queries with bad patterns in mediawiki
Krinkle added a comment. See also: T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) <https://phabricator.wikimedia.org/T210206> TASK DETAIL https://phabricator.wikimedia.org/T251286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Krinkle Cc: Krinkle, eprodromou, jcrespo, Ladsgroup, Marostegui, Aklapper, Addshore, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, PatsagornY, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges
Krinkle edited projects, added Performance-Team (Radar), Sustainability (MediaWiki-MultiDC); removed Performance Issue. TASK DETAIL https://phabricator.wikimedia.org/T93142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, aaron, daniel, JanZerebecki, Lydia_Pintscher, aude, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, RhinosF1, Nandana, jijiki, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Mbch331, Jay8g, Dinoguy1000 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T309770: TimedText namespace appearing on Wikidata
Krinkle added a comment. In T309770#7976506 <https://phabricator.wikimedia.org/T309770#7976506>, @TheDJ wrote: > In T309770#7976419 <https://phabricator.wikimedia.org/T309770#7976419>, @Jdforrester-WMF wrote: > >> Let's gate it on `wgEnableUploads` instead? > > Seems reasonable to me I see two caveats here that may be worth considering: 1. wgEnableUploads is enabled fairly widely even on many wikis that effectively don't have an upload link in the sidebar and don't permit non-sysops to upload. These are a number of wikis that once allowed uploads and disable it but keep this flag on to allow admins to theoretically react to anything that might be arise with files that used to exist and e.g. override the handful of files that remain. This means we'd expose the namespace as new and parement entry in every UI control on Search, Move page, etc. but have no practical purpose. This is how the task got filed, and while for wikidata it was always false afaik, many other wikis like nl.wikipedia.org have it technically true via `wgEnableUploads => commonsuploads => true` and thus remain affected by the regression/bug as reported. 2. We'll need to take into account when disabling wgEnableUploads that this also affects namespaces and thus requires pages to be migrated/renamed etc and might make deleted content inaccessible/un-restorable. This seems fine but something to keep in mind as wgEnableUploads probably isn't expected currently to have that kind of irreversable impact on existing file/timedtext pages. TASK DETAIL https://phabricator.wikimedia.org/T309770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, TheDJ, Ladsgroup, Tacsipacsi, Jdforrester-WMF, Aklapper, Fernandobacasegua34, Astuthiodit_1, Susie413113, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, PachaTchernof, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, jayvdb, brion, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder
Krinkle removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T287769 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter, Krinkle Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Fernandobacasegua34, 786, Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run
Krinkle edited projects, added Slow-DB-Query; removed Wikimedia-database-issue. TASK DETAIL https://phabricator.wikimedia.org/T238199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: SilentSpike, WMDE-leszek, ArielGlenn, Lea_Lacroix_WMDE, jcrespo, Addshore, Lydia_Pintscher, Aklapper, Ladsgroup, Marostegui, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Amorymeltzer, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Sethakill, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
Krinkle added a comment. In T304515#7804508 <https://phabricator.wikimedia.org/T304515#7804508>, @Krinkle wrote: > […] > While I don't have a root cause answer to this error. I do know the immediate cause of it. It seems these errors are only happening on POST requests to Special:Badtitle, […]. > > I haven't yet figured out what's making the requests, but I have found what's causing the referer to be Badtitle. It seems the `ve.init.*` tests are changing the address bar to Badtitle. […] This also has the side-effect of breaking the QUnit UI when VE is installed. I've managed to observe the POST requests locally by enabling (most) of the CI-gated extensions locally. These are coming from GrowthExperiments' unit tests, which are calling to `sendBeacon()` via EventLogging. The reason the requests were seen by CI without an event payload (neither in URL nor in body) will become apparent in a moment. POST /wiki/Special:JavaScriptTest#?%7B%22event%22%3A%7B%22newcomer_task_token%22%3A%221234%22%2C%22task_type%22%3A%22copyedit%22%2C%22maintenance_templates%22%3A%5B%5D%2C%22revision_id%22%3A102%2C%22page_id%22%3A101%2C%22page_title%22%3A%22Some%20title%22%2C%22has_image%22%3Afalse%2C%22ordinal_position%22%3A100%7D%2C%22schema%22%3A%22NewcomerTask%22%2C%22webHost%22%3A%22mw.localhost%22%2C%22wiki%22%3A%22foowiki%22%2C%22revision%22%3A-1%7D; POST /wiki/Special:JavaScriptTest#?%7B%22event%22%3A%7B%22newcomer_task_token%22%3A%221234%22%2C%22task_type%22%3A%22copyedit%22%2C%22maintenance_templates%22%3A%5B%5D%2C%22page_id%22%3A73%2C%22page_title%22%3A%22Some%20title%22%2C%22has_image%22%3Afalse%2C%22ordinal_position%22%3A0%7D%2C%22schema%22%3A%22NewcomerTask%22%2C%22webHost%22%3A%22mw.localhost%22%2C%22wiki%22%3A%22foowiki%22%2C%22revision%22%3A-1%7D; POST /wiki/Special:JavaScriptTest#?%7B%22event%22%3A%7B%22message%22%3A%22Parse%20error%20at%20position%200%20in%20input%3A%20%5B%5BTampa%2C%20Florida%7C%5D%5D%22%2C%22url%22%3A%22jqueryMsg%3A%2F%2Fpipe-trick%22%2C%22line%22%3A0%2C%22column%22%3A0%2C%22flowId%22%3A%2216485826419007%22%2C%22flowPosition%22%3A1%7D%2C%22schema%22%3A%22UploadWizardExceptionFlowEvent%22%2C%22webHost%22%3A%22wiki.xyz%22%2C%22wiki%22%3A%22foowiki%22%2C%22revision%22%3A-1%7D; .. POST /wiki/Special:Badtitle/JavaScriptTest#?%7B%22event%22%3A%7B%22message%22%3A%22Parse%20error%20at%20position%200%20in%20input%3A%20%5B%5B%5D%5D%22%2C%22url%22%3A%22jqueryMsg%3A%2F%2Fempty-link%22%2C%22line%22%3A0%2C%22column%22%3A0%2C%22flowId%22%3A%2216485832632794%22%2C%22flowPosition%22%3A3%7D%2C%22schema%22%3A%22UploadWizardExceptionFlowEvent%22%2C%22webHost%22%3A%22wiki.xyz%22%2C%22wiki%22%3A%22foowiki%22%2C%22revision%22%3A-1%7D; HTTP/1.1 Note how there is a hash `#` between the end of the path and the start of the would-be query string holding the event payload. This comes from ext.eventLogging/log.test.js#7 <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/EventLogging/+/6eec50c8505fdee93edb1264fe80e63156379e86/tests/ext.eventLogging/log.test.js#7> which fails to restore the state afterwards. This is my fault (change 583183 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/583183>), both for not restoring it but also more broadly as being not working as intended. See, I copied this from ext.eventLogging.debug.tests.js#77 <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/EventLogging/+/6eec50c8505fdee93edb1264fe80e63156379e86/tests/ext.eventLogging.debug.tests.js#77> for the original EventLogging service which used GET requests, and so by setting the base URI to a hash I accomplished two things: 1) The feature is now enabled for testing, and 2) It still doesn't go anywhere since navigations to hash are a no-op. Except, that's not true for AJAX requests. And even then, it most certainly isn't true for POST requests which will happen no matter what and the hash just gets ignored. In summary: - In CI, we are seeing corruption that looks eerily familiar to the php-opcache corruption we see in prod (T245183 <https://phabricator.wikimedia.org/T245183>). - I explained at T304515#7804508 <https://phabricator.wikimedia.org/T304515#7804508> that this is strange given we don't modify files. This might mean we just need to increase the size, or it might mean php-opcache is worse than we thought and can cause this race even during normal compiling of new files to opcache. If it's opcache related, then the immediate cause would be the switch from php-webserver to php-fpm with Apache. T285649 <https://phabricator.wikimedia.org/T285649> - The secondary cause is the bombarding of the server with POST requests. These come from unit tests for GrowthExperiments and UploadWizard. These tests are not at fault as EventLogging is meant to be no-op by default. - The tertiary cause is that I broke EventLogging's tests.
[Wikidata-bugs] [Maniphest] T185211: Generate coverage report for Wikidata extensions
Krinkle added a project: CoverMe. Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T185211 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: WMDE-leszek, gerritbot, hashar, Addshore, Legoktm, greg, Aklapper, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Ladsgroup, Astuthiodit_1, karapayneWMDE, Invadibot, Devnull, maantietaja, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, skpuneethumar, Zylc, 1978Gage2001, Lahi, Operator873, Gq86, Bsandipan, GoranSMilovanovic, DSquirrelGM, Jayprakash12345, Chicocvenancio, QZanden, Tbscho, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, thcipriani, Wikidata-bugs, Jitrixis, aude, Gryllida, scfc, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T258822: Wikibase extensions do not declare extension.json dependency on Wikibase
Krinkle renamed this task from "Wikibase extensions do not declare extension.json dependancy on Wikibase" to "Wikibase extensions do not declare extension.json dependency on Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T258822 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Tarrow, WMDE-leszek, Ladsgroup, ItamarWMDE, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist
Krinkle assigned this task to Lucas_Werkmeister_WMDE.
Krinkle closed this task as "Resolved".
Krinkle added a comment.
Confirmed via the ApiSandbox example in the task description. However, it now
produces a different fatal error that still counts as the same severity
production error. This probably still needs to be caught somewhere and turned
into an API error that blames the client, instead of now where it counts as an
internal server error.
"error": {
"code": "internal_api_error_InvalidArgumentException",
"info": "[5c825728-ab28-4c14-9c67-a8bc8b96a56c] Caught exception of
type InvalidArgumentException",
"errorclass": "InvalidArgumentException"
},
InvalidArgumentException: Entity type property cannot be edited on this
wiki.
from
/srv/mediawiki/php-1.39.0-wmf.4/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(629)
#0
/srv/mediawiki/php-1.39.0-wmf.4/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(669):
Wikibase\Repo\EditEntity\MediawikiEditEntity->checkLocal(Wikibase\DataModel\Entity\Property)
#1
/srv/mediawiki/php-1.39.0-wmf.4/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php(77):
Wikibase\Repo\EditEntity\MediawikiEditEntity->attemptSave(Wikibase\DataModel\Entity\Property,
string, integer, string, NULL, array)
#2
/srv/mediawiki/php-1.39.0-wmf.4/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(392):
Wikibase\Repo\EditEntity\StatsdSaveTimeRecordingEditEntity->attemptSave(Wikibase\DataModel\Entity\Property,
string, integer, string, NULL, array)
#3
/srv/mediawiki/php-1.39.0-wmf.4/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(339):
Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity(Wikibase\DataModel\Entity\Property,
string, array, DerivativeContext)
#4 /srv/mediawiki/php-1.39.0-wmf.4/includes/api/ApiMain.php(1897):
Wikibase\Repo\Api\ModifyEntity->execute()
TASK DETAIL
https://phabricator.wikimedia.org/T242959
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE, Krinkle
Cc: brennen, cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar,
Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, Astuthiodit_1,
786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja,
Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz,
Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana,
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF,
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan,
_jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude,
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T207683: Wikibase Repo api modules and special pages should be conditionally loaded based on entity types enabled and local, or only accept loaded local entities (or at lea
Krinkle closed subtask T242959: Error from NameTableStore::loadTable: Table commonswiki.wbt_type doesnt exist as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T207683 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jarekt, DannyS712, hoo, Lucas_Werkmeister_WMDE, Bugreporter, Multichill, SandraF_WMF, Keegan, MarkTraceur, Abit, Tpt, Ramsey-WMF, Jdforrester-WMF, Lydia_Pintscher, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, toberto, Invadibot, maantietaja, FRomeo_WMF, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304625: CI failing with IndexPager::buildQueryInfo error: 'wikidb.unittest_globaluser.gu_id' isn't in GROUP BY
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T304625 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Krinkle Cc: Krinkle, Reedy, aaron, Majavah, DLynch, Zabe, Aklapper, Lucas_Werkmeister_WMDE, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, Snowolf, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
Krinkle added a project: VisualEditor. Krinkle added a subscriber: Esanders. Krinkle added a comment. The current assumption around how php-opcache gets corrupted in prod is that there is a race condition when the main php-fpm process detects that opcache is full (e.g. due to files having changed since it never deletes old versions, e.g. after a new branch gets added to a server, and unused two week old code paths are still in the opcache). When it is full, it does a full reset and starts populating again which with our traffic seems to sometimes trigger a race where it corrupts itself. Our assumption so far has been that it is not possible to trigger this when you have unchanging code and are simply compiling it, like CI does. Having said that, there are two possibilities I see. 1) Our assumption is incorrect and the recent enablement of of Apache in CI has exposed us to opcache corruption. Or 2) Our code in the shared gate has reached the size that no longer fits in the default opcache size and thus may sometimes be getting too big to not consistently fit but forced to evict stuff during the browser tests and then immediately re-compile the same stuff again and likely reach the fullness again. While I don't have a root cause answer to this error. I do know the immediate cause of it. It seems these errors are only happening on POST requests to Special:Badtitle, which is certainly an odd thing to be seeing. Badtitle is the value of wgPageName during the QUnit tests (I modified it in change 772502 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/772502> to confirm this suspicion and make it easier to detect in the future). I haven't yet figured out what's making the rests, but I have found what's causing the referer to be Badtitle. It seems the `ve.init.*` tests are changing the address bar to Badtitle. Something similar came up in change 500819 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500819> for T89434 <https://phabricator.wikimedia.org/T89434>, but that was since fixed by @Esanders with change 768041 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/768041> and change 768046 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/768046/>. I'm guessing something here is still causing that to be triggered (and more importantly, and if intentional: not torn down afterward). This also has the side-effect of breaking the QUnit UI when VE is installed locally, as it will lead to Badtitle after form submission. TASK DETAIL https://phabricator.wikimedia.org/T304515 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Esanders, toan, Michael, Lucas_Werkmeister_WMDE, matmarex, RhinosF1, hashar, Krinkle, kostajh, Aklapper, Astuthiodit_1, Trngsh15, VPuffetMichel, karapayneWMDE, ycrepeau, Invadibot, Mengs21, Mohammadmalek554, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, keithbrianpadilla, Tinzawoo533, Saimongoltinio, WikimeSteve, ppelberg, Onmir, DannyS712, Nandana, marcella, Revansx, lucamauri, Mh-3110, Yahya, OhKayeSierra, Amorymeltzer, takidelfin, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, merbst, LawExplorer, Wess, _jensen, rosalieper, Scott_WUaS, Srdjan, Dixtosa, Jrf, Husun1297, Wikidata-bugs, aude, Dinoguy1000, Swainr, Jdforrester-WMF, Mbch331, Slack_connector_for_Editing_team_triage ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304625: CI failing with IndexPager::buildQueryInfo error: 'wikidb.unittest_globaluser.gu_id' isn't in GROUP BY
Krinkle added subscribers: aaron, Reedy, Krinkle. Krinkle assigned this task to Reedy. Krinkle added a comment. Thanks @Reedy. \cc @aaron Looks like there's some things that weren't under strict yet that now were after our change. Looks like the failing tests may have in common that they aren't in group Database. I don't know if that's indeed cause, but if so presumably means we have a tail of strict mode violations that are covered by tests but 1) not in the wmf-extension shared CI gate and thus missed during the code patch and 2) are not `group @Database` and thus don't need a mock DB but do make some basic read queries that violate strict mode. TASK DETAIL https://phabricator.wikimedia.org/T304625 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Krinkle Cc: Krinkle, Reedy, aaron, Majavah, DLynch, Zabe, Aklapper, Lucas_Werkmeister_WMDE, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, Snowolf, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
Krinkle added a comment. This seems to sporadically come up and is limited to the shared WMF-extension gate job, when Wikibase is installed. P22994 (An Untitled Masterwork) <https://phabricator.wikimedia.org/P22994> There appears to be a situation in which something is causing LocalisastionCache to initialise a new uncached language with a dataset of `int(1)` (instead of an array of message keys and values). In that situation, we see the following chain: - .. - `Wikibase LanguageFallbackChainFactory` - .. - `LanguageFactory->newFromCode` - .. - `LocalisationCache->recache` - `LCStoreStaticArray->set(string, string)` - This causes `PHP Warning: Cannot use a scalar value as an array` because `$this->data` is an integer instead of an array. - `LCStoreStaticArray::finishWrite` - This causes the fatal `TypeError: Argument 1 passed to Wikimedia\StaticArrayWriter::create()`. It's not clear to me how `$this->data` can be an integer there. It is explicitly set to an array in the constructor, and we then read `cache/l10n/:lang.php` if it exists, which presumably either won't exist or if we just generated it it would be written as array and up-to-date and not needing to be written to. The fatal error also clearly indicates that the code doesn't even allow itself to create that file as a non-array, so it's not clear how that file can end up as an integer. TASK DETAIL https://phabricator.wikimedia.org/T304515 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: hashar, Krinkle, kostajh, Aklapper, Astuthiodit_1, Trngsh15, Sgs, karapayneWMDE, Invadibot, Mengs21, caldera, maantietaja, EgbeRef, NavinRizwi, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, DannyS712, Nandana, lucamauri, Mh-3110, Yahya, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, Nattes, QZanden, enigmaeth, rohitt, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, geraki, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T289046: Use core QueryBuilder for DB queries in Wikibase
Krinkle renamed this task from "Use core's Query Builder for DB queries" to "Use core QueryBuilder for DB queries in Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T289046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
Krinkle changed the task status from "Stalled" to "Open". Krinkle assigned this task to Lucas_Werkmeister_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T265091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Krinkle Cc: Krinkle, Umherirrender, Lens0021, Addshore, Daimona, Aklapper, Reedy, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
Krinkle added a comment. Still seen at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764445 (build 137348 <https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/137348/console>. Please consider disabling this test. TASK DETAIL https://phabricator.wikimedia.org/T265091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Umherirrender, Lens0021, Addshore, Daimona, Aklapper, Reedy, karapayneWMDE, Invadibot, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist
Krinkle added a comment. There are a number of side-effect errors in production that suggest NameTableStore is not only failing to execute its query but also leaves the underlying connection in a dirty state for other code paths: Caller from MediaWiki\User\TalkPageNotificationManager::dbCheckNewUserMessages ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1146] Table 'commonswiki.wbt_type' doesn't exist Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1146] Table 'commonswiki.wbt_type' doesn't exist TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar, Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T242959: Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist
Krinkle renamed this task from "NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist" to "Error from NameTableStore::loadTable: Table 'commonswiki.wbt_type' doesn't exist". TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar, Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T242959: NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist
Krinkle renamed this task from "A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist" to "NameTableStore::loadTableError: 1146 Table 'commonswiki.wbt_type' doesn't exist". TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar, Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T242959: A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loa
Krinkle merged a task: T293921: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1146] Table commonswiki.wbt_type doesnt exist (db1142). Krinkle added a subscriber: cjming. TASK DETAIL https://phabricator.wikimedia.org/T242959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: cjming, Lucas_Werkmeister_WMDE, Jdforrester-WMF, Krinkle, hashar, Ladsgroup, Pablo-WMDE, Aklapper, Addshore, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T293921: PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Storage\NameTableStore::loadTable: [1
Krinkle closed this task as a duplicate of T242959: A database query error has occurred. Query: SELECT wby_id AS `id`,wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loadTableError: 1146 Table commonswiki.wbt_type doesnt exist. TASK DETAIL https://phabricator.wikimedia.org/T293921 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: cjming, Aklapper, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release
Krinkle added a comment. Not classes, class, singular. I acknowledge `messagebox` is different as it was added misguidedly more recently without realizing it to be a localwiki concept (or without sufficient research and migration toward adopting a central style or new name). In T299625#7637799 <https://phabricator.wikimedia.org/T299625#7637799>, @Izno wrote: > […] Fixing 450 wikis would be prevented by renaming the class on the MediaWiki side. For the same reason that removing localwiki messagebox from the software helps with this, so does preserving errorbox, which has been part of the software since 2005. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, 786, fenpedia, Suran38, Biggs657, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, Kent7301, Chambersjay, EvanProdromou, joker88john, SD0001, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumz24, Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Minilexikon, Bsandipan, Daimona, Gboyers, GoranSMilovanovic, ihojose, Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: [subtask] successbox, errorbox and warningbox classes will no longer function in 1.39 release
Krinkle added a comment. In T300306#7698162 <https://phabricator.wikimedia.org/T300306#7698162>, @Jdlrobson wrote: > We plan to remove the old classes April at the latest, […] anything that's not changed by that date will degrade regular unstyled HTML. If I understand correctly, we're talking about ~ three individual bytes of CSS, after transfer encoding, to be saved by removing these class names in the grouped CSS selectors. Perhaps we can leave these decade-old stable class aliases defined for a few more release cycles along the new selectors and not be bothered by one line of code in the interim. This would also aid edit notices, filter warnings, less popular gadgets, Lua modules, interface translation messages, templates, and everything on third-party wikis where migration cannot easily begin until after the next release. These things take time, but fortunately it's really easy to support at no cost to us. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Edtadros, Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Fernandobacasegua34, 786, fenpedia, Suran38, Biggs657, toberto, bwang, Invadibot, Feldpauschhaylee2017, LaMagiaaa, Lalamarie69, Zabe, Asartea, Florian_COLLIN, R4356th, Bebiezaza, maantietaja, Wilmanbeno, Juan90264, Alter-paule, Beast1978, CBogen, GeneralNotability, Un1tY, Akuckartz, Dzaky17, Hook696, CptViraj, darthmon_wmde, ST47, WDoranWMF, Majavah, Kent7301, Chambersjay, EvanProdromou, joker88john, SD0001, 94rain, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Tks4Fish, Tumz24, Gaboe420, Jony, CycloneIsaac, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Minilexikon, Bsandipan, Daimona, Gboyers, GoranSMilovanovic, ihojose, Mahir256, QZanden, LawExplorer, Litanwei, spatton, Samuele2002, Lewizho99, JJMC89, Maathavan, SundanceRaphael, _jensen, Jseddon, rosalieper, Agabi10, AGK, XanonymusX, Neuronton, RuyP, JEumerus, gabriel-wmde, Scott_WUaS, mb, Cirdan, Pchelolo, DStrine, XenoRyet, Wong128hk, Luke081515, Nirmos, Bsadowski1, mys_721tx, I_JethroBT, Unapersona, Zache, alex-mashin, Niharika, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Nullzero, Pcoombe, Huji, Dinoguy1000, jeblad, jayvdb, MrStradivarius, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, KartikMistry, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, Krenair, jeremyb, Legoktm ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T44063: [Epic] Provide a plain linked data interface for accessing entities
Krinkle added a project: Purtle. TASK DETAIL https://phabricator.wikimedia.org/T44063 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: ahmad, Smalyshev, Lea_Lacroix_WMDE, Realworldobject, Eroux108, Multichill, thiemowmde, Tpt, Lucas_Werkmeister_WMDE, Prtksxna, gerritbot, PokestarFan, cscott, Liuxinyu970226, intracer, Aklapper, AnjaJentzsch, Abraham, Denny, Lydia_Pintscher, daniel, BeautifulBold, Suran38, Invadibot, maantietaja, Peteosx1x, NavinRizwi, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T267129: Purtle issue truncating TTL export
Krinkle added a project: Purtle. TASK DETAIL https://phabricator.wikimedia.org/T267129 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, despens, Invadibot, maantietaja, Samantha_Alipio_WMDE, Akuckartz, Jelabra, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Asahiko, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T254631: Schema.org metadata is in the rather than the
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T254631 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Demian, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Volker_E, Niedzielski, Aklapper, dbarratt, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T254631: Schema.org metadata is in the rather than the
Krinkle added a project: Performance-Team (Radar). Krinkle added a comment. As I understand it, the JSON-LD scripg block was added in 2020 as part T209306 <https://phabricator.wikimedia.org/T209306>. Testing with Google's own tools (example <https://search.google.com/test/rich-results/result/r%2Farticles?id=e7R2yEeGm8VWmsR_OIepbA>) shows that this appears to be working correctly. For performance reasons I would advise against moving this to the `` unless we can quantify and validate with concrete evidence that this is a problem. And even then I would propose we first reach out to releant standards bodies to see if it can be loosened to follow best practices such that we prioritise human experience over that of automated indexing. TASK DETAIL https://phabricator.wikimedia.org/T254631 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Demian, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Volker_E, Niedzielski, Aklapper, dbarratt, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Chicocvenancio, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle
Krinkle removed projects: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-InputBox, MediaWiki-extensions-Graph. Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Seb35, Ladsgroup, BEANS-X2, Xover, Woolvia, Esanders, Krinkle, Aklapper, gerritbot, Jdforrester-WMF, Volker_E, Schnark, Rivaldid, Galobtter, G1964j, 786, Trngsh15, Zekwn, Suran38, Biggs657, the0001, Invadibot, Mengs21, Lalamarie69, Zabe, Selby, H0bby, Florian_COLLIN, AndreCstr, caldera, maantietaja, XeroS_SkalibuR, Juan90264, Alter-paule, EgbeRef, NavinRizwi, Beast1978, Un1tY, Vaibhav0199, Akuckartz, Hook696, Tinzawoo533, darthmon_wmde, abi_, Kent7301, Onmir, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Mirahamira, Tumz24, kostajh, Gaboe420, Mh-3110, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, Jayprakash12345, Nattes, QZanden, EBjune, enigmaeth, rohitt, EnricoCNC, LawExplorer, spatton, Lewizho99, Maathavan, _jensen, Jseddon, rosalieper, Taiwania_Justo, shinjiman, gabriel-wmde, Scott_WUaS, DStrine, Dixtosa, XenoRyet, Izno, Wikidata-bugs, Base, matthiasmullie, aude, AndyRussG, Pcoombe, geraki, Dinoguy1000, Gryllida, jeblad, Tacsipacsi, fbstj, Catrope, Paladox, Nikerabbit, KartikMistry, Addshore, Mbch331, Jay8g, Timbaaa, Pietrasagh, Bouzinac, Esc3300, Yurik, Jackmcbarn ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook
Krinkle added a comment. In T298509#7609799 <https://phabricator.wikimedia.org/T298509#7609799>, @cscott wrote: > In my personal opinion, rMW1d7221d066c0 <https://phabricator.wikimedia.org/rMW1d7221d066c01c3fa6fb3e539cebd9fe7a91550f> was a mistake: as a MediaWiki developer I have just about every extension every authored checked out in an `extensions` directory, and I enable them on demand via LocalSettings.php. But after `rMWcf4654399bd3` phpunit completely ignores my LocalSettings.php and runs tests on every extension it finds in the directory, regardless of whether it is currently enabled/configured/set up, etc. So I have to resort to storing my extensions out of the tree and a hack in my LocalSettings.php that creates symlinks in my `extensions/` directory to correspond to the current set of enabled extensions. That's annoying. […] I'm unable to reproduce this nor see how it could happen. I don't doubt you're experiencing it, but I am fairly confident that this is not in any way desirable or intended functionality and either result of a bug or an accident/misunderstanding in configuration. The linked patch discovers `tests/phpunit` in enabled extensions. It does not discover extensions. It uses ExtensionRegistry, which iterates over enabled extensions at run-time in the same way as e.g. Special:Version does. The only code I'm aware of that discovers uninstalled extensions, is the CLI installer where Antoine recently added a way for CI to quickly install MW with all extensions enabled that are present on disk, such that the logic for deciding which extensions to install in CI for a given repo is tied to which extension repos are cloned, and then MW takes it all. That's opt-in though, and afaik not something we expose to PHPUnit. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, aude, Dinoguy1000, ssastry, Arlolra, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')
Krinkle closed this task as "Declined". Krinkle added a comment. Thanks for confirming it isn't an issue with the software. > Around 140 errors over the past 12 hours, all in wikidata This error (`stack_trace:"HTMLDocument.altLabels"`) now has about 60 matches for the past 24 hours. I'm not sure where the threshold is for reporting a ask, but anything less than 10,000 a day or 1,000 an hour for the same message/trace can probably be assumed as noise and ignored by default; given a scale of over 200M Grade A pageviews a day, and this being unsampled and near-globally enabled. If a trace has an obvious owner (e.g. a familiar function or error from code you maintain, from a team-specific Logstash query), you could file more if it seems legit or worth investigating; but I wouldn't recommend it for general org-wide triage. TASK DETAIL https://phabricator.wikimedia.org/T298975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, matej_suchanek, Krinkle, bwang, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, dachary, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Ricordisamoa, Tacsipacsi, Sjoerddebruin, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')
Krinkle added a comment. Seems like a problem with the altLabels user script, not with Wikibase's own scripts. TASK DETAIL https://phabricator.wikimedia.org/T298975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, bwang, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T298975: wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')
Krinkle renamed this task from "TypeError: Cannot read properties of null (reading 'labels')" to "wikidata-altLabels TypeError: Cannot read properties of null (reading 'labels')". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T298975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: bwang, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view
Krinkle added a parent task: T277788: Save Timing improvements (2021). TASK DETAIL https://phabricator.wikimedia.org/T269960 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: karapayneWMDE, Michael, wkandek, Jdforrester-WMF, darthmon_wmde, Lydia_Pintscher, WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285987: Do not generate full html parser output at the end of Wikibase edit requests
Krinkle added a parent task: T277788: Save Timing improvements (2021). TASK DETAIL https://phabricator.wikimedia.org/T285987 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: danshick-wmde, RShigapov, Kormat, Marostegui, LSobanski, Ladsgroup, tstarling, Lucas_Werkmeister_WMDE, Michael, Tarrow, daniel, Krinkle, Addshore, Aklapper, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, WDoranWMF, alaa_wmde, EvanProdromou, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294862: t.message is not a function (from wikibase.termbox)
Krinkle added a comment. @Michael The error seems to be a logic problem in the client-side JavaScript code about an undefined function. If I understand correctly, you suspect this is a (normal?) side-effect in the Termbox JS code when it receives bad data or an error from the server. Is that right? TASK DETAIL https://phabricator.wikimedia.org/T294862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Michael, Manuel, Aklapper, Masumrezarock100, nray, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294862: t.message is not a function (from wikibase.termbox)
Krinkle renamed this task from "t.message is not a function" to "t.message is not a function (from wikibase.termbox)". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T294862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, Manuel, Aklapper, Masumrezarock100, nray, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist
Krinkle added a comment. In T296712#7539644 <https://phabricator.wikimedia.org/T296712#7539644>, @Tgr wrote: > Wikibase's own documentation also says <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/be728a4541dd9382218edd006781d0ce3c3e406d/docs/topics/options.md#Echo> `path` should be relative to the extensions directory. So the simplest fix is to just prefix the path with `Wikibase`. As I understand it, this config setting in wmf-config is meant to be an override (changing the generic Wikibase logo to a Wikidata logo), referring to a version of this file not present in the Wikibase extension directory. There is /static/images/wikibase/echoIcon.svg <https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/HEAD/static/images/wikibase/echoIcon.svg> in operations/mediawiki-config, hence I thought this was perhaps meaning to configure a `url`, like the production setting (the issue in this task is with the Beta Cluster setting, which uses `path`). TASK DETAIL https://phabricator.wikimedia.org/T296712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Tgr, Krinkle, dom_walden, Aklapper, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist
Krinkle edited projects, added Notifications, Performance-Team (Radar); removed MediaWiki-ResourceLoader, Performance-Team. Krinkle added a comment. Restricted Application added a project: Growth-Team. According to Codesearch, this path is set in wmf-config as `wmgWikibaseClientEchoIcon` using "path" (instead of "url?): wmf-config/InitialiseSettings-labs.php 1430'wmgWikibaseClientEchoIcon' => [ 1431'default' => [ 'path' => '/static/images/wikibase/echoIcon.svg' ], wmf-config/InitialiseSettings.php 21926'wmgWikibaseClientEchoIcon' => [ 21927 'default' => [ 'url' => '/static/images/wikibase/echoIcon.svg' ], wmf-config/Wikibase.php 313 $wgWBClientSettings['echoIcon'] = $wmgWikibaseClientEchoIcon; https://codesearch.wmcloud.org/search/?q=wmgWikibaseClientEchoIcon=nope=== and then `$wgWBClientSettings['echoIcon'] `, to Wikibase onBeforeCreateEchoEvent, to wgEchoNotificationIcons, to ResourceLoaderEchoImageModule which maps "path" to "file", and then core tries to read the path relative to the base path "" relative to the extensions directory. It seems the base path is undefined as well. The option "url" does not appear to be read anywhere, though presumably the prod variant is the one that's working... TASK DETAIL https://phabricator.wikimedia.org/T296712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, dom_walden, Aklapper, caldera, NavinRizwi, Akuckartz, kostajh, lucamauri, Gq86, Nattes, Vali.matei, xSavitar, Taiwania_Justo, SBisson, Wikidata-bugs, geraki, Catrope, Nirmos, Dinoguy1000, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T195792: Add support for setting individual query timeout in wikimedia/rdbms
Krinkle added a parent task: T293530: Improve slow read query handling. TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CDanis, Kormat, dpifke, danshick-wmde, Aklapper, Legoktm, Marostegui, jcrespo, aaron, daniel, Addshore, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, WDoranWMF, Kent7301, EvanProdromou, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Rayssa-, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T195792: Add support for setting individual query timeout in wikimedia/rdbms
Krinkle renamed this task from "Create Mediawiki DB abstraction for individual query timeouts" to "Add support for setting individual query timeout in wikimedia/rdbms". TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CDanis, Kormat, dpifke, danshick-wmde, Aklapper, Legoktm, Marostegui, jcrespo, aaron, daniel, Addshore, Invadibot, maantietaja, Akuckartz, WDoranWMF, EvanProdromou, Nandana, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T195792: Create Mediawiki DB abstraction for individual query timeouts
Krinkle added a parent task: T129093: SHOW SLAVE STATUS as a health check should have a low timeout. TASK DETAIL https://phabricator.wikimedia.org/T195792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: CDanis, Kormat, dpifke, danshick-wmde, Aklapper, Legoktm, Marostegui, jcrespo, aaron, daniel, Addshore, Invadibot, maantietaja, Akuckartz, WDoranWMF, EvanProdromou, Nandana, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294862: t.message is not a function
Krinkle added projects: MediaWiki-extensions-WikibaseRepository, wdwb-tech. Krinkle moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board. TASK DETAIL https://phabricator.wikimedia.org/T294862 WORKBOARD https://phabricator.wikimedia.org/project/board/1055/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Masumrezarock100, nray, Akuckartz, darthmon_wmde, lucamauri, Gq86, Verdy_p, Wikidata-bugs, Jdforrester-WMF, Addshore, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T283198: Database deadlock in Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster query
Krinkle renamed this task from "Wikimedia\Rdbms\DBQueryError: Error 1213:
Deadlock found when trying to get lock; try restarting transaction (db1104)
Function:
Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster
Query: INSERT IGNORE INTO `wbt_text_in_lang` (wbxl_text_id,wbxl_language)
VALUES (''y,'es'),('x','fr')" to "Database deadlock in
Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster
query".
TASK DETAIL
https://phabricator.wikimedia.org/T283198
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Krinkle
Cc: Michael, Addshore, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Invadibot,
maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention
Krinkle added a comment. It's not documented to my knowledge, but it is a pattern that is followed quite consistently throughout our software and elsewhere in the industry as relating to how StatsD, Graphite and Prometheus are used. Metrics follow a left-to-right hierarchy. In Prometheus this is done with underscores, in StatsD this is done with dots. There is generally one main segment at the start for the overal service or component, then a segment for the metric being measured, and then labels (Prometheus), hash tags (dogstatsd), or subcomponents (statsd/Graphite). The labels/subcomponents should only be used to represent subslices of the same metric, not to create entirely different metrics. So, for example, you would have `foo_bar_request_count.wiki` and `foo_bar_request_size.wiki` and not `foo_bar_request.wiki.request_count` and `foo_bar_request.wiki .request_size. This is also reflected on https://prometheus.io/docs/practices/naming/, because incompatible data structures would otherwise clash and result in non-sensical visualisations when later segments are left out of the query with a wildcard. This ensures maxium benefit of the wider ecosystem through Grafana, such as autocompletion, wildcard queries, and templates. And also reduces chances of conflicts with unrelated metrics clashing in the same timeseries database directory. Remember that for Graphite, each dot-component is a subdirectory on disk where a file is stored, so `enwiki.wikibase.client.scribunto.wikibase.getEntityStatements.cache_miss` gets stored in `/var/lib/carbon/enwiki/wikibase/client/scribunto/wikibase/getEntityStatements/cache_miss/rate.wsp`, for example. TASK DETAIL https://phabricator.wikimedia.org/T292601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Krinkle, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T255706: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock
Krinkle removed a project: Wikimedia-Rdbms. TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender, Ladsgroup, Krinkle, eprodromou, aaron, Michael, Addshore, Aklapper, thcipriani, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Rayssa-, Agabi10, Dinoguy1000 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279585: Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)
Krinkle renamed this task from "Error on wmf.38 when parsing edit summary via API: Content serialization failed: Failed to decode as application/json" to "Content serialization failed: Failed to decode as application/json (when parsing edit summary via API)". TASK DETAIL https://phabricator.wikimedia.org/T279585 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, Krinkle, RhinosF1, matmarex, dduvall, Aklapper, LucasWerkmeister, Invadibot, maantietaja, Naike, Akuckartz, eprodromou, darthmon_wmde, WDoranWMF, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Sethakill, dg711, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wong128hk, Verdy_p, Wikidata-bugs, aude, jayvdb, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292446: Change Dispatching should not stumble over mowiki redirecting to rowiki
Krinkle added a comment. `mowiki` is a deleted wiki, which is no longer recognised or served anywhere from the MW side. See also https://noc.wikimedia.org/conf/highlight.php?file=dblists/deleted.dblist. `huwikinews` is a closed wiki, which are fully functional and publicly served with existing pages that may also be active Wikidata clients. The only thing about closed wikis from an infra perspective, is that people cannot register new accounts and that (most) people are unable to make edits there. I don't know exactly what the impact of removing subscriptions is at T292440#7398803 <https://phabricator.wikimedia.org/T292440#7398803>, but my gut sense is that closed wikis should not be treated differently from open wikis for most purposes. It might be okay to not send them change propagations, but that could potentially cause problems. E.g. closed wikis do still use parser cache, and Commons, and they can still receive purges and the ocasional edit from a global bot or interface editor. TASK DETAIL https://phabricator.wikimedia.org/T292446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Aklapper, Michael, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T292601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Akuckartz, lucamauri, Vali.matei, _jensen, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T292601: Confirm Wikibase LuaFunctionCallTracker to statsd naming convention
Krinkle created this task. Krinkle added projects: MediaWiki-extensions-WikibaseClient, Wikibase-Lua, Performance-Team (Radar). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The stats from LuaFunctionCallTracker are perhaps a bit too deep and integrated into the global namespace of stats messages. For example: enwiki.wikibase.client.scribunto.wikibase.getEntityStatements.cache_miss:100|c enwiki.wikibase.client.scribunto.wikibase.getEntityStatements.call:100|c wikipedia.wikibase.client.scribunto.wikibase.getEntity.call:100|c wikipedia.wikibase.client.scribunto.wikibase.getEntityStatements.call:100|c Compared to: resourceloader_build.all:0.12707710266113|ms resourceloader_build.user_options:0.12707710266113|ms wanobjectcache.resourceloader_titleinfo.hit.volatile:0.41294097900391|ms wanobjectcache.filerepo_file.hit.good:0.50878524780273|ms In particular: - The fragments (sitegroup, wikiid) are top-level metrics whereas these should go to the end to avoid conflicts with other metrics. - There is no containing metric for LuaFunctionCallTracker which makes these difficult to discover and organize. Source code: - Wikibase: LuaFunctionCallTracker.php <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/37219bf67b1d3c8453e48b564a109360278b3db9/client/includes/DataAccess/Scribunto/LuaFunctionCallTracker.php#95> - Wikibase: mw.wikibase.lua <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/37219bf67b1d3c8453e48b564a109360278b3db9/client/includes/DataAccess/Scribunto/mw.wikibase.lua#155> (call example) I suggest the following metric pattern instead: wikibase_client_lua_tracker_by_wiki . . wikibase_client_lua_tracker_by_sitegroup . . Where `key` would be a single segment, eg. dots converted to underscores using ` strtr( $key, '.', '_' )` . The Grafana dashboard can continue to query and plot multiple of these using wildcards, which are supported on segments as well. We can even copy over the existing data if preferred, using ad-hoc scripting on the Graphite which I can help with (and we've done this few times before). This is also in preparation for Prometheus, to make the metric ready for the conversion. From a 5 minute capture in production, this was the only metric source I found that was not grouping its metrics or that was using many more subsegments than seem to logically expected from the underlyng source code. TASK DETAIL https://phabricator.wikimedia.org/T292601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, Akuckartz, lucamauri, Vali.matei, _jensen, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T68025: [Story] Monitor size of some Wikidata database tables
Krinkle assigned this task to Addshore. Krinkle added a comment. Restricted Application added a project: User-Addshore. Is this task considered resolved, or is there more? I'm triaging the oldest open incident follow-ups, and this appears done. I've seen the Grafana: Wikidata reliability <https://grafana.wikimedia.org/d/79S1Hq9Mz/wikidata-reliability-metrics?orgId=1=29> dashboard, which is quite nice! Also related: T291332 <https://phabricator.wikimedia.org/T291332>. TASK DETAIL https://phabricator.wikimedia.org/T68025 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Krinkle Cc: Krinkle, Manuel, LSobanski, Marostegui, Ladsgroup, Reedy, ArielGlenn, Liuxinyu970226, GoranSMilovanovic, Addshore, jcrespo, Ricordisamoa, hoo, Aklapper, daniel, JanZerebecki, Lydia_Pintscher, Invadibot, Devnull, maantietaja, Akuckartz, Iflorez, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, QZanden, LawExplorer, Minhnv-2809, elukey, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287206: Add link to add interwiki links back to the sidebar
Krinkle added a comment. I ran into a New Vector wiki while logged-out, and noticed this doesn't seem to look quite right: https://pt.wikipedia.org/wiki/Algoritmo F34611515: Screenshot 2021-08-20 at 16.20.25.png <https://phabricator.wikimedia.org/F34611515> It has the grey right-aligned pencil styling as if it were at the end of a list of language links. I assume this styling is no longer meant to apply. Perhaps this is due to a change that was incompatible with our caching in production? (I suspect, since it doesn't appear to be this way everywhere) TASK DETAIL https://phabricator.wikimedia.org/T287206 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Edtadros, Krinkle Cc: Krinkle, BEANS-X2, PPham, Edtadros, sgrabarczuk, bwang, Mike_Peel, cjming, Aklapper, Lydia_Pintscher, alexhollender, Jdlrobson, Ladsgroup, Addshore, Theklan, ovasileva, Patafisik_WMF, Invadibot, Selby, maantietaja, Akuckartz, Demian, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T112243: Overwriting a redirect using wbeditentity causes an exception
Krinkle added a project: Wikimedia-production-error. Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T112243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Lydia_Pintscher, StudiesWorld, hoo, Ricordisamoa, pywikibot-bugs-list, jayvdb, Aklapper, Invadibot, Jyoo1011, maantietaja, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Akuckartz, Zkhalido, darthmon_wmde, Viztor, Nandana, Wenyi, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, Verdy_p, mys_721tx, Wikidata-bugs, aude, Masti, Alchimista, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T112243: Overwriting a redirect using wbeditentity causes an exception
Krinkle added a comment. Searching over the last 90 days in Logstash for `message:*UnresolvedRedirectException` on the mediawiki-errors dashboard, I find only entries like "Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q..", and those stopped mid-July (ref T283862 <https://phabricator.wikimedia.org/T283862>, T251876 <https://phabricator.wikimedia.org/T251876>, T251880 <https://phabricator.wikimedia.org/T251880>, T93273 <https://phabricator.wikimedia.org/T93273>). TASK DETAIL https://phabricator.wikimedia.org/T112243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Lydia_Pintscher, StudiesWorld, hoo, Ricordisamoa, pywikibot-bugs-list, jayvdb, Aklapper, Invadibot, Jyoo1011, maantietaja, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, Wikidata-bugs, aude, Masti, Alchimista, Mbch331, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
