Krinkle added a comment.
In T298509#7609799 <https://phabricator.wikimedia.org/T298509#7609799>, @cscott wrote: > In my personal opinion, rMW1d7221d066c0 <https://phabricator.wikimedia.org/rMW1d7221d066c01c3fa6fb3e539cebd9fe7a91550f> was a mistake: as a MediaWiki developer I have just about every extension every authored checked out in an `extensions` directory, and I enable them on demand via LocalSettings.php. But after `rMWcf4654399bd3` phpunit completely ignores my LocalSettings.php and runs tests on every extension it finds in the directory, regardless of whether it is currently enabled/configured/set up, etc. So I have to resort to storing my extensions out of the tree and a hack in my LocalSettings.php that creates symlinks in my `extensions/` directory to correspond to the current set of enabled extensions. That's annoying. […] I'm unable to reproduce this nor see how it could happen. I don't doubt you're experiencing it, but I am fairly confident that this is not in any way desirable or intended functionality and either result of a bug or an accident/misunderstanding in configuration. The linked patch discovers `tests/phpunit` in enabled extensions. It does not discover extensions. It uses ExtensionRegistry, which iterates over enabled extensions at run-time in the same way as e.g. Special:Version does. The only code I'm aware of that discovers uninstalled extensions, is the CLI installer where Antoine recently added a way for CI to quickly install MW with all extensions enabled that are present on disk, such that the logic for deciding which extensions to install in CI for a given repo is tied to which extension repos are cloned, and then MW takes it all. That's opt-in though, and afaik not something we expose to PHPUnit. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, aude, Dinoguy1000, ssastry, Arlolra, Addshore, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
