[Wikidata-bugs] [Maniphest] [Commented On] T141859: [Task] Contemporary constraint check

2018-02-02 Thread abian 
abian added a comment.
Update: I have finished formalizing this constraint as a part of my final degree project, and I will start implementing it at some point in the coming weeks so that this can be finished around May. I will keep you informed. :-)TASK DETAILhttps://phabricator.wikimedia.org/T141859EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Jklamo, Ivan_A_Krestinin, PokestarFan, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Wikibase-Quality-Constraints, abian, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T141859: [Task] Contemporary constraint check

2018-02-02 Thread abian 
abian renamed this task from "[Task] Contemporary Constraint check" to "[Task] Contemporary constraint check".abian removed a project: Need-volunteer.abian updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONImplement a check on Wikidata for [[ https://www.wikidata.org/wiki/Template:Constraint:Contemporary | Contemporary constraint ]].

Proposed assertions (if true, there isn't a constraint violation; if false, there is a constraint violation):

* **Text**: if [item A] has this property (Pn) linked to [item B], then [item A] and [item B] have to coincide or coexist at some point of history according to properties `P569` (date of birth), `P570` (date of death), `P571` (inception), `P576` (dissolved or abolished), `P580` (start time) and `P582` (end time).
* **Formally**:

```
 (
 (
 A.P580 ≤ B.P582 OR
 A.P580 ≤ B.P570 OR
 A.P580 ≤ B.P576 OR
 A.P569 ≤ B.P582 OR
 A.P569 ≤ B.P570 OR
 A.P569 ≤ B.P576 OR
 A.P571 ≤ B.P582 OR
 A.P571 ≤ B.P570 OR
 A.P571 ≤ B.P576
 ) OR (
 NOT EXISTS A.P580 AND
 NOT EXISTS A.P569 AND
 NOT EXISTS A.P571
 ) OR (
 NOT EXISTS B.P582 AND
 NOT EXISTS B.P570 AND
 NOT EXISTS B.P576
 )
 ) AND (
 (
 B.P580 ≤ A.P582 OR
 B.P580 ≤ A.P570 OR
 B.P580 ≤ A.P576 OR
 B.P569 ≤ A.P582 OR
 B.P569 ≤ A.P570 OR
 B.P569 ≤ A.P576 OR
 B.P571 ≤ A.P582 OR
 B.P571 ≤ A.P570 OR
 B.P571 ≤ A.P576
 ) OR (
 NOT EXISTS B.P580 AND
 NOT EXISTS B.P569 AND
 NOT EXISTS B.P571
 ) OR (
 NOT EXISTS A.P582 AND
 NOT EXISTS A.P570 AND
 NOT EXISTS A.P576
 )
 )
```

It would be great that the set of "properties of start" and the set of "properties of end" could be modified somehow over time.Implement the [[ https://www.wikidata.org/wiki/Template:Constraint:Contemporary | contemporary constraint ]] in Wikidata.

It would be great that the set of "properties of start" and the set of "properties of end" could be modified somehow over time.

TASK DETAILhttps://phabricator.wikimedia.org/T141859EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: abianCc: Jklamo, Ivan_A_Krestinin, PokestarFan, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Wikibase-Quality-Constraints, abian, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T186367: Don't show "No label defined" if no label was found in any of the fallback languages

2018-02-02 Thread Amire80 
Amire80 created this task.Amire80 added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, I18n.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONTo reproduce:


Set your language in Wikidata to English.
Go to an item that doesn't have a label in English (example query)


Instead of a label, the words "No label defined" are shown (it's the wikibase-label-empty message).

It would be more useful to show some label than to show nothing at all.

There is a related bug, which was marked as resolved: T88193: Create label fallback mechanism. But the problem, as described in this bug, still remains.TASK DETAILhttps://phabricator.wikimedia.org/T186367EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Amire80Cc: Amire80, Aklapper, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T186365: In Wikidata Query tool the tooltip arrow looks broken in RTL languages

2018-02-02 Thread Amire80 
Amire80 created this task.Amire80 added projects: RTL, Wikidata Query UI.Herald added a subscriber: Aklapper.Herald added a project: I18n.
TASK DESCRIPTIONScreenshot:

F12969109: Screenshot-2018-2-2 Wikidata Query Service.png

Notice how the arrow at the top looks like two triangles.

In English it's just one nice clear triangle.TASK DETAILhttps://phabricator.wikimedia.org/T186365EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Amire80Cc: Amire80, Aklapper, Gq86, Lucas_Werkmeister_WMDE, Jayprakash12345, EBjune, merbst, Srdjan_m, Jonas, Xmlizer, MuhammadShuaib, LNDDYL, Psychoslave, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T178712: Support continuation for WDQS MWAPI

2018-02-02 Thread Smalyshev 
Smalyshev closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: gerritbot, Jarekt, Aklapper, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T178721: WDQS tests unstable with some thread leak errors

2018-02-02 Thread Smalyshev 
Smalyshev removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Gehel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T42656: [Task] Wikibase: have test coverage of JavaScript QUnit tests

2018-02-02 Thread Legoktm 
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T42656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Liuxinyu970226, Aklapper, Danwe, Krinkle, Wikidata-bugs, Tobi_WMDE_SW, Denny, JeroenDeDauw, adrianheine, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, aude, Mbch331, Jay8g, hashar, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T88435: [Task] generate patch code coverage on gerrit patch-set upload for wikibase.git

2018-02-02 Thread Legoktm 
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T88435EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Liuxinyu970226, Zppix, Lydia_Pintscher, Aklapper, JanZerebecki, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, hashar, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T88434: jenkins job to generate wikibase.git coverage

2018-02-02 Thread Legoktm 
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T88434EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Ricordisamoa, Addshore, Legoktm, hashar, JanZerebecki, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T185211: Generate coverage report for Wikidata extensions

2018-02-02 Thread Legoktm 
Legoktm added a project: Test-Coverage.
TASK DETAILhttps://phabricator.wikimedia.org/T185211EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: gerritbot, hashar, Addshore, Legoktm, greg, Aklapper, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T150204: Enable autocomplete for the textboxes on Special:MergeItems

2018-02-02 Thread matej_suchanek 
matej_suchanek added subscribers: Jan_Dittrich, daniel.matej_suchanek merged a task: T176404: Item merging should be possible without remembering Q-IDs.
TASK DETAILhttps://phabricator.wikimedia.org/T150204EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: daniel, Jan_Dittrich, Lea_Lacroix_WMDE, Lydia_Pintscher, Huji, Aklapper, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T176404: Item merging should be possible without remembering Q-IDs

2018-02-02 Thread matej_suchanek 
matej_suchanek closed this task as a duplicate of T150204: Enable autocomplete for the textboxes on Special:MergeItems.
TASK DETAILhttps://phabricator.wikimedia.org/T176404EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: daniel, Lydia_Pintscher, Aklapper, Jan_Dittrich, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JGirault, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T183081: Clean up mediawiki/extensions/Wikibase ACL

2018-02-02 Thread Legoktm 
Legoktm added a comment.
Compare the Wikibase ACL with a normal MediaWiki extension, e.g. https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MassMessage,access - it really should look like the latter.

However, this only makes sense if nobody in no other extension Wikibase runs it's tests against can ever force-merge anything. Is this given?

Nope. Force merges are allowed in mediawiki/core, vendor, most extensions, etc. (And to be clear, I don't have an opinion either way here, I just want it to be one way or the other, not half in the middle)TASK DETAILhttps://phabricator.wikimedia.org/T183081EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: thiemowmde, hoo, aude, Lydia_Pintscher, WMDE-leszek, demon, Aklapper, Legoktm, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, jayvdb, Paladox, Mbch331, Jay8g, Krenair, QChris, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T186308: "Your skin is incompatible with VisualEditor" in Wikidata

2018-02-02 Thread eranroz 
eranroz added a comment.
The first question would be are wikidata sure they want wgIsArticle to be true on item pages?

I suppose this is correct, usually the main/content namespace is "wgIsArticle" (I dont know of any wiki site for which it is false in the main NS).
Possibly this warning can be shown also based on a check with wgVisualEditorConfig.namespaces?TASK DETAILhttps://phabricator.wikimedia.org/T186308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Esanders, jhsoby, Aklapper, eranroz, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Srdjan_m, Jrf, Husun1297, Wikidata-bugs, aude, Deskana, Swainr, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186356: Wikidata should fire "wikipage.content" when an edit is published

2018-02-02 Thread He7d3r 
He7d3r added projects: _javascript_, Easy, Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186356EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: He7d3rCc: Aklapper, He7d3r, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, enigmaeth, rohitt, Zoranzoki21, LawExplorer, TerraCodes, MuhammadShuaib, Dixtosa, SimmeD, Wikidata-bugs, aude, Dinoguy1000, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T178712: Support continuation for WDQS MWAPI

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 406241 merged by jenkins-bot:
[wikidata/query/rdf@master] Support continuations in MWAPI

https://gerrit.wikimedia.org/r/406241TASK DETAILhttps://phabricator.wikimedia.org/T178712EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev, gerritbotCc: gerritbot, Jarekt, Aklapper, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186308: "Your skin is incompatible with VisualEditor" in Wikidata

2018-02-02 Thread Esanders 
Esanders added a comment.
This appears on all wikidata item pages: https://www.wikidata.org/wiki/Q45554042

This is similar to T186174. VE is attempting to register itself because wgIsArticle is true, but then stops because the page doesn't have the correct UI components for article editing.

The first question would be are wikidata sure they want wgIsArticle to be true on item pages?TASK DETAILhttps://phabricator.wikimedia.org/T186308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EsandersCc: Esanders, jhsoby, Aklapper, eranroz, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Srdjan_m, Jrf, Husun1297, Wikidata-bugs, aude, Deskana, Swainr, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Reopened] T178721: WDQS tests unstable with some thread leak errors

2018-02-02 Thread Smalyshev 
Smalyshev reopened this task as "Open".Smalyshev added a comment.
Reopening, still happens: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven/238/consoleTASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, SmalyshevCc: Gehel, Aklapper, Smalyshev, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T132665: Commons categories' "in Wikipedia" sidebar should always link all languages

2018-02-02 Thread matej_suchanek 
matej_suchanek added a project: Commons.
TASK DETAILhttps://phabricator.wikimedia.org/T132665EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: El_Grafo, Aklapper, Steinsplitter, Tpt, Nemo_bis, JEumerus, Lahi, Gq86, Minilexikon, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, Wong128hk, Wikidata-bugs, aude, Dinoguy1000, Shizhao, Gabrielchihonglee, TTO, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- to be continued…

Left to do:[ ] [constraint scope arguments](https://gerrit.wikimedia.org/r/407708)
  - [ ] prior [refactoring](https://gerrit.wikimedia.org/r/407707)
- [ ] [constraint scope list arguments](https://gerrit.wikimedia.org/r/407709)
- add- [ ] [language argument type “constraint scope” (incl. lists](https://gerrit.wikimedia.org/r/407710)
- add argument type “language”, probably (corresponds to one param for autonym and one param for language code)- to be continued…

Left to do:
- {T185999}...TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407709 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scope lists to ViolationMessage

https://gerrit.wikimedia.org/r/407709TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for language to ViolationMessage

https://gerrit.wikimedia.org/r/407710TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for constraint scopes to ViolationMessage

https://gerrit.wikimedia.org/r/407708TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407707 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject Config into ViolationMessageRenderer

https://gerrit.wikimedia.org/r/407707TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T178492: Create a more controlled WDQS cluster

2018-02-02 Thread debt 
debt closed subtask T184083: Define the constraints of the new WDQS cluster as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T178492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: debtCc: Daniel_Mietchen, BBlack, Lydia_Pintscher, Volans, mobrovac, Jonas, Aklapper, debt, Smalyshev, Gehel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Avner, FloNight, Xmlizer, Susannaanas, Eevans, Aschroet, Jane023, jkroll, Hardikj, Wikidata-bugs, Jdouglas, PKM, Base, matthiasmullie, aude, Tobias1984, Manybubbles, Ricordisamoa, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T184083: Define the constraints of the new WDQS cluster

2018-02-02 Thread debt 
debt closed this task as "Resolved".debt added a comment.
TASK DETAILhttps://phabricator.wikimedia.org/T184083EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Gehel, debtCc: debt, EBernhardson, Lucas_Werkmeister_WMDE, Smalyshev, Gehel, Aklapper, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, SandraF_WMF, GoranSMilovanovic, QZanden, EBjune, Tramullas, Acer, merbst, LawExplorer, Avner, Jdrewniak, Jonas, FloNight, Xmlizer, Susannaanas, Aschroet, Jane023, jkroll, Wikidata-bugs, Jdouglas, PKM, Base, matthiasmullie, aude, Tobias1984, Manybubbles, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- add argument type “constraint scope” (incl. list)
- add argument type “language”, probably (corresponds to one param for autonym and one param for language code)...TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- remove most of `ConstraintParameterRenderer`
- remove injected `ConstraintParameterRenderer` from checkers and helpers (at this point, it might be interesting to check the `git diff --stat 407387c src/`)TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T185332: Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)

2018-02-02 Thread thiemowmde 
thiemowmde added a comment.
I'm bringing this up because this ticket is linked to the "derived labels" ticket T175030, but I do not think this ticket here will help in any way with that. Having a better LexemeIdFormatter will probably not help much when it comes to the search integration. And RDF is even unrelated to HTML, so having a better HTML formatter can't help there either.

This is not an issue we need to care about now. What the first patch proposes is totally fine. I think at this point we should only care about T184997 and get it done (ideally with proper prefetching in place, which is currently missing).TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- to be continued…

Left to do:
- add argument type “constraint scope”
- add argument type “language”, probably (corresponds to one param for autonym and one param for language code)
- {T185999}
- //after that//, use `ViolationMessage` in `ConstraintParameterException`. Requires s11n because `SparqlHelper` serializes and deserializes CPEs in the regex cache.
- remove support for plain `string` messages from `ViolationMessageRenderer`
- remove most of `ConstraintParameterRenderer` (at this point, it might be interesting to check the `git diff --stat 407387c src/`)TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T185688: Constraint check results are cached independent of language

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
I just realized that we also have the same problem in some code that’s already deployed on wikidata.org – the “text matches regex” cache can contain a serialized ConstraintParameterException, where “serialized” means “take the localized message and put it in the cache” :( see I1671255279 / T183992.TASK DETAILhttps://phabricator.wikimedia.org/T185688EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185332: Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)

2018-02-02 Thread WMDE-leszek 
WMDE-leszek added a comment.
What the patches don't cover (possibly because of this tasks wording) are:


How to put derived Lexeme labels, descriptions, and "aliases" a.k.a. "secondary labels" (whatever that is on a Lexeme, maybe the Forms?) into wb_terms and search indexes?
Is an EntityIdFormatter (possibly a plain text one) enough to have proper Lexeme labels in RDF exports?


This indeed not done. Are these necessary for get lexemes in the statement on on lexeme (or item) page?
I suspecting wb_terms would be ralated to searching for the lexeme, when adding it to the statement. But searching is different thing, that we are actually going to jump on after solving the display part.
But I might have easily missed something, so if there are more requirements, this should be added indeed.TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: thiemowmde, gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T186163: BadMethodCallException on diff pages of deleted revisions

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the Wikidata-Sprint-2018-01-31 board.Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a comment.
Should be fixed now, and it’s probably not worth backporting, so closing this.TASK DETAILhttps://phabricator.wikimedia.org/T186163WORKBOARDhttps://phabricator.wikimedia.org/project/board/3216/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, thiemowmde, Framawiki, Sjoerddebruin, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Multichill, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407657 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage for FormatChecker

https://gerrit.wikimedia.org/r/407657TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [extra test](https://gerrit.wikimedia.org/r/407044)
- [ ] [inline code arguments](https://gerrit.wikimedia.org/r/407653)
- [ ] `ViolationMessageRenderer` refactorings [1](https://gerrit.wikimedia.org/r/407654), [2](https://gerrit.wikimedia.org/r/407655)
- [ ] [multilingual text arguments](https://gerrit.wikimedia.org/r/407656)
  - [ ] [messages with such arguments](https://gerrit.wikimedia.org/r/407657)
- to be continued…TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407655 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Simplify ViolationMessageRenderer::renderArgument

https://gerrit.wikimedia.org/r/407655TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for multilingual text to ViolationMessage

https://gerrit.wikimedia.org/r/407656TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407654 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make ViolationMessageRenderer::renderArgument return params

https://gerrit.wikimedia.org/r/407654TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407653 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for inline code to ViolationMessage

https://gerrit.wikimedia.org/r/407653TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T185332: Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)

2018-02-02 Thread thiemowmde 
thiemowmde added a comment.
In addition to a few more specific comments I left on the Gerrit patches, here is what I think about the different approaches:

LexemeIdHtmlFormatter

https://gerrit.wikimedia.org/r/406306 registers a formatter via the existing registry infrastructure Wikibase provides (namely "formatter-factory-callback"). This formatter can exclusively turn LexemeId objects into HTML strings. This formatter is automatically used in almost all cases we care about (LexemeId references in statements, special pages, even summary lines, I believe).

Note there was already a LexemeIdHtmlFormatter. The patch just replaces it with an other one that does not hard-code so much knowledge, but relies on a message instead.

I like this approach very much because it is so self-contained. I suggest to implement this no matter how we are going to implement derived labels (see T175030) later. The only detail we need to think about is a proper caching layer for this formatter (including prefetching), to avoid fetching possibly hundreds of Lexemes via an EntityLookup, which is what the code in the patch currently does.

EntityPresenter

The approach presented in https://gerrit.wikimedia.org/r/406608 is not different, but builds on top of the first. It still is just a "formatter-factory-callback" utilizing the existing ….datatypes.php infrastructure.

It introduces the concept of "primary" and "secondary labels" that come in pairs. The patch starts using this concept in a single place in the LexemeIdHtmlFormatter. At this point this is not much more but some formatter logic factored out into a separate class. The only difference users will see is that the messages translators are going to see are constructed in an other, more modular way.

As the patch is now, it does not even need the interfaces in Wikibase. This can be seen in https://gerrit.wikimedia.org/r/406612: the code introduced there is not used in Wikibase. I believe the "primary/secondary label" concept is meant to be used in more places. But at this point I can not tell where.



What the patches don't cover (possibly because of this tasks wording) are:


How to put derived Lexeme labels, descriptions, and "aliases" a.k.a. "secondary labels" (whatever that is on a Lexeme, maybe the Forms?) into wb_terms and search indexes?
Is an EntityIdFormatter (possibly a plain text one) enough to have proper Lexeme labels in RDF exports?
TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T175491: [Bug] Particular wikibase-…-summary-…-update autocomments are missing in en.json

2018-02-02 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).
TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, ReleaseTaggerBotCc: gerritbot, TerraCodes, aude, thiemowmde, Lydia_Pintscher, matej_suchanek, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, SimmeD, Wikidata-bugs, Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T146750: Wiki(pedi)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge)

2018-02-02 Thread Chicocvenancio 
Chicocvenancio edited projects, added Tools; removed Toolforge.
TASK DETAILhttps://phabricator.wikimedia.org/T146750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01, ChicocvenancioCc: Yaron_Koren, Tinaj1234, Slaporte, Aklapper, Lydia_Pintscher, hoo, 01tonythomas, Bene, D3r1ck01, Cpaulf30, 1978Gage2001, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, Chicocvenancio, QZanden, Tbscho, LawExplorer, JJMC89, Wikidata-bugs, aude, Dinoguy1000, Gryllida, scfc, Mbch331, Jay8g, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T183253: [Task] Update Wikibase CodeSniffer to use php_codesniffer 3.x

2018-02-02 Thread thiemowmde 
thiemowmde closed this task as "Resolved".thiemowmde updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...[x] Update custom test runner to work with php_codesniffer 3.x: https://github.com/wmde/WikibaseCodeSniffer/pull/16
[x] Review sniffs added in and update to mediawiki-codesniffer 0.9: https://github.com/wmde/WikibaseCodeSniffer/pull/16

From there, we are at 3.x, and all other updates are unrelated "bonuses" to this task:
[x] Review sniffs added in and update to mediawiki-codesniffer 0.90.10: https://github.com/wmde/WikibaseCodeSniffer/pull/17
[x] Review sniffs added in and update to mediawiki-codesniffer 0.100.11: https://github.com/wmde/WikibaseCodeSniffer/pull/18
[x] Review sniffs added in and update to mediawiki-codesniffer 0.110.12: https://github.com/wmde/WikibaseCodeSniffer/pull/19
[x] Review sniffs added in and update to mediawiki-codesniffer 0.1213.0: https://github.com/wmde/WikibaseCodeSniffer/pull/20
[] Review sniffs added in and update to mediawiki-codesniffer 13.014.0: https://github.com/wmde/WikibaseCodeSniffer/pull/24
[] Review sniffs added in and update to mediawiki-codesniffer 14.015.0: https://github.com/wmde/WikibaseCodeSniffer/pull/24TASK DETAILhttps://phabricator.wikimedia.org/T183253EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, Lucas_Werkmeister_WMDE, WMDE-leszek, thiemowmde, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T183081: Clean up mediawiki/extensions/Wikibase ACL

2018-02-02 Thread thiemowmde 
thiemowmde added subscribers: Lydia_Pintscher, aude, hoo, thiemowmde.thiemowmde added a comment.
From looking at the provided page I'm not able to understand the "mess".

I would like to argue for giving all people that already have +2 rights also the right to force-merge. This can be a helpful tool in super-rare situations. I don't recall situations where it was misused (actually I do, but this was 2 years ago, and the person is not around any more).

Taking the possibility to force-merge away from the team does have it's benefit. Most notably: everybody must fix CI first before being able to continue working on it's own stuff, which I consider a good thing. However, this only makes sense if nobody in no other extension Wikibase runs it's tests against can ever force-merge anything. Is this given? Otherwise "they" could still block "us", but we can't unblock, leading to the same situation that inspired this ticket, just the other way around.TASK DETAILhttps://phabricator.wikimedia.org/T183081EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, hoo, aude, Lydia_Pintscher, WMDE-leszek, demon, Aklapper, Legoktm, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, jayvdb, Paladox, Mbch331, Jay8g, Krenair, QChris, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T175491: [Bug] Particular wikibase-…-summary-…-update autocomments are missing in en.json

2018-02-02 Thread gerritbot 
gerritbot added a comment.
Change 407408 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing messages for Wikibase autocomments

https://gerrit.wikimedia.org/r/407408TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: gerritbot, TerraCodes, aude, thiemowmde, Lydia_Pintscher, matej_suchanek, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, SimmeD, Wikidata-bugs, Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T175491: [Bug] Particular wikibase-…-summary-…-update autocomments are missing in en.json

2018-02-02 Thread thiemowmde 
thiemowmde closed this task as "Resolved".thiemowmde edited projects, added Wikidata-Sprint-2018-01-31; removed Patch-For-Review.thiemowmde claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T175491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, TerraCodes, aude, thiemowmde, Lydia_Pintscher, matej_suchanek, Aklapper, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, SimmeD, Wikidata-bugs, Gryllida, Shizhao, Arrbee, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T146750: Wiki(pedi)a RSS user manual updates & IFTTT Flask application UI improvements (on Toolforge)

2018-02-02 Thread D3r1ck01 
D3r1ck01 removed a project: Africa-Wikimedia-Developers.
TASK DETAILhttps://phabricator.wikimedia.org/T146750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Yaron_Koren, Tinaj1234, Slaporte, Aklapper, Lydia_Pintscher, hoo, 01tonythomas, Bene, D3r1ck01, Cpaulf30, 1978Gage2001, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, Chicocvenancio, QZanden, Tbscho, Freddy2001, LawExplorer, JJMC89, Luke081515, Wikidata-bugs, aude, Dinoguy1000, Gryllida, jayvdb, scfc, coren, Mbch331, Jay8g, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T186317: Handle adding and/or removing forms in lexeme diffs

2018-02-02 Thread WMDE-leszek 
WMDE-leszek created this task.WMDE-leszek triaged this task as "High" priority.WMDE-leszek added projects: Lexicographical data, Wikidata, Wikidata-Sprint-2018-01-31.
TASK DESCRIPTIONWhen forms is added, the change should be visible when diffing relevant revisions of the lexeme.
When forms is removed, the change should be visible when diffing relevant revisions of the lexeme.TASK DETAILhttps://phabricator.wikimedia.org/T186317EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Aklapper, thiemowmde, Lydia_Pintscher, Jonas, Ladsgroup, WMDE-leszek, Lahi, Gq86, Cinemantique, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186035: Autocomment-like snippets in labels, descriptions or aliases are rendered like additional autocomments

2018-02-02 Thread thiemowmde 
thiemowmde added subscribers: Lydia_Pintscher, thiemowmde, WMDE-leszek.thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Technical-Debt.thiemowmde added a comment.
I can not think of a good way that utilizes escaping to avoid this.

What we could do is to apply some validation to user-provided summaries, and deny to accept user-provided text that looks like one of our autosummaries.

An other possibility is to add this to our FormatAutocomments hook handler at the top of RepoHooks::onFormat:

if ( $pre ) {
	return;
}

With this, only the first autocomment in a summary line gets parsed and localized. Since all summaries our code produces conform to this (see SummaryFormatter::assembleSummaryString), I believe introducing this limitation would actually be consistent.

Note that T184702 might start using the fact such a limitation was never implemented as a feature.TASK DETAILhttps://phabricator.wikimedia.org/T186035EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: WMDE-leszek, thiemowmde, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T184702: Set the edit summary when editing the representation and/or grammatical features of the form (days: 10)

2018-02-02 Thread thiemowmde 
thiemowmde added a comment.
From the discussion I had with @Lydia_Pintscher on Wednesday:


In our discussion we confirmed this: The user is able to edit as many grammatical features and representations as he wants the same time. One click on the save button should trigger one API request, and result in one history entry with one summary line.
Concatenating multiple atomic localizable summaries is a new concept for Wikibase and wikidata.org. (Even if is not a new concept for MediaWiki core.)
In the discussion we concluded we don't want to introduce this new concept (with all the consequences that follow, including UX considerations) right now. Possibly later, but not for this story.
Summary lines should be precise. Ideally the line should allow to understand what an edit is about without looking at the diff.
But this does not mean that all summary lines must always repeat all details from the edits they describe, no matter how complex the edit is. That's still the job of the diff.
Lydia estimated that use cases where only one element is touched (e.g. only one grammatical feature, or only one representation) are the majority. That's what Lydia cares about. If the majority of edits does have precise summaries, Lydia is happy. The remaining use cases that produce generic summary lines can be improved later, if needed.


The summary lines needed right now are:


Adding one or more grammatical features: "Added {{PLURAL:grammatical feature|grammatical features}} of L1-F1: …, …"
Removing one or more grammatical features: "Removed {{PLURAL:grammatical feature|grammatical features}} of L1-F1: …, …"
Adding one or more representations: "Added {{PLURAL:representation|representations}} of L1-F1: en: …, de: …"
Removing one or more representations: "Removed {{PLURAL:representation|representations}} of L1-F1: en: …, de: …"
Editing one or more representations: "Edited {{PLURAL:representation|representations}} of L1-F1: en: …, de: …"
A generic summary for all other types of edits.


Two additional summaries can be considered (@Lydia_Pintscher, please decide):


When grammatical features are added and remove the same time, a generic summary can say "Changed {{PLURAL:grammatical feature|grammatical features}} of L1-F1: …, …". The list does not show what's removed or added, but all elements that are there after the edit.
When representations are added, remove, and/or changed the same time, a generic summary can say "Changed {{PLURAL:representation|representations}} of L1-F1: en: …, de: …". The list does not show what's removed or added, but all elements that are there after the edit. Note: This is a new suggestion currently not listed in the tasks description. The difference between "Edited representations" and "Changed representations" is that "Edited" only lists elements that are actually touched in an edit, while "Changed" must list all.
TASK DETAILhttps://phabricator.wikimedia.org/T184702EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: thiemowmde, gerritbot, daniel, Aklapper, Jonas, Lydia_Pintscher, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186161: What to do if the WDQS does not synchronise with Wikibase?

2018-02-02 Thread Addshore 
Addshore added a comment.
So you can have a look at the log for everything (checkout the docker-compose logs command), a paste of those would help pin down what happened.
Although if you have already run 'down' then the containers have been removed and the logs won't exist any more.

When I then tried to run some SPARQL queries in the WDQS the WDQS gave a nginx error

What error exactly? Again you can see what was happening in cases like this by looking at the logs of the containers.

I waited an evening for the wdqs to pick up. Unfortunatly still not updates

It looks like you are running into the exact issue that T182394 was filed for (though that is a guess without seeing the logs).
Per T182394#3938346 the fix we need will be in 0.3.0 of the query service which is currently blocked on T178712TASK DETAILhttps://phabricator.wikimedia.org/T186161EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Andrawaag, Aklapper, Abbe98, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T185710: Introduce class for constraint violation messages (days: 1)

2018-02-02 Thread WMDE-leszek 
WMDE-leszek renamed this task from "Introduce class for constraint violation messages" to "Introduce class for constraint violation messages (days: 1)".
TASK DETAILhttps://phabricator.wikimedia.org/T185710EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, Aklapper, Lucas_Werkmeister_WMDE, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T185332: Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)

2018-02-02 Thread WMDE-leszek 
WMDE-leszek renamed this task from "Investigation: How to make it possible to format a Lexeme used in a statement (days: 3)" to "Investigation: How to make it possible to format a Lexeme used in a statement (days: 4)".
TASK DETAILhttps://phabricator.wikimedia.org/T185332EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, Aklapper, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T184702: Set the edit summary when editing the representation and/or grammatical features of the form (days: 10)

2018-02-02 Thread WMDE-leszek 
WMDE-leszek renamed this task from "Set the edit summary when editing the representation and/or grammatical features of the form (days: 9)" to "Set the edit summary when editing the representation and/or grammatical features of the form (days: 10)".
TASK DETAILhttps://phabricator.wikimedia.org/T184702EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: gerritbot, daniel, Aklapper, Jonas, Lydia_Pintscher, WMDE-leszek, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T185761: Make i18n keys in WikibaseLexeme consistent (days: 5)

2018-02-02 Thread WMDE-leszek 
WMDE-leszek renamed this task from "Make i18n keys in WikibaseLexeme consistent (days: 4)" to "Make i18n keys in WikibaseLexeme consistent (days: 5)".
TASK DETAILhttps://phabricator.wikimedia.org/T185761EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: gerritbot, WMDE-leszek, Aklapper, Ladsgroup, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T185308: Display references next to query results

2018-02-02 Thread Mrjohncummings 
Mrjohncummings added a comment.
Would it be possible to add the name of the organisation producing or providing the data by stripping the URLs to just the root URLs and then  'official website (P856)' to get the name?TASK DETAILhttps://phabricator.wikimedia.org/T185308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MrjohncummingsCc: Mrjohncummings, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Jonas, Xmlizer, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T186218: Show wikidata descriptions on wikipedias

2018-02-02 Thread jhsoby 
jhsoby added a comment.
Many wikis use Yair rand's WikidataInfo.js as a gadget, it's worth taking a look at that.TASK DETAILhttps://phabricator.wikimedia.org/T186218EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Lydia_Pintscher, Addshore, Aklapper, daniel, Lahi, Gq86, Sharvaniharan, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Dbrant, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T186308: "Your skin is incompatible with VisualEditor" in Wikidata

2018-02-02 Thread jhsoby 
jhsoby added a project: Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T186308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsobyCc: jhsoby, Aklapper, eranroz, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Srdjan_m, Jrf, Husun1297, Wikidata-bugs, aude, Deskana, Swainr, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T74318: [Task] add possibility to generate proper phpunit coverage reports of Wikibase.git

2018-02-02 Thread Legoktm 
Legoktm added a comment.
See https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Generating_PHP_test_coverage_for_a_MediaWiki_extension for how to get this enabled for Wikibase. I believe this is currently blocked on the fact Wikibase is not following the standard directory layout of src/ or includes/.TASK DETAILhttps://phabricator.wikimedia.org/T74318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Legoktm, Liuxinyu970226, Aklapper, JeroenDeDauw, Wikidata-bugs, Tobi_WMDE_SW, JanZerebecki, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T183081: Clean up mediawiki/extensions/Wikibase ACL

2018-02-02 Thread WMDE-leszek 
WMDE-leszek added a comment.
Wow, what a mess. At this point I see no reason to allow force-pushing, V+2 etc. But will verify whether this is required, and for what reason with my more experienced colleagues.TASK DETAILhttps://phabricator.wikimedia.org/T183081EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, demon, Aklapper, Legoktm, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Luke081515, Wikidata-bugs, aude, jayvdb, Paladox, Mbch331, Jay8g, Krenair, QChris, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T186161: What to do if the WDQS does not synchronise with Wikibase?

2018-02-02 Thread Andrawaag 
Andrawaag added a comment.
I actually don't know when things went wrong. I launched all containers using docker compose. Upon initiation, seems to work. I then launched a bot to populate the wiki base instance. Which ran overnight to at around 180lk items. When I then tried to run some SPARQL queries in the WDQS the WDQS gave a nginx error, which I solved by relaunching all containers.

I have restarted all with the following commands:

sudo /usr/local/bin/docker-compose down



ubuntu@wikibase:~/wikibase-docker$ sudo /usr/local/bin/docker-compose down
Stopping wikibasedocker_wdqs-updater_1  ... done
Stopping wikibasedocker_wdqs-frontend_1 ... done
Stopping wikibasedocker_wikibase_1  ... done
Stopping wikibasedocker_wdqs-proxy_1... done
Stopping wikibasedocker_mysql_1 ... done
Stopping wikibasedocker_wdqs_1  ... done
Removing wikibasedocker_wdqs-frontend_1 ... done
Removing wikibasedocker_wikibase_1  ... done
Removing wikibasedocker_wdqs-proxy_1... done
Removing wikibasedocker_mysql_1 ... done
Removing wikibasedocker_wdqs_1  ... done

The be sure, a reboot, followed by:

ubuntu@wikibase:~/wikibase-docker$ sudo /usr/local/bin/docker-compose up --no-build -d
wikibasedocker_wdqs_1 is up-to-date
wikibasedocker_mysql_1 is up-to-date
wikibasedocker_wdqs-proxy_1 is up-to-date
wikibasedocker_wikibase_1 is up-to-date
wikibasedocker_wdqs-frontend_1 is up-to-date
wikibasedocker_wdqs-updater_1 is up-to-date

I waited an evening for the wdqs to pick up. Unfortunatly still not updates

Am I a missing a specific command?TASK DETAILhttps://phabricator.wikimedia.org/T186161EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AndrawaagCc: Addshore, Andrawaag, Aklapper, Abbe98, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs