[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
gerritbot added a comment. Change 434193 abandoned by Jdlrobson: Add a "standard" compatible wikidata summary endpoint https://gerrit.wikimedia.org/r/434193 TASK DETAIL https://phabricator.wikimedia.org/T111231 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Marsupium, Niedzielski, RodrigoTavares, Salgo60, Jhernandez, WMDE-leszek, bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Masumrezarock100, Dibya, Meekrab2012, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, NebulousIris, Guilhermebm, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, WSH1906, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, Jdrewniak, JEumerus, Scott_WUaS, Ananthsubray, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Lydia_Pintscher added a comment. We said it'd be nice to display the number of statements and sitelinks in order to give people a quick way to see how "good/useful" the item behind the link is. If you see an item has no sitelinks and statements then it's probably not worth clicking because it'll not tell you much more. But it's totally ok from my side to leave this out for now.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. Happy to chat through this. No rush. Please let me know if you would like me to attend any services sync relating to this. It feels like we have a few things to work out with the accept-language header before this patch is ready anyway.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: WMDE-leszek, bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
bearND added a comment. @Jdlrobson As long as you and @phuedx agree on what it should be and it's all in sync with the documentation that sounds all fine to me. It's certainly fine to introduce the new type in a later patch. #Services: The current version of the patch takes the accept-language header to determine the language to be requested from Wikidata. How do we want to proceed for this MCS endpoint? In other words, would you like to store one entry for all languages or multiple entries in Cassandra, one per language?TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: bearNDCc: WMDE-leszek, bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. @bearND I've clarified in the commit that this is seen as iterative and the goal for https://gerrit.wikimedia.org/r/434193 is to be compatible with the standard endpoint. Doing this would allow us to begin experimentation on the beta cluster I've written a POC to demonstrate how we could iterate off this patch to create a new preview type if we decide we want to make changes to the client. I can't comment on the merits of a new summary type right now, but I'm skeptical. I propose we continue that conversation on the talk page.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: WMDE-leszek, bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. Long term we'll probably want to add a 'type' 'wikidata' to https://www.mediawiki.org/wiki/Page_Previews/API_Specification rather than lean on the 'standard' type The first iteration of the patch implements yhe I am happy to drop sitelinks and claims on the short term but keeping the other field names the same simplifies the client greatly and allows us at least to test page previews on wikidata with out any changes whatsoever on page previews.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
bearND added a comment. @Jdlrobson Thanks for the updated patch! @Jdlrobson @phuedx I see some discrepancies between https://www.mediawiki.org/wiki/Page_Previews/API_Specification and this task description. "type": "wikidata" vs "wikidata_preview" Extra attributes: number of sitelinks and claims in @Jdlrobson's patch vs. "wikidata_label" on the spec page. Let's agree on what we want here and update the two sides (task vs spec page) to keep in sync. I'm not sure why we would need the number of sitelinks and claims but I can live with them if they are indeed needed by clients. If there is no immediate use for them I would prefer to keep them out for now. We can add properties later, just not remove them without breaking BWC.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: bearNDCc: bearND, hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, Lewizho99, Maathavan, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
gerritbot added a comment. Change 434193 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/services/mobileapps@master] Add a wikidata summary endpoint https://gerrit.wikimedia.org/r/434193TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: hoo, Vibhabamba, Jdforrester-WMF, Wikidata-bugs, JanZerebecki, Se4598, SamB, Raymond, Quiddity, pizzzacat, gerritbot, Bdjwiki, Trizek-WMF, Jakob_WMDE, Pablo-WMDE, Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, Snowolf, Dcljr, Shizhao, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. I worked on this during the hackathon. This seems relatively straightforward. It needs a new endpoint (POC=https://gerrit.wikimedia.org/r/434193 WIP: Add a wikidata summary endpoint) and configuration like so ($wgPopupsRestGatewayEndpoint = 'http://0.0.0.0:6927/en.wikidata.org/v1/page/summary/') where en is the language. This could be configured on the client and obey user preferences. A minor change in page previews would be needed to support language specific configuration (e.g. $wgPopupsRestGatewayEndpoint = 'http://0.0.0.0:6927/$1.wikidata.org/v1/page/summary/') but apart from that, this is a pure mobileapps change - creating the API. Demo: http://jdlrobson.com/DEMO2.movTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Smalyshev, ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, Dcljr, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. http://jdlrobson.com/DEMO2.movTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, Winter, Salgo60, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, Dcljr, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
ovasileva added a comment. @Jdlrobson - upload video hereTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ovasilevaCc: ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, Zoranzoki21, LawExplorer, Winter, DatGuy, Devwaker, Niklitov, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, Dcljr, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Lydia_Pintscher added a comment. The reason is that labels are what represents a concept. They are used in all kinds of places. They need to have "proper" casing in order to make them usable in all contexts. I am not sure what you mean by differentiating display of content and content in this case.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Nirzar added a comment. @Lydia_Pintscher what is the primary reason for doing that? also is there a way we can differentiate display of content and content itself?TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Lydia_Pintscher added a comment. Yes. The community is spending quite some time explaining to people that labels and descriptions should not start with a capital letter (unless it is a proper noun). If we're showing people the opposite a lot in page previews that'll cause more people to do it wrong imho.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Nirzar added a comment. We use sentence-case for articles, ui elements, and most of the in-product communication as well. ugly seems like a subjective opinion, unless there is an objective reason for changing our conventions, I would avoid making it lowercase. Some relevant information about the use of titlecase/sentence case - https://medium.com/@jsaito/making-a-case-for-letter-case-19d09f653c98 To my knowledge I do not know any product or interface that uses lowercase for titles, hence if you look for research and resources on what to use, lowercase is not part of comparison. Lowercase is usually used in brandmarks and wordmarks for companies to seem more friendly. e.g. facebook. If there is a connotation that the project community uses with letter casing, that would be a different issue. In that case, we should discuss that.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Sjoerddebruin added a comment. Oh yes, sorry. I mean that indeed.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Nirzar added a comment. you mean titlecase?TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Sjoerddebruin added a comment. Are you actually deciding on making all titles uppercase? I still think that is a ugly design choice.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Nirzar added a comment. This is barebones page previews for wikidata. it only has item title and description. F8453797: missing desc.png F8453796: only desc.png F8453795: missing desc with image.png I would like for us to investigate more into relevant and useful metadata that we can surface, but maybe as a follow up... Note on Spec: We will be using same spec as default page previews. height, width, orientation, image dimensions etc. The only thing new here is the typography between title and description. Note on titles: We don't use titles on wikipedia as the blue link exists. They exist on wikidata as well but due to the lack of information to surface we need at least 1 concrete anchor element. we can use Title till we find better solution to this problem. it's actually not even about finding better solution, it's more about the amount of engineering work that will go into it.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111231: Page previews for Wikidata
Jdlrobson added a comment. Needs mock from Nirzar to show how this looks.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson, Liuxinyu970226, Yair_rand, JKatzWMF, Ricordisamoa, Bene, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Winter, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Izno, Luke081515, biplabanand, Wikidata-bugs, Snowolf, Shizhao, Se4598, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
