[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-06 Thread gerritbot 
gerritbot added a comment.
Change 382758 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 045f94babc293704f10a98c8fdced0216fec7feb:

https://gerrit.wikimedia.org/r/382758TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-06 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Dropdown menus show left alignment (it may be valid for "tools", as tools have Latin names, and wrong for "help")

Also, I assume for the “Help” menu, the order of question mark icon, “help” text, and dropdown arrow should be reversed in rtl locales? (The “tools” button seems to handle this better.)TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-06 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
X of the query helper should float left not right

float: inline-end is the magical CSS that does the right thing in both locales… and which is currently only supported by Firefox :(TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-06 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
It may be more correct to have the arrow icon mirrored in RTL

Hm, I’m not sure about that… on https://mideastunes.com/, the arrow points to the right in both the English and the Arabic version. And on YouTube with language set to Arabic, the play button also points to the right. But perhaps this is another thing like the question mark, where it further depends on language?TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-05 Thread eranroz 
eranroz added a comment.

In T171564#3660992, @Jonas wrote:
Is this how it should be?
 F10018211: image.png


More or less yes. The most basic aliveness for it is having LTR for the code area/line numbers/cursor, and it looks like once Lucas patch is deployed it will be use-able in RTL languages.

There are some minor issues of much lower priority that we may want to address in the future like what Smalyshev pointed earlier, for example:


Splitter - dragging left moves it right and vise versa
Dropdown menus show left alignment (it may be valid for "tools", as tools have Latin names, and wrong for "help")
It may be more correct to have the arrow icon mirrored in RTL
X of the query helper should float left not right
Some RTL languages (Arabic, Persian) mirror the question mark for help. In others (Hebrew and probably Yiddish) the question mark is same as in LTR languages (e.g currently shows correct)
TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-05 Thread gerritbot 
gerritbot added a comment.
Change 382402 merged by jenkins-bot:
[wikidata/query/gui@master] Force query editor and hints left-to-right

https://gerrit.wikimedia.org/r/382402TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-05 Thread Jonas 
Jonas added a comment.
Is this how it should be?
F10018211: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Soteriaspace, Jayprakash12345, Th3d3v1ls, JakeTheDeveloper, Rafisamra2016, Ramalepe, Liugev6, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, Lewizho99, Maathavan, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-05 Thread gerritbot 
gerritbot added a comment.
Change 382402 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Force query editor and hints left-to-right

https://gerrit.wikimedia.org/r/382402TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, Rafisamra2016, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T171564: interface Hebrew in left to right from written is query

2017-10-04 Thread eranroz 
eranroz added a comment.
BTW it is so broken that it would be better to de-feature it for now.TASK DETAILhttps://phabricator.wikimedia.org/T171564EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Lucas_Werkmeister_WMDE, Smalyshev, Jonas, Aklapper, eranroz, PokestarFan, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, Rafisamra2016, QZanden, EBjune, Tal-WMIL, Zoranzoki21, merbst, Avner, debt, Gehel, Tzafrir, Srdjan_m, FloNight, Xmlizer, MuhammadShuaib, Izno, LNDDYL, Psychoslave, IKhitron, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Huji, Manybubbles, Amire80, Gryllida, Shizhao, Arrbee, TheDJ, Matanya, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs