[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Hanna_Petruschat_WMDE]

Hanna_Petruschat_WMDE added a comment.


  @Pablo-WMDE thanks for documenting this! I was going a bit further with it, 
trying to create a new account as well. Here is what happened:
  
  1. click "edit pen"
  2. click "Create an Account" in the overlay
  3. create an account page in desktop version opens
  4. created an account
  5. get redirected to the item page I came from (now also in desktop version)
  6. switch to mobile by clicking the "mobile version" link
  7. checking, if I'm still logged in (**I'm not**)
  
  Then the circle of the above begins: clicking the edit pen, click "log in" in 
the overlay, get directed to the desktop log in page, but instantly 
automagically logged in in the background and redirected to the desktop item 
page (without any action of mine).

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Hanna_Petruschat_WMDE was kind enough to showcase this to me, click path is 
a follows
  
  1. open **mobile** item page (trough useformat=mobile query not **m.** 
subdomain), e.g. 
https://wikidata.beta.wmflabs.org/w/index.php?title=Q11&useformat=mobile
  2. click "edit pen"
  3. click "log in" in the overlay
  4. login page in **desktop** layout opens
  5. logging in with correct credentials
  6. item page (same item as before) in **desktop** layout opens
  7. scroll to bottom, click the "Mobile view" link
  8. item page (same item as before) in **mobile** layout opens (trough **m.** 
subdomain)
  9. warning is shown "Central login - You are centrally logged in. Reload the 
page to apply your user settings."
- the page behaves as if not logged in
- reloading does not resolve this - message re-appears, page behaves as not 
logged in
  
  Interestingly the same behavior can be observed when, in step two, clicking 
the "watchlist star" instead of the "edit pen" - i.e. it is not limited 
to/caused by termbox.

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Hanna_Petruschat_WMDE]

Hanna_Petruschat_WMDE added a comment.


  Regarding the notice: When logging in I got redirected to the desktop version 
and needed to switch back to mobile. When doing so, I also got the the notice. 
I could click it away but got it back when reloading as it stated. @Pablo-WMDE  
if you like, you can test and reproduce on my machine.

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Pablo-WMDE]

Pablo-WMDE added a comment.


  @Lea_WMDE It would be interesting to see under which circumstances this (the 
"Central logi" overlay) happens for you - I can't really reproduce this. Even 
if it does not sound like it could be our fault it should still be reproducible.
  
  FWIW the buttons wrapping to multiple lines under certain conditions is a 
known discrepancy from the mocks, but //the way they wrap// was explicitly 
handled in coordination with @Hanna_Petruschat_WMDE. We should have done a 
better job documenting the decision.

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Lea_WMDE]

Lea_WMDE added a comment.


  I checked and there is a few things that I found, but I don't expect any of 
this to be an acceptance blocker:
  
  - If I log in after having clicked on "Log in" on our overlay, when they 
redirect me to the page I receive the info that I am logged in, but need to 
reload:
  
  F29484010: Bildschirmfoto 2019-06-12 um 16.40.59.png 

  This info does not go away, even after hard reloads, and our overlay also 
doesn't disappear. I am assuming that this is a beta wiki issue, and the fact 
that the overlay still shows up is related to the wiki, although knowing that I 
am logged in, not being able to deal with that fact. Do you concur?
  
  - Right now, I think the buttons will be in a separate line each for most of 
the phones. But I  will follow up with @Hanna_Petruschat_WMDE and if necessary, 
this would become a new ticket.

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Pablo-WMDE]

Pablo-WMDE added a comment.


  This is on beta 

 with all sub tasks now.
  Of course, the checkbox (T221833 ) 
is not there yet.
  
  /cc @Lea_WMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[gerritbot]

gerritbot added a comment.


  Change 514009 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Update Termbox
  
  https://gerrit.wikimedia.org/r/514009

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[gerritbot]

gerritbot added a comment.


  Change 514009 had a related patch set uploaded (by Jakob; owner: Jakob):
  [mediawiki/extensions/Wikibase@master] Update Termbox
  
  https://gerrit.wikimedia.org/r/514009

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[gerritbot]

gerritbot added a comment.


  Change 511924 **merged** by jenkins-bot:
  [wikibase/termbox@master] AnonEditWarning: mend styling
  
  https://gerrit.wikimedia.org/r/511924

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Matthias_Geisler_WMDE]

Matthias_Geisler_WMDE added a comment.


  As yesterday here the short summery of how we go on with the font-size 
question:
  OOUI defines the default font-size of 0.875em (===14px)[1]. The only 
exception is for screen-width-sizes of 320px-960px[2], there the font-size is 
1em. After checking out that we need 1em as default font-size for mobile and it 
does not make sense to decrease font size on wider screens. So UX decided to 
keep our current state of 1em(=== 16px ) font-size in Termbox.
  
  1. see: 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/src/themes/wikimediaui/common.less$4-5
  2. play with width of 
https://doc.wikimedia.org/oojs-ui/master/demos/?page=dialogs&theme=wikimediaui&direction=ltr&platform=mobile#demo-section-buttons

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Hanna_Petruschat_WMDE]

Hanna_Petruschat_WMDE added a comment.


  Hi @Pablo, sorry for the late reply. Also: I cannot really get this 
discussion to a farther point I asssume. If I look at the initial fonts on my 
machine, they appear all way heavier than the ones represented in the OOUI 
demos 
.
 I played around with the font weight to get to the numbers mentioned above. So 
maybe it's okay to not see a difference on your device?

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Pablo-WMDE]

Pablo-WMDE added a comment.


  Hi @Hanna_Petruschat_WMDE,
  
  I'm not quite sure what to do about this. I created a patch 
 to reflect the changes requested but am 
uncertain if I should hand it in to the other devs to review or if there will 
be more input about the questions stated above.
  
  Thanks

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[gerritbot]

gerritbot added a comment.


  Change 511924 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [wikibase/termbox@master] AnonEditWarning: mend styling
  
  https://gerrit.wikimedia.org/r/511924

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Pablo-WMDE]

Pablo-WMDE added a comment.


  Hi @Hanna_Petruschat_WMDE,
  
  I looked into your change requests - thanks for the very precise 
instructions. There are a few questions, though.
  
  > 1 Could you change the font weight in the buttons and the headline from 700 
to 500
  
  There are two challenges
  a) For the button this diverges from OOUI (where "bold" = 700 is in use 
).
 Is this intended? Should this change apply for our button component in general 
or is this mean exclusively for the buttons contained in the "You are not 
logged in" overlay?
  b) font-weight support for different fonts is a delicate subject 
.
 Depending on the device and the available fonts some numeric weights do share 
the same actual font used. In my case e.g. all values from 100 to 500 result in 
the same visible weight, consequently for me buttons & headline would then look 
like "normal text".
  
  > 2. Could you change the line heights from 1 to 1.2
  
  Will do
  
  > 3. Could you change the font weight of the message text from 400 to 300
  
  Again, this change effectively causes no visual change on my device.
  
  Depending on the fonts installed the very specific numeric values may make 
sense or not. This is not to say that this change does not bring value to may 
devices, just wanted to bring it to your attention so it is a conscious 
decision. FWIW these are the weights (basically by the book) that famous 
bootstrap 
 uses.

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Hanna_Petruschat_WMDE]

Hanna_Petruschat_WMDE added a comment.


  Hi Jakob. Thanks a lot for the link. It mostly looks great. I have a few 
picky remarks.
  
  1. Could you change the font weight in the buttons and the headline from 700 
to 500
  2. Could youu change the line heights from 1 to 1.2
  3. Could you change the font weight of the message text from 400 to 300
  
  Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Tarrow]

Tarrow added a comment.


  From my side this is fine to leave. If the complexity were to change I would 
expect it to be encapsulated in T221833 


TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T221831: Add "You are not logged in" overlay popup on termbox editing

[Lea_WMDE]

Lea_WMDE added a comment.


  Due to some miscommunication we started this ticket without the most current 
version of mocks :/ It should actually look like shown below. Is this a small 
enough change that we can still put this in this ticket, or would you want to 
reestimate/ do a follow up /first discuss it, because this has pit falls the 
current version does not?
  
  F28983410: Bildschirmfoto 2019-05-09 um 16.29.14.png 

  (Please ignore the pink box, that's my ignorance when it comes to figma, and 
since we changed the text of the checkbox today I think the spacing went a bit 
off as well)

TASK DETAIL
  https://phabricator.wikimedia.org/T221831

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs