[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-06-11 Thread Catrope 
Catrope added a comment.


  The preference is labeled "Show Wikidata edits *by default* in recent 
changes". If you don't have it enabled, the default state of the RC filters 
when you open RC will be such that Wikidata edits aren't shown, but if you then 
change the filters they may end up being shown. I'm not sure how we could make 
this clearer.
  
  What is a bit confusing is that the way that this excludes Wikidata edits is 
by filtering for everything else (Page creations, Page edits, Log actions, 
etc), because the interface always tells you what it is showing (not what it 
isn't showing). If you remove these filters, all types of changes will be 
shown, including Wikidata edits, and that confuses some people. But I don't 
think there's much to do here, unless there are relatively simple ways to 
clarify this.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Catrope
Cc: Catrope, Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, 
Patriccck, Urbanecm, Aklapper, darthmon_wmde, 94rain, Nandana, kostajh, Jony, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-31 Thread Patriccck 
Patriccck added a comment.


  In T224426#5223067 , 
@Etonkovidova wrote:
  
  > In T224426#5223042 , 
@Urbanecm wrote:
  >
  > > The workaround was to add "edited pages", "logged actions" and "created 
pages" to his filterset.
  >
  >
  > Thx! Yes, these filters are default filters and it works for the specific 
situation (since wikidata edits are not classified as Page creation, Page 
edits, or Logged entries).  In my opinion, the more general issue with making 
the logic clearer for "Show wikidata edits" and  other Preferences-RC options 
still needs to be re-evaluated.
  
  
  I think it too.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Patriccck
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Etonkovidova 
Etonkovidova added a comment.


  In T224426#5223042 , 
@Urbanecm wrote:
  
  > The workaround was to add "edited pages", "logged actions" and "created 
pages" to his filterset.
  
  
  Thx! Yes, these filters are default filters and it works for the specific 
situation (since wikidata edits are not classified as Page creation, Page 
edits, or Logged entries).  In my opinion, the more general issue with making 
the logic clearer for "Show wikidata edits" and  other Preferences-RC options 
still needs to be re-evaluated.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Etonkovidova
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Urbanecm 
Urbanecm added a comment.


  The workaround was to add "edited pages", "logged actions" and "created 
pages" to his filterset.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Etonkovidova 
Etonkovidova added a comment.


  In T224426#5221895 , 
@Patriccck wrote:
  
  > After help (using e-mail) from @Urbanecm, I don't see Wikidata & 
categorization edits. Thanks!
  
  
  @Patriccck - did you find some workaround for specific filter set you're 
using?

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Etonkovidova
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Patriccck 
Patriccck added a comment.


  After help (using e-mail) from @Urbanecm, I don't see Wikidata a 
categorization edits. Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Patriccck
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Etonkovidova 
Etonkovidova added a comment.


  @Urbanecm
  
  In T224426#5219687 , 
@Urbanecm wrote:
  
  > @Etonkovidova Hi, I can see "Wikidata edits" in your second screenshot. 
However, in the screenshot from task's description (F29258444 
), there's nothing saying 
"Wikidata". I understand that the filters understands "Wikidata edit" as "human 
edit", even that, I think preferences should be honored, unless explicitly 
overriden by adding "Wikidata edits" to display, as in your screenshot.
  
  
  My screenshot illustrates only the point that selecting the option "Show 
wikidata edits" option in Preferences-Recent changes will include Wikidata 
filter in  default filters - nothing more.
  
  In the task description  screenshot - wikidata entries appears because 
Human(non bot) filter was selected and Wikidata edits were made by humans, as 
you mentioned in the comment above.
  
  I agree that "Show wikidata edits" when not enabled should exclude wikidata 
edits entirely from all filters' result set.   Two other options "Hide 
categorization of pages" and "Hide minor edits from recent changes" behave the 
same as "Show wikidata edits". 
  The real bug is actually there -   the option "Show wikidata edits" is not 
enabled and no RC filters are selected,  wikidata edits are still displayed 
e.g. 
  the following options selections 
  F29271735: Screen Shot 2019-05-29 at 9.02.40 PM.png 

  
  will result that RC page disregards these options entirely 
   F29271742: Screen Shot 2019-05-29 at 9.03.19 PM.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Etonkovidova
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-29 Thread Urbanecm 
Urbanecm added a comment.


  @Etonkovidova Hi, I can see "Wikidata edits" in your second screenshot. 
However, in the screenshot from task's description (F29258444 
), there's nothing saying 
"Wikidata". I understand that the filters understands "Wikidata edit" as "human 
edit", even that, I think preferences should be honored, unless explicitly 
overriden by adding "Wikidata edits" to display, as in your screenshot.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-28 Thread Etonkovidova 
Etonkovidova added a comment.


  Selection of Preferences-Recent changes options applies **only to default 
filter set on Recent changes**.  Selecting the option - 'Hide Wikidata' will 
not hide the filter wikidata, or wikidata entries if they will come in the 
result set of other filter selection.
  
  For example, if I select in Preferences-Recent Changes the following options
  
  - Show Wikidata edits in recent changes
  - Hide minor edits from recent changes
  - Hide categorization of pages
  - Highlight likely problem edits with colors and an "r" for "needs review"
  - Show only likely problem edits (and hide probably good edits)
  
  F29269680: Screen Shot 2019-05-29 at 9.05.10 AM.png 

  
  And then I go to Recent changes, I'll see the following filters defined as 
default  filter set (the true default filters - without user selecting options 
- are in red circles).
  
  F29269674: Screen Shot 2019-05-29 at 8.58.26 AM.png 

  
  If I did not click the option "Show Wikidata edits in recent changes" - 
Wikidata edits still be shown as result of applying other filters - Page edits 
or Logged edits.  The present logic for filters does not work as "show me Page 
edits but exclude Wikidata edits.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Etonkovidova
Cc: Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, 
Urbanecm, Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-28 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, Urbanecm, 
Aklapper, darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences

2019-05-28 Thread Urbanecm 
Urbanecm added a comment.


  And one more rename, I forgot I have filters to display only unpatrolled 
edits, which doesn't include WD edits. So, can reproduce it too.

TASK DETAIL
  https://phabricator.wikimedia.org/T224426

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Urbanecm
Cc: Lydia_Pintscher, Ammarpad, Reedy, Patriccck, Urbanecm, Aklapper, 
darthmon_wmde, Premeditated, Nandana, kostajh, Jony, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs