[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot 
gerritbot added a comment.


  Change 541225 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeResult: guard 
against mTitle being null
  
  https://gerrit.wikimedia.org/r/541225

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona, gerritbot
Cc: Jdforrester-WMF, Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, 
Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny, Hook696, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot 
gerritbot added a comment.


  Change 541223 **merged** by jenkins-bot:
  [mediawiki/core@master] searchResult: Fix docs for mTitle
  
  https://gerrit.wikimedia.org/r/541223

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona, gerritbot
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot 
gerritbot added a comment.


  Change 541225 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] LexemeResult: guard 
against mTitle being null
  
  https://gerrit.wikimedia.org/r/541225

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, 
CucyNoiD, Nandana, NebulousIris, Mringgaard, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, EBjune, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread gerritbot 
gerritbot added a comment.


  Change 541223 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  [mediawiki/core@master] searchResult: Fix docs for mTitle
  
  https://gerrit.wikimedia.org/r/541223

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona 
Daimona added a comment.


  In T233763#5551443 , 
@Daimona wrote:
  
  > AFAICS, mTitle is not defined as property, and this happens as of 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/
  
  Uh, actually, not completely culprit. I was deceived by my IDE which still 
had to load the RevisionSearchResultTrait. Which //does// have an mTitle 
property; however, although it's documented as Title only, it can also be null.

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona 
Daimona added a comment.


  AFAICS, mTitle is not defined as property, and this happens as of 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/
  
  IMHO, it's pretty sad that:
  
  - This wasn't spotted when updating the class;
  - Nothing triggered (PHPUnit) tests in WBLCS in the last month, and hence the 
error remained unnoticed;
  - Phan wouldn't have caught it anyway, because we use stubs.
  
  That's a failure across the board... I'm going to fix the code itself, and 
make phan more powerful. And, as a side note, it'd be great to automatically 
run tests in a repo when no changes were sent in say the last month.

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona 
Daimona added a comment.


  Curiously, PHPUnit is failing on the WikibaseLexemeCirrusSearch repo with 
"Call to a member function setFragment() on null". I don't know if it's exactly 
the same error, but oh well...

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs