[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo
daniel added a comment. My 2ยข on this: ChangeFactory should be split into a general factory in lib (defining the newForChangeType methods), and a RepoChangeFactory in the repo component, that has knowledge about EntityContent, Revision, etc. Any code that needs services or knowledge about repo concepts should be extracted into RepoChangeFactory.TASK DETAILhttps://phabricator.wikimedia.org/T75643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aleksey_WMDE, thiemowmde, JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo
thiemowmde added a comment. @Aleksey_WMDE, the problem is this line: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Changes/EntityChange.php;52253d5b116df36849b2c44f787cbe3f256fedd2$201 This is code in lib, but it type hints against EntityContent and calls EntityContent::getEntityId, which is code in repo. This means lib depends on repo, right?TASK DETAILhttps://phabricator.wikimedia.org/T75643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aleksey_WMDE, thiemowmde, JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo
Aleksey_WMDE added a comment. Seems like task has incomplete description. I cannot understand what the problem is and also what needs to be changed and how. Can anyone provide more info?TASK DETAILhttps://phabricator.wikimedia.org/T75643EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Aleksey_WMDE, thiemowmde, JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, QZanden, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T75643: EntityChange in lib depends on EntityContent in repo
JeroenDeDauw added a subscriber: JeroenDeDauw. JeroenDeDauw added a comment. Noted this in the last code review thing: https://wmde.github.io/code-analysis/Wikidata/2014-MarchReview/slides/#/6/2 TASK DETAIL https://phabricator.wikimedia.org/T75643 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeroenDeDauw Cc: JeroenDeDauw, Ricordisamoa, Aklapper, Wikidata-bugs, JanZerebecki, adrianheine, aude, daniel, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
