[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-08-03 Thread gerritbot 
gerritbot added a comment.
Change 285630 merged by jenkins-bot:
Use new EntityIdValue serialization in JS

https://gerrit.wikimedia.org/r/285630TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, gerritbotCc: Jonas, Tobi_WMDE_SW, thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-07-27 Thread gerritbot 
gerritbot added a comment.
Change 300015 merged by jenkins-bot:
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, gerritbotCc: Tobi_WMDE_SW, thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-07-21 Thread thiemowmde 
thiemowmde added a comment.
Yes, except:


 Make sure everything is at least compatible with DataModel 6.1. Since the _javascript_ code in question is not used anywhere in our code base, this is to make sure external users (e.g. gadgets) can still deserialize the JSON blobs we provide. The JSON must contain the new "id" key, which requires DataModel 6.1.
 https://gerrit.wikimedia.org/r/300015 is unrelated.
TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, thiemowmdeCc: Tobi_WMDE_SW, thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-07-20 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.
@thiemowmde sound great, thx!
Does that mean we need to do in the following order:


 Use DataModel 6.1 everywhere
 Merge https://github.com/wmde/WikibaseDataModelJavaScript/pull/63 and a release a new version of DataModelJavaScript
 Merge https://gerrit.wikimedia.org/r/#/c/300015/
 Merge https://gerrit.wikimedia.org/r/#/c/285630/


Is that correct?TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, Tobi_WMDE_SWCc: Tobi_WMDE_SW, thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-07-20 Thread thiemowmde 
thiemowmde added a comment.
I had an other look and as far as I can tell the _javascript_ implementation called EntityId was never used. Nowhere.

Selectors/suggesters are using Item and Property objects/stubs, but never an EntityId.

Item and Property are using strings, not EntityIds.

So I suggest to simply merge and release this the moment Wikibase.git depends on DataModel 6.1 (which introduced the "id" key). This can happen any time, somebody just needs to update composer.json to say ~6.1.

EntityId is mentioned by mistake in ViewFactory, which I'm going to fix.TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, thiemowmdeCc: thiemowmde, gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-07-20 Thread gerritbot 
gerritbot added a comment.
Change 300015 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix mistake in ViewFactory.js

https://gerrit.wikimedia.org/r/300015TASK DETAILhttps://phabricator.wikimedia.org/T93172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: adrianheine, gerritbotCc: gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, D3r1ck01, Izno, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-05-02 Thread adrianheine 
adrianheine added a comment.


  https://github.com/wmde/WikibaseDataModelJavaScript/pull/63

TASK DETAIL
  https://phabricator.wikimedia.org/T93172

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, 
JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, Lewizho99, Maathavan, 
D3r1ck01, Izno, aude, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T93172: [Task] Adapt JS Serialization to new EntityIdValue serialization

2016-04-27 Thread gerritbot 
gerritbot added a comment.


  Change 285630 had a related patch set uploaded (by Adrian Heine):
  Use new EntityIdValue serialization in JS
  
  https://gerrit.wikimedia.org/r/285630

TASK DETAIL
  https://phabricator.wikimedia.org/T93172

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Ricordisamoa, adrianheine, daniel, Lydia_Pintscher, 
JeroenDeDauw, Denny, Wikidata-bugs, Aklapper, Lucie, D3r1ck01, Izno, aude, 
Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs