[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 679529 **abandoned** by Silvan Heintze: [mediawiki/extensions/Wikibase@master] Don't catch TermStoreException Reason: old and resolved otherwise https://gerrit.wikimedia.org/r/679529 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: aaron, Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Rosalie_WMDE, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 721529 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@REL1_36] Re-throw DBErrors in DataUpdateAdapter https://gerrit.wikimedia.org/r/721529 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: aaron, Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 721529 had a related patch set uploaded (by Addshore; author: Ladsgroup): [mediawiki/extensions/Wikibase@REL1_36] Re-throw DBErrors in DataUpdateAdapter https://gerrit.wikimedia.org/r/721529 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: aaron, Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Addshore closed this task as "Resolved".
Addshore added a comment.
Going to close.
Not seen the log in prod since the 29th.
https://logstash.wikimedia.org/app/dashboards#/view/AXFV7JE83bOlOASGccsT?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-4w,to:now))&_a=(description:'All%20MediaWiki%20logs',filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'logstash-*',key:type,negate:!f,params:(query:mediawiki),type:phrase),query:(match:(type:(query:mediawiki,type:phrase,('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'logstash-*',key:channel,negate:!t,params:(query:api-feature-usage),type:phrase),query:(match:(channel:(query:api-feature-usage,type:phrase,('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'logstash-*',key:level,negate:!t,params:(query:INFO),type:phrase),query:(match:(level:(query:INFO,type:phrase),fullScreenMode:!f,options:(darkTheme:!f),query:(language:lucene,query:'%22acquireAndInsertTerms%22%20AND%20%22ignored%20an%20error%20originally%20raised%22'),timeRestore:!t,title:mediawiki,viewMode:view)
This could also just be because it hasn't occurred, but it looks good!
TASK DETAIL
https://phabricator.wikimedia.org/T279409
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, Addshore
Cc: aaron, Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE,
Michael, Invadibot, Lalamarie69, maantietaja, Alter-paule, Hazizibinmahdi,
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301,
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30,
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer,
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p,
Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27). TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, ReleaseTaggerBot Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Hazizibinmahdi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 679533 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Re-throw DBErrors in DataUpdateAdapter https://gerrit.wikimedia.org/r/679533 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, gerritbot Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Hazizibinmahdi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T279409 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 679533 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): [mediawiki/extensions/Wikibase@master] Re-throw DBErrors in DataUpdateAdapter https://gerrit.wikimedia.org/r/679533 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Ladsgroup added a comment. oh my bad, we do catch db errors in `DataUpdateAdapter`, I thought it's a core class. Making a patch now. TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Ladsgroup added a comment. Oh this is another case of catching DBErrors. See https://www.mediawiki.org/wiki/Database_transactions#Use_of_transaction_rollback (emphasis not mine) > Callers might catch DBError exceptions without either re-throwing them or throwing their own version of the error. Doing so is extremely **bad practice** and can cause all sorts of problems from partial commits to simply spewing up DBTransactionError errors. Only catch DB errors in order to do some cleanup before re-throwing an error or if the database in question is used **exclusively** by the code catching errors. Funnily enough, we don't catch any db error in our codebase (the only one we catch is never thrown, removing that for good measure), it's happening in core meaning this warning will likely continue to pop up in different shape and form for different extensions or basically anything that does sql queries in deferred updates. TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
gerritbot added a comment. Change 679529 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup): [mediawiki/extensions/Wikibase@master] Don't catch TermStoreException https://gerrit.wikimedia.org/r/679529 TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Jakob_WMDE removed Jakob_WMDE as the assignee of this task. Jakob_WMDE moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T279409 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Jakob_WMDE, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
Jakob_WMDE claimed this task. Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T279409 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
darthmon_wmde moved this task from Prioritized Tech (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board. darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T279409 WORKBOARD https://phabricator.wikimedia.org/project/board/3402/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthmon_wmde Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate
noarave renamed this task from "Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate" to "[8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate". TASK DETAIL https://phabricator.wikimedia.org/T279409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Michael, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
