[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 196 kB of uncompressed JavaScript on Vector-22 page load

[Michael]

Michael added a comment.


  I looked into it briefly to remind myself of what is going on. This was added 
in context of T310259 . And looking 
at that script 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/60a3d9821fe5460930a47a9565b1aa0559cf1fbf/client/resources/wikibase.client.vector-2022.js:
  
  name=wikibase.client.vector-2022.js
var itemId = mw.config.get( 'wgWikibaseItemId' );
if ( !itemId || [ null, 'error', 'registered' ].indexOf( 
mw.loader.getState( 'ext.uls.interface' ) ) !== -1 ) {
return;
}

// wait for ext.uls.interface to be ready,
// and lazy-load the other dependencies now that we know they're needed
mw.loader.using( [
'mw.config.values.wbRepo',
'mw.config.values.wbSiteDetails',
'ext.uls.interface',
'oojs-ui.styles.icons-editing-core'
], function () {
  
  The intention is indeed to lazy-load these dependencies. But we may have 
misunderstood how something in how ResourceLoader works and made a mistake 
there?
  
  Another approach could be to create a config module that contains the client 
config only for the current site and not all sites, that should then be much 
smaller than wbSiteDetails. Though that might be a non-trivial thing to do.
  
  Also, this loads all the icons in `oojs-ui.styles.icons-editing-core`, would 
be nice if we could only load the one icon that we actually need.

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Jdlrobson, Michael, ItamarWMDE, Manuel, Peter, 
Aklapper, nray, JCW555, hnijhuis, Astuthiodit_1, Nishu02, Patafisik_WMF, 
karapayneWMDE, Invadibot, Selby, maantietaja, Akuckartz, Demian, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, Vali.matei, Iniquity, 
_jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 196 kB of uncompressed JavaScript on Vector-22 page load

[Jdlrobson]

Jdlrobson added subscribers: Michael, LucasWerkmeister, Jdlrobson.
Jdlrobson added a comment.


  Looks like this was added in T310259 
 @Michael and @LucasWerkmeister  
could you help us clarify what this is for, as this is problematic for our 
first input delay metrics and we'll like to see how we could optimize it. Could 
you help us prioritize this higher within WMDE?

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Jdlrobson, LucasWerkmeister, Michael, ItamarWMDE, Manuel, Peter, Aklapper, 
nray, JCW555, hnijhuis, Astuthiodit_1, Nishu02, Patafisik_WMF, karapayneWMDE, 
Invadibot, Selby, maantietaja, Akuckartz, Demian, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Winter, Vali.matei, Iniquity, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 196 kB of uncompressed JavaScript on Vector-22 page load

[Arian_Bozorg]

Arian_Bozorg added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: ItamarWMDE, Manuel, Peter, Aklapper, nray, JCW555, hnijhuis, Astuthiodit_1, 
Nishu02, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, maantietaja, 
Akuckartz, Demian, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, Vali.matei, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 196 kB of uncompressed JavaScript on Vector-22 page load

[larissagaulia]

larissagaulia moved this task from Inbox, needs triage to Radar on the 
Performance-Team board.
larissagaulia edited projects, added Performance-Team (Radar); removed 
Performance-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1212/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: larissagaulia
Cc: Peter, Aklapper, nray, JCW555, hnijhuis, Astuthiodit_1, Nishu02, 
Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, 
ItamarWMDE, Akuckartz, Demian, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, Vali.matei, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T331760: "mw.config.values.wbSiteDetails" module downloads 196 kB of uncompressed JavaScript on Vector-22 page load

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T331760

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Aklapper, nray, JCW555, hnijhuis, Astuthiodit_1, Nishu02, Patafisik_WMF, 
karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, ItamarWMDE, 
Akuckartz, Demian, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, Vali.matei, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org