[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ItamarWMDE closed this task as "Resolved". ItamarWMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T336922 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, ItamarWMDE Cc: Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ItamarWMDE added a comment. Looks good to me, thank you TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, ItamarWMDE Cc: Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01). TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, ReleaseTaggerBot Cc: Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, Maintenance_bot Cc: Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
gerritbot added a comment. Change 939297 **merged** by jenkins-bot: [mediawiki/extensions/EntitySchema@master] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interface https://gerrit.wikimedia.org/r/939297 TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, gerritbot Cc: Aklapper, ItamarWMDE, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, gerritbot Cc: Aklapper, ItamarWMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
gerritbot added a comment. Change 939297 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)): [mediawiki/extensions/EntitySchema@master] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interface https://gerrit.wikimedia.org/r/939297 TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE, gerritbot Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
HasanAkgun_WMDE claimed this task. HasanAkgun_WMDE set the point value for this task to "3". TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
HasanAkgun_WMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. HasanAkgun_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T336922 WORKBOARD https://phabricator.wikimedia.org/project/board/6016/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: HasanAkgun_WMDE Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ItamarWMDE moved this task from Incoming to Prioritized on the wmde-wikidata-tech board. ItamarWMDE added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T336922 WORKBOARD https://phabricator.wikimedia.org/project/board/5864/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ItamarWMDE added a comment. **Prio Notes** - Impact Areas: Analyzability, Testability - Does not affect end users / production - Does not affect monitoring efforts - Does not affect development efforts - Affects onboarding efforts - Does not affect additional stakeholders TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336922: [ES-M5] Refactor `onBeforeDisplayNoArticleText` hook handler to use hook interfaces and Dependency Injection
ItamarWMDE created this task. ItamarWMDE added projects: wmde-wikidata-tech, Wikidata, Shape Expressions. TASK DESCRIPTION Currently, the registered `onBeforeDisplayNoArticleText` hook handler is registered through a static method of the `EntitySchemaHooks` class. However, as this class depends on some MediaWiki services, it could leverage from the new MediaWiki dependency injection system. To improve the analyzability and testability of this hook handler, we should refactor this static handler to a class that implements the `BeforeDisplayNoArticleTextHook` interface and has its dependencies injected via constructor. **Acceptance Criteria**: [ ] The hook handler function is moved to a class that implements the `BeforeDisplayNoArticleTextHook` interface and injects its dependent services [ ] The hook handler's registration in `extension.json` declares its service dependencies for dependency injection TASK DETAIL https://phabricator.wikimedia.org/T336922 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, pdehaye, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
