[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread Umherirrender 
Umherirrender closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread gerritbot 
gerritbot added a comment.


  Change 991841 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] tests: Avoid dynamic property $user in 
MockRepository
  
  https://gerrit.wikimedia.org/r/991841

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread gerritbot 
gerritbot added a comment.


  Change 991841 had a related patch set uploaded (by Umherirrender; author: 
Umherirrender):
  
  [mediawiki/extensions/Wikibase@master] tests: Avoid dynamic property $user in 
MockRepository
  
  https://gerrit.wikimedia.org/r/991841

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2024-01-19 Thread Umherirrender 
Umherirrender claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2023-12-18 Thread Reedy 
Reedy added a parent task: T314099: PHP 8.2: Dynamic property creation is 
deprecated.

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2023-12-12 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > Not sure why it was added in 58d27b73c6fbaf99ba8e51b98f1c7837046ff723 
,
 it seems the property never exists on the EntityRevision
  
  The property is checked in `userWasLastToEdit()` in the same class.
  
  I guess we can just add an array mapping revision ID to user name to 
`MockRepository`? (If I understand the class correctly, it completely bypasses 
any real MediaWiki page/revision store, so we have to store the information 
somewhere.)

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2023-12-11 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.
Restricted Application added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated

2023-12-11 Thread Umherirrender 
Umherirrender created this task.
Umherirrender added projects: MediaWiki-extensions-WikibaseRepository, PHP 8.2 
support.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  phpunit under php8.2 fails with the following message
  
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/151/console
  
41) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set 
"fresh" (Wikibase\DataModel\Entity\Item Object (...), 1, false)
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is 
deprecated

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447

42) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set 
"update" (Wikibase\DataModel\Entity\Item Object (...), 2, 1011)
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is 
deprecated

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447

43) Wikibase\Lib\Tests\MockRepositoryTest::testUpdateWatchlist
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is 
deprecated

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:585

44) Wikibase\Lib\Tests\MockRepositoryTest::testUserWasLastToEdit
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is 
deprecated

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486

/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:602
  
  The code is:
  
$revision = new EntityRevision(
$entity->copy(), // note: always clone
$revisionId,
wfTimestamp( TS_MW, $timestamp )
);

if ( $user !== null ) {
if ( $user instanceof UserIdentity ) {
$user = $user->getName();
}

// just glue the user on here...
$revision->user = $user;
}
  
  Not sure why it was added in 58d27b73c6fbaf99ba8e51b98f1c7837046ff723 
,
 it seems the property never exists on the EntityRevision

TASK DETAIL
  https://phabricator.wikimedia.org/T353184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Umherirrender
Cc: Aklapper, Umherirrender, malberts, ItamarWMDE, Akuckartz, lucamauri, Gq86, 
TK-999, Wikidata-bugs, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org