Re: [Wikitech-l] XKCD: Extended Mind

[Domas Mituzas]

On May 25, 2011, at 9:35 AM, K. Peachey wrote:

> http://xkcd.org/903/
> -Peachey

that error is fake! 10.0.0.242 is internal services DNS server and is not used 
to serve en.wikipedia.org - dberror log does not have a single instance of it! 
10.0.6.42 on the other hand

the incident yesterday was network card drivers / linux / network cards being 
stupid to interface going down/up - we saw some isolated issues similar to that 
in the past, unfortunately that knocked out all databases and they all needed 
serial console intervention. 

Domas
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] dns issues during downtime

[Domas Mituzas]

> What was the problem exactly? I don't see anything about it in the
> server admin log.

The usual, powerdns deadlock. There're plenty of cases like that in the past.

Domas

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Tim Starling]

On 25/05/11 17:05, Domas Mituzas wrote:
> 
> On May 25, 2011, at 9:35 AM, K. Peachey wrote:
> 
>> http://xkcd.org/903/ -Peachey
> 
> that error is fake! 10.0.0.242 is internal services DNS server and
> is not used to serve en.wikipedia.org - dberror log does not have a
> single instance of it! 10.0.6.42 on the other hand

I would have thought the fact that it was hand drawn would have given
it away.

-- Tim Starling


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Domas Mituzas]

> 
> I would have thought the fact that it was hand drawn would have given
> it away.

well, it is valid DB IP, so some random extension pulling data from db9 could 
be likely. 
Worth checking anyway ;-)

Domas
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Svip]

On 25 May 2011 08:35, K. Peachey  wrote:

> http://xkcd.org/903/

> Wikipedia trivia: if you take any article, click on the first link in the 
> article text not
> in parentheses or italics, and then repeat, you will eventually end up at 
> "Philosophy".

This is also true.  I came from Groom Range to Philosophy.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Andre Engels]

On Wed, May 25, 2011 at 10:36 AM, Svip  wrote:
> On 25 May 2011 08:35, K. Peachey  wrote:
>
>> http://xkcd.org/903/
>
>> Wikipedia trivia: if you take any article, click on the first link in the 
>> article text not
>> in parentheses or italics, and then repeat, you will eventually end up at 
>> "Philosophy".
>
> This is also true.  I came from Groom Range to Philosophy.

No, it's not. The exceptions may be rare, but they do exist. My third
attempt was "Masquerade (theatre group)", which quicklyl ended up in a
loop of "Renaming of cities in India" and "Mumbai". "Philosophy"
itself has "Reason" and "Rationality" as the other members of its
loop.


-- 
André Engels, andreeng...@gmail.com

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Peter Gervai]

On Wed, May 25, 2011 at 09:24, Tim Starling  wrote:
> On 25/05/11 17:05, Domas Mituzas wrote:
>> On May 25, 2011, at 9:35 AM, K. Peachey wrote:
>>
>>> http://xkcd.org/903/ -Peachey
>>
>> that error is fake! 10.0.0.242 is internal services DNS server and
>> is not used to serve en.wikipedia.org - dberror log does not have a
>> single instance of it! 10.0.6.42 on the other hand
>
> I would have thought the fact that it was hand drawn would have given
> it away.

But in this particular case hand drawn doesn't mean facts can slip. At
least these drawings are usually extremely precise. (You can see which
pulldowns he usually keep open. :-))

I second Domas to check because there may be a super secret conspiracy
and the drawing may be correct. ;-)
-- 
 byte-byte,
    grin

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Domas Mituzas]

> 
> I second Domas to check because there may be a super secret conspiracy
> and the drawing may be correct. ;-)

well, $wgContributionTrackingDBserver = 'db9.pmtpa.wmnet'; - though I don't see 
anything on profiling. *sigh*

Domas


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Martijn Hoekstra]

On Wed, May 25, 2011 at 10:52 AM, Andre Engels  wrote:
> On Wed, May 25, 2011 at 10:36 AM, Svip  wrote:
>> On 25 May 2011 08:35, K. Peachey  wrote:
>>
>>> http://xkcd.org/903/
>>
>>> Wikipedia trivia: if you take any article, click on the first link in the 
>>> article text not
>>> in parentheses or italics, and then repeat, you will eventually end up at 
>>> "Philosophy".
>>
>> This is also true.  I came from Groom Range to Philosophy.
>
> No, it's not. The exceptions may be rare, but they do exist. My third
> attempt was "Masquerade (theatre group)", which quicklyl ended up in a
> loop of "Renaming of cities in India" and "Mumbai".

{{sofixit}}


>"Philosophy"
> itself has "Reason" and "Rationality" as the other members of its
> loop.
>
>

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Jay Ashworth]

- Original Message -
> From: "Tim Starling" 

> On 25/05/11 17:05, Domas Mituzas wrote:
> > On May 25, 2011, at 9:35 AM, K. Peachey wrote:
> >> http://xkcd.org/903/ -Peachey
> >
> > that error is fake! 10.0.0.242 is internal services DNS server and
> > is not used to serve en.wikipedia.org - dberror log does not have a
> > single instance of it! 10.0.6.42 on the other hand
> 
> I would have thought the fact that it was hand drawn would have given
> it away.

Well, in fact, Randall's pretty good about the details (vis 2000 people 
showing up in a park in Cambridge just because he put an undesignated
time and lat/lon in a strip)...

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth & Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] XKCD: Extended Mind

[Domas Mituzas]

> Well, in fact, Randall's pretty good about the details (vis 2000 people 
> showing up in a park in Cambridge just because he put an undesignated
> time and lat/lon in a strip)...

Randall: " I drew it based on an older error message where the IP was 
10.0.0.243.  I changed it to 242 (a) because I try not to get too specific with 
those things, and didn't want people poking the actual machine at .243 (if it 
was still there) -- I actually considered putting .276 and seeing how many 
poeple noticed, but figured they'd just think I made a dumb mistake.  and (b) 
as part of this ancient inside joke involving the number 242 ... "

Funny though, it caused way more confusion with .242, as we have random stuff 
pointing at it ;-)
.243 was enwiki database box until July 2008;-)

Domas
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] New committers!

[Chad]

On Thu, May 19, 2011 at 6:41 PM, Chad  wrote:
> Just created a couple of new SVN accounts.
>
> Akshay Agarwal - akshay - GSoC student
> Ankit Garg - ankitgarg833 - GSoC student
> Zhenya Vlasyenko - zhenya - GSoC student
> Yusuke Matsubara - whym - Editor trends research
> Shawn Walker - swalker - Editor trends research
>
> Welcome :)
>

Added a few more...

Aaron Halfaker - halfak - Editor trends research
Fabian Kaelin - declerambaul - Editor trends research
Giovanni Ciampaglia - giovanni - Editor trends research
Kevin Brown - kbrown - Google Summer of Code
Zack Exley - zexley - WMF staff, analytics work

Whew, finally caught up :)

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r88797]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88797.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88797#c0
Commit summary:

Misc EOL w/s and spaces-instead-of-tabs fixes.  One day I'll get around to 
nagging people for this stuff, but for now, I'll JFDI myself.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88497]: New comment added, and revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88497.

Old Status: fixme
New Status: new

User "Reedy" also posted a comment on MediaWiki.r88497.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88497#c17165
Commit summary:

add various translations

Comment:

You can link locally by using [[Special:Code/MediaWiki/88654]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r82205]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r82205.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82205#c0
Commit summary:

Added two messages to handle new regex feature (!)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88015]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88015.

Old Status: fixme
New Status: new

User "^demon" also posted a comment on MediaWiki.r88015.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88015#c17166
Commit summary:

(bug 21086) generateSitemap.php uses wfWikiID() in sitemap filenames

Add optional --identifier parameter to override wfWikiId()

Comment:

Fixed in r88495.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78108]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r78108.

Old Status: fixme
New Status: old

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78108#c0
Commit summary:

Changes by Jason Giglio

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r72349]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r72349.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72349#c0
Commit summary:

Merging resourceloader branch into trunk. Full documentation is at 
http://www.mediawiki.org/wiki/ResourceLoader and a general overview has been 
posted on wikitech-li 
. 
One important change is that all JS is now loaded at the bottom, so any scripts 
assuming things from wikibits or whatever are present will fail.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87897]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r87897.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87897#c17167
Commit summary:

* (bug 28842) Fix userrights issue on 1.16.5 with the Lockdown extension (check 
for partially initialized $wgUser before continuing with SearchableNamespaces 
hook)

Comment:

And 1.17, and 1.18...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87468]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r87468.

Old Status: fixme
New Status: new

User "^demon" also posted a comment on MediaWiki.r87468.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c17168
Commit summary:

Move CleanUpTest, fixes in next commit

Comment:

See followup.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88768]: Revision status changed

[MediaWiki Mail]

User "MaxSem" changed the status of MediaWiki.r88768.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88768#c0
Commit summary:

* Changed @ => wfSuppressWarnings
* Added wfSuppressWarnings to Bitmap.php:
Notice: unserialize(): Error at offset 0 of 2 bytes in 
D:\www\MW_trunk\phase3\includes\media\Bitmap.php on line 685

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88775]: Revision status changed

[MediaWiki Mail]

User "MaxSem" changed the status of MediaWiki.r88775.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88775#c0
Commit summary:

Finish r88768, *ahem*

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r39635]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r39635.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39635#c0
Commit summary:

Committing todays work on LinkHooks and the link rewrite:
* Cleanup and remove cruft
* Get hooks working
* Get Categories working (whitespace trimming not done)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r73875]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r73875.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/73875#c0
Commit summary:

Don't show empty source code for non-existing pages if editing was prevented by 
a permission error

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88053]: New comment added, and revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r88053.

Old Status: resolved
New Status: fixme

User "Catrope" also posted a comment on MediaWiki.r88053.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88053#c17169
Commit summary:

Added direct file loading functionality to debug mode for both scripts and 
styles, with callbacks for module state changes (changing to ready) and 
executing of jobs and modules awaiting dependency resolutions. These changes 
also provide a way to used mw.loader.implement with arrays of URLs for the 
scripts and styles arguments, which will make it possible to implement modules 
using user scripts. This probably solves bug #27023 - tests to verify that will 
be coming soon.

Comment:


+   if ( $.isFunction( callback ) ) {
+   // Document.write is synchronous, so 
this is called when it's done
+   callback();
+   }

Lies! document.write() is not synchronous, at least not in Firefox 
4.0.1, but I understand why it would appear to be. The 
document.write() is deferred: it's queued and the script tag is 
only written to the DOM after this script's thread finishes, i.e. some time 
after the callback has run to completion. However, in your use case (debug mode 
where all modules are file-based) the only thing in the callback was more calls 
to document.write() (indirectly, via addScript()). 
This means that if B depends on A, the document.write() for B is executed 
before A is loaded. That's not a problem, though, because the 
document.write() calls are serialized properly, so the script tags 
are written to the DOM in the right order, and executed sequentially.

This house of cards collapses when you're mixing file-based and wiki page-based 
modules in debug mode, though, or generally when mixing modules of the form 
mw.loader.implement(["some url"], {}, {}); (which is how file 
modules work in debug mode) with modules of the form 
mw.loader.implement(function($) { code; }, {}, {}); (which is how 
wiki page modules work in both debug and production mode). If a wiki page 
module depends on a file module, the document.write() call for the 
file module will be executed before the wiki page module is executed, but 
because the document.write() is deferred the wiki page module ends 
up being executed before its dependency. This is happening in the WikiLove 
extension with ext.wikiLove.local (which is a wiki page module and depends on 
ext.wikiLove.startup, which is a file-based module). I investigated Jan Paul's 
complaints and found this.

I'm not really sure how this should be fixed. At the bottom of the body, 
document ready hasn't happened yet but the document is ready enough to do async 
script loading as done in the if ( ready ) { branch (at least in 
FF4). At the top of the body, this doesn't work, but this can be detected with 
if ( document.body ) { (at least in FF4). However, doing that (I 
tried it locally) introduces another set of problems. Because 
load() is no longer synchronous before document ready, modules 
like mw.util and mw.user can't just be assumed to be present. This means 
dependencies for mw.util have to be flagged explicitly and the inlined 
mw.user.options and mw.user.tokens modules have to be wrapped in 
mw.loader.using( 'mw.user', function() { ... } ); . Worse still, 
it means site and user scripts will typically execute before mw.util and 
mw.user or any of the other stuff that's loaded at the bottom of the body.

I've tried wrapping the callback(); invocation in 
setTimeout( ..., 0 ); but that fails catastrophically because code 
run through setTimeout() executes in a different thread where, 
apparently, jQuery isn't available and IFFEs fail.

Other solutions that could be explored are:
* return the code as a string instead of a closure, and inject that into the 
DOM as a script tag using document.write() . We basically do the 
same thing for CSS already. A major disadvantage is that we won't get proper 
line numbers and that tracking down the origin of a piece of code is 
non-trivial. These are bad things in debug mode
* URLify non-file modules too, using only=scripts. This seems like 
the most promising way to go forward to me


+   for ( var i = 0; i < script.length; i++ 
) {
+   registry[module].state = 
'loading';
+   addScript( script[i], 
function() {
+   if ( ++done == 
script.length ) {
+   
registry[module].state = 'ready';
+   handlePending();
+   if ( 
$.isFunction( callback ) ) {
+   

[MediaWiki-CodeReview] [MediaWiki r79272]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r79272.

Old Status: fixme
New Status: old

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79272#c0
Commit summary:

-Destroy the DB automatically when initting the DB
-Add $force option to wfSetVar
-More work on getting SQLite to work

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r79377]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r79377.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79377#c0
Commit summary:

Solve 1 test by changing static variables to non-static

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r79431]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r79431.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79431#c0
Commit summary:

Don't use the --verbose option anymore

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85907]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85907.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85907#c0
Commit summary:

Follow up r85888: Add the parameter to DatabasePostgres.php and 
DatabaseOracle.php
Follow up r85884: The parent tableName() should work now for DatabaseMssql.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88025]: New comment added

[MediaWiki Mail]

User "Duplicatebug" posted a comment on MediaWiki.r88025.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88025#c17170
Commit summary:

* removed unused messages because of previous revert.
* hidden namespace select box if in wgMiserMode(requested by domas)

Comment:

You can allow namespace filter, when the recentchanges table is in the query, 
than only the last few days are filterable for namespaces, but better than 
nothing. That filter is already on [[Special:RecentChanges]], so there should 
be no problem. Thanks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86960]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r86960.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86960#c0
Commit summary:

mft r86011

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86578]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r86578.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86578#c0
Commit summary:

fixed bug that namespace wasn't accurately being recorded, no more duplicate 
entries on user properties table, fixed errors on userbuckets

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88790]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r88790.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88790#c0
Commit summary:

Fix r88125: forgot to remove another call to mw.loader.go()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87467]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87467.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87467#c0
Commit summary:

Improved on r87466 - this is much simpler and more fair.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86992]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r86992.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86992#c0
Commit summary:

Using orange instead of red for "bad".

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87464]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87464.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87464#c0
Commit summary:

This part of the API seems universally ignored. If anybody needs this, they're 
going to have to modify every caller anyway, so it serves no purpose by 
existing. There, now my commit message is longer than the code being changed. 
My work here is done.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88802]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r88802.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88802#c0
Commit summary:

Removing the last occurrences/mentions of mw.loader.go
* Follow-up r88125, r88790.
* Also cleaned up some comments to use the same uppercase/colon use as the rest 
of this file.

Search results: 
http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=202&hash=96029a8f5c6a5aaadc61767532e01571

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86992]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r86992.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86992#c0
Commit summary:

Using orange instead of red for "bad".

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88513]: New comment added

[MediaWiki Mail]

User "Duplicatebug" posted a comment on MediaWiki.r88513.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88513#c17171
Commit summary:

Adding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js
* Moving wiki* functions together in mediawiki.util.js
* Adding Adding mw.util.wikiScript (like wfScript() in GlobalFunctions.php)
* Adding test suite for it
* Example to use it in mediawiki.action.watch.ajax.js
* (bug 29071) mediawiki.action.watch.ajax.js doesn't use uselang

Comment:

'uselang' is undocumented in the api doc. It is possible to add documentation 
and use it explicit in the code? Thanks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88513]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r88513.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88513#c17172
Commit summary:

Adding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js
* Moving wiki* functions together in mediawiki.util.js
* Adding Adding mw.util.wikiScript (like wfScript() in GlobalFunctions.php)
* Adding test suite for it
* Example to use it in mediawiki.action.watch.ajax.js
* (bug 29071) mediawiki.action.watch.ajax.js doesn't use uselang

Comment:


'uselang' => 'Which language to parse the request in',


on Parse, but I don't think it exists elsewhere

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88809]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88809.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88809#c0
Commit summary:

New extension (ShortUrl). Empty Commit

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88818]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88818.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88818#c0
Commit summary:

Spacing fixes for ShortUrl

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88215]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88215.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88215#c0
Commit summary:

Properly fix bug 28678, by not allowing to enter the set creation page in
read-only mode.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87404]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r87404.

Old Status: fixme
New Status: reverted

User "^demon" also posted a comment on MediaWiki.r87404.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87404#c17173
Commit summary:

Commit live hack for bug 28678

Comment:

Was superseded by followup.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r80856]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r80856.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80856#c0
Commit summary:

Start another attack on raw sql queries

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78376]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r78376.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78376#c0
Commit summary:

Per r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that needs 
it is badly written and needs to use the AutoLoader properly."

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87254]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87254.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87254#c0
Commit summary:

Followup r87253, doc tweak for 1.16.x.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87149]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87149.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87149#c0
Commit summary:

Copy GoogleNewsSitemap from trunk for bug 21919

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87146]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87146.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87146#c0
Commit summary:

Make this private since nothing outside here calls it

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85080]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85080.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85080#c0
Commit summary:

MFT r78108, r78179, r78344, r78347, r78350, r78365, r78380, r78425, r78539, 
r78886, r78893, r78897, r78909, r78964, r79086, r79087, r79091 (catches up thru 
Mid-January and rev 80k)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85081]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85081.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85081#c0
Commit summary:

MFT last round of db and installer changes: r81755, r82596, r85021, r85047, 
r85066

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85354]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85354.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85354#c0
Commit summary:

MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, 
r82748, r82836, r82853, r82858, r82871, r82938, r83005, r83015, r83046, r83114, 
r83153, r83173, r83270, r83284, r83374, r83390, r83392, r83402, r83403, r83410, 
r83411, r83420, r83461, r83463, r83476, r83489, r83496, r83586, r83587, r83798, 
r83814, r83876

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85033]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85033.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85033#c0
Commit summary:

MFT more extension revs: r82601, r82654, r82698, r82755, r82756, r82759, 
r82917, r82919, r82923, r83281, r83468, r83494, r83586 (partial), r83816, 
r83817, r83919, r84228 (partial), r84365, r84454, r84598, r84575, r84581, r84602

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84589]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r84589.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84589#c0
Commit summary:

MFT installer changes thru head (+db and autoloader changes from r80957)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85510]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85510.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85510#c0
Commit summary:

Make minimum tested version configurable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83799]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83799.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83799#c0
Commit summary:

* (bug 27670) Ordering by timestamp (and usage of start and end) isn't as clear 
in auto generated document, as it is on mw.org

Followup r83797, closing. Adding bit of documentation, + RELEASE-NOTES

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r53740]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r53740.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/53740#c0
Commit summary:

Commit Transliterator extension for Cirwin.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87253]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87253.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87253#c0
Commit summary:

Followup r84169, r83217: require 5.2.3 in REL1_17 also. 5.1.x is broken by a 
lot of stuff already.
Changes were already merged, this is a doc fix.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87255]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87255.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87255#c0
Commit summary:

Followup r87253, doc tweak for trunk (this is in 1.17 rel-notes now)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83800]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83800.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83800#c0
Commit summary:

* (bug 27182) API: Add filter by prefix for meta=allmessages

Patch by Harry Burt (Jarry1250)

Comment tweaked, logic inversed ( so skip == true means we skip ), makes a bit 
more sense then :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88829]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88829.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88829#c0
Commit summary:

Fix for r83799: mw.org -> mediawiki.org

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83833]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r83833.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83833#c17174
Commit summary:

* (bug 27340) API: Allow listing of "small" categories

Comment:

+1.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88640]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88640.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88640#c0
Commit summary:

MFT r88402: profiling

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88396]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88396.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88396#c0
Commit summary:

MFT r81833

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87311]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87311.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87311#c0
Commit summary:

MFT r87157, r87236

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83834]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83834.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83834#c0
Commit summary:

* (bug 27342) Add audir param to list=allusers

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r80693]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r80693.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80693#c0
Commit summary:

(bug 26848) deleteArchivedFiles.php deletes db records, but not files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78389]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r78389.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78389#c0
Commit summary:

Fix a few more paths, restore a few files lost in the move

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83835]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83835.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83835#c0
Commit summary:

Minor followup to r83814, also fix some other existances

Don't hardcode module prefixes (just incase they're subclassed at somepoint... 
:) )

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83840]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83840.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83840#c0
Commit summary:

* (bug 27203) add fato param to list=filearchive

Cleanup some whitespace also

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87215]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87215.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87215#c0
Commit summary:

(bug 28343) Kill unused contextlines/contextchars

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83843]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83843.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83843#c0
Commit summary:

Bug 27341 - Add drto param to list=deletedrevs

Tidy code up a little bit

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83852]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83852.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83852#c0
Commit summary:

Followup r33162, use $this->pager to fix undefined $pager

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87706]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87706.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c0
Commit summary:

Revert SQLite-related part of r87357: sauses SLQ errors, not needed

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83858]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83858.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83858#c0
Commit summary:

Followup r83856

Per BRYAN (;P) don't use a conditional parameter, just die if miser mode and 
prefix set

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83856]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83856.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83856#c0
Commit summary:

* (bug 27020) API: Allow title prefix search of logevents (only when not in 
miser mode)

Won't work on WMF wiki's as miser mode is enabled, but won't show as an 
available option either

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87357]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r87357.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87357#c0
Commit summary:

(bug 19408) user_properties.up_property: 32 bytes is not enough.
Increased it to 255 bytes to be like page titles
Some minor tweaks to modifyField() in the installer to make it more useful and 
added insertUpdateRow()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83961]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83961.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83961#c0
Commit summary:

TitleBlacklist

Fix undefined $user

Documentation, braces

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88271]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r88271.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88271#c0
Commit summary:

Add exposeGlobals() b/c stuff

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83861]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83861.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83861#c0
Commit summary:

* (bug 28031) Add pageCount support to ArchivedFile

Apply my patch

Add documentation to File

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r78447]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r78447.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78447#c0
Commit summary:

When using safe_mode, mail() cannot take the 5th parameter. Rather than 
(needlessly) disabling e-mail confirmation as a result, just disregard the 
parameter. Pointed out by Kunda on IRC.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84207]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84207.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84207#c0
Commit summary:

Documentation, braces, unused globals

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84238]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84238.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84238#c0
Commit summary:

Remove some ancient version code paths

Remove unused global

Explicitally define a variable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r80887]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r80887.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80887#c0
Commit summary:

Followup r80864: DatabaseSqlite exploded on installer page because it tried to 
open an invalid $wgSqliteDataDir.

Even though it doesn't use $server, only call open() if it's set, like in the 
other constructors.

The amount of code duplication here is stupid.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r80864]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r80864.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80864#c0
Commit summary:

Followup to r79848 (and really, make it useful...)

Turn DatabaseBase::classFromType() into newFromType() factory function for 
constructing a new object based on a given type and (optional) params. 
Documented it fairly clearly.

I think it looks nicer :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85010]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r85010.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85010#c0
Commit summary:

Merge some deployment changes to trunk: r82738 (as HISTORY), r81962

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84239]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84239.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84239#c0
Commit summary:

Remove some old codepaths

Kill unused globals

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84241]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84241.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84241#c0
Commit summary:

Fix really daft way of checking version

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84244]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84244.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84244#c0
Commit summary:

Fix undefined variable $name by moving code earlier

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84243]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84243.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84243#c0
Commit summary:

Fix another daft way of doing version checking

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84245]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84245.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84245#c0
Commit summary:

Kill TableMod for being evil and nasty

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84133]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84133.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84133#c0
Commit summary:

Another old version checking thing

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88816]: Revision status changed

[MediaWiki Mail]

User "IAlex" changed the status of MediaWiki.r88816.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88816#c0
Commit summary:

More documentation stuffs

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84168]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84168.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84168#c0
Commit summary:

* (bug 27924) PhpHttpRequest doesn't return response body if HTTP != 200

Apply Bawolffs patch minus the var_dump()'s

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85028]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r85028.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85028#c0
Commit summary:

Fix missing parameter to cacheUpdate

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85015]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r85015.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85015#c0
Commit summary:

* (bug 28309) Auth_remoteuser error: Cannot make non static method 
AuthPlugin::getCanonicalName() static in class Auth_remoteuser

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88812]: Revision status changed

[MediaWiki Mail]

User "IAlex" changed the status of MediaWiki.r88812.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88812#c0
Commit summary:

Documentation

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84398]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84398.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84398#c0
Commit summary:

Followup r84396 per CR

Don't reinvent the wheel

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84396]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84396.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84396#c0
Commit summary:

Fixup strpos logic, and swap setting of $lang (noticed it's wrong)

Add a comment

Follows up r84381

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88799]: Revision status changed

[MediaWiki Mail]

User "IAlex" changed the status of MediaWiki.r88799.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88799#c0
Commit summary:

Fix undefined variable from r39635

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview