[MediaWiki-CodeReview] [MediaWiki r92009]: New comment added
User "NeilK" posted a comment on MediaWiki.r92009. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c20046 Commit summary: Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests Comment: In includes/upload/UploadStash.php line 189 onwards, I wish you hadn't changed $status to $storeResult -- it's a hint that this is a Status object (includes/Status.php). If you felt the status needed a more descriptive name, maybe $storeStatus ? includes/upload/UploadStash.php#230: wfDebugCallstack(); -- we shouldn't have this in production... In includes/api/ApiQueryStashImageInfo.php#63 you added a TODO for some new exceptions -- fix that? * UploadStashNotLoggedInException * UploadStashMaxLagExceededException (others?) In general this change was too big, and it incorporates a name change to one API parameter, along with more substantive changes. It would be easier to review if those (at least) were separate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92269]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92269. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92269#c0 Commit summary: No longer using the content hash as a file key. This solves a concurrency problem when multiple people use the same account to upload from the same set of files. Each stashed file is now a unique and beautiful snowflake, and the content-based deduping that comes at the end of the process can sort it out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92030]: New comment added, and revision status changed
User "NeilK" changed the status of MediaWiki.r92030. Old Status: new New Status: ok User "NeilK" also posted a comment on MediaWiki.r92030. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92030#c20045 Commit summary: Added maintenance script for cleaning up abandoned uploads Added methods for working with UploadStash without authenticating, for maintenance script Comment: I had the same feeling about REPO_AGE -- we usually (not always) define any time period in seconds. Also, it ought to be configurable so that probably means it's another global. See includes/DefaultSettings.php Otherwise ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92039]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92039. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92039#c0 Commit summary: Added index for abandoned uploads maintenance script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92081]: New comment added, and revision status changed
User "NeilK" changed the status of MediaWiki.r92081. Old Status: new New Status: ok User "NeilK" also posted a comment on MediaWiki.r92081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c20044 Commit summary: Added us_status column for future expansion re Bryan's suggestion Implemented changes suggested in code review on r92009: constructor bug handling passed repo/stash up-to-date timestamp generation fetching db handle from repo iterating over select results according to convention changed uploadstash.us_media_type to enum to mirror image.img_media_type removed (most) new references to $wgUser, instead using ApiBase::createContext to find the user Comment: Seems to be okay with followups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92200]: New comment added
User "NeilK" posted a comment on MediaWiki.r92200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92200#c20043 Commit summary: fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. Comment: I don't understand, under what conditions can this problem occur? There is not supposed to be any check for uniqueness of file contents in the UploadStash. As you mentioned it is very likely to get re-uploads, even from multiple people, and this is not necessarily a mistake at this stage. Files just need to have unique names and generally the unique name is set by the API client anyway, and if not you have a good function to create a unique name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92213]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92213. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92213#c0 Commit summary: properly handle the case where a file disappears during the uploadwizard process remove database records for files that move out of the stash ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92213]: New comment added
User "NeilK" posted a comment on MediaWiki.r92213. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92213#c20042 Commit summary: properly handle the case where a file disappears during the uploadwizard process remove database records for files that move out of the stash Comment: xdebug_break() call removed in r92456 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please welcome Ben Hartshorne and Daniel Zahn
On Fri, Jul 22, 2011 at 4:28 PM, CT Woo wrote: > Both Ben and Daniel are joining the Technical Operations team to help us to > build, improve, scale and support our web systems and infrastructure. Welcome to the team! :-) Special shout-out to Daniel for his s23 work, which I've probably accessed a few hundred times in the last few years to get quick real-time cross-wiki stats. -- Erik Möller Deputy Director, Wikimedia Foundation Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r86622]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r86622. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r86622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c20041 Commit summary: (bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually * Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow * Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive * Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place Comment: Test cases added in r92923; splitlines looks ok for the bullet lists. There is one basic failure in IE 6, which may need to be investigated further. No obvious problem with the actual selection, so it might be a problem with the getSelection func. (Not related to this commit, which updated the splitlines support.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92922]: New comment added
User "Kaldari" posted a comment on MediaWiki.r92922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92922#c20040 Commit summary: Finishing banner settings logging. (specifically, changed content flag is now accurate, and changed landing pages are also displayed now) Comment: I love banner setting logging! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92921]: Revision status changed
User "^demon" changed the status of MediaWiki.r92921. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92921#c0 Commit summary: Fixed unit test Removed unnecessary method, re r92807 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92920]: Revision status changed
User "^demon" changed the status of MediaWiki.r92920. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92920#c0 Commit summary: Plots, R and diff stuff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92807]: New comment added
User "Raindrift" posted a comment on MediaWiki.r92807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92807#c20039 Commit summary: removed cruft, followup to r92805 Comment: Good point. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92919]: New comment added
User "Raindrift" posted a comment on MediaWiki.r92919. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92919#c20038 Commit summary: This extension makes article section edit links clearer. It: - moves the links next to the section title without a parser patch - adds a hover action that highlights the edit link when the mouse is placed on the section - adds an outline around the section when the mouse hovers over the link It expands on EditSectionHiliteLink, and requires the new parser hook added in r92506. Tested with section-spanning DIVs and seems to work in LTR. Could use some visual cleanup, but the code is here and someone with a more developed sense for design could take it and make it pretty. For example, that unicode arrow could probably go. Comment: I hope so, but I figured I'd try it out with a smaller footprint first. Putting it in core would mean not-insignificant parser changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92641]: Revision status changed
User "^demon" changed the status of MediaWiki.r92641. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92641#c0 Commit summary: fix escaping of r92636. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92672]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r92672. Old Status: new New Status: ok User "^demon" also posted a comment on MediaWiki.r92672. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92672#c20037 Commit summary: fixes for r92636 Comment: With $wgRequest->getVal( 'wpInterwikiURL' ), you can pass wfMessage( 'interwiki-defaulturl' )->text() as the second parameter and skip the ternary comparison. Looks ok otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92792]: Revision status changed
User "^demon" changed the status of MediaWiki.r92792. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92792#c0 Commit summary: Use Linker trick to get rid of wgUser, per r92559 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92767]: Revision status changed
User "^demon" changed the status of MediaWiki.r92767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92767#c0 Commit summary: fix for concurrency problem with logging ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92768]: Revision status changed
User "^demon" changed the status of MediaWiki.r92768. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92768#c0 Commit summary: MFT r92767, switching db reads from slave -> master for concurrency issues ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92850]: Revision status changed
User "^demon" changed the status of MediaWiki.r92850. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92850#c0 Commit summary: Register new extension (r92675) for translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92916]: Revision status changed
User "^demon" changed the status of MediaWiki.r92916. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92916#c0 Commit summary: Blacklist IE 7 and below from MoodBar ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92918]: Revision status changed
User "^demon" changed the status of MediaWiki.r92918. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92918#c0 Commit summary: Make cursor works in lists, selection partially works ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92919]: New comment added
User "^demon" posted a comment on MediaWiki.r92919. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92919#c20036 Commit summary: This extension makes article section edit links clearer. It: - moves the links next to the section title without a parser patch - adds a hover action that highlights the edit link when the mouse is placed on the section - adds an outline around the section when the mouse hovers over the link It expands on EditSectionHiliteLink, and requires the new parser hook added in r92506. Tested with section-spanning DIVs and seems to work in LTR. Could use some visual cleanup, but the code is here and someone with a more developed sense for design could take it and make it pretty. For example, that unicode arrow could probably go. Comment: Is there any plans to move improvements like this into core? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Please welcome Ben Hartshorne and Daniel Zahn
All, Please join me in welcoming Ben and Daniel to Wikimedia Foundation. Both Ben and Daniel are joining the Technical Operations team to help us to build, improve, scale and support our web systems and infrastructure. Ben, who is based in SF office, comes with a broad set of expertise and experiences in Systems Engineering and Operations, in particular, scaling the systems and creating tools to manage large number of servers. While his initial focus is on database and analytics systems, he will also be working on our new distributed (with redundancy and scalable) file system and getting the infrastructure in the new datacenter into full production. He comes to WMF from Linden Lab, makers of Second Life, where he was first a member, then a manager of the Systems Engineering team. The group was responsible for maintaining the thousands of servers that power the Second Life grid as well as the development, QA, and staging environments. In addition to maintaining the grid, the SE team at Linden was instrumental in helping the engineering group design systems and services in a way that would scale easily and fail safely, increasing reliability and uptime for the service as a whole. He is eager to learn new approaches to managing large numbers of servers with few people effectively, and would be happy to talk about how things work at Linden Lab for comparison. Prior to Linden, Ben helped grow Simply Hired from a 5-computer stealth startup to a 600-server company with millions of page views per month. Ben also enjoys adventure wherever he can find it, whether local or foreign. Travel, photography, cooking, backpacking, etc all keep swallowing up whatever time is left over. He was married last October and loves having a fish monger, baker, butcher, and vegetable market all within walking distance in the North Berkeley neighborhood where he lives. Daniel will initially be working out of from Cologne, Germany and he will be commuting to Amsterdam sporadically to work on our data center there. Previously, he has worked as a system administrator for OnVista Media, Ligatus, and Host Europe, managing and supports hundreds of servers. Daniel is also an active Wikipedian. He made his first edit on en.wp in Apr 2002, but spends most of his time on en.wikt. where he has been an administrator since 2008 and focuses on adding German words and categorization. He also maintains a statistics site about Mediawikis at http://s23.org/wikistats/. His global account name and IRC handle is "mutante" (cloak wiktionary/Mutante) while his WMF username is "dzahn". Daniel has a daughter living here in the Bay Area and has taken her to visit our office last year. Besides speaking his native German tongue, he speaks English, French and a little "ksh" (Kölsch / Ripuarian). Thanks, CT ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92043]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92043. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92043#c0 Commit summary: Turning simultaneous multiple file upload back on, re bug 26179 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92035]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92035. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92035#c0 Commit summary: changing smallint to int for image sizes, re bug 26179 comment 13 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86622]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r86622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c20035 Commit summary: (bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in the WikiEditor toolbar act on each line individually * Reintroduce support for the splitlines argument in encapsulateSelection(). Was implemented by Adam Miller in r61493 but got lost somehow * Add 'splitlines': true for the bullet list and numbered list buttons. The indent button already had it, so that part of r61493 did survive * Copy options.pre and options.post to local pre and post variables instead of using (and modifying!) them directly all over the place Comment: The simplest thing to do is to write the tests so we can resolve the revision with some measure of confidence. I'll do it, I guess ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90586]: Revision status changed
User "^demon" changed the status of MediaWiki.r90586. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90586#c0 Commit summary: * MFT r90585 (i know it's late ... ready for 1.17.1 :D) * *this* is why i need testing pplz on oracle ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92569]: Revision status changed
User "^demon" changed the status of MediaWiki.r92569. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92569#c0 Commit summary: MFT r92568 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92477]: Revision status changed
User "^demon" changed the status of MediaWiki.r92477. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92477#c0 Commit summary: * (bug 29938) list=users&usprop=rights shows rights the user doesn't have ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92505]: Revision status changed
User "^demon" changed the status of MediaWiki.r92505. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92505#c0 Commit summary: MFT r92477, r92480, r92481, r92482, r92484, r9485, r92486 RELEASE-NOTES already merged... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92502]: Revision status changed
User "^demon" changed the status of MediaWiki.r92502. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92502#c0 Commit summary: 1.19 -> 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92494]: Revision status changed
User "^demon" changed the status of MediaWiki.r92494. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92494#c0 Commit summary: REL1_18: Kill RELEASE-NOTES-1.19, svn copy RELEASE-NOTES-1.18 from trunk after r92493 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92914]: Revision status changed
User "^demon" changed the status of MediaWiki.r92914. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92914#c0 Commit summary: CodeReview extension: fix for authentication, which was not being used in PECL svn mode (oops!) This caused breakage for one user who found us on IRC, where the CLI scripts seemed to work (perhaps due to using the SVN command-line bits, which did handle auth) and the web scripts didn't. Now works for both! For proxy users, that's your proxy's problem. ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92915]: Revision status changed
User "^demon" changed the status of MediaWiki.r92915. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92915#c0 Commit summary: Got copy paste working. Introduced getText and getContent ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91495]: Revision status changed
User "^demon" changed the status of MediaWiki.r91495. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91495#c0 Commit summary: Reverted part of r91246, fixes: Fatal error: Call to undefined method RawPage::getSkin() in C:\wamp\www\MW_trunk\includes\RawPage.php on line 156 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91685]: Revision status changed
User "^demon" changed the status of MediaWiki.r91685. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91685#c0 Commit summary: Bug #29752: add back a space that SPQRobin missed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91219]: Revision status changed
User "^demon" changed the status of MediaWiki.r91219. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91219#c0 Commit summary: * Follow-up r84397: make sure that mysql uses the job_id index even with the job_cmd clause * Removed redundant 'LIMIT' option, already added by using selectRow() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91167]: Revision status changed
User "^demon" changed the status of MediaWiki.r91167. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91167#c0 Commit summary: Add dirmark so RecentChanges displays properly with CleanChanges extension and wgBetterDirectionality = true ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91169]: Revision status changed
User "^demon" changed the status of MediaWiki.r91169. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91169#c0 Commit summary: Follow-up r91167: that was for history of course.. this one is for recentchanges etc. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92223]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r92223. Old Status: new New Status: ok User "^demon" also posted a comment on MediaWiki.r92223. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92223#c20034 Commit summary: Follow-up r92220: changed autoblock handling to use PerformRetroactiveAutoblock hook instead of a global. Also made CheckUser always override autoblocks (no config). Comment: Needs release notes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92220]: Revision status changed
User "^demon" changed the status of MediaWiki.r92220. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92220#c0 Commit summary: * Removed angry autoblock code - unused by anything * Added $wgAutoblockHandlers variable for alternative autoblock handling functions * Gave CheckUser a potential $wgAutoblockHandlers function (bug 29330) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92910]: New comment added
User "SPQRobin" posted a comment on MediaWiki.r92910. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92910#c20033 Commit summary: in "marked version X of [[Page]] patrolled" on IRC, the "version" displays according to the user language. If this is the correct fix (didn't test), it can perhaps be merged with 1.18 and 1.17wmf1. Comment: Well, I would have to set up so the recent changes of my localhost wiki are displayed in an IRC feed... :( I hope someone else can test that easily :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92912]: New comment added
User "Catrope" posted a comment on MediaWiki.r92912. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92912#c20032 Commit summary: Fix r92911: dropped slash in path Comment: I meant to say that I accidentally dropped the slash in the earlier commit, and am fixing it here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92913]: Revision status changed
User "^demon" changed the status of MediaWiki.r92913. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92913#c0 Commit summary: RL2: Add ampersand to indicate pass-by-reference in unitTestsList hook function. It seems to work without but I don't really understand why ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92912]: New comment added
User "^demon" posted a comment on MediaWiki.r92912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92912#c20031 Commit summary: Fix r92911: dropped slash in path Comment: dirname() doesn't add the trailing slash, so it looks like the original version was correct? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92910]: New comment added
User "^demon" posted a comment on MediaWiki.r92910. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92910#c20030 Commit summary: in "marked version X of [[Page]] patrolled" on IRC, the "version" displays according to the user language. If this is the correct fix (didn't test), it can perhaps be merged with 1.18 and 1.17wmf1. Comment: "Didn't test?" :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92903]: Revision status changed
User "^demon" changed the status of MediaWiki.r92903. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92903#c0 Commit summary: MoodBar CSS: Add some @embed comments and remove an empty CSS rule ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92904]: Revision status changed
User "^demon" changed the status of MediaWiki.r92904. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92904#c0 Commit summary: Add missing global ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92905]: Revision status changed
User "^demon" changed the status of MediaWiki.r92905. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92905#c0 Commit summary: Reduce padding ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92906]: Revision status changed
User "^demon" changed the status of MediaWiki.r92906. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92906#c0 Commit summary: Wording updates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92789]: Revision status changed
User "^demon" changed the status of MediaWiki.r92789. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92789#c0 Commit summary: Add a stub disable() method ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92790]: Revision status changed
User "^demon" changed the status of MediaWiki.r92790. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92790#c0 Commit summary: Some documentation/syntax/whitespace fixes per Nikerabbit on r92559 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92814]: Revision status changed
User "^demon" changed the status of MediaWiki.r92814. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92814#c0 Commit summary: remove double '' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92907]: Revision status changed
User "^demon" changed the status of MediaWiki.r92907. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92907#c0 Commit summary: Follow-up r92887: clear throttle count once the password is accepted as normal ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92710]: Revision status changed
User "Platonides" changed the status of MediaWiki.r92710. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92710#c0 Commit summary: Revert DatabaseBase::tablePrefix() part of r79272: doesn't seem to be really necessary (tests are all still passing, Mysql && Sqlite) and as Tim points out this breaks anything trying to use it as an accessor rather than mutator. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92702]: Revision status changed
User "Platonides" changed the status of MediaWiki.r92702. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92702#c0 Commit summary: Use $this->getLang() per Nikerabbit on r91648. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90483]: New comment added
User "Platonides" posted a comment on MediaWiki.r90483. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90483#c20029 Commit summary: Mark test incomplete for a legitimate reason like trying to serialize a PDO object--rather than imaginary ones such as blaming memory_limit being too low when the test was being stupid and lowering it for us. Comment: > This allows us to get some idea of what was going on when the test went wild > and blew up memory usage I don't think so. It's an infinite loop that only ends due to memory limit. And yes, it is an ugly way to do it through serialize. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92803]: Revision status changed
User "Platonides" changed the status of MediaWiki.r92803. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92803#c0 Commit summary: self rv r90483. Still needs investigating though ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92838]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92838. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92838#c0 Commit summary: Make loading of dependencies conditional -- mediawiki.user is not its own module in 1.17 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92840]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92840. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92840#c0 Commit summary: Add jquery.cookie dependency ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92841]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92841. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92841#c0 Commit summary: Fix jquery.cookie dependency: move to the other module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92815]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r92815. Old Status: new New Status: ok User "Catrope" also posted a comment on MediaWiki.r92815. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92815#c20028 Commit summary: Actually alias sessionkey to filekey, fixes bug in r92459 Comment: Alright, as long as you know what the side effects are... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92815]: New comment added, and revision status changed
User "Raindrift" changed the status of MediaWiki.r92815. Old Status: fixme New Status: new User "Raindrift" also posted a comment on MediaWiki.r92815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92815#c20027 Commit summary: Actually alias sessionkey to filekey, fixes bug in r92459 Comment: Totally, but I did that on purpose: in this case, it fails in the correct direction: I intend to disallow 0 (string or number), empty string, and null. None of those are valid session keys, and I can imagine cases where one might be supplied, especially if the caller is written in a weakly typed language. There's a failure much later that rejects keys that don't match a regexp, but passing such cases through seems like a less graceful way to handle it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91976]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r91976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91976#c20026 Commit summary: New "Asirra" module, from the Asirra extension by Bachsau Comment: The JavaScript looks like it can replace some bits with $.ready(). The 'asirra_localpath' thingy should not be using DOCUMENT_ROOT or $wgScriptPath, but rather $wgExtensionAssetsPath. No escaping is done on data exported through JS vars -- danger! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91382]: Revision status changed
User "^demon" changed the status of MediaWiki.r91382. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91382#c0 Commit summary: Model to deal with reading stats from the db ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88901]: Revision status changed
User "^demon" changed the status of MediaWiki.r88901. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88901#c0 Commit summary: Add js/css to place link to shorturl right after title. BROKEN ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89024]: Revision status changed
User "^demon" changed the status of MediaWiki.r89024. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89024#c0 Commit summary: Default .htaccess for 'really' short URLs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89019]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r89019. Old Status: new New Status: ok User "^demon" also posted a comment on MediaWiki.r89019. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89019#c20025 Commit summary: Adds proper default $wgShortUrlPrefix Comment: Coding conventions are to write NULL as null, but otherwise this is ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89018]: Revision status changed
User "^demon" changed the status of MediaWiki.r89018. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89018#c0 Commit summary: Followup to make js conform to mw coding standards ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89017]: Revision status changed
User "^demon" changed the status of MediaWiki.r89017. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89017#c0 Commit summary: Fixed resourceloader issues ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92755]: Revision status changed
User "^demon" changed the status of MediaWiki.r92755. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92755#c0 Commit summary: Revert r92013, r92018 per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92864]: Revision status changed
User "^demon" changed the status of MediaWiki.r92864. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92864#c0 Commit summary: Undoing r92755 - if you want to revert these changes, please let's discuss it first ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91976]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r91976. Old Status: new New Status: fixme User "^demon" also posted a comment on MediaWiki.r91976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91976#c20024 Commit summary: New "Asirra" module, from the Asirra extension by Bachsau Comment: * Should not use cURL directly, use the Http wrappers in MediaWiki * Passing data around via the global $wgAsirra isn't very elegant * The stuff with DOCUMENT_ROOT to determine asirra_localpath is kind of ugly and looks easily broken. Should just use $wgExtensionAssetsPath? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91977]: Revision status changed
User "^demon" changed the status of MediaWiki.r91977. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91977#c0 Commit summary: Version 1.1: Asirra module added ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92900]: Revision status changed
User "^demon" changed the status of MediaWiki.r92900. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92900#c0 Commit summary: Rename getLocation to getLocationFromOffset ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92885]: Revision status changed
User "^demon" changed the status of MediaWiki.r92885. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92885#c0 Commit summary: Add some slack to the width calculation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92884]: Revision status changed
User "^demon" changed the status of MediaWiki.r92884. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92884#c0 Commit summary: Refactored code out into incLoginThrottle/clearLoginThrottle functions (for use by SpecialChangePassword et al) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92892]: Revision status changed
User "^demon" changed the status of MediaWiki.r92892. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92892#c0 Commit summary: Add some messages to the resource modules, they were needed to not just show invalid message placeholders ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92876]: Revision status changed
User "^demon" changed the status of MediaWiki.r92876. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92876#c0 Commit summary: Add Nepali transliteration and InScript schemes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92883]: Revision status changed
User "^demon" changed the status of MediaWiki.r92883. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92883#c0 Commit summary: Fix bug where everything was in "edit mode" ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92895]: Revision status changed
User "^demon" changed the status of MediaWiki.r92895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92895#c0 Commit summary: Use versionNumber instead of versionBase -- 1.17 compat and the data is more useful ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92898]: Revision status changed
User "^demon" changed the status of MediaWiki.r92898.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92898#c0
Commit summary:
Removed Special{$this->getName()}ModifyFormFields from r86482. Seems kind of
weird, was undocumented, and is unused by extensions.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92817]: Revision status changed
User "^demon" changed the status of MediaWiki.r92817. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92817#c0 Commit summary: Actually commit the r92816 stuff... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92809]: Revision status changed
User "^demon" changed the status of MediaWiki.r92809. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92809#c0 Commit summary: style clean-up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92887]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r92887. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92887#c20023 Commit summary: Fix for r86482: throttle password attempts for SpecialChangePassword (uses r92884, r92886 code) Comment: 'login-throttled' isn't quite the best message - could use improvement. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92808]: Revision status changed
User "^demon" changed the status of MediaWiki.r92808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92808#c0 Commit summary: Remove arrow from button ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92899]: Revision status changed
User "^demon" changed the status of MediaWiki.r92899. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92899#c0 Commit summary: MoodBar: Kill unused variable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92894]: Revision status changed
User "^demon" changed the status of MediaWiki.r92894. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92894#c0 Commit summary: Improved r92884 comments a bit on second thought ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92886]: Revision status changed
User "^demon" changed the status of MediaWiki.r92886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92886#c0 Commit summary: Follow-up r92884: mark these functions static ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92887]: Revision status changed
User "^demon" changed the status of MediaWiki.r92887. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92887#c0 Commit summary: Fix for r86482: throttle password attempts for SpecialChangePassword (uses r92884, r92886 code) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84058]: Revision status changed
User "^demon" changed the status of MediaWiki.r84058. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84058#c0 Commit summary: Add an hourcount parameter to limit results returned to those added to the category in the last X hours. the guidelines for news sitemaps indicate they should only have stuff from the last 48 hours. Parameter is off by default. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c20022 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor with all the latest bells and whistles * Allow wikis to enable resettting by entering an email address (bug 13015). This is currently an unindexed query, but it is disabled by default so no immediate problem. * Allow resetting to be disabled entirely (bug 20473). * Don't send registered users' IP addresses in the emails (bug 18347) * Check that a user is not globally blocked before letting them send messages (bug 23669) * Display a more useful error message when an account exists globally but not locally (bug 18996). Comment: Hook removed in r92898. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92459]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92459. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92459#c0 Commit summary: changed sessionkey to filekey to keep consistent with the rest of UploadStash (while retaining sessionkey for backwards compatibility) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92815]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r92815.
Old Status: new
New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r92815.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92815#c20021
Commit summary:
Actually alias sessionkey to filekey, fixes bug in r92459
Comment:
+ if ( !$params['filekey'] && $params['sessionkey'] ) {
I missed a similar thing in the previous rev, but: you should be checking for
!== null instead of casting to boolean. The latter has lots of
nasty and usually unintended effects, because things like the empty string or
the string '0' can also evaluate to false.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92889]: Revision status changed
User "Reedy" changed the status of MediaWiki.r92889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92889#c0 Commit summary: 1.17wmf1: Revert r92888 per Reedy so I can do it properly with svn copy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92888]: Revision status changed
User "Reedy" changed the status of MediaWiki.r92888. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92888#c0 Commit summary: 1.17wmf1: Update jquery.localize to trunk state. Not bothering to figure out and merge the right revs, just used cp(1). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92693]: New comment added
User "Catrope" posted a comment on MediaWiki.r92693. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92693#c20020 Commit summary: MoodBar: Port Special:MoodBar to a TablePager, leave CSV export up to the maintenance script Comment: Oh, right, I guess so. Whatever. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86482]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r86482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482#c20019 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor with all the latest bells and whistles * Allow wikis to enable resettting by entering an email address (bug 13015). This is currently an unindexed query, but it is disabled by default so no immediate problem. * Allow resetting to be disabled entirely (bug 20473). * Don't send registered users' IP addresses in the emails (bug 18347) * Check that a user is not globally blocked before letting them send messages (bug 23669) * Display a more useful error message when an account exists globally but not locally (bug 18996). Comment: See r92887. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
